From patchwork Thu Oct 31 06:29:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Burri X-Patchwork-Id: 839939 Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11013046.outbound.protection.outlook.com [52.101.67.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBA2F7A15A; Thu, 31 Oct 2024 06:30:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.67.46 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730356237; cv=fail; b=gGULCFMZYcT3zMlMHFwkTM2D3qkmuzPByfwRMVw8iNF5VTqSHj+uRTki88eZ/hgwvCxhSkND2P6Wzv5mGMDkxj4aDrZgK6D3lL+QPHwbfYZQHEFbL66ZyWUv0VnyrTrfApRWb/Mgt4aphiUJRcr1TKtbHE0PsnS/+Eo8UU6X/m0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730356237; c=relaxed/simple; bh=2JgJUp0muyY6HKUfcYE7hCw4Uywu17MgmCICSXHZvnE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=Vfs2PNzeIZk01Re4RvghnB63v6Gbf8KtyA5zISV0WbCJ11zVqBAkQUfQTcaqSV831hxnhMzns6BXrXW5L0NPyoxWexEqtPbLQUVB2nzrCMaybcw4iZ2GbPKZ6wXQUymY6eXA1woL50qQmNjsShnyWpRzcAHsKaioZ2jD2cVUYKs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mt.com; spf=pass smtp.mailfrom=mt.com; dkim=pass (2048-bit key) header.d=mt.com header.i=@mt.com header.b=GfINoTzN; arc=fail smtp.client-ip=52.101.67.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mt.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mt.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mt.com header.i=@mt.com header.b="GfINoTzN" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oaJX25RzUZ4FWx6/VQdJ25gbZJ3Rp56S6Xwo3WJB0eat0Wlkp0uqWcT8lzqdNx2pNz9+LMhx4PlxP6Wm7bRb045u+q8bnRXAxzCkaq7x5B2tDaSa0lg19gZVay0aXhWLGqNxvLn05IFx406IDZ9+y8wWqsyG+EkA/fBlmm/2TdONhjMFMT23x/YPb+QGOirxiWG67+xce3lZrm9hDB2dJZWIbluF5mgNxJ2dx2AdRsrR0T4+hrIW+0VKgXQFYSp2ZkwYTK7VdXPsdeTDqkFXP0rCqsg2sD5J27bfN9J4qD5jc0s/Sql1CZ4Tmm+FOU9VfBDYamnp+j2tF9qym9GgaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ElWlJbJZR8MOatkQ6tjF16LmsPBk6+DHoeCHsZS8qMM=; b=lRTx+CPzELIgygvsqAqniPMeBAh9sewKnPWtgPt9imySMldFMjazO4R2ay6kjko6bJCM/96Jgf0GqRMvb+FxI87F4hQGpCgjtQ6cXuvuI7Nx/+mIfm4F0c7WY9HPwG2XI3LrGu4ABD6RX8xAdL0J8eHmRSQSc6HEy7uJ3t5GxdBW1kh46bdu2m69AfiGpavXPmC5HwAxExVPJ69YCRXZzR/q31ccgAm+tXKy4vcDwBemJo7ywW+1J1bqCesLLPADCW8tQsLJctokP6BLR6YhNZd9Gk8I9/jkk0nrorRi5knx3NKr99Nq9J9ENAFOGJE/uPKP+AV+acPiML0fyn+8Kw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mt.com; dmarc=pass action=none header.from=mt.com; dkim=pass header.d=mt.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mt.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ElWlJbJZR8MOatkQ6tjF16LmsPBk6+DHoeCHsZS8qMM=; b=GfINoTzNZS2uhBbRb7z23AQWZHHxJtEoYWpPQwPtR767zAO2VmrUfvdFYQADY0VbweTroMgkNAEwfayfs53EKFM4Lkv/FG3PDHuH52lvCBEk/nlLCHCjeUDB1W/TKsAlBvNO6sg7QaCQTqT70kTe5RgxmbFQjw/4eM422saCgP18AMqImyIDfwynW+3bmHtzqhPk8JkIZKcq/MZyHqTbcn5Qk3VCNdcUTZ+aD3smXd3Dfdv9wjyx+YibWf0OtpE1aNov7SfgVFihe67DCAWVn94+XfSJ4vQhJ3JVNn00sWzPQ2YAjnCWFg0MEB9jXyH8dKssu6lFSoX/BkNv5AOq9g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mt.com; Received: from DBBPR03MB5399.eurprd03.prod.outlook.com (2603:10a6:10:f5::22) by PAVPR03MB9797.eurprd03.prod.outlook.com (2603:10a6:102:311::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.18; Thu, 31 Oct 2024 06:30:32 +0000 Received: from DBBPR03MB5399.eurprd03.prod.outlook.com ([fe80::2fec:64f5:1893:f53a]) by DBBPR03MB5399.eurprd03.prod.outlook.com ([fe80::2fec:64f5:1893:f53a%4]) with mapi id 15.20.8093.014; Thu, 31 Oct 2024 06:30:32 +0000 From: Markus Burri To: linux-kernel@vger.kernel.org Cc: Markus Burri , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-input@vger.kernel.org, devicetree@vger.kernel.org, Manuel Traut , HeDong Zhao Subject: [PATCH 1/6] Input: matrix_keypad - move gpio-row init to the init part Date: Thu, 31 Oct 2024 07:29:59 +0100 Message-Id: <20241031063004.69956-2-markus.burri@mt.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241031063004.69956-1-markus.burri@mt.com> References: <20241031063004.69956-1-markus.burri@mt.com> X-ClientProxiedBy: ZR0P278CA0087.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:22::20) To DBBPR03MB5399.eurprd03.prod.outlook.com (2603:10a6:10:f5::22) Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DBBPR03MB5399:EE_|PAVPR03MB9797:EE_ X-MS-Office365-Filtering-Correlation-Id: 34bee9d6-cb3a-41d7-5825-08dcf9758527 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|52116014|366016|38350700014; X-Microsoft-Antispam-Message-Info: gBBGzupsebTPHTBV2vjtvnSwrEQH63Zh9I3GAz71UZ7FJcBFYdHEonTzvcih+jxV0WwuPOKb3J7WfJJh8JdKdbOD3lxoSux7sRh5zE/t9zvpKNMt/hUEh4Oqq/9PVw9Cw5GgVR65R0fVbrgWwLrdzxQU/33oA6xViS2U6ebnfIAE4rQTAG1rLd1bvH2jqVSx+LhGUATz5V6K/Ifq9SFcwpy4o2f8AFKSf1wrDhql8U6RvELhOGRXoxz89RbCORVaomAzGcb2sgJDs7gwlAiNd+/w/WfK39zYueIZROB7qfAzmpwafUL90X+EQk4Z4FmF2NcnOnZyhNI5n8Roh5X4gWOiobRMmFdnsb13B1cb02Blc+9S1miLKEo8zEYHiFUlfrKX6zi227B56pPRkeNXIyFHL4931UPcq8btsDHk84yZwO+FqQkO0tANLLQTtQerKlZS5oE02Pykq6x9J2BTxKCbY9Wu1XNHjP54lIlIehR7ml9hwMuyAccnaxyMhUpuBmH2TOQ5CYXht+rVxdjdhYzhZeHNdPkp+biiCI8QpXUgTrRLtPVTBcUTublgo6JRN73zDHb1mPOnWFbSbLBxmpAVF5Ts9HOywB9NzZEsXbv3eTmuwR30kBMyrteZIJr8qM2WxUKdROE3yd0ItZoQ/qXB49kkXqWchsbXlDUdejM6x9V77XCVFqtzeLt23+H2k42vRvfVnrqY7Y/WW7F/UBxaWHzq3T9VUHwAqJfmQIhA+QmpnW2RSDMnmyoRiHQy/fh25M3zVl6XzrvHNh0gnoUdY/ZdhDWU7b9JTH2MeO2M40JOVXpb/l0UFQEz3Qknyxpcrx0wF6BdSt51P+axRHz+pbmQVnIKojMg8SChN3RPx9JyFO+vE32Rus+yoFSuMMHMwsrxHfvTannGEhuIPX8NCeTY4Xz5SmJ62qg3EontQ04cjhKLewPWzmPjMhuf9Xi4zJTApeQ3bjsR0J1eeC5HKCG5SoSuIOrr6a++4jdOOJlqcT7f9YzuA6Llye2Yh9tkGgf0aLWXx6jwOxJOArKdzcLkHu6tQwXYYNChvlNW4hxgiXZ9PGGD/bksiySTb7TECMTSIqrXx9AjdbRNiuNIU4DuBNk006J4CgqmK8Gh4rvi4DpwmtLD0uKfkObUty3OmQhmms2AKSfDmzVDHbaqNoWXhLAGvQ3uOjsbF1X3EoHjM6XU3zmWFxFNxpNvOJmngwDYGnDKyr5Y4BlxwUDl2IT+1Al5WS5VQYA/HYK9LLIueJdyrNPywLgX0eeT5McrMVsEkv8QofEhuEY60FbSBF+c91eywXnTV3/EfYa0GKS7mgGyYrSAQJpwALJueA/+rSFV2pcnPLvHv8dOMd6oOGLDluxEEg+6BVdUTfw= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBPR03MB5399.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(52116014)(366016)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: vMSRwuBgpNFyRe6/E41lxDt7lYNlNSCMryuz2GOdMBK9LfKfJorPVmYzs9RrR85r0MC8XSMsTEUStIyXXOjb4j7CAMSCKp61YCMNZZdC3k4FtKGy/8i0YoPJyFTjZ5Qa2VUyfduFoFLFV/GQszE6Xc23qXh8bCWe3hruPAmhcJUHAq2JQMesJ5g7OL8VGg2spcUj7jCj53cNy+u4Hcuc0B8JkeYxRec2wXiiR81NiYqoqwQq2kOL2kwXunYKxhQ/KVSMf9Iu5IRhWjWS3503cjCTOz0yYZ1bDePnP9LH73jDz2hQN5VD/7h4+QXEu9QA4RV/XsUmtyHciTEc4Saqb9cfIv9NYDfq8Q1UXR0LTqGR0iFhcTpzuiPdCS4VTeEo0dLFiS5wDdDS3TB8Fwpw7ihHl+tBJqVzhzKGeNgJ6dPEug1EOeT1jpSsEeMAbL9ex5x/Q/M6ZJsfLE5LY4KJdHga2wDGmWGHZb/hqrpU/FY/Bk1/juy+X441rxwxUPcDlUKpaHqrRqPTLy0w/1i6uttcX/h5U1lebzyIxkQa9+VurfWIfT37beLJ0sm4L2Sv9Yiga9ccUAZHX1qyb4VFM1MYUEe6U/tB6L/9yTatbBjj6AwbofuVUgl+qbOdgjC3JMY9LhG9QByACWV6hXbeLCLR01AIaQkXJMrf6a/2iE4Nk4iHeZmj8Sl1q3Ij5jcLptJD7KCm1Fhw0CN8dwiVRL46vcfBJTIQZRSLWLJ/Kh3WqFx9fPfE0z6f9sZgC1ISUsZZ7LxAtnUXzIPNJeLFoqUq2xeOXPGhsOYe98rWEgQLQ6VaF9liZg34cVVJriP0PONiSw9V+SS3nmLJUmX9WmFaNHtBJZh9jbwHkWbvbg9QtmDUHS4GHFA1hZdqXqjm/W/UqQO59SuXHNL8/kCRfwE45Ojww1dmUdHjhgntBlJ/9njB8dxcPV6ACFIyonii0YNQEvjHVCJGAwY7GYH4Bu3m5dRqdeJylzn22VrQt/8EegyaEBxo+v1kV4Bu2zUZa+GEjm+mo9xLYiiTYLz3dUoDq+gNtU1h72OO5NUjp+PUE7JX9qI6QuxMfybpKhnWI0W96jhIwqDRiUofB9hzXaW79o1LCXfvkjNA133aC7DW/RDoI+U3sbE8CoPX0YmtCnQT/K0sbas5rFDWdNfbtSIfvx7fCe/+kXDW1KIkauOZxSEKBv+QAj6mpNku3GQQUsG7gBEDuTjkERigIWsoDE+5mJTV3KOa5iv9dOURWgifiYP3cjyL/Oyobkp93+B9b0tofZADP82Ycz+MkWoAS55C5RFcTOL2yXjVF0qu0nSFEb4Mdubv17I0qFq3j3C3/7l4oCVPzFtxNdRLTkgsLt5bDEdCBSqlverEVNuVO+cNBqPfkRMmVeKbwtx6x+YqJ60HoRayZqRuVWPFey0zCt5fVSt8HSelTbmS9Cseru8ooXuWUZ51h/IsxYj4tHQfV/26qWPjKZM+eoljkq1Uk3fpnYnzT+jtS7lxfHVLOGbI3yGORW64BjtcHoicC/JuerhM+k83YHncPV19Pk0xKh5+WrKw3wANlq4yAm0g7xagsloccPgFt1xh1Xw4Gauy X-OriginatorOrg: mt.com X-MS-Exchange-CrossTenant-Network-Message-Id: 34bee9d6-cb3a-41d7-5825-08dcf9758527 X-MS-Exchange-CrossTenant-AuthSource: DBBPR03MB5399.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2024 06:30:32.1017 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fb4c0aee-6cd2-482f-a1a5-717e7c02496b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 02/HTA1LlGn3OQA3RaWYxbfgginRuThcQotbXcZRRNs+ALDS0eqFGnFvjcAOl9l/8EUqouSFCdvGVig1xeA64w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR03MB9797 If the matrix keypad is wired over a slow interface (e.g. a gpio-expansion over i2c), the scan can take a longer time. Move the initialisation of row gpio from scan to the init function will reduce the scan time and therefore increase scan performance. Signed-off-by: Markus Burri Reviewed-by: Manuel Traut Tested-by: HeDong Zhao --- drivers/input/keyboard/matrix_keypad.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/input/keyboard/matrix_keypad.c b/drivers/input/keyboard/matrix_keypad.c index 3c38bae..a2ec9f6 100644 --- a/drivers/input/keyboard/matrix_keypad.c +++ b/drivers/input/keyboard/matrix_keypad.c @@ -118,9 +118,6 @@ static void matrix_keypad_scan(struct work_struct *work) memset(new_state, 0, sizeof(new_state)); - for (row = 0; row < keypad->num_row_gpios; row++) - gpiod_direction_input(keypad->row_gpios[row]); - /* assert each column and read the row status out */ for (col = 0; col < keypad->num_col_gpios; col++) { @@ -326,6 +323,8 @@ static int matrix_keypad_init_gpio(struct platform_device *pdev, if (active_low ^ gpiod_is_active_low(keypad->row_gpios[i])) gpiod_toggle_active_low(keypad->row_gpios[i]); + + gpiod_direction_input(keypad->row_gpios[i]); } return 0; From patchwork Thu Oct 31 06:30:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Burri X-Patchwork-Id: 840328 Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11012053.outbound.protection.outlook.com [52.101.66.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BB7B13D899; Thu, 31 Oct 2024 06:30:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.66.53 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730356246; cv=fail; b=ZKsMHJFwGsjBv216DMnMaFlwOB+Gp22q4WL7RcG759+efcKytupkscDnOhtJyr4IYdUVFJSF2a7THGcgJUh0oVG9CKIxcXf9qVd4Fz+/VANmBm1g2f4/yMlZHIw/HFXQhDrfPAgW+gVlr2F/Qr3XPXBqRBWpTRv2PxQmy/HJK1M= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730356246; c=relaxed/simple; bh=y1MYnZ8vRwLXpf1FgeyiXnH/v+nZAQNao5ioxg1AoLc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=fLq3zM//4YHIF4llXLhodi9cc5sO2Eqizk5iWfmgn051iiqqPl5oXIceSWqGZV79ut5+hgyoYBNNU4Mgg2re3v5KuUIAcxgL9B7Z8VdD6xEGARZm1BiAenr8dTXi+g7zh0D5Wh1JkoKtWj6cz9GJTBpvLemoQqfmxkv+/CeF35U= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mt.com; spf=pass smtp.mailfrom=mt.com; dkim=pass (2048-bit key) header.d=mt.com header.i=@mt.com header.b=kG27Ymze; arc=fail smtp.client-ip=52.101.66.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mt.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mt.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mt.com header.i=@mt.com header.b="kG27Ymze" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=twQF5qjnymRbdtCXnjswM+AU3AL0DwBbWnlc9vk3mJfpP/06HDy41urjdTKljJl4hhEHNGTqTyeWY0OOQCjAsBTDBWHhPnwhK5ANBuHCBJz6/ZayTXcWGe7lz5jxeif5z+VOMbRBOCRTuTy6BCJC5+dCmiF+aVc55ktLvEVlgC8kg/szG2E3bUJvnBWltplBN5IxlbC7EVMxeaHUS61nXjBmC9NVXhwg9bphiMe1yDnGvNCv2bcF3KCmXO42qxGFh1jtHuuW3oV71XfH0TL6aiUL5GFytY+Swn8HwCG42iPbU+sPx3/VLazHQhD8lKAKSBvRLZPs3JOkSRnRNp3SdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eYVicDZ7a8ijNc4JdHRVIRf7abz+NCb0Ez3C/vfMo3s=; b=XgZRBlXV2sdCohErl9p9BG0ze5ngfNy+XMbrF078a6LZvA6OZfWgP7ygG5EP/KxLqnSSjTbNPtkRkHuS3AJnq0AZA3mdwIRGOiUjMhY8ZBy9GziMQ/uk2njuIkrODqwASd5IBLX4FH4ZzWfuLvUrK36hEJ5i7iEMbqjs4LCge1pR+Y/5iuGT5kSWWyUvJoLspLTwxuAj9gUE5JJV0u78JSjFw3hOnkXa8XtssC3KmYT3Fug0RFo7RXlr+CHMr6NdVGxM1hOxsgDAIrSyv7QALIrpDiMA6JIWBQbft3qchUU84ETbbuBggpizFqtjOmif+eDDfVqquH+pcwytkf9sjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mt.com; dmarc=pass action=none header.from=mt.com; dkim=pass header.d=mt.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mt.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eYVicDZ7a8ijNc4JdHRVIRf7abz+NCb0Ez3C/vfMo3s=; b=kG27YmzeFX+uT3hMg2aQJRZu0sVwMcx3jzaXCOrZP1msqF4qc3H6B2SlmzUfr67Dbh8JcRehQbZ2WXnZuKFM3S+DzbNKoC7zJyLDxZkMedMY/0qF9rri/03OBXKqN1YqqRSf00jdd2299l8oA7sbyADzXWoAlW0B5XHaE+KajXu61WuL6Fqn+Ht5Xf+2NjGu+pXdSz3wFsiY+KhQ2CV2zw7jPp12GsSX2m4LWjOvrm2DxPPMdnNp4apLzsHV3vQ6spzrNfHulBNbFmqM2RED9u1mKjuUuwJVhu289v6avHfzJRaAKZvuv3op2e3pLxEbgrRFR+jlvlP3nsLW1H43hg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mt.com; Received: from DBBPR03MB5399.eurprd03.prod.outlook.com (2603:10a6:10:f5::22) by PAVPR03MB9797.eurprd03.prod.outlook.com (2603:10a6:102:311::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.18; Thu, 31 Oct 2024 06:30:41 +0000 Received: from DBBPR03MB5399.eurprd03.prod.outlook.com ([fe80::2fec:64f5:1893:f53a]) by DBBPR03MB5399.eurprd03.prod.outlook.com ([fe80::2fec:64f5:1893:f53a%4]) with mapi id 15.20.8093.014; Thu, 31 Oct 2024 06:30:41 +0000 From: Markus Burri To: linux-kernel@vger.kernel.org Cc: Markus Burri , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-input@vger.kernel.org, devicetree@vger.kernel.org, Manuel Traut , HeDong Zhao Subject: [PATCH 2/6] Input: matrix_keypad - use fsleep for variable delay duration Date: Thu, 31 Oct 2024 07:30:00 +0100 Message-Id: <20241031063004.69956-3-markus.burri@mt.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241031063004.69956-1-markus.burri@mt.com> References: <20241031063004.69956-1-markus.burri@mt.com> X-ClientProxiedBy: ZR0P278CA0125.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:20::22) To DBBPR03MB5399.eurprd03.prod.outlook.com (2603:10a6:10:f5::22) Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DBBPR03MB5399:EE_|PAVPR03MB9797:EE_ X-MS-Office365-Filtering-Correlation-Id: 84be9a38-8be3-4aa4-a6ee-08dcf9758ac0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|52116014|366016|38350700014; X-Microsoft-Antispam-Message-Info: bvyDUSqm7vc+u5wu59wdjoUoO3NG2jIifDuxuWBpNwBbCQlB8cJXgwdj7bvgFfiPKv1jGqBlszs8HZ5CaDEOm7lkNk0NNKCs9usHzmCFa8xvHFSEfRBmMpAbe+Z38jgwvXOVva2FHlBFGSVpuNZpLitI3a8lB0lSi1G9WfAFbjwo2vZNdsBi2KhVjnT80754kv4mlrtQk48H+pNqfqC5loFmn089Mxt/KXzjT8bLVsGxIcxquUQVdmqNzCXa+WHeUTk+zE/fNv0p0+xDz9H9d+WWV6GFuxR5jw9OK6LMyB2+IhigZLrLz4GZHko44izOe4qAzkQVvqscDvVIzbC6LKAEhYU6CRLELitvnRRcu4iiqMmZ5FZ5cRoQ92qJyuoLfNM7iWjVUYM189V552hbrNfixFaTs3cLjVPXOvaBv9yUDCvLdZiA6DaNJkLiSpRE54Mt/RjslSoU6Ud1guwngw2+4qzYB274xfKQtQgInz1kNzT/zItq6th9NFxCBLnf+if9gAZ/X92M3OZqOQifcqkvEtg+tKe/MQ1aFnrdJ7k7huGNLr0PMbFamAKHDSGAoy7WVXEZL/pinwNv4kibrllVJS9evgZyxKWU84cnQ+OH51h/VToJ5fQhSnI3c8nC/UrPwr7fp1K+R3d12n2YmQt5C0Qhzq3R3YPGyDNwngP3wz5MbvlAHCHPBMn6ueBmjhoQLaKSSEGObqUJJI6VWXcxxQ98njAbRXd7nCuUMgMedGfwwGJ8WoP5T8Svvd0PzMNI8IYM2zj24leLnX5S/JMHYia5P7aTZNlah/4PgM5y/U8zeH0tUKa0GObxrCcJNSBKe8UFdlJBT2TAv5+9AxviCf8B0d0uTwe2+yBFJ9RCK3v4FhcDbUbVGIvjn3tjnT9lYOAiwvwVm6qaz11rZCunFH5iDf5pK/YjMBwA8My8kQtIFYNMiLXviPgJSa8mnnyRFzo2V4TaA0BFzqmEeHhoQFAh7G0T3EBBLYUNLlPh1ts228QeLpKiAL0AjlHaVn+sTqqROCt5rpV6+wBBlwU9q5m6YGdJlbvnXZWeyfPCtw8czd1ynEHkHWdFR0GrV8cseZEYb199QbtkZXzJ5iVGceY0FqrESpydWiGPsEztbHzOtVhGol7ekfzZ6enfsKLdsUr2PqG2O7AeKftsvQc9qG7ZBQCzNg5cJaUVtOiqN6nthz6MlzlZU2CsUGTIi3nf8D9GbeUYlewU2EDjeJNAXq/Foj54YmzpnPMCchybTT016HmBTGnSf/5nQ15kBslpQzEUNJgVI6vZVK7wC41nPf2yVfdIlD4KVUwjF8YuqaZh8192anYqvgiCAeEP2CctdkdsG99ethE2zejnqkUY//bgyuh2VVqvHOm8zWAtfSMdrTbl8yNBLU1Olpz/ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBPR03MB5399.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(52116014)(366016)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: FwpJiapOXDMStrk8CLnPIInossNHJraRixCQGQ3M+fMoOxib2jIFb/IoS0T11CRExr1yVpOEoDX52lzr/whuYltrxM0Wbk7j/iM+Xb0nyMRW0lm5k4cSFQfqmTe3BZplAWnAA6cGjFM+Kp9RQZarCfdsD+Blvl3ZjU8+H3NaXusv2v/i+axcm7vBTOiX9wRCamGvp5Z+H6eK7eJX4mVZhFtX998YsH6DYmwSNEZwozjLX+fH7a2xDIFRV/k+Ykh0ThgvdGMG42h5LTXh2+O9ByURtIP+nqaEfLMPc29Y/DiDMWlzwySK8Kzdn9aI6Z70W+nn558ITUW3Ka4MqCfFH/CvTv4LP+d0ng6ZVtkTHueRkux5F5k1Z+RrxpTKwExkjK/KcAGyZmGDy3jnInbxetqheeOrm2OIN+/ql923Bq0WTR4Q6q+8WY8nH3Ng5Luft4FV1vHsINtQz/OwEVOw5vh3cx4jOYFyRMnNSFPiENrZ50rV49f0GOpjkH4p7VE0KgApvK5Nw32QaO2mN8xqSKMFY9esVpHhY308+2DuesIhZ0sXdWp2pxFktxPogQFuUp66xKidFX4wJJl4oflcbFOdKr6lJ52FC2mkpB02KDT6B4LbBkcv3ST6JaNumkQlLRFp1t1DXQmD/gXMlIwG9ZEJak+iWBZJNCXqrtU2FldmO3HlQhr6fBBnf45Mb9dR41cW4A6WRrVQBuc7absXgKtDEJZVjeq7orV7z2QWJlkHt5BRPnEa8PZq3p2W1Jy6b4/TMDCY0s03HOy4xQw8B5+UYb2ayylpDYlZg+kkY3kGEAmqJIxtKVWGFeoLNzkNVB4T3kFAFpcs1i/JCx3Tmts27YPURUOXQtb35zu8F5NRXisT1Inxs+cGhJ8a9uChWXDcodJvGC+lyzkOx10OQALasEUjCscA/PrrjmNDXo3a0wZcG3WSOFnf5zdcdcwBppXj1mkF9tbHOz36Dwdw0aXpwTD4ZSpFafP5f2OFaEr/z6/DnnDthAtekgt7cYKyGsbTjoum2YuH5WK8zuoyezR13g8kCmWuorH1vLKzB02dHigwOFVuDobDDBHQPJLkcBLI+EOrkRBsGOc0askLM96+U1iGC9g9NVqMA6q/xc8u5QWP1NS6ukAoWuDmBioErwyicndWM0G5NFG2EUudPHZx2+HwMi9WICR7l7+fwVQN5LPGVAC4KDm8/Bpn/fDiMme0FMBWW86ExOgUTYwDZ99iHBw/WOrraTdSq6vHq+NqnU1FN+omfx9iY6voNkxaLOizHItAXzZFujcUSiNeY+FxczpB1hN97awbSlJ7YZAFdqGpR3rsrlNYKy5PuRT6eAPg7vHrjCrGZ9jxk7KHo/lvRVk+Omc6iBN5I0DbrvABl2eq8BtNzohevUAd0JD9i+WJaCCYJmxPc5H1Xmcz8geu0lQ9XKP5MLLyO8qgmwLafzsAYzFXx+wabiXLORClf0yGrp/mGvg18Miex/y5dOpXzaXH1ccoGAqcDiom7VIxGr40Wgb5cvTj0B3tfoCl86erEDybOzaqorYq+5bvhen6623BlW0z0QqgmjlJ4vZXqURtqkSjsU9JFZo2uOyC X-OriginatorOrg: mt.com X-MS-Exchange-CrossTenant-Network-Message-Id: 84be9a38-8be3-4aa4-a6ee-08dcf9758ac0 X-MS-Exchange-CrossTenant-AuthSource: DBBPR03MB5399.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2024 06:30:41.4986 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fb4c0aee-6cd2-482f-a1a5-717e7c02496b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Mo+8n2WPMdwimPh0ivFywD9Loqi59D5RKqCec3J9GQNBJGkl+QEgE0CxkUeMHZy6pAp/SYT1cJwGASH+3ThR2A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR03MB9797 The delay is retrieved from a device-tree property, so the duration is variable. fsleep guesses the best delay function based on duration. Link: https://www.kernel.org/doc/html/latest/timers/timers-howto.html Signed-off-by: Markus Burri Reviewed-by: Manuel Traut Tested-by: HeDong Zhao --- drivers/input/keyboard/matrix_keypad.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/keyboard/matrix_keypad.c b/drivers/input/keyboard/matrix_keypad.c index a2ec9f6..e08d7d5 100644 --- a/drivers/input/keyboard/matrix_keypad.c +++ b/drivers/input/keyboard/matrix_keypad.c @@ -69,7 +69,7 @@ static void activate_col(struct matrix_keypad *keypad, int col, bool on) __activate_col(keypad, col, on); if (on && keypad->col_scan_delay_us) - udelay(keypad->col_scan_delay_us); + fsleep(keypad->col_scan_delay_us); } static void activate_all_cols(struct matrix_keypad *keypad, bool on) From patchwork Thu Oct 31 06:30:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Burri X-Patchwork-Id: 839938 Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11013025.outbound.protection.outlook.com [52.101.67.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70DAD146A71; Thu, 31 Oct 2024 06:30:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.67.25 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730356256; cv=fail; b=aSvCqvup2wAsGX/TomqaO0DuzpDmEvj/Sb8CNto0Y7v4ADls/IYewat89fR05IndedVmWaGnw8TabMoy30mYDhMJ2e8aflKIV4NcJrgy0BOQTKxCtHTs5iMp70EmnWkC6QuhCacXOa1CEQkbVL2oiNoCn+/Qcc8nx58a/Kf8ajE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730356256; c=relaxed/simple; bh=0TL3eszPsXS15LWRzFBdD5LNuJOQOlWN2vuPYINr93E=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=L/M/pfF+LXOz72X92iFHE//on9WRl2pRu1vlz/oEefNAWc3o6rPN7twgLhjkRYoiSvePD4HfLTKRlMNkIDW3ULa7GvN1mr3p8Oomppx0tIq85MstRMfP3naYNZrVWWVsA9Yg2E6UAv9rbe/qf6aI7msxgvjkBtFRBucXZc5RVeY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mt.com; spf=pass smtp.mailfrom=mt.com; dkim=pass (2048-bit key) header.d=mt.com header.i=@mt.com header.b=Fu91qiNO; arc=fail smtp.client-ip=52.101.67.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mt.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mt.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mt.com header.i=@mt.com header.b="Fu91qiNO" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ImIlhm4qIOAn8WGb17w1vriO9SMH3e5uURBd/e5U/HctNOrYjIxqPVYxdpZutLViiqw4yGD7sbyo3hAxa7ifZwS46S4ORO6LKzVdpIdHnjo6cvtJkH8CoOZZF8WRnmCXkRhw5nochh2/JkWB16l9k+XAXNzJs5AQsM/ib3XL77C5TByHHAuUEQElehhoLPdpFr1h3/OjcxI0z9cYWrWv8Ttwt8CDE9fC/OSsTVHmiw9oEB7BRUrN1cNc39FKptr1FFo/oMAWbziJQnGqnWAlew8RD6JYN3rWD0OFsM8sqJzHpQLMk+afWCPHoTE4GKX2VyHlc9nx3UqAkqJaFlADNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bqsdfSW+AIXNzHY2JAESylM/5d99FguRZSl9P9cv3OI=; b=SpmOARpyygsF3dNXi9VjWe6KsLod65afEEIlkmFOt94+BL/g8cDjtJ//Wmde8aK/DTPrKgdKVuNMEjToPXHx9Noorvt6YZNlIXLqs4gqeETfKpCmzzpq+D3RgFKcCbjKK4fZQFcnfU7XmMy5l0mgphicgCnmR4h5c18ZMOwKH1XvkMDLC2NW5ijdtMQcdqLCHRyDH80uh7yCFzoalUF056ucc8eYhu0hrSzIdZBFxpDcsOGYrKbxn69WQOIsr5D6Y1TxsnChpnS/SyzQddjt5Y2vv+PSYU2MKeoAZsMN2Za7aY1zRtNPGk/r6plrRPaPwVkWY2NhY9xFqL53WRqiNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mt.com; dmarc=pass action=none header.from=mt.com; dkim=pass header.d=mt.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mt.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bqsdfSW+AIXNzHY2JAESylM/5d99FguRZSl9P9cv3OI=; b=Fu91qiNOdt/1K7PhrybctTAsQIcXg4Ki33YV+vPz0O6n57j62gbaE1krb5R4oJWL4VXfbzoc9XYtwQMRWbElbSKNYCyx70M4xtfZfhGsRErNptk2/8O7kTPSjrda8ko18EGjO/KPu2mbEB+63dVom4yNix4cqj+VSdvmkFPFZLcfVJDsYSPxt9SSGiCzqBvQap7AHam5TWTAT9tA4mGY7w1SUHth9tAaAH/iD1XPEgBALCk7rSVpAnXV8PxyOpoSDJLihnBP8CbEfVA/+Wpg2nfkqneXi5obWaR6Ptk/DDBgEtKLrhESFnzDkCFIUNQp/GjN5dSbLYonCfprwBOUfg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mt.com; Received: from DBBPR03MB5399.eurprd03.prod.outlook.com (2603:10a6:10:f5::22) by PAVPR03MB9797.eurprd03.prod.outlook.com (2603:10a6:102:311::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.18; Thu, 31 Oct 2024 06:30:51 +0000 Received: from DBBPR03MB5399.eurprd03.prod.outlook.com ([fe80::2fec:64f5:1893:f53a]) by DBBPR03MB5399.eurprd03.prod.outlook.com ([fe80::2fec:64f5:1893:f53a%4]) with mapi id 15.20.8093.014; Thu, 31 Oct 2024 06:30:51 +0000 From: Markus Burri To: linux-kernel@vger.kernel.org Cc: Markus Burri , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-input@vger.kernel.org, devicetree@vger.kernel.org, Manuel Traut , HeDong Zhao Subject: [PATCH 3/6] Input: matrix_keypad - add function for reading row state Date: Thu, 31 Oct 2024 07:30:01 +0100 Message-Id: <20241031063004.69956-4-markus.burri@mt.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241031063004.69956-1-markus.burri@mt.com> References: <20241031063004.69956-1-markus.burri@mt.com> X-ClientProxiedBy: ZR2P278CA0018.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:46::16) To DBBPR03MB5399.eurprd03.prod.outlook.com (2603:10a6:10:f5::22) Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DBBPR03MB5399:EE_|PAVPR03MB9797:EE_ X-MS-Office365-Filtering-Correlation-Id: f386ac41-3ebd-493e-1dcd-08dcf97590a9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|52116014|366016|38350700014; X-Microsoft-Antispam-Message-Info: WwxrPTnEwsQ6Obh53jLzReDShkKkjTR3fQeMl8QXb+blEI7pM7jyPKeAaGsgjbJD1gZEjmJslxdj2taU2n4Fra0jxuqUHK6zwF6MfuINMklEd4I6tYNMvLQopHFVYxUaREoDVxip4KrvyjKmZED3Eqym7LvDoXyCAaUi6al8yHGoowFvVdGa07+vr2RAijRB0qyF80+wCwGcw/pFRy7nCoxyNijpQMucu9HnP44+zMHwFJWvpONNgia8PTLHBPjgh+wVWDj20sJElGnAFn7q3TTlWKVNJ9bZyqqip1NFaBCr/di72Br6U5UZJtxKWYCY0DccmBj1Z8nGcuz0frtmxzgXSYqNaIzQuZQDFEhTDeIGCJqQad72WXV4f6Qgzd+OILN29bc1te/xHN3F8WQQbL0qlCog4fQe1dh8KpF3hAkOFZ7a7BT6svmTgwWidEm6a6ACALFFxpX297sCF9RiIM7aBYC+Qn3py6P8hdR6s9BA1Kq9sO5GHKDJ10ov/4Tv41rtqgZphN94BKzxHD6MQnay/dN3UKaJ5doifztRNKk1rOcIUe1MAAGsDoXRzmvcvipn1JTuF1flmnwg/QfbHvIMJKmrHEHr57MurqkW3VxhSJmHVvaU2AmGQnFpTEKwf4HzR/8FIFTsYJf2XjGYIOG46eFWma6pAsh/ZT+5pz1IysWRBOh1P5Gw9fRtOqAXCZjStyquEh+wmB1EFRZkX/hZHaUt2vFlbpJXNKJrq/RrsFUORSPrwlyWuezmtaknTcDdBfdiygwntvWuLUeDWY/a+4TK13FlLkb4RQz2SHg+n4vRLVhQ49ka/v0NEQCqUCT0w/PWb5zk6uTKAaDP6GJnh7USuLAUE3SkkeqCndN4X2GvfetFlMSUsOyMHDj4eG7viDv8EO5+9w23sOfOtrccL67NhoN4QFz7fauvvF9P4EIpmoNo0tlxQ80uomuQn56F8nrCy74tdAzYBeaHUE9l8CymJGBzN9tUfm4C5krate46YMDtWEzopB8DxLaOnCUAXbvmulea2XndmXqiZp7m6qnCeneqv8JdkRB4s5IxidtjEIe02qMEdBc7dm7l169KvDeiFck3KV68rA+rU3QYm+QdJ4MbxBKSFdWxNfRi0vilA2O3YlJxEWCDvoKNSnWZHyaiCBszzENA7HaXxuXIRisgNwOm7HuyMOxhKcGbTLn/MB5b6kUuho2lCEOcXHqwPVAgTdATRRnv/sWNwKo3NuzqOdNWd66n04WD49XeeWF2++d90KEEH04WO7S1g6IJM/qbhwZeyDTFLRsi2oSzGlI7f0jS5QoJBL7sO/tB1kDS+2xuyMU0awXnN/duTvOMv6QjAA4HTLVQvJSj9WHFjZHy/xSOGBK7G6lGJQE= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBPR03MB5399.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(52116014)(366016)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Cyd96F7epd0FaEK01YFSvtT1tp41krdXQlkPwCE+NuoPhfrQCsgQouWhw1Oc4T8hXbuBGqee7MKR4HPbchOo1mJVOYZKHUbmTRVZ+c7BRFoAp8uqpZLZnsmjXdUHNOJOQvC+ZBCqE7RuFhkgWUKzMessIfi2A/rX9bsW1d4zdmqxP/RZsNhT7NyAvypt+kHIRP/81C2Qcc4AsuVWu1uk3jgB+qqtR3QtuXSz4VE2drVdyxs2MyMvmQ+WP+OoaTJMcsGh/JCxG5kGzXQF3UPGOa+EaqjEqLu4WqxVmcEjh7LmlYNnymmMlgdT5TlSNu1Ws0P0hOrGkPmGSV3HDODxlgiadgxpPFJbYnfAv9NzK+F2yYZ+tGiFymYLdOvCtdEY4BrjjaHMEqtujhYrgxHnA1L67V2lf+Y+9s3xyYrcryQjMlLkTQEhd6jrybgYmCb3jhLvlPkCS9iDP2afGko2d8r9KMjY4TCpciLjMjX5KMOOvR/JH4cOEmcQltMj/+XQYovNrCKjRBsf6PNddvyXQLDjDY6/Ir82dG59U43Qq4OVJuGtLprfGkrBGDQPwvKrZ6cYUST1tC+Q55Jm4/YbwUhVxZFQXw48hg5WQ6poHmGM9ndOqWxedqJVG/ikCo2UHEtM+YO8JNUyQMzF3ghulbbQjlp1HLgCDB1CBOVWFr8kgOuegespCtmy1zGnC9WV4T3d5JOMyE2XRnVm2tM+3aDmYkAcmiW4eWC28pbKAHau6h1NTUOYMRUyHkLrwivMCivc/DYpHqA/smd+kk+rkpGU3SITglphNjM7npugesNcdPJzsjlxF018AfzreTuECePyi3dk2pWEzaIS1bjzcn1TRAXx0W5wKk5P/B+vHzHtCHKCsXkWBS/epdabYBX/5j2NbnQyDhvgDjAS2Qz4MkL1xxcBy+5I86QFV34QuS110Q8FyXQq6o6gcPgbwxcrIEM/XiR4XjPQfnygzeuF1HL4T5FyAT4zblIo3ysWSCy7PjogTA4+MO0v2u1Zi8Q88iJnGUl5rNZs/utg7IHSrEwHEPvVx4DH4QGQqwxAFqjbIpMVmGHGodKqWCs9uKTudePkhSCLFSGG81RA+0DdY6oh6ucU9yIRWLQ3g208eozRbr/tkKotimHEwqXx5DXWI+oT6C/l/k09S+s61R88NqBF16HsjHR/GZ3nf5EH5cxcCGt669Z23V3brHslWrjJMOEszIsGJvQxsnko6BPTna5yhhvReHZuHOeDwG9KJSqqmFXiV7LLRxDvkSdK9rGInmQvzkFc6bxpBSkNJQLdzOaDUyzLIsKYXJHQ2s5YQEDN5D2FPxJx2HDigWQVrHe1Mqm8vNdU9CMLZ9rli5P+3FGmAdZtJDD5QEEXM3zboSHYdC1sdLr6cS2q6tmkF4uaUnWyDSCmqjm8i/NJSBOdW967wgBmr9FsBdpriaYrYsSTUog8ipO0f9rA3+mJDyDmFK4kRA/A0aFFsq1Zz4VouJYXdQtTNb+V7h5HMuiEpuFK8zj48ynk3T1F8XY4xz+EZq37bcDZTzC2Y8vRwGoqnfCjTSmnzfd25f7jcpyokyK6tMMxN8THmFsfcE+2fveE X-OriginatorOrg: mt.com X-MS-Exchange-CrossTenant-Network-Message-Id: f386ac41-3ebd-493e-1dcd-08dcf97590a9 X-MS-Exchange-CrossTenant-AuthSource: DBBPR03MB5399.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2024 06:30:51.4298 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fb4c0aee-6cd2-482f-a1a5-717e7c02496b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CUEIB/9bkMpGBN9RyrZ/84aDFO+gRJmgtCDAyiQKi78bkeo+E4Ltsk79DIgQXYUe+Ko5VEp+2GYLgNnxmR4buw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR03MB9797 Move the evaluation of a row state into separate function. It will be also used by a change later in this series. Signed-off-by: Markus Burri Reviewed-by: Manuel Traut Tested-by: HeDong Zhao --- drivers/input/keyboard/matrix_keypad.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/input/keyboard/matrix_keypad.c b/drivers/input/keyboard/matrix_keypad.c index e08d7d5..c091f90 100644 --- a/drivers/input/keyboard/matrix_keypad.c +++ b/drivers/input/keyboard/matrix_keypad.c @@ -101,6 +101,16 @@ static void disable_row_irqs(struct matrix_keypad *keypad) disable_irq_nosync(keypad->row_irqs[i]); } +static uint32_t read_row_state(struct matrix_keypad *keypad) +{ + int row; + u32 row_state = 0; + + for (row = 0; row < keypad->num_row_gpios; row++) + row_state |= row_asserted(keypad, row) ? BIT(row) : 0; + return row_state; +} + /* * This gets the keys from keyboard and reports it to input subsystem */ @@ -123,9 +133,7 @@ static void matrix_keypad_scan(struct work_struct *work) activate_col(keypad, col, true); - for (row = 0; row < keypad->num_row_gpios; row++) - new_state[col] |= - row_asserted(keypad, row) ? BIT(row) : 0; + new_state[col] = read_row_state(keypad); activate_col(keypad, col, false); } From patchwork Thu Oct 31 06:30:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Burri X-Patchwork-Id: 840327 Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11013026.outbound.protection.outlook.com [52.101.67.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 961F813DDAE; Thu, 31 Oct 2024 06:31:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.67.26 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730356264; cv=fail; b=KrbjcFF+6BBsDQbGiAArlpc3YtLCupmul0JOqZiEdhjy6bWK6QWrEwQISASWmJaHDTMU8Lx6rTmtDDsn/qMtirrUIhnHpHzBZULqeGr9EabiR0GLZ5XAYVe7Ua7tiJM7329wMy2WU8L+1LZ8rAtJpHqlQ/G1X0jaQGUo4USrJ0M= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730356264; c=relaxed/simple; bh=SLiygjteYy3D9gMTmdomf5GpacK9XT+u+eebMlGsj3A=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=i5wJ86RIeGwZv+pjJNw85BSHsyr0+EaJaVpaaR9+faBffeUI18lf/b6pTiYbeaEOjq1XQ8QxlU7qKM7BjLZA4ugMHMFqJJ3a1jX8+658CKQyBeUZDaaaT236KN/oqxIj2hWr5TCEPCJf8pkHFxzWXEJ8HtAB4S2ZPfN10uCuav0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mt.com; spf=pass smtp.mailfrom=mt.com; dkim=pass (2048-bit key) header.d=mt.com header.i=@mt.com header.b=KcHxJL76; arc=fail smtp.client-ip=52.101.67.26 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mt.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mt.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mt.com header.i=@mt.com header.b="KcHxJL76" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pHOowlrpOtV/eR6QIAlg+hx10hwRnXXia+W9PuCcpIe4q/We9vWRobhiY7eR7DmCTJs11LUwzdtub9XtM00DR3aKJDpEZoutZJBwu55XiqlEctNgFCScez9lyKV+ReelyIhvZrhpjd84f3Xb25I7aWLpBfl2KaW9hk55eztj4fnALeuFjjDT/z+ea7HTbqX8mYKjw8mFEpZwCXxOeIp71PGIo4wsUQdcNGM2ANT1wiLEC8fdG1b6AwcRkjsDJH/mbn2e4PXsgtFP67J1TWFcl7AERgho29k+KUTcyHMYT+QD2iwB628te3Wb8ziN+Yw+ARheYzUW0G6YsenOuJgX9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zgGdKJiKCKSfW2OkGCQhkNI0k9EPY4wttilOMOkC1r0=; b=TOoZDL8TsLdh3fzLXdY/dnbajovAyp7isGRNczea9mDb1ahL6R8ouovS98kTy2MMBAOqrVA8D+9UiYTsflUmieJY+S25ZRg7hYm5pNzSpP2MEPTCPvtzyygtWgqoPdX/xtYHE4TRCN8C6a2rvu7P63Tk+BleH8BEc8gRkMxuRFEdMTdBLVuSvE8sFkIY0xUmu8fuYJTZLQsRImEhwxj+zQZSaKaajuIaW1677grecGN39UhnffMDSQWZULoctTEm52TKoYSyaf5IE815HAMZIlsH5ziUzraoxNSoAKZgYBX1nAhCS0boonU3GxpkBi9BShU+cw7S7HipRjBXUhqvrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mt.com; dmarc=pass action=none header.from=mt.com; dkim=pass header.d=mt.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mt.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zgGdKJiKCKSfW2OkGCQhkNI0k9EPY4wttilOMOkC1r0=; b=KcHxJL76z8QkznfYisCF6JcaV1qY2IQOG53UwUDgF4JsY6KeLyow3a5zW0wthF/8E5h/7NSyWF1VyHA30VQbojmrCZyNOE26sM6g5BqCWKPIzbPgjUrR/JIfszMyRZruGaB8fRlT5o6OFEz4TqHxwTvTidyAHgeGLY3V9y1mjxmYLUnNrNPvJIAqUXaQr6n7HioPa2P9noll3wlbGogoh7a+n4EvxiUOVKCoINrFg6sRY1RSmXOCWqklyOgyi3/RVoz665erpnrKgyfz5Hy5JPAeK0quhhmXLsJC6zkY2JsNsSTBQb5b4yMjwDgQxz6M7JYTRsLuUnHNS7fDUMjwDg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mt.com; Received: from DBBPR03MB5399.eurprd03.prod.outlook.com (2603:10a6:10:f5::22) by PAVPR03MB9797.eurprd03.prod.outlook.com (2603:10a6:102:311::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.18; Thu, 31 Oct 2024 06:30:59 +0000 Received: from DBBPR03MB5399.eurprd03.prod.outlook.com ([fe80::2fec:64f5:1893:f53a]) by DBBPR03MB5399.eurprd03.prod.outlook.com ([fe80::2fec:64f5:1893:f53a%4]) with mapi id 15.20.8093.014; Thu, 31 Oct 2024 06:30:59 +0000 From: Markus Burri To: linux-kernel@vger.kernel.org Cc: Markus Burri , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-input@vger.kernel.org, devicetree@vger.kernel.org, Manuel Traut , HeDong Zhao Subject: [PATCH 4/6] dt-bindings: input: matrix_keypad - add settle time after enable all columns Date: Thu, 31 Oct 2024 07:30:02 +0100 Message-Id: <20241031063004.69956-5-markus.burri@mt.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241031063004.69956-1-markus.burri@mt.com> References: <20241031063004.69956-1-markus.burri@mt.com> X-ClientProxiedBy: ZR2P278CA0015.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:50::19) To DBBPR03MB5399.eurprd03.prod.outlook.com (2603:10a6:10:f5::22) Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DBBPR03MB5399:EE_|PAVPR03MB9797:EE_ X-MS-Office365-Filtering-Correlation-Id: a07a9efb-30bc-4baa-1877-08dcf97595a3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|52116014|366016|38350700014; X-Microsoft-Antispam-Message-Info: d6InHlKxIBXJ4dBx3BXdeHY8HCaPtTwluChZBlSN9pj9EhnbjoA0lcZB69TNw/BCe0LpDjbw9M7mbmVN3JLrGZOuqFlf5wK8wHrbRoJqP1Q8hbogG4BCBgkTKkDyKJSRe6gZQfLton+3eWmaxAgneB2jjZfwwtBwwo2hwfmodc6Kfln3MGd2VoVnvrDEFWUUHn6Akfi3P9MfyguVuwrjyE1wyYiIh9ZvDvYCdBGwVwkjZRH4MGOKINfJiwOMXNpyiNdGz+DmwAOPY5OQj3IjJV+me3J/jSdQ3T9i9R2NtEmYVvNnCMpDJfM2kBInpzAu+/GuYcZzVk2c/ev8IlmnsjXuBLddEk9v8ptZsaBbq4xSinkg3smCJz/Ytv2/UM46Fevgd5/RMg64guUwBhIkkJDc7l1KcEtGLQKnLfu+Lx9auiG5ksCke3SORVaxv4W00lY/5pSqDE72J7l7m0za2P6buKF3l4rCo1sBy94NJsBo8zQRReToIFLzINrnssTPi0JTZHiC7B4VnWr+MFVh7m2obbRFeICQrw1XTAZ1U8sBJcG3MhfW+Uz3PUf1Yk6VkrGLqnFzW3Vy8VyQd4n4s4AHVAQklu5XVysTfp6JRWsRJaUfHbqkgD88t5GXK1ZuR06C0FZxsM8GHedVPFwjLSYsj4MgQFEbACXzexTSYL1tcSHII3plrQbZJ41tZZ7CGJf9wCQpRfTzJZbJY67YYE65ptBv64tNU0FMbAjbaUPGf2cMU8JvFIwEfSpR3GjJIHTFg9xywnqgbHszXheS7uVW0ETDi+EU76g4Z46B0THCJiU9n7IxCJhjsq2jiy8Bcl/0DwllgWTw/Qh10hARLzZSGmnw33550OGvT5Mq1NLZY0AmENJQ+nAh+Y7Ve3yj6E41BT+6tEsRwED5BL/QCqpO1EJ4duCEVa939ep3Qo6Vl+jXZasyENnc21r0nTj8QZWR501dPP2rndAkEoVS5RvhR/EpaFpoP7L1KZJZXyfziWh4Zn1mSr7ns6i9+eiQ+aeIyra3mzLNvH3NPiVlQLADA5zgOScCfQFmSXxendY2b+0NXpeIB/78xDx5rWqbGeR86mj6NXcqg0N4tGVOB9XSxPCrLj3RwPwgPdfRXasyfXrRGahsM7JAGxUU+TrSS49aSKZJ469kEa1qlL3f55/oq+NK1euTjWlBfmhomom79JcGQPhV8YDwANgImoiPoEt25fQCXwbNh4gaIIRhIfufnMVwdiSQjkQ5iBdfy/GB3PpBAlxWvGXImO9KssIfT0LIN0i7dDzMVhkTnH5wEDByARya+tcFHMgaIYfHLzvYG+3uNr4QOpic9kX8lRx8Eh5kA3+SvRscLG0nMDucHcdNoMp7KxwvcrMgcSjTJZU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBPR03MB5399.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(52116014)(366016)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: z+woOE9cnOzgQKdtDaX0c1oj1WU8lydo6yBeEWdFohI+NADTApExhlmw1cCzqKUHWhA1NaIuUD1VHNknCklSlbS14S6/vAfy9Aviqzw4UoZzWWFJdRGnu9txv95ihZHNmcpo9VyBqVX7SFwhoFAIjleQCjksbwPIFfFHEV42dOKXS/Tn9yNeaTdiy2RvbD/J469zaPej+LIZUQP850tF24fZf5qIwb4nx/z4Y8ZCKtYOItg0xQu3uQUzyI4Rkdfc8wyAqiZgUV4Y5COA0Mk8woL9ZQC2pFkaGdVgepYpomMD1UElO48AKs8zVp11QIed4DXZ2n5UYyO6tNpEZcM4cpAG1QDja2P/fopDEDhWlbLzvyTL8QoOvO0RF10fLKfn/71aufAUFh5Gga2sWoOsloy7KDjPwrwQurlvASPnFAqKRBBG+lKO3kLXpbz1ifsAJ72FlRig54S9qTwROAF5BSl1f+ld4mWi8Czl7S1jaPycjNiTWKIVkbGeX12h/WegcEGR+mfwn736ZdsBa/MWBk9cdRunnBAzbr219F2PuyWJQB1San5mSgiKZT+1qEOp9h+p0gnRAb6mwIJ4+d7nDw/V7zhC/wvgmu3QzfsMOt0e8h5/9D4clV3Nf+rId0pyPjOm8htpQ6bY/PlUShB66lRXYXMG0qsWZj2YnNFpBybIj9XsDIlxDoqBIVi06UxuoSsnNwev5uSV9m5VKjKSuPoEpZljD5x3+XE/zS4uRLAi1g4sGL3jro612o+IZRoxAmG69mWqL7M2l52WS1cuFEMBqlV19HdEzXwLu1EJN/lc3dR1JjgsEsVSJEmUBFH1m4kUg3KROtKrvTV9mcktbU2+jtuzHLHoeIvQntMK2Wqc9BV0x8KNljcsIvifwF5W90dA6YJ/5gffShBdcpmIi1wkCtta46GogaXzWrOw9LKGi0aQosFQoHw8Df73hdotctr5qTGrFWW+pdYdmUDCUj82AYp2bziSwILgIwH0vybKdFiW6YtCBLYmnIks6eqrxeTqpctDOmvV5uDXeg9f3wJgKOxf9Lx1Pyh298OpYWARizHX2+EbJLFG5F5rwzvbOyIHRqgpoxl8wxjUFWXn/8nLm3gYROU5i2GNg0yHHeqY/dO989QBKma1tp5Mj5+2pmgzd1JgjX8aIuHksjwkUzoJdg7RzHNOIyKxqA9uRKUZKaNNgiNw1i6XJB8ucb09aN29nctK9o+CgrMUe5Hj52EX6HURzpwqV0p0T0CqA+XCC/HTPxmk+ocn24+jH3mrDuDPNKkU/MzHwNdS1WmMuBpAVBSNwM3IJlsXrmXjSr1JnW4ZlVWBrZfr3vp5du1s8FI4NpUnpYTOBjOA52t+hIzDons+2DfWnwNoa76dXbRXhR3kz5oRz/QM4RIlz5bbaQdktBafzvg/v9HRit4p6YFLdJSc1Pz5BUsDUhi7niDRIt41sE4ieYtHZpYwO1Kjc2KpceW0BO4EY90334I7aISHJfSawOIvvZ6P9Dli6bV7+R3c44LaZhuL5ZtrBZShjrmz8avaSbyuQlUXgH8NFyVIKHnEwwpbM+H0ve2OnSU6fp8M+yVnkhBtwvE9Aknt X-OriginatorOrg: mt.com X-MS-Exchange-CrossTenant-Network-Message-Id: a07a9efb-30bc-4baa-1877-08dcf97595a3 X-MS-Exchange-CrossTenant-AuthSource: DBBPR03MB5399.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2024 06:30:59.7947 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fb4c0aee-6cd2-482f-a1a5-717e7c02496b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lLFujr8LpeXJE0IAm1tP9jISKjNz6mLOsmgQ0saIdn/lYQTdNbV9JV1x80CSePP0i6pXptp5cUfPE2iXQgm4vw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR03MB9797 Matrix_keypad with high capacity need a longer settle time after enable all columns. Add optional property to specify the settle time Signed-off-by: Markus Burri Reviewed-by: Manuel Traut Tested-by: HeDong Zhao --- Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt b/Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt index 570dc10..cf43fa0 100644 --- a/Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt +++ b/Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt @@ -24,6 +24,8 @@ Optional Properties: - debounce-delay-ms: debounce interval in milliseconds - col-scan-delay-us: delay, measured in microseconds, that is needed before we can scan keypad after activating column gpio +- all-cols-on-delay-us: delay, measured in microseconds, that is needed + after activating all column gpios, default is no delay. - drive-inactive-cols: drive inactive columns during scan, default is to turn inactive columns into inputs. From patchwork Thu Oct 31 06:30:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Burri X-Patchwork-Id: 839937 Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11013056.outbound.protection.outlook.com [52.101.67.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1496C146D6E; Thu, 31 Oct 2024 06:31:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.67.56 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730356273; cv=fail; b=cnHkrbaIqOqTAwRmwWvDh/Bvf7i8TAZ5rxOEVwwBu/1lQIcB/ZWgNiZdPm+uosN2576xcrWZ1hL69FbDJXsXEaPB3Qmim1LQ7kH3uLs9mPW+c2Ppt0iHi3WExLFG/cEHH0jpKMi0srvjvADrjddKlP2Y1ARNHagoAA/UOfCfbI8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730356273; c=relaxed/simple; bh=St5a4cm327l1cBWkQVf5p1hsDXxmtaWCJlFZ8JJvnXc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=H36c+njyMeqkP/Aj9MGOHNdBNvQGa8WX6/Tfk5dJUHcKAPz1herfaS6zm0s8FT3mbslHwwyvgrE6NEhmVcxrPSzAZn6ODK+9IDhXDGOSYIOxigogoiMrsCDvBHFfX6VRqZHSE3iU1OSTpFZseJ5H63U/daY45Cesv54KS3cCsXA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mt.com; spf=pass smtp.mailfrom=mt.com; dkim=pass (2048-bit key) header.d=mt.com header.i=@mt.com header.b=lvr79fEz; arc=fail smtp.client-ip=52.101.67.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mt.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mt.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mt.com header.i=@mt.com header.b="lvr79fEz" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cam0XomqzzVAkkWvVW68/t9J9jYsvgzG4EkXJQ92HU2+gKGhSUX86UBN6hdhwQ8eV3tKQZlv690BWtmlodx5bk5PUUO4JPUup5x6WxlwqE3OVejGV7T0huYoBOizP7GLx2jIU9bTC35D57yFsbCB3hIXGAq4vyf5ae0UZ3tBhYCFGX7XcTy5181ghQeB3alGAkr7YGg2cw4JQtFp52SDtxIRRLVn3SDgjY+Ruvf/rLG5PHZ1KXNfdSwvu6cEfxvpnAlEWKhfWAoudTqePwToaQJSJii8ndMQEM5yHm3Un4yy3BTO9Q1XUCL6tL8GZUZGtEyZFw0iDR0tWTEMBnyLGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EaW40cTlogoneT8tAEqcXOHyjc/wCnOytjchG3JYfM4=; b=pUtHdqL2y59h0NRAbHz8uaR7rh0L1R/m6XmpsL2clMX4d2NiW7rZrTb6acBPiYKbfB6eFidQOirDMVI6jbZO5t5ZFO0F3L4Sneb95H3rg1XkW3Aa0cfxs1F74uC+txFnRF2UvycAhTusjJGsGG/rXXWl/eDFjg0QWI2rC+7b8UQkU6avAQ2P6R6A3rVvpD8lGU5TY9yDhldxcWV/SSoSwmu6OJo9gCHv20/B057nEH5nWBCI5bQOS932uiWfCX2vcSjdlnJN4gcVXltcP945g+ZKIOqqZ52RUyp5YDlwXU67AxoDofTUD7QtTyYOrl99ZGDjW7+/oEqY6N0JFk4UEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mt.com; dmarc=pass action=none header.from=mt.com; dkim=pass header.d=mt.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mt.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EaW40cTlogoneT8tAEqcXOHyjc/wCnOytjchG3JYfM4=; b=lvr79fEzlgaoUlR8EcCunXXS3bUxFFiWaZ7GGQGzSHrMFY3XSoCpJg5cMljHSHuGwNEcGtINdgpedFYAVCjYv05OQopx3yiyYtju91pEcJVjxPmGlFZRrIIgRsjy2cxEdNtL2SKhiN2GMKDwliFNfL1Q9tX1jSLieu8xwoNLcOSyS7hxkZm+/lYmFIVBVm3dTuvxvJkZ8Y+teEZlGDp8xdB5B4LLdSXZIvg4HOMyhRPPvVL+I/hRVDp7BaNlz57PwZ+4CQ54pWT3T1n+jVjs4YtuLyglu+cJpG2o2z9PCEmUFGWM8UmqIj5xnTvjTHsOkXjpugpUTZNAOwRH2CsmqQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mt.com; Received: from DBBPR03MB5399.eurprd03.prod.outlook.com (2603:10a6:10:f5::22) by PAVPR03MB9797.eurprd03.prod.outlook.com (2603:10a6:102:311::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.18; Thu, 31 Oct 2024 06:31:08 +0000 Received: from DBBPR03MB5399.eurprd03.prod.outlook.com ([fe80::2fec:64f5:1893:f53a]) by DBBPR03MB5399.eurprd03.prod.outlook.com ([fe80::2fec:64f5:1893:f53a%4]) with mapi id 15.20.8093.014; Thu, 31 Oct 2024 06:31:08 +0000 From: Markus Burri To: linux-kernel@vger.kernel.org Cc: Markus Burri , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-input@vger.kernel.org, devicetree@vger.kernel.org, Manuel Traut , HeDong Zhao Subject: [PATCH 5/6] Input: matrix_keypad - add settle time after enable all columns Date: Thu, 31 Oct 2024 07:30:03 +0100 Message-Id: <20241031063004.69956-6-markus.burri@mt.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241031063004.69956-1-markus.burri@mt.com> References: <20241031063004.69956-1-markus.burri@mt.com> X-ClientProxiedBy: ZR2P278CA0006.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:50::12) To DBBPR03MB5399.eurprd03.prod.outlook.com (2603:10a6:10:f5::22) Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DBBPR03MB5399:EE_|PAVPR03MB9797:EE_ X-MS-Office365-Filtering-Correlation-Id: 4a213cdf-fbfc-4b5c-830d-08dcf9759abf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|52116014|366016|38350700014; X-Microsoft-Antispam-Message-Info: rYE/yV9vZnxAATaUnaxZ88M4c1/XQJgEYTy0hgZJKzXuuMXPT1FfGgDaHerWydW8e5NbJzQvxoQ5n+yVfhSRWVj7+ki71zGLMIQEDeDqv4vVIoJd+4mPk/IitwoYHbjCeG7wHHU2jbhCOxjmWfsddYV/cdrwkLeqYiWStWljKZNsyfdcXP3xb5bsHuU1s7iO5REZRdXRZgHddNT20X5PWAwy2iouoz0z6KBDV6tmOicAnvUbefaHSGWOMUNutJBUptHetMjPQ7n9wnnaLF3TJb35e2VpFF9xHGYJzHzPTZRAnVO4qeVYArKHwEARcQ08uAreupwUXK1GIXZdRB/kKhfMR/rwVsXbIEXaEnLjepFeLg/RUwQ0HhvoljdXPwTW9o0+Og45gcyXxWtqR7+uCbRG1V3BjpmLf1U2Qe+72Iejqcqxqn4tpVgkgUNGhPCLLGCosIPcNW/zN6BKsUjtJlPxRUFbyKjdts8F8gIQ9GbydB0OaBVylbGFr0QXY+Pnjiv+IB4CZ1T2ohNnZcFDfZBPV0aKIBlBIyRoTgzH2CnyBvsg+xCOx837SFZfGTKN75tE5p2L0V0pMjkgBERUgFED0dAgMu9jYstuvM6bRQCCqii1wVm2eYyIzUpwaNPJpvfZrszN512yXa7VaRgJH00YhFjouByQD1Nx7bHECboNiRgBn5iGWOJ32QwoncKiaQZCUMCMbrVIjGyzmIcWqEabcRq1bs3lMYEpRmsLddkMfY2CUzBZ9wIxF4PElOAtxfOATsiCs5xPYGB7uILWqsnXIFvqaEAvRT+4S8Hao9TQCgTTHP8FonY6MSd0UfJ3calUtlBk8iJsTNjT6cgtFrlrIx7f2BJgqkmYZwWNRoIJvdzPhEFK2XWv/9axK4XcLWWH4XmSJe5qO1tHJArnYIkhduFt+odTyzBjV79C8krtSDh0TOVWiEo0pJpm7F5XM50fA2UfcftKAlqD0iBQvI3cLlCgrJs5XPmGI1q6ncFrEJYfeav4ziWcP0jCYud2gMMloa7KInwLahg2h90HP+xdQXlksPIJA/SMxQIzflMOQdRAQDWrA9xsYMeIXgxKqQ7nzOoFTzxab/gI4MlAh3H9KBgeloszERCjHCu3CheziNjv7adrDEcY2rxOm5nN+8cKu7lVv5Fz0jtgWkEMVfjPHo+KxH+RzAyMQkv5jUwjE2Il/iyy+WeDIvjyRPTbR2USgei8pyLISTs89cLM3GzDKnZnHrPEkxuZG30UrysA88nPgfDM9pJUyAXx9+9f1h2/qfJM2YcxRockSursiDL9rkh8HlJ2dsO/5qNA6FSGCtKBcs22MzWGfwscgG0JLxb1aNktI8jekOLeyvLnWAFWOSwv27N9jmLaF+DDNkk= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBPR03MB5399.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(52116014)(366016)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: dcSnUtxKC5OacpPfDc3CA1Lo4lgtHZEnKvLXmX4qfquyf31caOWqtk6qW18enuDb/BJP7kEQea7AVPg66UConEsHalQeHLV4iKBHnZxZLR50krbLCHknxTOV/czn0vmleSaMRug3Hj00AWIjDBNHsSctIWdweVbIJTrCahHIvML70Nkq0wFodhxNl53jacl6WdENymQ8KP80ilDiW0P7ra+5nekqw2SXNvPTbuRb4an4BSRgMcmWobvu0S/kwgiIcETIo22+erEkmewLWX8vktmlWKXqQCkrOfxxULKT7W4cw0Gvmi4RwV5DQ1hnpOZKEO9ZJN3MHQ3VPBcYYLmFfRDIpGwRYjr1r72yN166SCLU9ONUwO4lq7f7mPi/ZVmFrhSZTIde19afh3CB6qB/V0UFnM2PpZYL9qZF2Afa0lnPI601OpnmaKbmUb5TnsXKEOrPKXdQBmTWYnMC21363PJD3jtoJrYkxl5IwTwCOdyZ4LPofa4Wr+p49aUIUHvWN6n9WvvUpf7kKN8viyetPyge+nHgFzdinUuuvQzvuT5B36lpSIqYNSt+ztWFjAeNbiWbRgBcG+317UsCmKMgyZZDGWYz2orDYAG2iGSp8/GzoqShIp89jNzO0b2i/BecDgMmiRJaXadUKhCRGee6uiuO8mwriD0YTQeQIN8Sm4LUj31PPQs08j3HyaRg2KLzSwH7Q8IAPf88U1m1DxqsTKKw89HY7iu77r+9KoyUqzqg5TZkR31u8v8wO2YJnvG7mT2sqlqfsfouEq0DYpA1RjmNvQ+9zW5VNkFEwCwQy/s4ZW1iMQWWAAcB84657nj9rIKNELW/t0WB07b5OxGMDkajyUS3QS1wJR1cLQWhRnBXUXqDUx01xdiyY9aSHnsluXcC8xb2sQsbEzer6U5pj17Tuz3UKpqOvp/LI5WuGHgYAlesNT5x9iici2MScl0MG7WoB0J9bo5UKUToTL+rwBqDcjYyx7yzgPBo7JBm0P7ZF0SbgUAk6hAEURIIHrYvBDzqw4cXuezWQuf2QvFp4XSgHjVkXhIsjU1ipFCnlfGGGsXdnpEvcV32o8bsqN5iMyDKuiFbPrBrsOzmTA8kgG7gBIXzEysD0Rbk7QgCP9z4fKDUmrNHTkftrpfMW+nBLqnyr9HbvXR/wP3XcbKB7AhIJWH0ruM3jJ6RZ7hO0laTysPcerXoXtiVnlhxLMBo4X6lQ4rRuj2Grkeag6yA2oeTK0u82TipyB+Ofn05gek5/LCQcTlptRwaawENF+kWPb+K+SOhZpCeiVx14MYja3OIipPqNB/WsBQ9cPwn8mhkCr2kWn9j0oumW2DcGqripB0buqlc92Jx8vTOWFgBrC1vH05J6o+83icbclTmeU+DVr6pasW5JSdTC6PPICV7QGGv/yZu74njGgW0WgCQ+QIdxchtQrHE6suTdlJw9vD2tESedutPj66eSzHQa00xZJ6nYPhnyAdh4Oih4M/81Is9npUE3uAsghIew/bz2KRfSiIyzM0x4/idwtw3pFI85QQMg6tB63n5E2iuV2iS2kiTc32rA0SDaFMscNTRYR5uWYxrVtnMqMNRNq62hCZq X-OriginatorOrg: mt.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a213cdf-fbfc-4b5c-830d-08dcf9759abf X-MS-Exchange-CrossTenant-AuthSource: DBBPR03MB5399.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2024 06:31:08.3517 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fb4c0aee-6cd2-482f-a1a5-717e7c02496b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aklhE9Tk0sm42J+g9wIl+loFX1Ot+udDyesceSWfxQ+cj2Gf9ig6LULd5z65CjU42Ob31dXvySB4+QaVP+m6mw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR03MB9797 Matrix_keypad with high capacity need a longer settle time after enable all columns and re-enabling interrupts. This to give time stable the system and not generate interrupts. Add a new optional device-tree property to configure the time before enabling interrupts after disable all columns. The default is no delay. Signed-off-by: Markus Burri Reviewed-by: Manuel Traut Tested-by: HeDong Zhao --- drivers/input/keyboard/matrix_keypad.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/input/keyboard/matrix_keypad.c b/drivers/input/keyboard/matrix_keypad.c index c091f90..f0d3004 100644 --- a/drivers/input/keyboard/matrix_keypad.c +++ b/drivers/input/keyboard/matrix_keypad.c @@ -27,6 +27,7 @@ struct matrix_keypad { unsigned int row_shift; unsigned int col_scan_delay_us; + unsigned int all_cols_on_delay_us; /* key debounce interval in milli-second */ unsigned int debounce_ms; bool drive_inactive_cols; @@ -78,6 +79,9 @@ static void activate_all_cols(struct matrix_keypad *keypad, bool on) for (col = 0; col < keypad->num_col_gpios; col++) __activate_col(keypad, col, on); + + if (on && keypad->all_cols_on_delay_us) + fsleep(keypad->all_cols_on_delay_us); } static bool row_asserted(struct matrix_keypad *keypad, int row) @@ -402,6 +406,8 @@ static int matrix_keypad_probe(struct platform_device *pdev) &keypad->debounce_ms); device_property_read_u32(&pdev->dev, "col-scan-delay-us", &keypad->col_scan_delay_us); + device_property_read_u32(&pdev->dev, "all-cols-on-delay-us", + &keypad->all_cols_on_delay_us); err = matrix_keypad_init_gpio(pdev, keypad); if (err) From patchwork Thu Oct 31 06:30:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Burri X-Patchwork-Id: 840326 Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11010070.outbound.protection.outlook.com [52.101.69.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 617FA146D59; Thu, 31 Oct 2024 06:31:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.69.70 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730356283; cv=fail; b=l0AlJGKD2DHKQjcvt1+CY1/jvkw19MqPKVONSLChRrLpBaHrf7AA+4cyM5bu2COeIN7iJHWQcUkZJyBbo/BB4eeMPyl8mYfB3WfDxLemYgAnB31NsoLWr5MqQEAfv8SLuH2lHeXlPHd0XSUz1NkgR2DiNwmWAGxlVL4edmz0zsQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730356283; c=relaxed/simple; bh=4fbsm3p05dHdFKozzpdHPtHRQIg2i58rUrg4QP6dj8k=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=rtzZMQmvfhgNOkoJzgH85uHsd7i6gEfonm1k1Gpv3VlSZthufTFcpazz6Z1qNoYhIiy828lImr+B3JHJEfW0lPLs6W5/N/hG/GQge6K6/8m1D3U6C++mliyGerBDQP4p90evbvHT5TzK8b7Mncb8vRtuCGiI7W7oYE0p1kSFthQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mt.com; spf=pass smtp.mailfrom=mt.com; dkim=pass (2048-bit key) header.d=mt.com header.i=@mt.com header.b=Yg9p1bS8; arc=fail smtp.client-ip=52.101.69.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mt.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mt.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mt.com header.i=@mt.com header.b="Yg9p1bS8" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XwCn2XIdS3urRfqkooQ62VB3vKF17LZTTL72h4X8DnFfDEstQv56l1c40C3fWmbSet7XFUG/+hfwcys2/Ac4V3ykMt3jP8DBmTzZKSG3l1/9mCIlqARCIwYJkXGHsyfsDeabHn7keIsS9HiZEDt+RY0LFr6wwUcEGMXPXV45CNlrB3O1yS0OuyR38UrdTrySPFK7DlBEM0cJqEIwl7/rgqPz1vgd1iB1z2F11w16BSX+pZRa78ckhLtbHtyAsAnPqCdw3ogDy/xt5Z4DEYlCc2+zVpyZlaeeYJwIY1Va4E4aLEmNFEdnrAvQzvcFW/Ex3fbsfaloLLYMdaWcJbrs2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=40sO2nvbbkMxOTpX0qWijE4NSJtlb6hxD2NqP2tGPiM=; b=YuIPRTe6nxE+APOAl03XvkGAcc89Ap8lBAnCdH53MZH70CcfzhU+LV56Hg6XvJhTsREyAXwsyYpRhZhGKWDJvnI7TiQF1rw7YJpkzgh5CZJkOXaGwnbzZKD3g3d8EvAV8jTWnn9/IDTzFf2Ewc1ibhuoKAaZwKeKISrULLilM6LArEuKJZ8Lc4FV0KSqnH/q1SUhI5hRxilHCZH9xoqwZ+aqLUal0EI3QHaRtwJbZ7hK2wsNMvF9aXLYXD+uC7eZB0sK2dBn/BGuVCVNU7+kCoHwRNKWGuGbDmaEJyzBZOaBLKeOdxSG1qRq7Cl8uGUQmU4MAp8pX4un10sMliAigA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mt.com; dmarc=pass action=none header.from=mt.com; dkim=pass header.d=mt.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mt.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=40sO2nvbbkMxOTpX0qWijE4NSJtlb6hxD2NqP2tGPiM=; b=Yg9p1bS8FTdC4x8B2DBYJEOihd2r+LsH0Zi4z93Mk6BQMIF9BENMGzvHWZ4Uk08z3vMN2kapcAqcby1DbONRD95u+qOpWWgtmQm3iqYBrnezynXzknLQTSmpEkUhKsTdF5uvuHHJwCuHMaRUcdie7oU+4x6hCZzTL5T8JgextgS1p9vJsG8me50i7Rtm6/DeV7UZtLu3ub5VCSr+UKjw1jAonOnJbTny0ZlKXrLnYDR5g50sMPr1cqi0ZDMsZGkXWR177QzWyar7zfeOSxnzyjCAQcZxy//mdTY6NGNhku0QRjsFb2dyf5d41GXBedIEiZDCTniZNUBmFKhfrRp6dQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mt.com; Received: from DBBPR03MB5399.eurprd03.prod.outlook.com (2603:10a6:10:f5::22) by PAVPR03MB9797.eurprd03.prod.outlook.com (2603:10a6:102:311::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.18; Thu, 31 Oct 2024 06:31:17 +0000 Received: from DBBPR03MB5399.eurprd03.prod.outlook.com ([fe80::2fec:64f5:1893:f53a]) by DBBPR03MB5399.eurprd03.prod.outlook.com ([fe80::2fec:64f5:1893:f53a%4]) with mapi id 15.20.8093.014; Thu, 31 Oct 2024 06:31:17 +0000 From: Markus Burri To: linux-kernel@vger.kernel.org Cc: Markus Burri , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-input@vger.kernel.org, devicetree@vger.kernel.org, Manuel Traut , HeDong Zhao Subject: [PATCH 6/6] Input: matrix_keypad - detect change during scan Date: Thu, 31 Oct 2024 07:30:04 +0100 Message-Id: <20241031063004.69956-7-markus.burri@mt.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241031063004.69956-1-markus.burri@mt.com> References: <20241031063004.69956-1-markus.burri@mt.com> X-ClientProxiedBy: ZR0P278CA0011.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:16::21) To DBBPR03MB5399.eurprd03.prod.outlook.com (2603:10a6:10:f5::22) Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DBBPR03MB5399:EE_|PAVPR03MB9797:EE_ X-MS-Office365-Filtering-Correlation-Id: ffed2d29-159a-434f-ed07-08dcf975a04a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|52116014|366016|38350700014; X-Microsoft-Antispam-Message-Info: BEmwpQsYnJBlDXPwkxuz1LiNJ1qDCQJB05xG4KAVoJ+s0qxNu9m7rVG9FJNQrBTZdeCieD0AQh8XMQX6PfPxcvwzct8HZvNSlFO3GtKS9oIf7sINo3eGeASBlFtlLaJumNiRYvON+Ipy0axxoH08v8F0WcZIeLkLlkiPPvm8iFdQBPC65f7y0fGvwPI5oZH9pku/VZi2DinUBzz56TuhtvyM/cRgAmHG23UEb8chKwp6UlsBf3tiutVdZ5fz9uL+fyMmpmfHDKj1C86k9fbqKQYSqBgpNDWt9wGBUmC6LAfLQtRCUHzK3C2t0ahX0Z+esaEOhio8S1RXQx46IRX1k1C4B9bTzvnfQ7/x6pJikFfshuM0D1KqNMYbVjCn6cIkEIPIVFIZXeFCZA0tjFmlAsbWVBGKjEqiq/waG/Mw/McfZJmYP6UtCIad+muiCnzX5W7P1LKMfDz3Z/rQ8VEL8XomZEs92Whv4hQS2AHwkT7OdhiSkqtAgI5HQ2+2pAfYi7rGlcqhTxCzoNtelToRhEyd05vOKbB+FOodBhP8LKpbVmAWuRanQ35xKedErSFay2fqodM3cnYSw3XEdmxNCUm9vMr1oIpRyQlI8FbzP5LMYtpHGExAH3yM+1isYnL9IK0KcxuqQpOZ/Ahs9aoZ3JydjOiZULLW2QUhmiXtQyeb1YNbCIKKvl4c9E2bSTKd33EE5J/NcuV4O9742+DoW2cHBBlV0YNCbn7QoqAooXwn/lMB3VjGs56RLDAcyaDB0cVmdBYlRfO3XhivwnaO+kJvdO5S7haca3yYmZ/V5WTdCYbPGMHJ476F5mskz4Fz4gxMJXrdrAMvySLeqda7dqcUK4hQ5UbOlIg0eelL7HVosoUTZfEP3Z6IUa0wS0xJo9VELXHCGg/ePuhr1/3fEhDRKBHmGzKBh7t5qqmMPz+D+cLLhRvSRgfbbz4ymaxvpcxdGLKOAxefBSRGocjQSjV1DTxGfZnhH0HKomfVj0P6ClL3atZ2NLUIw0mIoeA9CAP9PX20KyJDyApj2425vqncV+EN/qFjrh5OlRRJf1WPpU4wCeTqQVxPFy7dToG7/cf9M/k70bWcx0/GHymGR88ko2RK70bRu6dbRRhMGNZIG2CTy+olHklXIYIfKImE0Qf6j56tTU/gx1GOJIej2C03zOnbPBq7xEx+MObgkoRaRpV02V7YkVv57huI/TtYhMXSkSzhhaVbXeUh6geAK3EkfmAY6DK14ctdCNjDV1AIAKqeHy8uEDzr+MRZYsprNlTRO1je+Gef2jYQYKMu0qRZE7fwYHQ3/4kAiRTLhA1AHjcpx9pgdgebe6hQOqOg8taEWNOs2aabu77QtV6WxULO1bjfs8H70ZEHYKDgQVU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBPR03MB5399.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(52116014)(366016)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: IWV0J3/OGe2e0/RhHd1zfR1960n9RuINc5BlPfdmtGY4lO5HlvbRjCmWXK2XsCmgSPWnnSQj8aCkUvcrKLPLMYz9H6oOfYg6ywj7IMXzbAZq/y7PzGSIaZoAVA/8WTqnSFhiLn/NkLOKa8nz2Sz6BlDLDQiAsTNR0EehcT77vr82J70FbPIveJvTdn8JkUQVA51Wl7+If4iInJpkVtvDZ36o4I5RRIwa8NP5oDKHtIjMl8r++YLKE8oaf67qjK+w0odTQ3Z0WX5xPPnsxa7HYeH8SdnUhn2YgkxU30+fCtpIVvGM/DqKq4WwQ2ayBaeWhwrhjkJi4wyZbt8xMSz0G/9kQnhpC6MVWsLzNKr14C4/zdkJH5tIvp6u/g2OnCk8jLPoMfXNA8vtbHx4RI3KZNaMFK1tdZA1gp1giUn2ih3k7C6PvPS1lll9vPbDWT3ViQWXR7z/E7/jS6Y2y/62sL6q/glSBxJ4N/PvT2jaylsbCyVoynm+hjhuTk6zxQyRT7FM0ApBL2TPJ3qxEn27QFF5/3/jvvU2cT21MbWIJr97hBn9Nd19ojNkILKmxv/ovJiBxTpC2UQWcO98ohAaRRCyHJMM+YMH0XdFg3y55sgTKTxdwDd0wy1SPElafK8na4tTKYk8oApkr2Ec7Z7kCUk6ty4djG/7X4fd2V0TC1lrhOCnbHLrYQjJUOD1663KXKChxnedTbCKc3jmpHjPZCKB5Fq8H8Jw2GEZaPByKafPnNhauC6JuwBum7P6MIz9ZUp/NkmAAs4Rb/dI3B4M1LENeBM2hqZ/hx23BLijwsmL3gAW1zOTlNz/8wHqGW5X49wOBa/h3+wqgKjpzexmkDPocVlNy/8wbhhBR2ZzPFvk+gNaDl8r06srVYk9seQSyt/mSh0QAE4uWkU9QscdCrJB1cXxSZTxtDsuzhOP3jf9u4ZAqBOFrd6M8z+Fgp7PAtoVNIMi5TuGPjZzEBhqT0yi9EJz8iPTUmvbMAzfRJob8e7LRuRMIm2+cGO8cmx5qCTvqHPSo5J/d+/Diorxpl/a40zDVDCcL8YE0+tltLGzGNrfgNH8qjV4UppLta5qOyXKfUTdlfo08S+EprPRqa31uHCU4ldSXuayObEHb9dnd37jYwBoHNpHrRijqzoYpt9eNj3nOiJ38XpDo1FkWZTosYhKVgNrsAK44xKI5REnp/djuht56LQEfs1KDkHxs6JJQnA6VRKqEBAP547ceZaF8ktOyKVVHgBEg9rU4hjEdsKx9XIi88rH9/tdIpQU8uFvzwsPp3iRngM+eXAm+t2GP5zFWsXFWXE+kNBvlJL8OvWmRTPw1lOJ8inCNmC9uzdg2G+ig4m9BLaxxNrwbqLRaKGkSkleVoTFA4aHe2xGgKdX+Yy8Rz8sAQYGE4uTKGsnkji3tN5VrxNiJlP1ERGuIs4iCTiufV7fboiAEiYUT28909hAjF5IUPzHQwaQNrt+OFbYgeeUCImrhJ+pyCyyQZN+dHsT1Lwq2oPupU3r5L/Ug4qby0A5wl48rkyh+Wuf8nBKrDfphCUJeuaFFIc6daGSfNfYOisVwbKpghP2VQwjkhI2KS0cmvc/QZ98 X-OriginatorOrg: mt.com X-MS-Exchange-CrossTenant-Network-Message-Id: ffed2d29-159a-434f-ed07-08dcf975a04a X-MS-Exchange-CrossTenant-AuthSource: DBBPR03MB5399.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2024 06:31:17.6769 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fb4c0aee-6cd2-482f-a1a5-717e7c02496b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OS73Qkl9RhAIZBMiQ9AhEggTGJf6JNsD2qqQ80ABVFPXW/K8KoI2ydypOa1B3iI2v8l1gbYC+2WwOjRKDULKCQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR03MB9797 For a setup where the matrix keypad is connected over a slow interface (e.g. a gpio-expansion over i2c), the scan can take a longer time to read. Interrupts need to be disabled during scan. And therefore changes in this period are not detected. To improve this situation, scan the matrix again if the row state changed during interrupts disabled. Signed-off-by: Markus Burri Reviewed-by: Manuel Traut Tested-by: HeDong Zhao --- drivers/input/keyboard/matrix_keypad.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/input/keyboard/matrix_keypad.c b/drivers/input/keyboard/matrix_keypad.c index f0d3004..428b36e 100644 --- a/drivers/input/keyboard/matrix_keypad.c +++ b/drivers/input/keyboard/matrix_keypad.c @@ -126,6 +126,10 @@ static void matrix_keypad_scan(struct work_struct *work) const unsigned short *keycodes = input_dev->keycode; uint32_t new_state[MATRIX_MAX_COLS]; int row, col, code; + u32 init_row_state, new_row_state; + + /* read initial row state to detect changes between scan */ + init_row_state = read_row_state(keypad); /* de-activate all columns for scanning */ activate_all_cols(keypad, false); @@ -171,6 +175,19 @@ static void matrix_keypad_scan(struct work_struct *work) keypad->scan_pending = false; enable_row_irqs(keypad); spin_unlock_irq(&keypad->lock); + + /* read new row state and detect if value has changed */ + new_row_state = read_row_state(keypad); + if (init_row_state != new_row_state) { + spin_lock_irq(&keypad->lock); + if (likely(!keypad->scan_pending && !keypad->stopped)) { + disable_row_irqs(keypad); + keypad->scan_pending = true; + schedule_delayed_work(&keypad->work, + msecs_to_jiffies(keypad->debounce_ms)); + } + spin_unlock_irq(&keypad->lock); + } } static irqreturn_t matrix_keypad_interrupt(int irq, void *id)