From patchwork Fri Nov 1 00:24:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?KO2VmeyDnSkg7J6l7J246recICjsu7Ttk6jthLDqs7XtlZnqs7wp?= X-Patchwork-Id: 840355 Received: from SE2P216CU007.outbound.protection.outlook.com (mail-koreacentralazon11021076.outbound.protection.outlook.com [40.107.42.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D1C7196; Fri, 1 Nov 2024 00:24:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.42.76 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730420689; cv=fail; b=hfwfXzROs6NU4EqdDv/IPz66Ojgub2Byi3Nq0z8w4IqaihFCfjDLe38rg/ksRAyK6MQ6bLzVqj+sMQzNG/ub9sa82YXIcuUU0Ys5DCkjeYO+tGasqPXPJCBBLWUsAXY7LvtOd/VGZE+psUvO/EXKa7vXQpGoIAzf4D2+aEurLEI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730420689; c=relaxed/simple; bh=2mrnDUvIRVIJUVVowJtn1GTLQS/fNeX6i/JswA0nb9o=; h=From:To:CC:Subject:Date:Message-ID:Content-Type:MIME-Version; b=j7sZDPqSJz5HHffifnD0FAAfn94bymrnunFHQzPF8/SSfBCcZwVPw8svJKYwmsRceGbjoAISt88s3avkMii3mVtyne6uzj1U4TDJayFA2VQ2LDcXKcJUsEf8ovDEjgHuhVKAgtrDk+jdxDdxP+kNKRcsHujOyJuqc078T1Yhxa4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=unist.ac.kr; spf=pass smtp.mailfrom=unist.ac.kr; dkim=pass (1024-bit key) header.d=unist.ac.kr header.i=@unist.ac.kr header.b=fAS0U3cB; arc=fail smtp.client-ip=40.107.42.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=unist.ac.kr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=unist.ac.kr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=unist.ac.kr header.i=@unist.ac.kr header.b="fAS0U3cB" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yUWR1v/wDrWmwgeEElszsorFnQEZW2J1UrcONARnGYaz8xcZw6Ql8odd3WVSfdVBYxMbnp1k+qR8AHMaM2BZT/PxDJY/mVi4OAo1Bb06GURzd7nXs3m8xribHhh62FkMN/7cxMNA0bq0GnZrR0S70bSuN0PuXZQHx8xvHj9AOvMVv1M8jtF5IDXCIMk0YkabLSz32LGXSDB0KDtyJNcizgYIqFeJjStw40URWA+PyiZsvmWpW8X8VbeLbqdiHnXE/hZguCsVsHUcm/27IcswrfiznOw9d7nhub1icQ27YnDIU+AEvqXZd9vrO9gOAS5qiWiJRLNFQo2o8eZbkP/Puw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2mrnDUvIRVIJUVVowJtn1GTLQS/fNeX6i/JswA0nb9o=; b=N0lKigKiAJzdf1Km9Dj2Ov+IMhHFk/xxTCVBnIpNp7jsu9eUACOYvppFy4UOcs10WD6xQTRwz2ZT/A5Jc0GfIvP3Y1dHqsJlEMBE9CuI4jeaKyF/cgkxLA7WpwsjwKZK6hJEvvsHCpxH3UHERwpaqHZTKH5Nqh5bIjBdmF+pIHMGS6F+xnYjWifi8y9fkkAc0aMNlA+9OXzfQGyHEbTYJh1H5UChs0IcketMk1AMdC+WiXWIoaZlc9YfDIHnIzyYOv7xRHXvkDhzifp1kcQ+gpPsIln6PkoVzmj+GtggnFp6uUPWWNrJLg79SVXlyTofoXMA+VpDCBf2nuldMSO6Dw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=unist.ac.kr; dmarc=pass action=none header.from=unist.ac.kr; dkim=pass header.d=unist.ac.kr; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unist.ac.kr; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2mrnDUvIRVIJUVVowJtn1GTLQS/fNeX6i/JswA0nb9o=; b=fAS0U3cBJmwxFInJ3PWoqT6OK8wnG2hHgweRrS+DDl82cVVtH8cu08ZA/YO5rG/KGxg3oy9+SNJUiJ1jTZGKePxPShIvCL4PXMUhNldszvqyBt1JYKeJDOeaoS61kvNTQ2Ur94870D6U5j5gBij33sTcuivf3cRxo28QuDhbyME= Received: from PU4P216MB2281.KORP216.PROD.OUTLOOK.COM (2603:1096:301:12b::12) by SL2P216MB2109.KORP216.PROD.OUTLOOK.COM (2603:1096:101:155::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.25; Fri, 1 Nov 2024 00:24:37 +0000 Received: from PU4P216MB2281.KORP216.PROD.OUTLOOK.COM ([fe80::40c8:79b6:9574:33f0]) by PU4P216MB2281.KORP216.PROD.OUTLOOK.COM ([fe80::40c8:79b6:9574:33f0%4]) with mapi id 15.20.8114.023; Fri, 1 Nov 2024 00:24:37 +0000 From: =?ks_c_5601-1987?b?KMfQu/0pIMDlwM6x1CAoxMTHu8XNsPjH0LD6KQ==?= To: "James.Bottomley@HansenPartnership.com" , "martin.petersen@oracle.com" CC: "njavali@marvell.com" , "GR-QLogic-Storage-Upstream@marvell.com" , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: [PATCH] qla2xxx: Fix START_SP_W_RETRIES returns positive EINVAL Thread-Topic: [PATCH] qla2xxx: Fix START_SP_W_RETRIES returns positive EINVAL Thread-Index: Adsr8+qItYqDP0lKRa+kdzC7A22B0g== Date: Fri, 1 Nov 2024 00:24:36 +0000 Message-ID: Accept-Language: ko-KR, en-US Content-Language: ko-KR X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=unist.ac.kr; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PU4P216MB2281:EE_|SL2P216MB2109:EE_ x-ms-office365-filtering-correlation-id: 254f0213-ebc4-49f5-aa90-08dcfa0b915e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|41320700013|366016|376014|38070700018; x-microsoft-antispam-message-info: =?ks_c_5601-1987?q?pHR8Ez1uigThWTQHzwhn4t?= =?ks_c_5601-1987?q?1EzhlS7UtE5bl55EmMcbWcvLwOteIr0ZoJqX2wqFjSNENNrN27L7CT7+?= =?ks_c_5601-1987?q?heNFG0rcJVDq7jG6UMhfEWWRMJalk8LQVQB0UPrPdhLz0uvRnBsqvRt/?= =?ks_c_5601-1987?q?wlOnGvm1XZl6bn7PT/hb+s08Tikzg7AWxcAgWaJnShA7Q7f6D3QVPjjH?= =?ks_c_5601-1987?q?HiBSm1EXdMpozquR9zIVB+kWFRiFA/lQligdbFaI80+hbD8w+o0LYMBx?= =?ks_c_5601-1987?q?vexjE4eq8HRwhC6zjrumNRJh4/vFN6GZQEBHm1mROsQXoC5dcu/gbRGm?= =?ks_c_5601-1987?q?zFoxom4sTAw3KzKCjuUwIP1fwGfQChrX0oXslqEt6PSCnomZyIm7+9Ha?= =?ks_c_5601-1987?q?cb++PcdA0q9boyEbfQL+b9GNM/Kg46jGIaW2HGG8K6QiW44EdIyMwnxQ?= =?ks_c_5601-1987?q?iQhf0GXKqVE48UcA50FY0iW/Bt2e7BEwpb7T4Q+YvI4A0Mj25jmFyPQ4?= =?ks_c_5601-1987?q?ATNHa9RZmHQ+ejM86z2U203gK9uxUKy3STD4TzZlAS7dzAMNmDygD5OZ?= =?ks_c_5601-1987?q?rQh+LnJ/+SJV8wS1cG2Zsa6Lr8dOw3jRwgVkiWPso5euBnWDT1ZC5BXN?= =?ks_c_5601-1987?q?7ngzROdAWqEOUx+XoPaddyi+G4Tb79MU+9L4RtEbpydI97j/dnwKk5h2?= =?ks_c_5601-1987?q?l5ZXTyF5e6LODeUEXqSX4ZzH5YGFKThqOcRBEzWyFGTtA3AShLJ3aaE/?= =?ks_c_5601-1987?q?LZ3LGc8lLr0IHhI+YnBn4Qm6YWc994k2QE9hi45RStNvPU14Ik1+buz7?= =?ks_c_5601-1987?q?JIdaJ3mt22eNmIz+gzhxCx/lPb7HRmWyLggeyOsTOQNp9spgFzUkP96X?= =?ks_c_5601-1987?q?aigkxqGmzJJCt2T8IW/NqjUTYlnegt6EFDGVc9JzaVa8BbTAYvuTjqSq?= =?ks_c_5601-1987?q?SqDFxY6JaVGjvtqPVQX+9UqH5DOMPtE12oPuQy5N1v8h52YEj3uCXNUV?= =?ks_c_5601-1987?q?ndddZta0IfS4iNd3uyW7DxTJ7A8zUrZwZtNdgi1EcLsbQSU8Z1f0VUZP?= =?ks_c_5601-1987?q?wZ0xkQs1TsaGk8b7aO0+NpMpX3DZ3hcmSwbMYCCzC4Mmxx7+iirSkPsH?= =?ks_c_5601-1987?q?djkrkhqc7L1Shf+e8qpa0Mf2on+MfiMgaM+GDDYlQetlc6amicKfDGNT?= =?ks_c_5601-1987?q?BTTlq7n00rRzaY+IXxZn/SFSmpaMr7QxNiCucPDKQm9+K8KRe0xW6k4c?= =?ks_c_5601-1987?q?n2vvmQB/IRN77xh63UkjzooozlwpyUwMpepmxhXexzFuRjhAWkOLZF9l?= =?ks_c_5601-1987?q?cK09sQK+j2i4CgGEa88Q/UXd9tBAA2eof9glVPU5A948oejlvf9l+/GT?= =?ks_c_5601-1987?q?rTRB+ttT6/MRC8Pi0Zi+MBFdWKHulwBLAMIcFrKMFy8rA3Ju8Q1chT9/?= =?ks_c_5601-1987?q?94gYYoe3f4y26VJrZbxdFNh8aLWVTM3cLYKQvEsuE1hQ2pwtu/jSSRjv?= =?ks_c_5601-1987?q?ygMSn+5vdskLb9DQrUJWE=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:ko; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PU4P216MB2281.KORP216.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(41320700013)(366016)(376014)(38070700018); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?ks_c_5601-1987?q?fb9roNREIwK9RoGE1SR?= =?ks_c_5601-1987?q?eeREUstOrjTbaXqXohUmZwhtrxwtf7UV4yO2iCEXjAqpxJlVdRdUwFoY?= =?ks_c_5601-1987?q?NVfwr/36j4Yh7dNcJKWCKqyZeDHH6+s5aDt0Q06CkMTKjT4q/s+KOMvW?= =?ks_c_5601-1987?q?Q8AqGZstdIy+Y9poOuXy/43wic/kdmWs2SQUvrM8wGP8p7Uq/1DS4H+7?= =?ks_c_5601-1987?q?GIQfIbmMDsGZpIL+DBktqzHdaHm9Mea0HKqGl/nPvOF2EgDaTkC5t6rG?= =?ks_c_5601-1987?q?JolKayzKp7KHXbngeDQWq7eZBpUHVBnq7VhozTG+cjDHU3/BH518gOcD?= =?ks_c_5601-1987?q?3/w/Dc6FkrvQ3J4/kMeJqo8s8Yc5aEpV2eMna/6U9YjMlwj7NxRGRgdX?= =?ks_c_5601-1987?q?sqvZKA8fompCjMcaQSE8GqrrsuvnizmLky/OLG2+5ZgJQTyp07r/0BIj?= =?ks_c_5601-1987?q?d3yvpmneM6nRqyl7+dy9r09cF2bxkJuBTmUkeei7tODiTEMJtL+DY9Tk?= =?ks_c_5601-1987?q?ONQGaqswbbWPpuolLi0Kmr+H7Ds+1Gi8CNkRgW3IP8890aJ0MCZxLwif?= =?ks_c_5601-1987?q?693xZUxRRrR08RdRW6WIQfSbD2rQxvtHXU4WY/dsLAscNol2j8NwZ7WI?= =?ks_c_5601-1987?q?BPom9Yy+B64ZofhsYfK2ve6TdQjGhP4p0UxTBTWFS4N+tmXfMWrWegPA?= =?ks_c_5601-1987?q?q44ialC9vTsNXq6y42tjluaOsUyYeUj8fVTzq3gwN82kT1Eb5Ry0f7Z8?= =?ks_c_5601-1987?q?rhtZHyO0mftHpD6+MtV85vVlWRxsm4bqBDMvUKhpDzwhmac/tH6U2aiP?= =?ks_c_5601-1987?q?faNLHYYN6Xc22HvVxf0qvdV8t8ZL93iXCEQh38xc4bvQjfCnTZbDoJDs?= =?ks_c_5601-1987?q?dGo6vVGUdpXHgvllRbH7X3VVJU/vCXuVCrvVFsZZsmFJkrCpqRGqavEf?= =?ks_c_5601-1987?q?n34YmM4bTFZrdeVF2uMlbEewwBSlR4iEhu2lPpNY2RJgNIDSFJ7yk1Bm?= =?ks_c_5601-1987?q?tzPb1wniyHJNjdjo3rwSW7nVLsdGf/JLBcBFMChCeyr/oV6IAxRbG8xg?= =?ks_c_5601-1987?q?Gzkt58FEgtHZ8ss2aKWoxusiW1Mex7B0aRRKSFoaQKqFA3NqQyZd0BaP?= =?ks_c_5601-1987?q?zCUzx5/7RU7by0q50lXf5jbsQPd5yESjI4vSvZm5PV++IY2C/EQAz08+?= =?ks_c_5601-1987?q?1ar+/phAbL/nGABK2Bu5+9U7RKSrCWDsmCFiOMtI9qNe6vh5i7tv57pQ?= =?ks_c_5601-1987?q?M0CDEenb5mWTDIHluqAhPgbFmJtmZafS8suvPMrBbAISi4NTaUdZ6OSR?= =?ks_c_5601-1987?q?1N+ttkyp2YnYnuDui+m9nT858GyXeTPD/gVEhqsXeQB4LphlGUPusgMP?= =?ks_c_5601-1987?q?X7W9zR6Q0MeRrGXcF9fV7AiC8XXx89R5V+ZzqjttJ2kGDGHtbb1wz7Qk?= =?ks_c_5601-1987?q?HuKJoiioJOLbSD7scK5HgkNsLWQYXZrtURltqBBxGIeU6GXTPl8L+bkK?= =?ks_c_5601-1987?q?jz+tOH0m4hn8i6Cj4CVUs1d5Ctni3bClgfjFeoGNY9Em/G81pYLfIs42?= =?ks_c_5601-1987?q?DWWLywA4z+E2J/BG4r2jZw3AWok0hsjNKbHJO4W+fifkD9Zyl5z4q+Ki?= =?ks_c_5601-1987?q?KZUaQYyDOBklVAr9mpNd8B5bytmWb9W6IbqpxlQ/0yZY1whfUn3QfgM7?= =?ks_c_5601-1987?q?qJ+oheloAmbfAWTDBs26ZB9rmD5OhOBWeU+fQI+Rcx6qphFSQMVTccaI?= =?ks_c_5601-1987?q?1ulUs+w8d6rVv?= Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-OriginatorOrg: unist.ac.kr X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PU4P216MB2281.KORP216.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 254f0213-ebc4-49f5-aa90-08dcfa0b915e X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Nov 2024 00:24:36.9668 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: e8715ec0-6179-432a-a864-54ea4008adc2 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pa85GlspiRRQ+0NWvvzGKkPLmbw7L5LbkrAKI5W5sWVHKoD968oO3RFLkdfSQYOsR+t8sjsLWViKi6tJk1bzeA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SL2P216MB2109 >From 6e78ff23b9f11f6896c09299e0a38b4443420eed Mon Sep 17 00:00:00 2001 From: Ingyu Jang Date: Fri, 1 Nov 2024 09:05:44 +0900 Subject: [PATCH] qla2xxx: Fix START_SP_W_RETRIES returns positive EINVAL The START_SP_W_RETRIES macro previously returned a positive EINVAL code when chip generation or login generation mismatches were detected, potentially leading to improper error handling in caller functions and creating security risks if the error state was misinterpreted. This patch updates the macro to return -EINVAL, aligning with kernel error handling conventions and mitigating unintended behavior in error handling. Signed-off-by: Ingyu Jang --- drivers/scsi/qla2xxx/qla_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index 31fc6a0eca3e..089d560e4114 100644 --- a/drivers/scsi/qla2xxx/qla_init.c +++ b/drivers/scsi/qla2xxx/qla_init.c @@ -2059,7 +2059,7 @@ static void qla_marker_sp_done(srb_t *sp, int res) int cnt = 5; \ do { \ if (_chip_gen != sp->vha->hw->chip_reset || _login_gen != sp->fcport->login_gen) {\ - _rval = EINVAL; \ + _rval = -EINVAL; \ break; \ } \ _rval = qla2x00_start_sp(_sp); \