From patchwork Tue Nov 5 13:03:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Burri X-Patchwork-Id: 841213 Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11011022.outbound.protection.outlook.com [52.101.70.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B2EA1AA785; Tue, 5 Nov 2024 13:09:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.70.22 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730812168; cv=fail; b=bldJDWz7cklEUv2T3rM2H/CAvepCbhEKx7Sb81ExoBCOKwebCFXAYS/TpugJRleGvZ203a+KG9qZV1aU1d+q047POm7k/x63LXS1tYCfL/tDVDcA37hRWvIuFjsYScpFglfm6dsDNacHRl8sEIOCSJI3FoPw1QjO/t4q+P2NXew= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730812168; c=relaxed/simple; bh=mxjAbWOV464PMVwuF6eGOPI6nsHK3o08Njk75jLKYJg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=aU8Z5R/FTpDJdVWcqHJAJgOL765+BReei3RjtM3Z+EgynvFvKi2JzzBHeD/8RRfFIeHXIEKr8VJKB4XuhoQ2YssMbqc0sudaExF5RyBc173ZUkHhXSFK3oR07bvYGh5dd/E3ovXr0LfmEVYFag9PAh//gPlTPP+DFAJyzWAvw/4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mt.com; spf=pass smtp.mailfrom=mt.com; dkim=pass (2048-bit key) header.d=mt.com header.i=@mt.com header.b=EPvSRdIt; arc=fail smtp.client-ip=52.101.70.22 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mt.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mt.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mt.com header.i=@mt.com header.b="EPvSRdIt" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lJNf53pV+RKzzTtuuFpDJiaaBlfZHqFHhmCKjMpGbGvB/7PPCsEph/MwOhFdpZTA5LzL/ZAgVdDom9V1ApSOiLYbFDu53Djex7BjZ7fNqvn8Ew5s9D1Wio5eXD8HiJBZ6GNT6k0zOkJn2DU+9ofnuDAXJF81HQvWEL7rC2uykeXxHFoNl8/Ce/AR0GTUpdhdU3RoCft87rjGEyHCKkNNJwVRoXlVmO+1c8UqHu0MSpfUKk7bR7tIGeuWj2LRF5GKKRkp9TT4ue3M4OidNfm0ONPZDOqvZlouQj57EFGJYePAWK6c8C+c62htu8MnGvSfWfYgre0tC5hks9DNx4izqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pSODWt0opjE9i0NHr7kGA6OkXCCnvHRAdLpOTN3muO0=; b=DdhaXoKDqSlF0AsTz2TfdttCOw8btm93NDIptIpJAESdFeh8OKOTEpbk9UfnviDVXIfyRr/MkSf0JHYGHCA3dZRsVJSm0OvmL+tWryetkI5ZJlNeI1MENOhgeNHEpdjprmklBkN5vh+5h1uyxolM2jRNfevg1zf2RzXJ2mg5O2gCXU3BPxOSB/s4quOQLF/playm/ZGZcbIvRBPGCcaWFoJo/JsKRAfPsc+6Pq5aAFDWMsYE9d4ppI6uhGAkclXH4l5qru2BepWZgqvYLQVQ9wHL9pdpZlmPTwI1ny6etTJfDil/tTOtJSUUq4ZE54ug5WnEPPcq83LsYjbeeG3ySg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mt.com; dmarc=pass action=none header.from=mt.com; dkim=pass header.d=mt.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mt.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pSODWt0opjE9i0NHr7kGA6OkXCCnvHRAdLpOTN3muO0=; b=EPvSRdItUERXILhH7AXN9jG+DikQ0OYY4veYeHlru4o6ERAU8J4Ws7EG69x091djK9X7MGiCN0Xl3rpwjVkfKGe38lLOqP/4uqEE3B3neBIn+FehWrhCjbjfO7iXbgjqspiYAJAp/td7sUv3zPt1FYGoobqbAEtoLjCaax+yMlqU1sqLsbkVsv7oSNxXAsIvgom1O067yd52f5JpsCN+B2cNdK81FVqfGvQIPXy2EE12Q4cOMFx+VuPOMV22uHkpsQHRsa1n63RKMKKJhrGG3na8ZIit/zY8itH4zeivuqVIgQerATeeUP+2Jbh3po+U4VYdrf8NovNKxRVroTevjQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mt.com; Received: from DBBPR03MB5399.eurprd03.prod.outlook.com (2603:10a6:10:f5::22) by GV2PR03MB9377.eurprd03.prod.outlook.com (2603:10a6:150:e0::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.30; Tue, 5 Nov 2024 13:09:22 +0000 Received: from DBBPR03MB5399.eurprd03.prod.outlook.com ([fe80::2fec:64f5:1893:f53a]) by DBBPR03MB5399.eurprd03.prod.outlook.com ([fe80::2fec:64f5:1893:f53a%4]) with mapi id 15.20.8114.028; Tue, 5 Nov 2024 13:09:22 +0000 From: Markus Burri To: linux-kernel@vger.kernel.org Cc: Markus Burri , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marek Vasut , linux-input@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v2 1/7] Input: matrix_keypad - use fsleep for variable delay duration Date: Tue, 5 Nov 2024 14:03:16 +0100 Message-Id: <20241105130322.213623-2-markus.burri@mt.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241105130322.213623-1-markus.burri@mt.com> References: <20241031063004.69956-1-markus.burri@mt.com> <20241105130322.213623-1-markus.burri@mt.com> X-ClientProxiedBy: ZRAP278CA0002.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:10::12) To DBBPR03MB5399.eurprd03.prod.outlook.com (2603:10a6:10:f5::22) Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DBBPR03MB5399:EE_|GV2PR03MB9377:EE_ X-MS-Office365-Filtering-Correlation-Id: 513e86e7-9bf9-405b-2b58-08dcfd9b1105 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|52116014|376014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: lj7bE3ywiYpfnp9c9jgWnbk+n95G4AYZPz5GN9wIj1z/IJ7M9CwaacNiSKozTRY4jiNVUpvcH1swi5hSUc6Di4qWhDmQYLmoBJCSwg1/qvWMB8LSW5uGPJfIVost2lkO10eEzSfJ2rqK6XXpKIuJ0MFrYSmWQWD5Jvzyt1Y8vhB13artWvLEh+BWJw4ogoVP+OzXfYXDQwaSZr/IN6Z/hXzjzCK89wQomKjMd8C69zRQAG+Etf7OlPIc/9mxzKNoOlP0LhI8iElPtHh4Dkmk1y9wYGn9a4o7TBpM8tAKUgP/aYb31aK+Bp6HqaRTEJZOPVAeSAvxpkaxnXQ88MrP/p4IBLrE/F5FEWdUQEj1/a19hqUAE8lEMk9Yk/mkjHLElHVCUFnicaOgu54VsvF9OLaNA3wSWR6ExWeekU5wrWQQexG14lbR0ORQdbV364gMpTU/ujNw7Ur1VnM8S3LBzGG2nt1Qsc3NuSupkcyEfC65+j0Q/Xsp9OpY/V8ABk4PW/zu2UDlnpl5Ar+PjqCE12NXZq2Tgy81eRcVOQ0275w5GhrDJE3bePm+qzXMeT0h6RW3ESyelMXKWm6S1CgT4Ui1rl91u0NozyDgs57nClbavY/RUwSX5fNR3aYukvOEq54EzHn4DbnhJncsTD0lFyA9e6skMIa4j59YmZdyiVCvQ8SWaPTrO4zxCiRijGkS2GxNXIfaO+bCoTTeHofwgdjQZ/aOyAmIk6fZwoVUGC3QqYNgURdhjI4BxK51Icxj+dXYjVIyKbKGFeQH6lmYurhTAlb2wGzA1953Xe8t7S/JgdhoT43uaQLUbmi+eRC+oMAslt88G0REdD0iJhk0/xKec/oGnm/atM+osmQXxsfDM5QmXvOD/ACNMghBYF5tEdTb4mgVkiboV1mk5vppuQEz2+VEmazfOkgaQY12INNukfvOl9w5g+b8lFOm0pr9PHFWUGGrL8ObBCuPsaoNlNdUwx+NAcvuxN9tDtJ2uUaZAaRvSZxJDz8dDuJbCOaaNeYwoVG16wdlE5CnWcHxu8jie5FfrHuFdOzewXoDd3Koos4F/mBTD4/uqCDb83oJlXOiwLiwMpRzMJvK9Iv0E1bVZ44zRjobxnfIJOMkcBSjNhEzQzs/J9pF3SYfq9rcfu+gyDTs8UF7C9Ex0TZ2K+103sR53BQSZ0be0armE1zyMi9yjM95Sp1YeUSazuru4k0DVEFv1z62s91gqvdl07kUkrtEBRlNpHvPpOCRGLUWlJAJT2U1h9et60xz26NQnhxTaey3YZqmDaG9QAFVCqVQuEjz4it+sSPiCCaILOefaF2Tl+EkeoInIiNnPHkhppE06F0iwCjXnTVzFYVBbiIvyvLqvuy0qtHYz/uc4kVSJX6RfXlxNvUcRfEeSdkG X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBPR03MB5399.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(52116014)(376014)(366016)(1800799024)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: OSR6aQrbDUsOotBX+ZXyqP+ORvAvQR9p+umx72VMSkkd81IpsecUM7jj2/8xpECLmiW4LTud5VCi9G7Flv8JDJm2eTjDtk4rYaQsax//MlV6NuhxQHtsyk5m9FkM+qGn9edDBl7E1siWL3tqOiEnxhDGBqeZqGOC8Ff+K8f5kT7xK1nplLDrcgBZ/WMpzJJFzSrx2HBVsCs+4KeJAk6af3O1Uv9lSoZRMB1vIsmRwyrdiKIcc8XDNlfp0f+qGk2RtAG5OX5NK5gg02jBW1VL+clR90fhJtMci25/BGlaJbudjunWJnTyPL1pzp4TqFPe1HzVBlWug5Wy0qfmvNB/8gyUtbi2Cb/vIJIFRrRGchS4ATsnuxgPeoTFNdMvSJ5KRGtuUU2/ph5pEEy5vKwyZokfn5FR+0EcxXLOTB1xEMIg+qLrgPDy+L+WxuL6EDna1yY+Ff5p2HME0bY1uXrRfZ0rGpW9hrTvULBhMKvBhvo5KUf7RvEZ8sOyTpnzLgdggLeDYnUURx19WSYJni3PhAd9dk4lzKvabsL6X2+cqXIs7EJgLbNRybarG0m9yAXIH2+cBho2zuo4guxyTwLpMNtX9mQ3PL4nHYGAeg4Kenc6ewVVN7dM86f46jMyskQrazrREFThTGmp47cd6cqZPSeoYYVwcg7aKqQ6DmQokv9w4glBN+b+mJkUQGaVo3FvLuJ6I803jXrU+CjOQsD4ACGmPw/MM++XSZAz7SReEAqHDgcoqOguy1t7oWREefh/w0FBCV8RLIXqB5pv1ZbMqM/Z2nAM09ec2AxADfcqrygo0Qo6wseVAxF49qmyKnDmpEuxEpzERQsFWtDKrc45WBpX+rI7PjXw3sdyHRi+T/LJRAgyOAxKqz48fFoLyCwVM+s/6/STd07ZfzRFsmkT7Kl/Qdm+yW7W4PXaYZFOFn1zjYeONYS8Bi8d9iyY3olQisv/inB5czIphh4bAm9RAJ8bVKqfyW1L5wF0yC8OHZ+bzZ96WARYwwnd4ToXEpEcwQ9jtkXf7HjQdkOQ4ODXdrWED+yZF8YnuOSVLzWgR7EIydmi3ZQYVMy5raA94O3Hw3Gw1422yj3GojgN0Q0sMxwz4e2ynbwAoQ56AfIiv/fnBZ42ZsKWyC8v+jb/qy/hiIBUWoLS+sFaX17yvS/RRVawkwGRpXNtAr7W4HjqMUzq6nxbFFUt6fcC8+91qMRTDem8s1Ho9zdrcHg0Dd5cLJiDJExY2sVmU2tWludNatJ0+PfSxUhnpJR/qNRIO3wCSzJJWcw73TrXJAFnblQ/By/RM3ILj2xoQZzEkm7QZdjlGVnufG2HTaSjIVyh6VmMRehL86q8olbOIpz28u21cYnH0os3xvz774p67o+p6/4BP1jPcVTfv5hAUR8spAXf7k+lbiN5ygc5AovU7F1RQBn/Dw30hOPEIGttcIfQ6On7/Lvkx2Ykw71vM2t/oXBLqkXFcWihlmGOasGt7aqU8zwKJxXk6Ide18Qz6gTe+sqlRVHMb/wZJ24fMl1UxOsseOW+vSYZP0hZ1izCAoij8NJw4H5s4aL7Ua74qqkNb2FeT2T1xAJFAeRK4t8S3P5j X-OriginatorOrg: mt.com X-MS-Exchange-CrossTenant-Network-Message-Id: 513e86e7-9bf9-405b-2b58-08dcfd9b1105 X-MS-Exchange-CrossTenant-AuthSource: DBBPR03MB5399.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Nov 2024 13:09:22.7760 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fb4c0aee-6cd2-482f-a1a5-717e7c02496b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xZfefxVp74OaI9Hq8HVUDEzJKQ5FC4ZKxga2i9/jKjwhkAtWi/BqWopZXmmPXjexMTpSU8ssTq7JAd9TdAvwZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR03MB9377 The delay is retrieved from a device-tree property, so the duration is variable. fsleep guesses the best delay function based on duration. Link: https://www.kernel.org/doc/html/latest/timers/timers-howto.html Signed-off-by: Markus Burri --- drivers/input/keyboard/matrix_keypad.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/keyboard/matrix_keypad.c b/drivers/input/keyboard/matrix_keypad.c index 3c38bae..9eb6808 100644 --- a/drivers/input/keyboard/matrix_keypad.c +++ b/drivers/input/keyboard/matrix_keypad.c @@ -69,7 +69,7 @@ static void activate_col(struct matrix_keypad *keypad, int col, bool on) __activate_col(keypad, col, on); if (on && keypad->col_scan_delay_us) - udelay(keypad->col_scan_delay_us); + fsleep(keypad->col_scan_delay_us); } static void activate_all_cols(struct matrix_keypad *keypad, bool on) From patchwork Tue Nov 5 13:03:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Burri X-Patchwork-Id: 840931 Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11012006.outbound.protection.outlook.com [52.101.66.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4287F1D79B7; Tue, 5 Nov 2024 13:09:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.66.6 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730812175; cv=fail; b=sW+BdSBxe6rOrO+BMULxCEr6bZooJ8/c65YchIrA8BH8IP5EVfEvE5Dg4U2wiowxi2v8DGcLamfXNnuaDSKBLwxespJqRx/btKvL+1YU5RneyF93st3s1xYj7M1sqDLZ+OHEZ/EEtQCbinui6N+1fMWJmYp886XdMMoXOJh6fBw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730812175; c=relaxed/simple; bh=ICb1ZJa6LdnXLJpcObLc7GnKhpTlymZSzdD9dyFNT2Q=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=Zkkhkaawfw/gH4OsPsXp+LhJm12VaGvb2SUYqklTtTZgKti9uD6oejaoObWAyCPmaWPJVsndBKXFraKjj3mrYLFvwEBWH7W5Oqh9Si0xtkEpnDrBtHAVF4JBACIKUziyI+lFX7FweCySdj821rDtRpk+9fLXf1VZKv0Wxg+DbHw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mt.com; spf=pass smtp.mailfrom=mt.com; dkim=pass (2048-bit key) header.d=mt.com header.i=@mt.com header.b=SjAA99lm; arc=fail smtp.client-ip=52.101.66.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mt.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mt.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mt.com header.i=@mt.com header.b="SjAA99lm" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qW1oZfMyzPP6OIm6UC/CEwXj7u06FVQrzA/FlYfDQNiiY+66SuKiR7eiJUOsgHnQ0+q4ieopujG7DfHDZL+7GEYCPENeOhtDc+cQPX6zfZMxPYILoIUkbglOxYOFBV3/A4+5OQarwHFt00X8kaBa3JKWUyDdwmZ6TBpQOwAMl9U3aRE6nCdECMFg68XclK1qtB79YUsCsTKs7cc1gaLK12aphNWZYXXbsxeeWLA8WoUzi/x3BV/VXss1jTHed7DeStjHbPPVXRMjyGISsjNnZJESigUwUvGTzTXwKX0DVawJ/HCL6kz7JTrYUE71Sl/qTz7QPkwV1KfSCDojbzfmHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=etH6092wcqik7oYjT3OW7PC/JboEFgrsdlXTFY9BDoE=; b=LaqEuzvbM1dSD7eg3VVZXfwDLAyJy6NezupPVcKEvow2llosVVevlUtL16YiBToX1w/suyssU7AJjHl/IpBnTXvzTgz81l8Gh/nvJODW1PhHR02NRK4naC3jmRmQ46arKguGpzKbX3JDzP2bza4zTqc8yO+OhsPwr/Fuu9HhcHgUd7jDhRuNGL9DjEh96rASd/YdXoIprw0KQP3HWXfYmkZbx32ZrOvZG575bUsb/eoYLiTpZXMtTyGtBJ/BN8wOjkZZW2eLgerU6Q0PoZAAPV0xBfO3iZTxhOOJ8W7RU33UV3vrhU26INRMDlHbhlAILPMh1/nkEG48SGrIY5nJdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mt.com; dmarc=pass action=none header.from=mt.com; dkim=pass header.d=mt.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mt.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=etH6092wcqik7oYjT3OW7PC/JboEFgrsdlXTFY9BDoE=; b=SjAA99lmrYftZIaIu7u07C/Fg0ARDdlO06GRD0MtZhVc9i9Wsta829X9ph3mCi9WrNqbK6FX6z/NqEnd8qJGnTCD0I2J3QICNH9/yB490wBBE69HbZZzcLSZlKTJJhdS8yuXs0zSwSuh/aDRoQvNRZtqxKmtK25pdorPOD/oUl+NFoNq8cNVjp/qrnYNNUyv+IFMxzIrjSr1eeFPSX2bjbDxFSPuP4qQG5GUhU6eUl/NC/ZWfb7f2bP7QGVkwdXG1fuJoPoJFQLvvhnf0C0X3eyDxzUOzjfiBckzLYeQ9uRa2nkNPawrPplNTZ9ckXAMnZqUT7i6UbM9ONcIdkWjkQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mt.com; Received: from DBBPR03MB5399.eurprd03.prod.outlook.com (2603:10a6:10:f5::22) by GV2PR03MB9377.eurprd03.prod.outlook.com (2603:10a6:150:e0::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.30; Tue, 5 Nov 2024 13:09:30 +0000 Received: from DBBPR03MB5399.eurprd03.prod.outlook.com ([fe80::2fec:64f5:1893:f53a]) by DBBPR03MB5399.eurprd03.prod.outlook.com ([fe80::2fec:64f5:1893:f53a%4]) with mapi id 15.20.8114.028; Tue, 5 Nov 2024 13:09:30 +0000 From: Markus Burri To: linux-kernel@vger.kernel.org Cc: Markus Burri , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marek Vasut , linux-input@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v2 2/7] Input: matrix_keypad - add function for reading row state Date: Tue, 5 Nov 2024 14:03:17 +0100 Message-Id: <20241105130322.213623-3-markus.burri@mt.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241105130322.213623-1-markus.burri@mt.com> References: <20241031063004.69956-1-markus.burri@mt.com> <20241105130322.213623-1-markus.burri@mt.com> X-ClientProxiedBy: ZR2P278CA0025.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:46::15) To DBBPR03MB5399.eurprd03.prod.outlook.com (2603:10a6:10:f5::22) Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DBBPR03MB5399:EE_|GV2PR03MB9377:EE_ X-MS-Office365-Filtering-Correlation-Id: 6dbf1fd2-040f-48ce-06fc-08dcfd9b15a4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|52116014|376014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: GO0Y55qAjdjVwwK6LmYuoVdgbAMCYUfUEOAU4gqc8Vb8Qpy0FVddwWtkJrOdZL1b5O8I6SVmD8BOAKu8ucHchm3UH6vfn6r10SUaD+3aC3sBChz8O9R5b/cpLeKiQIkFJCMuqomU+RkYnHsFr20hiNoGKs5FMCgN9DWEOFxG14WCaSvBlPNU5/1RHnRjgkFZaK9pWE+og3++YwS+s1/7PDLSCBzkRfZg57ci8vQxh4ydyyRCGancXzJ0adZWg92cKT3kOtzvJJh7iSnMQF2iMRNr9OcrbkPRahidfdq3OAXEAewegKYuBtigRipJCTVkRBZS67Tye0EiV9UgJ1g6dCHKV2cTzg7RqcCQnVykLeaZw6BiUXI4DaKZsE3bdOfPmuUuWMNwvqAbpmbpt9pJ9V1j1wR+VxfFDyNYfV3/5bBQhmYa6kBpy4SFFtJkSlpRiyE0B/1K50w+MplMYqLOvcFJ4YdKljVXxSyzeXpI7LAliTQVZ6v8RBQpMDUdjArb+S/WiDL5XI2+Fx3Lzr/Zy/1Ce5ZNamk2yNrB5KDi7+VmyJcLL61jU65wMk77xAsuDLmdzbm8ujSYXd5EqbN0tolxGV7Ku9PnEAsj+cqKFJfOpRghZwz6osRn+NFHcegKnMFKifNEP36D1dH1lEVd4qnmrAXJjcvFBNPVbKkpv/cnDeR89FdqioVcqtoW5mQq8RwzCUc2zXugkob6lSvrjnZANGYc5IjkLahQl7DXmwPp4pLdz5INAkfNAiSqXnktfvhsAGoNFKjs75PzQEzdK52nGPndWn1/5Mr5/RrGfQcOziSPYi6H84x/eL6CVrRIwH2BiQbAJBoedYZjAkATrDTvYlzWlmL2eLQq4PCv/ujin479apSbrXWyKgonJoRhicSZkV/H5tcmAcbDSlM6LxQL/HNQuzc4JtwJ7H5aXkfW3Qy7rYTG+UEBwA2fL9oOE5BkaUarF+yTdG0fGg2KYfsn6BygGsF1+vkwWy8ApmMrSSDHdgpL4kEB47dD/0wVl1qH5z+UUNyEKGM6fg0eZKcHpflxTZwHKbFcvBC+7vrDxdszmu3YVGdupZ+eGEGPIj27JgBzx12rKVYlKeoRCr0s0mIdIy+rlx8+sPyIzflUqI7a0WwPHjLnDmC1qve46BWzJ6ZRQqR9SxeeSXo6HIfyAOZGSZD3IupUeYQjQQC6dvSAVGq/9BBQW41P5EP9XDLajd+cF3qRZZ1p0SxK86x/U5Un9YfZLaNn2ku9Zvc9SJ9Ac7P57KsQ/xZLAR5wKmVbmozjfUshQKdgE8rKsU32QB8n9MfZxUThw4gKgmMZ29GGlBHQKUdfS7g/Ya84nJUKXURnX7c51q26dj3CMw4GYngAyz/pKl+CKc48VFc= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBPR03MB5399.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(52116014)(376014)(366016)(1800799024)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: /kgKYsL6l2c5HUZXSRmtF+HpiVBEp9h3ly3SDJQONQhbqeqmdnGIhJUMdWCddVpIUWyjoR0+rn6oK9e8uSzflorArr/WZeS3uxAD+Q3rZ7C1poCNnehwRteogwtc9L/rq/jTFmjP3kK1dz+Z7i1047vRUbypj/g89jAngt9Uzm4WfCygcQOfDlTf4CZruiuUq4ebmENGOByqPSLLdJd2worGm5tBJR5r07EaNmcYGDqXuCIMLKVI8TADUpEh1y/EvxmoagnWY87m0BTFD+26uuobRt0sENitI3yZYJ2ncPpUBcjoiv0FSMb0jkrIVX9Y1Rk3wV3rwiGBVFPvJPeTnvhhjLsOxicJvAShQrNDAG6zxBUtacIujw2pYITyI/Smd7ZiVhvjGbVH584VycuJ0ChdsMmaM4qjhtx50VQ7FHMfEP4MkGHpwhtwEivVS6fmfCSbp8ufuZuGcHIsNwhNLvUnzVOZD/t1RmNiG2+3Oa9diHiinR0P1IGqEUjzvxT3gckdtCkUPz0RKYhNyJeJW0DmJZsx/58MZLBVEn1/JZqh3+MAUJcx9otYWuP0OC1Z9v4zXJ2kSA+rHB1z8g789QpFT4eFhL7PugRVmnECuIZ9lXCKoIWK26EP/R4rQoWXKwGzEbQHJ6GtdWl5mZsCcao9CIX/xUkCzxZ1mcZ378yeI052D6P7o+UqK9EqJi7QZwigzOupwK6bzQX4jCV1aWWVUtpMJ/yiqthQ1JaX8AhdpOSNGejj6l1Yrp+0FgsTbLNRCPWm/tgXeFCsXC1KHIokYp708u06c+889wdkdeprrBq+ELr/1xpR2UBbmmuBuXLj7GXp4Kq0b0QQ5N2ktEU3ber75FLU7Uwb2A3eje09I8Da6znBrztnL3zj2VE4nyavdbqn3OnG9G/A738c6u14qk5oe3uxjzQhfVFburVeLzjiEQUR0sJN0aJoegItp/wgRbHS9KlKawYsFmD0y5a0CSEmkldYXIWjM1M9L5H+mNZymHWn1MKwfs5glR8ct6cMXiBQm4vUEg0S29qvxWjjh9G/vLaOuYyJcoxOQkj5bWuJz4MqUVBlneZy5mJMEBj3Fp2706lmbbW9wCAMm4wH4dR/F7Q/eBabooNYNkPNNz8FkME5CkzSDVQQjHRDcZ3euqjAx24jKHVNbumC0BIVCZXR6jTQGND9n0Wup5hQwa4GFcAMeWOf/dq0hdaM7eeLb0dIwy+Btg8GFcr6N4TnhKDino/1ViQg4Qa1Dz+jlHWxD4pHufSCRNmfLlTmKnSditRGkGm/1+ky7RABBmEfzQaI5h4NKttDxJyWrqShNHnDBkuuGrVhsYIMY0NuU1WsvH10fi23KQiDolMWyN4m4Ekiku8+It+iOtHnlUPLIp6f66juSPvNplRr5TIhdM67zxeSUBr+v+3VusFDM9dmg2ucAdRj3AaUXOD4sJRM2QKIFTcrrnp+z39jrlgp1UFpyOHNq/ux+F5cNggRpsoYGQMkavePOBQEURmfD/oMl57GuPE4ssG2MvViKyhDAbgxSAKx0ubN8o5rciFOE1F/5pCdHvgj19wcOaZdWB1STLvjwSfcQtOI1Ea022wk X-OriginatorOrg: mt.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6dbf1fd2-040f-48ce-06fc-08dcfd9b15a4 X-MS-Exchange-CrossTenant-AuthSource: DBBPR03MB5399.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Nov 2024 13:09:30.5316 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fb4c0aee-6cd2-482f-a1a5-717e7c02496b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fJa6gOjvWGSlnAj8WNcFy0uyN0TS4gB3TLW99KdlYvtSDgMvMl8JaUHDpLhqmJw3LHSTaFo2Y3CGRQGt04eTiw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR03MB9377 Move the evaluation of a row state into separate function. It will be also used by a change later in this series. Signed-off-by: Markus Burri --- drivers/input/keyboard/matrix_keypad.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/input/keyboard/matrix_keypad.c b/drivers/input/keyboard/matrix_keypad.c index 9eb6808..2818915 100644 --- a/drivers/input/keyboard/matrix_keypad.c +++ b/drivers/input/keyboard/matrix_keypad.c @@ -101,6 +101,16 @@ static void disable_row_irqs(struct matrix_keypad *keypad) disable_irq_nosync(keypad->row_irqs[i]); } +static uint32_t read_row_state(struct matrix_keypad *keypad) +{ + int row; + u32 row_state = 0; + + for (row = 0; row < keypad->num_row_gpios; row++) + row_state |= row_asserted(keypad, row) ? BIT(row) : 0; + return row_state; +} + /* * This gets the keys from keyboard and reports it to input subsystem */ @@ -126,9 +136,7 @@ static void matrix_keypad_scan(struct work_struct *work) activate_col(keypad, col, true); - for (row = 0; row < keypad->num_row_gpios; row++) - new_state[col] |= - row_asserted(keypad, row) ? BIT(row) : 0; + new_state[col] = read_row_state(keypad); activate_col(keypad, col, false); } From patchwork Tue Nov 5 13:03:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Burri X-Patchwork-Id: 841212 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2063.outbound.protection.outlook.com [40.107.21.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0638F1D5AD8; Tue, 5 Nov 2024 13:09:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.21.63 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730812188; cv=fail; b=r2CCT7gNyR4QacSWC6jmHiewE2PpDLVA9slfn6NXUXVW+dS3ZpzEL59dWCAnQRHmQqF/G6P9yDTgB0ckdV9iSJ5hy0w2AtDDXqisHvV9VvM6+FOtgDkpAv5gJdLCA/zfVh6o1knNMqu8o5gWfktbOMcO9CPpN1LX/AUPvdWPmjY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730812188; c=relaxed/simple; bh=D4Ak6jcKklaQNd9P5WXiyg8rFu4ecgUqmYcpaVN0Huk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=Xdma1ZEJ4mZh4OnmDDXBPc0RRTlmMdDk+gU0HyQXEaw0CmvPAJlMleg2F9MlVdwx3rJDFXGB/MgqF5/COxUZ6b0l8K0Df1ZrVX0GR9vuvBzcKq3Z0yQChFNcbjT+b7R/yPADSkULYlZcAXHoAm+7DYGqY2LhHUnzDwkfKma3F08= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mt.com; spf=pass smtp.mailfrom=mt.com; dkim=pass (2048-bit key) header.d=mt.com header.i=@mt.com header.b=ekINm43W; arc=fail smtp.client-ip=40.107.21.63 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mt.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mt.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mt.com header.i=@mt.com header.b="ekINm43W" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZetmmI0mMhShX8uuJRoOs/o2hPrpoRcCNwlCMCqeWtoHk4S7ecw1a06FML05h8fSUbzZlf2XqadpMxt8suB0lWc6u/Resw6JvQqczwHkEL748Am2ZIb2l5nJG2QUFiNLGw24ufCSMXj4gQYlA69oqMZOxBgIXsfyRhc3pDrTgkBZ5Q2UV2trWYOTHjWSmwiqmzYUJgevFcs7bwEFx2rZ11qHGDSPyg/SsAindhgBGen8Z/+hV/qm637dvIqwhKO3OXsa+WpQeS4UiMx6AAfgCWKJMw2ilJ0oEV2NfNvkRu6F88+pr1hb/kpPyV+qjg9xhU8CIWMrClnlK5jMiBFO1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iCaMny5/duH60dVwnVNbsO12yqHuLzmpEI39bRaipvU=; b=L5yo/un2sqeiQyB58iS0NFCfFY10kyzqFQcOijQGyUar0TG8jj0xk9516NSmracgoAO4cSqKolVFpDkLIsbEd/qXzKyC5pIJJKewGHU374VghIXY6dTcJC4rvvhq3PoKvkZQRRH0fRNd36kw6a2sRJB3fqrS9rD3YhBD348j3ZOUm4lYS552VfzLYYzp3FGRxdueXLE2XGFceWH/jE85Omqz1qWuyqv1yMwQpe8/pfVF4o0z+CWcfc92vgPhkxZcpRxU/7ggIflA8OCP1RTSBJtlCsEgnJcomZ27LG6YWtltG0v2Hq18IlnSa7E8e9gE0q5gt9t1i8POqueSXi33mw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mt.com; dmarc=pass action=none header.from=mt.com; dkim=pass header.d=mt.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mt.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iCaMny5/duH60dVwnVNbsO12yqHuLzmpEI39bRaipvU=; b=ekINm43WBa1RwJuOTWyr0qDyAqdmB+qe+qhOIUkoj029n3zFRIFfgCaS2WdyUCc2qmceygsaEk3TtRknSm14dIXiBVoqY0X/hD/0a21Bfo1xRiDC4qa3apKDsTnwBwP4hN/2Fvs35ivp/PKnhajzMtyxptL7DzdO0EbLlD3OaXSq1xKSOvMjD/+HrKJ+MvYlWKVJbPQbeA5Kx6MvUf7ur/JaWYniWTc7nJXT6Ppa+zDj4lgknOivacL0GlwWqAqKE9Vt/d5nxwBSHPjlMfsEJE9CorPrWED2kqlNa/sucoIGifPJwjaSts8byvZqbaAvnGuvd6mE+pShqqJ9ag5QiA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mt.com; Received: from DBBPR03MB5399.eurprd03.prod.outlook.com (2603:10a6:10:f5::22) by PAVPR03MB9211.eurprd03.prod.outlook.com (2603:10a6:102:325::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.18; Tue, 5 Nov 2024 13:09:38 +0000 Received: from DBBPR03MB5399.eurprd03.prod.outlook.com ([fe80::2fec:64f5:1893:f53a]) by DBBPR03MB5399.eurprd03.prod.outlook.com ([fe80::2fec:64f5:1893:f53a%4]) with mapi id 15.20.8114.028; Tue, 5 Nov 2024 13:09:38 +0000 From: Markus Burri To: linux-kernel@vger.kernel.org Cc: Markus Burri , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marek Vasut , linux-input@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v2 3/7] dt-bindings: input: matrix_keypad - convert to YAML Date: Tue, 5 Nov 2024 14:03:18 +0100 Message-Id: <20241105130322.213623-4-markus.burri@mt.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241105130322.213623-1-markus.burri@mt.com> References: <20241031063004.69956-1-markus.burri@mt.com> <20241105130322.213623-1-markus.burri@mt.com> X-ClientProxiedBy: ZR0P278CA0128.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:40::7) To DBBPR03MB5399.eurprd03.prod.outlook.com (2603:10a6:10:f5::22) Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DBBPR03MB5399:EE_|PAVPR03MB9211:EE_ X-MS-Office365-Filtering-Correlation-Id: 0bf6abc9-24d5-441c-1951-08dcfd9b1a2a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|366016|52116014|376014|38350700014; X-Microsoft-Antispam-Message-Info: hZ1AEuPr6Hu8icpMhRxk04KbfbU8gs6eb0VoBEwzCQ4N2rEWekfEY1mRR7L4eYBvlbb3Gpbp0fHTfOLn1qsqcsO4nzeeWdeKFTF8GLyZGRPxKsekDjPXe7xXGDwmjB6thynZzLvqs1qwatvByacPHLact1kMXQ0+TgkiiYFACf9pF1Wp/lldPk+A7wRiOlxaBgRRDWOxUbURYrDOPgRKTtVnEn7WNhgtn21Gfp91jAMeGyRi2dRLg9mG/mhuKmpN7WGqzhGZgrMppwUXx0ZR4KwxWLACU3y0Ki9+huLA/LwJ3p+xqRzvQM1tRyvgf0x5d+alhmW5j40m17sQN1qaFs67jLVmfqgKJ0CmsW7clS+6Y00x6Tqi/Bkjo3GXHtjBLovZenoAiYG8vO+et2OJb07Q5JdJQInTT1/n/XuQaPYh+FDO+BAeE3LXH3+3N51X6q9fydFjjNfaUB5bcYjt9bDqqAGMGAaTL+VPw5RF2mvBR3MYD7kcN0b4xQ11ngwQ55n3/Tp/3pRA+D4aY5lj5bqCo4DkOTnH532Kl4cVzb3rxdOUK2i8ksFYypdJkjd94y4/QcStU884hJpN/l01J2D/EdOBMBapy+XssHG/+bE5j1EkumWH7SVxo8VVUPDH0B6FlSYGUXirMLmQVP74vh5KG0SJU3Wd6BPegJAoKnbZsG/yxoa5eDVUjnHI7e45w0igXkDRXnGHF/lcwZxr1yXkZLy17jVC4U/eMNa+hzoFq30Tm0TsL1aKC9G+BTnbYdLrhb+cnBQHVfHPLm3024qZC8qx/aoeVM69zN/g03Gp+mQuUcHIo2FTXPh6PSlH5RYlLYv6ao/i5CJD0+WEcHZJ0s+INRom3OJpEwbLfK+aPCwpOOvRRv4JKa3micxgLYmg8jQVinBotcDRcgz3bjnJQyOng2WilvNcpxn8esQmIccHRl3YKH3dSh4YuxYPUyXEqv2MTf5x3olQS8xon2WJVTLHmGvlAAgRBrxp1bdG/O+jrPzXl/OaO5c5g6BnRyYmbiDbwHkLzaSLQtVXlDfd8GkMH3pIHpdn4BSNgmPgtxkS5xDkuDnBGwDiPtZ7EsCWX/n/U27WsSGMuIYn8FixvDSxKhYGDliMnyoWaFcVtNFhPo9ZqK+z7A87UqAqUC+f1bo0TaFFg26tPZXnMpffB4nP0LZIBvlXUXdateL0gqndQ5dGjHbuDN/jf8QrzaJNjzBor01AmKkcNMDZBcGgCgvUnxV7tvN4luVw9S35Lm7IwYWglt5jPECZ/zHdtAdW0owStJR2S4wvP1HjhcGylwGzLljutT9Hvf7fDAJ+8jUdR3B1MHfQmESDd2R2 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBPR03MB5399.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(52116014)(376014)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: iNEK+NVxJg0iAxIXB/9/XFLMnyLEHUdpei8lcfIjj9rVeXahDzIjmUaF6/MQgd/rL3syJI0ekk7qKGoXZRPdQMbtmS4MEuUcYHzKY4Qr0l3Jl2N+QTV6lReuwWIyhQIhsSp+10Mm06Jof0lx0MWJRNhGI+T6KOu8ImimjJgDrHPxJQ7xhqzZik7DnYEDCWPRs3mmEppivRPOYjaZY0Zr/lgzRWirXPMtZY70of1PXDKK11V3+o1uc68PUp/vhbHC2xiE4LASFDmlbn60aR/VZX5UM2tjSszB0twZBirpHdaI2XdSN3lJjn2mb/ZxoxkUX7wqDYa6l2AGVlp5jdGcnx+9GJAMEkblt/Vx+7DM1g/2mv59J+3XM2RQ1Dx93yqyebJ1mObXmZL59hKkyGvFsLJEwt1bhy/r39lJyB71CTu7oHwJtfxNOSJSWPME+Y0Aup7JxgKjB4OK/y7lsqNTlcFusnpEA7MT3LAGrFAdcUuZztNQVAXbKORqnRBaWHUwrNLfE95D41h6cGT//J1j0i+gUHUlgAb10W8hXYA692VhgZgmbkrueqhzJO9mjnpJKPAdm6+Mn7atZVaJFuW45zlr+9MuKfl69mSllrQB7hwyqaVMXbTcLyPPa145dX/rQb/6uPhTfCdwIYMq4BJCq8HnigsjNnUH2g2muzJR9iHU+PVY8VVYKH9UHsVFaMg+WE/ruqEl4u7AJ3EO3Nb+K4J1Cib3fEgC7j8QIf8H4NPWkPIMmlk2h85ClLeJbbUZDn2wVGzlCZRfp21hGY+RFUf0y/IVCt3IMAyuGZRoZmqPEya6vK2Vrwn+o5I4RIzUiWJq3zTKBr7gss9MC6JUv9VMW22cWJ28CtpuSL6m2cRCt4dC+Z7XfGaYuI6LhqNiVkLhVer7VRVf9dtrZ8pVc3Ok7ncXYShCAV+eV0yfwDM4OPxLzPNB6jWEWCOPjIwnhfZiEu92LBQg64IejyHzmHZxvmpQWdq1sveF0AI/LlcPJ4oMhyqX+fBKy6aswIs5Y71hYgbiBxLcW2bNFSPHOCkWp1Dmc+9ZMv+jKb4iSDvJjUULecGUExWdGypkRhD1I36hkQsoSkTyJWyjRepfC7a5LOOXe+U40mKTDNq7mfvnquh6uYg1HxPpdDvd3ncHdof9lUMJh3lAp5SBTzbE2QjE4UPvurObnOVgoOojcLWni0MNs/uPeaP44u+7+pu3EaM3k+UgFkWeE/uo+xfaXzXh5oLhw0hZOk0IPnjDaDtM/E1pUC4Mwjo0tAKBkq3jCWr2pJkDzUfJKwZwu2qaRivmwMVWn1kFExgL1I0r7vhJuubYAL7POdZqLwyiFCuV0CoXAmFVr+QwuQZrRDsd3csYNgnWSGKzT7SxWgqCOEpocdmBpu6Yd1FpO7Vb3fR+6EqlFTGx3M7R85umaJOaOQ2wPDfXbkvrfteKkaTlK4hoee9s4R5unGfKagpv1ujM8Kt9F8mjOykl412fphAyZefaQdeXagUjR8g2cKQoJTl9WVda3p101Eej9RhuQfBWSRB3gC8Tb5ySFpQ8z6gOjFZeDkWEHRnFsKA5VptUpv4UMFhmlbxW4Ek+pqHr+b9u X-OriginatorOrg: mt.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0bf6abc9-24d5-441c-1951-08dcfd9b1a2a X-MS-Exchange-CrossTenant-AuthSource: DBBPR03MB5399.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Nov 2024 13:09:38.1248 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fb4c0aee-6cd2-482f-a1a5-717e7c02496b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WFpkvq1GkEH9pq9XoR38j3leLnDI1qGE0M7/PoLXo6q0rTjK/foNsni4yDBq82iMXuDUzX84vYgxM1gJRK2lgQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR03MB9211 Convert the gpio-matrix-keypad bindings from text to DT schema. Signed-off-by: Markus Burri --- .../bindings/input/gpio-matrix-keypad.txt | 49 --------- .../bindings/input/gpio-matrix-keypad.yaml | 99 +++++++++++++++++++ 2 files changed, 99 insertions(+), 49 deletions(-) delete mode 100644 Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt create mode 100644 Documentation/devicetree/bindings/input/gpio-matrix-keypad.yaml diff --git a/Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt b/Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt deleted file mode 100644 index 570dc10..0000000 --- a/Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt +++ /dev/null @@ -1,49 +0,0 @@ -* GPIO driven matrix keypad device tree bindings - -GPIO driven matrix keypad is used to interface a SoC with a matrix keypad. -The matrix keypad supports multiple row and column lines, a key can be -placed at each intersection of a unique row and a unique column. The matrix -keypad can sense a key-press and key-release by means of GPIO lines and -report the event using GPIO interrupts to the cpu. - -Required Properties: -- compatible: Should be "gpio-matrix-keypad" -- row-gpios: List of gpios used as row lines. The gpio specifier - for this property depends on the gpio controller to - which these row lines are connected. -- col-gpios: List of gpios used as column lines. The gpio specifier - for this property depends on the gpio controller to - which these column lines are connected. -- linux,keymap: The definition can be found at - bindings/input/matrix-keymap.txt - -Optional Properties: -- linux,no-autorepeat: do no enable autorepeat feature. -- wakeup-source: use any event on keypad as wakeup event. - (Legacy property supported: "linux,wakeup") -- debounce-delay-ms: debounce interval in milliseconds -- col-scan-delay-us: delay, measured in microseconds, that is needed - before we can scan keypad after activating column gpio -- drive-inactive-cols: drive inactive columns during scan, - default is to turn inactive columns into inputs. - -Example: - matrix-keypad { - compatible = "gpio-matrix-keypad"; - debounce-delay-ms = <5>; - col-scan-delay-us = <2>; - - row-gpios = <&gpio2 25 0 - &gpio2 26 0 - &gpio2 27 0>; - - col-gpios = <&gpio2 21 0 - &gpio2 22 0>; - - linux,keymap = <0x0000008B - 0x0100009E - 0x02000069 - 0x0001006A - 0x0101001C - 0x0201006C>; - }; diff --git a/Documentation/devicetree/bindings/input/gpio-matrix-keypad.yaml b/Documentation/devicetree/bindings/input/gpio-matrix-keypad.yaml new file mode 100644 index 0000000..745652b --- /dev/null +++ b/Documentation/devicetree/bindings/input/gpio-matrix-keypad.yaml @@ -0,0 +1,99 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- + +$id: http://devicetree.org/schemas/input/gpio-matrix-keypad.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: GPIO matrix keypad + +description: | + GPIO driven matrix keypad is used to interface a SoC with a matrix keypad. + The matrix keypad supports multiple row and column lines, a key can be + placed at each intersection of a unique row and a unique column. The matrix + keypad can sense a key-press and key-release by means of GPIO lines and + report the event using GPIO interrupts to the cpu. + +maintainers: + - Marek Vasut + +properties: + compatible: + const: gpio-matrix-keypad + + row-gpios: + description: | + List of GPIOs used as row lines. The gpio specifier + for this property depends on the gpio controller to + which these row lines are connected. + + col-gpios: + description: | + List of GPIOs used as column lines. The gpio specifier + for this property depends on the gpio controller to + which these column lines are connected. + + linux,keymap: + $ref: /schemas/types.yaml#/definitions/uint32-array + description: | + An array of packed 1-cell entries containing the equivalent of row, + column and linux key-code. The 32-bit big endian cell is packed as: + row << 24 | column << 16 | key-code + + linux,no-autorepeat: + type: boolean + description: Do not enable autorepeat feature. + default: false + + wakeup-source: + description: | + Use any event on keypad as wakeup event. + (Legacy property supported: "linux,wakeup") + default: false + + debounce-delay-ms: + description: Debounce interval in milliseconds. + default: 0 + + col-scan-delay-us: + description: | + Delay, measured in microseconds, that is needed + before we can scan keypad after activating column gpio. + default: 0 + + drive-inactive-cols: + type: boolean + description: | + Drive inactive columns during scan, + default is to turn inactive columns into inputs. + default: false + +required: + - compatible + - row-gpios + - col-gpios + - linux,keymap + +additionalProperties: false + +examples: + - | + matrix-keypad { + compatible = "gpio-matrix-keypad"; + debounce-delay-ms = <5>; + col-scan-delay-us = <2>; + + row-gpios = <&gpio2 25 0 + &gpio2 26 0 + &gpio2 27 0>; + + col-gpios = <&gpio2 21 0 + &gpio2 22 0>; + + linux,keymap = <0x0000008B + 0x0100009E + 0x02000069 + 0x0001006A + 0x0101001C + 0x0201006C>; + }; From patchwork Tue Nov 5 13:03:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Burri X-Patchwork-Id: 840930 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2065.outbound.protection.outlook.com [40.107.105.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16BB31D6DA4; Tue, 5 Nov 2024 13:09:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.105.65 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730812192; cv=fail; b=t6yRbMOrybo8MtRDGyjSg98wzbEGBjOpxhgOBs+xA6Cjp8qIguKeLQBn6HEKr/gBHFFXPn2NbtEr5gOOoF/UqR8ubqRrahjaKxY4r8VTIZ/9DTQjT3KopyDBVoJ7q4cijIFuuUnTY672XKcZar2aif85yKmYc27q5/kc3fuUXuo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730812192; c=relaxed/simple; bh=ixd9vx7fGX6WhyKoIZR+/6JvIOeTDfPrEj60bDbhlBk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=sd37ZBuUiUSHAlQ10g0g2M6hwH+RwJg4xrCesolbO9J7WppDxD1Z9NZSdmMrYQVSR0FLWvkCn0i8XD9EHPyVxdXU3XlkdFvCTraKUhop3d96ZpLsy0+k52um7DgQNZh02urCO33mwwhr/Im+M9s2c2pHuz1VrFGskEHcgPkUNUg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mt.com; spf=pass smtp.mailfrom=mt.com; dkim=pass (2048-bit key) header.d=mt.com header.i=@mt.com header.b=hnfHMGQ4; arc=fail smtp.client-ip=40.107.105.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mt.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mt.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mt.com header.i=@mt.com header.b="hnfHMGQ4" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=S9hf0tqBE4AH8zigWWc7WdFjPMkzwCfvyjbNv+VPesGAObuOHXfZ5Pvwyl0mrej2xh9yYIgyknn/gBFs6XB1AE/t1Q98qN4TulUCJSe+AOzgDZHcF0xx5vBlJASD1Zrq/i2GZ31/UJU5+nRBWThwoQS3JOxQQykA1CGxILfNun9EbDu2PEsEYLtK73hBTs12koqmu65hueQPXeCO/BDRUOgVIqwEcojS+9JDhvcvO1uO2tFJZ36MU5zDfHwU2zqOfc2omk1BjTGu/8KCxFDYTvSOaCFtRVLgmPe5GQRxIOaFqLPL+BQEV4gvBt6IYdr3eVObPb45AMORctUT6Y5OGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YPpqvU/x1lLLzvA1jSXQ2tcMAGSm2VDvD1469TGC/pk=; b=Iv2eN3YBM+PL2itGkhasNKIdOWO81qWhKdd4qadJqQDq1m6p4WPuADY3C0fkuASX9sn486ITXglMGOuxB3vUG2YimRz/xAq3artWs4JkZTpo2mIMGaCFyTzgOlcBQ0qhgIvE4H3z9G29HuhDrPH4wt+sdUtoiJO7Za4/Xc/QAG4O1seZZOFcT9MCwvEvkwbhuSYT2NBBupLJrJ9rSezyJUmY8hJfud6kK6wkwvYi3tl3YH1xev0hGocYXZwqDuh4XUStPhtNTPYAftt5kbYBbAftB5lIn8Cz3KZY/JrqhMqHd/1hmjln9kLIhdBn2IppM7nLmoqzkirI72nhot9KqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mt.com; dmarc=pass action=none header.from=mt.com; dkim=pass header.d=mt.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mt.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YPpqvU/x1lLLzvA1jSXQ2tcMAGSm2VDvD1469TGC/pk=; b=hnfHMGQ4CExth4GxjNhXET24rY5FqBWbVV6qFrj014eG+IQTqH/OJsAsMk3DgjwXNFWd30b5g8fMQL2oEzWktIDLa4WFSfqUIQLNxgePsfjRFIivZ1wwcPyrJWCCeywEGs3iCgRl31TW5Tp/W8WhhKWU8Ig/iPEUVqjjXhN1KkCzD+0iURiMX2eInC2vlwRT3gkCXXKeFarpuCF/XoZAi16e50I1IcLNvLXKDTrkM4iV34Bbi8DXIXShkj9cvS00wp74+XEZJG4XMlu+73zHXJxh8arABpikfkNXwFp+4XaXyjJal63d6oF4adwAo2XMPtgUTEjR4TOWjrumMrR6Cg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mt.com; Received: from DBBPR03MB5399.eurprd03.prod.outlook.com (2603:10a6:10:f5::22) by AS8PR03MB8468.eurprd03.prod.outlook.com (2603:10a6:20b:52e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.30; Tue, 5 Nov 2024 13:09:47 +0000 Received: from DBBPR03MB5399.eurprd03.prod.outlook.com ([fe80::2fec:64f5:1893:f53a]) by DBBPR03MB5399.eurprd03.prod.outlook.com ([fe80::2fec:64f5:1893:f53a%4]) with mapi id 15.20.8114.028; Tue, 5 Nov 2024 13:09:47 +0000 From: Markus Burri To: linux-kernel@vger.kernel.org Cc: Markus Burri , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marek Vasut , linux-input@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v2 4/7] dt-bindings: input: matrix_keypad - add missing property Date: Tue, 5 Nov 2024 14:03:19 +0100 Message-Id: <20241105130322.213623-5-markus.burri@mt.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241105130322.213623-1-markus.burri@mt.com> References: <20241031063004.69956-1-markus.burri@mt.com> <20241105130322.213623-1-markus.burri@mt.com> X-ClientProxiedBy: ZR2P278CA0024.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:46::13) To DBBPR03MB5399.eurprd03.prod.outlook.com (2603:10a6:10:f5::22) Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DBBPR03MB5399:EE_|AS8PR03MB8468:EE_ X-MS-Office365-Filtering-Correlation-Id: 29257e80-f1e1-43df-b624-08dcfd9b1fa1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|52116014|376014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: vuhXbb9FcUhQE9Z1sAxC/HuzWULXfk+BkYkOsyXH4q52zZKM20mbOu7TtqT+EMPrISy3c0yge4uC1CPH7yqySS6u7I7xZ8ZLRyUkKeYLek+X1dyjLZUlu2lNAJ97PnXGFEn8pOu3s5fAVw2vD7lPv5iPRwfUh5l16+KrdUiu/UkmIkU1GoUyE2j7HvvFnG+CwD0s6aErX4P/Hvq+4eurADd00Aj5Vn8MrhB6oGIoCZNd+I1l1eT9KG1Mw5CbokBMubtRzPELWVKdhp/Y4wQYwG4VoqgUKMAA/olyIT9orlv2X74MDVoUQwnvLAAqVG3Vdasm0EYC9dkWeyzrFJD7pkVNBenYuQq3rYGz6dAD3mVMGj2QisWi8w+3DRr+poN252K0/bf6XIBOHpKEqDHkls6H/Ka1L6solatljXsGzGkFJXorc+Aer+rbkH09YpaBw6QKHjK0HNVaLPbIX0PWE4N6cUcxyOoPm3eelwni36h7a2g/OK9cJmhVqoIzbHb2z92W5XA89LlhBvPflfucIp5+Bem/EeckSCPADobxbPm2BWpIlRGg3ZA8qqcssthBkKKz4wVk4+VC4Xtw0LPbphdJ3bNzK3UfjGJsJaUe94Pz3I72dmda+vMrAgOBV3+kCK3Ir7NXWYWM4Z5B7cmWKktVKuqydYyu8ofCI8JG00Bin6GUJ6DVQ3/XW5tInXO07iCMCeOYQk7Q1yvyyA7ss1XO9VXJMIhzv35tbMnhBe38g8hvsCCG4RNRkK6cvaAA0bRht12aIU8nhYgtNzcBJF+twNEKf4aJPmJhAneazYul4/I0T/ee2bEr7yHb2sKB/lKEG1MyJKpsV1SfCGeIQRQCIcwTo9gP9HSmGuSK5Z1YgDFEID82p3FuFRU81V72hfLYfxijtxgmAki4H9WNmoQefESibVJ3D/nC6DWdXJf//TPiKlqmM253mmO6BHMF/atxBVj3JRi30/GReZJAbVUdwgjujgPsAzr695xML6BTo7GPetZYHACRm6LCbf6QHqmjswgnskPnXljwJDXOO8TTd1HwBx5IvvCw1ghJpaowgJpVeWx6LId3jplJdsojMN3WvpJwU9hPZyVgBErq9V+S6O+5fqaW9asWxqJ7A3QH/YDoX4ii0qM29z/g16FiRGmtGDVkTLwDMQDdnrGWm0EFRX36/bEa/D5mfFtm1gsxQwTnJcBu4DdxLap/r0P+j4+f+FNj37ozioFXnspcd+HESfPS+JwrAV4txlnFKFGunWkQcN8ULNVB5VAmU7zwW2ZEDthlPshegt3g/CwV+var5920wxOV11R9MqcoorltyV+bcpZIbyHxIXsuo3aM6SFUOgWmc+BqQq5poD2Ovzp8DRGkC3qlDYqEAYLM7dU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBPR03MB5399.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(52116014)(376014)(366016)(1800799024)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: E7OmlWhD5NBrdnwifp1b/Iirn0IHrXlwxnqoqWxRae0cJQon5YeEUTHAaZvkaIRTl9P8Wz0NF4kl1UAIMH3tAcdNqMHJpgpOc75C/PnOVlZo50XFegNS7+B7vpAbKDG+4F/vtyeYFOgJrbTR0Nk1SojZRSEXKCfSGJoJcWXV/TxzLyRxCztLcK7ls1f/jiOOi0CC11NP/lOz9RISfZAt6CxtQc7abRTT2pGuPQY+a7OJMdsnxSNxY4bw3UL1dpNa4JFAWum9yhtF5o1vBmLPtSPiLCevSrhPTVc3v0Qi9qN3/Wh5VHzO0Sc7uS+YQs9t8uMXp323U9DF5u4wEjB1B+YXGr8vlXCQ+bUP7xjegQhCuNaVw8+guE73dob8ByWn5BQqmNVehP8e29k+uyoOFow/Mkw6NO6XVKJrBVeB5ynsY5FI56FewHzNipozsu0/T/9YxdGZzL6tng34H+6+kOuwUqAcjo22xWW7wU0bdVn2fZiLihkIMg+og5+A07y6hv4qDB/9OCt2bNNFb30wWZ1h6C47fKTa0qQ+dbMDqAUJDZ/MwV16CDkGO4QfVp5Cin17sccJxCpemrqe9ZdlHQiKWYdM9q6JMthq/k4rN+BFAeZ4Fzz9k/bSDAPFjCSHgbfFN+gvPImiTS/LMMMJa/8/SftVXLm6VNss/PR+E3gMxQ7U5x5Pn47StKS689Kt0B4W0bHF1dOBtQyEA8tcaLza5MVvfSzhp/41OmjZSs1WCqhut1tcFQn4F1y3/l4KhHV+qxGIB9As/WySqXwNClv0CV4k3MUQQ1K96C69ddhBr076jI85r/xNqEqMcrh1e9fwNdfCkm5GaZ82u+5o6womu3kSSEWrHwdoaDsQ/ZXVDE3d2vB4dAUooFEYxqTNRN4hZ0YbTu0yW//Tg3TxpOYG0mM07h+Tg94uyflI5RH8joMdyoRmcqmeSbHlqHnDkDsUjcvMHNW3eRzyEexMfflHJ3duwUvRgN/BiXgkiVjFPQGJxdAmP0nvjmLp//egDDhZ/keY61j4q/+IuiGgmn95218mvgRCU8Oyo2Guf3P3Kt9N8sVNNmi4851mFg3hHojqkUKqeJ4aB6gCmqX4d2AIjCH44DXRSNxNgfXo2/8j0HChG6JDcw+C7eLuQnnzkUgITPJvf+dtK/zgTMMTOc8F9mQI7Uw7ItNg64XgYxs1pHKvvmxmzGsQdCdLROnglTISc6wTY0vkchlqge+IMf8Tyu4jl4uGtViHAsZZevrKY4Z3A69ERAgMuRuH0Txu6ug1tsHX7J4sMSEiSEaHoDW7ssE+Z8odE3jxKyGPNfpeVn3FfZb8hVvtgwdDAAeVvf/bKh7uXwlU6zO124Hz1fsbphk2D+TDPkgKdJo/v09XLusNA9N3wE0W/UA7R/TmJHFmWuP6pyJP2aLIIDQAjD1FSQH4lPdbYsRBYSwQ/slPzyeTWPFBx4pbWtyIhsg4qbgojCPNdDNy+WApDZQwpGkVW5wq3sAtGgyQjhCr8CjKzyut9yEaUHhmxiWNbU+KcRQ8pYo5nUe0XZAhEuer0us+BcWEq6QNrD+AqA4w8l/rhWph8HEuMYZHVtAkPo2e X-OriginatorOrg: mt.com X-MS-Exchange-CrossTenant-Network-Message-Id: 29257e80-f1e1-43df-b624-08dcfd9b1fa1 X-MS-Exchange-CrossTenant-AuthSource: DBBPR03MB5399.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Nov 2024 13:09:47.2917 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fb4c0aee-6cd2-482f-a1a5-717e7c02496b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cS5L4H3bCjXKcxn2b/i17KTgvL1Xf8H8lDfLBVGSCnsXkyaLq1MDymNHgxr7d9binsy/0YhxuZJSW/7M9hw4GQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB8468 Add missing property 'gpio-activelow' to DT schema. Signed-off-by: Markus Burri --- .../devicetree/bindings/input/gpio-matrix-keypad.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/input/gpio-matrix-keypad.yaml b/Documentation/devicetree/bindings/input/gpio-matrix-keypad.yaml index 745652b..9ea66b3 100644 --- a/Documentation/devicetree/bindings/input/gpio-matrix-keypad.yaml +++ b/Documentation/devicetree/bindings/input/gpio-matrix-keypad.yaml @@ -51,6 +51,11 @@ properties: (Legacy property supported: "linux,wakeup") default: false + gpio-activelow: + type: boolean + description: The GPIOs are low active. + default: false + debounce-delay-ms: description: Debounce interval in milliseconds. default: 0 From patchwork Tue Nov 5 13:03:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Burri X-Patchwork-Id: 841211 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2065.outbound.protection.outlook.com [40.107.103.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5523E1D6DBB; Tue, 5 Nov 2024 13:09:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.103.65 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730812200; cv=fail; b=j7je/Zoe8Y8THOJuUctJEAqYNvXvNiC1cUlzHKtaIa+U5Ai14/pRyK+4U/yOUkA1w1nsW1z78r/xQskwg/xlpL6je04syPJJQwjEZXHwakF52qj02iiKgiQihr1HswUYSIb6jDuXjR5ADdbAtaHXSTlmIAKAxoWNFglKCg0DPwk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730812200; c=relaxed/simple; bh=hsFSlzAzK+Y37KCdiE2V4fS/I8LptbZxhm8jRpUkzwc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=hrME/Y0iV/hR4QH+QQjYsyjHbsofSTUw6skjxpaEJm95tWprAIlYVeC56Uu+D/qNnKGChzn1vaDSVly22sssI2nM/3KUccoKMk8E5hsMlyGX3i/lNHAO8Erm8YxCD6WwWwfpuAtGCzE9ruakZuiQcrHeiWxsn2kMuoXFM+B69vc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mt.com; spf=pass smtp.mailfrom=mt.com; dkim=pass (2048-bit key) header.d=mt.com header.i=@mt.com header.b=naHcsTpe; arc=fail smtp.client-ip=40.107.103.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mt.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mt.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mt.com header.i=@mt.com header.b="naHcsTpe" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JE7MGMI2qGz4OzZkwU8RQqmetnBz2HMBaumudkwMsJJQm9557zfAPppYcz+J9VLjGIbmMjhWssYhVTJfezpnTDUw6hujhm5HSHc85AXrho90zdzb069TOLlKtFwhbwG7NKmHqFKEnrgODoAtjaR3cA7FXVnh74J5yDK3wYr7kB+4nEI1EJPuCaTVCfw8nA8m92cggvnOpZFvQICh1DvJLaaaUQGe3vt2/vv5671yDyFHoey2nkSdUe4FgFkf847o1nZTXg5pCSj2KVCzvX0H3OO2wGcqS41+/4FwUn/0TNRaAXr4uqQdAifVhfbOBVzkS4nFrOJoet2s37BmkRULXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Dm8kwbF8ujtQJ3hks0GazQ+RZH0hifiVhqY1o/rXA5A=; b=QNUsLf/WQwrrR8OQA9M14ZW1WGSdPoGOopQ6tQCv6h6zx7KW+7E23747DSIwtODE1zFfs9LnfT0J9PI5O5/nCE5g6CuM9uVNkXeSlmipXKyN47AOeiU1Qgj64cnAyg0UQ7V/tJKlXuetZ93w4vTl9L0tcDDit4Bu+1SFrWowbGio9+iR9Av/Gnqb0Nrw26X/qpLkPbR7xGIGCwTBx+dJMlMSaezUF7hPq9Md2mSh49RnoQ4+gde9SLc+cyWR5xcGTeK+QoyOvbYCVvgmraUYDNW8ohF9ZaXLgTWIrgsBb5jfHLC2Fnixz2oXtIqBm7VZwW78qdANPeyFX1V2K2/T2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mt.com; dmarc=pass action=none header.from=mt.com; dkim=pass header.d=mt.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mt.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dm8kwbF8ujtQJ3hks0GazQ+RZH0hifiVhqY1o/rXA5A=; b=naHcsTpesVl9udWq9u4nmGIk3d4vYyke4u7zEiVx/qmsy7AqGwXqvvfWuWiMVWbLrlf0wEafe6fCtX6J0F9k/xUUZDd6Gx/W+O4vOxaYsYBPTHpeBABuL8Ykxkv3sthdXV35ahoJSLHhsweVKCYD1/IUA2GUcpkM6slk3y+jxkTRFv0vV9C+/UnoxR+ITNUbEUbZQ5UgFDnDwzyxq2CNmkEBRErQQKQNHWVhexEKGzJfXh5zx71bGtL+f0wlv2Vu5LzD3coGv0XeU2umep4/HDtQztK2uCQ9d2Mm37+FkOuFxoZDBKfvH7Ud/MiIh7LYNHvBJDkI3ep9F1TRQ3h8+A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mt.com; Received: from DBBPR03MB5399.eurprd03.prod.outlook.com (2603:10a6:10:f5::22) by AS8PR03MB8468.eurprd03.prod.outlook.com (2603:10a6:20b:52e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.30; Tue, 5 Nov 2024 13:09:55 +0000 Received: from DBBPR03MB5399.eurprd03.prod.outlook.com ([fe80::2fec:64f5:1893:f53a]) by DBBPR03MB5399.eurprd03.prod.outlook.com ([fe80::2fec:64f5:1893:f53a%4]) with mapi id 15.20.8114.028; Tue, 5 Nov 2024 13:09:55 +0000 From: Markus Burri To: linux-kernel@vger.kernel.org Cc: Markus Burri , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marek Vasut , linux-input@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v2 5/7] dt-bindings: input: matrix_keypad - add settle time after enable all columns Date: Tue, 5 Nov 2024 14:03:20 +0100 Message-Id: <20241105130322.213623-6-markus.burri@mt.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241105130322.213623-1-markus.burri@mt.com> References: <20241031063004.69956-1-markus.burri@mt.com> <20241105130322.213623-1-markus.burri@mt.com> X-ClientProxiedBy: ZR2P278CA0026.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:46::9) To DBBPR03MB5399.eurprd03.prod.outlook.com (2603:10a6:10:f5::22) Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DBBPR03MB5399:EE_|AS8PR03MB8468:EE_ X-MS-Office365-Filtering-Correlation-Id: 9e3436e5-e6b6-4a87-d3fc-08dcfd9b243a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|52116014|376014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: O7/9GSXv7S8EgawARv5K/31nigflX/j+ni7QIP8jNUMbltu2/Wkxra0A5FqwYNYeVGPlFD9MmBAIRDVmhkhI2oSUeGLOevvpMPzwT7tlP1viO/Hf4dhPsNOdetJ6+XTuHsGEIzQ5DBWVMYzyIQp2f5ESgXSWLKAc001VV3iFcDnUQHqdf+qiDUt/m7v7DUTVaCGfjQWBEgTXllhtJu6Xlk9hk17CEpccTkihaoOC/d12BBYHVygILKo30ep5kRiOrfKYnbqIMdo2p5Fpd9apEJICG20RBz+9NRVVcrvU3HvgyJ/LtxXaQEApeeFYGUAhkjICaabJEPLs2AQhzUVR+GRu31wvc85OZ0Eb+5exyMixE3UxUhQKxkNdEqoWK2ebSPNXOraThU1Ge3TsxlG0+z7N1caSbH5tatSrCNwd6GDMQFgxvBhMQEfkqD3zXvs+/iavkG48wmoWz91xzTIAzWgPdX5hTyD6WyQnXCJGEP/3b9xF4X0ZGe5hFqxlHw8+YLqXVuzMsf/9iTNku7lm6cviSQUZzWLUgjWOU2mWTCuHR+gbFAuOtQ/d1ZaMbc6VBxVlgSCWnrAq3C/MoWoPEs/zBedF8XuR4S1Bv4OgC+4w0SM2eEULT4uc3vf3F7UsIiadAThwssdFaE3xFsuYp0BgnPh+/4Lqt+2Yh3dUOFebh1xS2LVuY5MpClqV9TpxG/fRKcQ9rCM4yVDTUrE/PKtnLLX0sLWMRr+Mp1802RlBURSImyITJZOnknKBPzyYPl7clGz0ifgym0w6Ei0LLjUYxjEUR3bcOgLtDgfHPg7vUbs/DEHjRnAdu/YqkafXr9RuugFLuGURoVN7w39mdwIvqusUDTRg1qKmqsqV0U+KoUjK7m73/Exej/wKauwY+Ncl8P+ScEOW5pkYXXqeFJvcEiRFEpsQp1dpdLKh40lc5NAyx64tj2UaeO9n/taVB2SQT+dh36f/s0f3fucU7d/UH1mZ9hps+PpiaRrrJsCzKhFQWUHvSosl4x/QTdUIjOrCoR2ciOABZ7f6SE2qpjaOPuiOzhcwYolmljRNGHWctCvEEmXvsYgEVDqmu3O8rKb1X9xRVA/Koso1U0spEVwD/W17Ptecj1OdTAmlIGgrFWUod5H5/Fn90uNvQn1DvM5A6DXcIYMYPEg6jI9Gy1JYH8Z2nS+0KE4MjbUCZTxbcJoeXc6KfZpqXUd7OdGDzWiACqrCZRZRX3FiRRGNFh4Dn4u8Pk3WieH8yT96XVdZ7+dARzbPheS4OliriC2CjYtvSPdspyTyg44jp5ODaef4I+njU4QdsayzBuVcqu3mt5ZPsoK/04G+kLdlWx/+xKiKLT5aM5UhLh4TIynrPQJZoQueygxdK0i3OO/4GIQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBPR03MB5399.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(52116014)(376014)(366016)(1800799024)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 9XUeBsYL+3d/NNs/TcP75HYTVbfKQD/Cb7Ef0d5zNWlP9q2by7owQXpni+e5ryeA5FDmpkgsc6Eh5JNPiW5UN3DK+BKcKxwjbEuZKiZy2PoKMyklf19ZzPhDtryQJQxK0a0edFDbJQze5IffjOz8YxpPly5OGR5Q0Fa+JKAyJzWH5T56ne/1UXlAFz6IW1ljeugKDUROKYFYrcIdX4iwihPLnDrYUYEL0ci+ywbF6JgauywiKD8oX9ll4SSFnO0ygVQelZtI/4lZHGJiXNoTNuiaZAOEYsdwDNTiH4R/JmZLaGEmMQJHma4dGZwXJIzDNo+0VNFteR708sGvnyyZoL/Awgp6yogIjxmNLOG1VmTTx5P4bSE9C9tPGaH/a4B6je4RdvNQjNH6eT1o3h8O3b1wsI2GjD8H9Yu86oeTPYNjRGQjD/by/5Iljonge4v+VZjy7d04NCZs1AMuhHSp75KHwJ7RV1Sv5esJ+XkLk21MZEKPZZTrViZOg9nhLS0GEgRS8085F3hezyrJASVgsxWLICSUfYKct/e9nLSNFHJnZQa/a6dGVOF7ZnBOv1QCxHyEnF4E3Yl6IzKGlzQT/AdM9mWBUVh1wM6PPgnaEzgGcMwMtio3xn8KSyuhf9jvZQoTX+X0wwjI/MyAKenp8wKnAf9/K5U/eSt+r+SH/0dHaW8f95JO9hR5RqJZQaTTeXCc/a3DL7IFgK/q3hz4MQwcpC74urnaW/GL7tqxDIiXOswfVbW8M2LNUFZ2uf9BydvQHwep6NiwWK0SFOteuF0mF4ieW8V0Fggdc0o9o2DIDy/YKftb0iKdEnqhBsGgGZP7FC7XV5SvLYIQV2KMpZKXo2ldk62BhhRhIvZeUMSbawr6A0h3sENDB9p2R3uJWQNOJgGAaQOkuVIDVeEPmR5BmFict+C8UqA5viuLGAG54HC+LTSGm2o0xSnuGljP8aMpUharOF0VUfkN195YPqdHwA894RZXiotl1FJN/0eEYC1rIZJByYeG0oeB40sEUIMasUxWAaeUoi0/2CwMKa1+L9eWMzOR4zU2PjnntYnEaf0u1t+IKA92o8cne8GiP7suupyU54ymzObQkmaL/afczWit20j5OuLDMgPxUtE3iEcIu2oBvUaeBtAOy4x/KaL3ZLfF4bAmY/qYCi5HbpcswXPAgjL5sUzLmZsCIrOJJ1BYxby4G1HO4zX4WAptuzdCDPqQ2Q2KW4Wexc9YxP67/2/5N9/XbnBZM1ZkvcDM3X/AH0L9al+W/EcQ1cdbmhxLig9E2kfOC7w80P+PFaPjEJ2jpK7KLV6shO0RXFM/3xxOj+L72QZDuUVd2BZClXvq6cpO7T3mh4PgyAAvCaFM6kh+/Gyv/LDRuH/AcXM28cl9AX9ivKPc6IfkTs+OGPsBdBS9i0opGz6fXlJC/GEPTfnjyGzbZFI4P9gflDRIs5TeQ/UVprX6ilTmGZ3zQ4w5ddNKUwYy5l5TbNAyUlrfsksHp653MdE/S7oVP/viqrp0qUzr4QFCYrb+WFOmqQ3Aqy2Te3kM07yI1SWMOMBg6JgNxtdo8rEJs/CR9GeVf6U7ZbHxUx6IJ6WKbc5s X-OriginatorOrg: mt.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e3436e5-e6b6-4a87-d3fc-08dcfd9b243a X-MS-Exchange-CrossTenant-AuthSource: DBBPR03MB5399.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Nov 2024 13:09:55.0102 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fb4c0aee-6cd2-482f-a1a5-717e7c02496b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8jb3KIH/IxdRUIq/TNWiBdONbdWXMhKqgMHbkJoqY+jgJpVDtuCW+UOE5X3Jl0FHp4olIrT84rH17I2UuZUT/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB8468 matrix_keypad with high capacity need a longer settle time after enable all columns. Add optional property to specify the settle time Signed-off-by: Markus Burri --- .../devicetree/bindings/input/gpio-matrix-keypad.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/input/gpio-matrix-keypad.yaml b/Documentation/devicetree/bindings/input/gpio-matrix-keypad.yaml index 9ea66b3..0ce89a6 100644 --- a/Documentation/devicetree/bindings/input/gpio-matrix-keypad.yaml +++ b/Documentation/devicetree/bindings/input/gpio-matrix-keypad.yaml @@ -66,6 +66,12 @@ properties: before we can scan keypad after activating column gpio. default: 0 + all-cols-on-delay-us: + description: | + Delay, measured in microseconds, that is needed + after activating all column gpios. + default: 0 + drive-inactive-cols: type: boolean description: | From patchwork Tue Nov 5 13:03:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Burri X-Patchwork-Id: 840929 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2072.outbound.protection.outlook.com [40.107.103.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 135461D79B0; Tue, 5 Nov 2024 13:10:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.103.72 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730812207; cv=fail; b=mjSGcwlhqIO6FQzgssKAPjVmvaxywOlgKfmnMu1KpE0pPDrDnojuD33DIQ2xjau4iZWGfEypFk+0rvmw+NL5hkPn3UlLYTkHbM+U9ycmupypf/5Ii80aCsHe0FdtVV9QbLyf87Bssm7kpqgcGBhvvtSRctNSNhrJVsn6pCbjXAI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730812207; c=relaxed/simple; bh=HlA+B+bMsb9X0pL9Dak2Dxl2qB3bCXfHS/XszhS7Ci0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=udJXnk1r7l9sdbXxD8qnUjHV+14nVvAJ/EHwBxnf6cIaHHr02YqplCf5iDD/zUYIiwygazgE5KSzPHdHDsZ1CySTXgI2RVJ/al+XOCUCnXg68AhYhCnAz/PvvjrhbFiVV4fiZhXBII3cAzbiMKUmusbpldqzMLoFHOQYCfRUR00= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mt.com; spf=pass smtp.mailfrom=mt.com; dkim=pass (2048-bit key) header.d=mt.com header.i=@mt.com header.b=kj45WaKO; arc=fail smtp.client-ip=40.107.103.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mt.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mt.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mt.com header.i=@mt.com header.b="kj45WaKO" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gKh5fpaS8Vd6DuSkIsGPNu/E8sK+YfUXdYrl6xUL82PLM786eUfLxB67gAPs79SzX8rfDLtbTU11kLtrJvBvh8qvvYyssKT1+3q8+1h15bm+Y7mEqqo6mAqU+926/1LBnaR6xOERsdJHAVZ/dV9y7eYcmQAg8apFJ6IA6HbH+uPrHlzcpr4IaCHs1a0CskwB1F5LLgR4iS/QYHsrZV0zhREeaolxT6+8hMvZQjXCnu55L2vYQEQxMRMX47hHcxZKBJ7lLyHXLOjoG2fxa+cC3T5+rqVaxj+PUSmIGOOsPXcdgd1j17OTbaTo8v2zgUca5vAzM/tM9H1yy3B1jm4GZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pjVRoRtT0K+lfU7ftwM2WRCcaz5bD9GFkcczj9oJ8Rc=; b=MyVS22HBnaB0V/xzbpGBajWD6BBGkqIsf6z8vSzs8s8dk0CDMzHjeEUKJpgCkbb9uoN0QQ6QJ133OdBFB8KuVIcOgSfKGnu39V2jkqVkJNuCYQXAxPz+OLnC+a2sAAS3OsC4yzfSZyesZltyfgJjuMbvRRpvaRnkM+J4v+VDolRMPDT5X4tfwHJ6xqHgGT2iZAvmJ/YQZsrEx4zr5Lf3XzCymVQl4z9+bHWfV/Fm34o2EaU8YRJfrzIMbmtugkn4ZZA3wh7PPI1gkQV0tRGJHS1Eepqg3L9a8P4yR/YOyAdUaF2l6pU1HT9IqikAav6IEn9eG/ZrRAMKXLo3NGYLBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mt.com; dmarc=pass action=none header.from=mt.com; dkim=pass header.d=mt.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mt.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pjVRoRtT0K+lfU7ftwM2WRCcaz5bD9GFkcczj9oJ8Rc=; b=kj45WaKOsaiN737thigcQNeAT1bV8gBTQRKcQrqxk7RQkcy55vKxZgiPdlnHTNzkpf0cLdkBsNvGje1LyUHOPT/Twn/wq1KfFxnQaZDWYUwovXnAfqUiEv0scnxOCBdGkLH7ucVBEmpwJOeZVhan494TdbeQvdyYPVWv0De51ZpmmkGpz2D3m3u4XuCEMwKiFEMVJ986F8BcdHBi9ExExDNzC+1vha6s9Wkk4GZjufmqAdGvUZmp5AOoqvBTNuoZfaHDi7GgUTV0xbQEutGRzR8HOY0M3thakngyfQ6F8a9+ISKdtgtZW3qm0rA239/9ZgaEIylSe4PeSKtKQFAwRQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mt.com; Received: from DBBPR03MB5399.eurprd03.prod.outlook.com (2603:10a6:10:f5::22) by AS8PR03MB8468.eurprd03.prod.outlook.com (2603:10a6:20b:52e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.30; Tue, 5 Nov 2024 13:10:02 +0000 Received: from DBBPR03MB5399.eurprd03.prod.outlook.com ([fe80::2fec:64f5:1893:f53a]) by DBBPR03MB5399.eurprd03.prod.outlook.com ([fe80::2fec:64f5:1893:f53a%4]) with mapi id 15.20.8114.028; Tue, 5 Nov 2024 13:10:02 +0000 From: Markus Burri To: linux-kernel@vger.kernel.org Cc: Markus Burri , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marek Vasut , linux-input@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v2 6/7] Input: matrix_keypad - add settle time after enable all columns Date: Tue, 5 Nov 2024 14:03:21 +0100 Message-Id: <20241105130322.213623-7-markus.burri@mt.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241105130322.213623-1-markus.burri@mt.com> References: <20241031063004.69956-1-markus.burri@mt.com> <20241105130322.213623-1-markus.burri@mt.com> X-ClientProxiedBy: ZR0P278CA0080.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:22::13) To DBBPR03MB5399.eurprd03.prod.outlook.com (2603:10a6:10:f5::22) Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DBBPR03MB5399:EE_|AS8PR03MB8468:EE_ X-MS-Office365-Filtering-Correlation-Id: 29950423-6a00-47ef-81d2-08dcfd9b28dc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|52116014|376014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: PKrdB1iU6bYgq0rUjXR0uZQ6LZd16onv6+JC5zZCCJMglIqtol9aT4LIcWN9P5aiBny9ABx0MQjFsx4KD16L+B1Vk58eDcCPcAChM0R4DP6/sij67/tMw2tfTsYThr3nq3iqiiSZzaLv4fg7JJCEaDmthYT5LowOCk67mtUrYAnNl70karm7p2CwLGgyLCssDQaoGvPrhsvkIYMw8VacjFOthl7t9dmRvQRHC+npsKWADeP48YLMiUv+66hWitXzrOcF4xPZiYr35vDhdjBe7nbaokxhcVr0bE81R7zlVlEfqzoJSlEtLqBoJtnMsYkN8CTUqhxc6/9w8QS8CDp1TXSjuYhXBpfoaF/IJ/nyp29lP4NHdq3j74r8TljSuS/dRa15/jB873xmKKs8usdEyy3jnQZSDfGC6zdEba/Wy+HoKuJO4ETTidCXI4P9gJyycF0uZjx9TkmnjrYZ254iDzTNy5t09x46uhhBUCYUvDBzWlYIHp8gRX919uwsTWh6zotidC4pV3VYk/teHgJTwOoryA/10OflQF2+XGZvvNNRlwllmg/WYGKpBef47a+MXVznj+R5LDQ9bpZNUgUYRiv0NsAkpXsm8GgIY3BtT/XURGcxV50pEk1jZdbxe3gE81h+3nB5pPAuJZn4bE7uph5Cw7vcxy56IiK9scpf+pmknivqQpl2uzaiAJez77icuN4UTYkdTb+x1CCHKSm/YN1rgCke/HzoQ7axBtrx0L2473mFZPJUVoBExWceDd3Jdz6uOwQLwPv7hnhyEJxeyVMAgxsO4qNuMNQBhA8XtZ84PpoRwe97PptZaAdbqr0u6+IgnUCKjJ2C1Up8kcobTGhbQtLirouPMj+oTuJ1BSdGwP3CyhTsiAel+o0NiqxwzCBcHPDIfELdME+GsD5CCxdvOr5SsEve/hqybKbB70gOf2OFEIGhIYvYdi8+QH+8zbRvoE1OcweC8hF4OEzIzgrSLUrZ6lkcuWKWyF+YklCSvE+FklTm+nKUzXMFYxwzDOp96Ue8NmhNZZxXqyCb/GC5+WkTSnHYQOedZDuo3rqCcOdJV/ZNoh2TwE045HWG8EJDeEl3gTGsOF7Ba51jeJ9tFNZtw+Axmgbq/oriVu3F93rAFxpJ+vgzEm7BTjdPvGqtexKnskE878dSZnd1xW+UfJASZ8ZfZhORmzTo7yLxsF/DHw2WydfdSXbHEZwUij19UHlUCXtJELiOv14qnjj9fL5CFijjgD7D0EN7IgdC2nK8rnna9rspwroukd9ubFC+jLqscoBYM2UhiWpfaGTpzN1fOP/a4smV0RTKYPZ330P4teITc7bfD8CAfmgSssnpiQN92JW/QjOeMxKQiHqiJrSZPv/iICTHCJhHxag= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBPR03MB5399.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(52116014)(376014)(366016)(1800799024)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: pfhU8neAxY65EyQktgnD4m0Vy71WCnt3t/oU6aaa3txHwiau1NZcosHp2Nen1diuaMB2bjcc4ADVEFRLu+kPV++Wey+S8EO2DZr1pjcKA14miy7XnmulIqa5CfiOg4wCPexLA7Bt5hjC6zWtXvBHp+f3eFwnCjNWYEutXCF1XnPF8IOedHAjZjS5qLOOyBkVyI3pL9++ObbzDpySE1wL51UJ7lqUkBkx6ggxbw58rEcBG0D0eer1YmYmCbit6VcCERnsaBUt7aMcvVPqNTbbs4KGNYXpwRczBn2RON6hPaHVz7k4Cz4lT0Z8nbcgcWYJcCQL8+OtSDDZx92cM7ESgPOTmiqg4YGsOi/GI9ahEm4nuLx6JEyNt+gOQmRak7KaoQiaC1eqKXKhxrzgs8zUGawZPls89TiViYZ3tqG0VgwMDtbcyxQmwkb8x7y9uMyTBOh+KNPNKk3SL1pPhsZ3JYD4KnUK4qxLZgU8sQQlnHLoiXHDgxL0JVjZp02QRxqiuS36PYfYw5J9z+Vue49VDhUwbqjDbgOnkTnGXWU/gsE/wErrr/JXZoPWrID4nrpUUyRo5RYEbSELgtPg39T0UXaXaRfSXGJacoCrW+y6y/LspGo1xMgTFWDxaS2xDtCD8WP7wTu9zlkztC9TuypFDeWq48YDue6Y7ypt2XeAwCgxNtRSFmrgw/5Ggc7tqhpIeWjH466ZzgijsSdUlx4R3tEMSTcm06HfRyBaR3zbBWOcJ5LAjV1icCkHnP+MPK+qfIPNdBHvDk2KT1QwDpRZH7I6XxP1POgfdpn8oqpaR1+B3sYoW8NMNovsrj2WqdPsLrXo23XQPH4SS2rI5N03wCTTabQ7Xt3AAi3vF1sW558U4qN7R7ga0FoKGaRpXdKHUslu+VVuPDYTlECJUV5Zsjs2GGqo5RJzjOX/i8cu7yvEqrUz0BwNnTtHQzpiyz3GeV+D2jHbxoGM8L2+hP7saFxYmv0B8sZel05H9dA3X4ybmolCk+i/Rk4YbMYiMtnfmBZJKveaQJNfT4bQXRFTZaFiBxkpc8Z3PrnWCt94ESmizXkV3ur5dwBrnqXPFF298ZJZRBAYgbw9nrCNnxQ8dtUsPnycEQAJTQ/5OwxSjlpR+x/md5aLDLRNo58D3m1usn2Pu0YFfRFuxt/6w+nhEs+jSGyY4dykET7mmZ8/BfPXpEZIKIj+MtmJCvOAS78RdbQrJCErvm13yQ9q6dXihgNkC4/GaNHDveDlKSvNh4hODTQ8QAPRCZcm/PdBmdoN88JGIaNUQZ06Uitr9ntlNvRY+Dlm5Vw7PzbnHK5SCl1s2GD2alGm7Ok3L/hMv3R40e6yTTEjOPtVsdUAVuTVb6KAZMSgQ+RhA62xQY7jRcnsHoyeU4CY079JY9s8K0wnx0pb1+95cqbmtFta1ZREqQ/3sHqtGQo4eJ3tEtu8xhqG+ZKIiMcEZTtvqk62fQQYa2qoWKlvdHyCIPq8XYMX6ZpE/PUEWSIQhyVRhZo4Usx+0MBLGalKOMXhMDRzB/yVbknWa+ZOqrxam6XfQf99Yl76y7JnnKMDR77CWntBtO7n4rDgY4bLQskNlrF8scFT X-OriginatorOrg: mt.com X-MS-Exchange-CrossTenant-Network-Message-Id: 29950423-6a00-47ef-81d2-08dcfd9b28dc X-MS-Exchange-CrossTenant-AuthSource: DBBPR03MB5399.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Nov 2024 13:10:02.7876 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fb4c0aee-6cd2-482f-a1a5-717e7c02496b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xHoQzObrLOJFGrLUP9NQBFhsOLx0SB8P/aLqgvwDjZ7DHBPNXvJribDQRXJ/qolezGUPklh7ju9tQVOSE+07sg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB8468 Matrix_keypad with high capacity need a longer settle time after enable all columns and re-enabling interrupts. This to give time stable the system and not generate interrupts. Add a new optional device-tree property to configure the time before enabling interrupts after disable all columns. The default is no delay. Signed-off-by: Markus Burri --- drivers/input/keyboard/matrix_keypad.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/input/keyboard/matrix_keypad.c b/drivers/input/keyboard/matrix_keypad.c index 2818915..46873b8 100644 --- a/drivers/input/keyboard/matrix_keypad.c +++ b/drivers/input/keyboard/matrix_keypad.c @@ -27,6 +27,7 @@ struct matrix_keypad { unsigned int row_shift; unsigned int col_scan_delay_us; + unsigned int all_cols_on_delay_us; /* key debounce interval in milli-second */ unsigned int debounce_ms; bool drive_inactive_cols; @@ -78,6 +79,9 @@ static void activate_all_cols(struct matrix_keypad *keypad, bool on) for (col = 0; col < keypad->num_col_gpios; col++) __activate_col(keypad, col, on); + + if (on && keypad->all_cols_on_delay_us) + fsleep(keypad->all_cols_on_delay_us); } static bool row_asserted(struct matrix_keypad *keypad, int row) @@ -403,6 +407,8 @@ static int matrix_keypad_probe(struct platform_device *pdev) &keypad->debounce_ms); device_property_read_u32(&pdev->dev, "col-scan-delay-us", &keypad->col_scan_delay_us); + device_property_read_u32(&pdev->dev, "all-cols-on-delay-us", + &keypad->all_cols_on_delay_us); err = matrix_keypad_init_gpio(pdev, keypad); if (err) From patchwork Tue Nov 5 13:03:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Burri X-Patchwork-Id: 841210 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2050.outbound.protection.outlook.com [40.107.103.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 880B81D63E8; Tue, 5 Nov 2024 13:10:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.103.50 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730812218; cv=fail; b=jc+S4Pz9ITe7zyOFnviLBWHY8KoAOWJBg5kJLAkyO2wcZLrsCYpXWhNTcvEBq9e3RRMQBQCz1Khca98zrGmyT/Wlz6xTUb8d2EI2KXlw0W150TRpd+90k9o0ExbhrfnfGwm0UuM7xyP4SA/JualR0QnJ+Uw5rszY1rAePKu9yDA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730812218; c=relaxed/simple; bh=dS0EPvrlKmpyuZD95c7kn0I5Qj6u/+zLwSdT5HG9YeQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=CrFX//01NrERX2bWhM2mM3doawcuWblWfgdO8I7ZCq7jzioifXoiAhvwPGDS0SU9CYAUbGrf/V59jyZcJOJqnFOQKQOE2B/hGkuGDF6pY2GOcR7qDLVyR3/+lBAHtUecdCs0PkjYCCeCYR7aBV6GdX5sT3+W9BjSznqRndADhgQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mt.com; spf=pass smtp.mailfrom=mt.com; dkim=pass (2048-bit key) header.d=mt.com header.i=@mt.com header.b=lDKFoiNv; arc=fail smtp.client-ip=40.107.103.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mt.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mt.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mt.com header.i=@mt.com header.b="lDKFoiNv" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jgGDEym0MEHaplfMVRhs3kQjEJIsqC5jdEhyXAxv3iSCzHErUcm3aeDGTyYxW65cpGCvazmqCaawrlyT2CjhBnvJOuZ+f7T3s6BRAnebgKZsmIzb8z4k/jQlKk6n3LlH+PM8x1dMXvXMyWpCnl0s1Y4fOhMEE47YLejE0DSgGPZE9LrELbqKK3coHgdGLYSO612hgwhJiLMQJBeJzDirj2LNoU3UT5okGlLct+PGjhNkOAzLNO40syUFqMUY03iqXx59hNt60zS4G/X7GM4Rf5YhbbUulJKwSk4O/q9yS3U+RA8RvGZfY2wdpe37mB9u1djpxD4Sii6zlxu9A7s00w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3cQ0GlwCUa1Pyu+/7QMAItAu+fgfDkTFS0ht19uK+x8=; b=yuwLboJ9/r5AgNvIH85z6NGMeoduEzI9Er//1GUm3qNdPoj2dCO8j0akcPZtXDFEo23ecy7Tv8kGk7vPOuIzI+3bYkV5qYmVZ7poxEYJ2w77JYS2iWCqpKNXKCmFtU8QZa4aaYU8fM1y9pEkFIYZgyLN4pund4xeCNPY9h4ZpDkd/Onx8Y8Bd4eXxLEzMTCFhrNAdKOcJcHu7BoyE1IelwGo6yRVasboIKLrV6pU3f67D6GUfbOVcP9RRkhmlng/IuU0WBamD/WecI9zBHFDdAoErPtFirYyO7Iz60M+PFtaXV8ep4u2MkfeWazeMwC3W+LyfZOstguHEvLWEkMj5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mt.com; dmarc=pass action=none header.from=mt.com; dkim=pass header.d=mt.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mt.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3cQ0GlwCUa1Pyu+/7QMAItAu+fgfDkTFS0ht19uK+x8=; b=lDKFoiNv0NA6R+UuI3BiwUR+mawvnsglrlp67vxd7jJYzCFgD7ZJllUl4Dnsn9kD7QluGGEMHwlYLEFD7MTAcyBXbcDU3MJDQir9lISoRe0gZ6YORRs2GyYsHCYYZxa5iuGQuI5MMCZMYUsSn4eOwS9Ebb04rXlSYEBAHEvcoEo+2gCspM+nrxsdCD7MRsc4lxUWcTi9dZL0RmU0hSjutGX/xZffe28uhJ/ueGGYXvtExSsAkxvqpS05Y3RwtdmmKAWAjC3VE48EZYaGhHTTPIInmpwK+xQhbo6BtyCWEW9sm5u4GTpuxSsgbsGIwX4Z/TCEKL/6uwtcX4qyrtrmCQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mt.com; Received: from DBBPR03MB5399.eurprd03.prod.outlook.com (2603:10a6:10:f5::22) by AS8PR03MB8468.eurprd03.prod.outlook.com (2603:10a6:20b:52e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.30; Tue, 5 Nov 2024 13:10:13 +0000 Received: from DBBPR03MB5399.eurprd03.prod.outlook.com ([fe80::2fec:64f5:1893:f53a]) by DBBPR03MB5399.eurprd03.prod.outlook.com ([fe80::2fec:64f5:1893:f53a%4]) with mapi id 15.20.8114.028; Tue, 5 Nov 2024 13:10:13 +0000 From: Markus Burri To: linux-kernel@vger.kernel.org Cc: Markus Burri , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marek Vasut , linux-input@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v2 7/7] Input: matrix_keypad - detect change during scan Date: Tue, 5 Nov 2024 14:03:22 +0100 Message-Id: <20241105130322.213623-8-markus.burri@mt.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241105130322.213623-1-markus.burri@mt.com> References: <20241031063004.69956-1-markus.burri@mt.com> <20241105130322.213623-1-markus.burri@mt.com> X-ClientProxiedBy: ZR0P278CA0022.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1c::9) To DBBPR03MB5399.eurprd03.prod.outlook.com (2603:10a6:10:f5::22) Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DBBPR03MB5399:EE_|AS8PR03MB8468:EE_ X-MS-Office365-Filtering-Correlation-Id: 23c0c6e7-0da2-4827-810a-08dcfd9b2f24 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|52116014|376014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: ICH0sQE0BQikQxcLfG8p2KOAlbwGHwlukeWbfXR4K5Q0AgDDPnzLhPgInUptV/eDOOO4IkU9b/ysP3H2K3EVVoCA9papheNK23PH6OkWhr+TArEq5e3dQKDPS2W1Y5Im6c+9g63mcl6sFUQS/mC2TsZezel6iZIHge2OmDMx6FcEsMVhyPHGTi8q1hfK6S0SM9sObtIz+BYp+oAHTWAtZ42Hft5l8aEGlHOR5u6tuzhXDBECNVe+J/13LKfEQRuyzWoo+jEmJ4jsvbLb25P/rYILLSCSylgeplhlqpNBaWfwh/8M/tRICIgPd2ZRXKr/3+1Nm2IQaUwB/JowTMmObnrf+ripNl5/AErTXOW4XEkfXYDmyVKHtrZx3pQDfjzfiiKgH44PUxGpo2F0dydPyehfuUMROCNsiwHZdTdaWb72wYh/LkLwG3exNc2HkfYNppodAX/K5vJCx+sUnnRDRRT4rZYSXtLKWH8J0KCUX9T8B6cNYqzrOBhfQQQnJCdBaw6/SVZi4qJDk1pJ7JMBbC8VBh6pWNUu8cwzjJGB0uRL+1eAYIAnJ1n/iYlcpbIO81lVPToKaII9DSiBPEgfFFTY+hxnDrg/Gols0XL9p7YuamUoUJVO7puvbPWVVKQgbwtzY0R07KO0S6gC0Pn8zs2FWanL++bSSaGnkqFQaeA1stZYU3l9Sg6unKZBtGupuQ3i5hqVxILzAC9PGIEulAqw8cKpmxPtUKnfA3bmFVnZ66H+W2AEBIAxxfezxCRQKocR3cAMKY6noSwdDxKUJfF+A6vV29nubcxAl9I9ViN+vT9mNtYXL3gC+ciPoAIiDqGhHw5dru4PzWQJG76S1WeRB2a6vuOzjMiZkoKdCgjZ03lXtXyR2YZWlV0pLYNm9rM27Vr6ObuQPFCdiwUHtbV7+8CuXpUgfJVNIP144yqW6nCqAp2jRz5KCqZcTY2Fz9GGA9S0TGQj3QmvXq4tvKJQtQmJRN4s2g1/V0qVr+ZY5R/nbvPcS5SK4LjCOi8ispofGLpEIqHaFeKy+SPGqVQwhYHhBPGaRBkJnoeMZQzxWh0y3OGX3fY6SejuYdK2J7RqRpbNbN1/nz2sNPPpPg8UwjmMNzmLp+Jri0ebbZxAt6VkxaCgxG6T7RPkBFd5Xb9XsJ/yHv8g+rGmRNJixIpRTqbGydp3KkVg/V1nXDbeOiqap2ndi88HLow1jg1E9RDJsIe045ozHHZT28Jf599JgNW3Y7rAncu2Z2lM5OiA6Z/TlKdJg7OMLfVOfLHFC5U20X9R0o+tO8hprzpYbd2hKekX3GrkN3hVzb/pMdJkT+oDtJ2v+BCxc3ii1WshewIMZpSliEqH+dsoBAANsDD/i9Y/Naw2w5Osw8zPN5w= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBPR03MB5399.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(52116014)(376014)(366016)(1800799024)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: IaQAChT+oA8TNfz1Hkka4TrIvRwb0G4Ni3ely7A6puEv0e6v3G3aPdWUlb+UEropenZjXWUZ1DZGtj5xlxi8/ozTdj2+ZCYsmg8Isva/a1JNp85yPOSxScWFJmE4jd2VXLZORJqkG3OGO9R/jEScn9wmjvolPD3Hijyb5+AdUD2MjZFTDDHD9RrXFjLNoMZyU3h8PxbCajsvWsVn7oMi9Kbm7gAiCO1SmFPQx7M55XrAx3GT6KPduy1o1xZ/rtB8CPpnvWFRhbm3LHXTLf6qQonRmbx8YGze8r8BHLf21aepskB4TLJNTVKJOj5vX5bguDh9N4StWa4ltoORd82Cbjsl/qNbfm+AB4Wofqd8YJbd8OEiQbLtkI/aUnvBuL1Fxkb4CYg92+BAu1S8mnjmNd/49BgzEq0WoXmhPk7Vz3iueOP8W4W7NMJpo0hc5WaOd6L6IPU9gJeiNjQ6Gks61py8IupWvns62bQksTy/+5WjV6I758wIRToH6FBYzie5h6OLuQVJRMUbD2q7STfhkciVrxJ+IwbLgvSc9hc8uXPlelBk4kaUAg63dJ/9Tzhsqwre0Oa0Y2vnTMgjAe/1QFzfYFdgiDZrmBKDvCrYHpX7mQ/3gdT+JrsYbh2tKVQtiCq/YoNQ6bJuwEbvi73SDHWkyOvvArHRJgX8Z6fRDf9XIduu2NtXGL0z6dw/dktgdgbiuONddAJCGOrDtFJakX7HJoKN00RyUsSEX9+HP3tzu5WWO5LoVGuG/r/ugaog5OUNWeNFScMTqswqp/Svkxba7uBqUSWOtOZH61Rst2KILBxn1niZBPrqjTN4E9GfC0HGTpR8wH556pX352c4nYX0CO035dkHhn2hPj4beLJLFhA8AU8Wyyx+pImn3bBpLp9SnTKPb5G3hu9WjflQHV7QdTC/BAVi/seW9yaBuwScR7fINL/qRew3gfLmx0UXEcoMfahnCOLCXjIDqpO5RhdhqgSk/FiKED32gkZGSiK+yowYqGZRkDtdVM88xVZbMbqJv3Q0/ypyWSkimgUcn9SLZJycKC7/QEVlmGjvi7wT0Izs7fWvMngqc7sV0kDC5Q8VQeiKbj1+5onzc5bNa3ygK/YLNlAAqhaJItR6/9DwZhkWpnki6V1vVbL/R3qqFND2TOJ73ocb+dDTblew5yQbV2fXFKygcuCPQ4yyL4fC34AzdbPxeThXBXnS12svVp+TKh7HdHWV9IhdH82+mVHDty+capFV/2wGNDGxF44s58uaX67pmXd6+tSqlQXIYZ2pZ8cdsn/ESh9QrMXE5aaGj+Hg1PDn7ERTfQp+p0CGbjMgxowCWnzbbdZJqSwKIa+OsJmJgJz3Z/9PkVYl/wDrB8QSIun6MWovT/aS6Bti8/7lQTRkBvGJ1gkE9MYLuA9UYHVLYIXP+q0wXPrexpq4yDuovQekzE/SwIl8gVJRqv7/YIjX7GNKpwTQ/tNsW7LiJxCN4oR/jAaYsDx449mo8zp85dhZyJrFb8Ah+OGRgkc+JRQ9QBq5UuPDKNo/NmogBRTXFd+73KZ9VMvNERPBJa8dmK/I0GVqtlNLgTwiBlkm/wttrOrp1st81Uo0 X-OriginatorOrg: mt.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23c0c6e7-0da2-4827-810a-08dcfd9b2f24 X-MS-Exchange-CrossTenant-AuthSource: DBBPR03MB5399.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Nov 2024 13:10:13.3134 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fb4c0aee-6cd2-482f-a1a5-717e7c02496b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cgpl7a5KV6jWg37qzmOxYGKWa9BuoPSqaUlBN+axYJ0YLkzTEI1ii6SA+crOH9dhQQHeZ7bPCb6eZUWyK+5cmg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB8468 For a setup where the matrix keypad is connected over a slow interface (e.g. a gpio-expansion over i2c), the scan can take a longer time to read. Interrupts need to be disabled during scan. And therefore changes in this period are not detected. To improve this situation, scan the matrix again if the row state changed during interrupts disabled. Signed-off-by: Markus Burri --- drivers/input/keyboard/matrix_keypad.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/input/keyboard/matrix_keypad.c b/drivers/input/keyboard/matrix_keypad.c index 46873b8..93c8404 100644 --- a/drivers/input/keyboard/matrix_keypad.c +++ b/drivers/input/keyboard/matrix_keypad.c @@ -126,6 +126,10 @@ static void matrix_keypad_scan(struct work_struct *work) const unsigned short *keycodes = input_dev->keycode; uint32_t new_state[MATRIX_MAX_COLS]; int row, col, code; + u32 init_row_state, new_row_state; + + /* read initial row state to detect changes between scan */ + init_row_state = read_row_state(keypad); /* de-activate all columns for scanning */ activate_all_cols(keypad, false); @@ -174,6 +178,19 @@ static void matrix_keypad_scan(struct work_struct *work) keypad->scan_pending = false; enable_row_irqs(keypad); spin_unlock_irq(&keypad->lock); + + /* read new row state and detect if value has changed */ + new_row_state = read_row_state(keypad); + if (init_row_state != new_row_state) { + spin_lock_irq(&keypad->lock); + if (likely(!keypad->scan_pending && !keypad->stopped)) { + disable_row_irqs(keypad); + keypad->scan_pending = true; + schedule_delayed_work(&keypad->work, + msecs_to_jiffies(keypad->debounce_ms)); + } + spin_unlock_irq(&keypad->lock); + } } static irqreturn_t matrix_keypad_interrupt(int irq, void *id)