From patchwork Sat Nov 16 20:36:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 844451 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE108192590 for ; Sat, 16 Nov 2024 20:37:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731789426; cv=none; b=c+rbPkI5SF8/7JEWCGWvH34PZfHRCKIM8CQIKA7FpqltOsmwcKWZLXkwHIfFX4RYpByuI+LSUv36pkUlipuGe6rSvqPkdkT/eiCcrzdLmmls+5/YKd7NcBXJ9dTk+RETki2ZlX6vQLHUXuFeuoVETos8KAyzd4zUEgPCnu3Wxb8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731789426; c=relaxed/simple; bh=m3OWkHTSLWTUOwdJQ8ONbUPa8uj2qOi8R7Ooe6Q7ptk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=fCP+y74ebLfwGkCXLsQwY2RbqvuaH5gyu3nqG2pSYa23vHivBqRHxTqDlr4In7iHty+sLtmnuJmrC2r5QZPetLkdxVWlUS5SG6/oFXORiDcogH4WFXolKohvEIk7Xr8G3nSpg1W5xXUEgZCyMfw+wPFVQ2WVTZO7WUI3qlZSPMc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=NtnlPApB; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NtnlPApB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731789422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=HnuLBgjShB6JItGvQptzxKCXuY+/QrDp1kAZJwosvf4=; b=NtnlPApBhR2ukbqQyozVEeknpO7mOT0fP43GxKicgq2OaKrPygJEprbye56oohvV00mHnM 1AptgXvl4i62XKwYnhnJWkAWb6jtusMLeYzLAcyW6pQLyU70xWsiOMJGSVn+sFiUBF8ePw 7/rnJ3iYbkhKmIaDdh+RpJhHriNjnAM= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-74-ed4UtPiVPm2rR8lcmC30rw-1; Sat, 16 Nov 2024 15:36:59 -0500 X-MC-Unique: ed4UtPiVPm2rR8lcmC30rw-1 X-Mimecast-MFC-AGG-ID: ed4UtPiVPm2rR8lcmC30rw Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8E85B19560B1; Sat, 16 Nov 2024 20:36:57 +0000 (UTC) Received: from localhost.localdomain (unknown [10.39.192.14]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0EB001956056; Sat, 16 Nov 2024 20:36:54 +0000 (UTC) From: Hans de Goede To: Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Hans de Goede , Hermes Zhang , linux-pm@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 1/3] dt-bindings: power: supply: bq24190: Add BQ24297 compatible Date: Sat, 16 Nov 2024 21:36:46 +0100 Message-ID: <20241116203648.169100-1-hdegoede@redhat.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 The BQ24297 is identical to the BQ24296 except that it uses USB D+ / D- data-lines for charger-type (max. input-current) detection instead of a PSEL input pin. This is the same difference as between the already supported BQ24190 (D+ / D-) and the BQ24192 (PSEL). Signed-off-by: Hans de Goede --- Documentation/devicetree/bindings/power/supply/bq24190.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/power/supply/bq24190.yaml b/Documentation/devicetree/bindings/power/supply/bq24190.yaml index 131b7e57d22f..07adf88997b4 100644 --- a/Documentation/devicetree/bindings/power/supply/bq24190.yaml +++ b/Documentation/devicetree/bindings/power/supply/bq24190.yaml @@ -21,6 +21,7 @@ properties: - ti,bq24192i - ti,bq24196 - ti,bq24296 + - ti,bq24297 reg: maxItems: 1 From patchwork Sat Nov 16 20:36:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 843872 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6D23191F91 for ; Sat, 16 Nov 2024 20:37:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731789427; cv=none; b=B+BXKuYV8iu99DMs9vZ2ZDqfQJxdQGYSxzwjqceDyZ7nj+73hQ4V41PX1w5JTqDNcz6ob6OZDfb7d0hw7irNSBP8MnRvNUnk/13wmejm3HJhuqeML0EyL6SHS99RVwdL3ytqWVQN+92Zuuda1l0F9oCc0E2wg1zEdt9FtZDXH7Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731789427; c=relaxed/simple; bh=8Z9adF3i5dFbjVgTDTqQ35n5Zr7fqKmMo1Iu9jx97m0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cjmOY5Hl2HopZqhy3j3lDOrTjAHHi8VV7ZdH2jTMla2j6o/Nm5+aAYJA7S2RBcMegG6cVgp2lSup4aUw7M+9HHdma3+dmKKPCZboiHNVysNxECQSQ8dUlZJGgc+jCtolqxcQtE0eO4xvLY+Zzh35/F5ihfnlva0AB6hPo2MD2xQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=D2GommU0; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="D2GommU0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731789425; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d3mlHFtAuQ0Swa9hlusVWD5DNnww2YIjIcVgtDs/jxE=; b=D2GommU0M3/4O4z+re0X1I6tpiLVrPD3+fe0tUaE4KoNvo+oYdtJ/hNh6sy+iSmDqF8RXK JocF8QGHF9ziLV3nvL+TBUIW+xT8wJc8cpl2mCUBptYWFsHoOh6G+16OBEh2iT8ouptHs6 IoYv6EDQu9LRQ6qOdjmBCmZW2Cz5h2U= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-107-um7B8WKnPh2NZUsJcvLr4w-1; Sat, 16 Nov 2024 15:37:01 -0500 X-MC-Unique: um7B8WKnPh2NZUsJcvLr4w-1 X-Mimecast-MFC-AGG-ID: um7B8WKnPh2NZUsJcvLr4w Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 489F71956096; Sat, 16 Nov 2024 20:37:00 +0000 (UTC) Received: from localhost.localdomain (unknown [10.39.192.14]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id F14E51956056; Sat, 16 Nov 2024 20:36:57 +0000 (UTC) From: Hans de Goede To: Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Hans de Goede , Hermes Zhang , linux-pm@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 2/3] power: supply: bq24190: Fix BQ24296 Vbus regulator support Date: Sat, 16 Nov 2024 21:36:47 +0100 Message-ID: <20241116203648.169100-2-hdegoede@redhat.com> In-Reply-To: <20241116203648.169100-1-hdegoede@redhat.com> References: <20241116203648.169100-1-hdegoede@redhat.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 There are 2 issues with bq24296_set_otg_vbus(): 1. When writing the OTG_CONFIG bit it uses POC_CHG_CONFIG_SHIFT which should be POC_OTG_CONFIG_SHIFT. 2. When turning the regulator off it never turns charging back on. Note this must be done through bq24190_charger_set_charge_type(), to ensure that the charge_type property value of none/trickle/fast is honored. Resolve both issues to fix BQ24296 Vbus regulator support not working. Fixes: b150a703b56f ("power: supply: bq24190_charger: Add support for BQ24296") Signed-off-by: Hans de Goede --- drivers/power/supply/bq24190_charger.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c index 0101aaca1a97..4881cbd0e672 100644 --- a/drivers/power/supply/bq24190_charger.c +++ b/drivers/power/supply/bq24190_charger.c @@ -567,6 +567,7 @@ static int bq24190_set_otg_vbus(struct bq24190_dev_info *bdi, bool enable) static int bq24296_set_otg_vbus(struct bq24190_dev_info *bdi, bool enable) { + union power_supply_propval val = { .intval = bdi->charge_type }; int ret; ret = pm_runtime_resume_and_get(bdi->dev); @@ -587,13 +588,18 @@ static int bq24296_set_otg_vbus(struct bq24190_dev_info *bdi, bool enable) ret = bq24190_write_mask(bdi, BQ24190_REG_POC, BQ24296_REG_POC_OTG_CONFIG_MASK, - BQ24296_REG_POC_CHG_CONFIG_SHIFT, + BQ24296_REG_POC_OTG_CONFIG_SHIFT, BQ24296_REG_POC_OTG_CONFIG_OTG); - } else + } else { ret = bq24190_write_mask(bdi, BQ24190_REG_POC, BQ24296_REG_POC_OTG_CONFIG_MASK, - BQ24296_REG_POC_CHG_CONFIG_SHIFT, + BQ24296_REG_POC_OTG_CONFIG_SHIFT, BQ24296_REG_POC_OTG_CONFIG_DISABLE); + if (ret < 0) + goto out; + + ret = bq24190_charger_set_charge_type(bdi, &val); + } out: pm_runtime_mark_last_busy(bdi->dev); From patchwork Sat Nov 16 20:36:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 844450 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72A55194C7A for ; Sat, 16 Nov 2024 20:37:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731789434; cv=none; b=TWoQFYIXACJgG9QgmV30zzJX9aISTc3SnnJWiunTufNwspi4cRgBNhktICrGr5/jveueTa2JHtILZQenBSM4kSurF8Z+30KgYm+1NPLSymt1G1xGzOjYqRi/uKGOyaJejm6etBpOSH5Opa6dq3fioPXQylAu9M9rrcuhNWHXBoA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731789434; c=relaxed/simple; bh=u1/AtEoQwSJwGsbKD0GLeGX10uHIv29qtpAUQFKf95o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sSr6x2Cj9IrlToTJjRW6MBfkde3it93UQyP+jwGTCQgZ7L9oYvVQKGEAwQ3y2qU2EQc7Yg96Jq6yC2u60cHJE2lcW8JlyjEboyTPQFYdPsQsyfLt/L6ji3RMIT6uGYO8Hm44uVTaq0C9WJkIhdFFQB9iXi+ZaOpWfH3Na4HL78I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=MZ2IUeY6; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MZ2IUeY6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731789431; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4+hwsuXUh6txVo7lD5/sCKQ9GduGoC9trsMg2Xh+ZEM=; b=MZ2IUeY60Ct4fq329Ax3u/7I6H67azVIKDidXnFLsrvgNvmLuOw2Alomb9FalmYdQ+V8Sn 5xbVQXwOJIJvR9Qk8Yn9w6FtpokntpoD81rIr/lpbkus1Pj3V0ceUs/ImoUPaznWKlcK3O sshTO1WT8tK2CI63Kv+XPM/6J/6GMdc= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-296-EFyKibtaPLy1b7pJ8MXweg-1; Sat, 16 Nov 2024 15:37:04 -0500 X-MC-Unique: EFyKibtaPLy1b7pJ8MXweg-1 X-Mimecast-MFC-AGG-ID: EFyKibtaPLy1b7pJ8MXweg Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DCFD319560B1; Sat, 16 Nov 2024 20:37:02 +0000 (UTC) Received: from localhost.localdomain (unknown [10.39.192.14]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 95E3A1956056; Sat, 16 Nov 2024 20:37:00 +0000 (UTC) From: Hans de Goede To: Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Hans de Goede , Hermes Zhang , linux-pm@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 3/3] power: supply: bq24190: Add BQ24297 support Date: Sat, 16 Nov 2024 21:36:48 +0100 Message-ID: <20241116203648.169100-3-hdegoede@redhat.com> In-Reply-To: <20241116203648.169100-1-hdegoede@redhat.com> References: <20241116203648.169100-1-hdegoede@redhat.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 The BQ24297 is identical to the BQ24296 except that it uses USB D+ / D- data-lines for charger-type (max. input-current) detection instead of a PSEL input pin. This is the same difference as between the already supported BQ24190 (D+ / D-) and the BQ24192 (PSEL). Note just like with the BQ24190 vs BQ24192 there is no difference how the charger-IC works at the register-level. The only difference is in the external hardware interface. Signed-off-by: Hans de Goede --- drivers/power/supply/bq24190_charger.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c index 4881cbd0e672..a6a9f3ede34a 100644 --- a/drivers/power/supply/bq24190_charger.c +++ b/drivers/power/supply/bq24190_charger.c @@ -152,6 +152,7 @@ #define BQ24296_REG_VPRS_PN_MASK (BIT(7) | BIT(6) | BIT(5)) #define BQ24296_REG_VPRS_PN_SHIFT 5 #define BQ24296_REG_VPRS_PN_24296 0x1 +#define BQ24296_REG_VPRS_PN_24297 0x3 #define BQ24190_REG_VPRS_TS_PROFILE_MASK BIT(2) #define BQ24190_REG_VPRS_TS_PROFILE_SHIFT 2 #define BQ24190_REG_VPRS_DEV_REG_MASK (BIT(1) | BIT(0)) @@ -208,6 +209,7 @@ enum bq24190_chip { BQ24192i, BQ24196, BQ24296, + BQ24297, }; /* @@ -1904,6 +1906,7 @@ static int bq24296_check_chip(struct bq24190_dev_info *bdi) switch (v) { case BQ24296_REG_VPRS_PN_24296: + case BQ24296_REG_VPRS_PN_24297: break; default: dev_err(bdi->dev, "Error unknown model: 0x%02x\n", v); @@ -2033,6 +2036,17 @@ static const struct bq24190_chip_info bq24190_chip_info_tbl[] = { .ichg_array_size = BQ24296_CCC_ICHG_VALUES_LEN, #ifdef CONFIG_REGULATOR .vbus_desc = &bq24296_vbus_desc, +#endif + .check_chip = bq24296_check_chip, + .set_chg_config = bq24296_battery_set_chg_config, + .ntc_fault_mask = BQ24296_REG_F_NTC_FAULT_MASK, + .get_ntc_status = bq24296_charger_get_ntc_status, + .set_otg_vbus = bq24296_set_otg_vbus, + }, + [BQ24297] = { + .ichg_array_size = BQ24296_CCC_ICHG_VALUES_LEN, +#ifdef CONFIG_REGULATOR + .vbus_desc = &bq24296_vbus_desc, #endif .check_chip = bq24296_check_chip, .set_chg_config = bq24296_battery_set_chg_config, @@ -2296,6 +2310,7 @@ static const struct i2c_device_id bq24190_i2c_ids[] = { { "bq24192i", (kernel_ulong_t)&bq24190_chip_info_tbl[BQ24192i] }, { "bq24196", (kernel_ulong_t)&bq24190_chip_info_tbl[BQ24196] }, { "bq24296", (kernel_ulong_t)&bq24190_chip_info_tbl[BQ24296] }, + { "bq24297", (kernel_ulong_t)&bq24190_chip_info_tbl[BQ24297] }, { }, }; MODULE_DEVICE_TABLE(i2c, bq24190_i2c_ids); @@ -2306,6 +2321,7 @@ static const struct of_device_id bq24190_of_match[] = { { .compatible = "ti,bq24192i", .data = &bq24190_chip_info_tbl[BQ24192i] }, { .compatible = "ti,bq24196", .data = &bq24190_chip_info_tbl[BQ24196] }, { .compatible = "ti,bq24296", .data = &bq24190_chip_info_tbl[BQ24296] }, + { .compatible = "ti,bq24297", .data = &bq24190_chip_info_tbl[BQ24297] }, { }, }; MODULE_DEVICE_TABLE(of, bq24190_of_match);