From patchwork Thu Dec 19 16:21:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Dubois-Briand X-Patchwork-Id: 852161 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76685226172; Thu, 19 Dec 2024 16:21:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734625320; cv=none; b=bZ0pBv2OhBvW8rLTsuvIl0gbdWfxIZhzXJzDg3/nMgAOR//4ug7eKm8dTzV5rsXAWpQHUbwkWiDP8SKxvKZQQMCwejFk9mduYdxnGnEJFmTmOmi5XlkCeIsILul2C3MlTvq8bfkQ8+YaSnPEv15jpxxP0luzM27x/sFegUgTmm4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734625320; c=relaxed/simple; bh=Qs1lXdR3k4hh5hqJDPaLH7psb2FueYZC74dIRlcG+8Q=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KzMbVXt/fb1nGCMj/d6ARVkrqX9lPng5tY5hpf+tHdpsALqpLkfpXd/1SEnkh0aKH2RkaHckXxT1ie1NUYdN+dDx4rrjIu2XpXT4f0nc2NTFDxcr07rWISyc/tAbA4uZW2T5WUbF0w340syWp+QLKxGBiPhRavDnNyRbaOu7h78= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=DciEccms; arc=none smtp.client-ip=217.70.183.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="DciEccms" Received: by mail.gandi.net (Postfix) with ESMTPSA id 418FC60009; Thu, 19 Dec 2024 16:21:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1734625310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h31lyABGlYGYdph3DUXih1SNot88N+ffTqw66rva9/s=; b=DciEccms/7F/3YzSdPpzpcuxkpEfz0t2W4m9Y7mx4CT2YPYwzHnktZzNXfBjNz21CWGz/u LQ2CtQtXFcdXgrSXgdOHJRV9sgEplUCE/5o8FNTMvIpXRPDLfy+F6G2ihnrk11EelUpn6O f9C0IyVFPYYEbEtet0uA2FOcwEN/vMX/97RCiG8SgVUpG2M9PurtZcPomwe/iMHCvxUp6x wwxa0XPKBoageV6zMe1VcHzY1o6qrUSobHpf7fFY1an/ZKRwyTM6evGNCAbJ8Xj5O1uihE zU7Icj+c98YK1GIlKSXnhuRYXFLm2+fPUsiD0nLHnOCedRBtoF2rEiEHhJJAQg== From: Mathieu Dubois-Briand Date: Thu, 19 Dec 2024 17:21:19 +0100 Subject: [PATCH 2/8] dt-bindings: Add MAX7360 subdevices Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241219-mdb-max7360-support-v1-2-8e8317584121@bootlin.com> References: <20241219-mdb-max7360-support-v1-0-8e8317584121@bootlin.com> In-Reply-To: <20241219-mdb-max7360-support-v1-0-8e8317584121@bootlin.com> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kamel Bouhara , Linus Walleij , Bartosz Golaszewski , Dmitry Torokhov , =?utf-8?q?Uwe_Kleine-K=C3=B6n?= =?utf-8?q?ig?= Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-input@vger.kernel.org, linux-pwm@vger.kernel.org, =?utf-8?q?Gr=C3=A9gory_Clement?= , Thomas Petazzoni , Mathieu Dubois-Briand X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1734625307; l=7491; i=mathieu.dubois-briand@bootlin.com; s=20241219; h=from:subject:message-id; bh=Qs1lXdR3k4hh5hqJDPaLH7psb2FueYZC74dIRlcG+8Q=; b=tSuhYavHF7GT3CZ1THiMbRIustPw4CMj9MIV/4fHTCqcjTqobpVHSEJWUoGMUNQLZBXd5vi6l gRNCp945UCFBxthmnr2hvx2idlWCBo1iWzBWB6eYF27BwEg48u/clSL X-Developer-Key: i=mathieu.dubois-briand@bootlin.com; a=ed25519; pk=1PVTmzPXfKvDwcPUzG0aqdGoKZJA3b9s+3DqRlm0Lww= X-GND-Sasl: mathieu.dubois-briand@bootlin.com Add device tree bindings for Maxim Integrated MAX7360 MFD functions: keypad, rotary, gpios and pwm. Signed-off-by: Mathieu Dubois-Briand --- .../devicetree/bindings/gpio/max7360-gpio.yaml | 96 ++++++++++++++++++++++ .../devicetree/bindings/input/max7360-keypad.yaml | 67 +++++++++++++++ .../devicetree/bindings/input/max7360-rotary.yaml | 52 ++++++++++++ .../devicetree/bindings/pwm/max7360-pwm.yaml | 35 ++++++++ 4 files changed, 250 insertions(+) diff --git a/Documentation/devicetree/bindings/gpio/max7360-gpio.yaml b/Documentation/devicetree/bindings/gpio/max7360-gpio.yaml new file mode 100644 index 000000000000..3c006dc0380b --- /dev/null +++ b/Documentation/devicetree/bindings/gpio/max7360-gpio.yaml @@ -0,0 +1,96 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/gpio/max7360-gpio.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Maxim MAX7360 GPIO controller + +maintainers: + - Kamel Bouhara + - Mathieu Dubois-Briand + +description: | + Maxim MAX7360 GPIO controller, in MAX7360 MFD + https://www.analog.com/en/products/max7360.html + +properties: + compatible: + enum: + - maxim,max7360-gpio + - maxim,max7360-gpo + + gpio-controller: true + + "#gpio-cells": + const: 2 + + ngpios: + minimum: 0 + maximum: 8 + + interrupt-controller: true + + "#interrupt-cells": + const: 2 + + interrupts: + description: The interrupt line the device is connected to. + maxItems: 1 + + constant-current-disable: + $ref: /schemas/types.yaml#/definitions/uint32 + description: Bit field, each bit disables constant-current output of the + associated GPIO. + + +required: + - compatible + - gpio-controller + - ngpios + +if: + properties: + compatible: + contains: + enum: + - maxim,max7360-gpio +then: + required: + - interrupt-controller + - interrupts +else: + properties: + interrupt-controller: false + interrupts: false + constant-current-disable: false + + ngpios: + maximum: 6 + +additionalProperties: false + +examples: + - | + #include + + max7360_gpo: max7360_gpo { + compatible = "maxim,max7360-gpo"; + gpio-controller; + #gpio-cells = <0x2>; + ngpios = <4>; + }; + + max7360_gpio: max7360_gpio { + compatible = "maxim,max7360-gpio"; + + gpio-controller; + #gpio-cells = <0x2>; + ngpios = <8>; + constant-current-disable = <0x06>; + + interrupt-controller; + #interrupt-cells = <0x2>; + interrupt-parent = <&gpio1>; + interrupts = <23 IRQ_TYPE_LEVEL_LOW>; + }; diff --git a/Documentation/devicetree/bindings/input/max7360-keypad.yaml b/Documentation/devicetree/bindings/input/max7360-keypad.yaml new file mode 100644 index 000000000000..8bc3c841465b --- /dev/null +++ b/Documentation/devicetree/bindings/input/max7360-keypad.yaml @@ -0,0 +1,67 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/input/max7360-keypad.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Maxim MAX7360 Keypad Controller + +maintainers: + - Mathieu Dubois-Briand + +description: | + Maxim MAX7360 Keypad Controller, in MAX7360 MFD + https://www.analog.com/en/products/max7360.html + +allOf: + - $ref: matrix-keymap.yaml# + - $ref: input.yaml# + +properties: + compatible: + enum: + - maxim,max7360-keypad + + interrupts: + description: The interrupt line the device is connected to. + maxItems: 1 + + debounce-delay-ms: + description: Debounce delay in ms + minimum: 9 + maximum: 40 + default: 9 + + linux,input-no-autorepeat: + description: If present, the keys will not autorepeat when pressed + +required: + - compatible + - interrupts + - linux,keymap + +unevaluatedProperties: false + +examples: + - | + #include + #include + + max7360_keypad { + compatible = "maxim,max7360-keypad"; + + keypad,num-rows = <8>; + keypad,num-columns = <4>; + + linux,keymap = < + MATRIX_KEY(0x00, 0x00, KEY_F5) + MATRIX_KEY(0x01, 0x00, KEY_F4) + MATRIX_KEY(0x02, 0x01, KEY_F6) + >; + + interrupt-parent = <&gpio1>; + interrupts = <23 IRQ_TYPE_LEVEL_LOW>; + + debounce-delay-ms = <10>; + linux,input-no-autorepeat; + }; diff --git a/Documentation/devicetree/bindings/input/max7360-rotary.yaml b/Documentation/devicetree/bindings/input/max7360-rotary.yaml new file mode 100644 index 000000000000..19afa8344249 --- /dev/null +++ b/Documentation/devicetree/bindings/input/max7360-rotary.yaml @@ -0,0 +1,52 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/input/max7360-rotary.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Maxim MAX7360 Rotary Encoder + +maintainers: + - Mathieu Dubois-Briand + +description: | + Maxim MAX7360 Rotary Encoder, in MAX7360 MFD + https://www.analog.com/en/products/max7360.html + +properties: + compatible: + enum: + - maxim,max7360-rotary + + interrupts: + description: The interrupt line the device is connected to. + maxItems: 1 + + debounce-delay-ms: + description: Debounce delay in ms + minimum: 0 + maximum: 15 + default: 0 + + linux,axis: + description: The input subsystem axis to map to this rotary encoder. + +required: + - compatible + - interrupts + +additionalProperties: false + +examples: + - | + #include + + max7360_rotary: max7360_rotary { + compatible = "maxim,max7360-rotary"; + + debounce-delay-ms = <2>; + linux,axis = <0>; /* REL_X */ + + interrupt-parent = <&gpio1>; + interrupts = <23 IRQ_TYPE_LEVEL_LOW>; + }; diff --git a/Documentation/devicetree/bindings/pwm/max7360-pwm.yaml b/Documentation/devicetree/bindings/pwm/max7360-pwm.yaml new file mode 100644 index 000000000000..68d48969e542 --- /dev/null +++ b/Documentation/devicetree/bindings/pwm/max7360-pwm.yaml @@ -0,0 +1,35 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/pwm/max7360-pwm.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Maxim MAX7360 PWM controller + +maintainers: + - Kamel Bouhara + +description: | + Maxim MAX7360 PWM controller, in MAX7360 MFD + https://www.analog.com/en/products/max7360.html + +properties: + compatible: + enum: + - maxim,max7360-pwm + + "#pwm-cells": + const: 2 + + +required: + - compatible + +additionalProperties: false + +examples: + - | + max7360_pwm: max7360_pwm { + compatible = "maxim,max7360-pwm"; + #pwm-cells = <2>; + }; From patchwork Thu Dec 19 16:21:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Dubois-Briand X-Patchwork-Id: 852160 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60D0B22654A; Thu, 19 Dec 2024 16:21:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734625321; cv=none; b=T4bHTohuKQhgHAXTYF42zkdrD0tue7AC63H+V8grdgtOAF5ZXMZHJyx73syGqgeEfnmRCkMOiiVDC4uTW2JxkuCwCLmiLvuooiGATwgGtS4CrkoOHlXzdsL2nRrCIYcjuPtjqh0ODB22HxXKyW/vMM+qyrMIMQI7WbBRZotYmig= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734625321; c=relaxed/simple; bh=PybKAU+3vbndizy2H1sa0Lwsq0GbIx6ABnD6dcyNxWQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Y6/eghu4LNOjAzGGqZxJ6UbsMmfmN8t93Xb2UNmLAjblVhKi17+JM4TFei8Uf1r9S2RqDIhLvLFdacuFr9HcEpxwEozZ9U5cJUhdMlE+t/4ON13YM6Fe9BicwoYd5wVja6UiE70rCFXLTJMzedo7eN7QznwrIv81XoZz5O8wIvU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=VnR/ugfn; arc=none smtp.client-ip=217.70.183.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="VnR/ugfn" Received: by mail.gandi.net (Postfix) with ESMTPSA id 17CC860003; Thu, 19 Dec 2024 16:21:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1734625310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wfUnDdooPof7eT/RduRzy7XQjBZM7wassZexFE60gSM=; b=VnR/ugfn6rN534C0YR0r/IHcaaSBv/jjSiB9bRIs59IeKXwhQL1jLpFNXB6bpeN+t6QyoJ x3DIv/8mqQaP0145EOE76Nq+GCT6SjIft5r6F91veMA5BpaRGkW4+ceBjEZGIE5wGuJrIe wceRxdKeFl8AbiGOgBf5daiiWtJri+JIq7EZ8idY9WbocJRZ6uSTHghecWlSSTfl8GYV6h qqECafGYc4tZz3utgf11ZWyXrOQuk0Br5ghqbt5Dnjc2w+LV4x4x/7yCj7csRUQcM22o/1 bA1qW9KkMFAoMHdo5cWRWY5mzWqSyPcKkUzXBAPzRU37d3Yw7hPKhD/kL/305g== From: mathieu.dubois-briand@bootlin.com Date: Thu, 19 Dec 2024 17:21:20 +0100 Subject: [PATCH 3/8] mfd: Add max7360 support Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241219-mdb-max7360-support-v1-3-8e8317584121@bootlin.com> References: <20241219-mdb-max7360-support-v1-0-8e8317584121@bootlin.com> In-Reply-To: <20241219-mdb-max7360-support-v1-0-8e8317584121@bootlin.com> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kamel Bouhara , Linus Walleij , Bartosz Golaszewski , Dmitry Torokhov , =?utf-8?q?Uwe_Kleine-K=C3=B6n?= =?utf-8?q?ig?= Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-input@vger.kernel.org, linux-pwm@vger.kernel.org, =?utf-8?q?Gr=C3=A9gory_Clement?= , Thomas Petazzoni , Mathieu Dubois-Briand X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1734625307; l=13201; i=mathieu.dubois-briand@bootlin.com; s=20241219; h=from:subject:message-id; bh=doolHWPKXd7dXbLUCc0fkQ10pFTbxLhiIJPiEIXe1XE=; b=CUq0LgiAqO+36IuT9iQg8SzXZfxk5jm07J1sTSeTg1KF54oSIEoeNsvm53AhLWCA1rQxTIxx9 sIKnzWw++8nBJ0vzGvMR/vZN9A+l82N8KLZTq1ydmbEoeJbmktp6rpr X-Developer-Key: i=mathieu.dubois-briand@bootlin.com; a=ed25519; pk=1PVTmzPXfKvDwcPUzG0aqdGoKZJA3b9s+3DqRlm0Lww= X-GND-Sasl: mathieu.dubois-briand@bootlin.com From: Kamel Bouhara Add core driver to support MAX7360 i2c chip, multi function device with keypad, gpio, pwm, gpo and rotary encoder submodules. Signed-off-by: Kamel Bouhara Co-developed-by: Mathieu Dubois-Briand Signed-off-by: Mathieu Dubois-Briand --- drivers/mfd/Kconfig | 12 ++ drivers/mfd/Makefile | 1 + drivers/mfd/max7360.c | 302 ++++++++++++++++++++++++++++++++++++++++++++ include/linux/mfd/max7360.h | 103 +++++++++++++++ 4 files changed, 418 insertions(+) diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index ae23b317a64e..c1ddda480922 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -2414,5 +2414,17 @@ config MFD_RSMU_SPI Additional drivers must be enabled in order to use the functionality of the device. +config MFD_MAX7360 + tristate "Maxim MAX7360 Support" + depends on I2C + select MFD_CORE + select REGMAP_I2C + select REGMAP_IRQ + help + Say yes here to add support for Maxim MAX7360. + This driver provides common support for accessing + the device; additional drivers must be enabled in + order to use the functionality of the device. + endmenu endif diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile index e057d6d6faef..6cd55504106d 100644 --- a/drivers/mfd/Makefile +++ b/drivers/mfd/Makefile @@ -163,6 +163,7 @@ obj-$(CONFIG_MFD_DA9063) += da9063.o obj-$(CONFIG_MFD_DA9150) += da9150-core.o obj-$(CONFIG_MFD_MAX14577) += max14577.o +obj-$(CONFIG_MFD_MAX7360) += max7360.o obj-$(CONFIG_MFD_MAX77541) += max77541.o obj-$(CONFIG_MFD_MAX77620) += max77620.o obj-$(CONFIG_MFD_MAX77650) += max77650.o diff --git a/drivers/mfd/max7360.c b/drivers/mfd/max7360.c new file mode 100644 index 000000000000..c53b42f00a9d --- /dev/null +++ b/drivers/mfd/max7360.c @@ -0,0 +1,302 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Maxim MAX7360 Core Driver + * + * Copyright (C) 2024 Kamel Bouhara + * Author: Kamel Bouhara + */ + +#include +#include +#include +#include +#include +#include +#include +#include + +static DEFINE_SPINLOCK(request_lock); + +struct max7360_mfd { + struct regmap *regmap; + unsigned int requested_ports; + struct device *dev; +}; + +#define GPO_COMPATIBLE "maxim,max7360-gpo" +#define KEYPAD_COMPATIBLE "maxim,max7360-keypad" + +static const struct mfd_cell max7360_cells[] = { + { + .name = "max7360-pwm", + .of_compatible = "maxim,max7360-pwm", + }, + { + .name = "max7360-gpo", + .of_compatible = GPO_COMPATIBLE, + }, + { + .name = "max7360-gpio", + .of_compatible = "maxim,max7360-gpio", + }, + { + .name = "max7360-keypad", + .of_compatible = KEYPAD_COMPATIBLE, + }, + { + .name = "max7360-rotary", + .of_compatible = "maxim,max7360-rotary", + }, +}; + +const struct regmap_range max7360_volatile_ranges[] = { + { + .range_min = MAX7360_REG_KEYFIFO, + .range_max = MAX7360_REG_KEYFIFO, + }, { + .range_min = 0x48, + .range_max = 0x4a, + }, +}; + +static const struct regmap_access_table max7360_volatile_table = { + .yes_ranges = max7360_volatile_ranges, + .n_yes_ranges = ARRAY_SIZE(max7360_volatile_ranges), +}; + +static const struct regmap_config max7360_regmap_config = { + .reg_bits = 8, + .val_bits = 8, + .max_register = 0xff, + .volatile_table = &max7360_volatile_table, + .cache_type = REGCACHE_RBTREE, +}; + +static int max7360_set_gpos_count(struct max7360_mfd *max7360_mfd) +{ + /* + * Max7360 COL0 to COL7 pins can be used either as keypad columns, + * general purpose output or a mix of both. + * Get the number of pins requested by the corresponding drivers, ensure + * they are compatible with each others and apply the corresponding + * configuration. + */ + struct device_node *np; + u32 gpos = 0; + u32 columns = 0; + unsigned int val; + int ret; + + np = of_get_compatible_child(max7360_mfd->dev->of_node, GPO_COMPATIBLE); + if (np) { + ret = of_property_read_u32(np, "ngpios", &gpos); + if (ret < 0) { + dev_err(max7360_mfd->dev, "Failed to read gpos count\n"); + return ret; + } + } + + np = of_get_compatible_child(max7360_mfd->dev->of_node, + KEYPAD_COMPATIBLE); + if (np) { + ret = of_property_read_u32(np, "keypad,num-columns", &columns); + if (ret < 0) { + dev_err(max7360_mfd->dev, "Failed to read columns count\n"); + return ret; + } + } + + if (gpos > MAX7360_MAX_GPO || + (gpos + columns > MAX7360_MAX_KEY_COLS)) { + dev_err(max7360_mfd->dev, + "Incompatible gpos and columns count (%u, %u)\n", + gpos, columns); + return -EINVAL; + } + + /* + * MAX7360_REG_DEBOUNCE contains configuration both for keypad debounce + * timings and gpos/keypad columns repartition. Only the later is + * modified here. + */ + val = FIELD_PREP(MAX7360_PORTS, gpos); + ret = regmap_write_bits(max7360_mfd->regmap, MAX7360_REG_DEBOUNCE, + MAX7360_PORTS, val); + if (ret) { + dev_err(max7360_mfd->dev, + "Failed to write max7360 columns/gpos configuration"); + return ret; + } + + return 0; +} + +int max7360_port_pin_request(struct device *dev, unsigned int pin, bool request) +{ + struct i2c_client *client; + struct max7360_mfd *max7360_mfd; + unsigned long flags; + int ret = 0; + + client = to_i2c_client(dev); + max7360_mfd = i2c_get_clientdata(client); + + spin_lock_irqsave(&request_lock, flags); + if (request) { + if (max7360_mfd->requested_ports & BIT(pin)) + ret = -EBUSY; + else + max7360_mfd->requested_ports |= BIT(pin); + } else { + max7360_mfd->requested_ports &= ~BIT(pin); + } + spin_unlock_irqrestore(&request_lock, flags); + + return ret; +} +EXPORT_SYMBOL_GPL(max7360_port_pin_request); + +static int max7360_mask_irqs(struct max7360_mfd *max7360_mfd) +{ + unsigned int i; + unsigned int val; + int ret; + + /* + * GPIO/PWM interrupts are not masked on reset: mask the during probe, + * avoiding repeated spurious interrupts if the corresponding drivers + * are not present. + */ + for (i = 0; i < MAX7360_PORT_PWM_COUNT; i++) { + ret = regmap_write_bits(max7360_mfd->regmap, + MAX7360_REG_PWMCFG + i, + MAX7360_PORT_CFG_INTERRUPT_MASK, + MAX7360_PORT_CFG_INTERRUPT_MASK); + if (ret) { + dev_err(max7360_mfd->dev, + "failed to write max7360 port configuration"); + return ret; + } + } + + /* Read gpio in register, to ack any pending IRQ. + */ + ret = regmap_read(max7360_mfd->regmap, MAX7360_REG_GPIOIN, &val); + if (ret) { + dev_err(max7360_mfd->dev, "Failed to read gpio values: %d\n", + ret); + return ret; + } + + return 0; +} + +static int max7360_reset(struct max7360_mfd *max7360_mfd) +{ + int err; + + /* + * Set back the default values. + * We do not use GPIO reset function here, as it does not work reliably. + */ + err = regmap_write(max7360_mfd->regmap, MAX7360_REG_GPIODEB, 0x00); + if (err) { + dev_err(max7360_mfd->dev, "Failed to set configuration\n"); + return err; + } + + err = regmap_write(max7360_mfd->regmap, MAX7360_REG_GPIOCURR, MAX7360_REG_GPIOCURR_FIXED); + if (err) { + dev_err(max7360_mfd->dev, "Failed to set configuration\n"); + return err; + } + + err = regmap_write(max7360_mfd->regmap, MAX7360_REG_GPIOOUTM, 0x00); + if (err) { + dev_err(max7360_mfd->dev, "Failed to set configuration\n"); + return err; + } + + err = regmap_write(max7360_mfd->regmap, MAX7360_REG_PWMCOM, 0x00); + if (err) { + dev_err(max7360_mfd->dev, "Failed to set configuration\n"); + return err; + } + + err = regmap_write(max7360_mfd->regmap, MAX7360_REG_SLEEP, 0); + if (err) { + dev_err(max7360_mfd->dev, "Failed to set configuration\n"); + return err; + } + + return 0; +} + +static int max7360_probe(struct i2c_client *client) +{ + struct device *dev = &client->dev; + struct regmap *regmap; + struct max7360_mfd *max7360_mfd; + int err; + + regmap = devm_regmap_init_i2c(client, &max7360_regmap_config); + if (IS_ERR(regmap)) + return dev_err_probe(dev, PTR_ERR(regmap), + "Failed to initialise regmap\n"); + + max7360_mfd = devm_kzalloc(dev, sizeof(*max7360_mfd), GFP_KERNEL); + if (!max7360_mfd) + return -ENOMEM; + + max7360_mfd->regmap = regmap; + max7360_mfd->dev = dev; + i2c_set_clientdata(client, max7360_mfd); + + err = max7360_reset(max7360_mfd); + if (err) + return dev_err_probe(dev, err, "Failed to reset device\n"); + + err = max7360_set_gpos_count(max7360_mfd); + if (err) + return dev_err_probe(dev, err, "Failed to set GPOS pin count\n"); + + /* + * Get the device out of shutdown mode. + */ + err = regmap_write_bits(regmap, MAX7360_REG_GPIOCFG, + MAX7360_GPIO_CFG_GPIO_EN, + MAX7360_GPIO_CFG_GPIO_EN); + if (err) + return dev_err_probe(dev, err, "Failed to set device out of shutdown\n"); + + err = max7360_mask_irqs(max7360_mfd); + if (err) + return dev_err_probe(dev, err, "could not mask interrupts\n"); + + err = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE, + max7360_cells, ARRAY_SIZE(max7360_cells), + NULL, 0, NULL); + if (err) + return dev_err_probe(dev, err, "Failed to register child devices\n"); + + return 0; +} + +static const struct of_device_id max7360_dt_match[] = { + { .compatible = "maxim,max7360" }, + {}, +}; +MODULE_DEVICE_TABLE(of, max7360_dt_match); + +static struct i2c_driver max7360_driver = { + .driver = { + .name = "max7360", + .of_match_table = max7360_dt_match, + }, + .probe = max7360_probe, +}; +module_i2c_driver(max7360_driver); + +MODULE_DESCRIPTION("Maxim MAX7360 MFD core driver"); +MODULE_AUTHOR("Kamel Bouhara "); +MODULE_LICENSE("GPL"); diff --git a/include/linux/mfd/max7360.h b/include/linux/mfd/max7360.h new file mode 100644 index 000000000000..2b77110acd80 --- /dev/null +++ b/include/linux/mfd/max7360.h @@ -0,0 +1,103 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __LINUX_MFD_MAX7360_H +#define __LINUX_MFD_MAX7360_H +#include +#include + +#define MAX7360_MAX_KEY_ROWS 8 +#define MAX7360_MAX_KEY_COLS 8 +#define MAX7360_MAX_KEY_NUM (MAX7360_MAX_KEY_ROWS * MAX7360_MAX_KEY_COLS) +#define MAX7360_ROW_SHIFT 3 + +#define MAX7360_MAX_GPIO 8 +#define MAX7360_MAX_GPO 6 +#define MAX7360_PORT_PWM_COUNT 8 +#define MAX7360_PORT_RTR_PIN (MAX7360_PORT_PWM_COUNT - 1) +/* + * MAX7360 registers + */ +#define MAX7360_REG_KEYFIFO 0x00 +#define MAX7360_REG_CONFIG 0x01 +#define MAX7360_REG_DEBOUNCE 0x02 +#define MAX7360_REG_INTERRUPT 0x03 +#define MAX7360_REG_PORTS 0x04 +#define MAX7360_REG_KEYREP 0x05 +#define MAX7360_REG_SLEEP 0x06 + +/* + * MAX7360 registers + */ +#define MAX7360_REG_GPIOCFG 0x40 +#define MAX7360_REG_GPIOCTRL 0x41 +#define MAX7360_REG_GPIODEB 0x42 +#define MAX7360_REG_GPIOCURR 0x43 +#define MAX7360_REG_GPIOOUTM 0x44 +#define MAX7360_REG_PWMCOM 0x45 +#define MAX7360_REG_RTRCFG 0x46 +#define MAX7360_REG_GPIOIN 0x49 +#define MAX7360_REG_RTR_CNT 0x4A +#define MAX7360_REG_PWMBASE 0x50 +#define MAX7360_REG_PWMCFG 0x58 + +#define MAX7360_REG_PORTCFGBASE 0x58 + +/* + * Configuration register bits + */ +#define MAX7360_FIFO_EMPTY 0x3f +#define MAX7360_FIFO_OVERFLOW 0x7f +#define MAX7360_FIFO_RELEASE BIT(6) +#define MAX7360_FIFO_COL GENMASK(5, 3) +#define MAX7360_FIFO_ROW GENMASK(2, 0) + +#define MAX7360_CFG_SLEEP BIT(7) +#define MAX7360_CFG_INTERRUPT BIT(5) +#define MAX7360_CFG_KEY_RELEASE BIT(3) +#define MAX7360_CFG_WAKEUP BIT(1) +#define MAX7360_CFG_TIMEOUT BIT(0) + +#define MAX7360_DEBOUNCE GENMASK(4, 0) +#define MAX7360_DEBOUNCE_MIN 9 +#define MAX7360_DEBOUNCE_MAX 40 +#define MAX7360_PORTS GENMASK(8, 5) + +#define MAX7360_INTERRUPT_TIME_MASK GENMASK(4, 0) +#define MAX7360_INTERRUPT_FIFO_MASK GENMASK(7, 5) + +#define MAX7360_PORT_CFG_INTERRUPT_MASK BIT(7) +#define MAX7360_PORT_CFG_INTERRUPT_EDGES BIT(6) + +#define MAX7360_REG_GPIOCURR_FIXED 0xC0 + +/* + * Autosleep register values (ms) + */ +#define MAX7360_AUTOSLEEP_8192 0x01 +#define MAX7360_AUTOSLEEP_4096 0x02 +#define MAX7360_AUTOSLEEP_2048 0x03 +#define MAX7360_AUTOSLEEP_1024 0x04 +#define MAX7360_AUTOSLEEP_512 0x05 +#define MAX7360_AUTOSLEEP_256 0x06 + +#define MAX7360_GPIO_CFG_RTR_EN BIT(7) +#define MAX7360_GPIO_CFG_GPIO_EN BIT(4) +#define MAX7360_GPIO_CFG_GPIO_RST BIT(3) + +#define MAX7360_ROT_DEBOUNCE GENMASK(3, 0) +#define MAX7360_ROT_DEBOUNCE_MIN 0 +#define MAX7360_ROT_DEBOUNCE_MAX 15 +#define MAX7360_ROT_INTCNT GENMASK(6, 4) +#define MAX7360_ROT_INTCNT_DLY BIT(7) + +#define MAX7360_INT_INTI 0 +#define MAX7360_INT_INTK 1 + +#define MAX7360_INT_GPIO 0 +#define MAX7360_INT_KEYPAD 1 +#define MAX7360_INT_ROTARY 2 + +#define MAX7360_NR_INTERNAL_IRQS 3 + +int max7360_port_pin_request(struct device *dev, unsigned int pin, bool request); + +#endif From patchwork Thu Dec 19 16:21:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Dubois-Briand X-Patchwork-Id: 852159 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E657228381; Thu, 19 Dec 2024 16:21:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734625323; cv=none; b=fv328ixsI88iaiejFviV8ZKae9nE/vGdp+sQv2+thqlpjHKYLmFtdmp51cszhsY+gEQFXibONJFqKdZ/ZAg1iWaMw5m6cQHkwqQmp8otFTOBokKGgZBZF15PUgiclkjM/xYDkc2/QFYV9hJH4zUbT6G8tYr0T3DNXMCLEO68JHM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734625323; c=relaxed/simple; bh=NKKK6m3TELHnW2cRSo1Kk+Wj76SXFUJ2uWnoCjAZsFY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=P0fN0QPHPL2psuZKsv9/UJQAMUH1xshOjaTNFczT7A0Jb8YamAiudJFd+qepPn4Cx5sUgB2GegG5Hhb1IT7MgEfqeuEU6YH2usiXlSbjz78DfkcXUjv6+xu0or3R2yiUWK/QwGas6gG5i4dmVbWwkCZBz1Jo7SNVLZemn75hwZ4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=oSZPluGl; arc=none smtp.client-ip=217.70.183.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="oSZPluGl" Received: by mail.gandi.net (Postfix) with ESMTPSA id 8D78860006; Thu, 19 Dec 2024 16:21:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1734625313; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N5XRZr3gsIuLzCYmmgqzJoRUGlzpyX2inEBWBRXtQkk=; b=oSZPluGlYajSX6Rc9a6dCYLRuNR/Fv1qtQgRa0Zg+szhf9S9WLeE8s7zlBLVOeQTAIR+mK vI1yl8wNbevHG8bhiELkrDmrn1n3/ExbZHT95CgnbtMod6kpdCqZBu+jtL+ARLnlWs1FWG 2aEsAMmMItGO2THmYt0n+3+t5v5SF5gNi+m78FG8t5prGnA2Cb1eOQ5/DaIxENoosF4urv Iek3IvILqEHxHuynH/DXUvldxFuwxjiPmM8q14CepOfUXgFe7CWl81OApVeILZUg/0XA1G TpBixykAsgD+56xaaTDFRXnlo66LJnelpQ41HAj0ftZ3nV5XHeoZW/ytWro+ng== From: Mathieu Dubois-Briand Date: Thu, 19 Dec 2024 17:21:23 +0100 Subject: [PATCH 6/8] input: keyboard: Add support for MAX7360 keypad Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241219-mdb-max7360-support-v1-6-8e8317584121@bootlin.com> References: <20241219-mdb-max7360-support-v1-0-8e8317584121@bootlin.com> In-Reply-To: <20241219-mdb-max7360-support-v1-0-8e8317584121@bootlin.com> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kamel Bouhara , Linus Walleij , Bartosz Golaszewski , Dmitry Torokhov , =?utf-8?q?Uwe_Kleine-K=C3=B6n?= =?utf-8?q?ig?= Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-input@vger.kernel.org, linux-pwm@vger.kernel.org, =?utf-8?q?Gr=C3=A9gory_Clement?= , Thomas Petazzoni , Mathieu Dubois-Briand X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1734625307; l=10712; i=mathieu.dubois-briand@bootlin.com; s=20241219; h=from:subject:message-id; bh=NKKK6m3TELHnW2cRSo1Kk+Wj76SXFUJ2uWnoCjAZsFY=; b=MIoi6JqektC3LUFRkKSZy4fwOY7p7XcJXe3y1wg59QwGkLbCr7h/OU7KQ8EE98YK12HqF4qyO GBlimW0tJa2B7i4mrkjjDRKWLd1BOqQHGOYJ5Dfiu7lBcEvdWUCD+HW X-Developer-Key: i=mathieu.dubois-briand@bootlin.com; a=ed25519; pk=1PVTmzPXfKvDwcPUzG0aqdGoKZJA3b9s+3DqRlm0Lww= X-GND-Sasl: mathieu.dubois-briand@bootlin.com Add driver for Maxim Integrated MAX7360 keypad controller, providing support for up to 64 keys, with a matrix of 8 columns and 8 rows. Signed-off-by: Mathieu Dubois-Briand --- drivers/input/keyboard/Kconfig | 12 ++ drivers/input/keyboard/Makefile | 1 + drivers/input/keyboard/max7360-keypad.c | 297 ++++++++++++++++++++++++++++++++ 3 files changed, 310 insertions(+) diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig index 721ab69e84ac..bba029f65cfa 100644 --- a/drivers/input/keyboard/Kconfig +++ b/drivers/input/keyboard/Kconfig @@ -421,6 +421,18 @@ config KEYBOARD_MAX7359 To compile this driver as a module, choose M here: the module will be called max7359_keypad. +config KEYBOARD_MAX7360 + tristate "Maxim MAX7360 Key Switch Controller" + select INPUT_MATRIXKMAP + depends on I2C + depends on MFD_MAX7360 + help + If you say yes here you get support for the keypad controller on the + Maxim MAX7360 I/O Expander. + + To compile this driver as a module, choose M here: the + module will be called max7360_keypad. + config KEYBOARD_MPR121 tristate "Freescale MPR121 Touchkey" depends on I2C diff --git a/drivers/input/keyboard/Makefile b/drivers/input/keyboard/Makefile index 1e0721c30709..b49d32d4003d 100644 --- a/drivers/input/keyboard/Makefile +++ b/drivers/input/keyboard/Makefile @@ -42,6 +42,7 @@ obj-$(CONFIG_KEYBOARD_LPC32XX) += lpc32xx-keys.o obj-$(CONFIG_KEYBOARD_MAPLE) += maple_keyb.o obj-$(CONFIG_KEYBOARD_MATRIX) += matrix_keypad.o obj-$(CONFIG_KEYBOARD_MAX7359) += max7359_keypad.o +obj-$(CONFIG_KEYBOARD_MAX7360) += max7360-keypad.o obj-$(CONFIG_KEYBOARD_MPR121) += mpr121_touchkey.o obj-$(CONFIG_KEYBOARD_MT6779) += mt6779-keypad.o obj-$(CONFIG_KEYBOARD_MTK_PMIC) += mtk-pmic-keys.o diff --git a/drivers/input/keyboard/max7360-keypad.c b/drivers/input/keyboard/max7360-keypad.c new file mode 100644 index 000000000000..fbc51c89dba1 --- /dev/null +++ b/drivers/input/keyboard/max7360-keypad.c @@ -0,0 +1,297 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright 2024 Bootlin + * + * Author: Mathieu Dubois-Briand + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +struct max7360_keypad { + struct input_dev *input; + unsigned int rows; + unsigned int cols; + unsigned int debounce_ms; + int irq; + bool no_autorepeat; + struct regmap *regmap; + unsigned short keycodes[MAX7360_MAX_KEY_ROWS * MAX7360_MAX_KEY_COLS]; +}; + +static irqreturn_t max7360_keypad_irq(int irq, void *data) +{ + struct max7360_keypad *max7360_keypad = data; + unsigned int val; + unsigned int row, col; + unsigned int release; + unsigned int code; + int ret; + + ret = regmap_read(max7360_keypad->regmap, MAX7360_REG_KEYFIFO, &val); + if (!ret && val == MAX7360_FIFO_OVERFLOW) { + /* FIFO overflow: ignore it and get next event. */ + dev_err(&max7360_keypad->input->dev, "max7360 FIFO overflow"); + ret = regmap_read(max7360_keypad->regmap, MAX7360_REG_KEYFIFO, + &val); + } + if (ret) { + dev_err(&max7360_keypad->input->dev, + "Failed to read max7360 FIFO"); + return ret; + } + + if (val == MAX7360_FIFO_EMPTY) { + dev_dbg(&max7360_keypad->input->dev, + "Got a spurious interrupt"); + + return IRQ_NONE; + } + + row = FIELD_GET(MAX7360_FIFO_ROW, val); + col = FIELD_GET(MAX7360_FIFO_COL, val); + release = val & MAX7360_FIFO_RELEASE; + + code = MATRIX_SCAN_CODE(row, col, MAX7360_ROW_SHIFT); + + dev_dbg(&max7360_keypad->input->dev, + "key[%d:%d] %s\n", row, col, release ? "release" : "press"); + + input_event(max7360_keypad->input, EV_MSC, MSC_SCAN, code); + input_report_key(max7360_keypad->input, max7360_keypad->keycodes[code], + !release); + input_sync(max7360_keypad->input); + + return IRQ_HANDLED; +} + +static int max7360_keypad_open(struct input_dev *pdev) +{ + struct max7360_keypad *max7360_keypad = input_get_drvdata(pdev); + int ret; + + /* + * Somebody is using the device: get out of sleep. + */ + ret = regmap_write_bits(max7360_keypad->regmap, MAX7360_REG_CONFIG, + MAX7360_CFG_SLEEP, MAX7360_CFG_SLEEP); + if (ret) { + dev_err(&max7360_keypad->input->dev, + "Failed to write max7360 configuration"); + return ret; + } + + return 0; +} + +static void max7360_keypad_close(struct input_dev *pdev) +{ + struct max7360_keypad *max7360_keypad = input_get_drvdata(pdev); + int ret; + + /* + * Nobody is using the device anymore: go to sleep. + */ + ret = regmap_write_bits(max7360_keypad->regmap, MAX7360_REG_CONFIG, + MAX7360_CFG_SLEEP, ~MAX7360_CFG_SLEEP); + if (ret) { + dev_err(&max7360_keypad->input->dev, + "Failed to write max7360 configuration"); + } +} + +static int max7360_keypad_hw_init(struct max7360_keypad *max7360_keypad) +{ + unsigned int val; + int ret; + + val = max7360_keypad->debounce_ms - MAX7360_DEBOUNCE_MIN; + ret = regmap_write_bits(max7360_keypad->regmap, MAX7360_REG_DEBOUNCE, + MAX7360_DEBOUNCE, + FIELD_PREP(MAX7360_DEBOUNCE, val)); + if (ret) { + dev_err(&max7360_keypad->input->dev, + "Failed to write max7360 debounce configuration"); + return ret; + } + + ret = regmap_write_bits(max7360_keypad->regmap, MAX7360_REG_INTERRUPT, + MAX7360_INTERRUPT_TIME_MASK, + FIELD_PREP(MAX7360_INTERRUPT_TIME_MASK, 1)); + if (ret) { + dev_err(&max7360_keypad->input->dev, + "Failed to write max7360 keypad interrupt configuration"); + return ret; + } + + return 0; +} + +static int max7360_keypad_parse_dt(struct platform_device *pdev, + struct max7360_keypad *max7360_keypad) +{ + bool no_autorepeat; + int ret; + + ret = matrix_keypad_parse_properties(&pdev->dev, &max7360_keypad->rows, + &max7360_keypad->cols); + if (ret) + return ret; + + if (!max7360_keypad->rows || !max7360_keypad->cols || + max7360_keypad->rows > MAX7360_MAX_KEY_ROWS || + max7360_keypad->cols > MAX7360_MAX_KEY_COLS) { + dev_err(&pdev->dev, + "Invalid number of columns or rows (%ux%u)\n", + max7360_keypad->cols, max7360_keypad->rows); + return -EINVAL; + } + + max7360_keypad->regmap = dev_get_regmap(pdev->dev.parent, NULL); + if (!max7360_keypad->regmap) { + dev_err(&pdev->dev, "Could not get parent regmap\n"); + return -ENODEV; + } + + no_autorepeat = of_property_read_bool(pdev->dev.of_node, + "linux,input-no-autorepeat"); + max7360_keypad->no_autorepeat = no_autorepeat; + + max7360_keypad->debounce_ms = MAX7360_DEBOUNCE_MIN; + ret = of_property_read_u32(pdev->dev.of_node, "debounce-delay-ms", + &max7360_keypad->debounce_ms); + if (ret == -EINVAL) { + dev_info(&pdev->dev, "Using default debounce-delay-ms: %u\n", + max7360_keypad->debounce_ms); + } else if (ret < 0) { + dev_err(&pdev->dev, "Failed to read debounce-delay-ms property\n"); + return ret; + } else if (max7360_keypad->debounce_ms < MAX7360_DEBOUNCE_MIN || + max7360_keypad->debounce_ms > MAX7360_DEBOUNCE_MAX) { + dev_err(&pdev->dev, + "Invalid debounce-delay-ms: %u, should be between %u and %u.\n", + max7360_keypad->debounce_ms, MAX7360_DEBOUNCE_MIN, + MAX7360_DEBOUNCE_MAX); + return -EINVAL; + } + + return 0; +} + +static int max7360_keypad_probe(struct platform_device *pdev) +{ + struct max7360_keypad *max7360_keypad; + struct input_dev *input; + unsigned long flags; + int irq; + int ret; + + if (!pdev->dev.parent) + return dev_err_probe(&pdev->dev, -ENODEV, "No parent device\n"); + + irq = platform_get_irq(pdev, 0); + if (irq < 0) + return irq; + + max7360_keypad = devm_kzalloc(&pdev->dev, sizeof(*max7360_keypad), + GFP_KERNEL); + if (!max7360_keypad) + return -ENOMEM; + + ret = max7360_keypad_parse_dt(pdev, max7360_keypad); + if (ret) + return ret; + + input = devm_input_allocate_device(&pdev->dev); + if (!input) + return dev_err_probe(&pdev->dev, -ENOMEM, + "Failed to allocate input device\n"); + + max7360_keypad->input = input; + + input->id.bustype = BUS_I2C; + input->name = pdev->name; + input->dev.parent = &pdev->dev; + + input->open = max7360_keypad_open; + input->close = max7360_keypad_close; + + ret = matrix_keypad_build_keymap(NULL, NULL, + MAX7360_MAX_KEY_ROWS, + MAX7360_MAX_KEY_COLS, + max7360_keypad->keycodes, input); + if (ret) + return dev_err_probe(&pdev->dev, ret, + "Failed to build keymap\n"); + + input_set_capability(input, EV_MSC, MSC_SCAN); + if (!max7360_keypad->no_autorepeat) + __set_bit(EV_REP, input->evbit); + + input_set_drvdata(input, max7360_keypad); + + flags = IRQF_TRIGGER_LOW | IRQF_ONESHOT | IRQF_SHARED; + ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, + max7360_keypad_irq, flags, + "max7360-keypad", max7360_keypad); + if (ret) + return dev_err_probe(&pdev->dev, ret, + "Failed to register interrupt: %d\n", ret); + + ret = input_register_device(input); + if (ret) + return dev_err_probe(&pdev->dev, ret, + "Could not register input device: %d\n", + ret); + + platform_set_drvdata(pdev, max7360_keypad); + + device_init_wakeup(&pdev->dev, true); + ret = dev_pm_set_wake_irq(&pdev->dev, irq); + if (ret) + dev_warn(&pdev->dev, "Failed to set up wakeup irq: %d\n", ret); + + ret = max7360_keypad_hw_init(max7360_keypad); + if (ret) + return dev_err_probe(&pdev->dev, ret, + "Failed to initialize max7360 keypad\n"); + + return 0; +} + +static void max7360_keypad_remove(struct platform_device *pdev) +{ + dev_pm_clear_wake_irq(&pdev->dev); +} + +#ifdef CONFIG_OF +static const struct of_device_id max7360_keypad_of_match[] = { + { .compatible = "maxim,max7360-keypad", }, + { } +}; +MODULE_DEVICE_TABLE(of, max7360_keypad_of_match); +#endif + +static struct platform_driver max7360_keypad_driver = { + .driver = { + .name = "max7360-keypad", + .of_match_table = of_match_ptr(max7360_keypad_of_match), + }, + .probe = max7360_keypad_probe, + .remove = max7360_keypad_remove, +}; +module_platform_driver(max7360_keypad_driver); + +MODULE_DESCRIPTION("MAX7360 Keypad driver"); +MODULE_AUTHOR("Mathieu Dubois-Briand "); +MODULE_ALIAS("platform:max7360-keypad"); +MODULE_LICENSE("GPL"); From patchwork Thu Dec 19 16:21:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Dubois-Briand X-Patchwork-Id: 852162 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65E7A22616F; Thu, 19 Dec 2024 16:21:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734625318; cv=none; b=F2VpgwI8UOSd18JXHjNKawkdlYWKhxB6F05fmZimGZ4HeC9iUBdGdmIMjvznrTYh3EZCK6TomJWz1Db4NSekjsb/HVzYuzgkNM+Kz88IWl4zKSBtHkTok9up2rVFehQMv+x9OI9goe34qBBHSykz05uJ3X40SAdrkt07eE5D2YU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734625318; c=relaxed/simple; bh=MMa1aWrpC+Hhbb5vbJvmx5OLBFFy4Ju1nNEWOoDy1s0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kvPZPQ7VIDbW6jN1dsDl1ximME9NFZ5qHGXjukoybUCBpO4vVW22cOcCktk6LKlVHK3d0zX2N0pWFjdQGnpQ0LyeRmIVaeVspxwfDNQSoN9vo1Z1/jR/nvAvBuJggPIEXVfOqsAXonbmBZBizQXcXkBmBVO4YR0mcguMKUN8TW4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=IYvEwIrr; arc=none smtp.client-ip=217.70.183.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="IYvEwIrr" Received: by mail.gandi.net (Postfix) with ESMTPSA id 21D5760012; Thu, 19 Dec 2024 16:21:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1734625314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m5ZGJQUU63vFd9YFgXUTncUS1ermsqmNadQRrooj508=; b=IYvEwIrr1nm8nr0nts6jaOChHC8gDWyyW8FNiEJ6EXYxNBVqwxRMLryLTC2SThG4LFjw/R /PQizCekvhUcIDfCo8TZ//7H1IzV7CIy1dAzNgeuw73DEJpZ769gD8NcUFI6Ov0Q0oIkY4 rXxB0/TMu7S+gSJs6O5PsHKWgCfwmw3yeo1JLprCbZeRcOasBTqJ9/nf+mW0+tyZeFdUC8 3pJ4QhjnhjhnjJVn1UEFt356Kyg5rzA1H4U7nV0CKVt2R8mFs5XuY4ythJtvpwz7GY2lDf miDtaKgWa4jZ3uPGOS9HIIRmJ8gwQGj2vwftmEp6uJKqVk1/XtfRZFHIVdnl2A== From: Mathieu Dubois-Briand Date: Thu, 19 Dec 2024 17:21:25 +0100 Subject: [PATCH 8/8] MAINTAINERS: Add entry on MAX7360 driver Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241219-mdb-max7360-support-v1-8-8e8317584121@bootlin.com> References: <20241219-mdb-max7360-support-v1-0-8e8317584121@bootlin.com> In-Reply-To: <20241219-mdb-max7360-support-v1-0-8e8317584121@bootlin.com> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kamel Bouhara , Linus Walleij , Bartosz Golaszewski , Dmitry Torokhov , =?utf-8?q?Uwe_Kleine-K=C3=B6n?= =?utf-8?q?ig?= Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-input@vger.kernel.org, linux-pwm@vger.kernel.org, =?utf-8?q?Gr=C3=A9gory_Clement?= , Thomas Petazzoni , Mathieu Dubois-Briand X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1734625307; l=1024; i=mathieu.dubois-briand@bootlin.com; s=20241219; h=from:subject:message-id; bh=MMa1aWrpC+Hhbb5vbJvmx5OLBFFy4Ju1nNEWOoDy1s0=; b=gJY9TqsxOErNI5KgRO1RC6t1fWCzwGBuuTSDUM7w5JJ+7zQdNKlWEvEBaOdF6oNgYAA9/2gjA Z5c0nJDYA8DDVL6elxigwvZ2oULzCD8E85p8oXOcv/QiR/BhSxW8ZQH X-Developer-Key: i=mathieu.dubois-briand@bootlin.com; a=ed25519; pk=1PVTmzPXfKvDwcPUzG0aqdGoKZJA3b9s+3DqRlm0Lww= X-GND-Sasl: mathieu.dubois-briand@bootlin.com Add myself as maintainer of Maxim MAX7360 driver and device-tree bindings. Signed-off-by: Mathieu Dubois-Briand --- MAINTAINERS | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index baf0eeb9a355..6e9b8caebb38 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14132,6 +14132,18 @@ L: linux-iio@vger.kernel.org S: Maintained F: drivers/iio/temperature/max30208.c +MAXIM MAX7360 KEYPAD LED MFD DRIVER +M: Mathieu Dubois-Briand +S: Maintained +F: Documentation/devicetree/bindings/*/max7360-*.yaml +F: Documentation/devicetree/bindings/mfd/max7360.yaml +F: drivers/gpio/gpio-max7360.c +F: drivers/input/keyboard/max7360-keypad.c +F: drivers/input/misc/max7360-rotary.c +F: drivers/mfd/max7360.c +F: drivers/pwm/pwm-max7360.c +F: include/linux/mfd/max7360.h + MAXIM MAX77650 PMIC MFD DRIVER M: Bartosz Golaszewski L: linux-kernel@vger.kernel.org