From patchwork Fri Dec 20 01:54:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alistair Francis X-Patchwork-Id: 852340 Delivered-To: patch@linaro.org Received: by 2002:a5d:4888:0:b0:385:e875:8a9e with SMTP id g8csp1814200wrq; Thu, 19 Dec 2024 17:59:21 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWNXGs1VjEz8EVszGX+muYZrOU6BPkHZTEWz7E0Hvr0dVVMO2/liJCrZrKNKRX1DFPtEHLZlg==@linaro.org X-Google-Smtp-Source: AGHT+IHsx3+xyQRmaigprWEijM+WsXqR8sXfaXKJTDvxwYtFHNdODrOaujRDDCucWGzagT2g6Vt+ X-Received: by 2002:a05:6214:202d:b0:6d8:ab7e:e552 with SMTP id 6a1803df08f44-6dd23397311mr24556256d6.39.1734659961108; Thu, 19 Dec 2024 17:59:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1734659961; cv=none; d=google.com; s=arc-20240605; b=Vlgd5WMUWhfdh/MQIKU5u1feqsnlBY8GHWZ4EJaloz6+ovU3tr03n3DrkFKLir12eg RkwDHj0uetVuKoqhD+J+nU1KA5S/CsiBaYwTmdUQq7bhjU6KGRS31PfTygVkJap/rrW0 YOK+antcYGNFbmo6/ntmmEZkXvDfRdvlGI49Z/AqcFWRrIdCNfGmEt85RE60UugR31c8 IKEuQ79Erb91t+UPkC90pZOExe6qGQMHGSCPoC/xh7us3/zm6YLZX6eGGIRvM6fVHKla TSno0yPeQ5ydQ9pVGH+GTG5CJ2vR/hkwNbV2ooFgOYLlsnxkapauwgU4PVJfBp8+9NdO oMlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=QJY1Flxg9aXR92n2V8B8X5lq0zaZewnkQsTGkMNreb8=; fh=hOsOEs8aEq9LJJTsYsIoWx0jWixGs6ALmHBYDbZCZmk=; b=Mz6BYpsZXhz0+kLypHciWJjoaY9YLyaMl0OGIDLshGQNVtWb7Jx3t07kI6zoYQq33u HkMJYyt5+olF6TCUQzvmXPoLz8tVyLpX9TRxrOybaSev7WPCRLX7sSG2VJ8KWVp9QAH6 bco9EDWNaLSYaWPLqpzsWnRCzF5CBM5haFFI2NB9Y92s6dhIPC+jJXuspwa5NDYCAzVn Jt7mm4zSvoWi1l2IuF9jrI3Kvkq65LjnQ1brJ02EOo2FEzDtfi2jwJa//zHOHa1Hhix/ OGykakRY1AYfASStbGAtcSpvpKoGcqA/WJdybG1qAjOf+wcsydf4N8GozDh0xKxVtpFG XClw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=ZaM7VMSr; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6dd18104927si31996916d6.54.2024.12.19.17.59.20 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 19 Dec 2024 17:59:21 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=ZaM7VMSr; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tOSFf-0007m0-RM; Thu, 19 Dec 2024 20:56:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOSFJ-00075x-FD for qemu-devel@nongnu.org; Thu, 19 Dec 2024 20:56:07 -0500 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tOSFH-0004Xv-UL for qemu-devel@nongnu.org; Thu, 19 Dec 2024 20:56:05 -0500 Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-728f1525565so1731978b3a.1 for ; Thu, 19 Dec 2024 17:56:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734659762; x=1735264562; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QJY1Flxg9aXR92n2V8B8X5lq0zaZewnkQsTGkMNreb8=; b=ZaM7VMSrQFLF3vhnYqcvm3kFbzeFqBjJ9Cn0BqhqEvVwVAa36oXzzaHjC/CujLfglX nn0VM5V1W+alQ3KW1MwcwMiXPKcMeMXsnDG2w7WLpiMyiOD1jpEuadVdqiCOgQfYl7yZ ZZDk03wBePt7pu/UmlNeVHx3u0xYi/nehl+xdnjNxzZjnuavHJ0XC5m4Hm9rXiw1aTtm Q6tAbEBJS0gQ20HTKvM9Nj9Qx9WmgsvsHJdnV9LqIoKZfemjqeze0OX6cNjFBtN/zZ2o VmcWvYN9EcIgAsL8ZaU8RBFAFdGNcawZy8bG1USSeqGkS78c4rd3a7ObLYHruE1YxCqm xYAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734659762; x=1735264562; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QJY1Flxg9aXR92n2V8B8X5lq0zaZewnkQsTGkMNreb8=; b=M2eHN8UdN0g66FhnH94snFep/DyFPIlH1seoLzQs3N6FtzkrVJVeIXexSvoWvLg7nW 07TBHkfp/q+yaxSszqW2LY976vm11pczhvemvC5ls+ZssHIb/8bJRZNFosz9Jj7dUCFW mRgFSQ4ut9vvgXs0cs+qUN1uCkqzKPLvwtidqcy5Fn0ShZwF1IsdnzjjksdlAglKIEVK +5TbgLh7ICRRecAG1tBohXnmFWDTX1cecCj++DoTjimTv8imaOa4mK/qQqIF+2gtnnEQ oKO7s4eJACHlMV82VBcNkealJpIpLRF5WMm7xWl7taYE8j2/aY3B9lsJGZkPI1bZTYHh rdSQ== X-Gm-Message-State: AOJu0Yw2O0k3LDSEmi1Ge82MADB1JDT7keYQG8rz+TnY2+rT9MmK0tUV X0QDLf1ZFsNOSgOivLaY+N8/OpR2TSbx9SOcBHcPo4vThGEWm6MKhUc7413T X-Gm-Gg: ASbGnctvQTdihXTlkG8vELarPnHUBVh7/W25tIsSgWeLunFI2IQx7V2WTl58UuCuEJ2 CVlGvYNaBe6h37xSQIQKxIVkXJwAuerqALVspp84bP7HWXurTWlblkoqgwLtZ4TsjPkL4wJRw9A BWKeyUEhZdj9bWVFh8UfmErsmv9d0XnwdJ+DMlY02EMgm0GzL2SugUKQcFJ40f3QkH/jqRgUmYv M55rz2ko1YgGSN5dN7a8MUtEO0Z+jr2u3yUnAHNKP2nYYjdWmaIIrqPyirp7TOqlztM2doY/JIm AwNrsW2XsD5svmZVrQtzSh/XCZ9GlgOTB2Xv8xSnOy/Oscqvw8P53N/0Rg4bqNU= X-Received: by 2002:a05:6a21:3998:b0:1dc:2a02:913b with SMTP id adf61e73a8af0-1e5e0459dbemr2424097637.15.1734659762483; Thu, 19 Dec 2024 17:56:02 -0800 (PST) Received: from toolbox.alistair23.me (2403-580b-97e8-0-82ce-f179-8a79-69f4.ip6.aussiebb.net. [2403:580b:97e8:0:82ce:f179:8a79:69f4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad8164d3sm2002539b3a.15.2024.12.19.17.55.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2024 17:56:02 -0800 (PST) From: Alistair Francis X-Google-Original-From: Alistair Francis To: qemu-devel@nongnu.org Cc: alistair23@gmail.com, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Alistair Francis , Daniel Henrique Barboza Subject: [PULL v2 23/39] MAINTAINERS: Cover RISC-V HTIF interface Date: Fri, 20 Dec 2024 11:54:23 +1000 Message-ID: <20241220015441.317236-24-alistair.francis@wdc.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241220015441.317236-1-alistair.francis@wdc.com> References: <20241220015441.317236-1-alistair.francis@wdc.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::435; envelope-from=alistair23@gmail.com; helo=mail-pf1-x435.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé The HTIF interface is RISC-V specific, add it within the MAINTAINERS section covering hw/riscv/. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Reviewed-by: Daniel Henrique Barboza Message-ID: <20241129154304.34946-2-philmd@linaro.org> Signed-off-by: Alistair Francis --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index fb6a66f1f8..1076a028a1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -324,8 +324,10 @@ S: Supported F: configs/targets/riscv* F: docs/system/target-riscv.rst F: target/riscv/ +F: hw/char/riscv_htif.c F: hw/riscv/ F: hw/intc/riscv* +F: include/hw/char/riscv_htif.h F: include/hw/riscv/ F: linux-user/host/riscv32/ F: linux-user/host/riscv64/ From patchwork Fri Dec 20 01:54:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alistair Francis X-Patchwork-Id: 852342 Delivered-To: patch@linaro.org Received: by 2002:a5d:4888:0:b0:385:e875:8a9e with SMTP id g8csp1814515wrq; Thu, 19 Dec 2024 18:00:27 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCU+RnuQVsWeVz23KPwnrbfT/QdU/g8e0XvXmFn2JQlhr9+afdQ5cqejaLevXNULtM1WH3U44Q==@linaro.org X-Google-Smtp-Source: AGHT+IFYVtM1H7hLNp3l61sKfvLVxOn3F2ixEApxsatJFcPR9Z+1OQC8m44hCxuskQDNxjm29utN X-Received: by 2002:a05:620a:2453:b0:7b1:880c:5805 with SMTP id af79cd13be357-7b9ba7e60eemr172605385a.45.1734660027744; Thu, 19 Dec 2024 18:00:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1734660027; cv=none; d=google.com; s=arc-20240605; b=Di40EYuvVq6oDDaQ3obxfwwLRd9ERysQBucdsfZC0akviBZxkXMkdM1AW0JcWJLcE+ 8AjV4WVnh2BElPkubtdtJcu/2Gsjo4783YNv3d2bvbCTf3U7ALUeZfcwUggd7NmlmB5K jiFkGl79ijqnjQgdxZddkkmmoHhz2kp5EBPawK7cBYDNiTSlSRQVXaFTzrKAf30kZeZZ YBoN19lOtaBESgTJEtRZx0zQdtGZtUBKI8k0u3/C0RPtKnn1zlWl5I3YwFsHa8glysnE +aSe8Kr5LlDW69NtoUWKmnw1SDPGCY7eqsCP8HQEX6tK9Ut4GKktd9VxNAOAVl/4XTc4 4f9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Xpx/pC7csSWAMTwJpfy2pCt1TJXuOjp6x6k2PZQ7S2E=; fh=hOsOEs8aEq9LJJTsYsIoWx0jWixGs6ALmHBYDbZCZmk=; b=BreDsAhPgwn7Xauy5gjEiMZ1ydu5YNqTlb6wm9bY0BPmltZ3aFb1JRibNZoD2j5MeT WuDbaMcRValC/G4EYMEfhZNSSeOWChljRaKN0B6uVAPAseM1dgc9VP1DUKfmcqZ19uyI O70C9Y2smXiOHRI/Rxw0T1srzh2O05FjXsh1JOVPvlOFIVzoCmj8zU8extZ3G9vKhkJ2 hoFaHzFyYv2au+28BUq8860J7qAJxXmxrZZJpNQ2YdTTn2aUKfiMG6IGaoRoeOyqk8l0 K7PjiAczr0qbjmqa+ZNRBe6uBitqlUN7+ZqlJ1LT58IgClQcMUMlT+Y09b5J9itnGkY/ 2zXQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Qo0PDFdY; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7b9ac2d1164si294005685a.192.2024.12.19.18.00.27 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 19 Dec 2024 18:00:27 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Qo0PDFdY; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tOSFh-0007vG-66; Thu, 19 Dec 2024 20:56:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOSFN-0007H4-2k for qemu-devel@nongnu.org; Thu, 19 Dec 2024 20:56:12 -0500 Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tOSFL-0004YP-FZ for qemu-devel@nongnu.org; Thu, 19 Dec 2024 20:56:08 -0500 Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-725f4623df7so1381886b3a.2 for ; Thu, 19 Dec 2024 17:56:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734659765; x=1735264565; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Xpx/pC7csSWAMTwJpfy2pCt1TJXuOjp6x6k2PZQ7S2E=; b=Qo0PDFdY1PGXXdO30RFafuBukXXj68G5NgXmOmBYQYgqM7kdzCkq05mt0a1WbPHhfk mPJUvNvwj1VbTIcMyh4jez1y82qflwS6RbKQIMTb9UUQJYEOAnao9yZb4lPL2bygZmwC vCjJMDy60HP9XCUcJqlghF690RdxzDto7MmuTQf+VroKhjsa1gj6Tu/lL+pLFzYPGlBO VkM4EyoyN9C3pAp/8m8P/BNpcyNJ+E0IOyRMTYPuwf6P9rlLSjY73Gk83ceJ13xKY7lo 1NFvy5vC8cFzr0XKVmUcMBndpU1sVws+/onlh4JhfFbWc+rbuh20aD8CoLYcPslEZ6ro rIrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734659765; x=1735264565; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Xpx/pC7csSWAMTwJpfy2pCt1TJXuOjp6x6k2PZQ7S2E=; b=hdUMmpxmTHjBeS9hOaBHMizAd9eLH3LMBub26DAHJReyUqZOYWU9RfxBtgLJXaPQJB K+ezf+Qav54ZoxHoYevlwnlwVOmdDK/ooI/jd9yTyUZzBiU8/ak5mLY+Fdy9q1Encx3Y 6oHFP/wQBBn6Y34zOZ/oJh1BzOs2V6I8F9byjSPYFqWoPDGWOrRhm1+OKTlEUSUgAKX0 zoSwJnuqGflRrvuMed1I4MQChVcuXeTtBAqMXZi7U1j0/Sz1D1+A1lSiEERka0ej8Jmr J3MIHeZdvDvA5zy5d3WfhQIu/28SYGBmLFHgAsYdvvzwH1xHWDDwdbDtCf/sbSqLO1hY XT1Q== X-Gm-Message-State: AOJu0YzW3u+OZQvjLyBuh2+MC+r1O4kFbJ1NRS3RRnBDEF6H4cF3T6+b aUjkJSOsXpjDmR3z4uUbdiXms9O+XB5wbGzzY+/QuepcgOFKeuVvo5H58mpz X-Gm-Gg: ASbGnculOGt9TMUChY+84gFr2e3WKvlv8Z5Q38YmDQ+g/LSmjKrUvSObATpWmerS/Vg b3wiPyJyp3DDOCneebygAznv8WOavdAt5bC8POwE7nNkMsiczOvPwnLDAdrh/CB8ppk6i60BsRT +ZsyRWAHSrKTDOYx/T8jfM/OTFYgJ85kRNz7km6uSZ7x50zbW+uPSPZM1d5rq6T7JRxVWgDV/JA jTVZHLoeWmRWbJLjaxWnpXp7X+CHgjN635o2LiiGh5ODjctmX3ZmD/U+VvAhcx43d0z00O8qrfz zsw2+7Xxc3va4GQ6aEpU3D7Grjrm0rOlwlavcxmidydfDsVdJG3RASyZIXFAqoQ= X-Received: by 2002:a05:6a00:35ca:b0:724:f86e:e3d9 with SMTP id d2e1a72fcca58-72abdecbdb4mr1324997b3a.14.1734659765511; Thu, 19 Dec 2024 17:56:05 -0800 (PST) Received: from toolbox.alistair23.me (2403-580b-97e8-0-82ce-f179-8a79-69f4.ip6.aussiebb.net. [2403:580b:97e8:0:82ce:f179:8a79:69f4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad8164d3sm2002539b3a.15.2024.12.19.17.56.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2024 17:56:05 -0800 (PST) From: Alistair Francis X-Google-Original-From: Alistair Francis To: qemu-devel@nongnu.org Cc: alistair23@gmail.com, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Alistair Francis , Daniel Henrique Barboza Subject: [PULL v2 24/39] hw/char/riscv_htif: Explicit little-endian implementation Date: Fri, 20 Dec 2024 11:54:24 +1000 Message-ID: <20241220015441.317236-25-alistair.francis@wdc.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241220015441.317236-1-alistair.francis@wdc.com> References: <20241220015441.317236-1-alistair.francis@wdc.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::42e; envelope-from=alistair23@gmail.com; helo=mail-pf1-x42e.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé Since our RISC-V system emulation is only built for little endian, the HTIF device aims to interface with little endian memory accesses, thus we can explicit htif_mm_ops:endianness being DEVICE_LITTLE_ENDIAN. In that case tswap64() is equivalent to le64_to_cpu(), as in "convert this 64-bit little-endian value into host cpu order". Replace to simplify. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Reviewed-by: Daniel Henrique Barboza Message-ID: <20241129154304.34946-3-philmd@linaro.org> Signed-off-by: Alistair Francis --- hw/char/riscv_htif.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/hw/char/riscv_htif.c b/hw/char/riscv_htif.c index 0345088e8b..3f84d8d673 100644 --- a/hw/char/riscv_htif.c +++ b/hw/char/riscv_htif.c @@ -29,7 +29,7 @@ #include "qemu/timer.h" #include "qemu/error-report.h" #include "exec/address-spaces.h" -#include "exec/tswap.h" +#include "qemu/bswap.h" #include "sysemu/dma.h" #include "sysemu/runstate.h" @@ -212,11 +212,11 @@ static void htif_handle_tohost_write(HTIFState *s, uint64_t val_written) } else { uint64_t syscall[8]; cpu_physical_memory_read(payload, syscall, sizeof(syscall)); - if (tswap64(syscall[0]) == PK_SYS_WRITE && - tswap64(syscall[1]) == HTIF_DEV_CONSOLE && - tswap64(syscall[3]) == HTIF_CONSOLE_CMD_PUTC) { + if (le64_to_cpu(syscall[0]) == PK_SYS_WRITE && + le64_to_cpu(syscall[1]) == HTIF_DEV_CONSOLE && + le64_to_cpu(syscall[3]) == HTIF_CONSOLE_CMD_PUTC) { uint8_t ch; - cpu_physical_memory_read(tswap64(syscall[2]), &ch, 1); + cpu_physical_memory_read(le64_to_cpu(syscall[2]), &ch, 1); /* * XXX this blocks entire thread. Rewrite to use * qemu_chr_fe_write and background I/O callbacks @@ -324,6 +324,7 @@ static void htif_mm_write(void *opaque, hwaddr addr, static const MemoryRegionOps htif_mm_ops = { .read = htif_mm_read, .write = htif_mm_write, + .endianness = DEVICE_LITTLE_ENDIAN, }; HTIFState *htif_mm_init(MemoryRegion *address_space, Chardev *chr, From patchwork Fri Dec 20 01:54:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alistair Francis X-Patchwork-Id: 852343 Delivered-To: patch@linaro.org Received: by 2002:a5d:4888:0:b0:385:e875:8a9e with SMTP id g8csp1815027wrq; Thu, 19 Dec 2024 18:01:31 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCVncUBTzMWktIdGRat5tUsIc+Yb8CUnoLk3kqKdbIEbNAScyYD2CzeBuI9HoUnXNsYCg1dtgg==@linaro.org X-Google-Smtp-Source: AGHT+IELFTV7Yzy9ALPfxAPA/UZAXjuFrNvbajqlkCSHBBeFfXmw4FExzEqwUPRWlzFoykDCb0fV X-Received: by 2002:a05:620a:24ce:b0:7b6:913f:3df3 with SMTP id af79cd13be357-7b9ba83650amr220913085a.47.1734660091667; Thu, 19 Dec 2024 18:01:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1734660091; cv=none; d=google.com; s=arc-20240605; b=L4qULGybzzW0eN5aI6at7wLS6PlASPildtx2/62gcZgqrWH6GH9dlvYXo47yUAgQ9o gKZrGRXcyECsqgw4pVXxsotuZKVHhaMmOsWyKiFZ0LaNDSDSNHW86AYfFrB5+e1DCoTS 1cIR0pc6Nggdi47XQtIuqf/UAsv/TGTFFqUiQJGgN7HQ0zABjwtu+Qc796BkpmAIQgTX 6LVaH7keUZ9W3fq1WXlQASctA/oVDFUK8NwKPvvtGHGLFE1UvMWAgBuz5+CB4pFZaR9K +5yR0JY3rjRqBW7ocbxWZlxrzETs82wJdBm07ZSecrKItFi7x9GKJtutYtQ5HA3MqFn7 ticg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=csnlmIZP9qWpoQxYhNQ4ejdvpdIVgMo5uAQbmxbPJDc=; fh=hOsOEs8aEq9LJJTsYsIoWx0jWixGs6ALmHBYDbZCZmk=; b=D/8vma+3J9u9sQdiLsuuXbp5ZRGsCK1frUJ9+7idFzbsKhps/EAD7LKY5hdm8bmi8a gEg7HDUBiETRH/h825w6g04NLKbuWhyd0l5XT6cU/NQHxOVnHOwxrvNYlVX+anXFZZnh b2VzE2PECi7S2aaTBDsvPdc4M9p+oUQPZ4GVw3Dj36gQgWUbkH6s8RV+XKxnGUdVaVcR gxKgTgiQ7kFX5YLMqoTArthET/loteGI/A7A4eiidm+4hSdbrvVaePi10ETlXCZVQApv L0jzKGMBFPTap64H479zaM1DOeUgM+rSNikRRXUVL0XdMm1YKmdo8B1PRsmc3Tqm6GON QtkQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=fBMb0cND; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7b9ac2ad40fsi302830985a.88.2024.12.19.18.01.31 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 19 Dec 2024 18:01:31 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=fBMb0cND; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tOSFm-0008Vu-F3; Thu, 19 Dec 2024 20:56:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOSFS-0007Vq-1B for qemu-devel@nongnu.org; Thu, 19 Dec 2024 20:56:17 -0500 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tOSFP-0004Yx-0Y for qemu-devel@nongnu.org; Thu, 19 Dec 2024 20:56:13 -0500 Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-7273967f2f0so1734102b3a.1 for ; Thu, 19 Dec 2024 17:56:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734659768; x=1735264568; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=csnlmIZP9qWpoQxYhNQ4ejdvpdIVgMo5uAQbmxbPJDc=; b=fBMb0cND5GjSTuE1/fmFwBx3WSEcIJprb6Pzr/4as8ykPBEN6AjRhGKN91snFF+FdZ rJlxHf4ddqcVZ903GYndRYgHUX1NRIQaGTee0VY7bRI757tIeSndAxmjkK7Ic1sV+EUV efDHjHgQuKVAhnc+TEmeAJs04uzJlwmp/+mnHiVMzSmN/sbPtgMzw84oz4CPcQsUOoWu n3jsbu36a6Ah8bmqcG9n6DGITBD/d1V5zoutYDX+MGOSlgns5kAgWlKaD/RijfXZue/B PXs+zkQgBqSmIuiSfGf/0Dp/UWmHf4JaLYmOyUFpAmPAcsO198m4Y9U+jeVPe6DtHr4D Lbeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734659768; x=1735264568; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=csnlmIZP9qWpoQxYhNQ4ejdvpdIVgMo5uAQbmxbPJDc=; b=llFq1iwMzDv2MpHLEhygleHeTaZXXK2KcvFL5RWCNpCqf36wPgTYr1lJFLbTuKB+zy aEIH9N4RLHtjySm483nyk6FuuTHR2XHgNurNoh1/TxrHHaCUJyutaNM8zOdgZN/QdzUr OPrD6DMWstRaDUOC5l1yuL/Ju6Nd38FXoUBBvLKndViit4cPXjoLSmlSoUDDUHDnOBz5 fR12YUp3yotTOMIYoiHgme181Oc9mSwZDk6XKD+1jsIPSoo3uxcw8e/bvb8uEuMO/ndO QR3m04MPoOnuHZCgqrlOb0msexyF9MVVQZ2dt8m3xGOALUsE5ACR1itX6MGv3kvv5dhx ED9g== X-Gm-Message-State: AOJu0YxeW9YDIxNKWX5dtYuVh1+9ST6VMzWSEAI32+aNUQm0j4IhSBNm iLDA0mkc148D1VqCJjXbkdnNHLRcFmE6cXg/q7LTSKcMdiORGgDf1uCZmFDt X-Gm-Gg: ASbGncsHwyFuaQ6Ql+X3jewQyGoaFkDCsXbZ8IxOeXKoygb362j1eSVEZMSA4N3PGAz fSZlK2TBySkLIKm1RyQZ+tM46YotoO4Z4CUqGsdq0pz6AH8rKH/dDR4bdtelCMJugDJtvUSCRlQ 0B/Pjzw2MMwrO0U3J8vQS8bbgRhRTiO6PtsKW+QGzSSkampU48PHLz7yNLWJKolqva8//MKwSIf jMupln0JvFWzbZPOW9jPxNMereU9WacJV5cdlVhY3zSkrbl5ay8xq7AsbIeOfDxDtiQQsAfYvxn LwNs/CbKC1uk/Lq8sx88rFCObzHOsSexg+jaVDgA4PP7WqjxzXdO+Dp8/egTNqo= X-Received: by 2002:a05:6a21:6d9e:b0:1e1:ab03:866d with SMTP id adf61e73a8af0-1e5e0458e4amr2112155637.3.1734659768532; Thu, 19 Dec 2024 17:56:08 -0800 (PST) Received: from toolbox.alistair23.me (2403-580b-97e8-0-82ce-f179-8a79-69f4.ip6.aussiebb.net. [2403:580b:97e8:0:82ce:f179:8a79:69f4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad8164d3sm2002539b3a.15.2024.12.19.17.56.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2024 17:56:08 -0800 (PST) From: Alistair Francis X-Google-Original-From: Alistair Francis To: qemu-devel@nongnu.org Cc: alistair23@gmail.com, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Alistair Francis , Daniel Henrique Barboza Subject: [PULL v2 25/39] hw/char/riscv_htif: Clarify MemoryRegionOps expect 32-bit accesses Date: Fri, 20 Dec 2024 11:54:25 +1000 Message-ID: <20241220015441.317236-26-alistair.francis@wdc.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241220015441.317236-1-alistair.francis@wdc.com> References: <20241220015441.317236-1-alistair.francis@wdc.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::42f; envelope-from=alistair23@gmail.com; helo=mail-pf1-x42f.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé Looking at htif_mm_ops[] read/write handlers, we notice they expect 32-bit values to accumulate into to the 'fromhost' and 'tohost' 64-bit variables. Explicit by setting the .impl min/max fields. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Alistair Francis Reviewed-by: Daniel Henrique Barboza Message-ID: <20241129154304.34946-4-philmd@linaro.org> Signed-off-by: Alistair Francis --- hw/char/riscv_htif.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/char/riscv_htif.c b/hw/char/riscv_htif.c index 3f84d8d673..db69b5e3ca 100644 --- a/hw/char/riscv_htif.c +++ b/hw/char/riscv_htif.c @@ -325,6 +325,10 @@ static const MemoryRegionOps htif_mm_ops = { .read = htif_mm_read, .write = htif_mm_write, .endianness = DEVICE_LITTLE_ENDIAN, + .impl = { + .min_access_size = 4, + .max_access_size = 4, + }, }; HTIFState *htif_mm_init(MemoryRegion *address_space, Chardev *chr, From patchwork Fri Dec 20 01:54:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alistair Francis X-Patchwork-Id: 852339 Delivered-To: patch@linaro.org Received: by 2002:a5d:4888:0:b0:385:e875:8a9e with SMTP id g8csp1814157wrq; Thu, 19 Dec 2024 17:59:12 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCVm0GLdweA2F1GYdoV1GaEZFiVzXT/Kt8petnfBRz3Es1EKA1EVvFUesW/BwLQJc1DatiR3cA==@linaro.org X-Google-Smtp-Source: AGHT+IFoKyNNZhE7rYFmoliHLKk+4zzV+Dwc51s4yFDQSoqqv4B4tmRJ7hlxJaJPEzmsUwfKgcYo X-Received: by 2002:ac8:7dc6:0:b0:466:93e2:8ba5 with SMTP id d75a77b69052e-46a4a8add12mr18701181cf.5.1734659952104; Thu, 19 Dec 2024 17:59:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1734659952; cv=none; d=google.com; s=arc-20240605; b=WRC24Vdzata542awURRBdIWur1nP34qspSGhzqyAfVrSV606rCCs5PCzlc5ZUz6iyl qs5WDmH4tvPX270YCPhNvDFsfLUco7FOtucZNl+G8aiQyAbr4d9HJQhJPUEhjaUW6whj j18YCuMHww1IniYeSYkf2xOaqHMD7ZQFIROBdafxD5D+lqYmDBzVMEUv1vFZbTPBlL4P af7+w+PU6ZGDYkwAURljWlbKnDMmyKiRTngWttA+pRBClHoZfhTjw8/HwrLJH4wTE5c3 GwdXEJINu94IHCf+SUTEKPR54+F43UKYko9cYTRK4acw8rAfsSif+BQla11whx1yVXkk qDMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Hja11IV5nNA1bZBHCKOlY+QF4apsmUpXaGb/2G3nPWw=; fh=hOsOEs8aEq9LJJTsYsIoWx0jWixGs6ALmHBYDbZCZmk=; b=Pg76O/MN3joxYrIQSzrkG8pxuSnTup2FfTu0jqj6jegJoljp8GvuKgPGz9IKcgW4/G uwv8l9PuflEwftFZXrUrvTEaeQYSA5ym4g6gWX4M71ImXQFeDZ+d56Gr6XKZisdEIZNe 4xxjEyKkXpyMWSFYU8GbF7uArg9ztlw/qSwYWqtYaTSF/nz8zJDgX+uc0M4mEwoYOfdT PMNB7pPDJS18vpMG7/3s8aHj4ZACXviuJQFhTw/crv/0SyMgMyaCZ5vChCqTtXEcPYi8 KJaMPFGCoUClLWae3g2Z5hxQmvn9vJB6xbrI4c8I5g+MwOUVillW0F8GkSoJTPHg5+NI D5cw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=ilZZK2Xf; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6dd182340e3si31003086d6.223.2024.12.19.17.59.11 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 19 Dec 2024 17:59:12 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=ilZZK2Xf; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tOSG8-00021s-UK; Thu, 19 Dec 2024 20:56:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOSFv-0000xh-IW for qemu-devel@nongnu.org; Thu, 19 Dec 2024 20:56:43 -0500 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tOSFu-0004e0-0I for qemu-devel@nongnu.org; Thu, 19 Dec 2024 20:56:43 -0500 Received: by mail-pf1-x42a.google.com with SMTP id d2e1a72fcca58-725ed193c9eso1283904b3a.1 for ; Thu, 19 Dec 2024 17:56:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734659800; x=1735264600; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Hja11IV5nNA1bZBHCKOlY+QF4apsmUpXaGb/2G3nPWw=; b=ilZZK2XfjsEoYjAsCMnc3o+BeXVDFeKjO7xi45xxDuEZtRXGafMrLNR9oVXx1eeMf3 4/GRLQ6EQ/AActpFeqUUay0+pVFH7P37zv32sfxXOqWCtGC1de1qXlcrc/uKV6EmZ+bn bDIMDvia1bwr+KrtZi8q/WHe1urQCM5iZmXIbvMC6qvIRixA6GBej2PQlBiWClEkMuyN UY4gYBsTJm872iSKGN890/8Skn6yHjP2A5KoLLTy8tlWiTxj63/oLIJGfPwHQcoteZSg xTxw0sSQx9/kR7aBUVe7MhvLtKCstXUvVIMuAaJebCyYB5iYUTEQVYNNopJxQ/ujrF+L jtnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734659800; x=1735264600; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Hja11IV5nNA1bZBHCKOlY+QF4apsmUpXaGb/2G3nPWw=; b=LsyJrbzcFgFF8/XzpwC7ARjJODUCs37iF9X+wEIRKOcsNlS7bkEevibJjK6JeVJPhE Cxrp/d6grTrDjjlEjJc4dN4yjkHLOMI6Rtet2Lfj0M81QPWkyEKzHqYgaQCVSMBFJH8j hIhqtevdNA6HS31Gdhmp8PAX/c8o5t24B1aAjQ7nUSR/L5wURaww9qkFXhlVrZxwGNhw E+5NM0+yvv+tYzQMp79xnLN4vUxlX/p98LoKkbiZJooNuLK91QRAgtVzy7O3H0C4tvQO ZjkUoKGBc7iobjqMBysmP4aooiusG5dhqe40HlUzpv/J7QYighLk6LB7eIwrALE57UG4 vHCQ== X-Gm-Message-State: AOJu0YyAUiO6rnLqQ7KSmhkg/NhTNiJHoT7PKYH3Muj8qLCKt4VxB5dx tkDnt67FtMg5aIQr3P8NAvkPBo4kUctHagIkf/hNHV7ahjBH8JCllK+TA81K X-Gm-Gg: ASbGnctD5pmWN/T9Rg/bpeapJvNgyFD6F6HB2mWvkvr/a/OPD3evZY9gZtL1KEB8f0i K0secWlX97JtF8a7rq9ZI7MacfNw8mlFLfkqzSUxRbrLL4YIJAYRpgcoCWixniaMSSmWb7JX4pv edKEblILKsM3jOafw++ZxwA99/iytjkCfIp1+4vMT1edAKOtOjgbz2/hXHvhxyHtiBWeXxzQvxN fQR+ULRCVdUyjRZmFRABoZmpGasICFZXSCnALZV2RCFYJpPL3Ok3ZZ7mWi7XR4qs/tlOtLoavYS ZZ4OrSn7dg7x33ayWxk4rAU0d9wlSmA46GBYcFhrxM1Ux2wmo1uFpWXJULQ5Gu4= X-Received: by 2002:a05:6a21:394a:b0:1e0:df27:10d6 with SMTP id adf61e73a8af0-1e5e0497c5fmr2020057637.23.1734659800481; Thu, 19 Dec 2024 17:56:40 -0800 (PST) Received: from toolbox.alistair23.me (2403-580b-97e8-0-82ce-f179-8a79-69f4.ip6.aussiebb.net. [2403:580b:97e8:0:82ce:f179:8a79:69f4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad8164d3sm2002539b3a.15.2024.12.19.17.56.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2024 17:56:40 -0800 (PST) From: Alistair Francis X-Google-Original-From: Alistair Francis To: qemu-devel@nongnu.org Cc: alistair23@gmail.com, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Alistair Francis , Daniel Henrique Barboza Subject: [PULL v2 35/39] target/riscv: Include missing headers in 'vector_internals.h' Date: Fri, 20 Dec 2024 11:54:35 +1000 Message-ID: <20241220015441.317236-36-alistair.francis@wdc.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241220015441.317236-1-alistair.francis@wdc.com> References: <20241220015441.317236-1-alistair.francis@wdc.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::42a; envelope-from=alistair23@gmail.com; helo=mail-pf1-x42a.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé Rather than relying on implicit includes, explicit them, in order to avoid when refactoring unrelated headers: target/riscv/vector_internals.h:36:12: error: call to undeclared function 'FIELD_EX32'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 36 | return FIELD_EX32(simd_data(desc), VDATA, NF); | ^ Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Reviewed-by: Daniel Henrique Barboza Message-ID: <20241203200828.47311-2-philmd@linaro.org> Signed-off-by: Alistair Francis --- target/riscv/vector_internals.h | 1 + 1 file changed, 1 insertion(+) diff --git a/target/riscv/vector_internals.h b/target/riscv/vector_internals.h index 9e1e15b575..a11cc8366d 100644 --- a/target/riscv/vector_internals.h +++ b/target/riscv/vector_internals.h @@ -20,6 +20,7 @@ #define TARGET_RISCV_VECTOR_INTERNALS_H #include "qemu/bitops.h" +#include "hw/registerfields.h" #include "cpu.h" #include "tcg/tcg-gvec-desc.h" #include "internals.h" From patchwork Fri Dec 20 01:54:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alistair Francis X-Patchwork-Id: 852341 Delivered-To: patch@linaro.org Received: by 2002:a5d:4888:0:b0:385:e875:8a9e with SMTP id g8csp1814281wrq; Thu, 19 Dec 2024 17:59:44 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWjdK3rjIEbhudIQevgRcIyP0bMRvpTMhGxHNPOHPutID6oRzGVZ4EUmJKF5zajVExZQ9z+5A==@linaro.org X-Google-Smtp-Source: AGHT+IEDaak3T8OUtZkK1s6u0Oqc1WeQZ+DFmq8CapxPbXrmpo03BwwSUGDRkP8Fq49HE3LmBgSR X-Received: by 2002:a05:6214:20a1:b0:6d4:1bad:7415 with SMTP id 6a1803df08f44-6dd2331fa78mr21089966d6.2.1734659984698; Thu, 19 Dec 2024 17:59:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1734659984; cv=none; d=google.com; s=arc-20240605; b=XACm1vsS42RvnAFa8jPgyt/VzY6Pp25e9RfyM0TUekiuugX9kj9Db28gs4qg32Tzdt XsgVxMDusN6y7vhg+2YzTWiTlZeMecuY7haAQIKWpBHzTno7D+hrC7B2GqM3Jn88lGBb pq4flw+4VtQOQLOu3eEVoLfFH308Omme7B7Q+iPFcjham/rUeDh8e1iiPH0JmAIzqWBo PtYbKKHJyfT7Mw8vjipBzMTuEEmxIamP8CGwDJ2YNlkZktIBprjP195EI4yIUJ7tuHeA cRBmXxotViZF+L1ot5BiKE3OmvkNih3kBYenU1BO2OE4+0hgpqhZZUNgHl5m6GV4Xs5b FFMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=jxMLDcONSvYYPpx6U61hKxGfs4I1jXSi4kLYiSJ5F/M=; fh=hOsOEs8aEq9LJJTsYsIoWx0jWixGs6ALmHBYDbZCZmk=; b=FEPRRhYcLuODfJMJuG0Dc/0qqXi7yIadOl4YIcO3WwgWXfs68l5Rr/ChYqSYBRgxSA z7k2/JLSLsE67jp2jeKgZSqyTNZu2k3kFVidkGrt6E6IUBzlIrSBYUNuH5X/V+MrvrVg FdlXJHgfGAiqik8YefG7S7e56x1hOWZJw5S4zBxR+n4xgXcM7V9c6IlX4c+4LUzyL+ze ESD6Qi5lFdQPGahWxhVzAcnRaDOtfcNl4o3zbTqgLz7GmtRRsmG1cKvz3iYSA2Cbyj9t W4BFLqFpy6tnhlQ1qY8MY090kLZDk0BJCDlD8n5bQnBRm6rVsqyysVk/5rSizTjT6m1t Ru1A==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=T8JLuBjb; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6dd1836fc2asi27583526d6.514.2024.12.19.17.59.44 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 19 Dec 2024 17:59:44 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=T8JLuBjb; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tOSGK-0002U9-W6; Thu, 19 Dec 2024 20:57:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOSG2-0001bR-W1 for qemu-devel@nongnu.org; Thu, 19 Dec 2024 20:56:51 -0500 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tOSFw-0004fj-TD for qemu-devel@nongnu.org; Thu, 19 Dec 2024 20:56:50 -0500 Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-7292a83264eso1286392b3a.0 for ; Thu, 19 Dec 2024 17:56:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734659803; x=1735264603; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jxMLDcONSvYYPpx6U61hKxGfs4I1jXSi4kLYiSJ5F/M=; b=T8JLuBjbOEx046Ywy1jWOxYGt1/wiexzVdZsgAPfAhB0Pv6dmKTI96en+pd8H/Qbty dQgeCaFtoKmKa4xR0KI03eK0DnT7KSvVM7SfFisZqxamMGig7oDIMeJ/6Lrtar8eaFX9 PMel3u4bRPlikf1kcJCtAVhzrjOADR4gRY3sMwxwVGqgQqK3aSpLBiEhSSfpBSSnuP6y QeEIHW/k+9nlQTgSph4/j0bdJn2m+RNXT3fLnFuwUdsGxnM8EELqv0UMMbDD8A6vo1dd zNluOoULBYI8Jrv0GI7Snt56JuY7h2kDdFU/MPe3vRleUKsYUu7mfmJfEcI7gDYOo6KL acKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734659803; x=1735264603; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jxMLDcONSvYYPpx6U61hKxGfs4I1jXSi4kLYiSJ5F/M=; b=cbFoUQ3F5YACcKjsaf2wqr9U4bdDPYww5W7monbrbJGPb78VVqCoEuxuxTp0NzIV4Y VglTvZedEb4A2ac63jcSqFXL7hAZ2C18RM5e6LvmcmIOde5VowkBIzcUqqLmAzIGcFYD x/047E0AuYW2dW8+ewnSQdjIv1/vWlHcNLpYvHEt7Bovpdg8YZeR4g+sv+JfFwUP119A RGMoJ6grDmPFhfJxHYzd5UH3GLKRIpD+tD0UD68DEg7BhtclocLBqFbcpytPiw3OL2RA miJYDY0PDXUGWna3aKsQeA/yri9QOZQZObs4mfHEHOGa/MGWUHxohASScAyGaHV6vcfz 1hew== X-Gm-Message-State: AOJu0Yx8AbWAbTviTZXwEkQnUr59xs4jSMssgUnpC3xxR9gbGetRPmmB zROtWAETNp+01o+ihSdhHlrKJAdcTx2ApjkIz2IACkjoHHDXHuQ1dwVup+oi X-Gm-Gg: ASbGnctTkwkgYs5SGbIQTl0vQgx0v5LX3gIe7sl4kcztsZCydLoa8GlRbcqWMb/bpyi oEjNQeVAUmy2cNTi2ACl5scVj7irQafe099E4oTX0/U841OTvjen1IHTIyioqQAKesJweos859u Cbe6+kV8UGTNedcfz00NldHbJ/R8dhZb1+Yt6W/JGju0M3/GBui6p1UYt+YZjWjuhgA3elrMTd1 eizBWelF4AB4QQehPm7ytlvxWX5llWKSzV3h8ybd19RUBXFtZFHXywgedmyGUG+84gCkqYW0XBo 0Eso530quZAQg1+BARbRd7lX88rr1KdSAMpSZROoobkCsSpPYnPLn03G0r4nAyI= X-Received: by 2002:a05:6a00:6f0b:b0:725:b4f7:378e with SMTP id d2e1a72fcca58-72abdbe0cb5mr1400116b3a.0.1734659803439; Thu, 19 Dec 2024 17:56:43 -0800 (PST) Received: from toolbox.alistair23.me (2403-580b-97e8-0-82ce-f179-8a79-69f4.ip6.aussiebb.net. [2403:580b:97e8:0:82ce:f179:8a79:69f4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad8164d3sm2002539b3a.15.2024.12.19.17.56.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2024 17:56:42 -0800 (PST) From: Alistair Francis X-Google-Original-From: Alistair Francis To: qemu-devel@nongnu.org Cc: alistair23@gmail.com, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Alistair Francis , Daniel Henrique Barboza Subject: [PULL v2 36/39] target/riscv: Include missing headers in 'internals.h' Date: Fri, 20 Dec 2024 11:54:36 +1000 Message-ID: <20241220015441.317236-37-alistair.francis@wdc.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241220015441.317236-1-alistair.francis@wdc.com> References: <20241220015441.317236-1-alistair.francis@wdc.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::42d; envelope-from=alistair23@gmail.com; helo=mail-pf1-x42d.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé Rather than relying on implicit includes, explicit them, in order to avoid when refactoring unrelated headers: target/riscv/internals.h:49:15: error: use of undeclared identifier 'PRV_S' 49 | ret = PRV_S; | ^ target/riscv/internals.h:93:9: error: call to undeclared function 'env_archcpu'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 93 | if (env_archcpu(env)->cfg.ext_zfinx) { | ^ target/riscv/internals.h:101:15: error: unknown type name 'float32'; did you mean 'float'? 101 | static inline float32 check_nanbox_s(CPURISCVState *env, uint64_t f) | ^~~~~~~ | float Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Reviewed-by: Daniel Henrique Barboza Message-ID: <20241203200828.47311-3-philmd@linaro.org> Signed-off-by: Alistair Francis --- target/riscv/internals.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target/riscv/internals.h b/target/riscv/internals.h index ddbdee885b..76934eaa7b 100644 --- a/target/riscv/internals.h +++ b/target/riscv/internals.h @@ -19,7 +19,10 @@ #ifndef RISCV_CPU_INTERNALS_H #define RISCV_CPU_INTERNALS_H +#include "exec/cpu-common.h" #include "hw/registerfields.h" +#include "fpu/softfloat-types.h" +#include "target/riscv/cpu_bits.h" /* * The current MMU Modes are: