From patchwork Thu Dec 19 15:04:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 182119 Delivered-To: patch@linaro.org Received: by 2002:a92:d0a:0:0:0:0:0 with SMTP id 10csp598932iln; Thu, 19 Dec 2019 07:05:13 -0800 (PST) X-Google-Smtp-Source: APXvYqzmmAD3/CVhDKBiLwKdgi5V8SubeyMmxH4IyffMSi3GVpct7G0D41X1U6Ya/TqA+njpbfts X-Received: by 2002:a9d:133:: with SMTP id 48mr9014286otu.15.1576767913229; Thu, 19 Dec 2019 07:05:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576767913; cv=none; d=google.com; s=arc-20160816; b=JrjKqa7XfTY8YPI5lbmhusE73TmtQpr5VjCemUiNiyJHfwiBomxdhXFq8H57DFW+j/ IGSXw3aDoWSGzLMpuxQcxlXbQuyxlBiN1RJ+RUA7kxuYdUynVfS/aEtWVbLmK4Sij/lI 5SOu5HDQaI8ZN3ZazeITq70GPJ1/RK2jm/txYnoA6M7Kh8/zHuU/J/x7V268E7qXfqJj ftHaXO2qwBInY45vlFuIAqrZScNfcC6SXIAX79REkD2HNcpflLh4WbYtdw91/mTRBUEu G4J8NzRZsttwFSV+mJqEBR54c4MWeKxfxYqUDPjhZtGXzi2f4jOKSJEvXA0/jRK553aO KT6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=UV8wFR7M+VS4arxyH1PUjEkzp5QsXyxTBfn/3aIBy9c=; b=U+MgB8yTggiTImerIVK0si8Wnt+yaibHed629OyHScbCOQixV1IppRgdkM3hEEmWib yuYZ6LliBRbYY0e9r9AVauOSkkPcW3/mfyVnqT8sCSkNXe/8RUNgh4cASXk4dRtRgLKY otRp7iTTRoKo4p1xaxSi2/PIDzAb7Z+nOqPJG0oDA3x5xgx/Fl01jfhhmCH/7L+RwU9A ho4wU/HjSqWBCCLBjZlKPxfEIjt+R8CibyiqypDxxnmXo4DO7d0IAVuSkoMl2UZt2yl3 Nqy14Oyw/w2ZEiK1p1Q1qX60ZQ3zm7d6vNbqVonzhbWxAwT5c2Zu7cX99U8kaNsLZsGS ld2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wEoffsMq; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m24si3463420otn.67.2019.12.19.07.05.09; Thu, 19 Dec 2019 07:05:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wEoffsMq; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726877AbfLSPE7 (ORCPT + 15 others); Thu, 19 Dec 2019 10:04:59 -0500 Received: from mail.kernel.org ([198.145.29.99]:34160 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726817AbfLSPE7 (ORCPT ); Thu, 19 Dec 2019 10:04:59 -0500 Received: from localhost.localdomain (unknown [122.178.234.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1970724672; Thu, 19 Dec 2019 15:04:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576767898; bh=nGIBL8aVxoKmkDIwSClLd5dlI6t4JIUetskk9vvcXmE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wEoffsMqqtDei+TxWhS4ErXebPe5/QAcEeRDjnuJ9hWoJuDCFZWni5wTkSw5v+0Q+ CzGqS0kYdZAd0Y9O503gtkAOKiGeCgwUjyD0KNFf3/GMMxtdcqF28IFUfVQ0PY2zeQ JOG8wfnizA3Yp3TbCOaBK+2Teopb8kCOPg/J93GI= From: Vinod Koul To: Kishon Vijay Abraham I Cc: linux-arm-msm@vger.kernel.org, Bjorn Andersson , Vinod Koul , Andy Gross , Can Guo , Jeffrey Hugo , linux-kernel@vger.kernel.org Subject: [PATCH 1/4] phy: qcom-qmp: Increase the phy init timeout Date: Thu, 19 Dec 2019 20:34:30 +0530 Message-Id: <20191219150433.2785427-2-vkoul@kernel.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191219150433.2785427-1-vkoul@kernel.org> References: <20191219150433.2785427-1-vkoul@kernel.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org If we do full reset of the phy, it seems to take a couple of ms to come up on my system so increase the timeout to 10ms. This was found by full reset addition by commit 870b1279c7a0 ("scsi: ufs-qcom: Add reset control support for host controller") and fixes the regression to platforms by this commit. Suggested-by: Can Guo Signed-off-by: Vinod Koul --- drivers/phy/qualcomm/phy-qcom-qmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.23.0 Reviewed-by: Jeffrey Hugo Tested-by: Jeffrey Hugo diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c index 091e20303a14..c2e800a3825a 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c @@ -66,7 +66,7 @@ /* QPHY_V3_PCS_MISC_CLAMP_ENABLE register bits */ #define CLAMP_EN BIT(0) /* enables i/o clamp_n */ -#define PHY_INIT_COMPLETE_TIMEOUT 1000 +#define PHY_INIT_COMPLETE_TIMEOUT 100000 #define POWER_DOWN_DELAY_US_MIN 10 #define POWER_DOWN_DELAY_US_MAX 11 From patchwork Thu Dec 19 15:04:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 182120 Delivered-To: patch@linaro.org Received: by 2002:a92:d0a:0:0:0:0:0 with SMTP id 10csp599042iln; Thu, 19 Dec 2019 07:05:17 -0800 (PST) X-Google-Smtp-Source: APXvYqx9ZTbJf2pQa8bCEQr4VWeus90KcA59jXJe0dExCSwnrVaY8+eX9e4tkG050RfFZkVQMv3g X-Received: by 2002:a9d:369:: with SMTP id 96mr4804771otv.228.1576767917630; Thu, 19 Dec 2019 07:05:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576767917; cv=none; d=google.com; s=arc-20160816; b=0QYBP4cSlr50qVFGHYOB9fuRGmKvpX+JVydiX/izH9gGZ3LwWvRkCYnYZfTD1eF0H+ F5liVBZiuiV+DkmqbIafXDV53zs8u/CtowubpfSPLvgeY6S3RGkgRmhDF35RT1lrEnsY BHSP/KRI0PhjFXRrNliLiYwUwA2Sv8KUB5yP1TMLEe9PLOM+FYJ5Av8tmQ2AWU668VKo C8sZAs3VbtWL2o0FFZtkNU8o8AbgpEqoFulNHOrxbREbV2yCh/1KYnZwKYkdCOQbm6mX OEtGLsRr4RiCk85gZ9ZhkurbxYEL0wzNXy1LKGg8QpL1oU3aQy3y6zhiK6oHTEKVe7SQ 6kRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=itbOzx2u+ajfL8QFCXjKyusz38x3FyInKhpNkP/7a1s=; b=i7HvC+kovzfl0jL9N2t6IG1fOb0PprVgJcrE5nVpsZwQyLX4uYxdthVxlXSvS4w1aa fbcRRy5yTxUqJJs6YwPq0rqowPfe1eFrfHojRa7OiB526pxuW5XU5oVG6lk5NeyJ0eaf 3y6w1LI0J99xDXj5NvJIOeHJd+qsZ00huGuGngPxEMoHBiD3f0Ji3zOOOF1mB17DRpwA hX2RK2G3GBYBmHrW8I6beDBBYp5dGLvS0fZ7zMNAq+wf/7RK22SVNGXWZ/DpuuEwsiPQ FLl9CWBUkoveP+u7NjXWUu7fk3n3SwW/uj5e2zBGO5+cLhJ6cufFr6lBe1/9LZv1ZLLv eECQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=TeQlztHq; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m24si3463420otn.67.2019.12.19.07.05.14; Thu, 19 Dec 2019 07:05:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=TeQlztHq; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726817AbfLSPFD (ORCPT + 15 others); Thu, 19 Dec 2019 10:05:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:34226 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726801AbfLSPFC (ORCPT ); Thu, 19 Dec 2019 10:05:02 -0500 Received: from localhost.localdomain (unknown [122.178.234.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6591524679; Thu, 19 Dec 2019 15:04:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576767902; bh=HIjcrR1V5NJu2M5zDIohQ4KGUZPwSjZcbWqjK0s0U5g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TeQlztHqJ4CWsAjEPkYcnCF8m3ocN89NgCpOqQeRSl7oqxvuZu+N5FuEUgeVDKYo0 3S/rHRA0/SnGD97M9K6ppwM1oXxHVtKU11odsfVdLzgcU0G1ImZA+KHP59BnFoqW7/ 0krxxajWEc1Yz6WMsnSb5RF/xUkmokrrektMfc+Y= From: Vinod Koul To: Kishon Vijay Abraham I Cc: linux-arm-msm@vger.kernel.org, Bjorn Andersson , Vinod Koul , Andy Gross , Can Guo , Jeffrey Hugo , linux-kernel@vger.kernel.org Subject: [PATCH 2/4] phy: qcom-qmp: Use register defines Date: Thu, 19 Dec 2019 20:34:31 +0530 Message-Id: <20191219150433.2785427-3-vkoul@kernel.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191219150433.2785427-1-vkoul@kernel.org> References: <20191219150433.2785427-1-vkoul@kernel.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org We already define register offsets so use them in register layout. Signed-off-by: Vinod Koul --- drivers/phy/qualcomm/phy-qcom-qmp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.23.0 Reviewed-by: Jeffrey Hugo diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c index c2e800a3825a..06f971ca518e 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c @@ -166,8 +166,8 @@ static const unsigned int sdm845_ufsphy_regs_layout[] = { }; static const unsigned int sm8150_ufsphy_regs_layout[] = { - [QPHY_START_CTRL] = 0x00, - [QPHY_PCS_READY_STATUS] = 0x180, + [QPHY_START_CTRL] = QPHY_V4_PHY_START, + [QPHY_SW_RESET] = QPHY_V4_SW_RESET, }; static const struct qmp_phy_init_tbl msm8996_pcie_serdes_tbl[] = { From patchwork Thu Dec 19 15:04:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 182121 Delivered-To: patch@linaro.org Received: by 2002:a92:d0a:0:0:0:0:0 with SMTP id 10csp599292iln; Thu, 19 Dec 2019 07:05:29 -0800 (PST) X-Google-Smtp-Source: APXvYqy7G9oNUBfu3BvKHd7sfY/htcyXGg+zT826N6EbeQwPIb2ia75RaGgJw1Sj/F2ckVnMG1I+ X-Received: by 2002:a9d:369:: with SMTP id 96mr4805764otv.228.1576767929149; Thu, 19 Dec 2019 07:05:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576767929; cv=none; d=google.com; s=arc-20160816; b=om3n30aupOKwEIe2x56a6m+BhEWL86a93r9Lrm27U7RI/YW07L246ECvRi46epGjDA xGvQkuP0DTOskCD7sOvkR6kj3ytmg5vBFOAEeVFYZzBMMhAN9CR9DOBhQZ+9EIYyXn+0 WK/e50z5YU4TsomNTgjbvItlqg7puKNefV4HOK7QW5HW+5y2oq5Q4Nz5aWLRTPbre0VU CFoyxYDklkO1BjAVVFu5lFUtxEr5UWRP6Qa6QSKM9W3EZgVIEXlLcd30km/VoXrVA0Vz 698QkjeFGLLkDGd3uX57ee5xtDjqUatJ6QS0KkDBa9l6OabUrrzZPsIZJtgG3Z2Xhb3W diHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=sY5LgWL6tR/sTobqa9Jw1QbScUZLKeZrYgIyOt0uIt0=; b=iZWbCaU7KBHmo4XREQ96EJdCiu8XigHDHTLFer2CsS8D6PMgSEoxUdWUgEzl0qtT5H oNiuSYb17/Ti6OXGkAEufUTyQ9ONwa8q3go4DST/d0HkevPV9fuAYYBUITF79SdqQ9+J emUv3hjJI35HWvjj8XULZDAMgbuLHPmzWjvFXtkjRMQBAO2+sgv16HMEBdLVmvfThVkC q+EO/9Gn/S0eAgo33lAaoc3z8sj3HbrdoM7/ftTAQzMs4eES9AUSCU8NCdqgrO65ogFV SE4le6YodajBRk3w1rz70WQ8uReQ4TcO8VO5sJZFKyuaQiMLIh+h5PTDUK9j32fgT0HN Ta+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NYgNPf78; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m24si3463420otn.67.2019.12.19.07.05.26; Thu, 19 Dec 2019 07:05:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NYgNPf78; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726930AbfLSPFG (ORCPT + 15 others); Thu, 19 Dec 2019 10:05:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:34314 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726801AbfLSPFG (ORCPT ); Thu, 19 Dec 2019 10:05:06 -0500 Received: from localhost.localdomain (unknown [122.178.234.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B1D8221655; Thu, 19 Dec 2019 15:05:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576767905; bh=2vFU+S6HKqKhfz4jubJ0RuqI/YrwcWJmmCmTPInyZtw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NYgNPf78Ks2olSLVdWXX45DQN+xgYZmkM4W7388mGgelnnhI4LdEBenVPTxkPpk/2 UEcAZTgAdfHMGHbTE9jdbwVmn9cE7bEXtNY1qqaM/QiN/2oEVkqjsGyXthHzzYLK2A f5vfJLWD/WFsYwnwiLKOE4NjGn04YwInN4WG7KiY= From: Vinod Koul To: Kishon Vijay Abraham I Cc: linux-arm-msm@vger.kernel.org, Bjorn Andersson , Vinod Koul , Andy Gross , Can Guo , Jeffrey Hugo , linux-kernel@vger.kernel.org Subject: [PATCH 3/4] phy: qcom-qmp: Add optional SW reset Date: Thu, 19 Dec 2019 20:34:32 +0530 Message-Id: <20191219150433.2785427-4-vkoul@kernel.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191219150433.2785427-1-vkoul@kernel.org> References: <20191219150433.2785427-1-vkoul@kernel.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org For V4 QMP UFS Phy, we need to assert reset bits, configure the phy and then deassert it, so add optional has_sw_reset flag and use that to configure the QPHY_SW_RESET register. Signed-off-by: Vinod Koul --- drivers/phy/qualcomm/phy-qcom-qmp.c | 10 ++++++++++ 1 file changed, 10 insertions(+) -- 2.23.0 Reviewed-by: Jeffrey Hugo diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c index 06f971ca518e..80304b7cd895 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c @@ -1023,6 +1023,9 @@ struct qmp_phy_cfg { /* true, if PCS block has no separate SW_RESET register */ bool no_pcs_sw_reset; + + /* true if sw reset needs to be invoked */ + bool has_sw_reset; }; /** @@ -1391,6 +1394,7 @@ static const struct qmp_phy_cfg sm8150_ufsphy_cfg = { .is_dual_lane_phy = true, .no_pcs_sw_reset = true, + .has_sw_reset = true, }; static void qcom_qmp_phy_configure(void __iomem *base, @@ -1475,6 +1479,9 @@ static int qcom_qmp_phy_com_init(struct qmp_phy *qphy) SW_USB3PHY_RESET_MUX | SW_USB3PHY_RESET); } + if (cfg->has_sw_reset) + qphy_setbits(serdes, cfg->regs[QPHY_SW_RESET], SW_RESET); + if (cfg->has_phy_com_ctrl) qphy_setbits(serdes, cfg->regs[QPHY_COM_POWER_DOWN_CONTROL], SW_PWRDN); @@ -1651,6 +1658,9 @@ static int qcom_qmp_phy_enable(struct phy *phy) if (cfg->has_phy_dp_com_ctrl) qphy_clrbits(dp_com, QPHY_V3_DP_COM_SW_RESET, SW_RESET); + if (cfg->has_sw_reset) + qphy_clrbits(pcs, cfg->regs[QPHY_SW_RESET], SW_RESET); + /* start SerDes and Phy-Coding-Sublayer */ qphy_setbits(pcs, cfg->regs[QPHY_START_CTRL], cfg->start_ctrl); From patchwork Thu Dec 19 15:04:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 182122 Delivered-To: patch@linaro.org Received: by 2002:a92:d0a:0:0:0:0:0 with SMTP id 10csp599559iln; Thu, 19 Dec 2019 07:05:40 -0800 (PST) X-Google-Smtp-Source: APXvYqwo6vkF0HLeuwGioppSW5AkL+zRmNCeFSzZ4+gpoQr/BDQjuLKADf7AXugCcaTF5RGWhFc4 X-Received: by 2002:a05:6808:9b4:: with SMTP id e20mr578757oig.37.1576767940719; Thu, 19 Dec 2019 07:05:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576767940; cv=none; d=google.com; s=arc-20160816; b=NHaeY2sb3Tqi/8yvrneMRqgIVqwPE3mQKoGk24b6mTOkpB4UjzomaGbCuFAcgX13kB aRGqxEp55Sz0q1u/gwHiKWB2aUOsZKyrUz9xmsjiKBP2ENIQoM9UEVqjSHA0saHf/28q 6f3A4RS/GVpm65AGmsClecQbdz4IdrblRt9OzF0xHH24qqSim3yhjILa8v+PfpU3iUKF rmDF3EO8z3hKjk7ZWWh091QbPha1xWLhxn5D0ZvDo8tHSyg/0hYGNXi/nCzvkZp9/HLc jDTI7V/l1R7gknoN6mMmUaNVt4m012afq51OdeglSCR6/ufXuzqVQepMEHQDG2xI2G7f RkPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=oheoDFG5gU1caTfdgJ5aCIxpLF+prdBmssw2tD96l+o=; b=xP8naSUqeJrEczN0D4O+g9qH5JTu0stfcMid442pNU/XJcsBX0hYvaOZAXcPCwkdDp 4O/ibDLQppQSA94hVRPIWPqaSoSDK6wzGol75go7Y3wZpAO5iCdCOcDeQTxl4onLXuXd YawnA8xGmUzxs7+sjpret6uIHiJqRYIcdxBmznZTNcgRW7yD1pf8rfeXL+O2XntXEsEL p4bBE59D/1W/rVFADnGMBbOmd6ihAaZvJhxrj1KoSHN8tkjXcjfLLC/4UG813crDEZoX 2o3Bs30O+ZfPv6jBgG9+cbURseq4//FlJBK27i3GnjbKKg6uj7YcvyILYek2QqNWzVnb A9LQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=VYxcHDDB; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m24si3463420otn.67.2019.12.19.07.05.36; Thu, 19 Dec 2019 07:05:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=VYxcHDDB; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726801AbfLSPFL (ORCPT + 15 others); Thu, 19 Dec 2019 10:05:11 -0500 Received: from mail.kernel.org ([198.145.29.99]:34354 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726751AbfLSPFJ (ORCPT ); Thu, 19 Dec 2019 10:05:09 -0500 Received: from localhost.localdomain (unknown [122.178.234.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 09EA824672; Thu, 19 Dec 2019 15:05:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576767908; bh=p80ASa2e+ERmBUt4/2lrbwFwRHc3FZsVGsG89n2xFRI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VYxcHDDB7QXpMzgECtUDyu9s3nmp4cwHUCukVUhPwthi52qMM5l7Pdvp0ZIOOlHxU W5yEiCYGb+O1PifZMJacf8Bu1lVzfBe3TPqeXRIV8mcM+fGpx6ym1R5dhPiuDSJoxv 7E8WLVOZDky85i2qWroG2BzSIAigwJqadWt4H0Ck= From: Vinod Koul To: Kishon Vijay Abraham I Cc: linux-arm-msm@vger.kernel.org, Bjorn Andersson , Vinod Koul , Andy Gross , Can Guo , Jeffrey Hugo , linux-kernel@vger.kernel.org Subject: [PATCH 4/4] phy: qcom-qmp: remove duplicate powerdown write Date: Thu, 19 Dec 2019 20:34:33 +0530 Message-Id: <20191219150433.2785427-5-vkoul@kernel.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191219150433.2785427-1-vkoul@kernel.org> References: <20191219150433.2785427-1-vkoul@kernel.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org We already write to QPHY_POWER_DOWN_CONTROL in qcom_qmp_phy_com_init() before invoking qcom_qmp_phy_configure() so remove the duplicate write. Signed-off-by: Vinod Koul --- drivers/phy/qualcomm/phy-qcom-qmp.c | 1 - 1 file changed, 1 deletion(-) -- 2.23.0 Reviewed-by: Jeffrey Hugo diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c index 80304b7cd895..309ef15e46b0 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c @@ -885,7 +885,6 @@ static const struct qmp_phy_init_tbl msm8998_usb3_pcs_tbl[] = { }; static const struct qmp_phy_init_tbl sm8150_ufsphy_serdes_tbl[] = { - QMP_PHY_INIT_CFG(QPHY_POWER_DOWN_CONTROL, 0x01), QMP_PHY_INIT_CFG(QSERDES_V4_COM_SYSCLK_EN_SEL, 0xd9), QMP_PHY_INIT_CFG(QSERDES_V4_COM_HSCLK_SEL, 0x11), QMP_PHY_INIT_CFG(QSERDES_V4_COM_HSCLK_HS_SWITCH_SEL, 0x00),