From patchwork Fri Dec 20 10:17:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 182227 Delivered-To: patch@linaro.org Received: by 2002:a92:1f98:0:0:0:0:0 with SMTP id f24csp325670ilf; Fri, 20 Dec 2019 02:17:43 -0800 (PST) X-Google-Smtp-Source: APXvYqzdSn0SJto3E14lQcy/dimURj5WT+pZwwWZS4LUU2bsNnDFh5VKq2vWy3o32zKiCK1vmzEA X-Received: by 2002:aca:33d5:: with SMTP id z204mr3349388oiz.120.1576837062976; Fri, 20 Dec 2019 02:17:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576837062; cv=none; d=google.com; s=arc-20160816; b=cpwtKrsquZpnGs2VoOm6iEdlCkrERzmnXKDQTUWuE9xG22N/uAGdAjMbzarHPx+kop JTFR+9U5jlt7+U/DUABm0dflW+qC/UiXylNtZWPtK1LcwTioW+yQVU9rgzQRbetjQe+1 LFyX93eOx+DAsc8evLUe9fLqDRbFqU18oOTPg5aBtBU9asR+wxkasDc1xb5lfyru2nt4 Te+XJF2Ecl4PtszjdlzJGHrNg8NATGUlvAk0IHxQpGmUPbwDG2DtZi0yLMMhX7ISygjd 6upMD7wI7YCOp0Mk3SNJydvsdLg9qAC749y2qOAstISl62YQenoldPPLcWiIFocnmISX 0Low== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=7dNkHppjXwII6U6JHTtlNke7qfH7z1XU33SXrIDnriA=; b=H+QH+D4eHp6+lMk7+Y2osZjuEjcboLlKGojuTL1KlELTTGNL+FvYn9lPGU/QeXFG8O NP+EsNlry+TLjuFXRsoolVlLd96emOZAFM9o+IxHN+ieTBpVVYYQh+ak7pbBk+6e1aNm JM6wxWlJOF4TSeShLtdXPUU/4N36pnxCRq1OdTQjkaQsJ1U52Qq+LSCyWi42bpP3Ynrv 48ddpZYlQkiqIk+GI2RBMRh27rqB1A5uE4dBvCUbXcoIusEGJ85hzWYardG0oMPHuXr6 VqAlPo4n8vTMTc5P91EtXD3pqEn+BesVOr1QAtqgBwLNNGDUeBq3afoG6qxcbbN/LnuP Mo+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="B/zZDE4n"; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a12si4319345oie.87.2019.12.20.02.17.42; Fri, 20 Dec 2019 02:17:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="B/zZDE4n"; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726210AbfLTKRm (ORCPT + 15 others); Fri, 20 Dec 2019 05:17:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:53056 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727347AbfLTKRm (ORCPT ); Fri, 20 Dec 2019 05:17:42 -0500 Received: from localhost.localdomain (unknown [106.201.107.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5C32424682; Fri, 20 Dec 2019 10:17:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576837061; bh=Ck3ilHyvx6XvHA65br3cwI6dDkzvtwpztH+Uhmy2tGA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=B/zZDE4n02b82w4qCokUUQjSkUgLZwjv5e9nYqSUAfE2q2owaqqvaS3AF/cUOvdjo g5afNUbO3sB9dU/TtmkVlAQ8BVSKRaVjvOhcwUfVlDkdaxp72791c0zBTYM3nZZsls ty+wyajBHF3lWNajncHVZ6hMXVgq6u63SMDr45JU= From: Vinod Koul To: Kishon Vijay Abraham I Cc: linux-arm-msm@vger.kernel.org, Bjorn Andersson , Andy Gross , Can Guo , Jeffrey Hugo , linux-kernel@vger.kernel.org, Evan Green , Vinod Koul Subject: [PATCH v2 1/5] phy: qcom-qmp: Increase PHY ready timeout Date: Fri, 20 Dec 2019 15:47:15 +0530 Message-Id: <20191220101719.3024693-2-vkoul@kernel.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191220101719.3024693-1-vkoul@kernel.org> References: <20191220101719.3024693-1-vkoul@kernel.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org From: Bjorn Andersson It's typical for the QHP PHY to take slightly above 1ms to initialize, so increase the timeout of the PHY ready check to 10ms - as already done in the downstream PCIe driver. Signed-off-by: Bjorn Andersson Tested-by: Evan Green Tested-by: Vinod Koul Signed-off-by: Vinod Koul --- drivers/phy/qualcomm/phy-qcom-qmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.23.0 diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c index 091e20303a14..66f91726b8b2 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c @@ -66,7 +66,7 @@ /* QPHY_V3_PCS_MISC_CLAMP_ENABLE register bits */ #define CLAMP_EN BIT(0) /* enables i/o clamp_n */ -#define PHY_INIT_COMPLETE_TIMEOUT 1000 +#define PHY_INIT_COMPLETE_TIMEOUT 10000 #define POWER_DOWN_DELAY_US_MIN 10 #define POWER_DOWN_DELAY_US_MAX 11 From patchwork Fri Dec 20 10:17:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 182228 Delivered-To: patch@linaro.org Received: by 2002:a92:1f98:0:0:0:0:0 with SMTP id f24csp325745ilf; Fri, 20 Dec 2019 02:17:46 -0800 (PST) X-Google-Smtp-Source: APXvYqxvQfoZ9Xidy7ZJaTbaghfl9+5+xc+y3G74jZlLsLEapNPLTetEqo1EhdTaz7Dw+b9LN3LN X-Received: by 2002:a9d:51c1:: with SMTP id d1mr13362218oth.136.1576837066853; Fri, 20 Dec 2019 02:17:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576837066; cv=none; d=google.com; s=arc-20160816; b=ervQXUi8SR1C7IflxpHOpAqgEUyHHX1P5BwSc0zGXVFwFaMI7C1AA7EhLhQKSerg8m 5ovtq7A/YyXrCIhiBXGzbG7GPSYEjNvgaFZE5q7yk8ozkQrkOLkVzV7Vk50heRSl8yvK O4oULzGKapsbncuP1qxDVzUFgpO0PN5zbfKjtX43PriA93yFDywa2mphx3H16nIZaatu Sdvm97fMLvfQKmMwMl4b1A3sTNmDH3bMLdg/+n0x8mWjuaoENGgaYQ/GscPnFFIh2cKr xsP6mgsCC38WfS9alLTnypbH05wpON+nnGtgPrmuer30bH9Ccl3gEls8Z3ARwLBt1uGZ FGrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=OsDps1XMTjdLLrGy7vtZ/M11owj/wk9Fc3IJNWcQEuw=; b=drUy3pOeJoHyzwHj54xDtSWRrdElp62PQPHiVU5rusH1OIPuaziC3dVAUpcHEI0uvn MqRtGDiK+FWP3Uz6HjZE23RXuTXwaUQiX/bRTqTin54opMnk/d+08z/awy3jwj8fvsef tofTcJzV6UyrdD1MtEr7hypUvGy1D+iTdOCbYl6C2n9UC9XzhQWGAjNEZbbVh3zernem Xy/5IQtwcq7xZC44ETKtT4nrpHXtPV7xuJhvcKOZulciXvEvpOrKzF6pYhocapA/kiGg jT6WnyDS915H/v9EYQmp+eOkGV8A4JtyIdpjurQhR3kNsRL/L+kFszdUvZYJB7suLeAS iN4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lJ2ORSCc; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b1si245672otl.302.2019.12.20.02.17.46; Fri, 20 Dec 2019 02:17:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lJ2ORSCc; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727347AbfLTKRp (ORCPT + 15 others); Fri, 20 Dec 2019 05:17:45 -0500 Received: from mail.kernel.org ([198.145.29.99]:53130 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727327AbfLTKRp (ORCPT ); Fri, 20 Dec 2019 05:17:45 -0500 Received: from localhost.localdomain (unknown [106.201.107.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2E8222467F; Fri, 20 Dec 2019 10:17:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576837065; bh=AIPv8fFMMsHNljU/EUBaNwyln0JkI1Y+vYsA84xKH64=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lJ2ORSCcvS0TR3JABMss3CAEJC3xAKGknJykh0LoIk5dx0J0UPB43q/DMBs6PrBKi PXMqsiEGCg+owBLOM1D2EwPPFLdjpR3dPwyypumyWNwRmg7bSNmTH3twyQPkJaZ5ee ZNqaxsY4DJSjS3aHU1tT9VQ/boEd74NXpRR/B9mU= From: Vinod Koul To: Kishon Vijay Abraham I Cc: linux-arm-msm@vger.kernel.org, Bjorn Andersson , Vinod Koul , Andy Gross , Can Guo , Jeffrey Hugo , linux-kernel@vger.kernel.org Subject: [PATCH v2 2/5] phy: qcom-qmp: Use register defines Date: Fri, 20 Dec 2019 15:47:16 +0530 Message-Id: <20191220101719.3024693-3-vkoul@kernel.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191220101719.3024693-1-vkoul@kernel.org> References: <20191220101719.3024693-1-vkoul@kernel.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org We already define register offsets so use them in register layout. Signed-off-by: Vinod Koul Reviewed-by: Jeffrey Hugo --- drivers/phy/qualcomm/phy-qcom-qmp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.23.0 diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c index 66f91726b8b2..1196c85aa023 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c @@ -166,8 +166,8 @@ static const unsigned int sdm845_ufsphy_regs_layout[] = { }; static const unsigned int sm8150_ufsphy_regs_layout[] = { - [QPHY_START_CTRL] = 0x00, - [QPHY_PCS_READY_STATUS] = 0x180, + [QPHY_START_CTRL] = QPHY_V4_PHY_START, + [QPHY_PCS_READY_STATUS] = QPHY_V4_PCS_READY_STATUS, }; static const struct qmp_phy_init_tbl msm8996_pcie_serdes_tbl[] = { From patchwork Fri Dec 20 10:17:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 182229 Delivered-To: patch@linaro.org Received: by 2002:a92:1f98:0:0:0:0:0 with SMTP id f24csp325804ilf; Fri, 20 Dec 2019 02:17:50 -0800 (PST) X-Google-Smtp-Source: APXvYqygI30vZI2NRdym1PNRVnMb8MQH6+ZHBCtimj0sa6Pe9slevKR6riTY0H7GeBSnUBH0MFaG X-Received: by 2002:a9d:5616:: with SMTP id e22mr13692526oti.366.1576837070469; Fri, 20 Dec 2019 02:17:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576837070; cv=none; d=google.com; s=arc-20160816; b=TCkAM88UNbrWSGS29e/JvxCP/f7i1ZQ6A07YGiWeH3Bc8vOHQopMpcyapflEoP5e6W /++GOPjCLA2Hxtw3brkshsYAGICyGc8rPSuW89EPDipqu1jXDD9duw7hORVn8EHE5Heg MKmDx7ktp4SBfOpcbSFo4/y+BSpE/FxK6pdxHt9RW+emYdDaVVINxLve6wADo1DHvGYx 3VO4gEa0jj2Q8AEk9GxL9DYxXPamdqBiLbHdFApk3x1VDwFsHn9x2T8QWoI84yZ6fZYb bAg6Igo0iV4KmaouwO72cdb7jPRTSMyNC9XWLtaUcoDFXfT7aMTd/clRXAMWBjxSFuLW BjVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ySyIYzqBpCfWbUlWOn49FAmGg4GlPY2orfOBkmTiBXk=; b=z6O0O+DeQVdzPFf1RVXMzCjohMeQSJ6/gzyVzRUJKK7uIRf8BlKomfPpETZjn36aYY MfgJ9bLghUIx0DDjChZNhu9UnUZ0RFwQibgJhw1kK1BGW0EP5z3MnRJBqAZCLY17UT2d zmRv6aUF42ht9V4Pcomv/MKFAxLW3IIbT/ozT493+N061MhoJRoZSwJEABX4T6ZrqAAm wASz9uMRo0/HgS/SujlXz7d5kyg7jhcSb5Ns+Euz0Qar7f/4CFMX7ERhqgRfcEY/lkzE ONPXLZnyVElmQp52MMDgIqHAul4kyT+QGN05NLh6TTVpMGJd4FSdOD+fXfNnf3ZFwMNI 4sSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Pek5gpwX; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d6si5116826otq.41.2019.12.20.02.17.50; Fri, 20 Dec 2019 02:17:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Pek5gpwX; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727276AbfLTKRt (ORCPT + 15 others); Fri, 20 Dec 2019 05:17:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:53184 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727327AbfLTKRt (ORCPT ); Fri, 20 Dec 2019 05:17:49 -0500 Received: from localhost.localdomain (unknown [106.201.107.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AC00F24685; Fri, 20 Dec 2019 10:17:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576837068; bh=9y+vE6be/fQg89xEmZaoRg10l2d1ad2HMwJK38tcPPo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Pek5gpwXHKbqG0cPWLKoN1eHZXptlJROT1u799eqAhU4dZ5tI1/IKP2caoTQHk2b4 nEG/JO1B2/yVpEub4V/AnObpUSzvwqMjIQZDuERG9q+WxHIWCEqGwGislHMT43+NVx iKtMWxDgRTJwtqr8k70e6DXf3K8T/rRJi2qz4ZGc= From: Vinod Koul To: Kishon Vijay Abraham I Cc: linux-arm-msm@vger.kernel.org, Bjorn Andersson , Vinod Koul , Andy Gross , Can Guo , Jeffrey Hugo , linux-kernel@vger.kernel.org Subject: [PATCH v2 3/5] phy: qcom-qmp: Add optional SW reset Date: Fri, 20 Dec 2019 15:47:17 +0530 Message-Id: <20191220101719.3024693-4-vkoul@kernel.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191220101719.3024693-1-vkoul@kernel.org> References: <20191220101719.3024693-1-vkoul@kernel.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org For V4 QMP UFS Phy, we need to assert reset bits, configure the phy and then deassert it, so add optional has_sw_reset flag and use that to configure the QPHY_SW_RESET register. Signed-off-by: Vinod Koul --- drivers/phy/qualcomm/phy-qcom-qmp.c | 11 +++++++++++ 1 file changed, 11 insertions(+) -- 2.23.0 diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c index 1196c85aa023..47a66d55107d 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c @@ -168,6 +168,7 @@ static const unsigned int sdm845_ufsphy_regs_layout[] = { static const unsigned int sm8150_ufsphy_regs_layout[] = { [QPHY_START_CTRL] = QPHY_V4_PHY_START, [QPHY_PCS_READY_STATUS] = QPHY_V4_PCS_READY_STATUS, + [QPHY_SW_RESET] = QPHY_V4_SW_RESET, }; static const struct qmp_phy_init_tbl msm8996_pcie_serdes_tbl[] = { @@ -1023,6 +1024,9 @@ struct qmp_phy_cfg { /* true, if PCS block has no separate SW_RESET register */ bool no_pcs_sw_reset; + + /* true if sw reset needs to be invoked */ + bool has_sw_reset; }; /** @@ -1391,6 +1395,7 @@ static const struct qmp_phy_cfg sm8150_ufsphy_cfg = { .is_dual_lane_phy = true, .no_pcs_sw_reset = true, + .has_sw_reset = true, }; static void qcom_qmp_phy_configure(void __iomem *base, @@ -1475,6 +1480,9 @@ static int qcom_qmp_phy_com_init(struct qmp_phy *qphy) SW_USB3PHY_RESET_MUX | SW_USB3PHY_RESET); } + if (cfg->has_sw_reset) + qphy_setbits(pcs, cfg->regs[QPHY_SW_RESET], SW_RESET); + if (cfg->has_phy_com_ctrl) qphy_setbits(serdes, cfg->regs[QPHY_COM_POWER_DOWN_CONTROL], SW_PWRDN); @@ -1651,6 +1659,9 @@ static int qcom_qmp_phy_enable(struct phy *phy) if (cfg->has_phy_dp_com_ctrl) qphy_clrbits(dp_com, QPHY_V3_DP_COM_SW_RESET, SW_RESET); + if (cfg->has_sw_reset) + qphy_clrbits(pcs, cfg->regs[QPHY_SW_RESET], SW_RESET); + /* start SerDes and Phy-Coding-Sublayer */ qphy_setbits(pcs, cfg->regs[QPHY_START_CTRL], cfg->start_ctrl); From patchwork Fri Dec 20 10:17:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 182230 Delivered-To: patch@linaro.org Received: by 2002:a92:1f98:0:0:0:0:0 with SMTP id f24csp325879ilf; Fri, 20 Dec 2019 02:17:54 -0800 (PST) X-Google-Smtp-Source: APXvYqwDxtI/jox72hTgbrs8nRJ/B7RWDRmLcvtr9tYAgXk7Ryr4Xz008hOHjVujfytMHoe8sjwM X-Received: by 2002:a9d:6f82:: with SMTP id h2mr14163632otq.69.1576837074422; Fri, 20 Dec 2019 02:17:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576837074; cv=none; d=google.com; s=arc-20160816; b=sil2VD3XTJMGjwH3jeiqaMWSL1eTdcyWvyhxGowECiZjHybCHjpbr5BrqG2c0KSaXc i3G3G68RpJ0X2vRI9N40/1OupwCSmNuWkoabgLTWBbVq7K20X1UyF9ArrRs8swkmlShq Mvn4QqkpirGIZ/tg8tZIL6ZWKxdw/TPPZQ73pZX4tbn2sJxiv2a/IbdLNrP9cciwZfYe VsicQZHA3gK/1vn3laB4cRlTJW5LhTP5vu2WW8PdBJ9+6tGwDBjvtRvSTLA5v1JUCqCt KNbVjBkjgJpcK+Zl9PICWVxhz71vuwR7f+U+yg/DskJQmtTQygiHqTk2SvIQn6s+KChK SPxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=taa0aEold4qGmLVO8d8wjYqY83nyZQX18qrEuLXgJKM=; b=sFxByXIG0Pj7g3HtKbJrurzwq3DuzFcsnnoY06AFfwjtIKhmdt6b9WYJRsLVrCRuDG NfE9UilozXNyVXVSziJFmCKs7smyKI7amR1qPrJ5Ly7ISYezY/VEUPMu72MeFnNpzxMi 540uyYjiiefriwTZKHKA5S80KKQbwgGFPf3U4wGe3Gs3ME1Z/wvOnGcPnOz2MbT2vQOk 9sNh2gs9WqGtx3dDSq8Xpc0BNnsOBJNeFkYQFYKWpyGVGouMk8GWEy5GI0ZbvdCLHJdt wl/+P6ZcpcfA49g88ZjLbUrJPE8IRa2r7im/Cir1l4PUk+4eWLE8M6POT7MrP4dK0jE0 8MGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zzBFMGgg; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h14si5211876otn.6.2019.12.20.02.17.54; Fri, 20 Dec 2019 02:17:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zzBFMGgg; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727437AbfLTKRx (ORCPT + 15 others); Fri, 20 Dec 2019 05:17:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:53258 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727327AbfLTKRw (ORCPT ); Fri, 20 Dec 2019 05:17:52 -0500 Received: from localhost.localdomain (unknown [106.201.107.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 358CC2467F; Fri, 20 Dec 2019 10:17:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576837072; bh=gWCt3r6TgCbriGXQfdsqIUuQ6iWj5AjVkeFPdeu1DoU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zzBFMGgg36f7Qz2mrSyFRGxf0x4yGX+0VdWzI4numDiw5hJUtlw7aYyeXaoBwrMkK N1kbStn7uv2wCg5ZUgqAVV3bf8uiIZ3MKEUGSi7Z8zAskEwmqEoq2eKxk6kfVULp14 Y22Sn0XfWMpD+VJEPP37lGD/X1JCRJXzBVuVHtG0= From: Vinod Koul To: Kishon Vijay Abraham I Cc: linux-arm-msm@vger.kernel.org, Bjorn Andersson , Vinod Koul , Andy Gross , Can Guo , Jeffrey Hugo , linux-kernel@vger.kernel.org Subject: [PATCH v2 4/5] phy: qcom-qmp: remove duplicate powerdown write Date: Fri, 20 Dec 2019 15:47:18 +0530 Message-Id: <20191220101719.3024693-5-vkoul@kernel.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191220101719.3024693-1-vkoul@kernel.org> References: <20191220101719.3024693-1-vkoul@kernel.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org We already write to QPHY_POWER_DOWN_CONTROL in qcom_qmp_phy_com_init() before invoking qcom_qmp_phy_configure() so remove the duplicate write. Signed-off-by: Vinod Koul Reviewed-by: Jeffrey Hugo Reviewed-by: Can Guo --- drivers/phy/qualcomm/phy-qcom-qmp.c | 1 - 1 file changed, 1 deletion(-) -- 2.23.0 diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c index 47a66d55107d..2a12a0b3bd72 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c @@ -886,7 +886,6 @@ static const struct qmp_phy_init_tbl msm8998_usb3_pcs_tbl[] = { }; static const struct qmp_phy_init_tbl sm8150_ufsphy_serdes_tbl[] = { - QMP_PHY_INIT_CFG(QPHY_POWER_DOWN_CONTROL, 0x01), QMP_PHY_INIT_CFG(QSERDES_V4_COM_SYSCLK_EN_SEL, 0xd9), QMP_PHY_INIT_CFG(QSERDES_V4_COM_HSCLK_SEL, 0x11), QMP_PHY_INIT_CFG(QSERDES_V4_COM_HSCLK_HS_SWITCH_SEL, 0x00),