From patchwork Mon Feb 3 11:50:32 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Chan X-Patchwork-Id: 861640 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C0C520409E; Mon, 3 Feb 2025 11:52:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738583551; cv=none; b=mHxFnvu4dA/C/8LDdq7HWwF2lp328osDqhd6NTg1T0zctQEW+4pnygueovMeZY+flflKbnHKWpDjAsfCef232MiQ8ZcQ5eEYeO3M6VmLzXiPitKefpTTIppUM9O2HHGJC9aXZWVS9hK1qhaCNesh8fECMRr/H/YYNQI7EwUdK5k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738583551; c=relaxed/simple; bh=e4LCw8b9TArgBNatCS4iPLDcnxNGjb099gyuFiAoxA8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eaWNlhg9TCFCvLwjy9IwsNeYZsPam+2+0pv5T8YNPfh8FdTSZztO+dtxYFwUIFDD+Cx960AVaOq1CbONlDcPe2LHVh/ezm07/bLKXgxu0545/wR0OIXsc5t19NoF9Z5cqxanpnJrZa71b7soLyN809hpVQdb6ZsYKSlakCVhkr0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AzMV41dr; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AzMV41dr" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2165cb60719so74877545ad.0; Mon, 03 Feb 2025 03:52:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738583549; x=1739188349; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Bvsk07Lzw6XdWgB2cdXk97Y7I1cSDuStLmoSGezH+tI=; b=AzMV41driRrt6qX3d4c/qcWdEoxbKX8ervDbKuFYvx7LpIxi/tt1ffKbl1L4XdcRJv fincyGI5Ui7PIex4H93Z+wUl3gOm5MivINZwQpY4hcESyIL1zucSfktBkYC2amjkRyZ2 MoimKUsRx7zBcu8jsCv426J2Bj7CTgYgawHzO/bG/bVYZq9lWsiKkDq3CHaS0Ar9oft3 QETp7pRm7Ar6xE8DPS7Wnfa6LaeJVZW+3nnL5E+fFaqj8XX9JNX6phEMs/VNNy5uiwiU TH4+0avftPd8ExvnW+mxbM6LXpunuSA53IQlfgyWuAFvt4zhSIpTbSOsZUC3Gdro2Rv2 6COw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738583549; x=1739188349; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Bvsk07Lzw6XdWgB2cdXk97Y7I1cSDuStLmoSGezH+tI=; b=IWKTliu+e7xaR59dE9olOkYKBp9pEDCzPUlqBPtsH4hKj0DNKF11nwjs3S29/PLoEh 9PeOu7Uqv1t1KRcSxUBLMYtvAZzsIQYbLhG8wo9T2ncD12ZSzlKBOtxnHIcpSlYhyCx/ tROAMuMuepF9hyioAErmO1+qrJPhYIR0PDlahmEapHShspLAN1OlyC+EPnRzhxnP+VYw he43jj6TNWlhcIG2Uuns4TjeUtGQXH/7x8ivF3V4TFevLUDoqt5KLIIqrBsqJLIRO4W/ XUjcvNqkQDfNef9HDS8x0uDTJCStTsGAYHTWmxvnoVqJ6t3zdqxNi94f9unugejDLacF 65Cg== X-Forwarded-Encrypted: i=1; AJvYcCU4h8g04K6cSnsqXUz2jrS+lYQiyc1oRuoiNSozf4gouNAEKl36G/Bq7LFQs6VwVyp/8g4SciyX87N2Tg==@vger.kernel.org, AJvYcCUDAR3HtL+0NKeDA5aOOOY7qw/twvFSN7+/y22I9mhzuJRH3TCoFDl6/2G0Xeyy6eZ69szb6D/rZVjC80RK@vger.kernel.org, AJvYcCVWx2ZjoRpk/uO5Kiu6t5SPIrj/INVILvox2Mov4JVy1x5uu/B5vYcRNavugl+wGgja76FRpITw/Bsg@vger.kernel.org, AJvYcCXOOFsjFvZLktpu0QUz2T4nLkN31fgVIu6UJT5xKc3g18kdZs8+OfDvEwj+5cic3WRWy2aa4dkKHwM/I7c=@vger.kernel.org X-Gm-Message-State: AOJu0YxXH+5Gs8lHKsYjWyBdFSGZJNdfoaFNmwDnythqNaSKRj8MFJ1A M7z78haAjl2AgbJN5Lm7z9XiqjNtCflQNpLkZYxWdps4yAmrHPAy X-Gm-Gg: ASbGnctUHVcqYSXo564HbJ8sfHNMBGFLAiTQGMY6GvQhgtauAod3aF1p/nzMhNAm9yN YBdRBpKFetXDnjwn6cSmYUi5pJPoJo6HowSenKj4FI5k0TnXVuN+Vk5gPZ6S4C5AXKbhRVT7ccl zbhlj24oBrpzjrkXe71UDuGk8FtjCqr69aGkaflsFTA81gGLm6KsHC0QSBSQmqR9wwxUltvWF1W QBY4pfHNIky6w+JjIpB56s4K+j16yJHnGGWGlOwH3hkyBxfRv93kzMxot1SuB9udaTgyNFq+7y5 KQjqiWoVPW0T6X7d X-Google-Smtp-Source: AGHT+IH1MtQsv7n9+03TmRQLhZL0KNOrrS14baU7/DtFKLh1qhS09XchSBq/EFGuV307S9+ypU09rw== X-Received: by 2002:a05:6a20:cd93:b0:1e1:afa9:d38a with SMTP id adf61e73a8af0-1ed7a48c85cmr32676039637.1.1738583549287; Mon, 03 Feb 2025 03:52:29 -0800 (PST) Received: from nick-mbp.. ([59.188.211.160]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-72fe631c039sm8262408b3a.25.2025.02.03.03.52.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2025 03:52:28 -0800 (PST) From: Nick Chan To: Hector Martin , Sven Peter , Alyssa Rosenzweig , Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Helge Deller , Nick Chan , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v5 RESEND 1/3] dt-bindings: leds: backlight: apple, dwi-bl: Add Apple DWI backlight Date: Mon, 3 Feb 2025 19:50:32 +0800 Message-ID: <20250203115156.28174-2-towinchenmi@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250203115156.28174-1-towinchenmi@gmail.com> References: <20250203115156.28174-1-towinchenmi@gmail.com> Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Add backlight controllers attached via Apple DWI 2-wire interface. Reviewed-by: Krzysztof Kozlowski Reviewed-by: Daniel Thompson (RISCstar) Signed-off-by: Nick Chan --- .../bindings/leds/backlight/apple,dwi-bl.yaml | 57 +++++++++++++++++++ 1 file changed, 57 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/backlight/apple,dwi-bl.yaml diff --git a/Documentation/devicetree/bindings/leds/backlight/apple,dwi-bl.yaml b/Documentation/devicetree/bindings/leds/backlight/apple,dwi-bl.yaml new file mode 100644 index 000000000000..29caeb356e6f --- /dev/null +++ b/Documentation/devicetree/bindings/leds/backlight/apple,dwi-bl.yaml @@ -0,0 +1,57 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/backlight/apple,dwi-bl.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Apple DWI 2-Wire Interface Backlight Controller + +maintainers: + - Nick Chan + +description: + Apple SoCs contain a 2-wire interface called DWI. On some Apple iPhones, + iPads and iPod touches with a LCD display, 1-2 backlight controllers + are connected via DWI. Interfacing with DWI controls all backlight + controllers at the same time. As such, the backlight controllers are + treated as a single controller regardless of the underlying + configuration. + +allOf: + - $ref: common.yaml# + +properties: + compatible: + items: + - enum: + - apple,s5l8960x-dwi-bl + - apple,t7000-dwi-bl + - apple,s8000-dwi-bl + - apple,t8010-dwi-bl + - apple,t8015-dwi-bl + - const: apple,dwi-bl + + reg: + maxItems: 1 + + power-domains: + maxItems: 1 + +required: + - compatible + - reg + +unevaluatedProperties: false + +examples: + - | + soc { + #address-cells = <2>; + #size-cells = <2>; + + dwi_bl: backlight@20e200010 { + compatible = "apple,s5l8960x-dwi-bl", "apple,dwi-bl"; + reg = <0x2 0x0e200010 0x0 0x8>; + power-domains = <&ps_dwi>; + }; + }; From patchwork Mon Feb 3 11:50:33 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Chan X-Patchwork-Id: 862202 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 127EF20409B; Mon, 3 Feb 2025 11:52:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738583555; cv=none; b=A9VbOyttcm5Kd6i3TRf5UtjVBywwLsrX+LH6gtWzaLFLS9Bw3V4/x7wE3z1j5PNd6BhX+p664usMfH7n55RTg+eWkfNA6OzcKsGgSh8Nh1hXgZdgu3e9gskxglyBib6a6Fz8E4prvn7x7pcimy2x3dZOkTBhEFhiW8KSv+AWJ9g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738583555; c=relaxed/simple; bh=QwDgbG+tY6+So94gundvFXsu5ZWRLKety0hbMOMSb2A=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MgigmH69/uxfgUY55rfXvZE/05/XjDjJZ3c0RwerOB4QBaWFW7mwrboFft6hY7JOMOBAPzZDUHtpo9GRnXKiqv/TZZKIsee1Tcgloe07JKl+yEKdS1blrql8fY/6PsJ2Cw216ks++dMpaln36gDOqN+ynz9TY3mZ1SNRwV1UeXQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JkzS/afA; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JkzS/afA" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2166f1e589cso3678285ad.3; Mon, 03 Feb 2025 03:52:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738583553; x=1739188353; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=NuVUwIb3ATElWRb+tDZLU6hMx05qo8CzOAa+DShnxhY=; b=JkzS/afAc2T12gfO9gpd7TCt3IUDOaZ+NBNiQyN50Ks1IqA3DKiBTMbWKkNWzv6XTB FLwZqE2xcIOTtrtjm0eupfJrxg8uKRPqWWzJ/ZmzdCwnA6qNFH4zEytpcam6YLCsVZw9 GqRCNLok4utRKmEBBnbu3rDGeZ0H8wSZiyOvMHYBo00Ex41axsHQrL49U7/I885urawA cMuOF3zKPMCpymPNy4Qyvlj17HG+bvMGswf8kXQcZBkaEBnDCyBsMN1+aFBahD/zPdj/ xTphR/1ed+gcSTLSRE00Y1mp7LRwD9Jv77cw84nLYPkSA2S7TDPFfY07pINOfTPeK7mF ip3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738583553; x=1739188353; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NuVUwIb3ATElWRb+tDZLU6hMx05qo8CzOAa+DShnxhY=; b=WnUvz/xVzmSF/AuQTrxe5tlRuHvzxMuYCI8qIXkqEgB5HEzdr7bOp3qGic3EPb72vq IirWU3T1PbGpU7ernG8hVR28ZuUY+NzkgmCynqRfSpe2b3cOHQB4hjt55RjbAQXSUdXm BvuJMIPIXF0/LYzylvRowDc7gMb7EiI68NAC8hNxdrd2wcB29GC/BmscgKH6H4ZRjK3w CKEmF5xOfrpSO444ZrnVw6MdmeN8jMmuSzQRgTBemPcJ/QYWlgX+RC9uFUF3NDInJKXp aU3x8APRurNGuK5IdtRl8Gb1+iNCKUkkrDsl03s7q+VFYCZbs0aS3RFbhX2d/xw485i8 FZwg== X-Forwarded-Encrypted: i=1; AJvYcCUopLi84F72MwKUMAgKAFtPDcq1kCwJ6ywUwqgOzYFC7QUTu2ih78IxyOj7X+7v0TA0KB7Js+Dr4iBt6GTW@vger.kernel.org, AJvYcCUwzfWJMFq/ACJDkvMsuGndrnpSgvCGpRtcahBLY5Tanwgl7HdG8ntYfn9j18FfuGaU07oIn1T4X7zrlXI=@vger.kernel.org, AJvYcCVnkP1VpzrtWckWHLA36dmDWpVoVA/xYDxh9fmCVU3awD8Nq4Z9gmewrOpLPmkB35cJSFh25sPqhdawnQ==@vger.kernel.org, AJvYcCX+yorpw+5a2cEkHHmyjDi387Yhm6p8FkA8z/GiApiou16TSzs407OU1gMgPM8dXJBJtJF6GkeFVs9g@vger.kernel.org X-Gm-Message-State: AOJu0YyK05COs5yCMlFYDlq2qiS6GESFPQm1bTBwQwfXNbGOD/RcnNtv SFw46ZBtEd06bAL7yyRrKDvICHgxPAPSgV5z8nRgik/kIBUYhC3D X-Gm-Gg: ASbGnctCBCF1HZ6J+QHbqrw1DpFyVArjdepUxLLqJ7CAY8Njjy/av6Pl+RPzltxO5cl tHKjubLdl07nE+qG6QV32yWkVhqU6EY2psowM2aP4fu2LG9sm5zPP7vdo0oCTvgQtHKgmAuMWsK +unQx+yJFM3wmgZ6folpSuO2LAkculnD56EQBqEFK9g4uq9UXvx5R7mFDR8kPc1rCP3cs1EsvqZ aVFZ/xkNBrAIJOy2DLyNVXkXXPcphukKjb6X5dXMSViAOXIFjWSLRidpEFxbU+pBMkfVDMr/UhG fw7a/oOZ35N5CbcO X-Google-Smtp-Source: AGHT+IHAUg+jBA6FADxyc/xDCHiXuFU49eYPAhY7dRRNEYaiurAK+cyssoskPZL1rJkF+Q3jR0YDHw== X-Received: by 2002:a05:6a00:2e14:b0:71e:4cff:2654 with SMTP id d2e1a72fcca58-72fd0bf7126mr31273767b3a.6.1738583553324; Mon, 03 Feb 2025 03:52:33 -0800 (PST) Received: from nick-mbp.. ([59.188.211.160]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-72fe631c039sm8262408b3a.25.2025.02.03.03.52.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2025 03:52:32 -0800 (PST) From: Nick Chan To: Hector Martin , Sven Peter , Alyssa Rosenzweig , Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Helge Deller , Nick Chan , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: [PATCH v5 RESEND 2/3] backlight: apple_dwi_bl: Add Apple DWI backlight driver Date: Mon, 3 Feb 2025 19:50:33 +0800 Message-ID: <20250203115156.28174-3-towinchenmi@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250203115156.28174-1-towinchenmi@gmail.com> References: <20250203115156.28174-1-towinchenmi@gmail.com> Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Add driver for backlight controllers attached via Apple DWI 2-wire interface, which is found on some Apple iPhones, iPads and iPod touches with a LCD display. Although there is an existing apple_bl driver, it is for backlight controllers on Intel Macs attached via PCI, which is completely different from the Samsung-derived DWI block. Signed-off-by: Nick Chan --- drivers/video/backlight/Kconfig | 12 +++ drivers/video/backlight/Makefile | 1 + drivers/video/backlight/apple_dwi_bl.c | 123 +++++++++++++++++++++++++ 3 files changed, 136 insertions(+) create mode 100644 drivers/video/backlight/apple_dwi_bl.c diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig index 3614a5d29c71..c6168727900a 100644 --- a/drivers/video/backlight/Kconfig +++ b/drivers/video/backlight/Kconfig @@ -290,6 +290,18 @@ config BACKLIGHT_APPLE If you have an Intel-based Apple say Y to enable a driver for its backlight. +config BACKLIGHT_APPLE_DWI + tristate "Apple DWI 2-Wire Interface Backlight Driver" + depends on ARCH_APPLE || COMPILE_TEST + default y + help + Say Y to enable the backlight driver for backlight controllers + attached via the Apple DWI 2-wire interface which is found in some + Apple iPhones, iPads and iPod touches. + + To compile this driver as a module, choose M here: the module will + be called apple_dwi_bl. + config BACKLIGHT_QCOM_WLED tristate "Qualcomm PMIC WLED Driver" select REGMAP diff --git a/drivers/video/backlight/Makefile b/drivers/video/backlight/Makefile index 8fc98f760a8a..156ff9461fb3 100644 --- a/drivers/video/backlight/Makefile +++ b/drivers/video/backlight/Makefile @@ -23,6 +23,7 @@ obj-$(CONFIG_BACKLIGHT_ADP5520) += adp5520_bl.o obj-$(CONFIG_BACKLIGHT_ADP8860) += adp8860_bl.o obj-$(CONFIG_BACKLIGHT_ADP8870) += adp8870_bl.o obj-$(CONFIG_BACKLIGHT_APPLE) += apple_bl.o +obj-$(CONFIG_BACKLIGHT_APPLE_DWI) += apple_dwi_bl.o obj-$(CONFIG_BACKLIGHT_AS3711) += as3711_bl.o obj-$(CONFIG_BACKLIGHT_BD6107) += bd6107.o obj-$(CONFIG_BACKLIGHT_CLASS_DEVICE) += backlight.o diff --git a/drivers/video/backlight/apple_dwi_bl.c b/drivers/video/backlight/apple_dwi_bl.c new file mode 100644 index 000000000000..93bd744972d6 --- /dev/null +++ b/drivers/video/backlight/apple_dwi_bl.c @@ -0,0 +1,123 @@ +// SPDX-License-Identifier: GPL-2.0 OR MIT +/* + * Driver for backlight controllers attached via Apple DWI 2-wire interface + * + * Copyright (c) 2024 Nick Chan + */ + +#include +#include +#include +#include +#include +#include + +#define DWI_BL_CTL 0x0 +#define DWI_BL_CTL_SEND1 BIT(0) +#define DWI_BL_CTL_SEND2 BIT(4) +#define DWI_BL_CTL_SEND3 BIT(5) +#define DWI_BL_CTL_LE_DATA BIT(6) +/* Only used on Apple A9 and later */ +#define DWI_BL_CTL_SEND4 BIT(12) + +#define DWI_BL_CMD 0x4 +#define DWI_BL_CMD_TYPE GENMASK(31, 28) +#define DWI_BL_CMD_TYPE_SET_BRIGHTNESS 0xa +#define DWI_BL_CMD_DATA GENMASK(10, 0) + +#define DWI_BL_CTL_SEND (DWI_BL_CTL_SEND1 | \ + DWI_BL_CTL_SEND2 | \ + DWI_BL_CTL_SEND3 | \ + DWI_BL_CTL_LE_DATA | \ + DWI_BL_CTL_SEND4) + +#define DWI_BL_MAX_BRIGHTNESS 2047 + +struct apple_dwi_bl { + void __iomem *base; +}; + +static int dwi_bl_update_status(struct backlight_device *bl) +{ + struct apple_dwi_bl *dwi_bl = bl_get_data(bl); + + int brightness = backlight_get_brightness(bl); + + u32 cmd = 0; + + cmd |= FIELD_PREP(DWI_BL_CMD_DATA, brightness); + cmd |= FIELD_PREP(DWI_BL_CMD_TYPE, DWI_BL_CMD_TYPE_SET_BRIGHTNESS); + + writel(cmd, dwi_bl->base + DWI_BL_CMD); + writel(DWI_BL_CTL_SEND, dwi_bl->base + DWI_BL_CTL); + + return 0; +} + +static int dwi_bl_get_brightness(struct backlight_device *bl) +{ + struct apple_dwi_bl *dwi_bl = bl_get_data(bl); + + u32 cmd = readl(dwi_bl->base + DWI_BL_CMD); + + return FIELD_GET(DWI_BL_CMD_DATA, cmd); +} + +static const struct backlight_ops dwi_bl_ops = { + .options = BL_CORE_SUSPENDRESUME, + .get_brightness = dwi_bl_get_brightness, + .update_status = dwi_bl_update_status +}; + +static int dwi_bl_probe(struct platform_device *dev) +{ + struct apple_dwi_bl *dwi_bl; + struct backlight_device *bl; + struct backlight_properties props; + struct resource *res; + + dwi_bl = devm_kzalloc(&dev->dev, sizeof(*dwi_bl), GFP_KERNEL); + if (!dwi_bl) + return -ENOMEM; + + dwi_bl->base = devm_platform_get_and_ioremap_resource(dev, 0, &res); + if (IS_ERR(dwi_bl->base)) + return PTR_ERR(dwi_bl->base); + + memset(&props, 0, sizeof(struct backlight_properties)); + props.type = BACKLIGHT_PLATFORM; + props.max_brightness = DWI_BL_MAX_BRIGHTNESS; + props.scale = BACKLIGHT_SCALE_LINEAR; + + bl = devm_backlight_device_register(&dev->dev, dev->name, &dev->dev, + dwi_bl, &dwi_bl_ops, &props); + if (IS_ERR(bl)) + return PTR_ERR(bl); + + platform_set_drvdata(dev, dwi_bl); + + bl->props.brightness = dwi_bl_get_brightness(bl); + + return 0; +} + +static const struct of_device_id dwi_bl_of_match[] = { + { .compatible = "apple,dwi-bl" }, + {}, +}; + +MODULE_DEVICE_TABLE(of, dwi_bl_of_match); + +static struct platform_driver dwi_bl_driver = { + .driver = { + .name = "apple-dwi-bl", + .of_match_table = dwi_bl_of_match + }, + .probe = dwi_bl_probe, +}; + +module_platform_driver(dwi_bl_driver); + +MODULE_DESCRIPTION("Apple DWI Backlight Driver"); +MODULE_AUTHOR("Nick Chan "); +MODULE_LICENSE("Dual MIT/GPL"); From patchwork Mon Feb 3 11:50:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Chan X-Patchwork-Id: 861639 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25E472045A2; Mon, 3 Feb 2025 11:52:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738583559; cv=none; b=SNKhZEwzkcI8nJ4zRm1XIQRI0ZyUCtvNxa8Ow3RDOw4r7H+qjUN2LfefVeTW1bSGUlEJ4HwpnGZ4k8922p4GA812RXGQAw0k1TPaKiyCadZbaLOmUX8SfCpKHFWf4xASWBmdJtbt2EIhbrR9C1jFkcj0lcARKQTxJPCxZksanvI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738583559; c=relaxed/simple; bh=mtPz4s+4egQ0jOh3GQAGAPwNPBPu0BZnd8qj+UMcZso=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=X8xj1O1d5JkEzlDoiDvM2uFDLCTydrGcwYwmcktf/5g3BoYYo/fXog1QwaFUHpdqVsumcPdaC9zrRoWwIpSbtn+jVEe35M3WHg9xQso5vylX7tXGxhdLhiptrBVI4pEv6gmRM36j0fmRkGOy2ryZIpagH3he3Vv8V/UIjuRMEQQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Zr6GL1mC; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Zr6GL1mC" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2161eb94cceso49914835ad.2; Mon, 03 Feb 2025 03:52:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738583557; x=1739188357; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Uc4uCqsleGcCsKVC2kCtafnEyIcpxj+3QblkARK4r2c=; b=Zr6GL1mCVD35zEQCcBoyuLXtiuDYsnmfSGU/iwcnbuWjCS0ZDe7P8EAIJIq/mKXjrL E/lmKMRZKClU/YGa5ukT0H5QM24PI65D/TXT2mtjLt3WJkY1UusXTzOcWRWc/tethChZ JTrDGI/iOay6k74seXvzboEG74idEwEzTc9OjJbJekzK0cNCsJMHA5xMkmJA5CfI+QH+ t7dbk/hHX4DHxpX93dzNQq5If1fiDOSfmIRxXaV6L0QPX2WPF/hrCV583wGVez3+1VqH sf9rNdkfPCNazRfge9HLIfThioxN3gcUIiWd085hdeYy0yJavBoTaZ2q+RpG4nq5yrgD OjKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738583557; x=1739188357; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Uc4uCqsleGcCsKVC2kCtafnEyIcpxj+3QblkARK4r2c=; b=gDETCQgnAFpAyz+SBawRoz0p4paZOTcQWYG4H9M/JSHHnVYVjSZaq6oR41hfUUWiG5 yLVZNQNkuZWnFhSUg8bE1ztAznAhXKv6nzIsR+LYeRVWWk1s5yTPwDnGoej1XDFO/XHE hRJW/vRyO4pv4O8n5HKF1YB5DcDV5j26c3hbbnYzy1I+SuBWBAjoc3RqSY5PcNWM9Qdd XCLAr69W8QeNIhVLJg61HvHczKzvwuF/irOCI8mhjjikNX/7499ysOVlpC45cxzhQmZM ahLV4Y0W/XJTlQ/yuo4u0FIiK7cE1CR7oT7BbPYhwS1PkkkI788XMxuvtJXBvQ5xq3pc KuiA== X-Forwarded-Encrypted: i=1; AJvYcCUSSYrxSIeR1oG4RbpcRJPl0ub/9f4owINj7EDixv88rEbqoSJtHytZJWsUgmm8pZWkA/GxmwVkvoVZSw==@vger.kernel.org, AJvYcCUvnomiKUBzg9d2E19hYBvmV0U0lutsQr33oMKoYtIMclXKV04D/w25QeQmKxdGWYTn5CgUbCLgIS1EPTEH@vger.kernel.org, AJvYcCVILihiV700WSJbUrE5Lx9GS+I4VY2BNZScGMRdzzch62onZSU9b8YRRGP/wuXp89CV7am5Tea+RCEQ@vger.kernel.org, AJvYcCVzhcbHHzwdLDRybGeWgGf/xikHPAt2NW+F5qiQ4nYoYCxF2O6otNwMq0amFjqXHVlDiV6wroswilHrzZQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyoEGQwG9t7SVxkimi+pq3ZzYua7qKjtWpsNwMft88A9RAj35gl Vq9+E+WHi2Usm1fG9UjyJiyc0SMP8oRW9IPTidScFHcihyts7BGO X-Gm-Gg: ASbGncuyDBCpUB5DV9JPqCsqr7Hn2/mmg6I/TTW9HPlUmlzCL17NPBADShwaUxaA7L/ 5COEcEh7hHo0PEmcqZ549jVYplgqUjC3mJJPpBAE6saRs8hUtwHr4bHKmoRvQBX64WaxhcAV8rB 9yLzQ8nyyWe7TOHJwpSTl6sgeE7RcONtvIy2RA1XMjINzJOrtEd4QCvFnwIeC/d9D8AdSh9EtN5 V2CGWJs/MbvOYSeKngxenVT7UxrJRRE3Qu+7wgWSgdWYKpNogRf+g4NR6C4FYfoY4RDVXddBPz2 0wSo9eK1eFHF+50K X-Google-Smtp-Source: AGHT+IG9OzjbgkvCS8tq7nwliRQ7D0GE7eIK1YFb7OgjbU/H0UhSsEr4jVXSBegVQdOpNlym0wtPBw== X-Received: by 2002:a05:6a00:4642:b0:725:f1b1:cbc5 with SMTP id d2e1a72fcca58-72fd0bc26c1mr38178820b3a.3.1738583557299; Mon, 03 Feb 2025 03:52:37 -0800 (PST) Received: from nick-mbp.. ([59.188.211.160]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-72fe631c039sm8262408b3a.25.2025.02.03.03.52.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2025 03:52:36 -0800 (PST) From: Nick Chan To: Hector Martin , Sven Peter , Alyssa Rosenzweig , Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Helge Deller , Nick Chan , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: [PATCH v5 RESEND 3/3] MAINTAINERS: Add entries for Apple DWI backlight controller Date: Mon, 3 Feb 2025 19:50:34 +0800 Message-ID: <20250203115156.28174-4-towinchenmi@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250203115156.28174-1-towinchenmi@gmail.com> References: <20250203115156.28174-1-towinchenmi@gmail.com> Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Add MAINTAINERS entries for the driver. Reviewed-by: Daniel Thompson (RISCstar) Signed-off-by: Nick Chan --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 896a307fa065..a576324807f5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2228,6 +2228,7 @@ F: Documentation/devicetree/bindings/i2c/apple,i2c.yaml F: Documentation/devicetree/bindings/interrupt-controller/apple,* F: Documentation/devicetree/bindings/iommu/apple,dart.yaml F: Documentation/devicetree/bindings/iommu/apple,sart.yaml +F: Documentation/devicetree/bindings/leds/backlight/apple,dwi-bl.yaml F: Documentation/devicetree/bindings/mailbox/apple,mailbox.yaml F: Documentation/devicetree/bindings/net/bluetooth/brcm,bcm4377-bluetooth.yaml F: Documentation/devicetree/bindings/nvme/apple,nvme-ans.yaml @@ -2253,6 +2254,7 @@ F: drivers/nvmem/apple-efuses.c F: drivers/pinctrl/pinctrl-apple-gpio.c F: drivers/pwm/pwm-apple.c F: drivers/soc/apple/* +F: drivers/video/backlight/apple_dwi_bl.c F: drivers/watchdog/apple_wdt.c F: include/dt-bindings/interrupt-controller/apple-aic.h F: include/dt-bindings/pinctrl/apple.h