From patchwork Thu Feb 6 11:15:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akash Kumar X-Patchwork-Id: 862943 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 341EC46BF; Thu, 6 Feb 2025 11:16:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738840579; cv=none; b=ZwvmXR1Q2TwYb0A5Eve0s04La6ST6mXu1aOHMZermu6k8k7BWFgv6mQj9SrB0hjdP9PXR8mhuXbuxNVqAvX2ebWI2tCsjGK9QLOtr0j1vW0JDY1OUSxg5BOdJ8NtNIivxBoiGZXVrAf9B0j6+ptaCB+2Q2TyLLiqm7JAEi7iLY0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738840579; c=relaxed/simple; bh=lZlj0tm43siYbSBXyKlzgDvp+YGdKBp3z7Siz9fTpFE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WizLpbcPObkUp1ukZYQ1+9i7uh9YCGZLWOj0Xf0QAySBze0FHwbxEVwRYUYU585qxbs2lnfok1BtG4xSIF17Ya1b4vtT+XCLrtKHxEUMIQFzxxA4R+pUo2JHIlZesc4EZpFBPfb1tdtEtzXWrZRv+JlXavqaA7eDjLH3TVRxK4k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=VgVC7LD8; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="VgVC7LD8" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 516AES2R021985; Thu, 6 Feb 2025 11:16:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=JbhsLWjnrEZW9Cujvt2qHprj 1MSkff69H7zdTBdnURg=; b=VgVC7LD8mSVEqWNuxOFPkcuW6uN+iewuZ7TLjryl +hRsryBvCFSlWE5IabTcOo3HE9b4HQ9cdguCxGSi3wFF8svq3vPnhQx1t554Bi6R e9wCHkJjc5sOIZdb2nE6B3dgTYKmF7h8ymjKFRTE2/ZqPkG6edDBObKo59xDx0Eb cwBVJI7ZWrHax/elYMb0xD9MWsI9pafuhx7xCQP39qZXqn3upHfgiTOCaU20Voqh LIjWBMFGDbvAoFZIEaPsilIV1sDJRrPbM5xZwfnzZv8kUqfGNu9gBUikQQQP8v8R H6qYdFVb8eDoToXk/efM1p1a8lQt2IbiNYwv6kyBsxAsew== Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44mu5gg4gy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 06 Feb 2025 11:16:12 +0000 (GMT) Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA04.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 516BGBiI008535 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 6 Feb 2025 11:16:11 GMT Received: from hu-akakum-hyd.qualcomm.com (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Thu, 6 Feb 2025 03:16:07 -0800 From: Akash Kumar To: Thinh Nguyen , Greg Kroah-Hartman , Jack Pham , , Wesley Cheng CC: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Vijayavardhan Vennapusa" , , , Akash Kumar Subject: [PATCH 02/18] arm64: dts: qcom: sa8775p: Enable high bandwidth for hs isoc eps Date: Thu, 6 Feb 2025 16:45:27 +0530 Message-ID: <20250206111543.17392-3-quic_akakum@quicinc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250206111543.17392-1-quic_akakum@quicinc.com> References: <20250206111543.17392-1-quic_akakum@quicinc.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: lC0nzx8NPTDpxRvcHgT0CgyMwmKs4v2S X-Proofpoint-GUID: lC0nzx8NPTDpxRvcHgT0CgyMwmKs4v2S X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-06_03,2025-02-05_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 phishscore=0 impostorscore=0 mlxlogscore=926 suspectscore=0 mlxscore=0 bulkscore=0 adultscore=0 clxscore=1015 priorityscore=1501 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2501170000 definitions=main-2502060093 It is observed while testing multiple audio devices, a glitch is observed during testing. As per dwc datasheet,By default, HC reserves 80% of the bandwidth for periodic EPs. Add quirk to set GUCTL BIT 16 to accommodate higher bandwidth for 2 isoc eps. If this bit is set, the bandwidth is relaxed to 85% to accommodate two high speed, high bandwidth ISOC EPs. USB 2.0 required 80% bandwidth allocated for ISOC traffic. If two High-bandwidth ISOC devices (HD Webcams) are connected, and if each requires 1024-bytes X 3 packets per Micro-Frame, then the bandwidth required is around 82%. If this bit is set, then it is possible to connect two Webcams of 1024bytes X 3 paylod per Micro-Frame each. Otherwise, you may have to reduce the resolution of the Webcams. This bit is valid in Host and DRD configuration and is used in host mode operation only. USe this quirk to set bit for host mode uvc uac usecases where two isoc eps are used and flicker is seen. Signed-off-by: Akash Kumar --- arch/arm64/boot/dts/qcom/sa8775p.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi index 3394ae2d1300..230b432cc3ac 100644 --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi @@ -3431,6 +3431,7 @@ phy-names = "usb2-phy", "usb3-phy"; snps,dis-u1-entry-quirk; snps,dis-u2-entry-quirk; + snps,dwc3_guctl_resbwhseps_quirk; }; }; @@ -3522,6 +3523,7 @@ phy-names = "usb2-phy", "usb3-phy"; snps,dis-u1-entry-quirk; snps,dis-u2-entry-quirk; + snps,dwc3_guctl_resbwhseps_quirk; }; }; @@ -3587,6 +3589,7 @@ phy-names = "usb2-phy"; snps,dis-u1-entry-quirk; snps,dis-u2-entry-quirk; + snps,dwc3_guctl_resbwhseps_quirk; }; }; From patchwork Thu Feb 6 11:15:29 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akash Kumar X-Patchwork-Id: 862942 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5CD321422B; Thu, 6 Feb 2025 11:16:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738840590; cv=none; b=MXZWG+IdFiVOrXuPbTjMWC1APaf77n/UVA3DlaZBodTtq486VUrwcXK4gqdAJMUe45/7/1W9GIKP+wEGTWBgk0DDH+LoCqLKHTJDRNpXu52HlcM9wDNzwYIb6FX9gcnEX98Otr1rPDoXfKVf4uG1cDFM5uk59SuYeOmJ90Zire8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738840590; c=relaxed/simple; bh=0EMq1NQVxY1lRRKkoDXpgXQyju6s4RNSfLlmhDP8zpw=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rBej4wml3g3IlyDsUIMkf+qnR4EnCOOrGRY1fbWeBrznUO0ZHMq4oUkWxH0OKfu+jJRUdMpS3t452Qi+nL4+dz/vKzqSpT+HyAS+GScPBl+rEvvXIROd1VV8RBYnyB3YbCcQ6EJRbkzly+aaEdLFjoaW+jgrb/8XgSsBVLrXuHk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=N12cHgub; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="N12cHgub" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5168bXXm014568; Thu, 6 Feb 2025 11:16:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=8qoP0oaxC7t5eHklRBPwSJ4Z 6B870MySvdoqL+Xb4uo=; b=N12cHgubBYIIV1wsLsSbvg8pEvbw57sz84ymJOb+ vR4a2HhcNv++Vb0dQ2X06Q5fyq928YFG7cQDbaiZfHFr8cYFWofKa8twtpVJMg1o 08R/5xHCjGzpU4EV+79Gk+SnzqkAXrZEnFjJR1w0ypc8cB1IPChm8tK6SHC8tsJy PwPB9PzgyyHhWaOfxn7U8GX9ohs645AoL8UmarO4sr5MmqRaxYutaUvm8UJtBoZg wMKig+nBFr4c0u7dhL22CnrDJiHUQPvtT0c0GtSYlgXORPvSHJ4iWdf/bGtzM40v ts2yUXBerIwxy+j38YD37QPQrQ+8ZpD1l8s5fAJ4X1FB+g== Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44msr10dkt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 06 Feb 2025 11:16:24 +0000 (GMT) Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA02.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 516BGNxl020997 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 6 Feb 2025 11:16:23 GMT Received: from hu-akakum-hyd.qualcomm.com (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Thu, 6 Feb 2025 03:16:19 -0800 From: Akash Kumar To: Thinh Nguyen , Greg Kroah-Hartman , Jack Pham , , Wesley Cheng CC: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Vijayavardhan Vennapusa" , , , Akash Kumar Subject: [PATCH 04/18] arm64: dts: qcom: sm8450: Enable high bandwidth for hs isoc eps Date: Thu, 6 Feb 2025 16:45:29 +0530 Message-ID: <20250206111543.17392-5-quic_akakum@quicinc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250206111543.17392-1-quic_akakum@quicinc.com> References: <20250206111543.17392-1-quic_akakum@quicinc.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: Hk8w4i6VPdCj_FjKsuV9KjayUTS58th3 X-Proofpoint-GUID: Hk8w4i6VPdCj_FjKsuV9KjayUTS58th3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-06_03,2025-02-05_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 impostorscore=0 mlxlogscore=999 clxscore=1015 mlxscore=0 suspectscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2501170000 definitions=main-2502060093 It is observed while testing multiple audio devices, a glitch is observed during testing. As per dwc datasheet,By default, HC reserves 80% of the bandwidth for periodic EPs. Add quirk to set GUCTL BIT 16 to accommodate higher bandwidth for 2 isoc eps. If this bit is set, the bandwidth is relaxed to 85% to accommodate two high speed, high bandwidth ISOC EPs. USB 2.0 required 80% bandwidth allocated for ISOC traffic. If two High-bandwidth ISOC devices (HD Webcams) are connected, and if each requires 1024-bytes X 3 packets per Micro-Frame, then the bandwidth required is around 82%. If this bit is set, then it is possible to connect two Webcams of 1024bytes X 3 paylod per Micro-Frame each. Otherwise, you may have to reduce the resolution of the Webcams. This bit is valid in Host and DRD configuration and is used in host mode operation only. USe this quirk to set bit for host mode uvc uac usecases where two isoc eps are used and flicker is seen. Signed-off-by: Akash Kumar --- arch/arm64/boot/dts/qcom/sm8450.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi index 9c809fc5fa45..95d5a67b7b9a 100644 --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi @@ -5400,6 +5400,7 @@ snps,dis_enblslpm_quirk; snps,dis-u1-entry-quirk; snps,dis-u2-entry-quirk; + snps,dwc3_guctl_resbwhseps_quirk; phys = <&usb_1_hsphy>, <&usb_1_qmpphy QMP_USB43DP_USB3_PHY>; phy-names = "usb2-phy", "usb3-phy"; From patchwork Thu Feb 6 11:15:31 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akash Kumar X-Patchwork-Id: 862941 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3A6422E41C; Thu, 6 Feb 2025 11:16:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738840598; cv=none; b=fhdeBUc31QuzYtTnaQt73w6l24bhqqdpe+Ajnw/PFM3mMpUieEWtQIBS72R3AIUeZz83bSx43R48xYwJWuIqTF25ZcLb3bM21LPszatILw9qNKgFgwDRkBMww3CbzRdNiPCw+hlOgmgot44r85w5vt7Z05fOkrB9GEOamQbppM0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738840598; c=relaxed/simple; bh=+HB3bKm68PmTdv/1QvWAeBzv4phkRlMxf+z+5ud8XB8=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dxgKEnIjocrQb8f7l8CvxshDdVx7/eqL7umG241+3vyBh6cn7TmnWd99B5N4OKqsxpNuapboTYYXCwtkaTxqp8QK3Ix1uTEQfn9FlvcO2341ZUZdZT1/Z9VbmN54AYQd7m+UbVccqyOhZkE0MCOhQJSaAbOPHF3kN2ms2yWiano= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=YFnfLZvj; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="YFnfLZvj" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5169mdw2015404; Thu, 6 Feb 2025 11:16:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=QzlwLz4QD4miPNlSfLm/ELON JpDjImC3QALnMHOAXEI=; b=YFnfLZvjKz9itXblEJukVwAX0VCxsrTinNIQ2UNA zP+gdfrzdbRXTHYozDyvBNV12xScrh0iabp6v0BjpSQDuf/iZ0MCJSdgJboyvjV/ U/S5bcC5ERaXw82ovjTkiDOH+H3iZ0W0Lk8JIsHikTINIIX0r7h/66Ara199mtrx pBsByrqsMYEMnCiv+hKu3kxJr3uE51I3xHZBjZB03jSVsLOhgkoFQDdFwu8Saguh 98eQQ96g7nUvFgoDuFA/hU5QbK2msvKjxTnDz/LLC9zOVnvGQBy+/pNZzed/XFdW ZSk5Og3vEw+8THt/urSdV9xvBrzZ8f/E5brqtgx2Row00w== Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44mtsa06u0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 06 Feb 2025 11:16:33 +0000 (GMT) Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA05.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 516BGWUw002240 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 6 Feb 2025 11:16:32 GMT Received: from hu-akakum-hyd.qualcomm.com (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Thu, 6 Feb 2025 03:16:27 -0800 From: Akash Kumar To: Thinh Nguyen , Greg Kroah-Hartman , Jack Pham , , Wesley Cheng CC: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Vijayavardhan Vennapusa" , , , Akash Kumar Subject: [PATCH 06/18] arm64: dts: qcom: sm6125: Enable high bandwidth for hs isoc eps Date: Thu, 6 Feb 2025 16:45:31 +0530 Message-ID: <20250206111543.17392-7-quic_akakum@quicinc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250206111543.17392-1-quic_akakum@quicinc.com> References: <20250206111543.17392-1-quic_akakum@quicinc.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: rxiiaw0n3sF1rD2eemMtg3GulQfYTJfu X-Proofpoint-ORIG-GUID: rxiiaw0n3sF1rD2eemMtg3GulQfYTJfu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-06_03,2025-02-05_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 lowpriorityscore=0 spamscore=0 impostorscore=0 priorityscore=1501 clxscore=1011 mlxscore=0 adultscore=0 bulkscore=0 mlxlogscore=956 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2501170000 definitions=main-2502060093 It is observed while testing multiple audio devices, a glitch is observed during testing. As per dwc datasheet,By default, HC reserves 80% of the bandwidth for periodic EPs. Add quirk to set GUCTL BIT 16 to accommodate higher bandwidth for 2 isoc eps. If this bit is set, the bandwidth is relaxed to 85% to accommodate two high speed, high bandwidth ISOC EPs. USB 2.0 required 80% bandwidth allocated for ISOC traffic. If two High-bandwidth ISOC devices (HD Webcams) are connected, and if each requires 1024-bytes X 3 packets per Micro-Frame, then the bandwidth required is around 82%. If this bit is set, then it is possible to connect two Webcams of 1024bytes X 3 paylod per Micro-Frame each. Otherwise, you may have to reduce the resolution of the Webcams. This bit is valid in Host and DRD configuration and is used in host mode operation only. USe this quirk to set bit for host mode uvc uac usecases where two isoc eps are used and flicker is seen. Signed-off-by: Akash Kumar --- arch/arm64/boot/dts/qcom/sm6125.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/qcom/sm6125.dtsi b/arch/arm64/boot/dts/qcom/sm6125.dtsi index 350d807a622f..d84c85342851 100644 --- a/arch/arm64/boot/dts/qcom/sm6125.dtsi +++ b/arch/arm64/boot/dts/qcom/sm6125.dtsi @@ -1211,6 +1211,7 @@ snps,dis_enblslpm_quirk; snps,dis-u1-entry-quirk; snps,dis-u2-entry-quirk; + snps,dwc3_guctl_resbwhseps_quirk; maximum-speed = "high-speed"; dr_mode = "peripheral"; }; From patchwork Thu Feb 6 11:15:33 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akash Kumar X-Patchwork-Id: 862940 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B5A922F389; Thu, 6 Feb 2025 11:16:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738840607; cv=none; b=KuToiMLNVEWDDei2/eZzYQyCDkP5VPolhSXAuXlwymiB5ksYjgjY5Hfh/WeMFqm9/0GzIFhjKKFlB8oWx2Mtv0RNQvsMt9Kb/47OqUwk7A4geiYLe5QXfR3ToI/S27ty2NMpPCECS+2GkFLZ5onIHpHMLLRUZMVzWS90tVk0xrg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738840607; c=relaxed/simple; bh=1chXtfx8ODD12KgIqOEjdx95uT6u6y2/Fwb/jy7bmrU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=gEIyLjuZOLyU2+euCAZN6mNgkK7xLHJu2o5z0QJvwVa66eTCPTSOQZqqIlZkyfumh/6M26owGByNbzD4fo75qkH8I9ovTcGzgpDvTzApiNvAR4zS1zQFy7vbsBTuHEhhkxiJQe5zcCyQt05J0fAcItOyZ790tnQgzStKvRjGJfQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=j80fdNq+; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="j80fdNq+" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5169KZQR011499; Thu, 6 Feb 2025 11:16:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=ImuT2mNGyiBjQiN8BGd0mmfX rtojjYSjD0CP4zV2nBI=; b=j80fdNq+wqRVnJfU18FcmlO8jyiCz4MBQl1yerJq JSI3UykuqeQvWu5dZW66XT82k36fD4UuxjPP0ZOInscma7KgxNBkYVJinm42OXCa 9AcaMuHr0Uwk1cAjbsWgtvXHr6T4qmcQqnuE1ejP1dy7/UrQ92QU65qsFWio1Z1p 026pKe3Ooj/bQejbgNjSVey4oEOiJRF6V0N6NWBybc8w5p19hskgnBol24M8ObIc Q0VhAtBy6ncYPtYWbBZfOlelTxaccd8uUhuMdooxokyw13BPsTkjIRipua9Drapa 1Q61xyhk4Pi++wLKEOcyDs2MFjhgOczCr2nLMFfUiL/EFA== Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44mtc68a34-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 06 Feb 2025 11:16:41 +0000 (GMT) Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA05.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 516BGeir002347 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 6 Feb 2025 11:16:40 GMT Received: from hu-akakum-hyd.qualcomm.com (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Thu, 6 Feb 2025 03:16:36 -0800 From: Akash Kumar To: Thinh Nguyen , Greg Kroah-Hartman , Jack Pham , , Wesley Cheng CC: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Vijayavardhan Vennapusa" , , , Akash Kumar Subject: [PATCH 08/18] arm64: dts: qcom: sm6350: Enable high bandwidth for hs isoc eps Date: Thu, 6 Feb 2025 16:45:33 +0530 Message-ID: <20250206111543.17392-9-quic_akakum@quicinc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250206111543.17392-1-quic_akakum@quicinc.com> References: <20250206111543.17392-1-quic_akakum@quicinc.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: BqGbgtjoAmLN7W02fyk3vkhqUbcOiojL X-Proofpoint-GUID: BqGbgtjoAmLN7W02fyk3vkhqUbcOiojL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-06_03,2025-02-05_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 spamscore=0 clxscore=1015 mlxlogscore=999 lowpriorityscore=0 bulkscore=0 impostorscore=0 phishscore=0 priorityscore=1501 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2501170000 definitions=main-2502060093 It is observed while testing multiple audio devices, a glitch is observed during testing. As per dwc datasheet,By default, HC reserves 80% of the bandwidth for periodic EPs. Add quirk to set GUCTL BIT 16 to accommodate higher bandwidth for 2 isoc eps. If this bit is set, the bandwidth is relaxed to 85% to accommodate two high speed, high bandwidth ISOC EPs. USB 2.0 required 80% bandwidth allocated for ISOC traffic. If two High-bandwidth ISOC devices (HD Webcams) are connected, and if each requires 1024-bytes X 3 packets per Micro-Frame, then the bandwidth required is around 82%. If this bit is set, then it is possible to connect two Webcams of 1024bytes X 3 paylod per Micro-Frame each. Otherwise, you may have to reduce the resolution of the Webcams. This bit is valid in Host and DRD configuration and is used in host mode operation only. USe this quirk to set bit for host mode uvc uac usecases where two isoc eps are used and flicker is seen. Signed-off-by: Akash Kumar --- arch/arm64/boot/dts/qcom/sm6350.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom/sm6350.dtsi index 00ad1d09a195..5bfef5800548 100644 --- a/arch/arm64/boot/dts/qcom/sm6350.dtsi +++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi @@ -1926,6 +1926,7 @@ snps,parkmode-disable-ss-quirk; snps,dis-u1-entry-quirk; snps,dis-u2-entry-quirk; + snps,dwc3_guctl_resbwhseps_quirk; phys = <&usb_1_hsphy>, <&usb_1_qmpphy QMP_USB43DP_USB3_PHY>; phy-names = "usb2-phy", "usb3-phy"; usb-role-switch; From patchwork Thu Feb 6 11:15:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akash Kumar X-Patchwork-Id: 862939 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9579A22AE71; Thu, 6 Feb 2025 11:16:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738840616; cv=none; b=RW7yNCdIP8u84S/j77PO5z4qhDfzwvjqv0TMH72mUZRDUFhmvw/68nrHY9z1ghmmYhzyizYPjLZCy0dhkmaYNM/ZHaovQWKLUBFms6qHa4KexS9HF5HAS34FT1FaHMhATQNkCps6TfpvVjJpSCiIycDIMlsu+68vYOIusNIllV8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738840616; c=relaxed/simple; bh=BOwx6/aeZ2074a3PKyQcRGEZzSXU0flwFWloX/nzQVw=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=D0IrwJkdyHFWs3BU2ZUrzqmUY4LIz/ClyYIHmxh8CJ/wc8IaHS4jPQbUMSbWofv8JIh+cTkrHJiUntAMXxBFsKNF+mbtydotjqgixPUsNlLoUSukJM/2docgBmQhzHCgBxHAIPrJeIzwr84E3hKlvBqRhxUXLOoQRkZiqpKxqcs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=T9RQ880E; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="T9RQ880E" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5169lxq3026763; Thu, 6 Feb 2025 11:16:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=QYESYvG0Rvk/9d1tkzN2raXV Ct2tQ610K/YF9iQM8a8=; b=T9RQ880E1rxSyrCTDjlp3mocvey7vXrWtfZ5k7Ez 82PzP/XJP3rdRe6EXFMeLnpK4ayAStVJtSYR3wqA/itsbeoKAzkBDeUS41kQB3SI O40EmIbmMPw8mKOlBwxY3QZl7QmdFot3luM6VM36zQEn2+2ZR/k4qtsx5AGXBjcL rbFxEXiPOkgFYumnmyFsEtVaIMHarC5rZBLJtQZpRd2/IdiNXp+rhSf1mwhmlj1L tSU6k+SGkK1pCFNUNTW6XOy17mQWmr/4JmCPdcz5tdGNyel7KDnzKiXFmvl2NF3C 4yUcvsiYoIvwHUKC0V5SALhzCx+k3HoYDuV6lZ4g/rvirA== Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44mtrx876f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 06 Feb 2025 11:16:49 +0000 (GMT) Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA03.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 516BGnGl014071 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 6 Feb 2025 11:16:49 GMT Received: from hu-akakum-hyd.qualcomm.com (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Thu, 6 Feb 2025 03:16:44 -0800 From: Akash Kumar To: Thinh Nguyen , Greg Kroah-Hartman , Jack Pham , , Wesley Cheng CC: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Vijayavardhan Vennapusa" , , , Akash Kumar Subject: [PATCH 10/18] arm64: dts: qcom: sdm630: Enable high bandwidth for hs isoc eps Date: Thu, 6 Feb 2025 16:45:35 +0530 Message-ID: <20250206111543.17392-11-quic_akakum@quicinc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250206111543.17392-1-quic_akakum@quicinc.com> References: <20250206111543.17392-1-quic_akakum@quicinc.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: FZAD6IxXctlWam2qw1z9heaFXMQreJFo X-Proofpoint-GUID: FZAD6IxXctlWam2qw1z9heaFXMQreJFo X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-06_03,2025-02-05_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 priorityscore=1501 mlxlogscore=979 clxscore=1011 adultscore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 bulkscore=0 phishscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2501170000 definitions=main-2502060092 It is observed while testing multiple audio devices, a glitch is observed during testing. As per dwc datasheet,By default, HC reserves 80% of the bandwidth for periodic EPs. Add quirk to set GUCTL BIT 16 to accommodate higher bandwidth for 2 isoc eps. If this bit is set, the bandwidth is relaxed to 85% to accommodate two high speed, high bandwidth ISOC EPs. USB 2.0 required 80% bandwidth allocated for ISOC traffic. If two High-bandwidth ISOC devices (HD Webcams) are connected, and if each requires 1024-bytes X 3 packets per Micro-Frame, then the bandwidth required is around 82%. If this bit is set, then it is possible to connect two Webcams of 1024bytes X 3 paylod per Micro-Frame each. Otherwise, you may have to reduce the resolution of the Webcams. This bit is valid in Host and DRD configuration and is used in host mode operation only. USe this quirk to set bit for host mode uvc uac usecases where two isoc eps are used and flicker is seen. Signed-off-by: Akash Kumar --- arch/arm64/boot/dts/qcom/sdm630.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi index a2c079bac1a7..985f1252d7fd 100644 --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi @@ -1302,6 +1302,7 @@ snps,parkmode-disable-ss-quirk; snps,dis-u1-entry-quirk; snps,dis-u2-entry-quirk; + snps,dwc3_guctl_resbwhseps_quirk; phys = <&qusb2phy0>, <&usb3_qmpphy>; phy-names = "usb2-phy", "usb3-phy"; @@ -1509,6 +1510,7 @@ snps,dis_enblslpm_quirk; snps,dis-u1-entry-quirk; snps,dis-u2-entry-quirk; + snps,dwc3_guctl_resbwhseps_quirk; /* This is the HS-only host */ maximum-speed = "high-speed"; From patchwork Thu Feb 6 11:15:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akash Kumar X-Patchwork-Id: 862938 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFC46230262; Thu, 6 Feb 2025 11:17:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738840623; cv=none; b=XEpnyvhavgpv461fhOHyvkaS575W6k9sIPBNcCvRx9RC7l1qZJ049khCmyiQMniegqL8c34j6m7RfJ8vjXnD4CgYmrNw1ERc+0t3nOVH3wSDJz8J4FihgzkRNv5uBqLsJX9I2P49ddVeiBU4/UeaPJ+zXPmGTOx+Tr6Z+Xzp8uk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738840623; c=relaxed/simple; bh=NRN3FST4wbsPvxGfOs6e4A67Mh7/7uHbNhqp9HX7Aow=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=bMgY5MdlFBlQav/3acq8GjyBQuKi9wv+HpJZ/Dq6N0l/C8WGF0tBBHnCLZPvLbTdpjEO4tdWRMyFKTk8Ry6TxbiZr8+QKEUQK+ZIbWcDVAbxGTNDbPQ/Y02eEEUA1DvqbjeQQ8GbeCJPq0FyIodwG4tUmwO41+RQhQBfj8XCoGA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=Itz6GE/C; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="Itz6GE/C" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5169lqYh026712; Thu, 6 Feb 2025 11:16:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=CVO0rFyy+d07RgYwM5IY3u1Y rBdA6/FHVGadO6eOr5g=; b=Itz6GE/ClkIqjxTdcFxdQuYc4yk4lQTjwhSr8pwn p065dGvJVF48Y12NO4/bUJK4o/ayKKLNBsZL5fF8Rl7jS3dHLaFIDeLCDpRCwWi3 /z3aluOEbxvXOhvhd84QU1A53aGMIW4oJWmt7FNQ61++iJnLS7nks29dGC27sV+l Cv9dvXXSFfB2Fc2vCPq7JJCqtD/DfJZf2VEMoPobv2OZ2gqoNOR9hIDdKIOvoJb/ coTJjUdnvn9v4qJLSyY3C/K4GmpRKF2ipwTkH/wXhvzntS8HZcOKmO7afBi+y/4V BFBo/NwAxG3Toiqqlgnvid65CCpMgp+J/qg9zMOt6fRTjQ== Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44mtrx876x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 06 Feb 2025 11:16:58 +0000 (GMT) Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA03.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 516BGvUr014183 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 6 Feb 2025 11:16:57 GMT Received: from hu-akakum-hyd.qualcomm.com (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Thu, 6 Feb 2025 03:16:53 -0800 From: Akash Kumar To: Thinh Nguyen , Greg Kroah-Hartman , Jack Pham , , Wesley Cheng CC: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Vijayavardhan Vennapusa" , , , Akash Kumar Subject: [PATCH 12/18] arm64: dts: qcom: sdx75: Enable high bandwidth for hs isoc eps Date: Thu, 6 Feb 2025 16:45:37 +0530 Message-ID: <20250206111543.17392-13-quic_akakum@quicinc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250206111543.17392-1-quic_akakum@quicinc.com> References: <20250206111543.17392-1-quic_akakum@quicinc.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: XSOrxTQYojEvnw5jwr3DJZtUsNKAVAUU X-Proofpoint-GUID: XSOrxTQYojEvnw5jwr3DJZtUsNKAVAUU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-06_03,2025-02-05_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 priorityscore=1501 mlxlogscore=999 clxscore=1015 adultscore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 bulkscore=0 phishscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2501170000 definitions=main-2502060092 It is observed while testing multiple audio devices, a glitch is observed during testing. As per dwc datasheet,By default, HC reserves 80% of the bandwidth for periodic EPs. Add quirk to set GUCTL BIT 16 to accommodate higher bandwidth for 2 isoc eps. If this bit is set, the bandwidth is relaxed to 85% to accommodate two high speed, high bandwidth ISOC EPs. USB 2.0 required 80% bandwidth allocated for ISOC traffic. If two High-bandwidth ISOC devices (HD Webcams) are connected, and if each requires 1024-bytes X 3 packets per Micro-Frame, then the bandwidth required is around 82%. If this bit is set, then it is possible to connect two Webcams of 1024bytes X 3 paylod per Micro-Frame each. Otherwise, you may have to reduce the resolution of the Webcams. This bit is valid in Host and DRD configuration and is used in host mode operation only. USe this quirk to set bit for host mode uvc uac usecases where two isoc eps are used and flicker is seen. Signed-off-by: Akash Kumar --- arch/arm64/boot/dts/qcom/sdx75.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/qcom/sdx75.dtsi b/arch/arm64/boot/dts/qcom/sdx75.dtsi index b0a8a0fe5f39..f46374fd785c 100644 --- a/arch/arm64/boot/dts/qcom/sdx75.dtsi +++ b/arch/arm64/boot/dts/qcom/sdx75.dtsi @@ -1039,6 +1039,7 @@ snps,dis_enblslpm_quirk; snps,dis-u1-entry-quirk; snps,dis-u2-entry-quirk; + snps,dwc3_guctl_resbwhseps_quirk; phys = <&usb_hsphy>, <&usb_qmpphy>; phy-names = "usb2-phy", From patchwork Thu Feb 6 11:15:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akash Kumar X-Patchwork-Id: 862937 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6687B22CBFC; Thu, 6 Feb 2025 11:17:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738840632; cv=none; b=boDUngvNYSgmyxLW2IsGmmtlbdP9ooR6jwAGjAu6ZosAJlmE1GQd4oNlKHeSapoLBTLTnBfs7jsGG7OBwxpvdiVap/o5dzyqo5YyX68AOfqHGs6M+ZopZcMFkSm1YovayOIQW5Mu0CwU0SxZVoDGSs9O7RvpsCsQ1OoVETdarwk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738840632; c=relaxed/simple; bh=/5wvv7eSRq3FrQZD0IJBd+plWXbPmX2VobczVXNG/Xw=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=XMeq2H/Gq22ZKRTpwnS4H8TQFOF5knsnoSwBjDuyqh4+itzZnp8P/B1KHQiMkyKdc9o3eDtiwX2CRIufz7Mjhr/DClV1wOK39qImTGfkk4uh2jF9a0rZt03/c8rlAuIPxutg3mmD7vFvWECA58dms+J7lXy3frDSDQ29qVG0KMI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=DmORLoDz; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="DmORLoDz" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 516AF8qi022748; Thu, 6 Feb 2025 11:17:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=By8Apog1PErQvms2lzozV7b0 dLKJfO+xAGI5aW9qfmY=; b=DmORLoDz9I47I5Pg45pfR/G1TvGAmRThEEIqu3OI kL9ac+4hmagtF5MSCka/rO7WM6l4MKV3vIw2IAWJkKbX3z/a6aWKKk1nA7bP5aIf j4gUJCM0FhNfRJYQt8yZpMD8f3hnzs/EnPeviy8jNv05dv25BprHs47+BTER5LpD eauHxa5jVMaOzBLJAmAJ+EST5c4wmbuXIVwdHjAfMJ7yiMV5QyjcyJg+fnRnq63P CWXOOIuZIcYb7MrS3KzrsN5zJ1pNqSsQg9Gz+tHJsHPebqyrin2/WUfABwgWznbd 0y7UnEUZIj2LZ7dRsWCnD2nAzoyD9g/xL6ACC4vRd73gxA== Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44mu5gg4kq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 06 Feb 2025 11:17:07 +0000 (GMT) Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA04.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 516BH6tf009854 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 6 Feb 2025 11:17:06 GMT Received: from hu-akakum-hyd.qualcomm.com (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Thu, 6 Feb 2025 03:17:01 -0800 From: Akash Kumar To: Thinh Nguyen , Greg Kroah-Hartman , Jack Pham , , Wesley Cheng CC: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Vijayavardhan Vennapusa" , , , Akash Kumar Subject: [PATCH 14/18] arm64: dts: qcom: sc7180: Enable high bandwidth for hs isoc eps Date: Thu, 6 Feb 2025 16:45:39 +0530 Message-ID: <20250206111543.17392-15-quic_akakum@quicinc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250206111543.17392-1-quic_akakum@quicinc.com> References: <20250206111543.17392-1-quic_akakum@quicinc.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: AgZLHUf3z49DrgDmEDKIqX_WdeblPr6J X-Proofpoint-GUID: AgZLHUf3z49DrgDmEDKIqX_WdeblPr6J X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-06_03,2025-02-05_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 phishscore=0 impostorscore=0 mlxlogscore=995 suspectscore=0 mlxscore=0 bulkscore=0 adultscore=0 clxscore=1015 priorityscore=1501 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2501170000 definitions=main-2502060093 It is observed while testing multiple audio devices, a glitch is observed during testing. As per dwc datasheet,By default, HC reserves 80% of the bandwidth for periodic EPs. Add quirk to set GUCTL BIT 16 to accommodate higher bandwidth for 2 isoc eps. If this bit is set, the bandwidth is relaxed to 85% to accommodate two high speed, high bandwidth ISOC EPs. USB 2.0 required 80% bandwidth allocated for ISOC traffic. If two High-bandwidth ISOC devices (HD Webcams) are connected, and if each requires 1024-bytes X 3 packets per Micro-Frame, then the bandwidth required is around 82%. If this bit is set, then it is possible to connect two Webcams of 1024bytes X 3 paylod per Micro-Frame each. Otherwise, you may have to reduce the resolution of the Webcams. This bit is valid in Host and DRD configuration and is used in host mode operation only. USe this quirk to set bit for host mode uvc uac usecases where two isoc eps are used and flicker is seen. Signed-off-by: Akash Kumar --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index 87c432c12a24..e22aa8a757f9 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -3066,6 +3066,7 @@ snps,parkmode-disable-ss-quirk; snps,dis-u1-entry-quirk; snps,dis-u2-entry-quirk; + snps,dwc3_guctl_resbwhseps_quirk; phys = <&usb_1_hsphy>, <&usb_1_qmpphy QMP_USB43DP_USB3_PHY>; phy-names = "usb2-phy", "usb3-phy"; maximum-speed = "super-speed"; From patchwork Thu Feb 6 11:15:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akash Kumar X-Patchwork-Id: 862936 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC5182309BF; Thu, 6 Feb 2025 11:17:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738840641; cv=none; b=ISyOPxmICcFZwzxDsAjkFLUgQ0mTmYSDLntROLPN024310vTfWTwe52ws9atYnVrym93FxHBOXlixYA5d9jGuo10r+dnUorD3305Y4V8jj3d3tcyVFF/SKzJUtPdja1bDBCLaMF7UXSOcXZZRwURbAz4qFqV9TekYXtbQrcwino= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738840641; c=relaxed/simple; bh=l4DohLaGZsOx+16nGTRP2GHIfESdx5qCXcoJFUEJYYE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Sr8ZZ8LpvBXgIV6h+atjER8QXMGR6+JTjYt7TkStCyP/ftg/+xt5ATDhoLHEfYLjk7dRpcdqmRnZBTP4dGzpwtk1pSLEzbvnvshz7InCzCW2ncThbRks8HmzZFoyaIxkXRZ2BFDVCiaa+M/p1JGBLmHocoaGOLGvcaNx6X+JPuA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=j6JejNpS; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="j6JejNpS" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5169KTgU011381; Thu, 6 Feb 2025 11:17:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=nl2DHcxEqB9pjO80oGBXr7Sn 45aZgBkr81f5OIc/M9g=; b=j6JejNpSEAAbtWypAb1XGEN9Qt/R4nCiXlo/cLvg 4oVgKS6+51pC8KpDB3fasr9L1IPG+3zyoBIVt7TnYmTUs5pQozARbjORehnNTDDs QbJhf71Od7qLNQwmn9ZMEzfGBnNwrkZTWOMpJgC5FRrLx0AU2RQSZDddEouAjepv JYmKlnhzw7+6hMzS+oEVxCJodi2kgVJ3ROBhkn2ovgM7V/tRPr+7qxvluaHKTl5m hlrDKVLYnmU+hl1cYlDBg82H/c7jjGGjgu6JSjJ38fI0v08jNAfoebPBrfoYe2AZ oTCWWJzV1GxGbJc7Vr6Q304ITivUW8fNYRhTuGHj9rDCeg== Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44mtc68a4q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 06 Feb 2025 11:17:15 +0000 (GMT) Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA04.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 516BHEHD010006 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 6 Feb 2025 11:17:14 GMT Received: from hu-akakum-hyd.qualcomm.com (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Thu, 6 Feb 2025 03:17:10 -0800 From: Akash Kumar To: Thinh Nguyen , Greg Kroah-Hartman , Jack Pham , , Wesley Cheng CC: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Vijayavardhan Vennapusa" , , , Akash Kumar Subject: [PATCH 16/18] arm64: dts: qcom: Enable high bandwidth for hs isoc eps Date: Thu, 6 Feb 2025 16:45:41 +0530 Message-ID: <20250206111543.17392-17-quic_akakum@quicinc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250206111543.17392-1-quic_akakum@quicinc.com> References: <20250206111543.17392-1-quic_akakum@quicinc.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: oXjmP7xybj9AI-r3Nd2phQrw9JpoelQx X-Proofpoint-GUID: oXjmP7xybj9AI-r3Nd2phQrw9JpoelQx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-06_03,2025-02-05_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 spamscore=0 clxscore=1015 mlxlogscore=999 lowpriorityscore=0 bulkscore=0 impostorscore=0 phishscore=0 priorityscore=1501 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2501170000 definitions=main-2502060093 It is observed while testing multiple audio devices, a glitch is observed during testing. As per dwc datasheet,By default, HC reserves 80% of the bandwidth for periodic EPs. Add quirk to set GUCTL BIT 16 to accommodate higher bandwidth for 2 isoc eps. If this bit is set, the bandwidth is relaxed to 85% to accommodate two high speed, high bandwidth ISOC EPs. USB 2.0 required 80% bandwidth allocated for ISOC traffic. If two High-bandwidth ISOC devices (HD Webcams) are connected, and if each requires 1024-bytes X 3 packets per Micro-Frame, then the bandwidth required is around 82%. If this bit is set, then it is possible to connect two Webcams of 1024bytes X 3 paylod per Micro-Frame each. Otherwise, you may have to reduce the resolution of the Webcams. This bit is valid in Host and DRD configuration and is used in host mode operation only. USe this quirk to set bit for host mode uvc uac usecases where two isoc eps are used and flicker is seen. Signed-off-by: Akash Kumar --- arch/arm64/boot/dts/qcom/qdu1000.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/qcom/qdu1000.dtsi b/arch/arm64/boot/dts/qcom/qdu1000.dtsi index f973aa8f7477..bc1a0b7e0d3a 100644 --- a/arch/arm64/boot/dts/qcom/qdu1000.dtsi +++ b/arch/arm64/boot/dts/qcom/qdu1000.dtsi @@ -1025,6 +1025,7 @@ snps,dis_enblslpm_quirk; snps,dis-u1-entry-quirk; snps,dis-u2-entry-quirk; + snps,dwc3_guctl_resbwhseps_quirk; phys = <&usb_1_hsphy>, <&usb_1_qmpphy>; phy-names = "usb2-phy", From patchwork Thu Feb 6 11:15:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akash Kumar X-Patchwork-Id: 862935 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76617231A4C; Thu, 6 Feb 2025 11:17:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738840649; cv=none; b=IveHhfvTJzVthVqjNfesg+7yJ1AOpsZ+VzKXMOoUvcuLkfQOPSHDlBOO4iYs2fCsUOW0JhifIcLf6XAKU9p57MYuCOEn2D+dezQJqB+I91TNAFRs8IyV8xbLwT7HHzywFTc6HF+akHcvZDbCJyu0U7eXb1WWc6R7J+FOLJ9Ev+M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738840649; c=relaxed/simple; bh=9L8v/jl6HSIO/6Dv+m2eRFhdPWznBdGxxI8lE91xy+E=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Lbon55AzvpGWufdMV8qDQLcKhb2UIL0FPfRjICnNgTYHaaRdd4GysQVvaesqdDlmIglFYe1WH6efdog6FAy/ExIlnMiTmbMB9CgEnj6KoJ/eJ2XzXI6plvXtIZObzcjNLeBzbLnKGC5zpf486wrGWP9xT8jfn09of4qY2UZIGqk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=K8RnFg9n; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="K8RnFg9n" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5169dqvs022537; Thu, 6 Feb 2025 11:17:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=GZWmSmi1VtT9mCKl6G3K8hDw bOPO1HBGZzHKdkg+pxo=; b=K8RnFg9nWnZNGFIw8+dMvGttjPOuUw+24LPlwQKh MU/aDZEIX17Oi9vouOI4mXag6GT+MmN/5PCoE7/tmjNb8h09mXLLSxmXHYHMR++X N/+HE0Zte5EGqiBotDe1rR8VSv+ktuYxIthKlRUTw9PM4Oj+fxwVjy9BwXv7PJxM R5pl+n1PjbDRN16UFPPeQVM00F3kyUpTWj9G3ckuFj/juv2FppkkH6+1VV/xjlLW 4w3pBJfnL8QNR7TurIaB9J6cpVvI3MtVsPX7CUUuWtGeHWuy98T6+zpIYeCBmsqq A8y0ntslEZmg0XnVreGM9qsUPsj2gGAJP8qtLtPmDRjqTg== Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44mtn7g7kt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 06 Feb 2025 11:17:24 +0000 (GMT) Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA03.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 516BHNKw014514 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 6 Feb 2025 11:17:23 GMT Received: from hu-akakum-hyd.qualcomm.com (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Thu, 6 Feb 2025 03:17:19 -0800 From: Akash Kumar To: Thinh Nguyen , Greg Kroah-Hartman , Jack Pham , , Wesley Cheng CC: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Vijayavardhan Vennapusa" , , , Akash Kumar Subject: [PATCH 18/18] arm64: dts: qcom: sc8180x: Enable high bandwidth for hs isoc eps Date: Thu, 6 Feb 2025 16:45:43 +0530 Message-ID: <20250206111543.17392-19-quic_akakum@quicinc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250206111543.17392-1-quic_akakum@quicinc.com> References: <20250206111543.17392-1-quic_akakum@quicinc.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: Fiapd-lVlyX6-irdFofSnmoPr1q9Tttw X-Proofpoint-ORIG-GUID: Fiapd-lVlyX6-irdFofSnmoPr1q9Tttw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-06_03,2025-02-05_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 mlxlogscore=989 impostorscore=0 lowpriorityscore=0 phishscore=0 suspectscore=0 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2501170000 definitions=main-2502060092 It is observed while testing multiple audio devices, a glitch is observed during testing. As per dwc datasheet,By default, HC reserves 80% of the bandwidth for periodic EPs. Add quirk to set GUCTL BIT 16 to accommodate higher bandwidth for 2 isoc eps. If this bit is set, the bandwidth is relaxed to 85% to accommodate two high speed, high bandwidth ISOC EPs. USB 2.0 required 80% bandwidth allocated for ISOC traffic. If two High-bandwidth ISOC devices (HD Webcams) are connected, and if each requires 1024-bytes X 3 packets per Micro-Frame, then the bandwidth required is around 82%. If this bit is set, then it is possible to connect two Webcams of 1024bytes X 3 paylod per Micro-Frame each. Otherwise, you may have to reduce the resolution of the Webcams. This bit is valid in Host and DRD configuration and is used in host mode operation only. USe this quirk to set bit for host mode uvc uac usecases where two isoc eps are used and flicker is seen. Signed-off-by: Akash Kumar --- arch/arm64/boot/dts/qcom/sc8180x.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi index 28693a3bfc7f..fafc907efa84 100644 --- a/arch/arm64/boot/dts/qcom/sc8180x.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi @@ -2764,6 +2764,7 @@ snps,dis_enblslpm_quirk; snps,dis-u1-entry-quirk; snps,dis-u2-entry-quirk; + snps,dwc3_guctl_resbwhseps_quirk; phys = <&usb_mp_hsphy0>, <&usb_mp_qmpphy0>, <&usb_mp_hsphy1>, @@ -2829,6 +2830,7 @@ snps,dis_enblslpm_quirk; snps,dis-u1-entry-quirk; snps,dis-u2-entry-quirk; + snps,dwc3_guctl_resbwhseps_quirk; phys = <&usb_prim_hsphy>, <&usb_prim_qmpphy QMP_USB43DP_USB3_PHY>; phy-names = "usb2-phy", "usb3-phy"; @@ -2908,6 +2910,7 @@ snps,dis_enblslpm_quirk; snps,dis-u1-entry-quirk; snps,dis-u2-entry-quirk; + snps,dwc3_guctl_resbwhseps_quirk; phys = <&usb_sec_hsphy>, <&usb_sec_qmpphy QMP_USB43DP_USB3_PHY>; phy-names = "usb2-phy", "usb3-phy";