From patchwork Tue Feb 11 12:08:46 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 864634 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFB951FBCBC for ; Tue, 11 Feb 2025 12:08:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739275736; cv=none; b=tFhMSKv9hQP4a4SJxeen4aPKXSx+z/gbY5qy8Cm9L6Hq3YBZS9kX/95Ir/Ll/9466N1FbVKglUvoz2ZXWXApBVsc0jRTwuKQzS0+PMxyq/15/7mvD8Rt5s1ufzPpzrZ1RmnQdI60eM2G8RlqKmiJGnUgNOzBvAXOXlTmm9GsPic= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739275736; c=relaxed/simple; bh=DMmQKJUWoLWDTo6CsUcRWGqMfh0KVbe3frTIjat0dVs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=fuYlq4o4HtTRw2rfEj2bg0CIPjQiqCsFf+28qBmITMwUfWP1cykHanaTatSTwWyoxOfZE7J9WDjvNQsmKsokkMWDxUTarQQ2YzTsiRdEwnSLOaqdWnv4KtYJsvVv4nuyYcvC0H+K3mUNms6VyVyv1U4R9s71rnHxgo1/6GM/d2I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=wEXSWn+2; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="wEXSWn+2" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4361b0ec57aso55037885e9.0 for ; Tue, 11 Feb 2025 04:08:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1739275732; x=1739880532; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=aW+CbC+3CkKX6aO8ZADFZPA9ixVxGeRfqoxuCdLGR9k=; b=wEXSWn+2CACgypv+TqvOq4RAmQXX7MaHs6meynTIne8CStuRTWjuqIEYuuzM3oFKg0 HiKjz9yz6a8a/bCceHnYMNNBsQonZ/3blbDPREWWC6CX79kyBYUU2wNw/IXvKS+trwww 5wbs0DqhJH/KvtmVuACuLb6HI6UYdOHKzKg66a7yEMC4+7Q1UXK2CIq/IupRKhr4IK0B GfAPn9A84G9WVprh+NiXCnPw/n9tSn8xZua4X42JlmH8vyXJKhnR0BuA7T65ZuUdNyl2 o6afhCcikqG9ZjRTQbYKQBdFDpnyTo/mI0lAa83YxCpdnyQqoetVUHP6VZiy+f653kl7 yoeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739275732; x=1739880532; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aW+CbC+3CkKX6aO8ZADFZPA9ixVxGeRfqoxuCdLGR9k=; b=vTbB3xNVz2FPDZ4rBXqG7RcKsK6xdMpXG9JAf7nsO57xRo7lsbFkLCczmmP3TDAMYG S0CNpVP7MOhIaOWe+iD0J/TFJMRqAaOfjNLhpW3ZZJXtHuUMDdI9U8JSv+He5oIBKMvV KJOVJy0CDBhBiloJG5u1NO/7Xkscwv0EH8E9544S6GPyAkotzRDd41t+ElVHatcIbXh5 SgEUpb+YTQHeJgBOU4wl51JkfBR1ezVk/OcmUkeY2IaxD9Wb0dBsblIPqpAfA5r+jOPh 05cmGiv7kC3x4UgRiQ7qUuYdWPEZHqssigy8B4S2s6kMb8smS3iPNEW8wFDEXtJvSeVh ILGQ== X-Gm-Message-State: AOJu0Yy3kpSr3oxbnvRiSSJk+JEWdDJtLnu5JQ7QVThUr0BR5FYDUB5H OuWo/qM7SEGkyQt1WIp0JcG/PWLmUss8vSmwzudjN0abNBwonX0ZCcR6UGJ3lxIKsN99ps+RFpH 6vIg= X-Gm-Gg: ASbGnct8n27IyuYLoPRCAFkfGju5bzB70HMdxzR5j4pZePvuhH/qjxN0c0l8tz2FI1Z aRtIfdT1eEEwm2H5UWVsNsjPXXpn/MOKnT7bOwGp9DOhd5WHmod7jFoXStcyHM0qR/y6PqRG6VC SEoQ474hpYca2r7LatvP4fMAua1pdXQ36gmzZJZ3LPhctkUz3Uj2YIXewVVnoCKqh2Lq0bVOq6T 10MRv5yAN9/Z6iHZec0mSqLoQ/TlQ0Wp0tRdoVqiwlyMnbFo4jnnJg8F+QethE2soYZ1Jr+YHkR 4eJAm5Ouzs+Y5A== X-Google-Smtp-Source: AGHT+IGDzevVeKanekK8LsK569/EGDe7hIKmgjII5hLLH9kDMlcAizGPk9JfK4EPb34oW1q9kfAhqg== X-Received: by 2002:a05:600c:5844:b0:439:5560:c9a1 with SMTP id 5b1f17b1804b1-4395560cc1dmr14883275e9.4.1739275731736; Tue, 11 Feb 2025 04:08:51 -0800 (PST) Received: from brgl-uxlite.home ([2a01:cb1d:dc:7e00:561:8978:1d41:636a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4393b66f3e3sm86966375e9.19.2025.02.11.04.08.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2025 04:08:51 -0800 (PST) From: Bartosz Golaszewski To: Linus Walleij Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH 1/2] gpio: latch: use generic device properties Date: Tue, 11 Feb 2025 13:08:46 +0100 Message-ID: <20250211120847.42437-1-brgl@bgdev.pl> X-Mailer: git-send-email 2.45.2 Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Bartosz Golaszewski Replace calls to OF-specific interface with generic device property getters. This is good practice and also drops implicit run-time dependency on CONFIG_OF. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-latch.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-latch.c b/drivers/gpio/gpio-latch.c index d7c3b20c8482..722eb5b045f5 100644 --- a/drivers/gpio/gpio-latch.c +++ b/drivers/gpio/gpio-latch.c @@ -44,6 +44,7 @@ #include #include #include +#include #include #include "gpiolib.h" @@ -138,9 +139,9 @@ static bool gpio_latch_can_sleep(struct gpio_latch_priv *priv, unsigned int n_la static int gpio_latch_probe(struct platform_device *pdev) { + struct device *dev = &pdev->dev; struct gpio_latch_priv *priv; unsigned int n_latches; - struct device_node *np = pdev->dev.of_node; priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); if (!priv) @@ -172,14 +173,16 @@ static int gpio_latch_probe(struct platform_device *pdev) spin_lock_init(&priv->spinlock); } - of_property_read_u32(np, "setup-duration-ns", &priv->setup_duration_ns); + device_property_read_u32(dev, "setup-duration-ns", + &priv->setup_duration_ns); if (priv->setup_duration_ns > DURATION_NS_MAX) { dev_warn(&pdev->dev, "setup-duration-ns too high, limit to %d\n", DURATION_NS_MAX); priv->setup_duration_ns = DURATION_NS_MAX; } - of_property_read_u32(np, "clock-duration-ns", &priv->clock_duration_ns); + device_property_read_u32(dev, "clock-duration-ns", + &priv->clock_duration_ns); if (priv->clock_duration_ns > DURATION_NS_MAX) { dev_warn(&pdev->dev, "clock-duration-ns too high, limit to %d\n", DURATION_NS_MAX); From patchwork Tue Feb 11 12:08:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 864229 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E44E1FBE9E for ; Tue, 11 Feb 2025 12:08:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739275736; cv=none; b=d2gjtTOMtx70cpiEkibWK3i8QSGHvKDGGsYfybaWlGJjiyPEj8Llol7Vpdf0csl41CCNT+0G4zdBBbWrF0YuPzYOxSsWokhiDHUfyZhprOFHBszIxhAkrzSVLwc6D9THIAtFKLuj7mxkUouRPL+j0jz9sz5Ah6vNuN7IdIDzCRQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739275736; c=relaxed/simple; bh=UHUYIddf+n4H5dMnEJICjm1zFmW3Cc7Ddp9PK9+vm8k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eTd/ve2ZCHozjf7feEY428i1r3PUqgQ2Rup9kNZbgdQ3WRSfryU5paZZBH+qAx2EKrb9L2PCE5LMiTOseYBcrDZ0cTWxB2IlHaFv0M5cEEEFvtVvGyGGuARUOhN7qcJPXorOg/uQ8xoEbFVe2D95eTylCqNWk4xEHceUfhq137E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=tVZ2+aqB; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="tVZ2+aqB" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-43690d4605dso37325505e9.0 for ; Tue, 11 Feb 2025 04:08:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1739275732; x=1739880532; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/LXQ6cLbViDtV5N9eGseg4G8vDo8CWaGoGPlt8jHaoQ=; b=tVZ2+aqB5Z3QaMqHt07of/aKKe+ybG/ysHStS/kD/dl0tYmWfS2HvrLDoYMGddyEid sJTuCYXMP4TjoIhdflvT45RjQrdvUMoik5aJjiH2XkSSB7gUhibhiq4E8HOgyjbA/Xfv RYQNIRI5GTMAHogBOSFVqSNP3orl5EQlw/X6fDGe33pwdaZwWtqOOMMCxiG0xQOOA/p9 dj5fRhBEE1Wg9+QTgo4uHav6HGjTCbz2pIYOLCi2+3G8mDh609FtWJop6oE8HqWShcD1 p7N6m0ueykNr+rJYgptFmoTWvyKFbLoqnqZYFOujrTDcIooVzPfbEVdxac/AhujY2JDd vpiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739275732; x=1739880532; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/LXQ6cLbViDtV5N9eGseg4G8vDo8CWaGoGPlt8jHaoQ=; b=sfaUXzQ5eOm/Ctcgycu5EajBVrNgTpatrsL2W/waYrh1Dw0Ke1tcboUTyOQHSJQ7dH oXQ3hlakgU+9lkvjp/l7lh9JQ06eYPdgA8ldCeEd4hMxR427JdQefZSAzipS8qfztWgP loFtETOpnUu7BP0z9TCDL0SqrHpQHinRu/Fb0S4DhkVA9qJ5Lx7aMzplIw5+kkPNghyw vPCJTKyLMKMamEJKSG4sav32ulUSe3uevzqY36/pHqwXMbmgeKCJsOgmgTnCz/rfUvSL 1IFZhgrK4XxYGqesVk/96o7RuXrFrrcoOtLn//tjno5WSfYmc9PfF4xP2eTWUg3S3jts q2ig== X-Gm-Message-State: AOJu0Yzl+Gc6IMR8oWFpxg/CNvZ1ry7ex6ctY0gNouFiTxaPwhm2KlZn RKnCWGeT1+iFJuvLp0MEKKP99MjRxLi+Ea+J3psHxnW2OcGZyWNfFpmKNqrPGsUidVOYRlVo1wa RCoI= X-Gm-Gg: ASbGncsDI2M55xc+tVMP9J3Ma/44YY0kyDkiyfd4kF5O58au7SnQVra0DYHuwL7LvAv NR5oUeFkQAXD1SBgWKmki7dhA9xiBNvf8vsLgOO8cclvkSBFk96g9p0xHXyBAs57A7aNbpnx4pb 44MXehVsa3OImRoqZP2v7Jhu2iRM900QlL5q9zcVVzyh1PwrWzUwJZlLr4mUz/OOHR7HaM9SCCb 9o5V//nozsrmS2cGKiUPCfdiCahFoRgUdfUifps4ZkpdW+Wm3DcF5M6v7p0QxJ5y+ACLn+JUihD rw8jTBjYpqAmhA== X-Google-Smtp-Source: AGHT+IEUjN3gs/vgcSyV3xa8eYF+tOlngAqw3C6M762kb/hbi1cU/0PcGo2jLZC7dcyMer/PguHNxg== X-Received: by 2002:a05:600c:5811:b0:436:488f:4f3 with SMTP id 5b1f17b1804b1-43924991efamr149129625e9.17.1739275732441; Tue, 11 Feb 2025 04:08:52 -0800 (PST) Received: from brgl-uxlite.home ([2a01:cb1d:dc:7e00:561:8978:1d41:636a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4393b66f3e3sm86966375e9.19.2025.02.11.04.08.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2025 04:08:52 -0800 (PST) From: Bartosz Golaszewski To: Linus Walleij Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH 2/2] gpio: latch: store the address of pdev->dev in a helper variable Date: Tue, 11 Feb 2025 13:08:47 +0100 Message-ID: <20250211120847.42437-2-brgl@bgdev.pl> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250211120847.42437-1-brgl@bgdev.pl> References: <20250211120847.42437-1-brgl@bgdev.pl> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Bartosz Golaszewski Make the code a bit more readable by using a helper variable to store the address of pdev->dev in probe(). Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-latch.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpio/gpio-latch.c b/drivers/gpio/gpio-latch.c index 722eb5b045f5..46cdfb08747a 100644 --- a/drivers/gpio/gpio-latch.c +++ b/drivers/gpio/gpio-latch.c @@ -143,22 +143,22 @@ static int gpio_latch_probe(struct platform_device *pdev) struct gpio_latch_priv *priv; unsigned int n_latches; - priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); if (!priv) return -ENOMEM; - priv->clk_gpios = devm_gpiod_get_array(&pdev->dev, "clk", GPIOD_OUT_LOW); + priv->clk_gpios = devm_gpiod_get_array(dev, "clk", GPIOD_OUT_LOW); if (IS_ERR(priv->clk_gpios)) return PTR_ERR(priv->clk_gpios); - priv->latched_gpios = devm_gpiod_get_array(&pdev->dev, "latched", GPIOD_OUT_LOW); + priv->latched_gpios = devm_gpiod_get_array(dev, "latched", GPIOD_OUT_LOW); if (IS_ERR(priv->latched_gpios)) return PTR_ERR(priv->latched_gpios); n_latches = priv->clk_gpios->ndescs; priv->n_latched_gpios = priv->latched_gpios->ndescs; - priv->shadow = devm_bitmap_zalloc(&pdev->dev, n_latches * priv->n_latched_gpios, + priv->shadow = devm_bitmap_zalloc(dev, n_latches * priv->n_latched_gpios, GFP_KERNEL); if (!priv->shadow) return -ENOMEM; @@ -176,7 +176,7 @@ static int gpio_latch_probe(struct platform_device *pdev) device_property_read_u32(dev, "setup-duration-ns", &priv->setup_duration_ns); if (priv->setup_duration_ns > DURATION_NS_MAX) { - dev_warn(&pdev->dev, "setup-duration-ns too high, limit to %d\n", + dev_warn(dev, "setup-duration-ns too high, limit to %d\n", DURATION_NS_MAX); priv->setup_duration_ns = DURATION_NS_MAX; } @@ -184,7 +184,7 @@ static int gpio_latch_probe(struct platform_device *pdev) device_property_read_u32(dev, "clock-duration-ns", &priv->clock_duration_ns); if (priv->clock_duration_ns > DURATION_NS_MAX) { - dev_warn(&pdev->dev, "clock-duration-ns too high, limit to %d\n", + dev_warn(dev, "clock-duration-ns too high, limit to %d\n", DURATION_NS_MAX); priv->clock_duration_ns = DURATION_NS_MAX; } @@ -193,11 +193,11 @@ static int gpio_latch_probe(struct platform_device *pdev) priv->gc.ngpio = n_latches * priv->n_latched_gpios; priv->gc.owner = THIS_MODULE; priv->gc.base = -1; - priv->gc.parent = &pdev->dev; + priv->gc.parent = dev; platform_set_drvdata(pdev, priv); - return devm_gpiochip_add_data(&pdev->dev, &priv->gc, priv); + return devm_gpiochip_add_data(dev, &priv->gc, priv); } static const struct of_device_id gpio_latch_ids[] = {