From patchwork Wed Feb 12 20:01:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 864551 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5477E1FFC7D for ; Wed, 12 Feb 2025 20:01:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739390514; cv=none; b=fR6I+HfwfymrCvMXlp+zIj5iwYus8W/ooYIY18R4Wi13f8KzV8mEpV6mVER6esEdy3rDu+sQdEQabac+xnsu8dKYuDnoSHuFILwVNGhDztHJUp/nHTZa/jR5Bz4zC62nGlSKsUpM7pYpK4zhtaL5flVwP8we7+GSOekHqSRnpf0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739390514; c=relaxed/simple; bh=y5h75cbURq+QFYroNTwHW0qeM75W82wRrh1mTp5vUw0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DUix872ApEjZeWyhq+RudvEkhPI+r0I/25TvOH0DVS7NHsfgS9hEQv4Aj54dMq+Fray2B/WjduSgo/97f6uYWHk/F5K2mmBdY8KZTiNW8BL+tTpe2KhLZodbBu1hqiWgJfA8pn9wU9DxmoUgXlrwFARMhp3KWSKlYnC+sxLFbas= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=OYSggrqc; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OYSggrqc" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-5de427a1d12so10559a12.1 for ; Wed, 12 Feb 2025 12:01:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739390510; x=1739995310; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=og53lkxft6Cw9SOu+fSVtcrVp1LfxilP6rODB9GjWWo=; b=OYSggrqcVKSyzsUVSCrrzU+nQUakqMu2NY1MG+UPc0SH02r9ZKz7o/2SrADGCuA6sq QAJOU9sVyklexJHaaWKPNo1eRkmDqsl1GIbo+TaKx0QWaZal0sGIiAsY1Dwn5EVkjPhY 6e/0N1A8nMbksjIL3T4Bv3ZyGfQkOIsN3LDOzeGw/AWxWm90f3xNBEoGmqvkZtU+rXLg LpWmLRnMQZitLam4E+9Jd4lzmQ9dxyQy89OPuWB4oCF7gZGJHSPv5Z9aW2Jx8w1yOvea +y56Ph45s+iBbya3f1OWGHxYJCnkL9c8/01xO5FhAGooYRw21XQhI1wGVB32ZKfja28s 6gqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739390510; x=1739995310; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=og53lkxft6Cw9SOu+fSVtcrVp1LfxilP6rODB9GjWWo=; b=nnIAwTBqE6A+ZwE1wnvZt+2TLQa2YBGCfNr7x0pQkI/QSqZE2EHEeYOd669PZOpg7x 9rT/dNJZcv+DR1tyhg4FuBXNPczMhq7Ak8rxNA2gJvIqCXGRGJyFIKtKtqJm8Zr+MZJN fKzrlGxbvvQjpEcZWM3Q4OoQd5i75ZAbmLeeXESC4z4MicfKnsBRO80lPKOFtQIQfJnI 0rKvrpcG58QYqvARXESBFN+uurhd026zdZukFn9inqnTwVYuF9yzBsdut7j6tHzGBvNC nQogzmzNpI+iRwvWtiiRB1cP8+Fl76NkOZ+obnqh+6Lnou3lFFTC/MWMCpNAJpg3lnkp SNDg== X-Gm-Message-State: AOJu0YyJnvSdlhSYa9fxXI8quG95VsM9ashRapa5LQY0VdrYOLOud7zp 0EqK9Fs98xQAfaXPqnUrTh/Q5E58B6+Cnc88Z6uxywzVgyIJqOkXwde95JEjxT2x7WR4NJpKXSJ M X-Gm-Gg: ASbGncv18q6m86KFrobvKa5Jqhh+hrKD/hJEpl+3/ipdwIDMPXpBQxC4OsZBrt1UI4K Ewcv+xuPL0VvM3Zpdjgk3/TOZ1DnL6b1Ysfue35DDhpXdECjPyvBktAeejtw5cBWZ4bfp3fOUF8 e0yXd6oMHixSdm0MNREjrenbSOiMkf9I640d35irfdMGsZCAiNTNUX3+tXZUZcUqdojEARK3mPE F4R6ZD7+iRtR5H4SG+j9jw1Wntb68SQm5eB39kGJ+itN/Jm2qMD4j3DhoHLWjt/yfQQvReZFvAi w09Is0/QHZD0J9mXNt/ViVP2Pfy63QQ= X-Google-Smtp-Source: AGHT+IHq9PhGjIrCokOrbT3WcuYrA7+Gcw6tdzPVbLWXUZAeFDUaP6P9fjZXwPJtK2GCEApPfUgigQ== X-Received: by 2002:a05:6402:5111:b0:5dc:58ad:b8c9 with SMTP id 4fb4d7f45d1cf-5deade126b9mr1672088a12.10.1739390510082; Wed, 12 Feb 2025 12:01:50 -0800 (PST) Received: from [127.0.1.1] ([178.197.218.144]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5deca41378fsm144527a12.74.2025.02.12.12.01.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2025 12:01:49 -0800 (PST) From: Krzysztof Kozlowski Date: Wed, 12 Feb 2025 21:01:35 +0100 Subject: [PATCH v3 1/3] clk: qcom: clk-alpha-pll: Do not use random stack value for recalc rate Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250212-b4-clk-qcom-clean-v3-1-499f37444f5d@linaro.org> References: <20250212-b4-clk-qcom-clean-v3-0-499f37444f5d@linaro.org> In-Reply-To: <20250212-b4-clk-qcom-clean-v3-0-499f37444f5d@linaro.org> To: Bjorn Andersson , Michael Turquette , Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=4980; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=y5h75cbURq+QFYroNTwHW0qeM75W82wRrh1mTp5vUw0=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBnrP4m+rYGhwatCfcI9FCaxPhhQYy19YjkXgf77 RE8KAMxgyCJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZ6z+JgAKCRDBN2bmhouD 1xEyD/9kvHXg4erJmX81rC0iPH6WNVUEuLd7kW/FB9nJUp68/qvzrtcrpTqZ3UgiD6DjB+oMXhT iHg1cynqHnHbKEaN3Twdn2+SFj0kku4Lr/oeSRRA5Ch/VszfU1fmah7Tm2N9nMOvUeFZ3dSLcpA vG+mkbPwHhbfH1e9hhMb4P2rbenrPorL82w9rX8N3H/CdOiI2Lc3YrnNKJJEpSt5R0GIjWvQFNS Kqr5MBs9EDOF8XsyKpfxUp3atyB/8GXaaYM3D4Brvxsdx5YhKmdNcETJAfpDIRqYqBLeRe//Omu G8ruE90Zmq7C3/8tpImDfyCIGoizesStNA8N5uMIcgN5BUDAL3tlmKqed/wKgHZdzJcRC2/Lai6 PcWZhQGNoPSwiheSqNe85ujFq4fCAPkAwwSPivMDZDuYEc9OHSuZOl8L6HGBsLoJaLUPyH5SfXK fek3JD5HgAgAYwm7PRO4945c/aTpZNn+spcsGFtJwtChCgN4lfpFHp+I7CX8OmQ+IkYMGKshoBN hPQkpBShw6dmsr0ruu4uTGzOkOWjmONX/d5LQIOqQdTBhcFadELT+NJbcMmFsjecw3uZtCP2QEF HfhZgG6Xd0IsdmIo3cOs56AdxidK5b14AR6xBUc16C+Rf0JVeZcUL9WL9bug6VmJCB/OfzrUdxO hYj+zPv7y49Ewxw== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B If regmap_read() fails, random stack value was used in calculating new frequency in recalc_rate() callbacks. Such failure is really not expected as these are all MMIO reads, however code should be here correct and bail out. This also avoids possible warning on uninitialized value. Signed-off-by: Krzysztof Kozlowski --- Changes in v2: 1. Three more regmap_read() failure checks (Stephen) --- drivers/clk/qcom/clk-alpha-pll.c | 52 +++++++++++++++++++++++++++------------- 1 file changed, 36 insertions(+), 16 deletions(-) diff --git a/drivers/clk/qcom/clk-alpha-pll.c b/drivers/clk/qcom/clk-alpha-pll.c index 9a65d14acf71c97912664be4f6f78891cab4afa3..cec0afea8e446010f0d4140d4ef63121706dde47 100644 --- a/drivers/clk/qcom/clk-alpha-pll.c +++ b/drivers/clk/qcom/clk-alpha-pll.c @@ -709,14 +709,19 @@ clk_alpha_pll_recalc_rate(struct clk_hw *hw, unsigned long parent_rate) struct clk_alpha_pll *pll = to_clk_alpha_pll(hw); u32 alpha_width = pll_alpha_width(pll); - regmap_read(pll->clkr.regmap, PLL_L_VAL(pll), &l); + if (regmap_read(pll->clkr.regmap, PLL_L_VAL(pll), &l)) + return 0; + + if (regmap_read(pll->clkr.regmap, PLL_USER_CTL(pll), &ctl)) + return 0; - regmap_read(pll->clkr.regmap, PLL_USER_CTL(pll), &ctl); if (ctl & PLL_ALPHA_EN) { - regmap_read(pll->clkr.regmap, PLL_ALPHA_VAL(pll), &low); + if (regmap_read(pll->clkr.regmap, PLL_ALPHA_VAL(pll), &low)) + return 0; if (alpha_width > 32) { - regmap_read(pll->clkr.regmap, PLL_ALPHA_VAL_U(pll), - &high); + if (regmap_read(pll->clkr.regmap, PLL_ALPHA_VAL_U(pll), + &high)) + return 0; a = (u64)high << 32 | low; } else { a = low & GENMASK(alpha_width - 1, 0); @@ -942,8 +947,11 @@ alpha_pll_huayra_recalc_rate(struct clk_hw *hw, unsigned long parent_rate) struct clk_alpha_pll *pll = to_clk_alpha_pll(hw); u32 l, alpha = 0, ctl, alpha_m, alpha_n; - regmap_read(pll->clkr.regmap, PLL_L_VAL(pll), &l); - regmap_read(pll->clkr.regmap, PLL_USER_CTL(pll), &ctl); + if (regmap_read(pll->clkr.regmap, PLL_L_VAL(pll), &l)) + return 0; + + if (regmap_read(pll->clkr.regmap, PLL_USER_CTL(pll), &ctl)) + return 0; if (ctl & PLL_ALPHA_EN) { regmap_read(pll->clkr.regmap, PLL_ALPHA_VAL(pll), &alpha); @@ -1137,8 +1145,11 @@ clk_trion_pll_recalc_rate(struct clk_hw *hw, unsigned long parent_rate) struct clk_alpha_pll *pll = to_clk_alpha_pll(hw); u32 l, frac, alpha_width = pll_alpha_width(pll); - regmap_read(pll->clkr.regmap, PLL_L_VAL(pll), &l); - regmap_read(pll->clkr.regmap, PLL_ALPHA_VAL(pll), &frac); + if (regmap_read(pll->clkr.regmap, PLL_L_VAL(pll), &l)) + return 0; + + if (regmap_read(pll->clkr.regmap, PLL_ALPHA_VAL(pll), &frac)) + return 0; return alpha_pll_calc_rate(parent_rate, l, frac, alpha_width); } @@ -1196,7 +1207,8 @@ clk_alpha_pll_postdiv_recalc_rate(struct clk_hw *hw, unsigned long parent_rate) struct clk_alpha_pll_postdiv *pll = to_clk_alpha_pll_postdiv(hw); u32 ctl; - regmap_read(pll->clkr.regmap, PLL_USER_CTL(pll), &ctl); + if (regmap_read(pll->clkr.regmap, PLL_USER_CTL(pll), &ctl)) + return 0; ctl >>= PLL_POST_DIV_SHIFT; ctl &= PLL_POST_DIV_MASK(pll); @@ -1412,8 +1424,11 @@ static unsigned long alpha_pll_fabia_recalc_rate(struct clk_hw *hw, struct clk_alpha_pll *pll = to_clk_alpha_pll(hw); u32 l, frac, alpha_width = pll_alpha_width(pll); - regmap_read(pll->clkr.regmap, PLL_L_VAL(pll), &l); - regmap_read(pll->clkr.regmap, PLL_FRAC(pll), &frac); + if (regmap_read(pll->clkr.regmap, PLL_L_VAL(pll), &l)) + return 0; + + if (regmap_read(pll->clkr.regmap, PLL_FRAC(pll), &frac)) + return 0; return alpha_pll_calc_rate(parent_rate, l, frac, alpha_width); } @@ -1563,7 +1578,8 @@ clk_trion_pll_postdiv_recalc_rate(struct clk_hw *hw, unsigned long parent_rate) struct regmap *regmap = pll->clkr.regmap; u32 i, div = 1, val; - regmap_read(regmap, PLL_USER_CTL(pll), &val); + if (regmap_read(regmap, PLL_USER_CTL(pll), &val)) + return 0; val >>= pll->post_div_shift; val &= PLL_POST_DIV_MASK(pll); @@ -2484,9 +2500,12 @@ static unsigned long alpha_pll_lucid_evo_recalc_rate(struct clk_hw *hw, struct regmap *regmap = pll->clkr.regmap; u32 l, frac; - regmap_read(regmap, PLL_L_VAL(pll), &l); + if (regmap_read(regmap, PLL_L_VAL(pll), &l)) + return 0; l &= LUCID_EVO_PLL_L_VAL_MASK; - regmap_read(regmap, PLL_ALPHA_VAL(pll), &frac); + + if (regmap_read(regmap, PLL_ALPHA_VAL(pll), &frac)) + return 0; return alpha_pll_calc_rate(parent_rate, l, frac, pll_alpha_width(pll)); } @@ -2699,7 +2718,8 @@ static unsigned long clk_rivian_evo_pll_recalc_rate(struct clk_hw *hw, struct clk_alpha_pll *pll = to_clk_alpha_pll(hw); u32 l; - regmap_read(pll->clkr.regmap, PLL_L_VAL(pll), &l); + if (regmap_read(pll->clkr.regmap, PLL_L_VAL(pll), &l)) + return 0; return parent_rate * l; } From patchwork Wed Feb 12 20:01:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 864550 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D51E200136 for ; Wed, 12 Feb 2025 20:01:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739390520; cv=none; b=PVCqZAXdUML2jOcjvlZWZC2UzCKEqeEcUsmjfqyBBu1SL1q46L0OKNEHC4ma5aAu1xZbmbCX8Zs3cWpSg5t69hHisr9HnZyeqTRNlmMRICCFEwY6Cb/cdk5RDWi9kAmiJoRWMSn3bDxsYOgSv5xyXS+HMTtmsmZH+MNpe1fDwBY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739390520; c=relaxed/simple; bh=09Zq1wvYiAPyMIJJUWJ+HB5emBm/KsHziF4Pi65X4WM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=AhGi7I8p4hqF6/aNBeFVPDYTB7lT+L2xjMrTrPiwqItKlyMNl9OJTP28PFtblVIbPlu5Oz8twgZclTccvUp7jEkwqhSaTUVCOmbKG61CbQTubZQqYpFs6qY8fG93JpOnAtmG//XLKsPN9LEg5cZIVokY+BSk+VVgQ0C8lMQ3eEY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=l9GeHGms; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="l9GeHGms" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-5debb4aef2eso5275a12.3 for ; Wed, 12 Feb 2025 12:01:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739390516; x=1739995316; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=doXaPbYwDYHThLE3/vOulSah/CgrJWiEDAqjt9r9dc0=; b=l9GeHGmsNrS36oD0eWRk+Wf9+HbPA5N6mzmHZaWbsVFRbOXn/3tTQ5oM7LDM3hRVsJ qPJ2NGF7u6G1iMbesLwewmh93oE0oRccLLd5+bRNiBRxtY2IQmriD7B4wqynJJuNj2pb WwZwuYkHW5GaPAIjV9j5ZDIt84JfT0oJNnhKZjQX9elDiSL6Tr/seup36Om+g9uUZVZq XwH38iBTSu9/zh/dDjaDhtG543bY8koDQPIpONqYtlt3pNbxseY1FrcCgdGyyfSdRKUw aNdJaPF9nY1MDTl65z0bURo1efRm2N/eTAZSiYj/jnb6h/MDZTOY5nGJ++EuvmcSAL8F XhPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739390516; x=1739995316; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=doXaPbYwDYHThLE3/vOulSah/CgrJWiEDAqjt9r9dc0=; b=HPSDJOxJwwqf2ATLzfCreRxCwLrXy27QE6T+UFreQAOqTbuekv9Iz3pvV+LGVxeWPB 9y4Aop0Y5CfQF48wpUEbaKE5iridjgiazRPp88H7BkmDzWjohM8RuP13TQp9WJufd5ig F+4MLVL7Jx8HJjT89s7eh4oL/EZ6AZdJbgw2FQU39wCU/bUHjuSFu2FiDinwSXstLwrl QOkjFgEBy15xef27CcWCnEcCs3zWZ5ylCWqt9kNob55rLxtHd92uITWpsvVt11klwQc3 CnC6u5Z9qySOe19hMu8+qq0Tfnhi4A2fr1UHYKge2d3kngWH6ibYkYM483WR0otP9yUl BQUA== X-Gm-Message-State: AOJu0YwpUAi0EJcZvlzzpxOxcbyf5e/6ine9JQf8kAl1Lf9AnpTg8Qxc NSseXQXuO00YJ6OnlczR5U7xScBilZ9tQUFQhYY9r0MWLWjZjuQemRf+qcHabZRsRHRoeh6QPpG f X-Gm-Gg: ASbGncsqNCp2wIY5EOAdeE/xCool8K/PkWuqQh6YK+pGUszxGH2rE9gryW4OXud6fHX 3UmTBedaBMEKUBNf7F7nnVgJHGKfLKTP260cYdQ6BfF/JEu4n9BmhvqS1AYOA4Ddr3Rzt2T+ShC 3Mkr13yCOv5yz6qe57sxrc/TDV9bfBJQOV0zObxYqvA4UEl14Mg9PTNSM36ct58z8YCEGNUuyoU pDTUmggPvh6b34SRvNmXhp7S3vDsaUyv8YpnJerL4bzaqcWp/g+BGzk290SVgqclp1d8SQzhzt5 9Rz1+TU4arOY9L7M3TwloI97GKaxggo= X-Google-Smtp-Source: AGHT+IGD6cCYj9qKz5WKaxsvW+XDTfA8mWTCtGfkaZXYzOiNHvAFMHZ0mZDrQn8XBY7irOL/j5+kLQ== X-Received: by 2002:a05:6402:278a:b0:5dc:7374:2613 with SMTP id 4fb4d7f45d1cf-5deadd75063mr1608045a12.1.1739390514763; Wed, 12 Feb 2025 12:01:54 -0800 (PST) Received: from [127.0.1.1] ([178.197.218.144]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5deca41378fsm144527a12.74.2025.02.12.12.01.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2025 12:01:53 -0800 (PST) From: Krzysztof Kozlowski Date: Wed, 12 Feb 2025 21:01:37 +0100 Subject: [PATCH v3 3/3] clk: qcom: Add missing header includes Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250212-b4-clk-qcom-clean-v3-3-499f37444f5d@linaro.org> References: <20250212-b4-clk-qcom-clean-v3-0-499f37444f5d@linaro.org> In-Reply-To: <20250212-b4-clk-qcom-clean-v3-0-499f37444f5d@linaro.org> To: Bjorn Andersson , Michael Turquette , Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Taniya Das , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=18880; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=09Zq1wvYiAPyMIJJUWJ+HB5emBm/KsHziF4Pi65X4WM=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBnrP4oyRv1w3czNbCi79AVCzuo6JG4C9dG8Dnnd I2FN5qiC6WJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZ6z+KAAKCRDBN2bmhouD 1+5zD/0fK4N5Gxw4q4GjehhsmHnlaXH7sYBGP1EKNwJv2oC1jhZXKIkAxA1x/SiCduR7c1guLGJ VIAMQMSBwneYUuCsxCGSQ7/Qe4PCKcp/V04OviGo9PSwWAGmm0T64x7VJFPKLPwT3jBzL3kPEsW 1BwLCspCNtUYVf3fHCkIr8IIaXBfsjXawW0XwXbxhOlDo9FQUU2biO7mhv+ebLi2As3MaabmsQv ONkwmFi6Gyk9fcVP5/HvwH4SRZ2KAqBEd8szZFUQ1Y82u4UZeCBVygPryEh6wUZTtqvHBDvNYa2 qFPq3wgQZCUxorcCALVM3seG6bm/Dkd4wtabx4A2xbSzJxHFLwK9Le0x2F93ToHS8h8hq0TSKo3 oHIOf+wTqRFDEHPWGUyftjRNl0kkgYe4otuHTRPvhUkeFPk82GndNco/ToA/Ph8musOWU/IeoHP GtPv8oMfRiFf7FOkO5XZp0eVPbjEQDrVxd25hFuYB+urgjZR0xBvRBZKXYumk7q++LJYunjb6ku cWRDWfreRuHMf6Lsgkwu9fyUl7lbxmspZaBJNoCJqY+OGLQLcwV/ach9H2Pb+WCXr4VfWQhIRU5 cq0JmkButOpvN7nhDi1XIOp5yNCwtM2Pm/zZbFxLe8BzC33UNS3V/DzM3N+z9mXb0XvcGisNoiq cTmRvrDeYEjge7Q== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Include mod_devicetable.h for the 'struct of_device_id' and clk-provider.h for the 'struct clk_hw'. Reviewed-by: Taniya Das Signed-off-by: Krzysztof Kozlowski --- Changes in v3: 1. Drop change to dispcc-sm4450.c Changes in v2: 1. Rename subject (Include->Add) 2. Rb tag --- drivers/clk/qcom/camcc-sc7180.c | 1 + drivers/clk/qcom/camcc-sc7280.c | 1 + drivers/clk/qcom/camcc-sdm845.c | 1 + drivers/clk/qcom/camcc-sm6350.c | 1 + drivers/clk/qcom/camcc-sm8150.c | 1 + drivers/clk/qcom/camcc-sm8250.c | 1 + drivers/clk/qcom/dispcc-qcm2290.c | 2 ++ drivers/clk/qcom/dispcc-sc7180.c | 1 + drivers/clk/qcom/dispcc-sc7280.c | 1 + drivers/clk/qcom/dispcc-sc8280xp.c | 1 + drivers/clk/qcom/dispcc-sdm845.c | 1 + drivers/clk/qcom/dispcc-sm6115.c | 2 ++ drivers/clk/qcom/dispcc-sm6125.c | 1 + drivers/clk/qcom/dispcc-sm6350.c | 1 + drivers/clk/qcom/dispcc-sm6375.c | 1 + drivers/clk/qcom/dispcc-sm8250.c | 1 + drivers/clk/qcom/dispcc-sm8450.c | 1 + drivers/clk/qcom/dispcc-sm8550.c | 1 + drivers/clk/qcom/gpucc-msm8998.c | 1 + drivers/clk/qcom/gpucc-sar2130p.c | 1 + drivers/clk/qcom/gpucc-sc7180.c | 1 + drivers/clk/qcom/gpucc-sc7280.c | 1 + drivers/clk/qcom/gpucc-sc8280xp.c | 1 + drivers/clk/qcom/gpucc-sdm660.c | 1 + drivers/clk/qcom/gpucc-sdm845.c | 1 + drivers/clk/qcom/gpucc-sm6350.c | 1 + drivers/clk/qcom/gpucc-sm8150.c | 1 + drivers/clk/qcom/gpucc-sm8250.c | 1 + drivers/clk/qcom/gpucc-sm8350.c | 1 + drivers/clk/qcom/mmcc-apq8084.c | 1 + drivers/clk/qcom/mmcc-msm8960.c | 1 + drivers/clk/qcom/mmcc-msm8974.c | 1 + drivers/clk/qcom/mmcc-msm8994.c | 1 + drivers/clk/qcom/mmcc-msm8996.c | 1 + drivers/clk/qcom/mmcc-msm8998.c | 1 + drivers/clk/qcom/mmcc-sdm660.c | 1 + 36 files changed, 38 insertions(+) diff --git a/drivers/clk/qcom/camcc-sc7180.c b/drivers/clk/qcom/camcc-sc7180.c index a69b70ab1a7090b15fc3378afc200f37a66baa4d..5031df813b4a7e40cc45641d27478429c08b69bc 100644 --- a/drivers/clk/qcom/camcc-sc7180.c +++ b/drivers/clk/qcom/camcc-sc7180.c @@ -5,6 +5,7 @@ #include #include +#include #include #include #include diff --git a/drivers/clk/qcom/camcc-sc7280.c b/drivers/clk/qcom/camcc-sc7280.c index 5a9992a5b5ba5d4aec533c5cd9ef5c9e549ee40f..55545f5fdb98c94eb0557a94db683d2108311f61 100644 --- a/drivers/clk/qcom/camcc-sc7280.c +++ b/drivers/clk/qcom/camcc-sc7280.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include diff --git a/drivers/clk/qcom/camcc-sdm845.c b/drivers/clk/qcom/camcc-sdm845.c index 40022a10f8c0b5392da2f7db90db38c2c7c8afe0..cf60e8dd292a93d0bbc4f77aef6dd90a6943f269 100644 --- a/drivers/clk/qcom/camcc-sdm845.c +++ b/drivers/clk/qcom/camcc-sdm845.c @@ -4,6 +4,7 @@ */ #include +#include #include #include #include diff --git a/drivers/clk/qcom/camcc-sm6350.c b/drivers/clk/qcom/camcc-sm6350.c index f6634cc8663ef63b372183063d78cc89f5321268..1871970fb046d7ad6f5b6bfcce9f8ae10b3f2e93 100644 --- a/drivers/clk/qcom/camcc-sm6350.c +++ b/drivers/clk/qcom/camcc-sm6350.c @@ -5,6 +5,7 @@ */ #include +#include #include #include #include diff --git a/drivers/clk/qcom/camcc-sm8150.c b/drivers/clk/qcom/camcc-sm8150.c index ed96dcb885b353b2f1b915116fa4b357de91ff0d..f105534cb318069d71590fbeb2d6aa181c621af3 100644 --- a/drivers/clk/qcom/camcc-sm8150.c +++ b/drivers/clk/qcom/camcc-sm8150.c @@ -6,6 +6,7 @@ #include #include #include +#include #include #include #include diff --git a/drivers/clk/qcom/camcc-sm8250.c b/drivers/clk/qcom/camcc-sm8250.c index dcbc6c354e5a0fcd36f289568eb35ee36bb1bb16..2b84b1a0ac9c4f5273d488f6fa0445613efba1c5 100644 --- a/drivers/clk/qcom/camcc-sm8250.c +++ b/drivers/clk/qcom/camcc-sm8250.c @@ -4,6 +4,7 @@ */ #include +#include #include #include #include diff --git a/drivers/clk/qcom/dispcc-qcm2290.c b/drivers/clk/qcom/dispcc-qcm2290.c index f72e9585b4fb22ecc227a50dfaf2d54117882c3d..6d88d067337fa132114b0d8666931b449f86de17 100644 --- a/drivers/clk/qcom/dispcc-qcm2290.c +++ b/drivers/clk/qcom/dispcc-qcm2290.c @@ -4,8 +4,10 @@ * Copyright (c) 2021, Linaro Ltd. */ +#include #include #include +#include #include #include #include diff --git a/drivers/clk/qcom/dispcc-sc7180.c b/drivers/clk/qcom/dispcc-sc7180.c index 4710247be5306945838d9858c1af3fed70b04b51..ab1a8d419863df28da852a7d3467f09fb5e9d8da 100644 --- a/drivers/clk/qcom/dispcc-sc7180.c +++ b/drivers/clk/qcom/dispcc-sc7180.c @@ -4,6 +4,7 @@ */ #include +#include #include #include #include diff --git a/drivers/clk/qcom/dispcc-sc7280.c b/drivers/clk/qcom/dispcc-sc7280.c index db0745954894d4de2e2f3de95fdfa5b864c67ac3..8bdf57734a3d47fdf8bd2053640d8ef462677556 100644 --- a/drivers/clk/qcom/dispcc-sc7280.c +++ b/drivers/clk/qcom/dispcc-sc7280.c @@ -4,6 +4,7 @@ */ #include +#include #include #include #include diff --git a/drivers/clk/qcom/dispcc-sc8280xp.c b/drivers/clk/qcom/dispcc-sc8280xp.c index 0a810fc847ce0d8b4f14e00a6983aa83c728f1dd..34fae823423a9035bdd39517ef7ac429140a43b5 100644 --- a/drivers/clk/qcom/dispcc-sc8280xp.c +++ b/drivers/clk/qcom/dispcc-sc8280xp.c @@ -5,6 +5,7 @@ */ #include +#include #include #include #include diff --git a/drivers/clk/qcom/dispcc-sdm845.c b/drivers/clk/qcom/dispcc-sdm845.c index 94079c54333fccc9b06cc9f82f4b9111b40f8c22..2f9e9665d7e93fa73e8478b055bd73bdd9f13be3 100644 --- a/drivers/clk/qcom/dispcc-sdm845.c +++ b/drivers/clk/qcom/dispcc-sdm845.c @@ -4,6 +4,7 @@ */ #include +#include #include #include #include diff --git a/drivers/clk/qcom/dispcc-sm6115.c b/drivers/clk/qcom/dispcc-sm6115.c index 89f14cfd92336e6c28ad3eeb2ae9ef4219eb0555..8ae25d51db9463b3fb6452ca5b99662b1050f777 100644 --- a/drivers/clk/qcom/dispcc-sm6115.c +++ b/drivers/clk/qcom/dispcc-sm6115.c @@ -5,8 +5,10 @@ * Copyright (c) 2021, Linaro Ltd. */ +#include #include #include +#include #include #include #include diff --git a/drivers/clk/qcom/dispcc-sm6125.c b/drivers/clk/qcom/dispcc-sm6125.c index 51c7492816fbd397de881e2f42fc6f55d5b25fe3..851d38a487d3c95c29e90547ff90ad6386e0bb89 100644 --- a/drivers/clk/qcom/dispcc-sm6125.c +++ b/drivers/clk/qcom/dispcc-sm6125.c @@ -4,6 +4,7 @@ */ #include +#include #include #include #include diff --git a/drivers/clk/qcom/dispcc-sm6350.c b/drivers/clk/qcom/dispcc-sm6350.c index 2bc6b5f99f5725bf56c63623c3d5c16c25879d9e..e703ecf00e440473156f707498f23cde53fb7e22 100644 --- a/drivers/clk/qcom/dispcc-sm6350.c +++ b/drivers/clk/qcom/dispcc-sm6350.c @@ -5,6 +5,7 @@ */ #include +#include #include #include #include diff --git a/drivers/clk/qcom/dispcc-sm6375.c b/drivers/clk/qcom/dispcc-sm6375.c index 167dd369a7943655a5524077884e89dd148ce829..ec9dbb1f4a7c984a1f8b286fe448d61169ac0bea 100644 --- a/drivers/clk/qcom/dispcc-sm6375.c +++ b/drivers/clk/qcom/dispcc-sm6375.c @@ -5,6 +5,7 @@ */ #include +#include #include #include #include diff --git a/drivers/clk/qcom/dispcc-sm8250.c b/drivers/clk/qcom/dispcc-sm8250.c index 1f48e79acfac31641a1cccef895139fea9336a47..8f433e1e702839daf62c0a65992bc89927cac266 100644 --- a/drivers/clk/qcom/dispcc-sm8250.c +++ b/drivers/clk/qcom/dispcc-sm8250.c @@ -4,6 +4,7 @@ */ #include +#include #include #include #include diff --git a/drivers/clk/qcom/dispcc-sm8450.c b/drivers/clk/qcom/dispcc-sm8450.c index 96987d8445cb09085b8017e7f18824a643e677bd..0b76cddbeb940bcae5f37f4a226a204a6c608f47 100644 --- a/drivers/clk/qcom/dispcc-sm8450.c +++ b/drivers/clk/qcom/dispcc-sm8450.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include diff --git a/drivers/clk/qcom/dispcc-sm8550.c b/drivers/clk/qcom/dispcc-sm8550.c index 4c5feb96ae53d94b34b671da34ad090b80a9b247..a373c92a10aaff78172bdb44cafda82f564ea19d 100644 --- a/drivers/clk/qcom/dispcc-sm8550.c +++ b/drivers/clk/qcom/dispcc-sm8550.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include diff --git a/drivers/clk/qcom/gpucc-msm8998.c b/drivers/clk/qcom/gpucc-msm8998.c index 066793e47f79f42dfdf9895bca33393455925ee3..7fce70503141bd91b1503e71a4972f188ae8c90c 100644 --- a/drivers/clk/qcom/gpucc-msm8998.c +++ b/drivers/clk/qcom/gpucc-msm8998.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include diff --git a/drivers/clk/qcom/gpucc-sar2130p.c b/drivers/clk/qcom/gpucc-sar2130p.c index dd72b2a48c42da1e14fb1e87a7dcd5f17b1a43ad..c2903179ac85db72f2b927623e437a12c9985679 100644 --- a/drivers/clk/qcom/gpucc-sar2130p.c +++ b/drivers/clk/qcom/gpucc-sar2130p.c @@ -6,6 +6,7 @@ #include #include +#include #include #include #include diff --git a/drivers/clk/qcom/gpucc-sc7180.c b/drivers/clk/qcom/gpucc-sc7180.c index 08f3983d016f3f24b1e613de7d7391a8fe428c61..a7bf44544b956db3dd476869177ba9858401e7ac 100644 --- a/drivers/clk/qcom/gpucc-sc7180.c +++ b/drivers/clk/qcom/gpucc-sc7180.c @@ -4,6 +4,7 @@ */ #include +#include #include #include #include diff --git a/drivers/clk/qcom/gpucc-sc7280.c b/drivers/clk/qcom/gpucc-sc7280.c index bd699a624517846a289fa62ed8639579a0bd59e3..f81289fa719df42e659e681254d05c7093d11468 100644 --- a/drivers/clk/qcom/gpucc-sc7280.c +++ b/drivers/clk/qcom/gpucc-sc7280.c @@ -5,6 +5,7 @@ */ #include +#include #include #include #include diff --git a/drivers/clk/qcom/gpucc-sc8280xp.c b/drivers/clk/qcom/gpucc-sc8280xp.c index c96be61e3f479e1a8098e29a95e2a09f510dc258..913e17f101967036bf1dde7a3282c0155ae285c7 100644 --- a/drivers/clk/qcom/gpucc-sc8280xp.c +++ b/drivers/clk/qcom/gpucc-sc8280xp.c @@ -5,6 +5,7 @@ #include #include +#include #include #include #include diff --git a/drivers/clk/qcom/gpucc-sdm660.c b/drivers/clk/qcom/gpucc-sdm660.c index 6d37b3d8d1a40dfebbfa8ab89bf0459f041994a1..28db307b6717cc666a006c5d3ceb70c30f281f0e 100644 --- a/drivers/clk/qcom/gpucc-sdm660.c +++ b/drivers/clk/qcom/gpucc-sdm660.c @@ -9,6 +9,7 @@ #include #include #include +#include #include #include #include diff --git a/drivers/clk/qcom/gpucc-sdm845.c b/drivers/clk/qcom/gpucc-sdm845.c index ef26690cf504237f41acfd2ddea498b7e0eda5d3..0d63b110a1fb21a9026805c4245df6a440d4090e 100644 --- a/drivers/clk/qcom/gpucc-sdm845.c +++ b/drivers/clk/qcom/gpucc-sdm845.c @@ -4,6 +4,7 @@ */ #include +#include #include #include #include diff --git a/drivers/clk/qcom/gpucc-sm6350.c b/drivers/clk/qcom/gpucc-sm6350.c index 1e12ad8948dbd8ecc7cad421ebe77dd047ff928f..35ed0500bc59319f9659aef81031b34d29fc06a4 100644 --- a/drivers/clk/qcom/gpucc-sm6350.c +++ b/drivers/clk/qcom/gpucc-sm6350.c @@ -5,6 +5,7 @@ */ #include +#include #include #include #include diff --git a/drivers/clk/qcom/gpucc-sm8150.c b/drivers/clk/qcom/gpucc-sm8150.c index d711464a71b6d8ddb5e0a86d6dbe3c7035577b7f..7ce91208c0bc0fb0009e0974d7d45378d8df8427 100644 --- a/drivers/clk/qcom/gpucc-sm8150.c +++ b/drivers/clk/qcom/gpucc-sm8150.c @@ -4,6 +4,7 @@ */ #include +#include #include #include #include diff --git a/drivers/clk/qcom/gpucc-sm8250.c b/drivers/clk/qcom/gpucc-sm8250.c index 113b486a6d2fbfdf9bd2a6e3ba7c9b8999284eb3..ca0a1681d352c41bf2dc4ef7746ad7e5ec1626e2 100644 --- a/drivers/clk/qcom/gpucc-sm8250.c +++ b/drivers/clk/qcom/gpucc-sm8250.c @@ -4,6 +4,7 @@ */ #include +#include #include #include #include diff --git a/drivers/clk/qcom/gpucc-sm8350.c b/drivers/clk/qcom/gpucc-sm8350.c index 6d2660bdd82549806e1eb0d8fb64b1b2523e67d9..4025dab0a1ca9a37fa79f705e3be5e0e554737bb 100644 --- a/drivers/clk/qcom/gpucc-sm8350.c +++ b/drivers/clk/qcom/gpucc-sm8350.c @@ -8,6 +8,7 @@ #include #include #include +#include #include #include #include diff --git a/drivers/clk/qcom/mmcc-apq8084.c b/drivers/clk/qcom/mmcc-apq8084.c index 3affa525b875c3b313711a32f6d45133a09a6813..2d334977d783253e75d989f1623c5a3ea4444b97 100644 --- a/drivers/clk/qcom/mmcc-apq8084.c +++ b/drivers/clk/qcom/mmcc-apq8084.c @@ -6,6 +6,7 @@ #include #include #include +#include #include #include diff --git a/drivers/clk/qcom/mmcc-msm8960.c b/drivers/clk/qcom/mmcc-msm8960.c index a23440e13b71d67c4cc4c5efa3f7b5c927cd110d..cd3c9f8455e5e00bea2c2f163db41a1a6059e153 100644 --- a/drivers/clk/qcom/mmcc-msm8960.c +++ b/drivers/clk/qcom/mmcc-msm8960.c @@ -8,6 +8,7 @@ #include #include #include +#include #include #include #include diff --git a/drivers/clk/qcom/mmcc-msm8974.c b/drivers/clk/qcom/mmcc-msm8974.c index f2e802cf6afc558672f70f407d7538fde2a555fa..12bbc49c87aff41d18b93e4ff326f59526a7a5e1 100644 --- a/drivers/clk/qcom/mmcc-msm8974.c +++ b/drivers/clk/qcom/mmcc-msm8974.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include diff --git a/drivers/clk/qcom/mmcc-msm8994.c b/drivers/clk/qcom/mmcc-msm8994.c index 0a273630e852c978558d13a36ed4d8b3a4d339cb..7c0b959a4aa2075b6cd6ddf3fc2b62ebc488d0d5 100644 --- a/drivers/clk/qcom/mmcc-msm8994.c +++ b/drivers/clk/qcom/mmcc-msm8994.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include diff --git a/drivers/clk/qcom/mmcc-msm8996.c b/drivers/clk/qcom/mmcc-msm8996.c index 3426e3dde92478d6853e724fb2f555d1a1e31bdc..7d67c6f73fe138e37189a7459ff784a8fc0b8a7a 100644 --- a/drivers/clk/qcom/mmcc-msm8996.c +++ b/drivers/clk/qcom/mmcc-msm8996.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include diff --git a/drivers/clk/qcom/mmcc-msm8998.c b/drivers/clk/qcom/mmcc-msm8998.c index 5c37be700fa77985d0806587e80ac465956c5762..e2f198213b215d0bdd9bd463b7228ca13a966e5d 100644 --- a/drivers/clk/qcom/mmcc-msm8998.c +++ b/drivers/clk/qcom/mmcc-msm8998.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include diff --git a/drivers/clk/qcom/mmcc-sdm660.c b/drivers/clk/qcom/mmcc-sdm660.c index b3beeabe39ed1d9c66508dacfad904aa379b9a2d..e5bdcc75a36ed24a8c72d1fd6ee57083a7f5c499 100644 --- a/drivers/clk/qcom/mmcc-sdm660.c +++ b/drivers/clk/qcom/mmcc-sdm660.c @@ -9,6 +9,7 @@ #include #include #include +#include #include #include #include