From patchwork Wed Feb 12 06:25:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raag Jadav X-Patchwork-Id: 864671 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D06411FE454; Wed, 12 Feb 2025 06:25:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.17 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739341530; cv=none; b=DRyA3O962g4CS5mpzY+/e5DLMxcxeLfK8RFvJBY/SWSsAwZeEJoPVmJmFdyDXQGq6cjZY1s33ONEaoJtjYxpjMI5ZC57KXf07bF/DiYn7CQQ01wGEyuCfelaRvKScN2iLdPOu4ydlanQex6QItI2zJLiXrPPVsxuj+L0kbPoAI4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739341530; c=relaxed/simple; bh=FQ7bnBP/fmmMDiRo4TG+IeTx3Bz8M7QVDYt2sFVtmsY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=VmSWgiRZwexrCXhAy3mpryuNTzu4kgnClkEJ/jcVfmcY58i8xKfen2Dihjk0GIOZJ2tRfHFaaL58379jkCR321xuzpAL+xRHYPTocM5DrRS0xi/FMiH0ZlFmUJBI7bi1CEX+Tl2wdysYu9uN1nVQyDNW4/CP6PXCPWc3EI+4OPs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=KZaliRq1; arc=none smtp.client-ip=198.175.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="KZaliRq1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1739341529; x=1770877529; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=FQ7bnBP/fmmMDiRo4TG+IeTx3Bz8M7QVDYt2sFVtmsY=; b=KZaliRq1F0OkMcdbWqWhFz3qdE6yboJonMZDny9+cfKpHVISFtfjylJb li76UDNfgc5vGku5Xvh9smeKVqpW6T7ODNbt3Con5Cp63VM1zHS8FzNcS OPH/+WJDBQDqCj0dsNIbqWMOIy+eXbGfXPANTYoE3PKJSr2oey0dP2utm wvqnd4udr8saY4IWZvt3GU4Y69q6OVzH3SHPma2mJWVVFEq2uEx5SkXuS 37Zw34PA4TqcA9U+Jop9f/B7kZ1JCbcdDE/wDQarHES6CTye0SvulGdo+ NI1+SaCZpd/KxWHtCc2n9VklCycvh8fMlLq0TxK9mF0HGxLF4Y+Nj4O9w A==; X-CSE-ConnectionGUID: /PCV2F+xSCSaasal3ULC2A== X-CSE-MsgGUID: RG/mhJGbRX+fNN57NgEqPQ== X-IronPort-AV: E=McAfee;i="6700,10204,11342"; a="40005160" X-IronPort-AV: E=Sophos;i="6.13,279,1732608000"; d="scan'208";a="40005160" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2025 22:25:28 -0800 X-CSE-ConnectionGUID: GbnBNGxiT7i2MvcZsd1j/g== X-CSE-MsgGUID: paC+ABeIR5u1RRDxqvdV7A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,279,1732608000"; d="scan'208";a="117811973" Received: from jraag-z790m-itx-wifi.iind.intel.com ([10.190.239.23]) by fmviesa004.fm.intel.com with ESMTP; 11 Feb 2025 22:25:24 -0800 From: Raag Jadav To: arnd@arndb.de, gregkh@linuxfoundation.org, rafael@kernel.org, linus.walleij@linaro.org, mika.westerberg@linux.intel.com, andriy.shevchenko@linux.intel.com, dmitry.torokhov@gmail.com, jic23@kernel.org, przemyslaw.kitszel@intel.com Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-iio@vger.kernel.org, Raag Jadav Subject: [PATCH v5 02/12] driver core: Split devres APIs to device/devres.h Date: Wed, 12 Feb 2025 11:55:03 +0530 Message-Id: <20250212062513.2254767-3-raag.jadav@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250212062513.2254767-1-raag.jadav@intel.com> References: <20250212062513.2254767-1-raag.jadav@intel.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Andy Shevchenko device.h is a huge header which is hard to follow and easy to miss something. Improve that by splitting devres APIs to device/devres.h. In particular this helps to speedup the build of the code that includes device.h solely for a devres APIs. While at it, cast the error pointers to __iomem using IOMEM_ERR_PTR() and fix sparse warnings. Signed-off-by: Andy Shevchenko Signed-off-by: Raag Jadav --- include/linux/device.h | 119 +------------------------------- include/linux/device/devres.h | 124 ++++++++++++++++++++++++++++++++++ 2 files changed, 125 insertions(+), 118 deletions(-) create mode 100644 include/linux/device/devres.h diff --git a/include/linux/device.h b/include/linux/device.h index 80a5b3268986..78ca7fd0e625 100644 --- a/include/linux/device.h +++ b/include/linux/device.h @@ -26,9 +26,9 @@ #include #include #include -#include #include #include +#include #include #include #include @@ -281,123 +281,6 @@ int __must_check device_create_bin_file(struct device *dev, void device_remove_bin_file(struct device *dev, const struct bin_attribute *attr); -/* device resource management */ -typedef void (*dr_release_t)(struct device *dev, void *res); -typedef int (*dr_match_t)(struct device *dev, void *res, void *match_data); - -void *__devres_alloc_node(dr_release_t release, size_t size, gfp_t gfp, - int nid, const char *name) __malloc; -#define devres_alloc(release, size, gfp) \ - __devres_alloc_node(release, size, gfp, NUMA_NO_NODE, #release) -#define devres_alloc_node(release, size, gfp, nid) \ - __devres_alloc_node(release, size, gfp, nid, #release) - -void devres_for_each_res(struct device *dev, dr_release_t release, - dr_match_t match, void *match_data, - void (*fn)(struct device *, void *, void *), - void *data); -void devres_free(void *res); -void devres_add(struct device *dev, void *res); -void *devres_find(struct device *dev, dr_release_t release, - dr_match_t match, void *match_data); -void *devres_get(struct device *dev, void *new_res, - dr_match_t match, void *match_data); -void *devres_remove(struct device *dev, dr_release_t release, - dr_match_t match, void *match_data); -int devres_destroy(struct device *dev, dr_release_t release, - dr_match_t match, void *match_data); -int devres_release(struct device *dev, dr_release_t release, - dr_match_t match, void *match_data); - -/* devres group */ -void * __must_check devres_open_group(struct device *dev, void *id, gfp_t gfp); -void devres_close_group(struct device *dev, void *id); -void devres_remove_group(struct device *dev, void *id); -int devres_release_group(struct device *dev, void *id); - -/* managed devm_k.alloc/kfree for device drivers */ -void *devm_kmalloc(struct device *dev, size_t size, gfp_t gfp) __alloc_size(2); -void *devm_krealloc(struct device *dev, void *ptr, size_t size, - gfp_t gfp) __must_check __realloc_size(3); -__printf(3, 0) char *devm_kvasprintf(struct device *dev, gfp_t gfp, - const char *fmt, va_list ap) __malloc; -__printf(3, 4) char *devm_kasprintf(struct device *dev, gfp_t gfp, - const char *fmt, ...) __malloc; -static inline void *devm_kzalloc(struct device *dev, size_t size, gfp_t gfp) -{ - return devm_kmalloc(dev, size, gfp | __GFP_ZERO); -} -static inline void *devm_kmalloc_array(struct device *dev, - size_t n, size_t size, gfp_t flags) -{ - size_t bytes; - - if (unlikely(check_mul_overflow(n, size, &bytes))) - return NULL; - - return devm_kmalloc(dev, bytes, flags); -} -static inline void *devm_kcalloc(struct device *dev, - size_t n, size_t size, gfp_t flags) -{ - return devm_kmalloc_array(dev, n, size, flags | __GFP_ZERO); -} -static inline __realloc_size(3, 4) void * __must_check -devm_krealloc_array(struct device *dev, void *p, size_t new_n, size_t new_size, gfp_t flags) -{ - size_t bytes; - - if (unlikely(check_mul_overflow(new_n, new_size, &bytes))) - return NULL; - - return devm_krealloc(dev, p, bytes, flags); -} - -void devm_kfree(struct device *dev, const void *p); -char *devm_kstrdup(struct device *dev, const char *s, gfp_t gfp) __malloc; -const char *devm_kstrdup_const(struct device *dev, const char *s, gfp_t gfp); -void *devm_kmemdup(struct device *dev, const void *src, size_t len, gfp_t gfp) - __realloc_size(3); - -unsigned long devm_get_free_pages(struct device *dev, - gfp_t gfp_mask, unsigned int order); -void devm_free_pages(struct device *dev, unsigned long addr); - -#ifdef CONFIG_HAS_IOMEM -void __iomem *devm_ioremap_resource(struct device *dev, - const struct resource *res); -void __iomem *devm_ioremap_resource_wc(struct device *dev, - const struct resource *res); - -void __iomem *devm_of_iomap(struct device *dev, - struct device_node *node, int index, - resource_size_t *size); -#else - -static inline -void __iomem *devm_ioremap_resource(struct device *dev, - const struct resource *res) -{ - return ERR_PTR(-EINVAL); -} - -static inline -void __iomem *devm_ioremap_resource_wc(struct device *dev, - const struct resource *res) -{ - return ERR_PTR(-EINVAL); -} - -static inline -void __iomem *devm_of_iomap(struct device *dev, - struct device_node *node, int index, - resource_size_t *size) -{ - return ERR_PTR(-EINVAL); -} - -#endif - /* allows to add/remove a custom action to devres stack */ int devm_remove_action_nowarn(struct device *dev, void (*action)(void *), void *data); diff --git a/include/linux/device/devres.h b/include/linux/device/devres.h new file mode 100644 index 000000000000..6b0b265058bc --- /dev/null +++ b/include/linux/device/devres.h @@ -0,0 +1,124 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _DEVICE_DEVRES_H_ +#define _DEVICE_DEVRES_H_ + +#include +#include +#include +#include +#include +#include + +struct device; +struct device_node; +struct resource; + +/* device resource management */ +typedef void (*dr_release_t)(struct device *dev, void *res); +typedef int (*dr_match_t)(struct device *dev, void *res, void *match_data); + +void * __malloc +__devres_alloc_node(dr_release_t release, size_t size, gfp_t gfp, int nid, const char *name); +#define devres_alloc(release, size, gfp) \ + __devres_alloc_node(release, size, gfp, NUMA_NO_NODE, #release) +#define devres_alloc_node(release, size, gfp, nid) \ + __devres_alloc_node(release, size, gfp, nid, #release) + +void devres_for_each_res(struct device *dev, dr_release_t release, + dr_match_t match, void *match_data, + void (*fn)(struct device *, void *, void *), + void *data); +void devres_free(void *res); +void devres_add(struct device *dev, void *res); +void *devres_find(struct device *dev, dr_release_t release, dr_match_t match, void *match_data); +void *devres_get(struct device *dev, void *new_res, dr_match_t match, void *match_data); +void *devres_remove(struct device *dev, dr_release_t release, dr_match_t match, void *match_data); +int devres_destroy(struct device *dev, dr_release_t release, dr_match_t match, void *match_data); +int devres_release(struct device *dev, dr_release_t release, dr_match_t match, void *match_data); + +/* devres group */ +void * __must_check devres_open_group(struct device *dev, void *id, gfp_t gfp); +void devres_close_group(struct device *dev, void *id); +void devres_remove_group(struct device *dev, void *id); +int devres_release_group(struct device *dev, void *id); + +/* managed devm_k.alloc/kfree for device drivers */ +void * __alloc_size(2) +devm_kmalloc(struct device *dev, size_t size, gfp_t gfp); +void * __must_check __realloc_size(3) +devm_krealloc(struct device *dev, void *ptr, size_t size, gfp_t gfp); +static inline void *devm_kzalloc(struct device *dev, size_t size, gfp_t gfp) +{ + return devm_kmalloc(dev, size, gfp | __GFP_ZERO); +} +static inline void *devm_kmalloc_array(struct device *dev, size_t n, size_t size, gfp_t flags) +{ + size_t bytes; + + if (unlikely(check_mul_overflow(n, size, &bytes))) + return NULL; + + return devm_kmalloc(dev, bytes, flags); +} +static inline void *devm_kcalloc(struct device *dev, size_t n, size_t size, gfp_t flags) +{ + return devm_kmalloc_array(dev, n, size, flags | __GFP_ZERO); +} +static inline __realloc_size(3, 4) void * __must_check +devm_krealloc_array(struct device *dev, void *p, size_t new_n, size_t new_size, gfp_t flags) +{ + size_t bytes; + + if (unlikely(check_mul_overflow(new_n, new_size, &bytes))) + return NULL; + + return devm_krealloc(dev, p, bytes, flags); +} + +void devm_kfree(struct device *dev, const void *p); + +void * __realloc_size(3) +devm_kmemdup(struct device *dev, const void *src, size_t len, gfp_t gfp); + +char * __malloc +devm_kstrdup(struct device *dev, const char *s, gfp_t gfp); +const char *devm_kstrdup_const(struct device *dev, const char *s, gfp_t gfp); +char * __printf(3, 0) __malloc +devm_kvasprintf(struct device *dev, gfp_t gfp, const char *fmt, va_list ap); +char * __printf(3, 4) __malloc +devm_kasprintf(struct device *dev, gfp_t gfp, const char *fmt, ...); + +unsigned long devm_get_free_pages(struct device *dev, gfp_t gfp_mask, unsigned int order); +void devm_free_pages(struct device *dev, unsigned long addr); + +#ifdef CONFIG_HAS_IOMEM + +void __iomem *devm_ioremap_resource(struct device *dev, const struct resource *res); +void __iomem *devm_ioremap_resource_wc(struct device *dev, const struct resource *res); + +void __iomem *devm_of_iomap(struct device *dev, struct device_node *node, int index, + resource_size_t *size); +#else + +static inline +void __iomem *devm_ioremap_resource(struct device *dev, const struct resource *res) +{ + return IOMEM_ERR_PTR(-EINVAL); +} + +static inline +void __iomem *devm_ioremap_resource_wc(struct device *dev, const struct resource *res) +{ + return IOMEM_ERR_PTR(-EINVAL); +} + +static inline +void __iomem *devm_of_iomap(struct device *dev, struct device_node *node, int index, + resource_size_t *size) +{ + return IOMEM_ERR_PTR(-EINVAL); +} + +#endif + +#endif /* _DEVICE_DEVRES_H_ */ From patchwork Wed Feb 12 06:25:05 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raag Jadav X-Patchwork-Id: 864670 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C375A1FF60D; Wed, 12 Feb 2025 06:25:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.17 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739341538; cv=none; b=LB3afkzJ/biK4C4dDuQHEv81eG+EryV/GUhXxinigvCeItWhSCQfgi6pFgYjarseBMGv0c8AQe8YrtaKFee8V0BcPW/xa/yNpMx/32kMiFMNTntqkQ5n+9357U0hLg/XL3w4HMU32Rt/wBQS71fE7LXGZFuNk/8pwNDKVZmqk9s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739341538; c=relaxed/simple; bh=kXNsZ5OEPvESAT2ItADgSvaxbJWn0Bu43326BOmRHII=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=lmanCDMZ+OWSVWsVaGkgW5IdObTNFY5rRoFPUs0P+r6ZnYyAmEG5DeSjBACy3dNHV26cAFiiffKqepdZQriAbNWlvtAIqbv19LgPszIqN6eeEiCUmCH93mBCHX67PeJv6YXmseSUZszN/eDcUh7d72LO/fpqmjgmEgwrH42YiFQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=dXihWwJn; arc=none smtp.client-ip=198.175.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="dXihWwJn" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1739341537; x=1770877537; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=kXNsZ5OEPvESAT2ItADgSvaxbJWn0Bu43326BOmRHII=; b=dXihWwJngw/glPIcVlkOxtWVhFuevQdPcP2VhOCPVbBuji7l6BvDDHX8 YKAhQSVILYHeXXMy2p3Ke6DGzlhUg/58GVU8TryzCGSUtei6Fbea6WXgT bkJWr9rf+hiCMT3GDiyFcDC2p4Upu2zt09gRj7j1UYkXAVVMEgzT4L1vQ 8No0FDui4B9t4fP95CtBX04/k9wb6HllBcwmhqn56ilkBouXPEf12+vPB U3AXBX4j63d+qDxXkcrAX1i8ZTEKFXfIokMUOQ8y8LRbVpS7qQSwSKlzg K0XC+7NW5Q5YFywxr30Ugehp/5faZGXt9/0UtNa5F4kG+S1SHUdLGLaO+ w==; X-CSE-ConnectionGUID: TQk14WMKQ8O1GMea+zIsPw== X-CSE-MsgGUID: L7V9n618S8OnR3jmjkpKXg== X-IronPort-AV: E=McAfee;i="6700,10204,11342"; a="40005178" X-IronPort-AV: E=Sophos;i="6.13,279,1732608000"; d="scan'208";a="40005178" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2025 22:25:36 -0800 X-CSE-ConnectionGUID: CgIPukCaRF660G0wvOHD4A== X-CSE-MsgGUID: jINXPxBMRFuMHSguzkYokQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,279,1732608000"; d="scan'208";a="117812005" Received: from jraag-z790m-itx-wifi.iind.intel.com ([10.190.239.23]) by fmviesa004.fm.intel.com with ESMTP; 11 Feb 2025 22:25:33 -0800 From: Raag Jadav To: arnd@arndb.de, gregkh@linuxfoundation.org, rafael@kernel.org, linus.walleij@linaro.org, mika.westerberg@linux.intel.com, andriy.shevchenko@linux.intel.com, dmitry.torokhov@gmail.com, jic23@kernel.org, przemyslaw.kitszel@intel.com Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-iio@vger.kernel.org, Raag Jadav Subject: [PATCH v5 04/12] devres: Introduce devm_kmemdup_array() Date: Wed, 12 Feb 2025 11:55:05 +0530 Message-Id: <20250212062513.2254767-5-raag.jadav@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250212062513.2254767-1-raag.jadav@intel.com> References: <20250212062513.2254767-1-raag.jadav@intel.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Introduce '_array' variant of devm_kmemdup() which is more robust and consistent with alloc family of helpers. Suggested-by: Andy Shevchenko Signed-off-by: Raag Jadav Reviewed-by: Dmitry Torokhov Reviewed-by: Linus Walleij --- include/linux/device/devres.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/include/linux/device/devres.h b/include/linux/device/devres.h index 6b0b265058bc..9b49f9915850 100644 --- a/include/linux/device/devres.h +++ b/include/linux/device/devres.h @@ -79,6 +79,11 @@ void devm_kfree(struct device *dev, const void *p); void * __realloc_size(3) devm_kmemdup(struct device *dev, const void *src, size_t len, gfp_t gfp); +static inline void *devm_kmemdup_array(struct device *dev, const void *src, + size_t n, size_t size, gfp_t flags) +{ + return devm_kmemdup(dev, src, size_mul(size, n), flags); +} char * __malloc devm_kstrdup(struct device *dev, const char *s, gfp_t gfp); From patchwork Wed Feb 12 06:25:07 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raag Jadav X-Patchwork-Id: 864669 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 584151FFC73; Wed, 12 Feb 2025 06:25:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.17 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739341545; cv=none; b=nEzMyPuMrfUp7Qs275wC6jFlGkl6WxlflaFVTouz4Pczn/+Hu8wTvNf1hOmnFTuqoBZuVSqM12/MvrX9DqtGuh/ecrJ0YPALWVc2VbZabcHzUWlymhXMwoQK17jvbb5oVwExZRKrPK3Wm8MUsSrbiN60wZJ9XELZeIafoJ/P0xU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739341545; c=relaxed/simple; bh=NZrOpoIR0kcwzhW5RiAR7w3SpFSD3n21/pIeM0wBqjI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=LQKjIrZNeBtkZ/ogc2HL5HO9HEpCY1l2QxsfZGbwVSwmoQvNZz2X3U8kO7LaA9zO9QWvWbym22myQrPaKlINQSVb6zXxCRzxxZRT0L3ZI1ZRyZ0MsY9AGOyxz56L7OlzbiPU1rXPlZLTSUVNbEy0bqKGPmcJgxzWYp86bm/24As= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=K0TOYOOJ; arc=none smtp.client-ip=198.175.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="K0TOYOOJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1739341544; x=1770877544; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=NZrOpoIR0kcwzhW5RiAR7w3SpFSD3n21/pIeM0wBqjI=; b=K0TOYOOJDXnvZXe3Z+Alkm9u+vRefFAovI26/MAZmg0l+VfGCyjhpfQi 3HWxTq/5UHmllJCRqntTr+UOfzUmYw2LKbauS0Q90vzRgfPHe4Piu2gnr ncILELdqjdWGyyqmNXyoCmEdvql3oGQH7vj6b/9Eb/gJYXwQ7XtU8edz1 M5aL0uHtKbAj5gKoUJUIveO4SDQ0jScxYN+ZiZAelUtX9X2yc072uWpel UW9/Lla+hfhcuOx4Y9AhCnaB4bQ2spejpRrEsvTNs4cDtSlKGD26DhYCD wBhubbd2cWEKYG3+r63MVmcD42LXi3Zrpl3P59OeSjU5sDtox9YCrQIst w==; X-CSE-ConnectionGUID: R/MPFpaVS2+HNS7n18M3KA== X-CSE-MsgGUID: iK65QunjSnWi+rjgOS45Ug== X-IronPort-AV: E=McAfee;i="6700,10204,11342"; a="40005199" X-IronPort-AV: E=Sophos;i="6.13,279,1732608000"; d="scan'208";a="40005199" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2025 22:25:44 -0800 X-CSE-ConnectionGUID: 8SEEhFUSRb+fduAoTX1iWg== X-CSE-MsgGUID: VyvogbmVTvWDq4sHoTfZeg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,279,1732608000"; d="scan'208";a="117812058" Received: from jraag-z790m-itx-wifi.iind.intel.com ([10.190.239.23]) by fmviesa004.fm.intel.com with ESMTP; 11 Feb 2025 22:25:40 -0800 From: Raag Jadav To: arnd@arndb.de, gregkh@linuxfoundation.org, rafael@kernel.org, linus.walleij@linaro.org, mika.westerberg@linux.intel.com, andriy.shevchenko@linux.intel.com, dmitry.torokhov@gmail.com, jic23@kernel.org, przemyslaw.kitszel@intel.com Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-iio@vger.kernel.org, Raag Jadav Subject: [PATCH v5 06/12] pinctrl: baytrail: copy communities using devm_kmemdup_array() Date: Wed, 12 Feb 2025 11:55:07 +0530 Message-Id: <20250212062513.2254767-7-raag.jadav@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250212062513.2254767-1-raag.jadav@intel.com> References: <20250212062513.2254767-1-raag.jadav@intel.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Copy communities using devm_kmemdup_array() instead of doing it manually. Signed-off-by: Raag Jadav Reviewed-by: Linus Walleij --- drivers/pinctrl/intel/pinctrl-baytrail.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c index c4458ac539ff..969137c4cb06 100644 --- a/drivers/pinctrl/intel/pinctrl-baytrail.c +++ b/drivers/pinctrl/intel/pinctrl-baytrail.c @@ -1560,16 +1560,14 @@ static int byt_set_soc_data(struct intel_pinctrl *vg, vg->soc = soc; vg->ncommunities = vg->soc->ncommunities; - vg->communities = devm_kcalloc(vg->dev, vg->ncommunities, - sizeof(*vg->communities), GFP_KERNEL); + vg->communities = devm_kmemdup_array(vg->dev, vg->soc->communities, vg->ncommunities, + sizeof(*vg->soc->communities), GFP_KERNEL); if (!vg->communities) return -ENOMEM; for (i = 0; i < vg->soc->ncommunities; i++) { struct intel_community *comm = vg->communities + i; - *comm = vg->soc->communities[i]; - comm->pad_regs = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(comm->pad_regs)) return PTR_ERR(comm->pad_regs); From patchwork Wed Feb 12 06:25:09 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raag Jadav X-Patchwork-Id: 864668 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38C00200BBF; Wed, 12 Feb 2025 06:25:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.17 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739341553; cv=none; b=lJbUNL5OYYedWgsOuSThtGj335+tMLn0XKEM0iKZDbqchUTAciRxA8xVb6/uqqUIoHzOaA6+Nx4Yi0rOi3mqni1SvRvfHUqZFdnKu6SesadzTbqLgpK5b0fHBqzyJyPUZ87iUC0ih6lSf8KOIMuuAsQp8E0FGMrlehvzI/mjDmI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739341553; c=relaxed/simple; bh=i0Vg6izha13aWDeJ5vn8MBrolGY/TSxc4KHdVaVAYEk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ryVtv4NqVQBWmkIEbdY8aBWmC2qjKiqQBcYGQrDPgMbAgtgaSw+aG54U+WgLoX9izMeXpn6/PopSubkW/YJYne9hccCYFlt7g3w74g710s7A20wPn+9pVGS3CS3A8XmqGO87sItrmBvjNuGO8rDJphRwd9tCPkuuTkfKSpM8oa0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=nv6K+ER5; arc=none smtp.client-ip=198.175.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="nv6K+ER5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1739341552; x=1770877552; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=i0Vg6izha13aWDeJ5vn8MBrolGY/TSxc4KHdVaVAYEk=; b=nv6K+ER5jVqmUxcGgHMoCUOkfW4mj3NLQt2ePSSE/XjjvtLt5cOREBtf HrLIn/T4jjG/NZLdrm/WtLMToUHZ+zP6tNqLDyabxEOlfFWWMO8AwMJHf DdsoWEOl1l/EgVeMwbBqLGponiQA0izWhrIRXklxzCnwGTK1Ss3Wjda1D Gluoammpo9V7oC80MmIloD7TI5oDfwxO+YFX9FWjHXZGifAsoXwPhAfAv oz+cJEsKFCR+a+2GBWuQQftignuKKfynoehrtptcG29ChyKeWBOabgcV2 pc+RffTz5lctZ5Fcqj4GYPqXioudQVHTKEp+qX1eaN/tpIK/7jfADFAtx g==; X-CSE-ConnectionGUID: KTc3C//gTnmUdLOE2rP2Sw== X-CSE-MsgGUID: zzZc1hGGT/CGa0sBA3KWwQ== X-IronPort-AV: E=McAfee;i="6700,10204,11342"; a="40005216" X-IronPort-AV: E=Sophos;i="6.13,279,1732608000"; d="scan'208";a="40005216" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2025 22:25:52 -0800 X-CSE-ConnectionGUID: YPih9FbhRCaYYZF/gbSASw== X-CSE-MsgGUID: 0qhcn4GSSPemJrY0a07AkQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,279,1732608000"; d="scan'208";a="117812115" Received: from jraag-z790m-itx-wifi.iind.intel.com ([10.190.239.23]) by fmviesa004.fm.intel.com with ESMTP; 11 Feb 2025 22:25:48 -0800 From: Raag Jadav To: arnd@arndb.de, gregkh@linuxfoundation.org, rafael@kernel.org, linus.walleij@linaro.org, mika.westerberg@linux.intel.com, andriy.shevchenko@linux.intel.com, dmitry.torokhov@gmail.com, jic23@kernel.org, przemyslaw.kitszel@intel.com Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-iio@vger.kernel.org, Raag Jadav Subject: [PATCH v5 08/12] pinctrl: tangier: use devm_kmemdup_array() Date: Wed, 12 Feb 2025 11:55:09 +0530 Message-Id: <20250212062513.2254767-9-raag.jadav@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250212062513.2254767-1-raag.jadav@intel.com> References: <20250212062513.2254767-1-raag.jadav@intel.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Convert to use devm_kmemdup_array() and while at it, use source size instead of destination. Signed-off-by: Raag Jadav Reviewed-by: Andy Shevchenko Reviewed-by: Linus Walleij --- drivers/pinctrl/intel/pinctrl-tangier.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/intel/pinctrl-tangier.c b/drivers/pinctrl/intel/pinctrl-tangier.c index d3baf0f4eea0..ac61e632b487 100644 --- a/drivers/pinctrl/intel/pinctrl-tangier.c +++ b/drivers/pinctrl/intel/pinctrl-tangier.c @@ -524,7 +524,6 @@ static int tng_pinctrl_probe(struct platform_device *pdev, struct device *dev = &pdev->dev; struct tng_family *families; struct tng_pinctrl *tp; - size_t families_len; void __iomem *regs; unsigned int i; @@ -543,8 +542,8 @@ static int tng_pinctrl_probe(struct platform_device *pdev, * Make a copy of the families which we can use to hold pointers * to the registers. */ - families_len = size_mul(sizeof(*families), tp->nfamilies); - families = devm_kmemdup(dev, tp->families, families_len, GFP_KERNEL); + families = devm_kmemdup_array(dev, tp->families, tp->nfamilies, + sizeof(*tp->families), GFP_KERNEL); if (!families) return -ENOMEM; From patchwork Wed Feb 12 06:25:11 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raag Jadav X-Patchwork-Id: 864667 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9D072010EE; Wed, 12 Feb 2025 06:25:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.17 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739341561; cv=none; b=VGtimHbEu4+dCcFARQHST3qcr9krG8vVcMbuCbXiPReA6FtNPU/ky2qNyHHHgDvT6uCaBP38/fxdQG299pal6ZMqkXL9nzeq7vGWjnnoSIgdnIO9KP4FKh9f3cuFSFvcPSez+Chl2fzI+cgxu+TBkMm84Tp3EGQ/T93XwMdE/aw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739341561; c=relaxed/simple; bh=0GTAFR5PURoBnt701bKnn8CM0d1hlX0pwGmk2rGeaZg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=W4nOWjxM/U5oiopf7+Ve2dq12prKy2OHJRCS2DWHhmFe/oXAR/CnfBxcifSLgoGCl8TKGOEww0xtt1dybM9SYR5qrpdzldIoSE6wwFtY8nYPmKwQ0zby/HtTPDE98zEAl9SegA4WvmfRBCs3/90Iwp/1ecolVYWjKG13az14bu0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=XEuxkF0t; arc=none smtp.client-ip=198.175.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="XEuxkF0t" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1739341560; x=1770877560; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=0GTAFR5PURoBnt701bKnn8CM0d1hlX0pwGmk2rGeaZg=; b=XEuxkF0tJ3BeTfh2/TpACNHJguwiag/OKkH/rZ72VaImRPvrJQkLveyo hLwtJLwe1Ks5SKqgzqBGzCy82nrkxYIzRegxFN/pagpdF6qWg3xtn6C2k E1REKdOIrEhLgCDE/gQZYZGVemrcSTF33HgJvJZKKPo9k151LhySQDBvf V1mKlE/SDvW0z5/dSEnBuibzBY6qJMXkGAlwpTeGFiylIaH/xxHN/3G3E Q9pJRwxoYrSJMOAUkFRV5/K2s5L6F0bqIV3JBBs112pqzIki62bkSdUIw yLDMq3JT/N37+BA+O2X4jagVf00Mm+r3Mjv8e1Y15r/hbfTh8xJzWurIv w==; X-CSE-ConnectionGUID: 8xvDM8nqQjuxIdbXNB+3hA== X-CSE-MsgGUID: 0ByB8SvzTSiAsaRZlXPWWQ== X-IronPort-AV: E=McAfee;i="6700,10204,11342"; a="40005234" X-IronPort-AV: E=Sophos;i="6.13,279,1732608000"; d="scan'208";a="40005234" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2025 22:25:59 -0800 X-CSE-ConnectionGUID: a019WMu3RvKU23p17WdAfg== X-CSE-MsgGUID: QFK+jYDNRyWtfv15W7bfQg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,279,1732608000"; d="scan'208";a="117812178" Received: from jraag-z790m-itx-wifi.iind.intel.com ([10.190.239.23]) by fmviesa004.fm.intel.com with ESMTP; 11 Feb 2025 22:25:56 -0800 From: Raag Jadav To: arnd@arndb.de, gregkh@linuxfoundation.org, rafael@kernel.org, linus.walleij@linaro.org, mika.westerberg@linux.intel.com, andriy.shevchenko@linux.intel.com, dmitry.torokhov@gmail.com, jic23@kernel.org, przemyslaw.kitszel@intel.com Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-iio@vger.kernel.org, Raag Jadav Subject: [PATCH v5 10/12] iio: adc: xilinx-xadc-core: use devm_kmemdup_array() Date: Wed, 12 Feb 2025 11:55:11 +0530 Message-Id: <20250212062513.2254767-11-raag.jadav@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250212062513.2254767-1-raag.jadav@intel.com> References: <20250212062513.2254767-1-raag.jadav@intel.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Convert to use devm_kmemdup_array() and while at it, use source size instead of destination. Signed-off-by: Raag Jadav --- drivers/iio/adc/xilinx-xadc-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c index cfbfcaefec0f..e1f8740ae688 100644 --- a/drivers/iio/adc/xilinx-xadc-core.c +++ b/drivers/iio/adc/xilinx-xadc-core.c @@ -1245,8 +1245,8 @@ static int xadc_parse_dt(struct iio_dev *indio_dev, unsigned int *conf, int irq) channel_templates = xadc_us_channels; max_channels = ARRAY_SIZE(xadc_us_channels); } - channels = devm_kmemdup(dev, channel_templates, - sizeof(channels[0]) * max_channels, GFP_KERNEL); + channels = devm_kmemdup_array(dev, channel_templates, max_channels, + sizeof(*channel_templates), GFP_KERNEL); if (!channels) return -ENOMEM; From patchwork Wed Feb 12 06:25:13 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raag Jadav X-Patchwork-Id: 864666 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB0B11FECA5; Wed, 12 Feb 2025 06:26:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.17 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739341569; cv=none; b=WVjWEqEtgxkkzetC3H0C1eHUqvDsgAZxYLYez7NXvFZzOE6idv9pCgFlW9hR8dUDrP4QjkE4mlQe20bh2LzeaeBYxZAG+CVtGDYRNA4GwJFgfxdxUUzDmR6w096UpMc8BdWOQmgZpJrbJs5Etp294JtMqnehNgQ1arUGs5fNJnQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739341569; c=relaxed/simple; bh=tKd11dX8so6573A0u2H006iFssbu+bQR5O6pj8pFlEg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=heh0/jHwjpd/xya0FLqCCQJJ7XyhjDd7hN39CS/SCG0bHNoagHE8a41kWPEqxLBSaDIFOJATaZparH89sxW6ZS+wZMRaeVqs1hJjnLy3isx9nafyB67gti2wDEHib6f67p/tsMnB1VbqO0/E96VkOVRQamSsTlLgYon0K7aUoFk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=W88bWC5J; arc=none smtp.client-ip=198.175.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="W88bWC5J" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1739341568; x=1770877568; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=tKd11dX8so6573A0u2H006iFssbu+bQR5O6pj8pFlEg=; b=W88bWC5JkSl8VoVgMwOp5b6XKKJsnrTgXA+C43D/o7jJxkazNB/1qnYL ejwiFXoX+AiiVMP9+uO2rC2ypognyK4ux5Ynj+GlhZZp/5X4cJllCP00K UsvKbSAk5oTQEALVnkErJWvTSQ6e9XdW8zlk2jmXR41dFCN/lXMtD/gw2 vnLfL0LdqL+yhcANLy6guxOQ0y5D1S3dPh6LujiYUx+HwD5Lji2nQ3zh1 axN1Ayjwe0QetpXFcQEXxHl4xiUGczOtcMc854e1H/0c+vR4EECsS9g/d NseKjPhDaFABfBot3Q7CSVe6WMWfe437ypcSo0hrZs1VGd6k933wyzM6z g==; X-CSE-ConnectionGUID: 2O4CXHSZS9u6vAAIbfAyKw== X-CSE-MsgGUID: ArXUJoUpTmOLIfJEeSfOkA== X-IronPort-AV: E=McAfee;i="6700,10204,11342"; a="40005252" X-IronPort-AV: E=Sophos;i="6.13,279,1732608000"; d="scan'208";a="40005252" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2025 22:26:07 -0800 X-CSE-ConnectionGUID: 8ds+cfntTI+MByDkEBXUiw== X-CSE-MsgGUID: R4/vkoXzSPaZDNne193kjA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,279,1732608000"; d="scan'208";a="117812235" Received: from jraag-z790m-itx-wifi.iind.intel.com ([10.190.239.23]) by fmviesa004.fm.intel.com with ESMTP; 11 Feb 2025 22:26:04 -0800 From: Raag Jadav To: arnd@arndb.de, gregkh@linuxfoundation.org, rafael@kernel.org, linus.walleij@linaro.org, mika.westerberg@linux.intel.com, andriy.shevchenko@linux.intel.com, dmitry.torokhov@gmail.com, jic23@kernel.org, przemyslaw.kitszel@intel.com Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-iio@vger.kernel.org, Raag Jadav Subject: [PATCH v5 12/12] input: ipaq-micro-keys: use devm_kmemdup_array() Date: Wed, 12 Feb 2025 11:55:13 +0530 Message-Id: <20250212062513.2254767-13-raag.jadav@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250212062513.2254767-1-raag.jadav@intel.com> References: <20250212062513.2254767-1-raag.jadav@intel.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Convert to use devm_kmemdup_array() which is more robust. Signed-off-by: Raag Jadav Reviewed-by: Linus Walleij --- drivers/input/keyboard/ipaq-micro-keys.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/input/keyboard/ipaq-micro-keys.c b/drivers/input/keyboard/ipaq-micro-keys.c index 58631bf7ce55..ca7ec054b1ce 100644 --- a/drivers/input/keyboard/ipaq-micro-keys.c +++ b/drivers/input/keyboard/ipaq-micro-keys.c @@ -102,9 +102,8 @@ static int micro_key_probe(struct platform_device *pdev) keys->input->keycodesize = sizeof(micro_keycodes[0]); keys->input->keycodemax = ARRAY_SIZE(micro_keycodes); - keys->codes = devm_kmemdup(&pdev->dev, micro_keycodes, - keys->input->keycodesize * keys->input->keycodemax, - GFP_KERNEL); + keys->codes = devm_kmemdup_array(&pdev->dev, micro_keycodes, keys->input->keycodemax, + keys->input->keycodesize, GFP_KERNEL); if (!keys->codes) return -ENOMEM;