From patchwork Mon Feb 17 04:43:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Aditya Garg X-Patchwork-Id: 866288 Received: from MA0PR01CU012.outbound.protection.outlook.com (mail-southindiaazolkn19011028.outbound.protection.outlook.com [52.103.67.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 959CE15C0; Mon, 17 Feb 2025 04:44:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.103.67.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739767444; cv=fail; b=hgO7/oesYpfRjTVQo0cDC1cVTEe5LA9ChLk/SNlB7vHMy+IvuXVe0gwjRa6OcHGlTHWqrjvYmMmZfWC6jjKI/Y6h2Mr68ybUJZZYej9oGyKBDvXb4SpLCEmNKYst0INxg/kv3B7VJWYStxGvLTsQG1AZzyEPs3bvfoWsqS/0wGE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739767444; c=relaxed/simple; bh=YHlhb1ZKOY3KaiRMpdTotOYDHecZ8op+Sb3TGH9ji6Y=; h=From:To:CC:Subject:Date:Message-ID:Content-Type:MIME-Version; b=FC003lOQo1nAhvTB28XIp7UMztbISrNB/nRVA4gqYL556KyRf55i6NgplDhXL5zWLv4lzIGCRD2M9BDuPevVqZw9C9RM7MAQdW4LScsRV0uFU88iPAXtIO/a0vjZ4ptDn2eqbMv+CUIJwuNYRQN5mkWSYzi76kxcAqKroswjJhQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=live.com; spf=pass smtp.mailfrom=live.com; dkim=pass (2048-bit key) header.d=live.com header.i=@live.com header.b=YBWvVC+0; arc=fail smtp.client-ip=52.103.67.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=live.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=live.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=live.com header.i=@live.com header.b="YBWvVC+0" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=c20cgKNluBuoYnY2St0KiQMaJDa3OgPLVQW5YKXyt9Chvtwt9EcK2b3dhFlwHuSruQFDa6vcfvTcxSeoJ3Ij5mlfp+44dxI8JC2jcVpSR51y1rqkM1PBEX+ZIaeC4UgGSXLe1irfIERQwyrN5FfkFl3vVvmb6lb8yz/IqBXlUEUOKfpYHvPKMqVc4VF+anGinaHvY3fh7EVV8TxVeaVk8S4MNUepP0PcvSGwv/TKJrWV3p01PTWVYVf5nMRWGrZmtMz4Rnxdhbby/7KqxAgu5/LS4uZOJTG/NeTvtRzbMyp0ux7DTEPyJSWHoVccW5zilt2Rj875aVm7L8EhdQRWzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YHlhb1ZKOY3KaiRMpdTotOYDHecZ8op+Sb3TGH9ji6Y=; b=Gx0G75trn/AhCw90T/L6cjPvuTDD9cohI9dBs75/doq346Gm+H4vr05tIQCkI5yZi+VxCpZp2TLfEEYP6w4jVqv2//sq5cZPpft4UYg3HtTfctBVowgZZCjRGyoTXpPR7DXtxHolROcmuEm7qRjYSxUjkiLwjsVAwrlY7GxItGwE7TabxaC07c3jloBwmgGK1tz6VepC74G/umSyqAH4QFXCOEdkj7aHskyFZJC6LIXMWCy80HQWIUZHtLzOBVWWSEyQfJLCMCxcq96QlEeGBE8ZJ7oIUdQUyazRdBIjMF56Vhp8CO0WPGrI0Ca79TNjHcl9DSUouO+feeyh15ojpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YHlhb1ZKOY3KaiRMpdTotOYDHecZ8op+Sb3TGH9ji6Y=; b=YBWvVC+0bJpUb/zT2wstI4NUTHO6zY+nctIzBuMJrmq8mlnpCV5ZXqxCy6rChfSngnqu60V7An0NFrJOzrtgfAtHttFpIM5VgwC8fotRR7ZrHLS3pN4VfSTKHZ3EhpitEZltqeGKq7rjowVO9fpCblCiCRQ81fEP77/zjLIRpf9y9MrQ5OPx507ndHnIzjZR4wWII7JG4sjk9mbSQvndPrw6kWrdzdhBWDJmCpMi7Ve/lL87APVpaA4Lzj2YC/RyMWAfiuObUzUJWmnzRWVHd0XT753PMzNyJaia1SvMKmT4gW6ckIl3KHIHZM7gQiOukmjZFuif3VKWiQIL/+pAQg== Received: from PN0PR01MB9608.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:110::10) by PN3PR01MB7015.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:ab::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8445.19; Mon, 17 Feb 2025 04:43:57 +0000 Received: from PN0PR01MB9608.INDPRD01.PROD.OUTLOOK.COM ([fe80::972:abe8:752:bbde]) by PN0PR01MB9608.INDPRD01.PROD.OUTLOOK.COM ([fe80::972:abe8:752:bbde%6]) with mapi id 15.20.8445.017; Mon, 17 Feb 2025 04:43:57 +0000 From: Aditya Garg To: Jiri Kosina , "jkosina@suse.com" , Benjamin Tissoires , "bentiss@kernel.org" , Dan Carpenter CC: Orlando Chamberlain , Kerem Karabay , "linux-input@vger.kernel.org" , Linux Kernel Mailing List Subject: [PATCH v4 1/3] HID: hid-appletb-kbd: simplify logic used to switch between media and function keys on pressing fn key Thread-Topic: [PATCH v4 1/3] HID: hid-appletb-kbd: simplify logic used to switch between media and function keys on pressing fn key Thread-Index: AQHbgPaN5rsIxIjWmES8Fil+QZv1mA== Date: Mon, 17 Feb 2025 04:43:56 +0000 Message-ID: <8365C1B3-3A38-4F6E-955B-D6BBABA6B00A@live.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PN0PR01MB9608:EE_|PN3PR01MB7015:EE_ x-ms-office365-filtering-correlation-id: 1429c17c-8fff-40c4-bc5f-08dd4f0db07a x-microsoft-antispam: BCL:0; ARA:14566002|8062599003|19110799003|7092599003|8060799006|461199028|15080799006|440099028|3412199025|102099032; x-microsoft-antispam-message-info: =?utf-8?q?oBIrwHSG0Ak2TIPTH0tAk/Pz6cDKrsF?= =?utf-8?q?G0Y9TJBz/ocTNSJbFCr5Xe4Ud43z8/Qh3JDQyXgXs9MIb+w/QqvcVGr3wK+O5Et4V?= =?utf-8?q?QdDMaoeKhvjpytccT2gYogeP3bOht7EIT7wkL5ppRHMVQZPLww+hmj+dvfEPJ1Sh6?= =?utf-8?q?mRYaPYtW3BCOyN6ZW3Uuja1BgOd9pVKoX1rS57Z555VrGY2dTawwl4Oc4J2JHeui2?= =?utf-8?q?pfPhgpA0PtIZnnZRF9FgbCjUjZu21OmKnVlg9RktUxR+hEJ5RnNyQQkncpHNO/Svg?= =?utf-8?q?nbxUf/sYHsgHSlXyY36zOWKT/Fu1vDJtIk1a+No/39Qahe3d5r+DkiV690GW/Q+ti?= =?utf-8?q?8PWUqyAo1eoVKzFfvZuBDK/Hy4MaDseZcBIX8rffTqmzDb7qLP8uCbOYK9ndkE/+/?= =?utf-8?q?/jK01pA8fdVHiWf655hpfzSOvn2z7mDCzaWzl+83R/jekKOAOx4Zn8qBbV9BGPtno?= =?utf-8?q?leeeOC60XS5bKCdMnd8LePImA3DxEOUERionaYPYh6J5sec1QxX0eK8nfquEaaa4n?= =?utf-8?q?Fb5mbQIUpVR8KXoUvgv6noKvxNSnqxBy2KcBTuN65ZqFMhRcR+Tyw172+F8OuJAti?= =?utf-8?q?3baBgRjAzcHNVs3Lh1goJkWvt5HyterHnUIYxm4sR82olBPWj6h1e3QPhLtEa5IOA?= =?utf-8?q?Eom0vmBk0dT8AnUVWvrJ/w7CrF4l9rka+myE4ZZ0lyPgUunpKZ1v6EZ6oZwIZrAp0?= =?utf-8?q?nKjjvhqlj2YNXohSfXngMyZYeJVMBL3S5fFT2pIV6cR3naJUUt0gGowicZiaqar/J?= =?utf-8?q?Oz/QOvdhKjhBYLavY66SGxuiqf6y2GyfugsYyUn6oYaV6JjRkRVN5qfaU+AZSNtT1?= =?utf-8?q?FDMcT0GosYhOryDKkU2ehY16t5kdSHPIdZoFXy40APgJwYSavi0Xxcs3Na83VpmYz?= =?utf-8?q?hwrerMlDFyM//DWyN0tjYZbEyoHPIaCxst325P7k6eQymkpbn2L0nCot3HJUrBTsK?= =?utf-8?q?yvvqV0vMvfl5v1FvmGZ3TFziRE68iKaGEqOT2d4XUxAVjBbSfzjyIKit+FgOETj5v?= =?utf-8?q?t81/z8SM3pWVk1eqnGG5k77x5tr8PNW8BT6c9xQ=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?q?81grrDGdrbYGDTYWp3tmfMm4bO1E?= =?utf-8?q?mIgTax6lDrTkaT5Ag5mlpfbFOTJY1mIXD6s3XrzHv0BZhOuIbjMvb11QzEEIQM1FO?= =?utf-8?q?1Wud+9inJjh+uzhMfVLvvsuSs3G5yZn53Owrjjch8D2Dtn70L+l4dxKorJCjVvPov?= =?utf-8?q?RBBH4YRm8VgxSgPmCmgPRm3mcR3if3MQq+Bk1YWJvkC9F8IPA76F/RauQjXWeg3uc?= =?utf-8?q?c3WUVn/5pPKoBAusHs8KQxIr/sDNuosffe9IvlDTu6MhDuVByQ+e8EDeozs6so3pm?= =?utf-8?q?xeJLNBJDGq+Cb6sB1pGrmRsvoLaqN8UiIrNO6CbwXOezsR+OJOvJqyn6ER8n9Numo?= =?utf-8?q?Q/ZNa97rXnX7tShXaEQyLCLCQkDAQpZM4Q7gS0twrG1Ndz/cp5i+ysaJoo7hQgi3/?= =?utf-8?q?RWgIjCaD4Os4FcioDWFebl7+h/W1uMDTYToji56ej8Kd4DSYSjLJA4YIggcQuKcdP?= =?utf-8?q?aTn4iQFJSXz1us1ZZfxhrZ6ry1ee9CMRCV3WR01mN4ZAE0PRPq06YnzP4zSZhFvvV?= =?utf-8?q?CoSgA4sHh8sODjviyjnKvktkGspUukZAW764aUyKgx7Oxe/kQkF4UHSF2va43QbOG?= =?utf-8?q?4qGtyd8NGSgMdnrQ72erVBEjXCkrk+NfVMBMSmZavfH6EMDaQjcP0VKrZKSijMTz1?= =?utf-8?q?lHqeMEjks0Uy7Ed9G90rFmHyl+b82KXwFyyAb8cIuvjWI3WWVR4HENVLiMgdvfKQx?= =?utf-8?q?ThA9A/8m0mZ1t1THB3R0XCvO/pevxoP1sGw7I1UORa8tL8VpCAUyzHA2W189+gcgi?= =?utf-8?q?9yJXMK5CJETDhMB9MjuWq8yig7pHW8s3FL5yUT/FZEjN3bSiZ66ZN0OfQIUNetNAm?= =?utf-8?q?fjhF/sQuv9MJLgPJ12I2JXvd48yBkLrKTBJG4SQ6dkHa0jCdCC2uyAPbAbGS6IK5W?= =?utf-8?q?zkFFXK8xGxdh4lL0JevaUQYjTU3AsviUtzjR1ax+LF1Lwym/qi/KgHNUGB2J4ZR5J?= =?utf-8?q?/Hs/drCkHanx+xa0Kcddwm47dmRhVip4MnJ9zvP4zhz19Bj7GOW3iWkJSjU8k2ghd?= =?utf-8?q?9POrTj49Dgmq4HwxwjHejxuK5Ydnea/mO+u5PNhMUEuKZ5ZWqK3aFexYbh9MK6+QF?= =?utf-8?q?MRJ5ob8u1nGABoEG3JyJM85hGhUmTDzRkT+g6jnACxvrODkYCTNFaL28JUzJy0MSU?= =?utf-8?q?CPYahyfvK2UQy7tQEd2XHlX/G4ubdMVb7VkuRRyJq6NClqdEczRXacFlx2rzKlPDF?= =?utf-8?q?bepmfef86wWy8Itg53NYtJc/hsMeDJ1+4hFp2sH79H2lMbISvGylimwNxN0ye6UjD?= =?utf-8?q?9uelDcIFmHuGNNkL?= Content-ID: Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-ae5c4.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PN0PR01MB9608.INDPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 1429c17c-8fff-40c4-bc5f-08dd4f0db07a X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Feb 2025 04:43:56.9850 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN3PR01MB7015 From: Aditya Garg This commit simplifies the logic in appletb_kbd_inp_event used for switching between the media and function keys on pressing the fn key. We now also prevent touching the kbd->saved_mode variable in case the esc key only mode is chosen. The following small fixes have also been done in this patch: - A small comment style error has been fixed - Fixed spelling in MODULE_DESCRIPTION - I have added myself to MODULE_AUTHOR Signed-off-by: Aditya Garg --- drivers/hid/hid-appletb-kbd.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/hid/hid-appletb-kbd.c b/drivers/hid/hid-appletb-kbd.c index 38fc0e58c..e45cc3ac4 100644 --- a/drivers/hid/hid-appletb-kbd.c +++ b/drivers/hid/hid-appletb-kbd.c @@ -236,13 +236,13 @@ static void appletb_kbd_inp_event(struct input_handle *handle, unsigned int type reset_inactivity_timer(kbd); - if (type == EV_KEY && code == KEY_FN && appletb_tb_fn_toggle) { + if (type == EV_KEY && code == KEY_FN && appletb_tb_fn_toggle && + (kbd->current_mode == APPLETB_KBD_MODE_SPCL || + kbd->current_mode == APPLETB_KBD_MODE_FN)) { if (value == 1) { kbd->saved_mode = kbd->current_mode; - if (kbd->current_mode == APPLETB_KBD_MODE_SPCL) - appletb_kbd_set_mode(kbd, APPLETB_KBD_MODE_FN); - else if (kbd->current_mode == APPLETB_KBD_MODE_FN) - appletb_kbd_set_mode(kbd, APPLETB_KBD_MODE_SPCL); + appletb_kbd_set_mode(kbd, kbd->current_mode == APPLETB_KBD_MODE_SPCL + ? APPLETB_KBD_MODE_FN : APPLETB_KBD_MODE_SPCL); } else if (value == 0) { if (kbd->saved_mode != kbd->current_mode) appletb_kbd_set_mode(kbd, kbd->saved_mode); @@ -497,10 +497,11 @@ static struct hid_driver appletb_kbd_hid_driver = { }; module_hid_driver(appletb_kbd_hid_driver); -/* The backlight driver should be loaded before the keyboard driver is initialised*/ +/* The backlight driver should be loaded before the keyboard driver is initialised */ MODULE_SOFTDEP("pre: hid_appletb_bl"); MODULE_AUTHOR("Ronald Tschalär"); MODULE_AUTHOR("Kerem Karabay "); -MODULE_DESCRIPTION("MacBookPro Touch Bar Keyboard Mode Driver"); +MODULE_AUTHOR("Aditya Garg "); +MODULE_DESCRIPTION("MacBook Pro Touch Bar Keyboard Mode driver"); MODULE_LICENSE("GPL"); From patchwork Mon Feb 17 04:45:04 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Aditya Garg X-Patchwork-Id: 866014 Received: from MA0PR01CU009.outbound.protection.outlook.com (mail-southindiaazolkn19010000.outbound.protection.outlook.com [52.103.67.0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BDA7155A52; Mon, 17 Feb 2025 04:45:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.103.67.0 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739767511; cv=fail; b=pqjxPhs9btavw7xj87kYG38pSqhZWx2f6Z7fjPW3mBhp1+xO9SHsAoVF5Xis9ZI/9ER+8DIJeyx6d20dXiy4ytjE99gtMhJNGtXhIexO2zcBE/yNhzgnItv3k92W8fOmudHZv2XRYmi3QH8aSfz9n/XVKP1R5zOmjzv3AxGz3Xw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739767511; c=relaxed/simple; bh=PPi15f63hoAy86xQcZ45uU/GC2NgZXi0T9pMc3VgLvo=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=IC/mIOUM0rWh7gk41US/GTZVCuER/Axq/RpludUXp57xW3U9IYLpHyksYy9CkNP0VMh5DVBk1TEtWC69SRAcTSvF2ctke3QCP3ERM86eCq7DFtYzhcGg5y/2pcDAsem0mR885WQWOgMsQln9AVl22O6ROIr3Kbdn3XtIIZgkWUo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=live.com; spf=pass smtp.mailfrom=live.com; dkim=pass (2048-bit key) header.d=live.com header.i=@live.com header.b=rbgsBoHN; arc=fail smtp.client-ip=52.103.67.0 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=live.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=live.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=live.com header.i=@live.com header.b="rbgsBoHN" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OR5OLWd6x5vkQqxEWmAS57LdU4I6cnUbiY6dvJnonAg3DnZY8LkWBspw1tWSZPiVuU5HmaBlDtU/qvNKJXUNDi0Qmbv4M+/NzjyM2YDRgI9tiEgIA+CDQ0MPGTljU8T4VNvIRta2JGamivNQby+PbVMZnKIO6YAHAfM+59NpYcCzsIQjACUXSMLwqHnL+eg5txMBgjeF385FzAvMRGMBMMqkdRAvCNf14MjBtHwAxIFfy6TM24vZ1MaRDkz3c2BKHR5411lDq7iyA3f1/xV0s0jgFTp3FynELxWRWDGC2KG9B2mnNz04ZNn4TEa8LPCVFeyTF2D0y/H0iDdjEYCq5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PPi15f63hoAy86xQcZ45uU/GC2NgZXi0T9pMc3VgLvo=; b=AsX8xyRCnnRL5C8vgo3olRwjOLqmiYr1DYZcT12fzknYg7TqL5l1sWc2j625ri8num2q9fHSf6TRXPF1KvbiJ5EtxPaRV/EZn26x1c9dMSnxUGIM9z5s8mTaOEusAZGZPNzGwOeSmUI4PXoZgqHmWah6weHmGKlE9/66HcS7YCk8tIQI6IzrVJBR5zHAZBhjAAOgqtRJsYmcC9Z05gwDMkdr1IwzId582RA1MUOozRAmxLJvikZBZbsDa3CwlGwfOeBDI2G/TlvRKk5G435gUHYcmnUx1PlOi4FB+eSfmh8DpkevUQHzCrq7ZB5jy3Wp7MOxBM+Rn2aFFTzw5Jj4iA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PPi15f63hoAy86xQcZ45uU/GC2NgZXi0T9pMc3VgLvo=; b=rbgsBoHNrIwWaFkCVKWSc90tELOozepLpk0Bawrm1eity3LlCaylYR36Meu1g80eJbST4ItqBxVZbWMWzw0uD/oXqexxBY13x0llO+ERJ3v7S7Rtl5PjfT46tc8FtDja10y186F5GJvlcJNcveMakFq6/iF7Aifsu2sbpV1Vxo3m6T/nhaGkbEfXI/HEPpU64PFdhcU9u0WktLKwFC3CXUB4NHG0up0Xr7yFvJ8Xcikc/R4mXnD53YBq5ca5dQT2ad2FPsgU/0WygBW9WOvQXzieisBQc3qOgxQ8r+JYMnhzz5sD4St0tuuodbFC2kXxn0mOP4QJSakDa8BEFDQmzg== Received: from PN0PR01MB9608.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:110::10) by PN3PR01MB7015.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:ab::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8445.19; Mon, 17 Feb 2025 04:45:04 +0000 Received: from PN0PR01MB9608.INDPRD01.PROD.OUTLOOK.COM ([fe80::972:abe8:752:bbde]) by PN0PR01MB9608.INDPRD01.PROD.OUTLOOK.COM ([fe80::972:abe8:752:bbde%6]) with mapi id 15.20.8445.017; Mon, 17 Feb 2025 04:45:04 +0000 From: Aditya Garg To: Jiri Kosina , "jkosina@suse.com" , Benjamin Tissoires , "bentiss@kernel.org" , Dan Carpenter CC: Orlando Chamberlain , Kerem Karabay , "linux-input@vger.kernel.org" , Linux Kernel Mailing List Subject: [PATCH v4 2/3] HID: hid-appletb-bl: fix incorrect error message for default brightness Thread-Topic: [PATCH v4 2/3] HID: hid-appletb-bl: fix incorrect error message for default brightness Thread-Index: AQHbgPa24BMjEJUStUyBicLEVwkKQw== Date: Mon, 17 Feb 2025 04:45:04 +0000 Message-ID: <3AB4CA1B-6FDB-4A21-9AAF-8D72A6F12D90@live.com> References: <8365C1B3-3A38-4F6E-955B-D6BBABA6B00A@live.com> In-Reply-To: <8365C1B3-3A38-4F6E-955B-D6BBABA6B00A@live.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PN0PR01MB9608:EE_|PN3PR01MB7015:EE_ x-ms-office365-filtering-correlation-id: 2d6d20e0-06b5-4b38-cbbb-08dd4f0dd886 x-microsoft-antispam: BCL:0; ARA:14566002|8062599003|19110799003|7092599003|8060799006|461199028|15080799006|440099028|3412199025|102099032; x-microsoft-antispam-message-info: =?utf-8?q?BIe4g680nwcPWB+l1S/b7sTcQJcMZFi?= =?utf-8?q?KE7In8XHkZkuc3/TXh+qrgGJhUyjD9IHsfTCAZ2Mbfeu3edq7g+Rxi5gA0cBxJGMM?= =?utf-8?q?4cCTl0YpIHM+2gAWsjtGMCRdZcM1nzR4rXf+jjVBNITO7ApJfpJEqVgkLCxtA0OVy?= =?utf-8?q?SEjR2Dp5kccrAHSl0C+nYiSBMXUGDAl2ju08d8/qGeFNMmkw4o2DeuCoPVkGDGSY6?= =?utf-8?q?8kaHghH5MF02wuY7edqGaiCG3Wzmt6Jqq7x+D7MWeuco/BEseTTA9d9xXMIny27C/?= =?utf-8?q?E4qOoszdiL/eG2MWf+9c2/sLkQiaLdo+/xRQiCYYMyfJQXXANPmIgls7WeEZBRCDB?= =?utf-8?q?wSN0kq6jeUKIQlR9Jp5lSLNHAvnLKE4PlBNtlxWR6kOSUIfe1/oWR6vJCYibUZx2o?= =?utf-8?q?vK1rIWDk/4zG3BdAkVPGxGrDufqYDyHvrjhdIfiTurnEV0ftqJ2Hr6SYSpRqdkDkZ?= =?utf-8?q?Q0ANKdNspxsjeNYcJqjn266uXe9rnzOM9RjeKHKZVMDYeRpI0mxSJXQ3eiyvvajNv?= =?utf-8?q?lNnNQN/DoDHif/veb+OJ8/VknQaKCluNU/tsp9UoZc2RxTnKID8LAz+Lx0nPpR/5D?= =?utf-8?q?cWqUqD9bQrmvWK6qrer0oCboiqEfxmAkowQK0QZLT/XRzbWUMwOVEp8P6Ns7Njdyp?= =?utf-8?q?ffdy/T5FpEh+REdpsZtZ1/ggZ0S60Q6MGq8HlbMOXIY+mFw7LozMZTnScMlN0SmS2?= =?utf-8?q?4CISS/OVrKos0WRmXHUoflRAa8BPvWdzeJfoIiKtlH/Dn7GO7/GBuNFZnmKpgLvNC?= =?utf-8?q?U0oZLkAQ8hr9g+R+8bYrqmvs76CtPbBsVOkmG5HuL1OBsjDB17JVl34cW+a/F91YA?= =?utf-8?q?vh0g2m/kFgK5+kR5d07gqFKQjdD2Rbnpvlt+fquhMNrwCzL10CpNpTrq6wxJp5lRj?= =?utf-8?q?Uak9MF+jkESDii+K/sTsH+sBDxOFCKGaWBLfcu/9RBqJ8UHm+efgsnojTR5sMkiz4?= =?utf-8?q?ICoAP3rFdLvhbCPOURRZLz6ojKDn0Z1zDzQWVR0+j3HKsp8SSSMThZYMminDXj3cm?= =?utf-8?q?wi3aNQkxAfvlgdsS2?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?q?UqDbYJnR7dhW+K+/ccsEqctc51dd?= =?utf-8?q?CkHt7jn7Wj0Px6sZZ55mXcMJnhAyJmL1SDb9HoSEQdqsMMwzhCZsg1LjVnRziHSNx?= =?utf-8?q?7rYFUV1sReLU0blzqGimmjyz8Rrx7Ow8lGnAEDh2KHIZjdr8PLkaUSSqVmUttPDxA?= =?utf-8?q?E4zOVKqPtLxFRDP2uG4IYbv0ToNF7EVkz+21O1ty3NpgXyoBeyiq7rgpIN5ENApU4?= =?utf-8?q?Dsu07zbxWyDE+JPg70o0b9f1dkWdHsyeikHCuvo6I/XpQGznRBOswNCLY9PVzaEcS?= =?utf-8?q?XC3xLYbZz5GA/sRD2OKXWkU4jQLEj9u9CIobh8ExNAUyECyCG5OMCzfo/zrziGNXK?= =?utf-8?q?3aO9zzLlEr/+lf2waPlUapcI3M6p/aSxdt9fUGDC1vzfzOH9ui5tZZmFc2DYyC28R?= =?utf-8?q?bYoT+4Mk35iASSRWVEXhlWeFMy+KwURhEFgmaly0Q6WdU04VogAcHFjJm/vhz50RB?= =?utf-8?q?Af4tFf1hMY2RsNqiQ6XmHe6j1Lts8X7WMSI1ADuz+zK3xnhyajBwwrBx1jqTh/e+R?= =?utf-8?q?NwoK6T9LTWqPHw9wjtkfe3fYdZoL2kajUbRo9CfzlgIBql+auvIAlw5GPL5LGFWf9?= =?utf-8?q?AGdiaauJu35zJC+HAaF1/yrVhtlAbPzGlUdf8Jf/lh4JpGyrm3OxMP2GqGGOBhjAP?= =?utf-8?q?Ztc16l+s63UtyKPIWociSAcH7ltQgyZXQW/pOjyfUBRQ0rapRJacHf682vwIssgDD?= =?utf-8?q?s3JRMPHfzwopEPfmFB20pmXBlMZzbne6wFqNlkMexLkPu5vLvkNtdZuCdrJ1vrNHx?= =?utf-8?q?IXaMykyo28GOlvPR2XOMo51XB9N1T8hSqMYGNBd6lQVDYr8ectzUAdjmdiFbQE0pk?= =?utf-8?q?OuG2mKwZyko9N4uwNU7dIrieg5YSmZBByk1uO46GzDibJgm8pweQqnXqtt0QfEAwp?= =?utf-8?q?1oUxQdiu9b639k+6tGcUETRoIsmIQKIj2D13/S8CgzUstEWu/7UtKyEUHvLy7dV19?= =?utf-8?q?v8N0twXAcfqwYDpQhUknraWBo/BGU2i0xNBanh2TzTGVUGpOkF7mzgZkrU455Bwys?= =?utf-8?q?4hghJAyel07p0nVWWfGiuKsog6jWI/6pTZ+iPge81+mSIKTf2qVcOFLSvM71WwVdE?= =?utf-8?q?1+ojPnIh9BV/Yg1Csy+q19DQBZijrZ64DLr60xm1ePq5AbSrfSW3tTTF8CZCNE65c?= =?utf-8?q?H438JzBgwbdQG3OOJvgPSWSMSzNxdNnGI5I8aA0Lknwzo+3+WXlesJDRysoRx0gDD?= =?utf-8?q?PLCcIUIilYRXIdV0rhLDcRv5ktvvt1OUqPLxGtqpamR88G7Ue1dCzn6FokoN9U3XH?= =?utf-8?q?Etu7KogQBHlOfsjV?= Content-ID: Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-ae5c4.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PN0PR01MB9608.INDPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 2d6d20e0-06b5-4b38-cbbb-08dd4f0dd886 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Feb 2025 04:45:04.1852 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN3PR01MB7015 From: Aditya Garg The error message responsible to show failure to set default backlight brightness incorrectly showed the intended brightness as off irrespective of what the user had set it. This patch intends to fix the same. Also, a small typo in MODULE_DESCRIPTION has been fixed. Signed-off-by: Aditya Garg --- drivers/hid/hid-appletb-bl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid-appletb-bl.c b/drivers/hid/hid-appletb-bl.c index 1a3dcd44b..bad2aead8 100644 --- a/drivers/hid/hid-appletb-bl.c +++ b/drivers/hid/hid-appletb-bl.c @@ -145,7 +145,8 @@ static int appletb_bl_probe(struct hid_device *hdev, const struct hid_device_id appletb_bl_brightness_map[(appletb_bl_def_brightness > 2) ? 2 : appletb_bl_def_brightness]); if (ret) { - dev_err_probe(dev, ret, "Failed to set touch bar brightness to off\n"); + dev_err_probe(dev, ret, "Failed to set default touch bar brightness to %d\n", + appletb_bl_def_brightness); goto close_hw; } @@ -199,5 +200,5 @@ module_hid_driver(appletb_bl_hid_driver); MODULE_AUTHOR("Ronald Tschalär"); MODULE_AUTHOR("Kerem Karabay "); -MODULE_DESCRIPTION("MacBookPro Touch Bar Backlight Driver"); +MODULE_DESCRIPTION("MacBook Pro Touch Bar Backlight driver"); MODULE_LICENSE("GPL"); From patchwork Mon Feb 17 04:46:05 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Garg X-Patchwork-Id: 866287 Received: from MA0PR01CU009.outbound.protection.outlook.com (mail-southindiaazolkn19010014.outbound.protection.outlook.com [52.103.67.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 705A933E7; Mon, 17 Feb 2025 04:46:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.103.67.14 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739767571; cv=fail; b=VXnvW2GLJoMe6MJg++jnvHn9cFqCrO8MROANYVUwsDWdGID7SuBhv2wnXwfcmC8XNVOckwjWhKaOG6rTN+4Ym4YCQPJR6qL5jnekW09C1F4O+aAAJOai/M0r1w5cRHN6yPg8F0asZIv4E0MF1qoi7lVv/sRuSrgKV11mW6bOhsI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739767571; c=relaxed/simple; bh=+VtLlWv+YwI/aimC78OdPDfFn3BDbMX0HN5xNe+Z+IM=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=jYqzfbTVCIAECrUBtxV/gs3DqujwbxBq8YVUkAEAIpvvFZ596GvaJyTJVOUbbD1asFpM3Q73rWOwem2wOIr1JNNm+ZfpONexclRv8jWvZ1+R0SFMuJYM7+9s6WzE0yoKygfY0ti71sW7WE2sSi2rEchUOFI5RDDQ8GDyyfedzFc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=live.com; spf=pass smtp.mailfrom=live.com; dkim=pass (2048-bit key) header.d=live.com header.i=@live.com header.b=dljL2xg8; arc=fail smtp.client-ip=52.103.67.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=live.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=live.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=live.com header.i=@live.com header.b="dljL2xg8" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=u2/KdwA9Pz/Q4aUIQhc/MuL4PyrSh8iCLZxSpvKe5HvROCIBqMl6WhRdB2m2ZEJA3w3X59kkZh6V9cqQqR4f0d2mk+27JCaAfUv+inYuf7albXLovPKWwWxzxDjImSC/hxlhVZFdtda/lIRGHxoi/BtGR81HtNXF3y6eUSFx2GIMq3vDcGXNDmNv7iQGCo6S3kxT8do1TuouM7WtJ2n2Pi/wgtLMxY3NxtidVtl6Scd/nPk5wWyRhvqM/psnDGC5AJO8rVCGtezmeCPD0loKc/BYuVT6NEayM2sR5x4aC36WNB+1iZSfQ8RFpIMF+3hQnDX4X/fGkl4vl2QlhcHYzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3QZKEjEKBo8oYsc7+EbtlMnsVJbLMOrMAibEg3sso4w=; b=DD5ffCxVV+YuJebxqyPBUFoMEU+dKnp9cb1R5B2m0/mv++vPxvE1jU8bbfgjd3gYDoOv2kQKMZFet3WEzqYSCUdWhGoeyGDM5m3gsrJzU/TnhFfY16OErX+nXU1rFGU+7LxT4C0WF3Da3zBuStTfluv53tJN1RZ6ajJucMsadAyTV1xt7XkUcVBLl3AQfD1SpVvkRumnphYNOPDOPo9N9a07KzonK36q0cScQVh8/X/22x9gWmg7iaOAl2BbPC+uF0sbJpIos5fKXTvdADq1WkP0YjjoE2ktZhwwM7vzXVAbBnQRJay1JQ+y84oi95AtfVjLGm+9Xov3vLzSLlekDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3QZKEjEKBo8oYsc7+EbtlMnsVJbLMOrMAibEg3sso4w=; b=dljL2xg8f/uJH+UDF9uyoWTxPhZwlfSrNkpiRwCjBopbeR0SO0NkGaZXLZUHjUsSC01GBKAVVdx47lvksTbcRyHW6pGktvxgROTaECatd/YWAw6ncFHd/dwOPcY92KhuIlibkQhVjmxbxCE7NAxmeqH6hE1Q85zIp1PL7pPPxQJ60sT6EREz5L04BPIOIAUOJsJZmDtfbo8vxj3yUZOziVrdj+dvRAetz6IvHRTiTYjDG6GL8mm5kfpHgrzx61oPvE/+HzGUmMa7WnQqdfd9pXomfEwzpgo0ex/KWO3J+HcT6cWQjWPhov7SqWDwb31FfUsIRI+S9DSGXuBDvNQAgg== Received: from PN0PR01MB9608.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:110::10) by PN3PR01MB7015.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:ab::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8445.19; Mon, 17 Feb 2025 04:46:05 +0000 Received: from PN0PR01MB9608.INDPRD01.PROD.OUTLOOK.COM ([fe80::972:abe8:752:bbde]) by PN0PR01MB9608.INDPRD01.PROD.OUTLOOK.COM ([fe80::972:abe8:752:bbde%6]) with mapi id 15.20.8445.017; Mon, 17 Feb 2025 04:46:05 +0000 From: Aditya Garg To: Jiri Kosina , "jkosina@suse.com" , Benjamin Tissoires , "bentiss@kernel.org" , Dan Carpenter CC: Orlando Chamberlain , Kerem Karabay , "linux-input@vger.kernel.org" , Linux Kernel Mailing List Subject: [PATCH v4 3/3] HID: appletb-kbd: Fix inconsistent indentation and pass -ENODEV to dev_err_probe Thread-Topic: [PATCH v4 3/3] HID: appletb-kbd: Fix inconsistent indentation and pass -ENODEV to dev_err_probe Thread-Index: AQHbgPbauH2mSAtX0k+7dZzv5BNdGQ== Date: Mon, 17 Feb 2025 04:46:05 +0000 Message-ID: <25CD58FB-ED22-4CBC-8166-7340D1E1B4B1@live.com> References: <8365C1B3-3A38-4F6E-955B-D6BBABA6B00A@live.com> In-Reply-To: <8365C1B3-3A38-4F6E-955B-D6BBABA6B00A@live.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PN0PR01MB9608:EE_|PN3PR01MB7015:EE_ x-ms-office365-filtering-correlation-id: d7942f7c-67c8-442b-57e2-08dd4f0dfd1e x-microsoft-antispam: BCL:0; ARA:14566002|8062599003|19110799003|7092599003|8060799006|461199028|15080799006|19061999003|4302099013|440099028|3412199025|10035399004|102099032|1602099012; x-microsoft-antispam-message-info: V1+4Rtjj1ztnv+KsArv26dWUrt6YvTWBlMhfWQPZ27m1yCHfhM3JtnVd2KAuederoCMbozMUr85dQvqCdMBcr5yxFGdILUIzIBi7fauZticICeK17w2OXnyFa+FbOwaM8sxlqWkkIB6eMzHhf7MwgohzpHtfBQIWg6vkITlZ7jtH+qfMu1SGy6Yzg4qk1VbQUCVouNGZZz5lhgx8gXOmHQRoweYQGywg3JComERNk42EnJw9e44bIMPgB8b0LNKRW8auGbnuPGUjiaav06MYVkKkZNIIuXMVw3KKS+IEzc60dQOPhJnVkWfwdM2+6qBH6G5/xKOOKrtpZ3b6rhwzfNDdcVKbYyr+GKYFgVPNuaZiJ0QxpXEdeLYAuO3MzfLStMKb1R1eoIl5TUG0otj7NHB27cpMhmuYMl5osNzFUeFydXNO9D5NwYZORJgAiZHE5iT8DEeIO/I/eDahzEJ/lSxESLSOhqeteblq6kBwgPK1ShhCzgyMwJtZfQI8LOyEsXHOLtOlUAIxB8vAcKCVKg32yIDe/MTVU5GERB8R7DIevQMfhw+eEqtwY5ihhJCkbGJjEsIrbuswRC3g7Vf51tw2FFTVCH1LvAh2/hFMCe2JqKSHQRxAeUOH2pkJAVxCQTfKb44WRm5DPgqgne14LLzEdoq47GZtw86USEQTkSzx0hktQRiFSWLyxiQrT0yfgJtYqMZVKaTEDB1oej5wxQ+AmI/lr0S2OgixgoHMkFhdhqGTevAKGp7UrXBt+BAsvfFHEnJR9ndyUTm1azNwlqHoFwi+i2e+lgjlDfYz69enMzLsM5Y4wvn06Hr7bkhE/LQJqYNZpmtqZIY83mV5EMvwlzBRcDekQamukxNDA0SjJ5k33WNhbRb6y2imlg6Jalz5e2R+jx7u3Hsjgkv4L4Vw+NB2S99HEQQBUGQiAEKQrXxBW0UzR0W6pVV+aEU7RrEoVtAJ01yOUIQygpQr7PbYj9UkQ3sCdXjf2QtE7vpcqIhnel2hrNDAApf5DU6AETu8Hk8rW5vgjyJ2eh6cT6s0lHnog+p04gh97RYhR8/37VO06AxVDUwfZz8n7FeECy+nnbaZYculAf576psiq8CM2fVvLKGYquEqt6z8KZw+7aO9KPdWF7S9Qnrkopc70Umj0fvnNO733hbsjQ8liX66NybAklPMOZHCwtPC9GMteWQaisca/n7jH3JMq/zvGuAKNuqrGFfAl943RJD62C0ygam/3LBVhq78cZ0+CRv5pOImA3oW49PzHUsPQct/1U3vv0l9GsA12FZLuZKdJA== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: iIgKjXuB94vCJVkHVqM9JjjUaJ2nrznZ92qKzl/h6LfqwOi8JLIfQW6PWDyKwrLvazC2l6e3nBQ0jU8n6tvH1/M4U9V0VB5d8sOufM5eaX/cBn9YQBXkfy/QUneIqdHBUz6o+eInHXRCfK8XqxDkDDJdw5JRFyfYhpXTM3+O44X9uTUr5M426i6zGXu9qHPBXWD75T2sLB1psLb1kSt4trHglPneMnIK7Pq55u3TpXLoiEZCakP3BhgfSaaq4RBGYoMAy9XYyasyL/T3cbVTdMmHXzy09VEpqoNSXB3/MhJ2hbPO6ARbEtZe8dQ266xsQr0brkRWFEsrwbVS6pzYK4zRiuWibM4QZ/T5TEpxAoSNUhbTs/1uzsK8/vhfs0edKubVleLBXkpmraGqXkr1fyAIhlvP1j4vjKH0/UfqD/hA/3f8upeF69zNYIGG0QL1KFx1FhEdvO3wbZQfJDXoX0yDzPge38ZpIDeXyRQUSoi+Q1vHLgT67qK5v3xIvLKXG2T7+qtzMgzmfQh9lCHlKvaGMYWRcHNxaJZwDFnIe4/YB+Xo+1U6hg8I0S4Q9Xhfa2wwGZz/Onh4VlFUt5N238fMRVXlikJ5H/p4fVhUpM84YuO28Rr8G/M9r51pNd3nISX+WU0jiCwS/CxMQJnJ2PTqNZUOuKNX+WzsNN+0RbpH0YyBI4dIM0h0YcmeXUc81FYHsdPjZquHZLNmkTr6FkcfzQGXrxkBLVIAHMrDLkG3JXO2C4rpzVGwtC9pHRzn0vyPFwfnqg5oT0LYGJMKaMD/XCyNQK34KA2NWI2j57UbI+2fktfsdjn4bBwfZDJAcm4ODY9BxRi4OqNYDcg0mrwLxUvnQqFfMboF3oIQfiHEO6pejbcOujMVhQ9wEwvbmIYuGphvQLxFZYyJyByK4789smFVcslCkhqgmS0oUBnV+QI8aI8U8IEDb+FOFw9LU39pQX+ipB/YnsM42rgjX+tukDlYY5Bpm0s6i5IQqd/H7/DJ1fjXtTuwAVlYyh0SLGW6Trdj28ZYiwTEsZ8Ld8fBhe6+SFsYiTJ0GVgpdux/dmYyiSBN/hZyPoEz9Ic8BVlwhfMxFfUshNvu02Wa+MhAi4VgePIslMJlskpjTiG2Ays4vGHvSEJVsJiyjMH+bfoGUw1GYMZPt22PfvNd3Z9Ye9rQKRO0FtX4tAc0lbPNIAgLVTo3W+W7J+0f5IiP6SzdSi27jSA+yoboQXPtztzRJ9uUZeAOASC1wL8fBGygUz4pMXFNp3Gd0PALBvGmcxSgw9o3cut505vWTHsngecZwm968Q4dRtcM9mP2nZu55jb0v2IIuyMN5aeLZWt0 Content-ID: Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-ae5c4.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PN0PR01MB9608.INDPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: d7942f7c-67c8-442b-57e2-08dd4f0dfd1e X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Feb 2025 04:46:05.6059 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN3PR01MB7015 From: Aditya Garg The following warnings were flagged by the kernel test robot: drivers/hid/hid-appletb-kbd.c:405 appletb_kbd_probe() warn: inconsistent indenting drivers/hid/hid-appletb-kbd.c:406 appletb_kbd_probe() warn: passing zero to 'dev_err_probe' This patch aims at fixing those warnings. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202502152006.fBBCdEr3-lkp@intel.com/ Reported-by: Dan Carpenter Closes: https://lore.kernel.org/linux-input/6263a1a2-4d50-41db-aa54-cfcb3e0523a4@stanley.mountain/ Fixes: 93a0fc489481 ("HID: hid-appletb-kbd: add support for automatic brightness control while using the touchbar") Signed-off-by: Aditya Garg --- drivers/hid/hid-appletb-kbd.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/hid/hid-appletb-kbd.c b/drivers/hid/hid-appletb-kbd.c index e45cc3ac4..d4b95aa3e 100644 --- a/drivers/hid/hid-appletb-kbd.c +++ b/drivers/hid/hid-appletb-kbd.c @@ -402,13 +402,13 @@ static int appletb_kbd_probe(struct hid_device *hdev, const struct hid_device_id } kbd->backlight_dev = backlight_device_get_by_name("appletb_backlight"); - if (!kbd->backlight_dev) - dev_err_probe(dev, ret, "Failed to get backlight device\n"); - else { - backlight_device_set_brightness(kbd->backlight_dev, 2); - timer_setup(&kbd->inactivity_timer, appletb_inactivity_timer, 0); - mod_timer(&kbd->inactivity_timer, jiffies + msecs_to_jiffies(appletb_tb_dim_timeout * 1000)); - } + if (!kbd->backlight_dev) { + dev_err_probe(dev, -ENODEV, "Failed to get backlight device\n"); + } else { + backlight_device_set_brightness(kbd->backlight_dev, 2); + timer_setup(&kbd->inactivity_timer, appletb_inactivity_timer, 0); + mod_timer(&kbd->inactivity_timer, jiffies + msecs_to_jiffies(appletb_tb_dim_timeout * 1000)); + } kbd->inp_handler.event = appletb_kbd_inp_event; kbd->inp_handler.connect = appletb_kbd_inp_connect;