From patchwork Wed Feb 19 16:12:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Claudiu X-Patchwork-Id: 866684 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED86C1F9410 for ; Wed, 19 Feb 2025 16:12:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739981568; cv=none; b=pcnVBbr0UN/knobfkserGSTzD9o5CTN79XvONG7JxHaLUMv7IHmMRXo58BhsAFy+0h/fSjTRoppbuL8E5Czt7YL9X857SeY15TMIXFs7c56Q4kqn/88pilQ2y7Ih52+OHMqBFcO/p/R6m2qoc1QfpUe7SA0EtFewWbZ9jjWPyzk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739981568; c=relaxed/simple; bh=ocze8YqnRMaWZsMl7gofFidYX1Ww5q1qO93+l3/0JDY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=StlTTn4CNgRAhyDM9qISf48IeIjUBMvacLL7cZwqqqMjTY+kWnVi6ahghRQa4dMaVjCf5rDwIb8VgFzNr+sQTZTuyzOZ7rpRZsv73MySjCqRBKB+fSeqE+1TFTQ/tpsqS87WNx2fDkHRiIfvbPGZyum9nLa5lVjIY0WtGvuzusc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=Gf0T/rmG; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="Gf0T/rmG" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-5e0516e7a77so5608897a12.1 for ; Wed, 19 Feb 2025 08:12:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1739981565; x=1740586365; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=G9x4mlOjAiy9oa9aITlEsW4n3OXG4Pm6mlTbu2Zgyrw=; b=Gf0T/rmG5zo9EJO0MsPcMDlvUNVJIp7er8PS+YlAS9prxMIcZ283F87fscWXGayGVS VNMBkXOSrqViMScZAUkYY4Y9Vg+uG5ua+fefwtx1Ag15gsAGtcKYXi+UUrHM+iNGGQT9 36gshRLUcQ+bVfTgxEpFbhbhCQJmCxf48dJMfUqEDsw9ZAdHxTh557Fla8QnFNf/5hos 51sQwEft2RuXGXfIl1u4oYyAjv/K9To0vyL/hvJ/qgHWOmkTdbIBshMxSAcbcpJku49p TigllHdYFxjYLCB9vfo1HCG2Eru8wsCuO3Vb4v0/LKc0aeFbZoZyu1qllb4SwDZxoMhp ZoFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739981565; x=1740586365; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G9x4mlOjAiy9oa9aITlEsW4n3OXG4Pm6mlTbu2Zgyrw=; b=DoLpLZMbXAgzo7URGWj5R4a8j9hozcsX2n2FvebmBmsx2T7zi8m4NDbCKVRr9Mrr03 uek6QyZ87jelQXV/izywQ0nC2Pa4mRmBFaKJk1EAOpHSfWnsn36eNe2LY5aJHTUx0Nk8 Lr3wBdZ1U+PGKxjCePqqqaVL+2ZCAyAs58TfY+cyKVaFycuESFL0KC5LgNccKt+yIsZ+ j/voSf0YJEVqM959Yxw6rPvajo/JQlwJeiztZSj9NJDnuZIqetQ56h+ddF5aiOaJ19xv g1N+61q2AOUckaVKaxB5wkGKhoipGDLIotgLg4VdA3WoR2Dmdnh8cFqLtu1DOsIGiVtM zkyg== X-Forwarded-Encrypted: i=1; AJvYcCVNfepghlt2/tRuYK2KSCo8BCLcYVpTczOYfD4dbdWdNZyaRoH8J3HO/djNV7STMo6+3P0ZKKV25x0=@vger.kernel.org X-Gm-Message-State: AOJu0YyTLLwEf0xAxX4xmJDzjhCS3KJVmuHH9zF6iVWt3mKAVppSCENd VTfpHiVMjnzNQuQF6diN7hcBOeeQfIUU1i9yLd9cjRPaWhre9PsCVYZne/XzkTg= X-Gm-Gg: ASbGncshNXcKM2VbTjASiWtnz0FN4I7gMSr+5KtBUB9zb+yHReyMCs0a6zIjcM2/ZmP k4gqoj4tIvAJ3rFYplGaew8DfI+eLcZtm6pD2P6kN6azZesL9dS97iUvPOU2TyfDXPTYsmC3gw+ y8o7K9n8TkzQzBIZg9uJbfHrO4u6s3g8RyuqLypkn1Bi215vpetm1n5xM6SDZz2gwNjb1+4PUD1 UlNOcOLRfaqMyon0Mr8aoWs8PfS9EQnAJvHq08FLqrzRQmF5z154Ugr+TI2ZaUBUVtZ+9Z3fBiM vcgKEozvQNQmRThb09EdDDDmi1ByjKkxeP7pfDDVTw5K X-Google-Smtp-Source: AGHT+IHvs3OSrAg6bwYOEo9sxXJTxipss8uEVegwbkp3y3giamb686DwVqQEfGye9BT5zFj7d6ma9w== X-Received: by 2002:a05:6402:a001:b0:5e0:4408:6bcf with SMTP id 4fb4d7f45d1cf-5e04408718bmr13432366a12.10.1739981565279; Wed, 19 Feb 2025 08:12:45 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.25]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e07f390626sm2548881a12.30.2025.02.19.08.12.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Feb 2025 08:12:44 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: gregkh@linuxfoundation.org, biju.das.jz@bp.renesas.com, geert+renesas@glider.be, yoshihiro.shimoda.uh@renesas.com, laurent.pinchart@ideasonboard.com, phil.edworthy@renesas.com, balbi@ti.com, kuninori.morimoto.gx@renesas.com Cc: claudiu.beznea@tuxon.dev, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Claudiu Beznea , stable@vger.kernel.org Subject: [PATCH RTF 1/3] usb: renesas_usbhs: Call clk_put() Date: Wed, 19 Feb 2025 18:12:37 +0200 Message-ID: <20250219161239.1751756-2-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250219161239.1751756-1-claudiu.beznea.uj@bp.renesas.com> References: <20250219161239.1751756-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Claudiu Beznea Clocks acquired with of_clk_get() need to be freed with clk_put(). Call clk_put() on priv->clks[0] on error path. Fixes: 3df0e240caba ("usb: renesas_usbhs: Add multiple clocks management") Cc: stable@vger.kernel.org Signed-off-by: Claudiu Beznea --- drivers/usb/renesas_usbhs/common.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c index 935fc496fe94..6c7857b66a21 100644 --- a/drivers/usb/renesas_usbhs/common.c +++ b/drivers/usb/renesas_usbhs/common.c @@ -312,8 +312,10 @@ static int usbhsc_clk_get(struct device *dev, struct usbhs_priv *priv) priv->clks[1] = of_clk_get(dev_of_node(dev), 1); if (PTR_ERR(priv->clks[1]) == -ENOENT) priv->clks[1] = NULL; - else if (IS_ERR(priv->clks[1])) + else if (IS_ERR(priv->clks[1])) { + clk_put(priv->clks[0]); return PTR_ERR(priv->clks[1]); + } return 0; } From patchwork Wed Feb 19 16:12:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Claudiu X-Patchwork-Id: 867425 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DBBE1FECA1 for ; Wed, 19 Feb 2025 16:12:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739981571; cv=none; b=tHX7kQBgQdUwz/vrJoVhS44rET1Xtp2vS7U07B3/rar18BQpYVi3JtKEStrA1375EFSM4TBL9m+324GSzleNCK4Txa27/7fbekYwf285ZqQ97BWDXBD7DaFBZW1dme75pAF1+M7QG80qI7kyHGpmTiEwbncEG2NKSdWHEF+EYFg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739981571; c=relaxed/simple; bh=olPIo7ondi9pZN9MKqIWTMM1H4TueaOeSXyLuuZ/SAU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TCFhtXUZR/wcZXeQ5jQfaU6ypy+B8N8PSlygAla20PTFHBxVI0r5pCnFQ5vOxQrx4Skb0gi0M7hCsQt/3dFFKTQLA6USwpWyKmZ5cCjTW+ACl5A0xo5/GyaMkgjcDRIoDw4nzPwdOIdXkUUqBBHQ2i2yhiTyxhWQRpyqK1me9FQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=AhWHJV4u; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="AhWHJV4u" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5dee07e51aaso11101352a12.3 for ; Wed, 19 Feb 2025 08:12:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1739981568; x=1740586368; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xEDW0l1uLZpkKjBmTN25YyNDkquVrBpJCv7mOsXan38=; b=AhWHJV4utcdkE1jDXDWT1m6MSm3+dzy0lH/HKvEjMWLpK6pRwk/KhIX0ZBTfjufK0H ePz3L8CzVWYEbBs5iVoJ05PRB3wl9KjVV3LpSN4T8mDxI+LDQJ1XeuHMBnjPpIcQ+hC5 YD6VOokiUkT2ixn2kEAxEBhQELGj9mOMXeGf42NbnLtNUgm89wZcxGtqZ2uOuRvLK+wd Y2BrpLD1E58tCqpQ/KOE2uUgDUpWK0tDKYNJapIsmyIe2j/K+4pjVT8uhtpgQnjAlRAt WkSXAa1QG6G5vdCDX7TB6s6pnj7+BQjPPGV3JdTzAzG6pFQUalT5D2CyWJkHQ44Bjvdo IE8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739981568; x=1740586368; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xEDW0l1uLZpkKjBmTN25YyNDkquVrBpJCv7mOsXan38=; b=ppWGEx9cHapjgVKqdhRK62vQHLwq0Oda0LsdkuL5SNXmya8kqAG6v5sk/br3vm7nXd mdEPoGNMrmz/D4KWNu8ocVFQsiMh0sFsIVANAnKFuF7cfMSkbq2DSecdxjT0UVZjMRos EzHevZAJ6MQkU6HqtHH/j3sOSMiTJad+G7VZaehJGgpyXA320GyjuJxq35tEyhw73a76 E6NINoGps/SkGLlp8ugpyytnyGwZ/KixRhrF7/l5/NoVELjdGMl55s1qJMPSj2y8j8a2 lY2whKW/lKDkl2RGm/M81oRmUhKF01/D01gpA095v0O4dtkRgQ6RIZLLPD6/VYZY81nG nJjA== X-Forwarded-Encrypted: i=1; AJvYcCXPGfHIj2SkjnPgyrsPK1TM+azyBq4Uz64EK77VwTYBhTtC3BcXKejebpD+HlPjhdIGpOOMAuJ93fA=@vger.kernel.org X-Gm-Message-State: AOJu0YyRf0OQjCVdgHPPVZe0hS6+CAabcAxYc6X1XG9OETYKcKziHKmB CMjSWjoB19EyqoZiX6ac+1Wem4ps1hV8ZGfdUhKzbZYyNOMQkBx0ty4As1o45Uw= X-Gm-Gg: ASbGnct/9J0TuaBU4X2vWG43oWQpijlOtiCZyjsWvORQKHWxUWmu9cfj+gUZ9exI9XI pI/fb7z3sRo3sHXDvPLdZbPkyWqpxRDpFz9IUyoiz0DqGcNTRs/MAL52On8ePk+rXcvm0L99hMl +y3H0BmVWzwaPMcEPt5i5lHiclI5Meso1+eBSj41db4zlC+MTA0HeOaAte/ME3pkYijiOg8jj4L fVSakkncrtBG7SnausUKAnBWI1Kcv7Hch7/oxOjfEIzGrDfN6CBK3oUjYqBko+gR27IEmm47wWL CHVNO/Er9ZydzPX5eXENFHq1gAfMqJVzzSrNHYSvkUsd X-Google-Smtp-Source: AGHT+IH3K7++bjaVQb708MVg6kp0Ba6iewq39EmLq++1d1VFY6n1zquEZBgNZF87Ke/PH45YqVx4tA== X-Received: by 2002:a05:6402:a001:b0:5e0:445f:9576 with SMTP id 4fb4d7f45d1cf-5e0445f96c6mr13997168a12.18.1739981567920; Wed, 19 Feb 2025 08:12:47 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.25]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e07f390626sm2548881a12.30.2025.02.19.08.12.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Feb 2025 08:12:47 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: gregkh@linuxfoundation.org, biju.das.jz@bp.renesas.com, geert+renesas@glider.be, yoshihiro.shimoda.uh@renesas.com, laurent.pinchart@ideasonboard.com, phil.edworthy@renesas.com, balbi@ti.com, kuninori.morimoto.gx@renesas.com Cc: claudiu.beznea@tuxon.dev, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Claudiu Beznea , stable@vger.kernel.org Subject: [PATCH RTF 2/3] usb: renesas_usbhs: Use devm_usb_get_phy() Date: Wed, 19 Feb 2025 18:12:38 +0200 Message-ID: <20250219161239.1751756-3-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250219161239.1751756-1-claudiu.beznea.uj@bp.renesas.com> References: <20250219161239.1751756-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Claudiu Beznea The gpriv->transceiver is retrieved in probe() through usb_get_phy() but never released. Use devm_usb_get_phy() to handle this scenario. This issue was identified through code investigation. No issue was found without this change. Fixes: b5a2875605ca ("usb: renesas_usbhs: Allow an OTG PHY driver to provide VBUS") Cc: stable@vger.kernel.org Signed-off-by: Claudiu Beznea --- drivers/usb/renesas_usbhs/mod_gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/renesas_usbhs/mod_gadget.c b/drivers/usb/renesas_usbhs/mod_gadget.c index 105132ae87ac..e8e5723f5412 100644 --- a/drivers/usb/renesas_usbhs/mod_gadget.c +++ b/drivers/usb/renesas_usbhs/mod_gadget.c @@ -1094,7 +1094,7 @@ int usbhs_mod_gadget_probe(struct usbhs_priv *priv) goto usbhs_mod_gadget_probe_err_gpriv; } - gpriv->transceiver = usb_get_phy(USB_PHY_TYPE_UNDEFINED); + gpriv->transceiver = devm_usb_get_phy(dev, USB_PHY_TYPE_UNDEFINED); dev_info(dev, "%stransceiver found\n", !IS_ERR(gpriv->transceiver) ? "" : "no "); From patchwork Wed Feb 19 16:12:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Claudiu X-Patchwork-Id: 866683 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 062E51FDE01 for ; Wed, 19 Feb 2025 16:12:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739981573; cv=none; b=tB0VedptLvPD/pz7HUKWQYh+DEY9aQTMM/1YI+6//ySveXjdS2UGFeQjkBkquRkL+Js+D4wHoztra3DBULuBIbWNh/5DkHrLqPsr5uKRGyH+JUhC+a7zl30n2yHMsMDuxJwZEpTd0EvfIAafz25BjEqUynmt8/K4up6Co85rA6Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739981573; c=relaxed/simple; bh=axF2Pp59a3z4NWipdCDsQn5fYbe8VXVp+WNIBSWoobk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aeVLwm2AqfZGLY6eIe1d5NMWFpbbR5lpLXaBWn1q5/UTEaDLXVCpPjlcUPEvhJE0KyzqUabjZPIq5tCV5cvmx/4kKQos2BcgDmnzM9uT1c8uhg7aFoiLNAwN6wzgFTREIJq/2/soFH0vLGeqGafXuCj5V6CuBzo9cS9miHfl5Xk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=U7dkyGrk; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="U7dkyGrk" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-5deb1266031so12254205a12.2 for ; Wed, 19 Feb 2025 08:12:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1739981570; x=1740586370; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pWZtx2jwJGHqxUnFIBqmFUKuSbo4cAmKHNmhP1PJ3qc=; b=U7dkyGrk+ttK0dBMzESf5NGFwMmAxjA8UJMS83+gUOGqgw77NA+Kcs76Tp0u8TrZx+ MpvnW6norj9M/3wAF7r8jJPUjriTxpjBV4rL62kYzfUgGbwAwcU4peRZIjICqcbROaTT tlChDhdkpfh/TEg0SsYQws4ozNLCc64+onzzlyEC202M26DV1wt5eCVVnYBXGcoAzWmq 3Pe5XbpBfwVJeElDM5C9BdJIDgEKCEAFruwVi1x3pYTd5qg1WJrmJs0rN/z1JpoB8NVC xndkNlTKzxz6oqeJB9G9MIzf0U0MF/diy4X3tJ06kI8NX1NWoJNR+WAWXgFCOX+6B66c D99Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739981570; x=1740586370; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pWZtx2jwJGHqxUnFIBqmFUKuSbo4cAmKHNmhP1PJ3qc=; b=NsWf224uHAYHw/bKgxfpuvn2xnrftGbjOGGRiqdpCy467LCmYXOY1J21WWjWdNgXaN kB0oYAdBKrEKq5T8cHvBJqBgqEtXLjxnYWfef29ZNMplF1ajayAVVGccanFNf2XM87dz 0Tgfj8YcdTglEfYhNkh1dFJkwX0pdHMHo3m3n4OzS/CVsd+Gcz7WGzwMQEvDEcHpDTAx oM8d8tIBwJLlJ6NHVVUfELZ65/9Za/pzUpxalDYgWiNbq/cre1WytUyT8KG/CHwO/eR/ MauGN8CPBkcL2uVz+isQAtCm9J1RQjT2sDUTNdB5ax5eYJ+gwmJDmdmxd56HfJp+Xvm8 5WGQ== X-Forwarded-Encrypted: i=1; AJvYcCUyCF8NL/IlEYTSaWeQMwFhdztoR7GcoNPfLpmKE6tfN1P+rq1MwLZhv0/MsnfcUuhBCn0TqdD0Jvw=@vger.kernel.org X-Gm-Message-State: AOJu0YyJhBmXZUnL4eOdazkbvOMDehNEPgDOFEs29gV+ItWCJ/28dXHr G4fWL4G9T2WKPyQEBKs6f85QCk+rCwyU/iuwfej/+AaTW4F73OjHQlA/rb3RYxI= X-Gm-Gg: ASbGncsDXCkfNly748qMNJFETJFVxf4+InvHqHqQOZ0G989UT/xRh+yB2xgeAQ2bzkY xAIg8JhRhqRDIbE9NUhRTOiLnyKgvp9JfF5rtUwAwLu8Z4kO7T0blyJt+sXyEVpC9hzUGNKya3G 7ukCnh5rQSkluBxNqg2b90djB4ovVfyVb2iQa8SWBxfVVurSxevvtj+ZZvGgxu/8ClJRwtML34X ZTY9fIyKt7mMwG3Yx3ds/Dqzl+hKFMrwP/VByw5wCkNPAJvMvHvjrdYqkZ41FmA9QCh2lM7Kib7 /pCyqvewFtaXex6bl0MLo45ocKz/78iMw0QiaiPHyPUW X-Google-Smtp-Source: AGHT+IEbhm7NcKnV5miBbyC3Mc4QXaqAGBiokThdnN9Unuo9244Ug/u1c1MM+nOw29agWhNsuqTOsA== X-Received: by 2002:a05:6402:5111:b0:5de:4b81:d3ff with SMTP id 4fb4d7f45d1cf-5e0360bb387mr15073998a12.13.1739981570329; Wed, 19 Feb 2025 08:12:50 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.25]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e07f390626sm2548881a12.30.2025.02.19.08.12.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Feb 2025 08:12:48 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: gregkh@linuxfoundation.org, biju.das.jz@bp.renesas.com, geert+renesas@glider.be, yoshihiro.shimoda.uh@renesas.com, laurent.pinchart@ideasonboard.com, phil.edworthy@renesas.com, balbi@ti.com, kuninori.morimoto.gx@renesas.com Cc: claudiu.beznea@tuxon.dev, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Claudiu Beznea , stable@vger.kernel.org Subject: [PATCH RTF 3/3] usb: renesas_usbhs: Flush the notify_hotplug_work Date: Wed, 19 Feb 2025 18:12:39 +0200 Message-ID: <20250219161239.1751756-4-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250219161239.1751756-1-claudiu.beznea.uj@bp.renesas.com> References: <20250219161239.1751756-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Claudiu Beznea When performing continuous unbind/bind operations on the USB drivers available on the Renesas RZ/G2L SoC, a kernel crash with the message "Unable to handle kernel NULL pointer dereference at virtual address" may occur. This issue points to the usbhsc_notify_hotplug() function. Flush the delayed work to avoid its execution when driver resources are unavailable. Fixes: bc57381e6347 ("usb: renesas_usbhs: use delayed_work instead of work_struct") Cc: stable@vger.kernel.org Signed-off-by: Claudiu Beznea --- drivers/usb/renesas_usbhs/common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c index 6c7857b66a21..4b35ef216125 100644 --- a/drivers/usb/renesas_usbhs/common.c +++ b/drivers/usb/renesas_usbhs/common.c @@ -781,6 +781,8 @@ static void usbhs_remove(struct platform_device *pdev) dev_dbg(&pdev->dev, "usb remove\n"); + flush_delayed_work(&priv->notify_hotplug_work); + /* power off */ if (!usbhs_get_dparam(priv, runtime_pwctrl)) usbhsc_power_ctrl(priv, 0);