From patchwork Fri Feb 21 18:25:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 867257 Received: from mail-wr1-f73.google.com (mail-wr1-f73.google.com [209.85.221.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECA622528E5 for ; Fri, 21 Feb 2025 18:25:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740162354; cv=none; b=t/U2rbf1fPK2PS/fizj5NRSXvrgGQB0za4hnohUDrgWho3IULzmojPbMjX1cCLMzMJoXKPiPqieeku3tlpfI0KpkoFpicXfg/2N0iyxMG3FY59HH/tqJP3MJB8fQl6MJHf8tGqIv2mHnJWCp2UfUnJMoqGX2MkdxFLA4fVn9XXc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740162354; c=relaxed/simple; bh=Ilk6+5tZclI1F7dj4D5Y8eYPtM9YM7Dc/fjaV8j1+O8=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=J7ZmkHGKiF9UnF4LDrc1SIw4MaVMQqg2ri42Df2YOYe3QkAdCy5nrWg6K9Lc/x07KqVtUuShss7NzhSYhdmO6JsWZI7oU3aXyD/vXubEv1vjn/FEWaRMG14C5rHllmK2xVSZWkmW58huHZLf34ayseVybKCth4pdZe5tEDZ8Q2o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=yyYUTpKs; arc=none smtp.client-ip=209.85.221.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="yyYUTpKs" Received: by mail-wr1-f73.google.com with SMTP id ffacd0b85a97d-38f20b530dfso3135289f8f.3 for ; Fri, 21 Feb 2025 10:25:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740162351; x=1740767151; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=wiDbMltjmyaz+TufXV5xdn+s6ZmLgnlpLnjEPTqGgXg=; b=yyYUTpKsjxOY+MVJ8O3WFXSlDtTPveuHDryCmeATQPIoCGBR/HN/9V44eyHwpaefAF nWkZepywzRYVnJIt1QsE641HtREin+poBtewlOG09c4CwVSUEoxJHD2o8TfYQ7PJOmiH alKAuIa1ufKFIAJnsxCQAWErqbnCkY0mHlxdrXLwHV58NfNOTpF4AZPz++yErDjXSde2 SDA0Achw/k7PNGqVeDHbtPoyAgzvDA4dOnliFxohd336D5ZkBy4ibwbvR4rkv3ZfEpnu kw8uDLQLTfA1SJHtCfbfkLINV3WTUUfZMz0MnA2OKJTJi87u4dXRS6Bs8gVPd3RTVs1B yfjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740162351; x=1740767151; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wiDbMltjmyaz+TufXV5xdn+s6ZmLgnlpLnjEPTqGgXg=; b=Ux70+DG8t1iRA1++Wpzf0UmyM45fWB89J/A74t9mMMPYvTDeMQFXTNPalHRRtyrRTe xOfIUwBUMAaGx69vfRlUdNo25dJuXDbYa2DJwI2+VvrOvwA/We3KeTE39eBpDwpYp+59 vtTxzoruHN81k+MJUDxByf3pHk6rk/0FJAV2R4NHecVBol1mA/LLT6wTpafQBlG+iR/0 hRn6R3Poe+rwFBlzBiolvTJQX/NvhDc9GyqclsukPEzVgXKMz1b0GFEl7CxYRJPVMGd1 R9IdfwJtTphH3lAX/fK1bTTqowvAOL0RRc4RvsgMqe7xBuwt/Zj840VdXYxAaO18lsK6 krRQ== X-Forwarded-Encrypted: i=1; AJvYcCXj68xQ7afS47ESGsPhqf+0MISOLJfBxsMF5Bu67KDHHPQfUv6MZ4YOmOC0rD2XVDGzvzvFutpXxUKIgbuCyHQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzTHQrLEuoV3q4wkCHc7uzYx4rO9jQKUaxW7VZMqMqY8681AjFN q8u+PHh1bVYGyAVsy9zCP8W9H+K6lWhJBEAXjxVD/5pnlQuJJ1tEGvUVfQA+gMY1J+3LnwWYPgh NFRToS4aWUQ== X-Google-Smtp-Source: AGHT+IHvtIB+srUjpk6uvB7EZGmO0/DSJFR+7wDmYyQaFCKzvAqVW3z1wzUI9oGP+GeG2cFpYZzpIvgbccRs1A== X-Received: from wrbcc7.prod.google.com ([2002:a5d:5c07:0:b0:38f:476c:40ec]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a5d:5985:0:b0:38d:d3e2:db32 with SMTP id ffacd0b85a97d-38f70783f03mr2572158f8f.7.1740162351365; Fri, 21 Feb 2025 10:25:51 -0800 (PST) Date: Fri, 21 Feb 2025 18:25:41 +0000 In-Reply-To: <20250221-mm-selftests-v2-0-28c4d66383c5@google.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250221-mm-selftests-v2-0-28c4d66383c5@google.com> X-Mailer: b4 0.15-dev Message-ID: <20250221-mm-selftests-v2-2-28c4d66383c5@google.com> Subject: [PATCH v2 2/9] selftests/mm: Fix assumption that sudo is present From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman If we are root, sudo isn't needed. If we are not root, we need sudo, so skip the test if it isn't present. We already do this for on-fault-limit, but this uses separate infrastructure since that is specifically for sudo-ing to the nobody user. Note this ptrace_skip configuration still fails if that file doesn't exist, but in that case the test is still fine, so this just prints an error but doesn't break anything. I suspect that's probably deliberate. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/run_vmtests.sh | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh index da7e266681031d2772fb0c4139648904a18e0bf9..9c963f50927ab2b10c3f942cedd087087d4d0def 100755 --- a/tools/testing/selftests/mm/run_vmtests.sh +++ b/tools/testing/selftests/mm/run_vmtests.sh @@ -89,6 +89,17 @@ RUN_ALL=false RUN_DESTRUCTIVE=false TAP_PREFIX="# " +# We can do stuff as root either if we are already root, or if sudo exists. +if [ "$(id -u)" == 0 ]; then + HAVE_SUDO_ROOT=true + SUDO_ROOT= +elif command -v sudo >/dev/null 2>&1; then + HAVE_SUDO_ROOT=true + SUDO_ROOT=sudo +else + HAVE_SUDO_ROOT=false +fi + while getopts "aht:n" OPT; do case ${OPT} in "a") RUN_ALL=true ;; @@ -384,10 +395,13 @@ CATEGORY="madv_guard" run_test ./guard-pages # MADV_POPULATE_READ and MADV_POPULATE_WRITE tests CATEGORY="madv_populate" run_test ./madv_populate -if [ -x ./memfd_secret ] -then -(echo 0 | sudo tee /proc/sys/kernel/yama/ptrace_scope 2>&1) | tap_prefix -CATEGORY="memfd_secret" run_test ./memfd_secret +if [ -x ./memfd_secret ]; then + if $HAVE_SUDO_ROOT; then + (echo 0 | $SUDO_ROOT tee /proc/sys/kernel/yama/ptrace_scope 2>&1) | tap_prefix + CATEGORY="memfd_secret" run_test ./memfd_secret + else + echo "# SKIP ./memfd_secret" + fi fi # KSM KSM_MERGE_TIME_HUGE_PAGES test with size of 100 From patchwork Fri Feb 21 18:25:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 867256 Received: from mail-wr1-f74.google.com (mail-wr1-f74.google.com [209.85.221.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B385E2512DC for ; Fri, 21 Feb 2025 18:25:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740162358; cv=none; b=ZF04hzehwTLNX2VihCIUf5WFbKxUfoFy81rRCBQONR638QK+3ZZ9+8KXFVqmbLENRgS5YHAuNyL4opgc8BV5HDcxQXih3qoVsI8abEjW/qeN/ELY+ZcuVyIcu33y0AflrENlcMfr0xzqBv4BXqBy76gCAwSSgsGLM9J3au12/hE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740162358; c=relaxed/simple; bh=Se/GydgHH9nLLIGfdGGZR9s2IiE5I/RUbIaLvfmjrag=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=ouB7KuQFkNCrJdmQ6TYVRyKIKEk5Cczt6fKTpL1U3MQIJHA80JrfEVxK14Y1NNxuyWPDw5XfMwMn471jJeuULzm8XWC0qnAY50NRIEbsQs2CQ738L1fzR6W2CZD5Njd58S/wgu8l4kCZQXcTbpOojLHhzuXfkCoZ5zcRkpGWthI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=PwNDunNQ; arc=none smtp.client-ip=209.85.221.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="PwNDunNQ" Received: by mail-wr1-f74.google.com with SMTP id ffacd0b85a97d-38f4e6e004fso1703818f8f.1 for ; Fri, 21 Feb 2025 10:25:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740162355; x=1740767155; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=y0OlocBh0Rs8sEPgodfZSsh3pCn2jLgGhmAgomJhmE4=; b=PwNDunNQ4iQ8OFox8WyAWJA0BgqS5SAg/Gur1Pza4LUhj0KA0T85vTztm06k2i34p9 ElDy+IEDkIitPiF2VT9AqPbXsvEmSBTPAbo8KLK+afhEsJIgP2rm8Q4iLkIhrIK2E3DF X5mimesiIzbnbBaiNwGTx1Z5O57lvWio3EyD9qnDKEdz3IwzcUQ0yblR7xFHLr/ZskMS hkCy0YNNYGo2wmzpZtFo+IaDNKLq2Hmi/F/lCEN9YZMDSTGP1AxnkSryzYKMcGzkYMpr RgR+CMqGfX7wx+d+SN8OUJRgyXjF9SNSLyd+/5KqQXr/Ufk4LCaAWtFuDzFbOhF+SRq8 jHoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740162355; x=1740767155; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=y0OlocBh0Rs8sEPgodfZSsh3pCn2jLgGhmAgomJhmE4=; b=u69dex8FDBqKD2AbX331tixttlq1Hmx3P2M2taF/oxbojdrxe0bSd9YOYR6X1g1+gl pEm2MHu1ZLgtjY7pQ4refhfoYUoHtLNRo1YO73ZUQPF4x+GhY7FgAbcjvUpNhPKMxhKI M6+0OlC69kR3ejaqlfrBKLuQXYYPvstHJwEvW/TexSnz4qmIFvaiks4fcDY6FAhFHmlN mHpcW8oxcKkCM4NXFnN66qv4dznLkMhs8dz//UZqM0crq93M/zt18/5MPBLG/D3EbG86 TpQeZuAwpj6w57H7ISk6DvLPLI0tg4XN2GH5WBisKi1ZlyLgYpMwkDmmKYbh+g26vnFh p/Sw== X-Forwarded-Encrypted: i=1; AJvYcCX0DZkfyNag0z8zj2p1AKNdFRCO/Zb/TwO3KKzecB9l1MDbM0vRgQdNBYwYqcgsoXK/exiHFn1Q8BLChRHU80o=@vger.kernel.org X-Gm-Message-State: AOJu0YxBA+ku9dcMgV0OUvGgikXuYmw/g2IInkAgbKMNa714CrPDPPGE Hefm5T3fOQFJTdH7GfjxW2YjC6W0gG19StFaPVF4sZ6a6DZ6Uud6CSG3a/A8qeAek4JQvrYZGlS yH4HFJh4LPQ== X-Google-Smtp-Source: AGHT+IHF00NYCWo/+nsUyTvFt7hFdbCjIyIp1GC7s9p832mqevEFRq+xbxahQieU1de9AeZKv94BIe2ilx4pmg== X-Received: from wrbed10.prod.google.com ([2002:a05:6000:20ca:b0:38f:59c8:7f1d]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6000:2c6:b0:38f:23ed:2c7 with SMTP id ffacd0b85a97d-38f6e95af22mr4581182f8f.14.1740162355261; Fri, 21 Feb 2025 10:25:55 -0800 (PST) Date: Fri, 21 Feb 2025 18:25:43 +0000 In-Reply-To: <20250221-mm-selftests-v2-0-28c4d66383c5@google.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250221-mm-selftests-v2-0-28c4d66383c5@google.com> X-Mailer: b4 0.15-dev Message-ID: <20250221-mm-selftests-v2-4-28c4d66383c5@google.com> Subject: [PATCH v2 4/9] selftests/mm: Skip uffd-wp-mremap if userfaultfd not available From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman It's obvious that this should fail in that case, but still, save the reader the effort of figuring out that they've run into this by just SKIPping Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/uffd-wp-mremap.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/uffd-wp-mremap.c b/tools/testing/selftests/mm/uffd-wp-mremap.c index 2c4f984bd73caa17e12b9f4a5bb71e7fdf5d8554..c2ba7d46c7b4581a3c32a6b6acd148e3e89c2172 100644 --- a/tools/testing/selftests/mm/uffd-wp-mremap.c +++ b/tools/testing/selftests/mm/uffd-wp-mremap.c @@ -182,7 +182,10 @@ static void test_one_folio(size_t size, bool private, bool swapout, bool hugetlb /* Register range for uffd-wp. */ if (userfaultfd_open(&features)) { - ksft_test_result_fail("userfaultfd_open() failed\n"); + if (errno == ENOENT) + ksft_test_result_skip("userfaultfd not available\n"); + else + ksft_test_result_fail("userfaultfd_open() failed\n"); goto out; } if (uffd_register(uffd, mem, size, false, true, false)) { From patchwork Fri Feb 21 18:25:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 867255 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B105C253B72 for ; Fri, 21 Feb 2025 18:26:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740162362; cv=none; b=mkJ1pykkV0WkwqGQK7C34tiF+x9DdLby652fGoezuoIEpxX/4Eb798qtkSQl+BWaUDl1yAVwJJyCb1xtgphooyMKzCrOiJxPRsxx3a0ZjJPKJj5VNMQ6N82eTp1sKIU08yFzPPO2IVl4v+td+C3E7y0eYQGGreFD6Cr/Ia0GhQ0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740162362; c=relaxed/simple; bh=Jd3sS0uhGXgTw9um/6BzDZdcnVVUyQaC/pjolFnZ02M=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=HsitDBxnWVLZU43Kbnw2DuWwxHcF9Kt5I0w2X/WMT97DjmZPX5k42Si6mJ6H7iu0aNnzbxVabIXdeW+nEQK0WhTZ0KOZj9n+9D9bwJNk8ThBm8jP3IyGX/naaUc7QoePzGAZxWhChtitYwpS8G/eMj4nqKML7xt1lQ9NgMLTbwE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=RFc0oUwi; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="RFc0oUwi" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-4398a60b61fso12607515e9.0 for ; Fri, 21 Feb 2025 10:26:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740162359; x=1740767159; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=mTW4zFHgqMTpKYtsmp9+cjJMhtMM4lVL076gYjHeNng=; b=RFc0oUwiD/QeWDpIxa0dDUicD/kdqhmSfuHQ6ZvEmLwg5KUDPIH0RBnnpL/k2HH0J2 xRRIeK6wOh4twSFeR82nH4RZEmY7kdx0chDJjIxwLgPvYO+fEJ6EcfZ2cjp5CQbAVRFW 6U+ir3Tryi0/pSrDcSLYAHRx3YqcMy+Xbj5UCZYDlg3KJqMcmfud8Ny7BhhHGmRLTso3 fGJ62tetieZF4F+UZrhMyBEXQrKzJmPQhVm7rqdGQ+jyHMLXQZ+5KA6r3SEYws40uHx+ HQrQ80gOcAdkNB1l7Q/wSzGjNSMgpFHuNCY2XkqtFPfE0xlB0ZbIViqwNaW9CEaF6ISE 8sKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740162359; x=1740767159; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mTW4zFHgqMTpKYtsmp9+cjJMhtMM4lVL076gYjHeNng=; b=Ni1f6g9UU/ROKtz3Cql1wSvo4UDPa8sSh0kD60DBUJx23+BO5+bM8OaqVL9woPPIOo jVWzztUQkOls/uuBo+IBv1yal9OJeWtKN0vtapiuC1jbrHN1CJWSBVtnr45nbdF9LQe0 PALOw8DhJ1fs5pdVbVlo9zMufWNBF35nzTF7+zHS+Go3HGbgMyoG1rGDr5wI2mc/cniR uUAQF6zAbknwR1mpaosQnoe+cM3P9LOi8AUE+KCTbLqS19dxoTWbkFNzKKMD0E+sgvi/ qI9AXsRADnKl8cUqqFr0QjXordTxY6/VRalb5BnBvzOCd2LNP+SzFMD+dyiRXSE60Viy 8QLA== X-Forwarded-Encrypted: i=1; AJvYcCWAeLuSCGehVoQMRjQizqozWLDUl8u1KJ0wGEDyEV6yDrtvkdc2odcM9ef12vqoX4oq9/QOKy37GampZrBU7AY=@vger.kernel.org X-Gm-Message-State: AOJu0YyYW85QzJ93UUPaexLE/qT3iD/6dP1Atc0WiVM6DwstPQZa6/hV zwQAncW3hARnm6rVzeA4WZjpnozz+DB2G4uF6rwZg4yPYgTghBAqynE8kTWI63YtOg2787DFHqU NJB85Ky6asg== X-Google-Smtp-Source: AGHT+IH+lec5x9erUgvTpG9GeO/CGpjb1ve0Ipn83JFb9w83c23OEehpnp+ZQ8agucCyadGiN7t3B4OuYtYozw== X-Received: from wmrs7.prod.google.com ([2002:a05:600c:3847:b0:439:80fc:8bc0]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:548a:b0:439:9a40:a9ff with SMTP id 5b1f17b1804b1-439ae1d7bb2mr32069955e9.1.1740162359413; Fri, 21 Feb 2025 10:25:59 -0800 (PST) Date: Fri, 21 Feb 2025 18:25:45 +0000 In-Reply-To: <20250221-mm-selftests-v2-0-28c4d66383c5@google.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250221-mm-selftests-v2-0-28c4d66383c5@google.com> X-Mailer: b4 0.15-dev Message-ID: <20250221-mm-selftests-v2-6-28c4d66383c5@google.com> Subject: [PATCH v2 6/9] selftests/mm: Print some details when uffd-stress gets bad params From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman So this can be debugged more easily. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/uffd-stress.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/uffd-stress.c b/tools/testing/selftests/mm/uffd-stress.c index ec842bbb9f18e291fa51de0ed8d1fbf9aaf14372..be0c93f24fccd618f52d54ff36d9a5540f420e46 100644 --- a/tools/testing/selftests/mm/uffd-stress.c +++ b/tools/testing/selftests/mm/uffd-stress.c @@ -456,7 +456,8 @@ int main(int argc, char **argv) nr_pages_per_cpu = bytes / page_size / nr_threads; if (!nr_pages_per_cpu) { - _err("invalid MiB"); + _err("pages_per_cpu = 0, cannot test (%lu / %lu / %lu)", + nr_pages_per_cpu, bytes, page_size, nr_threads); usage(); } From patchwork Fri Feb 21 18:25:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 867254 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AA84253F22 for ; Fri, 21 Feb 2025 18:26:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740162366; cv=none; b=FekDWHy6ARuyD5O7gtspdteN6qA6FDi7ELuz3xUBwQ9eyb5M9BZvdz/4R9X9+Z8LFzx/2VKEGKNxrJpMzg7CRzJWecnooaYpP7eCo8iS6spQCy8CECOH8wdq9mMHHi05UgSk32OZ64BMbnJxvQoeUQLuSg2M0+eKDOMKF01dlzM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740162366; c=relaxed/simple; bh=0VVzpjNfd+6snGR0TjzfQ8zQNDKzei8aKaEhvskOFCk=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=jtOco5HUz3cXDuddLbqx306nhavcl6KlbgSqHgXQ1arot3JQMH0Cec8bAWRKXG4yD9NwsQ3yPyRL3aFEdqapDLcv/7zoJNdfIXDZtUdrIJikdkO9XA1HOZwEloqE1qOTljUkVot5kSCJyMI2Brw23vemG1oc+fq+I02jbDEhuxY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=KAHLTkYj; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="KAHLTkYj" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-4399a5afc72so12232955e9.3 for ; Fri, 21 Feb 2025 10:26:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740162363; x=1740767163; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=tBZNxOekeKV0LYb007rKOQkv4qSAcfWIVKd3wLeISbE=; b=KAHLTkYjgqS2gEdw80e0AsykQPvzvthbmiNo4HB9uSAEv7iLlQKFR6HrJsOtewAX5T Ar8m9AO4OZPkA//fzq6YlSaNSZeGqAJ5sy4A+j+1qe/FBnuvVjR1eIvuBG0NGbTj4Wn/ 18yLiwVinIxeFKP5EHq4rS1xrAxAJcquL/mgSECT6AEdem5B3I91xuiXgy0FrYBN1V60 MEDACqVpZRdQfsrY6HInES+i/BUO5lF0r3GRg5kDdeAOx5RDWfmRbRoiu/rCmbBBRXTj dOVynd7jQD8fvC7K1GVqNdyLp9YXT3mSLXAMQ42Udy97q4lJ/WROEuGqsENpEbq3xzTF F8oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740162363; x=1740767163; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tBZNxOekeKV0LYb007rKOQkv4qSAcfWIVKd3wLeISbE=; b=UK2+4MH7g1PpW5pTK8v+QcLz0v3j4cGR90qpRLy7pRmvoNsaeMdDs6c9blYqGev/L9 P+AhPj3mH92vOOlqW3zJlQRFsIAThAymPCmVtUUGtNTxpj3UFJuHw3pshOmEQIcE9PVt tnBNjvrrexGM3p5C38SZdLvOg9GTOzEAqS3CTQHWqYxw/sdu1ipQLTDhxnhjs73Xv5qi ZYk/UDigYRFYljYzlbnklDGEy0WRgz9d1NQ3FRdfbmlrqr772Y2PNYlQspOHZ0uwcuXV RgijrdoNdmwfFWzwSjfehdVzimExpLcWS7QtKHD2A6SyRsH62cOZaMZV5Y4iHxISWdsL sEOA== X-Forwarded-Encrypted: i=1; AJvYcCVcI4KkC/eycUY9x9ojvMUoRAT5m8J4xGxYH6r1BHk9UfBJtLpCBlNo91oZcDG5jWsbzZmNs/GjgztwtyG9SIU=@vger.kernel.org X-Gm-Message-State: AOJu0YxQb9nT/DJqTaY9WmvtW13WFTEwPnh3FaqxBzzPyg3kg/oA2SDy 9hJdvZBAa9vGils9RSVhh+7LegkcKo9K1cGNP1dXPvVAqIWRHj8zvRigyHz/JbDQq7EjMX2d4PZ VcUKaQ2ZIKg== X-Google-Smtp-Source: AGHT+IExPP5BlXnuhegFwP5+f6OWmFBTfcOqXQgMBOZhO/TZNpjmVHE5y8AbHxBbpzzmIk1bu6Aq9tp7s4OWUQ== X-Received: from wmbay5.prod.google.com ([2002:a05:600c:1e05:b0:439:9541:1cf5]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:4e06:b0:439:9274:81d0 with SMTP id 5b1f17b1804b1-439af0d5031mr28996635e9.1.1740162363271; Fri, 21 Feb 2025 10:26:03 -0800 (PST) Date: Fri, 21 Feb 2025 18:25:47 +0000 In-Reply-To: <20250221-mm-selftests-v2-0-28c4d66383c5@google.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250221-mm-selftests-v2-0-28c4d66383c5@google.com> X-Mailer: b4 0.15-dev Message-ID: <20250221-mm-selftests-v2-8-28c4d66383c5@google.com> Subject: [PATCH v2 8/9] selftests/mm: Skip map_populate on weird filesystems From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman It seems that 9pfs does not allow truncating unlinked files, Mark Brown has noted that NFS may also behave this way. It doesn't seem quite right to call this a "bug" but it's probably a special enough case that it makes sense for the test to just SKIP if it happens. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/map_populate.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/tools/testing/selftests/mm/map_populate.c b/tools/testing/selftests/mm/map_populate.c index 5c8a53869b1bd287b09a250edf628a66c25c2439..cdd88531dd9fe98f2d25edf4878659767c919e8e 100644 --- a/tools/testing/selftests/mm/map_populate.c +++ b/tools/testing/selftests/mm/map_populate.c @@ -87,6 +87,13 @@ int main(int argc, char **argv) BUG_ON(!ftmp, "tmpfile()"); ret = ftruncate(fileno(ftmp), MMAP_SZ); + if (ret < 0 && errno == ENOENT) { + /* + * This probably means tmpfile() made a file on a filesystem + * that doesn't handle temporary files the way we want. + */ + ksft_exit_skip("ftruncate(fileno(tmpfile())) gave ENOENT, weird filesystem?"); + } BUG_ON(ret, "ftruncate()"); smap = mmap(0, MMAP_SZ, PROT_READ | PROT_WRITE,