From patchwork Sun Feb 23 16:42:01 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuan-Wei Chiu X-Patchwork-Id: 867837 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5365778F41; Sun, 23 Feb 2025 16:43:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740328983; cv=none; b=jdUEgLaO9ZVZTUxFZTX8m4BmWe4ITJ3tPWEZzqKqGByZOaTRZBpl2dsCz0FqFY4i+3aUDOTCpZ/471xYS+DWmeKA534aBtVZMo6XgGhEPk7jC+HTRqzwBPa+/Df6Oq/okBZ088JEXNSB62soGIxQIzzoWsSK81964jlIeB2rXZ0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740328983; c=relaxed/simple; bh=hSOjgUw8pInTvIwc3Vx2Sv+ma38FohsXF5UBIlyo008=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=St1Chg2RH5SY/LkOmwztshAExH4oJpnByxKNFSRsRWm4ySbYr/DIN50PnX7vLRupgWujWNtuhfIXxtWssmDzYYopVqWbqEKR/qLtmjCRDnWmCORTk6S1eIWEor5VPWC+Wo827bhpXGWU0cOJ0WMwT7tGta3smXJs4M0ZpgHVvG8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DO/shwOK; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DO/shwOK" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-2fcc99efe9bso5600716a91.2; Sun, 23 Feb 2025 08:43:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740328982; x=1740933782; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=l8NvrVTMlDH5q7zXpF8J7bfqPimXPkp8jnsCRo60EBQ=; b=DO/shwOKozgqDMAiGKOgSNvG8IJ14/csFa++GcSeBtS7Znv3okslTAGhJMk6iPVRP6 n4t4kHzUOHdNHvruj/bt8vHzI7tYwASpdHZssuviwOxTo15Pcf4YlzGfBI1W9vMgSlB1 PW65j8ZF9ebfF0vSrovejhNNqdYLsi/s+5Yif9Ww3NM26M4XERZy3ROvA0IbI76YOpqa 8Kf/9C8xbBNOgn3YxVj4cXtynsNCQ8SOZ9hz4DWVRt8pwWHN4TgTPJZre3Ss5rS6ph+R LR4U4g6GctJWXL7pUgW3zh7ii3kGDYTAgbByhV08CBUK5HhrWZZ+QIfmFP/+usvsImL/ G9Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740328982; x=1740933782; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l8NvrVTMlDH5q7zXpF8J7bfqPimXPkp8jnsCRo60EBQ=; b=gOKQ1nCgQA5md9y8No769wOfOn44amaNCtnozD6PqkAs1cUGf8zPgMyxMIeHyg4Kui rBhJK0RyKUK24yIq1aqNHcY8vqyT4DSGaVuPelVecfO1rf56IKTG547+rtdbJl/BNNsv AfP6t65TTNd4PFuZ/PkB4F/cKDg5Pq0rn5aQyXQOj85KdVHymS7e0V1uNwiiDgTTGOoz ReI9W0/JiPex30ZJJ2yQpP2JBYrec8JUiIdLcUcyfpDU70ex3T0Ki16/sjj6PZFskrbe xTD5GPt4Sj7ETG6X7cLLHB4Er3VCFtDipgyijvZ9KQ3kXCsIDp/ISZuE25+HVjanQ5x5 NR9A== X-Forwarded-Encrypted: i=1; AJvYcCU99jlV+/Jy02NNZNMTU9sNQHgmP3tzuPhYZ+jFb6hUYSbGV2JuRBzbdibudaRoIyquBmV+GrCIdlneG/4mZ8o=@vger.kernel.org, AJvYcCVKhfnT9xQ+B0wjai2QqfuRYA5i8IFOD3wTkaVkh8V3b6bQIQbnh2oIAiW8ZifZVxp0MZFng9uv5IYZk3cm@vger.kernel.org, AJvYcCVkghz2viIhJt68R1JvlqfcALSlCW/BqMu+qXyCJtgYkLA3WzNHjfEblw1fTX0lzOevHUHSMYjM@vger.kernel.org, AJvYcCWMGwp5S69s5Ai7b1BWbOcx/bE7L90D2Aw/W4NmTEwtEHgtC9B6/XDWzz9w+rSRUwa0szapf/zputUY+Ynt@vger.kernel.org, AJvYcCWw0hJ2eyWus/8K5BESklO75mk/Z7wegUt+YAujoN601KttjguG6aMoFO1HZQOFX3aWiJg=@vger.kernel.org, AJvYcCX0WAlctFwKuvydD6OjuZnr1GnqjyEUaROEMjhLix3a1y+AS1D7gfCC1EU9AQbJ5LBeAknpRovdCHjL8OY=@vger.kernel.org, AJvYcCXQfbpD6VLCjtFYfdrhudBvewR7HZ1SxVPJIvlGCe1AaFhk5EwYA/LZ4Yva7QFbxCttn79P7Cg2ageTIAE=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5A/Qbo9OEvt8xlsaFKGC+Wsox0YgJ3lHMUaEBSEgTMBnWpwIy kla9aTVEfazJ2iMcJ8AbCCWj8Nj0KUoerMfG1Ls6tBg1+DloOFN6 X-Gm-Gg: ASbGnctJeThbhDtahG+zwKrTX0mY5KxNj2kWNX18Y51oiSdk8ovQyVtlmZ3dRrceWRF lCIu1p40axoKhyGwufR57zqEkxYpdlQK38mVL0dPCtFi4xdf52hPVjIN6YTDQw18B04c2o4B0wQ OGj0v2aZXV/lJ55LFCL6H88K97mAy4gEQUXG1IO7Lk+eI7WoHOtTReetIM4ypHM26LYSJ6tm+RQ ZTZkblvqr6Lf0Vk3Rvy81q2XHhDOrOR4XJR9ZgbuUQaMU5odQA4GVbNihxId5TZWO135cP3VaI6 Y0lXN5Eo2TpeAWBYT0wqBuSCHOOcjoBeXtufokO1nc87XF9Yo54fIdu+ X-Google-Smtp-Source: AGHT+IHY182dhZjo+LBq9qsTP5GtRPKleXwf977mCGplhz7BFQQV3AK7mJ142hsRvikrULeBFmErJw== X-Received: by 2002:a17:90b:4b90:b0:2ee:a6f0:f54 with SMTP id 98e67ed59e1d1-2fce86b31cdmr16578615a91.13.1740328981599; Sun, 23 Feb 2025 08:43:01 -0800 (PST) Received: from visitorckw-System-Product-Name.. ([140.113.216.168]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fceb09f6e0sm4935080a91.44.2025.02.23.08.42.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Feb 2025 08:43:01 -0800 (PST) From: Kuan-Wei Chiu To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, jk@ozlabs.org, joel@jms.id.au, eajames@linux.ibm.com, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dmitry.torokhov@gmail.com, mchehab@kernel.org, awalls@md.metrocast.net, hverkuil@xs4all.nl, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, louis.peens@corigine.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, parthiban.veerasooran@microchip.com, arend.vanspriel@broadcom.com, johannes@sipsolutions.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, yury.norov@gmail.com, akpm@linux-foundation.org Cc: hpa@zytor.com, alistair@popple.id.au, linux@rasmusvillemoes.dk, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-fsi@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-mtd@lists.infradead.org, oss-drivers@corigine.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-serial@vger.kernel.org, bpf@vger.kernel.org, jserv@ccns.ncku.edu.tw, Kuan-Wei Chiu , Yu-Chun Lin Subject: [PATCH 01/17] bitops: Add generic parity calculation for u32 Date: Mon, 24 Feb 2025 00:42:01 +0800 Message-Id: <20250223164217.2139331-2-visitorckw@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250223164217.2139331-1-visitorckw@gmail.com> References: <20250223164217.2139331-1-visitorckw@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Several parts of the kernel open-code parity calculations using different methods. Add a generic parity32() helper implemented with the same efficient approach as parity8(). Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- include/linux/bitops.h | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/include/linux/bitops.h b/include/linux/bitops.h index c1cb53cf2f0f..fb13dedad7aa 100644 --- a/include/linux/bitops.h +++ b/include/linux/bitops.h @@ -260,6 +260,27 @@ static inline int parity8(u8 val) return (0x6996 >> (val & 0xf)) & 1; } +/** + * parity32 - get the parity of an u32 value + * @value: the value to be examined + * + * Determine the parity of the u32 argument. + * + * Returns: + * 0 for even parity, 1 for odd parity + */ +static inline int parity32(u32 val) +{ + /* + * One explanation of this algorithm: + * https://funloop.org/codex/problem/parity/README.html + */ + val ^= val >> 16; + val ^= val >> 8; + val ^= val >> 4; + return (0x6996 >> (val & 0xf)) & 1; +} + /** * __ffs64 - find first set bit in a 64 bit word * @word: The 64 bit word From patchwork Sun Feb 23 16:42:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuan-Wei Chiu X-Patchwork-Id: 867836 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38975132111; Sun, 23 Feb 2025 16:43:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740329005; cv=none; b=ZiuRa4QYt+yNu/S5VAG7FzQ/PS+Sk09ZgdD4ZLZbuyIUKBm2h3iEVp0z6h4eiwKeO0jz5cBaRE/W1GsqJD5v2wH7hbPW2jgib3P83OPpgrR/oaM2MtdiyT0p2XUvhfbs1tnhhCFG5lKqmDg4gvv0aErP4T25SKENQ9rdYhsezHw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740329005; c=relaxed/simple; bh=gsZPsEY5OYQwjaN0ui4KqvGSNWWg5CZ6i/qi0o892U4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=YQnK4oGMA8U9BT7Fhl5iLfU8lHl7XNrIX+4nz0iTPFmB/2F1XTGF/YdR8XYkmch4IbbS3CO+4XVsYX2XV9zclX8JOkbj1QX+a/AO6aA2HuE6tm53G06234j+tvOi/JaMSBlBH0TpwUa1jvKvFB56JybMaBmxqhet481VQd6fr5Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ak9knMFT; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ak9knMFT" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-2fc042c9290so5702225a91.0; Sun, 23 Feb 2025 08:43:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740329003; x=1740933803; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tmrxQyU7jDRE4tATauCMPx/rjxqRJrbj6hI/X9rAOQs=; b=Ak9knMFTDdjozMwvBJ86ijEXQhZNRB4q78kk+4l4vpZWYegA2AdY2NOpTAj/t+nFN3 OTB3S7ZNuQoiKOQx+bTGr1WOJ+9yyJupfA1hmUO8JSd/38NcdHnZVONYgsNKnp15tCpt yjgBhgIQ8V0gJgOIvST/SUcL799cyENuuJYsUuI2TmefYUL8ouTXD7ygdFxj+8h6Bgq0 Jm13Oxp1dlKIUvTaNuR25swljuRRrDkUA6euJt3a1QMqH3oKK6qh8UlLutPxEW24G32Q 8TUOmWbFF6en06QS+YzUVV1bwlcvbVERm9rSOuIuHp4Np6NFXY2ClMj0LzMGihv4oT06 2y+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740329003; x=1740933803; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tmrxQyU7jDRE4tATauCMPx/rjxqRJrbj6hI/X9rAOQs=; b=JNJ1XBkXpeVZq2LFlMSNFoCHDMsSd/BU3hHWnoMsVKOVqKLoqLJEbLq5qwe/pjLiON N8+xqfahqIWFLkwKHkOFM/7uZ5g7Aik1x4xZ0Hq0n85DtkAoQMO+jsS35O3WdADiwg3E kSU2M6Bq+wg8GcAhrvDoaPEHWot5uX3eaTuP+8/8FpQaLMgNGl83sgwcR1zSSTs26YNt dKDcAnazTXz/DjeSobEozYEtxOieCFj010nLWY9Jsq2bmkF3pIsBJPk9yJoGUOxMQ8mD zV1ferDtC5Qq1EmhwBtzr6fMenpNpB62Y0Y/sFZ0jCxYY54lACdosRj+OinQPlQ8Vpch kwGA== X-Forwarded-Encrypted: i=1; AJvYcCUfq8NA+qkznQF4NcbVes8vRUvCgf99DEjIPu0zSe09vVDb+8b9LhUWssNNbPAbw8tHjkzEXbtbLUfBdaUX@vger.kernel.org, AJvYcCV1o9DUAndCrYHclR/rEDmTaAoeV1z6+0kF5sDYFZFRGzUT3L2qJ/s2LOB8MunRestBytqBdZ5mpREvd4U=@vger.kernel.org, AJvYcCVVDyaz+b1UFtxre0vdfvFSSENGOz1gYZ9zvQBBrgT+j8D+8f2S9jqexmj+fsdyU++vaTYZdD3C@vger.kernel.org, AJvYcCVqrfQPl2KbkTf+PcdNSBvx2T1f2q+KKRTq6Gg2IMaR1pi0UQosboEESU9yG+1yUQXckA8=@vger.kernel.org, AJvYcCVv+AaysIiAkWwWVecuaWAIItYV6RRQdNhUcvaqmV+MDnfm6xPW5JKAqMTsP+I6+vZaQ/ASM9VK0Ybzcum5@vger.kernel.org, AJvYcCXPtI6/rFI5sV7h2/NdM+fz2QBZ7fOBtCDE43I4308+MitmgmUuQAPY4U2mOogu5WokFIfWi2jN+TrHpAuZz0A=@vger.kernel.org, AJvYcCXxkA8e38m63/fqpRdnK0IK91FcXRQ3VzrMMFwLcfuN87F1IRGF8PjlzA3Q7g6ZsuZxMMXGhtmp4MJVwwM=@vger.kernel.org X-Gm-Message-State: AOJu0YzpBwhHgiCLW07dIP9y88Lffj3dzJW5VaHJ5JxVEnC8vdqVo/a4 3HH4ZyyQJRdLLIuYD09nF9UxJVB/PwuxKE7XI+Ox0Ny56O7No1I1 X-Gm-Gg: ASbGnctcKbadp9Jup2cwi1zxO2hj78cnphkI4M8K073vLiJQfhMp8LiIQAZeQwqJ3bS zv1aXR5sUdK8TlZoSMOIpzoTYjcisrXtktAjWjQT2l24ezZLhoBmAcGsU5RdPLbRzTDOnYmiDjG IEPxuA36e3kreWHZQkWuA96t5jrQ28MIsY7GFq0i/7uTmd7xquUsoNLaB8V4B2nCiWsyOxQOSHK KIozR73DpI9XTLZXzMsUsxHyTAetOLraPgPrW0vvylS7DmTMRc2Thmp/mtVZLMj8CixYEiUdMNS Dd5lSvamk/VKCJCOBZ2MwsJ0Mz4RKkhzC/Sk7dt7XFgE5ggFlb1rF6rt X-Google-Smtp-Source: AGHT+IFT1Vzkj4StFehOYZfGx3Pqek+1r8/xkOZDF3lpptIfx6ywtn9p4F3sEZEqv+n3pwXv0Ec0Og== X-Received: by 2002:a17:90b:5488:b0:2ee:ee5e:42fb with SMTP id 98e67ed59e1d1-2fce789bbb5mr17312586a91.13.1740329003448; Sun, 23 Feb 2025 08:43:23 -0800 (PST) Received: from visitorckw-System-Product-Name.. ([140.113.216.168]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fceb09f6e0sm4935080a91.44.2025.02.23.08.43.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Feb 2025 08:43:22 -0800 (PST) From: Kuan-Wei Chiu To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, jk@ozlabs.org, joel@jms.id.au, eajames@linux.ibm.com, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dmitry.torokhov@gmail.com, mchehab@kernel.org, awalls@md.metrocast.net, hverkuil@xs4all.nl, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, louis.peens@corigine.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, parthiban.veerasooran@microchip.com, arend.vanspriel@broadcom.com, johannes@sipsolutions.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, yury.norov@gmail.com, akpm@linux-foundation.org Cc: hpa@zytor.com, alistair@popple.id.au, linux@rasmusvillemoes.dk, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-fsi@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-mtd@lists.infradead.org, oss-drivers@corigine.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-serial@vger.kernel.org, bpf@vger.kernel.org, jserv@ccns.ncku.edu.tw, Kuan-Wei Chiu , Yu-Chun Lin Subject: [PATCH 03/17] x86: Replace open-coded parity calculation with parity8() Date: Mon, 24 Feb 2025 00:42:03 +0800 Message-Id: <20250223164217.2139331-4-visitorckw@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250223164217.2139331-1-visitorckw@gmail.com> References: <20250223164217.2139331-1-visitorckw@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Refactor parity calculations to use the standard parity8() helper. This change eliminates redundant implementations and improves code efficiency. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- arch/x86/kernel/bootflag.c | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/arch/x86/kernel/bootflag.c b/arch/x86/kernel/bootflag.c index 3fed7ae58b60..314ff0e84900 100644 --- a/arch/x86/kernel/bootflag.c +++ b/arch/x86/kernel/bootflag.c @@ -8,6 +8,7 @@ #include #include #include +#include #include #include @@ -20,26 +21,13 @@ int sbf_port __initdata = -1; /* set via acpi_boot_init() */ -static int __init parity(u8 v) -{ - int x = 0; - int i; - - for (i = 0; i < 8; i++) { - x ^= (v & 1); - v >>= 1; - } - - return x; -} - static void __init sbf_write(u8 v) { unsigned long flags; if (sbf_port != -1) { v &= ~SBF_PARITY; - if (!parity(v)) + if (!parity8(v)) v |= SBF_PARITY; printk(KERN_INFO "Simple Boot Flag at 0x%x set to 0x%x\n", @@ -70,7 +58,7 @@ static int __init sbf_value_valid(u8 v) { if (v & SBF_RESERVED) /* Reserved bits */ return 0; - if (!parity(v)) + if (!parity8(v)) return 0; return 1; From patchwork Sun Feb 23 16:42:05 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuan-Wei Chiu X-Patchwork-Id: 867835 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F62F13792B; Sun, 23 Feb 2025 16:43:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740329027; cv=none; b=uMaYkGl6ghhzLTR1Ete8Xds21m1KkgxBc1M1dbPLLb/J3VZzgJbW0UFx2iLcrmDXhnlwryk90HcXucQ1R7IBNtmE/FaumGO9VOVRAzLwPOJMgPYB41M6tobp6sKrDuBuFWBX/MTe9+3J/LySFIcaqH1viAK+wahyB9sQZVQWybs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740329027; c=relaxed/simple; bh=JIGbdj519hBofglwm1x6Wa4PWHJoF7xJSHZGDTpyM6Y=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=JRnrNiUqwlLf2xLDpNkB1pZV9t/FL2xvbDf/tYLuqZcBha8+rhracb8s8yyVUu2yYfucBDsECKnNK/x67vt91xlMhMl4un00j1R252Bhs9ool78/fg+n/njIhnFsEZ83Mz+PBEQhd5nKOPGHwY8I7OMFNgJNOGBkQ1uHDXXaNsM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IP8bABKz; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IP8bABKz" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-2fce3b01efcso4287431a91.3; Sun, 23 Feb 2025 08:43:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740329025; x=1740933825; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=r0Ho2aCKNYfg5T/o22fFzxZ+UyjSx6Fm0wn6W8o8Gr8=; b=IP8bABKzIVJdlwzWzDVNlmft0o/mQWGbMN/Ur66+5XF/KrJNlzaeuGPkCqXr1sCiTq WpqRpwB09BEkuuwfnp1nWHawlVUFF/jC9+PZ6Oh3iKuXaJRNkEbx6kd2iY0hjGmuISYE tJQcE+81Eb220RWkfMOulirlnntMnBlTPsVTnf2NEu9+X7uK52y/mWz/FFJSAjFKKvgl gb6ie3kvk6fpm+wC0gpWtvMrI0CFE4lvhvwD/oOGsgTTDld85zURF5+IllKdLP4MY0uW J3YVIBUWnmrgL/cX/3v7Q5A4StjeG6t57w15x8SfZSo7LFSotfHtQkgEToSOIqMvKOlf 72bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740329025; x=1740933825; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=r0Ho2aCKNYfg5T/o22fFzxZ+UyjSx6Fm0wn6W8o8Gr8=; b=Aqc95Y72Yc6MFVZSPSF0SjHm5a3aAuc+Y8O2Sak2h8/vI78R+5etr4FboMYFfizypO yflYzh9t9mqNT0QiQPYua9fUhdd7LdJu8P31meuGK09+v9/Nx2+icJe2ela/EUrhbyz1 9i0EYUOwiNnYZ1xJD2LmKwvxqz1GRWLar0Av0XPtQrZ9B9yRTnkv9PYVEj1tDtvnGYAy 7ZXZKacqlNnDE9pw1430LLGKOiHAjyZhBtMJFjWCeyHXnRdhteJNeQUDvRvzh7yrW4KU LXMGC4CIvpLS422qmb/GzkggfliiRUQCVtxPqTdMorGaPS8W2KAr4rm+N/VMV3E5/Z3s gWcw== X-Forwarded-Encrypted: i=1; AJvYcCUHfUj1IqA2snmLgzjPbqbexT827UrGw0WGT9reiey1WMmBFxRrLSCqZDkgw/VUbMmY4HQ=@vger.kernel.org, AJvYcCUVhKLFPq1nQ6jDulijxhkQdVWzAEKRkdjOrI1pvxFqFMqbTHX7wkV5ZFU/FO5R6wzOqRO+IEOd4kKoBio=@vger.kernel.org, AJvYcCUd6HgvYDHfvOYJe+mN5wGw2ig4azVwEFxRaWPD4QiZxMAkuPR8tke/F3ararl+2ZcMhozaCj3vHM3wXyI=@vger.kernel.org, AJvYcCUfRDrswgElYQNG+HbrSN4gzi4gAA9c5AzZIHSJjhgy21F14T9s24slL8vOp5n+TqcWtQwEofkIOsdRVGXEXZE=@vger.kernel.org, AJvYcCVFE94nnmOJE5bdet8ZbdQ5aU/TfbyjvliHZ38SmCfxRr16aqNsE5Ts6hAv+Zt8rPzj6rvIrGxMIXoF/7+7@vger.kernel.org, AJvYcCVtDlKJlSPLH7bl2ARXMYJi5q86O4hD79qecMbrWlkilWQMSbyEfAlPEzCONSwOFAivIPI4TPeg@vger.kernel.org, AJvYcCXr1OOz9Wf4TR5Rkoxy58gewDFwmTeo5ptHX7o0CbzOefE+kMTiwD6QMp/fhqQwzt4evOfnE53JO4h8J28U@vger.kernel.org X-Gm-Message-State: AOJu0Yz7jIPYHaCzC8iipSLTrz5J5xI8C5lOBp0ocLfVJT40CkzEjSj8 koi921Sr+ELBx9aWYqqx3/PQTdVdIZrJBxrSpk9GjDL+/VIiiKjk X-Gm-Gg: ASbGncsa5F9m+aiUdIgf1+F/QQS9xKw2ZobApBXW++K1/5PnCljfXh6QCvw+Mu/tnY1 OBVoeZDqn2nTCxg+nd9fy7CCMsglhre67ZTjMwLHp54Pc7RcwunaSgjQ1K9A4p+48go1a6NETnY 2em8MNffW+xu6sAzsYf2/2gdNvUvWhTlfNz53fp4ldg0c1K2cSPyaAb8SkzTCvsvM7gg7NLv5e8 a35aiGR2Lr60BBy98RQr37noT0Z+aDzTqoAXA6W5jj7eSn9N3KRVVaWnlDj+Y3YXuw7pGhQtBEv Xf0wRiVfLDVDQgmRXBneRCURNQn4HCVsuAa00auSWlhUyj+PS4ppM5As X-Google-Smtp-Source: AGHT+IGVq/VDL8yFNkkrNqMmhpwnPeH21AgiBV1Ypn8QzIpzc6gLajBMUvDiltb0IdO3Sbiytrzwqg== X-Received: by 2002:a17:90b:2e0d:b0:2f2:ab09:c256 with SMTP id 98e67ed59e1d1-2fce7b07205mr19070739a91.33.1740329025494; Sun, 23 Feb 2025 08:43:45 -0800 (PST) Received: from visitorckw-System-Product-Name.. ([140.113.216.168]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fceb09f6e0sm4935080a91.44.2025.02.23.08.43.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Feb 2025 08:43:45 -0800 (PST) From: Kuan-Wei Chiu To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, jk@ozlabs.org, joel@jms.id.au, eajames@linux.ibm.com, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dmitry.torokhov@gmail.com, mchehab@kernel.org, awalls@md.metrocast.net, hverkuil@xs4all.nl, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, louis.peens@corigine.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, parthiban.veerasooran@microchip.com, arend.vanspriel@broadcom.com, johannes@sipsolutions.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, yury.norov@gmail.com, akpm@linux-foundation.org Cc: hpa@zytor.com, alistair@popple.id.au, linux@rasmusvillemoes.dk, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-fsi@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-mtd@lists.infradead.org, oss-drivers@corigine.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-serial@vger.kernel.org, bpf@vger.kernel.org, jserv@ccns.ncku.edu.tw, Kuan-Wei Chiu , Yu-Chun Lin Subject: [PATCH 05/17] media: pci: cx18-av-vbi: Replace open-coded parity calculation with parity8() Date: Mon, 24 Feb 2025 00:42:05 +0800 Message-Id: <20250223164217.2139331-6-visitorckw@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250223164217.2139331-1-visitorckw@gmail.com> References: <20250223164217.2139331-1-visitorckw@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Refactor parity calculations to use the standard parity8() helper. This change eliminates redundant implementations and improves code efficiency. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- drivers/media/pci/cx18/cx18-av-vbi.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/media/pci/cx18/cx18-av-vbi.c b/drivers/media/pci/cx18/cx18-av-vbi.c index 65281d40c681..1a113aad9cd4 100644 --- a/drivers/media/pci/cx18/cx18-av-vbi.c +++ b/drivers/media/pci/cx18/cx18-av-vbi.c @@ -8,6 +8,7 @@ */ +#include #include "cx18-driver.h" /* @@ -56,15 +57,6 @@ struct vbi_anc_data { /* u8 fill[]; Variable number of fill bytes */ }; -static int odd_parity(u8 c) -{ - c ^= (c >> 4); - c ^= (c >> 2); - c ^= (c >> 1); - - return c & 1; -} - static int decode_vps(u8 *dst, u8 *p) { static const u8 biphase_tbl[] = { @@ -278,7 +270,7 @@ int cx18_av_decode_vbi_line(struct v4l2_subdev *sd, break; case 6: sdid = V4L2_SLICED_CAPTION_525; - err = !odd_parity(p[0]) || !odd_parity(p[1]); + err = !parity8(p[0]) || !parity8(p[1]); break; case 9: sdid = V4L2_SLICED_VPS; From patchwork Sun Feb 23 16:42:07 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuan-Wei Chiu X-Patchwork-Id: 867834 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1FBC13B280; Sun, 23 Feb 2025 16:44:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740329052; cv=none; b=quE9H6VSbGUZwCWVZ7RZ5THHReQ+dfcJaaY0C/UpiydLo5wYKOHokdXBLUhv3KWOtH3wptI51XhPiy/aYNZ04h9zZxNuJCVHJmGlcTBo64azW3MOTasLIlLbZlhsV47nIMBheGaAVKJI5/IwmQQyY6TWfC/lUcmNFwc9M4uK+kY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740329052; c=relaxed/simple; bh=CbnMmjg7M9xhIhYb1IB6TOhn8N272SVk7DyDeXjNNRE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=LARos1UeyvQduEK6ludAmGLbqekplNefY6AS5yOt6/hFTO6dofALwXoKjKrkO7ejTJCVZ/TixivCKLXXcK9QvABtC2bBVFZ1Lcni5/DO94CBi8evUBwNfDpTsJ3+j6Agew2QTRDWg9MtZ6FC2VN2y9J2EsScXrMeflhGYP0UOI8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HbRdQ1Q+; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HbRdQ1Q+" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-2fbfe16cc39so7380189a91.3; Sun, 23 Feb 2025 08:44:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740329049; x=1740933849; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1hjFHt0d5k578dEe7TlBSwZUIRnR5xMHf3Vffd2Ioq0=; b=HbRdQ1Q+GdmZWRzMcJxD89urrBFY9zS9UDqV4jQgNWcupAYtmuStige1fQV88Vz3U9 pNoAsF8A5uONFoPNVeez+Ex0AeQwxI76KT86kZWRRHtGeMD3rf6av461N9rfUotVoeDa vXkkPwOObp/Gp25xposvXvApYKUhTgc5xmhVY91RXYvvbmzT3oa5hQb9TsfA6H+seKmO ntV9WGo2dS5U+Eu85DsIMCz8+PLoFrA7510gA52ldKr0EGuvlWTpsHTaViHqrlWfd+YL 4sF7vPXfZL0izTqJ5cpabyljhfw1vdW0Ioo3jG30/paAEc/FDkDGzkH+1YPvcT7pDacm viRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740329049; x=1740933849; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1hjFHt0d5k578dEe7TlBSwZUIRnR5xMHf3Vffd2Ioq0=; b=HYACTSRRr25PAVretGsp/gYi2OcjovPzqFJRwdLnd12ojuhVix2+9AO1sbGTBLW1xk 6HqTlXajKwGvNgTO8iWWHcyyfRx8aX54awsbBP0UVsTYn35iY6P/Nrgpp+P/S7Akudm1 LUaIFxgnFL/i4WC/9DQQypoKvAU3j/YDsITUpWp6XfpCWgQtNxcwVUaIz0EUtA4BdTHF Z6usMy6X/vhxaMvW2V+Xh4U4pso1eTdiD/Zjv5ZKExdiyd6o+287jHk86vdBAMQv9GzZ 2Hmv651PpE5Uf9gwlWV5sxzdUpNP2f1GsqcxF4N7ttnxndkBcZ0tqvQ++Lc0ul/uEyRo 7rfw== X-Forwarded-Encrypted: i=1; AJvYcCUwLFaxnMiZspWd2e4Stuum3qlcY2yhqjXvuQ4lj/3jKp1F+ExkxHzR8IQa8Lhl4ZKYi5ThRMO0bwfhuQUl@vger.kernel.org, AJvYcCWtBAQ/VVF3p6YoaxFO6fP9Ov/dar46dJKwasMUhC+nV0VIVK3YLbtUvIK8r7vF97x5Lce/NaMGqwyv1oI=@vger.kernel.org, AJvYcCX6WvJTFcPcFFcCb28CDo4XKiONIyj9LS7cohLAbKpzdDAyK9WwUginw3pzEp/4/0Wdtw/GgfM+lA35ATS2@vger.kernel.org, AJvYcCXFTmz92ycJvLCEI4Dw986uEGTO1efApiYCVcx5XPhV+QjaTsvb4/+nBWnbul8fXTOwuvy5yrWtdVbnutCUakY=@vger.kernel.org, AJvYcCXjzUm6cNQD1cA3e7Q2bJSvyVqTb+98XPMzfsULuLodFQsktR7eL1wL7Erf+Br4w2TcY44=@vger.kernel.org, AJvYcCXqVArIe0+HeLr+4vYcguWFrc9sTaKCXnj3XYpAV47TkreQ8wzp0vqpWUZxp4XRow+ua1VWjC/d+qpr2A4=@vger.kernel.org, AJvYcCXw2vthBr+k2sQ4F0mMSg43ZUBGd3pFtPFNXEcwocn8A/oWD0apG7kymqSx7lKxO6Ab4Ilk0vyj@vger.kernel.org X-Gm-Message-State: AOJu0Yy/WwoEmhP9+QhEmaEoDxReCFbw+BgoC3Bf1ZuuGwmhS8QH7MDe m7uotx7KWG6JGBl5utLEv4d61Z1ZwNy5aFz+rc7TmgVuvskurK4C X-Gm-Gg: ASbGncteE7DhFci1B4hSeJI5RaBwHA/Pc53YZohcSQ568oh5WeJZF800JGQy+VPEb5v heojLglHVI1rsJXXZA9sV7rNCdvBOTQxouRVfEjKNnIFEAO/JuYU6Z2OiqDn6LCYU1gakB5TfDj t+ymoxQ98t5K2viCLSD8d/gQbM2fF+e4KfSTQ9K3qLzF/1R4PTYHWFK6zuaiVOEhv3dTkJ1w6QJ 2JtR7jVrz0mQnWEp7f/JgsRciE7Ix2MixeyohTO08S/PMafuC8GSqtMVIIU2eqYPRw5ZL8V/kbD wi562rZ2vgm0ckVZL01VqJhy9cGVJrgkdbJ0J2KeLC0Zfp9mTfibFaw6 X-Google-Smtp-Source: AGHT+IGfwHShsfiPT7dt9SjKmid9dTaP6+iTVws9nn060cC+xpKYlrmp1TQEmd1LFjVUXo+AvslnXQ== X-Received: by 2002:a17:90b:4f4e:b0:2f9:c56b:6ec8 with SMTP id 98e67ed59e1d1-2fce86adf4emr17900240a91.10.1740329049260; Sun, 23 Feb 2025 08:44:09 -0800 (PST) Received: from visitorckw-System-Product-Name.. ([140.113.216.168]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fceb09f6e0sm4935080a91.44.2025.02.23.08.44.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Feb 2025 08:44:08 -0800 (PST) From: Kuan-Wei Chiu To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, jk@ozlabs.org, joel@jms.id.au, eajames@linux.ibm.com, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dmitry.torokhov@gmail.com, mchehab@kernel.org, awalls@md.metrocast.net, hverkuil@xs4all.nl, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, louis.peens@corigine.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, parthiban.veerasooran@microchip.com, arend.vanspriel@broadcom.com, johannes@sipsolutions.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, yury.norov@gmail.com, akpm@linux-foundation.org Cc: hpa@zytor.com, alistair@popple.id.au, linux@rasmusvillemoes.dk, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-fsi@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-mtd@lists.infradead.org, oss-drivers@corigine.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-serial@vger.kernel.org, bpf@vger.kernel.org, jserv@ccns.ncku.edu.tw, Kuan-Wei Chiu , Yu-Chun Lin Subject: [PATCH 07/17] serial: max3100: Replace open-coded parity calculation with parity8() Date: Mon, 24 Feb 2025 00:42:07 +0800 Message-Id: <20250223164217.2139331-8-visitorckw@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250223164217.2139331-1-visitorckw@gmail.com> References: <20250223164217.2139331-1-visitorckw@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Refactor parity calculations to use the standard parity8() helper. This change eliminates redundant implementations and improves code efficiency. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- drivers/tty/serial/max3100.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/max3100.c b/drivers/tty/serial/max3100.c index cde5f1c86353..f5c487bdc56a 100644 --- a/drivers/tty/serial/max3100.c +++ b/drivers/tty/serial/max3100.c @@ -16,6 +16,7 @@ /* 4 MAX3100s should be enough for everyone */ #define MAX_MAX3100 4 +#include #include #include #include @@ -133,7 +134,7 @@ static int max3100_do_parity(struct max3100_port *s, u16 c) else c &= 0xff; - parity = parity ^ (hweight8(c) & 1); + parity = parity ^ (parity8(c)); return parity; } From patchwork Sun Feb 23 16:42:09 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuan-Wei Chiu X-Patchwork-Id: 867833 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7AD11531C1; Sun, 23 Feb 2025 16:44:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740329073; cv=none; b=OueqQ6RorAyDLuhAdVwG0RiB8xX1OUNr2xYDq7b6CfbD4K0mG8IEmfaOOvLnfC8kIHiGqIjU8UaE0dQB3leX1rqiVmP1r0Udarzb15t9u2Z5RdQJhWo+IIWAF10ammFKHuTKF97dHLEfFy0XC9GkzT8NCFr3ksNRR79YA7QY7D8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740329073; c=relaxed/simple; bh=1i40o1s3Vqdk2RW0JIo3piubrRjz0Cy5aa5u5siB9VI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=dkYtLeQFPDppvDtWI+YL3eQl0EM9nVbjll91kFCR420UyXJ0nYep0jvKpgVCrver4l8oG97wlX+wBLOITu+DJ02TamoG6FFmXiAMseFG0b7Mfuc7XuwZhlZ2Ew5FyY16IffldNwjN6riEn5rs+ALoebkulW2MP2Wusr0dksxJCE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XRhAXjA7; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XRhAXjA7" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-221050f3f00so80332535ad.2; Sun, 23 Feb 2025 08:44:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740329071; x=1740933871; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=U4Bkihj4DGACHQctYAnhtp6nEz1RGAPDBfirVsTzUzk=; b=XRhAXjA7GIIjo/so54SLubNoMOdOEZ9HRBxyABKpkrXMVKgpv9J/qMsgDkdSrvWsQq z8X6Xw2Fr4BmTw7yjknPdPBPLvRVFaS4OeVxbaUHTyH5CoqhOP3kuROPkc5r5wbtkBsl m8+dnb5aoREz+oD+KweFJ87ZwyvwN3pJKCUKd/wFc1KqGilDubXqe2pc3yeh8KUi3/uD qX2KOds14Q4KWM+V8BwawX9RkHfbQDKWeIg2QNWfAShfPHEyqbvd1RJ2k6SSlwSYio67 aY/3QyVeWPFvWLilP9nDXHz07e2YSNRBwoHQGi3K/F+I2Q/J++QNMV1Jmn0PnwBcIcSu m0gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740329071; x=1740933871; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U4Bkihj4DGACHQctYAnhtp6nEz1RGAPDBfirVsTzUzk=; b=IKEuV4CHwzfntAWgP5fENz4d5bwZrx/7rjkGUN8zItkJhVdM33T9EvBvcIBRExNiXx AHXGMIY/8JyWV6+rAWvOPhNzaabAhdJsQjzJWmC9cipnlOcdSr79hUp/ooe+FagE6nXH JO2rxftBmyCpxfdkkS/ehoIB/8V2JXCYWja9/Te5UGdhABr4wNELhoHXHpMIZRG4FTBN 68Gpno9u7Fyxk4SVLKo+wXMuMwuVqPZCIl2/mja/r6LGZLRcBGlw7+j6bq9IIzyR7HXw vNac2dHND1ZaD3h7LLo+qtjhrKTbpfk5iTFH9ujYr1W1+aoTsPvFawyPaX0/9WZdcGno cL1Q== X-Forwarded-Encrypted: i=1; AJvYcCUDomqQnCRtSw/qLI9ZKpSp0r3A580v4t3okMU22EY5YZzfmVKVP7sMSmRW+OKjI11raDs=@vger.kernel.org, AJvYcCUuQRBqo3tjVDbfPJ/Q2uk5ovCEdrBXS0tDER8/+G+gcTZfdSyuWfrUeF4fg2ojE/gljWMU4lW4@vger.kernel.org, AJvYcCVIZDq7Ar3DDY+H2MWNtvhBikMQRZGPS6oEIfKdjLMC5JzQ6tUZkrOHZ8RPy7c+Vqhxa3A6cg1M5C+hIXCU@vger.kernel.org, AJvYcCVhjCxSGJaAYWzhavLlabHvIS7dXz/MJc3tcsipfJcTJL3wxk4MA0RB5sZe8FoUfjw/so7ryaPkwuKffCk=@vger.kernel.org, AJvYcCWJ/Lc4Abzimi0d4PElNWrrG1kGVNi9ntpoPfIpVN7uMDus6fBqiYAW5cxn8ryW8XEn7znOqJI/sMYHxfPd@vger.kernel.org, AJvYcCWwwUWLiGEJFVjv1Rac9ItWtBRS+mT0/n/TN6y3XkeZtxRJJBxkMpRgYJcU3rIDj7Wx72t1YE1nTGmbhwaqcpA=@vger.kernel.org, AJvYcCXdCxQUmPw3lTjpuxypsr/RhhxlS8leRjY/JRLiguRW3S5BR3DRuwMajlMyXCtKu4J62p0LzsUHtyH6IIk=@vger.kernel.org X-Gm-Message-State: AOJu0YynK9uJnyb2pOVQxvq/Jafk8DqnLRk7TjWJL7ePvSof9Nv8OiWw YoBDwefppytUvwOD9vx+oen3kUOnTu4RdmhN04PfPQTQNe7tgoL3 X-Gm-Gg: ASbGnctnXnCvn/Qz7lWFOjRrM8YNXxT6cGVOxK1D0BJv+U/bcN3VuRtqwtmL7kOCRRA NrYf6dXQ0ti9LfPqzuAZWgacs4apEZ550Mmm7HaV0RpAVG+NBQSB0WP1ttS2aFJKnUFCBt+XaDb ZuhUpTvAF1vgJuNPPJeVb4hLDV+oKjHsqsYWw7ceucAbPBsdCP95CBwUvr/6DHUbI+HMh3LI1S5 R1QFhu5ZPO2ugdnThFxSz2SxV3zmlJlA9RMrNWNbKoXEILY8NCJi3JCB6A393BzqKWawBf3TTGm GyMrkPvYqlhH2ov5eiGaaVNTlG0r2fLilGSEHf8GwJnKiMY6GSiYCSfp X-Google-Smtp-Source: AGHT+IFqMPtN+gPmr77Z5+UXqcepcxQO5H8AaDoUEcywHGCumZ53dM6PMFmuD7xMrlzO6YmaaybKmg== X-Received: by 2002:a17:903:2286:b0:220:cd9f:a186 with SMTP id d9443c01a7336-2219fdc2dfcmr186405365ad.0.1740329071014; Sun, 23 Feb 2025 08:44:31 -0800 (PST) Received: from visitorckw-System-Product-Name.. ([140.113.216.168]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fceb09f6e0sm4935080a91.44.2025.02.23.08.44.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Feb 2025 08:44:30 -0800 (PST) From: Kuan-Wei Chiu To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, jk@ozlabs.org, joel@jms.id.au, eajames@linux.ibm.com, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dmitry.torokhov@gmail.com, mchehab@kernel.org, awalls@md.metrocast.net, hverkuil@xs4all.nl, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, louis.peens@corigine.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, parthiban.veerasooran@microchip.com, arend.vanspriel@broadcom.com, johannes@sipsolutions.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, yury.norov@gmail.com, akpm@linux-foundation.org Cc: hpa@zytor.com, alistair@popple.id.au, linux@rasmusvillemoes.dk, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-fsi@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-mtd@lists.infradead.org, oss-drivers@corigine.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-serial@vger.kernel.org, bpf@vger.kernel.org, jserv@ccns.ncku.edu.tw, Kuan-Wei Chiu , Yu-Chun Lin Subject: [PATCH 09/17] Input: joystick - Replace open-coded parity calculation with parity32() Date: Mon, 24 Feb 2025 00:42:09 +0800 Message-Id: <20250223164217.2139331-10-visitorckw@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250223164217.2139331-1-visitorckw@gmail.com> References: <20250223164217.2139331-1-visitorckw@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Refactor parity calculations to use the standard parity32() helper. This change eliminates redundant implementations and improves code efficiency. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- drivers/input/joystick/grip_mp.c | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/input/joystick/grip_mp.c b/drivers/input/joystick/grip_mp.c index 5eadb5a3ca37..897ce13753dc 100644 --- a/drivers/input/joystick/grip_mp.c +++ b/drivers/input/joystick/grip_mp.c @@ -18,6 +18,7 @@ #include #include #include +#include #define DRIVER_DESC "Gravis Grip Multiport driver" @@ -112,20 +113,6 @@ static const int axis_map[] = { 5, 9, 1, 5, 6, 10, 2, 6, 4, 8, 0, 4, 5, 9, 1, 5 static int register_slot(int i, struct grip_mp *grip); -/* - * Returns whether an odd or even number of bits are on in pkt. - */ - -static int bit_parity(u32 pkt) -{ - int x = pkt ^ (pkt >> 16); - x ^= x >> 8; - x ^= x >> 4; - x ^= x >> 2; - x ^= x >> 1; - return x & 1; -} - /* * Poll gameport; return true if all bits set in 'onbits' are on and * all bits set in 'offbits' are off. @@ -236,7 +223,7 @@ static int mp_io(struct gameport* gameport, int sendflags, int sendcode, u32 *pa pkt = (pkt >> 2) | 0xf0000000; } - if (bit_parity(pkt) == 1) + if (parity32(pkt) == 1) return IO_RESET; /* Acknowledge packet receipt */ From patchwork Sun Feb 23 16:42:11 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuan-Wei Chiu X-Patchwork-Id: 867832 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47CAC77104; Sun, 23 Feb 2025 16:44:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740329095; cv=none; b=t1k/RKmPkURetcec5XnSDMp27wrDcgXCg/bfXLc1pmV8jQWKTlPyeq83R8gXmF/aRXndBbf5NtmN2fAs6la+DHUFDKwrZguPBfW7vAwSzDc8QgbFgYMUk9p+I2Vk9p3i3CcHOQ0Keld7CRqO/4TvXa30ET0XO90tr5QHvZsENs4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740329095; c=relaxed/simple; bh=v3VP9b1b7CvlBsixzdFcwOQjjl2Hrulp8xfqmv1a5yY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=BOuu86/zdBVQBB8Ke2boeB2Udj/eXnSYd1d8OX7bKzZKm6RWkMCKpV6hT9fLpd+v4MqUc94OPUAzqBDyOu3hbWYCyj0Z1zBsoxS1ygQnjlmvEtNylhlbwLSzcREXlpcF+UyhTExwkWuVUDHrVCoih1llVAbqBD6hxsQcCk0Z9SA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CVM8wdUg; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CVM8wdUg" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-2fc0d44a876so5833219a91.3; Sun, 23 Feb 2025 08:44:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740329093; x=1740933893; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0/rM0c8KAofiqOH9E+BbTStqrJdKUl6Z4Ta9tU7voiA=; b=CVM8wdUgcjml+AFsid8GHXhJ1Fttyq5x5xVEEJpe6g9Z4/siHaUkOn/Obik7Khta0H sX6E6VV2QsGR1lek5fm+qMKW0dt3vy82f2csSs84ugk+veJ25SbEy/SdA22dhyJt9YKy JTvcveEetBbs5Fsp5MMy1YY1eP8UGpBxslnB7s21PDSmJEmFo3Fk3WfXqADnU2QvGqzf dl82eM/uKHjxX8lhGx0AUZcoKvzVwvvB8rUnbFk0VaPmoyFuB6JIGPc8VJCAMJ+2YEnH 7fycycD8fp3HfyyCmN5gZ+eSoRK4exkzf+mB2VHm+fyK82CVhakQ0EfXOnaxGq99eUWD tYSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740329093; x=1740933893; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0/rM0c8KAofiqOH9E+BbTStqrJdKUl6Z4Ta9tU7voiA=; b=dGb9uavk+QeI5e+Q4ggASBKNQWliHf6czd8Tzo8xJxfhp1h1IOZm5PhmO/KaiZ5WmT aEhuvgAFAbaIyVQwE931qi5pTW2sCd0T0BExjjy0dRtcnHNumNqMtulWFeDbib0Q8/AB Egcg3WGTzwYCMZwJTX6JLYHhBqWuKAFFfEvuXKYCZcLDNq/GjKButf3JrkEUddeKcXAL fIbAnUCNVppmhiPqTYgn8+7mLtpWVbU17P/Cfxahurlz1YS8nIGmqv7+9YY870Zxuxo9 Xs3pj+xf+D4ijGNIR68trU7qvBEM5dylBPEvtxmYVsr9XJK4Z6JOd4iNDVV9gnjciFQ0 nNMg== X-Forwarded-Encrypted: i=1; AJvYcCUZk3moQx45JlR3KWEsdENEQ1cy3kC5k8lMTshzNvLkyYRukBMeR8Lct/JttuWEcdcSnAARcKvI@vger.kernel.org, AJvYcCUyvpPilvOkZbAeZhuwes8D5WOamSoyTuVjx41kEiNI8nja3w7V03reLUwVnEIB5Ep4HGzxgL9BbO1Jqfk=@vger.kernel.org, AJvYcCV4faCZXislByBoydXdkCKJwN7/PAjZULsNaEGg+5ixQQsmiHgp48XVIgbtcmL/UXtnOTG9wcnZdDcCHcfX@vger.kernel.org, AJvYcCVMuHhHR4ZJDwZLOkSfjEvkkA2zbvArwkf4Q1qB3gCauF/QMlr+uLN084MrjU4A7cvtSZ8=@vger.kernel.org, AJvYcCWbuYmtW9u2L8mXov0Q4iu6e7RWAkWD3RXcfE6DvblStfdYs1Do5SvIWrHHlAWwGi/YUszp4sQYsrLZWVciJlw=@vger.kernel.org, AJvYcCX8VujuUPq0WflFUqbFM5NTtt/mfFmiCzmnX9wTCY4JAPTRqpUFL0xZVooFiRfj8YSibPyhRY1AlZB94KM=@vger.kernel.org, AJvYcCXXrcmkN3/pylPS35S54YjbXZiemnVJC+vPWY0wPtOO/5CMIQzHkZbz9PObWuxajTp9ipIfczx6bQSrsd+t@vger.kernel.org X-Gm-Message-State: AOJu0Yy1Hq2H1Owgdjvn3r6eKf+wdtSMyqpJ0gyv7vbAuI6qF71Kuo/W rp4/O0jStRlPGVZsgbSeMwFpJoGyRSx0DhIJXzgkk3JQN3d2rTk6 X-Gm-Gg: ASbGncvoJ6ohKiWe13qE9R3fSop+CtsluHE/z616ANycbk9yExPmie3ugXhGePuvShl /zlWZvDw4T2Fj9/yaOTIrinPe12Ld2A1kckPQCcz3cbkIjt3iFhPdWRllcpf1qwYFkXezuUOFyl 7+oy+dPQJl2TYc3NOLIiBJa0kCpjmHgF87ncHfd0aF1Ej3ClmfiW0ypfHQvv31Fo3h1XBRjsizC 1VdRzEHhzs9BKDMWd+hTvkZ50YfysDrckQc657jFCBj2XD3QRLbDSsJr0pAowG6hkIYTpsIisD5 d7SgBk4/lFkMNaAyun2ludFZ1KUuOXQusWm5k91HmHP7QRrSJ6E4/lYT X-Google-Smtp-Source: AGHT+IFyGSvrJM271swgjLlCi2TwHZU6y12ME2N9/TuoQb9IugR13IQRKyCWyxRNE+S6ruhpAiUUqQ== X-Received: by 2002:a17:90b:2b8f:b0:2ea:3f34:f194 with SMTP id 98e67ed59e1d1-2fce78aab09mr18428370a91.10.1740329093592; Sun, 23 Feb 2025 08:44:53 -0800 (PST) Received: from visitorckw-System-Product-Name.. ([140.113.216.168]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fceb09f6e0sm4935080a91.44.2025.02.23.08.44.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Feb 2025 08:44:53 -0800 (PST) From: Kuan-Wei Chiu To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, jk@ozlabs.org, joel@jms.id.au, eajames@linux.ibm.com, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dmitry.torokhov@gmail.com, mchehab@kernel.org, awalls@md.metrocast.net, hverkuil@xs4all.nl, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, louis.peens@corigine.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, parthiban.veerasooran@microchip.com, arend.vanspriel@broadcom.com, johannes@sipsolutions.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, yury.norov@gmail.com, akpm@linux-foundation.org Cc: hpa@zytor.com, alistair@popple.id.au, linux@rasmusvillemoes.dk, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-fsi@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-mtd@lists.infradead.org, oss-drivers@corigine.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-serial@vger.kernel.org, bpf@vger.kernel.org, jserv@ccns.ncku.edu.tw, Kuan-Wei Chiu , Yu-Chun Lin Subject: [PATCH 11/17] wifi: brcm80211: Replace open-coded parity calculation with parity32() Date: Mon, 24 Feb 2025 00:42:11 +0800 Message-Id: <20250223164217.2139331-12-visitorckw@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250223164217.2139331-1-visitorckw@gmail.com> References: <20250223164217.2139331-1-visitorckw@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Refactor parity calculations to use the standard parity32() helper. This change eliminates redundant implementations and improves code efficiency. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- .../wireless/broadcom/brcm80211/brcmsmac/dma.c | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c index 80c35027787a..d1a1ecd97d42 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include @@ -283,21 +284,6 @@ struct dma_info { bool aligndesc_4k; }; -/* Check for odd number of 1's */ -static u32 parity32(__le32 data) -{ - /* no swap needed for counting 1's */ - u32 par_data = *(u32 *)&data; - - par_data ^= par_data >> 16; - par_data ^= par_data >> 8; - par_data ^= par_data >> 4; - par_data ^= par_data >> 2; - par_data ^= par_data >> 1; - - return par_data & 1; -} - static bool dma64_dd_parity(struct dma64desc *dd) { return parity32(dd->addrlow ^ dd->addrhigh ^ dd->ctrl1 ^ dd->ctrl2); From patchwork Sun Feb 23 16:42:13 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuan-Wei Chiu X-Patchwork-Id: 867831 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A27F4157E88; Sun, 23 Feb 2025 16:45:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740329117; cv=none; b=jrnJvHqZ6J295+2Digq06Y0ThOQif0axVvAvwFpmK/qV+N8+1vTpQ6r0Y/gidgEbVMlBmMAasmoVGx3nGWQOhil2GhJlkqykQoxx4zUM5t6mTevRz6kWMP/zdwdu/9YLLYsA85e9nPEVgeXtzeG3WcewTtdeaZyl3KkuB6zaqtQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740329117; c=relaxed/simple; bh=ZR7k7WuXjWgoiKosaPdwElgny5Md8dRLy7kh+y/t7/4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=pAcMZuvattZMnP1WsrCOrYkpAjrl+0b+vksnsPSvPlk4uVpbZFpVizsaMe/0kg93/Avnjfe8OLSDqivjdxH0KHSv9+c/J8hM1YaTShZGBGx5bzHyIKdRPFeaFs5RlS1n9AqnJHk5y9ncvWivB+77UWhgQXo+64IT9tTP3Bz4IN8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Kecdzp54; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Kecdzp54" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-2f9b91dff71so5518703a91.2; Sun, 23 Feb 2025 08:45:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740329115; x=1740933915; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=M0fPaIWjdscIdDk4T1YIhhdJwaKRFyAzbGum2CZXkTo=; b=Kecdzp54CjErVHVKs0eq0Kgpq0rNxPJpXict9Ak4VppT1lBU90wzThiO+kXKMaB/pO A35uUtjHme6ShFS9bMxNEe3RgWFs1nF4FaUcAtZxPereEt1u7v9jzwJHSppslI/Jt6kG oraiW1VOrizSR/+oDadm8NwH30/IgmtWUwAb/Oz+1bKCEcpOK/f5+xUHX96bOBj3PyNl oNmo5ENhg6jb2euY2/OskjCMkaFw1VzfXcO/EEy0L610YGWuyAWWihdE/wIgWXiXKND1 IKE/rLUCtgwPkKl/0eBZK6vlRW9tNzI8HbxPhz3z2/GqL1crB3mZ/xjScxXzqKkb7uqe QtfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740329115; x=1740933915; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=M0fPaIWjdscIdDk4T1YIhhdJwaKRFyAzbGum2CZXkTo=; b=xN7SZF+6QVyd0W9n9L4GtVSNVqMW1ukS9M42OV7BnJKUYOuynf8mAe52WVyfV5Ri6k Il3x3LB9LZS0GujxKxTBz8wZQ/EVX48wVZm92LYn1UKuzGtvnFByy7E5yBLsGvLvmK8+ dZTdX9VewaYMbrIEKzI5U5Wpeza0tdD+SLvxip+KYytP+M/4NEaJa91w+XsnN6VM4UUM 4IXZrduy0hB0IlEZ7t7bnN2InUVAOqv813EPEgFzOq8nUwF2zitYkil7t1OoY/1Exja1 fDP4s6SgoLQJ/fmNLkY2dZmjGETdb3kALpxP1bs6R1Yi+T9UFp3hiXAoF0FgP+U9pQv5 /TUA== X-Forwarded-Encrypted: i=1; AJvYcCUNeZOShh4o3sTAQRwpHh3AolTt5M47WXrplGBE3h9zJ0N8jNQKf7RgnhEXvK6gryLE9qtNl35mheHAHAo=@vger.kernel.org, AJvYcCUjuL9UMJ8rFUhVqB6jpd+RalTOaMuLS3UK+FxlY+7NipqXy3I298T4tECiuXsGC1eN3S4TtQr+7gATD5hI@vger.kernel.org, AJvYcCV+J8NNC+rTIXBj2w0dyyLwejJL6l8KRsPsQdM74pDfkmuYaJOsODWC48UWss2CUr/0ien32y6y@vger.kernel.org, AJvYcCVESlNrh7bZPZuUmHrOiKhTddwVODBqXmRaAl0ynytSP4zCYl1vZGp9nXl4JtPWtmMz4TB7ms00Ue3BsQM3@vger.kernel.org, AJvYcCVKfkGgfXFG3V8ad6sH7pPR4pv7nYp3SiIUSmkGH7nKHtRApZhSTDxdMPWeVW+G5v2rzrl4eFynklFzwBI=@vger.kernel.org, AJvYcCVrpFDeVULZKkj7Gv7awRNPXO364bY1mGje5cI/nA9yCScnRmLV/1YP3yoDvcflM+bEBXM=@vger.kernel.org, AJvYcCWDsXh2ATtLgLxUnTuyqcKEZi4Leqg00Qj9Pln1Jy6wwM3C4odGO4uBEUF8G3/wz1qHSN4MjKbXUup61fvS/cs=@vger.kernel.org X-Gm-Message-State: AOJu0Ywznh54PHGrTVIPWIhy4FaJsJUgM+e65ltze5PJqynKzPok+2Nb moBu9TvbVszP8tdkR/qCP5sZ0BLDePnnWh7cTI3Ul99PxOYpFcdq X-Gm-Gg: ASbGncvnwLVnhrNgwXBAXYHjxXA9AVWzFtqVTqgKiowBHjVKIzcczPhF7IvB3CeOplM o6aytYrMciR/HIQjYgr0zlX7ej0MJ/JcrIUebpMUfM17Hu4XvKPFmDcUFf6UQ8rZ8lBQWOR6lJS GbTZQGq+ALH5Hacegb27Rm/Y7bQ/LrC8QNbitZ9Sjkadg0LtZlmFGz82BeCjhP0PLCXHQOvRATF zhOb+m2n2R0QUO3yUPha9VnQSLLi0YNgawRTPlyXcFhSXaHeJ91A3zwPn7vxWV00qB/mvgq/xIr AHaEzu3cSDqKTvMemho56fdfV5iWQ2+axDlmmm9ib7zfT6aqJjPM9BFo X-Google-Smtp-Source: AGHT+IGRfmJ1JykXVI/nOn1hWPryN6XcmSxHhj3JPmFZZoIcxcyuC/O0UeP8Z39VhK9JcSyFdzE6jQ== X-Received: by 2002:a17:90b:548c:b0:2ee:c04a:4276 with SMTP id 98e67ed59e1d1-2fce77a4863mr16234632a91.5.1740329114693; Sun, 23 Feb 2025 08:45:14 -0800 (PST) Received: from visitorckw-System-Product-Name.. ([140.113.216.168]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fceb09f6e0sm4935080a91.44.2025.02.23.08.45.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Feb 2025 08:45:14 -0800 (PST) From: Kuan-Wei Chiu To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, jk@ozlabs.org, joel@jms.id.au, eajames@linux.ibm.com, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dmitry.torokhov@gmail.com, mchehab@kernel.org, awalls@md.metrocast.net, hverkuil@xs4all.nl, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, louis.peens@corigine.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, parthiban.veerasooran@microchip.com, arend.vanspriel@broadcom.com, johannes@sipsolutions.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, yury.norov@gmail.com, akpm@linux-foundation.org Cc: hpa@zytor.com, alistair@popple.id.au, linux@rasmusvillemoes.dk, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-fsi@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-mtd@lists.infradead.org, oss-drivers@corigine.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-serial@vger.kernel.org, bpf@vger.kernel.org, jserv@ccns.ncku.edu.tw, Kuan-Wei Chiu , Yu-Chun Lin Subject: [PATCH 13/17] mtd: ssfdc: Replace open-coded parity calculation with parity32() Date: Mon, 24 Feb 2025 00:42:13 +0800 Message-Id: <20250223164217.2139331-14-visitorckw@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250223164217.2139331-1-visitorckw@gmail.com> References: <20250223164217.2139331-1-visitorckw@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Refactor parity calculations to use the standard parity32() helper. This change eliminates redundant implementations and improves code efficiency. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- drivers/mtd/ssfdc.c | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/mtd/ssfdc.c b/drivers/mtd/ssfdc.c index 46c01fa2ec46..e7f9e73da644 100644 --- a/drivers/mtd/ssfdc.c +++ b/drivers/mtd/ssfdc.c @@ -7,6 +7,7 @@ * Based on NTFL and MTDBLOCK_RO drivers */ +#include #include #include #include @@ -178,20 +179,6 @@ static int read_raw_oob(struct mtd_info *mtd, loff_t offs, uint8_t *buf) return 0; } -/* Parity calculator on a word of n bit size */ -static int get_parity(int number, int size) -{ - int k; - int parity; - - parity = 1; - for (k = 0; k < size; k++) { - parity += (number >> k); - parity &= 1; - } - return parity; -} - /* Read and validate the logical block address field stored in the OOB */ static int get_logical_address(uint8_t *oob_buf) { @@ -215,7 +202,7 @@ static int get_logical_address(uint8_t *oob_buf) block_address &= 0x7FF; block_address >>= 1; - if (get_parity(block_address, 10) != parity) { + if (parity32(block_address & 0x3ff) == parity) { pr_debug("SSFDC_RO: logical address field%d" "parity error(0x%04X)\n", j+1, block_address); From patchwork Sun Feb 23 16:42:15 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuan-Wei Chiu X-Patchwork-Id: 867830 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E06321369A8; Sun, 23 Feb 2025 16:45:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740329138; cv=none; b=ksvvEjbdeJpVQ0odc4zYNYJ/wnN4yOhQzS52ClR3nHkQSkg77T6uC+avaJoVruSkllvKUwZqt9xA+bC8GKQzmPdf8QdH5aPy9+0gdXnr7wZqQVq5ULFSDZMA7acgiZN9UFUfMbVb4UGa4Qjbzvf1Dd9/prvYU4+xQ68nAGOWGw8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740329138; c=relaxed/simple; bh=9MLeZfNC/T6rZivDo76ukvYaafOdf3Bq52OJ1FPtYmo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=AEPSAAoAf0cHolTmBdr8rIMVkGwOk8Q/J16olvfkjXaw/naOIsu+gNG4s52pPJyz/3yeQ+QCcGm72lnwxqU77MrIm9eXdW4XQg/PjqKKn14yqxqYo0HaDSdGacF2lSZuBsWUx+JeBKf91Gajtsl+UUJqOZQWyE+R7kOJdlcWDfg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EAyoF025; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EAyoF025" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-2fa5af6d743so5646230a91.3; Sun, 23 Feb 2025 08:45:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740329136; x=1740933936; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H92cNXD8ivdLBJu7PZvS/WlFHsCPSxa0jaZByFXEmx4=; b=EAyoF025vyKYWl/BJTDDxjWmRZjKJ3aFhdeDDQNu7KuymnzF4EcVDc8n6QcWrhbFC3 q6+KBAgGpACn2HdfWi8F/nn4o+C4+2sFan5APDpwG6sxdmqb7NWGSWfOYWWGzlWtB2Tb Q9oxyez01VKwLBOixsuSyIiKOXmW5UvDvT4UjMsOCJohsUbGQRQRDlFAfPFQ+BaIgbSF 0XcaOvv8isuIrCr5QX4F7t5q4itRVrn4Z6rpf/KYiwB96ien57oYWE4PTD7SUhAHk6TI MINdOZYq/WoKoYv4Lbh/tQwNUPYdJKCngb35Iciet5VbA+6HjJB4Lp1uV1vbvFjwXGRL 1SIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740329136; x=1740933936; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H92cNXD8ivdLBJu7PZvS/WlFHsCPSxa0jaZByFXEmx4=; b=cHWlfJU+9EkgWEgX3WPVk4ju7o6ZlATfoRFyJUGrcnpgQjJUzNtk7G2JiFBXITrT+8 MvgRvHfcgDeHbI58I+O7Ja2pfzbhFQwIQlmJrX61sVvGHv9k6UTaYaDb6g9QQbjac4Vv QhmvqkyRW95TCRXp92zvMo9uu9fsig9bXNJPbtNlC6neKgUR2ArGhD9gozGWyThfzn5E YVcTdyQbaG88kt515BWQTRve7jS1FhLz4xIc9bchCr4c2UUw/HI+Ow8DIrvfTKdbtDsV EZ7Atv+o/nFYGoNWmUTtZE4dfz2KgdVhdT4N/q+Y5yU+vua2i4rv0/WOpf1Rq5moX9OD VbvQ== X-Forwarded-Encrypted: i=1; AJvYcCUogcHBj9T+YK/DjQRmJJZjoaARunJZGCP3o6YQpF6ehbT7f7nhL1g1McJsUgURrOtt1naFhKBqZ3e3xVk2JP8=@vger.kernel.org, AJvYcCVteppFft5qPGu4sIzDG6HuOs+P5m+aisEoFefqCEz8ycNeUKCXD8yMrT1wcTqmHmOr7jGmJnexcDEUTB8=@vger.kernel.org, AJvYcCXBUXxxQ4xiIPlqzq6Dew2bOClorzOFmjsYMfuUgdAbgwCb6zPQiqx6N3fxN54nnLhxeoHURgRR@vger.kernel.org, AJvYcCXLoXZVqDOkPBnur3NTaTHkJ32LXgUhJ8Iqksq86KrmNsAeynlvh6I5m/CWgjL4RoUFM48cwkX66mM5jtQ=@vger.kernel.org, AJvYcCXbdUfOvL8VDAV/yrxS7uTxNXs4rGf/2l2YQpWut1fBoBck1ig3WrMCJy4xDXH260d9znjVm3AS68GCx2bc@vger.kernel.org, AJvYcCXsyn4nCPvqIj80FTtpYcjGLzi9SqQd4xfhq0gsHURUL01Hl1of1cPkV+V0F8i6DaahPI/tPS2YiBaAO/HH@vger.kernel.org, AJvYcCXxgoc9kL3RksGuBj/aj+Dyx3xq+TG3022p4Fd5Tr+yHp/m6ivviXdx6FKVzW18Lc+ZVnw=@vger.kernel.org X-Gm-Message-State: AOJu0YzqBzlgtc8ZbSThYcUn+jli45lOtxqJDzAcqg6m3wpfxZnZ0YEJ vCCQ9cI1TJcVnq5aNOMpGR33uAJdW0CuQ2GukhKuAJqY1rrhcCFk X-Gm-Gg: ASbGncspRgDZWq3z/0hKoRyKwymPBht5Bx7mPm+/WCs0CKxGWCXcfmszzo89SLafjei ZyISKWdeDqNZ+ClE3hhdUZ4yej9gWsj/fVvtkSrR4Q5dqdrVURPW0azmQY6k7UwCw5KkqHgY9ZN ILH1IwjkIVufajXYXAYGRHNXh7nasRjzKAQN+OJtrLoYsW0VZ2ItKr8W6ZyzJTL0hPKX1hp8F/+ upeLtAfctL0J300NRuEYqzc25yVC5uKfpNsqYmK+yzNZZSn2mBS5beAyXD1dZ3URbXLX9eNppML h4plL3VjeIJLhr7cgOkkN3dbd+1eFBvMCLqFTHXncT7hO+ZfUhSf1oMA X-Google-Smtp-Source: AGHT+IG/5m3vxk7XH8yJGRjtosKFh6pQvnNnT6e9O4ZXx67836JTtD9gPOQACi8OqZVBfLdHsuq5WQ== X-Received: by 2002:a17:90b:2e0d:b0:2f6:f107:fae6 with SMTP id 98e67ed59e1d1-2fce7b1a82cmr15222650a91.23.1740329136041; Sun, 23 Feb 2025 08:45:36 -0800 (PST) Received: from visitorckw-System-Product-Name.. ([140.113.216.168]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fceb09f6e0sm4935080a91.44.2025.02.23.08.45.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Feb 2025 08:45:35 -0800 (PST) From: Kuan-Wei Chiu To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, jk@ozlabs.org, joel@jms.id.au, eajames@linux.ibm.com, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dmitry.torokhov@gmail.com, mchehab@kernel.org, awalls@md.metrocast.net, hverkuil@xs4all.nl, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, louis.peens@corigine.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, parthiban.veerasooran@microchip.com, arend.vanspriel@broadcom.com, johannes@sipsolutions.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, yury.norov@gmail.com, akpm@linux-foundation.org Cc: hpa@zytor.com, alistair@popple.id.au, linux@rasmusvillemoes.dk, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-fsi@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-mtd@lists.infradead.org, oss-drivers@corigine.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-serial@vger.kernel.org, bpf@vger.kernel.org, jserv@ccns.ncku.edu.tw, Kuan-Wei Chiu , Yu-Chun Lin Subject: [PATCH 15/17] fsi: i2cr: Replace open-coded parity calculation with parity64() Date: Mon, 24 Feb 2025 00:42:15 +0800 Message-Id: <20250223164217.2139331-16-visitorckw@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250223164217.2139331-1-visitorckw@gmail.com> References: <20250223164217.2139331-1-visitorckw@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Refactor parity calculations to use the standard parity64() helper. This change eliminates redundant implementations and improves code efficiency. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- drivers/fsi/fsi-master-i2cr.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/fsi/fsi-master-i2cr.c b/drivers/fsi/fsi-master-i2cr.c index 8212b99ab2f9..8f558b7c6dbc 100644 --- a/drivers/fsi/fsi-master-i2cr.c +++ b/drivers/fsi/fsi-master-i2cr.c @@ -44,15 +44,9 @@ static bool i2cr_check_parity32(u32 v, bool parity) static bool i2cr_check_parity64(u64 v) { - u32 i; bool parity = I2CR_INITIAL_PARITY; - for (i = 0; i < 64; ++i) { - if (v & (1llu << i)) - parity = !parity; - } - - return parity; + return parity ^ parity64(v); } static u32 i2cr_get_command(u32 address, bool parity) From patchwork Sun Feb 23 16:42:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuan-Wei Chiu X-Patchwork-Id: 867829 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1F20137930; Sun, 23 Feb 2025 16:45:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740329160; cv=none; b=bsaA2DGOgoZWFl0GAA02OUDLa92XdRTKy9YKSr3kJdBifcgy6RzLD8rjwOlvFFl8XlxcIqNLOGisY7/hekTukTsPQdc8W6AXlygjSf9G9I7fkXmfM8IFxv75tF4yc9OitDMQjRcyfGACt7KU1fYuB8rWXHetFxaj6Qo+LiXB7QA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740329160; c=relaxed/simple; bh=VpxAbF0iBul4Uw/Lq+mofgkf8czO0+orTD3RsRZ9cYQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=CKoDvYpGlME5HH4x/3ueOzqJ47bNM+8hEBO8S63bZmigIQX9Ryud+HcLo0PoJtKwr1H+SHGh2A76u9n5wXIKUl0jk/qB307913/GuFTH1pjbGy2M5zNu3Y+e/ubtVn2PoGvDsce52aboTBRdRcl5E/erOHf4RtnCB86BEC6MXBM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CjTBecVn; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CjTBecVn" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-2fcff77ff9bso2745195a91.0; Sun, 23 Feb 2025 08:45:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740329158; x=1740933958; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nzBrmzWckDIJwY51QBb0mQJ5Dqo6Ldx+jMH0V0Ck8/w=; b=CjTBecVnq+JEtt0Olvb3Q88N6Dhx8qwCfRzSi8G3dBD9JUn6ZOwA4fAZOyC7XqFUwJ Ai+//fykwUUGeVXRRlsC3AD5/b39+JAm/GArUx5PTB1uuF9y2bHJHUq5RUXw/ZOyRh2z pVkg4ZsbmEMnONLEsBz+FNGLIAhgC/DomaPhiiVrWNv7M1P3ORHQr+c7u3ilTgyY0WUa efrxFGT/b6Rrkw5RNDaDxjJKTLlR6C1Tqk5eIxxNIcuQqi7NDD37e9eB3teiAZpvemRc oZsUQh8wKHCJ0DwWRbTJgvuUfIjPibil7GStEbQYCkOHHqUXjcuuNgfdfVs8ooEdBJ1+ UzFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740329158; x=1740933958; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nzBrmzWckDIJwY51QBb0mQJ5Dqo6Ldx+jMH0V0Ck8/w=; b=q7H6ruRe6NXtMZHPIv4+CjOgHK3Yg78kmQEXKpdcxeGmGafyR5OxtQnrTCGKFzDaKu ZAl+WzLvT1Tt8KoOFe++MRmm/QEt+Nn1BQNtAHWPmXYmCVGT9tTN0sd73yGfcNGYzv7o kwg/eYFxawFBgrGG28lJY8xowH4cIutfwXejpjaIxkcGa625k5TvsNPRl502kGGKaPg8 M7ekY/CTLBQqlGYW6LTClBIKMx35pSfWDq9KPG0UKgywMsVF50Eq8O9+mhPyH3iUH6bG jMOohZ86oGJn637NIacGcL+EAqLxK+zIQASq9rjYMHzrLr9RESNSK7wn/uufDkNM6lxx MzJQ== X-Forwarded-Encrypted: i=1; AJvYcCU4xHnIMVo3PaOhn5mHUx5Hbs9ss1mSPb8GiYUyo+Ql4AZifQKg3doNQe0PIo70YsblOc+S3mfc4g1Jx7XIucQ=@vger.kernel.org, AJvYcCUnlqV5jl2oc1Q8LAuJjQ4ti+/2GEBLdaagGHwQ/+ydKhncSC8wWacrSeuP5G1gxg/uR+ckitnkSTKMlGc=@vger.kernel.org, AJvYcCWe15N4jzuvZg0Y+TPEDD3fblWLlaUKl3H/3JSdDJDPZXOGiHJDjVD7oq+SElamb6cif1K+Px91@vger.kernel.org, AJvYcCWihHuNyULU/0Ky+ZXZkprpBD+UviUAZEiy39ANo96PsRVjh2GlSBnUPmSFuqUlTee143jHNRCEg1+JCwPl@vger.kernel.org, AJvYcCWsCYLjy77JWWM4+crkA2NAowTuP6ebceY/ozLOU7LELsVq+PnLrWFuQrtxnK+WJywS9iYp85E5YGCH3NmQ@vger.kernel.org, AJvYcCXXCAwKRHPbdeOaOoZRkIbIl5NEcTdpJMAM99icnvx6Aj8LIyDKLLinNM8zLwPMBvKuMrc/ev7pNm86Ol0=@vger.kernel.org, AJvYcCXgUuLF0d5YwCkuszlZIuEMFqSQ4RyHlQBjQeIlUZluoGibS+6q+9zg6rrCQyW2WSdvoIc=@vger.kernel.org X-Gm-Message-State: AOJu0YypD5VxPgb2Aut9aRJE64Mg5TOP8NLJgCX9b/dxe/aemH16KfD6 govjoY8onB9KXlSYaddDq8n6GSjXErrDhcL2nFLJuzem1aweAMDZ X-Gm-Gg: ASbGncvf9SIYzpOy6HkwKz3qWAxzyQAQuEL9nxb9U4iJ18b5vOtfIj4qmjabMgLoyYp xRR+YuPLQTOezJp65+OxmED2Zc32B/jL7bp7Ow968gs9mX2qLS8dPjt+FFR19JuOI334dNWlR8j lb0SUKJsSGVjqDRhPVKDJY/+ZWnHGnu6IbdaKLfeX/6mK1HSEGMqsKoPQJNdvVdhKs8A9kcDePX iGQQI4bxoB0LqvZ0CS4x74CoT1OsKbjvQ4WRFebN5jx+FTW7MOZRqqUFxETB4NZuJpCZwXKIUyo 4VoPpHWbgfuVHpyhzG3zNJbDLwnUIagV9fyfGRqoPP3QuxjzujRZKwSW X-Google-Smtp-Source: AGHT+IF16AG7QV3yDJH/B6gDeFm18hoNJMWrJMQH/o1eQGkDQfNTajRN2mVaQtR8BSlGLJjsCZspog== X-Received: by 2002:a17:90b:2e44:b0:2f5:63a:44f9 with SMTP id 98e67ed59e1d1-2fce7b0acaamr15082851a91.23.1740329158110; Sun, 23 Feb 2025 08:45:58 -0800 (PST) Received: from visitorckw-System-Product-Name.. ([140.113.216.168]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fceb09f6e0sm4935080a91.44.2025.02.23.08.45.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Feb 2025 08:45:57 -0800 (PST) From: Kuan-Wei Chiu To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, jk@ozlabs.org, joel@jms.id.au, eajames@linux.ibm.com, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dmitry.torokhov@gmail.com, mchehab@kernel.org, awalls@md.metrocast.net, hverkuil@xs4all.nl, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, louis.peens@corigine.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, parthiban.veerasooran@microchip.com, arend.vanspriel@broadcom.com, johannes@sipsolutions.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, yury.norov@gmail.com, akpm@linux-foundation.org Cc: hpa@zytor.com, alistair@popple.id.au, linux@rasmusvillemoes.dk, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-fsi@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-mtd@lists.infradead.org, oss-drivers@corigine.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-serial@vger.kernel.org, bpf@vger.kernel.org, jserv@ccns.ncku.edu.tw, Kuan-Wei Chiu , Yu-Chun Lin Subject: [PATCH 17/17] nfp: bpf: Replace open-coded parity calculation with parity64() Date: Mon, 24 Feb 2025 00:42:17 +0800 Message-Id: <20250223164217.2139331-18-visitorckw@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250223164217.2139331-1-visitorckw@gmail.com> References: <20250223164217.2139331-1-visitorckw@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Refactor parity calculations to use the standard parity64() helper. This change eliminates redundant implementations and improves code efficiency. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- drivers/net/ethernet/netronome/nfp/nfp_asm.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/ethernet/netronome/nfp/nfp_asm.c b/drivers/net/ethernet/netronome/nfp/nfp_asm.c index 154399c5453f..3646f84a6e8c 100644 --- a/drivers/net/ethernet/netronome/nfp/nfp_asm.c +++ b/drivers/net/ethernet/netronome/nfp/nfp_asm.c @@ -295,11 +295,6 @@ static const u64 nfp_ustore_ecc_polynomials[NFP_USTORE_ECC_POLY_WORDS] = { 0x0daf69a46910ULL, }; -static bool parity(u64 value) -{ - return hweight64(value) & 1; -} - int nfp_ustore_check_valid_no_ecc(u64 insn) { if (insn & ~GENMASK_ULL(NFP_USTORE_OP_BITS, 0)) @@ -314,7 +309,7 @@ u64 nfp_ustore_calc_ecc_insn(u64 insn) int i; for (i = 0; i < NFP_USTORE_ECC_POLY_WORDS; i++) - ecc |= parity(nfp_ustore_ecc_polynomials[i] & insn) << i; + ecc |= parity64(nfp_ustore_ecc_polynomials[i] & insn) << i; return insn | (u64)ecc << NFP_USTORE_OP_BITS; }