From patchwork Wed Feb 19 21:05:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Honnappa Nagarahalli X-Patchwork-Id: 183648 Delivered-To: patch@linaro.org Received: by 2002:a92:1f12:0:0:0:0:0 with SMTP id i18csp894032ile; Wed, 19 Feb 2020 13:05:52 -0800 (PST) X-Google-Smtp-Source: APXvYqxtavIVxPMkKpT5VKh6UsBLPJBUu29OfcFdfyNy1GbXfH6gCC35SXE1o3aReWoXRe9p3033 X-Received: by 2002:a1c:282:: with SMTP id 124mr9774816wmc.62.1582146352066; Wed, 19 Feb 2020 13:05:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582146352; cv=none; d=google.com; s=arc-20160816; b=K6psZ6zKa8W7Z/MXK5mB5zZ82QcKqEz3vj8JL2qwp7WwwA7CwaYVLEyF63fD1iP8S3 ua6gmxViDBSHOqMlG45EFnJyEjw/SMGKZ2lMykJ0OsLXoLmzk7TO7TH927E1BY61ePAR v6WOfCrrantN8r8N0XRdUv5Gb2e82nrr39OSxQ9te/dyCqyN67kmcuTEXzOghECqh1+j 3bbMXL8579GODpd/xLBua/xJzlHxdbjEZinwd1hAIlrcrO9fTgUFTLATkss19YuFcE5q DGHj7mXMH7nKDxLgVgSxU+hlN5Ef2t0u+lF03mt0xSP39f41AjSFJ8apwcHcg7F50nyh nW0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:cc:to:from; bh=7YH1L9NxMkOFrKmLLdgriDkenvixAiy8b/tBoPJs+KI=; b=AbaZLR0D6fNgnaGSjiJ06CQV6yeX/Xn3YDkWFikVpDJS5bhd4SSzps9X9qRm9UTRww +jdhCNOFqH8rlwloQognWU+eJk+irPSbE3e695RubMhyBZTVIUheD4oHBi8YXb6v45Iy Zpjofsc/LCqV13pva88JJBlX6uJ7VDf7IPDpqJcF1/appYhfTKDf5VzA0CRj7mZBmFKD 5Nm/eXsaFI0zoYcxXMydvtVIC7dLY7dTr+ZGy0sxSmtsBwcu0uQw2cHSfsXwj5CDzPFr VInAyOpQvM0k/RrxxmeiI22iaIFTrztA4VxPJbegP1vK+VjoLIDHXTUB/B/lpuy8ywF4 rYlw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id z7si1907204wmk.152.2020.02.19.13.05.51; Wed, 19 Feb 2020 13:05:52 -0800 (PST) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B78B71BF7D; Wed, 19 Feb 2020 22:05:49 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by dpdk.org (Postfix) with ESMTP id 7B0CD4C81; Wed, 19 Feb 2020 22:05:47 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D2FA71FB; Wed, 19 Feb 2020 13:05:46 -0800 (PST) Received: from qc2400f-1.austin.arm.com (qc2400f-1.austin.arm.com [10.118.14.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C0FDB3F68F; Wed, 19 Feb 2020 13:05:46 -0800 (PST) From: Honnappa Nagarahalli To: olivier.matz@6wind.com, prateekag@cse.iitb.ac.in, ferruh.yigit@intel.com, thomas@monjalon.net Cc: dev@dpdk.org, nd@arm.com, Honnappa Nagarahalli , stable@dpdk.org Date: Wed, 19 Feb 2020 15:05:29 -0600 Message-Id: <20200219210530.22863-1-honnappa.nagarahalli@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200203045608.5870-1-prateekag@cse.iitb.ac.in> References: <20200203045608.5870-1-prateekag@cse.iitb.ac.in> Subject: [dpdk-dev] [PATCH v4 1/2] doc/rcu: correct quiescent state description X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The quiescent state description refers to an incorrect thread. Fixes: 64994b56cfd7 ("rcu: add RCU library supporting QSBR mechanism") Cc: stable@dpdk.org Signed-off-by: Prateek Agarwal Signed-off-by: Honnappa Nagarahalli --- V4 1) Seperated the commits for ring and RCU changes 2) Changed the commit logs doc/guides/prog_guide/rcu_lib.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 Tested-by: Honnappa Nagarahalli diff --git a/doc/guides/prog_guide/rcu_lib.rst b/doc/guides/prog_guide/rcu_lib.rst index 8d0dfcf29..9b0bf138f 100644 --- a/doc/guides/prog_guide/rcu_lib.rst +++ b/doc/guides/prog_guide/rcu_lib.rst @@ -61,7 +61,7 @@ wait till thread 2 enters quiescent state as well. However, the writer does not need to wait for reader thread 3 to enter quiescent state. Reader thread 3 was not accessing D1 when the delete -operation happened. So, reader thread 1 will not have a reference to the +operation happened. So, reader thread 3 will not have a reference to the deleted entry. It can be noted that, the critical sections for D2 is a quiescent state From patchwork Wed Feb 19 21:05:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Honnappa Nagarahalli X-Patchwork-Id: 183649 Delivered-To: patch@linaro.org Received: by 2002:a92:1f12:0:0:0:0:0 with SMTP id i18csp894151ile; Wed, 19 Feb 2020 13:06:01 -0800 (PST) X-Google-Smtp-Source: APXvYqxV7qqpkTdr/MUZdMnxTPHx9L7QZuAh/nLaeINs5hkIYDl2bzOLH2XGcsPNdi3ZuYMn0U5s X-Received: by 2002:adf:94e3:: with SMTP id 90mr37352087wrr.268.1582146360883; Wed, 19 Feb 2020 13:06:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582146360; cv=none; d=google.com; s=arc-20160816; b=KZdhNQSkBdgl+HJBNUzIMQRkDU5/vT21gJJW0KkCh6EoSFRl/zuV2wAk5fGUu3AWPN +Va1LumvnWGisxO80ZJxFZRo37BxsBNvrKtVkbsJ91BAI8cyCtZNcgiF2jOXFqMqBAs+ jDTBDoLHQeFN8XYTUzZqpI4ioCpOkm7p2oNAVY5D/Wy+/WfXMWUlg4dlSG1aoA7v9VOl JswOlm30FfJ8dQ6Xti6EMI7s7M3SHxOiw4KAMD1WwHFUYLFX3TpWDDr1bTSJJJTuN2JQ aEDRaAvUeNfV5lmJMp008BajyUOTM0ZhSppvrapHndAtqvhjR+TCpecrP6yuPJgoaqLS BC/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:cc:to:from; bh=s3HuzOgI79KfzhyagkGUdTGjO3LfJlBNpofbAP5xAQ0=; b=loxCrppwcJTiXhT03/49jMiISgywQpoL9m8s+DJEUgOECvGqPHZMSkfm6ixIpyZLME uU9LrOQkXKKhS8cjkqS3+4A2Imdxuf3NfEMdAOZ4BbXYOW6UH/JEInN+ifgI/f6gp6QG j0tCFAUCwwa/QpTWYHk/uxEQKVGjj1E58wopp38EO0KczvPAPzZqpVlCDVjTcDf4v+hD /NNmQct/RgqL3T3MmCkl5Op3b6osoHDsNmmgiWF3A5HlZ2nxVi3BflgFy1oXft8U5FGL 32FvrdydcvRqenH2xsLRLgROPqIuuzKOoXfK+fbPtGOLIwv8Celwlgj6FaeurqYSmRZL eaYg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id r5si5588168wmh.12.2020.02.19.13.06.00; Wed, 19 Feb 2020 13:06:00 -0800 (PST) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7F8981BF78; Wed, 19 Feb 2020 22:06:00 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by dpdk.org (Postfix) with ESMTP id 349E51BF87; Wed, 19 Feb 2020 22:05:50 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 96B7BFEC; Wed, 19 Feb 2020 13:05:49 -0800 (PST) Received: from qc2400f-1.austin.arm.com (qc2400f-1.austin.arm.com [10.118.14.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 89A5D3F68F; Wed, 19 Feb 2020 13:05:49 -0800 (PST) From: Honnappa Nagarahalli To: olivier.matz@6wind.com, prateekag@cse.iitb.ac.in, ferruh.yigit@intel.com, thomas@monjalon.net Cc: dev@dpdk.org, nd@arm.com, Honnappa Nagarahalli , stable@dpdk.org Date: Wed, 19 Feb 2020 15:05:30 -0600 Message-Id: <20200219210530.22863-2-honnappa.nagarahalli@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200219210530.22863-1-honnappa.nagarahalli@arm.com> References: <20200203045608.5870-1-prateekag@cse.iitb.ac.in> <20200219210530.22863-1-honnappa.nagarahalli@arm.com> Subject: [dpdk-dev] [PATCH v4 2/2] doc/ring: correct multi producer enqueue figure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The producer head pointer in multi producer enqueue fig.6.10 points to incorrect object in the ring array. Fixes: fc1f2750a3ec ("doc: programmers guide") Cc: stable@dpdk.org Signed-off-by: Prateek Agarwal Signed-off-by: Honnappa Nagarahalli --- .../prog_guide/img/ring-mp-enqueue3.svg | 194 +++++++++--------- 1 file changed, 100 insertions(+), 94 deletions(-) -- 2.17.1 Tested-by: Honnappa Nagarahalli diff --git a/doc/guides/prog_guide/img/ring-mp-enqueue3.svg b/doc/guides/prog_guide/img/ring-mp-enqueue3.svg index da483b031..8c15cc7c0 100644 --- a/doc/guides/prog_guide/img/ring-mp-enqueue3.svg +++ b/doc/guides/prog_guide/img/ring-mp-enqueue3.svg @@ -2,6 +2,7 @@ + @@ -359,15 +360,15 @@ inkscape:pageshadow="2" inkscape:zoom="1.4" inkscape:cx="201.35119" - inkscape:cy="221.79811" + inkscape:cy="107.5124" inkscape:document-units="px" inkscape:current-layer="layer1" showgrid="false" - inkscape:window-width="958" - inkscape:window-height="1002" - inkscape:window-x="223" - inkscape:window-y="22" - inkscape:window-maximized="0" + inkscape:window-width="1313" + inkscape:window-height="713" + inkscape:window-x="53" + inkscape:window-y="27" + inkscape:window-maximized="1" inkscape:snap-grids="false" inkscape:snap-to-guides="true" showguides="false" @@ -382,8 +383,10 @@ visible="true" enabled="true" snapvisiblegridlinesonly="true" - originx="-162.97143px" - originy="-370.03525px" /> + originx="-162.97143" + originy="-370.03525" + spacingx="1" + spacingy="1" /> @@ -393,7 +396,7 @@ image/svg+xml - + @@ -490,37 +493,37 @@ obj1 + y="495.49646" + style="font-size:14px;line-height:1.25">obj1 obj2 + y="495.49646" + style="font-size:14px;line-height:1.25">obj2 obj3 + y="495.49646" + style="font-size:14px;line-height:1.25">obj3 cons_head + y="589.505" + style="font-size:14px;line-height:1.25">cons_head cons_tail + y="603.41034" + style="font-size:14px;line-height:1.25">cons_tail prod_head + x="567.01239" + y="587.9577" + style="font-size:14px;line-height:1.25">prod_head prod_tail + y="602.57739" + style="font-size:14px;line-height:1.25">prod_tail local variableslocal variablescore 2 + id="tspan4150" + style="font-size:14px;line-height:1.25">core 2 structure state + y="664.09021" + style="font-size:14px;line-height:1.25">structure state cons_tail + y="401.48123" + style="font-size:14px;line-height:1.25">cons_tail prod_head + y="401.48123" + style="font-size:14px;line-height:1.25">prod_head prod_next + y="401.48123" + style="font-size:14px;line-height:1.25">prod_next local variableslocal variablescore 1 + id="tspan4152" + style="font-size:14px;line-height:1.25">core 1 cons_tail + y="328.57767" + style="font-size:14px;line-height:1.25">cons_tail prod_head + y="328.57767" + style="font-size:14px;line-height:1.25">prod_head prod_next + y="328.57767" + style="font-size:14px;line-height:1.25">prod_next compare and swap succeedscompare and swap succeedson core 2 + id="tspan3324" + style="font-size:14px;line-height:1.25">on core 2 obj4 + y="495.49646" + style="font-size:14px;line-height:1.25">obj4 obj5 + y="496.00156" + style="font-size:14px;line-height:1.25">obj5