From patchwork Tue Feb 25 22:30:01 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Tomasz_Paku=C5=82a?= X-Patchwork-Id: 868465 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 094572165E5; Tue, 25 Feb 2025 22:30:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740522613; cv=none; b=tBznM1rhfFJQTn4sTeXdwf6gkIyiLJg6VPC/2xKL2qM4StmGq2VTahHW4P3cLYoNb7dtAvOe8mFax4BXMMlvxQHtVnWt6wLxgjjemOfo1G09fTTldw3+GQKvjc/FJ30ka5Uh0sclrgdR8nBRdNe+DedH2q9VjPpRHS2Tz40TmCE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740522613; c=relaxed/simple; bh=ESWHMUxmV52Qaj36P2x83E7I7NyZYOkBXsH2Fo96Pno=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=RMo59I0lzQYMgfUooaC9OAyxAFpJYJybXIP3J6N87HN1aXpO8jsmtdIda6vq6Y/Woo9hHjuW4lVYZHNgi1gnpqh8rOoRidhwv67iqB1ZdZHVQhejVORKz/xGrtJ8pKKwu9qJNfWKv3vZdwdkbl4MprbRAuBjlvf1kuI+64VxBF0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RAYio6MZ; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RAYio6MZ" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-abb88d2b67eso72916766b.0; Tue, 25 Feb 2025 14:30:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740522610; x=1741127410; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KRf1ILuW4AlRtlcIymAG7O6j8cyk58JheUtEmycHXyM=; b=RAYio6MZBJiDgY939ftTEYuZOJbY2eJ9O3zc8OeUGFQPFRLcTp5cUmu2X8Mxvvtj9I 3F4mC+3f7bQjeGzqANp7IkLbmrOLmucFBG2LqQBkJ0E0Kd3f5kjF1JjfF9KQe57FGRLb /nX/XDd0i2gkyagLlWPokz4eTbEOP+rWwDYxB9dO2fVs/a95q7FNVb1/SttlEnxxBo4s EG8lTER+2+xjW0/w1HDQFAYqIi5oymLO17ROhLXUPBRHGBC0iSqoyoHJO+U5al7I3oZC Ch8vyELa8npsLDeIQTIObDHd/U4XydB8mLvZyKoIRrJo3mDnQ1nOjeCnNd+E/Q8lHzSn ibmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740522610; x=1741127410; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KRf1ILuW4AlRtlcIymAG7O6j8cyk58JheUtEmycHXyM=; b=Rvj9Idrz43EHa8BIzBZE772rGUeiZ+n3Wb7F1ti4hj/M9qTMq5X0OqR4RTct1wz7Fr TUkrFmCVaX8AsGf99ev021FwQHIYMdtRiUPI7wQiLd8evce7AsCc/zxyApybNXT5E8Y9 vM2TJty1u/xYccp9ub2hdqKLi1OH9D7HTzpYSHDMQCLAekkHzBkKhmLKw8RfxOC6ZaGJ HCrjoxVTrtZPvwOpmLl0LSE8u7UW3/Q2+SkRYEeW2LWU35vIT4kaR/8hfvc7aPIe+FMf ZbK5GZengjg5i5fJpif1/rQVmN0SyWb3tRNVS/SUXudrT7AZ7qWA33+fRZy16LBopPGC Jgrw== X-Forwarded-Encrypted: i=1; AJvYcCVY4Ztsz6TVNXBtku80H+uOd5TJ4RwbyitsUeZFhmNI/i6Nn+FYbrjWtlSzuT88JDUSRKGCROZzuNDrFQ==@vger.kernel.org, AJvYcCWEnhlgPWPSITR64IGQKVa/UWmNBUpGGLGhN/Lec29qZvDofKV9xXgDsjhAqBtq9za8PehncYtf0eCK@vger.kernel.org X-Gm-Message-State: AOJu0YzQgBZEpXZevq1UyG0VHZ/i7mdNBSR0JXLI7Yn6RpdiyFb5sowQ gnEjJSqqNnuRDZ6O2491S/9EWYh3PnQYo+hTda9jU/CSKAfSjWZb X-Gm-Gg: ASbGncvThB4n1I//VCbbVkHYWt81H58wlj6PyJ2hY20dIxYN9qvHey6unYOZr6a9XtP lYYNiYMdyAEaFYIGDF5U1pNplQ4l5KEoqXHRbk+NF2l810amOeMTyaZFXel8M5dMtC+rWmZOI42 ddFu8Do1lkErVzqWC0GFtRN95ujOhqzTPkvezI6OA7kvQVoFsyryjv4AaE9wjuwDSCXs7nRIw1X aZYNpGYWWsxMwvjmFFUhjCPrsEqoo+jbvqdz9EhvLbyZihkc02shklUK2+m1XaRdK0qFhJLAHLZ +dL/jGzEQ0s50wkknvJUsfAdrHdQ78QcspDlMK45Ia2pmdJA9YVOSC9YY8X8nXLPfvLQn7nb X-Google-Smtp-Source: AGHT+IHBX02/xI4FOdQxhX0adLlAWoHjoIp9ates0dEErgTqSCD+AyeIlyK1LkogAycDgE8tAx0hwQ== X-Received: by 2002:a17:906:7312:b0:ab6:d660:c84a with SMTP id a640c23a62f3a-abc09a0c05fmr859688666b.4.1740522610111; Tue, 25 Feb 2025 14:30:10 -0800 (PST) Received: from laptok.lan (89-64-31-140.dynamic.chello.pl. [89.64.31.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abed2010f74sm209122566b.121.2025.02.25.14.30.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Feb 2025 14:30:09 -0800 (PST) From: =?utf-8?q?Tomasz_Paku=C5=82a?= To: jikos@kernel.org, bentiss@kernel.org Cc: anssi.hannula@gmail.com, oleg@makarenk.ooo, linux-input@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH v2 2/5] HID: pidff: Clamp effect playback LOOP_COUNT value Date: Tue, 25 Feb 2025 23:30:01 +0100 Message-ID: <20250225223004.415965-3-tomasz.pakula.oficjalny@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250225223004.415965-1-tomasz.pakula.oficjalny@gmail.com> References: <20250225223004.415965-1-tomasz.pakula.oficjalny@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Ensures the loop count will never exceed the logical_maximum. Fixes implementation errors happening when applications use the max value of int32/DWORD as the effect iterations. This could be observed when running software both native and in wine. Signed-off-by: Tomasz PakuĊ‚a --- drivers/hid/usbhid/hid-pidff.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c index ffecc712be00..74b033a4ac1b 100644 --- a/drivers/hid/usbhid/hid-pidff.c +++ b/drivers/hid/usbhid/hid-pidff.c @@ -690,7 +690,8 @@ static void pidff_playback_pid(struct pidff_device *pidff, int pid_id, int n) } else { pidff->effect_operation_status->value[0] = pidff->operation_id[PID_EFFECT_START]; - pidff->effect_operation[PID_LOOP_COUNT].value[0] = n; + pidff->effect_operation[PID_LOOP_COUNT].value[0] = + pidff_clamp(n, pidff->effect_operation[PID_LOOP_COUNT].field); } hid_hw_request(pidff->hid, pidff->reports[PID_EFFECT_OPERATION], From patchwork Tue Feb 25 22:30:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Tomasz_Paku=C5=82a?= X-Patchwork-Id: 868464 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DC4221858F; Tue, 25 Feb 2025 22:30:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740522615; cv=none; b=dF4yLgcL1avgto7DeO8kM49gAnGM0/+rdCNiWPlCrHRP3gpsY3XRkhcYAnnns28nd6KMkAk7rmYyOu9fBz37+hUBFl7eaRfY3DzyPpL8WVn8upS+1K8/l1kkpfhgYoezSF89qmVdkJ3i2PuqpXLXT3NYAmMOLlvq+S5uBZv6aQo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740522615; c=relaxed/simple; bh=wpX4MDEKrwsvmMZvujrY/Z5rpaU0povc3dRNk6Rz7rQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LGrnnDibejchRUWB5Vm2JpbjfSVVM80+Zqmb2r04HwG8+/c/OxouzvTNU89yDijN5qo8yiQCikBWt9JTs2JK3ECkw3eHrzXVeccvH9TVEuIUvBD/HwvSGEuSfg4r6gIz1SwZX/pjd1asiDTpeBOJy3UaXrsF5dplU9KnYJ15tdw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G6U6fphL; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G6U6fphL" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-ab7e08f56a0so110149266b.1; Tue, 25 Feb 2025 14:30:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740522612; x=1741127412; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KepluMyj1J69FmALxGaavPqtO2RMuar8Zd14QOrTqME=; b=G6U6fphLvpiLiirpHU0P7eAyXVzzp7KEZDODQcpmEyacbk82B3NarZcO3GrI/Hg68z 8x104QEJe3OoCN5K+8iThDYuydplg/Em65wxrElYRFoIlXBwQmWNdBYSDf+DiA8pI1xn Zg2Qcz8mLYljAklk8rGi+PeAl4RW3LSkYxpU6Q5rUnDr5HaupulyyR61LvK+stcPM88r P9d0PBWjkF9DeqTPHqU2nzt/BB0IZnYnyHa2m/OtYPSGWNmf7pXU5WidC33fi6lbVKBR MCzaDDbIKLJD2ycfaKkP6m3k7kAAdiiRB6IK0iw5T7hETC4Lt383AvcjJ+ShF71o3m4M 4vFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740522612; x=1741127412; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KepluMyj1J69FmALxGaavPqtO2RMuar8Zd14QOrTqME=; b=c1m1w2aDeJUp2s1hDPhp/KgJ/TxYNeaohPhXfZ5ymupRAT8t6LPe/xMkkv/HBb2zPJ WnIBWi0z+K45BiiXLevo+u1nEk4mB2/ntfMyA18D13jGl+KFUvDBq8J3YZcXSaRK7vms I0bEei1BmtrwpKoNVhSmD/f95htiqW0fRlLrLx8WLGZxxUY44FJ/NvJzbWkStj8cTbg5 AmSKfHhjhDtWgffFGrufo8nwHUqOwAUm4x1YdzcTBP8MA93pDMU7UOpNoEOJyT/wx8AY Xtc3h5VhpFk4u1OeW//8Fh8pkeEj/v/zWAFiEPMoXveZ8h0MIDB+9lp2kS3hj+WHvdtm SJDg== X-Forwarded-Encrypted: i=1; AJvYcCUQP8Tjj8Ut2l5qexoP+Mnkxearn8q+3hli/NU3jnMiwW11E8rq9ZtE8ddCx1COmb7O5vme15EKxJqvnQ==@vger.kernel.org, AJvYcCVmNDH3sV7Mc/CK6m+jsJlen9bus6XzmoAu0Rq6UAIn9aKUiaE5ewbM36wZ6pzrQVRti525nvpZgggK@vger.kernel.org X-Gm-Message-State: AOJu0YzzRAfwsia57RA6biw70dsbFnjyWoLE8uTEi5fSAlDqw9aTeRbU WbLM5YWboGdwb/hJbQbPxh9RfzjTKf4ZB/eUF5yUyYGcqKd5S+na3Y3Ca6l4 X-Gm-Gg: ASbGnct2V9PpqJy8q3+p7DYdTZdBiHFYxe/w+0QsuGJqyFPMkdC32Wis3142q2Ryos1 NlMLlhd8NZ27yMd/yqQAymIXvTz3ahhNk4XanBsuNcMd5aIZIZYjrtJhPxvLn4ZaiAdrTwFZKMR LKSNXuo6whsQDaXiAp/sJELoD6MExS1h5pZbGC1zV7Rmqj3+hLd5EBjDc/1s3Q2h6tL65KJvwjk MspfyLjbhgbWZ6ol9gh9rn5v1it3Kif/HwRkboOFQmm9pgf92E1m37Eaz9m2rZZWAkQrwS2+IO9 Yr1V6lS0j3zi80NyutPU7MatdpLNVD5G3/hk0ujdKKx3Yxl0podwpMvO0L7POcpjLuKEilUo X-Google-Smtp-Source: AGHT+IFKK6j26Hyyk9NmDTaQWRrTWWtem6M9BzVP3zEJfldl8BXwXmh0hdZuH40tvJfCUQPtXAdUPA== X-Received: by 2002:a17:907:2ce2:b0:ab7:cd83:98bb with SMTP id a640c23a62f3a-abc09a3c1c5mr721291066b.5.1740522612359; Tue, 25 Feb 2025 14:30:12 -0800 (PST) Received: from laptok.lan (89-64-31-140.dynamic.chello.pl. [89.64.31.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abed2010f74sm209122566b.121.2025.02.25.14.30.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Feb 2025 14:30:11 -0800 (PST) From: =?utf-8?q?Tomasz_Paku=C5=82a?= To: jikos@kernel.org, bentiss@kernel.org Cc: anssi.hannula@gmail.com, oleg@makarenk.ooo, linux-input@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH v2 4/5] HID: pidff: Fix 90 degrees direction name North -> East Date: Tue, 25 Feb 2025 23:30:03 +0100 Message-ID: <20250225223004.415965-5-tomasz.pakula.oficjalny@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250225223004.415965-1-tomasz.pakula.oficjalny@gmail.com> References: <20250225223004.415965-1-tomasz.pakula.oficjalny@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 --- drivers/hid/usbhid/hid-pidff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c index a614438e43bd..6eb7934c8f53 100644 --- a/drivers/hid/usbhid/hid-pidff.c +++ b/drivers/hid/usbhid/hid-pidff.c @@ -145,7 +145,7 @@ static const u8 pidff_block_load_status[] = { 0x8c, 0x8d, 0x8e}; #define PID_EFFECT_STOP 1 static const u8 pidff_effect_operation_status[] = { 0x79, 0x7b }; -/* Polar direction 90 degrees (North) */ +/* Polar direction 90 degrees (East) */ #define PIDFF_FIXED_WHEEL_DIRECTION 0x4000 struct pidff_usage {