From patchwork Tue Feb 25 11:02:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Claudiu Beznea X-Patchwork-Id: 868469 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 359D02676F9 for ; Tue, 25 Feb 2025 11:02:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740481382; cv=none; b=oQNfnbwIPH0KfSHIt+q2/KsNBjVWSfv0e3ymC363Ot4d1UyST+kbHKftF37m3Uhtvg6QWaWH6wbpcyXzj2iBmvafL6OT9gH6iqQOM6cpaL7Q3J440EvCLQEmKJB1IV9rZL9ZJVrlX9Y/WEcQhXEGw527A4M8c1SrTdhYQRdBpTw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740481382; c=relaxed/simple; bh=EFoTjmBvFXfXjWb+GX1/FcvwY+PND4is0Ol1b2EMzJs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qfL6lGyZjxqM1wsR3P/quZtN4JXHlYjwvoJo3PKIFcdoWaczxwD6f4FKJE7hr1GmUoTWyD9SiIjyhh+WWos886UZqCBzsFMFcuuRL6D0xvNs75TH6/9Lxz69Iz2K1WdAGWdjKzbkub/46V4wRDGOCCr/AkT/uSkJ9UNkjfn5MJc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=k14C2U6n; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="k14C2U6n" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-439a2780b44so34110035e9.1 for ; Tue, 25 Feb 2025 03:02:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1740481378; x=1741086178; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1g90tifgQM9MVDjBzO/J2Q9Ytv3puck/TcrC4X2HffE=; b=k14C2U6nGMHsF8/MEKTGyx66X/GNX/AXIuxMBjthOmHyCVh3Qs3d6RCIodf3FL2KB8 ZOEgIsQ5L9Yisrg4dL+bMYNoduIE2WpcEkyrlN3WZwoPLKL0EVjvxLWhcasXzjLWhXaH 8Dw+UHLTblJvNiXztWWwWvP+49ExEwDcWxFvOlpPxayZkWHXyz9yTXBHo/DLHowNO5Ls C6A++u09CDhYP1b3aZx/MP7jurtIkfa3+p2T89o5IcUJirKjAVyYaMD7fXnDZvgH9lMS xmKyYNs48gjm91WmA7YsSqYrnicAaIWdRBgeJpuKXL2mWdIaZtu1kNJsZoyCPaPPvVT0 7HcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740481378; x=1741086178; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1g90tifgQM9MVDjBzO/J2Q9Ytv3puck/TcrC4X2HffE=; b=FYpGt1k5bgJEo8fPftu5qcUSO06nYXATS6OdB16M3auAc+eQgaggzntL6bgU7ZGYue yA+WA1Y8Gf8DlKQN1sj9Uw+4IWiUqlaCnvoEZBLwUWx+fyWSJB/6GnLiLLrBq6q6k52r LMVNZkxOXszY120zcXNFPZp81OcNTSeqySCk9073EhZHT65EyRI8dByzCIshacEZmN6G sEldEd67iOsGXjxj+pRwcK0tcuuqZdOTF8dgQ1dC7u1S1NY8fdU+1N1hyG4bemkISa0O czdI0VSYsfozqQlCApBDUr7YTa5FE3lZYvqw82FiGvMoVqPPyejtHzZNEImng8t4EsNz JtFw== X-Forwarded-Encrypted: i=1; AJvYcCVnakh1WK2XWMVDqwyN6NJY88dox6ZO2TLH/nh9/s6LdBm5jiWYgHJkjbTAsqXlxT6RHvDe8iV+OAU=@vger.kernel.org X-Gm-Message-State: AOJu0YxYufjBD4M0jEMrM30EOLoWHQuOKAl5qewig9aE21L3pgWHHisl 0EHwT7KPoc47DFjdCIZZP8KHu6kue4RfVEt4m2rsp/sG78+Bp7nirbONZc9sIus= X-Gm-Gg: ASbGnctfKhdsivKRiAnsNepq08s+6GbnhoIWPoUQs+yioEXqgbV3IUu0J0XvQxkn/ps uNKgM73Bx0bhTPmN921q+C5D9IC5qxi8DqbLsRonS9/xRRLqaEXSlcRrG6nBbhPDIHf1MbiXAjb GoQcSIOIR8kfOA09qh+03Cd27/iBN83wMPe/r9QzF/9t0Q7dHG5gPhrRtnJj/BZGaBXPYSl1zDz Sl8WIUErhWYN2TV9Ix5JNNB6mQKM1Q1e0NkIVYd1LLsL0B5jCDUJCmqiVJ25V7rx32g4wJzGKVW NRpB3db4PRsuAnRaiS6TSodzX92hVtnaLmsswkXSvbxTuUDUukceQTI= X-Google-Smtp-Source: AGHT+IH9p4vFb/WlIcpRZOBte7JgwwPLkhCZmRimhOlrCUbR7HFlC6wBkzx+vvYw/CKT/Zad3bHmmw== X-Received: by 2002:a05:600c:4f84:b0:439:955d:7ad9 with SMTP id 5b1f17b1804b1-439ae1f145cmr171014845e9.14.1740481378537; Tue, 25 Feb 2025 03:02:58 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.25]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ab1532dccsm21972385e9.7.2025.02.25.03.02.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Feb 2025 03:02:58 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: gregkh@linuxfoundation.org, geert+renesas@glider.be, biju.das.jz@bp.renesas.com, yoshihiro.shimoda.uh@renesas.com, phil.edworthy@renesas.com, balbi@ti.com, laurent.pinchart@ideasonboard.com, kuninori.morimoto.gx@renesas.com Cc: claudiu.beznea@tuxon.dev, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Claudiu Beznea , stable@vger.kernel.org Subject: [PATCH v2 2/3] usb: renesas_usbhs: Use devm_usb_get_phy() Date: Tue, 25 Feb 2025 13:02:47 +0200 Message-ID: <20250225110248.870417-3-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250225110248.870417-1-claudiu.beznea.uj@bp.renesas.com> References: <20250225110248.870417-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Claudiu Beznea The gpriv->transceiver is retrieved in probe() through usb_get_phy() but never released. Use devm_usb_get_phy() to handle this scenario. This issue was identified through code investigation. No issue was found without this change. Fixes: b5a2875605ca ("usb: renesas_usbhs: Allow an OTG PHY driver to provide VBUS") Cc: stable@vger.kernel.org Reviewed-by: Yoshihiro Shimoda Tested-by: Yoshihiro Shimoda Signed-off-by: Claudiu Beznea --- Changes in v2: - collected tags drivers/usb/renesas_usbhs/mod_gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/renesas_usbhs/mod_gadget.c b/drivers/usb/renesas_usbhs/mod_gadget.c index 105132ae87ac..e8e5723f5412 100644 --- a/drivers/usb/renesas_usbhs/mod_gadget.c +++ b/drivers/usb/renesas_usbhs/mod_gadget.c @@ -1094,7 +1094,7 @@ int usbhs_mod_gadget_probe(struct usbhs_priv *priv) goto usbhs_mod_gadget_probe_err_gpriv; } - gpriv->transceiver = usb_get_phy(USB_PHY_TYPE_UNDEFINED); + gpriv->transceiver = devm_usb_get_phy(dev, USB_PHY_TYPE_UNDEFINED); dev_info(dev, "%stransceiver found\n", !IS_ERR(gpriv->transceiver) ? "" : "no ");