From patchwork Wed Feb 26 14:17:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Jonathan_Neusch=C3=A4fer_via_B4_Relay?= X-Patchwork-Id: 868934 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D4F914D283; Wed, 26 Feb 2025 14:17:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740579452; cv=none; b=ugFOrsjm/KxqF0dpCQQYW0e7IGpK8cd1hzk13I/U87RKTkw8zItFieY+qnB/ZPIuSBHk54g8BqKN2zxPnUCgRmxkXFwach1P/CH2ZbRKC+NgREHPEN9WI2M3AOanLwGpBeguCKZvyWIbe62skEQqE85sHUCn5D7F/SrzBwSxeVg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740579452; c=relaxed/simple; bh=t4T1Z6bfxQBpjyXd5fjAXivHEZkPs3AogPqa+53JyR8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DWlb2i3stbp0rrGOyYZJx+jEUDglzMJ6ga3/wt+FI8kZj2SNvY0NRkjSb2vv41WimT7NodVjxIqTUNWDmOIXV5wSgvScnMoBkYC0+DhgSV9buDFrjg59cJhhDRwe+fkNzuXzEn/EMK6TNliuuaI5hJmzSUFPSGRqvqXO6yG8Hv8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FpfNRFbC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FpfNRFbC" Received: by smtp.kernel.org (Postfix) with ESMTPS id 8F178C4CED6; Wed, 26 Feb 2025 14:17:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740579451; bh=t4T1Z6bfxQBpjyXd5fjAXivHEZkPs3AogPqa+53JyR8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=FpfNRFbCPKE6RSmg0gEEzPqBzamu7Huf12NAVSa3nLj+FJz5KLy06Nq45lGXy9qHC JMLmuF1Olgu3PK2v7wqi8Xj88YftvKh9iaIcOocSq8zmr1PKqDMo7y8dAJ00bmkUus nRDgFR7W+XrKTVBPV3PoJUkz/TiUIwup4ZY4W91JwlXmK/VOolXNRzFPZQADOP99xd tsCt/KOeLNmEqvzEJfqvRk0cUqzk4+K2wABNSrsraSEYmPMZDKd5dYnr/TjInJJMac /LSSYa28n8TGH8c16OGDmGf1uZJm9Mx2iEF9qN1CsC+t+HPUo09gJxinUPxJC0nGWF uQLBWtzH0bn3A== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C441C021BF; Wed, 26 Feb 2025 14:17:31 +0000 (UTC) From: =?utf-8?q?Jonathan_Neusch=C3=A4fer_via_B4_Relay?= Date: Wed, 26 Feb 2025 15:17:23 +0100 Subject: [PATCH v2 1/9] usb: storage: jumpshot: Use const for constant arrays Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250226-misc-const-v2-1-ab655a4a29cc@posteo.net> References: <20250226-misc-const-v2-0-ab655a4a29cc@posteo.net> In-Reply-To: <20250226-misc-const-v2-0-ab655a4a29cc@posteo.net> To: Alan Stern , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, linux-kernel@vger.kernel.org, =?utf-8?q?Jonathan_Neusch=C3=A4fer?= X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1740579450; l=1619; i=j.ne@posteo.net; s=20240329; h=from:subject:message-id; bh=H3dMAb8P96lFwD5LpmR5haaczG54h7nPpY9qeuhmOyQ=; b=vF9loLYXkwunZHPQSBSjPkNHR4KE926KDCA6C9QnncH+mdwU9dnMF4CesPjZz4sBl+Ne+JVtm 2+tvSOmCGdhDGPfwhy6AZgOlbRXV1l3HYOfnimKf9m1M5Ii7mxetjEj X-Developer-Key: i=j.ne@posteo.net; a=ed25519; pk=NIe0bK42wNaX/C4bi6ezm7NJK0IQE+8MKBm7igFMIS4= X-Endpoint-Received: by B4 Relay for j.ne@posteo.net/20240329 with auth_id=156 X-Original-From: =?utf-8?q?Jonathan_Neusch=C3=A4fer?= Reply-To: j.ne@posteo.net From: Jonathan Neuschäfer These arrays are not modified. Make them const. Signed-off-by: Jonathan Neuschäfer --- V2: - use consistent authorship information --- drivers/usb/storage/jumpshot.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/usb/storage/jumpshot.c b/drivers/usb/storage/jumpshot.c index 39ca84d6859122903de4e64b13e697e8b7d4ab31..089c6f8ac85fbb683cca8b03a2ff06c0ca776167 100644 --- a/drivers/usb/storage/jumpshot.c +++ b/drivers/usb/storage/jumpshot.c @@ -367,16 +367,16 @@ static int jumpshot_handle_mode_sense(struct us_data *us, struct scsi_cmnd * srb, int sense_6) { - static unsigned char rw_err_page[12] = { + static const unsigned char rw_err_page[12] = { 0x1, 0xA, 0x21, 1, 0, 0, 0, 0, 1, 0, 0, 0 }; - static unsigned char cache_page[12] = { + static const unsigned char cache_page[12] = { 0x8, 0xA, 0x1, 0, 0, 0, 0, 0, 0, 0, 0, 0 }; - static unsigned char rbac_page[12] = { + static const unsigned char rbac_page[12] = { 0x1B, 0xA, 0, 0x81, 0, 0, 0, 0, 0, 0, 0, 0 }; - static unsigned char timer_page[8] = { + static const unsigned char timer_page[8] = { 0x1C, 0x6, 0, 0, 0, 0 }; unsigned char pc, page_code; @@ -477,7 +477,7 @@ static int jumpshot_transport(struct scsi_cmnd *srb, struct us_data *us) int rc; unsigned long block, blocks; unsigned char *ptr = us->iobuf; - static unsigned char inquiry_response[8] = { + static const unsigned char inquiry_response[8] = { 0x00, 0x80, 0x00, 0x01, 0x1F, 0x00, 0x00, 0x00 }; From patchwork Wed Feb 26 14:17:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Jonathan_Neusch=C3=A4fer_via_B4_Relay?= X-Patchwork-Id: 868931 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 764C522173D; Wed, 26 Feb 2025 14:17:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740579452; cv=none; b=c8dvixlJ3YomvY2Kiz0JHbnECUQItvQgkeWsrM9G7+ugoXXLF/7K1l8gwLA/+6fKyOim0MMUi1uPQjCzZnC9hEhTYa+QI+z1oS+gemzz8GKLjVIVQEmLFRBbuSu1aJ/T4tC4juHFxe0/g1Thqh1vLmNUNRg0MoorL5jnyA6vDJo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740579452; c=relaxed/simple; bh=jUkw+0qqo77n7xl7JQ8f7bG6tUCWZhM6MFwDw9efri8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=q2Fe30v4TMqifHMuf5TObJ790XQtrQeLlhMTaDXPF8NfH3NO1YxiZ8nK1KNcSbHvloN7wpsf8uOvzlwuwZlDYsaknb49+5nm9aDRqTXegt7WcU05iuTHSCWP34JjISKl0xJ94/hNLnXTsqW19v6NXbxjAEppMkOkCYZRlgnNGxg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZFqTgdqE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZFqTgdqE" Received: by smtp.kernel.org (Postfix) with ESMTPS id C323BC4CEEA; Wed, 26 Feb 2025 14:17:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740579451; bh=jUkw+0qqo77n7xl7JQ8f7bG6tUCWZhM6MFwDw9efri8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=ZFqTgdqEnETyo4qOK+Clnop91Czl0Sa9/OrPpeyGThdjKCabO+qXzrOI3RjXv4Z7C xzWrjC0uO7ebke+A4J3RvzgmSH5j5OC3w/jTgKg/C82J5yctMWkItY24xDfAslN2GV p/ayCdrCyznPf5fzcqByEIGUYZbXiACPkdqu5P6NiWvKThxH2StueFK96JZq5dePjY QqGHt/DFr/P3qfAU1OE9e11Yiocz3UTcP9VuZZcrKX81UAPK3avQQHIXQUH/S+aou+ MRipkELplPYU66ycGQP4yIk+QhqRtD+5nA6orlUIYcwG+wHKBdcCSP97i9pL4l1rqw aBo4bdEBahjtw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBF54C19777; Wed, 26 Feb 2025 14:17:31 +0000 (UTC) From: =?utf-8?q?Jonathan_Neusch=C3=A4fer_via_B4_Relay?= Date: Wed, 26 Feb 2025 15:17:27 +0100 Subject: [PATCH v2 5/9] usb: storage: initializers: Use const for constant array Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250226-misc-const-v2-5-ab655a4a29cc@posteo.net> References: <20250226-misc-const-v2-0-ab655a4a29cc@posteo.net> In-Reply-To: <20250226-misc-const-v2-0-ab655a4a29cc@posteo.net> To: Alan Stern , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, linux-kernel@vger.kernel.org, =?utf-8?q?Jonathan_Neusch=C3=A4fer?= X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1740579450; l=891; i=j.ne@posteo.net; s=20240329; h=from:subject:message-id; bh=E3sv7MUTjUoAFshGx3e7fa3LASnJqeGyCGNhGtip8E4=; b=e9djsAqkZ4XnlACb+EI453tnroUtGkD58yGmdSWYpfkInGcsTwB551/xvIIPIytkjdEKrY7V2 3JcC++IDHIsAQA0IpzE4CRdD36/ISBdF8NxT402z/qLs60wHbX+Ydws X-Developer-Key: i=j.ne@posteo.net; a=ed25519; pk=NIe0bK42wNaX/C4bi6ezm7NJK0IQE+8MKBm7igFMIS4= X-Endpoint-Received: by B4 Relay for j.ne@posteo.net/20240329 with auth_id=156 X-Original-From: =?utf-8?q?Jonathan_Neusch=C3=A4fer?= Reply-To: j.ne@posteo.net From: Jonathan Neuschäfer init_string is only read, not modified. Signed-off-by: Jonathan Neuschäfer --- V2: - new patch --- drivers/usb/storage/initializers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/storage/initializers.c b/drivers/usb/storage/initializers.c index f8f9ce8dc71029aff5ceaf4d62f596a30bbceca2..b243bd5521a66deb3ca3603b52ccf603e191a4de 100644 --- a/drivers/usb/storage/initializers.c +++ b/drivers/usb/storage/initializers.c @@ -54,7 +54,7 @@ int usb_stor_ucr61s2b_init(struct us_data *us) struct bulk_cs_wrap *bcs = (struct bulk_cs_wrap*) us->iobuf; int res; unsigned int partial; - static char init_string[] = "\xec\x0a\x06\x00$PCCHIPS"; + static const char init_string[] = "\xec\x0a\x06\x00$PCCHIPS"; usb_stor_dbg(us, "Sending UCR-61S2B initialization packet...\n"); From patchwork Wed Feb 26 14:17:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Jonathan_Neusch=C3=A4fer_via_B4_Relay?= X-Patchwork-Id: 868930 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7761722173E; Wed, 26 Feb 2025 14:17:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740579452; cv=none; b=q30b05acZmFC53YTwFn0Vjd24RISEINjev8dEX3GKMbF0RYwRV+GrZxR5dGagRltMWPeI13RntbsHtGxAClpEEFd7bwU3OYKwOpNfaDxAKftQap7IyFhBQmdylttMyT7irqVXvCjMR69iHf/tIRsGmlUuK+hU6RZmAbQNQ2Z5Lk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740579452; c=relaxed/simple; bh=3+NFvBIkl2OxeODbUHRWrngU00eA9zNm0aCEsh3XfoU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bjWtWu+Pt8OHKVidA/FsxVhhgwy6S/tDtg7n0yaB0aelMWZNnpcGQbOafcos1mpPuTdut+AtVSfiIidzEa1dQUg4wr2p3fWOIDPAKKmyCUY9rIshxyjumIWPfPfp3Yupln39LNg8qRV8xiiGxMcXK/tXsRiJJ5bGpiVdT1eUchM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kMQ2D97N; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kMQ2D97N" Received: by smtp.kernel.org (Postfix) with ESMTPS id D7679C4CEED; Wed, 26 Feb 2025 14:17:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740579451; bh=3+NFvBIkl2OxeODbUHRWrngU00eA9zNm0aCEsh3XfoU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=kMQ2D97NEg1fnj8z9iPtJomtnu6AfWSQ0hkXTCGV2+A8azhcIJ0glpMjPQlIWRII2 tHQjGOoaFrxl1e/NclbWa6qBMcmEf8O7805AUw/LCMKBQkaXT+ZOlfYuge6k0vHFgv DDuXgwrDoMxZK+KNlDAP+VCDuWsBtruFSLYmKxfNwztBBm/CpPzaPo8I9hw7m32gCo fN8AcmRCgXayxYTtLwl5n6kSyIcKDzZXTV/JQbYD8/yIY1rHBSicEwbjof0RtFp7Fr 575VJiyN2oRsLBjFTYpxQ1P4PMpg1ys18FE5DY+h0smmkJ2L1VBbToM7uR1Xs1jgs9 Q7v8tyfaOyI5w== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC979C18E7C; Wed, 26 Feb 2025 14:17:31 +0000 (UTC) From: =?utf-8?q?Jonathan_Neusch=C3=A4fer_via_B4_Relay?= Date: Wed, 26 Feb 2025 15:17:28 +0100 Subject: [PATCH v2 6/9] usb: storage: realtek_cr: Use const for constant arrays Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250226-misc-const-v2-6-ab655a4a29cc@posteo.net> References: <20250226-misc-const-v2-0-ab655a4a29cc@posteo.net> In-Reply-To: <20250226-misc-const-v2-0-ab655a4a29cc@posteo.net> To: Alan Stern , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, linux-kernel@vger.kernel.org, =?utf-8?q?Jonathan_Neusch=C3=A4fer?= X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1740579450; l=1414; i=j.ne@posteo.net; s=20240329; h=from:subject:message-id; bh=0nUrIAObJf+vvhJgWgBJJPr5uidrcg9fnFV47ZCiRf8=; b=yNC8wwiEJpTwvZ2ZJcdEasNQZyUBepYeM9CxLx3+7xPGzfB6agD2VCgDgaLyYzOPS/QjqWoKw keq/0ubOI4IAhaZzRPcNLUiTrJ1SF2xK8nJOoshhOdDNMNqO9LITQLs X-Developer-Key: i=j.ne@posteo.net; a=ed25519; pk=NIe0bK42wNaX/C4bi6ezm7NJK0IQE+8MKBm7igFMIS4= X-Endpoint-Received: by B4 Relay for j.ne@posteo.net/20240329 with auth_id=156 X-Original-From: =?utf-8?q?Jonathan_Neusch=C3=A4fer?= Reply-To: j.ne@posteo.net From: Jonathan Neuschäfer These arrays are only read, never modified. Signed-off-by: Jonathan Neuschäfer --- V2: - new patch --- drivers/usb/storage/realtek_cr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/storage/realtek_cr.c b/drivers/usb/storage/realtek_cr.c index 2a82ed7b68eaa75993e786afeda0d5d3a3c3bfce..4e516b44513672ebe7889247a70043e0dd013bc8 100644 --- a/drivers/usb/storage/realtek_cr.c +++ b/drivers/usb/storage/realtek_cr.c @@ -191,7 +191,7 @@ MODULE_DEVICE_TABLE(usb, realtek_cr_ids); .initFunction = init_function, \ } -static struct us_unusual_dev realtek_cr_unusual_dev_list[] = { +static const struct us_unusual_dev realtek_cr_unusual_dev_list[] = { # include "unusual_realtek.h" {} /* Terminating entry */ }; @@ -797,10 +797,10 @@ static void rts51x_invoke_transport(struct scsi_cmnd *srb, struct us_data *us) { struct rts51x_chip *chip = (struct rts51x_chip *)(us->extra); static int card_first_show = 1; - static u8 media_not_present[] = { 0x70, 0, 0x02, 0, 0, 0, 0, + static const u8 media_not_present[] = { 0x70, 0, 0x02, 0, 0, 0, 0, 10, 0, 0, 0, 0, 0x3A, 0, 0, 0, 0, 0 }; - static u8 invalid_cmd_field[] = { 0x70, 0, 0x05, 0, 0, 0, 0, + static const u8 invalid_cmd_field[] = { 0x70, 0, 0x05, 0, 0, 0, 0, 10, 0, 0, 0, 0, 0x24, 0, 0, 0, 0, 0 }; int ret; From patchwork Wed Feb 26 14:17:30 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Jonathan_Neusch=C3=A4fer_via_B4_Relay?= X-Patchwork-Id: 868932 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74C72221739; Wed, 26 Feb 2025 14:17:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740579452; cv=none; b=mJQTMPaOpwKWenM+wL462VUfMkWhgOGrui5kFN5cpM7JG0kahg5Xn6QMiCZZMnP2qB0u45jZszS90zcFKd0j+HKC92YZEz9f8rkELYBx7XiyBvFvNyVnFJ+3k5JfgLneqlYYhCiMsSSCGnqTwq2TXsqz6LUGfyDQ5M9eJ8W90zM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740579452; c=relaxed/simple; bh=1RsQM3p8xDMxTY4Sd1Vra8yukKbT55Y/Ik1kgDjut/s=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cAI0g3z2VkXuoPLm9sHOOA3yKis/5AcRyssA0kDUdZrtMsvyLC9RpjgG/iV+Eug8/3DYdQ0aMJdxY49LAuRFXn5kE6UXKfQh3X0vfwbmJo8M6RrjnkAA0ZyqDaChxggedGbmP3HQXXiQGYN+hH5wCoPnQ/y35MTQl2LmB0KgA9w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LBR+PAyE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LBR+PAyE" Received: by smtp.kernel.org (Postfix) with ESMTPS id F37D8C4CEEE; Wed, 26 Feb 2025 14:17:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740579452; bh=1RsQM3p8xDMxTY4Sd1Vra8yukKbT55Y/Ik1kgDjut/s=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=LBR+PAyEsMdbhP/NhDkSKd+vahPw7zOf04xi9xX0G4zAbJaNVokwxgLhHFYw7Ce1Q 2Z3JBOc+0Tcr89a01GVRkuq49v1iD8s7A5ymuEcFMgJhO3dhIl0BJ5E9yRYXlvM0Hr S0Dj24xF7Us5hU/55AENwU1Njd+Ra1ueARN8xBqJCmheXiiWVJEqgnora3Q/b58KQI a2/oafebUfCBWJRhgYPJmLtNTN9YtP04lIQ2uF0J4M+sqxYpxcwArak3BYQB5yGHM2 HxkBCHwMasl0UMqQ6Ud0KJ8cPF0fSkx93A2tL0yYi1YHra0Fy5XGAC8v+5zfFrKVIJ H/9H3JA34fdWw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA84AC19778; Wed, 26 Feb 2025 14:17:31 +0000 (UTC) From: =?utf-8?q?Jonathan_Neusch=C3=A4fer_via_B4_Relay?= Date: Wed, 26 Feb 2025 15:17:30 +0100 Subject: [PATCH v2 8/9] usb: storage: sddr55: Use const for constant arrays Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250226-misc-const-v2-8-ab655a4a29cc@posteo.net> References: <20250226-misc-const-v2-0-ab655a4a29cc@posteo.net> In-Reply-To: <20250226-misc-const-v2-0-ab655a4a29cc@posteo.net> To: Alan Stern , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, linux-kernel@vger.kernel.org, =?utf-8?q?Jonathan_Neusch=C3=A4fer?= X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1740579450; l=1112; i=j.ne@posteo.net; s=20240329; h=from:subject:message-id; bh=C7r28z1CFDV+sjQ7yiPOSMNteEWeKSpRUku1z3cAVDw=; b=YuvuOBJy+MirOAneLt7BuRHA3K01RUAXy/oJzPdR4gMU/FUr1G0Dut5fQeBkMLP3Mqei9WLw5 /KKgx2FY460BuIB3Lj4iv23TkpxIWhNYdfxfbm3NITH3RwC8Wx4X46r X-Developer-Key: i=j.ne@posteo.net; a=ed25519; pk=NIe0bK42wNaX/C4bi6ezm7NJK0IQE+8MKBm7igFMIS4= X-Endpoint-Received: by B4 Relay for j.ne@posteo.net/20240329 with auth_id=156 X-Original-From: =?utf-8?q?Jonathan_Neusch=C3=A4fer?= Reply-To: j.ne@posteo.net From: Jonathan Neuschäfer These arrays are only read, not modified. Signed-off-by: Jonathan Neuschäfer --- V2: - new patch --- drivers/usb/storage/sddr55.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/storage/sddr55.c b/drivers/usb/storage/sddr55.c index d5cdff30f6f31f98d3d58ffcdd2426d7cd385cbb..b323f0a3626031905b946ce64ddf04539a6e3232 100644 --- a/drivers/usb/storage/sddr55.c +++ b/drivers/usb/storage/sddr55.c @@ -775,11 +775,11 @@ static void sddr55_card_info_destructor(void *extra) { static int sddr55_transport(struct scsi_cmnd *srb, struct us_data *us) { int result; - static unsigned char inquiry_response[8] = { + static const unsigned char inquiry_response[8] = { 0x00, 0x80, 0x00, 0x02, 0x1F, 0x00, 0x00, 0x00 }; // write-protected for now, no block descriptor support - static unsigned char mode_page_01[20] = { + static const unsigned char mode_page_01[20] = { 0x0, 0x12, 0x00, 0x80, 0x0, 0x0, 0x0, 0x0, 0x01, 0x0A, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00