From patchwork Fri Feb 28 12:50:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Breno Leitao X-Patchwork-Id: 869451 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 072EB26BDA3; Fri, 28 Feb 2025 12:50:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740747048; cv=none; b=kkxXK3qe62nBnu9wl9HkvoJ2S94ZOmrZZSL9T3n2ILYLC0N8zeDQ4yAnANzqxn6pCLmFHMnAvIaPofFSXrb9voq4hIMmyxeAExsRmtOHChxcCnN6Tns3YIPhV/J4qdP2CvQS4SDpxpBH4BJbbiRevbg5Qykql6K/zG3Qm44u6nc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740747048; c=relaxed/simple; bh=pm0c48NJ0Nn05osu/S/ixet/zk1sAPWRLWcPnS4ZWw8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KW7u9PQSFv6pmS2AzA6c0NP1It43o3ZCGSWjr5BLRHlOakjPo40OOZBiuZW5xqRpHeDcChU8yT9kT4SOiDuTI3rMiE28CcliqvtOL5jdsYBd0MXBRghyGvgilOatnGcxsQef2t7sUZTPgBK5y2YH9ZgXKokg39ovRH+iRks7E1w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-abee50621ecso282117066b.0; Fri, 28 Feb 2025 04:50:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740747045; x=1741351845; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Vu5F8kOGJPxz/Bb9hvRPkqvLvBYaBsXDHbaT2XVsroI=; b=gNa6MP44kqDh83AmEe6hQHRGOgAqwjradtm5fnCR8LFntWOYxcKylI4z/nyGVLwPLz 3jy1jFOUPnbxAOX63DQ6NUoUp8OF20zm4UCRhuJeEBZuXr54kStz1SnTE6rXtpyNCNOY qLLgQ4i0VCRYJ6AE7lzxPNdjj6wZIck0y6ULTpynJttJ1YJ8JZzC5sye22RpaJ8a1dlM 0j30/BptRTTt52qYPienAvv4WzMFpH5qOOqfQcXzjuK5QPGNtlY3k7cnYnkbhVi0uYNH klQKh1CKTQlH0JlHLFQovSae/hB/w4qQnqcUtnCJJ/OxE9lxbVq+7iA8Alvp2Yo90R0e Ft7A== X-Forwarded-Encrypted: i=1; AJvYcCVpyP/ycRPvV7La56MX/GOg8VCfuh6QtVB2TrCCXLI022dgZNhs2XSWrLjdz0V2NUxLMwnnrZVJKa0=@vger.kernel.org, AJvYcCXSzoePsefBmN7jabAKgzZPe8JR9LUug0N0vnWUgmAeT97Fa/abRrhKXWBN0ZRhRJSvx27VYGiL62LL2pkzPBXC@vger.kernel.org, AJvYcCXl8Jd1A2I8bLOhSIOUsmck2YYDDTyQTNEce2K+uAMZ1CtMF0vz3T9CS9wfg9/OnXO8HDmIA0aaLDkJkGaH@vger.kernel.org X-Gm-Message-State: AOJu0YxJMuDygTw1vxq7ERSCkRIowImepx8mLLp4scbWOyfCcQu/iFdY Hl8e94cqdmR2oafUe3Th7RCWaAbsaHK40FCTppJk60qw+HjcRD2w X-Gm-Gg: ASbGnctGa0KbAWxoWmlHDwhGFSPxrfLzXT4mpovfsD/HeYwIO4Ktg99iPI0idgVRrIq KXFpN+/Q/8ua2ovfOkpTtHJ54O1TkSPIf9dm2Vnz9ubKN9n28R4nuO4602xEXNZ6+6sF0KrF478 fOKyJrP6i7Cq/HMFJrR7i6ZMtZzJLXabP8/+B7NoslrjtgCioxPATEbhRn6dXuMG5KRSydIjjPC 5eqoJ6HhN8qki/lkHHeHdp+HuQZIIDeALK6VMCELnXQhz832yF/H4CinPZAXTQKRR5ZhZqORiv0 5d3vMCSCzhlUvUXgbw== X-Google-Smtp-Source: AGHT+IGoTkB8G9zu0wLyoN3+y9WXN/pI9PvDpVLSDni/NiKzOBNtdzKT/iBTK0L6ve9ppsIAWSFUGQ== X-Received: by 2002:a17:906:da88:b0:abe:fed3:9eb8 with SMTP id a640c23a62f3a-abf2687fe85mr413659966b.41.1740747044921; Fri, 28 Feb 2025 04:50:44 -0800 (PST) Received: from localhost ([2a03:2880:30ff:70::]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf0c0db671sm286062266b.72.2025.02.28.04.50.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 04:50:44 -0800 (PST) From: Breno Leitao Date: Fri, 28 Feb 2025 04:50:18 -0800 Subject: [PATCH net-next v2 2/8] netconsole: Make boolean comparison consistent Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250228-netcons_current-v2-2-f53ff79a0db2@debian.org> References: <20250228-netcons_current-v2-0-f53ff79a0db2@debian.org> In-Reply-To: <20250228-netcons_current-v2-0-f53ff79a0db2@debian.org> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jonathan Corbet , Shuah Khan Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, Breno Leitao , kernel-team@meta.com X-Mailer: b4 0.15-dev-42535 X-Developer-Signature: v=1; a=openpgp-sha256; l=1072; i=leitao@debian.org; h=from:subject:message-id; bh=pm0c48NJ0Nn05osu/S/ixet/zk1sAPWRLWcPnS4ZWw8=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBnwbEeH/ooJp0c8utMbt9uQnzkvKJwSxICby3JZ mcb+jM6YnKJAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCZ8GxHgAKCRA1o5Of/Hh3 bRUCD/9Mt6mmvYXEeiFuefxDnl4ZRpnPhImc8JbmJnJ/FIQ7nbRqqCGUeXxADGr71IK8+wUkkB/ saMVE9bjzZ28DzkDmS/IHROdREfzi/HaTP8kgYPaSdeiFH2IQIiNYMSYV4BT6/oaaZ6TwTNUL5j 6CW94JUujGiPdElhpF2LRNlFzIwsX/UX8ldNqtErKnnEcNUX7n0zXECn2x19eYe/2p9RAKVImqi ryZ8g4SQEKwa1is+X0f7eEQN8LYdf0rhGEcIQUJW10j4TGJ7LEvrO+Re4EUtVaL6Iq7+9tvBlOp 7jW8HVm/AbNMFJc9hpqXFVl8kSJZsPlBUJbCXxYPL64kKtAMHkgjBCJjI796rc7OJxKM+qhRj3c ukPwDs1d901yLuCO2z47EVdBZoVYp892YTFiMpNSLjCeUcmtlX49KOKn7Dwyk1yrayNrRmgX1Mw 0gC9GvGwwKzAi6fem6taaheHaNpuw8focqVvUswruORJGWHQXlMIngB7ShltRufNMxu67WEB5gr q/LL3kJT4QD1f2btS/bhXJwvYjJjQgCxd2Hf8HkJ9NPO46d5+c7Y+tmsG9VZ8dTO0K3CRbdMTCY Hw9DKk+ECXB7NxBuOT/J4uQW/LgA13glgufw4sVL1sJ6hNtFvVMTTBFb16TsHe7pnSeCYl46Txd /oAvH0n8lLREUag== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D Convert the current state assignment to use explicit boolean conversion, making the code more robust and easier to read. This change adds a double-negation operator to ensure consistent boolean conversion as suggested by Paolo[1]. This approach aligns with the existing pattern used in sysdata_cpu_nr_enabled_show(). Link: https://lore.kernel.org/all/7309e760-63b0-4b58-ad33-2fb8db361141@redhat.com/ [1] Signed-off-by: Breno Leitao --- drivers/net/netconsole.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index c086e2fe51f87..698dbbea2713f 100644 --- a/drivers/net/netconsole.c +++ b/drivers/net/netconsole.c @@ -850,7 +850,7 @@ static ssize_t sysdata_cpu_nr_enabled_store(struct config_item *item, return ret; mutex_lock(&dynamic_netconsole_mutex); - curr = nt->sysdata_fields & SYSDATA_CPU_NR; + curr = !!(nt->sysdata_fields & SYSDATA_CPU_NR); if (cpu_nr_enabled == curr) /* no change requested */ goto unlock_ok; From patchwork Fri Feb 28 12:50:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Breno Leitao X-Patchwork-Id: 869450 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEDF726E17F; Fri, 28 Feb 2025 12:50:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740747051; cv=none; b=YnIYKGnwn16IDxsxEw0dThLx5ME3rpR2lZLJigQJIqQ06Th2/zP1XbmnKPEgrx3DUPv/eWZvl7iB+eVLzeMAcRBB9gJ8MlU+ezj7FaZv01AvF4EApmmN49Ebo+dyf64Z8MobdCfkms5MF4mXktiZCnbE1v8WtK3/SZtAxOD+kjA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740747051; c=relaxed/simple; bh=HelmDOCiSVH0oYe5AbfcFFoJ/Ba6YNqbtam259+9iGE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SVRpGMozAcmhrIvt5SExUkHeJMXylOMRMJGJC/8aokL8FngsGChFJlcGI2OQa/rI9Aq3qEH8BRJXr7Ls0X8vQsx8qm5UCi8dIlE3HsVTEJJD9Kc6+VMj676GBUPLX1LCYXrBddeustI3d+jyXeZdPJCvh5uvPH535SkV/tm4uYo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-abbda4349e9so292521966b.0; Fri, 28 Feb 2025 04:50:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740747048; x=1741351848; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OhK35+BiG35IdJLkSjkxmypo8Es3ZZiEMfpt6eVF6Ls=; b=Ky6fzWNEW8n58yxm2+65q4yJ0LUOOzHvD0hHC3i2TIhC5ZiAoX4TX/EXCq5YHijxN8 kijSxgiA1RbIamu2TMdZCQZXSvlV0ex8kzb78SOcCn61IIs9E2dl6wbEjT0bKqt21Cmw ADSno09uMCLYCwNNmqisOdtr4uKRx0nZ+n9KLfRsKD7E7Q4+4UjWz6gIj8N1tuS/iXCw moqw5ftXeXr31ErGGnOg2M7qgcw3K+HOjUk3/SHuy7JgcXvcs86qS43lTewDCLuVxgHV x+SRUF9OHTyk+nymjq9l4ys6bXtfuBmYHUcjvPEAWn27Ws9fYgZcw9jcP+NTlKYxQ0W5 zkSw== X-Forwarded-Encrypted: i=1; AJvYcCUu2CtDHMJyU50WcFaaLg/sgtPS/u4lAETXqYZPezsrENRXEKME3CeOIuEF8SKhCI0kMaebLkFrFk/ot9kj8FEW@vger.kernel.org, AJvYcCVWAVieeMyTPUZR99mWpKu9th90OMVVZOllzUxszG4MKZPqdkEjYy8IBH/yQcTGxlIepLXUQEyIUMo=@vger.kernel.org, AJvYcCVnSOu4bpb8tulbfWOfap/GxZ0Gw50dMmaIxyTbJK/inc+fpObY/uZCCjJYGjOB0QYk9fGeT+4SdbQ5ZjJJ@vger.kernel.org X-Gm-Message-State: AOJu0YxHpUslTbnp6lZCBL0JPbrpO9iYeiBO6zbsuxtRlb6Z41ZT/jtc 5JGDFX0xxHHSLO2eFYG9C8ai30pTWaUudmz+A8vPHKxWuDQYvg1detg84w== X-Gm-Gg: ASbGncvP+tAPYZf0GXs2hspXieF4yq5rJ2BuhT7999v2kxRuVvE+z2wBTJIXNW+r4Qg AhUSXLuBfpLaBscq0wPmxtLwyF4eBEgIG5Kq6gapv5vRtsR/rYJWUuLPQVMUNYtypG3vhAII/DV gwEZODANqjseCEO0QLZb6rM+gMr2YzNyY77H6hJo5uRJc4MNNDAzJCeWWraMNSsrEnSkr4wCVEH iv5np+L7G7SaFTJ2LPwPWtT04dL2t722myxgjKOyzgH7DkDzOOIIio0afkh2FH7tDOflxhOOcAc u2Ns/e1ZKWOfeAn6 X-Google-Smtp-Source: AGHT+IEi6GG4q7h6Czla8F5HRsiaBM5uUvVEFc8Z5W+Gdl1t9LwTk9M3gyqzUDWfgbRKNU21Rocabg== X-Received: by 2002:a17:906:6a02:b0:abe:ce46:6226 with SMTP id a640c23a62f3a-abf2684aab7mr365028666b.36.1740747048144; Fri, 28 Feb 2025 04:50:48 -0800 (PST) Received: from localhost ([2a03:2880:30ff:2::]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf0c74de3dsm282418066b.125.2025.02.28.04.50.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 04:50:47 -0800 (PST) From: Breno Leitao Date: Fri, 28 Feb 2025 04:50:20 -0800 Subject: [PATCH net-next v2 4/8] netconsole: add taskname to extradata entry count Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250228-netcons_current-v2-4-f53ff79a0db2@debian.org> References: <20250228-netcons_current-v2-0-f53ff79a0db2@debian.org> In-Reply-To: <20250228-netcons_current-v2-0-f53ff79a0db2@debian.org> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jonathan Corbet , Shuah Khan Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, Breno Leitao , kernel-team@meta.com X-Mailer: b4 0.15-dev-42535 X-Developer-Signature: v=1; a=openpgp-sha256; l=1183; i=leitao@debian.org; h=from:subject:message-id; bh=HelmDOCiSVH0oYe5AbfcFFoJ/Ba6YNqbtam259+9iGE=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBnwbEe301Sb0AKLT8rFcoVzhgcn+pZqZij3ml1u CG0sIXfjPiJAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCZ8GxHgAKCRA1o5Of/Hh3 bRaHEACGkaxq34Y4XQELZWMecCTu3lPxRsf98bW5ISjqhmSyigV6AZnFUGKoOggadE9xpZuO5rw TQTQ5DmHb1ZXduCietVDiJg7eUJ59sBu/iiWGRzEYqYoES/5nA9NNCNPxKxuz2cC7vHxxheIS0a XHI6hshm3S5CQ1nQv832PteQ7OSC9ZYJ4Q0wDWxUvsBPphVww8/vwuR64y6Tp7IxOYbckcoYBoL j2ZNjZY15NLs0oSGqLD/Dt9a8QLcZBznAZSDw/oxGKKNt0TqusQqOHn/8ToV3IUSjOJUdHPNd+U bibSkAPB6VBHCyM0lOZHDRidT2WckaTcgv1UD21MoxQBPjorXpyTULrW7PtuQyv77a4K9Ouw7Lr l7YLKHlSszT3qraY4fF/amA+qD+eVpDlFvQMNg7Sd9wLb+Iz8aTWeEonfumzff2byxPp7wJdpig CzTzeBUapkb/P6CZoT/pZ8d+wFf6kcoeI6N2/aZoZFyi94D2ZofGRZDYnA7aMbwV7yM8RHdgPMX WCQhckEdJ3JDTycwslmIw4Z4+OhZHahk2GGldL71k2qwdPB8YdJNEQ1TREgOfzSDJeP2FuAH6ov 0PEyp4hR8JqTTTwh9Je7yEKWDdWEifGDfDPWxDE/NybHat975OZBUNqoymeHotHZXKxXr9fwFc4 UJuWyr+r1gkXZQw== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D New SYSDATA_TASKNAME feature flag to track when taskname append is enabled. Additional check in count_extradata_entries() to include taskname in total, counting it as an entry in extradata. This function is used to check if we are not overflowing the number of extradata items. Signed-off-by: Breno Leitao Reviewed-by: Simon Horman --- drivers/net/netconsole.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index 96153fd01f46e..f46a0edf9c11e 100644 --- a/drivers/net/netconsole.c +++ b/drivers/net/netconsole.c @@ -104,6 +104,8 @@ struct netconsole_target_stats { enum sysdata_feature { /* Populate the CPU that sends the message */ SYSDATA_CPU_NR = BIT(0), + /* Populate the task name (as in current->comm) in sysdata */ + SYSDATA_TASKNAME = BIT(1), }; /** @@ -701,6 +703,8 @@ static size_t count_extradata_entries(struct netconsole_target *nt) /* Plus sysdata entries */ if (nt->sysdata_fields & SYSDATA_CPU_NR) entries += 1; + if (nt->sysdata_fields & SYSDATA_TASKNAME) + entries += 1; return entries; } From patchwork Fri Feb 28 12:50:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Breno Leitao X-Patchwork-Id: 869449 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D18B26FA73; Fri, 28 Feb 2025 12:50:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740747055; cv=none; b=rZB/1YHvAN5BRDkAD/86rTCTFjASA3s2Sj8EqS/O8CXtvKZTtmtnrdfJXn054AIvhDy75pJzMVFSL9MMVAmYwMqdz+mXaaE14xtMrXSNbf0wy97yqKcrdEDRE+ui54Fja+O344GMwksu/aeIQ6mHwJeI7VmVCjmvxumWLR0g/uw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740747055; c=relaxed/simple; bh=8C+nY21yevsU3UwMdamo0a9NlqQBPI9CGp6TGPaKLJE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BXV/uU5YYNvdkRD8J0Vk4Bm+elYipMK10VUp9ileVHFxC6++6X3YkYLQVGiRGSobZ+MXg/HigJ/KFdSwSu9ob/BLspvgSor4VoMeT1kq3XDxWqtZq0ypEgj+Bqy/YH1IBuWUgJgQEPp3XtnRBQLtn+FODCJspLi/Cdc7TgFDsXs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-5deb956aa5eso3148447a12.2; Fri, 28 Feb 2025 04:50:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740747052; x=1741351852; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+EDxdX1XBRovJcfFvztzdNk452+H0oR8ZEN7mPlg0dY=; b=iz/MHgibw6QQspFqpDzu07unrS8gTcJ63+6WqI9U9czBRcraROL99hVJyQzKJkVfZ3 j+9iB55VAnZr9K+V4LcnflahJLw5A5jxMVnWG7rkie4vLprFQvDj5XzSSG9jI8GFE0x4 vUcwO/k/EPhGYo3XEG7sHXYIjsT0WPHw6eKAXY92oIE53qDx4/jRy080JkZR9TA32SOC lbLtvuo5rLkS9qDoDPv90hZmGvj2lBAnckkqWXE3ck4FepA1y7/qKHMsXxv9/j8VuNF0 cJgcue6oXDQbFWPY5oRRxZIXTlepAI4H71y+64JlgDpJ88TW+3i+zYNUVnIeY0UaRlB0 6JsQ== X-Forwarded-Encrypted: i=1; AJvYcCUboxH4ZrCl2wQ2cB1SM2H9NL+pbFHHcZigE5nl/ro4q7iZ30CE15Hwd/yAq3H8maE7LGJFd8gjDiFBhcDGx37x@vger.kernel.org, AJvYcCUn03+4mY3PpHU90sWth1r9OH9WjwYS3zN6QBMdo83kVsS02Maeoe63yuSFxoaWdoyP5ciGdriHnKdOIpSs@vger.kernel.org, AJvYcCVVp5jfXgbOC3kVhAu/W6S2xF5rCbUbSue40P/R0XGYFNB0OY0iK8PlmejTSc+9pAkYlfMMAUpc/oQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+Br7XQOxTEMR+3djTd3R3zroQiD+QUCcqBnNVqSagUl0ga2Y0 fxu9j5o1Xo+VTzo3FxQVMpkqqCpMTVj0Y0FwuAxGNT5LRYVu+GZTQT4I6g== X-Gm-Gg: ASbGnctUBQCgNLS6gKf7VM0jES5Qa0TB45qAyng6Ie4N8afRK0PG7lCxunKLAlAOOCB FanhcN/dpAaeCzhYnf2ouMD5XpZAAbwksp8ntupiFtXlMxHBe8wcrQRAlKV2CJYYzelLwQI8mNS tIFG8uAZkS/UHSbWYxc2Acc2kec1CEGgyDp9fqW3Jk0+wnpKNqe5/i+ozDovG3PEV7aGF+iK2Zx cymL8UzbHjOh9UHQdKQnsypG/UvubfrWV71N+9Z8WruwywETC1WO4F5e6cSlIPsX9QNSI/FIC1k 6uIzCgv1uwKp9g== X-Google-Smtp-Source: AGHT+IHFTyi2Am6kv+da94xkq47KOQe4s4UOqJfTE+pf4N1crcnYVkWFX0RbgEYNbOpaLWRqJqhI7A== X-Received: by 2002:a05:6402:13ca:b0:5d0:c697:1f02 with SMTP id 4fb4d7f45d1cf-5e4d6af43famr6945957a12.17.1740747051629; Fri, 28 Feb 2025 04:50:51 -0800 (PST) Received: from localhost ([2a03:2880:30ff::]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf0c0b9b0esm285376866b.1.2025.02.28.04.50.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 04:50:50 -0800 (PST) From: Breno Leitao Date: Fri, 28 Feb 2025 04:50:22 -0800 Subject: [PATCH net-next v2 6/8] netconsole: add task name to extra data fields Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250228-netcons_current-v2-6-f53ff79a0db2@debian.org> References: <20250228-netcons_current-v2-0-f53ff79a0db2@debian.org> In-Reply-To: <20250228-netcons_current-v2-0-f53ff79a0db2@debian.org> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jonathan Corbet , Shuah Khan Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, Breno Leitao , kernel-team@meta.com X-Mailer: b4 0.15-dev-42535 X-Developer-Signature: v=1; a=openpgp-sha256; l=2066; i=leitao@debian.org; h=from:subject:message-id; bh=8C+nY21yevsU3UwMdamo0a9NlqQBPI9CGp6TGPaKLJE=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBnwbEeR0dUuM8iy6feHnneIR8HKpF3jdXbSrH5j hoBCqF1+RyJAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCZ8GxHgAKCRA1o5Of/Hh3 bXl7D/41F7oovHfDcfl8vMTILBOt4iEFQ7/NLgJk6Wnzsj2NPGLRpGBM341RmrEyUK2lTR0d2MX v7kebcOPnOjXtfJozzSbob/iZGvOLEJsMvf0CBqMOTDyuFtC8t1sO3ChBRGhDBjaLYIO6lE2Qr5 w5qJrzn/+g3vpLsBLcPRDIZl97tiqEeRnCpF6TLnzdIsmynmNGRVmlFMbYe7OAsEpu16ikqt1Tq amj4wUFUP0VCr+SykKpTfDKOC5yrbIsblI/US6m+04ZXlQT5ErDDJV8RDv77WhVUmRXvV48Kdj2 dNcYzARx2XmEZnga+DV8+YBdJkJqinKgl8JaGqRzJM58ejKva1pmWbH0XbunNR53Wlf8+YeoVZj peVIoPzjxFCvjGLOWqxNLs87YR+JKnJ52snhk0VCn/REIkYsx8pMBKfSmtclKXq6Td+5uu64bPU XGYPohTT+2kRaPkzSaFgAzvVdY8DT7K0I4UoHNob+Du2RIuxAXYD+0uyyqi892p7mGGr5J97/6g kK/3BpPtcGbhRjslo+LFl+6fGuQxuw1Gm71RfTpZTERKU9yB/8q0QzW9puXJhHo2aF//UjmoHrs HtIPxWLQjrGgU9zmsqm0m0UDFNR8CMuUcycdsHK8StT38YPeHtCWaLnadhciqSQZujBXj6nvOnO nHB3WdbwFBh/oSw== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D This is the core patch for this whole patchset. Add support for including the current task's name in netconsole's extra data output. This adds a new append_taskname() function that writes the task name (from current->comm) into the target's extradata buffer, similar to how CPU numbers are handled. The task name is included when the SYSDATA_TASKNAME field is set, appearing in the format "taskname=" in the output. This additional context can help with debugging by showing which task generated each console message. Signed-off-by: Breno Leitao --- drivers/net/netconsole.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index 9798b2b409e26..098ea9eb02373 100644 --- a/drivers/net/netconsole.c +++ b/drivers/net/netconsole.c @@ -1179,12 +1179,19 @@ static int append_cpu_nr(struct netconsole_target *nt, int offset) raw_smp_processor_id()); } +static int append_taskname(struct netconsole_target *nt, int offset) +{ + return scnprintf(&nt->extradata_complete[offset], + MAX_EXTRADATA_ENTRY_LEN, " taskname=%s\n", + current->comm); +} /* * prepare_extradata - append sysdata at extradata_complete in runtime * @nt: target to send message to */ static int prepare_extradata(struct netconsole_target *nt) { + u32 fields = SYSDATA_CPU_NR | SYSDATA_TASKNAME; int extradata_len; /* userdata was appended when configfs write helper was called @@ -1192,11 +1199,13 @@ static int prepare_extradata(struct netconsole_target *nt) */ extradata_len = nt->userdata_length; - if (!(nt->sysdata_fields & SYSDATA_CPU_NR)) + if (!(nt->sysdata_fields & fields)) goto out; if (nt->sysdata_fields & SYSDATA_CPU_NR) extradata_len += append_cpu_nr(nt, extradata_len); + if (nt->sysdata_fields & SYSDATA_TASKNAME) + extradata_len += append_taskname(nt, extradata_len); WARN_ON_ONCE(extradata_len > MAX_EXTRADATA_ENTRY_LEN * MAX_EXTRADATA_ITEMS); From patchwork Fri Feb 28 12:50:24 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Breno Leitao X-Patchwork-Id: 869448 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEAC32702CA; Fri, 28 Feb 2025 12:50:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740747058; cv=none; b=GKDujVPgjQ1mvF91Ps77ceQj8CvO3ZAuIyiAS/cJEEn0n5IOHMX0/1ZyPo9uun9mupLqGrfEoXo+ICl9Xr+lyua/zDUedyTcIqn9iWT+a6I6MwWSwHyHmskd+YQ9T9TQWZ3gAcFsmHjW2ev40EiKICDvjD4cUPpTb1RPEpFZUdI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740747058; c=relaxed/simple; bh=bQuZdV89ViO+C8ea3V/SA2TtywKFo513J57gSGk0RZk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SIbgM5/n6IwmfK0Otf4DluCjot6CceKxwy7L7Ai4GQx88SVvcGUdP3mVM1nuNHhcFA6MEciKiew35LHJj8eykEk1fPp8fdSXb+wYwXmLwZa3wBZXYVeaL+dNeLn+hu1PpiJyFuO/ynyFEJRfeNWjDLfzRFz597dd+OxaYBSAnkc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-5dca468c5e4so3442038a12.1; Fri, 28 Feb 2025 04:50:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740747055; x=1741351855; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/RoRzffhAWFwu1880cu+JXgdjT1m36rkED8fGCNHUI4=; b=aiPDD2HXMJSnbnG/m/qGTXY0aC+dfiRmOnGSbK+IFwbTolxRYCZNceDZNdb9kHFznb LYHcFShCk0KJe9WhM6zZCaaRB9FWJqRpjVQCaaizCjFyePTF4YwZ3hrXj6kdUKKMf+n3 AMLd8zhiDehfB9d2J4RYgGOPkH0x86+7P9taTxP08zEFMY4CSH9PcijuQaroNdUIpyyk TGphpLVNa6p6sAvrF31g9Is35HCkFP/7oGchlD6X6VyLjhJz0jUfHdBRgGq7QcF/v08m 0ujXtnvG9n0wwv8YVR9SIF9aZ+dbS53xb8hBrpVLZAR9DnUs9qUFLbBlWBvsdjXm3irN d3RQ== X-Forwarded-Encrypted: i=1; AJvYcCU06KbnkicGDmbMNTN/MbTpi6BbkX9ZDG2sdS5J4eIPO7bC3PnbvEkz3+Zno23VUJEE2K18zDszetDBGkcsxhAb@vger.kernel.org, AJvYcCUqLjXagfJtxgp8wA0nVQRTRW1DoLSIrqMIY0Pr9d5DVea+i1qnbCOE3C+AtZPcqWd8R0BbrmG2y4QGlyQT@vger.kernel.org, AJvYcCW4XBKeN98aLIrIRRfTB4FWpwenIwaAaZPGOCXrhD9Secvs7x46lrV3NAstp+C9jqSLNJUPbvrbuSs=@vger.kernel.org X-Gm-Message-State: AOJu0Ywg5XrSJsMi2J9FnLly5ChhWzNb3hPgon/6Q7GimwxTt6JZ+tmY sFUE5ZFoSxMuNRFQM8CASUQaptLfbEJgTj+STTfN2Y1N50eCU+3C X-Gm-Gg: ASbGnctlQ+pk6s8PAP98uWY7zFNt2mH46ih+Xqp0ijtEnGNBohs0th9QNQOewMQKqiD dgEh+D5y2Xi9UbIumvo9NNzZRCJOq1KL2zP5MwH8M/IkkCbffKxhrdvW5dn/6w3hUFzGcJjgw4h mT+IDGQLHVdoyZUTEQVRqYVIXHOv5SVS7kmqGs/12baY0FNL/3cPrM5e0/fiSeL8tVs/89ItR12 wpCZ1LduqVtPyF0/yHBmal5XCsWEigxmiXgK9oh0xFGC/ZG0h8AuNKME7SP1zOEb8Ms1mWn/xb+ ijHkpfnVVN0ZkAVX+Q== X-Google-Smtp-Source: AGHT+IFpcD4G0piaxn5eQhCYdsfhQ9AlB7Wf9C7Rk0yV7/3HEUfMAwI1lrGIckYABSHHB07CwJusEA== X-Received: by 2002:a17:907:98b:b0:aa6:a87e:f2e1 with SMTP id a640c23a62f3a-abf26824d2bmr366979366b.56.1740747055099; Fri, 28 Feb 2025 04:50:55 -0800 (PST) Received: from localhost ([2a03:2880:30ff:73::]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf1f1d5b4csm194129566b.85.2025.02.28.04.50.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 04:50:54 -0800 (PST) From: Breno Leitao Date: Fri, 28 Feb 2025 04:50:24 -0800 Subject: [PATCH net-next v2 8/8] netconsole: selftest: add task name append testing Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250228-netcons_current-v2-8-f53ff79a0db2@debian.org> References: <20250228-netcons_current-v2-0-f53ff79a0db2@debian.org> In-Reply-To: <20250228-netcons_current-v2-0-f53ff79a0db2@debian.org> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jonathan Corbet , Shuah Khan Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, Breno Leitao , kernel-team@meta.com X-Mailer: b4 0.15-dev-42535 X-Developer-Signature: v=1; a=openpgp-sha256; l=4252; i=leitao@debian.org; h=from:subject:message-id; bh=bQuZdV89ViO+C8ea3V/SA2TtywKFo513J57gSGk0RZk=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBnwbEeOlpLZz+jnYyR9K+wnsSZH4aDZZ19EMuR2 yd/tIPKlICJAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCZ8GxHgAKCRA1o5Of/Hh3 bfaWEACiJ9VntVXYjyI2qIax5VJSP6kSsBySEMH1ZKxbeKgyGhZ93Q8ygigvOiBWKKyVWp4cfaO oRuJvy6JFosQlkRNhwQoyCm1F4/RSsDO0z9TJvE/qVQK/vu39fxUYo+pFIPfJTj1plmhzMEMtOt VQ4+rCN4z3ouvh5bZOyNJPSbZ/zvxesii7/2wQ3AJaFNHskeMaQeOJnaVn9Fshv8QzkaepCBAp4 JkzYe7KcVdkQujg0O7tjhpZ29f6LW23JWaHHa0VjqvATTnuOFDMTlGEJkDqsA1kn3PmQRfDb32n jsUnwcuDGi2xshZ4JUWp/ULtCRz9LDefmsx5n3ioJQ0vJ9mUnUlIFJJzy5DSySZaO4W7Nti9U59 S4Aycxv3dqWcW5e/vHnc7HiMFa4xz5H4bujSK+1qC2DvVvCMu+CNk27Lij5P2wusHr5dZ6kef9b F/GUc73TAYww4dz85ZXjDkCOpaLRR8n1aYnkR2OwvcclIJHyw22RCCic0dp2TWqGvsAp+ZA9Lzf mPwDxOrOKF+brh1JfZK+2WfBEAkmqbWHnZdWZv8HozdIk8Y0886xRiLvUa67gE24t3aVYiljfVX hgPmCZ4YwWAF9845e8Bs6HXPNuYWlPr5w9f+ds05MjoVVBKmKy9IAPRk442270AqfLgOSsKAgZJ OjVeK/SZqu0mMUQ== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D Add test coverage for the netconsole task name feature to the existing sysdata selftest script. This extends the test infrastructure to verify that task names are correctly appended when enabled and absent when disabled. The test validates that: - Task names appear in the expected format "taskname=" - Task names are included when the feature is enabled - Task names are excluded when the feature is disabled - The feature works correctly alongside other sysdata fields like CPU Signed-off-by: Breno Leitao Reviewed-by: Simon Horman --- .../selftests/drivers/net/netcons_sysdata.sh | 51 +++++++++++++++++++--- 1 file changed, 44 insertions(+), 7 deletions(-) diff --git a/tools/testing/selftests/drivers/net/netcons_sysdata.sh b/tools/testing/selftests/drivers/net/netcons_sysdata.sh index 2b78fd1f5982f..f351206ed1bda 100755 --- a/tools/testing/selftests/drivers/net/netcons_sysdata.sh +++ b/tools/testing/selftests/drivers/net/netcons_sysdata.sh @@ -31,17 +31,38 @@ function set_cpu_nr() { echo 1 > "${NETCONS_PATH}/userdata/cpu_nr_enabled" } +# Enable the taskname to be appended to sysdata +function set_taskname() { + if [[ ! -f "${NETCONS_PATH}/userdata/taskname_enabled" ]] + then + echo "Not able to enable taskname sysdata append. Configfs not available in ${NETCONS_PATH}/userdata/taskname_enabled" >&2 + exit "${ksft_skip}" + fi + + echo 1 > "${NETCONS_PATH}/userdata/taskname_enabled" +} + # Disable the sysdata cpu_nr feature function unset_cpu_nr() { echo 0 > "${NETCONS_PATH}/userdata/cpu_nr_enabled" } -# Test if MSG content and `cpu=${CPU}` exists in OUTPUT_FILE -function validate_sysdata_cpu_exists() { +# Once called, taskname=<..> will not be appended anymore +function unset_taskname() { + echo 0 > "${NETCONS_PATH}/userdata/taskname_enabled" +} + +# Test if MSG contains sysdata +function validate_sysdata() { # OUTPUT_FILE will contain something like: # 6.11.1-0_fbk0_rc13_509_g30d75cea12f7,13,1822,115075213798,-;netconsole selftest: netcons_gtJHM # userdatakey=userdatavalue # cpu=X + # taskname= + + # Echo is what this test uses to create the message. See runtest() + # function + SENDER="echo" if [ ! -f "$OUTPUT_FILE" ]; then echo "FAIL: File was not generated." >&2 @@ -62,12 +83,19 @@ function validate_sysdata_cpu_exists() { exit "${ksft_fail}" fi + if ! grep -q "taskname=${SENDER}" "${OUTPUT_FILE}"; then + echo "FAIL: 'taskname=echo' not found in ${OUTPUT_FILE}" >&2 + cat "${OUTPUT_FILE}" >&2 + exit "${ksft_fail}" + fi + rm "${OUTPUT_FILE}" pkill_socat } -# Test if MSG content exists in OUTPUT_FILE but no `cpu=` string -function validate_sysdata_no_cpu() { +# Test if MSG content exists in OUTPUT_FILE but no `cpu=` and `taskname=` +# strings +function validate_no_sysdata() { if [ ! -f "$OUTPUT_FILE" ]; then echo "FAIL: File was not generated." >&2 exit "${ksft_fail}" @@ -85,6 +113,12 @@ function validate_sysdata_no_cpu() { exit "${ksft_fail}" fi + if grep -q "taskname=" "${OUTPUT_FILE}"; then + echo "FAIL: 'taskname= found in ${OUTPUT_FILE}" >&2 + cat "${OUTPUT_FILE}" >&2 + exit "${ksft_fail}" + fi + rm "${OUTPUT_FILE}" } @@ -133,10 +167,12 @@ OUTPUT_FILE="/tmp/${TARGET}_1" MSG="Test #1 from CPU${CPU}" # Enable the auto population of cpu_nr set_cpu_nr +# Enable taskname to be appended to sysdata +set_taskname runtest # Make sure the message was received in the dst part # and exit -validate_sysdata_cpu_exists +validate_sysdata #==================================================== # TEST #2 @@ -148,7 +184,7 @@ OUTPUT_FILE="/tmp/${TARGET}_2" MSG="Test #2 from CPU${CPU}" set_user_data runtest -validate_sysdata_cpu_exists +validate_sysdata # =================================================== # TEST #3 @@ -160,8 +196,9 @@ OUTPUT_FILE="/tmp/${TARGET}_3" MSG="Test #3 from CPU${CPU}" # Enable the auto population of cpu_nr unset_cpu_nr +unset_taskname runtest # At this time, cpu= shouldn't be present in the msg -validate_sysdata_no_cpu +validate_no_sysdata exit "${ksft_pass}"