From patchwork Tue Mar 11 13:18:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 872678 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F088F199237 for ; Tue, 11 Mar 2025 13:18:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741699103; cv=none; b=SoHVucKibhQJprpZwE1FW+oDHQzWyjhmTYN6WFhCNYrtIuCxXMcbZUxMr7FWttUTELzMTkuthZ374z3ZDtD8hX85QFUGEWQVRIL5TUNEh8ZgZ7BiytTOvx1h9MlLLPwS5P5tCDtadu6LjjgC8GxhFfx/hhI7RYqQwdwxevO0GG4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741699103; c=relaxed/simple; bh=JQhRr6deSyIwx2zw/NuSPazbVfMmtvtNqOIabeeTs8Q=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=VPvM+oIv6CxmpbuXxl9LqhLAbxYZCQmaS9p5GlPMDrYOyKrT+hHOoEiA8j2UpRRVTuuGY8n7VBfGA9SxjXk7UzoIW2TsWj6Mv7BN1Ep/eFG0FwniNZpXBSCFvA3KVlHrKaMMvOY2svCbnEhBdLw06ZblOR0bHWXMqpOjuEqLVsU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=GqgZKTOz; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="GqgZKTOz" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-43947a0919aso46334985e9.0 for ; Tue, 11 Mar 2025 06:18:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741699100; x=1742303900; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=q3kjR3e+tUhw3L1FQAPtkpKMwUmzOI7e4dVWjhqVqwM=; b=GqgZKTOzQfPAi905c5YmvBCypQts0zgmtYFsl1TJpL5IEjPvx0l2LKgyd7njdeK92I DaDODI5yt2UwldUS0iWgen9/R5rjcRaTRgFSBAadwCZ2fXAmzBWq8h3wPCeNgmZrHR2d SoWQBObMopX6qhlYXtxyUaZSJqdaCxUFiNm1vHQm6qjqyKkz8TQ6PZhDTnbHeIDLTKdQ 4vD3RthaJfMTAydVeBc8bZ6oxxqYsE7dCsCJzmkJXQa55JZUkiYPHA+uC2d/i4jk9MoD EXvifftU5AwbZvOJuUGhvvw/Er3MHm179Q4lvlWN9wnTwcNOYKrg2ohWah9JzogTZZM4 9BFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741699100; x=1742303900; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=q3kjR3e+tUhw3L1FQAPtkpKMwUmzOI7e4dVWjhqVqwM=; b=ZqaUuTvujdqZkYP9xmNubYIL2FfKiIfYLAdEjCMu/9W6I0e/LXYxDGl6WhdmrNbwpP 1DxSUfOnt/BKd086swoqtwp5eAaSZtBROjqI5SL0vIyW6P78eSC64WeA4ggWn0Bn74rt Ma8gvKRaFIn1bZzUbrQ3QoQd/nbuWG2hiC7LnC7+XTIfe56hTLk0Hl27qYaCHtKX7qlr xKx7+/eqlxKjQPgubb4vSW0xFSzrkkgbeW7O/y8wv6Kr4BApOWBON6WkkAzmCM/IPDGe AURIXi0RcokkaoGF2UNB6ApeOcAzSKdyUAXgwDtI81YRL726hamcQLI/ri+oaDdLpoQg /ZRw== X-Forwarded-Encrypted: i=1; AJvYcCWpnI6MdLtGA27CxdbCAEl1hGRcqKyDJfYXGWcMVf7MNp+exBNSk5nvQpGDXTU1GuQ0ZMqE/81D1gY0z4/XoxM=@vger.kernel.org X-Gm-Message-State: AOJu0YyC1bF/zSjktNfPOk8IRUsRAf0M54ZoQq31w2hnnwyLGU4pg0yu AfvSysiibmxqWsE6UXYsfL9yJKXyB1/j6uHelLgJI4LhURWGs9sFp1GzFO+KAkN9K3LrPjSqMbh ao0lihlA8kw== X-Google-Smtp-Source: AGHT+IFvDSGF/OHbPFKrTNFDJv2bYNbhXrjsIZlG+nsyMMEqyV04VNqP84+SWfbxxSYLZ4nKYbR3gmw1XGhYsg== X-Received: from wmpz16.prod.google.com ([2002:a05:600c:a10:b0:43c:ee49:c14d]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:3ba3:b0:43c:fcbc:968c with SMTP id 5b1f17b1804b1-43cfcbc97d3mr87744455e9.7.1741699100416; Tue, 11 Mar 2025 06:18:20 -0700 (PDT) Date: Tue, 11 Mar 2025 13:18:12 +0000 In-Reply-To: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> X-Mailer: b4 0.14.2 Message-ID: <20250311-mm-selftests-v4-1-dec210a658f5@google.com> Subject: [PATCH v4 01/12] selftests/mm: Report errno when things fail in gup_longterm From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman Just reporting failure doesn't tell you what went wrong. This can fail in different ways so report errno to help the reader get started debugging. Reviewed-by: Dev Jain Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/gup_longterm.c | 37 ++++++++++++++++++------------- 1 file changed, 21 insertions(+), 16 deletions(-) diff --git a/tools/testing/selftests/mm/gup_longterm.c b/tools/testing/selftests/mm/gup_longterm.c index 9423ad439a6140163bdef2974615bb86406a8c14..15335820656b1c143b440b8a1065a025378e22a2 100644 --- a/tools/testing/selftests/mm/gup_longterm.c +++ b/tools/testing/selftests/mm/gup_longterm.c @@ -96,13 +96,13 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) int ret; if (ftruncate(fd, size)) { - ksft_test_result_fail("ftruncate() failed\n"); + ksft_test_result_fail("ftruncate() failed (%s)\n", strerror(errno)); return; } if (fallocate(fd, 0, 0, size)) { if (size == pagesize) - ksft_test_result_fail("fallocate() failed\n"); + ksft_test_result_fail("fallocate() failed (%s)\n", strerror(errno)); else ksft_test_result_skip("need more free huge pages\n"); return; @@ -112,7 +112,7 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) shared ? MAP_SHARED : MAP_PRIVATE, fd, 0); if (mem == MAP_FAILED) { if (size == pagesize || shared) - ksft_test_result_fail("mmap() failed\n"); + ksft_test_result_fail("mmap() failed (%s)\n", strerror(errno)); else ksft_test_result_skip("need more free huge pages\n"); return; @@ -130,7 +130,7 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) */ ret = mprotect(mem, size, PROT_READ); if (ret) { - ksft_test_result_fail("mprotect() failed\n"); + ksft_test_result_fail("mprotect() failed (%s)\n", strerror(errno)); goto munmap; } /* FALLTHROUGH */ @@ -165,18 +165,20 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) args.flags |= rw ? PIN_LONGTERM_TEST_FLAG_USE_WRITE : 0; ret = ioctl(gup_fd, PIN_LONGTERM_TEST_START, &args); if (ret && errno == EINVAL) { - ksft_test_result_skip("PIN_LONGTERM_TEST_START failed\n"); + ksft_test_result_skip("PIN_LONGTERM_TEST_START failed (EINVAL)n"); break; } else if (ret && errno == EFAULT) { ksft_test_result(!should_work, "Should have failed\n"); break; } else if (ret) { - ksft_test_result_fail("PIN_LONGTERM_TEST_START failed\n"); + ksft_test_result_fail("PIN_LONGTERM_TEST_START failed (%s)\n", + strerror(errno)); break; } if (ioctl(gup_fd, PIN_LONGTERM_TEST_STOP)) - ksft_print_msg("[INFO] PIN_LONGTERM_TEST_STOP failed\n"); + ksft_print_msg("[INFO] PIN_LONGTERM_TEST_STOP failed (%s)\n", + strerror(errno)); /* * TODO: if the kernel ever supports long-term R/W pinning on @@ -202,7 +204,8 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) /* Skip on errors, as we might just lack kernel support. */ ret = io_uring_queue_init(1, &ring, 0); if (ret < 0) { - ksft_test_result_skip("io_uring_queue_init() failed\n"); + ksft_test_result_skip("io_uring_queue_init() failed (%s)\n", + strerror(-ret)); break; } /* @@ -215,13 +218,15 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) /* Only new kernels return EFAULT. */ if (ret && (errno == ENOSPC || errno == EOPNOTSUPP || errno == EFAULT)) { - ksft_test_result(!should_work, "Should have failed\n"); + ksft_test_result(!should_work, "Should have failed (%s)\n", + strerror(errno)); } else if (ret) { /* * We might just lack support or have insufficient * MEMLOCK limits. */ - ksft_test_result_skip("io_uring_register_buffers() failed\n"); + ksft_test_result_skip("io_uring_register_buffers() failed (%s)\n", + strerror(-ret)); } else { ksft_test_result(should_work, "Should have worked\n"); io_uring_unregister_buffers(&ring); @@ -249,7 +254,7 @@ static void run_with_memfd(test_fn fn, const char *desc) fd = memfd_create("test", 0); if (fd < 0) { - ksft_test_result_fail("memfd_create() failed\n"); + ksft_test_result_fail("memfd_create() failed (%s)\n", strerror(errno)); return; } @@ -266,13 +271,13 @@ static void run_with_tmpfile(test_fn fn, const char *desc) file = tmpfile(); if (!file) { - ksft_test_result_fail("tmpfile() failed\n"); + ksft_test_result_fail("tmpfile() failed (%s)\n", strerror(errno)); return; } fd = fileno(file); if (fd < 0) { - ksft_test_result_fail("fileno() failed\n"); + ksft_test_result_fail("fileno() failed (%s)\n", strerror(errno)); goto close; } @@ -290,12 +295,12 @@ static void run_with_local_tmpfile(test_fn fn, const char *desc) fd = mkstemp(filename); if (fd < 0) { - ksft_test_result_fail("mkstemp() failed\n"); + ksft_test_result_fail("mkstemp() failed (%s)\n", strerror(errno)); return; } if (unlink(filename)) { - ksft_test_result_fail("unlink() failed\n"); + ksft_test_result_fail("unlink() failed (%s)\n", strerror(errno)); goto close; } @@ -317,7 +322,7 @@ static void run_with_memfd_hugetlb(test_fn fn, const char *desc, fd = memfd_create("test", flags); if (fd < 0) { - ksft_test_result_skip("memfd_create() failed\n"); + ksft_test_result_skip("memfd_create() failed (%s)\n", strerror(errno)); return; } From patchwork Tue Mar 11 13:18:14 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 872677 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C221B1C3BEA for ; Tue, 11 Mar 2025 13:18:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741699107; cv=none; b=oiQS1qbC6PwfYfDiC/O0IG3qh5Gxw0f9h9MiixbdFNqHF5RJg81MKhksFbDiAbGNGpYO+0sPDeI2DNUetGWG/4uptDRqEJ/n7l3EgSfIvYJ0Crrp4Ro8CL6O8TThpcAwFAt6OWpM/ORJePn5H1jN6QtXy7ww963TKgfE65v8geo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741699107; c=relaxed/simple; bh=YI+QfZYo+Ua4IptGRz3TLf+pOBqxcgMjursiHKuuqQg=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=nuX+3dq64WD5qXLLjPH7aT1Fs1bSOKB3cJq8M5UD2FJnbdH1B7ODgn5GoXjWvM2BdvzZFt3Fqir4B2lobDMBFai7Vm6Pud3n3tMKcGFd2NdRnCqYi5TWqQpY/l3zRkO5HWNFLu6vbXwOkaKvdP/8OO4NSjqehtjrDheJdinfZ1Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=EsN2Npuv; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="EsN2Npuv" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-43943bd1409so37916685e9.3 for ; Tue, 11 Mar 2025 06:18:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741699104; x=1742303904; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=mU0cRsNzbsuSP1E5sjoXt0xKYtlq+gxz63wOE52l3IA=; b=EsN2NpuvnZRBWPwHVjVhZUlAvWVacGYo/2PJwIenfRAOgHz1eyNNJMdMDLqHzqyvA0 aU469XLW91EJUqiyViSiO5yqrPIHoVG2eir/YAB2TkteKxe5xEFRH9Hhzbd+vcsVVbQ7 lr9cqyBPkHCSLnCzR08Fb/BDQcZarXiwL+iU90qkbMGeh3LYivhVc+BwbexhFUN+SvRz u62+uvLEmD/0hHvoO5Amfh99qGA6z4JU+zdeEFCTKfYmYvKk4NyKA0NzHMjPTCSU1ZaN BTXKoAJUkvsfUL16UdFuJeQH9WBQgwo1ZeCcTCdwqO37+B1ZAHsqkXSeqfB59Tfwi9TK dpEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741699104; x=1742303904; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mU0cRsNzbsuSP1E5sjoXt0xKYtlq+gxz63wOE52l3IA=; b=laqzFSWdFYYLn49n1WWBLMvUTQT+v5bOJY25rn5rRZDveig6oLRy/Udk304Z+K9gVb O3kiowBoc+iQz2IXBxDM/ASwNFyuh4kq7svPzxcxBrcklmlX7t+BSp8vLxZEyGAuZlSp g3nwumknmXKN8cq1Fi1X9F4MqC6ZOsQNQSVkhHVOGbL8ogK9jCitckHUEpTwAcQX5myE +wIIFpbmK8f0LjKq/Tv240/TB1YfUG8fT7geo9aJ+iCIBeVDZ6HtwywL49cVju/m+rfv z2xkpwQD59yUstx7OGE24qi5LebKoNa7225K0iJo/Tzdnn/P20tJrMWwdRbIsUBa+9/Z Wetw== X-Forwarded-Encrypted: i=1; AJvYcCXVRBg7mSHMN6BskkPff3wnWsbuoWvrYtqds350888/WOmx0TgEUN04tG9dj3raTz2YwSRCst6aGiwiN3biJ/o=@vger.kernel.org X-Gm-Message-State: AOJu0YzyfrF/5wS98ynYIkuK4YCDNqlUANuquhyn3uRzXrC6TCwCYlr0 UaH64k4ZKz4Y38B9xiLLqNEx4AIc0j+RiP/B1IaHDP/hQp7JrRRqh3wUi9LPo9kosX9tYF2bhOG a9qP/lXxfRQ== X-Google-Smtp-Source: AGHT+IGSV21QBYLlvs34tFS6Vj4C4TFSxgnu4bOOKFjZdG2VcNI1hO3z4RNOQPjlkVLg4FfQFOtvmKJGtJlrQA== X-Received: from wmpz16.prod.google.com ([2002:a05:600c:a10:b0:43c:ee49:c14d]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:46cd:b0:43c:ee3f:2c3 with SMTP id 5b1f17b1804b1-43cee3f0578mr100814485e9.7.1741699104325; Tue, 11 Mar 2025 06:18:24 -0700 (PDT) Date: Tue, 11 Mar 2025 13:18:14 +0000 In-Reply-To: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> X-Mailer: b4 0.14.2 Message-ID: <20250311-mm-selftests-v4-3-dec210a658f5@google.com> Subject: [PATCH v4 03/12] selftests/mm: Skip uffd-wp-mremap if userfaultfd not available From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman It's obvious that this should fail in that case, but still, save the reader the effort of figuring out that they've run into this by just SKIPping Reviewed-by: Dev Jain Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/uffd-wp-mremap.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/uffd-wp-mremap.c b/tools/testing/selftests/mm/uffd-wp-mremap.c index 2c4f984bd73caa17e12b9f4a5bb71e7fdf5d8554..c2ba7d46c7b4581a3c32a6b6acd148e3e89c2172 100644 --- a/tools/testing/selftests/mm/uffd-wp-mremap.c +++ b/tools/testing/selftests/mm/uffd-wp-mremap.c @@ -182,7 +182,10 @@ static void test_one_folio(size_t size, bool private, bool swapout, bool hugetlb /* Register range for uffd-wp. */ if (userfaultfd_open(&features)) { - ksft_test_result_fail("userfaultfd_open() failed\n"); + if (errno == ENOENT) + ksft_test_result_skip("userfaultfd not available\n"); + else + ksft_test_result_fail("userfaultfd_open() failed\n"); goto out; } if (uffd_register(uffd, mem, size, false, true, false)) { From patchwork Tue Mar 11 13:18:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 872676 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E1B01BD01F for ; Tue, 11 Mar 2025 13:18:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741699111; cv=none; b=Mr9NvTwXDiloc21vU0fftRlf2xnMYeZDRGixfuo1EMZOomKZT8j+6d6QRtQShX1Anlma1kAH8dCzMjbU318++SbLyjHz2588xlvWTCGGBJBL7L72NXGL2x3eDE5zkK9YZ8yrI/dMz7c1dn9aQWawgUBa9eo0G22ZhL9zzZbx59s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741699111; c=relaxed/simple; bh=ZAXSMCvr+IvZnGOVJS0yA66QSG3JhZXcjwBrekeGfBs=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=HaMIoQBNnBEn+N/LnDn1eefrT6IGInb/qa9iqparaKEIUWVq2ZAdvoAwJlYaAbdfpBDfeUbc8XmWSl/jOamt6gNP/bge4ENfGlYhENeYFmjya287pHJIF7tfXdg2D6wTGK0JjYJxiDzlKlROD0emtsfE0GXNZw22yFHi+FYMqeI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=nGHkQ7zB; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="nGHkQ7zB" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-43cf327e9a2so18475365e9.3 for ; Tue, 11 Mar 2025 06:18:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741699108; x=1742303908; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=LGBb/Y6S3RxkI/6vwf1UwhFj4ViFPcNM6Jmgh/1tpM4=; b=nGHkQ7zBfBAh0E2oqdVC8DoeXRBzDb5o6fd/qxgNVftEh5BfS8V8XMefPQupXWT6Cw OoQww4SZpH+2vtD0gKBju3YWOhP/JOvNWxnjtmAX5s+LhY3ahfCfVTWaSFD+yjeyK9lF ADOR8NupGkadboMHeDH0b4p0zjHiLs06Z4MNs4l9kHO0Ko6F01ojAkRgm4xdYJWq1M6K 6ORviiK+WXuyCoAXtM06rvSCk66nKR7C++Xlk5Ct5ruvb8JE8RGCaP1ehJ6fteyireFt gqsgKZcmBi23+CC4RMepurGCXka1zQ3mGBvEO2HUgqiN53E/O4MNM6yn3WgURyFj0DzD V4Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741699108; x=1742303908; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LGBb/Y6S3RxkI/6vwf1UwhFj4ViFPcNM6Jmgh/1tpM4=; b=kc6g8WlWPznBCcwrW6PJAsDUCqWj/yaeOlTJhHtsGQYRvqFCx3RtFd8zODCPXRsGTR UALjOEafVxw/vcywGc3YEQlYqRW8JsdAxCt3teN68NWPJW9CY64gUnUifngnTVqPjb9Y k9itTBzKbD1rLhwZvN9zwLsQn0nQGknnRrE1x7Kf/jVuhmph1lmP/MQs1X/K97nwZucq Zw3Fp+F/f5774IqgexL6QLOG/4XWEH4iu59rfy1TZ6bCR+ecFy6tkj1VAXWSr1xgZXst O9C8luthWlmPiWnnGgOkvprr3AYMpHQV6p2u8IAItErKEZutbIUq5gEwZccwqaEZhcXB 1H5A== X-Forwarded-Encrypted: i=1; AJvYcCXDdSfQC08oQYdo0SHOZpzTZBr5GjbCyWs08J5Iged1jIAym33w9Pu4dBd3B9qYT+P/viY5jSrI6RdjseBhhCs=@vger.kernel.org X-Gm-Message-State: AOJu0YwzaC8YiWxoB9wvSSeDROSWhyIhhNLpYNcrpI9UxjASvWEs88zj es6Mh3nbFs8zvue1uQGTEf7BTyfyvFPufvkw6lVX33YeioBqYuNfQMMckPX7FwhFAiJov0h5kX3 DYmF1hdknAA== X-Google-Smtp-Source: AGHT+IEB4Ugao+9oG4PoYlVLqRx0MnCh6L1DYai8LwtyRUN8s3dqA+kO7+QszcVXjAFc8ZgqGgWa+WHaCnWckQ== X-Received: from wmbhc25.prod.google.com ([2002:a05:600c:8719:b0:43c:fce2:1db2]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:4e8f:b0:43c:f184:2e16 with SMTP id 5b1f17b1804b1-43d01bd2167mr54372315e9.5.1741699108122; Tue, 11 Mar 2025 06:18:28 -0700 (PDT) Date: Tue, 11 Mar 2025 13:18:16 +0000 In-Reply-To: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> X-Mailer: b4 0.14.2 Message-ID: <20250311-mm-selftests-v4-5-dec210a658f5@google.com> Subject: [PATCH v4 05/12] selftests/mm: Print some details when uffd-stress gets bad params From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman So this can be debugged more easily. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/uffd-stress.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/uffd-stress.c b/tools/testing/selftests/mm/uffd-stress.c index d6b57e5a2e1d7611aa1588ee41601ce16117a574..4ba5bf13a0108435ce8b53340b9e17ccd47e859e 100644 --- a/tools/testing/selftests/mm/uffd-stress.c +++ b/tools/testing/selftests/mm/uffd-stress.c @@ -457,7 +457,8 @@ int main(int argc, char **argv) nr_pages_per_cpu = bytes / page_size / nr_parallel; if (!nr_pages_per_cpu) { - _err("invalid MiB"); + _err("pages_per_cpu = 0, cannot test (%lu / %lu / %lu)", + bytes, page_size, nr_parallel); usage(); } From patchwork Tue Mar 11 13:18:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 872675 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 835471D9688 for ; Tue, 11 Mar 2025 13:18:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741699115; cv=none; b=QBVQjQkmv/lv5S1/7iUJQ4cqOnxEvU9hzs/bs9RMX4+6Oz1M2aqvWesP68MTvZ1d1fK9t1L3Rp3xfELulKIW9w2EYphOaJ4y+ZQR0nwtdhph26oHqpSSf/tiMRj77Oa4PA6V8Z6Hh4zaQ96BIZgEXV+pevM3fpDyhDObX3wZm2w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741699115; c=relaxed/simple; bh=oSXuPp+IUOl5G2aP9gTCdmTe3j7rVMOxHg2aJoo6Efg=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=a2YC6HhZxZ3FXYSmYb/pkDLvhPcsfhAh7PY1vJ2FpCBQqZPS+GPHo5CT5nUayxzs+YbABsymZAHst9R9NYNGytBaQ5CGcUZuyf3O79rA46CbMjqvKWhPE9jFEabvpTG50GxaS9T6DaIQt9Oc2I49PWrU2976gpsYDXOdthFvrLE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=k2yLkTxQ; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="k2yLkTxQ" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-43941ad86d4so26659495e9.2 for ; Tue, 11 Mar 2025 06:18:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741699112; x=1742303912; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Vce7eh8mPMitMWqdtTQW3Xgxbt0OG8W7iuQCUiRo4Hc=; b=k2yLkTxQ2K7t2n59+V3hFbYpdZD6A/EB8ugtx/QgGx4dtG91o0lsNwbTBFftlyrDcG ePsgnqUCvkeAkHYrhj6BwgbSa1fWnDN+qRvKnxU9L6jlBvk3otMVj1HvPhoXhtWyXQ2i VnNoWZWUXpyDWrhcPhsM7OZgIqBeGCdoRw6VENCQQ+HI2VtPi8iGMoaeHQQxj1iSlLDS DlyBQHd70iZw9jkzdb4vocACpbwwOi1JEoZl5ogskJJeLzl5L4ANuY7D/R5CreBMEvnl GeuBxaep58xgXsyCeYvf+UsrFyfl8qKBcDJDNLNEn9iJQQw6u45ttvXHX9FzaUvz7aOB lXRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741699112; x=1742303912; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Vce7eh8mPMitMWqdtTQW3Xgxbt0OG8W7iuQCUiRo4Hc=; b=Lm0mMTVOCowIvfXiqZTuxZKe7cZMHNyWmg7SOjGE70s7r5404qGC+UftZpyyXnAhvN V+79N4tXNUTvht6fC3TNPGWTNCs5TJdaWrvuYeDGxK6kEmYS0rbvQlMXelWX2XB5IT5y L3FdexeK9Gy9DEhUDylS5vwc3xz9j9/mdtv7PaH4rO6CUYtySrmnWT2JmIjRerdmOp5l ZJLPFpxqxZD5/r9pKbbZ+hQje/ONDPzUU6evupfDrUn17IABh0y4RxdxFn0CNO5fkcC7 YWDUckgCgtnjQBtFL25OPF52j+xzcCXfv8z9CroC4tvIIj0Zp9TxR0IUahK6PKKA+HyL DC3w== X-Forwarded-Encrypted: i=1; AJvYcCW7OsNKf8jmUHMJ72clMscPkOEvVyMXBpik9jyJAi0L2ePizCYUafrgFWGDVL+OW7uyyBkY9oQBjF69QhtxtzY=@vger.kernel.org X-Gm-Message-State: AOJu0Yyj/rPsb1yZ6AIPHpeiOEJRpU5nkSMgaZC320crfFFFhKOTH+KQ NBP9poYBNkl8NSP42sc9HOJ64JbJzE1Eb2d5wIiirnzeph4tcGmL8A9SvXVp3wCqV3+SNLEtjIL XXEvceNRhBw== X-Google-Smtp-Source: AGHT+IH0f6ArUDAT+Z1aqU0gEtWgWP4WVJVxUFx2+ko5jUv3CK2PIBB6GlZGbkJUJj1SHrJwdvtnC7ZX3WPGDQ== X-Received: from wmbbi10.prod.google.com ([2002:a05:600c:3d8a:b0:43d:7e5:30f0]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:45c6:b0:43c:e7ae:4bcf with SMTP id 5b1f17b1804b1-43ce7ae4f6cmr119062035e9.0.1741699112009; Tue, 11 Mar 2025 06:18:32 -0700 (PDT) Date: Tue, 11 Mar 2025 13:18:18 +0000 In-Reply-To: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> X-Mailer: b4 0.14.2 Message-ID: <20250311-mm-selftests-v4-7-dec210a658f5@google.com> Subject: [PATCH v4 07/12] selftests/mm: Skip map_populate on weird filesystems From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman It seems that 9pfs does not allow truncating unlinked files, Mark Brown has noted that NFS may also behave this way. It doesn't seem quite right to call this a "bug" but it's probably a special enough case that it makes sense for the test to just SKIP if it happens. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/map_populate.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/tools/testing/selftests/mm/map_populate.c b/tools/testing/selftests/mm/map_populate.c index 5c8a53869b1bd287b09a250edf628a66c25c2439..433e54fb634f793f2eb4c53ba6b791045c9f4986 100644 --- a/tools/testing/selftests/mm/map_populate.c +++ b/tools/testing/selftests/mm/map_populate.c @@ -87,6 +87,13 @@ int main(int argc, char **argv) BUG_ON(!ftmp, "tmpfile()"); ret = ftruncate(fileno(ftmp), MMAP_SZ); + if (ret < 0 && errno == ENOENT) { + /* + * This probably means tmpfile() made a file on a filesystem + * that doesn't handle temporary files the way we want. + */ + ksft_exit_skip("ftruncate(fileno(tmpfile())) gave ENOENT, weird filesystem?\n"); + } BUG_ON(ret, "ftruncate()"); smap = mmap(0, MMAP_SZ, PROT_READ | PROT_WRITE, From patchwork Tue Mar 11 13:18:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 872674 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 906E4255E37 for ; Tue, 11 Mar 2025 13:18:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741699119; cv=none; b=HmDIlmPj9KOoN/c8p0opsjgvsDlKxc0KFHrjvnLfd2i08569/62FhOjVFoMCIQXBVZlqKauqioP+6RWxa0JkhFMfwDVGJqt9N4LnKbk18KBv0Dk8JRSbC6qrY6LQ5zjOCJ3/uFRr7vpnD9d+xE7/WmrAMoND/T5WjI9RLLnIo/w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741699119; c=relaxed/simple; bh=TZCEoOVscJhi1eVQtBkTLxAR5uWerpL1QhTHsmZs710=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=HVnqYuSM6volUkMRmzGgDAOgdHqA9LbNwICLwU8UyhCNwDRfBhwitZEfLmbxGFQPIqCVk/e2BmiPQHEMbvjZoclrwDx0iGxEawq22mO/TESHi+pO5XLwIiSiVzrojuyApKbHnyq+h0Y15AeDyusqm7YuS0YTxLDNzFVYVDnwzc4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=gPIargED; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="gPIargED" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-43cf64f1dc5so12735565e9.2 for ; Tue, 11 Mar 2025 06:18:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741699116; x=1742303916; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=ezfRKweWcsi8VDsOy21QFyFbC65YGuaZroNiYeoxlPc=; b=gPIargED1npa5FTeBubhvT9SAcepTZ61BqJzmsJ7P3EGcVoCvbdkmQqKt5UtgCZMbB yc3yrxi33zkJH/OhaugWuqtxrs4VLF9cj8UNB8Pu2xWgpmPOPGvyGgwAE9rcVIw39hBH yw1Gi/rHxoq6c9ajpxKuS61ZFgKu6PH8pWBGo5rXFdteiCx6O32eKUPyz44xVXB2YsNC r0OxccIIXrQijIFVSuJxr1PY1XbexowNrwCWG8izUr4Wn+rmqp5vxRb+qgohgBEPUQc8 Kh02e+nax9M/bJBOCjRmbnNu6MYAJc3e7DTmQYMzjz1WOyqsJsxcSLlJ0NbOvbwhZK4p tW7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741699116; x=1742303916; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ezfRKweWcsi8VDsOy21QFyFbC65YGuaZroNiYeoxlPc=; b=HHeZN0W+tF6S1pAZ+EQt/EJ9pNoqCK33ffRcaWHzOQ7dLWq1BXN1WScDl8c0yPYNoK +WjlACOyrW7wlFAY8j2NMLGU87hR3v8a9uEnscsfEl6EI0n7QzO1+6v0TCkkfcc/SXoC Mj4oK3mGo0IV6DkP9UIY3QRG1UQbM3MLo32vW3lCeaG58Y/BoaO1ZqB2NNqQ68PHbvHm t14+EseLc6PO7pTCm6aXL9e9NsB9LDpcXr5Yhnfwo6gdIuyFFRd9Ut84++bEc5VAhPo6 EF56nDteF8LQ6WqICBjPUGFjO1B707X7QBLkA4xWJ6i6VWEXJXPb5w8LB0dMfzewz2es 2fJA== X-Forwarded-Encrypted: i=1; AJvYcCXN8G5tFbJh8wgvtW02ybW6boJvV5xpj3OuCA2eYrziim4VErE24gCu4dK27h/MelIlqSeGwyI3TnNamGhC6no=@vger.kernel.org X-Gm-Message-State: AOJu0YzcHsGYZKgO3wVbNVQu8ZBZy5X5dwWsTQZa3y4duWY0/M/XG676 c45nFAYhITkzRUebwQfwL8BVugHCuG+dRk7CutRmE9RwOS71g/43g+LUJGYLGQr0cGV9iQfwiKz WXiXPfMNyKA== X-Google-Smtp-Source: AGHT+IGM8dDbafePeprrNK04mscqi9s1n3LRsj1p3n0Stvsl5Ct+lcHP80x8iiWL53VzzL0Jri/DkBOybzhFEg== X-Received: from wmbet7.prod.google.com ([2002:a05:600c:8187:b0:43c:fad4:7595]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:35d1:b0:43d:53c:1ad6 with SMTP id 5b1f17b1804b1-43d053c1decmr18085815e9.26.1741699116150; Tue, 11 Mar 2025 06:18:36 -0700 (PDT) Date: Tue, 11 Mar 2025 13:18:20 +0000 In-Reply-To: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> X-Mailer: b4 0.14.2 Message-ID: <20250311-mm-selftests-v4-9-dec210a658f5@google.com> Subject: [PATCH v4 09/12] selftests/mm: Drop unnecessary sudo usage From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman This script must be run as root anyway (see all the writing to privileged files in /proc etc). Remove the unnecessary use of sudo to avoid breaking on single-user systems that don't have sudo. This also avoids confusing readers. Reviewed-by: Dev Jain Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/run_vmtests.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh index da7e266681031d2772fb0c4139648904a18e0bf9..0f9fe757c3320a6551e39b6d4552fd4874b0bf43 100755 --- a/tools/testing/selftests/mm/run_vmtests.sh +++ b/tools/testing/selftests/mm/run_vmtests.sh @@ -386,7 +386,7 @@ CATEGORY="madv_populate" run_test ./madv_populate if [ -x ./memfd_secret ] then -(echo 0 | sudo tee /proc/sys/kernel/yama/ptrace_scope 2>&1) | tap_prefix +(echo 0 > /proc/sys/kernel/yama/ptrace_scope 2>&1) | tap_prefix CATEGORY="memfd_secret" run_test ./memfd_secret fi From patchwork Tue Mar 11 13:18:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 872673 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C0F525743F for ; Tue, 11 Mar 2025 13:18:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741699123; cv=none; b=Xe8wSrdF0gBAaBm5dw7rcyWuRXOOTBGBdwns1J7fpUM0vMEXnAtUE/W9vCLwuba22Vg7pSNFP84CEdLQopkgix+1tBH0qcxMcWvjgudPX9vKhc87DQeOL3DY9IX5AAnZVIO4JVMIfnDQPPOEoktjPeHX02kHrcvoG5aA45DCA4g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741699123; c=relaxed/simple; bh=cpB8G5qu+8qB5CaAmCrhUFZfkRWT/4ipT85Ja0ySsMc=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=lMkAxjZ9ghAjr/MxBNdj5hZgsuYauurmauIWrpDjuDZ4Cudw9IPDlg3TWVyeL90TxAcfmVQiKIuZmqazohumLXgVIQUZj8QCC1XTZce3RVS6Hramj3XMJDQYkKYndJncY/2fveRvjBcmrIuZJQTX9j4AVhwrzDsTun5fAQIBO/U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=RVRagUag; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="RVRagUag" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-43ced8c2eb7so20519665e9.1 for ; Tue, 11 Mar 2025 06:18:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741699120; x=1742303920; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=AK0S7bcFsX0odpC5RGhRJMkWaOy0j3srCbmbQDGiiBc=; b=RVRagUag7pOLcuZaLduo9a8ik0O+cCOy+ksP98v6w3foNhEejsY7lomibuB1dOzPOv B/2agTO6Xv4f1UceU8u22GOEDCt/Su0ToFd7fmHZyF3Nou/aO8TLUBG0X36O4LsyBEwD W7IuGpdsAqr3L9LIQMBlQbZcnS9Kn4RjO9Fu/aosnt4oxl0rZN3Tko99wdB9hCnO+2nF lqYq1Ep96mzpxVctBwGmPrCkM9RjlWIb9IA4JjE1jOGMi5Z1WXqy6ky54EYv/3aaCIJe Jy1XItIpCxdFSnyHE0XAPHLlRRTQ9YA0B1r3cViip5l73r0lYlwHO8Vkm4zhp9sy9lnd P7CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741699120; x=1742303920; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AK0S7bcFsX0odpC5RGhRJMkWaOy0j3srCbmbQDGiiBc=; b=AhjIz9Iy81pNccl/IovKk8R0lQAUt8SsZTuDEdMbHHBjDem5fvJBw4fjhB+i0wconF 6BLQwuKrMVJ6JwiI06mHMu/WMX6MttXuzWABxDAo6uO1HRiKTB29x6lSkvvxvFVSClce zuXHbRfacFQeUdIkegTGBN02bajRDNTLroRctgfjHcQbxERLzuNYfQcCyTxYmipmuiA/ fAJuUVCKd5vNVfnTdb9ml4bIe/5Xo9wCcCQxkMnWFmGew0ONG70mSkMCSGIX1NxuSrEF s6U13uOLpY9T5DRF4HD7DMpESh7X2D9rCs7YEZtqOIXXa+G6fkjISJamyJ4oQ2gTg24u SE5g== X-Forwarded-Encrypted: i=1; AJvYcCWwxQ4xM9lE+kteznzv5EvBesYy9T0X3AMzLymH6kfJKPtwn9zm1B389Y5gjKgtxIex1jML3fK0Q2waMh1QS10=@vger.kernel.org X-Gm-Message-State: AOJu0Yyi4Z5v/WnX8KBCmQf+ERmVXM7KNF3TSiAXr7xy3hDrlYjCSjWL tKe+WyGF+DNSXv/XvTkM9yJc2MoFwtrWR9jJA4KzvDi02QUG6CTH8uGKWZ18JOSSeY8E2NVoL5j 5HIwRjQ54Lw== X-Google-Smtp-Source: AGHT+IFnEky9E+WTZ67n4oDhD85FHBGvf1ZaUlsC4CSzVhw94LW+c4vdMdF17ZTVjJHaNu8o0hoGt9vNnRMLVA== X-Received: from wmpz18.prod.google.com ([2002:a05:600c:a12:b0:43c:ebbe:4bce]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:444d:b0:43c:fe15:41cb with SMTP id 5b1f17b1804b1-43cfe154379mr72788015e9.15.1741699119995; Tue, 11 Mar 2025 06:18:39 -0700 (PDT) Date: Tue, 11 Mar 2025 13:18:22 +0000 In-Reply-To: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> X-Mailer: b4 0.14.2 Message-ID: <20250311-mm-selftests-v4-11-dec210a658f5@google.com> Subject: [PATCH v4 11/12] selftests/mm: Skip mlock tests if nobody user can't read it From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman If running from a directory that can't be read by unprivileged users, executing on-fault-test via the nobody user will fail. The kselftest build does give the file the correct permissions, but after being installed it might be in a directory without global execute permissions. Since the script can't safely fix that, just skip if it happens. Note that the stderr of the `ls` command is unfiltered meaning the user sees a "permission denied" error that can help inform them why the test was skipped. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/run_vmtests.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh index e86ef8cb37d00e572be8cf0ea9cc8246d4eecd7e..1467594b594c4fb1dceae875fe7616ecc3cd9382 100755 --- a/tools/testing/selftests/mm/run_vmtests.sh +++ b/tools/testing/selftests/mm/run_vmtests.sh @@ -337,7 +337,7 @@ echo "$nr_hugepgs" > /proc/sys/vm/nr_hugepages CATEGORY="compaction" run_test ./compaction_test -if command -v sudo &> /dev/null; +if command -v sudo &> /dev/null && sudo -u nobody ls ./on-fault-limit >/dev/null; then CATEGORY="mlock" run_test sudo -u nobody ./on-fault-limit else