From patchwork Sun Apr 6 20:16:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 878756 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A1A5192D8F for ; Sun, 6 Apr 2025 20:16:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743970615; cv=none; b=tCtX4BUy7XqrMwkRyNa0ww65W80ltDrVR6PjRgGM+XWjQ6w7mvI7cfYXC707i8JjvD6Mm2KA7YZIT+/qXQyu9+kOLhZBNBEjksnFu78Ojx0QYogMD+gvcWfVC3LElmar+p57ufEUn1+aQEmJSMQPvE6mZ2XnCXLIwWd6gemFWc8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743970615; c=relaxed/simple; bh=F9pY8frtPyY1rL3BUcLY6dFvtBPh975/9mhwZubWHTk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aQa/kaLpLNwu9P7ONFBmzBWopVU2RRkcKer1p8MHZqcyIg7ONlAUY+JfENBdwEwMmqpdjkUQu6Lv101EwjLEmnzrz2wsr5po0QywGb9B+UHiZbtIQ2WyCTMNS1RKpXO29JAi2iPnpE6gJawAQ+aILxe3OpBvIDjMAYWysggws6A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ddFasAe1; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ddFasAe1" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-39c2688e2bbso471227f8f.1 for ; Sun, 06 Apr 2025 13:16:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743970611; x=1744575411; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=PK1eLJRwjNUIf+jHFUkxf4T29EbEvmbmOLYjAcK/oEs=; b=ddFasAe1Kg8bXYiWRLH2/vrIIsYqiQ2x+/QNMtKdlNdJIcU76ZFqWR+Juc4KDj/C06 YY9BO0TndGAMCm8rsDfX935Ep1KYpcNJoS156sTKLu7iP3GrHKNIQyFpvzilT6YOqGtU defpmGoQmTZPLoOlDzR7lqT6FWMbTYwMdp2xSUD67oC5ldjSDeL1FJMv1N+76oYjsdNJ 7uQ4VM+9i1u6wxowAH/PnePKr8P4CHDMRhY/Un+WHLsRw/R2tN07RNkBKLLwC4vJlpVj ZKisXlz0XrCD/9/jTOAvY6Hm4HrSIsPIY0WfUHovKFXw+xgPDL6F/CzxrMohtb92ohOS uRAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743970611; x=1744575411; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PK1eLJRwjNUIf+jHFUkxf4T29EbEvmbmOLYjAcK/oEs=; b=NdbWUd3sSM2OUVlHL/l6CHFxyEL5AojZ0ZIc06p+WTg8c7zposWKPY7UTNet5vkAqa zIX2o3M4GCXS0ABXQs17srUQepvMyjfKA4gYd+67yQy7T6tEgDDHuw05/siGbVG4cz45 aO3Cw6L0NlE85Igf4BmZxCUloNa0zGsZr/rN5lly/5rj1fTxKqfwsyN27xCVSNDqkBnk 8/tVwHYRSG9bNHXFw50cJcvVPk+beFLCd4r0H1ffpX75plZJZDi19XTqwCEdQOY9Fv7w nUUVzlo4IYDiOyiRBvSOjv1cv8xVJevzxcLVb9OOYh552jtK9VXGcWjHsP8JeDk8LAvT +Gmg== X-Forwarded-Encrypted: i=1; AJvYcCV4gMZ90O1hA1+f7J7q2JDcnqF50govGpwIQcTxhW51L5vppMYC3q8EuAT3Hei268bcytMJfESa7PjL8YZm@vger.kernel.org X-Gm-Message-State: AOJu0YyFL/6jenRDMSDVsfDXNfv40islhLV4EV0QrDF5hNjyQQQi7QJU wPbyyKnZuvM44IFm528pcYC2FyCBLAciXvlJHo9ug9JvKKukQpyEW0BTPHSuvRw= X-Gm-Gg: ASbGnctP2bHdCZstd0+xfBfDMgBGSRiw6PTJNjWP73aAdnfdCc3XlKMb3CU4azUdhCr 9xvFWf2aCmEc0sMa2GKFIM5B7A6lo8B1SHsN7aqLSI19U0K/j/Vd0Pz2SS6maCzC8T1HFK1o+jn aEE6JmCXZnidCok3ZxUl7Xfmh7yjU+BcS82YIWmEKXMpf9ZzQmRUwHOPhBJzcSwtGjx5qdP8DJ3 PBxVGw8RYuGrqvEMnd384maNG4AmItuZ2fovPfGPn5rKYBQFoLTLn5kYVAIKJJRXkVTkjGnMx3K WEiHJQJzNt347QdD3acR+dhsAyf7Gyb6yuuFvYHhhKB/vF8OF9hko/Un77rILLo= X-Google-Smtp-Source: AGHT+IEXnr9lmKNwFlpML2O4KXsGHR/K7hZOIitu4Tj0r8I6LyT5tXM1RW9jPWiQr2tfEbpDM0u0sw== X-Received: by 2002:a5d:588b:0:b0:39c:12ce:1046 with SMTP id ffacd0b85a97d-39cb35a2333mr3406453f8f.6.1743970611516; Sun, 06 Apr 2025 13:16:51 -0700 (PDT) Received: from [192.168.1.26] ([178.197.198.86]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d68esm10295521f8f.67.2025.04.06.13.16.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Apr 2025 13:16:50 -0700 (PDT) From: Krzysztof Kozlowski Date: Sun, 06 Apr 2025 22:16:39 +0200 Subject: [PATCH 1/4] extcon: adc-jack: Fix wakeup source leaks on device unbind Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250406-device-wakeup-leak-extcon-v1-1-8873eca57465@linaro.org> References: <20250406-device-wakeup-leak-extcon-v1-0-8873eca57465@linaro.org> In-Reply-To: <20250406-device-wakeup-leak-extcon-v1-0-8873eca57465@linaro.org> To: MyungJoo Ham , Chanwoo Choi , Hans de Goede , Chen-Yu Tsai Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=769; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=F9pY8frtPyY1rL3BUcLY6dFvtBPh975/9mhwZubWHTk=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBn8uEsbOMZQJr73NW28WN6NH8FVqEpOW4owF6Sf RzXO/ebPOGJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZ/LhLAAKCRDBN2bmhouD 13hJD/43TZvFgpyHitYxVcyhVDUvoH7nzWapN24cfLCFk9UeuMbJkUiKxwhkzRz0am2QzNfc6Q6 o1INqA+wGCUsh0F7z7/fGzhY/581/mQwZwQCiY4cPy6zb5sAqHVTziS5M9syXOUn+AYVtNwxRZi YiVkdLLI2FCFxq/jDhK7RcPHUCWW0xVy6oxOqsDIr7Tht1Fw7pKBRwu8ZZU3wwtCk4+gB1uUvBe gahSEZKP9TKGeOuxXWIKXdJdGjxnETYD66ONmxXS2tFbBNVtzi3D7Ouwt9X0wfEhDWXi4k1Fz4W Mv+LeTmd2llPEsYErj/+XVTw+61Uaa8fitgMR8mFAeQwlzsoF212YRkox4jx7loZS31nMbzW6/s BvkWL5sP7nEu9+o0B9hdko+aRHBSF2GvXaWt73FycGvaRa0LQkOo1bf+/3Mplfp5Yyfgvc99adw E1up1XNK3bZ6SzYdU06Wqye0WDfdQZ9kpHEJfoUT1tyvcYU0Rc7VWhATJHxbjLpNvy4Pl6LLxJJ W1yzMx28T9UrsrfVRAMCXE9+IyfrbPu5Y59D1525LMqF+A1NBPf1IakgsAJyO0qtl0C/WLwFVWs 1EgO+kokDcUT5wcjt5oGLSYgYJHIsPHTDAdZWJwxMB5AY9lTelj/GTxXmC4EX7TcpjcUTBO1/gR EshPLTWcE7Tv70A== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Device can be unbound, so driver must also release memory for the wakeup source. Signed-off-by: Krzysztof Kozlowski --- drivers/extcon/extcon-adc-jack.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/extcon/extcon-adc-jack.c b/drivers/extcon/extcon-adc-jack.c index 46c40d85c2ac89599ffbe7b6d11b161b295d5564..d7e4b1418d7e6b242780b3511f2a49def3acb7a6 100644 --- a/drivers/extcon/extcon-adc-jack.c +++ b/drivers/extcon/extcon-adc-jack.c @@ -164,6 +164,7 @@ static void adc_jack_remove(struct platform_device *pdev) { struct adc_jack_data *data = platform_get_drvdata(pdev); + device_init_wakeup(&pdev->dev, 0); free_irq(data->irq, data); cancel_work_sync(&data->handler.work); } From patchwork Sun Apr 6 20:16:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 878625 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C3C81B4121 for ; Sun, 6 Apr 2025 20:16:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743970618; cv=none; b=if0rxSHjWJOW8cxTAHNPkwaQb2ZNrhqGTfgwIKttvtRF9BqW4OOO/fRV+GPiCjS8M+/jXGtZJhCmZF7wqFCeYNeZxbmzAHUgaPbV5AdZoJbQ6//m2xeTdjcpZu4FNuHY3bCpkPCjGL3PZK2CYUXgSlynPYlpfK5siq8LbsBEoeo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743970618; c=relaxed/simple; bh=2VJ2L2j3W6F1CErco4gfdUL8lB1zo3mE3nNOQ4I6bJM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Uqw5GsUnRlmNlapLUg7Bz0ndUWU2Jty6KM0MvEMRN68ZIIJIFb4VsbsFtBxZ4OevX1CErT6LoZkSyErFmhWw65s1HtzHRtYZ9+f8jKVTm8UN2A5DgjPrvTkTjtM5fa81m7WEZQbCfyIl6EDn0bMMfLvIEW0hrpwKmOn+tbx/Mig= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=zflTqgnP; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zflTqgnP" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-39973c72e8cso401713f8f.0 for ; Sun, 06 Apr 2025 13:16:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743970614; x=1744575414; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=nYJYCerL5QUzGevvLFCgEQM0pv0n0jatfNY5jPvYrVo=; b=zflTqgnPFooSVT/4+OpSKlm6qQxeX5wdtO+KSxVpdrBFI8J4x1extsO3RFObt35Hma 0uSUKo79M9Qs92FcpPCR8LJpN9/3fn/KTVghCfZgN/PEIK7+vTY2ez6ffgpy5OuR+Pwp fD1YjNytnhkqwM0w0rAqQl0ofybjN8roRvQ/wMbfj9JDnLDRWdGwwuBT6d6r7MBogsX5 ++q32jq62TCNnA4qXLWrnmYfn4A4pwea3HodXTHjKfd27XJJVpqlzDJI0gUSG3n0j+t1 ulpft0pOTKZau4/bIYeq5nGRzSnbVmtc8ujDU+JIUfxloOUjgwW/muRKRdi3lB1fZ0va 5Rpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743970614; x=1744575414; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nYJYCerL5QUzGevvLFCgEQM0pv0n0jatfNY5jPvYrVo=; b=Lfmd8r9fWzJ54bPNln4Lr3gblu8tOYMJ662MAdG/DAmZGhjUXu10Ja3IuQnRP17Edt tEpHRH+6BoPpQ3Mb7I24F+RV5zkYqU0aPo8yR0AUKLOMD0sYSsFkrPKmLcVrQmNFbFP+ 8Vf+nQfgcl/1PO5mFRIbDQDTU5iZEPwHRTHUt3XGADqszr+r9deUMhqUe1XT2o2GAHuF VJ/bJpcW6W3onZ83IAnArVs8APy74oiZTl6qfHC/1ksjFqjJ+LGCK0lGYIG1iVLOl5T4 RmBnHgo+KyDWJ6d6CIwKvXiiAzfbJ1gx69u590IEB6COz5gsQmtZbvGjxPqueGHd+bJd mMBw== X-Forwarded-Encrypted: i=1; AJvYcCWDAlCQifVPODzVAIXxEHqw6D8zxcOcz4L2LnhKL9+dkW50GemZG4+VtJv8pC1Quoh1eWOQqX0BUD4IQRk3@vger.kernel.org X-Gm-Message-State: AOJu0Ywj8lptcxY+C7OyXUUQw9RiuhqkHF9FN6ryBpJtI0ZP1TYw7fcy +tO+RElUu7OtRHgzWmJZvdoTgA6n0LRWwaZaYpGVc59xIPv9xQm2nGxUMH8k6nE= X-Gm-Gg: ASbGnctcYjwYADoP0cttv3jy/EHOLKUOEZf3VSCy8+bbrik/ns23TM+VTyx82+8F8M1 6ymDiIOmplb5WQmen/w8W4Z3g7wJlfVMbothvvX0B3s3SoNDD5jla7tVqnZCQx5igBR6FhvHykz PWqKqiQckxPvu/uwtPQ9SYvs7e/kMrkSea0y8nlL/cjXAFjvCghdCy3bH29IrZ/0i/zYi/IZdT/ YlRUZcmvprAEabP6rUwklE0m3pcIGX5WTqJtuOSe4gTg9/wuys2Rprq4TL6JvTgLhTUKxnTLVVR nj+ySD1iSGn/MTwpocWvBIPEQndtrFuvObBcdyVFu2UCRbDuomYn1HGlBHw+vnUd41X9e2LCBA= = X-Google-Smtp-Source: AGHT+IHelx1mcjCqANXW6R3Y4bDFza5EFI6CfMf4TOgrpJ7bKxL39mUZMC8jl/GTiIN+xlEd/rXmaA== X-Received: by 2002:a05:6000:420f:b0:39c:1258:17d6 with SMTP id ffacd0b85a97d-39cba9477c6mr2626485f8f.15.1743970614613; Sun, 06 Apr 2025 13:16:54 -0700 (PDT) Received: from [192.168.1.26] ([178.197.198.86]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d68esm10295521f8f.67.2025.04.06.13.16.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Apr 2025 13:16:53 -0700 (PDT) From: Krzysztof Kozlowski Date: Sun, 06 Apr 2025 22:16:40 +0200 Subject: [PATCH 2/4] extcon: axp288: Fix wakeup source leaks on device unbind Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250406-device-wakeup-leak-extcon-v1-2-8873eca57465@linaro.org> References: <20250406-device-wakeup-leak-extcon-v1-0-8873eca57465@linaro.org> In-Reply-To: <20250406-device-wakeup-leak-extcon-v1-0-8873eca57465@linaro.org> To: MyungJoo Ham , Chanwoo Choi , Hans de Goede , Chen-Yu Tsai Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=752; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=2VJ2L2j3W6F1CErco4gfdUL8lB1zo3mE3nNOQ4I6bJM=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBn8uEts1XIjx+ihcfWb+iUWLJZEOIrhmenUl6y2 PjD9Y0AjM2JAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZ/LhLQAKCRDBN2bmhouD 11POD/sFFuXYlPOrlxry3fkB9pwLZ6UXYdmjYwfGr8U0f+aDHMTTIvQdr5N/XkREAkbJpbSkZ3V dYnvI76CUqpYM5whDORX0ABOZO6Eq0q26Pv7v8h/NtE4DMN285zTyXutRVH1CEYrJFI2KL1pLYh XVoCU/AYzYnu4CJYOrJibpKfR/yCe5bTJkBuvrZ/jbGtsS58MlKJyfGzmtABnuIHDzVGSRnFx6i AD4Xc7cpFElGr6Qgwrtk+hI2k6gq1Cdz3kchGYDBo81PJGI3S7keKjm7vBumTJEyHgASInBe4wT Z6SoiGd3ZXD4Ou64hntb2vHPotsXPTcdOCyNp7JMkQ09NM/OtKuP74EfcTgFfoV6Z3xd2qCxltP D+jS6tHPO5/7YblrFwbfCZ8EpsRpSviHHWMdcWx8ijxX3fITf3dzeUpCIj4kDCnnPz1h82KDeGF 5hJ+qzkJn3suGVVxs4PTX6KDgQD8wsX7H2Wp6r7BanrdPqFJvAKPxio7g+n/xkzL5ZOTrhlP8HF XV/V6vJpjNFBGrC+8eyKj0ZPKxK19Ra2KyHERM3yc3aj3q0nHuCXTUb3arnx5eWFB3qHz9yVYYk 20ZdQe9qzf87TMWty5dqtmJwE56alGl1c/Rum2LBjTwm4SsBOfDZoR9JY18+8te9piQOnP/z58x X7+6kfmT5t1DPzw== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Device can be unbound, so driver must also release memory for the wakeup source. Signed-off-by: Krzysztof Kozlowski --- drivers/extcon/extcon-axp288.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c index d3bcbe839c095f126f0313a074681f1c900762c2..19856dddade62c5592701f8fd5842857ec24813a 100644 --- a/drivers/extcon/extcon-axp288.c +++ b/drivers/extcon/extcon-axp288.c @@ -470,7 +470,7 @@ static int axp288_extcon_probe(struct platform_device *pdev) if (ret < 0) return ret; - device_init_wakeup(dev, true); + devm_device_init_wakeup(dev); platform_set_drvdata(pdev, info); return 0; From patchwork Sun Apr 6 20:16:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 878755 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5BB41C4A20 for ; Sun, 6 Apr 2025 20:16:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743970620; cv=none; b=RaL4gN5KC0Wo+dT/3iYkqhUjAPCqa6Ypu1cw9CBxroBMOxTgkZOP2hgvEqgh72qJp4+Yy0qXUkg85DLh1sgIVvS25Uxs1K3w7lqw87nekZ3lrl/mXAzZMQHngFdGRQog0A2kkUTJVmIgCcaMTbwVcfYTrw463cVDhZgVE64nRIA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743970620; c=relaxed/simple; bh=Kaj9yPMcEEiMDLRcwdbnZDC+/5p/KQ6EFeBalyk7a+o=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QNHdtS4ESlm1wmKADnJ1Qto0cPa1QTbq10yObZDxlw7XFj/SpRLIKm/8Lgml74XTZVSDapLLWe3eeXVb+1t4FP2v3S7XIFLXFQKH3Or0TzvR5KgwAMTe04wcjXDPRGB3IHK3QCZ+2wPfeQljVGXB8bzoEZqrYvs6XnDbgfzvOR4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=mz6G8dP1; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mz6G8dP1" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-39c2688e2bbso471232f8f.1 for ; Sun, 06 Apr 2025 13:16:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743970616; x=1744575416; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=A5+V4XWX6ik8XXfemjH2aaHsT36827BDWO1+WiESIVs=; b=mz6G8dP1NLkSP9Lrq8k0yQDAHvAtX2hZZAIdcw9iwDPlaJgs2PU2qwfJk5CGc4OsGT JQFI20lZYHQ0pq3ShJzEo0cN8yJCoM19Tne4XkEflI4VZjCy3frWbPJ/zePiXfAQtC4/ cwfH5mVYbHvlnhf/VOSMzaSARVLiK5ykccyXztkhMGyg1NnMisAxWdPz8fKqEu2kUfRI i19Bx2PxF9JOheK70ocX6wujomypFwzgbnYskt/BUiv7Y0USTfYC1PYCTFQQ7HYKwY7m NZwrKXAxZG7B/eB4cgZgIsIwNr/r4PJywTfEJ3tz+1G8sb9+MLACM57Oqpe9Xx78iTqt 3LWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743970616; x=1744575416; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A5+V4XWX6ik8XXfemjH2aaHsT36827BDWO1+WiESIVs=; b=swMhjW58GKsqRRCoYdjC/pSdM7tCDp5xr8w4K74dzAya3CmWkQz6V67nZDDXcUT8wK rodpBWUIT5xqyiGWQRTtPQvPALcuD/f8lDot9BusJBBculqhaBKfZb5Cr416Uk5kgdPX ZsgL1epANhqNIp4+JpbtyoK6DFurxHYhvfCH7FrmmtP00p8WWz5KYnfHW7ugCtmRolCr /CccLKP894SnM/dAON2OxHquvh08+4u9E7C7v+B+aBBL+jdoOk5v2MDWB503NpX44TnS 8vnM/6T+VCuRsKK++a9JU0GKWr1C8y4bFymKbNgd5xaQtg3cGjjWZKJEZOmQYKV/+hOH JQIg== X-Forwarded-Encrypted: i=1; AJvYcCWLpvkZDVL14PUuiv9hpHMyKhl7u8p+AiirdcVnQfggu7/JsJUheSL/ziOAJcaedTBA4V1RcYmPcw/xp6vP@vger.kernel.org X-Gm-Message-State: AOJu0YzRTg35MLQ8IRpnohNKXtL65gQW511okNZQDQitfSpUjuaHXeu6 1/t4UjnceYEVSzKBnR4R/7PrjKxOxqFh31YgfoWtLiNOkBenpNEg1cPDoEfBwJ4= X-Gm-Gg: ASbGncu0hQI+gacsGmhTxV9Mjm3c+YjMtZT+eUNNS+XQkcQmNsH2sdn4SuEKmtY2C/b l7+PhIBQ7nHSu/odcF5NaFxipoypcfAUsbLimqi5Js5wAVsvmMMTFIJfJX94KB7I9CYm1wOFSCm sizzipDHtQ7z6wHjeKWdoIDIORnSviT2g04CSzYmdsZdruqSbSjb00LYJJ/aGToc4w1fqhEKENl u3BTmzyBI0i/yDQJl7+qWuzM+snR7wNFoaORVe9CSpftraV8Y4V53Hx+lXgFMVdeHA0hy6hAhjv UFe6T8FvC4xqcPmJo/ENg0b/RyhdKKQpFfY+5f49N4KWJZDnx/K74Xgm0gvKapWC0I5Z86slAQ= = X-Google-Smtp-Source: AGHT+IG3SkOB5mChKZuFqVQaiw1v/CrzGtpVH+xjt2NBrQMfv21qD2ytHbccZQ37eVeGOpP1nkljCw== X-Received: by 2002:a5d:588b:0:b0:39c:12ce:1046 with SMTP id ffacd0b85a97d-39cb35a2333mr3406474f8f.6.1743970615907; Sun, 06 Apr 2025 13:16:55 -0700 (PDT) Received: from [192.168.1.26] ([178.197.198.86]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d68esm10295521f8f.67.2025.04.06.13.16.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Apr 2025 13:16:55 -0700 (PDT) From: Krzysztof Kozlowski Date: Sun, 06 Apr 2025 22:16:41 +0200 Subject: [PATCH 3/4] extcon: fsa9480: Fix wakeup source leaks on device unbind Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250406-device-wakeup-leak-extcon-v1-3-8873eca57465@linaro.org> References: <20250406-device-wakeup-leak-extcon-v1-0-8873eca57465@linaro.org> In-Reply-To: <20250406-device-wakeup-leak-extcon-v1-0-8873eca57465@linaro.org> To: MyungJoo Ham , Chanwoo Choi , Hans de Goede , Chen-Yu Tsai Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=741; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=Kaj9yPMcEEiMDLRcwdbnZDC+/5p/KQ6EFeBalyk7a+o=; b=kA0DAAoBwTdm5oaLg9cByyZiAGfy4S7IMNz2a70TDXFdUMTmD6CqBec6xXO7TJbYaLKg5+ec6 okCMwQAAQoAHRYhBN3SYig9ERsjO264qME3ZuaGi4PXBQJn8uEuAAoJEME3ZuaGi4PXk4gQAJaC zS86EVrLWr114yL1IUjuj6d0KWG4ibRfEpWO4DG2xmikymthVVvYTl4BDhjLSw93DqSaWx/udWz RR6cr9eVIh9dPEb4dx7Zw+flUt5Z9XHnhjvIUnKgKoCOXvnPQuZBpM9DvDjAb66PCA2iU6+7M5X 5VUEX6FQ8CnB5JP2F43n+VaBnpbGod1uTLdjjSb2RrIzHtZDsdhrYmxg450HJifQXnmcBtLeXYS 2Tv/adlP0FuHMhhaF9C6vAD7yrGgoUtkiPhc+xrGA8gdhVbmRuFSkhj2S4ymnaofWd0XNIDVOwv bSaexrvTexY0giHjbBQkjw5O5nVv4m1y7Cjyd2PEwHiKTToCOKWmtYwO5dbm6zzTQ2n+20bQ3ly rwxqvN8LENXWyptGnD/79S9gv3YbduSJWe0uAR4cg6+1SQSjp8h42fHLTMupkJbDpqK0XQRZ1qo 16mLRLqhvJgssrgXmTW3852KIayqu6U7GRnFNEl97vDCT1uS/ARz99v38DojvZQhV2484G22ijK VN6S6HouP3vfzwphLJkRiOxmu+UuRdnVQluHfMRD7ynyBvvTLgVt8h38pKDofOsfkak4/fkFugh q5+3bQpizsAFBu40aXQlwrfb1CsHhsaoj2S4WgkwUe7e+gkxjvhVK+ra0iimozHArOvL9dcuppG BNZ3r X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Device can be unbound, so driver must also release memory for the wakeup source. Signed-off-by: Krzysztof Kozlowski --- drivers/extcon/extcon-fsa9480.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/extcon/extcon-fsa9480.c b/drivers/extcon/extcon-fsa9480.c index b11b43171063d6dc14a5a4a7efb63e610397312c..a031eb0914a0b68aacb0f5f1f522597ea286fa2b 100644 --- a/drivers/extcon/extcon-fsa9480.c +++ b/drivers/extcon/extcon-fsa9480.c @@ -317,7 +317,7 @@ static int fsa9480_probe(struct i2c_client *client) return ret; } - device_init_wakeup(info->dev, true); + devm_device_init_wakeup(info->dev); fsa9480_detect_dev(info); return 0; From patchwork Sun Apr 6 20:16:42 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 878624 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D18AE1A5BAA for ; Sun, 6 Apr 2025 20:16:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743970621; cv=none; b=daCf/st4yqqNDlebgB2r9G3o1g7bLODzHG1P1TsLJVn+KxKNGDrvqev5hZ2ea7n5yLGF4a34inOdYPaNYVvS5fnuftMgqZIao+5dP6YyI9Geq1tOn36obQLi0uP4/+l80OJ6MI6aSc9FP7TqIczmHEZdDiEDEAZ7Dkg+1hyjEcc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743970621; c=relaxed/simple; bh=+LKj42cLkyjYdRGFvqe5ygUreP0AOBiPNelbPAxonio=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=h9k8fOuVYk/9ZvPps7QpJ4jCihUUYFBk+J+bV+Zvndiyu4qPftK4wbBy43vZ3PGcEaippEGD+4FdtSm1vz00n2zHHWwe/hUWjcZxyNq011LbCHyEW9K7ob/zIcUOpIc2eLFj/IBDtnf9T1rtZeKB0nmitksfguF+NoQH4UUwOSk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=WspjjbiP; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WspjjbiP" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-43d72b749dcso3838245e9.1 for ; Sun, 06 Apr 2025 13:16:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743970618; x=1744575418; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=xjlBYf0UmyquSLTb5Xkn0Wr3kIZfJKW5KgRfEo1uP0g=; b=WspjjbiPW6MpB/aPkUaUMFzLlzCG037cWw3MzMMzLam8PBxfkPnIc6Smqb7f/8W5Cw 64MPoeJ4P0+EhT2H50AdKiT8bmNkbtI3+vVp+fS7vJvEofVTwvUnEvtx4/gnQgqpDSHR 5s8W5jSfmCfLx5Dj1glMuhxNjfDwBHyaLcaWjFB+yu1ksz8Aa2SCze5R4/JSrk784NH3 F4i9Ki5N/jZa/zQ07uvbqmLAjKjgH3pFyVvhYxcFxr1aeIrcDwugtchhWHA3lp/u42fc lmaKiBnJ0iIGuq+r8fMT26v1y3Kc7LZKKriPAECCQbbcZSCEuPAAZAMY5Ksb3PkmQx7h AKKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743970618; x=1744575418; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xjlBYf0UmyquSLTb5Xkn0Wr3kIZfJKW5KgRfEo1uP0g=; b=tylkPo9EB03qKqhAZE7vMsqmTW6OZbXRBSA89XAxPghQ0GXC7MRts01dH/v2x2XVcI 08MSysjTKNEq0OOdBasaulRg9D3lkPXdv4jQHARZkDLu1nJUeRxyZ4hyjI/ag7D3A49V KOa+shw+KPQiaqZgpnCYpdU0MhZXmDSgLVa5vngKxrVxjo9vpGiwFm1AEXrZeS5tDt7m Sj8LWb2M/OflExqHTUB4wlH1Kyjh9OhO8r57xOFoU4PUZXssW+xM0yzFGY/DZP7aBobB 4mC2wCykd43w01HRzIvW6j/KmIMG9kYSdtkff5dvkhSMm3JWCaxp5YDCmKC28zFXAgZz KZtw== X-Forwarded-Encrypted: i=1; AJvYcCULk4LlfzBRGYzM5oHNezU8EKy74oWRMGeN1OKU7v6LlPzfALgye2azqMi3AHQVRAnGyVdBaTk9DMNnzdz2@vger.kernel.org X-Gm-Message-State: AOJu0YyzJQJfPcQ5ncSqTMEQ28IV5ol8o1lGzg9MSzQMCIROvTsJYplL oTebRmljmQn8fELcz2aSvaGnKU8dYVIhG9GpysyTVzwyB9WE3AGlKJasJL2wFiLIXQEg3B/IDT/ Z X-Gm-Gg: ASbGncvvC5Nm/9zz050HQkQsyNu95Gwz12dSN2huwZlGvQBPwNIt0phuOGjHY9RYoYh orXXMvualT4BhhtW7S+sgqDWIvBoOQXOq7JsVmK0dZmfKnh/wvht0tlPBjY1v3wJz2NiF3kJpGH l5RZuh/CbqvnnxtMiQl73tZJ/FQAERUOk67EF4iaNo0kASqKqpmQOKkr/K52UoCtd6YV+b4rut2 SbBhxWsq13lvcYWhs9cQv2AHcsIjSKnNqqd2R7rdEdEpSrbfS8FYE+CFfVseHBOViDK9DB92Gk8 0ecm9gEQcLLg1mVhc514S3QmJUImrWJmpRClbe5GorQqlSyfew9dFySBAAo2YJY= X-Google-Smtp-Source: AGHT+IFVbMLrWyRal0YYCi+KHaKp8d8YFDVQ0prMTHvzyQRiYIV2ETIOBojkdoCfYGTtf7CDaEwDgw== X-Received: by 2002:a05:600c:44c6:b0:439:a30f:2e49 with SMTP id 5b1f17b1804b1-43edf8a2f04mr13701495e9.5.1743970617984; Sun, 06 Apr 2025 13:16:57 -0700 (PDT) Received: from [192.168.1.26] ([178.197.198.86]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d68esm10295521f8f.67.2025.04.06.13.16.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Apr 2025 13:16:56 -0700 (PDT) From: Krzysztof Kozlowski Date: Sun, 06 Apr 2025 22:16:42 +0200 Subject: [PATCH 4/4] extcon: qcom-spmi-misc: Fix wakeup source leaks on device unbind Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250406-device-wakeup-leak-extcon-v1-4-8873eca57465@linaro.org> References: <20250406-device-wakeup-leak-extcon-v1-0-8873eca57465@linaro.org> In-Reply-To: <20250406-device-wakeup-leak-extcon-v1-0-8873eca57465@linaro.org> To: MyungJoo Ham , Chanwoo Choi , Hans de Goede , Chen-Yu Tsai Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=844; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=+LKj42cLkyjYdRGFvqe5ygUreP0AOBiPNelbPAxonio=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBn8uEvk/jVL56aZSTw3nP5T8trMIMnOWlq6vOHC z64KDiieDaJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZ/LhLwAKCRDBN2bmhouD 19nMD/sHqz1qRUFFVM31s8UQ+C+KEVhdP1YB16EGX9gI6Nu21n7azx7Q9secX8Y7tRUik8oigNE U04tJRj4JPyaJSN639kP5H8VsU/sMWW7YFVtnuuafFERaij/cWBtfn73+372nFMCdcviaQiO34g PpMLAV+BTYHlqYvZF2Pir5gf4UBUKmWqt3CXQ7N/d6d4CVfkIijrocswczb4V9XYNTRpEGjM9Pp WOni9jCIZYpPZ5A+JmWA1zXrx0P0StmZ498iff3mv0ZroDgxkDbfIxW4PswBbJGkkyTexrfeHQs 44MAbfwOAV5Nu2Zb1tc72N650YYqctK7U+17E2X4QDfDHF+eIgg2y6FKKqldVQAMex1C0AwPVLN ydugLoy/9X72Nf+pXr8f14SZHwPK9JsXNodOt8q+aOxHTtZ8ntv9U3caTZWeq4bR8D+CqchhqSL P6Xmm4rGBNLbUVfRCIHwkd2u0xMryYGE3UZtCVulM1163RHTLChIuZ9i9YHYIJx8H0Ewyu6GSau pd0kM6pvskLLrdbQWioLHb/lXYy91bMkaFS/52/SMtVIUBSeYI9mCqFWkIbUY7ziQQeG9ulYQdX /zC0yAZsQm72GzjwXGcBuInoeHGG1ER3SKzWaYSJKcj5DdDNholhvcvQx8chK6r+J6OkSoW4NrF fGcV3bktJvmAQNQ== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Device can be unbound, so driver must also release memory for the wakeup source. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Dmitry Baryshkov --- drivers/extcon/extcon-qcom-spmi-misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/extcon/extcon-qcom-spmi-misc.c b/drivers/extcon/extcon-qcom-spmi-misc.c index 53de581a393a35bb48f637ea73e910b4c8340ace..afaba5685c3dcdbdc750c1835ec4c696bcc64fc4 100644 --- a/drivers/extcon/extcon-qcom-spmi-misc.c +++ b/drivers/extcon/extcon-qcom-spmi-misc.c @@ -155,7 +155,7 @@ static int qcom_usb_extcon_probe(struct platform_device *pdev) } platform_set_drvdata(pdev, info); - device_init_wakeup(dev, 1); + devm_device_init_wakeup(dev); /* Perform initial detection */ qcom_usb_extcon_detect_cable(&info->wq_detcable.work);