From patchwork Sun Apr 6 20:01:42 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 878758 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24B48192D8F for ; Sun, 6 Apr 2025 20:01:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743969713; cv=none; b=nG1+YypXw8xQ3MJLKHog3C57Iz4hThhlfeZjoZr6r1VMDI7Mq7LKrE/+r/kMTKgbdpa99B0bplqu4jmsHz0NQnOSb7ldy144K6Wxv5+9/Kyzcn9E1aV6NSUqG+7+ILxAvdDyqB7oBB8qXDv+tQYDd7UVNXTgtP3aLadZ7+tavcE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743969713; c=relaxed/simple; bh=JTR/P3EkGZofvJK08o84UvnirFpKqEhg8gq395B9I70=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iO8cRU2e1UCuK830BbGu01Q5/k3z22zGU42MKjHgQ89aYNllTFwy+/de1MFcucybDKXnbhSqzy2SbBpTIbkJSk+I+ecsQKr600CcCOtkW7tzcr1872rz//cQQ+0SnFfaUrKIR1TchM8XKv9CaXTVCTG6ZCr1zAxxgR8wEG4cRa0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=do0g/yUD; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="do0g/yUD" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-39ab85402c9so448135f8f.2 for ; Sun, 06 Apr 2025 13:01:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743969710; x=1744574510; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=oWlwiQDg0h2Z8rmTGPwySdCuGsBToV5oB+DTAJXaZkw=; b=do0g/yUDNfeJzZ5wYBFfoutJcxGWBxO/csMx0pdt0eEc8UK9B+IgqFY4nw+qR6E8Bi sPDFcwZQQDDsmCO9T3yVWzlKGA8qujuDQnfRAUvfCWy6BjegurzWmscAU3cNBcYPM0hM fQrz6ticrK9iJdPVXRNTV5KgTh5/Zkh1kJgwabKi+/4rLqCx6zAEqnAutkI7oi/oXC4J oj5jKoNq4MQbFh0DMarSRkq9BZ62C8WTKBRlUwmbQ19dpH4PwXc0zWBVyr8JeCTT+Wvq pWLM1VGGCRlPjp5XKPi1McHg2SjAdbPAin82IpNRJYMWuAw0T7m6WJ1mU0iyDAPPxCES s29w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743969710; x=1744574510; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oWlwiQDg0h2Z8rmTGPwySdCuGsBToV5oB+DTAJXaZkw=; b=oMAuGtdafFg77ms6+EnEu4N8lyROWpUbmAx1UNEY2iiE3awKkE4YLJRsqxNH6JjdyH rxn+fccqh5QfiSfH9Ab5/A+SdIWnPJWNOoMjIia6ej4Dzsk5G0Lq6M7J4o3jbKWXaYSw dpB0ODdJh68YmVDsRkQjPkqDv9YZ87y3hx59b6zl5mkB4XBh6u/Kww8LoAplZupIZysr klxdADwgwuqXfBsuKjs3AceY1ee1ZI/TXhdZ7k3iRhNUcdb1BZUCr3rsR1m8+LqfkALF UhqcwgkhRPEsVxOFYRyVZZP0a6eujzEoxl+2pXP1aDwv2J1CMed8P/qh7BVb/NztJMUw nAZQ== X-Forwarded-Encrypted: i=1; AJvYcCXFOciozXXvWGrpJU/GIA6ysgj60Eqe5IjWqIYHMAEF9P0ziPyEvne0tgm08wg1sUj0Gwa77cHj8y8/4DEL@vger.kernel.org X-Gm-Message-State: AOJu0Yz6U0oWiDiBueMSlLiNDJDHKKvS1T3h9OBLmh4fQ99OWueGoN7W cBvWLENY+CCoyj2yfnP0ma//nGakNPQtBibr0Pyx34jxpG/3CcYSn0Tc2rMMBjY= X-Gm-Gg: ASbGnctotzAci+QfhB0W1n8dJ7+Y5kvoGKXOtHpjxTjoUfdWoF0bb1i58gxXySidSRH M7HLIWEl/QVXFU+/lI2AzBCY8EcjHrd93mIlG++SWHQImnP1ubcxS2/dJcBYVhWnEx8BzUJ7uHs FX4f6I+Xgnqy8/+v2eR6Uknir7gvsUFaOOd6GJIRN8vh4vfeS3hq3fZO/Vwws2UcrVrWjKeYAnC tz+9ic2tsD2peFQWJSWNhtEV2Xgsk5JmkYGS2w0AV/MmVhBCZ0ASYZ+tDD69Bpg3WqCbVaBgWOI 8Vv0NrtT/S9rRuIh48PCrVShldzBnqq790y78c+N5b5cvZ2enyMmgWyzQoMieug= X-Google-Smtp-Source: AGHT+IEZjB4MI6wC9+JoB/jO2g6h/C6OH9uFv3PiHq9NZtSTSQkamc0Yiv5WCgkk3m3FLqGD4ixTkg== X-Received: by 2002:a05:600c:a4d:b0:43d:fa5d:2675 with SMTP id 5b1f17b1804b1-43ecfa5aa44mr35392475e9.9.1743969710316; Sun, 06 Apr 2025 13:01:50 -0700 (PDT) Received: from [192.168.1.26] ([178.197.198.86]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d98bsm10199924f8f.76.2025.04.06.13.01.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Apr 2025 13:01:49 -0700 (PDT) From: Krzysztof Kozlowski Date: Sun, 06 Apr 2025 22:01:42 +0200 Subject: [PATCH 1/3] iio: accel: fxls8962af: Fix wakeup source leaks on device unbind Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250406-b4-device-wakeup-leak-iio-v1-1-2d7d322a4a93@linaro.org> References: <20250406-b4-device-wakeup-leak-iio-v1-0-2d7d322a4a93@linaro.org> In-Reply-To: <20250406-b4-device-wakeup-leak-iio-v1-0-2d7d322a4a93@linaro.org> To: Jonathan Cameron , Lars-Peter Clausen , Lorenzo Bianconi Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1010; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=JTR/P3EkGZofvJK08o84UvnirFpKqEhg8gq395B9I70=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBn8t2pUcGp11KcDBPbWINpnXNq1f8z1KQg5S0km HZ67mDWZfSJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZ/LdqQAKCRDBN2bmhouD 1zfEEACYo6+sMdke/FBBVYQRLHP+qNj5MfxwUFwuDCgH6dBgvPzD2DljR4eYT8v6/qxOcAafsEn FsLSPN+2ZqX9U2sAvePioblX5EhBn9chywso3k9ISsHhcdzxKFQcAS7KUM0HbEB8KWmh5FX1ijH HfFUlNK9uSE57jw19nRFYFNnAlA4VlXbtQzubeYiSz2hoRXwDu2V+TkssQ/AlW/yKgaz9tP9tjx 7FCeXeKJpybmwbA2+kw8cGkA33x8lZgd7U2CwdFOjQ8uxL+ZDmypk3ck49VrXtl0c3i3WfDbWWt 6pWYHQ4grirBQkBRquN6tRjpvpuG0oLmCKT3YwB8xUB0IJY6BlIvdH8rUPKvvKvOKtJUFHmAPtD VpGC3gnzoxM8xR+1X5Bq21KS2HVEnF/Y3XqUe1tcnuthYcbv2auhMRm3AdL8lhHafCLOnJvcikW vKHsZSCoo5POCsUGj077F68cJnw+FgKa1YIKKlYLMD9io2sh+5kfbnsuG/9wpXAzV3QkWC3iwgD goADtSNKF38JVatHDTbPnG449E24D7M/36949/OQRZG6KTOGVbwntV7Y5adgS5qDmImDsZ2pIKt k6mLLfhfkpnsIH3ybYQeetcsBtNkEomPfz5/fFgxgrGC2v27gAZ8ygJTOd1EDEuFst6medTHKoX jlevVgAf+BBUVXw== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Device can be unbound, so driver must also release memory for the wakeup source. Signed-off-by: Krzysztof Kozlowski --- drivers/iio/accel/fxls8962af-core.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/iio/accel/fxls8962af-core.c b/drivers/iio/accel/fxls8962af-core.c index 48e4282964a0698d422df49739365648e19bdef6..bf1d3923a181798a1c884ee08b62d86ab5aed26f 100644 --- a/drivers/iio/accel/fxls8962af-core.c +++ b/drivers/iio/accel/fxls8962af-core.c @@ -1226,8 +1226,11 @@ int fxls8962af_core_probe(struct device *dev, struct regmap *regmap, int irq) if (ret) return ret; - if (device_property_read_bool(dev, "wakeup-source")) - device_init_wakeup(dev, true); + if (device_property_read_bool(dev, "wakeup-source")) { + ret = devm_device_init_wakeup(dev); + if (ret) + return dev_err_probe(dev, ret, "Failed to init wakeup\n"); + } return devm_iio_device_register(dev, indio_dev); } From patchwork Sun Apr 6 20:01:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 878627 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BEB81ADC7B for ; Sun, 6 Apr 2025 20:01:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743969715; cv=none; b=VRK6TWLeO6uoWURYX/FszFtRnDUWZ4xZsgEUYPHsz7judb4q2KLtHrhEsI81CEhMHkJziCsH06LTTAF9uPAJtE1k99R1J/tRkunIWt2zQYzEpU5KY09Ou9F42sQJTOvEwM4VKi1i7dJSUiE0bksA+rSSdVvy1kCWQsjVxDwZVBc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743969715; c=relaxed/simple; bh=VozTKdty23C6YF1YQQSfUpINCPfYLQLWcVgIyB0y+l8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=H3uZZTjFW9HM71bqq7FaFxB0zeYVx/xrQ+L35YxWzM2jv0IoAaTIML0GimoQBgTOx4rJTHOx9vv9vLGpLSgvS2+QfAPAKnRn9MvKp3ro0Ld6faKx9zwkKPGzyfOxTwVAoU8pOG8Po67osn7J111v/GVNBZzXmG1HBDDJbuSRYSg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=oEYEa8r+; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oEYEa8r+" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-3913290f754so445966f8f.1 for ; Sun, 06 Apr 2025 13:01:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743969712; x=1744574512; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ZJPjOgh8WB65h9CvEgp1vrBJ8vhfbj9Y4D8cf5G+Xh4=; b=oEYEa8r+lsceFZBEl7znzScAE7nc0X9NrJ5kAbgjyt7MQMva97Mpq+RLnFTYBbXsm+ zGzYwIEwPB2bZs5E7MEbu8sYNKH1Z8jaJEVIdbDaIrBeOmk+rXV7BOGKQViAzCRRV6uL lMev7Ei1JzhSlTlJSHjRqv971FIVkjlpT34NJw/7jaYlSeN0XCx1VKGqBbP4dOUSC0Zc sueuXW1PZW7vdkzBtDvsigYWYAIA0ePaB4w3Q1DuhfjHzeW+fdXjE3PBmf3FgRWu1QpS MplDcdWw0mSUyfu7SmfP0cw2Hs4M5AmlAtMi0pBgaLrZ7za/hm0jRlX4yUwCOxCAoDVW jYXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743969712; x=1744574512; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZJPjOgh8WB65h9CvEgp1vrBJ8vhfbj9Y4D8cf5G+Xh4=; b=BvdD/bGjP9O9Q1p4bh1GefKMU9IsPgMpyPDfnmHpbIgoXJxVbEoF1CKYXAssureu0G dmBVsU3JQio6oexpa48ksZmb5XGoBFrgebFA1FJYsFduuaHlctkULgWtrfTt7taLt2fV ppAGQGjjX49DDrCb1wxDWkaigU/fTLzdNYjgUQUlqSDEUMozyH3F2PkHjpmscx/fzXqa btfo94SYJxYrl0ylReHgUFQ1cZpR7DDHCq0fdZlzxpZoEwQJoZsOVsdjzvPA993bbrj/ UmovOhEa8UWdrE7MC6sdmIOoSqgas9E879LkOEZ5gJDtVKCoqfFOW5TY8o4XmE0sOWi3 mRDA== X-Forwarded-Encrypted: i=1; AJvYcCW+BWB+2f229edDt+wExdPzi51OI/CHTgeU9+NZqw5buRvvOwklfM87Qcs3xpIld3TW6inPYHzbzDPJl5cx@vger.kernel.org X-Gm-Message-State: AOJu0Yzzb9LpThHTdskRpSoyMXDxHvTdipNkY/ZE42lBohzbbMnRv9Sz XDAA+QOiXfTDqUFJQw20hdKSXM/b1ArG+p/fCRKyELhWoNVePLhNVhcfolLxJS4= X-Gm-Gg: ASbGnctDjPsDf+dCZ1CKdNt4fqBe5r9MZOOiX/6J1NR5/R7SBZdLvhtOwbSuufoA/wz 5miW1pK44P+bp4nkz6pi3k0pOjM8wncYkQmsoVLdsC28T9pfJNd3qtiSPSUFxLNVt8I5Ap2DzeI y5zAh+Z3ELF2AGkDugkSUMgyY/wDCSnaZjo6a6BXG/GEoLgqwNKRTH+XSJtMVbe0JcNmPs84rQe W5XP26CKgQzgEQ6DkbL8Igz0Dja8iQd7+igCjG90wU7hXrHLoo76ZO7QbKjilxPt6XeLlgMPhU2 HlIeStNoFnpB2HJaGeQFkRcKl5OQdSm99nGKR/QEP1zzjn6WC8XMs+8H3EDaeU0= X-Google-Smtp-Source: AGHT+IHuFOr4FLO+ZFNr82BE66IFExmH2hKlpvb7d+u4Xph9Bl+U6z0MmCsuokMDRZ1xyVizHupCiQ== X-Received: by 2002:a05:600c:3147:b0:43d:77c5:9c0e with SMTP id 5b1f17b1804b1-43ecf83e90cmr31132795e9.1.1743969712486; Sun, 06 Apr 2025 13:01:52 -0700 (PDT) Received: from [192.168.1.26] ([178.197.198.86]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d98bsm10199924f8f.76.2025.04.06.13.01.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Apr 2025 13:01:51 -0700 (PDT) From: Krzysztof Kozlowski Date: Sun, 06 Apr 2025 22:01:43 +0200 Subject: [PATCH 2/3] iio: adc: qcom-spmi-iadc: Fix wakeup source leaks on device unbind Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250406-b4-device-wakeup-leak-iio-v1-2-2d7d322a4a93@linaro.org> References: <20250406-b4-device-wakeup-leak-iio-v1-0-2d7d322a4a93@linaro.org> In-Reply-To: <20250406-b4-device-wakeup-leak-iio-v1-0-2d7d322a4a93@linaro.org> To: Jonathan Cameron , Lars-Peter Clausen , Lorenzo Bianconi Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=849; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=VozTKdty23C6YF1YQQSfUpINCPfYLQLWcVgIyB0y+l8=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBn8t2qc8HDmx9nNJlk5gIrngYPXgOifgyNrR5ta S9A5mrqeHaJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZ/LdqgAKCRDBN2bmhouD 17McD/9Z5hQHHH5TdFolh63i65wIz6oukBik7uolmyj7mHCtpZzO8Su5fTPql5M3W5zRK7dbsBB qPzpwPLVs38r19ObcYYxInJ1ASt9wuAxzg7sLFjuJ3r8Sy4mYEHoS3ln8hJoUIWxLBOHQJGrDoU nrKxkRnOEgdhTHSx3GZ5xnxzr/kjpj6F53zh+iwHJLkdQjpMGkQ8Vv4+UI0UN1ga9AMH+rak2zN 0YQgn39od572BCBlORKql6Ak/LAGIiYKFEhrJJqujL4sAiODZF5C5E6ntAh+c99M+VMw166IMAx Qx6XNH3V4Io2/BaXyVlaRhNI1iQk/t1BgVtF7o4hrf3pACErakEscg0hw2dv74vB3eELcfkIoxu gpG7o5Q4FPPFx14yNFMFoGKN6C5t+O8lDZxNbqDkmMxDPBKD2/aDjCWIX4dnk4GPG48fq/CUTkN D6FtTFoRSBe4QN+8sIv2VFCmZvdv9zX6G8jvSQhu4vJbOXljK9kRZjLbOXFbL9d6i0AXpIE4Cq2 xwfFbojMHsf296WshWkPNVjHgAFusDINpte4MX3gmGZ1EtvOcEBqsF1Xk1rt9qeOBQgLjY/eA27 Mkp1VKsiFRm0dc/uWTInvlZoxiPp0y2tQW2Hw63YANLJLFAlB0O1izOi7maBiksjva+CjWk0mHM Luu0A3KZbQO0NwQ== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Device can be unbound, so driver must also release memory for the wakeup source. Signed-off-by: Krzysztof Kozlowski --- drivers/iio/adc/qcom-spmi-iadc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/iio/adc/qcom-spmi-iadc.c b/drivers/iio/adc/qcom-spmi-iadc.c index 7fb8b2499a1d00e4a020da893181e693650726bd..b64a8a407168bbc109e6ea9a63b8c4e492ac5bf4 100644 --- a/drivers/iio/adc/qcom-spmi-iadc.c +++ b/drivers/iio/adc/qcom-spmi-iadc.c @@ -543,7 +543,9 @@ static int iadc_probe(struct platform_device *pdev) else return ret; } else { - device_init_wakeup(iadc->dev, 1); + ret = devm_device_init_wakeup(iadc->dev); + if (ret) + return dev_err_probe(iadc->dev, ret, "Failed to init wakeup\n"); } ret = iadc_update_offset(iadc); From patchwork Sun Apr 6 20:01:44 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 878757 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 483D11B5EA4 for ; Sun, 6 Apr 2025 20:01:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743969717; cv=none; b=jeDC6F0SW8MWlqEnYF/dGmjF8ztjFxkgNtV8LymTL4/As0nAaKCJqctTXaJGFyDLtUeIAgZ+jwWo7WI2PMZH8ps6Gpq9UeUNGmk1aDqdSvaENAe8+XA+dJPl/rtXXwC88R+n4kn91ElFptMSK3OZ/wRGwJXr+lj3cZwLReX7uZg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743969717; c=relaxed/simple; bh=l7CRhFlZ6pn6hdkl7kstlhIYoNXxtom6dCRCabxrvMU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fbJAvjAe2FLa+Lm5hIx56WfSdW+zWdcjqgskBfvKnmPMSOClUSsSPtwoZpv7Ht8l4kC2TB+KbRQDwdF60fbQXX/7u250zSyIqMywZX5nKP1Hd5P20tlNRYRFXUecQiUY0rkJkiFWBM+0Xw06uU1lI7ZO49g93y6gh5KD2o861js= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=BiKIhLGy; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BiKIhLGy" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-3913290f754so445970f8f.1 for ; Sun, 06 Apr 2025 13:01:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743969713; x=1744574513; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ux2yY1RchxKGuIqfE/2wQobUJuq5g/5pfkTf4qTXwDE=; b=BiKIhLGy9tI1I+L510O0dm/UGF5E5mhM3xxrtL/nZrqQbmuvckexqPbeJDZ0rnChbl aJsWipiuHgznhVX0+lr8BEp9XvDbSxFIybuDzkFzv0Krf/kMilZCJGgqmM6XiSXxF+GT E63zBNmtfmvmmgPHCgIcERL/Sl/acryadiyyEQFheia393X5GaqsSOpCO3NEaciir7/f +jl6P81cVR+i5+wwFneHkU6E43JXmfGdpUzVfgN9nFoWqtaJmYHTRTJEJNuyCzuV74Zh ozxjsPvDI5/wp9d/Gl/x8QF/ot6VUkvGNfPoXkTYAm8we2SJ+HK35GJt1CMXPep2Jl0f +0LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743969713; x=1744574513; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ux2yY1RchxKGuIqfE/2wQobUJuq5g/5pfkTf4qTXwDE=; b=ZwySqfqv2/O8WxW6KqDf91S7djR7CcLV0QRp8FfC/OT2B7Q6hv1s7jZZPsW2CDNH6e WyuGvRNAfIpurGtBtN1nYdmdI1d3aN4jIlJFyPjKH3L/FBd07yQWdAzocQzM4WitvtGQ PqczK+7oU5lYRbNQk2npt99TNFrHtlDCiXhecaTk76aD6Z4XI2vp85z3D2nRc3TnODO8 +aHNT6Zr/LphS705umR0zd0Wo9qMxZ6Xua5C+5bZgROEzTRtjzohc4MhqInuWteRYdEi zftmt2Wg2M1DPKK8kE2uEYoLr15BWx9Up7IDSJzk5bqsW14Sm7wsj0Li3sYG+0qWsC8K Wy4w== X-Forwarded-Encrypted: i=1; AJvYcCV+51bCdtvZMu28IQvJoRzsqArTgYiL/MD7+dK3fP8sFBmcdaaRVW7AlyUBzkMlQXH6NasaCIfJwMo1bCUa@vger.kernel.org X-Gm-Message-State: AOJu0YxI/ns9PJJMjN8qBN/Oh0gTpyz/8pRI0RcSF58meqE10m9e2FYv HBlziKIP7jmA1foKCcTZyubBOdR/nzi2NPeO8JDJdvt51p9MsGvNDjjK5KJpLAo= X-Gm-Gg: ASbGncuDTOpX3B5MmiIwFrgI6Oq8DWZnZUFrIf6bNtYHL9e+yQNTUxWSixJLCHqrOjy HyggysJk0BQiSif5hc5vOmL90FolJ5wB5xK7GpS6HmyQzVZ8GEguNH+ziAbV5bwxPgdKXcXSblC r/T7kZQkn8a8wUQ9kpfOreveC/NmwHqHtL1mE/aGYwx0aS2g6txuj2/5Nt5JB05Sw2TT7X5HIXB xP8VLKGDxoutFQqjEwgZNh+mbXKboogmOKBk/bH2wRWe7R2kH9Kji/y8tc65TRjNY/wMIcEUsox DqTZRpDwGviFBnsvtSucdQY7VsJAELLwxuXYsMlDYhYytFn0CsqsKQ50CepaT72lvyG+rY+LNw= = X-Google-Smtp-Source: AGHT+IEJ+Ef3Oex5pdoKvNGE2jNPnyAvjiCvNX7k53N0P6w5OL4ACrTa/WVrbC1VAnfl97pDetAO6A== X-Received: by 2002:a5d:6d81:0:b0:38f:27d3:1b44 with SMTP id ffacd0b85a97d-39cb357b616mr2957681f8f.2.1743969713594; Sun, 06 Apr 2025 13:01:53 -0700 (PDT) Received: from [192.168.1.26] ([178.197.198.86]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d98bsm10199924f8f.76.2025.04.06.13.01.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Apr 2025 13:01:53 -0700 (PDT) From: Krzysztof Kozlowski Date: Sun, 06 Apr 2025 22:01:44 +0200 Subject: [PATCH 3/3] iio: imu: st_lsm6dsx: Fix wakeup source leaks on device unbind Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250406-b4-device-wakeup-leak-iio-v1-3-2d7d322a4a93@linaro.org> References: <20250406-b4-device-wakeup-leak-iio-v1-0-2d7d322a4a93@linaro.org> In-Reply-To: <20250406-b4-device-wakeup-leak-iio-v1-0-2d7d322a4a93@linaro.org> To: Jonathan Cameron , Lars-Peter Clausen , Lorenzo Bianconi Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1002; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=l7CRhFlZ6pn6hdkl7kstlhIYoNXxtom6dCRCabxrvMU=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBn8t2qifPOWPOc85NGw1m7yDEGSug8i9ONXMKX5 5gP53XtWDiJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZ/LdqgAKCRDBN2bmhouD 1+B4D/0eXUZVxZoiPcZjMLxa3FH+U7uhxJSCqoHJdSpdEtOM4g0uDEfsauINOXiir8KF2EspHqx nkVH6hoL3EaHuDsWeD8bjY+PNKS3sThCakly4LNMYHyPCd9Hw6ikDYNkk3IIAMigdi0g9VUvBh8 A1NZIeM2OwUbGz01zpelL3sXyRjgDxQY6d0BlX4iTPnAiqmdIq5pTVDmp+v7qZd5owzwKwYqvN2 OCom9ADN+y/ham4MXhB7UFJoUKyrQcH7EKiqUCZHEGKCC7z25oZl26FaJCieR09OMf384mizQ7n zGGGFJ5Ik4Y9vMcQ6qMmM0GglVdV2VgYrHKob4im82KXGwWNcVIKS2a6KA+MGiv1riFAUOPDHzj h93xmc6Zfx594JWNbGfOHU7+n+zgbzGDO3KFe25OQLRHsWKNpUGOSgfTV1EVzL10JB8v1iWMvAR 5E/NTLjRjTwTqfqb/2M5DMEsJ4EAZi7EugacBRC8h0CFI1dJYLPtVg6Lk1R/98F/DFqe1VZhj5p Lg/dHImuAp5oCNfiLULw8w7XbBvIHYPeLFABam1fdzfllND6QIUUN1VX6wrr40uhxvJANSrJfL3 2Pc4yd55QRMjpKsKeX69vo2wtceyXiLQ5TzD53RWM1brIXiYa1zb191VmBV6xp2Glo0pnt68BgT ThIX3TfHGrgd1Tg== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Device can be unbound, so driver must also release memory for the wakeup source. Signed-off-by: Krzysztof Kozlowski Acked-by: Lorenzo Bianconi --- drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c index 4fdcc2acc94ed0f594116b9141ce85f7c4449a58..96c6106b95eef60b43eb41fef67889d44d5836db 100644 --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c @@ -2719,8 +2719,11 @@ int st_lsm6dsx_probe(struct device *dev, int irq, int hw_id, } if (device_property_read_bool(dev, "wakeup-source") || - (pdata && pdata->wakeup_source)) - device_init_wakeup(dev, true); + (pdata && pdata->wakeup_source)) { + err = devm_device_init_wakeup(dev); + if (err) + return dev_err_probe(dev, err, "Failed to init wakeup\n"); + } return 0; }