From patchwork Tue Apr 8 07:42:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 879648 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AAF1264FA0 for ; Tue, 8 Apr 2025 07:42:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744098128; cv=none; b=H6KAgKFr3HWN/D9YV1L/TAntZo1t8d0OVnACEwzZRZZevSzfKqUQE7spodR5gidUcm0tEDW4McEmATofYvIFzrDwoEdUN+kKezMKGHzeYxuao3UjLvW+kyeVvhI6iWgGofZyG3C4XfVd+GhJ2UKAEj62or+Y8uTLCXHP0ksH1Bk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744098128; c=relaxed/simple; bh=RyAfIuZv3je3SBTMoF+/atj8kvwGAnbZgGzow5BZkno=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=VOcQ/a/eQEJF+brmfzD93DD2PpRpFHZNl6tXVgRFeEF4ExT8SFaZJvaPJ82RZFBKygypsJvN+i4IV7oL/mht2jfUctADeVcr0O9w/TThgQB0qZZrSesQuaisMklZSwyFUw2BziHmyLMasUVtGKApz1nYlUn+q3w3TS5A0L0Vf2c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=OZGVjbzu; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="OZGVjbzu" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-43ea40a6e98so45455655e9.1 for ; Tue, 08 Apr 2025 00:42:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744098124; x=1744702924; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=sySIkoaK3IRdQx4BR3TKes9oICtr7GId9/YshM2vE9c=; b=OZGVjbzuzdA2VJyAuhDPv+6IOveBa0REDv3Z+i3j1Qnme1xKSygWlKtm7mujBGrgMT AyqZR/LbFjei0gWg2mWjA8MJtlBkXbTDRr6MBtZQORHS+RXNWtY5C3zEkttZSEx5IoeB jcvhLOkujjG11uq2lovheJCW//uRhgzfK7LWnTpnzXBkX+xgK2uohX/+f+dthfTjqt9q 3tuz4UeEjUeg7l2nhl7vb0XRrYwwFs+zlSQ8KaPyGfnaQn6zC0TgpfTuAevKoUDuknA5 bkRjWqzvg5LQgtH3p0HjB12PTucvCMBLRKwo++lEPubsDzA1BAO8Y+T5vqW9TGkNOGOq xssA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744098124; x=1744702924; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sySIkoaK3IRdQx4BR3TKes9oICtr7GId9/YshM2vE9c=; b=v+sE+YIN+YHh3+sA0b1zBPweXzCZrf7bBuqOIHrbWQxjFJmC/dY35TzofqyyauYcg5 xsEYaT4sEXF4kGSVjUtWQh1EEQ0JrVJeY+dUOcV0vslBFbd8CwVMXjDWEYJpDv+jBceh ec+ReTiJghx0NZPTLd8Tu1rDM9NhZ9ou6ix2AuIgTMqM1s1YhUCEC5POWoBOI1IiMEX8 6ezHBvB4oHHy0wzNn4Oox+p6aaJnxkTR70CNVzykDeZE53Fj1bCSFag3alJS5HGwSzV1 Ge+5X4bEa/IlwFHIdgatVxkg74FA4eJdnJEhhq0NltGm9a1sohVG/CAtEXHdTfmwYHPf HopA== X-Forwarded-Encrypted: i=1; AJvYcCXCVsUADFBNZekrMhXdKC6dTu5uZ3lwDoz52LbYnMFuewJcwQ2uPxLjvguS3B+h3mlPyx471QAKcLUh3Nk=@vger.kernel.org X-Gm-Message-State: AOJu0YxTSHSf9HEUChvAPeOIYUuwO1ban08bZ1aEzgfcYmIWy+sx0VW5 /RaXISD9vu421c3r4+VqjHsrzxE3xKEHRuiF6Coz4oRGdRDGTIc1Eg+WGhbtUu4= X-Gm-Gg: ASbGncvVr15hUmtN0GlRy7ILr8wByH3y+Cvuu5vCvP9mkGfbcNhxBKZ96titM8aK0MS BJ001reY4gOXMglI6L31ViOiFg5EMPSZq8vBDx5FH2J1oPq8/WI4yZGv8DsYa2vpSfd0zLAcvbJ U8r2ns4cZZH3TI/vUG7sEG7W0t7a7Wcw54YvRe8fgUYnMrjsbiLEDYzI7xpoYrEvSPqjO5bejYD uFaBUBRLkxGO1+AYiK5FsyeLlFF8Rgj56XhaxUtWeO1cioAwdQQ3SfXh39si5plTkD5MIKxF8/B U46Y89FqE/wFk95POYoIyeRYZClhVBEOIfu68g== X-Google-Smtp-Source: AGHT+IG4TGtq5Au/w2UqKHAScxhidBc80RYYVfg8sQ7D96APlwDYeYiEbrvsRIpR0Qt2Wl4Y27DqyA== X-Received: by 2002:a05:600c:a04:b0:43c:efed:733e with SMTP id 5b1f17b1804b1-43ee06401a7mr91933215e9.14.1744098124346; Tue, 08 Apr 2025 00:42:04 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3009644dsm13876928f8f.6.2025.04.08.00.42.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:42:03 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:42:00 +0200 Subject: [PATCH 1/2] serial: max310x: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250408-gpiochip-set-rv-tty-v1-1-fb49444827d4@linaro.org> References: <20250408-gpiochip-set-rv-tty-v1-0-fb49444827d4@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-tty-v1-0-fb49444827d4@linaro.org> To: Greg Kroah-Hartman , Jiri Slaby , Linus Walleij , Bartosz Golaszewski Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1635; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=r5oSZs3f1zUsjX8zJm9fMzINl/85fLjbu6aA1pLghh8=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9NNJcfc8I+UE8lWGsSD2mAUzyLlhYBjZVMKLq D4CZcJEGTCJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TTSQAKCRARpy6gFHHX cqZHD/97TfcaZqLEd6+BoImr2F6qt8m0As2dhiJpJWF/3LnCMt3kpc1q7dQb1mrpQOOHB5hyxEL qTdEhFy69rizvMFzFKSHvV3KqE1oaw7tGkL/DI2/mO16p/z/yimAT578lLj7dt2Dnkn+BBi2RO/ x/xMAkrhjmvCRUvosG5tc3X+XUmfEwKNT61TiMSueBz0pE6XkwSF5G+UmQzFhGQaKisXkjEKl52 eTJNJRci/+cPjRPYOq3OSokuZek6VpVVMIXhvkPCVT3dHYqCLwgDNawvrGnHw1GSgOvkNOcWYF3 w3obIPOYzmdnz+wJqMrfeukc8PM1qGF6AZF9NbdrRQWyD74Oj4kX0ls1H2zBzJnO3wKkRgzd/YW TKpczo74KFS7mpJ8xgUdWBhql1OSAxqJQuiPJl1xfd/3ineQpIg3PdduSDfmIPM/gt4u40Zhedk gAafzdFblv0F04swja6Q/DAQu3ycD+OpcA9ZeXX0tRDmNRICCceV3hlWiFdkFEUUuIizDKGGO5O xyOFFyQp342P5TfJyB4sHEtJLx5Yv4vk727ysZ7xq3SOFIaiBhnqMNcyxxGo7uloid39NT00zgm g/IjOiSxBH/k8aKhTSBwWIZrz7qwCEZegwWIIrHoEu2scxmEkIeUjvStc5+sLqN/iH/vtRv3lhs rsb3C4Mn+ZW4zOA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/tty/serial/max310x.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/max310x.c b/drivers/tty/serial/max310x.c index 35369a2f77b2..541c790c0109 100644 --- a/drivers/tty/serial/max310x.c +++ b/drivers/tty/serial/max310x.c @@ -1189,13 +1189,16 @@ static int max310x_gpio_get(struct gpio_chip *chip, unsigned int offset) return !!((val >> 4) & (1 << (offset % 4))); } -static void max310x_gpio_set(struct gpio_chip *chip, unsigned int offset, int value) +static int max310x_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct max310x_port *s = gpiochip_get_data(chip); struct uart_port *port = &s->p[offset / 4].port; max310x_port_update(port, MAX310X_GPIODATA_REG, 1 << (offset % 4), value ? 1 << (offset % 4) : 0); + + return 0; } static int max310x_gpio_direction_input(struct gpio_chip *chip, unsigned int offset) @@ -1411,7 +1414,7 @@ static int max310x_probe(struct device *dev, const struct max310x_devtype *devty s->gpio.direction_input = max310x_gpio_direction_input; s->gpio.get = max310x_gpio_get; s->gpio.direction_output= max310x_gpio_direction_output; - s->gpio.set = max310x_gpio_set; + s->gpio.set_rv = max310x_gpio_set; s->gpio.set_config = max310x_gpio_set_config; s->gpio.base = -1; s->gpio.ngpio = devtype->nr * 4; From patchwork Tue Apr 8 07:42:01 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 879296 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC48B264FAE for ; Tue, 8 Apr 2025 07:42:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744098128; cv=none; b=sEGNS6oHilg1G0f9ia340vJlpo17NkhwGFClzOqtekM4cnjJqTIRnjWAnsvrNnCEtu/ph01oCH/HSzX91GJU/WbxlVSb3F9rqhX8AX+9Rp3a119GqPDnev2kBf891M6Cc7OMDjysdk1FJ5q0yanbdLtURcH+zbEjRXVSJwWMZjM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744098128; c=relaxed/simple; bh=w9HdOzQ+MPAl+VXOwxJ+lRF040+F46AXVGIrMR12QAU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KherjLeP4zimAbP0fO44Paro/n+fL1A0PXwioPGiYee+GXLUCdnfg2538/MEVYYkVCOA5o+1aJX6/Jlb+m4KHBhoFbamdH9EU2BwTJ8HT37ggwAXN4tfTdWOtRONkcjOzWhmGSNDzYnAmbh45ub5gdbZg5suW//IW69/QJEFziE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=f5qwqH4D; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="f5qwqH4D" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-43ede096d73so21119025e9.2 for ; Tue, 08 Apr 2025 00:42:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744098125; x=1744702925; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=+E4+JrmdhxqWEi/lSbN287+Ko95rcwpd5gn3BuFGQ0o=; b=f5qwqH4DtVvSJ0eJvGpun1RuP6ujUqzZcC29/w86RTHbm/j+wAuwM+BSQjIBAWNHR1 8s3QTu32XqUnZEnHkQwsH9DgcCNLCsFHfoQdOpWd38ldTtEutKgnVJXnsRrNZe9v/J9a gI6Flcm5DhCvCHBSVHNBLu7/PT+SU4YsFdPWkdmc3uvlZBPS17w6q7IvCjikNSPxSyEZ yoErSEZfHH8dF4E1VV4ER9+2O6nI+f8OaHsq2/iWVHbVbcrjQDu4v1fgC9pC1gMG5TeU ca/10YXFzNnRCxFde5GYyuNIMjdreLH2JPnLQsOOpBPtpqnisu+RkjpgNYzV9ZlJt8nX OtRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744098125; x=1744702925; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+E4+JrmdhxqWEi/lSbN287+Ko95rcwpd5gn3BuFGQ0o=; b=bGkhskkVlh3U8ODZTVE/o6iwVUZe3LcP0KSserpxpbFMrgU+TnZP3R12J0R9KbyYQM lXTObLre657gpw3smlBZcSWcR+f7llJVQoWZumYMPwq4wd1ElRrCy6DSyTgYA+7qnj2f wsDp3NLqUVtRNh94tCZtprXETR4SN536TFqhEYCr77jVEQvoerjQk+1+YuAKf/+ixQ5c zSJv692Q3jh3EwsotQmFCA/LJ2GgcyefG2URrf8eK2+Y3yJLBJrsK+s5MVwjghAg2J3/ Hfp30UE4dh7i+66BjFsqVejMRm11rH3Nknv8Owq2BIF0lsrsng2DJMXKqkofYOBUZKSE ZEYA== X-Forwarded-Encrypted: i=1; AJvYcCU0CIWWxxHxkaTqP4OsxJdU3MaKFeJlgtxqa90n4n6svrIC8likfR4NCwXm+USPEii7jM6U1r/72rDnhIE=@vger.kernel.org X-Gm-Message-State: AOJu0YymNR7ye+HtZUwLyk07OaVZ9Ukb68f2maIrHTYaQ9Xt0NvyvoLX o1yynaiA6V5fsMofbQgCEB019AcS/dntnrbOTW32OZ9yvvh2HVDm1k13wqgTLPRjMvdINlZ+5jV gYfA= X-Gm-Gg: ASbGncuL9jLwvwpMCs14hH+rWceyEFTJvIxD/K6g88QglVDauEGIUAXnu43wQJN1DON 2OKotTx0MaKhnarXJV6jCi1I5dM4oR1QSvxvMQZ4cZPXcQCSPdtb+youN8BHpdPp0BLIIzhTZis xHZI9eUEMDSR+MeyUhWjOPratIlRLwtql8ObfUsEmUccbf2HpYHhWi6H3CTTcJba3UbDESYVAIN 9iiKop/fX1YEJtpHJYqbHR+90PzuOltjLGV70c7KJrHBI5qcTDepFrWtNLsz3BUOvMaPHSpWYMT hD3GI41dm0e4dZzWi7UGu5rdzBnC2M5xLmIz7FKZ0V38P9wX X-Google-Smtp-Source: AGHT+IEgYUJEVuD47zg99gzM4mhFe0o7lX2Qif0XxVRVrvKWgac3NPWEP6sjqY2Y/veqsO5+qA2ypw== X-Received: by 2002:a05:600c:698c:b0:43c:eec7:eabb with SMTP id 5b1f17b1804b1-43ed0bc790dmr159298255e9.8.1744098125299; Tue, 08 Apr 2025 00:42:05 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3009644dsm13876928f8f.6.2025.04.08.00.42.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:42:04 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:42:01 +0200 Subject: [PATCH 2/2] serial: sc16is7xx: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250408-gpiochip-set-rv-tty-v1-2-fb49444827d4@linaro.org> References: <20250408-gpiochip-set-rv-tty-v1-0-fb49444827d4@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-tty-v1-0-fb49444827d4@linaro.org> To: Greg Kroah-Hartman , Jiri Slaby , Linus Walleij , Bartosz Golaszewski Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1572; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=hQMZZhr8YRzEKYPpfo+vbJ73LYUTFXlK4aC8NxOLWao=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9NNKZc8Vdaxaa/DH5AXXTlTVJB177D+PAdS5m FnTcJm7bh6JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TTSgAKCRARpy6gFHHX cmvBEAC8a8bQCk7ugVP/EShWabd3phdda13V642kXNozPtEmmQX73ubQFwOanHqNpH5KHS3Sv1C HggbLZM8UFI9OX9AExD+mafcuzs1giV+w54uswUMUKFA71fWGMdUQuKP7WHsDj0KeNc8ry3QQb9 IQNfaUV+V0iyvoJ0xb29Dak/jaU69jWMzqdj/XR7w3yxEL4FcZ2hhHVdVaRC0ls4paJ7OiVFJmY cTlCuXkyTdfn6oFR0VVnN7W8qRSD9Elejz7ByjIbmg8xRJFfcnEFAU2BD70d8NeKDsuXoBfy5yF uuCT7ABi0QOArFVwtKbXczovOrigULbqhJZC326+G0IYddsp3MdBcCVinZynfvLoBZSqhLqXoRC w2Z3s0PW8jlr9661KvtNswG0xm/O4rS75vUihyAn6EehmWb9/SnP9LV5W75TZ5xaXZUjCC11g+M qgQXbekLAVUSakRmj7PToxh0f4qsE3pkBk52UzhSrWy5q+zKAC1pW1TVQdqgzQx8tW4FUecG9iF igWSd2j5REtSlwHiLp9K8mL8XAgJloIylS+JN3MJNbl4wTvv6l3L2RV6CjmqoWpFV3SgbqQs/K2 PeFa9CnsSBUqS2Az4ybSQDh0JhBgROU7o3tYcCw78S8evp/79pDgDwU79XZjS5FUDoWpbZIm64E mFsC6GdT5wM+33Q== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/tty/serial/sc16is7xx.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c index 560f45ed19ae..5ea8aadb6e69 100644 --- a/drivers/tty/serial/sc16is7xx.c +++ b/drivers/tty/serial/sc16is7xx.c @@ -1333,13 +1333,16 @@ static int sc16is7xx_gpio_get(struct gpio_chip *chip, unsigned offset) return !!(val & BIT(offset)); } -static void sc16is7xx_gpio_set(struct gpio_chip *chip, unsigned offset, int val) +static int sc16is7xx_gpio_set(struct gpio_chip *chip, unsigned int offset, + int val) { struct sc16is7xx_port *s = gpiochip_get_data(chip); struct uart_port *port = &s->p[0].port; sc16is7xx_port_update(port, SC16IS7XX_IOSTATE_REG, BIT(offset), val ? BIT(offset) : 0); + + return 0; } static int sc16is7xx_gpio_direction_input(struct gpio_chip *chip, @@ -1422,7 +1425,7 @@ static int sc16is7xx_setup_gpio_chip(struct sc16is7xx_port *s) s->gpio.direction_input = sc16is7xx_gpio_direction_input; s->gpio.get = sc16is7xx_gpio_get; s->gpio.direction_output = sc16is7xx_gpio_direction_output; - s->gpio.set = sc16is7xx_gpio_set; + s->gpio.set_rv = sc16is7xx_gpio_set; s->gpio.base = -1; s->gpio.ngpio = s->devtype->nr_gpio; s->gpio.can_sleep = 1;