From patchwork Tue Apr 8 19:13:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?J=2E_Neusch=C3=A4fer_via_B4_Relay?= X-Patchwork-Id: 879302 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBC0923F273; Tue, 8 Apr 2025 19:13:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744139639; cv=none; b=P+irbqfA0uzfBdBjfg6ZHP3J92BkZONWln+u9e3AOtyvsZwglga2EbyCG1bAfA3ApxoLxAtCvl22JQoqofwnCW6YcQbnwzRNBXehmhb1gbf23kAYmJ9IaDwz5xgbsNkl5+7YgWcW5ooePDyVXG8CWw3pU0K/TmBlonND6kMo1Jk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744139639; c=relaxed/simple; bh=88n+/OmONN80dFebJ7pjCh/IqPsrPBPEi4aqhvPQZTw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QZQw39hC8UClBkkob8xfqYWYKAWjjteSnSmMpWLUAdUb1rMqc36Sahhw0b3lubj4g4Oy5HS6IKTvOzQsIMhtbJdC3ARF4uruYMuXm1tjqHFnKzd0klMZAmSkMEAa+rZZBa1S4LhfiOU8XsA6+KNrm48W4vnmhRkOCVYu2RQ/Y+Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MPaiY989; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MPaiY989" Received: by smtp.kernel.org (Postfix) with ESMTPS id 56D64C4CEE8; Tue, 8 Apr 2025 19:13:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744139639; bh=88n+/OmONN80dFebJ7pjCh/IqPsrPBPEi4aqhvPQZTw=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=MPaiY989micZMK2KwK14OkSWYH/nN4F5j2Ec0cwSThksUNrPDG7lKWAxV/1Iu23Ca W22FOxUIflzgBD5yHIYMVo4VlI6/OOURTh4PD7mAOfgbh10TfTDcak5cmTgig9CnDJ 1udak+yhRGGUGJr/i+B0WR0VhkKaUULD4DSjRwI6zLLc9klB4iPcAQO1xmMgAYmUKM OvFc2sg0avd8zniS8QKQt4IaJXcnWkXUxYjDgyYDIi/1kfFEoenIIb/SpqY+Gb+HuD njYLki9jfKkCnC65tLEbmJv6ZBGWFsn7/wOqcV08aJiAxk4nUxW01mEYfHX9kKHTH6 Vwrma25qVtEsQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41929C369A5; Tue, 8 Apr 2025 19:13:59 +0000 (UTC) From: =?utf-8?q?J=2E_Neusch=C3=A4fer_via_B4_Relay?= Date: Tue, 08 Apr 2025 21:13:12 +0200 Subject: [PATCH v2 1/2] dt-bindings: net: wireless: Add Realtek RTL8188ETV USB WiFi Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250408-rtl-onboard-v2-1-0b6730b90e31@posteo.net> References: <20250408-rtl-onboard-v2-0-0b6730b90e31@posteo.net> In-Reply-To: <20250408-rtl-onboard-v2-0-0b6730b90e31@posteo.net> To: Johannes Berg , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Kaehlcke , Greg Kroah-Hartman Cc: Martin Blumenstingl , Jes Sorensen , linux-wireless@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Bitterblue Smith , =?utf-8?q?J=2E_Neusch=C3=A4fer?= X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1744139638; l=2077; i=j.ne@posteo.net; s=20240329; h=from:subject:message-id; bh=4nIhUGSI5Ng3z4pAy5LHnkaqH2Vjs66teKpBTHo1jxU=; b=+vY+V/NyRm4aQpt4QGCRdBd1HVGT5r1dsJSfIREdxcTqOB3DKIiMrYUpU1cEl4rcc02hiyeDx 48hktykm3uHDQtYx43hY+hvBe+POUGq04XV6kV1FXjHHpE9PxKasWPO X-Developer-Key: i=j.ne@posteo.net; a=ed25519; pk=NIe0bK42wNaX/C4bi6ezm7NJK0IQE+8MKBm7igFMIS4= X-Endpoint-Received: by B4 Relay for j.ne@posteo.net/20240329 with auth_id=156 X-Original-From: =?utf-8?q?J=2E_Neusch=C3=A4fer?= Reply-To: j.ne@posteo.net From: "J. Neuschäfer" This is an on-board USB device that requires a 3.3V supply. Signed-off-by: J. Neuschäfer --- V2: - Use my current email address - Remove TODO comment - Rename schema file to realtek,rtl8188e.yaml. This is the same granularity at which the rtl8xxxu driver is split into files, making it unnecessary to rename the schema file if another similar chip is added in the future. - Change license identifier from (GPL-2.0 OR BSD-2-Clause) to (GPL-2.0-only OR BSD-2-Clause) because GPL-2.0 is ambiguous --- .../bindings/net/wireless/realtek,rtl8188e.yaml | 50 ++++++++++++++++++++++ 1 file changed, 50 insertions(+) diff --git a/Documentation/devicetree/bindings/net/wireless/realtek,rtl8188e.yaml b/Documentation/devicetree/bindings/net/wireless/realtek,rtl8188e.yaml new file mode 100644 index 0000000000000000000000000000000000000000..2769731e07083b14e2f7388858dcded92c442018 --- /dev/null +++ b/Documentation/devicetree/bindings/net/wireless/realtek,rtl8188e.yaml @@ -0,0 +1,50 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/wireless/realtek,rtl8188e.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Realtek RTL8188E USB WiFi + +maintainers: + - J. Neuschäfer + +description: + Realtek RTL8188E is a family of USB-connected 2.4 GHz WiFi modules. + +allOf: + - $ref: /schemas/usb/usb-device.yaml# + +properties: + compatible: + const: usbbda,179 # RTL8188ETV + + reg: true + + vdd-supply: + description: + Regulator for the 3V3 supply. + +required: + - compatible + - reg + - vdd-supply + +additionalProperties: false + +examples: + - | + #include + + usb { + #address-cells = <1>; + #size-cells = <0>; + + wifi: wifi@1 { + compatible = "usbbda,179"; + reg = <1>; + vdd-supply = <&vcc3v3>; + }; + }; + +... From patchwork Tue Apr 8 19:13:13 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?J=2E_Neusch=C3=A4fer_via_B4_Relay?= X-Patchwork-Id: 880565 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBEE023F43C; Tue, 8 Apr 2025 19:13:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744139640; cv=none; b=Sgf/6RwL90dLgaX3qgDFuL20/76Rj/5mWCBwSe0WFHeKcGKDL7BM8BX81nIEcDVj0DQLbpFbwcx9pbVH1WGRkVGC+5n9f/L4G3lFNFR5EsDnwSEzvR2azKzW6BIQsK4wUpFneV+I3p9SAZBhkvsYJih7rKgT07zl8ZctpSGtXTk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744139640; c=relaxed/simple; bh=Us/AQtTYq5S+37wYdRc5NIVVXDfoZhcpVR62WWKXLWA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=s+P+iyDA5lR/qSVrOS382W+6kphewtyIU4ANgfFeeyKFypd7Kqig9/PR2xnLX9IQnQbD6IvSKGBFlxAXlQdEVz9SebT21zX5jgfbc7IXOMT+pJKdD87kA2PYagQPQTpDzCxMesDg4k4AUcqS5zGi/MvNqHdyVY6qxs4pzRDJ6pU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tcBofC4+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tcBofC4+" Received: by smtp.kernel.org (Postfix) with ESMTPS id 6ADC4C4CEEA; Tue, 8 Apr 2025 19:13:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744139639; bh=Us/AQtTYq5S+37wYdRc5NIVVXDfoZhcpVR62WWKXLWA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=tcBofC4+Iq6NRAMpYi+QIL4BxVbnvlqdusD18G9T4wwdxyMU9O40izGmBmWG3EU8I 5IstIjDIHt1owqlpZxfEHAXSlTr9iyx0ERSuF3jYwwOc141I23GXh01aspvUxmkZxF wtPGvxPWiiPRkr8iN9gA8xCzH9B+wzAHdQT1DPEG5FvuB2PTOAy7B/pbpr8QRopfpI Ao7rKOc+LbTr3Fd/UodibY8tiXOnwBsHwNHDqu//uI2n5x2g/8QXeTVeBougQHRQ0P VT4QAjMufyTDK/E4rUDGLjDxe7x13xZ9VNQzT+1Si98CRbK/iNP2JnlxpQjcttj44U sGoLe2lpPPoMw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52241C369A7; Tue, 8 Apr 2025 19:13:59 +0000 (UTC) From: =?utf-8?q?J=2E_Neusch=C3=A4fer_via_B4_Relay?= Date: Tue, 08 Apr 2025 21:13:13 +0200 Subject: [PATCH v2 2/2] usb: misc: onboard_dev: Add Realtek RTL8188ETV WiFi (0bda:0179) Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250408-rtl-onboard-v2-2-0b6730b90e31@posteo.net> References: <20250408-rtl-onboard-v2-0-0b6730b90e31@posteo.net> In-Reply-To: <20250408-rtl-onboard-v2-0-0b6730b90e31@posteo.net> To: Johannes Berg , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Kaehlcke , Greg Kroah-Hartman Cc: Martin Blumenstingl , Jes Sorensen , linux-wireless@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Bitterblue Smith , =?utf-8?q?J=2E_Neusch=C3=A4fer?= X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1744139638; l=2744; i=j.ne@posteo.net; s=20240329; h=from:subject:message-id; bh=QAwW/fIZM1Msvyl7HFFGS2WH+QP1UgWq6wvZq+BYZTg=; b=y9Q6G/o77lodCmXWcuYBq9RWABkFEcolT/FoGziqDsMP8XZrz51PCYjy0q4F0xA2X5IU90gQD 9A4kJYwfHMUDqtlUe+2Fb4EWRwCf+tRGXOOts/DPGv4r7F28U8p67qI X-Developer-Key: i=j.ne@posteo.net; a=ed25519; pk=NIe0bK42wNaX/C4bi6ezm7NJK0IQE+8MKBm7igFMIS4= X-Endpoint-Received: by B4 Relay for j.ne@posteo.net/20240329 with auth_id=156 X-Original-From: =?utf-8?q?J=2E_Neusch=C3=A4fer?= Reply-To: j.ne@posteo.net From: "J. Neuschäfer" Realtek RTL8188ETV 2.4 GHz WiFi modules (detected as RTL8188EU by the RTL8XXXXU driver) are found soldered into some embedded devices, such as the Fernsehfee 3.0 set-top box. They require a 3.3V power supply. Signed-off-by: J. Neuschäfer --- checkpatch.pl flags the "usbbda" prefix as undocumented because it isn't in vendor-prefixes.yaml. It is, however, an established pattern: $ git grep -E 'usb[0-9a-f]{1,4},[0-9a-f]{1,4}' | wc -l 213 V2: - Refer to RTL8188ETV in the title and description --- drivers/usb/misc/onboard_usb_dev.c | 1 + drivers/usb/misc/onboard_usb_dev.h | 8 ++++++++ 2 files changed, 9 insertions(+) diff --git a/drivers/usb/misc/onboard_usb_dev.c b/drivers/usb/misc/onboard_usb_dev.c index 75ac3c6aa92d0d925bb9488d1e6295548446bf98..2f9e8f8108d8c36403b02f3e66db55757d4808ef 100644 --- a/drivers/usb/misc/onboard_usb_dev.c +++ b/drivers/usb/misc/onboard_usb_dev.c @@ -584,6 +584,7 @@ static const struct usb_device_id onboard_dev_id_table[] = { { USB_DEVICE(VENDOR_ID_REALTEK, 0x5411) }, /* RTS5411 USB 2.1 HUB */ { USB_DEVICE(VENDOR_ID_REALTEK, 0x0414) }, /* RTS5414 USB 3.2 HUB */ { USB_DEVICE(VENDOR_ID_REALTEK, 0x5414) }, /* RTS5414 USB 2.1 HUB */ + { USB_DEVICE(VENDOR_ID_REALTEK, 0x0179) }, /* RTL8188ETV 2.4GHz WiFi */ { USB_DEVICE(VENDOR_ID_TI, 0x8025) }, /* TI USB8020B 3.0 HUB */ { USB_DEVICE(VENDOR_ID_TI, 0x8027) }, /* TI USB8020B 2.0 HUB */ { USB_DEVICE(VENDOR_ID_TI, 0x8140) }, /* TI USB8041 3.0 HUB */ diff --git a/drivers/usb/misc/onboard_usb_dev.h b/drivers/usb/misc/onboard_usb_dev.h index 933797a7e0841ceee655b80ee1c8d21bc2eaaa04..4b023ddfbdd61efbc41c039cafbd0c85971563ee 100644 --- a/drivers/usb/misc/onboard_usb_dev.h +++ b/drivers/usb/misc/onboard_usb_dev.h @@ -45,6 +45,13 @@ static const struct onboard_dev_pdata realtek_rts5411_data = { .is_hub = true, }; +static const struct onboard_dev_pdata realtek_rtl8188etv_data = { + .reset_us = 0, + .num_supplies = 1, + .supply_names = { "vdd" }, + .is_hub = false, +}; + static const struct onboard_dev_pdata ti_tusb8020b_data = { .reset_us = 3000, .num_supplies = 1, @@ -118,6 +125,7 @@ static const struct of_device_id onboard_dev_match[] = { { .compatible = "usb5e3,610", .data = &genesys_gl852g_data, }, { .compatible = "usb5e3,620", .data = &genesys_gl852g_data, }, { .compatible = "usb5e3,626", .data = &genesys_gl852g_data, }, + { .compatible = "usbbda,179", .data = &realtek_rtl8188etv_data, }, { .compatible = "usbbda,411", .data = &realtek_rts5411_data, }, { .compatible = "usbbda,5411", .data = &realtek_rts5411_data, }, { .compatible = "usbbda,414", .data = &realtek_rts5411_data, },