From patchwork Wed Apr 9 04:14:44 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thiago Jung Bauermann X-Patchwork-Id: 879352 Delivered-To: patch@linaro.org Received: by 2002:a5d:6dae:0:b0:38f:210b:807b with SMTP id u14csp5802351wrs; Tue, 8 Apr 2025 21:14:57 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXYdYaR7eW36LdWWceQpAaTuyMmTLUFFigYROufY3cAMsAEhlMHi/ctMSzU4DulQvJac7nAJA==@linaro.org X-Google-Smtp-Source: AGHT+IH6XoKksoxifKVx0b0GrSNT7ywNPalbZVjJfvgJocqnawBbSfj7w40dv7FHUFJf7vd0sdIc X-Received: by 2002:a05:620a:d96:b0:7c5:3d60:7f88 with SMTP id af79cd13be357-7c79cbd70famr233040385a.16.1744172097589; Tue, 08 Apr 2025 21:14:57 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1744172097; cv=pass; d=google.com; s=arc-20240605; b=ZQ1JhT4TmonApr/O2WcRo7WWefdtZzcINPe70JxIgIDDJd0272HlQ/xfV6rGTNzNoe sDxZW9PyK/zbmd4fRbDkwSdVgPH2+kSdqgnngq6yVOpb1HsYu7Dh3j+PL9+YFkx1HFpX x00eN8qH1JUQVc9vv4jsgZGQMkizIKPB1HiNS8Ku8NbQ+P8Gd4oYmTFpBBXpjYcSpWN9 Mc0jXByBFb3zbbdV3VLqokEIqKiQ4KrS9j9Uky7bjjJTc9WE7fYKbrkQzoUvuE9aAlZB f8nffS9CQ8MffZJ+R2xURDhO9SCDjXDB8dwnWHAK7keq8O4zqMvaE54Pb0zaPgY07LRM S1Dg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:to:from:dkim-signature :dkim-filter:arc-filter:dmarc-filter:delivered-to:dkim-filter; bh=uW8aZ8KmRN2CSJ4jN08skNsbqGxyYFr3FJN2pMOabvc=; fh=72kqq0iQhigvR9Vv/oqX5ebs3Yyyw7XhzWxOOEPdupI=; b=Gz6IZKweohVAIZV+bwZIEt/cFSW/5GxOkJeJ3C0r3Cv1iK7gcN2oe95gG+JBmGCtwd oEcWdLf+ub6XJtakXUirKxOyHi2+zFEcf6+5eunc6HmwccAS3LctKwMGLK7Gr238d7EL ru+uVZmoNSMnFGal+GfZq/Gq/cr1HplokpVe7c1TI9DV2BF3bkSr12bhd+tNDuw0L9st OQKhG5jUg+uyWBeOg93dolKQtfoTtaBTLzgBpxGbKmCUuKbowW8YFSnNGIg4YPqp9TYC x0AvxDxmyaOYC4eDIRlV0um9Pz/utINnnb2kpHfB7TF1u2CSy6MjFfz0Ao2gc8u/4xop SRTA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=a3WCPdGK; arc=pass (i=1); spf=pass (google.com: domain of gdb-patches-bounces~patch=linaro.org@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gdb-patches-bounces~patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id af79cd13be357-7c7a144fb9esi25219085a.378.2025.04.08.21.14.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 21:14:57 -0700 (PDT) Received-SPF: pass (google.com: domain of gdb-patches-bounces~patch=linaro.org@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=a3WCPdGK; arc=pass (i=1); spf=pass (google.com: domain of gdb-patches-bounces~patch=linaro.org@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gdb-patches-bounces~patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9406B3861027 for ; Wed, 9 Apr 2025 04:14:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9406B3861027 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=a3WCPdGK X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by sourceware.org (Postfix) with ESMTPS id C34C5386075A for ; Wed, 9 Apr 2025 04:14:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C34C5386075A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C34C5386075A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::631 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1744172089; cv=none; b=wVyR0pBz53ZVV0MLNY3Ubn7FVQsOPU67JCcf3ZSarXgxp99+CZMChTxgQIpyzlE0dmGerIk5yWVAK3MBIsRKUh3n3x7QyCwcXfRBMOCReMOEzvXm8DZueEZRMOAeepNTBvlZo304XKASHKx2rID8JMOh7kVe0jIlrqOV7v4WuS8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1744172089; c=relaxed/simple; bh=vqn4hMxt5xkLp6Wo5+9E3abOcLU2fuhIX+QfwNA6G5o=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=F1LYNpcvxe7BxE7XIAIUGLRQmPVrezqxWC8pGl3jkU1xPl4Oe+cp3qyryL5lEiE68kGwyECmL4JPkZ+w+53m6t42JTiLhi7bdL1nvIPUURIN1NL6PQvcX0+KuhhV7IvRy19D9vXpKBmduOep9FKeheRJpHYl+hXJ2du/f7uT3CM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C34C5386075A Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-22409077c06so77651695ad.1 for ; Tue, 08 Apr 2025 21:14:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744172088; x=1744776888; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=uW8aZ8KmRN2CSJ4jN08skNsbqGxyYFr3FJN2pMOabvc=; b=a3WCPdGKfx8rcrusT8VQp0A4NrAde4PxebM8WI54AhncSJhJHuKPibLyrJmIhH68z6 3n3ptn2hNLH0YXEvOXwHGMTSehViBY//wiPQrpb0+4qys3dK4bYqzdNOa4Fqe/pa9ZM5 vHdqUz+oi76ovuge78jnjcfUzVVliaKBrILuaiW8S6N5IikOVsNQ/OPTcZO05g8qT7PV ybaHrIgH6nrCwXtVz6yUTl035TM7TY/Y8sRqAMDi1G4f7NLTAVPGCofmGLcq2Fc5J3+V NZ8cXFIbiR7Y+1AuMfSndRIQ3fkMwvhSZJZktwAo+XYIICD/aCd9CYh0UcmdTKCEttg5 UeVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744172088; x=1744776888; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uW8aZ8KmRN2CSJ4jN08skNsbqGxyYFr3FJN2pMOabvc=; b=Typdj2Kdw4C7aE/firWxd299Fu+bomM002bCtO3q80r+UtvfXipm6sPQtGIODB+NIi k+0IPwobPgyoB3lMHihHwtVImTaxIWzSWrjjcUNYwRQtEo5vZ/5EZHgN3O8FXIWzXT98 qeUWCQCu2ocuca+UQOlQmIdbICMU0iInqwR0ZPFZFKlo1YTvozm0jueG25Y9cA3T+y/z YTih+f4RuedT3z4qugZZEQyswoAHNWFxHCVCyep/Bys+nwYnCQm7O8jNKhjZZlYztC7p 91i0LZ3EYuTG7dRmHf4XjN7WVwLfkLgpxiQsC1y9ugfDS4efHxAbp2c93UMKuYmxJ9CN hmFA== X-Gm-Message-State: AOJu0YyFNZtUz67mW/DHwSYwZsqabl4njIf0BYQgTpnK4Wcm12Y7Z5yA Fvi2UCS5fDER1T0jSyDTKVC80TaubZT4MuxbkZzhWvLkIUNDBdS8EDNwCPiZKOzR3ouFr4uRaGu P X-Gm-Gg: ASbGnctmsU16yngRHlWFCDfXgMLQsP4vsOWQKd9uY9MgayrdzvjFUOvnYqhysBHv83L 530vbz57rAToVIkpJbQTzoAoFGh/x0XmaD/IWCREv1WFwqGI8W0Ow12jY+4BEFD8K7qFQ6+F4np 74qZ4is3YPIJMmrbG1ftxiLPoITPN2/I4s90OWJ2asxcu7g1+vxqRhWAELrldZJIUENhPwi5j4L QxmERX0fZvg1uAinFzEBMs34yHtsuu9R2RQ2xSOx1+ldbmI2mnL2we1YIIuXCIiFzuSc1iraM5J f1MAXDdQ1/ZZINngeUgZtmEh7PuAM/aogNh+F5A3/WiH7Gf6+t5g+ws= X-Received: by 2002:a17:903:fae:b0:223:6254:b4ba with SMTP id d9443c01a7336-22ac2990cf8mr23238345ad.13.1744172087745; Tue, 08 Apr 2025 21:14:47 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8209:9a3e:18cb:3e7c:3e8f]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22ac7ccb32esm1622645ad.232.2025.04.08.21.14.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 21:14:47 -0700 (PDT) From: Thiago Jung Bauermann To: gdb-patches@sourceware.org Subject: [PATCH] gdb: arm: Add CPSR fields to arm-core target description Date: Wed, 9 Apr 2025 01:14:44 -0300 Message-ID: <20250409041444.106988-1-thiago.bauermann@linaro.org> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patch=linaro.org@sourceware.org PR tdep/32840 mentions that the "info registers" output for CPSR (Current Program Status Register) on 32-bit Arm isn't very helpful. Add a flags type with a couple of enums to provide better information on the bits that are set. Example output: (gdb) info reg cpsr cpsr 0x40070030 [ M=user E=little GE=7 Z ] Regression tested on native armv8l-linux-gnueabihf. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32840 --- gdb/features/arm/arm-core.c | 37 ++++++++++++++++++++++++- gdb/features/arm/arm-core.xml | 52 ++++++++++++++++++++++++++++++++++- 2 files changed, 87 insertions(+), 2 deletions(-) base-commit: faaee6b411411f3c1f45768d7ac15559fd27b980 diff --git a/gdb/features/arm/arm-core.c b/gdb/features/arm/arm-core.c index e401411fc5e7..7eb8d4de0923 100644 --- a/gdb/features/arm/arm-core.c +++ b/gdb/features/arm/arm-core.c @@ -9,6 +9,41 @@ create_feature_arm_arm_core (struct target_desc *result, long regnum) struct tdesc_feature *feature; feature = tdesc_create_feature (result, "org.gnu.gdb.arm.core"); + tdesc_type_with_fields *type_with_fields; + type_with_fields = tdesc_create_enum (feature, "pe_mode", 1); + tdesc_add_enum_value (type_with_fields, 16, "user"); + tdesc_add_enum_value (type_with_fields, 17, "FIQ"); + tdesc_add_enum_value (type_with_fields, 18, "IRQ"); + tdesc_add_enum_value (type_with_fields, 19, "supervisor"); + tdesc_add_enum_value (type_with_fields, 22, "monitor"); + tdesc_add_enum_value (type_with_fields, 23, "abort"); + tdesc_add_enum_value (type_with_fields, 26, "hyp"); + tdesc_add_enum_value (type_with_fields, 27, "undefined"); + tdesc_add_enum_value (type_with_fields, 31, "system"); + + type_with_fields = tdesc_create_enum (feature, "endianness", 1); + tdesc_add_enum_value (type_with_fields, 0, "little"); + tdesc_add_enum_value (type_with_fields, 1, "big"); + + type_with_fields = tdesc_create_flags (feature, "cpsr_flags", 4); + tdesc_type *field_type; + field_type = tdesc_named_type (feature, "pe_mode"); + tdesc_add_typed_bitfield (type_with_fields, "M", 0, 4, field_type); + tdesc_add_flag (type_with_fields, 6, "F"); + tdesc_add_flag (type_with_fields, 7, "I"); + tdesc_add_flag (type_with_fields, 8, "A"); + field_type = tdesc_named_type (feature, "endianness"); + tdesc_add_typed_bitfield (type_with_fields, "E", 9, 9, field_type); + tdesc_add_bitfield (type_with_fields, "GE", 16, 19); + tdesc_add_flag (type_with_fields, 21, "DIT"); + tdesc_add_flag (type_with_fields, 22, "PAN"); + tdesc_add_flag (type_with_fields, 23, "SSBS"); + tdesc_add_flag (type_with_fields, 27, "Q"); + tdesc_add_flag (type_with_fields, 28, "V"); + tdesc_add_flag (type_with_fields, 29, "C"); + tdesc_add_flag (type_with_fields, 30, "Z"); + tdesc_add_flag (type_with_fields, 31, "N"); + tdesc_create_reg (feature, "r0", regnum++, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "r1", regnum++, 1, NULL, 32, "uint32"); tdesc_create_reg (feature, "r2", regnum++, 1, NULL, 32, "uint32"); @@ -26,6 +61,6 @@ create_feature_arm_arm_core (struct target_desc *result, long regnum) tdesc_create_reg (feature, "lr", regnum++, 1, NULL, 32, "int"); tdesc_create_reg (feature, "pc", regnum++, 1, NULL, 32, "code_ptr"); regnum = 25; - tdesc_create_reg (feature, "cpsr", regnum++, 1, NULL, 32, "int"); + tdesc_create_reg (feature, "cpsr", regnum++, 1, NULL, 32, "cpsr_flags"); return regnum; } diff --git a/gdb/features/arm/arm-core.xml b/gdb/features/arm/arm-core.xml index 498aee1f8595..52edc66045a2 100644 --- a/gdb/features/arm/arm-core.xml +++ b/gdb/features/arm/arm-core.xml @@ -24,8 +24,58 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - +