From patchwork Wed Apr 9 00:50:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Zhang, Rui" X-Patchwork-Id: 879783 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E841132117; Wed, 9 Apr 2025 00:50:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.9 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744159833; cv=none; b=D+fGVG9JebregQlDt35e52ieKMb6QUJSEUfl/yGfTt5RgHEqO9D3AcVaFO2vq9qee1v86zuMqYiD1QY1qLuxKlS4sA8FvbloLatInVOsKdHAzfOQQBvi/z+BOnLdCOTBrKN2arjV+3pkUJp6rNiL8kT3TUZ2S9JRZtIx4eIB7Mc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744159833; c=relaxed/simple; bh=AuklLqaFsH2YuV7VhYot60oXJfik6SRvEYNcB3LgkqQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qhDg9vSJYCaQZ1YZ1w46ELrkY8zT5OFHjGKuEAYy9E4U1ocImTfehmcX6Ou6dvCxlqSvl0zf7oEiCqZItRR9+j5bC2DUAjCRRKqHCcCAXQce2/9g9Ao2/lMrCL6w4amuLkhMPXQioYa2H1F++BnJ1v/iBsVs1IYjlIIwagkb6wE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=adqebcE7; arc=none smtp.client-ip=198.175.65.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="adqebcE7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1744159833; x=1775695833; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=AuklLqaFsH2YuV7VhYot60oXJfik6SRvEYNcB3LgkqQ=; b=adqebcE7n9kdd1fBGoZDFvxaxRZWZzb8VwTM3zC2cJ0PpuNmYwj0eEOF UJy9k6qkxsUUJQeM4jatQ9vdTAtvHoRelRK91HDrivaw7oD97qnQIuDLQ Txuuwrop/bsgn3cGN21B2ciaUDAMCnupygVGT84Kxlg95dfMDOvuKFh+s IQVoaZBTEbajZvycLApt4yiBJvHn27+vcQqMeHrUTn7iABM25HAb/094d HFL5+imukQvqiEqI1QOMNmupLhPDwUip3S+ZUPVSlZ9vqMJ7z5kMgo86G ekr4mzoc2dbG7W14nMUkDOTmSj+rkYCxZ6V8BkicfSG6KM6nDgB4LFMCx Q==; X-CSE-ConnectionGUID: dJipZPcaTKycdl3yrQ05iQ== X-CSE-MsgGUID: 3uLFJ2BMRHmMIdy4XjIwpA== X-IronPort-AV: E=McAfee;i="6700,10204,11397"; a="68095410" X-IronPort-AV: E=Sophos;i="6.15,199,1739865600"; d="scan'208";a="68095410" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2025 17:50:31 -0700 X-CSE-ConnectionGUID: sVXjBq7HQGuQqaicxpprnA== X-CSE-MsgGUID: 4c1Lu6w5QdGcHXrPU24sFQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,199,1739865600"; d="scan'208";a="151611730" Received: from rzhang1-mobl7.sh.intel.com ([10.238.6.124]) by fmviesa002.fm.intel.com with ESMTP; 08 Apr 2025 17:50:29 -0700 From: Zhang Rui To: rafael.j.wysocki@intel.com Cc: ggherdovich@suse.cz, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org Subject: [PATCH 1/2] ACPI: processor: idle: Set pr->flags.power unconditionally Date: Wed, 9 Apr 2025 08:50:25 +0800 Message-ID: <20250409005026.1932637-2-rui.zhang@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250409005026.1932637-1-rui.zhang@intel.com> References: <20250409005026.1932637-1-rui.zhang@intel.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 acpi_processor_get_power_info_default() ensures that the processor's ACPI_STATE_C1 state is always valid. Consequently, the pr->flags.power should be set unconditionally after this. Remove conditional checks and directly set pr->flags.power. No functional change. Signed-off-by: Zhang Rui --- drivers/acpi/processor_idle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c index 2a076c7a825a..7264444d56b8 100644 --- a/drivers/acpi/processor_idle.c +++ b/drivers/acpi/processor_idle.c @@ -481,11 +481,11 @@ static int acpi_processor_get_cstate_info(struct acpi_processor *pr) acpi_processor_get_power_info_default(pr); pr->power.count = acpi_processor_power_verify(pr); + pr->flags.power = 1; for (i = 1; i < ACPI_PROCESSOR_MAX_POWER; i++) { if (pr->power.states[i].valid) { pr->power.count = i; - pr->flags.power = 1; } } From patchwork Wed Apr 9 00:50:26 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Zhang, Rui" X-Patchwork-Id: 879380 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E05D713A265; Wed, 9 Apr 2025 00:50:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.9 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744159835; cv=none; b=qEP5ylFp+hnxZbj2wodhFIwNO5agtQKBigp5ja6zAK9xSAYBc38Ze+CmsDWH5rptR5xcwkA/JOa4r6GoALgwnNOOobX9rXASYWeitchBCD/U8rrstaZvM+aGz1f/IlAu9tvkZ86DPfPUjMofuGl0Dgz0mmQeieh2Pkfk7yfXbtk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744159835; c=relaxed/simple; bh=bVh50W/06oFUVmTSZNyIfxGCe7IOik9ucMy2Q0xFECA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bTps1zDWdHhSMta4IWvJMpeuM67oGxdiNH/t3RmaSQBAgZ5A5j7Y4RTZ07xZQ0UQ3x6tyl2Z3MCccwk6ZFzIfTBZKw6QhAra/xy3/ue2cw6F8qdJzttcbvyuH4BR6VEoZS6Li1EwKELhzAe6YlmYuooqUojgO9OLuXLhU2pQ3Uc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=cSWSCGhf; arc=none smtp.client-ip=198.175.65.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="cSWSCGhf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1744159833; x=1775695833; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=bVh50W/06oFUVmTSZNyIfxGCe7IOik9ucMy2Q0xFECA=; b=cSWSCGhfIGWRlmSTDVrQ9l/O+7ShIKJyW8GI11+eweyzrrmdmLGblTYC Zxi2XIKDMZHqHUoSqmjgrvLdsQmkvTppmTP9hPK0/SUOXQh8F8irQIVMn gyNVi4hoY4Jzmh4oOCHMMdk5Iy+9nvj6J5UL4/Tzllcxs6j30pb0dUQPf YyXke9nkSwR1CYKUsQuFJ1Vm2x23HI0sTtBPck4Nw9NL8YMojt5AK78bf Qu7lf9CBubDzrEUpLhOm85mWFD2H/t6x6B+iFTq61yE21xNUcnSR4fbNd VVwxdTvUmX74L1dOMPqielPY/AZhvNJK1SIGrEOww/cuIngIiLax/FG2Y Q==; X-CSE-ConnectionGUID: CnkTWisQRH+1LQdZdEKwRg== X-CSE-MsgGUID: +esdBoC/TcO6Qzlr3j1+Kg== X-IronPort-AV: E=McAfee;i="6700,10204,11397"; a="68095414" X-IronPort-AV: E=Sophos;i="6.15,199,1739865600"; d="scan'208";a="68095414" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2025 17:50:33 -0700 X-CSE-ConnectionGUID: bnCG4pKPR6qkpkLQJgww7g== X-CSE-MsgGUID: 2nRf4wDmRv68LhAuqMW7hg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,199,1739865600"; d="scan'208";a="151611734" Received: from rzhang1-mobl7.sh.intel.com ([10.238.6.124]) by fmviesa002.fm.intel.com with ESMTP; 08 Apr 2025 17:50:31 -0700 From: Zhang Rui To: rafael.j.wysocki@intel.com Cc: ggherdovich@suse.cz, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org Subject: [PATCH 2/2] ACPI: processor: idle: Remove redundant pr->power.count assignment Date: Wed, 9 Apr 2025 08:50:26 +0800 Message-ID: <20250409005026.1932637-3-rui.zhang@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250409005026.1932637-1-rui.zhang@intel.com> References: <20250409005026.1932637-1-rui.zhang@intel.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 pr->power.count stands for the number of valid processor cstates. And it is correctly set with the return value of acpi_processor_power_verify(), in acpi_processor_get_cstate_info(). Remove the redundant logic that unnecessarily overrides pr->power.count value. No functional change intended. Signed-off-by: Zhang Rui --- drivers/acpi/processor_idle.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c index 7264444d56b8..623c415790b0 100644 --- a/drivers/acpi/processor_idle.c +++ b/drivers/acpi/processor_idle.c @@ -483,12 +483,6 @@ static int acpi_processor_get_cstate_info(struct acpi_processor *pr) pr->power.count = acpi_processor_power_verify(pr); pr->flags.power = 1; - for (i = 1; i < ACPI_PROCESSOR_MAX_POWER; i++) { - if (pr->power.states[i].valid) { - pr->power.count = i; - } - } - return 0; }