From patchwork Wed Apr 9 19:22:11 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 879638 Received: from mail-il1-f180.google.com (mail-il1-f180.google.com [209.85.166.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 655B91E51F5 for ; Wed, 9 Apr 2025 19:22:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744226542; cv=none; b=uwD4GsQbLb6fv43u6q1IjXZnrDDMWsHbkaoeZq6yweXDRBSaPdWVr3QMbr/kcY6PquEqVHR0ku74YcDr5XoereellpkDuhVc6MtbVYeWcCOAaP3ga+ZOoUKfg4KIToveVOyFK/NAz9hZfdjaXv1VVfnAtPRCjfcjopxc6mstJsY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744226542; c=relaxed/simple; bh=he9IA1+sEmtGpV+RfD/yvwaHIPJw7FZcA+CsPKHLNsY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mbdB5dRPf0enbUU66vKbKU4MwDKpkNMF3t9zFT22ijah+IJOgOrPxz/dtyFpx8CCdTy8ZP4f3JIRHQijeXNVLWEVxTZSm98bcqE9j8NiWBiSBG/brysOUwrCHpPKsgNaTbwNGN3s3y+qpPZgkDZLWM+ZR9usOW7h1c9rUjYPUpo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=lut8q8Ni; arc=none smtp.client-ip=209.85.166.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="lut8q8Ni" Received: by mail-il1-f180.google.com with SMTP id e9e14a558f8ab-3d589ed2b47so333115ab.2 for ; Wed, 09 Apr 2025 12:22:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1744226539; x=1744831339; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bAZLFz1IGr5iGWJpnMiF/uKgFNwzC6PY6kuRk72SglQ=; b=lut8q8Ni1hbyZx9cevMEU3YqMOUhsQhPKqmJAgDc6cYYex6kdQ/QLfIU60sQNgD7g8 JimgNl640PCTK+FpDRplBPvlvuKDdRe6DUfPxjQSM+hsymxq8POEfX7A2Jf0n5YkrxKn f2ybj/ajrmfvuGMqT49IAmXdrgFnKaf59WioJQUSS8Ps2mHdslboQOxOGOsLfx2ib2G4 GVt2GgaIfyRLLfRPSkfyytr0BVe2WYI104UkkYW8TaVcTvJ2koBiG1++5uepyrKQeNvB 7o9kqfqEWR5pfcB7Qu+7/dlXSkLuGLwauXtrcZ6AVTn3XRwcK6hI3E7fnIAQSLvRMEWC pKFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744226539; x=1744831339; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bAZLFz1IGr5iGWJpnMiF/uKgFNwzC6PY6kuRk72SglQ=; b=jDID5oam9+Ec2c+IsWJvp0slFzPf/e2J3b1F32ET37L7HC4NjN28ZjI1fqdlFfSQMZ 2bjq7bWyG1QJHbn8pOrIwSkXshPqlywEbrHW5vd23eZedHgW6pB3tUgd1K2zMhDEeLw6 NT52dsQelpbsAGNzJfXFhaU8GQv0LVBhtjE9RgRjGJYd5EoCD3Py2WzAk+jM/n7HpaHx PXfF1lDOiTDWu/oAMQYs0JTcNI3VfJMlTLrYgtKkPHhglLm47DFVz9Wx1MCdho5zxZ6+ QPKDgwy0p6r5mTK/ROlG2fIbgIktS0G4xvcQ0slgB4TsxXGJuP7GeakewAI4m5ainoXE 2N/w== X-Forwarded-Encrypted: i=1; AJvYcCVMA2GE+5HQBSGOaVuHkoAVpOSIaKex/OrUsQHpZXZocMfOWC6O3VroRtRyOMHe1CN/v75u72VE2EDau78=@vger.kernel.org X-Gm-Message-State: AOJu0Ywhk1v8wWHywg4M8AFmJ4IYeJzDJEsnxExNqNrNUp6KJFmM/Jgn 2TLVa4lhtPINQrLsJkczoLcafz2kPBkVbPuLO28rnn55em4HDVzpa/LmbFsb7Gw= X-Gm-Gg: ASbGncss/01usnlRwSYLRnJWZ0wHjXJXScQse6LjXhwqMSDIcLFtApCUnGm0G9ibjRP S3M3x2LvFiwZsGqMSSMHvm7OlQvPRGwcEDqC2/zLGvwrGVBlXnz9v7duKPRQ46C4exmAiTBHJtM +avu+r9eWRAwomexHLMAfhYxQ4ATzaj4zI66BPb0RU+Qqhhj/3VqfrfVIH4Qb8JIJnuwj+5pVET aSFht1ZifgA2itIGgwi8PLMyEqyydacdg+qKy1kgndT4RJkCTFsltOdrPpHneqm6cFNR6rv/tKP 8AguIi4aTYxBnKlUFI07KP3TgBASxXraRH7xv8mDe4BviUwutOPd1a0YiUbIEAPxvVO1isgJwhi +wCyMtCB+uAwi5Q== X-Google-Smtp-Source: AGHT+IEGuxmewmQbb75m5X7vBqHuIXERuCuTlAE6AMgAdiu3tfh0rm83MqrIv2yAApon5oQTbElRjA== X-Received: by 2002:a05:6e02:1446:b0:3d0:4b3d:75ba with SMTP id e9e14a558f8ab-3d7e46e082cmr3195055ab.4.1744226539359; Wed, 09 Apr 2025 12:22:19 -0700 (PDT) Received: from localhost.localdomain (c-73-228-159-35.hsd1.mn.comcast.net. [73.228.159.35]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4f505cf81bcsm373459173.10.2025.04.09.12.22.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 12:22:19 -0700 (PDT) From: Alex Elder To: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, gregkh@linuxfoundation.org, jirislaby@kernel.org Cc: dlan@gentoo.org, benjamin.larsson@genexis.eu, bastien.curutchet@bootlin.com, andriy.shevchenko@linux.intel.com, u.kleine-koenig@baylibre.com, lkundrak@v3.sk, devicetree@vger.kernel.org, linux-serial@vger.kernel.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/2] dt-bindings: serial: 8250: support an optional second clock Date: Wed, 9 Apr 2025 14:22:11 -0500 Message-ID: <20250409192213.1130181-2-elder@riscstar.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250409192213.1130181-1-elder@riscstar.com> References: <20250409192213.1130181-1-elder@riscstar.com> Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The SpacemiT UART driver requires a bus clock to be enabled in addition to the primary function clock. Add the option to specify two clocks for an 8250-compatible UART, named "core" and "bus". If both are needed, require them to be named. Signed-off-by: Alex Elder Reviewed-by: Rob Herring (Arm) --- v2: Require both clocks to be specified with names for SpacemiT .../devicetree/bindings/serial/8250.yaml | 30 ++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/serial/8250.yaml b/Documentation/devicetree/bindings/serial/8250.yaml index dc0d52920575f..33d2016b65090 100644 --- a/Documentation/devicetree/bindings/serial/8250.yaml +++ b/Documentation/devicetree/bindings/serial/8250.yaml @@ -135,7 +135,16 @@ properties: clock-frequency: true clocks: - maxItems: 1 + minItems: 1 + items: + - description: The core function clock + - description: An optional bus clock + + clock-names: + minItems: 1 + items: + - const: core + - const: bus resets: maxItems: 1 @@ -224,6 +233,25 @@ required: - reg - interrupts +if: + properties: + compatible: + contains: + const: spacemit,k1-uart +then: + required: [clock-names] + properties: + clocks: + minItems: 2 + clock-names: + minItems: 2 +else: + properties: + clocks: + maxItems: 1 + clock-names: + maxItems: 1 + unevaluatedProperties: false examples: From patchwork Wed Apr 9 19:22:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 880092 Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99CDA1E51FE for ; Wed, 9 Apr 2025 19:22:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744226544; cv=none; b=NqqmAiH0hs+Swsw3E8+IQt1BcbWxnr5v1f8WhR9f031C/Q0pFuSizCwfV7vaDK+EWHFe9li63wmuGxK7bjNSvyaaY+gEsTlfL1r43JlpvG7+RI5SLwlyr2m5vwJYaPGjRv6GP+4aI8Zzg5g1N0Is/oBWKeYjdb/wQILP0xGRQuA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744226544; c=relaxed/simple; bh=Y2ilGHMUTXCya8rzOvmKtYifGjbu9RYpGCgzY3UBtUU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AV/NSZvWDWjz14b4f3gho0NHWNPF77QZQTvkjQzp0A8ZyQ7apD2E94hav0r4GKayCt+pRa2itjL65FrtqS0awHmXZKgcGNq3I30SoclXbawTtJX2i1ndK3TB0bJ1nqgddZeOUOJfR1oBFHqOgBjJ+PIM0oY4gj0zEnITey6FamQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=OOh8qPm+; arc=none smtp.client-ip=209.85.166.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="OOh8qPm+" Received: by mail-io1-f52.google.com with SMTP id ca18e2360f4ac-86135aeca58so3195339f.0 for ; Wed, 09 Apr 2025 12:22:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1744226541; x=1744831341; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HNl26J3HRC4XsI0NsNHSQT2PLx01D+6pAV6deX3HHJI=; b=OOh8qPm+gkBB5ONASPmYgWUk7rIRRWcuu7szi2KIo7zL1XpyN3WXyaZzUcvPcZPU75 /W0VEEfCaPUyFuEkD/41Z8vxA9Thh5yRhqeoC/lxCojgRMWptqrfJv4iiYVh53pcg1FC +hEXY8p/ji6Lrp0pH2V/4j5kxiCYwGXrATfIOVTw2MSNVPK4plgAvGB/9mUv35rqbcHJ 4DkG5gxM9xNm5mFQApzf0Ayra1feJPARhYCVKuZr7tflKgXiZB4Qo3tldGOtf6o+vOWY EURl2c1IrTyS8iP4cU4eMqx3MJ2G8z+2WouZTLn+DInbQgaG6xd4u+1DuK4+9vPKsQZS PwCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744226541; x=1744831341; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HNl26J3HRC4XsI0NsNHSQT2PLx01D+6pAV6deX3HHJI=; b=DrNYdc1j6TVIiJMh/Oonup4sOj7AqENsjNuyddz92468Wory1tolfk6stoUHw+nxwe eB3pFd5HVTnKmaXMqGhxB223XWw6zLsrBeBCMq3JC3nOKQlkTUY90RgVQcA1cuKGz4N8 V3IdS9keZtvPaOwK+0wb1Bv0oiE/9q2G12+5n3EDxiAV0Wedglv73VSQ6sqvG7kVaLvb mIuFumQzBmta27Lg3q4k7Xz+EYmRt3aHcKbPab97lYoiXoiw1BCYxpPFhSnzjy6zR0Bc pIMdOJZCzEb25Rv/65PnyOQdPoQzckQkZspfyMp45lBWg36Dp5UiuuvtVVs8fpHmGosr wdLg== X-Forwarded-Encrypted: i=1; AJvYcCUvtNaWUkKKOVLhc1iX5FlEjI/Ho4d3NRpF+NEQTmM8pzeTMJVednFEvb23SV3HBbpV/Hp0vENAtBlgzQY=@vger.kernel.org X-Gm-Message-State: AOJu0Yxy2ZGpC84bWoMw08TSmJA/26Blu1+5Rcwcax67PBvI03/v19T7 UprhSNcueGx6wfs80vD7ot4FChjz1dXcYJDVh1rL2WOy3hwIQ//9jhScAbSLCYA= X-Gm-Gg: ASbGncsR1PIA8+nwXNx8Mntnj6/ycF9qjbTtEB/u8zCBBjDmxqHMHiKcZ/eok6TI2KL +w3zpzdi/Vii0wpvf1F8cxkrehVAxzZKlPafHK6j7K7NHNFabkvvatTfjwhz2yTzxJrX+GawKiL ODCoNYUhX5zxDOiiXNQptuJ3OZtRFpz9wIbImSEL70+091EJLfLX9BpxPEKOO113hMaQNHDv8YF jyMzTIQRIu3CUU4NGOP80Ups5/0l1B7ND7CHhb13h2Ahp/USb2dis/7iZyY/BU0URP/X+HgUFRg J8P23/o/kqVm+8NYfdwG8kz78zJCFxtIM2Yc/zDD5d1qNJ7u4UVP8weVmL5g3UbuDyrq7KlyHhM Ybqlze1sOFfvyhupcSTrY4Yky X-Google-Smtp-Source: AGHT+IHad8+4ZGmSEydVvWi93B5NhjlEAMlDrR2UwaWJMa/MsGHo4UvOCZSyheMgn+3uP3r9HQq5+Q== X-Received: by 2002:a05:6602:7210:b0:85b:4319:2a2a with SMTP id ca18e2360f4ac-8616ed25080mr12867839f.6.1744226540652; Wed, 09 Apr 2025 12:22:20 -0700 (PDT) Received: from localhost.localdomain (c-73-228-159-35.hsd1.mn.comcast.net. [73.228.159.35]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4f505cf81bcsm373459173.10.2025.04.09.12.22.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 12:22:20 -0700 (PDT) From: Alex Elder To: gregkh@linuxfoundation.org, jirislaby@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: dlan@gentoo.org, benjamin.larsson@genexis.eu, bastien.curutchet@bootlin.com, andriy.shevchenko@linux.intel.com, u.kleine-koenig@baylibre.com, lkundrak@v3.sk, devicetree@vger.kernel.org, linux-serial@vger.kernel.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/2] serial: 8250_of: add support for an optional bus clock Date: Wed, 9 Apr 2025 14:22:12 -0500 Message-ID: <20250409192213.1130181-3-elder@riscstar.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250409192213.1130181-1-elder@riscstar.com> References: <20250409192213.1130181-1-elder@riscstar.com> Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The SpacemiT UART requires a bus clock to be enabled, in addition to it's "normal" core clock. Look up the optional bus clock by name, and if that's found, look up the core clock using the name "core". Supplying a bus clock is optional. If no bus clock is needed, the the first/only clock is used for the core clock. Signed-off-by: Alex Elder --- v2: Update logic to more check for the optional bus clock first drivers/tty/serial/8250/8250_of.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/8250/8250_of.c b/drivers/tty/serial/8250/8250_of.c index 11c860ea80f60..a90a5462aa72a 100644 --- a/drivers/tty/serial/8250/8250_of.c +++ b/drivers/tty/serial/8250/8250_of.c @@ -123,7 +123,16 @@ static int of_platform_serial_setup(struct platform_device *ofdev, /* Get clk rate through clk driver if present */ if (!port->uartclk) { - info->clk = devm_clk_get_enabled(dev, NULL); + struct clk *bus_clk; + + bus_clk = devm_clk_get_optional_enabled(dev, "bus"); + if (IS_ERR(bus_clk)) { + ret = dev_err_probe(dev, PTR_ERR(bus_clk), "failed to get bus clock\n"); + goto err_pmruntime; + } + + /* If the bus clock is required, core clock must be named */ + info->clk = devm_clk_get_enabled(dev, bus_clk ? "core" : NULL); if (IS_ERR(info->clk)) { ret = dev_err_probe(dev, PTR_ERR(info->clk), "failed to get clock\n"); goto err_pmruntime;