From patchwork Thu Apr 10 09:34:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 880246 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35EF8266B5B for ; Thu, 10 Apr 2025 09:35:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744277707; cv=none; b=rBeOCzOHw3AoVd/ms/lF/Y5/ARxby52yPL3rGFoORh6DcOwS1LAQJNCP3e2DPwWgV6GPCVwiPl/WheYCyRGFsFm9KwBCSwoYN9RhfSV5r5y9xEpUlKK+KUqMbCg3WqlF/aEwaQP4EwuuCcs/bR7IVjCWLjfO2SAyeTTyV59rXdE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744277707; c=relaxed/simple; bh=DZ/xb93rJ3XNbgASkJ7xfZpeXZhU7bMWq3R9qJtV1u0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TFcCX9FaIEvpHEPRiJEjviPcIt6hVIewhiN4YwRIR6k1epsOcPaH+yCyUqvrlGeA1hRJCMI+8p7JNdSmraTiKIQt9+GM8p7+h37Sc4S0nSX7YHBSztKyCa0Uou6d+B7W5MID7P4R9OWKfDSmRQux94trnIaZliCZfFjMRlHo4P0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=d8TeUlbU; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="d8TeUlbU" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-3913d129c1aso425126f8f.0 for ; Thu, 10 Apr 2025 02:35:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744277702; x=1744882502; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=vKc4ni2bYp396pJgjc+ApP+2GPXywPdKnppMH0GYZOE=; b=d8TeUlbULOYZG0iOzWv4jpBu6k+lOYUtC16FIxGD5KjE3IPxI9UbathgToemTK1U4A BwXIV6ANYgRKXackzZkB3YUoPhcH3BiCXAyGYiL70hhXtoWYjVsurh7IdqG7PhK1WhZE vLG3fqlseXjn5ZROSavFBbDwE8qCSwOT9SS8ZP8Jxn6zJBO4IbzIEFY1VvyTlkEWbIfM yl1hAA6Xyx6fvf1UHy7A944H+HOzlZ8h8pnB5gFRugdlIeV8ZGdCYUr6l9G2d9X/OJoh 5QKomVNdFGFGY9fN/ndkr3y8uNuDqWwxAe7HyJ1/zZh0t0VGYk/RcyFSGf5i+cMlq0UF xnQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744277702; x=1744882502; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vKc4ni2bYp396pJgjc+ApP+2GPXywPdKnppMH0GYZOE=; b=twtAs3GNFFVkbzBO3umzHYjzvoHWpDb6QbD0RNBo7W7Gx5KRSKcNlQj8wqC+4wqZmO /wjOpAnj055C23NdFvcpqT7NGrAI1d4PAQuNj0zQxpZrPth3daQOzU6jAUdOy+CnSf7q uXSZYs1KzF04qlHNDI+iQ3GVvXscGXqjtrwwCJYfKOWm9kR1v+SpPe4HI588+OIuHn/y +EO6XBkZL3e8T9WYXjSvkzLlo5RhAd8xtjh65LE562GIxV8tSL+8aviUicOIB76E+vC8 /5XZzVYdOq1F13qy8S/iKsRAdT5CKloz0k4A3LH9ubYVZrrPnA12NKbLYl6NgYi7tQ2I q7JA== X-Gm-Message-State: AOJu0YxQtRlddjYkMAxB7AomEXiD+nhWIZlIy7UkIgn43OrbTenaOO16 bBvmxs7U1Yn/1nz8LXb75ek1HPoDzrKuXVc64CD6FVB2hfRqw5kHFlcle6kbxS46eC6ALn90g16 xDMM= X-Gm-Gg: ASbGncvwnbkHTeglITnJvrJ32pYOvGmBopL1DtHBAFjPKjVAsjfrWcfk48MfNRyDQ6t Ga9atghLOz6JtNcvbCPizupyac7x0gDwXcoXvypva61d5YH2kJxSVtsezE7O26YkLil+NpN6Y9o KbqaiuJ2apYs9pSZo9FmXT5uRQpZXVPhIC8zVb4etn8K8UdxjHj8ToCZLETK0Ozx+s1T0qxSSQb I9Zbdq+oqZ+dk1BlUBzbhyicbTRjdVGG3qjMY4ifkUpfwjn5zowEwaog4y/02lziOFfUbKl8ncw GT7fOVZlkJ/M/kfn4d5u3wdV31Zavs9HhA== X-Google-Smtp-Source: AGHT+IF9CCOYu0sZ4EtoBET0PxviFQ0BAKr/anVSOO4WNE5lPQ4fauspuBSv5FegePef7LtmJ26IhA== X-Received: by 2002:a05:6000:1acb:b0:39c:12ce:1112 with SMTP id ffacd0b85a97d-39d8f4c9638mr1721576f8f.21.1744277702477; Thu, 10 Apr 2025 02:35:02 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:7c4f:f9d1:94e0:53f8]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f206264a1sm49698435e9.9.2025.04.10.02.35.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Apr 2025 02:35:01 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 10 Apr 2025 11:34:43 +0200 Subject: [PATCH 1/6] pinctrl: qcom: lpass-lpi: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250410-gpiochip-set-rv-pinctrl-qcom-v1-1-6a6891338aae@linaro.org> References: <20250410-gpiochip-set-rv-pinctrl-qcom-v1-0-6a6891338aae@linaro.org> In-Reply-To: <20250410-gpiochip-set-rv-pinctrl-qcom-v1-0-6a6891338aae@linaro.org> To: Bjorn Andersson , Linus Walleij , Bartosz Golaszewski Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1522; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=8O4bilVXxN82WosLGq1PiA2eweBBlC7Bp7cOdXvJsAE=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn95DDStxdfGuVBR3XOsSKVkN/z/7yJgXF4ro6N rUvBcL81jqJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/eQwwAKCRARpy6gFHHX cpQWD/4884nUwImCE01ziWTugyxvx/Vel3SSsEo6GAKVf87PvRQRixhIciKdlPSk709Pm06Ue2R E2ochgWHNoV7YW3VWQJ0hgv3zrRfKGEcVZ37X/xeknxR/K2lB14J1bRunyB331PR5P0djPtadT7 Wb2MTOdSYuFSUtMLJnHEXNRvtKEcrFjLi6B/zuNR2wH0pg3d3t2mpz/vTaS5jOAX0bDbI934NeS 6KnhGwGiE0PUFjyN5O5nRpClZI5kQMMRrZxNRX/OTxwctPMrDDT+EZt6Fqv2inHVpR4QXfokDKL MS2ns96W1qJ2uByniuqRFyQekqckQxA3nxEa4nFRdh58jmIP4va5ZBhtyISewo0kbBDCyKQ3ELV jsOvDx+UbRA8kVGTxuK/iKAveJ45RcDUAv+l/Yv/BdFeIob4Nx9XbmvoKIXPFIZO4vLQromhvRU UFpR1p/AQSGwgiLtpY5rXobnwRi5FwunR/Qn06NE0em83JNQyS28DomKMEw+YdcnvoWImzcidt7 0PHyxr/4ZaU5LlJ2zxyFau7N5o1gy4/REdwz4G6ivNgpmh4pKokNm0gREPsy0eTey2UmJu+fH4g F2JDIOPZC5+eyjVoJHPRhcEdP9hllwUNcsBFjwKsMzbXikINeZMqvtzqMOTeYNJ1gc1dRY2vhgW ReVgBFqFT1kNL0A== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/qcom/pinctrl-lpass-lpi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c index 7366aba5a199..57fefeb603f0 100644 --- a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c +++ b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c @@ -327,14 +327,14 @@ static int lpi_gpio_get(struct gpio_chip *chip, unsigned int pin) LPI_GPIO_VALUE_IN_MASK; } -static void lpi_gpio_set(struct gpio_chip *chip, unsigned int pin, int value) +static int lpi_gpio_set(struct gpio_chip *chip, unsigned int pin, int value) { struct lpi_pinctrl *state = gpiochip_get_data(chip); unsigned long config; config = pinconf_to_config_packed(PIN_CONFIG_OUTPUT, value); - lpi_config_set(state->ctrl, pin, &config, 1); + return lpi_config_set(state->ctrl, pin, &config, 1); } #ifdef CONFIG_DEBUG_FS @@ -398,7 +398,7 @@ static const struct gpio_chip lpi_gpio_template = { .direction_input = lpi_gpio_direction_input, .direction_output = lpi_gpio_direction_output, .get = lpi_gpio_get, - .set = lpi_gpio_set, + .set_rv = lpi_gpio_set, .request = gpiochip_generic_request, .free = gpiochip_generic_free, .dbg_show = lpi_gpio_dbg_show, From patchwork Thu Apr 10 09:34:44 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 880245 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4593F2686AB for ; Thu, 10 Apr 2025 09:35:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744277708; cv=none; b=ETpA7lGnLGE2SRUVRS83YtWM/SL5TzkRPCziZqAyiZdMUKfSYtGdGytRVo+pd13yEKWQqNCrVsGkY8WAonrTPdOaxsChPX9HUKPL93TmZdtT1QJZB1wfTCp+kwLTcPKznUwtDoyTbshkkLV1kk1VKRLcYRdEkMFCDBOx0rcWDCs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744277708; c=relaxed/simple; bh=DoFdNFWoCcdwBqgFx7axqjS23MMKsUrQ/U/HOonOanY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gKOr5uMmyJ+JZqcZm2MIAryyJ18R/eyMGT4I8RZumQknJmbg8D9g1gFY/6V2+iPDkdLtpEzJ/GKgFZN6qZ336DEa3uA0U4stEe0jeTyrDzH+bzRXibfCWv4SgkYyz+P9sgGzovo9vqbP1esHxNuha6ySs4h3Q4kBub4qwLVT2pM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=Zaa6PS6d; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="Zaa6PS6d" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-43cf0d787eeso6877645e9.3 for ; Thu, 10 Apr 2025 02:35:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744277703; x=1744882503; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=c8Y49U7vyylV9HBlgThwXQyGyZVwK1RahyBl6+GUslY=; b=Zaa6PS6dNq8J8uH6qJYt4wIAT6ofYXV7gX/A1Yc20ga7kfOqRsALlQGRi49/1idFnF hILVamUUo7JkFwlkeiPlgpvGE00nSlRzX+05XzvYTP9G+TxRNmMKQ0nEeNvALBSI3IhZ 4l8p5uXcV37p8C67gadzYQFIvYEbLawMxfmwx00+p8EC6KHk3+sO4RPDFeiEeu8s170E 3HfEhGKjlYFYeqAue6iw7jaRNROWFUfPfAMn4CcuqNIDzxM74hzia/U+JLv1qk4SlWYX 3PaQj1prWSBHrj/JWyo/zkKODnN8Lq2LlXrCr0+oEN6NstQSpSnD8JDNpU3JwSEB54V9 WIiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744277703; x=1744882503; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c8Y49U7vyylV9HBlgThwXQyGyZVwK1RahyBl6+GUslY=; b=UvJchsX1YAsiC2WziIdDS3k0myXQOwGvQxrhd1/AYGNICQ2r896EDVW92UyhcUisWV Xb0Pajc0ZCQJa8zGnjkYH4LoZx8aeNjtDxa7LPLZwUqKL6E76Mso3bY5CWolHHg/ZVg3 nLwXUxW1OnwtioQqokSSjQnqRSGQuxvbugRylN0/7u3wxuaTwajRpQ36xMmCE7VQNxvu RFDWZX+HcpUXEPS67ufIRuPddUnWhC1EnCM8B2k4zlCmUH3ok+BoU/RqpEq8DelruWPV 7f39kmoO6rwRSGSMxz234/t4iFjeENyrOgsUF/u9Hx9L0uOiDX/15gF8rqo9GoNuyWHx dN6A== X-Gm-Message-State: AOJu0Yw+6A/ilH0jH78OGaLI82Srpol273Ce6dXekf5SFhQ3fm5jf7KT swOdDDQ3LYbU360f+l6bUVxbbK/xP+09erxiCCv6Xt2gV91/ET4iqqjarcATBBIKEF9AX69f/uE 7N4g= X-Gm-Gg: ASbGnctKugZ6eyBvS5gJhcZpF6EF84CnX07Y7JTEaUVtat7TIeVh7VzmS5FbYjiJ91l rn7TPNT9AhrCr3a6P9+m63K7BbQ2L6ddy3fwh1NMyjyf6k6ZDjzIVAiZJUrvAzasOVKCxaP7+Rf MjIvszKFhg192jrdtYvGEzrvv+17GVlMG8E/IhoiZLBtRSEVDDnMMYXtDYtk5uxi4bcVjsBEl5j wP2pg2qmOdpJvUkYZ12YNn0qoXBv/dbzkIzYV3SSQ6400N//wsxcW7gsQ0mT5JDiuLrMwUpww+f YdKklZH7GWCMqyoYWmrKkYabSAeTGJSItw== X-Google-Smtp-Source: AGHT+IFO/7yb5gwVk+EjcAiXS674jHL4dkOWAIJi2cH5g/WNiQpu8cbZDAfyXKFMDWcxeA32KO35qg== X-Received: by 2002:a05:600c:a05:b0:439:643a:c8d5 with SMTP id 5b1f17b1804b1-43f2fd29c65mr18806345e9.0.1744277703398; Thu, 10 Apr 2025 02:35:03 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:7c4f:f9d1:94e0:53f8]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f206264a1sm49698435e9.9.2025.04.10.02.35.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Apr 2025 02:35:02 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 10 Apr 2025 11:34:44 +0200 Subject: [PATCH 2/6] pinctrl: qcom: msm: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250410-gpiochip-set-rv-pinctrl-qcom-v1-2-6a6891338aae@linaro.org> References: <20250410-gpiochip-set-rv-pinctrl-qcom-v1-0-6a6891338aae@linaro.org> In-Reply-To: <20250410-gpiochip-set-rv-pinctrl-qcom-v1-0-6a6891338aae@linaro.org> To: Bjorn Andersson , Linus Walleij , Bartosz Golaszewski Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1588; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=usX00XKi8pnUCUTjAeiAi0APuP7ga/Kkn40N9cscMzg=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn95DDa/89BnXHtA4+4Ni8Mh9nKIEx8RLUu6TiL 7c/JWsquH+JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/eQwwAKCRARpy6gFHHX csL2D/9v1+J7NExhtOLP7S+W7lAyKvwFupRyUslizgwMatXixYiYi+QieSXSPPKQPM4VTj1KIWN n0FBazRjFNa3MaBdENT984m9UNUnwFOhviyywDuswR1ZU9fE/qZG73efOY2xo2gc9Ddb/kzDdHd 9Y0W2naMHv+Mw7/A77hWpAHVpNq3DzKfqGiZXHZxCWrU0bISk2Yov9g9IlHzpIGHhglJKT9ujAn uDnf0lhqQhtHIFvojPpLEwzKQ0KztXkUu6+EuL3bThCO7oy01OeGDO5XnwiKm52aHPYqki3+Gy0 P4I7OyFoVEgx4cW0RtMHLezTk0WekAwzt/xLjkhKeG3b74ceX11Cloa5fJofuwkA4ylLgBqwrv1 59QxWmyWLxGR5ctwp3mdTdjpz0EJn9wWGQAdzhG5jM2iV9bPosMsKZm0u0TOUzJ9+6KnTf7GEBk NTJ6tMYgmFIEmF060FKrEsnjnt17Dc44lVjY2BHZqo4WHcTKycJzZrlh1M2QoD+Tu5zQ+BpAeV8 uTsy7DQ3Zx7tbNX3DG6pW4NvOuxLS3l9pddMEgJI+p/zCsUXeQgSmgDNoom09iBJ7bvF7OUUO6H Cs6ZlNM1tb5SvmhkROfMQAkSPC7k0MmRkKbAqhaKMFxf2QP1kuZRNsL6pjELKXiQDbzjNUVFfvZ 0relZsbl8+PJkAw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/qcom/pinctrl-msm.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c index 82f0cc43bbf4..9ec15ae4a104 100644 --- a/drivers/pinctrl/qcom/pinctrl-msm.c +++ b/drivers/pinctrl/qcom/pinctrl-msm.c @@ -637,7 +637,7 @@ static int msm_gpio_get(struct gpio_chip *chip, unsigned offset) return !!(val & BIT(g->in_bit)); } -static void msm_gpio_set(struct gpio_chip *chip, unsigned offset, int value) +static int msm_gpio_set(struct gpio_chip *chip, unsigned int offset, int value) { const struct msm_pingroup *g; struct msm_pinctrl *pctrl = gpiochip_get_data(chip); @@ -656,6 +656,8 @@ static void msm_gpio_set(struct gpio_chip *chip, unsigned offset, int value) msm_writel_io(val, pctrl, g); raw_spin_unlock_irqrestore(&pctrl->lock, flags); + + return 0; } #ifdef CONFIG_DEBUG_FS @@ -792,7 +794,7 @@ static const struct gpio_chip msm_gpio_template = { .direction_output = msm_gpio_direction_output, .get_direction = msm_gpio_get_direction, .get = msm_gpio_get, - .set = msm_gpio_set, + .set_rv = msm_gpio_set, .request = gpiochip_generic_request, .free = gpiochip_generic_free, .dbg_show = msm_gpio_dbg_show, From patchwork Thu Apr 10 09:34:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 880244 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F8E826A0EB for ; Thu, 10 Apr 2025 09:35:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744277710; cv=none; b=lXHE9mGmR4ZcGAUjFvnpWnLkTtcxGekEBSeG23rZ337ySFyEte/pj3xK4DfTnk7zX9vxusOtPd2Dae9YpR8uWX/twdZNtxbbXa6X2JtSLU4emzIe6TtSurTpuh7xY6sBDhvEDdU/T6etf2dSkvlCZ95CuTkS6s0DqFOpD8It1wI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744277710; c=relaxed/simple; bh=CBNSk3yrCFCOlbMgCfYWRT8QGkYmxOkTlZAWAhHftYU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=E/5EJs/iiH5MmsgHOORGVjdzdoZj/eFgNcyT1LOL966evDitSg/DFn4vodtD4GP1FS1uz08R0or1g34rYy81axL8/IvAE9BU4FccdtcMCWNyHRE4/5IrIf0OSgLTw1Blquz18YVq7re7eIFhCV4Dj6d7cU49PzpbHC1pSHHwBtE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=0cs86pYG; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="0cs86pYG" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-43d0359b1fcso3869145e9.0 for ; Thu, 10 Apr 2025 02:35:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744277706; x=1744882506; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9gEo2m/viZuy0Hum07/62VQBUfloVHDkw2x/xR0+XyA=; b=0cs86pYGm70abco9fjhM56Qmym0LhpLkpUrxLBo0/CFg8TLRyz3qmKXaW0FjHK6XuX nIElyWL4LjpT8RKtNo9LEkamYipdLZTg/xNwSjOALmuNb6YOn92is+IhkdO3zomOeTOk lZkT6Tidf5NKh7NZFqz+QL1CtaBEsoD5kzcZvADFYEtD0Mk57dHw8UC50RObtE8CadsC jV83lIgOzaC1f2+zL723m1zwLv9QKs7RNfS8CUu0ME2ejzue5Zx22jK734ypgRyeYESf 91rgJardeEFqDH1qyauFKubcem07r3kpli/FPiSA54LX6YUnQwTAcviKkt8OHeG9vuRx uMGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744277706; x=1744882506; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9gEo2m/viZuy0Hum07/62VQBUfloVHDkw2x/xR0+XyA=; b=nNM66SN8jDYmxaIiB3MK6y1ma+AQ0KJ5EVVDhjdzGoY3OVfvN7LTspdowWBZZ+Veo6 rshMtxMrO29qb0T8dZCPQzPmZmlaaF8GIwWioNfrj/L87aMSMaUOwSlBAG+xH4fhNcwN mDysu9dxARLAZ6vAl/rnLSEMB9RpXtxy7ufwBo5PaDfI3xBwg7/FGgaUXpXkRomfZNbr TYuPojrBvA0yy5HIGnoyrpaz3TsSugTtcieVUY4fSSKCrHgh5zVIzYtofAWdhtA2Ry6B paEDUJxLJjSgrgspteMX/Yjr/mc/I7MFUyqlmFvKGReyWqlxe8WSbIuh3DKPPTeosjCu CIvg== X-Gm-Message-State: AOJu0YwxdfHDjr1C6I6S7wm3GQcU7ZqzstQikxbubGe4AvlENGGwStvC 2HZ0WGmB7DPVF0HcyA1wPiM74UNPl2u+7awRJdsBevTM5sgKEFd/TUyJvPjKYRUOj7HOxjc1BxQ eTRc= X-Gm-Gg: ASbGncsJO835XFqrYjj5NX5PSbotoC3un42x+eMOwgD0twweZ8s9mg79/HMMyOWGPU7 +XciIEdwdR7udZNjyNykrzp4EPjnTTzEXRFoF6f3XqEAFVuh6TptTkwAmNXbqhGRrsce5vFXSmy gwnu40ih0QsDUKQvUgRXsGgLRKHJtlg+42D+HmSCuctMcBHZEboudlpNbbo5PgB4QWP3ccRDhim dkoVO/Ff7h0TrDb2mL9uHj3elVn2wu2FP5palj2oRAwssbZ6wiXzuUqwpbHjr+cYch72u+RwViq 0IwLwVpB6bMkxe61Fb54qM51Th53rhYwpw== X-Google-Smtp-Source: AGHT+IGQMtxSsq5/DE95xt49hSnwg6XZGyLcP+OE0baBUHtuUXr/MHr9x/DHvH7LZH95Mxedo/aa/w== X-Received: by 2002:a05:600c:3c84:b0:439:91c7:895a with SMTP id 5b1f17b1804b1-43f2ea651bcmr18434155e9.7.1744277705965; Thu, 10 Apr 2025 02:35:05 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:7c4f:f9d1:94e0:53f8]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f206264a1sm49698435e9.9.2025.04.10.02.35.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Apr 2025 02:35:05 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 10 Apr 2025 11:34:47 +0200 Subject: [PATCH 5/6] pinctrl: qcom: ssbi-gpio: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250410-gpiochip-set-rv-pinctrl-qcom-v1-5-6a6891338aae@linaro.org> References: <20250410-gpiochip-set-rv-pinctrl-qcom-v1-0-6a6891338aae@linaro.org> In-Reply-To: <20250410-gpiochip-set-rv-pinctrl-qcom-v1-0-6a6891338aae@linaro.org> To: Bjorn Andersson , Linus Walleij , Bartosz Golaszewski Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1682; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=xuF564c737gHGSAxOu3BnJZRQm091DpG8CWSw+xr7mk=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn95DEb1OYPZ+ZieVXFnz0F0FKQSWFLy4/qEKp3 g9UkQaGDgeJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/eQxAAKCRARpy6gFHHX cpUREADdsULQgfyLf1FD3y7lCUngOFoOXSIwIrnRGGnV6dhK2OgKaj39Tls94XN8rhXJmaB5sEN rzMQlgx6LPSQmtDp3ommBKAl6XXJmVpcoV+IbFwGUfl22YKcbbYMoPV6DscGqmrjKaW319adR5c oITO9oitlqJKv/8mcI1DYGLzU6BeDnerRTsXk/KeggzCt8PHTfe2u06NBU652qYoH9gl50FOehT bP1RiE6bSPO7cyTx7fuuvlLVkOuRF+Bbou+htvyVRuDsaLKpRXTBosXDte3QcUEFeR58J4NdaMV KhIPuDKTV8Al9aDT1BIlBPkn3G3xXKMJXsACgD7Mc0jROrFdGghF2TLUxBvuJEGnGCjwmBnWrDP mZxKw5fQTPfiq0EvVd+5O6IyGGhL+KZoqDXCZ+HxXL7jS4W3iWaGHRg6tljnKsAwm4IZ0xpFDOG vIP4jDPnhkKX9P1I9qtGFMruUE+CX9/A4Ksy7mfu7VoMhlcxFCXrJsgEQvEwwY6xJLc7A3tJnsw O3z42DNFTPwz7VizVvVx6HlZ5uf0m7yjLAOf9y1t+0tzsAUbx5q5Py7RTmNDdVnzS5EzPC8J8Z4 kyUOaRLi3fLnVWpy1pJYrBV4LfiR5e3PVrjgUTipIcVv4eDFpE4vgppvYdY/fM2Ovn9Vfv8Y8zY g1bUBeQJ08MT9sQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c b/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c index 82679417e25f..3a8014ebf064 100644 --- a/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c +++ b/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c @@ -507,7 +507,8 @@ static int pm8xxx_gpio_get(struct gpio_chip *chip, unsigned offset) return ret; } -static void pm8xxx_gpio_set(struct gpio_chip *chip, unsigned offset, int value) +static int pm8xxx_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct pm8xxx_gpio *pctrl = gpiochip_get_data(chip); struct pm8xxx_pin_data *pin = pctrl->desc.pins[offset].drv_data; @@ -519,7 +520,7 @@ static void pm8xxx_gpio_set(struct gpio_chip *chip, unsigned offset, int value) val |= pin->open_drain << 1; val |= pin->output_value; - pm8xxx_write_bank(pctrl, pin, 1, val); + return pm8xxx_write_bank(pctrl, pin, 1, val); } static int pm8xxx_gpio_of_xlate(struct gpio_chip *chip, @@ -596,7 +597,7 @@ static const struct gpio_chip pm8xxx_gpio_template = { .direction_input = pm8xxx_gpio_direction_input, .direction_output = pm8xxx_gpio_direction_output, .get = pm8xxx_gpio_get, - .set = pm8xxx_gpio_set, + .set_rv = pm8xxx_gpio_set, .of_xlate = pm8xxx_gpio_of_xlate, .dbg_show = pm8xxx_gpio_dbg_show, .owner = THIS_MODULE,