From patchwork Wed Apr 9 05:34:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: K Prateek Nayak X-Patchwork-Id: 880856 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2054.outbound.protection.outlook.com [40.107.94.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1EC71DE8BE; Wed, 9 Apr 2025 05:35:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.94.54 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744176932; cv=fail; b=u2fzCLfydbw4pnaxO2RNEzxxNKef+qkMxPVkDYRsN2LI/E/10VGhrVw1Aol6dl9K57H017cHb6spfEwskiYqE69PdHWTgNCAvBqIgEjeXGYt5imDxNl4sYSj5Rc3YwAlRc42Oi8lYJqwHnvWtdiEfN1GkQuolBzp9SPozVLrawg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744176932; c=relaxed/simple; bh=KoCzauALSNFlQV0QLANKavLjEfqdOa/anecedhSeu24=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QnAPNAdQ/mVmgOvANxINbmo9CqlbyPnj84+kzQDGnbqXN9Eh3LDnsJcx2EMtj6RjHs05HpUoC9kkiGEkQ0At7A7MsPYZjrHXwJ1D5r3qpD/t/r8GnPnkLvsnUdNstSU3RvLjHOa/1jcM25rGRxh7A3vR/W8EtkdJj5/Ks5PjTVE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=Oo4g/yqc; arc=fail smtp.client-ip=40.107.94.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="Oo4g/yqc" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hukLKAOCXnGo32Si7xFno+YEtv9PltTeleIm1zgM0+hV/1ljK+0EV3UNXrEy/47MGmdfYxS082oA15PC++eE0dsmMYOIZZZP/Qa+G5qIul9FdyDfixiuiFVwbFON5vHJKl+h9cFUfWs8lbzjeX8Dfzy81IfS9TjHJtrUhLadbAKSF20kP3NGAmxg2IdenJckMGW3XUcuKpteBtB9+4/ypd93NRi2/pf+mkgXfQTisPyg7cE7vl/ywSbbij2QBkAxUDKOtiWsnHTZp6GpIy859A6xim/hs7/TnAS1uO5br3/gE2HyZPIaj3Cm5fcHA5jwE3lKeu1DVvZay+7Uaj061w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3Z5IuqlIlYFiC4oC0vmVqbtKJHcRr0/edZ+MJUI6tUg=; b=PZ2JK5gbAi27y4SFFXZFiEtVnJuvMukHNv4MPKKrVjUZTTrWabUFaWBeQpR9cxAGdghQ93Eci8zQRaepuRGh3D5IAplWjiskAxIihFVIKzIbsU4RIymrNfaBdd4Jr8UvokwIe27mo1/jN9ZaIkSKLqJsOCWMzsLpbLTCKN7sjBGcR3+wPtdz3wIK9boRt7WU+yoGftVh6eGBk67nAjX6r0YZwMSPhtd7Yud6uN8/E3ulCzwLiToSbllWiUlupjoELzItriw4zZCpinJbLbVNA270Lni4UvwZlNsG93ov8nbGGGbOAxDizVZWjNW/WmOC4dsaI0ePamvHPwGrUO9Zxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3Z5IuqlIlYFiC4oC0vmVqbtKJHcRr0/edZ+MJUI6tUg=; b=Oo4g/yqcO+JvmgKObUe+QS0X2zp/stsgp/iNRjY//Kl+8AY2nBRGh3ZswKo2Q2t7n7zRwJ11WIiRzO3iQ6x1/XATwhIg4BKvJwb3CNUKZNQSQ3WzL3mVqvB/XDzBoEiCx/7NJ2VicqiMt6voeC9AhX3ECmJ/jZic8LBrAElc8YQ= Received: from SJ0PR03CA0215.namprd03.prod.outlook.com (2603:10b6:a03:39f::10) by CY5PR12MB6551.namprd12.prod.outlook.com (2603:10b6:930:41::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.29; Wed, 9 Apr 2025 05:35:26 +0000 Received: from CO1PEPF000044F4.namprd05.prod.outlook.com (2603:10b6:a03:39f:cafe::a0) by SJ0PR03CA0215.outlook.office365.com (2603:10b6:a03:39f::10) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8606.35 via Frontend Transport; Wed, 9 Apr 2025 05:35:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1PEPF000044F4.mail.protection.outlook.com (10.167.241.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8632.13 via Frontend Transport; Wed, 9 Apr 2025 05:35:26 +0000 Received: from BLRKPRNAYAK.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 9 Apr 2025 00:35:19 -0500 From: K Prateek Nayak To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , "Gautham R. Shenoy" , Mario Limonciello , "Rafael J. Wysocki" , Viresh Kumar , , CC: Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Waiman Long , Swapnil Sapkal , "Dhananjay Ugwekar" , Huang Rui , "Perry Yuan" , K Prateek Nayak Subject: [PATCH v2 1/4] sched/fair: Use READ_ONCE() to read sg->asym_prefer_cpu Date: Wed, 9 Apr 2025 05:34:43 +0000 Message-ID: <20250409053446.23367-2-kprateek.nayak@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250409053446.23367-1-kprateek.nayak@amd.com> References: <20250409053446.23367-1-kprateek.nayak@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044F4:EE_|CY5PR12MB6551:EE_ X-MS-Office365-Filtering-Correlation-Id: 6a8ec31d-1216-465d-31ef-08dd772854d8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|7416014|82310400026|36860700013|1800799024|921020; X-Microsoft-Antispam-Message-Info: Qtve5uUpTzzFv9yp2sppvnaCTS5iu9KYrcmPeFM55prxG/pL+PK+zg9NRFgVvUFCVu0uPkqYpoh9LDE692Diaj4iJXwCqY/CVQRFfK0F2SY2GL8+gpje/XwDY5LAKTGYANA4wE5Q/ILBM9DM1bzGOcHozd0YVkaEu2lSDzAkQSx4dohVj1j7WcCL4c8tGcr/jHMalBEJNbBhI5aTnLf1F1xrMtI+a/Zt6tjXirg8ppBuYOtkLeLydFuWp2A/X2f7wWhVgbIvucdLUKmfQ9x3dMWvqROhGNv3WsnWQmYobT+gxmj6cQyZmxpX1U1oATAiLRt0klpzzNejfQfEt/FyhIglPtVmb7nifMslQ/5/Iplc13IiCpBlAnJC/4kOLhjxT8W19hiu3HBN7YztuX5JXudLOyTWeTlVhp6QZF+xBMQuQ6RTw2inakhhD51/mrHPYqX9heYeGeW3bxxDbDOSx0ewGsodaj1hGcClv1MkiuVyc2AoX308SOc7lwuWhG0qg7R6WZHkRR+IetJHokKGm7Ekd8ljvizYYRnlcgr/m+RNkZdCtDwvRMXJP54fgTPHSYACb5qwjWZvP8tAim2i1d0c2jGF1Bz/A5bUEDT/9d25RL+9M0Qgl3QBkqk4YPIUfTknFiKd32c9kLXu4bMlmmRuIZTpKgfZnV0h/wHChY47zGQx4w6uNoJRQxabMEHmF23I/9ocu72VpFBNzI4UJiiJsVWoEHCxjjuS2RchI4z0Q8dhJY8FDOCJ+ZesrnNMIYc3ffMFLGsxNYOSMoXHtRqjR6P8B+TNBfeLrA7PNi7D3IW/dL0Meb9vC/KCCdvC/7zDtA6rcFvm35Xvje+A5QS624puC84NtaKIyiP9bE5MylgrTXoqu+E0vhIULGk6an461mCgkH0WPvMDnaQwKkvCZiCzNcwgpUZyCn+Dt7ndowntEQipEGbmUBVMalheD/30cuZXau8lsfNBplhNZFiNk7FApB7XoEjh8xZ5eWWCkLawqBvMRK9YIwVqGoP/IakjcL3PT2w3U0eDopB2lZW3ELr3a35XQISeEGnx+6qOv/m1+mf28ez5b/c7vZIi5aD0ORAiWVx1WpMjb6ToSH3MAf9J+jkbISq8+AldFDzm1BwDy38dONPxtTk9XiTnybxRuy89w/bbm9WLbp9hpQ1CaGOKh96iqgJ/JDdk0wyXTRN5unwreWS2aZicr2QhQHWGL0ds6XK5VUgr70iA0uGVSAQ3RFTvyOSdQycKu/XLqocveTNjUopZTJmOkajqOc3KUvH0FSsI7tHOSYMoukVIomnGKfPsT4g6wKolb2sg7kgFCVvr2AB3QScHMc+G9fN6yjkDvPKEK+VcXMhvlT9f8YmdRcIenNgbgKPr51nHOeDytneuWc/xS9GN0vO8SVv0X+Aym+6FjdAMTzbmuaTtTAfcrxuVxcxxJNWgGa5h1Q6eRe1zKh/rLmUODsUY1xePT0eYtU8Q1YX65mRuakg2UKv6C2vU7g6Ym2u3T24= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(376014)(7416014)(82310400026)(36860700013)(1800799024)(921020); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2025 05:35:26.0924 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6a8ec31d-1216-465d-31ef-08dd772854d8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044F4.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6551 Subsequent commits add the support to dynamically update the sched_group struct's "asym_prefer_cpu" member from a remote CPU. Use READ_ONCE() when reading the "sg->asym_prefer_cpu" to ensure load balancer always reads the latest value. Signed-off-by: K Prateek Nayak --- kernel/sched/fair.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 0c19459c8042..5e1bd9e8464c 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -10251,7 +10251,7 @@ sched_group_asym(struct lb_env *env, struct sg_lb_stats *sgs, struct sched_group (sgs->group_weight - sgs->idle_cpus != 1)) return false; - return sched_asym(env->sd, env->dst_cpu, group->asym_prefer_cpu); + return sched_asym(env->sd, env->dst_cpu, READ_ONCE(group->asym_prefer_cpu)); } /* One group has more than one SMT CPU while the other group does not */ @@ -10488,7 +10488,8 @@ static bool update_sd_pick_busiest(struct lb_env *env, case group_asym_packing: /* Prefer to move from lowest priority CPU's work */ - return sched_asym_prefer(sds->busiest->asym_prefer_cpu, sg->asym_prefer_cpu); + return sched_asym_prefer(READ_ONCE(sds->busiest->asym_prefer_cpu), + READ_ONCE(sg->asym_prefer_cpu)); case group_misfit_task: /* From patchwork Wed Apr 9 05:34:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: K Prateek Nayak X-Patchwork-Id: 880855 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2046.outbound.protection.outlook.com [40.107.237.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82DEE1DC997; Wed, 9 Apr 2025 05:36:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.237.46 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744176970; cv=fail; b=LhJrR+uLhsJ9ptPZefEPRzMnouZCWdrDccfr2NKKcL/+dyG5a+XxJYVbsGeuf3J/5mJgEAo6uCBx9azc0u/at+QRhuXFR7iCvlgNw0j/a8QOUNoEjXmnG+W42XIjtuIg+Xcmhaigy9LhVZA70nZKNvJa8moMf3ZT0SWVY855lSw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744176970; c=relaxed/simple; bh=y+sJw537O8n3vIrVlJl69hNI1eBuTPGxEljugiuRmQ0=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=I078SEKZ/In1kIPNX+TzCHqmRPWF/DFDBKZGhnekO06YZjqLn8m0wwJUot5hBU4cyepNiNTRL0FU2+lYXE4sZoPPO8OSVDFIWVux3cnn0spRJUJK3i/qrEsUX2KQKiGnIgOp5b1UrvLHm7NkfZJEOyKDBK5SLVgPSHkMG94XUhI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=Lm+afrUU; arc=fail smtp.client-ip=40.107.237.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="Lm+afrUU" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=k2ytAyneDZzV9p+MRhIosviEQ2Up3sT3hAqNyQrdBzM0HABr2ixgh/59vF93KzviSlh1GRyqETLQ3Mu/hd5eFXjp+5jHM1eqhwRm11sX0Lld7uukdZ2i0htpWmykoroFQM98q+h11Lkoj/95Sri3Ba26/9uBZMBXlZylXe48YTxNeEaumdTzG3aqdmVEtrmrobWlJBbbg4AJ6omId2HKsOBp/whmdGTE3mAIzhLIQDmDkEbr7wdw1MmMHz/N6ORJb5gTq3Oa/FGEr1DutKQuXVjun1tnXt4PIogG6R0SHxncf2QND0EMWBd3ru+ONpWLnJwxU5aRplVrlPG4UvxG9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ttk1oyF3cF9zozJAhbovrdjff2WZS52rLspuN3uMrrU=; b=eOcMkl+TAInYUX1cGKq4BQWnZU/ECcLT2RC0dv/kYtLvyDMBE+Hyeu2DzluKrcmMdjjK4ABl5/f/NIP5+lZVKDFJApZsIBhzO2gpQp8I4n9+Km/P0Z/q0ygLgQkciMUONh81SqSKvmuse5P1JqPhWtHB6nHcpvVAXVGaYNNSvmcNFKBGxlge/TG7D7WJntaMbCXUAd6ZHFBWGDAY5HLzIb4DfBaAi4bIUvvdQ31Kbkh3YPQqt2geETTyJI2KSAupcMJvZ09gKwfk5ASrFTjTbj2nfgwiR80XyH3paw6rFjDG+XsxnrlaajrrV0Qn/HK8DU+Gb53fdg89gqndO5thQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ttk1oyF3cF9zozJAhbovrdjff2WZS52rLspuN3uMrrU=; b=Lm+afrUUR3q2r+3nKL1Bwnl98rDy/HZRQw0yXcNdmTZexs+bUkYMNykNzInZmd1cZXYT9RpgE7yzn1N3sVffTBw+eMMMRfdQPsTjVPcmWEc233plPLrhxsNpgXFh90qGaT8KgprMDDk2fgByzB/wQIGdq3JfGZedmC06n1clwCM= Received: from DS7PR03CA0201.namprd03.prod.outlook.com (2603:10b6:5:3b6::26) by CH2PR12MB9543.namprd12.prod.outlook.com (2603:10b6:610:27f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8632.21; Wed, 9 Apr 2025 05:36:04 +0000 Received: from DS1PEPF0001709A.namprd05.prod.outlook.com (2603:10b6:5:3b6:cafe::1a) by DS7PR03CA0201.outlook.office365.com (2603:10b6:5:3b6::26) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8606.35 via Frontend Transport; Wed, 9 Apr 2025 05:36:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DS1PEPF0001709A.mail.protection.outlook.com (10.167.18.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8632.13 via Frontend Transport; Wed, 9 Apr 2025 05:36:03 +0000 Received: from BLRKPRNAYAK.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 9 Apr 2025 00:35:57 -0500 From: K Prateek Nayak To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , "Gautham R. Shenoy" , Mario Limonciello , "Rafael J. Wysocki" , Viresh Kumar , , CC: Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Waiman Long , Swapnil Sapkal , "Dhananjay Ugwekar" , Huang Rui , "Perry Yuan" , K Prateek Nayak Subject: [PATCH v2 3/4] cpufreq/amd-pstate: Update asym_prefer_cpu when core rankings change Date: Wed, 9 Apr 2025 05:34:45 +0000 Message-ID: <20250409053446.23367-4-kprateek.nayak@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250409053446.23367-1-kprateek.nayak@amd.com> References: <20250409053446.23367-1-kprateek.nayak@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0001709A:EE_|CH2PR12MB9543:EE_ X-MS-Office365-Filtering-Correlation-Id: 730df8ca-95eb-4dc6-9aa5-08dd77286b56 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|7416014|376014|36860700013|1800799024|82310400026|921020; X-Microsoft-Antispam-Message-Info: SRv4Q2Og9IEUJCeF2DMMk4GYofTgFN45QlYiZBUWyBWn0QA37xRhtTOlFxQZpzWEp/VFNQ5wow+r1rcRj1l+r6iMfmanuWEoEe13nKlcrz59slhNU1TFq1Dl1Iru9hdCcnmjSv4Npiq1Zz5u3b7MHu9e6RXkQW10Gwv3Vc9d6nXeZEyTV//f5MejInWsHAp7TXW74Rb2enGDhyCe2zSM9HCIFF65fTwX6jgxZlAjefUi43k/OREQS/rOxdk8UMJw72wXSf2xCWBHIUQM4wYWjKUFwuFZoyV2xXbRip/XWZaYa43Hsb6r4ckOHc108ZddfSeeCbMT+QqL+RKGn4dWu4cJiNKuafL22jp0jUwZg9sOr9axzGpd+A++tIIDk5p2+DaurW4NZpH8nRxQlFF5xChEgnr8Cj21+NdhA2/UGvJuCdFXeBAzq1OLNxpW8yjkKYqcxX5QN7QMrELKGpcvphijkanf2KFN4Wn7c+8gp1Nh2Z0opICoYQo78ygi7biNk5HIoxCjcs5NW+MO4OVdV8yjhK7hh4kAjTg1uFCi1AAKdhiIwwDGJOt7MxY/94uICvu36jIKYGId8L3g1LFTsVz7Rjmog56Vl3oL/iV63UZb3QbhFnjsHrOB2PbkL01yWITSloAn9DVwyNSYOqenNyKadE+0iRKLxH/oN/BE+4uaCL4PJnxo6ySsfteOGK75BvNnjQS04Y7DvonoI+iD5bVLCF3M9bol1iyGMdAa2FH8yHaZ+QiTcEXCC7njYFEBXd5PLevuisgfARmqIc9Rhi+p4GQhIGG3+kCKpcprM6G6iqEUD+sOZJpqtFoj9QzIF0rn98nurRihi3RTrukYAKSikPDVvgQAT8UBTX9b7gY6nKjf/GDz2+mW/bdJovgsGishc6I3+WPMBJUpIgpGfrNfvwxHHGOxUuzHYgt7cAFSe8Y97mglmV6TIMEwVcKedoRDUWcWo5DeEXdjtUNKGSu6ldBxWIn4g+zN7yBidV+Ehb8fEfugF/+NB/fsqL7Dccvc/x6WbgA986Np0jQ9DHIgvMA5N8gYVf1LpsZOpXWAoBE/JGc7z54vXK0CmTkusAZSfdiD0rufnC4TmeOOyRhtg96K323FyGlfxckuWzVkISjFmnu3j0AUymX7qDJG11FG2ceNEtiEj0pOznx5Rb9pR/VA/jmW0GQLDWtw6vRTc4WUhAsDDYJnYLsR9h9Z63MSJPJIXJXkRgaloY+2BK2EQdVbsHcW4YbXl6ZpozfoLpGiIC06MBHbO6vhoO7PZugoaX8ACoS/pU4QhvtqkhkTCuB+a8aqIgDbZWBghCxIFTnIX+dxWAo9mBQW3PivxAEOGnYfvWjU+fCM2UwYjQQMv0mWzzBLwDqk7G8f/m3Gjb4ku4F5AR6jM20XeK0hyH1qnw2dpyLS4bZxrJYc9YJmZyyi9pobAmmN5Ndycl7nEMLTzEVlz7QRhCzySTH3SK9t8e3FQqXe9Wy2ntmt9mmfBTUPWgX2/JodwmvdXvc= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(7416014)(376014)(36860700013)(1800799024)(82310400026)(921020); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2025 05:36:03.8932 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 730df8ca-95eb-4dc6-9aa5-08dd77286b56 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0001709A.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB9543 A subset of AMD systems supporting Preferred Core rankings can have their rankings changed dynamically at runtime. Update the "sg->asym_prefer_cpu" across the local hierarchy of CPU when the preferred core ranking changes. Signed-off-by: K Prateek Nayak --- drivers/cpufreq/amd-pstate.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 6789eed1bb5b..8796217ccc60 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -844,8 +844,10 @@ static void amd_pstate_update_limits(unsigned int cpu) if (highest_perf_changed) { WRITE_ONCE(cpudata->prefcore_ranking, cur_high); - if (cur_high < CPPC_MAX_PERF) + if (cur_high < CPPC_MAX_PERF) { sched_set_itmt_core_prio((int)cur_high, cpu); + sched_update_asym_prefer_cpu(cpu, prev_high, cur_high); + } } }