From patchwork Tue Apr 15 18:34:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Enrico Zanda X-Patchwork-Id: 881477 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DBA1204F73 for ; Tue, 15 Apr 2025 18:35:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744742135; cv=none; b=T8WbxHMBUdIhbIH/b13NuenzPV6b5rVoeJBDT83rq6uBLwhIy6YZUFvCqJv9E/B4aW+8t7reFHpYPIlN2LemSXnKVDJivUVpR+Cn60ftgCtJeRCvpPc2JDFrF/ZBtmQWwYZ4Yq3qbiRKQ6JXMJbzxljW/enGhwHSTY2kW+rruzs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744742135; c=relaxed/simple; bh=kGoDOFQgx2377brWiTL4KcLOhyAypHsgycE1UFpJa1U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=r0u1p+AVIoVd6+BD3wCsY1/8twNx+myo8lmunU7PrhYJa2p/DDcxBEoNGFGAAuHgfGToP1biSZdFvFGAnW3MjxcBPnGQQudvvG978rgR9uhXyUx5lICX4plFiY/0FXD3IZG25uvAUoaybV62Do1vIQ9wNokB+6AK9qyzHSU9qGk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DEfo9CVO; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DEfo9CVO" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-ac3b12e8518so984056666b.0 for ; Tue, 15 Apr 2025 11:35:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744742132; x=1745346932; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jqDDKHcMVOtHqHJvkbewc6+GaqJjyOfiQe0VSDjHBgQ=; b=DEfo9CVORSRBszhVx5mUAz8tzTbRJ+C87hGqZX/mlwpkyjOUOpAa0hxHfo1MOgMhhd nav3nE6G0vA15UGNt6/qn9XvoAonLUsQYj8lzgGhP9+jpedFakP1ypgwqgWmZvsTL3A0 CdgU1X2cbhisb/pm8p1zTG9197VsbRuw+rZscCN5LEicSzYZFxZHocYoPZlytSqcpvMQ lqHQFfMP53cHoQEqbVqQfR2z5EWqE+OY9D9kY5qS9CE8Au+a8T8lIrQTfSJ9FotQB0vp ud6LQ5p8Zgn+9jPOf510zSUyzaY2rih4sbQTbJNplzDZ3h+4/tITN57ImQQJATLbwVa4 KR8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744742132; x=1745346932; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jqDDKHcMVOtHqHJvkbewc6+GaqJjyOfiQe0VSDjHBgQ=; b=d+EjpU4Qn118cSKfWTo9gFTGHn26m1rTeKIib3QcQLQdCh26NOBh+FaXuh587A7fiW p/bM8u7UZoGizPEUjz7gLaUZ6Xt4mEDcjnRjAUIfDmTGb8GpXJhcRLpbfYcdhBO2upzI RGVAsb37rqg8dXIv31ze1VYiJmV5Ei9+PSDCN1wsY/mMkvn6e5e9f0jTSW6uezFbMVFZ 8S6agI7WDfo3XT0IrlU5YzH6cjnBROh58hQGmwU8QsllUKaLoenED9vhu9TL2Pyumzcd LkP059/wWIV6PnOcdySWRdW7yOAXpa9YyU8wk7PTvswRoSi03npuFRDyueKiAvjjrXAL TnMw== X-Gm-Message-State: AOJu0Yw2UdYU70tKssdocxYxnvPnDG/ZvXRjbtrCQKQh9Idu1GOmcW4D ho5dOSUvTX1GFhQvomfvu0iH5ueIUg8e1gWeAoqlAbA1QPfhRTYbKphFe/vqCGc= X-Gm-Gg: ASbGncvZzFThXcKLYTEpmyOtKwaQK7aQyN5oQ9Tfxkh3FzXDTAboyxw3cIJlJ2u4O+O 81V2lDQ9flBobbvw7sfegfHdlxjm4RF6Q7h7fl2o2ns+6+IdC3FVYKY6mBPPhq4MN6zDi3slVWh fjzkRs61eeGrC/F+d677mB/GsSyP3UE3taUpJuUjYgq2v+c0vCT0mk3k/Xpv/ot2hcThtI41PDZ D6QiWMOboaNss7VujKx8B6++Rs+5Vz8Rj59w1ZjxYOG0ZDnCsaKhAWZwH6jMbffqRIygFSZkxK4 EDb2BPIQI8icCVWYLrpZHS2TE0pSZMNpfWTLA8T9ApIfxo0l62ucmX82hzdY51yfX3uzScw= X-Google-Smtp-Source: AGHT+IF9Hr1jJVGBwCaj9PAQ/AaQjFy/PsHSgSWhyQMi+4ABxfY3EViVvQ1nXI2UBBc2Zx/7IVG04w== X-Received: by 2002:a17:907:7f17:b0:aca:a1d8:981f with SMTP id a640c23a62f3a-acb381c9c0emr14183166b.12.1744742131507; Tue, 15 Apr 2025 11:35:31 -0700 (PDT) Received: from ez-X1.. (mob-194-230-145-83.cgn.sunrise.net. [194.230.145.83]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1ccd1adsm1148844266b.145.2025.04.15.11.35.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Apr 2025 11:35:31 -0700 (PDT) From: Enrico Zanda To: linux-i2c@vger.kernel.org Cc: andi.shyti@kernel.org, Enrico Zanda Subject: [PATCH 01/10] i2c: uniphier(-f): Replace dev_err() with dev_err_probe() in probe function Date: Tue, 15 Apr 2025 20:34:38 +0200 Message-ID: <20250415183447.396277-2-e.zanda1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250415183447.396277-1-e.zanda1@gmail.com> References: <20250415183447.396277-1-e.zanda1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This simplifies the code while improving log. Signed-off-by: Enrico Zanda --- drivers/i2c/busses/i2c-uniphier-f.c | 24 ++++++++---------------- 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/drivers/i2c/busses/i2c-uniphier-f.c b/drivers/i2c/busses/i2c-uniphier-f.c index d877f5a1f579..ca0358e8f928 100644 --- a/drivers/i2c/busses/i2c-uniphier-f.c +++ b/drivers/i2c/busses/i2c-uniphier-f.c @@ -532,22 +532,16 @@ static int uniphier_fi2c_probe(struct platform_device *pdev) if (of_property_read_u32(dev->of_node, "clock-frequency", &bus_speed)) bus_speed = I2C_MAX_STANDARD_MODE_FREQ; - if (!bus_speed || bus_speed > I2C_MAX_FAST_MODE_FREQ) { - dev_err(dev, "invalid clock-frequency %d\n", bus_speed); - return -EINVAL; - } + if (!bus_speed || bus_speed > I2C_MAX_FAST_MODE_FREQ) + return dev_err_probe(dev, -EINVAL, "invalid clock-frequency %d\n", bus_speed); priv->clk = devm_clk_get_enabled(dev, NULL); - if (IS_ERR(priv->clk)) { - dev_err(dev, "failed to enable clock\n"); - return PTR_ERR(priv->clk); - } + if (IS_ERR(priv->clk)) + return dev_err_probe(dev, PTR_ERR(priv->clk), "failed to enable clock\n"); clk_rate = clk_get_rate(priv->clk); - if (!clk_rate) { - dev_err(dev, "input clock rate should not be zero\n"); - return -EINVAL; - } + if (!clk_rate) + return dev_err_probe(dev, -EINVAL, "input clock rate should not be zero\n"); priv->clk_cycle = clk_rate / bus_speed; init_completion(&priv->comp); @@ -565,10 +559,8 @@ static int uniphier_fi2c_probe(struct platform_device *pdev) ret = devm_request_irq(dev, irq, uniphier_fi2c_interrupt, 0, pdev->name, priv); - if (ret) { - dev_err(dev, "failed to request irq %d\n", irq); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed to request irq %d\n", irq); return i2c_add_adapter(&priv->adap); } From patchwork Tue Apr 15 18:34:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Enrico Zanda X-Patchwork-Id: 881730 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92E2F22686F for ; Tue, 15 Apr 2025 18:35:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744742139; cv=none; b=L6LI8496meOza0kiWTLXrTxpUcT+XTmgEObSlJoq4nnNlgmv7tf6stpyUnupicd70bcZcA0HbPTWBhqJlkodWKOoQUM3FECT2W+tiBIUwX6KQK/W9H7zbfD3BzvVdNYcQN1ncE4hc+uNoIBFy1Lui/54RF73XDnD1QZl9nNNrx8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744742139; c=relaxed/simple; bh=wtvkK7t8bKcV1fXBVGIuLimOCdXGq7mpKoeZ36ObVgo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=t9zee/H1s8aApaG/le7+yZKEbxVIHZIQs1aidh+FncHB/2c4pFaprnn4Ukw6Qh2eXuG56uylOZFDMZmiIc6TE+aX3R2rJijH2/1lJuGwe9Y7igRi4O+R3m9YRPrBNZSiboBjlIf1Vy/XO0H+ecvSMAgGQgpjpyQ3hO794Zt1nco= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OtrGxS5a; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OtrGxS5a" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-5e6167d0536so10850547a12.1 for ; Tue, 15 Apr 2025 11:35:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744742136; x=1745346936; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=L+BiVUOweVIHSXPffjiVNDnalTCKeOgbSdliRb/NekU=; b=OtrGxS5aj+Ozw/FrA0SCadKfXU1G6/VhOpDgAcVLgLfN7dUd1zMDG7h9EH1N4TKrZL HnmsGQnvISGy+P/akvLQTkBgpaTmLFKHFR5pQUulpbZxx4QpjA+G9Ljkw+AMCS0eFEaI Je0ox6YHB/fzHdU1fkUDik6FTvXHltL0DXp2WfgRO2kKEU/Kxi9EDXxpOUuCPaarYm+M S+j4zqylut/5gRDWa4E4jF/WAWjzvPBIFL8hOL+fl4bR8j5RxI8g6GtOXTq9GaAsKSKz 8c641o4SDhOMXk0sciRRt0h1z9OIniOheumEVrAdKBcokqqjWldG4CgyqXbzPA8JsXYK wSHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744742136; x=1745346936; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=L+BiVUOweVIHSXPffjiVNDnalTCKeOgbSdliRb/NekU=; b=IuD6vZrUaw8aBV35Bly6l1ihGWIOnQ02y/QFu1qxxLX5hPji4LHT/gA+ujlyU5Pv6M 1IJe7heksCYZ9238q4vvXqKdqKMTmEI3orRQWqq/USkXes1Kz7cUF9uGRDLk2gYazuMN Qy9FtkFrXyl1cTHy+4dCru0zjOLbREDWtr4hUSzRS7/do5pzgM8xrTL5Lnq705rIsjof ojU3K7V/Bsdova/fHQGLMRL1+6U983duk6xsqWvLqwS3Y4aLNNyCL+vssFmBiqmy5Nyy XQUqFIjjd1wYbel0aL7a84Fg/yVq3fD2KiAuncccwrTSLGRZqIFe7/0FGdKTjl/AWGJc Bl7w== X-Gm-Message-State: AOJu0YzrfxVc5X0C2mPSh+mj+PqDwqRhAW1l/5U7FEuNS0w9csvDpghx DgvBUfjGFLPUD5JlBMcQU4WgIdvoW49JCpSMsQYX45lNrkWlS6a8Bs+9ZJ4v9DM= X-Gm-Gg: ASbGnctR5d4NGgomE+/FPgznBzYAptwuWuETERhBmmEU6thwfMHO7goKgcXNJbwp72w XPVrjcKJiMxWA4urxpynUu5JT6dQVda8vbQoAsDyS6q6F8eEfC/4sm9/yBsvqU/nNyEoST88hPS AuMY26cVV4s9gCT5CkUgJb3Kmxt40xpk63dLn7kIypZQDLISI6uxhSt6/bWlxnF0fHJGYc0TuEm lLi78jPqRpy0VCX01DxghlKJWZ86RKt0QpHAavT3xOnkZWq9iRzFFpbyJIs0LqNBk0yeuLePiFf C7rnYfK2ZPUWVVOi3ITb8v2MApmg3NYf/c6REFwHJHlJAFEMzKAsu3HrIWFDs//aVYq0ivY= X-Google-Smtp-Source: AGHT+IFHQOJjJ4u+1LqRGokl9xjv2UDGaWtsPPLgjEyCfUnypyM5hIue/p4kgtNxNDbj7bxEGC779g== X-Received: by 2002:a17:907:7ea4:b0:ac7:cfcc:690d with SMTP id a640c23a62f3a-acb3849e122mr9512566b.40.1744742135590; Tue, 15 Apr 2025 11:35:35 -0700 (PDT) Received: from ez-X1.. (mob-194-230-145-83.cgn.sunrise.net. [194.230.145.83]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1ccd1adsm1148844266b.145.2025.04.15.11.35.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Apr 2025 11:35:35 -0700 (PDT) From: Enrico Zanda To: linux-i2c@vger.kernel.org Cc: andi.shyti@kernel.org, Enrico Zanda Subject: [PATCH 02/10] i2c: uniphier: Replace dev_err() with dev_err_probe() in probe function Date: Tue, 15 Apr 2025 20:34:39 +0200 Message-ID: <20250415183447.396277-3-e.zanda1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250415183447.396277-1-e.zanda1@gmail.com> References: <20250415183447.396277-1-e.zanda1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This simplifies the code while improving log. Signed-off-by: Enrico Zanda --- drivers/i2c/busses/i2c-uniphier.c | 24 ++++++++---------------- 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/drivers/i2c/busses/i2c-uniphier.c b/drivers/i2c/busses/i2c-uniphier.c index b95d50d4d7db..9d49a3d5d612 100644 --- a/drivers/i2c/busses/i2c-uniphier.c +++ b/drivers/i2c/busses/i2c-uniphier.c @@ -327,22 +327,16 @@ static int uniphier_i2c_probe(struct platform_device *pdev) if (of_property_read_u32(dev->of_node, "clock-frequency", &bus_speed)) bus_speed = I2C_MAX_STANDARD_MODE_FREQ; - if (!bus_speed || bus_speed > I2C_MAX_FAST_MODE_FREQ) { - dev_err(dev, "invalid clock-frequency %d\n", bus_speed); - return -EINVAL; - } + if (!bus_speed || bus_speed > I2C_MAX_FAST_MODE_FREQ) + return dev_err_probe(dev, -EINVAL, "invalid clock-frequency %d\n", bus_speed); priv->clk = devm_clk_get_enabled(dev, NULL); - if (IS_ERR(priv->clk)) { - dev_err(dev, "failed to enable clock\n"); - return PTR_ERR(priv->clk); - } + if (IS_ERR(priv->clk)) + return dev_err_probe(dev, PTR_ERR(priv->clk), "failed to enable clock\n"); clk_rate = clk_get_rate(priv->clk); - if (!clk_rate) { - dev_err(dev, "input clock rate should not be zero\n"); - return -EINVAL; - } + if (!clk_rate) + return dev_err_probe(dev, -EINVAL, "input clock rate should not be zero\n"); priv->clk_cycle = clk_rate / bus_speed; init_completion(&priv->comp); @@ -359,10 +353,8 @@ static int uniphier_i2c_probe(struct platform_device *pdev) ret = devm_request_irq(dev, irq, uniphier_i2c_interrupt, 0, pdev->name, priv); - if (ret) { - dev_err(dev, "failed to request irq %d\n", irq); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed to request irq %d\n", irq); return i2c_add_adapter(&priv->adap); } From patchwork Tue Apr 15 18:34:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Enrico Zanda X-Patchwork-Id: 881476 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F04BD22128A for ; Tue, 15 Apr 2025 18:35:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744742148; cv=none; b=bZFPGHk5eh95LJBR+jNs68fC1JaX6AtXwGkd8WvV5PVLv49Btki/nlg22ZGfV0n+m5WQoe+uHP2VX1xXSAbkNSV1AK0Xk10DGYx4y6/yIwxU1GBYgH61JJieloyLBAWwjo/YOHd7CUaKG5Dz7hhNvo8OPaxeNEulxvG9nCox1wI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744742148; c=relaxed/simple; bh=pruY+nFNsKca88FjY5lSUCdbgnKB7JQMnCuDdhoig3I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=U0pSnP1Lp5NClVgXMcE6fZg/8zs4fjG/yEZZthKUg0r8Gc9n7fgPRCcHbbA0nQ2BFw2+fHvao3aWTdGK9r4jg+0VkP04Kjvn+D4bLegWrHnikP6DzGZ2klAMHswd6vYo/FXvKtUNPNvqmCkb42e412MfF0HYv6EYFXHmSE1Aw8Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=boAB4djM; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="boAB4djM" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-ac34257295dso1106307166b.2 for ; Tue, 15 Apr 2025 11:35:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744742144; x=1745346944; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MA+pMyIkNumlVCFVRszVFMlO4JT2BWBduaXaRgVvQKs=; b=boAB4djMNt8WmD284UXlysCfAAaIyAVrwDJsYKi73qsQh5CQ1X/iM9Res4jdMODSsx nKPMGNGA5guaop/EuoylOpISfCJkjLzqpgcFgyl5Ur8uzH5Jxs/qGFBqvZEdgIyBN+gf hzWLHunFxu5ToZMsXIqMTZzTuRmqnJOEA8dvs/jbmhqVjJ6q0AzARERa6FdRg3w0ZULu CxehfmqRHJyEzGt2+CiePZr/0Pi1WmuzpeKScLADfM4wpuVqgfxROjSn53OpDL1Xb0+F MY36aldn3dGTcdbTHvE9En8VSXxTH/z8/5zE7bv2dhUfQdTSx7JpHzuWQySvJc0nHDMT 9RJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744742144; x=1745346944; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MA+pMyIkNumlVCFVRszVFMlO4JT2BWBduaXaRgVvQKs=; b=fQCqRO5P455eCK9r6+eTX/4GjfjCY9Z6Pt2T5WMhTrueid1JLUemUwOydU9Nty94xz 7Tq11m4ESDXdWlqhNvG81o7FspiSyAOuZhfAJ8m6bYLbiXxOrVicsT2SH3zDYyeCNFYa jk+j5oeznBVAbI9Vn8MU7M0Ww5hxuRXsZaTzUhCV1CgEARaDxJut2YEIn/mVLmzNj2K6 d1e1/NxLfBYDx8smJNqqASodrMosvVP47Tkq2u78r5GO1WiUp+Ojb0vJMM6o2fMh2Tx9 X9QxlF2k/tG1W33QDYRv22jotmyDslQRwYPgDzFeUqR2ExcXw7ZQYQBYnB9bOuaOZxTC 9YKQ== X-Gm-Message-State: AOJu0Yyz+qXMXdMSY8h+P4FimLgEo1SKtyXEC8VSGfxvL76iKb6ARcjE HFQ2HcSPsxftcjXCth+noe5yHitWwaL5wSW5cg/ta9tGYQtljv+rqN89FlH44og= X-Gm-Gg: ASbGncvwpnh7aiia95J+aDhLxDmlgiXMaqbcDsW2n8D8sWf56gNZFDPYq0ADT0x8S4o 4BCb4g3ZWI0eV3j0/5MwC9PrXRMQ0zLqgP1BNMISotp8q6dsmAnLBnd0tVW1znWTT4tNS7hoBD7 6zUhH+TAlHpSyZNj5Q5nkcQ/YnlevgLJW2ABas9FCckMvlPlSdSWq4OLJmc/WiJ8C8SAGexOA/+ ZyrBNmTTiBoxpT3mtz18Fh47IoFw8xOoUsBvdj1XCxIXuPTx3vP2OGXmF3wxTMtJe7RBo9QQuAS vvOlL2Qh0YGj815Mo7TWJd3keSSG/ddLbGyDMa9wDXeTyOEq/+/94+FDXG8vUFZLsg5SVkUgRoq h1dh0HA== X-Google-Smtp-Source: AGHT+IHUaaOfL/D0V93BaMGd1t3O5JDHkPMEVCDMe+wxsykAlCbeQv8qY8+T036PDrTuoPiIF1WKyw== X-Received: by 2002:a17:906:730e:b0:aca:a688:fb13 with SMTP id a640c23a62f3a-acb383723a9mr12277966b.36.1744742144076; Tue, 15 Apr 2025 11:35:44 -0700 (PDT) Received: from ez-X1.. (mob-194-230-145-83.cgn.sunrise.net. [194.230.145.83]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1ccd1adsm1148844266b.145.2025.04.15.11.35.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Apr 2025 11:35:43 -0700 (PDT) From: Enrico Zanda To: linux-i2c@vger.kernel.org Cc: andi.shyti@kernel.org, Enrico Zanda Subject: [PATCH 03/10] i2c: via: Replace dev_err() with dev_err_probe() in probe function Date: Tue, 15 Apr 2025 20:34:40 +0200 Message-ID: <20250415183447.396277-4-e.zanda1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250415183447.396277-1-e.zanda1@gmail.com> References: <20250415183447.396277-1-e.zanda1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This simplifies the code while improving log. Signed-off-by: Enrico Zanda --- drivers/i2c/busses/i2c-via.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/i2c/busses/i2c-via.c b/drivers/i2c/busses/i2c-via.c index 7ed29992a97f..2de73fda6613 100644 --- a/drivers/i2c/busses/i2c-via.c +++ b/drivers/i2c/busses/i2c-via.c @@ -89,10 +89,9 @@ static int vt586b_probe(struct pci_dev *dev, const struct pci_device_id *id) u8 rev; int res; - if (pm_io_base) { - dev_err(&dev->dev, "i2c-via: Will only support one host\n"); - return -ENODEV; - } + if (pm_io_base) + return dev_err_probe(&dev->dev, -ENODEV, + "i2c-via: Will only support one host\n"); pci_read_config_byte(dev, PM_CFG_REVID, &rev); @@ -113,10 +112,10 @@ static int vt586b_probe(struct pci_dev *dev, const struct pci_device_id *id) pci_read_config_word(dev, base, &pm_io_base); pm_io_base &= (0xff << 8); - if (!request_region(I2C_DIR, IOSPACE, vt586b_driver.name)) { - dev_err(&dev->dev, "IO 0x%x-0x%x already in use\n", I2C_DIR, I2C_DIR + IOSPACE); - return -ENODEV; - } + if (!request_region(I2C_DIR, IOSPACE, vt586b_driver.name)) + return dev_err_probe(&dev->dev, -ENODEV, + "IO 0x%x-0x%x already in use\n", + I2C_DIR, I2C_DIR + IOSPACE); outb(inb(I2C_DIR) & ~(I2C_SDA | I2C_SCL), I2C_DIR); outb(inb(I2C_OUT) & ~(I2C_SDA | I2C_SCL), I2C_OUT); From patchwork Tue Apr 15 18:34:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Enrico Zanda X-Patchwork-Id: 881729 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCD9A2253EA for ; Tue, 15 Apr 2025 18:35:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744742150; cv=none; b=ITtdahsL3AL0ClNN3bw8V5kAq0wsMZhMnLD0JlcNKyM5mWrNaPmDdf3Z0TZOATVG8o39Yyvg82JVU+aamHpBRnoagxsYAium0+5xgr13fl1UCnk/FqldTDw3lK0UPYJtv2r6+7bFGfL4DM4k6m5MnA/3Imc3x6TLCxmJoHE6biE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744742150; c=relaxed/simple; bh=qjfGJe5YV631zV3iulbwZ6i7MOpznd77s+WGoyfz1HU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZK7jKmUbbBR3Ok4cBL5fVfSVYH/sYCZVOStcCXug5uWVD1yvGP+hdhu+rI3K0I0JNZ/zfqkiFQwTpQiP1Ffp/vo8aNRN2d1M2gDYG9YYvZb0isUEcMubAOQ07W1kPjjLHtQ15GwR21eaPk3Z1yoeTF0pfw0xax2o1MRdnfyhF30= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QcwiaxND; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QcwiaxND" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-ac2dfdf3c38so1131178266b.3 for ; Tue, 15 Apr 2025 11:35:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744742147; x=1745346947; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VP3m0RdnPv6mPDyQodFl6WZtTlIbnQ1jKMPGLv44k/c=; b=QcwiaxNDCZSPW3A+UPYhljx/sEIc7mfwswftqoXK4Wu/0AmjsQhDeSDwb5XOzAuRVa 3NOlqTyXcbFK7/K05jeJce/tog40l5ijFv6uSb3mzZJ2UdM9OT/HhnQhqr4eYlEyKgSX Qd6cHBkZubon8gTOJSuu7yHGown3z3UkhxJpFAkCp1YSbRSNnPlCdiB66pZrlDndeAlm ic6Coy6LkPUHrhnwTPaAxJcKH6SCy6V2IhGBrAGHUD/mbK+LShSAW3Et5FZj5uPu1OWo U7bX/17Ip3eiM08iY31AwwWrrq3U1Ei75haKVr4vrJnvOPasLjBBdvwLj3faH+KdPeac cBLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744742147; x=1745346947; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VP3m0RdnPv6mPDyQodFl6WZtTlIbnQ1jKMPGLv44k/c=; b=WhV9rBOLGxlL0D347PfCL6YNb/ZWplFgl4QaHTDeg1JhaO9aBhqRRJDXBMRwRZyqx/ KpLyUT57S8MldHuqOSQpNMWv0Xu262ZkKRcFkPnD3jxI1tjS+z45ZR6PeMRLhNKpd98O CMMrTwKUptA6Jwr0pxXv7Dg71EIsMzNjTtn9PvAcpc1zTq30LZlbo/tR/nVN6s1b6Bky 0lJE9sB2hyd3W3htQI4etghD/xSXqA7fHuy307yVDR78bzRvvX4PB/kiwqs96VeDARyC 5pQV3DhppgXNmCRTihbwk6vYy/kUYN8f9pLyOrykptFCFKVXvx/UPZHsp1I86QDGVdus DaSQ== X-Gm-Message-State: AOJu0YxzKxzk4zh3Ie7U2OmekcQYUeXCBrgSV+br+TIDHSJibQYYchKV CRtgWgwL7d5H8GlvyF22he8tdnZXO3lri+VkucftWwV4kQGZtWEclk+Uut/sC10= X-Gm-Gg: ASbGncvotQu/Q9Hsl/YkLOvSVgxnEj3HlBK/rOLUDbv5maaUElbbXphLPRiQL3a4ePK SSJIsqxWA3Zs7YS4aJCMg+6N7ogiGpmrxcrz1ixEoYu3MQ9COO2e3dTZlmd2LQeH+jZJd9qS0Tx 0MFRgD2MGd3b04oJ5WcirWfYPbgmaC4ZqD81wFWRXLNOPZPbsdWHFJ1e0GG+82IOM0OegQS2laJ ETkaMlvENH4QtlXtW+3l+eADcAT3liibU1+DLINAq61h5YEecWzVnfgL/jkeqtkVESgDbgfIS0p bo2Vfr70DMrcoRytGs1HO7sddbdo+IIOfgvcB5cpsam+/UYrM+m51ZU80yrA7n/wU63NHRnJKCB UUs2Ivg== X-Google-Smtp-Source: AGHT+IHa+4AkwUDbKN5xidVv06/d8Nn6wuD1cj9aNOo5RN+WNebCbM8UlTUzXq1A0C09KKoVrydpHg== X-Received: by 2002:a17:907:1c16:b0:ac3:3f11:b49d with SMTP id a640c23a62f3a-acb37e316d6mr16327566b.0.1744742146826; Tue, 15 Apr 2025 11:35:46 -0700 (PDT) Received: from ez-X1.. (mob-194-230-145-83.cgn.sunrise.net. [194.230.145.83]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1ccd1adsm1148844266b.145.2025.04.15.11.35.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Apr 2025 11:35:46 -0700 (PDT) From: Enrico Zanda To: linux-i2c@vger.kernel.org Cc: andi.shyti@kernel.org, Enrico Zanda Subject: [PATCH 04/10] i2c: viai2c-wmt: Replace dev_err() with dev_err_probe() in probe function Date: Tue, 15 Apr 2025 20:34:41 +0200 Message-ID: <20250415183447.396277-5-e.zanda1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250415183447.396277-1-e.zanda1@gmail.com> References: <20250415183447.396277-1-e.zanda1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This simplifies the code while improving log. Signed-off-by: Enrico Zanda --- drivers/i2c/busses/i2c-viai2c-wmt.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/i2c/busses/i2c-viai2c-wmt.c b/drivers/i2c/busses/i2c-viai2c-wmt.c index 4eb740faf268..be23dddf8bde 100644 --- a/drivers/i2c/busses/i2c-viai2c-wmt.c +++ b/drivers/i2c/busses/i2c-viai2c-wmt.c @@ -121,10 +121,9 @@ static int wmt_i2c_probe(struct platform_device *pdev) "failed to request irq %i\n", i2c->irq); i2c->clk = of_clk_get(np, 0); - if (IS_ERR(i2c->clk)) { - dev_err(&pdev->dev, "unable to request clock\n"); - return PTR_ERR(i2c->clk); - } + if (IS_ERR(i2c->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(i2c->clk), + "unable to request clock\n"); err = of_property_read_u32(np, "clock-frequency", &clk_rate); if (!err && clk_rate == I2C_MAX_FAST_MODE_FREQ) @@ -139,10 +138,8 @@ static int wmt_i2c_probe(struct platform_device *pdev) adap->dev.of_node = pdev->dev.of_node; err = wmt_i2c_reset_hardware(i2c); - if (err) { - dev_err(&pdev->dev, "error initializing hardware\n"); - return err; - } + if (err) + return dev_err_probe(&pdev->dev, err, "error initializing hardware\n"); err = i2c_add_adapter(adap); if (err) From patchwork Tue Apr 15 18:34:42 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Enrico Zanda X-Patchwork-Id: 881475 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E15D22256C for ; Tue, 15 Apr 2025 18:35:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744742152; cv=none; b=jRk2Ox3GRY7UYj67GMb23T35/2Gb6/AWYDRZpvuiQYJQ1olMPWZGoJBnrGLk0cEl4S2MhGmG4YOe36/2Yj+HeV2TtvhGcPtN2oTTC3J2VWtYlCGxJGv8USBC1G9TrVc9FmEGYAupM/SfTFNpufbZbiKAXoj/Q0tD/wIay/QSi/E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744742152; c=relaxed/simple; bh=zx0r4+m3QUyd9kb8a53p0Hzjlf1MKEWHv7xnICoUcDw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Aosh+UZvbpXDXuIR5rs+PXX4GlbNPpSQLATLRoFOhWUO8BkfI45gQlClxPh9LHqZWVBtxqviaMk45WAYaPdXvqbY5CyYcMoENOOuxtX6qEjipNF6QdDzccu2jFfuONaQx3KDDtfqwAPvWse68+P88Ccf+uXf9v+crOe4eYKh9p8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ccEz8pKJ; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ccEz8pKJ" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-ac2bb7ca40bso1104134166b.3 for ; Tue, 15 Apr 2025 11:35:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744742149; x=1745346949; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=loMTrZDHzmCOUyxOFOgREZ3HVqSK503Bi09wuZfwXGo=; b=ccEz8pKJjgr+QXnm/aG9QQCOjtoVEa7WJ7JCqyeXgF7+6vr8osIC0ITeEB/DjzcC8t vRpPMkhvJ9zcAPinomS0uw9NPdsIV2I7Vs0KL2sEWvuNy7yjsYHjHT4ObD/mbSsgUWqj bwMZWfTzMMimfktQ1ShUdIaDBuodZlnKL9iS58aztZ26Pl7SMJQeS+C2pCnjXFXoO1kK 4n54MSUKbmiD6NLH6bmx59x6Qn1pidLm0YbBLxV7ZDJI2MbNmw5TzHXV9437+yxNpsrL xhkQFtOsfDNo0Cgy8Mv+/WIR/Fyvx/K8OZH01uaHkuwAOBeCel7nEhIUrwPLK1juoEKg kpng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744742149; x=1745346949; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=loMTrZDHzmCOUyxOFOgREZ3HVqSK503Bi09wuZfwXGo=; b=rawv83M8rs9GXAUR3jvbVib0pk9Wu54ylzedZ90KoanCjvaZcgPboMDg4hVtfUXa6Z cZlfGSy749PWfksRHFv4oN9OlZbGgj4GMKkmCD2F6bVj1XvBce90XxZKn87H8hedv7y0 OzgckLWrc1flAUKlhfBMIPPkAbj/Jq5ERKgDdbFUpINzCuE/SgZKeqoCRwYGWkFz21L5 26kEX1lzxyrzBmE9YHO5Y2HqbhSsjlBdVAYlk+xZ3hIitVu1rOx4qqxag2kxjzzc8kSQ /rEdAvZFpGh7aoZszRw4LJOThKhINdx7RMshw2QZM1j0MpIEX4NdkQqqY0aL2tYCOFyx iUAg== X-Gm-Message-State: AOJu0YwstiCPa89Gle6LyGGaf4htwA3jxvjAZPHwJVX5O1iiCPRpo8vb oP9TJxnFP+VReyFX4T5HHH57w1JF7AK1kx77Ae0J5lP2JcWVdOsOP/CWB7g6EKs= X-Gm-Gg: ASbGnctjOPZcvUInWgL2Lql4zK5almFnVO7OasqAKtqhxb2aXeiIP3i1BiAP7o7qdoR UqA6Ip3UDkQBrkNuNYIyxxqNh2LFOgFtzPHtEkgdTbOEQyUhvEBLLex419AeW7zeiEZHX2o0tFT 6jVGly+6MMjlrqtKKYxV362HYgwDv21PFgt8rkrdu3j4AhL16v/QGfqDoPz+MaQfGaZjt91puVF Z5Y6Ff4rUdqnYaOt7SafE7aTbc+2nT+dUUHoMxjWEnwCgulNv26XvWuNptBcGxr/OhbBEHNWyKn aEQFMk+aD1jAwRUy+DzFNokkALPxpXfEYG5Bw3K5tSsnpRhux6hfI3VcYDxzTAT1HsRst7I= X-Google-Smtp-Source: AGHT+IEpiHL9WpvnEaKhVzpBQQDAFm4zv+R+fr356rT/rttzS3KXsLt6OA6vwvmRhxZOZ4EqcfXnuA== X-Received: by 2002:a17:907:7203:b0:ac7:81bd:60e3 with SMTP id a640c23a62f3a-acb382b8d8fmr10018366b.27.1744742148873; Tue, 15 Apr 2025 11:35:48 -0700 (PDT) Received: from ez-X1.. (mob-194-230-145-83.cgn.sunrise.net. [194.230.145.83]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1ccd1adsm1148844266b.145.2025.04.15.11.35.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Apr 2025 11:35:48 -0700 (PDT) From: Enrico Zanda To: linux-i2c@vger.kernel.org Cc: andi.shyti@kernel.org, Enrico Zanda Subject: [PATCH 05/10] i2c: viapro: Replace dev_err() with dev_err_probe() in probe function Date: Tue, 15 Apr 2025 20:34:42 +0200 Message-ID: <20250415183447.396277-6-e.zanda1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250415183447.396277-1-e.zanda1@gmail.com> References: <20250415183447.396277-1-e.zanda1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This simplifies the code while improving log. Signed-off-by: Enrico Zanda --- drivers/i2c/busses/i2c-viapro.c | 33 +++++++++++++++------------------ 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/drivers/i2c/busses/i2c-viapro.c b/drivers/i2c/busses/i2c-viapro.c index 2cc7bba3b8bf..c58843609107 100644 --- a/drivers/i2c/busses/i2c-viapro.c +++ b/drivers/i2c/busses/i2c-viapro.c @@ -330,30 +330,27 @@ static int vt596_probe(struct pci_dev *pdev, SMBHSTCFG = 0x84; } else { /* no matches at all */ - dev_err(&pdev->dev, "Cannot configure " - "SMBus I/O Base address\n"); - return -ENODEV; + return dev_err_probe(&pdev->dev, -ENODEV, + "Cannot configure " + "SMBus I/O Base address\n"); } } vt596_smba &= 0xfff0; - if (vt596_smba == 0) { - dev_err(&pdev->dev, "SMBus base address " - "uninitialized - upgrade BIOS or use " - "force_addr=0xaddr\n"); - return -ENODEV; - } + if (vt596_smba == 0) + return dev_err_probe(&pdev->dev, -ENODEV, "SMBus base address " + "uninitialized - upgrade BIOS or use " + "force_addr=0xaddr\n"); found: error = acpi_check_region(vt596_smba, 8, vt596_driver.name); if (error) return -ENODEV; - if (!request_region(vt596_smba, 8, vt596_driver.name)) { - dev_err(&pdev->dev, "SMBus region 0x%x already in use!\n", - vt596_smba); - return -ENODEV; - } + if (!request_region(vt596_smba, 8, vt596_driver.name)) + return dev_err_probe(&pdev->dev, -ENODEV, + "SMBus region 0x%x already in use!\n", + vt596_smba); pci_read_config_byte(pdev, SMBHSTCFG, &temp); /* If force_addr is set, we program the new address here. Just to make @@ -375,10 +372,10 @@ static int vt596_probe(struct pci_dev *pdev, pci_write_config_byte(pdev, SMBHSTCFG, temp | 0x01); dev_info(&pdev->dev, "Enabling SMBus device\n"); } else { - dev_err(&pdev->dev, "SMBUS: Error: Host SMBus " - "controller not enabled! - upgrade BIOS or " - "use force=1\n"); - error = -ENODEV; + error = dev_err_probe(&pdev->dev, -ENODEV, + "SMBUS: Error: Host SMBus " + "controller not enabled! - " + "upgrade BIOS or use force=1\n"); goto release_region; } } From patchwork Tue Apr 15 18:34:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Enrico Zanda X-Patchwork-Id: 881728 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF2EA22256C for ; Tue, 15 Apr 2025 18:35:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744742154; cv=none; b=cGF5Lke3pfTCWHMXDKptpUVcSgIsVFn5nsPjQ3FxGt2SYE854J0WXZdbn8R+6lrGTPYphtwVAVypX219VdCRBSijf47cyjzuIr18UeoGrXMbWJxhN0DAhrpUvX++y702QQXWg6MM+IMOxwzqG/LCUqMgw2YodGggLGrpWJqhFY8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744742154; c=relaxed/simple; bh=P4a9PkA3kJVcwIZwq0G2YlBk39aIMMfgZWf2uZG563M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ArEPSon53+9vsnfv9HBx3ymuqqVozP6R9gSB74bNWxALKo5GvG9BrGnkDBRtTdKXGegpkEw84aSj6kW322tnuyYv1r6spSHybvyAd/0LGNgh2Psf8ZGcw5cw+K/XVC9TzzeBjh1f/LTLXwgqgqeB9zp1YzjbdaoaDuhx8ye5hc0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UQZTOYaE; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UQZTOYaE" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5e5e0caa151so10339664a12.0 for ; Tue, 15 Apr 2025 11:35:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744742151; x=1745346951; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eMFKvS13V24oEXpPbrmoE/yWPQaVsv1gzO+NMDMGLiM=; b=UQZTOYaEu0yePQw6FnXzB67gMK2R2RDoXzS1veg8fizEW6kQ7O4e6997wAt5qnlGV2 /K8+FJy/9EhM/vP3IITKFkLyepcmway6cEFoan8/9/tv5gkjzNDl6ku0Ym3GFIjgV50q d60c+sGuhCHCFJPVvALChjROW3z0GO6aw65NRa89PWU2CNffEZwPwI4O2E+Rg9vQvOB9 NkAGakJlhSWHTG9YslSXUPTafOOQBcmOrOOjQF7vANiL2J6d/vfCfSvLHEzsel5WpiGu tr8PItP6O0TOmU9pxYJF818EOj9CcPwjFl594YShCMUAXv9j6RC8DfMfG0G2fTMPW4y1 6KGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744742151; x=1745346951; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eMFKvS13V24oEXpPbrmoE/yWPQaVsv1gzO+NMDMGLiM=; b=iZ6nou+ZxD8Yf+1s8IfGOFDTEX7Us8J6zsIrK+4eqttdcuyTXe/9UZvDZ5k/78Jnl9 N400qet3OFWOi3Z0bdue4nF/94WUgBgKBSzMa8wg7Oo4ZOmCVxT2ixzvKW/341f3DaKO kDWFv8diIn8jXAP+AsY9iI2o5QW6FeWX7S9e0Xw2SI3sudZNVw4OD6p1x1Cls/9ppsAJ bZAuw9vFfa0Abb8myPuIjmgvWHC0DAZlngDoVWJaC6egpCdSAve0ZT1DpRc6bneC+qcH k2GKHpEPao0YX8MDTVbEP8rQNMkW+8VR6aO7ljBXyj/jeJFuPGc+e/c7spMtrLTLI0mf qKoQ== X-Gm-Message-State: AOJu0YxwR1204lt120eK8uoFC/fld6uZTX7UJQ6cq9Aa+LIdLIKJ2eqh aJGY4QabUb4u/HGMpyO+IGQ1kPLPQEr73duWZKFM+1b7xaYNrA51AC8FFUekJic= X-Gm-Gg: ASbGncsDx6QdmNZ4XCdG0jFPRQeFf1hYMFiooBK4sloA7c9zqmhMAfAt+fQnfsEks1g NhbUd5VmyBgSdfiPWCnapX0Hl3EIBS7yiPTz5YGGflohe4ulsvbe8d0XBnz7/Rbg67lnxjXz1Dd 2Foa2tOI/Mqc2vdxDexs7ZWyoR/qvFEg7jUEPYgoM9TftPXFWs5D1qULUX2x/MxDEOgZ4z1XOdE 1GU8eB1kKdtTsULfuOHSP13YA0cYuyEsPmRHS4V6kg/bBu2QStd0wgYx8NIRed7VzDPTJZZkg5O XMSBkc0b+wVGttzDKU0aR3Lbk+qdRfOs21v2XoYniiernXn6MHCxXXJxAkdy6GMXn7HFYHg= X-Google-Smtp-Source: AGHT+IGiQ4yih0Ecg/pRPDgZK6EKOJQ3fWoqc45FOGxsBcRESYgAGcGoBoJGpB9gbPL0RQ9K67B9rQ== X-Received: by 2002:a17:907:2cc4:b0:ac3:e4ea:de3b with SMTP id a640c23a62f3a-acb38310a14mr12266966b.27.1744742150836; Tue, 15 Apr 2025 11:35:50 -0700 (PDT) Received: from ez-X1.. (mob-194-230-145-83.cgn.sunrise.net. [194.230.145.83]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1ccd1adsm1148844266b.145.2025.04.15.11.35.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Apr 2025 11:35:50 -0700 (PDT) From: Enrico Zanda To: linux-i2c@vger.kernel.org Cc: andi.shyti@kernel.org, Enrico Zanda Subject: [PATCH 06/10] i2c: viperboard: Replace dev_err() with dev_err_probe() in probe function Date: Tue, 15 Apr 2025 20:34:43 +0200 Message-ID: <20250415183447.396277-7-e.zanda1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250415183447.396277-1-e.zanda1@gmail.com> References: <20250415183447.396277-1-e.zanda1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This simplifies the code while improving log. Signed-off-by: Enrico Zanda --- drivers/i2c/busses/i2c-viperboard.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/i2c/busses/i2c-viperboard.c b/drivers/i2c/busses/i2c-viperboard.c index 503e2f4d6f84..7523e7c02271 100644 --- a/drivers/i2c/busses/i2c-viperboard.c +++ b/drivers/i2c/busses/i2c-viperboard.c @@ -384,15 +384,13 @@ static int vprbrd_i2c_probe(struct platform_device *pdev) VPRBRD_USB_REQUEST_I2C_FREQ, VPRBRD_USB_TYPE_OUT, 0x0000, 0x0000, &vb_i2c->bus_freq_param, 1, VPRBRD_USB_TIMEOUT_MS); - if (ret != 1) { - dev_err(&pdev->dev, "failure setting i2c_bus_freq to %d\n", - i2c_bus_freq); - return -EIO; - } + if (ret != 1) + return dev_err_probe(&pdev->dev, -EIO, + "failure setting i2c_bus_freq to %d\n", + i2c_bus_freq); } else { - dev_err(&pdev->dev, - "invalid i2c_bus_freq setting:%d\n", i2c_bus_freq); - return -EIO; + return dev_err_probe(&pdev->dev, -EIO, + "invalid i2c_bus_freq setting:%d\n", i2c_bus_freq); } vb_i2c->i2c.dev.parent = &pdev->dev; From patchwork Tue Apr 15 18:34:44 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Enrico Zanda X-Patchwork-Id: 881474 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E7AA22256C for ; Tue, 15 Apr 2025 18:35:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744742156; cv=none; b=bROI/Uuw//rKCAIoe3C1zAz9ger6379IMoTcaW41BYSvJpuihoyOsJ8b28acojAspI+y7iCiplxpgj0+NxjcZayybxwvFR8dwKnly+YWkxcI4FmJbk3gbankIpn6NJAOv8Sp9EQQ+YmZdqm0lGqRQVXsefPLhwRJuxP96+w/rtI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744742156; c=relaxed/simple; bh=/tJ9D8GYIduoMXrjYR8EsTcRPQ1LwBvXEzL51rJUHj8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bvc5S+wgF0DL12vHvqUUDY63qn7ZlmSY6Z+kDYF2PyBvsmWaa83c+8H7MkvgmmLkBjJkaESftpEKU6iAf2Vw0s+xIPVY4HCV9zdHIaiuQU2NAbDMdv1MOEXG1+Jvn6GZ7pXAX1sStfR8MD0mgGjZKO+Qtl1Yct+pRDdQiRnJf8U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FSTblXXM; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FSTblXXM" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-ac29fd22163so945776266b.3 for ; Tue, 15 Apr 2025 11:35:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744742153; x=1745346953; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UTi67/6dmxqMBvEYnApsNKxoInxyPoaa+WYLOfehCLk=; b=FSTblXXM07tFbSaGu+xrUh52AGarQ5Tl/+3TavoWyfmXwn6UP4T/Lh8YkLgEnMD44g rscASHmON4AR/hT5u7czlxi9rTrA4V1d/6Ush2xksVqcqbp1i/NSd/xrXoqqHQJN740d wkou+op9ySLBzDXJOwsystF9sZidqAIh9nMe4EEgCi4JV+JEkXaFZXJiPWjbwjo7Gutd LjUD7gv1L37QM1lmaCXWIpPI2IL7GGr7/M+zcZgiPKzArPVFC0R0PkHyC4g5i/yEo9VM gZnwtq4VS/HJDTAXATQ2PJv/cu24MXJ9yz0ApmqchwOeXMjIVn7cMXAIo/eAia+4YgE8 zXkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744742153; x=1745346953; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UTi67/6dmxqMBvEYnApsNKxoInxyPoaa+WYLOfehCLk=; b=sBjTjlfIYxeHXbyPNs4USVxXLAlsydIWBLguxGBE2mdXqXQuIL+JpP/uKBvEakb5SK eBh9cms2pzS1uth42vv7Grbj5VD972fTbua5vZMjiOvmRG1KTFwWgkFRqkAiL2eG48fT c3JxkHGWbWNSkb7lJnSMfTuA/32S4hiqJANItLP/khqRp+T5vSJ7OH5sxxrlSFjOhNiu Rejupz8o2TfFb8Xon8s0qpzN7wCKkeNSbcmxI5c5uQaAWUhgIQZeItXhTaQLGTxsra0I G2Fni/LR0QWElI2ITwU3vW8UOX7YNGoecW4GeOKM18sUo6LW5D5qrFNFJqV9vNX0eZQJ etDw== X-Gm-Message-State: AOJu0Yw2Wk59tR6XgspKstpkJHfM7D2Yj35p7crdPqX3GBwYItmaav8M 8+72VDcwGZj5gatumi7VSfMlVOBfLxP5UNZag4VGmh6MzyXbUfEo+96jHbN0QVE= X-Gm-Gg: ASbGncvkbjURzfzJ49a/kseoNS3LqyxUS8tBwVansB5lWB+uoCNcjpeVS3VznzpL5L9 3WW2GBCAcM7JM/VLvzh7R/rN2jIBX3uthVr9HQWy2uTiWCZsWDEeDa6ufUhsblhPArcf59l9vbH M4kuWIG1HNFzLMJz0XAgE1j1BI36HbJAD62mIW9Ul/c6KpRcQ2goTvk0FNSngiJfCFif7mtC0jd va48nh+LxO7rNeYVccHLjLkPsdE93p9xP4ceDKfSu8qj/iw7MeOQGWHcRY2ZNAQDiiEBr3vM9JO 82EO33GKg149OAwbMRC43hTab4femuymhxODCWRXkm/o/ohHGTjcMyQov7zwZ8gEn4MCKRQ= X-Google-Smtp-Source: AGHT+IFUYUEAp7a75i7XyWmMV2dJHpCM4Afodbb6OjiOcB8oLRw5NMd3jenRfO4s15xshVMtz+QO0g== X-Received: by 2002:a17:907:9693:b0:ac3:f1dc:f3db with SMTP id a640c23a62f3a-acb3822b8fcmr10905766b.13.1744742153227; Tue, 15 Apr 2025 11:35:53 -0700 (PDT) Received: from ez-X1.. (mob-194-230-145-83.cgn.sunrise.net. [194.230.145.83]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1ccd1adsm1148844266b.145.2025.04.15.11.35.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Apr 2025 11:35:52 -0700 (PDT) From: Enrico Zanda To: linux-i2c@vger.kernel.org Cc: andi.shyti@kernel.org, Enrico Zanda Subject: [PATCH 07/10] i2c: virtio: Replace dev_err() with dev_err_probe() in probe function Date: Tue, 15 Apr 2025 20:34:44 +0200 Message-ID: <20250415183447.396277-8-e.zanda1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250415183447.396277-1-e.zanda1@gmail.com> References: <20250415183447.396277-1-e.zanda1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This simplifies the code while improving log. Signed-off-by: Enrico Zanda --- drivers/i2c/busses/i2c-virtio.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-virtio.c b/drivers/i2c/busses/i2c-virtio.c index 2a351f961b89..9b05ff53d3d7 100644 --- a/drivers/i2c/busses/i2c-virtio.c +++ b/drivers/i2c/busses/i2c-virtio.c @@ -192,10 +192,9 @@ static int virtio_i2c_probe(struct virtio_device *vdev) struct virtio_i2c *vi; int ret; - if (!virtio_has_feature(vdev, VIRTIO_I2C_F_ZERO_LENGTH_REQUEST)) { - dev_err(&vdev->dev, "Zero-length request feature is mandatory\n"); - return -EINVAL; - } + if (!virtio_has_feature(vdev, VIRTIO_I2C_F_ZERO_LENGTH_REQUEST)) + return dev_err_probe(&vdev->dev, -EINVAL, + "Zero-length request feature is mandatory\n"); vi = devm_kzalloc(&vdev->dev, sizeof(*vi), GFP_KERNEL); if (!vi) From patchwork Tue Apr 15 18:34:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Enrico Zanda X-Patchwork-Id: 881727 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D05222256C for ; Tue, 15 Apr 2025 18:35:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744742159; cv=none; b=btKPpbD4MPBI90sZvAvWge8ZlO0wl9IUdXcdHOoj0hp5AK/h2BQAda4n8c8L/ECN2sOVVa8iWNrFI6Z+nomfuEAp2Xfh5h1JCBjeA8XZZ++rPyHvuPU/IsYQrJWw885C0UdGidBEFcA+Cvh1Y4W5YG/Xs2ahkO4/UAGR668OU8Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744742159; c=relaxed/simple; bh=y+CRr+GiYVZ/5maNcUQ6xt5fsEZnNSCJwGQqGM3YG08=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uLq0pooNAD3fLK7iFX2lNw2NhEAVKkALslKCGQnDQ+X9B+PogYeFb+6kjo8NOGKv57zVI637DJ97MmnUjVhUQcrqj3FJeqPKrhrrOC0xtqPxnqherv/jXauqrLg/w8oLGUf366zzJI4mgVCLntTxm1acvWwzR3puTERCsf7Fi44= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OBPhepYP; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OBPhepYP" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-ac34257295dso1106337466b.2 for ; Tue, 15 Apr 2025 11:35:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744742155; x=1745346955; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MpMdRmBpZFKtd62mzmIPIR4gQqjqZQRlAvxRyrE6pXU=; b=OBPhepYP3BtpwB8QeigCReXo1gL5aTFAC8sql/jpa/6Atvf5Ho1iCG+mJA31FiPaYc 3E5DKVlXaMqKdKsWYmQHvWI2coh71xTlZGX/hCnmSnAlbhxmfT5PNe29FvdkGmBj5e9c kyFLRDAh8qSoRt/19ABlh2V9ppn+EKY2dCoc/aumP3zJss/zrqIRVplBTgGmLXwKr0gu gnIHfLDMvef2z5Imyg3DfZ/1P2ovMJenla0FM4K+TkY9vTdTJv3hXFzoyHMcaruD5suQ vOo5o1fLgHzENhAjn6VUZib6FsQcTYg360BsH3lYOrJR5ZU9BChCJ3VACAtWyBT/Q2WF ZXUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744742155; x=1745346955; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MpMdRmBpZFKtd62mzmIPIR4gQqjqZQRlAvxRyrE6pXU=; b=ZfAWqUIzi86zfTDESC3SMVCMaqv0GLr7Z4Es5211kXlX4xNQVv2hxJCNUF5ecwEJis nB2ofw4GF16O9466At0xKosTBYOcwLtlS9d3K6o5EVBt46iuZNsLcgRnHY/Zpt4my1JZ VaabC8yPwVrFJ3OC8BfB+gxC1sJ8fdQoqiwLzLWu1RTrs9UyfaYdWxKkx8k4P1BABwEt mig4OXsM5ihfu6DVGO/nCHHviSC0+XAFBGCYjZHuR/pMMrwkEFVstRweLzXRHuoD5UsR kI7ilkDWRAqHOb0fUdkhDfhfzeGfDUQ7dsLbFWHIedaWcqBKqqcV9V3xvLVWrMa1Mk5T ul0Q== X-Gm-Message-State: AOJu0YxYMtw6A3gMVbJwjqGN7797j5MeCB+dTclvDa1GfPKCbisUVZ3o GD4iDbbKo1MA2Iq8CJZhSoar+Ur9+pJHDOlH6iQNbWrp3dUZH6YqXarNu/VW X-Gm-Gg: ASbGncu9aSrW92za6XY9+0OHiHwF2wJZB1e7WoeAexfXI0Vrfdu8KKNqRTWsYjvmtG0 S0lW3z6nlctuVvqkD7xwKVay0LniaTI8LeibwbNMTJ4pN1QNsyKJvffG3FE+osnKLqwd7PshY0H Xg20UmdGbfa9Axho/j57WAN1R82HSQzKhJWb1WvGVJNJzEY4uKl8ULgVs+pcuR7U/uHK1INUng4 r7AbMecHSbICpC/oprhiPg84VFYDxaVzdObyWCsBq993oWtQh6chBFYDcGEaPoMLpbQw51AyF9y Ysu2HOHo6muwnU4118pxSNu/LeP2Q/mkBg7Y9QycBBJldWayxxXJro7su9k3eXZ9TUVcO/Ll9OJ k4TMJlw== X-Google-Smtp-Source: AGHT+IGzWSZSjrC69Dkk01UK6Gs3szfFAprYngIblnXtEm/w0yyffRHjoJoY+Crm2Uj92w1SjSQ/pg== X-Received: by 2002:a17:907:db03:b0:ac2:baab:681c with SMTP id a640c23a62f3a-acb38310b43mr11508166b.28.1744742155162; Tue, 15 Apr 2025 11:35:55 -0700 (PDT) Received: from ez-X1.. (mob-194-230-145-83.cgn.sunrise.net. [194.230.145.83]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1ccd1adsm1148844266b.145.2025.04.15.11.35.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Apr 2025 11:35:54 -0700 (PDT) From: Enrico Zanda To: linux-i2c@vger.kernel.org Cc: andi.shyti@kernel.org, Enrico Zanda Subject: [PATCH 08/10] i2c: xgene-slimpro: Replace dev_err() with dev_err_probe() in probe function Date: Tue, 15 Apr 2025 20:34:45 +0200 Message-ID: <20250415183447.396277-9-e.zanda1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250415183447.396277-1-e.zanda1@gmail.com> References: <20250415183447.396277-1-e.zanda1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This simplifies the code while improving log. Signed-off-by: Enrico Zanda --- drivers/i2c/busses/i2c-xgene-slimpro.c | 27 ++++++++++++-------------- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a/drivers/i2c/busses/i2c-xgene-slimpro.c b/drivers/i2c/busses/i2c-xgene-slimpro.c index 663fe5604dd6..82cad0e9c384 100644 --- a/drivers/i2c/busses/i2c-xgene-slimpro.c +++ b/drivers/i2c/busses/i2c-xgene-slimpro.c @@ -457,10 +457,9 @@ static int xgene_slimpro_i2c_probe(struct platform_device *pdev) cl->tx_block = true; cl->rx_callback = slimpro_i2c_rx_cb; ctx->mbox_chan = mbox_request_channel(cl, MAILBOX_I2C_INDEX); - if (IS_ERR(ctx->mbox_chan)) { - dev_err(&pdev->dev, "i2c mailbox channel request failed\n"); - return PTR_ERR(ctx->mbox_chan); - } + if (IS_ERR(ctx->mbox_chan)) + return dev_err_probe(&pdev->dev, PTR_ERR(ctx->mbox_chan), + "i2c mailbox channel request failed\n"); } else { struct pcc_mbox_chan *pcc_chan; const struct acpi_device_id *acpi_id; @@ -480,17 +479,16 @@ static int xgene_slimpro_i2c_probe(struct platform_device *pdev) cl->tx_block = false; cl->rx_callback = slimpro_i2c_pcc_rx_cb; pcc_chan = pcc_mbox_request_channel(cl, ctx->mbox_idx); - if (IS_ERR(pcc_chan)) { - dev_err(&pdev->dev, "PCC mailbox channel request failed\n"); - return PTR_ERR(pcc_chan); - } + if (IS_ERR(pcc_chan)) + return dev_err_probe(&pdev->dev, PTR_ERR(pcc_chan), + "PCC mailbox channel request failed\n"); ctx->pcc_chan = pcc_chan; ctx->mbox_chan = pcc_chan->mchan; if (!ctx->mbox_chan->mbox->txdone_irq) { - dev_err(&pdev->dev, "PCC IRQ not supported\n"); - rc = -ENOENT; + rc = dev_err_probe(&pdev->dev, -ENOENT, + "PCC IRQ not supported\n"); goto mbox_err; } @@ -511,15 +509,14 @@ static int xgene_slimpro_i2c_probe(struct platform_device *pdev) pcc_chan->shmem_size, MEMREMAP_WB); } else { - dev_err(&pdev->dev, "Failed to get PCC comm region\n"); - rc = -ENOENT; + rc = dev_err_probe(&pdev->dev, -ENOENT, + "Failed to get PCC comm region\n"); goto mbox_err; } if (!ctx->pcc_comm_addr) { - dev_err(&pdev->dev, - "Failed to ioremap PCC comm region\n"); - rc = -ENOMEM; + rc = dev_err_probe(&pdev->dev, -ENOMEM, + "Failed to ioremap PCC comm region\n"); goto mbox_err; } } From patchwork Tue Apr 15 18:34:46 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Enrico Zanda X-Patchwork-Id: 881473 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E752204F73 for ; Tue, 15 Apr 2025 18:35:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744742160; cv=none; b=SH6AoP/RkFovvErG3EV82kKggiJFQbUIrS6P8hRW17eGJKEFZSabxHOxuHBpTQSO2Gg7bQZyEaQhfdZ2ZCbcEf9kt1Gyui81V5SmFfCkjLhWP6UDFEtb6nCXSH6dqRkcTtyujRj7KPWhmTC/h0jB/kRRDcnzPDCqRAC2QMeuO0Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744742160; c=relaxed/simple; bh=dxV8cSzj9WssYWag9PR/+gu64NGs1MqPWNg03L7kzR8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RJSQ81IMKLWPyI3huPSf7vGGsTmXeHdQmPmDTVjhTUixeNJWJNAhF2jDnBNYiagDoYq3clI/pxgsrOajviMgMJhanKI2oFgLasQIrAQmjz608V9DCsTlhof5JuxtvU3M3imjyyCiIpTP8pbwEAxDWzL5tzhIA+pJSUm2BExGGZo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XDvn8+10; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XDvn8+10" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-aca99fc253bso918243666b.0 for ; Tue, 15 Apr 2025 11:35:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744742157; x=1745346957; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=imnJIvmlPEYO5zwPP7FxPJDrPT2t9pZtdVbP//eKCUc=; b=XDvn8+100ChkqzYNY1NlvUPj3juD5e4VDIFMLG91tHk/oWimG0wQmJ8x3Zg68HpjeC F69FzGYhFVaHTfcCla7A0HGkeaCyPn8gCT0ccy/xCvHkX2r7SM/ZkrXf/5njPXDDKL4F S3G25SPR6gmaBvNKJA6nEHR3qo3u48aexv2AV2tAL/5JELhvFeTyHrOYGegw5JjWqCeQ 9meaOUqnoSgDxiUADnpRBxBNDKQei2R9VlGfhgFhp14OZR7I2WP+PfRhw88BnrlVywcO GT0D8DP/cB9QYu8ll1K2OMHf8FAfUvYovNdGM5TK2Adc5aG3VeoqK5uEMH2A9msD//NL 0MWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744742157; x=1745346957; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=imnJIvmlPEYO5zwPP7FxPJDrPT2t9pZtdVbP//eKCUc=; b=owA5+yCy4GCNUa1ZC/UqLh40VIFJQQOJEwtbYkZMRZyn22LnNw29AD4OwPtkp26Y8/ IrZYUk9dbBWsuXb+oC1FSiPE3oDCJs0j4tsT4uKfbxURzXWuUHjnBfuiCJe3SsPddCfA k6GnDBU0JlDmOsqMLtUSirym0YRn6Slbotbjq8W9UPpmL8oY4Bku8+fy/yBwRG71u9kl LE+LfcnPT2r1jls6TtwiiM1yohkPSqnUKzsqVYeG9GTPAX/7QMkdUU0I2ZWIFRhuq8bz UMrtX0q4gYDGkwR3LwaLrtTaamKSD62xO0Qf6+1jIOa7lB+SE0xoyfBbCw26efAawaQV Fs/A== X-Gm-Message-State: AOJu0Yx9StFjtyOq2hkfC0/Xhk2ckLy4Zxh1h/I5j8lto3EuFiwbgWJc o2bnkkWzlNlg9F/n7IIfPlsVcgVnJifgH9Vq+nEJU/1nMhTw2GAG+4vAVxFI X-Gm-Gg: ASbGncvrDT6blOGe7IYjPZf2o1zORfGwE1qsZdTAv+2X31zqiMBF7i+JTM57VYvB1Tx 2d5JYHUF+gAv5pBNLNo4c/hWVVirjU1evJtu2YQsc+Y+3XA01zBxSG2X9JyBHKguC8dkUcQfhEQ zqUVn4XM8AMn1V0SBYWNvM89//imV8KD90bqE0JEnvM+aL6HC2E4gcNmafSYkbCWyTN2c6yLP8m Eam0rXGfbve/nWiRloVjxyScAwhJ7V85j9/ySCD+podyLA1/UT26v8YDvclrAoTgIBKXehlqyZ/ BJQ1XPUJIXz9sLAfr0H2EL9aCXA3jB9sn8l4SYBY/eg1vZN9ysWpHqEIjBODI4p8BFa4rU4= X-Google-Smtp-Source: AGHT+IG+49RmF8hP8uaBg1JtEgSGb+5mlPDL8Wg2VQaKSpLJkXf9Ni2wIqbSRWix64qBv7CRMHCEew== X-Received: by 2002:a17:907:3d8c:b0:abf:4da0:28e3 with SMTP id a640c23a62f3a-acb3824ced0mr14160666b.18.1744742157213; Tue, 15 Apr 2025 11:35:57 -0700 (PDT) Received: from ez-X1.. (mob-194-230-145-83.cgn.sunrise.net. [194.230.145.83]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1ccd1adsm1148844266b.145.2025.04.15.11.35.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Apr 2025 11:35:56 -0700 (PDT) From: Enrico Zanda To: linux-i2c@vger.kernel.org Cc: andi.shyti@kernel.org, Enrico Zanda Subject: [PATCH 09/10] i2c: i2c-xiic: Replace dev_err() with dev_err_probe() in probe function Date: Tue, 15 Apr 2025 20:34:46 +0200 Message-ID: <20250415183447.396277-10-e.zanda1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250415183447.396277-1-e.zanda1@gmail.com> References: <20250415183447.396277-1-e.zanda1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This simplifies the code while improving log. Signed-off-by: Enrico Zanda --- drivers/i2c/busses/i2c-xiic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index dc1e46d834dc..6bc1575cea6c 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -1489,7 +1489,7 @@ static int xiic_i2c_probe(struct platform_device *pdev) pdev->name, i2c); if (ret < 0) { - dev_err(&pdev->dev, "Cannot claim IRQ\n"); + dev_err_probe(&pdev->dev, ret, "Cannot claim IRQ\n"); goto err_pm_disable; } @@ -1510,7 +1510,7 @@ static int xiic_i2c_probe(struct platform_device *pdev) ret = xiic_reinit(i2c); if (ret < 0) { - dev_err(&pdev->dev, "Cannot xiic_reinit\n"); + dev_err_probe(&pdev->dev, ret, "Cannot xiic_reinit\n"); goto err_pm_disable; } From patchwork Tue Apr 15 18:34:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Enrico Zanda X-Patchwork-Id: 881726 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D01B204F73 for ; Tue, 15 Apr 2025 18:36:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744742164; cv=none; b=KuRT7NTSZQw34p1GOxviP58jDyhkuZ0NUpBCMehumjhErbrbilrEDb/+uSzXyjVFW+apAnQMxZkDAlx5i9KPVW4/7jJcBJLvaq0y6KNbdrYMkdlxv/JFXYUAhn2+TeXvQpWSlfu4dLj0dtuWwIBDt7KUxu+804wSJM+TH4TER+4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744742164; c=relaxed/simple; bh=J0uYXjvD8Hpwh3hGZsfbLf46JUN/Psj+ddfsZVtxfyY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NDtqGQ/KppC95eEtJEDsGVEJufj+b0zcupySN2t/uuprmSfRgaEq1fmeGUZjaRyKcL+tXS0wA4Uy2+wgRjs7gtE/X4nrR82GGOrdnS5o1zwu5G16zAyPKBB8rW4AFNOMFKjTfD7Gc2+KY7MM1s4BLIXUg+Sk7KJec3DOxrjLXGE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=L2BZsJ0x; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L2BZsJ0x" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-5e61da95244so10176615a12.2 for ; Tue, 15 Apr 2025 11:36:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744742162; x=1745346962; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WfryQvIzOUjhiY3qFCzORTuNHV2UwDURqLCegwa/tk4=; b=L2BZsJ0x2wFgWrMYCdl+0msPguTTMOMWc9oQ9oy+sy1chJvVv6qE3MiLapYm4R8YYK NS6sgKWZLqqnbRZgXc+acmtLsQbT4RfWDnVOE8hhGQqAijqicS2KUEt+x8foa13bS35z HEcpEOUPPn1v/XmsIOTFf+qUQPStoV7+cQw0CoQL32iJoykTpMNi4zVCbQJDsOio9eLf N0ZSliexgRjJP5ivZC2rmQ/HiusPj0kYONyniG0x93/iFGV+/5DMbGANtsqUXNaD6luD OC3LdECdtyFPoWA5eQh/dZJUCEbrOiRGxCpqTYns828V4L9JPzWKapEVK0Aol/NUHJxz ZHrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744742162; x=1745346962; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WfryQvIzOUjhiY3qFCzORTuNHV2UwDURqLCegwa/tk4=; b=Ut5LgaPUUva44mKD4lkJTyxS7/x4XsVkr7L9vhNY8LpA2L/wd90qqH/lAnnw4J2w9o j694klnQ2YK6boY8QLCwar69vFrZCMx+mtGwC0wwy98V/8Yd4HIHAkohnXRW6lAYuQBi Jov3v4AlEc1OsL3Cbgnp9w9Q8oeOer4HWgR9+b21CwUsMJDsB+MStd3CyXBdkSrBqDMQ 3MkYt7SjQSgJYYerZsSGg0Bna8KfASUpY68TpsEb1AnRNorpM9eTOdDF9LMI3TItMmEP PmbWAEyaUmS6kf9/E5oUtagZ9GjmwTnohCrLlDveQNkTCHQp9Fr6rIRFHrIXk6lWUvAP p0Lg== X-Gm-Message-State: AOJu0YzgmwvZ5ii1m7o2cAlhEe901FcrGAEUZqVOZp9/ZOsc5xHum5pD hmYDYp+ctNfbYLrXu3+Q9hsULPIjhZwWd02HQJuyvAizDLWLy4GS8vVWuezQ X-Gm-Gg: ASbGncua5l8TrT/6adKM+NjNocleLMuoIeuM9zPOi7wJmH18yz0ZFBGRCmxM7fe/hR2 Z46PRld97EytjBohw2baO7qNZ9v9ht7gSnVKzKt/qsG1hAw8oOx9VT9QFEdnAMqsQSwEnUOmMhJ 9zo6h+oFqyYuhmNO3YNuW3F6ZikqDkteqNM9hCI94JW12f82qPCsFW9jd9YZ9dTMrTOZC6v6APg a2uawfLbyg4d635XqaFe4etekcFns4oy8B6bGhRSB3iQgrL9p8m158DBsgMTZ8EZukrMUQ7rCfj ppJsBcl4gswCNy4obiSJzO6ay65HCv8WTSeWE1E+Kr+PXJZZoI5PSuhgljG6KhscAWMcmBk= X-Google-Smtp-Source: AGHT+IHJGsewST6jnmj9yIH26E+Sgv/g2O/o6nz6W1pZh6kt6TBXhanEvsuCzFh2W+goShSflm9Q9g== X-Received: by 2002:a17:907:7e86:b0:abf:6cc9:7ef2 with SMTP id a640c23a62f3a-acb384e070emr7427666b.42.1744742161497; Tue, 15 Apr 2025 11:36:01 -0700 (PDT) Received: from ez-X1.. (mob-194-230-145-83.cgn.sunrise.net. [194.230.145.83]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1ccd1adsm1148844266b.145.2025.04.15.11.36.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Apr 2025 11:36:01 -0700 (PDT) From: Enrico Zanda To: linux-i2c@vger.kernel.org Cc: andi.shyti@kernel.org, Enrico Zanda Subject: [PATCH 10/10] i2c: scx200_acb: Replace dev_err() with dev_err_probe() in probe function Date: Tue, 15 Apr 2025 20:34:47 +0200 Message-ID: <20250415183447.396277-11-e.zanda1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250415183447.396277-1-e.zanda1@gmail.com> References: <20250415183447.396277-1-e.zanda1@gmail.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This simplifies the code while improving log. Signed-off-by: Enrico Zanda --- drivers/i2c/busses/scx200_acb.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/scx200_acb.c b/drivers/i2c/busses/scx200_acb.c index 4d6abd7e92ce..06cf221557f2 100644 --- a/drivers/i2c/busses/scx200_acb.c +++ b/drivers/i2c/busses/scx200_acb.c @@ -500,10 +500,8 @@ static int scx200_probe(struct platform_device *pdev) struct resource *res; res = platform_get_resource(pdev, IORESOURCE_IO, 0); - if (!res) { - dev_err(&pdev->dev, "can't fetch device resource info\n"); - return -ENODEV; - } + if (!res) + return dev_err_probe(&pdev->dev, -ENODEV, "can't fetch device resource info\n"); iface = scx200_create_dev("CS5535", res->start, 0, &pdev->dev); if (!iface)