From patchwork Wed Apr 16 18:52:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 881653 Delivered-To: patch@linaro.org Received: by 2002:adf:f902:0:b0:38f:210b:807b with SMTP id b2csp1129997wrr; Wed, 16 Apr 2025 11:52:48 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWzxTXwmT3b9ZV6nrkQRw8hUVeYQqAx48uL9YSmMbAe9nRqRov7eOobMhcVTAQuz4l6kGVYHw==@linaro.org X-Google-Smtp-Source: AGHT+IEO/DBvKIa710Eq4TFk3YeamHVy4vcoY6PnITXzkUdEdcjpS7qer0HaLTJw7AWY19E5Lu8v X-Received: by 2002:a05:620a:4093:b0:7c5:5859:1b81 with SMTP id af79cd13be357-7c919085cb1mr382108285a.57.1744829568610; Wed, 16 Apr 2025 11:52:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1744829568; cv=none; d=google.com; s=arc-20240605; b=Dv+2M4639NcG3ro+fVq37Hc+fPLmFDFvozrmaXankJcdx4dmpdfeBdAyrqWcj/DFaW jq/WaO4Vnm+PYiYT1awNfHY71LKbnAtKZ66yvYSOERFNhw0Z1PZHDaGb5mHKcJoYGQfj OD/jGYB0qWOVywL96XXenAB4WMskAYeZQzmVeOvsnPMSTpLIFpgEGVbIDptqvJZAiUXt oHYPPPyBxut46IdeCVN46KlcNWyKDt+m4doGolFBYnBSSoBcvrsaxCNAyA8XgQS33frH PbMd7rnT5gsIqy0plN4LRc40waAqzVogZkilrETOtEiqBzxBdo4C0qM6Bj8tPfMOs4P2 a87Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=Vv221GdfuK4r2mwZnrVqZmxXBkoRTIrQL78vHAzQy7c=; fh=2r3cWT6dFNE/5vGNi6/4KxKMlI6uK+sdjRSLNb0OVkY=; b=jSIs2DiRuk2hbBH/1ofecBqr04AF4md6OMxhxer2TfVQN753ukMIq/3j9+qRDIuQR5 Obs2gqDHeFO1qCfr2Hy+nw/BX0f8D2XRRXjlMb6l0/OE0GoOO3AX8OmCVntlkq7d1qhs ySUcB9PhVckBRk41OirnlzCeWioQyUmkWdPKgXLAt11xwQ5UppP9dsXLKV4Gu1quGMA0 N+yuGyXhQOMd9GEbBc3ulJ4A0ss0hLAlViUvKXxyuseJMd+92UjVC8gyVyuSXLuUOgVH 1YKeSUVRuf8BR5hDJKPNn7Hv6YDEhy7kQ+h/57iu7WURRwZhc8KrxPb6BkKs5AIEZnhn 4bqw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=q0SrLyI7; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7c7a8a4173fsi1431898985a.615.2025.04.16.11.52.48 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 Apr 2025 11:52:48 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=q0SrLyI7; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u57s8-0006lp-Et; Wed, 16 Apr 2025 14:52:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u57s5-0006lU-G4 for qemu-devel@nongnu.org; Wed, 16 Apr 2025 14:52:30 -0400 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u57s3-00026d-M9 for qemu-devel@nongnu.org; Wed, 16 Apr 2025 14:52:29 -0400 Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-224100e9a5cso114905ad.2 for ; Wed, 16 Apr 2025 11:52:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744829545; x=1745434345; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Vv221GdfuK4r2mwZnrVqZmxXBkoRTIrQL78vHAzQy7c=; b=q0SrLyI7haRAZi61ApI4irJjZtD4681FOkcgcRZhf+lUj+V7NFAzk26Gx4nSAlWBlI ZBEtL20vbOmmYhJDbldX7yWtVNWiPr/Yo/KyNleJaoIBnRTwLEh73sAgcJrU+x7q3DgH oELa04zl9I5nvYF6Sg5x9HPYY3juH7eqrNNaXd9D80hLuh6QxDq2JRa5z11swuSctcjM t4OrkDq+FiMQm/DmwjMJL4/nNYto+wDTFi28kOT/Px1bciKy5zgs3ij88YCFFPRgLRrd PO110wIz/c/EoVCNrCLRoysLeJQIkfXgVPM6PaRl2qsMMwEb8TRKw3aNS8aa1n7Wb8By 9pYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744829545; x=1745434345; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Vv221GdfuK4r2mwZnrVqZmxXBkoRTIrQL78vHAzQy7c=; b=UOjpccWuYYsCHyPBQdIMbHul/2Xk8eAJ4GhAxT2Mm6iNSagBNGbIDeSaZfw4KzRH8a MjsmWQ/xoGYlTWXrfdR/ul6YZC95C1bGnAfcByA9bxsu0hQ1/ChWALfB9HMq0vT3LEwr QwLnFGMBjO0qJe8aC6NUeQvH1QrgiVF0x6tWsIWNK/ftIeCBDfqcl+yNwebAkJ1mFEZW j7REXRZWxwwTH64OP8fOoo7LtWkufjHNfaXnZa5XXGlTLL7wzoUdiAOsrnCg+BJZsFcc oeX7qVsKDOzL/jqWVh5EHlHluXEHNXHwPEsXy6XdVme2WzVBg/QKpIVEScuteGFDA9UH z6QQ== X-Gm-Message-State: AOJu0YxmATTqpAPTJeHQKE3+YOGKrpWu4MxMAxmj7r73V7HKFUWO/8vp 4B17aNdtZsb4DBHDNIbLoQb/iT+aWq8q47bfLE3eSvyrNpzpB5qCBzgvpO0eB6jvLwoeN/1OEbV C X-Gm-Gg: ASbGncvgPIKwwMYHYqn2alRN2ag48eyLMaZ88oi5vLnaDszFIWM0nYDwexd1j0F7Q5z HjSx7TA7167nTTI6AEdo79wbYDV/81JQxOhHtxAqGLhFadw9sU13sQaCUn9VYgA/v6OLy5zt3jk Edz+kHNHaXtKCKs9QNQQyjUjzQxnLRpJKY1WL7wbLYndCNJK2XTIEKTP74HI0+HRA4xYfudb988 ZGff+tWkn0FQ22rHomAsizfu7euQ256sNJb+OcdRnJg9VxP2HaT8evOFwBmBykEht6UnDK86Xua xGiU0SS+aR/RasR9pFz4hJNwyVGToCMHh+NJLj8+MOZaBYXOJfA= X-Received: by 2002:a17:902:d4c7:b0:223:33cb:335f with SMTP id d9443c01a7336-22c358bc546mr36788745ad.3.1744829545140; Wed, 16 Apr 2025 11:52:25 -0700 (PDT) Received: from pc.. ([38.41.223.211]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22c33faac7asm17797435ad.137.2025.04.16.11.52.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 11:52:24 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: philmd@linaro.org, Phil Dennis-Jordan , Paolo Bonzini , Nicholas Piggin , Stefan Hajnoczi , Pierrick Bouvier Subject: [PATCH] system/main: comment lock rationale Date: Wed, 16 Apr 2025 11:52:18 -0700 Message-Id: <20250416185218.1654157-1-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::634; envelope-from=pierrick.bouvier@linaro.org; helo=mail-pl1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Signed-off-by: Pierrick Bouvier --- system/main.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/system/main.c b/system/main.c index 1c022067349..b8f7157cc34 100644 --- a/system/main.c +++ b/system/main.c @@ -69,8 +69,21 @@ int (*qemu_main)(void) = os_darwin_cfrunloop_main; int main(int argc, char **argv) { qemu_init(argc, argv); + + /* + * qemu_init acquires the BQL and replay mutex lock. BQL is acquired when + * initializing cpus, to block associated threads until initialization is + * complete. Replay_mutex lock is acquired on initialization, because it + * must be held when configuring icount_mode. + * + * On MacOS, qemu main event loop runs in a background thread, as main + * thread must be reserved for UI. Thus, we need to transfer lock ownership, + * and the simplest way to do that is to release them, and reacquire them + * from qemu_default_main. + */ bql_unlock(); replay_mutex_unlock(); + if (qemu_main) { QemuThread main_loop_thread; qemu_thread_create(&main_loop_thread, "qemu_main",