From patchwork Fri Apr 18 08:24:06 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: jesse huang X-Patchwork-Id: 882573 Received: from SEYPR02CU001.outbound.protection.outlook.com (mail-koreacentralazon11023078.outbound.protection.outlook.com [40.107.44.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C0A28462; Fri, 18 Apr 2025 08:24:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.44.78 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744964658; cv=fail; b=F+QRkalUzu0pwDcCTLBCHYw9eTggmJiWkpbZ+7F3FENY8TdgoBJGWQ8uwTsqQUC0RdZh1gSccUQjsfXCWzeo4nnO6lKj31W7d6NwjXHRw7Ai1n5+PPdG+QHzM0DN/UrdlfWR3enmtDnfgMYhQXcPHYFnouKNumApRT3L5Ajfwac= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744964658; c=relaxed/simple; bh=vkK3x84FTj8ngZqlnVqXwETSXk+CcCOiYxx38/kXXvI=; h=Message-ID:Date:From:Subject:To:Cc:Content-Type:MIME-Version; b=HmnFPE3QR8lCAvHHQfYlwmo/K0v/clc71s7ZaNi2D9K1g1p56ipLj4UQ5sjhVn6yoJUQBX153AgHBrAazVX1UxNQH01iLpfWC9iqX9f3Nqvb7hm58wLM3li9HeusMspwb0ssk4IegVuM+gmuVOsQiBTk/0112jd0NYf3E1iRSNI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=portwell.com.tw; spf=pass smtp.mailfrom=portwell.com.tw; dkim=pass (2048-bit key) header.d=fetCA905017.onmicrosoft.com header.i=@fetCA905017.onmicrosoft.com header.b=hWZwqAPi; arc=fail smtp.client-ip=40.107.44.78 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=portwell.com.tw Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=portwell.com.tw Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fetCA905017.onmicrosoft.com header.i=@fetCA905017.onmicrosoft.com header.b="hWZwqAPi" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sQooCDrReXtXR/jlUFInEuLVmkyJKl0Q/IWl2nVVAP2bnVIs5XxbnEGrQS2YD452xGPw0sDSonw7HIPglo5vYrAG+Utk0r4EOlCDGJnHl0ogjwnr5aIggM6amTNJQnFIRmHKqMfch8En9PVhhbsjK626KFhTpqCt+4zQ0AXg/iNuEs9HQvvjFgtLOJk5js/hTPeAj0H4kz+tYOn7sqO0B/rmJearThFkD9dqpu8zw2qhj/MQIYrhN8Qvj0Rnu19Z3/XkBS1WXt17obQGq+7SPjIzcxqoRWbhuR5MIsvz9KpOnYlYR3x9niC4Zvv1rEazzZFBx74Lgnl7/wP8F8ONHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QATOYv5yj+J+eH/5zpl2t0KmMS4nYy3yLUEt9+UFrDg=; b=hIPlR+ucVxWRUieCwmaGWG2joM+tCix0I/tDQNbaeVp0JPSREyNgGKzFA1+bGmsEmaQyCB5gnAyoVnlp13UH4y2238Eazn9sLnB+LdJP1Ie4j5uHFEjRhTFa8bxRvqaWX3GYKeov0CkzvhHh+zE0SROnUYaNyNURJiSNjuWe2ZvcPYPKmz2NMfxoPgetr/9DSRXN/Yy5meA/gVTCo82lzsQGy9apyB0VFw3ZJHNhQEz6ZkFU0tlKtWWJzBeeKyqF3Z+DRB8aUqHLKcCrjvh72bZ4Vblijx9GMSBpNlyj6PTs3HmRjbnY28jowb3asiewbrJ4LHddv/NhsVKirsxCYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=portwell.com.tw; dmarc=pass action=none header.from=portwell.com.tw; dkim=pass header.d=portwell.com.tw; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fetCA905017.onmicrosoft.com; s=selector1-fetCA905017-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QATOYv5yj+J+eH/5zpl2t0KmMS4nYy3yLUEt9+UFrDg=; b=hWZwqAPimrkgH8/JXvwfSqWByUhkTKrU1UBny7Iun9tqmw5aNNwVUhB3kx023pmfSCbbQcuXrSGUGa9fQRfn14S2UBREKggJUaKj92FjT+HQfgjkT5xSdae3NHAEov0kqRiAPONlbG/2m3PAFy/l2lAzxvTkE+Ix+IRUtYjw8im9XVxq7kk3TJEYc2aLmfHKMSHkkShpL9h7Rnlv+2Ip2YnG/JLQHYKNEvSeTow7Yf6NV5lOuCyC0DSHMB51d1buEcmtwcfXZUzBEW+CXCYfx5PB2cr+PEs7q64ZjiWm0XZsRnB/VXT95zUaS7wvjGhx2Hc5v4yLElEnJMDgFfg7XA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=portwell.com.tw; Received: from KL1PR06MB6395.apcprd06.prod.outlook.com (2603:1096:820:e7::10) by PUZPR06MB5675.apcprd06.prod.outlook.com (2603:1096:301:f9::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8632.33; Fri, 18 Apr 2025 08:24:10 +0000 Received: from KL1PR06MB6395.apcprd06.prod.outlook.com ([fe80::9235:5570:71b3:224]) by KL1PR06MB6395.apcprd06.prod.outlook.com ([fe80::9235:5570:71b3:224%4]) with mapi id 15.20.8655.025; Fri, 18 Apr 2025 08:24:10 +0000 Message-ID: <3fc723de-c7e9-4a03-852b-93d5538847d7@portwell.com.tw> Date: Fri, 18 Apr 2025 16:24:06 +0800 User-Agent: Mozilla Thunderbird From: Yen-Chi Huang Subject: [PATCH v5] platform/x86: portwell-ec: Add GPIO and WDT driver for Portwell EC To: hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com, linus.walleij@linaro.org, brgl@bgdev.pl, wim@linux-watchdog.org, linux@roeck-us.net Cc: linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org, jay.chen@canonical.com, jesse.huang@portwell.com.tw Content-Language: en-US X-ClientProxiedBy: PS2PR02CA0058.apcprd02.prod.outlook.com (2603:1096:300:5a::22) To KL1PR06MB6395.apcprd06.prod.outlook.com (2603:1096:820:e7::10) Precedence: bulk X-Mailing-List: linux-watchdog@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: KL1PR06MB6395:EE_|PUZPR06MB5675:EE_ X-MS-Office365-Filtering-Correlation-Id: 1b166aeb-2e34-43ab-e0ee-08dd7e5264bd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?q?2YoJlO6OXN1fkrMWQhNdmFzb6FSH3Q2?= =?utf-8?q?whffqdXmkRAnLeyTLdMfb0i9MP4tC2t1DbCYmWA4hnOt+7pTGdOx5UWedSPZV7xbD?= =?utf-8?q?Yzcf/X0K1qVTD8xPZU4RT6HNGR9tv/SoCALuQtPctc6NEjAIXbHvxPUmbRG2lbv0B?= =?utf-8?q?mnvzK08vA2bFWh688TgVDVa5+enK6lC0BXeYnl53uAJj+zyNgJvZJTZ8ZqDNYnmaw?= =?utf-8?q?AF/fUNmO+Nc8kq/Dj9MVYHENLAHozkiiNXAstDuyEENPQ+o3fVrnHFRIgiFHX5rBG?= =?utf-8?q?V3ANEq/g+0WFGVq357o5zdrtWk2PuJ/FJOCp+e7Bn95KpGxS54XBrRfBiMk5C5OFq?= =?utf-8?q?bSTLTzuqnkpn6DR+5FDw5CKYfBrPHnfa/pgTqrg/4oHXGX4UKlZcCxU1oY1M5ycv8?= =?utf-8?q?LiEKGLDIbk2PQNCOWL9YxvMSo1z7MQG3qQodJhcbPt3rtdrqXCbdU2UskIrMXHDDW?= =?utf-8?q?QdIqLeUGibovwunBrod9bWpuHAguQiANAs/UptaqrC1Hiyw6Z76KpIGMnVIJItoMD?= =?utf-8?q?uWYc9jYbrcR3PpxaKfQPYleFJAfXBpstCQNh8oUNGlEMkzp23YzPOH9NqXN0ZLDKQ?= =?utf-8?q?UAe9cNXCqjRR/VgGxQlKB9BR4DlEw765cwQ4eJWeKSW4yLBUEEq5Edz0HIp6LvXN2?= =?utf-8?q?O1cNDxsMDpZHyzSYzmRycbGglpo2VOmomtdbKm5AMixBYtU3pPuXyu6d3z9QByY84?= =?utf-8?q?m6rixGhAyAhiRfvcpvUsgyOtb4jdWOfusaeasEABIULeMHLRijg1FrxyRwMvA4l21?= =?utf-8?q?YRKwW2Z+jiuXw+CvZGTHdgtSqK6nMicj886rp0rObMxElZTrtkyr9sfTv+UE6bJf3?= =?utf-8?q?qshuyYlYkRe3yD10mdnvMlcPvv7ZvyU5kVx4CyTGSpNPVqV3TXqo3/YWcZbfEUkbe?= =?utf-8?q?CYBpMloZ/1ZNzxO5JmHIgl8CWJB+vBY2zo0kQTz1ytehc7mHzvUCGZBS85I7Zjs5u?= =?utf-8?q?U+tzKMKJ3N/9FoOnULhNyKJjeWhhBOOrwfM8SiqxphxG7lLHELt1hoD3q4wZM9Ko5?= =?utf-8?q?XodBsyt1Fxv0fM7cH1ueOmLkwXBN1VaTxAqli0AHadc8pGtBXYh7XWIWfp9FM44/c?= =?utf-8?q?p9UOsNhpdfdClVVXr2HIxu9l2NijgBCCjJt/N+5ukmCGarq1ZE4wyhpxQ3IvuVmEA?= =?utf-8?q?46Cpw3cpWIicXedqd8Un+qItJUv9TRM2nZ/bMaYsSdCBx79T6NCIBpkKbu24dskeb?= =?utf-8?q?dnM2o7kA+/tnT5RheiS4dB7e9F7TQhNavet7q4Pp6/RQ0GccnKjSW55NY28hg5Kg1?= =?utf-8?q?uk0I7/8jLiPoSup5M4acavFzEkXHkpO4HpRp2L69cR/dSp1PDA5Zwl3CqqbI4U1gw?= =?utf-8?q?LwvGSnmtIpDN4YqYKf8+ijr4KRPzlHkcAo6u0ivllup1YpIrcahna6w=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:KL1PR06MB6395.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(7416014)(376014)(366016)(1800799024); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?F8NkTOpatf8Y1oi1I7YkU4ApMu2h?= =?utf-8?q?0eje9lGEvueEkrbHKTNE6oATJuuh28vV0XMupnTPE3fkZs4fMEJfGIhcpH6QzQ6dq?= =?utf-8?q?4c6XVDQlwto8118kHrZxlGbt+2qnB8dLQvEAAvyYVCWAZ5gvLCveIGYYXXEkZjQVz?= =?utf-8?q?o9RIFSuYoNiMAJfDtVN92bBB8UCb1dSHN+zSXCvGCx0kKyhHit7DdJxvCUjxZLci3?= =?utf-8?q?wE1bE45VC8IZXnWM9gnZTcHMN9DO1Xms50n7Wa0zM4EEYT0sLGxz6d3/AMXQ3ouyf?= =?utf-8?q?8YFhWWx59N7WBoiFfC2i/CdZEv1tgEBsTutYqDz76uMafpCej3WA36Erd/Ibm7Dc/?= =?utf-8?q?vPSYU9NNS+wQt836j/di3FcwfcBnbsldREBAKhWVTSm9PdnyPXgdgqa9wR11hIrwE?= =?utf-8?q?2YHWahvE0rPIG+JAjBC9qk2UR3jzr2C6wQEE6yRf/wIa6X+jKsbUMqBUmKfMLGYjQ?= =?utf-8?q?mIXFMa1yLSN1baLvza3j9iM9elvj2m7yg6djUhlRlrMfIsk8V7/kVkw9Rs//Txlmz?= =?utf-8?q?nWUlxWxvuEgoNm4/CuKhXnJnCj18YRzifec3Fz4aUH2YvCVR2Uo+do3Bcl0vRD4hx?= =?utf-8?q?c+1Vv0Gj4rfN8zR1TL+ieo05E7hXCIo90CUUizd3xaONEUxGsAwoveL2BgMpD1DCW?= =?utf-8?q?5xOX5VBWgADlio2GEicKKajynJxb4iKXmJ09VJpkk1O5YL98BFV96sVoFP0wRhFyT?= =?utf-8?q?RlXsQ+5zjTqpslUyPvQY/XASybgEGpg6gfbvySM/vasqfadKTOnnk+gpAQ+9UIBFm?= =?utf-8?q?IRrVKnT71hPDpTNAMQPcin2i2hnnPuieLEy6wI3nwBHx4NKhkD4HOWFlsReiWZyFA?= =?utf-8?q?crIsvKqKBBqugV6mZKofGAlOPWaBx06/+NYyJoUmn5d5oqICJ3IxX7hDq9kW0kqEh?= =?utf-8?q?LaPk01FoTnBqj1TWPReiHnJN2+pdKezDgru+dMDbFBUaEhFg9fFRxkw5lqjfumDNt?= =?utf-8?q?mXrNG6i4zjIVkGv+HNG++CKSyRGeWkKYuZPeoS7xFd+QCoTHCekoE+3A6cQv56wN/?= =?utf-8?q?zVMJgoe0QzCqAmcVOxqbhscGbAMIfd9q2wAwl9z0IWVH3no7VHDUDrRZl1AX9jCqd?= =?utf-8?q?bbpTcPS2Hz7P+weHUvyysjYVFM3f5Hy67ya7oWWGtnN+M9S1nIoN0tL7MD70AgWDM?= =?utf-8?q?aW5/kUBPzn4wmNsHMZsDpV0GG+R1O9BLyWq+0OCtZ9NPdgUu2EO/gMsBC5Px7iRVj?= =?utf-8?q?dEcbQQUBZinPplHx10Xijjb86Hl/wH32SlgFl94+WnQLqgcRRSYjXPgKq544x2CYp?= =?utf-8?q?JrXyF9OCEjvnt5txPsxm8zRZhMxjeEI2mxY2TTyXE/unoJN+RvguQiA2X31HFtFsc?= =?utf-8?q?vrGF+ZYLFJOXDT2o6kMcmTQFjn7azO5S9tRAN9KTCSvgv1HSwoQY96nrMNe9ll071?= =?utf-8?q?WpgSPbqbxNZ4idKfwN0uyy4pJNBN+gs0X9MxRU4bE/+mOllM72gE7DCk3J+NK8vcj?= =?utf-8?q?mzfyogEU9Olfau6xzGW67YRLL0VHwfHAf3kH6irCxuS9OXti0J9kALcI5RQs7uSyt?= =?utf-8?q?82U3N8riPzspaGdPDDljR++V4lSyPAFIRw=3D=3D?= X-OriginatorOrg: portwell.com.tw X-MS-Exchange-CrossTenant-Network-Message-Id: 1b166aeb-2e34-43ab-e0ee-08dd7e5264bd X-MS-Exchange-CrossTenant-AuthSource: KL1PR06MB6395.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2025 08:24:10.1565 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5e309f7e-c3ee-443b-8668-97701d998b2c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TpJXGaPPYWqzfPCGbf4gPMBTY/K5p/P+6IIoV6QNdJLb7BaAVvEOhEgQIWeBFpQqWZvnu+N3DJgKCPfGtxJ+fBJW8IA1yMt0+m454XMSg40= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR06MB5675 Adds a driver for the ITE Embedded Controller (EC) on Portwell boards. It integrates with the Linux GPIO and watchdog subsystems to provide: - Control/monitoring of up to 8 EC GPIO pins. - Hardware watchdog timer with 1-255 second timeouts. The driver communicates with the EC via I/O port 0xe300 and identifies the hardware by the "PWG" firmware signature. This enables enhanced system management for Portwell embedded/industrial platforms. Signed-off-by: Yen-Chi Huang --- v4 -> v5: - Remove unnecessary `else` in pwec_gpio_get_direction() - Remove redundant watchdog timeout range validation - Rewrite pwec_wdt_get_timeleft() for rollover safety - Add missing comma in struct platform_driver and remove dummy parentheses - Fix devm_request_region() error message - Remove redundant pwec_dev null check in pwec_exit() V3->V4: - Added select WATCHDOG_CORE in Kconfig - Removed redundant retry logic from pwec_wdt_trigger() - Added pwec_wdt_write_timeout() helper - Handled second wraparound when reading min/sec in get_timeleft() - Reworked DMI check and force parameter logic - Fixed error handling for GPIO and platform device registration - Fixed typos, log messages, and formatting issues V2->V3: - Reworked based on review from Bartosz Golaszewski - Changed to use platform_driver and platform_device - Updated GPIO to use .set_rv() instead of .set() - Used devm_ helpers for request_region, GPIO and watchdog registration V1->V2: - Addressed review comments from Ilpo Jarvinen - Add DMI system check to avoid running on unsupported platforms - Add 'force' module parameter to override DMI matching - Use request_region() to claim I/O port access - Extend WDT timeout handling to use both minute and second registers - Increase WDT max timeout from 255s to 15300s - Use named defines for WDT enable/disable - Remove dummy pr_info() messages - Fix several coding style issues (comments, alignment, spacing) --- MAINTAINERS | 6 + drivers/platform/x86/Kconfig | 15 ++ drivers/platform/x86/Makefile | 3 + drivers/platform/x86/portwell-ec.c | 291 +++++++++++++++++++++++++++++ 4 files changed, 315 insertions(+) create mode 100644 drivers/platform/x86/portwell-ec.c diff --git a/MAINTAINERS b/MAINTAINERS index d5dfb9186962..c52f819786dc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -19132,6 +19132,12 @@ F: kernel/time/itimer.c F: kernel/time/posix-* F: kernel/time/namespace.c +PORTWELL EC DRIVER +M: Yen-Chi Huang +L: platform-driver-x86@vger.kernel.org +S: Maintained +F: drivers/platform/x86/portwell-ec.c + POWER MANAGEMENT CORE M: "Rafael J. Wysocki" L: linux-pm@vger.kernel.org diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 43407e76476b..3ceeb70897eb 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -779,6 +779,21 @@ config PCENGINES_APU2 To compile this driver as a module, choose M here: the module will be called pcengines-apuv2. +config PORTWELL_EC + tristate "Portwell Embedded Controller driver" + depends on X86 && HAS_IOPORT && WATCHDOG && GPIOLIB + select WATCHDOG_CORE + help + This driver provides support for the GPIO pins and watchdog timer + embedded in Portwell's EC. + + Theoretically, this driver should work on multiple Portwell platforms, + but it has only been tested on the Portwell NANO-6064 board. + If you encounter any issues on other boards, please report them. + + To compile this driver as a module, choose M here: the module + will be called portwell-ec. + config BARCO_P50_GPIO tristate "Barco P50 GPIO driver for identify LED/button" depends on GPIOLIB diff --git a/drivers/platform/x86/Makefile b/drivers/platform/x86/Makefile index 650dfbebb6c8..83dd82e04457 100644 --- a/drivers/platform/x86/Makefile +++ b/drivers/platform/x86/Makefile @@ -92,6 +92,9 @@ obj-$(CONFIG_XO1_RFKILL) += xo1-rfkill.o # PC Engines obj-$(CONFIG_PCENGINES_APU2) += pcengines-apuv2.o +# Portwell +obj-$(CONFIG_PORTWELL_EC) += portwell-ec.o + # Barco obj-$(CONFIG_BARCO_P50_GPIO) += barco-p50-gpio.o diff --git a/drivers/platform/x86/portwell-ec.c b/drivers/platform/x86/portwell-ec.c new file mode 100644 index 000000000000..fd01bb1bc69b --- /dev/null +++ b/drivers/platform/x86/portwell-ec.c @@ -0,0 +1,291 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * portwell-ec.c: Portwell embedded controller driver. + * + * Tested on: + * - Portwell NANO-6064 + * + * This driver provides support for GPIO and Watchdog Timer + * functionalities of the Portwell boards with ITE embedded controller (EC). + * The EC is accessed through I/O ports and provides: + * - 8 GPIO pins for control and monitoring + * - Hardware watchdog with 1-15300 second timeout range + * + * It integrates with the Linux GPIO and Watchdog subsystems, allowing + * userspace interaction with EC GPIO pins and watchdog control, + * ensuring system stability and configurability. + * + * (C) Copyright 2025 Portwell, Inc. + * Author: Yen-Chi Huang (jesse.huang@portwell.com.tw) + */ + +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define PORTWELL_EC_IOSPACE 0xe300 +#define PORTWELL_EC_IOSPACE_LEN SZ_256 + +#define PORTWELL_GPIO_PINS 8 +#define PORTWELL_GPIO_DIR_REG 0x2b +#define PORTWELL_GPIO_VAL_REG 0x2c + +#define PORTWELL_WDT_EC_CONFIG_ADDR 0x06 +#define PORTWELL_WDT_CONFIG_ENABLE 0x1 +#define PORTWELL_WDT_CONFIG_DISABLE 0x0 +#define PORTWELL_WDT_EC_COUNT_MIN_ADDR 0x07 +#define PORTWELL_WDT_EC_COUNT_SEC_ADDR 0x08 +#define PORTWELL_WDT_EC_MAX_COUNT_SECOND (255 * 60) + +#define PORTWELL_EC_FW_VENDOR_ADDRESS 0x4d +#define PORTWELL_EC_FW_VENDOR_LENGTH 3 +#define PORTWELL_EC_FW_VENDOR_NAME "PWG" + +static bool force; +module_param(force, bool, 0444); +MODULE_PARM_DESC(force, "Force loading EC driver without checking DMI boardname"); + +static const struct dmi_system_id pwec_dmi_table[] = { + { + .ident = "NANO-6064 series", + .matches = { + DMI_MATCH(DMI_BOARD_NAME, "NANO-6064"), + }, + }, + { } +}; +MODULE_DEVICE_TABLE(dmi, pwec_dmi_table); + +/* Functions for access EC via IOSPACE */ + +static void pwec_write(u8 index, u8 data) +{ + outb(data, PORTWELL_EC_IOSPACE + index); +} + +static u8 pwec_read(u8 address) +{ + return inb(PORTWELL_EC_IOSPACE + address); +} + +/* GPIO functions */ + +static int pwec_gpio_get(struct gpio_chip *chip, unsigned int offset) +{ + return (pwec_read(PORTWELL_GPIO_VAL_REG) & (1 << offset)) ? 1 : 0; +} + +static int pwec_gpio_set_rv(struct gpio_chip *chip, unsigned int offset, int val) +{ + u8 tmp = pwec_read(PORTWELL_GPIO_VAL_REG); + + if (val) + tmp |= (1 << offset); + else + tmp &= ~(1 << offset); + pwec_write(PORTWELL_GPIO_VAL_REG, tmp); + + return 0; +} + +static int pwec_gpio_get_direction(struct gpio_chip *chip, unsigned int offset) +{ + u8 direction = pwec_read(PORTWELL_GPIO_DIR_REG) & (1 << offset); + + if (direction) + return GPIO_LINE_DIRECTION_IN; + + return GPIO_LINE_DIRECTION_OUT; +} + +/* + * Changing direction causes issues on some boards, + * so direction_input and direction_output are disabled for now. + */ + +static int pwec_gpio_direction_input(struct gpio_chip *gc, unsigned int offset) +{ + return -EOPNOTSUPP; +} + +static int pwec_gpio_direction_output(struct gpio_chip *gc, unsigned int offset, int value) +{ + return -EOPNOTSUPP; +} + +static struct gpio_chip pwec_gpio_chip = { + .label = "portwell-ec-gpio", + .get_direction = pwec_gpio_get_direction, + .direction_input = pwec_gpio_direction_input, + .direction_output = pwec_gpio_direction_output, + .get = pwec_gpio_get, + .set_rv = pwec_gpio_set_rv, + .base = -1, + .ngpio = PORTWELL_GPIO_PINS, +}; + +/* Watchdog functions */ + +static void pwec_wdt_write_timeout(unsigned int timeout) +{ + pwec_write(PORTWELL_WDT_EC_COUNT_MIN_ADDR, timeout / 60); + pwec_write(PORTWELL_WDT_EC_COUNT_SEC_ADDR, timeout % 60); +} + +static int pwec_wdt_trigger(struct watchdog_device *wdd) +{ + pwec_wdt_write_timeout(wdd->timeout); + pwec_write(PORTWELL_WDT_EC_CONFIG_ADDR, PORTWELL_WDT_CONFIG_ENABLE); + + return 0; +} + +static int pwec_wdt_start(struct watchdog_device *wdd) +{ + return pwec_wdt_trigger(wdd); +} + +static int pwec_wdt_stop(struct watchdog_device *wdd) +{ + pwec_write(PORTWELL_WDT_EC_CONFIG_ADDR, PORTWELL_WDT_CONFIG_DISABLE); + return 0; +} + +static int pwec_wdt_set_timeout(struct watchdog_device *wdd, unsigned int timeout) +{ + wdd->timeout = timeout; + pwec_wdt_write_timeout(wdd->timeout); + + return 0; +} + +/* Ensure consistent min/sec read in case of second rollover. */ +static unsigned int pwec_wdt_get_timeleft(struct watchdog_device *wdd) +{ + u8 sec, min, old_min; + + do { + old_min = pwec_read(PORTWELL_WDT_EC_COUNT_MIN_ADDR); + sec = pwec_read(PORTWELL_WDT_EC_COUNT_SEC_ADDR); + min = pwec_read(PORTWELL_WDT_EC_COUNT_MIN_ADDR); + } while (min != old_min); + + return min * 60 + sec; +} + +static const struct watchdog_ops pwec_wdt_ops = { + .owner = THIS_MODULE, + .start = pwec_wdt_start, + .stop = pwec_wdt_stop, + .ping = pwec_wdt_trigger, + .set_timeout = pwec_wdt_set_timeout, + .get_timeleft = pwec_wdt_get_timeleft, +}; + +static struct watchdog_device ec_wdt_dev = { + .info = &(struct watchdog_info){ + .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING | WDIOF_MAGICCLOSE, + .identity = "Portwell EC watchdog", + }, + .ops = &pwec_wdt_ops, + .timeout = 60, + .min_timeout = 1, + .max_timeout = PORTWELL_WDT_EC_MAX_COUNT_SECOND, +}; + +static int pwec_firmware_vendor_check(void) +{ + u8 buf[PORTWELL_EC_FW_VENDOR_LENGTH + 1]; + u8 i; + + for (i = 0; i < PORTWELL_EC_FW_VENDOR_LENGTH; i++) + buf[i] = pwec_read(PORTWELL_EC_FW_VENDOR_ADDRESS + i); + buf[PORTWELL_EC_FW_VENDOR_LENGTH] = '\0'; + + return !strcmp(PORTWELL_EC_FW_VENDOR_NAME, buf) ? 0 : -ENODEV; +} + +static int pwec_probe(struct platform_device *pdev) +{ + int ret; + + if (!devm_request_region(&pdev->dev, PORTWELL_EC_IOSPACE, + PORTWELL_EC_IOSPACE_LEN, dev_name(&pdev->dev))) { + dev_err(&pdev->dev, "failed to get IO region\n"); + return -EBUSY; + } + + ret = pwec_firmware_vendor_check(); + if (ret < 0) + return ret; + + ret = devm_gpiochip_add_data(&pdev->dev, &pwec_gpio_chip, NULL); + if (ret < 0) { + dev_err(&pdev->dev, "failed to register Portwell EC GPIO\n"); + return ret; + } + + ret = devm_watchdog_register_device(&pdev->dev, &ec_wdt_dev); + if (ret < 0) { + dev_err(&pdev->dev, "failed to register Portwell EC Watchdog\n"); + return ret; + } + + return 0; +} + +static struct platform_driver pwec_driver = { + .driver = { + .name = "portwell-ec", + }, + .probe = pwec_probe, +}; + +static struct platform_device *pwec_dev; + +static int __init pwec_init(void) +{ + int ret; + + if (!dmi_check_system(pwec_dmi_table)) { + if (!force) + return -ENODEV; + pr_warn("force load portwell-ec without DMI check\n"); + } + + ret = platform_driver_register(&pwec_driver); + if (ret) + return ret; + + pwec_dev = platform_device_register_simple("portwell-ec", -1, NULL, 0); + if (IS_ERR(pwec_dev)) { + platform_driver_unregister(&pwec_driver); + return PTR_ERR(pwec_dev); + } + + return 0; +} + +static void __exit pwec_exit(void) +{ + platform_device_unregister(pwec_dev); + platform_driver_unregister(&pwec_driver); +} + +module_init(pwec_init); +module_exit(pwec_exit); + +MODULE_AUTHOR("Yen-Chi Huang "); +MODULE_DESCRIPTION("Portwell EC Driver"); +MODULE_LICENSE("GPL");