From patchwork Mon Apr 21 05:58:14 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amisha Jain X-Patchwork-Id: 883245 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC8962580E0 for ; Mon, 21 Apr 2025 05:58:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745215115; cv=none; b=fodL04JlYcEzD9PByCnjfTYnI9Yg8sWOj3P90BCzpj6EaFhThh1T/oOwftmBYRlJa2Sp3sdMNWzT0mSneAMvMZEETdZgXjAVMWzRj1wn6YRRNxoPW4EdsuiSGZBdIF33/f85pFQWJrGzTrAcwNg0100BNbrjeoPmM3D5A3b2P1w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745215115; c=relaxed/simple; bh=drVSs0OnMn/i4EbqepB3H6+1ipgbGHnRf03D5GK3Sn8=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=odg7ITd4sFjnlP4sl6CguTRbhGokVcm2uqjkIqr1sfmywgYJX2iMnq37VxHSNf9mmKxQqf49tCPg6kykGBNgfd1njmz8Vgze1x+etJAgwFOKHaxjbkCmD2CucqvovAuUwMjCTnSR67kQCZbMnARxcRVO2ATIQDx7unjqGB1udr4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=ELndVrNH; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="ELndVrNH" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53L0OA9D012752 for ; Mon, 21 Apr 2025 05:58:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=6NejW+GrER4Q46fdiElw6V PA7BEGtV2pFPZRWn4ufls=; b=ELndVrNHuyHrHO5Si4PilypGwUdGzyi7icXLtD 05B76PZ8Xe358nk677khNO5v9u6wbsyOWfwYw0pzUzAUgGzhm86SYbzWaUGCAP4T 92mQzydcsBtwPOnvPYC3dyxHknaBP0Au1LVmZY8U3/r72riRpIM2BXqR4AtA3qUt Gfjx3d28688L0/pbDxBBUasifzYUZ4rID4xgmNDa2c+H2t2VPZ1nEsQe1pjtZys/ 4SMREI3ySWUGlrCgSh5NAe/DAmCWgTmlFmN5QzS009uwp+W4HtaJhkoIMaJYv6Lj 3fJ+ykEkUculOSp3/en6g4PNnzALbnfwm5c8vJ8j0wbjapdg== Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4643wwk624-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 21 Apr 2025 05:58:32 +0000 (GMT) Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA01.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 53L5wVYD021327 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 21 Apr 2025 05:58:31 GMT Received: from hu-amisjain-hyd.qualcomm.com (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Sun, 20 Apr 2025 22:58:29 -0700 From: Amisha Jain To: CC: , , Subject: [RESEND PATCH v2] obex: Send response to client for Abort request Date: Mon, 21 Apr 2025 11:28:14 +0530 Message-ID: <20250421055814.96955-1-quic_amisjain@quicinc.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Authority-Analysis: v=2.4 cv=IpEecK/g c=1 sm=1 tr=0 ts=6805de88 cx=c_pps a=JYp8KDb2vCoCEuGobkYCKw==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=GEpy-HfZoHoA:10 a=XR8D0OoHHMoA:10 a=tyeDOegBlPOMNIItdlAA:9 X-Proofpoint-GUID: 3qfpC1STC0lX_tXJwI8zuVvGc8CQSees X-Proofpoint-ORIG-GUID: 3qfpC1STC0lX_tXJwI8zuVvGc8CQSees X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-21_02,2025-04-17_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 adultscore=0 clxscore=1015 bulkscore=0 malwarescore=0 suspectscore=0 priorityscore=1501 mlxscore=0 mlxlogscore=875 impostorscore=0 phishscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504210044 Incase of ongoing transfer, If the client sends Abort request, Server is not sending any response back. Ideally it should send OK or Success reponse code for the abort command. This is required in PTS testing for passing below testcases - 1) OPP/SR/OPH/BV-27-I To verify that a server can respond to an ABORT from the client during an OBEX operation. 2)FTP/SR/OTR/BV-02-C To verify that the pushed file is aborted normally. 3)PBAP/PSE/PDF/BV-06-I Verify that the PCE can abort a Phone Book object download from the PSE. 4)PBAP/PSE/PBF/BV-03-I Verify that the PCE can abort a vCard-listing object download from the PSE. --- obexd/src/obex.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/obexd/src/obex.c b/obexd/src/obex.c index 370bfac9e..0330d5a7c 100644 --- a/obexd/src/obex.c +++ b/obexd/src/obex.c @@ -389,6 +389,8 @@ static void transfer_complete(GObex *obex, GError *err, gpointer user_data) if (err != NULL) { error("transfer failed: %s\n", err->message); + if (strcmp(err->message, "Request was aborted") == 0) + os_set_response(os, 0); goto reset; }