From patchwork Sun May 4 14:45:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivaylo Ivanov X-Patchwork-Id: 887549 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F271224D7; Sun, 4 May 2025 14:45:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746369942; cv=none; b=EXAp7yhSlEa8rMEbMPJRuxPSig+bFbQYkakygbHdGkG9Mi+AMDH+e/1K/MIdE3Dq1sboNeilKmzpY+Y4o1iRCciYmRlB8cN1N5juqDNj9lvyFfayTgMtB/dZxWo3kzPhEBbApLa9MP0coNP/p3HnEGaijcEy6W73KBpBNddpCj4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746369942; c=relaxed/simple; bh=l4ZEs+cwcb8MF0o19kXrX6MFyG5dUJ2KQQHwtKW7bO0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WUB0X2jTqrBYPObCsDcTgxx2kB/E9rwJfo4ZK6rFyM6UHxpFMK2z63e03/sSOeWvWgrGy59n2slYD04e4+wCRi4cEwRAQoyNPgS1HXm8mgslVrlfEkga1dxEz/8hUvQWOID5n3nSwEwogJCgx6EKt7B64J1zXh+ZqiSFunyh8V4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cN4sCctJ; arc=none smtp.client-ip=209.85.208.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cN4sCctJ" Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-5e5cded3e2eso1491516a12.0; Sun, 04 May 2025 07:45:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746369939; x=1746974739; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IEe2Pk/caZE9tuS2ToysVXZZ+Dp3w9K8dh4ddcOqsJA=; b=cN4sCctJs2WKVoPsnqI4jgWmyf9pWsTBMF+fPupknm4gBM91Tpj/5V5vzrYHRHCesN FTysOqE14BgTyV7ug6yE3dgKc2EgIFTSPNG+8Gm4FZCyN4Vz2bJYp8vz/KIbjUei9sjM 0tJIwZB9yrP2IU6zUpN/nM1NgIUoqbyhJbNHB99+u2dZBxvG/Kw5wOi/pcVm1AOtGERg gg4/qWwlI4/W1O/qaTrPIsOUl7l/C4jUhaSCgXCyW1TvR+z+u6jUlbpwJhZpuLmmwd37 6ZXFMYXUD3/tVwLDSSfIDDcU0oPre9Af7psC4wux1g9zECO7IdqTZ28u6t20sXWncK9Q hZoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746369939; x=1746974739; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IEe2Pk/caZE9tuS2ToysVXZZ+Dp3w9K8dh4ddcOqsJA=; b=skCoSb9aUbCQDrYf9VzNutRQDSlw8gb9WxZojrx3zzEHyQMbSqoh02mBI9NAr+6SeG C2tYem+9t5xcai3VYDh/NfnqLEV5XrrJByGk2XN+ct8bX5M28ZGzeIY9wDpSBXBHuI4/ afO7+OQw/MOyvO/j6xprRX3rGwJc/Dj9OTDGJ4cCL92j9Q/y+D/fZSy7uvQIyybQoP8l 08cx15l9ikFvpcDnee95zpAp6JYLIsmN/ao8Wrh3mzcdy7AlAySItuMZM/p/B4i1hITg ww5ZVC/5cWnmGR4NAcGh1b+Y7OEEzbV4ksJgmARv40oGRwDGIOXNmSt9UDvMWEheRzn4 7Bdw== X-Forwarded-Encrypted: i=1; AJvYcCVVJ1rFwtOjtbj/6WriO7u+GoMiwZxJPv3dCDlWyqFeH5XzPDcwRlSx70Up/zdOFFlwYnoV6lZwa7xUt/4hfsV2F4I=@vger.kernel.org, AJvYcCVdOS5fdqeTQiNz85hCQ7+BkEBnq4sJ7rcKp0jGpJad2oGfbIZLyOmXrgAaM/4OAf/kzwbCP13AUd5j3V7/iw==@vger.kernel.org, AJvYcCWDKIWapacIibbRX4Gh+qgYFoB/emFQDFDZac6yLgqiQfTcLIwLLx7DYbMuf3sLzeZxw+hb1LmXU4UmNKVf@vger.kernel.org, AJvYcCX8tr7IReewjTtxPwvhq0rDU6+qXdlqwLkagbOnx6bSjH5wD5zTGyJ8yMRGqC/IVO987yd6xPWnDGmb@vger.kernel.org X-Gm-Message-State: AOJu0Yx/uEUoMnB2juKUdaUM41NQ9fIbEyQRNjosNeTrnluEeAY/0vck 55eqGRI2a9LHWS0VE8mEusioU6CZilZbsYOSUrRmN83y6/Ve+qDj X-Gm-Gg: ASbGncsNRK64EUG561z5LYMbQ0C4db9JWL7kgaYNULknEV8VGPJeFMEzSCPZtNddQCg ugteFq4uCTNxj6Nf2jmGeMJgzX6Rq/MxN1rCjqEsnFFZG8rnhHdp+UB+LXcZXUQOB8WB47rFBmv pYJ9bEVL/felr1vzvTq6Y693908rO27nz7HWztoBEUri+mOkya4GheKpOj6Pv3G+jmY/QAkkRCc KjSPzBQmLdeOpYTl92P/RfVBJgz2mPaBsddPg9/Xt4/1CNG5UHq9qbeCsHH+GRVLPlOXA6Sg99S R8T34q7VkuTpHU6nvRxAC1j6z/2xaSM9LI7Mi9yFZCmhRov9QX1nN76nZ4KRj64sy7KjvsU4gGS RK5lgDsBBq5eBsU20 X-Google-Smtp-Source: AGHT+IHh3dzRLVQA3aqoCJ5MBNUWOlX9P7YffHdktJwcGumENYOkPRjsZ41k9Z0xC0aeBgpqQPMNSg== X-Received: by 2002:a05:6402:1ecb:b0:5e4:c119:7ff8 with SMTP id 4fb4d7f45d1cf-5faa7f3170bmr4343957a12.4.1746369938837; Sun, 04 May 2025 07:45:38 -0700 (PDT) Received: from ivaylo-T580.. (91-139-201-119.stz.ddns.bulsat.com. [91.139.201.119]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5faecf59d31sm1147258a12.77.2025.05.04.07.45.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 May 2025 07:45:38 -0700 (PDT) From: Ivaylo Ivanov To: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Philipp Zabel , Marek Szyprowski , Sylwester Nawrocki Cc: linux-phy@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 01/10] dt-bindings: phy: add exynos2200 eusb2 phy support Date: Sun, 4 May 2025 17:45:18 +0300 Message-ID: <20250504144527.1723980-2-ivo.ivanov.ivanov1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250504144527.1723980-1-ivo.ivanov.ivanov1@gmail.com> References: <20250504144527.1723980-1-ivo.ivanov.ivanov1@gmail.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Document the exynos2200 eUSB2 compatible. Unlike the currently documented Qualcomm SoCs, the driver doesn't make use of reset lines for reset control and uses more clocks. Signed-off-by: Ivaylo Ivanov Reviewed-by: Krzysztof Kozlowski --- .../phy/samsung,exynos2200-eusb2-phy.yaml | 80 +++++++++++++++++++ 1 file changed, 80 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/samsung,exynos2200-eusb2-phy.yaml diff --git a/Documentation/devicetree/bindings/phy/samsung,exynos2200-eusb2-phy.yaml b/Documentation/devicetree/bindings/phy/samsung,exynos2200-eusb2-phy.yaml new file mode 100644 index 000000000..5e7e1bc2e --- /dev/null +++ b/Documentation/devicetree/bindings/phy/samsung,exynos2200-eusb2-phy.yaml @@ -0,0 +1,80 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/phy/samsung,exynos2200-eusb2-phy.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Samsung Exynos2200 eUSB2 phy controller + +maintainers: + - Ivaylo Ivanov + +description: + Samsung Exynos2200 eUSB2 phy, based on Synopsys eUSB2 IP block, supports + LS/FS/HS usb connectivity. + +properties: + compatible: + enum: + - samsung,exynos2200-eusb2-phy + + reg: + maxItems: 1 + + "#phy-cells": + const: 0 + + clocks: + items: + - description: Reference clock + - description: Bus (APB) clock + - description: Control clock + + clock-names: + items: + - const: ref + - const: bus + - const: ctrl + + resets: + maxItems: 1 + + phys: + maxItems: 1 + description: + Phandle to eUSB2 to USB 2.0 repeater + + vdd-supply: + description: + Phandle to 0.88V regulator supply to PHY digital circuit. + + vdda12-supply: + description: + Phandle to 1.2V regulator supply to PHY refclk pll block. + +required: + - compatible + - reg + - "#phy-cells" + - clocks + - clock-names + - vdd-supply + - vdda12-supply + +additionalProperties: false + +examples: + - | + usb_hsphy: phy@10ab0000 { + compatible = "samsung,exynos2200-eusb2-phy"; + reg = <0x10ab0000 0x10000>; + #phy-cells = <0>; + + clocks = <&cmu_hsi0 7>, + <&cmu_hsi0 5>, + <&cmu_hsi0 8>; + clock-names = "ref", "bus", "ctrl"; + + vdd-supply = <&vreg_0p88>; + vdda12-supply = <&vreg_1p2>; + }; From patchwork Sun May 4 14:45:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivaylo Ivanov X-Patchwork-Id: 887233 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1B801C8632; Sun, 4 May 2025 14:45:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746369944; cv=none; b=igpQ8yQGikUPFozYGTLMx6DcH4phJCGdhxv+HEY5tNlcWMw7SofaVrZYNmPOIl+2CVuakS/76VQqGOpVqooVuRZ9zHsyJMAQdRZyPOhEPVjEKBQn8L+VbLYns8ZT9HN1Jc7dcjG7dxgFiy6yRb6UafE34c6eN5/2H5j0Wpujmic= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746369944; c=relaxed/simple; bh=hZE5Mp6GiZHRqhUj85+sXTi8Fs9hMZVjICkycr0tjoI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=W4M787cVeaEDva+qjdzNaeTBtA6lgv2/hphVRcT+cclFYMzrEn7gf3Vhv5G7hF0lFmXATx+lzJNt1RZKz13aXU1UzIKboEg6Wx9LlLR6pcaJYfmIkKawquuNHq1nmdv88XDrh+8Uzc1GLRxT0bJqBu0nqLpgh8/zZ2o8PAlV3h0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PojG0M4R; arc=none smtp.client-ip=209.85.208.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PojG0M4R" Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-5f63ac6ef0fso3848101a12.1; Sun, 04 May 2025 07:45:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746369941; x=1746974741; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7BSVq6jDIx0gJiVYHcgvtP/1XdtkFfYyKmECHdYtqDM=; b=PojG0M4R4Ks1GWFYNoGuHn4XDAqykiEIs17bHpsmLQhILv15nujmsY+HKrL5hvH6iv EdmY6khQhPEn4mXPTCT1VZ14rdcByiq71LXAY7UkFphPBQauIk/EMkO811DqHZEraIZU rD+zqm0Mrp+6xtt0vl9uh0770PcuEjj6shUrMLcZAfq3Yh7puwCrsgRHeYj/A+rhw6QR oZVYNwnzz83QZvKHQnA6gy3tG+ldkdX4UM9zNslvan010rN/k+aZpWFHyzVU5CQ4mySC Cxr2H2IlAu20OcPLjESrijimQ+4mN8qSkuOVkLK/vZnTdYb5grjmqdY4PIqw1COj9o+h cyEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746369941; x=1746974741; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7BSVq6jDIx0gJiVYHcgvtP/1XdtkFfYyKmECHdYtqDM=; b=CKVeYbFdbbEOc5RgqCIThru2TShI0hBaLvADTdsMDYpsNaIzWl1mYvYkey5dR14CwL s9IToIXTy8IYNTXrhVUHZ/8OWvtqxgklKPlBCeVoyaJSwqPjHuoDwSO7di4ifstRZ9FR ofIxFY/QQU1KufkYSRlV9vu5q0MuomafuoyY8eORarI46EWDGvsM9td7srLZNeSGPqYr 8iBAcFmwu7nxca1qGSfFJud1gQjcNVEGsEAxqP2RDXiq/uUDXHtwKYu+93zg4VIaMeGL GYZyy2yyFfNoCBL3sLAuF9nNr1NWwTYig3MVNTrAqpfYfL7d5s+9EPzgbwRrvh660eue 3Oag== X-Forwarded-Encrypted: i=1; AJvYcCUcoDBtpj48VbWKZGWPN4Q5s56E7cDS9nRxgKxMrG5kMnY7B8TwdMnh6mgIBfLJuRaLQjhLCgHCYYFm@vger.kernel.org, AJvYcCUpmctwKRkaxgz+WQrTqhkLkv0wIqBCH/0WWY6LNfsGchH7+2VNq6I+tTMWU4LGLorqPYU2czP3Y6a9Lvq7Hrv/qVM=@vger.kernel.org, AJvYcCUvzCHZAzYBUdS2TsjwLgY9h+R11Q0CwAOClYS+v8l1D2oNRCcL8LwpBSsaw10H6VQZ/ac2DSEXa0TVQQ9X@vger.kernel.org, AJvYcCVnDzsTDxq+oDZt2y1sxoVZw+C8ksfEgSfwtK4XS3zd3sUVLTdmIWrEz0oqMNOpt+jkQfEv8bPIDn+iJCJKZQ==@vger.kernel.org X-Gm-Message-State: AOJu0YxF7LDRfMnMwKyhWRyI1r2Sjhukg+oMbVuNmIlE/S3O5MMRtzhL B1oJ8T5kskgHJntvs7kfiCCSkCMaiNchxRs9GzvOZzYWGVA2GV5w X-Gm-Gg: ASbGnctjR5j9eyZQVcsnwfSvBYF7cpcbSdbbEmjoWhPZmJis3vv4xJdGNa/JlCp9NSQ HXmroWM8udEPqGTyyK09izyyCsLgHBie+3BIfFcKxWY/Cy0k85XLjy+IZpGSnHHrhVFeTs7E5C2 TGAK9HnazoUpytx1i1ZPe3TLM6T2aoDITgzsBcEf7aWhjsva23U+UVYTP8e6DOEzsQYIZ8oSDmw LWLuyeY+h0O5mYLxA1trxzVBkff/xRe4Tuo/y8SkkZDwUbyHoLaq/nqAzdZxYNTQchREZ+oqKaZ 54DWynGIBkhPb/gcZLhcNvK6Iru05H8TNCs4XUVN7+MK4xqKhUvgFcd7kdsOEk2ZBLbxgQd0DXf CYAeCabpmTRo+phY8 X-Google-Smtp-Source: AGHT+IGseBUdREIdCgIBWp9MzoQsy7P4bCBbCMZPLx3ZedRLperaW69nIVN6ZjiqGB8e6RpDelnxiw== X-Received: by 2002:a05:6402:3493:b0:5fa:e2bf:5491 with SMTP id 4fb4d7f45d1cf-5fae2bf550bmr2184616a12.11.1746369940623; Sun, 04 May 2025 07:45:40 -0700 (PDT) Received: from ivaylo-T580.. (91-139-201-119.stz.ddns.bulsat.com. [91.139.201.119]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5faecf59d31sm1147258a12.77.2025.05.04.07.45.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 May 2025 07:45:39 -0700 (PDT) From: Ivaylo Ivanov To: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Philipp Zabel , Marek Szyprowski , Sylwester Nawrocki Cc: linux-phy@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 02/10] dt-bindings: phy: samsung,usb3-drd-phy: add exynos2200 support Date: Sun, 4 May 2025 17:45:19 +0300 Message-ID: <20250504144527.1723980-3-ivo.ivanov.ivanov1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250504144527.1723980-1-ivo.ivanov.ivanov1@gmail.com> References: <20250504144527.1723980-1-ivo.ivanov.ivanov1@gmail.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Document support for Exynos2200. As the USBDRD 3.2 4nm controller consists of Synopsys eUSB2.0 phy and USBDP/SS combophy, which will be handled by external drivers, define only the bus clocked used by the link controller. Signed-off-by: Ivaylo Ivanov Reviewed-by: Krzysztof Kozlowski --- .../bindings/phy/samsung,usb3-drd-phy.yaml | 38 +++++++++++++++++-- 1 file changed, 34 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml index 27295acbb..4506c5801 100644 --- a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml +++ b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml @@ -26,6 +26,7 @@ properties: compatible: enum: - google,gs101-usb31drd-phy + - samsung,exynos2200-usb32drd-phy - samsung,exynos5250-usbdrd-phy - samsung,exynos5420-usbdrd-phy - samsung,exynos5433-usbdrd-phy @@ -33,24 +34,32 @@ properties: - samsung,exynos850-usbdrd-phy clocks: - minItems: 2 + minItems: 1 maxItems: 5 clock-names: - minItems: 2 + minItems: 1 maxItems: 5 description: | - At least two clocks:: + Typically two clocks: - Main PHY clock (same as USB DRD controller i.e. DWC3 IP clock), used for register access. - PHY reference clock (usually crystal clock), used for PHY operations, associated by phy name. It is used to determine bit values for clock settings register. For Exynos5420 this is given as 'sclk_usbphy30' - in the CMU. + in the CMU. It's not needed for Exynos2200. "#phy-cells": const: 1 + phys: + maxItems: 1 + description: + USBDRD-underlying high-speed PHY + + phy-names: + const: hs + port: $ref: /schemas/graph.yaml#/properties/port description: @@ -150,6 +159,27 @@ allOf: - vdda-usbdp-supply - vddh-usbdp-supply + - if: + properties: + compatible: + contains: + enum: + - samsung,exynos2200-usb32drd-phy + then: + properties: + clocks: + maxItems: 1 + clock-names: + items: + - const: phy + reg: + maxItems: 1 + reg-names: + maxItems: 1 + required: + - phys + - phy-names + - if: properties: compatible: From patchwork Sun May 4 14:45:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivaylo Ivanov X-Patchwork-Id: 887548 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E7411D8E10; Sun, 4 May 2025 14:45:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746369946; cv=none; b=LMAoiq908rn3NI4crzZkZ3e2XwvXuLD2zqgXg7kXcCe8xDkKQwZRBU0n3e37cEsS6nsBgLyZAhwnstgS9emIIEDFsMG+cVP3EW7bhP9K53VQsfIad+buoq5td33u3p7lT3U+vj3WBOHQAQKK7NC25xn9LWF8yInpPrjINj0gMY4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746369946; c=relaxed/simple; bh=aTojt8Dh7gclUi44xp/qnVu5croeoXM5gZOR4fhmKuc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BcaTcT4OxDpPfW7HDa059d+eh+eyxDCYUlQu8PwpDK06HbxYKFNBPOXhvfwqb7Jep/cVyKfAfy9cVu8zV1ukEneGlF9zUtkNSgri17ujyJDodJylll2XvyMhqAhxZFHQ4x+Djm0TpeFzKLapG/1tEd1l2noATnac2cijga7p3QE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=e/F15RW6; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e/F15RW6" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-5eb92df4fcbso6750619a12.0; Sun, 04 May 2025 07:45:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746369942; x=1746974742; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2usqzIFp+F+sor9mgGvMP54EUED928aPFjm+huTcOyg=; b=e/F15RW65VocdvoSWoQ5f0hSszMjbs54GIdhMCf/r+NBC04RNYxN1OHUaeyDRQ0UHw cjGEUm9Whno37bzshvxSYfX+txsBwram0//5azr+GHZ0/FN3np+SYapKFkMWE6jyImNy yCnRhp4nOyBPuVkeZdIi5xcCe5nZYnfWDPGLsSNfJebQJZBTpAiN2vNq5aSMQN47r8kX 047QcvTl/Cld+7bUc9bPvRojXKYsIc81/Et2B3dTrerpMHmEwDuKpObLOOqRgwStF7H3 pUPAtI6Ymg+bTM0svtxVzdWcP1JlXeqi9v1/Pt1nrv3EOyaYLt4/G2kf2P/uGCkHx91X 2vWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746369942; x=1746974742; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2usqzIFp+F+sor9mgGvMP54EUED928aPFjm+huTcOyg=; b=gCn3tDqidjMxXSbRbyGANWFG8ldWHp5z3yqXa9YT1K/GPxSOYtHvudFscMYVGKkEua X0iTcz0kA0bOMZEBBSi67Enn0uJhKCuwiSAjt1gCHrPIKw8yyQqFx0C54BEkae2KBjg9 28qpxPARANL2szNbwQ0/jp5oBTN2zy58APscZcmgRuXTn2YvYIBu2/yh3zc8LpoQMatn oM/BersjBJFeINAPTeC6Klhapdz9OC9mS2X/q+mU7xPghvkRTA2pG+AfBLXFsgcQOnwK wQLmg34aKzNCsj4J53hymxJ4zTYh5bPSnQ6aVH1+JQAFV4ePJPmCc/LVEakG/SghQYvi NpaA== X-Forwarded-Encrypted: i=1; AJvYcCUNnfUpUMj7i0oiq3PayuOzs+qRxkJ0xUr+Rnv1uwgsxDj9X1uLU6VlapjtCTJ2rrfYbIiDOfLeOerKeODR7w==@vger.kernel.org, AJvYcCUeKMaSQlavgBsYsIXRGRlutniZBR/DK/QL6yIscJJSnZHprdTnqNSCjlWByzNy+1epP49P45N/1DBcqpHa@vger.kernel.org, AJvYcCVCiNDMiOYusro5sITovtsSC1ZMO7xTfNe6x+g2wgT8boySRal3iFOl/Kdsyl8gtMBH6zy4Oimhdnd3tBpc4lvb1eg=@vger.kernel.org, AJvYcCWPr6kUUNDEcD0GZbKmCoG3Q8RLrxCaqVhJdPZjJW0Tr/tSpgTIY7Pnku/6GdlS7KqS4MEkA+4xZNCI@vger.kernel.org X-Gm-Message-State: AOJu0YyQwRK2kYFzN+yGJ8DdKUklaZ/i9+lrVq5dwht5vsSKFqTu2UjD R4Xi7LQNyitujD7LTtmWyx25xUr2Q+b8UWDDW2QiQwsXD1vWkEVU X-Gm-Gg: ASbGncv0c5li6MPpN1ouSjyDVqIW6kpPIXlTQyS+KA+ZUyTjiBxTSPnx/8fWisVGTjO hsy4qvZewX5M5mlGHsIFfhrZ+Jd+8r6nkqztABsYEBhSeTaZ2Zl/heUVofO3xCr9gTcaVf9n0Z/ dpeIzX2XvFXz6crsS7usQal7WJQwcxAcE7y6f6Goh+Kj3t6a6YH2+F0VtRy9RJPajlfSGwiqlNl 0j7pv0xmVdnJY8M7Bh7xtn4T8eCNdIrhRzQc1tbxxYH3T7GvPLvAW6Nvd+/fOnVlIjmdXsQQOCl FburvN3Tl5yzqhy+o3UVpce3CUF73G/JjZJiVyP35h4Gn6dPBvAr3bdEqz5kzPaXFh4xU0MDHGH j69CvxFI8impfydwS X-Google-Smtp-Source: AGHT+IFTIP5CBFY93DSwyT3Ei3OKqLDWTnScVRZxdsvibHCNV0wkkQGod1vGXCLNf31UK3SVtHlNWg== X-Received: by 2002:a05:6402:4408:b0:5f8:d6b1:c3f8 with SMTP id 4fb4d7f45d1cf-5fab05763b1mr3722707a12.8.1746369942217; Sun, 04 May 2025 07:45:42 -0700 (PDT) Received: from ivaylo-T580.. (91-139-201-119.stz.ddns.bulsat.com. [91.139.201.119]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5faecf59d31sm1147258a12.77.2025.05.04.07.45.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 May 2025 07:45:41 -0700 (PDT) From: Ivaylo Ivanov To: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Philipp Zabel , Marek Szyprowski , Sylwester Nawrocki Cc: linux-phy@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 03/10] phy: move phy-qcom-snps-eusb2 out of its vendor sub-directory Date: Sun, 4 May 2025 17:45:20 +0300 Message-ID: <20250504144527.1723980-4-ivo.ivanov.ivanov1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250504144527.1723980-1-ivo.ivanov.ivanov1@gmail.com> References: <20250504144527.1723980-1-ivo.ivanov.ivanov1@gmail.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 As not only Qualcomm, but also Samsung is using the Synopsys eUSB2 IP (albeit with a different register layout) in their newer SoCs, move the driver out of its vendor sub-directory and rename it to phy-snps-eusb2. Suggested-by: Krzysztof Kozlowski Signed-off-by: Ivaylo Ivanov Reviewed-by: Dmitry Baryshkov --- drivers/phy/Kconfig | 8 ++++++++ drivers/phy/Makefile | 1 + .../{qualcomm/phy-qcom-snps-eusb2.c => phy-snps-eusb2.c} | 0 drivers/phy/qualcomm/Kconfig | 9 --------- drivers/phy/qualcomm/Makefile | 1 - 5 files changed, 9 insertions(+), 10 deletions(-) rename drivers/phy/{qualcomm/phy-qcom-snps-eusb2.c => phy-snps-eusb2.c} (100%) diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index 8d58efe99..11c166204 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -43,6 +43,14 @@ config PHY_PISTACHIO_USB help Enable this to support the USB2.0 PHY on the IMG Pistachio SoC. +config PHY_SNPS_EUSB2 + tristate "SNPS eUSB2 PHY Driver" + depends on OF && (ARCH_QCOM || COMPILE_TEST) + select GENERIC_PHY + help + Enable support for the USB high-speed SNPS eUSB2 phy on select + SoCs. The PHY is usually paired with a Synopsys DWC3 USB controller. + config PHY_XGENE tristate "APM X-Gene 15Gbps PHY support" depends on HAS_IOMEM && OF && (ARCH_XGENE || COMPILE_TEST) diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile index e281442ac..c670a8dac 100644 --- a/drivers/phy/Makefile +++ b/drivers/phy/Makefile @@ -9,6 +9,7 @@ obj-$(CONFIG_PHY_CAN_TRANSCEIVER) += phy-can-transceiver.o obj-$(CONFIG_PHY_LPC18XX_USB_OTG) += phy-lpc18xx-usb-otg.o obj-$(CONFIG_PHY_XGENE) += phy-xgene.o obj-$(CONFIG_PHY_PISTACHIO_USB) += phy-pistachio-usb.o +obj-$(CONFIG_PHY_SNPS_EUSB2) += phy-snps-eusb2.o obj-$(CONFIG_USB_LGM_PHY) += phy-lgm-usb.o obj-$(CONFIG_PHY_AIROHA_PCIE) += phy-airoha-pcie.o obj-$(CONFIG_PHY_NXP_PTN3222) += phy-nxp-ptn3222.o diff --git a/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c b/drivers/phy/phy-snps-eusb2.c similarity index 100% rename from drivers/phy/qualcomm/phy-qcom-snps-eusb2.c rename to drivers/phy/phy-snps-eusb2.c diff --git a/drivers/phy/qualcomm/Kconfig b/drivers/phy/qualcomm/Kconfig index c1e0a11dd..ef14f4e33 100644 --- a/drivers/phy/qualcomm/Kconfig +++ b/drivers/phy/qualcomm/Kconfig @@ -125,15 +125,6 @@ config PHY_QCOM_QUSB2 PHY which is usually paired with either the ChipIdea or Synopsys DWC3 USB IPs on MSM SOCs. -config PHY_QCOM_SNPS_EUSB2 - tristate "Qualcomm SNPS eUSB2 PHY Driver" - depends on OF && (ARCH_QCOM || COMPILE_TEST) - select GENERIC_PHY - help - Enable support for the USB high-speed SNPS eUSB2 phy on Qualcomm - chipsets. The PHY is paired with a Synopsys DWC3 USB controller - on Qualcomm SOCs. - config PHY_QCOM_EUSB2_REPEATER tristate "Qualcomm SNPS eUSB2 Repeater Driver" depends on OF && (ARCH_QCOM || COMPILE_TEST) diff --git a/drivers/phy/qualcomm/Makefile b/drivers/phy/qualcomm/Makefile index 42038bc30..3851e28a2 100644 --- a/drivers/phy/qualcomm/Makefile +++ b/drivers/phy/qualcomm/Makefile @@ -15,7 +15,6 @@ obj-$(CONFIG_PHY_QCOM_QMP_USB) += phy-qcom-qmp-usb.o obj-$(CONFIG_PHY_QCOM_QMP_USB_LEGACY) += phy-qcom-qmp-usb-legacy.o obj-$(CONFIG_PHY_QCOM_QUSB2) += phy-qcom-qusb2.o -obj-$(CONFIG_PHY_QCOM_SNPS_EUSB2) += phy-qcom-snps-eusb2.o obj-$(CONFIG_PHY_QCOM_EUSB2_REPEATER) += phy-qcom-eusb2-repeater.o obj-$(CONFIG_PHY_QCOM_UNIPHY_PCIE_28LP) += phy-qcom-uniphy-pcie-28lp.o obj-$(CONFIG_PHY_QCOM_USB_HS) += phy-qcom-usb-hs.o From patchwork Sun May 4 14:45:21 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivaylo Ivanov X-Patchwork-Id: 887232 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC5581DE3AB; Sun, 4 May 2025 14:45:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746369948; cv=none; b=AfejmFFfWkdSBb5kA9oiUj0mgNpM1yeBnDkTNjnjppKQmp3S/pysElwRGFGpFzRIBwcOnDlAEm7iyl8lbrtBBBQTyqPOQP6Aho28GeVz1VaGXU+hC4z4AY5EPWhYzS6TsuzEXXNlGqNxEiQWPT2LyVE23X06gpW034ocYZvWxv8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746369948; c=relaxed/simple; bh=+OIIOz2hdxGL78KHMo4lMpF6RDi0hxMvLnncPwM8Y6c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ETDsLDpxkYcipIbmBsc/MwSAm7YK/GJDvrzITuUWhMsgVNLZf3XIhWQnY2j1klnT5UhvfSO/UNdytGrq1Wzf87dAtOcl1AUeRvXLJQqlYZE9jT3DpVrTEPhuJ7edfNlcg2CuU28fNr9tO1NCtbOptulNUiE9Ex7sBxPogz9FqiY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QkxFOY8G; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QkxFOY8G" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-5f3f04b5dbcso5378985a12.1; Sun, 04 May 2025 07:45:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746369944; x=1746974744; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=o5tSHqpXtWFPabFBWZB93znRyMEz1UyBewsCCfTVVvw=; b=QkxFOY8G2G/KOtCMV9Of4X90XV5oY3SJwWo4LOVzrw8xhDNlww4cO//QO9dSSnYS5s nGTRSm01v8qfBDG9h3fEv+7mfbvnnxLwhEkMuy9BJxVc3PSuX6h5begcdApwd1Bkt4+j HlYhaWM3kBLg55wPXIGDsxV/XNWRIAuuS9s8daubKXXvDxHYSAxydOQrmQjCWqghmUvo 09Vx/jFrR5KgMtJ/cYFZwx4GG1Xy7ExJz1L3D9mhjoW3LaCdBcPa8hVdc/K1n7TfDa57 NbZHhcbXw4mmNO0Y5UDr006JJoQgC4iC6Gk5kAhcMyhYOmUUChOKFG3BE8mAz5raUKbT hb4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746369944; x=1746974744; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o5tSHqpXtWFPabFBWZB93znRyMEz1UyBewsCCfTVVvw=; b=gYVWRXV10qTzNmc6fYh5WWqlKS1w7m2D4KbCfiw2ytRsxO9WHYiHTLkUoEteLwsH+E r5+XVc2QXeojNtqbm5+/L6f5ZX6mXDeSlY6jmG8u13B9NlUSFdsVcTutTcQawXzBu+qp H3I1ETwdmBnVJXwH3ZElUvh9yk8dg8JR4WbgenzrKMAiomgPxUEFo+SxaRTMDypz21Mb 99uJO+NKM5bzCZgnjrzTaVZ9KcgrJzNav66AqkFweORIQB8ar7pe+xkO1gDaZoEAvnJ/ 9MnlJWwJL6XbvHz/Gm81rSXTABt9By0FTgfydyNT0PIUQI+PXS8T0TOaf514YzEHgEZ5 VUuA== X-Forwarded-Encrypted: i=1; AJvYcCU77vSlQcOnV9avet4zacZ8yX/39eNZsRT6XnsKqoXX5kaulgYneKqheiZHzHVsEC8uLehkBk9tClhkhdVU@vger.kernel.org, AJvYcCUO8UxZ2jhyrn9WVp6aLJNt+p5k1kkek8GzGPS3q80uvReu94EaSjc4hwTM/9CUbQQpupafzu7Wz74X@vger.kernel.org, AJvYcCXZXhatK71pZIqXO2OaTuLWRikp5B6gn6nzB3/9jql5CuuFg0/iOyhXyYbKDXDaa0VtHIHDzw52wsA7t7sZlLA7xW0=@vger.kernel.org, AJvYcCXzV2SyDX+qU8Exl1As1oVUWc6MQrLt5NBw+d3FwhOuMdp7O2FFechZ7S1IiDP0LWqHE9NGiIqKNnNt81Sojg==@vger.kernel.org X-Gm-Message-State: AOJu0YwNA1r7a7CMBcSr+I1ZjuuPEAJB15Ffb0Tx2A7rjS5OaBNmWxIq VSB0FJI4lRHLRbtducF5RaZxZBGq3fxUALG+/jcvVHt/xFtOPD94 X-Gm-Gg: ASbGnctBho/V5s36woxmk7pv5hqfpzY2JXHeBp38M4k0KIuP9RkRGH15QmkIqNIUUqO Z605BWmNvPWFcc0AjVPV3+R0xtZCN+z50OViYBxYXjwkiobsTzcsrNwItkS6ycDKlsqIhKXHCYQ qYn2nv+BPaHiV2KPZwsjggicFDCyB7JqESaYW2CaBR1zhMhTK3IL9vGXiCP4sB3eOu1ACJcTXhC SVoc2Oo8EoQo7nJ7/a4Q7c/eW4RJy2AqYz6zF3pL+iTx1zgA7kXQCjmf/D8pvsfvPYupV2jlLG2 sr2RK4cNEF0Of6xxUfCfc7ll4eb4Up8JO4zDqjOrFr8c3/TtJM4k5pIeYMrPMi6ioyzIzwJE8YM LaHJLE3MAa2n+tp7o X-Google-Smtp-Source: AGHT+IGQBQrBO1qlxwwu+jJ6EzfLuutmdXd+dnHvvpsx5Z89dAJ0PMX5GR7in/J0mFrvVBGWiDk2LQ== X-Received: by 2002:a05:6402:40c2:b0:5ee:486:9d4b with SMTP id 4fb4d7f45d1cf-5faa8025c59mr4232708a12.34.1746369943770; Sun, 04 May 2025 07:45:43 -0700 (PDT) Received: from ivaylo-T580.. (91-139-201-119.stz.ddns.bulsat.com. [91.139.201.119]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5faecf59d31sm1147258a12.77.2025.05.04.07.45.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 May 2025 07:45:43 -0700 (PDT) From: Ivaylo Ivanov To: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Philipp Zabel , Marek Szyprowski , Sylwester Nawrocki Cc: linux-phy@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 04/10] phy: phy-snps-eusb2: refactor constructs names Date: Sun, 4 May 2025 17:45:21 +0300 Message-ID: <20250504144527.1723980-5-ivo.ivanov.ivanov1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250504144527.1723980-1-ivo.ivanov.ivanov1@gmail.com> References: <20250504144527.1723980-1-ivo.ivanov.ivanov1@gmail.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 As the driver now resides outside the phy subdirectory under a different name, refactor all definitions, structures and functions to explicitly specify what code is Qualcomm-specific and what is not. Signed-off-by: Ivaylo Ivanov Reviewed-by: Dmitry Baryshkov --- drivers/phy/phy-snps-eusb2.c | 256 +++++++++++++++++------------------ 1 file changed, 128 insertions(+), 128 deletions(-) diff --git a/drivers/phy/phy-snps-eusb2.c b/drivers/phy/phy-snps-eusb2.c index 1484691a4..e1b175f48 100644 --- a/drivers/phy/phy-snps-eusb2.c +++ b/drivers/phy/phy-snps-eusb2.c @@ -13,15 +13,15 @@ #include #include -#define USB_PHY_UTMI_CTRL0 (0x3c) +#define QCOM_USB_PHY_UTMI_CTRL0 (0x3c) #define SLEEPM BIT(0) #define OPMODE_MASK GENMASK(4, 3) #define OPMODE_NONDRIVING BIT(3) -#define USB_PHY_UTMI_CTRL5 (0x50) +#define QCOM_USB_PHY_UTMI_CTRL5 (0x50) #define POR BIT(1) -#define USB_PHY_HS_PHY_CTRL_COMMON0 (0x54) +#define QCOM_USB_PHY_HS_PHY_CTRL_COMMON0 (0x54) #define PHY_ENABLE BIT(0) #define SIDDQ_SEL BIT(1) #define SIDDQ BIT(2) @@ -30,15 +30,15 @@ #define FSEL_19_2_MHZ_VAL (0x0) #define FSEL_38_4_MHZ_VAL (0x4) -#define USB_PHY_CFG_CTRL_1 (0x58) +#define QCOM_USB_PHY_CFG_CTRL_1 (0x58) #define PHY_CFG_PLL_CPBIAS_CNTRL_MASK GENMASK(7, 1) -#define USB_PHY_CFG_CTRL_2 (0x5c) +#define QCOM_USB_PHY_CFG_CTRL_2 (0x5c) #define PHY_CFG_PLL_FB_DIV_7_0_MASK GENMASK(7, 0) #define DIV_7_0_19_2_MHZ_VAL (0x90) #define DIV_7_0_38_4_MHZ_VAL (0xc8) -#define USB_PHY_CFG_CTRL_3 (0x60) +#define QCOM_USB_PHY_CFG_CTRL_3 (0x60) #define PHY_CFG_PLL_FB_DIV_11_8_MASK GENMASK(3, 0) #define DIV_11_8_19_2_MHZ_VAL (0x1) #define DIV_11_8_38_4_MHZ_VAL (0x0) @@ -46,73 +46,73 @@ #define PHY_CFG_PLL_REF_DIV GENMASK(7, 4) #define PLL_REF_DIV_VAL (0x0) -#define USB_PHY_HS_PHY_CTRL2 (0x64) +#define QCOM_USB_PHY_HS_PHY_CTRL2 (0x64) #define VBUSVLDEXT0 BIT(0) #define USB2_SUSPEND_N BIT(2) #define USB2_SUSPEND_N_SEL BIT(3) #define VBUS_DET_EXT_SEL BIT(4) -#define USB_PHY_CFG_CTRL_4 (0x68) +#define QCOM_USB_PHY_CFG_CTRL_4 (0x68) #define PHY_CFG_PLL_GMP_CNTRL_MASK GENMASK(1, 0) #define PHY_CFG_PLL_INT_CNTRL_MASK GENMASK(7, 2) -#define USB_PHY_CFG_CTRL_5 (0x6c) +#define QCOM_USB_PHY_CFG_CTRL_5 (0x6c) #define PHY_CFG_PLL_PROP_CNTRL_MASK GENMASK(4, 0) #define PHY_CFG_PLL_VREF_TUNE_MASK GENMASK(7, 6) -#define USB_PHY_CFG_CTRL_6 (0x70) +#define QCOM_USB_PHY_CFG_CTRL_6 (0x70) #define PHY_CFG_PLL_VCO_CNTRL_MASK GENMASK(2, 0) -#define USB_PHY_CFG_CTRL_7 (0x74) +#define QCOM_USB_PHY_CFG_CTRL_7 (0x74) -#define USB_PHY_CFG_CTRL_8 (0x78) +#define QCOM_USB_PHY_CFG_CTRL_8 (0x78) #define PHY_CFG_TX_FSLS_VREF_TUNE_MASK GENMASK(1, 0) #define PHY_CFG_TX_FSLS_VREG_BYPASS BIT(2) #define PHY_CFG_TX_HS_VREF_TUNE_MASK GENMASK(5, 3) #define PHY_CFG_TX_HS_XV_TUNE_MASK GENMASK(7, 6) -#define USB_PHY_CFG_CTRL_9 (0x7c) +#define QCOM_USB_PHY_CFG_CTRL_9 (0x7c) #define PHY_CFG_TX_PREEMP_TUNE_MASK GENMASK(2, 0) #define PHY_CFG_TX_RES_TUNE_MASK GENMASK(4, 3) #define PHY_CFG_TX_RISE_TUNE_MASK GENMASK(6, 5) #define PHY_CFG_RCAL_BYPASS BIT(7) -#define USB_PHY_CFG_CTRL_10 (0x80) +#define QCOM_USB_PHY_CFG_CTRL_10 (0x80) -#define USB_PHY_CFG0 (0x94) +#define QCOM_USB_PHY_CFG0 (0x94) #define DATAPATH_CTRL_OVERRIDE_EN BIT(0) #define CMN_CTRL_OVERRIDE_EN BIT(1) -#define UTMI_PHY_CMN_CTRL0 (0x98) +#define QCOM_UTMI_PHY_CMN_CTRL0 (0x98) #define TESTBURNIN BIT(6) -#define USB_PHY_FSEL_SEL (0xb8) +#define QCOM_USB_PHY_FSEL_SEL (0xb8) #define FSEL_SEL BIT(0) -#define USB_PHY_APB_ACCESS_CMD (0x130) +#define QCOM_USB_PHY_APB_ACCESS_CMD (0x130) #define RW_ACCESS BIT(0) #define APB_START_CMD BIT(1) #define APB_LOGIC_RESET BIT(2) -#define USB_PHY_APB_ACCESS_STATUS (0x134) +#define QCOM_USB_PHY_APB_ACCESS_STATUS (0x134) #define ACCESS_DONE BIT(0) #define TIMED_OUT BIT(1) #define ACCESS_ERROR BIT(2) #define ACCESS_IN_PROGRESS BIT(3) -#define USB_PHY_APB_ADDRESS (0x138) +#define QCOM_USB_PHY_APB_ADDRESS (0x138) #define APB_REG_ADDR_MASK GENMASK(7, 0) -#define USB_PHY_APB_WRDATA_LSB (0x13c) +#define QCOM_USB_PHY_APB_WRDATA_LSB (0x13c) #define APB_REG_WRDATA_7_0_MASK GENMASK(3, 0) -#define USB_PHY_APB_WRDATA_MSB (0x140) +#define QCOM_USB_PHY_APB_WRDATA_MSB (0x140) #define APB_REG_WRDATA_15_8_MASK GENMASK(7, 4) -#define USB_PHY_APB_RDDATA_LSB (0x144) +#define QCOM_USB_PHY_APB_RDDATA_LSB (0x144) #define APB_REG_RDDATA_7_0_MASK GENMASK(3, 0) -#define USB_PHY_APB_RDDATA_MSB (0x148) +#define QCOM_USB_PHY_APB_RDDATA_MSB (0x148) #define APB_REG_RDDATA_15_8_MASK GENMASK(7, 4) static const char * const eusb2_hsphy_vreg_names[] = { @@ -121,7 +121,7 @@ static const char * const eusb2_hsphy_vreg_names[] = { #define EUSB2_NUM_VREGS ARRAY_SIZE(eusb2_hsphy_vreg_names) -struct qcom_snps_eusb2_hsphy { +struct snps_eusb2_hsphy { struct phy *phy; void __iomem *base; @@ -135,17 +135,17 @@ struct qcom_snps_eusb2_hsphy { struct phy *repeater; }; -static int qcom_snps_eusb2_hsphy_set_mode(struct phy *p, enum phy_mode mode, int submode) +static int snps_eusb2_hsphy_set_mode(struct phy *p, enum phy_mode mode, int submode) { - struct qcom_snps_eusb2_hsphy *phy = phy_get_drvdata(p); + struct snps_eusb2_hsphy *phy = phy_get_drvdata(p); phy->mode = mode; return phy_set_mode_ext(phy->repeater, mode, submode); } -static void qcom_snps_eusb2_hsphy_write_mask(void __iomem *base, u32 offset, - u32 mask, u32 val) +static void snps_eusb2_hsphy_write_mask(void __iomem *base, u32 offset, + u32 mask, u32 val) { u32 reg; @@ -158,65 +158,65 @@ static void qcom_snps_eusb2_hsphy_write_mask(void __iomem *base, u32 offset, readl_relaxed(base + offset); } -static void qcom_eusb2_default_parameters(struct qcom_snps_eusb2_hsphy *phy) +static void qcom_eusb2_default_parameters(struct snps_eusb2_hsphy *phy) { /* default parameters: tx pre-emphasis */ - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_CFG_CTRL_9, - PHY_CFG_TX_PREEMP_TUNE_MASK, - FIELD_PREP(PHY_CFG_TX_PREEMP_TUNE_MASK, 0)); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_9, + PHY_CFG_TX_PREEMP_TUNE_MASK, + FIELD_PREP(PHY_CFG_TX_PREEMP_TUNE_MASK, 0)); /* tx rise/fall time */ - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_CFG_CTRL_9, - PHY_CFG_TX_RISE_TUNE_MASK, - FIELD_PREP(PHY_CFG_TX_RISE_TUNE_MASK, 0x2)); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_9, + PHY_CFG_TX_RISE_TUNE_MASK, + FIELD_PREP(PHY_CFG_TX_RISE_TUNE_MASK, 0x2)); /* source impedance adjustment */ - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_CFG_CTRL_9, - PHY_CFG_TX_RES_TUNE_MASK, - FIELD_PREP(PHY_CFG_TX_RES_TUNE_MASK, 0x1)); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_9, + PHY_CFG_TX_RES_TUNE_MASK, + FIELD_PREP(PHY_CFG_TX_RES_TUNE_MASK, 0x1)); /* dc voltage level adjustement */ - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_CFG_CTRL_8, - PHY_CFG_TX_HS_VREF_TUNE_MASK, - FIELD_PREP(PHY_CFG_TX_HS_VREF_TUNE_MASK, 0x3)); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_8, + PHY_CFG_TX_HS_VREF_TUNE_MASK, + FIELD_PREP(PHY_CFG_TX_HS_VREF_TUNE_MASK, 0x3)); /* transmitter HS crossover adjustement */ - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_CFG_CTRL_8, - PHY_CFG_TX_HS_XV_TUNE_MASK, - FIELD_PREP(PHY_CFG_TX_HS_XV_TUNE_MASK, 0x0)); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_8, + PHY_CFG_TX_HS_XV_TUNE_MASK, + FIELD_PREP(PHY_CFG_TX_HS_XV_TUNE_MASK, 0x0)); } -static int qcom_eusb2_ref_clk_init(struct qcom_snps_eusb2_hsphy *phy) +static int qcom_eusb2_ref_clk_init(struct snps_eusb2_hsphy *phy) { unsigned long ref_clk_freq = clk_get_rate(phy->ref_clk); switch (ref_clk_freq) { case 19200000: - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_HS_PHY_CTRL_COMMON0, - FSEL_MASK, - FIELD_PREP(FSEL_MASK, FSEL_19_2_MHZ_VAL)); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_HS_PHY_CTRL_COMMON0, + FSEL_MASK, + FIELD_PREP(FSEL_MASK, FSEL_19_2_MHZ_VAL)); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_CFG_CTRL_2, - PHY_CFG_PLL_FB_DIV_7_0_MASK, - DIV_7_0_19_2_MHZ_VAL); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_2, + PHY_CFG_PLL_FB_DIV_7_0_MASK, + DIV_7_0_19_2_MHZ_VAL); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_CFG_CTRL_3, - PHY_CFG_PLL_FB_DIV_11_8_MASK, - DIV_11_8_19_2_MHZ_VAL); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_3, + PHY_CFG_PLL_FB_DIV_11_8_MASK, + DIV_11_8_19_2_MHZ_VAL); break; case 38400000: - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_HS_PHY_CTRL_COMMON0, - FSEL_MASK, - FIELD_PREP(FSEL_MASK, FSEL_38_4_MHZ_VAL)); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_HS_PHY_CTRL_COMMON0, + FSEL_MASK, + FIELD_PREP(FSEL_MASK, FSEL_38_4_MHZ_VAL)); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_CFG_CTRL_2, - PHY_CFG_PLL_FB_DIV_7_0_MASK, - DIV_7_0_38_4_MHZ_VAL); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_2, + PHY_CFG_PLL_FB_DIV_7_0_MASK, + DIV_7_0_38_4_MHZ_VAL); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_CFG_CTRL_3, - PHY_CFG_PLL_FB_DIV_11_8_MASK, - DIV_11_8_38_4_MHZ_VAL); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_3, + PHY_CFG_PLL_FB_DIV_11_8_MASK, + DIV_11_8_38_4_MHZ_VAL); break; default: @@ -224,15 +224,15 @@ static int qcom_eusb2_ref_clk_init(struct qcom_snps_eusb2_hsphy *phy) return -EINVAL; } - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_CFG_CTRL_3, - PHY_CFG_PLL_REF_DIV, PLL_REF_DIV_VAL); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_3, + PHY_CFG_PLL_REF_DIV, PLL_REF_DIV_VAL); return 0; } -static int qcom_snps_eusb2_hsphy_init(struct phy *p) +static int snps_eusb2_hsphy_init(struct phy *p) { - struct qcom_snps_eusb2_hsphy *phy = phy_get_drvdata(p); + struct snps_eusb2_hsphy *phy = phy_get_drvdata(p); int ret; ret = regulator_bulk_enable(ARRAY_SIZE(phy->vregs), phy->vregs); @@ -265,73 +265,73 @@ static int qcom_snps_eusb2_hsphy_init(struct phy *p) goto disable_ref_clk; } - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_CFG0, - CMN_CTRL_OVERRIDE_EN, CMN_CTRL_OVERRIDE_EN); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG0, + CMN_CTRL_OVERRIDE_EN, CMN_CTRL_OVERRIDE_EN); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_UTMI_CTRL5, POR, POR); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_UTMI_CTRL5, POR, POR); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_HS_PHY_CTRL_COMMON0, - PHY_ENABLE | RETENABLEN, PHY_ENABLE | RETENABLEN); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_HS_PHY_CTRL_COMMON0, + PHY_ENABLE | RETENABLEN, PHY_ENABLE | RETENABLEN); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_APB_ACCESS_CMD, - APB_LOGIC_RESET, APB_LOGIC_RESET); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_APB_ACCESS_CMD, + APB_LOGIC_RESET, APB_LOGIC_RESET); - qcom_snps_eusb2_hsphy_write_mask(phy->base, UTMI_PHY_CMN_CTRL0, TESTBURNIN, 0); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_UTMI_PHY_CMN_CTRL0, TESTBURNIN, 0); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_FSEL_SEL, - FSEL_SEL, FSEL_SEL); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_FSEL_SEL, + FSEL_SEL, FSEL_SEL); /* update ref_clk related registers */ ret = qcom_eusb2_ref_clk_init(phy); if (ret) - goto disable_ref_clk; + return ret; - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_CFG_CTRL_1, - PHY_CFG_PLL_CPBIAS_CNTRL_MASK, - FIELD_PREP(PHY_CFG_PLL_CPBIAS_CNTRL_MASK, 0x1)); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_1, + PHY_CFG_PLL_CPBIAS_CNTRL_MASK, + FIELD_PREP(PHY_CFG_PLL_CPBIAS_CNTRL_MASK, 0x1)); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_CFG_CTRL_4, - PHY_CFG_PLL_INT_CNTRL_MASK, - FIELD_PREP(PHY_CFG_PLL_INT_CNTRL_MASK, 0x8)); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_4, + PHY_CFG_PLL_INT_CNTRL_MASK, + FIELD_PREP(PHY_CFG_PLL_INT_CNTRL_MASK, 0x8)); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_CFG_CTRL_4, - PHY_CFG_PLL_GMP_CNTRL_MASK, - FIELD_PREP(PHY_CFG_PLL_GMP_CNTRL_MASK, 0x1)); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_4, + PHY_CFG_PLL_GMP_CNTRL_MASK, + FIELD_PREP(PHY_CFG_PLL_GMP_CNTRL_MASK, 0x1)); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_CFG_CTRL_5, - PHY_CFG_PLL_PROP_CNTRL_MASK, - FIELD_PREP(PHY_CFG_PLL_PROP_CNTRL_MASK, 0x10)); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_5, + PHY_CFG_PLL_PROP_CNTRL_MASK, + FIELD_PREP(PHY_CFG_PLL_PROP_CNTRL_MASK, 0x10)); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_CFG_CTRL_6, - PHY_CFG_PLL_VCO_CNTRL_MASK, - FIELD_PREP(PHY_CFG_PLL_VCO_CNTRL_MASK, 0x0)); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_6, + PHY_CFG_PLL_VCO_CNTRL_MASK, + FIELD_PREP(PHY_CFG_PLL_VCO_CNTRL_MASK, 0x0)); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_CFG_CTRL_5, - PHY_CFG_PLL_VREF_TUNE_MASK, - FIELD_PREP(PHY_CFG_PLL_VREF_TUNE_MASK, 0x1)); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_5, + PHY_CFG_PLL_VREF_TUNE_MASK, + FIELD_PREP(PHY_CFG_PLL_VREF_TUNE_MASK, 0x1)); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_HS_PHY_CTRL2, - VBUS_DET_EXT_SEL, VBUS_DET_EXT_SEL); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_HS_PHY_CTRL2, + VBUS_DET_EXT_SEL, VBUS_DET_EXT_SEL); /* set default parameters */ qcom_eusb2_default_parameters(phy); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_HS_PHY_CTRL2, - USB2_SUSPEND_N_SEL | USB2_SUSPEND_N, - USB2_SUSPEND_N_SEL | USB2_SUSPEND_N); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_HS_PHY_CTRL2, + USB2_SUSPEND_N_SEL | USB2_SUSPEND_N, + USB2_SUSPEND_N_SEL | USB2_SUSPEND_N); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_UTMI_CTRL0, SLEEPM, SLEEPM); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_UTMI_CTRL0, SLEEPM, SLEEPM); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_HS_PHY_CTRL_COMMON0, - SIDDQ_SEL, SIDDQ_SEL); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_HS_PHY_CTRL_COMMON0, + SIDDQ_SEL, SIDDQ_SEL); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_HS_PHY_CTRL_COMMON0, - SIDDQ, 0); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_HS_PHY_CTRL_COMMON0, + SIDDQ, 0); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_UTMI_CTRL5, POR, 0); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_UTMI_CTRL5, POR, 0); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_HS_PHY_CTRL2, - USB2_SUSPEND_N_SEL, 0); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_HS_PHY_CTRL2, + USB2_SUSPEND_N_SEL, 0); return 0; @@ -344,9 +344,9 @@ static int qcom_snps_eusb2_hsphy_init(struct phy *p) return ret; } -static int qcom_snps_eusb2_hsphy_exit(struct phy *p) +static int snps_eusb2_hsphy_exit(struct phy *p) { - struct qcom_snps_eusb2_hsphy *phy = phy_get_drvdata(p); + struct snps_eusb2_hsphy *phy = phy_get_drvdata(p); clk_disable_unprepare(phy->ref_clk); @@ -357,18 +357,18 @@ static int qcom_snps_eusb2_hsphy_exit(struct phy *p) return 0; } -static const struct phy_ops qcom_snps_eusb2_hsphy_ops = { - .init = qcom_snps_eusb2_hsphy_init, - .exit = qcom_snps_eusb2_hsphy_exit, - .set_mode = qcom_snps_eusb2_hsphy_set_mode, +static const struct phy_ops snps_eusb2_hsphy_ops = { + .init = snps_eusb2_hsphy_init, + .exit = snps_eusb2_hsphy_exit, + .set_mode = snps_eusb2_hsphy_set_mode, .owner = THIS_MODULE, }; -static int qcom_snps_eusb2_hsphy_probe(struct platform_device *pdev) +static int snps_eusb2_hsphy_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; struct device_node *np = dev->of_node; - struct qcom_snps_eusb2_hsphy *phy; + struct snps_eusb2_hsphy *phy; struct phy_provider *phy_provider; struct phy *generic_phy; int ret, i; @@ -405,7 +405,7 @@ static int qcom_snps_eusb2_hsphy_probe(struct platform_device *pdev) return dev_err_probe(dev, PTR_ERR(phy->repeater), "failed to get repeater\n"); - generic_phy = devm_phy_create(dev, NULL, &qcom_snps_eusb2_hsphy_ops); + generic_phy = devm_phy_create(dev, NULL, &snps_eusb2_hsphy_ops); if (IS_ERR(generic_phy)) { dev_err(dev, "failed to create phy %d\n", ret); return PTR_ERR(generic_phy); @@ -418,25 +418,25 @@ static int qcom_snps_eusb2_hsphy_probe(struct platform_device *pdev) if (IS_ERR(phy_provider)) return PTR_ERR(phy_provider); - dev_info(dev, "Registered Qcom-eUSB2 phy\n"); + dev_info(dev, "Registered Snps-eUSB2 phy\n"); return 0; } -static const struct of_device_id qcom_snps_eusb2_hsphy_of_match_table[] = { +static const struct of_device_id snps_eusb2_hsphy_of_match_table[] = { { .compatible = "qcom,sm8550-snps-eusb2-phy", }, { }, }; -MODULE_DEVICE_TABLE(of, qcom_snps_eusb2_hsphy_of_match_table); +MODULE_DEVICE_TABLE(of, snps_eusb2_hsphy_of_match_table); -static struct platform_driver qcom_snps_eusb2_hsphy_driver = { - .probe = qcom_snps_eusb2_hsphy_probe, +static struct platform_driver snps_eusb2_hsphy_driver = { + .probe = snps_eusb2_hsphy_probe, .driver = { - .name = "qcom-snps-eusb2-hsphy", - .of_match_table = qcom_snps_eusb2_hsphy_of_match_table, + .name = "snps-eusb2-hsphy", + .of_match_table = snps_eusb2_hsphy_of_match_table, }, }; -module_platform_driver(qcom_snps_eusb2_hsphy_driver); -MODULE_DESCRIPTION("Qualcomm SNPS eUSB2 HS PHY driver"); +module_platform_driver(snps_eusb2_hsphy_driver); +MODULE_DESCRIPTION("Synopsys eUSB2 HS PHY driver"); MODULE_LICENSE("GPL"); From patchwork Sun May 4 14:45:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivaylo Ivanov X-Patchwork-Id: 887547 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41C461DF250; Sun, 4 May 2025 14:45:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746369949; cv=none; b=ryh5vm+NMZAMaiH/JMdt/qAqliIDZD5EdBMEDPdk6wUHSisZynAvo+iX/crGXhFuVapu8NNv8uNmYhz8eXbk7T8GucdoaeeEm9YabpZxyOBn5UnM8nUWrhTMToeTtFcUP0zlINviMFObHbOOG+jqIFLlyQW2GmMA81a80n3NG0M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746369949; c=relaxed/simple; bh=2yy6EjiXxSAPVufYCa9ePZHsjODKDJ7K9wk6lj3SPyY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=O4qWid0QKv/NpJOWFcWU3RnHi+pStnvRPnNiWFV4MlDIUA7VAq2xGoQe2HcBWIyj7ehsXLiZ36XF5zA7j10mdJyUGjU1iwJ7bzF2p4v2x2E6MWuu0yahRxYjtc2I6JVnaqRCa9Q4Tva9zMX4uMYNfeVLKZMZ/dzPLWj/F04nehU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Zug1JI1W; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Zug1JI1W" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-5f6214f189bso6803796a12.2; Sun, 04 May 2025 07:45:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746369945; x=1746974745; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=S/2ZMg6LQNzP+WqoJGSl/J+PhbKTk0j0hhnJ6TPVsHY=; b=Zug1JI1WRnZ9t5TJQDWSxmic6H6Nu5Xab8TlVH7AlLvO3KNMyq1pv2N2Dn4nxKhnfr +LQ0DWBp5uibh6Ul6X6lowkkOhj/xrZ53+E/RMhLWssvVf+dMaRcS+WkIFqk6uf8cI9K cIJ50kN16QX/gWHZ9w/ydNo5oVT6tsXAwetdsOai5lTYm691AgBpkDCwFCYmuHvWq+Bi Fo0jhSfq81kwWpgKteiS+wXMehaImCoL07cK80oKwqfzGV9nhS7ec9qnnCp9M6cPqr0/ 74I9euDZkO1I66A/wY1jnzOhCCURgnDnNUesTeTZ009LSwnG+DWJ+FfmPlnYv8BiMrgw VK7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746369945; x=1746974745; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=S/2ZMg6LQNzP+WqoJGSl/J+PhbKTk0j0hhnJ6TPVsHY=; b=wyo29iTGe4eDc9zEAY7OZ+MzRPNl+HTziySqwj5eNM89YGOiKjxFM1v3oQh7ZdxhwR IAuq3Aa8nNScgezXeO0/DwqkVU1Qb7bS8Pa1AlrJ27H3lORlfIr2jhjUVzH0tjjnhqmQ cD8G7koEl7tJAeoPuMNQdzCqEnX17ju4kGEQzGzZEx5F01cCPjUfVtsYtjdBP+MevlZy Kx72H/07Sz1eeel22fRtLSxD3oWq3FGeSCkQXJVmBwMGa0+LHQi4+3QHouP3dxJLCk8D pV4jEWIEJwUbUuJ0qj2w7AX2Zkwr7tNgpsFU6taVb1NJl3tM6Diixq7ifsplRwki5jUE 72dg== X-Forwarded-Encrypted: i=1; AJvYcCVB9XNLnAMXnNq03HHCJjBLy/Ygks7BShfI6c1JoBPi5zc1d90KbrEf5xH2M/CmVaNBGncxVvhs1tCZKy+w@vger.kernel.org, AJvYcCVBshxTDxaVxLoyF9EE1ZrKrdYir0spHNnxog89Z5NWiEXNKu4XQcVq1fBejtxvTlX56jkHZr50BgtY4XEDH80B49w=@vger.kernel.org, AJvYcCWNtpC6fL7ZzECzpTsy/WFpyknHHnLVUGpScimhBHaI/uTQo2Cbccq+IsIf8A3hIRYVKbH5ACO9kAjXhyxUSA==@vger.kernel.org, AJvYcCXHWUaLeY1vg016V73+H1/i9kZ9PseS4QAK81Mcu28JFhLJBpNnyDT1VeIJD02cZQicgE1WZ2yDMQIN@vger.kernel.org X-Gm-Message-State: AOJu0Ywouj9wM3Qz6l+cs7+HKQLFtz/0k1a36GN9WkJxnATXrs2gKrpd O2OJ4pa/Vjv/F48lZUF3Aim0tEohmdnyN4hs04ZzkqJc3Ha2IJNa X-Gm-Gg: ASbGnctzG48/dHGX3Yyr/Fk4zAw4YK5TQ7er4BxKG8nRGSwFA5hTIL/1OWys2lrReVo kKROUNSDqm2FTSE2MbjmshSNfhLvsrQ3GfPzkgBKYa6F13reBXzpYf0ASbybQQKdcUqeYykSLBl fdyvdWrzZ+O8YoY4jgqmaGz5mB7CWO0/75NTsI7407zSJqFy1ykn8id7fPThkUhea4gyJzjC8a/ YDHoCHwu0GOLHRSEIzC+dCFWAPiYyTsC51iyqWTY+fdK2g0muQOjbeuvNOmfq4zwCPLpcP2dYqq 14LwWgveByR8ISuBOQg71BUYTAoxjUmSaqa1IxTPZ+2+JRuD7Cjab2AbsWwoXO8ScYx9hIPXnAr PP8nCgq/qmkYEc7O1 X-Google-Smtp-Source: AGHT+IF7AQauSsrNTCBXEecy6z1zSfX3R1XXKCBQWg7IremhkdjxTo5/KPNyh6CLmo9LP5N75FIt7A== X-Received: by 2002:a05:6402:50ce:b0:5fa:f96d:7a24 with SMTP id 4fb4d7f45d1cf-5faf96d7cd9mr1447167a12.3.1746369945252; Sun, 04 May 2025 07:45:45 -0700 (PDT) Received: from ivaylo-T580.. (91-139-201-119.stz.ddns.bulsat.com. [91.139.201.119]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5faecf59d31sm1147258a12.77.2025.05.04.07.45.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 May 2025 07:45:44 -0700 (PDT) From: Ivaylo Ivanov To: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Philipp Zabel , Marek Szyprowski , Sylwester Nawrocki Cc: linux-phy@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 05/10] phy: phy-snps-eusb2: split phy init code Date: Sun, 4 May 2025 17:45:22 +0300 Message-ID: <20250504144527.1723980-6-ivo.ivanov.ivanov1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250504144527.1723980-1-ivo.ivanov.ivanov1@gmail.com> References: <20250504144527.1723980-1-ivo.ivanov.ivanov1@gmail.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The current phy init consists of hardware power-up, as well as QCOM-specific eUSB2 init code. Split it into two parts, to make room for such non-QCOM init code. Signed-off-by: Ivaylo Ivanov Reviewed-by: Dmitry Baryshkov --- drivers/phy/phy-snps-eusb2.c | 94 +++++++++++++++++++++++------------- 1 file changed, 61 insertions(+), 33 deletions(-) diff --git a/drivers/phy/phy-snps-eusb2.c b/drivers/phy/phy-snps-eusb2.c index e1b175f48..1933e8440 100644 --- a/drivers/phy/phy-snps-eusb2.c +++ b/drivers/phy/phy-snps-eusb2.c @@ -121,6 +121,10 @@ static const char * const eusb2_hsphy_vreg_names[] = { #define EUSB2_NUM_VREGS ARRAY_SIZE(eusb2_hsphy_vreg_names) +struct snps_eusb2_phy_drvdata { + int (*phy_init)(struct phy *p); +}; + struct snps_eusb2_hsphy { struct phy *phy; void __iomem *base; @@ -133,6 +137,8 @@ struct snps_eusb2_hsphy { enum phy_mode mode; struct phy *repeater; + + const struct snps_eusb2_phy_drvdata *data; }; static int snps_eusb2_hsphy_set_mode(struct phy *p, enum phy_mode mode, int submode) @@ -230,41 +236,11 @@ static int qcom_eusb2_ref_clk_init(struct snps_eusb2_hsphy *phy) return 0; } -static int snps_eusb2_hsphy_init(struct phy *p) +static int qcom_snps_eusb2_hsphy_init(struct phy *p) { struct snps_eusb2_hsphy *phy = phy_get_drvdata(p); int ret; - ret = regulator_bulk_enable(ARRAY_SIZE(phy->vregs), phy->vregs); - if (ret) - return ret; - - ret = phy_init(phy->repeater); - if (ret) { - dev_err(&p->dev, "repeater init failed. %d\n", ret); - goto disable_vreg; - } - - ret = clk_prepare_enable(phy->ref_clk); - if (ret) { - dev_err(&p->dev, "failed to enable ref clock, %d\n", ret); - goto disable_vreg; - } - - ret = reset_control_assert(phy->phy_reset); - if (ret) { - dev_err(&p->dev, "failed to assert phy_reset, %d\n", ret); - goto disable_ref_clk; - } - - usleep_range(100, 150); - - ret = reset_control_deassert(phy->phy_reset); - if (ret) { - dev_err(&p->dev, "failed to de-assert phy_reset, %d\n", ret); - goto disable_ref_clk; - } - snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG0, CMN_CTRL_OVERRIDE_EN, CMN_CTRL_OVERRIDE_EN); @@ -334,6 +310,52 @@ static int snps_eusb2_hsphy_init(struct phy *p) USB2_SUSPEND_N_SEL, 0); return 0; +} + +static const struct snps_eusb2_phy_drvdata sm8550_snps_eusb2_phy = { + .phy_init = qcom_snps_eusb2_hsphy_init, +}; + +static int snps_eusb2_hsphy_init(struct phy *p) +{ + struct snps_eusb2_hsphy *phy = phy_get_drvdata(p); + int ret; + + ret = regulator_bulk_enable(ARRAY_SIZE(phy->vregs), phy->vregs); + if (ret) + return ret; + + ret = phy_init(phy->repeater); + if (ret) { + dev_err(&p->dev, "repeater init failed. %d\n", ret); + goto disable_vreg; + } + + ret = clk_prepare_enable(phy->ref_clk); + if (ret) { + dev_err(&p->dev, "failed to enable ref clock, %d\n", ret); + goto disable_vreg; + } + + ret = reset_control_assert(phy->phy_reset); + if (ret) { + dev_err(&p->dev, "failed to assert phy_reset, %d\n", ret); + goto disable_ref_clk; + } + + usleep_range(100, 150); + + ret = reset_control_deassert(phy->phy_reset); + if (ret) { + dev_err(&p->dev, "failed to de-assert phy_reset, %d\n", ret); + goto disable_ref_clk; + } + + ret = phy->data->phy_init(p); + if (ret) + goto disable_ref_clk; + + return 0; disable_ref_clk: clk_disable_unprepare(phy->ref_clk); @@ -378,6 +400,10 @@ static int snps_eusb2_hsphy_probe(struct platform_device *pdev) if (!phy) return -ENOMEM; + phy->data = device_get_match_data(dev); + if (!phy->data) + return -EINVAL; + phy->base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(phy->base)) return PTR_ERR(phy->base); @@ -424,8 +450,10 @@ static int snps_eusb2_hsphy_probe(struct platform_device *pdev) } static const struct of_device_id snps_eusb2_hsphy_of_match_table[] = { - { .compatible = "qcom,sm8550-snps-eusb2-phy", }, - { }, + { + .compatible = "qcom,sm8550-snps-eusb2-phy", + .data = &sm8550_snps_eusb2_phy, + }, { }, }; MODULE_DEVICE_TABLE(of, snps_eusb2_hsphy_of_match_table); From patchwork Sun May 4 14:45:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivaylo Ivanov X-Patchwork-Id: 887231 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6996C1E1C3F; Sun, 4 May 2025 14:45:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746369951; cv=none; b=ngXFD/iP2uQXE/VO2sbhs1Cl9yW/3ghB5mmVxJdH4s6tSirU3VxkRxjzYMBpGaf/LNtnBSBT3PDTIOu8SEFbPCL55KtlRViKKMMALUvD55eQzHoVuKrP0VydaKw2Vqsp2Qsb+2JKAWGG0kOFmrt0QITtBcPFAeisORcwUNFvC6Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746369951; c=relaxed/simple; bh=tTlRXxdg/HE/Xx4UoLaC/7E8D2Teyq2hyKBHoUvS6Z0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ej9nl4Z1mhMYz0BusNWugSzQwOyaKvbJBFcQIdUy1a2WdYmqJ0jIeQNHYI9nca7rhF/VXSG7X2qs+XVVO5hXZoSE9wbJTbwGrBRgGj+f87aT5qokv0qJ42fNZN3Znct7FX7RNzWhHymIpic/QkWtzDrnwfbzKrgfordy9GYII8k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ne/TrnWa; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ne/TrnWa" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-5f728aeedacso5155373a12.2; Sun, 04 May 2025 07:45:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746369947; x=1746974747; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4mVbqwsxzgFPfZ9lDdnu8dfGQADmGRwdt2QEaF4tnGI=; b=ne/TrnWaWc9b6Rdo7c/8GzdqbH+2sra81uJ7pIrZ8YGKTQ/krqH+oCw6s/M9lJrQUn opZnGiS4ZNnrEaX/js2cHNhC/z5md9E6czfWSxgkXbWX8lSbyZ0ckbPbXI8SRZRffmsK Nmd/lyXrszHsuUGwtOQ4U/3MbQOkQuBJcWvdioJmiLY2rxq8GIvQtP3jx1VonxXvW9bB LcCm0P8enyoCdDtwawNVt5CEo2NBqv879nsoC/YRQT5LOYPVDcvvRz591WwV8clbb7Yg J714lVj8QodWBrX5UzPBKTJRtHlXK8kDQTqZ18f989apW/NErG15DNg2AIHQWB5Fx6ei h8Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746369947; x=1746974747; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4mVbqwsxzgFPfZ9lDdnu8dfGQADmGRwdt2QEaF4tnGI=; b=swbxQZ/G18ZoaGMx/WzE3rdQAn5ABt9vUKJkmyT6VUkozyE8umcj+QnW0YXeiAMo04 4pVAsJff4IIoS9udrJO42vd3cJfUf8UaoXkoJExjDPCn/8GCema/wcs5LwWkXFPxQ3iF 1YzyOtcuPsV6aT3fa+vGSEos6z2tTaoQFHUR/oLQ0ugARGQd6s/OUizyvIJCwNG2d7Hs Cm7B+h4jUauYu29gzCG063d/FqXh3hP6Reg9ondD7Ti4J2TzbW6aSKJ23iCI23XuoPcg osDR3dvXVIPUMs6rJpbC9AUVLq0mRl8KNZ+Xh73FgrRQyjM3h6LeIPhSmMk2zQoBtUj6 WzzA== X-Forwarded-Encrypted: i=1; AJvYcCV/WT/DPXOJHDc1xNEJYdSA6Wbw5TivikjVoL0AhigmnzIvmcC1u5neGPouvn0ZIL8eqjBsWYgrWkJy@vger.kernel.org, AJvYcCVnERHeKyYTTarqN8iE+AEhlfoIz7naFnSDEAQu5fIxCpHz1xrJchtFYFaStqLj83BrBrTm4+SYW2FyPwXQ2g==@vger.kernel.org, AJvYcCX5NEGtruNVSkDGw4V6ZUl5337B9oZoAmC7ZG8Fqe/eP2/OOQHpaLIS7zmaCILHyvFrrm6fFq4CR1mlll8l@vger.kernel.org, AJvYcCXWdrcE0b6oBwhf/KX1VqWOsc+jGUcSUScMgjXvg3JAet0tOmDgjf6IFScvgOYm0EwSd6ldlxfhxQ3lWdiKGbrmjHU=@vger.kernel.org X-Gm-Message-State: AOJu0YzWIUSSOqwZaxwOKCTwFZt2IGDhQtbbQpqcifS/eYHjNJekv/K+ pDZPKc16wV/m6TaqE3EiWoIG0fHqW/mMX7xXFY1ny8BaLGDcNa8u X-Gm-Gg: ASbGncsmG1Gpk6bygeoBzqj4ed9/Teod2ATXhDq6EtAeE2hUSKQRxgnddSuOyk5qP9Z BrcevLFWLq++nxuaD9FEtQ3Icf5WTOECfd3zcT8yiNEg//AvoQTPJ+taIwDs2N38knP+wTmJeY3 cZKrkognLnzViYB2vOW5Cv1XCI0IhJpyYT4JvtB64s54DaYuEf+LM3y6mTapMxu+mpqhqcu1gLQ SnAaP8B+v17XRx4UrNGofAkeVHCZLuFmPCPL9DUpNs2b9a5P2Wllqk6fjwszctYCsfKrVSxo1Tt Nv5dfZmdtEu8+I1+BSw4oCdWkBoL8Y8QchAOh3CoxIgmkpPTt+rkkMDJV3aP34Cqbzc9RzJqtJU Wq5bJ1YJRzvRIxCN/ X-Google-Smtp-Source: AGHT+IHjuIKWNJgawIjtwOkw8F15EvBzNiKAf12L7CVkflrKlhADiuEJeb1zBKuZ3rg6km845Z0EJw== X-Received: by 2002:a05:6402:2707:b0:5e7:88d8:30a6 with SMTP id 4fb4d7f45d1cf-5fab057dce4mr3636267a12.20.1746369946576; Sun, 04 May 2025 07:45:46 -0700 (PDT) Received: from ivaylo-T580.. (91-139-201-119.stz.ddns.bulsat.com. [91.139.201.119]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5faecf59d31sm1147258a12.77.2025.05.04.07.45.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 May 2025 07:45:46 -0700 (PDT) From: Ivaylo Ivanov To: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Philipp Zabel , Marek Szyprowski , Sylwester Nawrocki Cc: linux-phy@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 06/10] phy: phy-snps-eusb2: make repeater optional Date: Sun, 4 May 2025 17:45:23 +0300 Message-ID: <20250504144527.1723980-7-ivo.ivanov.ivanov1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250504144527.1723980-1-ivo.ivanov.ivanov1@gmail.com> References: <20250504144527.1723980-1-ivo.ivanov.ivanov1@gmail.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 As described in the device tree bindings, it's not necessary for the SNPS eUSB2 phy to be connected to a repeater. In configurations where there are such instances, the driver probing fails and the usb controller does not work. Make the repeater optional to avoid that, which also lets us use the eUSB2 phy when it's connected to a repeater that is not configurable by the kernel (for example it's missing a driver), as long as it has been configured beforehand (usually by the bootloader). Signed-off-by: Ivaylo Ivanov Acked-by: Neil Armstrong Reviewed-by: Dmitry Baryshkov --- drivers/phy/phy-snps-eusb2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/phy-snps-eusb2.c b/drivers/phy/phy-snps-eusb2.c index 1933e8440..4094786d2 100644 --- a/drivers/phy/phy-snps-eusb2.c +++ b/drivers/phy/phy-snps-eusb2.c @@ -426,7 +426,7 @@ static int snps_eusb2_hsphy_probe(struct platform_device *pdev) return dev_err_probe(dev, ret, "failed to get regulator supplies\n"); - phy->repeater = devm_of_phy_get_by_index(dev, np, 0); + phy->repeater = devm_of_phy_optional_get(dev, np, 0); if (IS_ERR(phy->repeater)) return dev_err_probe(dev, PTR_ERR(phy->repeater), "failed to get repeater\n"); From patchwork Sun May 4 14:45:24 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivaylo Ivanov X-Patchwork-Id: 887546 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C09631E5215; Sun, 4 May 2025 14:45:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746369951; cv=none; b=LkDDp+GMXkH9zQnxcW6OU3bAJ+oi2gOybcqGjawRdxJFVmwOJKAAhdPm11P1ZcpTg8lZgPZ6EUEC7r1fLRyz7EyYv7D2RlPoNU5uhPk4UHN9+E3EDWBO6RK/2zL4V0zDsozFBlazMFAyLWU7C+oxBm+H0xtltQOuQUHI4ZDIcuc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746369951; c=relaxed/simple; bh=9jGBgw7X4dT0+5FklcYtTpf6XdRbcwhpMrfLuBnypSE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GzLtgtoLXXNVMCHLzO1oOHyYnZ1wk3oQ1z3IfNwGyGCO43Phqhj98m3uBnN/8q67WZr1/JlEUiJ6CIIdcj9uQzxKOHx+Vp5Jv9ISVXmY3T1kvUM1cRdvnSMHI38TgL6kE24sR+gsPo9a8jVEzRVbZhUUPTJfywkrltNhnK5ygNI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HgwSYyTE; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HgwSYyTE" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-5f6222c6c4cso5095937a12.1; Sun, 04 May 2025 07:45:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746369948; x=1746974748; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RbJk9bz6EFQthks8Ev5pNh2F644o6dRNVZmRCAlT3D8=; b=HgwSYyTEUY1CmQzmkz46r+rbvd3+zFZm/3fX48L7G87K8i1hiKDq8ENOiuX4W7vC1T hG4U51xbqofIN9QFIqqjt7CrH63WE6CHvdY4m18FER5xrgfB1+SZNKMnDsubJf5wxme6 o1PPV6KReghIPKX9vHGAPdg91RP9RPTVZC2RifMrf6GDWSHficNqmUP2A7rQ+KlG2H0j 0UeIDs8BSYNd072TJwcJnO5BnqShAAf1qQNTCGCvO1qHMbX//lyeRLXXzJL1WM6Pq4Iy ExJj00yyBP9srDLEOdVQKkUBltFJc9L9Ah5GMKbEQO2tBMCQNNtzIPRlYwZtBVk+YkVo fTWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746369948; x=1746974748; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RbJk9bz6EFQthks8Ev5pNh2F644o6dRNVZmRCAlT3D8=; b=EWTnHKWSbEeuzB+rydXj0W6dsy/RRulH5J1OeLAmMxb6GpiklGo93kq5e7lGHz3V0D M75ZsBHtrJAMuR5rURKzI/ddmr6x28LmeXILZS7TrcCbJj642uDXMroHoxUD8Rq4zG3J dWwtPpSxzLpR1YtH2+t8cg9RYhc0Jk2X48CxNfL+yaiZCWxQ5PeAZNtCF/2NWAAioUJV Kng0q/xWeFBntzDcFXhyid3h55RXJfsG6g3RGPJXjXL9VKp36sVlScQMdx56/b2NgdUq xFMVd/If2JKawl2wovdumuOdM0fPoI0jzqk1F7Mgvc/G0PSUPro9qm8yBOqP+Fx/C58F NCCA== X-Forwarded-Encrypted: i=1; AJvYcCVXQRXtlWtFrrOwItynewl/LFMs478rQTpY7jh6LiMrnoS/Bgelir3FRZSE2K0xQVw1eYbWSwAVt+Gw@vger.kernel.org, AJvYcCVx54LnzNuX1YLRNCNuAcQAvIbVk2rsabT0wdKGKtmJ5ehBsuczZTJLUyNsPz0rhpRGQzuOjb5P6MrHHGSRuA==@vger.kernel.org, AJvYcCXD7gtVr9dC4H9qZ5udYNYxmvq5TgBrB3ybZtvkeJ2LCoi7uMOEkTGNb9SHS2EhR/ZyCP9tZmw2NXhNEcDU@vger.kernel.org, AJvYcCXM6ilhd0EUo+sTTjVI1d9SbritDNknIaLea+nkvs0bkRa8Mj04/I2t3uUH1b9HeGEX43yAspRETtw3WkSMW/jU4xE=@vger.kernel.org X-Gm-Message-State: AOJu0Yw72X2222zwA3AKjfyu03Uqpl+QMSHGUN39XpM4qFILkKWurQQW bVJbi5StgGtwYj9IFnhG/08NhI02OTRt4Flc1MpJ8LD791y4hi03 X-Gm-Gg: ASbGncvb0e05jb8TLS+LJifpL4Wi+vkM9su/p0pXs2DD0uhlqm+txCh8dQvY8jW4FKy GdpOyWARRWZ/nSUragyuSoKpAfMcr8Pi+DTm+tvVXW4nc7F+013DikiWMBmMp58RR7eK5kCtY8n ZEN+5i24JKlNz8cIxn3csZ5IMdqoQPEIbwin+dn0n88MNVKCZzyUQr4qE3uB78YQk48plTcaeIO 2LNXJr+VplDdWGnMn+hLSsKl5ODzyx6AcEOPhwy13f5A5X3HcpTa87MNXisjWNo7u4u61863rZE 79h8O9LECWIRaYWNESIJGaVjr/o2FyleeMJEggn2PE4EqIhXppjQObKy3j44HIOS3nVOahZhsoO lBZx2ef1EBJ1pM2hn X-Google-Smtp-Source: AGHT+IE7vTq91Ziy5tdSjRautreu12/lKKGXLd23gtOnTMb42Z27SvBFllDzeWoPOC2edcZgczXudQ== X-Received: by 2002:a05:6402:5250:b0:5fa:afe9:848 with SMTP id 4fb4d7f45d1cf-5fab0576388mr3103899a12.9.1746369947837; Sun, 04 May 2025 07:45:47 -0700 (PDT) Received: from ivaylo-T580.. (91-139-201-119.stz.ddns.bulsat.com. [91.139.201.119]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5faecf59d31sm1147258a12.77.2025.05.04.07.45.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 May 2025 07:45:47 -0700 (PDT) From: Ivaylo Ivanov To: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Philipp Zabel , Marek Szyprowski , Sylwester Nawrocki Cc: linux-phy@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 07/10] phy: phy-snps-eusb2: make reset control optional Date: Sun, 4 May 2025 17:45:24 +0300 Message-ID: <20250504144527.1723980-8-ivo.ivanov.ivanov1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250504144527.1723980-1-ivo.ivanov.ivanov1@gmail.com> References: <20250504144527.1723980-1-ivo.ivanov.ivanov1@gmail.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Not all SoCs expose the reset line controls to the kernel, so make them optional. Signed-off-by: Ivaylo Ivanov Reviewed-by: Dmitry Baryshkov --- drivers/phy/phy-snps-eusb2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/phy-snps-eusb2.c b/drivers/phy/phy-snps-eusb2.c index 4094786d2..f05333901 100644 --- a/drivers/phy/phy-snps-eusb2.c +++ b/drivers/phy/phy-snps-eusb2.c @@ -408,7 +408,7 @@ static int snps_eusb2_hsphy_probe(struct platform_device *pdev) if (IS_ERR(phy->base)) return PTR_ERR(phy->base); - phy->phy_reset = devm_reset_control_get_exclusive(dev, NULL); + phy->phy_reset = devm_reset_control_get_optional_exclusive(dev, NULL); if (IS_ERR(phy->phy_reset)) return PTR_ERR(phy->phy_reset); From patchwork Sun May 4 14:45:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivaylo Ivanov X-Patchwork-Id: 887230 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1587B1E7C11; Sun, 4 May 2025 14:45:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746369952; cv=none; b=r91JqF8FjbDfDd0iIQ7QchULX/rCb2DJYOoiBVVKl7bSFxSfTDNYBWo6N3Mh5OGeCCmxSYc85IBpGpDNK/mi3RNxGEn5JzTxutlahzmzNQZvh0cclxB3qT7l9LkltwPkTEPfcSR4QmhcNcZ5nl3oE03r6HWau3sbHBRS3h9yG/Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746369952; c=relaxed/simple; bh=AkBmi3smSWITHl2bmr29dOmbgvhXHgDHeSc21unzXPg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TjDtcU3WTwp4Tb0YYBaONucKBLPJe5w9iUhrlJLHRbzTDhKz0P9Fsw0CNDvBh4IdlKeaQ7YY6TLPjAW6lZKFFdC38Zv34SBUyfiTOjFNvhN0Mhl16ipOA2elfjjeDz6n9IkdVeAeF+XzdGarywlNOSzFimS4Y4mCD3z9rrdFF5Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GMG+Epy2; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GMG+Epy2" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-5fab81d6677so1710949a12.1; Sun, 04 May 2025 07:45:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746369949; x=1746974749; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H8Z64jhMWr4f68K+GRZRK+Jca5FzqJ7OziWBl/OdXKA=; b=GMG+Epy2OidA6r7ZszXaaj0iMjcHITwKoU9N6pivnC6P+yT7h+dVIRLcuvG2WOOtjP qMEDmIUfOvhBVZKziZCnQ0jqtplHpKpLuRw2i6BvHEFBAY0ySy8/Z9qAB8YeybAE6uDF vFoBBEAnYVPUaPTCV6ZKLe//Z9O0rSzThaGVwrm9NAGPHOSW40iJw57zb5aETzpWmoos VZAZpjMnJdC3QqqCAXODNWQm7PfTUjIBgnBDCXCCnjorgpaTX0bihoTW3Yu1leF5aItC G+sz/fkbO0QGypyIc/uq6oHYDjPvudHUhWPnYYeq6PYjSzIdXQICJKCg03mfBGtN20ez hmtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746369949; x=1746974749; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H8Z64jhMWr4f68K+GRZRK+Jca5FzqJ7OziWBl/OdXKA=; b=fpKwicw/YcM6XqF4TRG0PBtUmj7VX8LlOjTKrUQLcc4uC7lzNloLviBGAV4MBK1x86 qNKSbCp2yFFs5J4t1wSzoQTYzk0Bd0Bdlg8wwMDXhNSnjNendO6FMGlo0LJFGs49s7jL BaGCFqxDDCBfRIOXhjMzdHXoZvitM2pVWW/E8xkB4MUF3pNaC/sSacghTbRfwvyyUjsV XZAWyk0RUex+9nfNycWuirZWdbP8vmaHvBPPrVs8Z2BqYULsfIg0y1QTI9dL8o4/eSll Qu2To8m73v4t0sIBVqjT2JquQKRerl+U2MkkeXyQd82vM+ykyDuGo1vCRdGo9E6a3Iyo yKxw== X-Forwarded-Encrypted: i=1; AJvYcCU7vpcm3alyjgYX5Bt0bKQBYSw6CtuVygR3S6wOEFuTCb+H0t5ZuJmn0tfjIKDxZKDaWZKfTUBeQ95VYc8afA==@vger.kernel.org, AJvYcCUVL68z9XqWno4SsQn0xuXEHh/zmeyBK8Jsfq45t/20jlyRxKFcM13+AIZB06RwZqy0s6qL1vxOmU91Bnzv@vger.kernel.org, AJvYcCW50F8zPYRCqsiqC36H5Mweynf1QOSyONwB3D+8JuZfKwm5zwD8mnhxHONFtT6vRhz2aAX8YtaFL7w2yDw/sOdpsQA=@vger.kernel.org, AJvYcCXYxPZFi7As79vAglVFswV637usGCfzEVSoXeBr2PPV/46UIFsTbReCL0vtPsqkcst9XoJHkq80HZvh@vger.kernel.org X-Gm-Message-State: AOJu0YwnExyVlnAYDigNW8f3kaX0t8MlibRT4jQgJiL/J+aFdD02xpRh vQ2sy3CcnA3tNYeA0dPblRbw/MnlCsczoqnpdizzEk8XA8ExWnAN X-Gm-Gg: ASbGncusZfNm0Kz7TLltt0a1Iasc+YOCirwDSxmcRdFyKrMsTghm5siiCANHpANZoiW ROpwaG8r33E0zK2DK+lZDY8RxZtKbb98aSi9N24lLmkdyGigKD4JJcPbWcAY4wJbyjPNLYAWE4l zDCCpuWBl/SFaOpKkNt7qRqydgkCHGP33YzkJZvEgQ6di6XBUXbkyLqktPOJlPhXgcCE3PJ85FO ORzUXxQIOqDLv9yanWejrQ42JhYXd3MT4yRjeI6Jp9hazBx5iu54wz1W1pnSLvftIGyiImfgQCx n7Hsgb0pxzyLymvsLlquXHSnCuHmJvVzMaSy2uk0qwhiEYfR3jRt8B2+8xDngIJ9H0FvgCvfBAu cALA7SaeYRHGX4p5ehez9jABOqWA= X-Google-Smtp-Source: AGHT+IHLAPcmE4D8uUqNIDaDTGoj/0IoKeVQe1JZfKk7Q4vsF1Q3KnS4KP0HYO6oATvrVjuDaOVFJA== X-Received: by 2002:a05:6402:5cb:b0:5f6:20c4:3b0d with SMTP id 4fb4d7f45d1cf-5fab0576293mr3229682a12.8.1746369949176; Sun, 04 May 2025 07:45:49 -0700 (PDT) Received: from ivaylo-T580.. (91-139-201-119.stz.ddns.bulsat.com. [91.139.201.119]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5faecf59d31sm1147258a12.77.2025.05.04.07.45.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 May 2025 07:45:48 -0700 (PDT) From: Ivaylo Ivanov To: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Philipp Zabel , Marek Szyprowski , Sylwester Nawrocki Cc: linux-phy@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 08/10] phy: phy-snps-eusb2: refactor reference clock init Date: Sun, 4 May 2025 17:45:25 +0300 Message-ID: <20250504144527.1723980-9-ivo.ivanov.ivanov1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250504144527.1723980-1-ivo.ivanov.ivanov1@gmail.com> References: <20250504144527.1723980-1-ivo.ivanov.ivanov1@gmail.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Instead of matching frequencies with a switch and case, introduce a table-based lookup. This improves readability, reduces redundancy, and makes it easier to extend support for additional frequencies in the future. Signed-off-by: Ivaylo Ivanov Reviewed-by: Dmitry Baryshkov --- drivers/phy/phy-snps-eusb2.c | 61 +++++++++++++++++++----------------- 1 file changed, 32 insertions(+), 29 deletions(-) diff --git a/drivers/phy/phy-snps-eusb2.c b/drivers/phy/phy-snps-eusb2.c index f05333901..8caa62c0b 100644 --- a/drivers/phy/phy-snps-eusb2.c +++ b/drivers/phy/phy-snps-eusb2.c @@ -192,44 +192,47 @@ static void qcom_eusb2_default_parameters(struct snps_eusb2_hsphy *phy) FIELD_PREP(PHY_CFG_TX_HS_XV_TUNE_MASK, 0x0)); } +struct snps_eusb2_ref_clk { + unsigned long freq; + u32 fsel_val; + u32 div_7_0_val; + u32 div_11_8_val; +}; + +static const struct snps_eusb2_ref_clk qcom_eusb2_ref_clk[] = { + { 19200000, FSEL_19_2_MHZ_VAL, DIV_7_0_19_2_MHZ_VAL, DIV_11_8_19_2_MHZ_VAL }, + { 38400000, FSEL_38_4_MHZ_VAL, DIV_7_0_38_4_MHZ_VAL, DIV_11_8_38_4_MHZ_VAL }, +}; + static int qcom_eusb2_ref_clk_init(struct snps_eusb2_hsphy *phy) { + const struct snps_eusb2_ref_clk *config = NULL; unsigned long ref_clk_freq = clk_get_rate(phy->ref_clk); - switch (ref_clk_freq) { - case 19200000: - snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_HS_PHY_CTRL_COMMON0, - FSEL_MASK, - FIELD_PREP(FSEL_MASK, FSEL_19_2_MHZ_VAL)); - - snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_2, - PHY_CFG_PLL_FB_DIV_7_0_MASK, - DIV_7_0_19_2_MHZ_VAL); - - snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_3, - PHY_CFG_PLL_FB_DIV_11_8_MASK, - DIV_11_8_19_2_MHZ_VAL); - break; - - case 38400000: - snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_HS_PHY_CTRL_COMMON0, - FSEL_MASK, - FIELD_PREP(FSEL_MASK, FSEL_38_4_MHZ_VAL)); - - snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_2, - PHY_CFG_PLL_FB_DIV_7_0_MASK, - DIV_7_0_38_4_MHZ_VAL); - - snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_3, - PHY_CFG_PLL_FB_DIV_11_8_MASK, - DIV_11_8_38_4_MHZ_VAL); - break; + for (int i = 0; i < ARRAY_SIZE(qcom_eusb2_ref_clk); i++) { + if (qcom_eusb2_ref_clk[i].freq == ref_clk_freq) { + config = &qcom_eusb2_ref_clk[i]; + break; + } + } - default: + if (!config) { dev_err(&phy->phy->dev, "unsupported ref_clk_freq:%lu\n", ref_clk_freq); return -EINVAL; } + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_HS_PHY_CTRL_COMMON0, + FSEL_MASK, + FIELD_PREP(FSEL_MASK, config->fsel_val)); + + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_2, + PHY_CFG_PLL_FB_DIV_7_0_MASK, + config->div_7_0_val); + + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_3, + PHY_CFG_PLL_FB_DIV_11_8_MASK, + config->div_11_8_val); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_3, PHY_CFG_PLL_REF_DIV, PLL_REF_DIV_VAL); From patchwork Sun May 4 14:45:26 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivaylo Ivanov X-Patchwork-Id: 887545 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 443A61F0E38; Sun, 4 May 2025 14:45:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746369955; cv=none; b=uBRNe0NWpg4lGs5m1zrHrO2iRlBehDn0bYdCE47UcqAE4XxcJmlfgi3QJkCkkCwlgtNb7r3Aw5FhM6R19BBYjKyKPY6eybVQM75mkUP8YXDdRyRJlo89K04uEcxoUw8d3DJNAe0h84UmrVBSpokskrGX07uIGzfEfL81oBhwA7w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746369955; c=relaxed/simple; bh=ogdJs3P0nw4zm4/Rb98FqrgIjmxVeN0yklkwRVCI9K4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qzlIADBGj6wyGi3CPhrbsaasHQiNbW18Yc8GSIxV5jV85UXLDUl8xPJYX2vS/x7Ua41L/9K5U5YeivLHaezwmXuMJWdf7fepF94DUzPXWVpWXAISyfx4SDxeq9CE2n2qwTTN93h2I1CEYr1ZEwD5OqRs/CRWosa5NwFEhXjlbQU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nMvQrlsE; arc=none smtp.client-ip=209.85.208.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nMvQrlsE" Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-5eb92df4fcbso6750743a12.0; Sun, 04 May 2025 07:45:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746369950; x=1746974750; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TWVQ4JZdxhs/sxIlA/zTTHauX53b7ANsdgsUWP29zDk=; b=nMvQrlsEdJ1wgxpRK/OJ6xMviC5UlbXPbbOn7EGisVY6H9jPMDnChvWHGGImJ2Y579 O3F2AlGYT6btD7gnfTjCL2fW8jzfVk+8cPM1ePRh+z9tfpUP02k9NeDz0/7/ERcLIN+t AmrfzoDjYvYUEEnMWsjV9OZnfRAOsfv2zpdqpTWVLtK5TfZGkFWMP8ySCYs8/wR0m4dY 286D11WeGXfHoC6viow82/6h1AOhX+7zooh6FfNXbfqu9yWFmVjvLJUT4j72CWixhTs7 UrRkLS3/6roUAAvkvMULgBYWEndagWb95yw+lDHMKjsdncqqyzr73UWvRWO6wfR9bL41 NJ1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746369950; x=1746974750; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TWVQ4JZdxhs/sxIlA/zTTHauX53b7ANsdgsUWP29zDk=; b=bkdorj+R2k7e6kaWBHvSGhsCfXBmEfJZwIwiaZXp4+NqUwI7ho2DnmMlMPnaD+9vo0 XWf22aBTZG/XOip4ryfSab+7tlsUmwy21OZMAsuecvY10gbV2pIUTnBZ+fM9KpFwoaqb HcVAIbcmsQaiJMT49eVPhmqMNvLGpq8l9SRnX06Kpj9XWNPz0w4DcZNtP9RYlAU1X3+r 9etIzGA1Oq832ppa2HamdEvVfVMWSB9FwzUFkye+fbuBExDtuZu6Gga2K6run5SBZdsg qIVTysh9Gz9q60PEkE8O8ZH/FIXZ6FYl0+soYdBelk3iQ9Ffp30tVfPnpoF3rmrpiDi2 5FnA== X-Forwarded-Encrypted: i=1; AJvYcCU2zoZFtXmIDG9KSgWkXIAXKWu4AS5vzWz3DJmVkwfIrv6nv8nd8zMPG38yMcNtLgA5+mP/XmUCwZRrIOl9tQ==@vger.kernel.org, AJvYcCVoUBjpEJjyFegwFbWEPvSmIgWElNxIHBUtXJGE3d1gg9ceUz/0X4Yuv4R8Zb55w3Z5pDMlbnuBLGTy@vger.kernel.org, AJvYcCVrWbVhBtywVr9j9SsvyAzhATNGGyaEjglZDUlKgspIiRkzhNJG6wfFTgbuTy27x4ApTaXi+RrQyCwaA5YL@vger.kernel.org, AJvYcCXPz+fEF81FAe9bula1w7SQ91/VJsDBh24ooxlleltfIHqX/NHnkvq6jo/HUY11n3ZPL3hKBvT5k5/IfBfv28iqaA4=@vger.kernel.org X-Gm-Message-State: AOJu0YzZ5pu1ByVzSLYC8aEIvPE090ITrrmUUmjeHEGax7Q6L08/Pcv9 /a0/fdDinNvWi19ao142MLxFWom0m5XJgS/NWW32ZumaaF9H1Z9F X-Gm-Gg: ASbGncvDwieJG03MCHu6ZVbs8KxWkqsW8vOc94PtOhrPjhBAyE+WyDdtbTqTqbMnQxZ bJjhxg1jkbWnJUYJcxKxBMbQ/s+xBMwbMhGyYOIXVr6aO0SI3J1Ux2LyIXNMvFGMFd2RuF0CB/9 11FJeZ4efe4iKCiPcKltyBE3NYOzXbQyHvoWQcSRfXgyYnElG/sZzWdDneI2/UwJpvpbL7HYMWu v+R0/ovySrO8uTBuJvm9fic+aprefCkggWRiJbah4DRvRh5L/N23yt0GKKAiAhBDV8xT9tQpxur ErWg/JmVWjnYdhT1a4NoHlGU6HUMNWgYFIJGWxRjp9Dj0TGGzA5dDlxkWswECJN/idcWELPdkDM dI8zZGKPi7lg9q15Y X-Google-Smtp-Source: AGHT+IGcQhxZ8Ee0gV4Kq8eL/mz0wCqQOqMRE5y14X2fF6dY6I/c/y/b+aDL82lTFIMEL31lTx8VwA== X-Received: by 2002:a05:6402:90b:b0:5f8:604a:3a74 with SMTP id 4fb4d7f45d1cf-5fab057e1f8mr3077604a12.20.1746369950437; Sun, 04 May 2025 07:45:50 -0700 (PDT) Received: from ivaylo-T580.. (91-139-201-119.stz.ddns.bulsat.com. [91.139.201.119]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5faecf59d31sm1147258a12.77.2025.05.04.07.45.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 May 2025 07:45:50 -0700 (PDT) From: Ivaylo Ivanov To: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Philipp Zabel , Marek Szyprowski , Sylwester Nawrocki Cc: linux-phy@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 09/10] phy: phy-snps-eusb2: add support for exynos2200 Date: Sun, 4 May 2025 17:45:26 +0300 Message-ID: <20250504144527.1723980-10-ivo.ivanov.ivanov1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250504144527.1723980-1-ivo.ivanov.ivanov1@gmail.com> References: <20250504144527.1723980-1-ivo.ivanov.ivanov1@gmail.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The Exynos2200 SoC reuses the Synopsis eUSB2 PHY IP, alongside an external repeater, for USB 2.0. Add support for it to the existing driver, while keeping in mind that it requires enabled more than the reference clock. Signed-off-by: Ivaylo Ivanov Acked-by: Dmitry Baryshkov --- drivers/phy/Kconfig | 2 +- drivers/phy/phy-snps-eusb2.c | 162 ++++++++++++++++++++++++++++++++++- 2 files changed, 159 insertions(+), 5 deletions(-) diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index 11c166204..58c911e1b 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -45,7 +45,7 @@ config PHY_PISTACHIO_USB config PHY_SNPS_EUSB2 tristate "SNPS eUSB2 PHY Driver" - depends on OF && (ARCH_QCOM || COMPILE_TEST) + depends on OF && (ARCH_EXYNOS || ARCH_QCOM || COMPILE_TEST) select GENERIC_PHY help Enable support for the USB high-speed SNPS eUSB2 phy on select diff --git a/drivers/phy/phy-snps-eusb2.c b/drivers/phy/phy-snps-eusb2.c index 8caa62c0b..b73a1d7e5 100644 --- a/drivers/phy/phy-snps-eusb2.c +++ b/drivers/phy/phy-snps-eusb2.c @@ -13,6 +13,39 @@ #include #include +#define EXYNOS_USB_PHY_HS_PHY_CTRL_RST (0x0) +#define USB_PHY_RST_MASK GENMASK(1, 0) +#define UTMI_PORT_RST_MASK GENMASK(5, 4) + +#define EXYNOS_USB_PHY_HS_PHY_CTRL_COMMON (0x4) +#define RPTR_MODE BIT(10) +#define FSEL_20_MHZ_VAL (0x1) +#define FSEL_24_MHZ_VAL (0x2) +#define FSEL_26_MHZ_VAL (0x3) +#define FSEL_48_MHZ_VAL (0x2) + +#define EXYNOS_USB_PHY_CFG_PLLCFG0 (0x8) +#define PHY_CFG_PLL_FB_DIV_19_8_MASK GENMASK(19, 8) +#define DIV_19_8_19_2_MHZ_VAL (0x170) +#define DIV_19_8_20_MHZ_VAL (0x160) +#define DIV_19_8_24_MHZ_VAL (0x120) +#define DIV_19_8_26_MHZ_VAL (0x107) +#define DIV_19_8_48_MHZ_VAL (0x120) + +#define EXYNOS_USB_PHY_CFG_PLLCFG1 (0xc) +#define EXYNOS_PHY_CFG_PLL_FB_DIV_11_8_MASK GENMASK(11, 8) +#define EXYNOS_DIV_11_8_19_2_MHZ_VAL (0x0) +#define EXYNOS_DIV_11_8_20_MHZ_VAL (0x0) +#define EXYNOS_DIV_11_8_24_MHZ_VAL (0x0) +#define EXYNOS_DIV_11_8_26_MHZ_VAL (0x0) +#define EXYNOS_DIV_11_8_48_MHZ_VAL (0x1) + +#define EXYNOS_PHY_CFG_TX (0x14) +#define EXYNOS_PHY_CFG_TX_FSLS_VREF_TUNE_MASK GENMASK(2, 1) + +#define EXYNOS_USB_PHY_UTMI_TESTSE (0x20) +#define TEST_IDDQ BIT(6) + #define QCOM_USB_PHY_UTMI_CTRL0 (0x3c) #define SLEEPM BIT(0) #define OPMODE_MASK GENMASK(4, 3) @@ -123,6 +156,8 @@ static const char * const eusb2_hsphy_vreg_names[] = { struct snps_eusb2_phy_drvdata { int (*phy_init)(struct phy *p); + const char * const *clk_names; + int num_clks; }; struct snps_eusb2_hsphy { @@ -130,6 +165,7 @@ struct snps_eusb2_hsphy { void __iomem *base; struct clk *ref_clk; + struct clk_bulk_data *clks; struct reset_control *phy_reset; struct regulator_bulk_data vregs[EUSB2_NUM_VREGS]; @@ -199,6 +235,46 @@ struct snps_eusb2_ref_clk { u32 div_11_8_val; }; +static const struct snps_eusb2_ref_clk exynos_eusb2_ref_clk[] = { + { 19200000, FSEL_19_2_MHZ_VAL, DIV_19_8_19_2_MHZ_VAL, EXYNOS_DIV_11_8_19_2_MHZ_VAL }, + { 20000000, FSEL_20_MHZ_VAL, DIV_19_8_20_MHZ_VAL, EXYNOS_DIV_11_8_20_MHZ_VAL }, + { 24000000, FSEL_24_MHZ_VAL, DIV_19_8_24_MHZ_VAL, EXYNOS_DIV_11_8_24_MHZ_VAL }, + { 26000000, FSEL_26_MHZ_VAL, DIV_19_8_26_MHZ_VAL, EXYNOS_DIV_11_8_26_MHZ_VAL }, + { 48000000, FSEL_48_MHZ_VAL, DIV_19_8_48_MHZ_VAL, EXYNOS_DIV_11_8_48_MHZ_VAL }, +}; + +static int exynos_eusb2_ref_clk_init(struct snps_eusb2_hsphy *phy) +{ + const struct snps_eusb2_ref_clk *config = NULL; + unsigned long ref_clk_freq = clk_get_rate(phy->ref_clk); + + for (int i = 0; i < ARRAY_SIZE(exynos_eusb2_ref_clk); i++) { + if (exynos_eusb2_ref_clk[i].freq == ref_clk_freq) { + config = &exynos_eusb2_ref_clk[i]; + break; + } + } + + if (!config) { + dev_err(&phy->phy->dev, "unsupported ref_clk_freq:%lu\n", ref_clk_freq); + return -EINVAL; + } + + snps_eusb2_hsphy_write_mask(phy->base, EXYNOS_USB_PHY_HS_PHY_CTRL_COMMON, + FSEL_MASK, + FIELD_PREP(FSEL_MASK, config->fsel_val)); + + snps_eusb2_hsphy_write_mask(phy->base, EXYNOS_USB_PHY_CFG_PLLCFG0, + PHY_CFG_PLL_FB_DIV_19_8_MASK, + FIELD_PREP(PHY_CFG_PLL_FB_DIV_19_8_MASK, + config->div_7_0_val)); + + snps_eusb2_hsphy_write_mask(phy->base, EXYNOS_USB_PHY_CFG_PLLCFG1, + EXYNOS_PHY_CFG_PLL_FB_DIV_11_8_MASK, + config->div_11_8_val); + return 0; +} + static const struct snps_eusb2_ref_clk qcom_eusb2_ref_clk[] = { { 19200000, FSEL_19_2_MHZ_VAL, DIV_7_0_19_2_MHZ_VAL, DIV_11_8_19_2_MHZ_VAL }, { 38400000, FSEL_38_4_MHZ_VAL, DIV_7_0_38_4_MHZ_VAL, DIV_11_8_38_4_MHZ_VAL }, @@ -239,6 +315,55 @@ static int qcom_eusb2_ref_clk_init(struct snps_eusb2_hsphy *phy) return 0; } +static int exynos_snps_eusb2_hsphy_init(struct phy *p) +{ + struct snps_eusb2_hsphy *phy = phy_get_drvdata(p); + int ret; + + snps_eusb2_hsphy_write_mask(phy->base, EXYNOS_USB_PHY_HS_PHY_CTRL_RST, + USB_PHY_RST_MASK | UTMI_PORT_RST_MASK, + USB_PHY_RST_MASK | UTMI_PORT_RST_MASK); + fsleep(50); /* required after holding phy in reset */ + + snps_eusb2_hsphy_write_mask(phy->base, EXYNOS_USB_PHY_HS_PHY_CTRL_COMMON, + RPTR_MODE, RPTR_MODE); + + /* update ref_clk related registers */ + ret = exynos_eusb2_ref_clk_init(phy); + if (ret) + return ret; + + /* default parameter: tx fsls-vref */ + snps_eusb2_hsphy_write_mask(phy->base, EXYNOS_PHY_CFG_TX, + EXYNOS_PHY_CFG_TX_FSLS_VREF_TUNE_MASK, + FIELD_PREP(EXYNOS_PHY_CFG_TX_FSLS_VREF_TUNE_MASK, 0x0)); + + snps_eusb2_hsphy_write_mask(phy->base, EXYNOS_USB_PHY_UTMI_TESTSE, + TEST_IDDQ, 0); + fsleep(10); /* required after releasing test_iddq */ + + snps_eusb2_hsphy_write_mask(phy->base, EXYNOS_USB_PHY_HS_PHY_CTRL_RST, + USB_PHY_RST_MASK, 0); + + snps_eusb2_hsphy_write_mask(phy->base, EXYNOS_USB_PHY_HS_PHY_CTRL_COMMON, + PHY_ENABLE, PHY_ENABLE); + + snps_eusb2_hsphy_write_mask(phy->base, EXYNOS_USB_PHY_HS_PHY_CTRL_RST, + UTMI_PORT_RST_MASK, 0); + + return 0; +} + +static const char * const exynos_eusb2_hsphy_clock_names[] = { + "ref", "bus", "ctrl", +}; + +static const struct snps_eusb2_phy_drvdata exynos2200_snps_eusb2_phy = { + .phy_init = exynos_snps_eusb2_hsphy_init, + .clk_names = exynos_eusb2_hsphy_clock_names, + .num_clks = ARRAY_SIZE(exynos_eusb2_hsphy_clock_names), +}; + static int qcom_snps_eusb2_hsphy_init(struct phy *p) { struct snps_eusb2_hsphy *phy = phy_get_drvdata(p); @@ -315,8 +440,14 @@ static int qcom_snps_eusb2_hsphy_init(struct phy *p) return 0; } +static const char * const qcom_eusb2_hsphy_clock_names[] = { + "ref", +}; + static const struct snps_eusb2_phy_drvdata sm8550_snps_eusb2_phy = { .phy_init = qcom_snps_eusb2_hsphy_init, + .clk_names = qcom_eusb2_hsphy_clock_names, + .num_clks = ARRAY_SIZE(qcom_eusb2_hsphy_clock_names), }; static int snps_eusb2_hsphy_init(struct phy *p) @@ -334,7 +465,7 @@ static int snps_eusb2_hsphy_init(struct phy *p) goto disable_vreg; } - ret = clk_prepare_enable(phy->ref_clk); + ret = clk_bulk_prepare_enable(phy->data->num_clks, phy->clks); if (ret) { dev_err(&p->dev, "failed to enable ref clock, %d\n", ret); goto disable_vreg; @@ -361,7 +492,7 @@ static int snps_eusb2_hsphy_init(struct phy *p) return 0; disable_ref_clk: - clk_disable_unprepare(phy->ref_clk); + clk_bulk_disable_unprepare(phy->data->num_clks, phy->clks); disable_vreg: regulator_bulk_disable(ARRAY_SIZE(phy->vregs), phy->vregs); @@ -415,8 +546,28 @@ static int snps_eusb2_hsphy_probe(struct platform_device *pdev) if (IS_ERR(phy->phy_reset)) return PTR_ERR(phy->phy_reset); - phy->ref_clk = devm_clk_get(dev, "ref"); - if (IS_ERR(phy->ref_clk)) + phy->clks = devm_kcalloc(dev, phy->data->num_clks, sizeof(*phy->clks), + GFP_KERNEL); + if (!phy->clks) + return -ENOMEM; + + for (int i = 0; i < phy->data->num_clks; ++i) + phy->clks[i].id = phy->data->clk_names[i]; + + ret = devm_clk_bulk_get(dev, phy->data->num_clks, phy->clks); + if (ret) + return dev_err_probe(dev, ret, + "failed to get phy clock(s)\n"); + + phy->ref_clk = NULL; + for (int i = 0; i < phy->data->num_clks; ++i) { + if (!strcmp(phy->clks[i].id, "ref")) { + phy->ref_clk = phy->clks[i].clk; + break; + } + } + + if (IS_ERR_OR_NULL(phy->ref_clk)) return dev_err_probe(dev, PTR_ERR(phy->ref_clk), "failed to get ref clk\n"); @@ -456,6 +607,9 @@ static const struct of_device_id snps_eusb2_hsphy_of_match_table[] = { { .compatible = "qcom,sm8550-snps-eusb2-phy", .data = &sm8550_snps_eusb2_phy, + }, { + .compatible = "samsung,exynos2200-eusb2-phy", + .data = &exynos2200_snps_eusb2_phy, }, { }, }; MODULE_DEVICE_TABLE(of, snps_eusb2_hsphy_of_match_table); From patchwork Sun May 4 14:45:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivaylo Ivanov X-Patchwork-Id: 887229 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 009761F153A; Sun, 4 May 2025 14:45:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746369956; cv=none; b=kj4THu9GYNiOcCm8FMc60IKvbaiHxc1cfVtECA/uHKgaj87mLX5uaxbi2nhvFIEwZHRDHV6CAy+YakbnL/LZCuqQ+tuVQV5V9C3tOwTv2Z6e2Kv8ZXnGCIfXpiGeDSeZCG9O7YUFKKk9i4AnWsJ/IuUiL2MPmy2ZqXzhf4DWX4U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746369956; c=relaxed/simple; bh=419pGHS6E3Wy9OaZ5aQdZp14d/QKmc0lbbOW28DgCzA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ra7qUo05OPiFDC6s43Q2VBrCNmYgOrBp2llYdf94cmHFbbf/QOC8XuYmEqCRlvHgXHHtCGJq6Jgv7YP4xujDhlz7e1GXrTyea4QH/kZHV3G5sIHr4QZ1zBiwOIvwRt3ZFuc3/FLqFzSAT6V2QHAsHgsHA+1NociWWq733hbcSL8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GgFFoU5T; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GgFFoU5T" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5e5deb6482cso8533474a12.1; Sun, 04 May 2025 07:45:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746369952; x=1746974752; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=olWmtpJVJyP5ihquepeKVhUKSgcRCRnX8hMSMQjAVm0=; b=GgFFoU5Tk6g9hGfdzmdDLkxE5Ui7xE+QYI/tzCuEsy6ZmFY1jI6DmXjcBr9HZmM340 XZ9Slr1ULHEdRqoI5mafvAWdSNWm+snWws/5gNOBiRAZ5kw1hH+6B2yR8ECnmebQlepx Wlau0mQZrMA9e1ZHjI1E+Jt/ThUnNVtqm/HudacM5CEKaVm9jee6jtZfhsMd2cY0FSPL c/VT1jOKHDCy12l9xR92NnPBnx4Z1qBUcjx8gG/HGFfZ15GkysLkq3pYrFruZKGSbeGw 4ueOfuImZbnynZm5UPuZsrG0tOZnRowzpOjnnF8t8bg8+vCoZLRzntI8xNFfamwDp3KS zatA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746369952; x=1746974752; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=olWmtpJVJyP5ihquepeKVhUKSgcRCRnX8hMSMQjAVm0=; b=UMtN7qk+dNpam44QrDvi7dv7DFSJVrKX3aWv3JFq9f0n9GhqiYqcdjGu698Kv13gFu eSzQ6M7gsmHqT1gyZz7kFkBBiF6LFH5h6O+rjmSWyl1dGGJMqFug73gx9+DTiLC4Wd/3 ASd01fBfKQqq+ZT/optSV/05NNwWAA3pmwARWQpXkrekB4/RryatDUn+0K6wDRmW78Qp 9nT5Ibl2HBW3LyzFwQ1uNuLqwvi9a6OyL6vN2EmkOJrek/0oq/79yR8qJ7tZBeag0U6N WnxP9+okYgG7TW1VFC8PqH8Sengiyw8ZEibioWmoY2GcQv9hcsXwhemDBW7Us7dvp5bX M8Hw== X-Forwarded-Encrypted: i=1; AJvYcCUWIHJqLa7dJy+EQJjzsnCP/m8CYuvFXzy+0xOZU6ELEodU4Fvf12u25ImBLRrs3ADUFZxzlvJNTQ8BzgMa@vger.kernel.org, AJvYcCUml/bYXosRNCj1TaOV6obnDObhJdKfcRUwi57+1IRzeFcH6Ym/WwMoYNCLL/qo8XwVh14xET5Op8/jbZ5sB7m/i6Q=@vger.kernel.org, AJvYcCWyQmlw2jR3MlwHcztrjZXcEefdMthkxZeFwiN4iUI9+wd098PMhbVfF9/b4hz5EIMtji3wFm2lSW2X@vger.kernel.org, AJvYcCXeMjAMyJAb99Cvj6U8n5PjpPWoE13ONd7H/90m0tuOytjiSQlym+5PWMLdY2a3ZTbTQPDeJ+1pAGGgNFh6oA==@vger.kernel.org X-Gm-Message-State: AOJu0YyY2Erak+1jjqLdyIkehsjMY+wjeawnSz+vcEBCwLg87QMnatnQ 6asm2Q5tlAmNwZJIKinjx/eY32dAXNUjoGR+dSyaBb7+eyXETOez5JGFXQ== X-Gm-Gg: ASbGnctGzeeSSks/Kb5cIhQ8ntuDPkeuKN2YHb7xKXgPLKQmb6U0Ln/WmJA0feINA8T SA1tyD+23G++JKn+6eiJPbRzKU8IEYsuARm4iaHKc/ryNTpHlkVbLhMNbVS0GgrNI9JSQngqnVM 759c7TYonOD7zmeTvwUIpPwhALwGDLs8aDZAo+eO1pDZUG7iiZJtbdoZ00vR+3Y1/eUlOy6qGWS GGLUUf+iOPaDcLVxl1T6GhkXng7mZ5LC3lZ3Q1OCvzWfcnOAVK7dyJkib1VWyF5OMHjEkJ6TFb6 REd+GlUrOgU9K0Wpgx4xluLC8SQKbfZT44ffD1NrEnXcbQ937iSf2kw116SK39+PrlLo4FfAIWh YGY+czsWEaavbC1DI X-Google-Smtp-Source: AGHT+IEewLKEcMRJPlELXPyihjMHkdm1I8PMilAI27xxkLbRXIeAtZFm6BFezmKY/8inmTCaZPdqHA== X-Received: by 2002:a05:6402:234f:b0:5f8:f0ed:ffc5 with SMTP id 4fb4d7f45d1cf-5fa7336da3dmr7794715a12.12.1746369951931; Sun, 04 May 2025 07:45:51 -0700 (PDT) Received: from ivaylo-T580.. (91-139-201-119.stz.ddns.bulsat.com. [91.139.201.119]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5faecf59d31sm1147258a12.77.2025.05.04.07.45.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 May 2025 07:45:51 -0700 (PDT) From: Ivaylo Ivanov To: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Philipp Zabel , Marek Szyprowski , Sylwester Nawrocki Cc: linux-phy@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 10/10] phy: exynos5-usbdrd: support Exynos USBDRD 3.2 4nm controller Date: Sun, 4 May 2025 17:45:27 +0300 Message-ID: <20250504144527.1723980-11-ivo.ivanov.ivanov1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250504144527.1723980-1-ivo.ivanov.ivanov1@gmail.com> References: <20250504144527.1723980-1-ivo.ivanov.ivanov1@gmail.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Add support for the Exynos USB 3.2 DRD 4nm controller. It's used in recent 4nm SoCs like Exynos2200 and Exynos2400. This device consists of 3 underlying and independent phys: SEC link control phy, Synopsys eUSB 2.0 and Synopsys USBDP/SS combophy. Unlike older device designs, where the internal phy blocks were all IP of Samsung, Synopsys phys are present. This means that the link controller is now mapped differently to account for missing bits and registers. The Synopsys phys also have separate register bases. As there are non-SEC PHYs present now, it doesn't make much sense to implement them in this driver. They are expected to be configured by external drivers, so pass phandles to them. USBDRD3.2 link controller set up is still required beforehand. This commit adds the necessary changes for USB HS to work. USB SS and DisplayPort are out of scope in this commit and will be introduced in the future. Signed-off-by: Ivaylo Ivanov --- drivers/phy/samsung/phy-exynos5-usbdrd.c | 227 ++++++++++++++++++-- include/linux/soc/samsung/exynos-regs-pmu.h | 3 + 2 files changed, 215 insertions(+), 15 deletions(-) diff --git a/drivers/phy/samsung/phy-exynos5-usbdrd.c b/drivers/phy/samsung/phy-exynos5-usbdrd.c index 817fddee0..f9a657642 100644 --- a/drivers/phy/samsung/phy-exynos5-usbdrd.c +++ b/drivers/phy/samsung/phy-exynos5-usbdrd.c @@ -36,6 +36,21 @@ #define EXYNOS5_FSEL_26MHZ 0x6 #define EXYNOS5_FSEL_50MHZ 0x7 +/* USB 3.2 DRD 4nm PHY link controller registers */ +#define EXYNOS2200_DRD_CLKRST 0x0c +#define EXYNOS2200_CLKRST_LINK_PCLK_SEL BIT(1) + +#define EXYNOS2200_DRD_UTMI 0x10 +#define EXYNOS2200_UTMI_FORCE_VBUSVALID BIT(1) +#define EXYNOS2200_UTMI_FORCE_BVALID BIT(0) + +#define EXYNOS2200_DRD_HSP_MISC 0x114 +#define HSP_MISC_SET_REQ_IN2 BIT(4) +#define HSP_MISC_RES_TUNE GENMASK(1, 0) +#define RES_TUNE_PHY1_PHY2 0x1 +#define RES_TUNE_PHY1 0x2 +#define RES_TUNE_PHY2 0x3 + /* Exynos5: USB 3.0 DRD PHY registers */ #define EXYNOS5_DRD_LINKSYSTEM 0x04 #define LINKSYSTEM_XHCI_VERSION_CONTROL BIT(27) @@ -389,6 +404,7 @@ struct exynos5_usbdrd_phy_drvdata { * @clks: clocks for register access * @core_clks: core clocks for phy (ref, pipe3, utmi+, ITP, etc. as required) * @drv_data: pointer to SoC level driver data structure + * @hs_phy: pointer to non-Samsung IP high-speed phy controller * @phy_mutex: mutex protecting phy_init/exit & TCPC callbacks * @phys: array for 'EXYNOS5_DRDPHYS_NUM' number of PHY * instances each with its 'phy' and 'phy_cfg'. @@ -406,6 +422,7 @@ struct exynos5_usbdrd_phy { struct clk_bulk_data *clks; struct clk_bulk_data *core_clks; const struct exynos5_usbdrd_phy_drvdata *drv_data; + struct phy *hs_phy; struct mutex phy_mutex; struct phy_usb_instance { struct phy *phy; @@ -1075,6 +1092,149 @@ static const struct phy_ops exynos5_usbdrd_phy_ops = { .owner = THIS_MODULE, }; +static void exynos2200_usbdrd_utmi_init(struct exynos5_usbdrd_phy *phy_drd) +{ + /* Configure non-Samsung IP PHY, responsible for UTMI */ + phy_init(phy_drd->hs_phy); +} + +static void exynos2200_usbdrd_link_init(struct exynos5_usbdrd_phy *phy_drd) +{ + void __iomem *regs_base = phy_drd->reg_phy; + u32 reg; + + /* + * Disable HWACG (hardware auto clock gating control). This will force + * QACTIVE signal in Q-Channel interface to HIGH level, to make sure + * the PHY clock is not gated by the hardware. + */ + reg = readl(regs_base + EXYNOS850_DRD_LINKCTRL); + reg |= LINKCTRL_FORCE_QACT; + writel(reg, regs_base + EXYNOS850_DRD_LINKCTRL); + + /* De-assert link reset */ + reg = readl(regs_base + EXYNOS2200_DRD_CLKRST); + reg &= ~CLKRST_LINK_SW_RST; + writel(reg, regs_base + EXYNOS2200_DRD_CLKRST); + + /* Set link VBUS Valid */ + reg = readl(regs_base + EXYNOS2200_DRD_UTMI); + reg |= EXYNOS2200_UTMI_FORCE_BVALID | EXYNOS2200_UTMI_FORCE_VBUSVALID; + writel(reg, regs_base + EXYNOS2200_DRD_UTMI); +} + +static void +exynos2200_usbdrd_link_attach_detach_pipe3_phy(struct phy_usb_instance *inst) +{ + struct exynos5_usbdrd_phy *phy_drd = to_usbdrd_phy(inst); + void __iomem *regs_base = phy_drd->reg_phy; + u32 reg; + + reg = readl(regs_base + EXYNOS850_DRD_LINKCTRL); + if (inst->phy_cfg->id == EXYNOS5_DRDPHY_UTMI) { + /* force pipe3 signal for link */ + reg &= ~LINKCTRL_FORCE_PHYSTATUS; + reg |= LINKCTRL_FORCE_PIPE_EN | LINKCTRL_FORCE_RXELECIDLE; + } else { + /* disable forcing pipe interface */ + reg &= ~LINKCTRL_FORCE_PIPE_EN; + } + writel(reg, regs_base + EXYNOS850_DRD_LINKCTRL); + + reg = readl(regs_base + EXYNOS2200_DRD_HSP_MISC); + if (inst->phy_cfg->id == EXYNOS5_DRDPHY_UTMI) { + /* calibrate only eUSB phy */ + reg |= FIELD_PREP(HSP_MISC_RES_TUNE, RES_TUNE_PHY1); + reg |= HSP_MISC_SET_REQ_IN2; + } else { + /* calibrate for dual phy */ + reg |= FIELD_PREP(HSP_MISC_RES_TUNE, RES_TUNE_PHY1_PHY2); + reg &= ~HSP_MISC_SET_REQ_IN2; + } + writel(reg, regs_base + EXYNOS2200_DRD_HSP_MISC); + + reg = readl(regs_base + EXYNOS2200_DRD_CLKRST); + if (inst->phy_cfg->id == EXYNOS5_DRDPHY_UTMI) + reg &= ~EXYNOS2200_CLKRST_LINK_PCLK_SEL; + else + reg |= EXYNOS2200_CLKRST_LINK_PCLK_SEL; + + writel(reg, regs_base + EXYNOS2200_DRD_CLKRST); +} + +static int exynos2200_usbdrd_phy_init(struct phy *phy) +{ + struct phy_usb_instance *inst = phy_get_drvdata(phy); + struct exynos5_usbdrd_phy *phy_drd = to_usbdrd_phy(inst); + int ret; + + if (inst->phy_cfg->id == EXYNOS5_DRDPHY_UTMI) { + /* Power-on PHY ... */ + ret = regulator_bulk_enable(phy_drd->drv_data->n_regulators, + phy_drd->regulators); + if (ret) { + dev_err(phy_drd->dev, + "Failed to enable PHY regulator(s)\n"); + return ret; + } + } + /* + * ... and ungate power via PMU. Without this here, we get an SError + * trying to access PMA registers + */ + exynos5_usbdrd_phy_isol(inst, false); + + ret = clk_bulk_prepare_enable(phy_drd->drv_data->n_clks, phy_drd->clks); + if (ret) + return ret; + + /* Set up the link controller */ + exynos2200_usbdrd_link_init(phy_drd); + + /* UTMI or PIPE3 link preparation */ + exynos2200_usbdrd_link_attach_detach_pipe3_phy(inst); + + /* UTMI or PIPE3 specific init */ + inst->phy_cfg->phy_init(phy_drd); + + clk_bulk_disable_unprepare(phy_drd->drv_data->n_clks, phy_drd->clks); + + return 0; +} + +static int exynos2200_usbdrd_phy_exit(struct phy *phy) +{ + struct phy_usb_instance *inst = phy_get_drvdata(phy); + struct exynos5_usbdrd_phy *phy_drd = to_usbdrd_phy(inst); + void __iomem *regs_base = phy_drd->reg_phy; + u32 reg; + int ret; + + ret = clk_bulk_prepare_enable(phy_drd->drv_data->n_clks, phy_drd->clks); + if (ret) + return ret; + + reg = readl(regs_base + EXYNOS2200_DRD_UTMI); + reg &= ~(EXYNOS2200_UTMI_FORCE_BVALID | EXYNOS2200_UTMI_FORCE_VBUSVALID); + writel(reg, regs_base + EXYNOS2200_DRD_UTMI); + + reg = readl(regs_base + EXYNOS2200_DRD_CLKRST); + reg |= CLKRST_LINK_SW_RST; + writel(reg, regs_base + EXYNOS2200_DRD_CLKRST); + + clk_bulk_disable_unprepare(phy_drd->drv_data->n_clks, phy_drd->clks); + + exynos5_usbdrd_phy_isol(inst, true); + return regulator_bulk_disable(phy_drd->drv_data->n_regulators, + phy_drd->regulators); +} + +static const struct phy_ops exynos2200_usbdrd_phy_ops = { + .init = exynos2200_usbdrd_phy_init, + .exit = exynos2200_usbdrd_phy_exit, + .owner = THIS_MODULE, +}; + static void exynos5_usbdrd_usb_v3p1_pipe_override(struct exynos5_usbdrd_phy *phy_drd) { @@ -1384,27 +1544,37 @@ static int exynos5_usbdrd_phy_clk_handle(struct exynos5_usbdrd_phy *phy_drd) return dev_err_probe(phy_drd->dev, ret, "failed to get phy core clock(s)\n"); - ref_clk = NULL; - for (int i = 0; i < phy_drd->drv_data->n_core_clks; ++i) { - if (!strcmp(phy_drd->core_clks[i].id, "ref")) { - ref_clk = phy_drd->core_clks[i].clk; - break; + if (phy_drd->drv_data->n_core_clks) { + ref_clk = NULL; + for (int i = 0; i < phy_drd->drv_data->n_core_clks; ++i) { + if (!strcmp(phy_drd->core_clks[i].id, "ref")) { + ref_clk = phy_drd->core_clks[i].clk; + break; + } } - } - if (!ref_clk) - return dev_err_probe(phy_drd->dev, -ENODEV, - "failed to find phy reference clock\n"); + if (!ref_clk) + return dev_err_probe(phy_drd->dev, -ENODEV, + "failed to find phy reference clock\n"); - ref_rate = clk_get_rate(ref_clk); - ret = exynos5_rate_to_clk(ref_rate, &phy_drd->extrefclk); - if (ret) - return dev_err_probe(phy_drd->dev, ret, - "clock rate (%ld) not supported\n", - ref_rate); + ref_rate = clk_get_rate(ref_clk); + ret = exynos5_rate_to_clk(ref_rate, &phy_drd->extrefclk); + if (ret) + return dev_err_probe(phy_drd->dev, ret, + "clock rate (%ld) not supported\n", + ref_rate); + } return 0; } +static const struct exynos5_usbdrd_phy_config phy_cfg_exynos2200[] = { + { + .id = EXYNOS5_DRDPHY_UTMI, + .phy_isol = exynos5_usbdrd_phy_isol, + .phy_init = exynos2200_usbdrd_utmi_init, + }, +}; + static int exynos5_usbdrd_orien_sw_set(struct typec_switch_dev *sw, enum typec_orientation orientation) { @@ -1525,6 +1695,19 @@ static const char * const exynos5_regulator_names[] = { "vbus", "vbus-boost", }; +static const struct exynos5_usbdrd_phy_drvdata exynos2200_usb32drd_phy = { + .phy_cfg = phy_cfg_exynos2200, + .phy_ops = &exynos2200_usbdrd_phy_ops, + .pmu_offset_usbdrd0_phy = EXYNOS2200_PHY_CTRL_USB20, + .clk_names = exynos5_clk_names, + .n_clks = ARRAY_SIZE(exynos5_clk_names), + /* clocks and regulators are specific to the underlying PHY blocks */ + .core_clk_names = NULL, + .n_core_clks = 0, + .regulator_names = NULL, + .n_regulators = 0, +}; + static const struct exynos5_usbdrd_phy_drvdata exynos5420_usbdrd_phy = { .phy_cfg = phy_cfg_exynos5, .phy_ops = &exynos5_usbdrd_phy_ops, @@ -1769,6 +1952,9 @@ static const struct of_device_id exynos5_usbdrd_phy_of_match[] = { { .compatible = "google,gs101-usb31drd-phy", .data = &gs101_usbd31rd_phy + }, { + .compatible = "samsung,exynos2200-usb32drd-phy", + .data = &exynos2200_usb32drd_phy, }, { .compatible = "samsung,exynos5250-usbdrd-phy", .data = &exynos5250_usbdrd_phy @@ -1841,6 +2027,17 @@ static int exynos5_usbdrd_phy_probe(struct platform_device *pdev) return PTR_ERR(phy_drd->reg_phy); } + /* + * USB32DRD 4nm controller implements Synopsys eUSB2.0 PHY + * and Synopsys SS/USBDP COMBOPHY, managed by external code. + */ + if (of_property_present(dev->of_node, "phy-names")) { + phy_drd->hs_phy = devm_of_phy_get(dev, dev->of_node, "hs"); + if (IS_ERR(phy_drd->hs_phy)) + return dev_err_probe(dev, PTR_ERR(phy_drd->hs_phy), + "failed to get hs_phy\n"); + } + ret = exynos5_usbdrd_phy_clk_handle(phy_drd); if (ret) return ret; diff --git a/include/linux/soc/samsung/exynos-regs-pmu.h b/include/linux/soc/samsung/exynos-regs-pmu.h index ce1a3790d..b77187ba5 100644 --- a/include/linux/soc/samsung/exynos-regs-pmu.h +++ b/include/linux/soc/samsung/exynos-regs-pmu.h @@ -185,6 +185,9 @@ /* Only for S5Pv210 */ #define S5PV210_EINT_WAKEUP_MASK 0xC004 +/* Only for Exynos2200 */ +#define EXYNOS2200_PHY_CTRL_USB20 0x72C + /* Only for Exynos4210 */ #define S5P_CMU_CLKSTOP_LCD1_LOWPWR 0x1154 #define S5P_CMU_RESET_LCD1_LOWPWR 0x1174