From patchwork Mon May 12 14:22:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabor Juhos X-Patchwork-Id: 889732 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67EAF1DB125; Mon, 12 May 2025 14:23:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747059788; cv=none; b=KsF0F6Tl9NsaWxKA28fSHiM+9bCQiJSrh7ar+AK4px0knje2SPlIF0x3y2u/TdUgdDpLTD6ME/QI+HmRIe4vtQ68gqIKYN2jCSbf9DbiYlXqvMIcUBbx5W/Aub17XvOxomd3u24uOQm8UgTwl3GCRHCWe1OKSOmrAn3xqEzWuH0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747059788; c=relaxed/simple; bh=UFJT5Q/sXMPC9R7Mv07uxju5+mxc7XkI5fQRoIg/6JI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=q9NFyKBsNdPGpZnpujfLUubMduUeiVxJefTGez8f1xZjBUd+g1x79yN5yo+wRSz1+KWSUl7FYy3hhw1wPShsrQ9+2/TlVbvyynLTIG6QWvsnqggLz0etIiBVLzYz5fdFOzF7sn/EwMu6TCFLuudEABC0/htN8uivDOkWqEqHWLk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jk+pV71X; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jk+pV71X" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-ad24677aaf6so209531166b.2; Mon, 12 May 2025 07:23:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747059784; x=1747664584; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=77V/U3O+cTLaLaQfV/pKGfAWbRyDYwBVlD6FPlR2wRI=; b=jk+pV71XSvwoPEwyr8S36zkZxiYzW8s64MtPuvyWmuDTS5ZtIt7S7suoKfP6cc6AFK X8vcKIBYwAmZxryLJfei/sEYqVzJ45DGYJgFKHl+iO21X8t8pObh0PlNQBYqVbmvTvvo pIT78NpwX3uBMO/aYHZIIAnFd+kmFQHFiEoHI9XxN1JsYm8OiQ5XvYtPT0cbrgWqobAH m8Ql/w2DqtyF58sLSLVNsFTfyHVDNMLo1QS018nmZmhoT3kbS7UagVnc5itZlLYvwzXH c1Fkx7eA4ik0liDhBkhe+uV+4yUSyGRyGHvwKdfIdqnTE1pSDQcfWkxFCHsl+3AgUTb4 ceTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747059784; x=1747664584; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=77V/U3O+cTLaLaQfV/pKGfAWbRyDYwBVlD6FPlR2wRI=; b=MmlDDxCmDReu5vBrOPlPIfSPQ1UyZRDjMTAq430/6Q/iwIT0+BBsR9WUyoZBjdhBW6 Mg0MourTYGdqIBIcQF4R6Ifrnj5MfO3b8eCLv8ZHmfPLxSHK8kU7WzdtBgTR3Fn3uPD1 /uwo367aDsiJeRJvRgHsv4NP27RHF7rpwMX4ajxlarNh0VsQo/DDg80xbweo8PRFy+eu d/2Wzs1n01e+RAtbh1iv437dbmjpn5d6NGLLDN5g3kv4hPrBdyEcdV85AAJRPvy+Wj6W zGje9x+uCmJhwXowdgst08KYEbJjO/gpVnsFPyWUyjIFQlNHpGGUsHn3gw0WHlh3lUFn G8eQ== X-Forwarded-Encrypted: i=1; AJvYcCUxpBbRbWBk/N/mKZan+tG8f7UygzO84WHXLEhffUWx4zo9iO19u77aLMmkuQZKHWJ1JGhFyxCZ@vger.kernel.org, AJvYcCVdCxWE0c6sMYsI7sOYczRw8GgD4T2IAs9+vyyi4pYUcIa51YxhYx63tg03rFunR9pdq75x5QCGpE0pzoji@vger.kernel.org, AJvYcCXfrV331XKW/OhQqFZmImGiTcbp95KXNuQPipU0mCW3af76DbiCKfLvXeKofyQ9eopStavERWAAk+tq@vger.kernel.org X-Gm-Message-State: AOJu0YzuWs+AkDjw5XDgAvEMqo0KX+pPLWtv3JDLZqiLoAppBYJI0YxK kI1L8nWjMfxNODBqiewLFcktr4hYjSnQGMf+WmPYw8bscrDDe5dv X-Gm-Gg: ASbGncuph+BAQlRa3JHYeVapsDQTKXhmhPSjcL/zRule54+Fz6HA9cHPMnFffKyM+oh vRLKeSEa3oAhE2y75KAXsVgrnQwOjfdZFWmhtLFxTJF8nhijeZdGf5mJHm7Ef8CzegzR3ETzJRo hKK6LcD2BLo75N3woz/8D1NEq/H13nYh7T8Eu9Ewnpxm5tzFUc7PbFp9Nzb+FNdV8wPS/hXVzdZ UrzQXjV7/m1gjxZB0fgJFTtoQfbWPyzhkZ87sc38YJqbJ59VQu5ik9kO4E4PQeRD54aELiLpMgM m5N50OOXwiPlp8LmUJVBjFUmOIrJ08KnqtseUfWm8DSdBSKud67ZcP+FBigg57Vd3SEPmz6r2lS 6oykB X-Google-Smtp-Source: AGHT+IGkK/w/ZuLuBloF3PZd71dqrbQ/RypwZRAUlWpdxXu8MgumDQHdx4Av9Rps6vM9mbswRaiYOg== X-Received: by 2002:a17:907:7208:b0:ad4:d0ba:ef93 with SMTP id a640c23a62f3a-ad4d0baefd5mr32106266b.11.1747059784452; Mon, 12 May 2025 07:23:04 -0700 (PDT) Received: from [192.168.0.253] (5D59A51C.catv.pool.telekom.hu. [93.89.165.28]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-ad2197be0c5sm619626866b.153.2025.05.12.07.23.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 May 2025 07:23:03 -0700 (PDT) From: Gabor Juhos Date: Mon, 12 May 2025 16:22:37 +0200 Subject: [PATCH 1/7] pinctrl: armada-37xx: use correct OUTPUT_VAL register for GPIOs > 31 Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250512-pinctrl-a37xx-fixes-v1-1-d470fb1116a5@gmail.com> References: <20250512-pinctrl-a37xx-fixes-v1-0-d470fb1116a5@gmail.com> In-Reply-To: <20250512-pinctrl-a37xx-fixes-v1-0-d470fb1116a5@gmail.com> To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Linus Walleij , Bartosz Golaszewski Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Gabor Juhos , stable@vger.kernel.org, Imre Kaloz X-Mailer: b4 0.14.2 The controller has two consecutive OUTPUT_VAL registers and both holds output value for 32 GPIOs. Due to a missing adjustment, the current code always uses the first register while setting the output value whereas it should use the second one for GPIOs > 31. Add the missing armada_37xx_update_reg() call to adjust the register according to the 'offset' parameter of the function to fix the issue. Cc: stable@vger.kernel.org Fixes: 6702abb3bf23 ("pinctrl: armada-37xx: Fix direction_output() callback behavior") Signed-off-by: Gabor Juhos Signed-off-by: Imre Kaloz --- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c index 335744ac831057576473dd62c5533168b243a656..43034d29292687e875136aafa530b62479dc55ec 100644 --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c @@ -417,6 +417,7 @@ static int armada_37xx_gpio_direction_output(struct gpio_chip *chip, unsigned int offset, int value) { struct armada_37xx_pinctrl *info = gpiochip_get_data(chip); + unsigned int val_offset = offset; unsigned int reg = OUTPUT_EN; unsigned int mask, val, ret; @@ -429,6 +430,8 @@ static int armada_37xx_gpio_direction_output(struct gpio_chip *chip, return ret; reg = OUTPUT_VAL; + armada_37xx_update_reg(®, &val_offset); + val = value ? mask : 0; regmap_update_bits(info->regmap, reg, mask, val); From patchwork Mon May 12 14:22:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabor Juhos X-Patchwork-Id: 889522 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9D65217675; Mon, 12 May 2025 14:23:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747059789; cv=none; b=RNQopAUL+V7WtoZ8jrbOL75pGFfRew8YAOnt0oDOHE/fJKVHnaPsEDFJLWitoNNCXKMEZAQJCVKG0D8NvjJW61kIzpvfUeRr9gcL/wAsui6X6O704dWMrcecUeQBZ3hwmPVPpzkdPiS7agNPML75CFYtdYyvW/DxlCeA6cUef0c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747059789; c=relaxed/simple; bh=tvGeMijQtEl4zbB2adDy+N3cxusRFrtzixcKMNJhiwQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BXbNgzJmiq9vmvLMfgrvhVGtL/oVxCxs0XPNSANORjSPK8S03195JugTfgUlbSfI3xx1y418BHEhih1dHCBY3jy/9vWUzD0oK71lkbMKl01YflLeLtCyqvQom6n4MTweIHie8luFUVCUDxn7+M0BngWkQonrEBhGxMhTfM2lb90= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ENmQ6FB6; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ENmQ6FB6" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-ad220f139adso536944266b.1; Mon, 12 May 2025 07:23:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747059786; x=1747664586; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=V5MMTe/1pPBKil8h8G6mXnsqfuKZKWfjys0Hze7M4Ac=; b=ENmQ6FB6F7EteUWhHopPN7XRuaSV0gPcXiZfSp1yqxWXhfhjk8JnO+GcfeKPHeybDA gSrsLK45Mjj+/g6c7U5RbcCNhV0rqBU1adjUUiJI/hvRupepv6fh6JYkz1o0JHM36XWz VhfgsubBERe1fbCGCyQVRE7Xdr3+BU0ACMJ49tjCwMSR+/I6Ts0DsZ3FU+G6C813UaUl apRLs1mfYxD95Ut/DobHa6VUqp9QE+X+KG8rATw9v0jUO1ysViBTdy/6fgAVPEQaCxSY iLqZVsKDwkAqJ0aPcjBIBueFLwzSwDkJV84+TMIanwWz8fcCZ7KFFIEXr1om06nA2LGB g1qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747059786; x=1747664586; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V5MMTe/1pPBKil8h8G6mXnsqfuKZKWfjys0Hze7M4Ac=; b=FUGHycCsMuGjDAiKPDsRATDkq2l8nheBamWezt4gcfTzVL4vtDvRQaiSPmHStL5XMM +R9A21WkP8BnuQQPyAhiIO61ke0uhY2VRpzqZMF/XruU25Nb4qM/JJKNa6xgazaUD33I WmF39bAJaPYrBfC0HPMvhDGugNnqDS1GxEHd+29oVtKmbjMyA23a8MQOKWe9IN9e5n/6 tqwBaF0gJOkhT5Pf6Ej2ESxRSmfwb+VaKOh6zZRqQY8YzLheEeEuDZI2ZurYBpzzThG/ leV539ebLCPdkrGHHva3pGzO6MF0M/Pq/DgDB8GV1dFrPdogAdNzPoHBu4T6P+5toxiV v8Yg== X-Forwarded-Encrypted: i=1; AJvYcCV3jPFoejhOZZ/1np7n4/I8U3IeoM9ZLC1Dagvafme4c/nLPTVXsSU0yQ4elrQ4xN1/+/JZpdrE@vger.kernel.org, AJvYcCXRGlk/8kSzXjClNO08F4dp1BzquriqDMJKp2r5kxquut7e/P2VY4ioV2eHHGAK69ovGbP1Qc6nEduu2bGT@vger.kernel.org, AJvYcCXxOYnKDrF4zDhHNlbjVqrmV5/WnM4HAHGPSdkxqFYKT8bZ5GnY4Fucmd+LEaS3VwMs95+CkuYbMj1D@vger.kernel.org X-Gm-Message-State: AOJu0YxAjky0L06SUwKStCp/BCpwER8vPq+9hk+3NtNk3da66PtyqHuo uVr9P5EEwewdUzD58UBRghdmRhsLgTfgRz9tpP6m+qGNskOmJ/mn X-Gm-Gg: ASbGncuXT+rnLlw8T5AUyORK5/teQt/MKca6Ocx1QghLrlnMY25gFzRbPpCpjpyF7DS lW6M0reWPl5EMXlMmrvp59obeSK3PYgdLJ0BtRJeGPkvFmIabXu/l0sDOo6PmABtoZYrI+jisje fYJGD4Kx1zxbx85QygS+WrNXKLHZm/9CbR0iHBuaIwyxNkRQ+dO9R87G+wmZ53oJ7j6LZtoZnow E50P/i2Zj+RUXIzoaa77WiiZ0YDR8E8veRxq82GWZnbdlr0Lu0JJg3woVRX1/9DZ7/2IzncKPmZ hbDDIU4SGtVNwYsmNAwumgK8EwKZ93/qN9JeBLEl98hSC6FnvdOBj9m7Aq9IK4AwoP08yoA8lWO Zjk4R X-Google-Smtp-Source: AGHT+IGg6yqgLrxnODYvbZrrlO4v+1zcDtFnVhd7UYNsTtLAVcdwUEoxhvw/4dDgWMUG+hMWyi7rDQ== X-Received: by 2002:a17:906:1692:b0:ad2:1b0e:bfe5 with SMTP id a640c23a62f3a-ad21b0ec1bemr878356966b.7.1747059785804; Mon, 12 May 2025 07:23:05 -0700 (PDT) Received: from [192.168.0.253] (5D59A51C.catv.pool.telekom.hu. [93.89.165.28]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-ad2197be0c5sm619626866b.153.2025.05.12.07.23.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 May 2025 07:23:05 -0700 (PDT) From: Gabor Juhos Date: Mon, 12 May 2025 16:22:38 +0200 Subject: [PATCH 2/7] pinctrl: armada-37xx: propagate error from armada_37xx_gpio_direction_output() Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250512-pinctrl-a37xx-fixes-v1-2-d470fb1116a5@gmail.com> References: <20250512-pinctrl-a37xx-fixes-v1-0-d470fb1116a5@gmail.com> In-Reply-To: <20250512-pinctrl-a37xx-fixes-v1-0-d470fb1116a5@gmail.com> To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Linus Walleij , Bartosz Golaszewski Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Gabor Juhos , stable@vger.kernel.org, Imre Kaloz X-Mailer: b4 0.14.2 The regmap_update_bits() function can fail, so propagate its error up to the stack instead of silently ignoring that. Cc: stable@vger.kernel.org Fixes: 6702abb3bf23 ("pinctrl: armada-37xx: Fix direction_output() callback behavior") Signed-off-by: Gabor Juhos Signed-off-by: Imre Kaloz Reviewed-by: Andrew Lunn --- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c index 43034d29292687e875136aafa530b62479dc55ec..e0c8eebf40588a1b49b80e2a1ddcc2a35fa7c07b 100644 --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c @@ -433,9 +433,7 @@ static int armada_37xx_gpio_direction_output(struct gpio_chip *chip, armada_37xx_update_reg(®, &val_offset); val = value ? mask : 0; - regmap_update_bits(info->regmap, reg, mask, val); - - return 0; + return regmap_update_bits(info->regmap, reg, mask, val); } static int armada_37xx_gpio_get(struct gpio_chip *chip, unsigned int offset) From patchwork Mon May 12 14:22:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabor Juhos X-Patchwork-Id: 889731 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70947219EA5; Mon, 12 May 2025 14:23:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747059791; cv=none; b=fnL2wCm1lteVsD1cZmm9bkJNmpnlOZLmMjaktxRFXtQe4TSPAtNoQLA6hJtIxmjlSKL26H/x70dB3wvIWHEsCe1MbtiM2JnqipvPHZbXSywtLszv3aHs1q+cJPoLV8T0Whns1y5HSe9EgQAlZ1MKIhWoL4RhbkCgUSMUs0Bhoq0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747059791; c=relaxed/simple; bh=5Qph+BS8SehMxCQ3fU26TgLn80vRDcqYeQjtcgvN4BM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tilxrKsnEqej6zQrP/ThT9sjUss079SicmokrENX9YdVa9QSKkIuEYqYPJdofiPuRz8gtN/pLq2THzLxYqbIQLTaGzOmmExnN4nLHYK0WoNmFcDBLJCVe80HgYE6hWqPt8qIeM9tVeqR4cxsZmztMXfv9EdaZavgiESrtbMFclQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WVPBmKc7; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WVPBmKc7" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-acacb8743a7so766729166b.1; Mon, 12 May 2025 07:23:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747059787; x=1747664587; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=pNbP7UQ6QBCtzJmBLQElQ/Oiqog6oGM/rgRC50EdCKI=; b=WVPBmKc7b8cXjHAmqs1ueQzOg1LbCfgepS1FhAjwEiUtAPoH5kqC/Vxy69ckzPmnDm YthmtLRjS+W+Kb+REqnGYmYdCwnNd51KLBLC8IWjfWO5QblKIN3/hQU5sJK1hZzY3PDW XkZ2rnRoyG8in/X9tkHUIjd94NOq6Tb4h2FM4XyJFz96AtyFkNAbFZraClI0FQlFNxsE O+CsgMcW5kMNZdy6Uxtvyi5xfoeKbtDaGvcB7FWK0fmLN96kKCCMy84URs+dcyZBnn2m vGgfgsaEMAo7ysdW5K1JX2R2HzNdOvVkk5tDm/tWlZXtsJez/pb4F89UNGwrf+PW98C/ QrpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747059787; x=1747664587; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pNbP7UQ6QBCtzJmBLQElQ/Oiqog6oGM/rgRC50EdCKI=; b=FU/ITCLYjWAxIawBAY6TvRkvNfy+o7qdNb+/sZzPxQV90D4Zw2If2+h5qDP77eUWao LRNrGGfjjqZseZEa7D3mOS4My3io9GcUZpDaB5JikCgW6WuXf5WF+ysb0w0IVaDg22kI G48Ii+jy+Bt3Zg48bem8Us2WDbn3t9onAyLZmCCs7QpVaRPSD0uOnwakEysThTl4CSGr vTGVA4f2wN6FLoNOQyYxE5HKuRPmSRrSHaOdvhA1gr4n+GZr5FpwEYoVJiS+nLxKUqgI FfT0bo4HP23IssIIbqcQJO3Yx0sN5d8QTpGkJfIeW+1ZcUOnxAKHBa5UYwmwIeEm3Pri ztGA== X-Forwarded-Encrypted: i=1; AJvYcCUhwXK97QvZ57O/DWeu6EXuQRelx4qADDuszT863iiXJjo5kHhefby1gJG7F2f4TXTweQc6I19/QM6YPl63@vger.kernel.org, AJvYcCWVcYh9TeL7b4JrhmBQHmcjCy8Kuvfa6wV29VNQaN2ttZI1lebdYO/r8sCrpjyKWssFh7TuKhzF@vger.kernel.org, AJvYcCWfHkT9zu/gD0fcpUwL8YrmzrrlBl1GO0jGv93DvAeOcoJX3QNul0wZ3WhARpra3SfrFmnj9ZWz7Zzv@vger.kernel.org X-Gm-Message-State: AOJu0Yyi22b9WAlCqjcMVfb6SEEXwr1xtxZ6513H3bKedmLM19cSWhVG zDAPQ7oZuMAxGH2TT88ffwbUvAryJm6l093Bbr8i68KNews2g97n X-Gm-Gg: ASbGncu99mDetlI6CyemYt3Gos7BDiQ4tKVZOLmdeFaj57EkZqvGIdyOmEeUnBdTWN0 LqVBXjut/W1oEp+zsw1D89yYrzuxrTCrCNfFy5rr56xZuMe1BHYH+XGuRx14fHjM44UU5k1TV3v B2GvY5+wCwwVtOIz1XYJ5KwbCXnaPZry0IP03n0headVNynkJHLdx/LC3aGs4u9tG/EBF/7ViNO wTcVtQ1HvGWOrwKRozkhZqqSIsLEUD9HO8OElUUVJGdUm0NjXev9hFeHAsuoavIUTEpFZVdYmWA mNR7Xux5gI0mHQ/jAksWFhZMFegPi9ZLpOcnP1i/4juUMi6XlvLBNiNEFJF5xCsFvxe9mvhp6Vn w3eVmiSfOanHfvXw= X-Google-Smtp-Source: AGHT+IEAuWJVxQMEM1VpSI0jRTrCZ9DF6TOGQv6I7s6vfSy+SBEpvant7r1anHxZTeAjxxIQEyYQ9A== X-Received: by 2002:a17:907:a089:b0:ad2:27e6:7e62 with SMTP id a640c23a62f3a-ad227e6801cmr917487466b.27.1747059787151; Mon, 12 May 2025 07:23:07 -0700 (PDT) Received: from [192.168.0.253] (5D59A51C.catv.pool.telekom.hu. [93.89.165.28]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-ad2197be0c5sm619626866b.153.2025.05.12.07.23.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 May 2025 07:23:06 -0700 (PDT) From: Gabor Juhos Date: Mon, 12 May 2025 16:22:39 +0200 Subject: [PATCH 3/7] pinctrl: armada-37xx: set GPIO output value before setting direction Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250512-pinctrl-a37xx-fixes-v1-3-d470fb1116a5@gmail.com> References: <20250512-pinctrl-a37xx-fixes-v1-0-d470fb1116a5@gmail.com> In-Reply-To: <20250512-pinctrl-a37xx-fixes-v1-0-d470fb1116a5@gmail.com> To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Linus Walleij , Bartosz Golaszewski Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Gabor Juhos , stable@vger.kernel.org, Imre Kaloz X-Mailer: b4 0.14.2 Changing the direction before updating the output value in the OUTPUT_VAL register may result in a glitch on the output line if the previous value in the OUTPUT_VAL register is different from the one we want to set. In order to avoid that, update the output value before changing the direction. Cc: stable@vger.kernel.org Fixes: 6702abb3bf23 ("pinctrl: armada-37xx: Fix direction_output() callback behavior") Signed-off-by: Gabor Juhos Signed-off-by: Imre Kaloz --- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c index e0c8eebf40588a1b49b80e2a1ddcc2a35fa7c07b..8d93d36af63ab9496376219454214c05db30971f 100644 --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c @@ -417,23 +417,22 @@ static int armada_37xx_gpio_direction_output(struct gpio_chip *chip, unsigned int offset, int value) { struct armada_37xx_pinctrl *info = gpiochip_get_data(chip); - unsigned int val_offset = offset; - unsigned int reg = OUTPUT_EN; + unsigned int en_offset = offset; + unsigned int reg = OUTPUT_VAL; unsigned int mask, val, ret; armada_37xx_update_reg(®, &offset); mask = BIT(offset); + val = value ? mask : 0; - ret = regmap_update_bits(info->regmap, reg, mask, mask); - + ret = regmap_update_bits(info->regmap, reg, mask, val); if (ret) return ret; - reg = OUTPUT_VAL; - armada_37xx_update_reg(®, &val_offset); + reg = OUTPUT_EN; + armada_37xx_update_reg(®, &en_offset); - val = value ? mask : 0; - return regmap_update_bits(info->regmap, reg, mask, val); + return regmap_update_bits(info->regmap, reg, mask, mask); } static int armada_37xx_gpio_get(struct gpio_chip *chip, unsigned int offset) From patchwork Mon May 12 14:22:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabor Juhos X-Patchwork-Id: 889521 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D92D21ABD3; Mon, 12 May 2025 14:23:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747059792; cv=none; b=BRif4DMU2/AVKxf4B13fVZ3fQAHmq6gOzNP6dicdMz9vAMKWPWazglU5NHisoFfPgDFKKVQUmIgeW6IltCIZdprO8qUFWOsIEPVRouEADRc4LDuXHRpSNYmPy2yPC9w++NCdbUzV6u9xVKQ8DOudWpu1vj3HwV9zs3PNcIT3F/s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747059792; c=relaxed/simple; bh=GDOnWKWk4FBHNilM4Gzr5vCP9ujAJPgfrka/zdbU3zI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nsbh3LAh4lIQDy9vfpJIpCVPp+7TfDdrzcj3fY7o+R3ctYcuuAeilPSpuVBBPSI5Ej92tN70cCNIFAK8cVU/FZDXQZ6h7B6ylbrbj+RN9vtrpqoIrcf8fwz5O2rX2SNTsDNPRBfSn1YT7IXtuXHyC5KwcFvm5SrM0v/hDZF3vbI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LhwmH9p0; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LhwmH9p0" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-5fbdf6973e7so5727144a12.2; Mon, 12 May 2025 07:23:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747059789; x=1747664589; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/guz4pLuDNTxVy8lJnDBDsZGEukuirfrZgqdNdAPX1o=; b=LhwmH9p0MFwtdLXgmCR2cRP3Zy72xc5Nm9jcHhMCmoN2sg9lOcGlmD6hjxsgzcYk6M 9Ec8bTgO7i4OFVn0TCQLv9ZKQ3DxHeUKWlOoTCO0GpxUgPCNGpI8Bludc100LK1oc+3I BYt56C4exXX8L0fyGUZXmec2EjqKhshEVy5XG34z5wzVg2FCcHWLDdDX6gTIA4uLhH4U HWai87jlNrI4MsJ6aOWNofW5gUYGTk0ArsI/seHwtoa9H8xtvRTvmLjMtO6B81t8xI71 JDzXsytT8HSFoJZaNRCAYGoGTnif6bfbhAlAL7bE7JoTcFS9Czs4sH6/gUmJvQpk/LKL t3Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747059789; x=1747664589; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/guz4pLuDNTxVy8lJnDBDsZGEukuirfrZgqdNdAPX1o=; b=JisF0gI5+jBMCvWCS/f1bH+J5PF2XSp282Ts6oOBCIYYMKyFAuuXQ+ncyFqQ9fj9kR OXQV3PBARxkaSqUz9nOHQrgy1IWAmpkQJvBvn0oaqgbYlN0e+TfVLjJ/J0EfxYVnMn+B u12M6GyHeswBo4hKKF9qr5KQwKb/KQVisDc7dtLJt8J7P9ZmyjuQ5kSDftQ4pNPDUUfz VkOWhi4atCFfCfgdudLQ5hFVvUeqpGVn/8l3ONEXaW4TCeqZoP2/FoQBy7Qo2zNF8Tg+ vroCKmXASSCClYdYZLJPu8fOjAxiZUGSGLp8t30HraW2DwkBWk8bmi0MiZSqAS/zPD/m 1n9g== X-Forwarded-Encrypted: i=1; AJvYcCVYpLEmoyuTPe+RfYKa08e1iNw+fNmzHubNYA+uLpFWzNvwhfM6L+3E6ePvoNvIXuts1lezIPnjFcJ9WXey@vger.kernel.org, AJvYcCVp+IvqSVKirnAF6P7nQyFLM1xAQhiB5ckXexHNk/49tn5dmjGDWdeWpj+Wap1qDnHEu7NZxz/U@vger.kernel.org, AJvYcCWiqqqVH0YKdcEfP7bUOgtYhNeb8+fBnmjYZuirLuE1VpRXsLQi53O9FEMYRMkFpraw6nIysbpdR7Ir@vger.kernel.org X-Gm-Message-State: AOJu0YxO8l4XcTPJXdZj1AqDFI0TDqpuei/64uaX5EUKAABjTEIjTsr4 mkFAhzqDUS3ry4onwwgKbZ/0FQsCSxsvEye/dZIDZYb7KaTGdZf+ X-Gm-Gg: ASbGnctKmD+O9L4QK5pUl8Ae2Lf+SLDc9Q4GBnBmhySCrtIA/ndKHELB25ANe3UQhjv mooXJwd0Ie/80qh+1lURSldOUK8n04jlWsWPjxzaSukAZ6H9lQ+J1ONfQfgc7Rd2ZBze9lmH4z1 I7mi+9wXt4icHwNQ4nE8tDHWVkz+IrUES6RsggXC3q23APh6VGkNQhug3Yc2Xra+vgZ71T7JbWL wwSsSq7k+lgNq9ni9lupV9LkvoZb0WVFYFSpNmgt0RE8uy63otZhg3UecoS5Uls+7AsriPwwfIm 7ZyA7KQEhtG7IKQBWGNMts10Fz6roDwyhw/EBQv943O9uBl9J3idRWuMkWelaqO7hg0TJozxKpc 647f6 X-Google-Smtp-Source: AGHT+IH+FO5w31tHr6oUFBIoGn7EGEzlO+Kpe05iZvKG+L2hkO2L/WD3SeYo/NmL/boWglxIzee18Q== X-Received: by 2002:a17:906:d201:b0:ad2:1d1c:1c8e with SMTP id a640c23a62f3a-ad21d1c1f24mr934769966b.49.1747059788576; Mon, 12 May 2025 07:23:08 -0700 (PDT) Received: from [192.168.0.253] (5D59A51C.catv.pool.telekom.hu. [93.89.165.28]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-ad2197be0c5sm619626866b.153.2025.05.12.07.23.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 May 2025 07:23:08 -0700 (PDT) From: Gabor Juhos Date: Mon, 12 May 2025 16:22:40 +0200 Subject: [PATCH 4/7] pinctrl: armada-37xx: propagate error from armada_37xx_gpio_get() Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250512-pinctrl-a37xx-fixes-v1-4-d470fb1116a5@gmail.com> References: <20250512-pinctrl-a37xx-fixes-v1-0-d470fb1116a5@gmail.com> In-Reply-To: <20250512-pinctrl-a37xx-fixes-v1-0-d470fb1116a5@gmail.com> To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Linus Walleij , Bartosz Golaszewski Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Gabor Juhos , stable@vger.kernel.org, Imre Kaloz X-Mailer: b4 0.14.2 The regmap_read() function can fail, so propagate its error up to the stack instead of silently ignoring that. Cc: stable@vger.kernel.org Fixes: 5715092a458c ("pinctrl: armada-37xx: Add gpio support") Signed-off-by: Gabor Juhos Signed-off-by: Imre Kaloz Reviewed-by: Andrew Lunn --- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c index 8d93d36af63ab9496376219454214c05db30971f..2e88a0399d1a205064b58890db6477e2202bf311 100644 --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c @@ -440,11 +440,14 @@ static int armada_37xx_gpio_get(struct gpio_chip *chip, unsigned int offset) struct armada_37xx_pinctrl *info = gpiochip_get_data(chip); unsigned int reg = INPUT_VAL; unsigned int val, mask; + int ret; armada_37xx_update_reg(®, &offset); mask = BIT(offset); - regmap_read(info->regmap, reg, &val); + ret = regmap_read(info->regmap, reg, &val); + if (ret) + return ret; return (val & mask) != 0; } From patchwork Mon May 12 14:22:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabor Juhos X-Patchwork-Id: 889729 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D03D218845; Mon, 12 May 2025 14:23:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747059804; cv=none; b=RCQujQs8c35ip7qwHoNI0nEAeULNkuN+gF0DGZfDI4sHWzAxzgwAOyBFiAUeM4SUwTJWRyd9tNstsOirSO702qr4LkG0Wey5cjPcPKbscPYAYRJwhQ6WlshrVyzNeZSYKR8A/oJzZ/dBlmEeeAeTORXhGmAZVRgz3PGyas6eEk0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747059804; c=relaxed/simple; bh=tPQCzLZn2R2UK9DRrnxinSUKssq3JGAVyBqb0dtvrEs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=MJIk1GjKyUX+UC50morS6xx8kYSQv73bp0aEvBC/ibffaZoxGWcFHGpXbQlKHGM14oclHVNwhckRSTn4ycCeI/PnVwY0YUbGSm8mJWb8YIEI67g/V30UjNDYU6s0xFlqA/n3EBZsoXn/h21QSFPbr3P1y5EUa3pD+2eY5re19y4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QPcpxdVk; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QPcpxdVk" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-54e816aeca6so6355507e87.2; Mon, 12 May 2025 07:23:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747059800; x=1747664600; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3gAHy2dqHD8XlNE+NQO8OdbzNGj6fStBzDiksNNBgM8=; b=QPcpxdVkMdojOFVWdIht426iF93H/n2bHhFpVyAtCqtHE3naJoxu5rkr/PzsE1+V6r f7dlJU5Y22wDM7WHZ0vyqUwMK6REcLKpfiEw+NSWLIjPzxQupDhIR/pzVVhMzggmnk9R fO0KAjKrvi4eSNbeLiRYSRlLWuhYBpQ9ZdfugNOB+tJ9FmIk/Aeg2Xzq58LQASavhibL W/Acs+/01K7N+99ggmzfeaakIptvAAHrdvisYCiCc27cBmhkGr5V4VuARveIU8ojTuI5 nVyxUSEOsAm0WyYlFJbjX10sPWl8f4VuKiavBzAcJbND8h/+CvlJSlA8N/z9f1gZHD0c c71A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747059800; x=1747664600; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3gAHy2dqHD8XlNE+NQO8OdbzNGj6fStBzDiksNNBgM8=; b=mK70ZacLELqUVI0QyQxeoQNu59Yip5hEAoOyvxfJwtNOV3Pv+6qLgHq/3n6cIaBl+V MA86CgLNzSyl6uGAwo/3/12OVibJllt0rXRI44XwwpjlPYYaPNIAxqMD5T6M5zZ0+1wi f2zuf/jdkyi83q5MV2NyaR6SIwYClhHjqu+XSiYA9+uKxYuVW6BppkjgcsqmBwVQvcb4 d3umRTzFMz/VlzgbTEoDEVAa/zeZRd2eEAXgVH+FeYqfEWRt+5BWdoqCOEoetbsSE7oh b5QsrTmsJaDRjp08u/WI8THHl4Z3v8ojkTv0R4S0Z3BbDpJbWrH0Q8opiMylNgigyWax oihQ== X-Forwarded-Encrypted: i=1; AJvYcCUFo7G6npiTxgCkcFxdmFl4LVgE38XpiNuve6R4yI0ASyGIb3MQy3mJnGtcfOT8PzYVKuOwptWC@vger.kernel.org, AJvYcCUM9DGTX23dSRQmyuarg8iAYwukdpqJuTMJOGNjSz4Q85oB0VHYGiZ4I1BG0jErSOYsAe3za4Il3PW9@vger.kernel.org, AJvYcCXGsugjEdmUAcMp9dg77pMknKa3a0jrZhW0gtYZnmgIl8XgAGpkvoZ/j/DfH4MeYtUjBdaGhwc7mAmLymPp@vger.kernel.org X-Gm-Message-State: AOJu0Yy2hNBgnr9cxVyX7BpHaQ1AiVvmBw4hTZ++LVkco5ZBHaxW6pZ2 tJnje4yQYf27YbErNBTAzUQk3aPYV+Uk3IxsofUez/XBsygnAx2jwsBJDA== X-Gm-Gg: ASbGncsUm+zA11cPuL1H3IXxZldIwNer5lNcsD1zcWAA4wYt0p5NdqiDM9myF2aPE2a Nmz3hM2FrEccobj32GWtELr7RLFHMmlnDROUc2GlxLI7F68x0tPIClI6o9uBeL/5NtfaS5Ma/1w a99JGzT6DlTEdzgVuMzKP+Z8mAPG+y0T0p4A1n4ELueGougBRdMyj89FOVpDqwXRjKX8bwT74gj bjdGSZrPqDJkc7WZg2KdkijkqKMHtubQbJRDw6mpfRX0XjneWeoyaOT7BmxzAe+3I3AD7MDTOxq 3yVc4F3GanVN948Md86Xqulm7RyW4qskAGTWyVPINgvrjbids4O0pbIAojnPzpwtz1PHCCo3WII 2R+/T X-Google-Smtp-Source: AGHT+IGgwLVhY4Dppc9nKpM99+nmIcpUTBUiHOn5t/pN1WR9JabBYoC8Dok1NUb/mKsm5Hmdd7j+iA== X-Received: by 2002:a17:907:613:b0:ace:f078:e08b with SMTP id a640c23a62f3a-ad21916975fmr1032950066b.47.1747059789964; Mon, 12 May 2025 07:23:09 -0700 (PDT) Received: from [192.168.0.253] (5D59A51C.catv.pool.telekom.hu. [93.89.165.28]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-ad2197be0c5sm619626866b.153.2025.05.12.07.23.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 May 2025 07:23:09 -0700 (PDT) From: Gabor Juhos Date: Mon, 12 May 2025 16:22:41 +0200 Subject: [PATCH 5/7] pinctrl: armada-37xx: propagate error from armada_37xx_pmx_gpio_set_direction() Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250512-pinctrl-a37xx-fixes-v1-5-d470fb1116a5@gmail.com> References: <20250512-pinctrl-a37xx-fixes-v1-0-d470fb1116a5@gmail.com> In-Reply-To: <20250512-pinctrl-a37xx-fixes-v1-0-d470fb1116a5@gmail.com> To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Linus Walleij , Bartosz Golaszewski Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Gabor Juhos , stable@vger.kernel.org, Imre Kaloz X-Mailer: b4 0.14.2 The armada_37xx_gpio_direction_{in,out}put() functions can fail, so propagate their error values back to the stack instead of silently ignoring those. Cc: stable@vger.kernel.org Fixes: 5715092a458c ("pinctrl: armada-37xx: Add gpio support") Signed-off-by: Gabor Juhos Signed-off-by: Imre Kaloz --- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c index 2e88a0399d1a205064b58890db6477e2202bf311..aed0069b085ced5867993e95e0244df7ccda556d 100644 --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c @@ -472,16 +472,17 @@ static int armada_37xx_pmx_gpio_set_direction(struct pinctrl_dev *pctldev, { struct armada_37xx_pinctrl *info = pinctrl_dev_get_drvdata(pctldev); struct gpio_chip *chip = range->gc; + int ret; dev_dbg(info->dev, "gpio_direction for pin %u as %s-%d to %s\n", offset, range->name, offset, input ? "input" : "output"); if (input) - armada_37xx_gpio_direction_input(chip, offset); + ret = armada_37xx_gpio_direction_input(chip, offset); else - armada_37xx_gpio_direction_output(chip, offset, 0); + ret = armada_37xx_gpio_direction_output(chip, offset, 0); - return 0; + return ret; } static int armada_37xx_gpio_request_enable(struct pinctrl_dev *pctldev, From patchwork Mon May 12 14:22:42 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabor Juhos X-Patchwork-Id: 889730 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3383921C170; Mon, 12 May 2025 14:23:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747059794; cv=none; b=E15ibERLAqqZvKN0ZL0CCYlU3Sl4Jb7ktXLfYJHHVdVWEt4kuL78q8T9xv3IstcymAf3adFulssjlaWkTat6siaFw/ZH+h8q2lCr7FP4o6tsJUXYlhB97kfpeh5C0C0ZAaXrBYc4AHhEHRSDnIt7/CcPOdM+49Y5xwe+stS7tfI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747059794; c=relaxed/simple; bh=XxFOzwpfwLxWv53veDg6BCFF5Fv01aAKx6UgAlPxEAk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rwlyB4baBzDRtIDsMHMZmLSYQsaPoAEkbcFSuxd2lt1PyBY17+EodcgdIQdV25sOgLXtsvMFIJluMe9+QzqO99mRUEbLNPqWAcxPtgmSbFNodET2iCUHjgw9cDxjV2YnN3ogWaSxNLeMUPNMhQgy3H1W56bCtEMHDkrc3+vf/s4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DQz9LDL/; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DQz9LDL/" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-acae7e7587dso701503666b.2; Mon, 12 May 2025 07:23:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747059791; x=1747664591; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=CStQ3me6L+6+JT5UQlE0AR5A7HHsIVocJn1DO4HPocA=; b=DQz9LDL/jtmD0Oavzf2K6YSBMbC5EEFeZV6JBGFbFzMtKOVCc05wQXL7hYDvuQN3sU bBjq77h6HgTnKLa27mBTe1yoftP87HsCUXZdURovs54/SzmmZnsG5+WHwcP5DzwUmzpd mIVnIGi0UMP/Z0ASts12IcDkqvU6hMz8rI6Fc7EeI7IRFC7ufxV+VsFSobHZ6raZTTux RqJtfZofjbBXY67lMTM/YeW5Xpp28a02PPJgS4AmjpkNTlU7tG8zFInFiXANkKfKFFo0 ImLXAddh6WjKRJZqmaGXOLun1fb0o41ihC4fiUink8S1JX0Q8inTCp0lJHwcmWjHee4v dV3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747059791; x=1747664591; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CStQ3me6L+6+JT5UQlE0AR5A7HHsIVocJn1DO4HPocA=; b=pDh7YIJ3HcYz+f9tIOHWzcX8UK9oeqlKCRmdjGiae9JBupuQlVo6PQ049LKiBO7HGf 1yk5OEB30HxW0mhBKRJwZ1tAtlhhdE2eW/5rMDEISkBx3ESarj/9WDNBNFScy1Ng9EXr 2KQ2hM5U8v+rhBh7tIV0DOOvMuYLGCBxlPQdVrm34Pe+67vnV6DTKFtBeZFzjzs/wm6y 51TULbFwO0bb2IM713jMVWPbhSq5lYNxIXe4YnEZUIFKowqb90cW5FN0teiisv/H0vGM gL4snHvSQxF3jHaDsKmXFg9d0UeVpVEkgPz6ASJD/mTlFa+Wtja+3HFjrTHUn2qcOrd5 p3oA== X-Forwarded-Encrypted: i=1; AJvYcCV9qpEIJLmd7diyxDx8AY9ppa2VXvcomxupgDm9+vedOIgO9y1TNluMo5oBFh2bKQZ+kRH2ZVB5@vger.kernel.org, AJvYcCW+Ii4NM+59hQKjOiH+cZopoiXrtayLrNEweJ1mbphuUALXDdxZIHcAz/KqRb7CowK/cw2QupLaSSgI@vger.kernel.org, AJvYcCXUWcKlOxCHks1YVNQX9pMfCXYOMJKvKwvgmUYMWwPRHn3SY7uBjq24g9uuPjj9EZjzDSC80dTlY4Ui1XSb@vger.kernel.org X-Gm-Message-State: AOJu0YxPwUP8YOexM0boM9f4CvrdVuKKlI1vftJAbf4hNXFtMscEGBja tr8loKdFg3aEdf08tmDIO37twrQBA1iwYsvCpdqDTf/0UmGvIwiw X-Gm-Gg: ASbGncsDJVrzv1v45nMmwQK9vNZ86NQvhkiUIlbeNDGtWcYk+cu9obJ3D1IcIpUyaIZ H2610VqFJpMMPEqzuwmya5sz81Agka4NN7vu9yC701u5NEf7DtwG5T6YI5OIU/Od4te819RO9mn Gzm/753VF7iNmcmJzbWehLUzQ6MhQL4m2AzWyGH+11728chdDjc+qD/H0Zt2f/leM2jIX0cnMDO 4g1v5D2+aG3HrFZaMQjFlCBoyq5F3voav+4D8hQ2q0iWgC/ny0XANvoz6Bn4D0AoULhc9DmwDJ7 ZitRV/4TQPRy+yq6HfrIp3mWmCESbxg3BxhUkZRhGxE3RlU6Gui4YNn6GSBJzE/nVkQ82i7WIHe we+cF X-Google-Smtp-Source: AGHT+IEJ8JuqYsFOPLuXdkL4qUNKbfTaZqb+fmyTLkZmdZyKkJWiwhPAs4Y4Rf4gMO6EJazhHRUlCA== X-Received: by 2002:a17:907:1b1c:b0:aca:d6f0:af0c with SMTP id a640c23a62f3a-ad2192d4a49mr1292462066b.59.1747059791258; Mon, 12 May 2025 07:23:11 -0700 (PDT) Received: from [192.168.0.253] (5D59A51C.catv.pool.telekom.hu. [93.89.165.28]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-ad2197be0c5sm619626866b.153.2025.05.12.07.23.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 May 2025 07:23:10 -0700 (PDT) From: Gabor Juhos Date: Mon, 12 May 2025 16:22:42 +0200 Subject: [PATCH 6/7] pinctrl: armada-37xx: propagate error from armada_37xx_gpio_get_direction() Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250512-pinctrl-a37xx-fixes-v1-6-d470fb1116a5@gmail.com> References: <20250512-pinctrl-a37xx-fixes-v1-0-d470fb1116a5@gmail.com> In-Reply-To: <20250512-pinctrl-a37xx-fixes-v1-0-d470fb1116a5@gmail.com> To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Linus Walleij , Bartosz Golaszewski Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Gabor Juhos , stable@vger.kernel.org, Imre Kaloz X-Mailer: b4 0.14.2 The regmap_read() function can fail, so propagate its error up to the stack instead of silently ignoring that. Cc: stable@vger.kernel.org Fixes: 5715092a458c ("pinctrl: armada-37xx: Add gpio support") Signed-off-by: Gabor Juhos Signed-off-by: Imre Kaloz --- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c index aed0069b085ced5867993e95e0244df7ccda556d..18c6c5026b26c294ee65e3deea02d2e852e10622 100644 --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c @@ -402,10 +402,13 @@ static int armada_37xx_gpio_get_direction(struct gpio_chip *chip, struct armada_37xx_pinctrl *info = gpiochip_get_data(chip); unsigned int reg = OUTPUT_EN; unsigned int val, mask; + int ret; armada_37xx_update_reg(®, &offset); mask = BIT(offset); - regmap_read(info->regmap, reg, &val); + ret = regmap_read(info->regmap, reg, &val); + if (ret) + return ret; if (val & mask) return GPIO_LINE_DIRECTION_OUT; From patchwork Mon May 12 14:22:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabor Juhos X-Patchwork-Id: 889520 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8400F21C9E8; Mon, 12 May 2025 14:23:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747059796; cv=none; b=Rfyt7Mv5xUJhDqgqWoAV0/P0g0LjtymWd4xgZz8O0MwC8HHBvD8UTSVppM0MMdNe1/K0ehJJ6xF6WWx6xXdCpIo5WN4eUTZsi/IvbcAQpLRuYactuMK97aS7DrrZb0TuXM8iSZ0sFqMWbwGXa61OAiCZGId6/aC63ZcOdD7QCMY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747059796; c=relaxed/simple; bh=ZLTORN5u7xcGbuKsv3Ru9a7w59Xjk8sOypfmX4XRREY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZrCgGqmAjP6Lff+NZVmg3/oKmZTh/2q+JjGiXsM02w2Weim8EK2LhGw0GIaxX+S5fvBDN2DcQ7hr+qBtnkwTjapqQwUAd+mZTNiqs7xyoaMDvqdq7m8snjufEJp5t6/HEXZtVOuYiIDdnNIjvTAgGGKEjI01RfykIufMstJ36Rc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ipULPwnM; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ipULPwnM" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-acb5ec407b1so787115066b.1; Mon, 12 May 2025 07:23:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747059793; x=1747664593; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=TjdqA5SphZm+l2ts69ztB+ZwZbqHkrkuYbQuDIwGCqA=; b=ipULPwnMmdnzCMoF8BDGF+AcMIKvZ2fpHk+VIScUcZ+PlsMkSzpVJJkRfcm0zw370+ mCJ6TYZPufzR6LebcEz3V811sdYBphyw8kBJoH5o9U/Ag4jBVnvXZ9GRnpvPEpjPvxU4 wTWEWIpNCq3Vm93bzI1AOh21BKDDRDA7X0OYOQ98de+p8JDqaz0+1nW+PIH9U/PW9c6m xcjsHwK5rWuQowEW3dV2Lk/NcoDkpyBXyG8VXl0oYr2Xaz1BAtqZ64Y/P79oHJ6pAnA1 SaTXsus49ZGjyK9CaCgj5oFPEtrnb94UqT2ia+zjf6X28xBsRH84LQbBRPmVu+1/0UU4 Qh4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747059793; x=1747664593; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TjdqA5SphZm+l2ts69ztB+ZwZbqHkrkuYbQuDIwGCqA=; b=H1WaTxE35xP2C7BtXoZEX05llfTjDT5fehx8uBnxt9sL3ovaqb9lv6T1OiTHk+j/dp KFQ4y57GqDW6PQjugnCCZAuWVBH1Jv7KHxzGjP7IPf0uUweMflIKmJiJnV+4tb9QYKOe BVL+6FtiX8ASfcs9IJosZNT8ymV6GsQnQT8UmLDj66vTrHl0LqvtGoLMuhr4g1s6zZGc TVy4w+6b3R9EgkvsN7LNkhugK+4qCX7xI0COZJRgyx69UTzzL4Fam4plKr9sZJduvXm4 Z+UgIsqH6cvAXF04ex+zi5OzmqXL4MYEz9g5e+Xzdq8HzRyFJPx2Ah0XSR81Zfme4VKO anOg== X-Forwarded-Encrypted: i=1; AJvYcCUUqyo1uXYGToJJ8dVw1I4/uhhy5OHE63+qydFdFpj250EedAHtfmzdO5l7N2lFiYNktm++a+xik2FDpeCE@vger.kernel.org, AJvYcCV7KS7HYYhM+1egXkPUC156jAj12sHeyRQzWZair6bwWk4RyJyQPzge/OkndcR+X4X9edRJi9FyfOy/@vger.kernel.org, AJvYcCW13Dp2dPnLj/y3i5kyZMVt6IYsX6u60F53p0xWJMLw9bG47D7aM/qjhrNRQrEzqfBvmrfznLQY@vger.kernel.org X-Gm-Message-State: AOJu0YxCGdBsWAc3CdwKp/eYSHR1HRHh2P4YesmH1hRkqE8+JB8UEQ7X 1rz8haKSCaX7QoJk8rM72hggeSMp/OtlrcBCDIRr3nevWV/Wk+FM X-Gm-Gg: ASbGnctJ0GvJPELcXlwgOjAf6k3fGhPTrfEsHyTMbXdFKuapcwt76yl22WJX9a2qqt6 smhUueXQv2Sq2fN76M1p0cwIIPCooDH+TVTf4qFUvOxfCQmL6o5mQSC3GaFtHK79wKA5zkfbbBi ZGVdZrkipB/lQNsYH1sXRANikiNXd4IbTa/4cecgg/ae539tpokEvJGedCn+yV05Uf7WjSRbwwg 1swE+10EG35kbNwybiWNtbzJLirJKbFwodNFfMsk4Ug5YUpXcOIgFOAMorn5r5RhkSuTzBz7ptD opUZmVxBPkCB/z4XSMD44uZc/TcrkrlP6htkKg9GfBLzgipkzawzTYIB+jwN8513uw1s8XVTTMB ITgn6TcjwxGuGCnQ= X-Google-Smtp-Source: AGHT+IHY89ib1m+RqAiIfHD1t0Lvi8Km0tjdoUyONCMCestwVPtVg38jm6cI4xiUm+sBXYxZlhwWDg== X-Received: by 2002:a17:907:7a8b:b0:ad2:3fa9:7513 with SMTP id a640c23a62f3a-ad23fa97742mr725361766b.46.1747059792642; Mon, 12 May 2025 07:23:12 -0700 (PDT) Received: from [192.168.0.253] (5D59A51C.catv.pool.telekom.hu. [93.89.165.28]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-ad2197be0c5sm619626866b.153.2025.05.12.07.23.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 May 2025 07:23:12 -0700 (PDT) From: Gabor Juhos Date: Mon, 12 May 2025 16:22:43 +0200 Subject: [PATCH 7/7] pinctrl: armada-37xx: propagate error from armada_37xx_pmx_set_by_name() Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250512-pinctrl-a37xx-fixes-v1-7-d470fb1116a5@gmail.com> References: <20250512-pinctrl-a37xx-fixes-v1-0-d470fb1116a5@gmail.com> In-Reply-To: <20250512-pinctrl-a37xx-fixes-v1-0-d470fb1116a5@gmail.com> To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Linus Walleij , Bartosz Golaszewski Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Gabor Juhos , stable@vger.kernel.org, Imre Kaloz X-Mailer: b4 0.14.2 The regmap_update_bits() function can fail, so propagate its error up to the stack instead of silently ignoring that. Cc: stable@vger.kernel.org Fixes: 87466ccd9401 ("pinctrl: armada-37xx: Add pin controller support for Armada 37xx") Signed-off-by: Gabor Juhos Signed-off-by: Imre Kaloz --- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c index 18c6c5026b26c294ee65e3deea02d2e852e10622..f35bf0cd98c97419ba0ab0291a23d4774a595d39 100644 --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c @@ -358,9 +358,7 @@ static int armada_37xx_pmx_set_by_name(struct pinctrl_dev *pctldev, val = grp->val[func]; - regmap_update_bits(info->regmap, reg, mask, val); - - return 0; + return regmap_update_bits(info->regmap, reg, mask, val); } static int armada_37xx_pmx_set(struct pinctrl_dev *pctldev,