From patchwork Mon May 12 13:23:30 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rafael J. Wysocki" X-Patchwork-Id: 889598 Received: from cloudserver094114.home.pl (cloudserver094114.home.pl [79.96.170.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFD0FAD58; Mon, 12 May 2025 13:23:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=79.96.170.134 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747056221; cv=none; b=DvD1OYXuRDUxPlV+YA04omjdyLtyDdbIZ7vHkqan/DSGtYFxaxAg6pGwLCqD6pPG4aULl1znRckkx8/GNX/Ig5mJQ1wIO6vNJsSVbLARx1nrvCU2FtVx2NBD8QYbAjz9WuhbjR6/pIyCaAEJCouVsSwqO9zW9/C4ltBS3EK3QNU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747056221; c=relaxed/simple; bh=cBwH3AMY+j1loh80XQyMwRSXd1cJWPgyALHwqOGeA3w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=itdBl2Yua3u5o2hizM2m9ImEH95F32Z/3M6n1BJLg/UwDRBZG7hjDyc14b+e0BfY8+EWfbovCNqILqQdlJZ/msswY3qNSgA+A/Hc85s+6jVJrZTPOsLQMBFMnOSza+fG8LpXdV3kHQhcMeNbrohdSWEsHQCuTvTDUOEuxirrYAo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rjwysocki.net; spf=pass smtp.mailfrom=rjwysocki.net; dkim=pass (2048-bit key) header.d=rjwysocki.net header.i=@rjwysocki.net header.b=NHtBkkYQ; arc=none smtp.client-ip=79.96.170.134 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rjwysocki.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rjwysocki.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rjwysocki.net header.i=@rjwysocki.net header.b="NHtBkkYQ" Received: from kreacher.localnet (unknown [217.114.34.19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by cloudserver094114.home.pl (Postfix) with ESMTPSA id 5F8BD666D2F; Mon, 12 May 2025 15:23:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=rjwysocki.net; s=dkim; t=1747056210; bh=cBwH3AMY+j1loh80XQyMwRSXd1cJWPgyALHwqOGeA3w=; h=From:Subject:Date; b=NHtBkkYQR2Eu20UISoxPZJzBoTVe46L8yX4VpfLN4xmlOef1/YSG81DwTV0GlCJ1y MxnydAazwwCCMw46LTn7XVqOGh8d3F1fXEgkkRx5pithF89eQxBKblRG7NWaOlmACv btCUKU0vJhpd1k5vc2KiKFjIHNii42dsR2YLzLk4lvvyrXCrtnIXaexRnUSY48ylT0 6GMs40dcka8mBfR6IFXz/pJHIGSsHLYJu5CXfOg9zTaNZ406oNvQpiSKvNnP4SR4sn pE0qD+zuwU5ERzhpvcjr2T5Ip63UcetZILpu8H0tmoBYOdHiVnKJVUqLRoE4GJHKCE f8wvRvdxyUjbQ== From: "Rafael J. Wysocki" To: Linux PM Cc: LKML , Lukasz Luba , Dietmar Eggemann , Ricardo Neri , Christian Loehle , Marek Szyprowski Subject: [PATCH v1] cpufreq: Drop policy locking from cpufreq_policy_is_good_for_eas() Date: Mon, 12 May 2025 15:23:30 +0200 Message-ID: <2806514.mvXUDI8C0e@rjwysocki.net> In-Reply-To: <3344336.aeNJFYEL58@rjwysocki.net> References: <3344336.aeNJFYEL58@rjwysocki.net> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-CLIENT-IP: 217.114.34.19 X-CLIENT-HOSTNAME: 217.114.34.19 X-VADE-SPAMSTATE: clean X-VADE-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdeftddufeejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecujffqoffgrffnpdggtffipffknecuuegrihhlohhuthemucduhedtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttdejnecuhfhrohhmpedftfgrfhgrvghlucflrdcuhgihshhotghkihdfuceorhhjfiesrhhjfiihshhotghkihdrnhgvtheqnecuggftrfgrthhtvghrnhepfeduudeutdeugfelffduieegiedtueefledvjeegffdttefhhffhtefhleejgfetnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucfkphepvddujedruddugedrfeegrdduleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpedvudejrdduudegrdefgedrudelpdhhvghlohepkhhrvggrtghhvghrrdhlohgtrghlnhgvthdpmhgrihhlfhhrohhmpehrjhifsehrjhifhihsohgtkhhirdhnvghtpdhnsggprhgtphhtthhopeejpdhrtghpthhtoheplhhinhhugidqphhmsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtoheplhhukhgrshiirdhluhgsrgesrghrmhdrtghomhdprhgtphhtthhopeguihgvthhmrghrrdgvghhgvghmrghnnhesrghrmhdrtghomhdprhgtphhtthhopehrihgtrgh X-DCC--Metrics: v370.home.net.pl 1024; Body=7 Fuz1=7 Fuz2=7 From: Rafael J. Wysocki Policy locking was added to cpufreq_policy_is_good_for_eas() by commit 4854649b1fb4 ("cpufreq/sched: Move cpufreq-specific EAS checks to cpufreq") to address a theoretical race condition, but it turned out to introduce a circular locking dependency between the policy rwsem and sched_domains_mutex via cpuset_mutex. This leads to a board lockup on OdroidN2 that is based on the ARM64 Amlogic Meson SoC. Drop the policy locking from cpufreq_policy_is_good_for_eas() to address this issue. Fixes: 4854649b1fb4 ("cpufreq/sched: Move cpufreq-specific EAS checks to cpufreq") Closes: https://lore.kernel.org/linux-pm/1bf3df62-0641-459f-99fc-fd511e564b84@samsung.com/ Reported-by: Marek Szyprowski Tested-by: Marek Szyprowski Signed-off-by: Rafael J. Wysocki --- drivers/cpufreq/cpufreq.c | 2 -- 1 file changed, 2 deletions(-) --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -3067,8 +3067,6 @@ return false; } - guard(cpufreq_policy_read)(policy); - return sugov_is_governor(policy); }