From patchwork Tue May 13 14:23:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Zapolskiy X-Patchwork-Id: 890342 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E567F28F520 for ; Tue, 13 May 2025 14:24:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747146246; cv=none; b=BJrkRYFE2gCCqWASTRlCwSHtb+ZEp3CDhuEH4NnnDnCPrQb+xVoDZhHPeLitzyHG4eUirIdbiXQ7vI0DmPntPz2ul2tyKdMtjpibz1N2kg/Waw/x5NvGzOK/7mHrKVDzutpDLLbU7YkduZkZq+ynZvzYsYSB9cgbT9rJbMquxpk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747146246; c=relaxed/simple; bh=TEtk0BAez4A9tbONJb+ibjQlQfyN/iZx4xrxbWn0Z5c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=K5LicVoTC8GREOA2YjGMPtNQOaxwKpRvHqvN1aaTf10sFh8LQOBT2ORFDpWLRgXa8GlQMIMvBEncFHykYgdoFck99LemrakDYD1Ceqqh0j0E1p1reuG0J7XatI1ovqqgO+Yj/4UnF4DqK34wb6WYXFEqAlC44xFxoZW7A/ZRFTY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=cio8mBlS; arc=none smtp.client-ip=209.85.167.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cio8mBlS" Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-54fc4a9b290so749834e87.1 for ; Tue, 13 May 2025 07:24:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1747146243; x=1747751043; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=87PeNSaoARSO0xJcDgxfba3OS94iBFvi7PfmwqCHUmQ=; b=cio8mBlSTllkz4DWRti2TqDfgmP3xcLsZoPnt67S8yS8fVSR6a1n7xh17mudDkS/z8 sMCdCCZR3huskBa1YsHzCDv6sjYdjz/auEH6iOAsfGjurZtZzve/C1VZSbWRp0hSLTQf 0cqy/KMwMgvObEjCEcW/QObTMRnTIvCJsqfI6EYF75IW+gdvwRchskgnqDbhz0uTxeAd PZsGeeB9ieMpYKA353z4zTzCObxk2If7jRKj96mzIJ6RPO/VDxJhEx7+O5bXmtKnJOTO GcLvYj5WqDpi//ya/S22vYYvnEguvxHHVLsH2tfwe8oFBpm6xV7rvJtQ4oub8CuqW2vY L4qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747146243; x=1747751043; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=87PeNSaoARSO0xJcDgxfba3OS94iBFvi7PfmwqCHUmQ=; b=etzgcaRsP22du1jYLciJZk3LKuznjGIYt4MsUfU0X0OeyUEoM+gd3/YBowLusRET5t Gj5+SsBKLTb19AVxAVrPvb/M6ZPqIX63IRLUAmYcE+lVo2iKB42cUnj1PgxYv2Ez56KU s0JB2u8Sx2Tuh66Gl+yGtVeSDiuMNygTb4Q7V37apefiIkM9+Z4TL1AbtSMf8HQoQ0gt 2f0uDNoiJNybm4pT79GddIWMGFmOgyMvIAWNx/YNewET5hRoKn8Z88Reo6rReTFSvgD+ moPHb/TNXXDxFBY5wG/mNxvTBHPluhhROTMv0AVrY+AK2/oro0EU4By4t0pKM2PMwXb/ 7rTQ== X-Forwarded-Encrypted: i=1; AJvYcCW4d/W/cFpvnbFDnsP2FSpq2Fv7d+lIfBOu0Cq5tEnFzi5AjTu8Rb7r+7h8rYnGRhbEtmUntedyPNUsd704@vger.kernel.org X-Gm-Message-State: AOJu0YwXHni+/G9e/5moQIZFEERZjye/N/oXR9ovubuqkAieeuUAnITJ /IJ0lQ0DUIkclkwYmbxhhjuo6paQdgBtiL3sog7qT51nn2PWJDeeFX719VoBJ8M= X-Gm-Gg: ASbGncuxsyHp1DnFZCufYBgZ22s7Ehw9tlry6ugvYHjpvSLyui4Zwo6uqSj/zm+m1+A QlTJiYcg3uxjoT0pqgXdBT1cxRlysXTem6FR0tANkkrPpmxi6HIDAqxYH1YFX+vFPed4hDbTXGC e3P2V8metRQ8L+NRPyyrcnuUdNYK4s1mSqHb8oZkObxTBq6umI5xZEEIRi8UronPXF2p+Abv21V XMu1HSnZGp0pRxd8BvU58MYq7Rks7/A73b/rkN09TMAjPRtszTM3u3kYagWHC+AdE9YgNqV2EeT ud8Aqz/56oqHvIhNbCb/xOgmUQ4kU/NxRfUjBhSdt9I4xCfBBH4Y6E2iA3HgXmyQ8X1UlptQNZu bWcsgVjEV2QbKI4LZ5FlAsImv04v4ExZQSdt4vrFL X-Google-Smtp-Source: AGHT+IFCj6ItwkApXIPWgFlOj214q7Cn7XzHyhJB7R1HfvQX2QzqVdxWqZtWqd1cP42fxdofZLJTcA== X-Received: by 2002:a05:6512:acc:b0:545:2f92:ff5 with SMTP id 2adb3069b0e04-54fc67cead0mr1820285e87.11.1747146242900; Tue, 13 May 2025 07:24:02 -0700 (PDT) Received: from localhost.localdomain (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54fc644fba0sm1871813e87.23.2025.05.13.07.24.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 May 2025 07:24:02 -0700 (PDT) From: Vladimir Zapolskiy To: Robert Foss , Todor Tomov , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH 1/9] media: qcom: camss: cleanup media device allocated resource on error path Date: Tue, 13 May 2025 17:23:45 +0300 Message-ID: <20250513142353.2572563-2-vladimir.zapolskiy@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250513142353.2572563-1-vladimir.zapolskiy@linaro.org> References: <20250513142353.2572563-1-vladimir.zapolskiy@linaro.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 A call to media_device_init() requires media_device_cleanup() counterpart to complete cleanup and release any allocated resources. This has been done in the driver .remove() right from the beginning, but error paths on .probe() shall also be fixed. Fixes: a1d7c116fcf7 ("media: camms: Add core files") Signed-off-by: Vladimir Zapolskiy Reviewed-by: Bryan O'Donoghue --- drivers/media/platform/qcom/camss/camss.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c index 06f42875702f..f76773dbd296 100644 --- a/drivers/media/platform/qcom/camss/camss.c +++ b/drivers/media/platform/qcom/camss/camss.c @@ -3625,7 +3625,7 @@ static int camss_probe(struct platform_device *pdev) ret = v4l2_device_register(camss->dev, &camss->v4l2_dev); if (ret < 0) { dev_err(dev, "Failed to register V4L2 device: %d\n", ret); - goto err_genpd_cleanup; + goto err_media_device_cleanup; } v4l2_async_nf_init(&camss->notifier, &camss->v4l2_dev); @@ -3680,6 +3680,8 @@ static int camss_probe(struct platform_device *pdev) v4l2_device_unregister(&camss->v4l2_dev); v4l2_async_nf_cleanup(&camss->notifier); pm_runtime_disable(dev); +err_media_device_cleanup: + media_device_cleanup(&camss->media_dev); err_genpd_cleanup: camss_genpd_cleanup(camss); From patchwork Tue May 13 14:23:46 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Zapolskiy X-Patchwork-Id: 889659 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B90EA2BD009 for ; Tue, 13 May 2025 14:24:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747146247; cv=none; b=q5ioQlZsm48sueJCyNt/VrC5CRWzT6TPRfo6kK0tAlPTCHLraGpT510Ri3U7YfNPkY+vPXRZNIEItCVAQYHDRnNZ+AMpRiQHH7s7yaS/RC3f4uXaHyUdxRcWpwcp+qY/+l+4FRe4GKVB57HuWAeth8cvJmKtbFZLA86hpd9Tf6M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747146247; c=relaxed/simple; bh=1dbZKTa/g+MzsnzTQFCT1jdM3evL1vIx93omGHH0mS4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JMw9GtT1a3Twmc5SH2dE01RgE8+cPnLnoWkLMFmjT40RjvP6LnqKAvpMq2KvkSoj/PLPChN9NvWURY51erBbQLjOH+ANTigHP2LeeTdnaWNu6Zvc/amqLz3uoXDTUg71Ohb92Z8eYvPsJXwJpaEQw4+YxXRr2i7mvv5ZRxCYqeE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Vs5/NShG; arc=none smtp.client-ip=209.85.167.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Vs5/NShG" Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-54fcdc99478so349604e87.0 for ; Tue, 13 May 2025 07:24:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1747146244; x=1747751044; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FLyQNl/IfprA8mrvUU0qzCD9YVX1jlfRaaDTODi+QbM=; b=Vs5/NShGV04HpSXCK/5zy/JjMa9blTs5UiwgGyiEK1kvBWF/aTzhATN5kAGKAy5H7V bkGZVDaoz0zKMABDVh43J4iQiKbee1mKP/+XNbsv2dtmgCV4xLSdiTo+uLQi6J1Cq8Kt 88xNudE8lFtgC6163eAFf/Diblf/r0zyz6Ll1YYaLwk5mGfBjzxiLizcPZOy60zyDLgL r6/+AsJ0gHTxd47sqHEy8ReEEuSXEbTC6C6tK5ymH0o0Xe68Q1gnhiv57ZcJVzzMClYQ R4cJlwbtthIJj8qUUdjdsWwTHPi1XN5Md93CARSX3bl1x124R8RZHZIbm6wHLylWUkoE Huqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747146244; x=1747751044; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FLyQNl/IfprA8mrvUU0qzCD9YVX1jlfRaaDTODi+QbM=; b=rb3QM0tZRXZQ4FYNksVyMUraouHmRxmAT4LAR2EMkFatD2Tme+RLU2xffVLnkLNCih 7PunI3n/OSFtMP880IMbiv0EKd7+vkMA1StJURmzDb1sjugYIl7TfdHqIJDHbV1WLtF8 oRwXPtR+dxdNU9wNBWzQl4wExltnVAIcKDV8obn4qhHdOsueVhD8RN+ZrsYarCw0Yxz0 /b7ZMhQkL44oiq8QbPsY0wzyJb1ERIbTBYTIytxZKTW/VRDTlfppQQ7LeSvO85JfCcYY ErLepTjLha9ka303buJOUmtq7er3kstrDnAfVfbKi6IDDmpi1WNTpxhOujtTZ1X4cmI4 7tqQ== X-Forwarded-Encrypted: i=1; AJvYcCWciVnu3IUgZDckBQXzqwYzZovZ1jNsxWySbO2GSPtKgB/ho9Pywitqp1fUfHMn0bkoWNLSVe1CunoxYe9E@vger.kernel.org X-Gm-Message-State: AOJu0YztKo/tQh7GICPbFk+4Mw01QVNbKKgGPplIqhnpvqY/X5128Iba ZEy7H0S7TidIeAEdBxYy7vzBQ8j95TU0GLkCnp6UmaX3Yeg+9z3eirNm9tREYUNkpKm4m1kzzkS u X-Gm-Gg: ASbGncv+iLpfJcz1geMojHmzXSNoOhtK6MVgy/qlfxd1RRZQUWoEAEAS3GRE3Wgan4T ElazLUWog2GAefbu9MsqhVbS7GX/2V8P5jlUUwbL8+B/C6HeBIp5i7XbORbAliPAS6FoFZzjXxf T2rWZS/ERE9E2inTgda0jSTdN5kqcn8FwC40nw4hVDa3AImL+1WqoRLJhC4WQiUIOdfsAsaAJ7O Gmya5NQUsxLv+cPK1fBmPL43+St/XZdcBRr65MG3LNYVtD5TlbUIplw7RUaQwIivXmJb3YKnXIv /upgJ/iNEkN8BoyHcbOGBBC3FO2u7iCS7I2ckT2bgPrpD8Bs/Xh1ie204elAMvvIEgWeG5OZmh1 j+cqnDPr1ZoX7kjeuVYtPZJLw48PqVaT3q7ntD4eq X-Google-Smtp-Source: AGHT+IHtk921lEO/dQfipJFfEuJ1GeNiLuhJwnGHgJR1JF/11YYx8N67y8WnOW6vPy9eWziLe0e9eQ== X-Received: by 2002:a05:6512:3da6:b0:54f:c10b:7286 with SMTP id 2adb3069b0e04-54fc67ad7f5mr2070039e87.3.1747146243820; Tue, 13 May 2025 07:24:03 -0700 (PDT) Received: from localhost.localdomain (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54fc644fba0sm1871813e87.23.2025.05.13.07.24.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 May 2025 07:24:03 -0700 (PDT) From: Vladimir Zapolskiy To: Robert Foss , Todor Tomov , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH 2/9] media: qcom: camss: remove duplicated csiphy_formats_sc7280 data Date: Tue, 13 May 2025 17:23:46 +0300 Message-ID: <20250513142353.2572563-3-vladimir.zapolskiy@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250513142353.2572563-1-vladimir.zapolskiy@linaro.org> References: <20250513142353.2572563-1-vladimir.zapolskiy@linaro.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 It's sufficient to have just one previously set csiphy_formats_sdm845 data. Signed-off-by: Vladimir Zapolskiy Reviewed-by: Bryan O'Donoghue --- drivers/media/platform/qcom/camss/camss-csiphy.c | 5 ----- drivers/media/platform/qcom/camss/camss-csiphy.h | 1 - drivers/media/platform/qcom/camss/camss.c | 10 +++++----- 3 files changed, 5 insertions(+), 11 deletions(-) diff --git a/drivers/media/platform/qcom/camss/camss-csiphy.c b/drivers/media/platform/qcom/camss/camss-csiphy.c index c622efcc92ff..2de97f58f9ae 100644 --- a/drivers/media/platform/qcom/camss/camss-csiphy.c +++ b/drivers/media/platform/qcom/camss/camss-csiphy.c @@ -103,11 +103,6 @@ const struct csiphy_formats csiphy_formats_8x96 = { .formats = formats_8x96 }; -const struct csiphy_formats csiphy_formats_sc7280 = { - .nformats = ARRAY_SIZE(formats_sdm845), - .formats = formats_sdm845 -}; - const struct csiphy_formats csiphy_formats_sdm845 = { .nformats = ARRAY_SIZE(formats_sdm845), .formats = formats_sdm845 diff --git a/drivers/media/platform/qcom/camss/camss-csiphy.h b/drivers/media/platform/qcom/camss/camss-csiphy.h index ab91273303b9..895f80003c44 100644 --- a/drivers/media/platform/qcom/camss/camss-csiphy.h +++ b/drivers/media/platform/qcom/camss/camss-csiphy.h @@ -126,7 +126,6 @@ void msm_csiphy_unregister_entity(struct csiphy_device *csiphy); extern const struct csiphy_formats csiphy_formats_8x16; extern const struct csiphy_formats csiphy_formats_8x96; -extern const struct csiphy_formats csiphy_formats_sc7280; extern const struct csiphy_formats csiphy_formats_sdm845; extern const struct csiphy_hw_ops csiphy_ops_2ph_1_0; diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c index f76773dbd296..8c844ebf9cb6 100644 --- a/drivers/media/platform/qcom/camss/camss.c +++ b/drivers/media/platform/qcom/camss/camss.c @@ -1481,7 +1481,7 @@ static const struct camss_subdev_resources csiphy_res_7280[] = { .csiphy = { .id = 0, .hw_ops = &csiphy_ops_3ph_1_0, - .formats = &csiphy_formats_sc7280 + .formats = &csiphy_formats_sdm845, } }, /* CSIPHY1 */ @@ -1496,7 +1496,7 @@ static const struct camss_subdev_resources csiphy_res_7280[] = { .csiphy = { .id = 1, .hw_ops = &csiphy_ops_3ph_1_0, - .formats = &csiphy_formats_sc7280 + .formats = &csiphy_formats_sdm845, } }, /* CSIPHY2 */ @@ -1511,7 +1511,7 @@ static const struct camss_subdev_resources csiphy_res_7280[] = { .csiphy = { .id = 2, .hw_ops = &csiphy_ops_3ph_1_0, - .formats = &csiphy_formats_sc7280 + .formats = &csiphy_formats_sdm845, } }, /* CSIPHY3 */ @@ -1526,7 +1526,7 @@ static const struct camss_subdev_resources csiphy_res_7280[] = { .csiphy = { .id = 3, .hw_ops = &csiphy_ops_3ph_1_0, - .formats = &csiphy_formats_sc7280 + .formats = &csiphy_formats_sdm845, } }, /* CSIPHY4 */ @@ -1541,7 +1541,7 @@ static const struct camss_subdev_resources csiphy_res_7280[] = { .csiphy = { .id = 4, .hw_ops = &csiphy_ops_3ph_1_0, - .formats = &csiphy_formats_sc7280 + .formats = &csiphy_formats_sdm845, } }, }; From patchwork Tue May 13 14:23:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Zapolskiy X-Patchwork-Id: 890341 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5A08165EFC for ; Tue, 13 May 2025 14:24:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747146248; cv=none; b=RgNJdqWepbMIFbwCs+Bnk88HOjFw+WmmKLtZ0Mu0AeiXuoSYFoVcjvfFplVm6Miuo4A6Vh1mieNUuLluF6gdeAKMLV++8lhcOvIbTyy9fTT+BBjkbR/mSyV1pNlkQIU3ZUQaHbqeep/+biBzjpSLlsVsFeSYmnWCs1r2zXYSXiI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747146248; c=relaxed/simple; bh=wd5OK2vpaUbdVbTuvyN3zcrNtkQAd/14OzJXAvp/rRQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=p8mf3Y0HJRqxQhBEugLKL6NUj1mL8//ewNIvQuXu2L1M79u//9JxIU5hz9LGyjuVS6ZOz1pT1OroVHd7SD6dBIhb47ii/ISow0GYwSWRpn/UMiKXZWcKAql63k48BN3Mvu2AeqBfycjTzXTYrng86050fQhxsZhK/4GphkOKWdg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=YRAR3QL1; arc=none smtp.client-ip=209.85.167.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YRAR3QL1" Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-54e66deb66fso891113e87.3 for ; Tue, 13 May 2025 07:24:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1747146245; x=1747751045; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JEIMfORhvN5jRYVM9DDW32f9X7YFOQS1p/b7fC45Eds=; b=YRAR3QL1Re1fx1MzODCXIAK0USJlEWwf0LjciRTqe3ijwLebpaRreVtKVhWfrUsab2 Ta8wMX2DSjXF2zUGPLxCdqaM4GkpTZTTtUSMs4wdxnsH7KLE+2G7WRbIhVVO7vEG2h+M 4hDwpz/WE8FlCt+m6fk/DUSUKd/eOssHC7TXXqAWCBRF6Nd8zaz5be64jtsXtrEfiKpg bsW9kznacQMdNiavaovZLwWInaS9hXZP9B0N/i6j+Aiz8fefUodDf8gAPMouqemy5BgF mkKyCQRF1i/j3Gxjfa6xxjQwC3WYWtaudrd0J9bnz3DiwX7GlCaeo5G854w00VfJtffU 4WlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747146245; x=1747751045; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JEIMfORhvN5jRYVM9DDW32f9X7YFOQS1p/b7fC45Eds=; b=kZkuxgGEFpMgAEnG9gE5jgjNvoFbGcB7jOMiWvOepkk+Pew2KFVxp15dzQMvxfobPl Yv3fM6AJXGLphUfwEZEMzW3/P5OlMbE6clkWRi+/DBZTedY9u+GE5fQP3wNVh+8Jam1x L2kTHNCectg8OX68/p+cbq1LJsxFLmMAAU1epsXTkIxIiy27rXU6CKqKfVCuO7Ckwlx6 R1ms1kBQ4miB8jTkHrBLUB8HFX4CORxUlqHunix6T6nCk2zQ6rmoBtO7eNbmF44O4Rri O2whiNDJJkozg7qug/PkF1pY6cGu4fUQW6iz/nqqXSFfliiauiVsAY6BJasKXxDYVpyH /fXg== X-Forwarded-Encrypted: i=1; AJvYcCXQ8MUDph0+krlcqWj8YhqHqfI/RAV5UlyCXnEvaL3UgJSErQ8cdwOxSHbYpo4//IEcdwb/J/IwpySstCId@vger.kernel.org X-Gm-Message-State: AOJu0YyE+/3yhUO49eHmHrOuVrSa23gaVCsqvZEJwcigNNN0adPZZpe9 aF9UKK4Ie4/dyBcwVA1C0i2r1C95cYO2c3mu0Sdeh4SH0KfzTLGRyzv+ato55mk= X-Gm-Gg: ASbGnct9Njylc6+c6QXmc0S0/KdVKDC2drb0UEPhKNk8g3U2MZUU/Jtt3wqZF55v/Ev my1PVCnL74Q5mXynoYiVvBQavUx+G/hTHr/UKg/IGYuzC+WEJCkhEGB4uoJ18Z6Od90QanMEfEz 26FQm1E8785XKxdW/PGpFLMXaaSc1wOt/WTOolU2xOaLbX2z+oS2IDX83u8Awf7RTK4ACUdORL2 9QjJeR+2mtVXz8mVYDzmmKP1WtMObY27wV8TxyakoacW77ILk4G09cIeoFwRqoAzj+YfmUyBXB0 f1tIhqBPiHff6b6eVSSZGjBzVZIvppZpVNToII10YKYr9k7IRfE1O9OjtvQXG/Y++J04MDjbyxP wEiAZJDDBMiY1re1Z59ym9I/gGc0xgSU4j4jLuL5B X-Google-Smtp-Source: AGHT+IG4ecE3HUplA9i8a8L1PN8LSDGDhOHpOg/H8jWcK3aNKhgRCeYMXpbwZbnyw+FZV+J05fzC9A== X-Received: by 2002:a05:6512:159d:b0:549:8faf:e20b with SMTP id 2adb3069b0e04-54fc67c3400mr2319152e87.9.1747146244761; Tue, 13 May 2025 07:24:04 -0700 (PDT) Received: from localhost.localdomain (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54fc644fba0sm1871813e87.23.2025.05.13.07.24.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 May 2025 07:24:04 -0700 (PDT) From: Vladimir Zapolskiy To: Robert Foss , Todor Tomov , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH 3/9] media: qcom: camss: remove .link_entities Date: Tue, 13 May 2025 17:23:47 +0300 Message-ID: <20250513142353.2572563-4-vladimir.zapolskiy@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250513142353.2572563-1-vladimir.zapolskiy@linaro.org> References: <20250513142353.2572563-1-vladimir.zapolskiy@linaro.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 There is no potential for a custom .link_entities callback, remove it by replacing with a common camss_link_entities(). Signed-off-by: Vladimir Zapolskiy --- drivers/media/platform/qcom/camss/camss.c | 14 +------------- drivers/media/platform/qcom/camss/camss.h | 1 - 2 files changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c index 8c844ebf9cb6..2977aeaf27e1 100644 --- a/drivers/media/platform/qcom/camss/camss.c +++ b/drivers/media/platform/qcom/camss/camss.c @@ -3143,7 +3143,6 @@ static int camss_init_subdevices(struct camss *camss) } /* - * camss_link_entities - Register subdev nodes and create links * camss_link_err - print error in case link creation fails * @src_name: name for source of the link * @sink_name: name for sink of the link @@ -3642,7 +3641,7 @@ static int camss_probe(struct platform_device *pdev) if (ret < 0) goto err_v4l2_device_unregister; - ret = camss->res->link_entities(camss); + ret = camss_link_entities(camss); if (ret < 0) goto err_register_subdevs; @@ -3726,7 +3725,6 @@ static const struct camss_resources msm8916_resources = { .csiphy_num = ARRAY_SIZE(csiphy_res_8x16), .csid_num = ARRAY_SIZE(csid_res_8x16), .vfe_num = ARRAY_SIZE(vfe_res_8x16), - .link_entities = camss_link_entities }; static const struct camss_resources msm8953_resources = { @@ -3740,7 +3738,6 @@ static const struct camss_resources msm8953_resources = { .csiphy_num = ARRAY_SIZE(csiphy_res_8x96), .csid_num = ARRAY_SIZE(csid_res_8x53), .vfe_num = ARRAY_SIZE(vfe_res_8x53), - .link_entities = camss_link_entities }; static const struct camss_resources msm8996_resources = { @@ -3752,7 +3749,6 @@ static const struct camss_resources msm8996_resources = { .csiphy_num = ARRAY_SIZE(csiphy_res_8x96), .csid_num = ARRAY_SIZE(csid_res_8x96), .vfe_num = ARRAY_SIZE(vfe_res_8x96), - .link_entities = camss_link_entities }; static const struct camss_resources sdm660_resources = { @@ -3764,7 +3760,6 @@ static const struct camss_resources sdm660_resources = { .csiphy_num = ARRAY_SIZE(csiphy_res_660), .csid_num = ARRAY_SIZE(csid_res_660), .vfe_num = ARRAY_SIZE(vfe_res_660), - .link_entities = camss_link_entities }; static const struct camss_resources sdm670_resources = { @@ -3775,7 +3770,6 @@ static const struct camss_resources sdm670_resources = { .csiphy_num = ARRAY_SIZE(csiphy_res_670), .csid_num = ARRAY_SIZE(csid_res_670), .vfe_num = ARRAY_SIZE(vfe_res_670), - .link_entities = camss_link_entities }; static const struct camss_resources sdm845_resources = { @@ -3787,7 +3781,6 @@ static const struct camss_resources sdm845_resources = { .csiphy_num = ARRAY_SIZE(csiphy_res_845), .csid_num = ARRAY_SIZE(csid_res_845), .vfe_num = ARRAY_SIZE(vfe_res_845), - .link_entities = camss_link_entities }; static const struct camss_resources sm8250_resources = { @@ -3801,7 +3794,6 @@ static const struct camss_resources sm8250_resources = { .csiphy_num = ARRAY_SIZE(csiphy_res_8250), .csid_num = ARRAY_SIZE(csid_res_8250), .vfe_num = ARRAY_SIZE(vfe_res_8250), - .link_entities = camss_link_entities }; static const struct camss_resources sc8280xp_resources = { @@ -3816,7 +3808,6 @@ static const struct camss_resources sc8280xp_resources = { .csiphy_num = ARRAY_SIZE(csiphy_res_sc8280xp), .csid_num = ARRAY_SIZE(csid_res_sc8280xp), .vfe_num = ARRAY_SIZE(vfe_res_sc8280xp), - .link_entities = camss_link_entities }; static const struct camss_resources sc7280_resources = { @@ -3830,7 +3821,6 @@ static const struct camss_resources sc7280_resources = { .csiphy_num = ARRAY_SIZE(csiphy_res_7280), .csid_num = ARRAY_SIZE(csid_res_7280), .vfe_num = ARRAY_SIZE(vfe_res_7280), - .link_entities = camss_link_entities }; static const struct camss_resources sm8550_resources = { @@ -3845,7 +3835,6 @@ static const struct camss_resources sm8550_resources = { .csiphy_num = ARRAY_SIZE(csiphy_res_8550), .csid_num = ARRAY_SIZE(csid_res_8550), .vfe_num = ARRAY_SIZE(vfe_res_8550), - .link_entities = camss_link_entities }; static const struct camss_resources x1e80100_resources = { @@ -3860,7 +3849,6 @@ static const struct camss_resources x1e80100_resources = { .csiphy_num = ARRAY_SIZE(csiphy_res_x1e80100), .csid_num = ARRAY_SIZE(csid_res_x1e80100), .vfe_num = ARRAY_SIZE(vfe_res_x1e80100), - .link_entities = camss_link_entities }; static const struct of_device_id camss_dt_match[] = { diff --git a/drivers/media/platform/qcom/camss/camss.h b/drivers/media/platform/qcom/camss/camss.h index 63c0afee154a..1d0f83e4a2c9 100644 --- a/drivers/media/platform/qcom/camss/camss.h +++ b/drivers/media/platform/qcom/camss/camss.h @@ -107,7 +107,6 @@ struct camss_resources { const unsigned int csiphy_num; const unsigned int csid_num; const unsigned int vfe_num; - int (*link_entities)(struct camss *camss); }; struct camss { From patchwork Tue May 13 14:23:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Zapolskiy X-Patchwork-Id: 889658 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A801128F538 for ; Tue, 13 May 2025 14:24:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747146251; cv=none; b=LURLKtM9V+2EPmfPgGH+eOzAy+XOJyYydGyiHVA51CUWoKLYEKoAG2bdk48Ugy0iKM9a6C9EfUjcyNJeVzQpXyOXO9Enc8QKmMSHvWd6k2i0FJ0UToSaDp7wHo/+0ad15XU4AbpqucVyzyIhtWFTx2HhZduVFP3Wp63+2TU9kyM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747146251; c=relaxed/simple; bh=V+yA0wwcS/bVf5oT8EHOGAo5JiL/HicUzO3XXCHGScE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=D1gDaJfNB8nYRwqsbdSBDw/iAiRuoA/HeiVEWE/Cn1rc7SHYqS6QgiVtOsK2uPrW8KBZJ71EcgR/48v5hGGWfcxhKSQsPCQr1147Q2WiPqPvm9hp6xCwzflAno+KCcwmhSyGOCffgV9IwhRa5y8Erb9RNFZTaxLaendMvOEt6no= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Vr2C19Q8; arc=none smtp.client-ip=209.85.167.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Vr2C19Q8" Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-54fc36137caso538992e87.2 for ; Tue, 13 May 2025 07:24:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1747146248; x=1747751048; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=P+mIWe4f7/ePA4eiTd6mBWZ/3eo5UNvBmTQDWz6UZOo=; b=Vr2C19Q8UQrlRGw30BYh5g29Z+4kEMYE9XewAWBKBjrstcr3s+O+J+SReRrVgIpjKy ahCFUFnFRB+e/cM+1U5K39V48VRmKf+gDHZPAIbEdS9WJAnEQa+8UHudDVYP2z6EvHjU R476q71FoTuhEFHJ90kAUeBmwsT2I8L2Zj8Hdt+SthICmAPdX27e1ELRGLhS3Tyi46Y8 8ly41YHABoaF86ZyqSxYhTjdQf2ijut3M858ZOv9C9iNZ6s+dEWG7wKMsRuzzu6jkC3+ 30BZF3AwqdyZevXojPG1x1vOk4vzgHxXmIHStnl/NS7UiwX+jwKL6+efOxrHOV/XN1b+ Ib+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747146248; x=1747751048; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=P+mIWe4f7/ePA4eiTd6mBWZ/3eo5UNvBmTQDWz6UZOo=; b=ItXODR5uW40GDCrEpV8/09s6u76q3YP2fZ0TvP8Xx6Qoeivd1G+CbNr5ofPILfNd/N o77Awj0QGNLyN1bANro7isvnLkHMV3NGNwr32IlgvyPj3sIg2fNiTl8BD3HI2m/o1xyd YFvVWw5d0PT3xKrpoyOUF/sSFHYcmUTd/LGdx7BBznTeMllfaSKlobYRCBrUSGlf+LYm VBQ6xhMtGALcH+ooutc0mhomc/mwR8bZHw1EsKL0QbxA/849cJ4DbI78edqwvBiO1JCe HgHsD7tGdjMkRRpcGqbglWOFUwCkAIgAUI0yKSH5dZ/qhMDL/BY5J+XopegCdIbYp2Lp oP7w== X-Forwarded-Encrypted: i=1; AJvYcCXTYFLsrs4PGMO2pFB4n9DUN47tmOkZ+U2I+lT5koyv+eEE35OxgpvDUWh3hp2c5nyHcDVpvg5ud/kYf793@vger.kernel.org X-Gm-Message-State: AOJu0YxLLrGnD9/NHbI8KX0jbyMpCJN+MbJYgPzDsB2Zz2sVdNLSkReI TIRXNcaj8fJp1ANUl5rVVzkCeftNnm0pxvAo2xIOR5VXxUGfg0xU4j6v8X9LOgQ= X-Gm-Gg: ASbGnct+t8fxtiv+s+EXEK9cw2Nz5EAO9srtoob0lpeTCpp7Y3ickfPVkmPo5Ilu54d 3PVKORbrDDMd7SukLXwlF26aiDrRFS5sBFmIRbz0oEXd2Q72kH9JWzeGvXii5KpByNhLpz4Jp0/ awypUm3BQtpkcrl9UejEsFbQEL3n3fEOzDpRSoFX1Po73F7KBhlkfaLp5egnUTs+weB+oaVyP5r v5M9FLhDCHkjZgQWWJUVSJbYXqjrn4SGqQ2+9UhyjMSa7++o8vXumGDWWVIkrdqlY8rPd8aU2fp gnC49cZOSk/UfVHV/qm6rx6Ke9fSvplugmQ5K+xoTHcA0sdhg43y+VgiLEOpWqYg01IdKBvseWn uB6CXFz0u8eph5bugRyq5xrCeb6BtD0pIK2YqbsRJ X-Google-Smtp-Source: AGHT+IETgSn1urVnMun+WYtNS1QXqt+HyQMwe0j+DtEuUcdRDUPi7bIqRr9TigWkClOwQ9fQ4/Hijg== X-Received: by 2002:a05:6512:4019:b0:54f:c2ab:c6be with SMTP id 2adb3069b0e04-54fc67bee89mr2089901e87.7.1747146247658; Tue, 13 May 2025 07:24:07 -0700 (PDT) Received: from localhost.localdomain (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54fc644fba0sm1871813e87.23.2025.05.13.07.24.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 May 2025 07:24:07 -0700 (PDT) From: Vladimir Zapolskiy To: Robert Foss , Todor Tomov , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH 4/9] media: qcom: camss: register camss media device before subdevices Date: Tue, 13 May 2025 17:23:48 +0300 Message-ID: <20250513142353.2572563-5-vladimir.zapolskiy@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250513142353.2572563-1-vladimir.zapolskiy@linaro.org> References: <20250513142353.2572563-1-vladimir.zapolskiy@linaro.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 A media device can and at least for sake of simplicity should be registered before V4L2 devices including the ones added on async completion. The change removes the second and out of camss_probe() media device registration path, and it allows to get a working ISP media device independently from connected or not sensor devices. Signed-off-by: Vladimir Zapolskiy --- drivers/media/platform/qcom/camss/camss.c | 25 ++++++++++------------- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c index 2977aeaf27e1..976b70cc6d6a 100644 --- a/drivers/media/platform/qcom/camss/camss.c +++ b/drivers/media/platform/qcom/camss/camss.c @@ -3417,11 +3417,7 @@ static int camss_subdev_notifier_complete(struct v4l2_async_notifier *async) } } - ret = v4l2_device_register_subdev_nodes(&camss->v4l2_dev); - if (ret < 0) - return ret; - - return media_device_register(&camss->media_dev); + return v4l2_device_register_subdev_nodes(&camss->v4l2_dev); } static const struct v4l2_async_notifier_operations camss_subdev_notifier_ops = { @@ -3645,6 +3641,12 @@ static int camss_probe(struct platform_device *pdev) if (ret < 0) goto err_register_subdevs; + ret = media_device_register(&camss->media_dev); + if (ret < 0) { + dev_err(dev, "Failed to register media device: %d\n", ret); + goto err_register_subdevs; + } + if (num_subdevs) { camss->notifier.ops = &camss_subdev_notifier_ops; @@ -3653,26 +3655,21 @@ static int camss_probe(struct platform_device *pdev) dev_err(dev, "Failed to register async subdev nodes: %d\n", ret); - goto err_register_subdevs; + goto err_media_device_unregister; } } else { ret = v4l2_device_register_subdev_nodes(&camss->v4l2_dev); if (ret < 0) { dev_err(dev, "Failed to register subdev nodes: %d\n", ret); - goto err_register_subdevs; - } - - ret = media_device_register(&camss->media_dev); - if (ret < 0) { - dev_err(dev, "Failed to register media device: %d\n", - ret); - goto err_register_subdevs; + goto err_media_device_unregister; } } return 0; +err_media_device_unregister: + media_device_unregister(&camss->media_dev); err_register_subdevs: camss_unregister_entities(camss); err_v4l2_device_unregister: From patchwork Tue May 13 14:23:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Zapolskiy X-Patchwork-Id: 890340 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 824CF2BCF5B for ; Tue, 13 May 2025 14:24:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747146252; cv=none; b=nfSDv4qExVLk90dRTUebUbWivltnAdBxuXAVjJeea0Py0xrSOD2LyckjQHoiAKjUitVgYzdRS6JcLX5EKGLVLAEtoiZR1Vc0U8DVCeRkC/WT0bSXjD7JZeB5/sqNi/52E/usnp7HxSrLVi9cyiMoaNKs2tQUk/b5O6orSoxBLeM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747146252; c=relaxed/simple; bh=erNjneX1ykXPs40HPM7FAn+r4hIz/TDnlNai6OUxWf0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LaEU4CaJ4SJsYn4+EpEy82XVFaYNil2TZy2/1qxJnK1sybCndBIfWal2kJfRS/Z9u6Io+CX8HbCjuRISik0Wrw2hDI6ll1xIzt2cU8xLWtBc3xOKbvTevB4/8WPduIsWB/MuvOFBHoK922xmlM7Ave+Lol0kD9ddcK+8hQ3BSL0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=dZRDmxVX; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dZRDmxVX" Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-54fc7dcf64fso566547e87.3 for ; Tue, 13 May 2025 07:24:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1747146249; x=1747751049; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=R1GPv/f99tPbM0UPQ85Mqw1y4SMVAklj5dFNW1gK2Gs=; b=dZRDmxVXe7IgZ59LhcNgMZV0kqJQKStUV9bSymNRtug+eBHpji3Jq1qTlJJKyXPt31 evd4ieac6ybyOq5lNoCyF90hvuwUUe7XvUE6crR5Xk+ywW1x2tIWzT42YomMOeAHCsnf se4zO19xWu717NQmHkcrHMcXXP33xkFYjZf6N2Xt0QodcpGIzdKI2NGN5L9pnhsnTGp4 QloCxIultmNLvSa2lrDdIfSJzSW+PbpTQ5awZy2T5yGhhiMuPNbUJdHgroDie5NdMj/0 4qllg9aGxMfgbI/pCPFSP5wEbqZWRm38SEMT1Shmbp7H5vo72Ci7XrzPnEq9ZyWBfHel Ptlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747146249; x=1747751049; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R1GPv/f99tPbM0UPQ85Mqw1y4SMVAklj5dFNW1gK2Gs=; b=J1xAGHO2Djg7iAhAjghZ2Q3nvGSY3WhHktXH58cdC7GsgmCmbhyzWT4P4g+Xiiyy9s TVX3eyca/TfLQcWatmieMIIW5eOGAt5gJd0XPAnpRrYReHkY8veUdg0ApXXPONROmXNT jEE916MLmfRwrOWP61DkDttfaU5alvbniP3krmr14WtqSLQLDpdZW35gKI/f9cuuam0w ZnJi0NTh3yjziAtuSWDZkrDErxw2N0UB1uDeOwAxrRgRUKdZg6Uvkl8/MNQGk3AF4f+A jMAuN0uNplRWJwGouFW9I1N11Ift2vdNVwtTERG4QQQ5pQ5TwUNTDgPs4hTuYwP7qGov Rekw== X-Forwarded-Encrypted: i=1; AJvYcCU04qHnX94LqwAEDq29x6jFaXCByO+Hpfh1VYtphVPzIdFzsRiZtiB4xX/uL883C2iCQIziccdC+YMACEvd@vger.kernel.org X-Gm-Message-State: AOJu0YySgSJqp/l4kiJZHpgVgan9D+L+TkvZfwXxFlS1Rf7g2hjFvA4U /AGcsHEDPDYDMne2fZyC1ygsmrSFGex1eMCkqw3huWfRWLj9kJ1ziw3AXBl12v4= X-Gm-Gg: ASbGncvEsU4YF5dl3KaOGxnzUlL3yVpTMnoeE8wvK0jTP/GnCQGI5xbmk3KyjmYkqCx kGhgViRJE/qgIdFoe3aZgcvMxBQDpoK8m835088oI3qIQBWebd6XQpaX2RgSkESE/So3bAvtriE alnx7CdtbzXF0UBFJkdeERHP1Sh2SjgPg97jPuWYSeohL7bj5TKpSYjmnxCXg6HlH0kKTc95L8v ohTQFn1t/YZvnw7cygknLnhAdzsOr0ENbtOr9fUjBI185NDM9s3UKyhbNHo5o8PMqgX5JjrtAJV Bw64xX9a0My2F/hdgYIruLIIgd3pD0xaHEKmsdR3AqeEX7L/JGYn7J+A5vJNZegEZ54vqXhVO9u lO7F/vqYLcELOd42uPsS5Pv5FlqEOQS6eStOvKncn X-Google-Smtp-Source: AGHT+IGO1rTBMd+2KCdhIBdhmkYdra8c308MKiP+DS9B6TmEo+B1Fa2ub8Is/wdTA9cZdM0jG2ILhg== X-Received: by 2002:a05:6512:a8d:b0:545:760:44ca with SMTP id 2adb3069b0e04-54fc67cfea0mr1793598e87.10.1747146248650; Tue, 13 May 2025 07:24:08 -0700 (PDT) Received: from localhost.localdomain (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54fc644fba0sm1871813e87.23.2025.05.13.07.24.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 May 2025 07:24:08 -0700 (PDT) From: Vladimir Zapolskiy To: Robert Foss , Todor Tomov , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH 5/9] media: qcom: camss: unconditionally set async notifier of subdevices Date: Tue, 13 May 2025 17:23:49 +0300 Message-ID: <20250513142353.2572563-6-vladimir.zapolskiy@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250513142353.2572563-1-vladimir.zapolskiy@linaro.org> References: <20250513142353.2572563-1-vladimir.zapolskiy@linaro.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 For sake of simplicity it makes sense to register async notifier for all type of subdevices, both CAMSS components and sensors. The case of sensors not connected to CAMSS is extraordinary and degenerate, it does not deserve any specific optimization. Signed-off-by: Vladimir Zapolskiy --- drivers/media/platform/qcom/camss/camss.c | 30 ++++++----------------- 1 file changed, 8 insertions(+), 22 deletions(-) diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c index 976b70cc6d6a..4e91e4b6ef52 100644 --- a/drivers/media/platform/qcom/camss/camss.c +++ b/drivers/media/platform/qcom/camss/camss.c @@ -3556,7 +3556,6 @@ static int camss_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; struct camss *camss; - int num_subdevs; int ret; camss = devm_kzalloc(dev, sizeof(*camss), GFP_KERNEL); @@ -3627,11 +3626,9 @@ static int camss_probe(struct platform_device *pdev) pm_runtime_enable(dev); - num_subdevs = camss_of_parse_ports(camss); - if (num_subdevs < 0) { - ret = num_subdevs; + ret = camss_of_parse_ports(camss); + if (ret < 0) goto err_v4l2_device_unregister; - } ret = camss_register_entities(camss); if (ret < 0) @@ -3647,23 +3644,12 @@ static int camss_probe(struct platform_device *pdev) goto err_register_subdevs; } - if (num_subdevs) { - camss->notifier.ops = &camss_subdev_notifier_ops; - - ret = v4l2_async_nf_register(&camss->notifier); - if (ret) { - dev_err(dev, - "Failed to register async subdev nodes: %d\n", - ret); - goto err_media_device_unregister; - } - } else { - ret = v4l2_device_register_subdev_nodes(&camss->v4l2_dev); - if (ret < 0) { - dev_err(dev, "Failed to register subdev nodes: %d\n", - ret); - goto err_media_device_unregister; - } + camss->notifier.ops = &camss_subdev_notifier_ops; + ret = v4l2_async_nf_register(&camss->notifier); + if (ret) { + dev_err(dev, + "Failed to register async subdev nodes: %d\n", ret); + goto err_media_device_unregister; } return 0; From patchwork Tue May 13 14:23:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Zapolskiy X-Patchwork-Id: 889657 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBA042BE101 for ; Tue, 13 May 2025 14:24:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747146253; cv=none; b=R2JKQ1G7TziymTKWyvGIRsqxyhhiEE3KL68e4eyu0r4qomejGZj/y8PVWxlG8AMkDooeRAW+YEfHgr08ynyGz40KpTf4LFmjn6eBoQLtHnbbWZlgybG5xONKnlf7A6IPnAyEjCTMPlZpeJ6N5o2IL/EOUgYDqcT+OnJdAvw0CB4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747146253; c=relaxed/simple; bh=n5GbW9547xms/973wpMFEJ+iyozutW75ILZ3e5FuJag=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AWF/nHCzojXA7rDQ+T/v8cpCnWePWvBU42BZq7ytjynPW6ZgZ4xtZlx4v0Tot63mmb7c5T5vF3mFatx/K7/3WkCO0pwxWT6xJ0aNtU7+K8CupqnO13kFXEvIf0vYrJEM3Z71h0WPtY93s0UF1SUr6nQX++WXfBrOOTliB85u+VI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=n5fJgXZG; arc=none smtp.client-ip=209.85.167.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="n5fJgXZG" Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-54fc509e7eeso635693e87.0 for ; Tue, 13 May 2025 07:24:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1747146250; x=1747751050; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Je1pnbYGeDSwO8l0nWcUWFR3rRs+nLJrQdN1nv9aVoQ=; b=n5fJgXZGNwfmbKs+Ga9tFehNOy7onWR9RNIgdZbdchKERdnzJHaTgL8+LrxADT02gy bByHIe/ohE8pssKrZV0ynxNvNQWhVWRXaxhSnJEqauVb82wkZLMgpefMiyfIAGA2INAS AYQXZmcpTqyvbQAoPjxps4k1AJgp4HKpOhJfB3ORWQDYXRwbQ/UVU1Wd0I5YNy4PhDUs 5ih+0Mx/2AvQg+i1242OYSs2QDDd7ky/UJOKT+TTKJB7sDrkZGYRoFjm87BiI0iGGTLF wc7BaXBrv7LrsNqUrR7fedmyJCPOJX4izU6rE5VrgO1mN96m1ad9DbUGtlvHvbi8L8cV sTjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747146250; x=1747751050; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Je1pnbYGeDSwO8l0nWcUWFR3rRs+nLJrQdN1nv9aVoQ=; b=CVDbMV7ucPldO83DzPgBxoxseAXkL1J+PSS43sAdnR6CvHVmrQAEaZuxKs9kOmA/Aj WDxaJGIRvoufLunr8285VW3xyisekI4OTWvggTX0qEf9/+qBWi8Nb4EzeYB7l33ZeLcC hIFkdOJVGzfoQpQE2WlMa4dj/Nz7QKCSPw9FE3Kp0/Itf8W/Msm4bl0kB0Wjgl/1Sa18 fKq3gki69S8NqsMmPcButjcX1vGZt0P+NQ2EmAjgFjGJJeWwGSmTZoYuYYtzcNjsmDbV pC6Pgz8Lz0bYMwuwpDW+xAFjjd5/YUQ9FzjDws37KGUTIJ7GXainoV5MAVBeyf5aDNP8 GtrQ== X-Forwarded-Encrypted: i=1; AJvYcCVgB91LS7MQLGAEiyjVX8DvS+XempKZWCKQrw1Lw7NaN3XGrzIj+LL5SmKcV4iS1lZd0Sh5XptmFsxHtTdf@vger.kernel.org X-Gm-Message-State: AOJu0YxLoyO5+KSFDoudO5Ojw9hZRZHPUSo0aBobxXnDVqt1e9TOSj8e WgGTbZTctlbSu4PXoy/ZKwBEoKJi3RqJWTsDN30M/twSXFpsx8sqTwReT7ShPlI= X-Gm-Gg: ASbGnctv6Lbj50uVcIvzmB10tjywjLFgkLqKr875dJ4SVwGmxpstuZMJODiitFIPnCq J10bQuRimiQtPi8FSeRDAT8YgyyrIYT0jWXlh8tTn9cXkTlc5ldOxIa1N5EwdXEqMhrX9/PWCsh 8jLH+tgkgoBx0qryRX1/SCWvcE47ZZq7PTECoSFWPASqj2JUmLoIUQCpCzXK/D9rb1p+HcL3Vrd R71Aug5M+/j/TE18XWzlw1hHi5GJsDtbU2oQpMR5+3Y8yjWdtt9oAPsQAMnP4DuvU1LFtRQZnw3 7PRvzuoYFNygpFIY8FSRs3ZX/XmVYGuRMfckbwza6kbFqahF/UEYrMNlM2B6CSP/CxmDvHFEVCV JQSOfTprz+Dj0BhAHQo3tJ+7tnNoMbYTLR5QT9y5EqjI8g6rv39g= X-Google-Smtp-Source: AGHT+IHTeW9zs26KYKOPDOT1amI557o7iaow9p3jy/WNJzSFNHOCm9k+ajDzGAdoM1UDpUNvywcrSQ== X-Received: by 2002:a05:6512:10c5:b0:54f:c088:fb11 with SMTP id 2adb3069b0e04-54fc67d3101mr2037761e87.13.1747146249850; Tue, 13 May 2025 07:24:09 -0700 (PDT) Received: from localhost.localdomain (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54fc644fba0sm1871813e87.23.2025.05.13.07.24.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 May 2025 07:24:09 -0700 (PDT) From: Vladimir Zapolskiy To: Robert Foss , Todor Tomov , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH 6/9] media: qcom: camss: simplify camss_subdev_notifier_complete() function Date: Tue, 13 May 2025 17:23:50 +0300 Message-ID: <20250513142353.2572563-7-vladimir.zapolskiy@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250513142353.2572563-1-vladimir.zapolskiy@linaro.org> References: <20250513142353.2572563-1-vladimir.zapolskiy@linaro.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 For sake of code simplicity and readability reduce the function code by one level of indentation, the change is non-functional. Signed-off-by: Vladimir Zapolskiy Reviewed-by: Bryan O'Donoghue --- drivers/media/platform/qcom/camss/camss.c | 50 +++++++++++------------ 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c index 4e91e4b6ef52..39c5472f4552 100644 --- a/drivers/media/platform/qcom/camss/camss.c +++ b/drivers/media/platform/qcom/camss/camss.c @@ -3385,35 +3385,35 @@ static int camss_subdev_notifier_complete(struct v4l2_async_notifier *async) struct camss *camss = container_of(async, struct camss, notifier); struct v4l2_device *v4l2_dev = &camss->v4l2_dev; struct v4l2_subdev *sd; - int ret; list_for_each_entry(sd, &v4l2_dev->subdevs, list) { - if (sd->host_priv) { - struct media_entity *sensor = &sd->entity; - struct csiphy_device *csiphy = - (struct csiphy_device *) sd->host_priv; - struct media_entity *input = &csiphy->subdev.entity; - unsigned int i; - - for (i = 0; i < sensor->num_pads; i++) { - if (sensor->pads[i].flags & MEDIA_PAD_FL_SOURCE) - break; - } - if (i == sensor->num_pads) { - dev_err(camss->dev, - "No source pad in external entity\n"); - return -EINVAL; - } + struct csiphy_device *csiphy = sd->host_priv; + struct media_entity *input, *sensor; + unsigned int i; + int ret; + + if (!csiphy) + continue; + + input = &csiphy->subdev.entity; + sensor = &sd->entity; + + for (i = 0; i < sensor->num_pads; i++) { + if (sensor->pads[i].flags & MEDIA_PAD_FL_SOURCE) + break; + } + if (i == sensor->num_pads) { + dev_err(camss->dev, + "No source pad in external entity\n"); + return -EINVAL; + } - ret = media_create_pad_link(sensor, i, - input, MSM_CSIPHY_PAD_SINK, + ret = media_create_pad_link(sensor, i, input, + MSM_CSIPHY_PAD_SINK, MEDIA_LNK_FL_IMMUTABLE | MEDIA_LNK_FL_ENABLED); - if (ret < 0) { - camss_link_err(camss, sensor->name, - input->name, - ret); - return ret; - } + if (ret < 0) { + camss_link_err(camss, sensor->name, input->name, ret); + return ret; } } From patchwork Tue May 13 14:23:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Zapolskiy X-Patchwork-Id: 890339 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC0BB2BCF5B for ; Tue, 13 May 2025 14:24:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747146254; cv=none; b=dJNlicsEdJVKLlGfuFX5nt8B5PlFe88rr04PhJBsEgMR7upRmflPnHXFEOo+QFimYRmkDo9dKFjVhCsDUhq6aFv6WoObDJtc5q9IbcNftuzJjipfiDIonRa49YO7MOHEpLh5RPVO2RqXsWZoAQMc8sGNVccADzZ+EsIkTofG2Pk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747146254; c=relaxed/simple; bh=Dg/kRgRiQN2QvOJWPN/51Hfk4qa0Ifb2gj/F+hVKG5Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ffoMpO8o+jjowTfS1G5lM529RfTlV5czqQmJN8UBMR+FlSBXH4RmHdVSL+btNoY0wEYb/evhGzAYYBljhc9bTgsBoACm1LjIrUiYz+sGn00VFC0UGmb4yq7bb/MLy/QckbU0KH0ui77gyW0TOqyLDrMyK7jWuk7V9r6IoHdX2Ik= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=WGQEdub4; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WGQEdub4" Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-54fc4a9b290so749845e87.1 for ; Tue, 13 May 2025 07:24:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1747146251; x=1747751051; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5/auQxm3IrAhfUVDmTuHtjr7cikuNi8RLWcR7PSjSIA=; b=WGQEdub4bgnJ3E7gJKXdrCAgNNErSBCU0oi9ccWArHL9gEz4+oKMKlnhX27YaVVjRJ 4de89VU6EzBuwEC5HM7gz0A12B7BP5v6BG8WywLhLTAtyEqEB4QuNa2+4ERAM5M2WC4v NQB14czX3paTVL/1mZIBIrd2xrbOp3BOcJv0CDPv3WnevNpjmaxGeRWcp+YUDoN1Bg3F x9ghImOEm2d8aZK6NSmfppLlGwmKLWwL3aqfJxG5uWEBuKc6lrx17ghgIh5fYvfFU4hB nDrXRGzb4mdaZj5DxnPw+a9mKf59VnHw0VFkY2DhQLO0BtdquVGzk8anEHDrShjy5t9c k30g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747146251; x=1747751051; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5/auQxm3IrAhfUVDmTuHtjr7cikuNi8RLWcR7PSjSIA=; b=HjRl4P6XVdybq0j6fG8aYq5DIlrF/Ts1tToLnmtHTUzdpsfvmbYuLKgHVX26Xhly+/ BdUxQx61icqOuMsHndmAQoV9QJ++fEOrz2F4cNe72RqHZHL1Hnbz2sVPcRpgs4esv36S D85GgOq3n+WmT/REi+pOxTKJZWfZGrZRh3hmpLrS2FuViG9fn7Ro+GvFAI62t2Hdoojt X+Af6jh2vGRZONHa749mYLmWsizQyXTtbqoU86XhRyceJMHTrZxda80Qv8fkK357LLd0 BEHOcap4r5F1Yg5kPzkpKsIvERMoq77aQrptaizO0xm7ca+JnyWWm+GOZMPP3FJaZYDI TepQ== X-Forwarded-Encrypted: i=1; AJvYcCXQcYRbyDmfwI/8Rr8iSiv/IrfFIn8Ls3n9gQdUpFtiRDaPnlr/Y4TpWVVWLp1fmI/Ix//ngxWLZ77oAGcf@vger.kernel.org X-Gm-Message-State: AOJu0YytfLJukQ9y4Z29hoLrSFU7u15Ud2KEY1eDPJsa/z7JLssT97YS vlhJjV0D31T9M6+ustlBs/gb3P0unomQX1jMYA82pBCLuBOBs4ov7fUYWdMNtpQ= X-Gm-Gg: ASbGncs0ImE71QXk6m/W12BGpydsGOv/WYLD3qSaTJR8du4qiWb6nktWAKlaaS+9XLc CyaN3rESFemtRJdEQofd1GwxpHie5SArVJZKnPX4sA8KOkJa/5IK+z3r62GWG3sFwUMN0De9vrA u2WkKJ1mU0TFqTKzGyfalrGLFT9X64qcoDfV0S5QADUD6ydA6536TWc2YQ2DbNSOtfP9ZxGMfV8 4TlRulj+C8RYmrf+aWk5E6nHUYpWvOXwpjdcAwCZmQDbcdHrCuApGBUbcLonXNBD+vwY6g2kHaN G6kCOZScjymPIdNDgrg0NK/Gble23gZK6PjE2PUrcRCaVtr6lqtZElKBkAv5Ht65sh/M3/wFR2y j2Ko0at05x/gcWU35MDIBpjk06e7hJiYQRryPLJmN3v2XzrEF+fw= X-Google-Smtp-Source: AGHT+IHqwEbFhZhgXovx7bSWXvfgsMhzKBNxgoML9g87PhfEO8ZtLUbvptRFKBUuDrk1kKgcCCoHpQ== X-Received: by 2002:a05:6512:b10:b0:54d:6dd3:614e with SMTP id 2adb3069b0e04-54fc67aa84emr2239184e87.1.1747146250792; Tue, 13 May 2025 07:24:10 -0700 (PDT) Received: from localhost.localdomain (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54fc644fba0sm1871813e87.23.2025.05.13.07.24.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 May 2025 07:24:10 -0700 (PDT) From: Vladimir Zapolskiy To: Robert Foss , Todor Tomov , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH 7/9] media: qcom: camss: change internals of endpoint parsing to fwnode handling Date: Tue, 13 May 2025 17:23:51 +0300 Message-ID: <20250513142353.2572563-8-vladimir.zapolskiy@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250513142353.2572563-1-vladimir.zapolskiy@linaro.org> References: <20250513142353.2572563-1-vladimir.zapolskiy@linaro.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Since a few called V4L2 functions operate with fwnode arguments the change from OF device nodes to fwnodes brings a simplification to the code. Because camss_probe() as the single caller of camss_of_parse_endpoint_node() has no need to know a number of async registered remote devices, it makes sense to remove the related computation from it. In addition there is no reason to check for a OF device availability on CAMSS side, the check is useless as the always passed one. Signed-off-by: Vladimir Zapolskiy --- drivers/media/platform/qcom/camss/camss.c | 52 ++++++++++------------- 1 file changed, 23 insertions(+), 29 deletions(-) diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c index 39c5472f4552..d4745fb21152 100644 --- a/drivers/media/platform/qcom/camss/camss.c +++ b/drivers/media/platform/qcom/camss/camss.c @@ -2973,16 +2973,16 @@ static const struct parent_dev_ops vfe_parent_dev_ops = { }; /* - * camss_of_parse_endpoint_node - Parse port endpoint node - * @dev: Device - * @node: Device node to be parsed + * camss_parse_endpoint_node - Parse port endpoint node + * @dev: CAMSS device + * @ep: Device endpoint to be parsed * @csd: Parsed data from port endpoint node * * Return 0 on success or a negative error code on failure */ -static int camss_of_parse_endpoint_node(struct device *dev, - struct device_node *node, - struct camss_async_subdev *csd) +static int camss_parse_endpoint_node(struct device *dev, + struct fwnode_handle *ep, + struct camss_async_subdev *csd) { struct csiphy_lanes_cfg *lncfg = &csd->interface.csi2.lane_cfg; struct v4l2_mbus_config_mipi_csi2 *mipi_csi2; @@ -2990,7 +2990,7 @@ static int camss_of_parse_endpoint_node(struct device *dev, unsigned int i; int ret; - ret = v4l2_fwnode_endpoint_parse(of_fwnode_handle(node), &vep); + ret = v4l2_fwnode_endpoint_parse(ep, &vep); if (ret) return ret; @@ -3025,52 +3025,46 @@ static int camss_of_parse_endpoint_node(struct device *dev, } /* - * camss_of_parse_ports - Parse ports node - * @dev: Device - * @notifier: v4l2_device notifier data + * camss_parse_ports - Parse ports node + * @dev: CAMSS device * - * Return number of "port" nodes found in "ports" node + * Return 0 on success or a negative error code on failure */ -static int camss_of_parse_ports(struct camss *camss) +static int camss_parse_ports(struct camss *camss) { struct device *dev = camss->dev; - struct device_node *node = NULL; - struct device_node *remote = NULL; - int ret, num_subdevs = 0; + struct fwnode_handle *fwnode = dev_fwnode(dev), *ep; + int ret; - for_each_endpoint_of_node(dev->of_node, node) { + fwnode_graph_for_each_endpoint(fwnode, ep) { struct camss_async_subdev *csd; + struct fwnode_handle *remote; - if (!of_device_is_available(node)) - continue; - - remote = of_graph_get_remote_port_parent(node); + remote = fwnode_graph_get_remote_port_parent(ep); if (!remote) { dev_err(dev, "Cannot get remote parent\n"); ret = -EINVAL; goto err_cleanup; } - csd = v4l2_async_nf_add_fwnode(&camss->notifier, - of_fwnode_handle(remote), + csd = v4l2_async_nf_add_fwnode(&camss->notifier, remote, struct camss_async_subdev); - of_node_put(remote); + fwnode_handle_put(remote); if (IS_ERR(csd)) { ret = PTR_ERR(csd); goto err_cleanup; } - ret = camss_of_parse_endpoint_node(dev, node, csd); + ret = camss_parse_endpoint_node(dev, ep, csd); if (ret < 0) goto err_cleanup; - - num_subdevs++; } - return num_subdevs; + return 0; err_cleanup: - of_node_put(node); + fwnode_handle_put(ep); + return ret; } @@ -3626,7 +3620,7 @@ static int camss_probe(struct platform_device *pdev) pm_runtime_enable(dev); - ret = camss_of_parse_ports(camss); + ret = camss_parse_ports(camss); if (ret < 0) goto err_v4l2_device_unregister; From patchwork Tue May 13 14:23:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Zapolskiy X-Patchwork-Id: 889656 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BB4B2BE113 for ; Tue, 13 May 2025 14:24:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747146255; cv=none; b=ss7n5anasWGWxG2SxjIVreukNksTyTtqR/dyFDf8GatuotNPpYUqX8C1kOViJ9Mlt7kGynzBH1OGWmJKnP5ehedZJirL0p9UUixEAnF3Qe2NSYccnKrTlUjUCKo7loAavSwkRYeUuOrlS4dANFdm0S1LG3oRlvkqsVertTsDc9E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747146255; c=relaxed/simple; bh=XdEO4KmhdzkmFgTppxOTLqYmKKiZ4V91Zop709Tv7QM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UqtfK0ObjiWNTZXEJFL4M5jQ+bQEagk0uSF8jVuf99aN3kU/EkvCCC0ek/sDvZPSMr0cs511pnBjxY8QLsgpmJMcAOrlrJWk3yezqr5J2NRHCj864TtxQ2+cva+jEcc4+c8h5ohrYHcOG16zoHczCKCG8C5WF3cb6j5JPkj7F8M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fA0/DqK1; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fA0/DqK1" Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-54fbf721fd7so752561e87.0 for ; Tue, 13 May 2025 07:24:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1747146252; x=1747751052; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bkvIXboeSQ7DpFMEdb2LOpzhdD+Ul3bkMffg79IGGvk=; b=fA0/DqK1u1AHapDtBP7DbQ1EE7NbFRf5SZIFkfVDBavvYxzDxcFJSJBCR11orhq/LQ RivDUbg5JZJCZOhdRRY/rx94p/6tw93fI6SjJqE3ELjv6qmKP5e6yRAiabjVl2AnIfSa LhXjQ7X9DV9j2Q0liUibRkfqEtzGqYCnHs1Kz+3c0jqN3yx711uJXol1mQwN9iF+/VSc MmsC9G4NsNmxApGYRL6WOpllJLPudkrzi/t25K/dISF3/aveuCp9L58uxp+vOzu1FcBC lM07mqOHSojQALWDsw5F6THJcZt7advAgdzAf5HTeVTwU8yav51TZVzwWNz9TsxPwLOD fUxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747146252; x=1747751052; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bkvIXboeSQ7DpFMEdb2LOpzhdD+Ul3bkMffg79IGGvk=; b=dh6xtwsGvYQTbUKWlsKf20Y//SECoRnIEwiitE58v0IjLCBxDYUXZVzHqxRIc49VrZ Br8gXO51W/QTcIF7+XfvT2GdtRKikNJmDVI5vto3BraI2lIGmdL17jnANmrXpNdNIJ1X E/yXpOxnhS/z6Iwv/yD380GbVBNn+yikWrrrTFofT5UnTyHx4Z8DIEALG7umCFnD+S+X 6+x9WfPFowmaaM3gtDd7RykgneoELtmrQIqaAiSfM3ikNGYGrSLxxPhrDjy194M6y27I WaITwbKohwwL6rWeRX4Uqf4/p9WkTwg13uoK8M4msuoxvywhLfKThViDrIQz5vFkJf24 fc1A== X-Forwarded-Encrypted: i=1; AJvYcCUMbR61Yrhk2AHFvmkc85olr/jUwFhZzMBYABgeiKYkwPGp+s396MJRogqjecgLC5FZxo+iiWnMRDC7PHeE@vger.kernel.org X-Gm-Message-State: AOJu0Yy2LKpXFqObQExjYpuChBjkgINqo4m7yEk+dbgKUCa9dSzlOCJ6 qsh48oxMJXrYH9SUrWwcoXVh1Td2y9JGt8KMopMMtvHf0N9coRGnkcC5CZknMFE= X-Gm-Gg: ASbGnctiwh92cV24Q+ql28qtUye6yNGk5e5tGxzp4FPosgNd3NAVl/rGEO61nzLO0lt pIc4X/UQHKXLN5anwJo40vtR5tH+ma+K8C3IW1G6MGn2bauZnsujtTUvQfqcyD0x5ljYOrAGVlH arTaLe52OXRZsCUCwFWujv6HkoTTYGVYbnScXhp4AJ89NqykMm7+EFoV51vElvVK70D7yD5Rstv hpQu2lam8F158nINsRn7KpNmMEw8xA/bLRTEMaoBKqpAVz8wjAGCCpxT3iWmAy+7hV29bD4lptd 7ftQT2pDrCLPHbQLpL42D/QFPDxRA5YqNl1i974a6Dc+pECXxtTUW32LJzD3eswXkZGudkyrstw egXTD22elYnrLtfFvGgwIvpp6DWs0WQpPmId83TNC3+iKEStoy3Y= X-Google-Smtp-Source: AGHT+IGQvf2B9ZgZKrTjzA36UsxZkfwbIxpb/CDy+kO+0v3DXVBuJa/bdlFuqAoJspo3OGr97iZJ5A== X-Received: by 2002:a05:6512:3d28:b0:54c:a7c:cbda with SMTP id 2adb3069b0e04-54fc67d30e8mr2165049e87.15.1747146251725; Tue, 13 May 2025 07:24:11 -0700 (PDT) Received: from localhost.localdomain (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54fc644fba0sm1871813e87.23.2025.05.13.07.24.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 May 2025 07:24:11 -0700 (PDT) From: Vladimir Zapolskiy To: Robert Foss , Todor Tomov , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH 8/9] media: qcom: camss: use a handy v4l2_async_nf_add_fwnode_remote() function Date: Tue, 13 May 2025 17:23:52 +0300 Message-ID: <20250513142353.2572563-9-vladimir.zapolskiy@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250513142353.2572563-1-vladimir.zapolskiy@linaro.org> References: <20250513142353.2572563-1-vladimir.zapolskiy@linaro.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 One more code simplification makes parsing of remote endpoints easy. Signed-off-by: Vladimir Zapolskiy --- drivers/media/platform/qcom/camss/camss.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c index d4745fb21152..0d05f52a6e92 100644 --- a/drivers/media/platform/qcom/camss/camss.c +++ b/drivers/media/platform/qcom/camss/camss.c @@ -3038,18 +3038,9 @@ static int camss_parse_ports(struct camss *camss) fwnode_graph_for_each_endpoint(fwnode, ep) { struct camss_async_subdev *csd; - struct fwnode_handle *remote; - remote = fwnode_graph_get_remote_port_parent(ep); - if (!remote) { - dev_err(dev, "Cannot get remote parent\n"); - ret = -EINVAL; - goto err_cleanup; - } - - csd = v4l2_async_nf_add_fwnode(&camss->notifier, remote, - struct camss_async_subdev); - fwnode_handle_put(remote); + csd = v4l2_async_nf_add_fwnode_remote(&camss->notifier, ep, + struct camss_async_subdev); if (IS_ERR(csd)) { ret = PTR_ERR(csd); goto err_cleanup; From patchwork Tue May 13 14:23:53 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Zapolskiy X-Patchwork-Id: 890338 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAAC72BE7AD for ; Tue, 13 May 2025 14:24:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747146257; cv=none; b=CMOgaVotuL21BHvEl8D1wVou1lAjAVK/oLwMqOBv77jEfHUJIFUQlvg7s68dHih2v7uWC3K3ZYUDWp6N02KYAtzxKK+KksT8hNYt6/KNIeLfO17+DzZk3fLCkmmMiZWwXcVB9E4ZFDpFBNdaYPPZaREf/bs7IePjl9hEkIM2Ab8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747146257; c=relaxed/simple; bh=xuTTjd+g462s92piJzO152zSuWtKaJvpLpSJbcZ7r7A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=V1XeYxJU2gaitxQMk5O8kbLsJtKeXGbZSB7Vk5DRExrdMiv8YVlfrB+952UEYjVq3zA0aQoL7zBpY72hSrW4OwwJ09sfZxacL+EXUbi849rnmnthRUah2G7SZExDj3RYK8QKIVINCfFnDKXTLsb0fdjWsmlJ/1hegUfxTQa8thw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=gpn1+7So; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gpn1+7So" Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-54fc1132006so807380e87.2 for ; Tue, 13 May 2025 07:24:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1747146253; x=1747751053; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Jbp09rP7yjvsBo1LKOhlRvBKJcU01MMyhu8zUDGFwjs=; b=gpn1+7So1bBB1yAq2YqdQad9Eu3XhiQ7KYKOOAYWGY9pP2EV//WAtn0+6+HPoZFLkl pf2qeUQy9IRPUl5IGo3lxZji6UVl7Fxr8W2wcvBpuBPPiz17LQzfHMAFXfAvH/a5RSu8 OtQjxAI8fnpDSvDHBxFSTFdqwTAMGeaATx3iuHSRVvBhPNbMOj6Ied3VnaMcgN9lTLAS vf1Fe6kwcTux7TkxeWOkNjVD2yvYPZrlV/L3MPmRvGLkE4k83CRPOvZVr5h3HZssv0OP zsHA+NKv+XpUjMbSVIqMRjAjyl+7Ruv4io0fnww1yRASn25XVBXeQr4DDAmx77Lz/eLM CMdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747146253; x=1747751053; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Jbp09rP7yjvsBo1LKOhlRvBKJcU01MMyhu8zUDGFwjs=; b=lLlFRST7JYZsVJtYMyYTQTMTsiTc4LQNQjaI5MZx3lVSmFWMm6/q/fk0X0Afxj3uVf zbbsG2Q4vnRMfdemVp4DyfW5amb+X2E+Q2k6mwJdlLN/L6ki35Yco6sywXhQvKKcgtPr VwR8i9mG5IKsMySfKXqMwxi9ii5N2Sc6Rckh2kvFr9YBv/OIB95DdR0e8Pcx/gcl2gx/ CBRYzghjr54aQTpMZX9gS1sLg+2OzNxlfMP7nJvAFZFMTECC0xN+dMNMTQeTkrFre3EH KrUojDX4kSqoWCJerv0dcbLxpoa1S+dZ5vZhFVuOEPJO98TgaIup/b2glZv/+qka1iuF cutA== X-Forwarded-Encrypted: i=1; AJvYcCU9Ed3IvfPKIim+j9wD8xk5Ao66iRysf5oqIKdbRpKFSvGchsBujo4j4J6t+QVNf306PaHefvpth7ZqtyZh@vger.kernel.org X-Gm-Message-State: AOJu0YxEzTo+bAM1XuJKJtDhdCXnBBHQMm2fM6YJwKIXx7sqKwspBg+h I5J6zZvsUbgbMzDhJb3qpj1RuHAnZvoNKSK43IQnobPd0CTPHLdsFLowO490suo= X-Gm-Gg: ASbGnctiy4IwJKiScLpY9HHDUgrMl7AeHFJdXtVTpQqw6CQrr9GRrO7mMpAJaxylFSi RKZUMavz9l4gwGrOQmCN8LTgMmnQEWVtBI14Li3WAQKgbNuPF0YwTjYKbWfPE8wuHlLdDL8cIDs qQ2d6kjlTUJePmmmyUmYlmbGCeHoNyB0egLHvqLUMRVnnBqUbpyyDGAWRAJuL7Jt5WhLVDG/d8W Mg43Q57/UFqDcVwl+Ska26t8ZqzFV0m0CfKE2oDr0G/jQAwblpG0xxZHk1YA+1zUB6tm1zhRVtx TYPYcYzJEyzAJRKKJ3dJTCeooxf8Tcl+LP5X+jFBDe3rE9fpRpniufHhtG0Mr0iNkHaJM/c9vTS GCs5k4geJ5NKgaid43LlDJRnWLA95hYJCNMBfdhpUqJgE1V0PaYc= X-Google-Smtp-Source: AGHT+IEysCfN4QoGm+Kt4uTCWGC/FxersV1Axm+mK3Qn1WIeyAnenQCAPHpytZp/YJF6w/cpc4ZOqg== X-Received: by 2002:a05:6512:3994:b0:549:8c32:78ea with SMTP id 2adb3069b0e04-54fc67bd4e7mr2176139e87.7.1747146252969; Tue, 13 May 2025 07:24:12 -0700 (PDT) Received: from localhost.localdomain (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54fc644fba0sm1871813e87.23.2025.05.13.07.24.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 May 2025 07:24:12 -0700 (PDT) From: Vladimir Zapolskiy To: Robert Foss , Todor Tomov , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH 9/9] MAINTAINERS: add myself as a CAMSS patch reviewer Date: Tue, 13 May 2025 17:23:53 +0300 Message-ID: <20250513142353.2572563-10-vladimir.zapolskiy@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250513142353.2572563-1-vladimir.zapolskiy@linaro.org> References: <20250513142353.2572563-1-vladimir.zapolskiy@linaro.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Add myself as a review of Qualcomm CAMSS subsystem patches. Signed-off-by: Vladimir Zapolskiy --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6dbdf02d6b0c..9b973c0128fa 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -20135,6 +20135,7 @@ QUALCOMM CAMERA SUBSYSTEM DRIVER M: Robert Foss M: Todor Tomov M: Bryan O'Donoghue +R: Vladimir Zapolskiy L: linux-media@vger.kernel.org S: Maintained F: Documentation/admin-guide/media/qcom_camss.rst