From patchwork Wed May 14 19:18:33 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabor Juhos X-Patchwork-Id: 889998 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8038D28DF3B; Wed, 14 May 2025 19:18:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747250332; cv=none; b=SEYRa4Du0atzSG44f7HZA+irCUbi7Dbx9x1/OfjJDvPV0zJvneWiE4Af2YmatZ5Em58yMZOc2Q0hUKDhYdmrzypIchuFx06k3TAFsEVBGYo35Qkp2witTKVcnsHzM32wKN8DmjaQkrceLMkqSBNJIvAnktLIJZQICOm65QeM4bA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747250332; c=relaxed/simple; bh=rkHy0kQeLRmpuGO74kKtvOziIW+BrhpOftFy3YFd1qw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=B4TXdaaa2mh898IAsMTJwl8cb8IaR+Dq9KBPEv6lcjyvwAAeqeBoUMnTXZylJ5rgkS3dHH9cuRgwUUryLh6+gWzHqVaijqgJmcQ0YXzmGhdGEMr1jvePNSxiOzVux7JxLjzN4NZe70CPy8mwnHpC/rPbqj9y1Vbkg5PZV3/LTgA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZEGGEnrG; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZEGGEnrG" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-43edb40f357so1442975e9.0; Wed, 14 May 2025 12:18:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747250329; x=1747855129; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=w1VHW2HJExWmBNfaPof6yV4PNzfV43beUESvCPBIVuk=; b=ZEGGEnrGc5SixD8L8+9/Bf9GN8S9YHQh4JyUPC8uW2fnhtoV2wQrbq+5b7wOMnVvvU ETN8rgRUcfdJIk2nxVDa/+VOCLK1wkJrYHrf9oZCPUvcM2Nwdx0EpDjym4lEnCeJZKXP alRwuhKUTLiy5u+Wi2OWE8D82D0cBPsirSdJqFtPaln6ni5l5Bcul1yknI+GKNKEKtBv sdF/ONiqeF662LlIXZc89djUv6YHmprnvQRS3LTLnAN43X9JUpIQGDJf1SN0PwT6CZuP UquFk4J0PXdZTG4C0PkVuXtTYFj5kLQdbIljchnp31MDaWXdvFrzRx1kCjC+vcmS+SgT bC8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747250329; x=1747855129; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w1VHW2HJExWmBNfaPof6yV4PNzfV43beUESvCPBIVuk=; b=mgO0gPKDNdQSw2vP3lMdc11uYSUXsInGvSx6ghCKQyVvO6iNPTQWm29h0efrt0gZg0 2DIq4G5CWHH1axtQVekYG5818vMNrmnKaUAxTeOSdSMWuN/vsSkFgFuMlMbORqBDLoiz I0GthopwvnI7dT8GzJRKLI/+vj6O7KvVgz/t9r/sG5pscOkFFK+lyg3ycA+aFdvG+WTs m4jZybktTrlOMigW/39xehwA6lQpelmDhisWoC4XZSUJAI9fBgKoCFIpq5YLXzE7uhud c0hJNJF2WsSCHOUu+nXmEufJnfICo0gnj7YYh6UD7Jyy3HIb0ddJgqhgcdMEcdPssQkm AWtQ== X-Forwarded-Encrypted: i=1; AJvYcCUS+qGnWYXRhIFgUOluumMrFrQfw+IzBrxI6xR0U2VcalViBVM7iLgYeaFYfkK9HIMxLm1GXYUvoNCm@vger.kernel.org, AJvYcCW8Obf+ZqiWPrLH7Yi/S23Lv4pX9wWWwVg0dgqz0OpruOQop5HZZjCyVVJoUYAHY/VyWzLgwCJ/@vger.kernel.org, AJvYcCXtX67TM3G7EqX88ThAzAZs9eKIjy6i7iWFfH/FOlzp93x8lp94+4Uwv+f/YYkicLlVXrhvM9v0/i7rpauu@vger.kernel.org X-Gm-Message-State: AOJu0Yzq3+ZEp0wQ2xMF1UV8NR3D1rbAXOpgfVK+nS6O12LmoV8jHt4M Xa9PsXSETeZe2e9v2VlWb9GTrqYRMmY8MA6jLaypYxQfslbVxCCm X-Gm-Gg: ASbGncuEemFgR5TLWBWrdrYcu9FNqOn+6TjP+/OWnHZ7h3cbwDaAjpnclWDc5BKEV4y Q6/yuEWoCf7XOnCsZSVCMZ7rguaYBDHFzuif73HWdJ0R6IROCnIepMGGa8OAfpzkIvxmgeHlqBh N/779UaqZjdCCFF+FJWDh9/k4bin8jwK8mWXAFXuqKaWmAM9I+dXNgxPhvrfH9osXfYFnb2AVld 0VWIrDniW4N4ViFaQ00839yQZZXn4qZbRq9m9Tu1HeyFNSKgPcnp6E8A5CFpTaIXsg+JI27DqqP vjmEEPFGnInVyA4JBJ69yCEhupPzLeIuIPBfS2EcM0RgbBxMPEXDIEh40nLQhXhcDy3p4HxtGQj r59yV X-Google-Smtp-Source: AGHT+IFVv7oza45Q2QfziPl/5KRvPAxx5elH3SF3XZpjCrkHu0ZxgVl+w6k+ib6M2XHCdlmCCVtmpQ== X-Received: by 2002:a05:600c:4686:b0:43d:94:2d1e with SMTP id 5b1f17b1804b1-442f20e9013mr43795755e9.13.1747250328632; Wed, 14 May 2025 12:18:48 -0700 (PDT) Received: from [192.168.0.253] (5D59A51C.catv.pool.telekom.hu. [93.89.165.28]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-442f39ef811sm38707525e9.35.2025.05.14.12.18.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 May 2025 12:18:47 -0700 (PDT) From: Gabor Juhos Date: Wed, 14 May 2025 21:18:33 +0200 Subject: [PATCH v2 2/7] pinctrl: armada-37xx: set GPIO output value before setting direction Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250514-pinctrl-a37xx-fixes-v2-2-07e9ac1ab737@gmail.com> References: <20250514-pinctrl-a37xx-fixes-v2-0-07e9ac1ab737@gmail.com> In-Reply-To: <20250514-pinctrl-a37xx-fixes-v2-0-07e9ac1ab737@gmail.com> To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Linus Walleij , Bartosz Golaszewski Cc: Imre Kaloz , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Gabor Juhos , stable@vger.kernel.org X-Mailer: b4 0.14.2 Changing the direction before updating the output value in the OUTPUT_VAL register may result in a glitch on the output line if the previous value in the OUTPUT_VAL register is different from the one we want to set. In order to avoid that, update the output value before changing the direction. Cc: stable@vger.kernel.org Fixes: 6702abb3bf23 ("pinctrl: armada-37xx: Fix direction_output() callback behavior") Signed-off-by: Imre Kaloz Reviewed-by: Andrew Lunn Signed-off-by: Gabor Juhos --- Changes in v2: - swap with patch 3 from v1 - add 'Reviewed-by' tag from Andrew - reorder 'Signed-off-by' tags (result of 'b4 trailers -u') --- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c index 43034d29292687e875136aafa530b62479dc55ec..79f9c08e5039c31acb170d4f38b516b1454fd9ea 100644 --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c @@ -417,23 +417,22 @@ static int armada_37xx_gpio_direction_output(struct gpio_chip *chip, unsigned int offset, int value) { struct armada_37xx_pinctrl *info = gpiochip_get_data(chip); - unsigned int val_offset = offset; - unsigned int reg = OUTPUT_EN; + unsigned int en_offset = offset; + unsigned int reg = OUTPUT_VAL; unsigned int mask, val, ret; armada_37xx_update_reg(®, &offset); mask = BIT(offset); + val = value ? mask : 0; - ret = regmap_update_bits(info->regmap, reg, mask, mask); - + ret = regmap_update_bits(info->regmap, reg, mask, val); if (ret) return ret; - reg = OUTPUT_VAL; - armada_37xx_update_reg(®, &val_offset); + reg = OUTPUT_EN; + armada_37xx_update_reg(®, &en_offset); - val = value ? mask : 0; - regmap_update_bits(info->regmap, reg, mask, val); + regmap_update_bits(info->regmap, reg, mask, mask); return 0; } From patchwork Wed May 14 19:18:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabor Juhos X-Patchwork-Id: 889997 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D50E9292915; Wed, 14 May 2025 19:18:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747250335; cv=none; b=pbTiXg/XJ7gkPVSSGFzBhJXJhH64PxgKaPvHxNDFgRhWxYX+SBsQGI8N6kdCkq6cVFsynOOSYGKMBVJPJkOZ9g/cCAvmDIRaAxvdCgMz3OiJ/yaIqjB/HIm/EGSCcYIJyDe1UU369S/pi/E60V+MnaxP6VfDgcQucrbJ+lAB2K4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747250335; c=relaxed/simple; bh=jlyE/5zTgoPhjJoVNnSQJM7bQxmZU/bpkCu7beL60fk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lOk7ilbVFMJ4LsvVj7E5RP/hg0pezxaCAisAWLBK0/mvE86Wrb2HjvZ1XOGiKTqHzveopjBeKQL7gZBjbnh5na1yNGdNlhfVSQBUT6MjqYrx96AXnV+umxNFk1kLMcM8q7Fqlelr8D8mrLq+VWgWTUdhvfjmgcqN73yABnLXtVM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZhJUA7DH; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZhJUA7DH" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-3a0b6773f8dso89622f8f.1; Wed, 14 May 2025 12:18:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747250331; x=1747855131; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/w5xa3ncgd49kFJyT9bhO/chzYmHK3SV50+YzkQ82VU=; b=ZhJUA7DHy9IbAa2fUT7tv10t0tlWZRWELtrOOkWOlFm+knyc3QgzZn28SGuzNUFR4J YZnIDNyzTcvwgPBLtCkmQykk6dtNsPyqUVrGDsx59+o100H6Cy6brOLLCdHVDl3VeFBb aN03M5mv4JrquPqedplLRguTSmvwV0a27oNKmEAtzc8MMlAMKI8uqy64uhav+jaOUqy7 OtTdZL0/lEv1OgsE1wfFpY2LmLwbGGGbSokH+X1HoK1sQjonlJUihAwgjLyhBN2Mhtbr iaV+l1rPhvBFy4OLy/QviPYUKSCUgwYCmB9bNETpLTo9uCwHtUxTgB4ohH1AAgHxOZoq BhfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747250331; x=1747855131; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/w5xa3ncgd49kFJyT9bhO/chzYmHK3SV50+YzkQ82VU=; b=cj3VgfIuyDJByMG1NGiNpZIpxxv8t5SnYcvHzFuIXOByJhgHKxsXRxILzdBqoLQk5v OfJoQuRiRQW9kRQaoF1oI5JBfzesGLvID2ouGJcFpdIlxLDKmuJhF0CRSVxcamkKAPpJ AkgiS3SK7nMMTOn9qsmMqSSpF4+VpsNegGGqYibx+1hixXdfDSn7F8LzL9ddATiS7pnJ gT+zYJ0qxFq4OmBHX+StApb2wo4AdlSh2lE3D17NGRqlUWng7AkfRY4JVPnY7kPYKBfW Xk6QF8EsHkWa9heROWE3EDPWZoy2z7lRiKoKo9Vo40PX0zpYOTqaO/olzDlS41N2A51h GNPg== X-Forwarded-Encrypted: i=1; AJvYcCVE06PwXKiW1FYFxYjM+HNXTR/c11Xb1HwGf9FD1v6mjM4Sqk7MK48fuSrxjjxpXAOxP94S61yLNSL/@vger.kernel.org, AJvYcCVQnu8QZoxw/s2F4ER69J0somjyq8FL7BH1nCliTSxdcTBCOwaB0qvrPjuh0FLS65L9FelE6XpWIqMHRl0U@vger.kernel.org X-Gm-Message-State: AOJu0YzN9J6u3SRVTlM4Au9qcVKpM4MIx7vw7Ujoo0Sw1DyULcp7yjEr ugtEkZ7LThtlmkPAvSJQKFe0S6T3sV9rRnhCxAwlFRPOo//p7WIp X-Gm-Gg: ASbGncupGAsiD54XE8DnhdZiduetkMU/y2/LWlIJ38jnTnei0s7HGPQbbTgtF15J/hs vRt/Se5RBF2D+KAMMWnLcIS3nZiURzPCH/3rOgla6bnZcr29iuw826DiewvOlsL3vJLzFi2O3lG 4/HNMHXJ3Sz+Vdv915vRGKh2MhBUtm5v44jO07DiEJo9pNlBWnAew6eiqfUb0GaPMXjwhGWlwi/ dgcepPrYaDOhWQc+DBJIsb4hmTlL94qIubrQ1C1qUwDMYOGQjiwwlAPAFlk/fZ1wOA6THNrVii6 2QJSQ6/BrxmFGicwimo5ykGERmTEg4+bfAsh5HVAjRfur5sUIWmMBUs+KExfpPLp/AcSfnxqoxl bU0ix X-Google-Smtp-Source: AGHT+IEgJuTYC7ocCZO4XzaB8x9Uw4o8jNbva79UgC8DZ96g+uMc/4dsrtA/ArSqnVslHqk6qc2TAg== X-Received: by 2002:a05:6000:4382:b0:39e:f9e8:d07d with SMTP id ffacd0b85a97d-3a3496a497emr4133973f8f.20.1747250331033; Wed, 14 May 2025 12:18:51 -0700 (PDT) Received: from [192.168.0.253] (5D59A51C.catv.pool.telekom.hu. [93.89.165.28]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-442f39ef811sm38707525e9.35.2025.05.14.12.18.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 May 2025 12:18:50 -0700 (PDT) From: Gabor Juhos Date: Wed, 14 May 2025 21:18:35 +0200 Subject: [PATCH v2 4/7] pinctrl: armada-37xx: propagate error from armada_37xx_gpio_get() Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250514-pinctrl-a37xx-fixes-v2-4-07e9ac1ab737@gmail.com> References: <20250514-pinctrl-a37xx-fixes-v2-0-07e9ac1ab737@gmail.com> In-Reply-To: <20250514-pinctrl-a37xx-fixes-v2-0-07e9ac1ab737@gmail.com> To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Linus Walleij , Bartosz Golaszewski Cc: Imre Kaloz , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Gabor Juhos X-Mailer: b4 0.14.2 The regmap_read() function can fail, so propagate its error up to the stack instead of silently ignoring that. Signed-off-by: Imre Kaloz Reviewed-by: Andrew Lunn Signed-off-by: Gabor Juhos --- Changes in v2: - remove 'stable' and 'Fixes' tags - add 'Reviewed-by' tag from Andrew - reorder 'Signed-off-by' tags (result of 'b4 trailers -u') --- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c index 8d93d36af63ab9496376219454214c05db30971f..2e88a0399d1a205064b58890db6477e2202bf311 100644 --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c @@ -440,11 +440,14 @@ static int armada_37xx_gpio_get(struct gpio_chip *chip, unsigned int offset) struct armada_37xx_pinctrl *info = gpiochip_get_data(chip); unsigned int reg = INPUT_VAL; unsigned int val, mask; + int ret; armada_37xx_update_reg(®, &offset); mask = BIT(offset); - regmap_read(info->regmap, reg, &val); + ret = regmap_read(info->regmap, reg, &val); + if (ret) + return ret; return (val & mask) != 0; } From patchwork Wed May 14 19:18:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabor Juhos X-Patchwork-Id: 889996 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BFC7293746; Wed, 14 May 2025 19:18:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747250338; cv=none; b=SS1IHO63XyrAUUrMNotiLaw7MR1uCuzRRJWwrlfZnp8L/oQtNUQrKQ6wShlODMI2akLYDXM07wKaVPKk/LQU9CRYRC+MO2jSWVZrfVg1tYWIrZunaBcd5OK081tqZ/Zl5KFis501aMIe5CA6ZDLviGwCeTPP9hhfXxv0UBhWZp4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747250338; c=relaxed/simple; bh=c162Anph3qlAPGzo2CLpqBLKtsxPBThotJe6YKAgJZg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=P3d+pRwU93OruB1ldHCq8MF6RX3v+/TCDAfh5oFxK/dNiAH6UMq/SkNkjdLc6nq1qy2bqUvlcHoHJpKTLqiUH2XO0jLSantNnLu6qkmIbvE4FTVJiOe0GA64qvJzyn2gjBE+FTEdY0RaK7YzEvkZ0iJ4rAWyLMx2DASp6NaGFN4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FISLwmRe; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FISLwmRe" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-3a1d8c09674so87031f8f.1; Wed, 14 May 2025 12:18:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747250334; x=1747855134; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3JH55QdZJtAaACW1NAFT3cE1dsxbphEYIr1BTgO2aG4=; b=FISLwmRecUnKV7+bPJlE9iWF+npXyPH6Xpi6/FYrHX+y+jgTAt2MtVnlRX0VkkYGI2 +TuN2tMlVZQuViUWbMse4vwkVNuWTLD9jE3G6Np9H+MHgjXtfZ4QzGHrMF2g/tfaBucg PezWptj19pAcAjl6/YYl5Ex5ylTC2mJB7RcgNCCL3lcmLr5/ddEntkUeSqqhscZstSby 65pn/MmtY+r4QYwkKPbSklis8lRnVU9XMaObUdx21KQOC+tf+7D7Upypdpjh0uoTH6ZZ 8qFLoavwwBgMu8z8BoI1JFOmEJgCJlX+HM/f2j8/J/3GAwLWvqbztZUb60VQxuyLicvL SIcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747250334; x=1747855134; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3JH55QdZJtAaACW1NAFT3cE1dsxbphEYIr1BTgO2aG4=; b=su0jFvWjDcBuQp/LtcSo3PlhSOkCAJfVN8GtC7se7uKly4Zwh1TAChrx/Faxtz/pZ6 sVqheRSbJ9R7F1/jk1JoJ4yNAItVQt8V14/akP7eNpXwNAqB6QXL6guFJ1qXucZ6bsGy sW5vVYuc4ihHlhAm4szVGJBegnUz/SgYeyGaTNl5jqsEdNI8lF9yNLhuyAwvpRQWY7WE 5LoNhCZR0/0rIDsQ5TGxbgscrzQr/SQJ9ig5wgeaYKznK0ZT3hoBLXxHfLN+tBmgIHR1 LzqHjppNbKwwBSAt0NLy4md4+L0vfbJ+DxwAFi9+OmV8v2s3TaEjm9Z+PgtkNZZp0LVx KIIQ== X-Forwarded-Encrypted: i=1; AJvYcCX5YFmGk4lS05v3wtpCFUBEaFQtKJtoYfKJFakoM06x5KupSKHso8sw1o/G2D6moTCZfqXzgiHC7LhAuTnh@vger.kernel.org, AJvYcCXmISiBpWWBZov5WSLYAnbvDN+AymOWU4QgxAvU2WXlcXavVjqz6DyWNyh6r3fqYFEDZjvwdWCHRKwh@vger.kernel.org X-Gm-Message-State: AOJu0Yx+4Oid425MuiI6zxx/Ksiw6lczgXX96oJVT0x60KUE6MqOpTda owRpq4gAqZFveJz+i/ZVhkiqW5blc8qwowtmSGXt11hJpN+SDyCR X-Gm-Gg: ASbGncu3A3zrBQl0mSAG1lBgoE/gke7/onZfbxj7unPWIGYuQyi1b58Nli1PL+HWQ6h 61dg5PhRO2A+eTDDeo5QT36hXoSYvoyD4vInwlddvmlxRnt2Hsun3CLaUqFJ6Gy0d/wx6/9mjDJ HTHbD3t65fTcqdpAdPRUE71pW4NufufLGvQOA+gaE44DJ1xua48nuD6voSEHM+uKOSqo4t5K7bt bSj1+2qcZ5RI47uiaBwUw4z3ST0h2Pgq6Jvir+lG1EQREyfG/z26Fx+yEUlbBf26MnC9YKA4z53 S6ajmqCxk13x+DVF0S/I3cKbaN2ClolX5QL6+XSpfbYQZlJhrDHz5T0dI9HnqWXnmGiLKSbYzge TaM5m X-Google-Smtp-Source: AGHT+IHzNZaFCgyXoBk/vI3JWqPShaXSNalLho71Vx1hM7ORoJVxx3uDSV4erFJ5/o6LPZDyD2SVTA== X-Received: by 2002:a05:6000:40dd:b0:39d:724f:a8f1 with SMTP id ffacd0b85a97d-3a34969487emr4027229f8f.10.1747250333647; Wed, 14 May 2025 12:18:53 -0700 (PDT) Received: from [192.168.0.253] (5D59A51C.catv.pool.telekom.hu. [93.89.165.28]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-442f39ef811sm38707525e9.35.2025.05.14.12.18.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 May 2025 12:18:53 -0700 (PDT) From: Gabor Juhos Date: Wed, 14 May 2025 21:18:37 +0200 Subject: [PATCH v2 6/7] pinctrl: armada-37xx: propagate error from armada_37xx_gpio_get_direction() Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250514-pinctrl-a37xx-fixes-v2-6-07e9ac1ab737@gmail.com> References: <20250514-pinctrl-a37xx-fixes-v2-0-07e9ac1ab737@gmail.com> In-Reply-To: <20250514-pinctrl-a37xx-fixes-v2-0-07e9ac1ab737@gmail.com> To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Linus Walleij , Bartosz Golaszewski Cc: Imre Kaloz , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Gabor Juhos X-Mailer: b4 0.14.2 The regmap_read() function can fail, so propagate its error up to the stack instead of silently ignoring that. Signed-off-by: Imre Kaloz Reviewed-by: Andrew Lunn Signed-off-by: Gabor Juhos --- Changes in v2: - remove 'stable' and 'Fixes' tags - add 'Reviewed-by' tag from Andrew - reorder 'Signed-off-by' tags (result of 'b4 trailers -u') --- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c index aed0069b085ced5867993e95e0244df7ccda556d..18c6c5026b26c294ee65e3deea02d2e852e10622 100644 --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c @@ -402,10 +402,13 @@ static int armada_37xx_gpio_get_direction(struct gpio_chip *chip, struct armada_37xx_pinctrl *info = gpiochip_get_data(chip); unsigned int reg = OUTPUT_EN; unsigned int val, mask; + int ret; armada_37xx_update_reg(®, &offset); mask = BIT(offset); - regmap_read(info->regmap, reg, &val); + ret = regmap_read(info->regmap, reg, &val); + if (ret) + return ret; if (val & mask) return GPIO_LINE_DIRECTION_OUT;