From patchwork Wed May 14 16:27:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 890056 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C264F1DF994; Wed, 14 May 2025 16:28:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747240131; cv=none; b=QaIicDjjwADaTDccRc03faSbe9Xna61LXLHwDiOYF500SJ7qusx/x4izAhq8zcy8ctQSjyiSi0j1XDI2hYX34jEv3VJlzc+dOXRN7MdggD4xlAvwuO+X1zZFibXewJ5UncmUu9zdvGLrxM9gARqMZQPAmv/hoZN8nWUGVHfqHpQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747240131; c=relaxed/simple; bh=XwpvdJj7/FvWWHGNfEpZ5k4PCCpLNXQ1N0RRVFxieuQ=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=GjgTNB93zWa9R7RPwQ4uIRwladSfJP8pFybPo3cBSk7ry/z2Dar86CXTv+bukDHkar5reQo8/81jX8eSRN37+emj1S699D6bdZJYqvXXMm9QvADUZ52T+uWRzkviBixXxPtSskwQutu5JnC61J7VQ6Y+g0uGQfzZq2E3E59rqlc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MzerA7hm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MzerA7hm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93972C4CEE9; Wed, 14 May 2025 16:28:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747240131; bh=XwpvdJj7/FvWWHGNfEpZ5k4PCCpLNXQ1N0RRVFxieuQ=; h=From:To:Subject:Date:From; b=MzerA7hmXnTWXA0YHp2z8MTiAsbXU6kd30TJDfDgit2MIU/3CGTY+PtteLvtVbzFe XJmQCZJFRBRGObdrr8ivkb/wr85JMqvslrpz1ABh2oZGaCk5cOCUxRprN2rNjjot/x mIVOtg+/Iy3G5dg5nQD4dveg75JwGn1mQHgYrwqUBp+gkwIbCwvY5dApevTzyZNiAa 5g1/SLSd+RuJ1CZRdHPX6bNymOh3MHdafr8Eyn5HMhH81vaFk87D4uGYhoVB3lBJOS PW1Ir+k5ESsgLFlH45k5ut6W9YFXJMTgqPkBgRSq5vq2EKWE/CCz5RjoZxDyEMS9xM dnrx4dtoZaw3Q== From: Lee Jones To: lee@kernel.org, bettyzhou@google.com, ynaffit@google.com, tkjos@google.com, jacek.anaszewski@gmail.com, Pavel Machek , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/5] leds: led-test: Move common LED class registration code into helper function Date: Wed, 14 May 2025 17:27:52 +0100 Message-ID: <20250514162807.708010-1-lee@kernel.org> X-Mailer: git-send-email 2.49.0.1045.g170613ef41-goog Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Since we will always need to register an LED class, it makes sense to avoid duplicating this part over and over. Returning void and not propagating errors is expected here since the assert will terminate the process early if an error condition is encountered. Signed-off-by: Lee Jones --- drivers/leds/led-test.c | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/leds/led-test.c b/drivers/leds/led-test.c index ddf9aa967a6a..0f152fb12dfb 100644 --- a/drivers/leds/led-test.c +++ b/drivers/leds/led-test.c @@ -22,10 +22,10 @@ static enum led_brightness led_test_brightness_get(struct led_classdev *cdev) return LED_TEST_POST_REG_BRIGHTNESS; } -static void led_test_class_register(struct kunit *test) +static void led_test_class_register_helper(struct kunit *test) { struct led_test_ddata *ddata = test->priv; - struct led_classdev *cdev_clash, *cdev = &ddata->cdev; + struct led_classdev *cdev = &ddata->cdev; struct device *dev = ddata->dev; int ret; @@ -36,6 +36,17 @@ static void led_test_class_register(struct kunit *test) ret = devm_led_classdev_register(dev, cdev); KUNIT_ASSERT_EQ(test, ret, 0); +} + +static void led_test_class_register(struct kunit *test) +{ + struct led_test_ddata *ddata = test->priv; + struct led_classdev *cdev_clash, *cdev = &ddata->cdev; + struct device *dev = ddata->dev; + int ret; + + /* Register initial device - same as always */ + led_test_class_register_helper(test); KUNIT_EXPECT_EQ(test, cdev->max_brightness, LED_FULL); KUNIT_EXPECT_EQ(test, cdev->brightness, LED_TEST_POST_REG_BRIGHTNESS); @@ -63,12 +74,9 @@ static void led_test_class_add_lookup_and_get(struct kunit *test) struct led_classdev *cdev = &ddata->cdev, *cdev_get; struct device *dev = ddata->dev; struct led_lookup_data lookup; - int ret; /* First, register a LED class device */ - cdev->name = "led-test"; - ret = devm_led_classdev_register(dev, cdev); - KUNIT_ASSERT_EQ(test, ret, 0); + led_test_class_register_helper(test); /* Then make the LED available for lookup */ lookup.provider = cdev->name; From patchwork Wed May 14 16:27:53 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 890435 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E9691DF994; Wed, 14 May 2025 16:28:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747240135; cv=none; b=eC+pzZLDkwL3R4nVPfF5ThEZoZJvVjSW+GO6+BjmvZVIQo4UTAGkkxUm++T3ecNC/Gew3NoLxHFxHNcmpnxwCiWn5oaI393tucQFmKQ5sMpnkloq807CQV2XRGcYYoCG7ZcJWGgHDs1XOoZT+s1qKnpB3HysQ5h25hnef4jlgVk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747240135; c=relaxed/simple; bh=3TE35hqTDVtiIk98kRy31bNG5xD/ZKIvkLUctYVIXN4=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gVVFtP9kuvbAaUTDwMI+LufaHsgMBIScWxQhjuWh36+HWK9s6YBij+Ndtjb6f4nKyxyMfn/oaqe8ixszKiPuG7Llv24zWVuEy/b2+3SI0fAWnDln21BxZjZ/pa20fOnK4Rl9N2SPLGtLJxagzM254p8FmldJxrUoVIp2XOWSeTA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=asKuXhhg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="asKuXhhg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC10DC4CEE3; Wed, 14 May 2025 16:28:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747240133; bh=3TE35hqTDVtiIk98kRy31bNG5xD/ZKIvkLUctYVIXN4=; h=From:To:Subject:Date:In-Reply-To:References:From; b=asKuXhhgVCJdInbain9/JTZOEJFIxlRe50e0vPtncBmVOror3ZiL9SYfvUlLS+3gk dDZQKZq/HJAjjlzu/k3ffqObXePaA5MbrfSGKegM1u/4NKQUphmsk2Rncn7WfXLiLS cYbFJ+2HHrl3+au1k8qIuTExM3+ZIp6IZN3GeT5NasQ2D9fUgEy52aUeApgaGUSEVB hJ2z86tj2ZfpEKXQuzgp04lv5+2NsjwRcTe5cGALEXS1OLsl7EUo15Tad3OsV355z9 qRF10Ak3mYm1xIWEGeGQHqHC/knDmtDhW0n7O7znr/7nZo4SIJuNTU4awaUMAi5B+9 dlgI9QBi97Dbw== From: Lee Jones To: lee@kernel.org, bettyzhou@google.com, ynaffit@google.com, tkjos@google.com, jacek.anaszewski@gmail.com, Pavel Machek , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/5] leds: led-test: Provide test for registration with missing default_label Date: Wed, 14 May 2025 17:27:53 +0100 Message-ID: <20250514162807.708010-2-lee@kernel.org> X-Mailer: git-send-email 2.49.0.1045.g170613ef41-goog In-Reply-To: <20250514162807.708010-1-lee@kernel.org> References: <20250514162807.708010-1-lee@kernel.org> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Insist on legacy (non-DT) registration and omit the default_label, which should fail with an invalid argument error. Signed-off-by: Lee Jones --- drivers/leds/led-test.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/leds/led-test.c b/drivers/leds/led-test.c index 0f152fb12dfb..27c8d13bd2e1 100644 --- a/drivers/leds/led-test.c +++ b/drivers/leds/led-test.c @@ -93,9 +93,25 @@ static void led_test_class_add_lookup_and_get(struct kunit *test) led_remove_lookup(&lookup); } +static void led_test_class_init_data_missing_default_label(struct kunit *test) +{ + struct led_test_ddata *ddata = test->priv; + struct led_classdev *cdev = &ddata->cdev; + struct device *dev = ddata->dev; + int ret; + + struct led_init_data init_data = { + .devicename = "led-test-devicename", + }; + + ret = led_classdev_register_ext(dev, cdev, &init_data); + KUNIT_EXPECT_EQ(test, ret, -EINVAL); +} + static struct kunit_case led_test_cases[] = { KUNIT_CASE(led_test_class_register), KUNIT_CASE(led_test_class_add_lookup_and_get), + KUNIT_CASE(led_test_class_init_data_missing_default_label), { } }; From patchwork Wed May 14 16:27:54 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 890055 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 790B927CCF6; Wed, 14 May 2025 16:28:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747240136; cv=none; b=GfJpPglNcqbiFny4V8S3MQMEKNB5YR8+L0ZP0tlLBxiv6rD/pLnDLBU25HNwTDLyplEYYWKzK9qGecjKQyPmVEyH1DX8N490VpqdHqmkId3d/1hYEbfxc/J5KzWg3ArOBQKir1opfsxeIyLEtOvx1Wv0sdKU2XFAu469Q/E45ME= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747240136; c=relaxed/simple; bh=1/ch9q2arJV7wR9O5cQaSNVKk844AHl2YzhHV/R+8y0=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=isc4EIS2496WOxdiguAPxvgBgZCQkp3zBmzYKC8fWpFHqzwltvpIs+gQEmEJjfTfnq777cz2QbH7R7T+z8mFSkvgjmJUsDT4W9np64E9tcGlUuZz6FBTNnI0/Aek5Hqn7eI7mBBxwxaoQwVbGggh5aZCTkzlssD9VBhBU2Hxs24= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Xp/z8pLE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Xp/z8pLE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51A78C4CEED; Wed, 14 May 2025 16:28:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747240136; bh=1/ch9q2arJV7wR9O5cQaSNVKk844AHl2YzhHV/R+8y0=; h=From:To:Subject:Date:In-Reply-To:References:From; b=Xp/z8pLE6ANZbQ8gc1QFoPtM9MDU4stcY1holVPgYx3hs22ErK06tHLhZ5RNJZQZo pnoY2EngYRh9aj8WK56zeSmnEG3Yy18VYIcsp7LvpkUmseXeLIyRe3njJaOE1pf0it I66ddJhkY0hATO9QQBesV8dgt9+ldbFAh+KZjtYI+FqVrdkAcyaum6VvwpUlXtTvrW QF5XqGitf9Q6lphBf4T2ySgd01tnfyWevDCwteRa1u+1dHEuEKE5iYBw78DuKdFJQ7 Le/qjlHLfzZJNaGrojAOW+0wpZYmMj3EGiiLuQhRmW7kDHb8V6MRI4UWBqbGEGSzLf 3nbA1hGklyWfA== From: Lee Jones To: lee@kernel.org, bettyzhou@google.com, ynaffit@google.com, tkjos@google.com, jacek.anaszewski@gmail.com, Pavel Machek , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/5] leds: led-test: Provide test for registration with missing devicename Date: Wed, 14 May 2025 17:27:54 +0100 Message-ID: <20250514162807.708010-3-lee@kernel.org> X-Mailer: git-send-email 2.49.0.1045.g170613ef41-goog In-Reply-To: <20250514162807.708010-1-lee@kernel.org> References: <20250514162807.708010-1-lee@kernel.org> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Insist on legacy (non-DT) registration and omit the devicename, which should fail with an invalid argument error. Signed-off-by: Lee Jones --- drivers/leds/led-test.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/leds/led-test.c b/drivers/leds/led-test.c index 27c8d13bd2e1..3d71c7a23e21 100644 --- a/drivers/leds/led-test.c +++ b/drivers/leds/led-test.c @@ -108,10 +108,26 @@ static void led_test_class_init_data_missing_default_label(struct kunit *test) KUNIT_EXPECT_EQ(test, ret, -EINVAL); } +static void led_test_class_init_data_missing_devicename(struct kunit *test) +{ + struct led_test_ddata *ddata = test->priv; + struct led_classdev *cdev = &ddata->cdev; + struct device *dev = ddata->dev; + int ret; + + struct led_init_data init_data = { + .default_label = "led-test-label", + }; + + ret = led_classdev_register_ext(dev, cdev, &init_data); + KUNIT_EXPECT_EQ(test, ret, -EINVAL); +} + static struct kunit_case led_test_cases[] = { KUNIT_CASE(led_test_class_register), KUNIT_CASE(led_test_class_add_lookup_and_get), KUNIT_CASE(led_test_class_init_data_missing_default_label), + KUNIT_CASE(led_test_class_init_data_missing_devicename), { } }; From patchwork Wed May 14 16:27:55 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 890434 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4E1527FB2B; Wed, 14 May 2025 16:28:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747240138; cv=none; b=cUmYkQMqNpW/VTvWaGNgAlvZXR6izXyVZwxpiNLBfMk7oXcx9Ahvd2rCY5nU9HfXzKDmTb2WDJNwVTcMtQKdkVUeHeCUzgVU+N3QyKlrXR/IRVs/vWXUh70CWJXabSRWNnwDChTiQAd8tSXgf6LKFytyPY/MRL2+VC5CEg/nyBo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747240138; c=relaxed/simple; bh=cmM31LAa75nZJMCe8JZ+Zr9c30GPrpS490ZGzVPjfOk=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=G+XGbDUFhDNfGXGVONevXN0GThXJ/kIizLDbkL9sQQ2SQfDC7xk0bgwv9GALysJTN1yqyoEbtQQp60Y9lomhMnmwbwLRmfmU0aGZNxDngqF7veHRgXy6Qqto7wkFU++yx7+mEs2c52UkVT5DQYi/MCVqBrN0TyVcqubnji1gwBc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UuHprccX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UuHprccX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A80BCC4CEED; Wed, 14 May 2025 16:28:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747240138; bh=cmM31LAa75nZJMCe8JZ+Zr9c30GPrpS490ZGzVPjfOk=; h=From:To:Subject:Date:In-Reply-To:References:From; b=UuHprccXYlIej26h2GSqgWBkgvNNTsvYq6gd48QstggvLAu+dvBUILxz9/23EY8AO yoOpHLMG60ZYbGWUGkzr7YJGvuy8y26IhebrPUniGy1nmbcgfC859VM37RglDw6SwR JGrHfgJKXCLHNwrEA3MAHP9zab29OI1qnZcESjs+DHrn/G/V/C9MquckRVxSnP86J2 dPSOJGLkf/VK5yR2W2Pirlpmm4v3skgIhHQbmf/uefer69ixY9HcMpgLTzLx7BDLd1 N05tvI5vsas84i4ajsnQqZ7a3/WsSF4awUef6xtSb47T3ROvHusc0cRW1dmMAvufFl EKNmumE+qJd5g== From: Lee Jones To: lee@kernel.org, bettyzhou@google.com, ynaffit@google.com, tkjos@google.com, jacek.anaszewski@gmail.com, Pavel Machek , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/5] leds: led-test: Provide test for registration with a name that is too long Date: Wed, 14 May 2025 17:27:55 +0100 Message-ID: <20250514162807.708010-4-lee@kernel.org> X-Mailer: git-send-email 2.49.0.1045.g170613ef41-goog In-Reply-To: <20250514162807.708010-1-lee@kernel.org> References: <20250514162807.708010-1-lee@kernel.org> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Insist on legacy (non-DT) registration and provide a default_label and devicename that when concatenated together results in a device name that is unacceptably long. Signed-off-by: Lee Jones --- drivers/leds/led-test.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/leds/led-test.c b/drivers/leds/led-test.c index 3d71c7a23e21..741dc0269515 100644 --- a/drivers/leds/led-test.c +++ b/drivers/leds/led-test.c @@ -123,11 +123,28 @@ static void led_test_class_init_data_missing_devicename(struct kunit *test) KUNIT_EXPECT_EQ(test, ret, -EINVAL); } +static void led_test_class_init_data_name_too_long(struct kunit *test) +{ + struct led_test_ddata *ddata = test->priv; + struct led_classdev *cdev = &ddata->cdev; + struct device *dev = ddata->dev; + int ret; + + struct led_init_data init_data = { + .devicename = "led-test-devicename-very-long-names-fail", + .default_label = "led-test-label-also-very-long-names-fail", + }; + + ret = led_classdev_register_ext(dev, cdev, &init_data); + KUNIT_EXPECT_EQ(test, ret, -E2BIG); +} + static struct kunit_case led_test_cases[] = { KUNIT_CASE(led_test_class_register), KUNIT_CASE(led_test_class_add_lookup_and_get), KUNIT_CASE(led_test_class_init_data_missing_default_label), KUNIT_CASE(led_test_class_init_data_missing_devicename), + KUNIT_CASE(led_test_class_init_data_name_too_long), { } }; From patchwork Wed May 14 16:27:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 890054 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DB0128031A; Wed, 14 May 2025 16:29:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747240141; cv=none; b=P9yAjDmwldH9t1FXV4ky6s4Mb4z8Z2jY8k4Ldz2IhlPcLlJHO4ckfZceaw/Sv26VdszwK68uw3jJfui+q4ftUMtRz7SO8WVktWmzoX8rh2zBY6cah7lD9KzioTGcLvkU8/cyJm7B3kiYkpwoKkAlQsYkRxtEg4ZF93PEbg77wVs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747240141; c=relaxed/simple; bh=Gr24NwIpvXUdDA6goxGK/Y2r676Txw/MJuwGccnCO3c=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UQPg3ZmiHCvYn3BsPuo3tm95q0ar8pUrh1DSvF4nzQa6AwgsK8qORxm7Q1BAuAGvAUabAv4kfkvexaaozNYttdjQayol8Jb4yP1wHCktC20zkJkEFBe0jsgWCw1UH3pVjLO5SGsDRDUvaXdIlHWRlJXTZRk4F6OAaSznQO5OQbg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DSZq0tSq; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DSZq0tSq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09EB4C4CEE9; Wed, 14 May 2025 16:28:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747240140; bh=Gr24NwIpvXUdDA6goxGK/Y2r676Txw/MJuwGccnCO3c=; h=From:To:Subject:Date:In-Reply-To:References:From; b=DSZq0tSqAwR67zb2bAv/Cr/E+d22nRNFcaglwdd28aYp4yIJxnJtVqfkW6iULIzD/ 7pq+mQU/Nyzy6iYF6SG87vuK5IMEq1h0iSOUo6PI6ZjtNLB8/wlVfTWYzePQOJxTFJ 6Ev1j3/6iQ/aZuiaIcwdYYmX9ANHI7qCIrLJEEgd7mTGwqzlDevX+iYItBix3x2ga3 A1viVPy679GYjMLo0qbDWoUNYKbwKuS9Qwthi+J1jr6lUp03ChOfHDyGQkG/g4XYQ0 8F60NbN7tkzwZxnWBVXm1rCNkzWcpNtLyRCa55Hq1JQkCuO8ErBg4jafgC8wgxsyC2 vqpa4KmnqaYwQ== From: Lee Jones To: lee@kernel.org, bettyzhou@google.com, ynaffit@google.com, tkjos@google.com, jacek.anaszewski@gmail.com, Pavel Machek , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/5] leds: led-test: Provide test for successful registration using init_data Date: Wed, 14 May 2025 17:27:56 +0100 Message-ID: <20250514162807.708010-5-lee@kernel.org> X-Mailer: git-send-email 2.49.0.1045.g170613ef41-goog In-Reply-To: <20250514162807.708010-1-lee@kernel.org> References: <20250514162807.708010-1-lee@kernel.org> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This time both the default_label and devicename are provided such that when concatenated together result in a device name that is acceptable. In this case registration should succeed. Signed-off-by: Lee Jones --- drivers/leds/led-test.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/leds/led-test.c b/drivers/leds/led-test.c index 741dc0269515..123e1feb835e 100644 --- a/drivers/leds/led-test.c +++ b/drivers/leds/led-test.c @@ -139,12 +139,29 @@ static void led_test_class_init_data_name_too_long(struct kunit *test) KUNIT_EXPECT_EQ(test, ret, -E2BIG); } +static void led_test_class_init_data(struct kunit *test) +{ + struct led_test_ddata *ddata = test->priv; + struct led_classdev *cdev = &ddata->cdev; + struct device *dev = ddata->dev; + int ret; + + struct led_init_data init_data = { + .devicename = "led-test-devicename", + .default_label = "led-test-label", + }; + + ret = led_classdev_register_ext(dev, cdev, &init_data); + KUNIT_EXPECT_EQ(test, ret, 0); +} + static struct kunit_case led_test_cases[] = { KUNIT_CASE(led_test_class_register), KUNIT_CASE(led_test_class_add_lookup_and_get), KUNIT_CASE(led_test_class_init_data_missing_default_label), KUNIT_CASE(led_test_class_init_data_missing_devicename), KUNIT_CASE(led_test_class_init_data_name_too_long), + KUNIT_CASE(led_test_class_init_data), { } };