From patchwork Tue May 13 12:13:04 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Kodanev X-Patchwork-Id: 890135 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F5C928DB4F for ; Tue, 13 May 2025 12:14:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747138444; cv=none; b=TswlSMIk7ZEVvbuKbwArft2efqp+jPyELojVOAud2IPuBCwraw1IqYYbeWH7+VLGmTSzG4gZNHkm4U5ld+f+8MkwD8soVhZAw1uuhVLQ56Knq4y6eVl7mZMLT4A6z6OGiOwJLsTlbYLprDgOsx81b+bVetVrlmvbsFA056QTxAE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747138444; c=relaxed/simple; bh=LA/KCLameLqFOczlCUJ/2B4/nB7vo4JUftohFXDrgXY=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Ye4h9Mf2E1Cy8AQ0djv8YcWqgrVJ9SJTjFU1Pfx/F6PVqPlBjCqJ4TAS1nCxhDAEO6KVheXhavksyccIJX/BX8qHLht9NaBMmiMrnmHr5m+pAUs4pCxBL9JYuGkjwGcO8nxdtCv3m839LcfvL8p+OU1dTA9OVNQoLRR9pGuscLM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bell-sw.com; spf=pass smtp.mailfrom=bell-sw.com; dkim=pass (2048-bit key) header.d=bell-sw-com.20230601.gappssmtp.com header.i=@bell-sw-com.20230601.gappssmtp.com header.b=IO41QlRz; arc=none smtp.client-ip=209.85.167.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bell-sw.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bell-sw.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bell-sw-com.20230601.gappssmtp.com header.i=@bell-sw-com.20230601.gappssmtp.com header.b="IO41QlRz" Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-54fc61b3ccaso5772277e87.1 for ; Tue, 13 May 2025 05:14:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bell-sw-com.20230601.gappssmtp.com; s=20230601; t=1747138440; x=1747743240; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=fBlZgEOoEfroAGDNOtFCLBH/jbcjwtEuds8r227tD1Y=; b=IO41QlRzvA1J3/3k6dZolCl9QVCbpTfH3iBDZwWoiMTxW+N3rGNpk4iAYqRjmDepsB Us4Rixd7qymtPtaL+i8zFrRo3CEeuQ0G67CdVjqXbJpp/EidTFZJ/6i/TMPuq1EnmZlp W1vRf49mCUxXWVqTcoYMN8DBVd5d/L8nLsypfd9GhSBciK7tBVPc+QEl8NGOJI+XN6zs CICYu55GRxHh/WiLEySM/ACtvi3+yLuz8SU01Z56KlG3l8Y9rRFP/BoenVSh5rloZnuE 4zYR9sdV2xvHd3ibO+bmjkaVdlASbzRwjvoSRfwNxdAsl0f42GO7IodySDV2K01I5VQP F2lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747138440; x=1747743240; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fBlZgEOoEfroAGDNOtFCLBH/jbcjwtEuds8r227tD1Y=; b=q7VdNMs/tq0+JH6fv2xKt+6IsMQ1CF4p5Gze7FYhvW9qyNTPK70UfLuCoQAT4ds2pG Vn2rV9P2bINfgtbiBaogXS6hL7QZEQQgZoyn1pkRIGB7MQU5ybrWdVSXqWG9W2uJVs9r FQna3GC0dXUai6kNi2ikSCHq81NbKruIStOTiTox2BuvtQmtWbYarltsL2YZ16gBhFth pKbXYoCr5jO9agnPveoj6lawhn/w5prCcYJMWGLj57jXyLtcMk+HyuGuRpeTCOk7Gs/r 7mhx+kWmlDKNuNMbdUnFhzybbvmXHxsht1VzhHYdYpw6XJ8gP6BcuBeOY7XGM5eSFtNL Otpg== X-Gm-Message-State: AOJu0YxuyC19G9FY8Xc+Zb1wh1Exe+7JmGFSiWoPDmyr5A1xvVGwOCBW tCyI+9QNfir9lNChUe4HFhUEEPjkkGomDsM5mYJKmEqslaLSb7mnpntKEzbQI0PKazsHcXwz9Ts = X-Gm-Gg: ASbGncs2sZr6v0aH4BBQC2k+u50EpWWhx7DDGtgEOSffE7dEY+wPEeyApP5tbcdJdkM BHvn5eHUBACsWunzekks5+d/qWNYBGjCekpXfzI6gemoDAqikluoy8tpLz0o8GwBW4oEwjG0KoM 56F70aTSP79p5SeyodkVK12hWK6IBM54tCYTHe0aXchqrPZCaAtR//ta+jcH7H6bypks7vA47Iy 1Bppeb0DBkYfIGQ4VV/4biRW8Xmb8D4wVB6wFPBhqyY23e2FZluP0pJwVftbzXKl9Slz697UszO 67qoHHXxaO2NSR5dgUL6uvFQ/lA68ir72XXCDn9C8xuoZJwGzIHBimRq8o1/zoi053w= X-Google-Smtp-Source: AGHT+IE+2GmTp6jx2k0URSKcwhuRxgmsdmMIIUyJ9yehgMa56iPa5P8QafOjySC9AD26kZQGxzILCA== X-Received: by 2002:a05:6512:6286:b0:54f:c4ab:106e with SMTP id 2adb3069b0e04-54fc67cbe49mr5266453e87.28.1747138439923; Tue, 13 May 2025 05:13:59 -0700 (PDT) Received: from localhost.localdomain ([5.8.39.119]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54fc645cd2bsm1848085e87.73.2025.05.13.05.13.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 May 2025 05:13:59 -0700 (PDT) From: Alexey Kodanev To: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, Ping-Ke Shih , Kalle Valo , Alexey Kodanev Subject: [PATCH v2] wifi: rtw88: fix the 'para' buffer size to avoid reading out of bounds Date: Tue, 13 May 2025 12:13:04 +0000 Message-Id: <20250513121304.124141-1-aleksei.kodanev@bell-sw.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Set the size to 6 instead of 2, since 'para' array is passed to 'rtw_fw_bt_wifi_control(rtwdev, para[0], ¶[1])', which reads 5 bytes: void rtw_fw_bt_wifi_control(struct rtw_dev *rtwdev, u8 op_code, u8 *data) { ... SET_BT_WIFI_CONTROL_DATA1(h2c_pkt, *data); SET_BT_WIFI_CONTROL_DATA2(h2c_pkt, *(data + 1)); ... SET_BT_WIFI_CONTROL_DATA5(h2c_pkt, *(data + 4)); Detected using the static analysis tool - Svace. Fixes: 4136214f7c46 ("rtw88: add BT co-existence support") Signed-off-by: Alexey Kodanev --- v2: initializer style change drivers/net/wireless/realtek/rtw88/coex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtw88/coex.c b/drivers/net/wireless/realtek/rtw88/coex.c index c929db1e53ca..64904278ddad 100644 --- a/drivers/net/wireless/realtek/rtw88/coex.c +++ b/drivers/net/wireless/realtek/rtw88/coex.c @@ -309,7 +309,7 @@ static void rtw_coex_tdma_timer_base(struct rtw_dev *rtwdev, u8 type) { struct rtw_coex *coex = &rtwdev->coex; struct rtw_coex_stat *coex_stat = &coex->stat; - u8 para[2] = {0}; + u8 para[6] = {}; u8 times; u16 tbtt_interval = coex_stat->wl_beacon_interval;