From patchwork Thu May 15 08:28:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 890776 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88EF12980A7; Thu, 15 May 2025 08:29:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747297774; cv=none; b=ph1kzTjwxvSp15MNSlkM+dy/gkx81JGkFkuCPHIS6JheCOaYSDxB0fGZiU0gUItd0El9cXubNnWIsPExQcHe2UTmTWlpmmCka3AkwJNEmCbJVWNTciynk40iCYA1e41jZZe11BNLGMjORQqV19wIbLp9ypB7SiAwbbemiuMdTcY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747297774; c=relaxed/simple; bh=UyqFPPIsvZYPyxj9l36RUgJ7D0gy1o3YcnKbYtbWweA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=a6ZCEQa4zNZx3SnvxPPh0Hcbr9y/w6JHtXN6ekYXQK96MVLJzXkWq8OA3zdcNxFZyZWnPEr5pH2YgqneLgTDRUS04EE5tZd8piC8bLtczTQrpcpw6h5hsfnR2clo3a4D49pz2yn84kBY0YXjqfaxOGJ/0kpTHbbrLhmFitR/jrM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=m6F+jPQL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="m6F+jPQL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57B29C4CEE7; Thu, 15 May 2025 08:29:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747297774; bh=UyqFPPIsvZYPyxj9l36RUgJ7D0gy1o3YcnKbYtbWweA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=m6F+jPQLcNfjiJYQO+Jkz1RNfT4y7t4HRkYMXyJwl2jt7pS09E1MIFENOuawIKGX5 UAi8ZwhKJL7xc/GLH2D/EBeRlyF/T0yp0FSFQGbxT1tdpPN4NH4w4yEppdegqD9bbb GBczLkRUNlE8ZnLRkO0twQLVVwYfKyPV7ccmL43A0xRRvaJrukVfeSOORhHURBfxi3 R47iikQejujHqZK/wvjOfQNVvjqL6nd+WyUURVvAL9Dgb0voFPTJdYJ3R49IzfNnjL 2mmad9Xkcz6hRTjDpLyHFhYdpQT6tTaP5ZJnIIynWGZrwvHHW7GLz1uaWDt0aDt10p tfTdAq5gpVN4Q== From: Lee Jones To: lee@kernel.org, Pavel Machek , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: bettyzhou@google.com, ynaffit@google.com, tkjos@google.com, jacek.anaszewski@gmail.com Subject: [PATCH v2 1/5] leds: led-test: Move common LED class registration code into helper function Date: Thu, 15 May 2025 09:28:00 +0100 Message-ID: <20250515082830.800798-2-lee@kernel.org> X-Mailer: git-send-email 2.49.0.1101.gccaa498523-goog In-Reply-To: <20250515082830.800798-1-lee@kernel.org> References: <20250515082830.800798-1-lee@kernel.org> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Since we will always need to register an LED class, it makes sense to avoid duplicating this part over and over. Returning void and not propagating errors is expected here since the assert will terminate the process early if an error condition is encountered. Signed-off-by: Lee Jones --- drivers/leds/led-test.c | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/leds/led-test.c b/drivers/leds/led-test.c index ddf9aa967a6a..0f152fb12dfb 100644 --- a/drivers/leds/led-test.c +++ b/drivers/leds/led-test.c @@ -22,10 +22,10 @@ static enum led_brightness led_test_brightness_get(struct led_classdev *cdev) return LED_TEST_POST_REG_BRIGHTNESS; } -static void led_test_class_register(struct kunit *test) +static void led_test_class_register_helper(struct kunit *test) { struct led_test_ddata *ddata = test->priv; - struct led_classdev *cdev_clash, *cdev = &ddata->cdev; + struct led_classdev *cdev = &ddata->cdev; struct device *dev = ddata->dev; int ret; @@ -36,6 +36,17 @@ static void led_test_class_register(struct kunit *test) ret = devm_led_classdev_register(dev, cdev); KUNIT_ASSERT_EQ(test, ret, 0); +} + +static void led_test_class_register(struct kunit *test) +{ + struct led_test_ddata *ddata = test->priv; + struct led_classdev *cdev_clash, *cdev = &ddata->cdev; + struct device *dev = ddata->dev; + int ret; + + /* Register initial device - same as always */ + led_test_class_register_helper(test); KUNIT_EXPECT_EQ(test, cdev->max_brightness, LED_FULL); KUNIT_EXPECT_EQ(test, cdev->brightness, LED_TEST_POST_REG_BRIGHTNESS); @@ -63,12 +74,9 @@ static void led_test_class_add_lookup_and_get(struct kunit *test) struct led_classdev *cdev = &ddata->cdev, *cdev_get; struct device *dev = ddata->dev; struct led_lookup_data lookup; - int ret; /* First, register a LED class device */ - cdev->name = "led-test"; - ret = devm_led_classdev_register(dev, cdev); - KUNIT_ASSERT_EQ(test, ret, 0); + led_test_class_register_helper(test); /* Then make the LED available for lookup */ lookup.provider = cdev->name; From patchwork Thu May 15 08:28:01 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 890431 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3F6F288C80; Thu, 15 May 2025 08:29:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747297777; cv=none; b=Nf/1m5JC/RMZhKDWDUxPZGVWEzR+u7EetGUDybPKGPIgDwrrjYQla/Ku172ONI72uIG3XncsPqjfiw75/6b9hLv5eADnjJrhzEqibLyYAlaVES45enjwaKMAM+RKik2eYqbD9cb84KdP7vcuFyugg90NnlqLdMxmJ5V5lgeZCHw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747297777; c=relaxed/simple; bh=C/ny+BNIPWcqRm+PTf4xhqG3xTGLDJv0F0ZAltq3x3U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rixEJD59zKcZGjcfZDzhtrY3xmCqLsuVyq+NYRiIqDed/xlJemfDqrDA3a5ioTtRXwqp55z5LczrjSZW2KNA3E0/fRGC15VVYk1bpl7e58m3YJF4qOo6ILD+CxA8O3CfcZlPb5XXwdXZ5opjRaQrLnnZdMLoFJH5rDj63FbTV+Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=pEFj6xOu; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="pEFj6xOu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6325C4CEE7; Thu, 15 May 2025 08:29:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747297776; bh=C/ny+BNIPWcqRm+PTf4xhqG3xTGLDJv0F0ZAltq3x3U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pEFj6xOuvQSidx2R1B8jW1FsTZ4p00Lf/vRSCaofxlPnekiqUQrAnOkdkoiOVFAsJ 5QoP7UKd6RlFiLl/ycaiX06zhR43V44DFUlaLOb61Mtfk6W5cOA+KjguMAtWYebtNy 8spi2LOhnf09hzCelUPPiPta/dpC0PuGIhMdppxU3GYkNrz5oFlYIJzcc25u8S8Aua FmMbpwIPy/AwQiC9KFIFytWuExw9/06ZuF0WjPImdyhdF76uHba8zNVV3Z5qMl6WwC 5UBQMIz+59gR0qEwSIig0rsSMAt0ROEJKJggdWwIw03RRFlmsRSP/pNywoccIcnA4p MJWiMX50F1Z2Q== From: Lee Jones To: lee@kernel.org, Pavel Machek , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: bettyzhou@google.com, ynaffit@google.com, tkjos@google.com, jacek.anaszewski@gmail.com Subject: [PATCH v2 2/5] leds: led-test: Provide test for registration with missing default_label Date: Thu, 15 May 2025 09:28:01 +0100 Message-ID: <20250515082830.800798-3-lee@kernel.org> X-Mailer: git-send-email 2.49.0.1101.gccaa498523-goog In-Reply-To: <20250515082830.800798-1-lee@kernel.org> References: <20250515082830.800798-1-lee@kernel.org> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Insist on legacy (non-DT) registration and omit the default_label, which should fail with an invalid argument error. Signed-off-by: Lee Jones --- drivers/leds/led-test.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/leds/led-test.c b/drivers/leds/led-test.c index 0f152fb12dfb..760c393f5c5d 100644 --- a/drivers/leds/led-test.c +++ b/drivers/leds/led-test.c @@ -93,9 +93,25 @@ static void led_test_class_add_lookup_and_get(struct kunit *test) led_remove_lookup(&lookup); } +static void led_test_class_init_data_missing_default_label(struct kunit *test) +{ + struct led_test_ddata *ddata = test->priv; + struct led_classdev *cdev = &ddata->cdev; + struct device *dev = ddata->dev; + int ret; + + struct led_init_data init_data = { + .devicename = "led-test-devicename", + }; + + ret = devm_led_classdev_register_ext(dev, cdev, &init_data); + KUNIT_EXPECT_EQ(test, ret, -EINVAL); +} + static struct kunit_case led_test_cases[] = { KUNIT_CASE(led_test_class_register), KUNIT_CASE(led_test_class_add_lookup_and_get), + KUNIT_CASE(led_test_class_init_data_missing_default_label), { } }; From patchwork Thu May 15 08:28:02 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 890775 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45E8B298244; Thu, 15 May 2025 08:29:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747297779; cv=none; b=lgpvn5QjlQch+5dV898WUgC1ghLsb/uJnislI8P8kuNF1RNTHFlU8eJHpqGqSHzljdeDvphanEdvMRuPQstRS3zN70YgMLX3IH5ldLIVUOak0nljMZlQL1nsPANAZPPqXYWMYD7LzbkPcOhn2t0OLiOwDs1Gk3wtCkuGLksVAoQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747297779; c=relaxed/simple; bh=KkrCkIrNoINcDGVsoaeXs/3WVDpp0D897mQKNrzpRZA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ifHngiHJP1Pi0JSNSvSK2a5m2lYlkfdte4wxdZVvDqIBjctssLAQJkhJGutEfj8mgIWKZhrOB1eSiI5wVasWtdAjnmXyCF0JLWMBK5erJijOUvnGrKxInTshFlxe3YRH98HCCMd2mJGuAgRBKo8/E5gYoxhiprqyorq62UZMxxk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ETvrG/hz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ETvrG/hz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2058DC4CEEF; Thu, 15 May 2025 08:29:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747297778; bh=KkrCkIrNoINcDGVsoaeXs/3WVDpp0D897mQKNrzpRZA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ETvrG/hz9wfXOG7XhzO/I5ViijNzRSFbFfj6k7H+ypXSQdLJADGod9d3SPn1RXFG4 94fqO+dRDfEU98rCaybUi4tRO9D9iYDmcFbIoJNXOYsmftNgeLXvKGZJMnrAQxxe0q iLXXW10XJ19wWsNDF02kHJS1t55mp0JxmkIRYhTMAqmMJLJA2iadFnoI+wah55YK8K ydffAV4/AQ3MTtw9Yy9LhxU7ZI5wWKPJXn2y8AQ7/x17atg/UWyfbMvKuliE7dRVX7 SkQ+viAPnw/D4MEykj/uHmx2YXPvfdfHinJEZIm7iHIHOV37hlXXSFFw7p+nMk8N6t C7lfO5diKuaiw== From: Lee Jones To: lee@kernel.org, Pavel Machek , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: bettyzhou@google.com, ynaffit@google.com, tkjos@google.com, jacek.anaszewski@gmail.com Subject: [PATCH v2 3/5] leds: led-test: Provide test for registration with missing devicename Date: Thu, 15 May 2025 09:28:02 +0100 Message-ID: <20250515082830.800798-4-lee@kernel.org> X-Mailer: git-send-email 2.49.0.1101.gccaa498523-goog In-Reply-To: <20250515082830.800798-1-lee@kernel.org> References: <20250515082830.800798-1-lee@kernel.org> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Insist on legacy (non-DT) registration and omit the devicename, which should fail with an invalid argument error. Signed-off-by: Lee Jones --- drivers/leds/led-test.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/leds/led-test.c b/drivers/leds/led-test.c index 760c393f5c5d..d378c905546b 100644 --- a/drivers/leds/led-test.c +++ b/drivers/leds/led-test.c @@ -108,10 +108,26 @@ static void led_test_class_init_data_missing_default_label(struct kunit *test) KUNIT_EXPECT_EQ(test, ret, -EINVAL); } +static void led_test_class_init_data_missing_devicename(struct kunit *test) +{ + struct led_test_ddata *ddata = test->priv; + struct led_classdev *cdev = &ddata->cdev; + struct device *dev = ddata->dev; + int ret; + + struct led_init_data init_data = { + .default_label = "led-test-label", + }; + + ret = devm_led_classdev_register_ext(dev, cdev, &init_data); + KUNIT_EXPECT_EQ(test, ret, -EINVAL); +} + static struct kunit_case led_test_cases[] = { KUNIT_CASE(led_test_class_register), KUNIT_CASE(led_test_class_add_lookup_and_get), KUNIT_CASE(led_test_class_init_data_missing_default_label), + KUNIT_CASE(led_test_class_init_data_missing_devicename), { } }; From patchwork Thu May 15 08:28:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 890430 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7879298244; Thu, 15 May 2025 08:29:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747297782; cv=none; b=DKzGP+NYFwMvSGs4yyWFMoXeEuintbDon80gmRBJ2ibxAwQXbEbBXed83vy8nP2CFfmHtigImJpruqHupog4UUVXw9x5aRYF5+8cSrDobW+Rj+VyBa2B+a98tbY3lKMiADUp46gfzmL+tVFLAq6tJhGNxpbQ7IJxBIQeJY6yL8c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747297782; c=relaxed/simple; bh=NMawEyh1cP+zm+j6rRd9ARnVfG/D+EF3+jJuPMcV8Ys=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=opBPHFyLMu3yBH3CchVuxCM98F7DaWul+dnuLSbjNm5jW0I5jo9WKgXaV44S6iaRNT7ngozkzPWVbLkwOCMK5XTj2up69AwhDN4NPzibjPq7KYFUVwRnDFXt8GafdWX7GcIt7s0hwg07HPoGqRzxUNfFQTUIBwIgltlbi9de2kI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ClgWpF3/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ClgWpF3/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7911CC4CEED; Thu, 15 May 2025 08:29:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747297781; bh=NMawEyh1cP+zm+j6rRd9ARnVfG/D+EF3+jJuPMcV8Ys=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ClgWpF3/KuzD6qd8TlTMSK6v6NlJCAsB660VbCnfMUhOx3RzbTN6KBLzM6IqorRN0 sCPLUcT+D+ShdIwQMo+VZ8/jEzeSBbGxKswGEGqFH3xIzEipQ23ioQ2WRXFeyK10Do WPyqbpDZ4OBF8owYbmHjuf/UmDj0nCXvTVHvZZ0uziUAXBvGyFIQmfNq5y8Dz3kf0A EC6J893W1yPV4jE5oGh19cbYauk4FmzIJ/RxSCD1MxmlJduN+MIGFe6MTV6JfRD5dN wmOFgRaWljetXwXUfZPmoR/BaUcDVwOINwEGruaiCk+IFilMFsbhpr9Udvd+6c1cUX 0j8C1WB9wH1/g== From: Lee Jones To: lee@kernel.org, Pavel Machek , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: bettyzhou@google.com, ynaffit@google.com, tkjos@google.com, jacek.anaszewski@gmail.com Subject: [PATCH v2 4/5] leds: led-test: Provide test for registration with a name that is too long Date: Thu, 15 May 2025 09:28:03 +0100 Message-ID: <20250515082830.800798-5-lee@kernel.org> X-Mailer: git-send-email 2.49.0.1101.gccaa498523-goog In-Reply-To: <20250515082830.800798-1-lee@kernel.org> References: <20250515082830.800798-1-lee@kernel.org> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Insist on legacy (non-DT) registration and provide a default_label and devicename that when concatenated together results in a device name that is unacceptably long. Signed-off-by: Lee Jones --- drivers/leds/led-test.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/leds/led-test.c b/drivers/leds/led-test.c index d378c905546b..d5017c6dca08 100644 --- a/drivers/leds/led-test.c +++ b/drivers/leds/led-test.c @@ -123,11 +123,28 @@ static void led_test_class_init_data_missing_devicename(struct kunit *test) KUNIT_EXPECT_EQ(test, ret, -EINVAL); } +static void led_test_class_init_data_name_too_long(struct kunit *test) +{ + struct led_test_ddata *ddata = test->priv; + struct led_classdev *cdev = &ddata->cdev; + struct device *dev = ddata->dev; + int ret; + + struct led_init_data init_data = { + .devicename = "led-test-devicename-very-long-names-fail", + .default_label = "led-test-label-also-very-long-names-fail", + }; + + ret = devm_led_classdev_register_ext(dev, cdev, &init_data); + KUNIT_EXPECT_EQ(test, ret, -E2BIG); +} + static struct kunit_case led_test_cases[] = { KUNIT_CASE(led_test_class_register), KUNIT_CASE(led_test_class_add_lookup_and_get), KUNIT_CASE(led_test_class_init_data_missing_default_label), KUNIT_CASE(led_test_class_init_data_missing_devicename), + KUNIT_CASE(led_test_class_init_data_name_too_long), { } }; From patchwork Thu May 15 08:28:04 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 890774 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1D35298267; Thu, 15 May 2025 08:29:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747297783; cv=none; b=kzY/eiid/+suCO6lIOa43S3ffKaLv5XWIYb2nTnVg/dtoCdNL3SAhlP0rvftH8fX1snMp+dgHMI53BIbIqG5iF23Aze95LxRLEK8m/ImkqLn/SZlxZgZbpFMWtU2asp7ZoeqHABgpbkMpqlqSj5S3vLsDYQpAf/Yk1ItR3Xz/rk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747297783; c=relaxed/simple; bh=XlzEAb7PToBb2K9/BeILyEoOT9WYVsQ9y421Y6PB1pU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TavySHD3BMxhPasoEG0ZjhZYAIHbZxLg7st4T78IILp2e6Z8Yodpn4/0ycgbiqosTVav9g49ctqMIUhy49ki07bcdXiYaDxRyPmcVP1Qn06msVjqyFJUWYnWNrzaJVNV+zsqDziilddzpUJu5A6YucOahDsXC8f1wMU3YUHBtPo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QAJwup9F; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QAJwup9F" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D3F42C4CEEF; Thu, 15 May 2025 08:29:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747297783; bh=XlzEAb7PToBb2K9/BeILyEoOT9WYVsQ9y421Y6PB1pU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QAJwup9FonxkyT6thjXQcqmSNx1DmdB/bNS9y3dZScSSvTg44UikDnAv9nbm0Lhbn YSIrAspfi0hRW4eYUbimoTfbd5q1fgenpCbrDRx10fGj0f9OnaPtjl+n6SWQf9500o xQZe3y9nM0zg6KovWTOc1F/JXM7TgFJl6M4x9iiIwqVw77I/+Tj2tgcuq0WaWmjLlI oC1mZ5EQ3jO20KXb7MYIDrwXV59/cJoRmeAHcl2DC1kIiKCN5wBzRKTRkH1Q1rI+ND YMPo5MPxaNlmG8Qkeyer6hMvLDJNaR+dZWo9T/38Cc0nidJtTF0LwJilC9ghVtj91+ qZ0JT9/9EpOOA== From: Lee Jones To: lee@kernel.org, Pavel Machek , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: bettyzhou@google.com, ynaffit@google.com, tkjos@google.com, jacek.anaszewski@gmail.com Subject: [PATCH v2 5/5] leds: led-test: Provide test for successful registration using init_data Date: Thu, 15 May 2025 09:28:04 +0100 Message-ID: <20250515082830.800798-6-lee@kernel.org> X-Mailer: git-send-email 2.49.0.1101.gccaa498523-goog In-Reply-To: <20250515082830.800798-1-lee@kernel.org> References: <20250515082830.800798-1-lee@kernel.org> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This time both the default_label and devicename are provided such that when concatenated together result in a device name that is acceptable. In this case registration should succeed. Signed-off-by: Lee Jones --- drivers/leds/led-test.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/leds/led-test.c b/drivers/leds/led-test.c index d5017c6dca08..9bdebbe04462 100644 --- a/drivers/leds/led-test.c +++ b/drivers/leds/led-test.c @@ -139,12 +139,29 @@ static void led_test_class_init_data_name_too_long(struct kunit *test) KUNIT_EXPECT_EQ(test, ret, -E2BIG); } +static void led_test_class_init_data(struct kunit *test) +{ + struct led_test_ddata *ddata = test->priv; + struct led_classdev *cdev = &ddata->cdev; + struct device *dev = ddata->dev; + int ret; + + struct led_init_data init_data = { + .devicename = "led-test-devicename", + .default_label = "led-test-label", + }; + + ret = devm_led_classdev_register_ext(dev, cdev, &init_data); + KUNIT_EXPECT_EQ(test, ret, 0); +} + static struct kunit_case led_test_cases[] = { KUNIT_CASE(led_test_class_register), KUNIT_CASE(led_test_class_add_lookup_and_get), KUNIT_CASE(led_test_class_init_data_missing_default_label), KUNIT_CASE(led_test_class_init_data_missing_devicename), KUNIT_CASE(led_test_class_init_data_name_too_long), + KUNIT_CASE(led_test_class_init_data), { } };