From patchwork Mon May 19 02:35:10 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mina Almasry X-Patchwork-Id: 891192 Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9B6E1DEFD9 for ; Mon, 19 May 2025 02:35:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747622125; cv=none; b=pduO10Bh5cf/4zPI7Wp4HRKBSxdmiwwR3UHcAMA2zmBqzm51w2notnTztySMOBBaoDx0+hmZcvOd+KeBj1vkSiRJZZQeqxEgH8y/55PGz62IbwraGfWoHloPdrTrSp/aF7kb+X3BspbNlmu1o+6jm9HrHuRQt3ibmGMAS2ARNaA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747622125; c=relaxed/simple; bh=fjMbYp1OUTPpUA+isQhdpqYICCd17AJcekK61Bn+4TY=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=f45qohf9juP04V/eJeeIcu1iGUavW5ilnFCd2RF8oozlyH4Jrwj54dxkUUPZzq4WDvShr4wo9ILc9cnRiDUXvO6bB4ZLJbx41KcMXgHIuZI87K3dslB9K4mOj16WcuHMuXdlacVfiTKbQSZlfK4CJfeIrCSB5IiAZWuQ/Oc0obo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--almasrymina.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=hsuqJtWr; arc=none smtp.client-ip=209.85.210.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--almasrymina.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="hsuqJtWr" Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-742c5f7a70bso1042048b3a.2 for ; Sun, 18 May 2025 19:35:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1747622123; x=1748226923; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=SiIOWkaYu6Q5NvtHbuVewPLdOWvzkt5VSs00BXd1iZA=; b=hsuqJtWrT+r7rFyfp6q4p2B076jErBiTumcXh3MiCUuWfOuYO8x5iTG87RScJ8I69t wfqPlxOB2cDPd6Bkd1qmlXaC2VPzbw40DTGdVId9SUGGbiSkdyaG9XE7MdMUzfZB9hRY CCQyORXj1nX57kyW7dto4nEjLu8Tu3vUyixU+CH28gbqM/RPwk8MrdZKvDrrjUkwgVnG rO44nAzRTLK3zVohbdArjYyTJ7NNxL0zP+EX/BlgcF/CskcEXaFVXO0iy0dcCNjmdGdi yjIz3DGjHZXN8owG+n4y7Z+wFs35znaUnnNIV9v4UPnHsiaWd7I1jX+OiVMkYTsrs42c aGkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747622123; x=1748226923; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SiIOWkaYu6Q5NvtHbuVewPLdOWvzkt5VSs00BXd1iZA=; b=BCYj1vjvHn2lM8vkZof5XzToH7QwHLx8uERa7dAouVFMzsAS1265ZSNwE3GBdvstlQ tqq5zVqt29dfP7wzskhsUySSWo/Lugwr0RNfIwbOUA/+WEhNgS+l+WMMYsaSV6RtBlk0 vexwuO2Ng9sI3KGwvrbIC2g5bFqHgbpWgTXeVpRCeYKBf38PYKY639VmmVrLxYlaW8bD JLrShyIlYlYq2j4VR6XbLZhF1e3w+NfDifPamvo6e8t1vZPyj3fJUxkdDoZBiikkBYWi OAGiLPxDWEUIL8z+5MNP8ZrBzZ+g6jqI/3Yk9LG3kUg3XYGeT0lb5pgrq0pDHv1GFqfP cqQg== X-Forwarded-Encrypted: i=1; AJvYcCXooSTdlydB2O06mpJWslBckLsUlZhBvIZZQXloDxm5kqs2rMoY5GXraopqY789ZzMEVRmShm3NiapEbVcUlNA=@vger.kernel.org X-Gm-Message-State: AOJu0YyuPboKhEeAeNAsix9GerjUVOu0KNrk4XsS8HQm9AysC+f9VYi6 +sI60D2BM74ECLuYi5fjNzY75MZ8Ziq3GDfuJcLSlsdxR9a1RostV3JR4g/3Hnz0/pEhzOvk9bB yB66sWTauwYy0xSGNlBqrTCTI2A== X-Google-Smtp-Source: AGHT+IHBrwI4b9TNUkLaMgynwA2HQL/MTtdwhOuI/X1LYMxFchY6tJBRsHHTzW22QGPcgrBPKF64HUiyRaUkCYyEgQ== X-Received: from pgmp18.prod.google.com ([2002:a63:1e52:0:b0:b0b:301e:8e96]) (user=almasrymina job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:3385:b0:1fa:9819:b064 with SMTP id adf61e73a8af0-2170cb407f7mr14894249637.18.1747622122885; Sun, 18 May 2025 19:35:22 -0700 (PDT) Date: Mon, 19 May 2025 02:35:10 +0000 In-Reply-To: <20250519023517.4062941-1-almasrymina@google.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250519023517.4062941-1-almasrymina@google.com> X-Mailer: git-send-email 2.49.0.1101.gccaa498523-goog Message-ID: <20250519023517.4062941-3-almasrymina@google.com> Subject: [PATCH net-next v1 2/9] page_pool: fix ugly page_pool formatting From: Mina Almasry To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: Mina Almasry , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jesper Dangaard Brouer , Ilias Apalodimas , Neal Cardwell , Kuniyuki Iwashima , David Ahern , Andrew Lunn , Shuah Khan , sdf@fomichev.me, ap420073@gmail.com, praan@google.com, shivajikant@google.com Minor cleanup; this line is badly formatted. Signed-off-by: Mina Almasry --- net/core/page_pool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/core/page_pool.c b/net/core/page_pool.c index 974f3eef2efa..4011eb305cee 100644 --- a/net/core/page_pool.c +++ b/net/core/page_pool.c @@ -867,8 +867,8 @@ void page_pool_put_unrefed_netmem(struct page_pool *pool, netmem_ref netmem, if (!allow_direct) allow_direct = page_pool_napi_local(pool); - netmem = - __page_pool_put_page(pool, netmem, dma_sync_size, allow_direct); + netmem = __page_pool_put_page(pool, netmem, dma_sync_size, + allow_direct); if (netmem && !page_pool_recycle_in_ring(pool, netmem)) { /* Cache full, fallback to free pages */ recycle_stat_inc(pool, ring_full); From patchwork Mon May 19 02:35:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mina Almasry X-Patchwork-Id: 891191 Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDFF61E9B04 for ; Mon, 19 May 2025 02:35:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747622129; cv=none; b=DnSAjOkzPyItZIDWoRPpo5L8EDh3WV5CYj1mz2+79bZSWSC3jzqZKZ0bjqwA8SzuJzsZS1fxoFaxstrIR2Pvlj7wMDq7Wal/IklRKxsLMrq0ZU4S3g6glxt6Ru9ez4SlOd5uA59eKvYZRHkP8E09WzSO2gxScOYrMSCl/1CCyfQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747622129; c=relaxed/simple; bh=mv1hnc/JYcrsYiWob27N35tjryacdBHMn0uTMgSU2F0=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=a0ie6U+wLUm+KTIXKiebZAcKV3jGIesXHOL7yyANsarnh/hts+EUc3bpl6VXcmAj/tbBJgvxGYeIdXhqgey/5QP7hUElvE3FpzUAwqCEi3vz2QPI0ZZ0Sy1SK2SvSSYQYIViLZZL15pFp9BlP5UQSnsRF1du5iJ96OJQD6MCKF0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--almasrymina.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=01LmC/qz; arc=none smtp.client-ip=209.85.210.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--almasrymina.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="01LmC/qz" Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-742cf6f6a10so655483b3a.1 for ; Sun, 18 May 2025 19:35:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1747622127; x=1748226927; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=dgbVYH77FpbHQz0jo3ZInucxDqpVyDPyOGojAswcD18=; b=01LmC/qzQmgA0OPRbG75nu8kKZGDpPtmUhKpXWEFmgwKD3fXToyX2vAor/wc4pHEdz ux/u6NPwi4sXacRQL1a4Fc8Qxi9xMu4S1gcTBXvV60h4mo5BVpg1jchWNaByWaRo37OV 6rdWwPKPdDp13xgYq7dOQrsc5sDizzNG1Uo7rEmVQwIIZQtufHwKaHFW8Gbs5KcYBSB1 5695azyZoOfPl+qaensLQMqjm/gprTWik7XwQn89A6MSrQvUtgIDVAN25urC9qZ+h5z9 jeNqCOxv6TgkGytsJi5SFuPSEQq4jKckAJA7IWDie8tH17EuCluG7Tk48Xfqk+m0ikGG //dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747622127; x=1748226927; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dgbVYH77FpbHQz0jo3ZInucxDqpVyDPyOGojAswcD18=; b=ot2phzyzJNeRQ6VhtG+ZwHU1dFyMv7kFh0/wOZYBqxlO6E44joezRCqtrpoFqXp0f/ d+5W5tDdjw7ayPNU3Fu1vAshQhwO+nvbwSeYRlv+/9adAkc2d29DmYCw4wJykwJcJlM6 RS9hzhe26yVnHAPa2S8i51M+ntnBskq/wA+C9RSgdLm8Lpv/NxVwcSx9uFHBJBmr5F9G dzhJxHI5fZHGrI/aPNS3SpZ0fXPmN4APgg/hC+/+lNGZzVXAER6ZZJxkWR1tRQOoO1Vr j0nYMeyNJA+WML8FTUvbwAGH0pLZlr80mJOPNGLZiKWjAQFFJ9aoKUhv+4M3vPdt/i8B S+lg== X-Forwarded-Encrypted: i=1; AJvYcCVtf87FWWR34zLBbv5n3aw7NOL85wGIREAQ10MymH0aQc9uyV1IuFdF9vFM4H8ckq0+PUrUUc7gPoQWavDBXy4=@vger.kernel.org X-Gm-Message-State: AOJu0YwAYUyBUTMP1/NTqYbH5a4jJkAbP76TOWodXopuCMoaq8YaaYYJ lbZxWz/O9GvPZd/XeW64J4Km7iCBKXppozZcb5Pc/0JEa7j/PLWJh4BVVUwn2uMdVc+/Yq8W4hZ 5JqoIOSFTJK1IjO+U4lQIpvcseA== X-Google-Smtp-Source: AGHT+IGYP7gHTQY4VrMBV4Jvp7SIjOwTc4ULH4X27OGkctqn0OJKaDn02AnHC71nkqQCZpE94dyzsqSq6kKMXBhrJg== X-Received: from pfes20.prod.google.com ([2002:aa7:8d54:0:b0:742:a60b:3336]) (user=almasrymina job=prod-delivery.src-stubby-dispatcher) by 2002:aa7:9ddd:0:b0:742:b3a6:db16 with SMTP id d2e1a72fcca58-742b3a6dbc0mr10282223b3a.20.1747622127291; Sun, 18 May 2025 19:35:27 -0700 (PDT) Date: Mon, 19 May 2025 02:35:12 +0000 In-Reply-To: <20250519023517.4062941-1-almasrymina@google.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250519023517.4062941-1-almasrymina@google.com> X-Mailer: git-send-email 2.49.0.1101.gccaa498523-goog Message-ID: <20250519023517.4062941-5-almasrymina@google.com> Subject: [PATCH net-next v1 4/9] net: devmem: ksft: remove ksft_disruptive From: Mina Almasry To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: Mina Almasry , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jesper Dangaard Brouer , Ilias Apalodimas , Neal Cardwell , Kuniyuki Iwashima , David Ahern , Andrew Lunn , Shuah Khan , sdf@fomichev.me, ap420073@gmail.com, praan@google.com, shivajikant@google.com As far as I can tell the ksft_disruptive here is unnecessary. These tests are largerly independent, and when one test fails, it's nice to know the results from all the other test cases. Signed-off-by: Mina Almasry --- tools/testing/selftests/drivers/net/hw/devmem.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/tools/testing/selftests/drivers/net/hw/devmem.py b/tools/testing/selftests/drivers/net/hw/devmem.py index 7fc686cf47a2..f5d7809400ea 100755 --- a/tools/testing/selftests/drivers/net/hw/devmem.py +++ b/tools/testing/selftests/drivers/net/hw/devmem.py @@ -6,7 +6,6 @@ from lib.py import ksft_run, ksft_exit from lib.py import ksft_eq, KsftSkipEx from lib.py import NetDrvEpEnv from lib.py import bkg, cmd, rand_port, wait_port_listen -from lib.py import ksft_disruptive def require_devmem(cfg): @@ -19,7 +18,6 @@ def require_devmem(cfg): raise KsftSkipEx("Test requires devmem support") -@ksft_disruptive def check_rx(cfg) -> None: cfg.require_ipver("6") require_devmem(cfg) @@ -34,7 +32,6 @@ def check_rx(cfg) -> None: ksft_eq(socat.stdout.strip(), "hello\nworld") -@ksft_disruptive def check_tx(cfg) -> None: cfg.require_ipver("6") require_devmem(cfg) From patchwork Mon May 19 02:35:14 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mina Almasry X-Patchwork-Id: 891190 Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E1221F099C for ; Mon, 19 May 2025 02:35:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747622132; cv=none; b=JWyds+zMTD2ijoBAGVtdBDBo3dP1P2j/WXVLI33Iw2on12mxBqbPIOOALLIdPFqp7BOWxBJDUXcPvkB3dXrXUOEjOSAhYrhmQJS1P6CyP9aPsoZEzj0ulI+b1aePwNNI8CNMqfRjSdABhv990oqCXa/tEs7K2Iof4CDglznd1+U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747622132; c=relaxed/simple; bh=+fLzCD1RoUrUeV193X0CN0MPAFz9uajW9owZKfgSTYA=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=X4JLSeLKcdVYZHHAV38I6SYJTnZCpmeY+bB8bZlYxTw74/9htYrlg5tW/1dvK0qMkS20qOF5lFINK8zmeTC36LSXWqzz+A6WQ4AAVo47yy6YA8Zjyc8aGpKwTiQzBquRTvEmCBxFe2fm0nxFyeWWtayBExM4hs66zIb2bImQuxA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--almasrymina.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=c0YgX5rK; arc=none smtp.client-ip=209.85.210.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--almasrymina.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="c0YgX5rK" Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-7401179b06fso3013038b3a.1 for ; Sun, 18 May 2025 19:35:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1747622130; x=1748226930; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Dsib5kCQHhRTpjaf9L/1KcIsuAgRVw/2/Ukd6+B+UoU=; b=c0YgX5rKmwq33rnuPYK6ZxMBYswLZHFh4/l3+XZMwZNAkr7n9MrnTFjr19kx2kaW7Z Ji+ka646sC8VLF6Nzic96WWm1BeIQzTIu2dy0CPOcP++sG5LnUaqsYrMqltkBC8m/8Ex u/cu3uUcgZ9B6ADwUMUOF7ksGmgGFir7bhQynTCJ+yLZ4b5a+p7lbQcR+3Ra0WT3mqB8 h4IcH8a8rI4aIOhcxs8Sc92je8MFgbuhCFFB33Xl7OqCGTxuvwwYoygWXWIvklJJ1ADY rY/BNdjCmCmvLVo4AKAXyOqoVYhmbwTYHDE6/2L+AlmmXzGhlsoMDhvaOwC1lzjYxFaH I19g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747622130; x=1748226930; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Dsib5kCQHhRTpjaf9L/1KcIsuAgRVw/2/Ukd6+B+UoU=; b=oVqrKJV3mK/WuMksR/V9iNfYpT64Y8OFpFNQzPJE3VLWl6K05O3beUAO5ggSMAPjqQ IOPKSAR1UzKUJxJCZFuChr5YYGQMsWor1w+4IFqDBY3Q4vqFAd925uBYDDmab/GmdyqQ U0gAhcZ/Sa9ETesPlAuCwch0YonFOmxT80x7NQBi/4IqyIwfH6sdFb9kABJ1jyk8dWUb LwVI9X9jiPPCGZSPqBHWLqzlYLWpHAhkKVv1xFQ3dQTrSTWEWvH7X5lcGAuQ1iNHCKRO oSKVCDN1iFknzh/g0SgN477xuJ9mNDkc+F6KRm0HStMRIZMNg6YXYTY4eP9vKGu4GJhu pBDw== X-Forwarded-Encrypted: i=1; AJvYcCVNXgRD8FlL67nGQi+YflQmaroyjh8M0FEdXfZ2jvHPf/9Ua09+i0OyBzXOlGOfXv8PYDNhEVdiFRSFhn5tdYQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzQV7vVlAz7zlSsVacITAM53ojoEzZw5sio+siNIAwkUKFyqN8U TI5pZy94r14x3VSvHAZMQTu0NNIUCPMmyChJF3sULZC2uSruQffTT9wGME++QQBBKJ73Y06wDDt d/XbRKHulUNAfFlSXR5uIidg2hg== X-Google-Smtp-Source: AGHT+IHYtSlpqkjG9aEm65HFlOMqCYP8ZVIHIn0ysadn3DoH/Dao7wFtqE4cnWV8BuGlnEjplUE25OvnhoAFtu3l/Q== X-Received: from pfbei22.prod.google.com ([2002:a05:6a00:80d6:b0:736:415f:3d45]) (user=almasrymina job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:91e0:b0:740:b394:3ebd with SMTP id d2e1a72fcca58-742a97ad507mr16514775b3a.7.1747622130537; Sun, 18 May 2025 19:35:30 -0700 (PDT) Date: Mon, 19 May 2025 02:35:14 +0000 In-Reply-To: <20250519023517.4062941-1-almasrymina@google.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250519023517.4062941-1-almasrymina@google.com> X-Mailer: git-send-email 2.49.0.1101.gccaa498523-goog Message-ID: <20250519023517.4062941-7-almasrymina@google.com> Subject: [PATCH net-next v1 6/9] net: devmem: ksft: add exit_wait to make rx test pass From: Mina Almasry To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: Mina Almasry , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jesper Dangaard Brouer , Ilias Apalodimas , Neal Cardwell , Kuniyuki Iwashima , David Ahern , Andrew Lunn , Shuah Khan , sdf@fomichev.me, ap420073@gmail.com, praan@google.com, shivajikant@google.com This exit_wait seems necessary to make the rx side test pass for me. I think this is just missed from the original test add patch. Add it now. Signed-off-by: Mina Almasry --- tools/testing/selftests/drivers/net/hw/devmem.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/drivers/net/hw/devmem.py b/tools/testing/selftests/drivers/net/hw/devmem.py index 850381e14d9e..39b5241463aa 100755 --- a/tools/testing/selftests/drivers/net/hw/devmem.py +++ b/tools/testing/selftests/drivers/net/hw/devmem.py @@ -30,7 +30,7 @@ def check_rx(cfg, ipver) -> None: port = rand_port() listen_cmd = f"{cfg.bin_local} -l -f {cfg.ifname} -s {cfg.addr_v['6']} -p {port}" - with bkg(listen_cmd) as ncdevmem: + with bkg(listen_cmd, exit_wait=True) as ncdevmem: wait_port_listen(port) cmd(f"echo -e \"hello\\nworld\"| {socat}", host=cfg.remote, shell=True) From patchwork Mon May 19 02:35:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mina Almasry X-Patchwork-Id: 891189 Received: from mail-pg1-f202.google.com (mail-pg1-f202.google.com [209.85.215.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9038209F38 for ; Mon, 19 May 2025 02:35:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747622136; cv=none; b=D26Dc8sIJY2hgkpr8/y32CQHQaPoQcVxnftne5pEPSRAnf2S7Kjl06LgmiLoDeIi+Y7gGYeIyMC8ZFNQBKfsMWtULqcSUOoJnAYyWIyiZRvwv6ExJKMLdgw+7cIVKQrj49z7sRJfjpjKuIZVE4Gt6UgVZNizEy+uELfA26VuGlA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747622136; c=relaxed/simple; bh=DyWWH7L0CCILd4odcqjjQy5VKvNZph+DcgjHacONU08=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=LYCjB02H8cPyKipnwXK3mPqe0fa+XGS/TP8N1Rmth0RPKVeaffr4e/eZpzAX6lIPbz3ImV67gwlMPY7ClS6x8X8yNDPP9wl8lKRgzFyXfTAdcoi8XWb1j/EvVpBG1vYO5bgP/ipCiOrlxFFflFE/fYQ0F3ohrR5a2nFi0ed7MWg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--almasrymina.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=w1tnfZ6W; arc=none smtp.client-ip=209.85.215.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--almasrymina.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="w1tnfZ6W" Received: by mail-pg1-f202.google.com with SMTP id 41be03b00d2f7-b26e278dd1aso2146775a12.1 for ; Sun, 18 May 2025 19:35:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1747622134; x=1748226934; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=GOoqGQ98UOim4ci2kcnS9BvhTjdsuvqj0JQE1ld7C3U=; b=w1tnfZ6WgTx53clXqSvj7QMR0DLvEhPE2G7VuwAtpgmFjbGkLDugrlqKsjUAILCZAl 8i41tZZ6HvgB0+mrmae0F4wrwhtlCVhHtkrARP8fh9BWELm+vzeul+7mGrW5qbLEIAoN FR6tTTCPoPbMwERimgwEIDj8Rs9Fe1BVSANb15fk3MzNsMjZNQwnkcBesxuKKjB2AFF2 XS+TUb5oMGZyfBCo0XPUrdzZI+GNI4SJEnArVv3coI5MR658VGmPM1BE26R2ELSbd8sg lcnhTU9rav0yW7ShVNIieQ2f3l4Ssz2qHdTkTGGm3caK5bVR/3Du+FUmS/7JTBW/audF wgIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747622134; x=1748226934; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GOoqGQ98UOim4ci2kcnS9BvhTjdsuvqj0JQE1ld7C3U=; b=qHfauXKLiHsSZLbHF3YSjLu5Xc+cI/I/MrQNCq2Rm1my4C3/Zn2kL2Avc+vkm/C0FK AVniY+qYFhDKfLMJjzCFkwSTO2KEwYcQtFkMI2ojoxKI6Zy16GgkjQ0XiW/lRgES3zPA p4lOpmQu8xtaYDRXw65yW5EtzYVt8pH7HJ+YLCSFU9Q4Hm/u4cUL+ZCcEFABjm1T+IhO dPdMBPwmMjvnfzXz5swEWgk3zg9x66/Ao8EGLbo0jsjHBmZTw8y8zwTDXJY4g3YUcXvI xRMEwd2LXH1y5YmXLa0y0gn4MPkpHCmD1r0Oul7W5kywGUZ73CRrcRxtLh0DJGQK3PkO Z9TA== X-Forwarded-Encrypted: i=1; AJvYcCUWDCYy3LzqA55bIXz7CdmxPn4Dp5aiqZf4ewT0Tf5MyDZrba5yKYeRFoTLUv3FO9/k3NzqmKIFyOcPesJJQrw=@vger.kernel.org X-Gm-Message-State: AOJu0YxLB25zlw2pRtk5Bd2N+Jv9/OhTvFeZ3M/jnkjdW5IhqWlp4dyS 9Wd/iFYMHFyVyUUSeF6qWoIKQT/fis2j3Y8Q20gPuwgyCKZoNJAmX2ytt5WXOMkAJayRVlog+Q3 ZzfpxVF9CaXdmCYxhBw3dRGw0QA== X-Google-Smtp-Source: AGHT+IE6aX84b0eaIo0V77IgI3eQ+VzhrvTcrSqQdZ5DqYv5fJgf6icKRjS5aZdtIH3xwKERF3FKSLCy29p3I18ZnA== X-Received: from pga23.prod.google.com ([2002:a05:6a02:4f97:b0:af2:4edb:7793]) (user=almasrymina job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:439e:b0:1fd:ecfa:b6d7 with SMTP id adf61e73a8af0-216219b13c4mr18758690637.28.1747622134057; Sun, 18 May 2025 19:35:34 -0700 (PDT) Date: Mon, 19 May 2025 02:35:16 +0000 In-Reply-To: <20250519023517.4062941-1-almasrymina@google.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250519023517.4062941-1-almasrymina@google.com> X-Mailer: git-send-email 2.49.0.1101.gccaa498523-goog Message-ID: <20250519023517.4062941-9-almasrymina@google.com> Subject: [PATCH net-next v1 8/9] net: devmem: ksft: upgrade rx test to send 1K data From: Mina Almasry To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: Mina Almasry , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jesper Dangaard Brouer , Ilias Apalodimas , Neal Cardwell , Kuniyuki Iwashima , David Ahern , Andrew Lunn , Shuah Khan , sdf@fomichev.me, ap420073@gmail.com, praan@google.com, shivajikant@google.com The current test just sends "hello\nworld" and verifies that is the string received on the RX side. That is fine, but improve the test a bit by sending 1K data. The test should be improved further to send more data, but for now this should be a welcome improvement. The test will send a repeating pattern of 0x01, 0x02, ... 0x06. The ncdevmem `-v 7` flag will verify this pattern. ncdevmem will provide useful debugging info when the test fails, such as the frags received and verified fine, and which frag exactly failed, what was the expected byte pattern, and what is the actual byte pattern received. All this debug information will be useful when the test fails. Signed-off-by: Mina Almasry --- tools/testing/selftests/drivers/net/hw/devmem.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/drivers/net/hw/devmem.py b/tools/testing/selftests/drivers/net/hw/devmem.py index 40fe5b525d51..10ffd8a8f72b 100755 --- a/tools/testing/selftests/drivers/net/hw/devmem.py +++ b/tools/testing/selftests/drivers/net/hw/devmem.py @@ -38,16 +38,17 @@ def check_rx(cfg, ipver) -> None: if fs_5_tuple: socat += f",bind={remote_addr}:{port}" - listen_cmd = f"{cfg.bin_local} -l -f {cfg.ifname} -s {addr} -p {port}" + listen_cmd = f"{cfg.bin_local} -l -f {cfg.ifname} -s {addr} -p {port} -v 7" if fs_5_tuple: listen_cmd += f" -c {remote_addr}" with bkg(listen_cmd, exit_wait=True) as ncdevmem: wait_port_listen(port) - cmd(f"echo -e \"hello\\nworld\"| {socat}", host=cfg.remote, shell=True) + cmd(f"yes $(echo -e \x01\x02\x03\x04\x05\x06) | \ + head -c 1K | {socat}", host=cfg.remote, shell=True) - ksft_eq(ncdevmem.stdout.strip(), "hello\nworld") + ksft_eq(ncdevmem.ret, 0) def check_tx(cfg, ipver) -> None: