From patchwork Thu May 22 08:06:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 892150 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9541524C668; Thu, 22 May 2025 08:07:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747901236; cv=none; b=ZU2M/eG6L+S2BoiKKP+BytvsClzxIMI0rT/MXLT5BBmG6xFabjp4F3qwUXFOclNqvwHKWwnpUSA9VeA4qD5oDnJosJARafaQ6gR6gymHydYRClUzQ3aH7vQpPTl+Rb/W4wve3hkRStnHjgbHX1v9A5oeDyEpcN6dlbnrunuJaHA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747901236; c=relaxed/simple; bh=gfFWoXtvfq0dOKxLkZYmplPetaqqvPy/+dRBhhnGRHM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=nvaRJ+orMuhKMT8cs4+L1+3wqk/dqzekplVcqdIE4CgSbN/lYzlO6NFN97DHOX1fre/D8b2/tIo3snqaOGFsIEoq6md1farMW0+lowSQ891cRNIWYLUSCQ1+aehRdoPRUqZ4/j7CNAShQv8CaNmOKzSYF1ZuJ+PnMTmR1aoyV7I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=pxdGRtTK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="pxdGRtTK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B026C4CEE4; Thu, 22 May 2025 08:07:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747901235; bh=gfFWoXtvfq0dOKxLkZYmplPetaqqvPy/+dRBhhnGRHM=; h=From:To:Cc:Subject:Date:From; b=pxdGRtTK5fQoKAgAwumAQzBjfmmTcde6P+a38VJT0t2uI2sF9CJaeea+qrI6fqu7s R38ZPEJCfTsJkzLZj3luHxdiV09Tv+6TWDhyRiuvqDqcnHJRB6UDeGnXlrBoIEwzWc 3RslrjJVAtt3hFgGM7nRD+FTSyfeY9//IbW2qSN/f5Am+jDq8AXPfFUNgbFZWv9Ea6 8jyr964i884Tb30cnwMptbCVUw2mIhRBUCyw/9xjUFskAlVeF1KrRintW6fvlsk8dk Z4/aGk6Ot1QXQ7uPQT0gW0F0IpyLCfEjEUIpZPRSX+FNbeOCuZ0NU+2OJjvsPIZtiV IT8FWOgoWFrNQ== From: Lee Jones To: lee@kernel.org, Pavel Machek , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: bettyzhou@google.com, ynaffit@google.com, tkjos@google.com, jacek.anaszewski@gmail.com Subject: [PATCH v3 1/5] leds: led-test: Move common LED class registration code into helper function Date: Thu, 22 May 2025 09:06:48 +0100 Message-ID: <20250522080656.1215457-1-lee@kernel.org> X-Mailer: git-send-email 2.49.0.1143.g0be31eac6b-goog Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Since we will always need to register an LED class, it makes sense to avoid duplicating this part over and over. Returning void and not propagating errors is expected here since the assert will terminate the process early if an error condition is encountered. Signed-off-by: Lee Jones Reviewed-by: Jacek Anaszewski --- drivers/leds/led-test.c | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/leds/led-test.c b/drivers/leds/led-test.c index ddf9aa967a6a..0f152fb12dfb 100644 --- a/drivers/leds/led-test.c +++ b/drivers/leds/led-test.c @@ -22,10 +22,10 @@ static enum led_brightness led_test_brightness_get(struct led_classdev *cdev) return LED_TEST_POST_REG_BRIGHTNESS; } -static void led_test_class_register(struct kunit *test) +static void led_test_class_register_helper(struct kunit *test) { struct led_test_ddata *ddata = test->priv; - struct led_classdev *cdev_clash, *cdev = &ddata->cdev; + struct led_classdev *cdev = &ddata->cdev; struct device *dev = ddata->dev; int ret; @@ -36,6 +36,17 @@ static void led_test_class_register(struct kunit *test) ret = devm_led_classdev_register(dev, cdev); KUNIT_ASSERT_EQ(test, ret, 0); +} + +static void led_test_class_register(struct kunit *test) +{ + struct led_test_ddata *ddata = test->priv; + struct led_classdev *cdev_clash, *cdev = &ddata->cdev; + struct device *dev = ddata->dev; + int ret; + + /* Register initial device - same as always */ + led_test_class_register_helper(test); KUNIT_EXPECT_EQ(test, cdev->max_brightness, LED_FULL); KUNIT_EXPECT_EQ(test, cdev->brightness, LED_TEST_POST_REG_BRIGHTNESS); @@ -63,12 +74,9 @@ static void led_test_class_add_lookup_and_get(struct kunit *test) struct led_classdev *cdev = &ddata->cdev, *cdev_get; struct device *dev = ddata->dev; struct led_lookup_data lookup; - int ret; /* First, register a LED class device */ - cdev->name = "led-test"; - ret = devm_led_classdev_register(dev, cdev); - KUNIT_ASSERT_EQ(test, ret, 0); + led_test_class_register_helper(test); /* Then make the LED available for lookup */ lookup.provider = cdev->name; From patchwork Thu May 22 08:06:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 891827 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E04FE24C668; Thu, 22 May 2025 08:07:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747901240; cv=none; b=b+b4D3+WYIeAWemxt8hTDrlovENON32KZbngxSJelxjdCsnESlHCRfSiwsIJIcGlMO9Bovv7EAfypvcHgWgfQ+uw+OQfRAcaq4+avKPB7BfKc2ab/ZDVFiNIC462bKQAc4Fn6JqKoFJ8QOBt5MWNAua5roseHs347QgVMStQc1k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747901240; c=relaxed/simple; bh=ReQyfORtliZOnPmpdjyz9VziDJLYath6ikkCRZAibrg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=odLJxabHPbH0roF8uaCRfqKLEWQEhh6dQXogSz3LjlK8kVb4CNMVS0mVsI9diDXW2PQC8zcR5zTNz/CFyPSzey+j87DeYKd6O9fu70Mk7X6CO5B+L0H901adZaeroM2eIPGACfN0dMQHjwesLAXD1DV4yZ4PrK8A0RzHfClcuwo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QavLiKZB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QavLiKZB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2B5CC4CEED; Thu, 22 May 2025 08:07:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747901237; bh=ReQyfORtliZOnPmpdjyz9VziDJLYath6ikkCRZAibrg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QavLiKZBOBu41+PBal/K1HO9IoE1GoI0zAKpvHfUjLl2YZlsQOKyOeeQpl9zzoh5H 72sI0KEbdcv+S35NERPjxis5SWgnlDo7oAjFzyzUcgzABh/vfPYM4iHPV0tngcwZlB GR9DjlT6QBXO7eGmvEd+kagFwOrRmAzFG53Ifu7Y4OrdovL+ZQ7rzMYmVafNE754hH Oet/SqlqhAhXiDiiq0s0IdMh3HfwMwGN1DIdxXgBiu5bx/27fFz4PXHhBD70N9VZLf dmehwpQrpF34/wvyJui1ws7EeAi+elWDr2OffFNILYFCSvwKit3cfUWQ/QvEkTbkUq IVkPBZ50++Vlg== From: Lee Jones To: lee@kernel.org, Pavel Machek , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: bettyzhou@google.com, ynaffit@google.com, tkjos@google.com, jacek.anaszewski@gmail.com Subject: [PATCH v3 2/5] leds: led-test: Provide test for registration with missing default_label Date: Thu, 22 May 2025 09:06:49 +0100 Message-ID: <20250522080656.1215457-2-lee@kernel.org> X-Mailer: git-send-email 2.49.0.1143.g0be31eac6b-goog In-Reply-To: <20250522080656.1215457-1-lee@kernel.org> References: <20250522080656.1215457-1-lee@kernel.org> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Insist on non-DT registration with init_data, but omit the default_label, which should fail with an invalid argument error. Signed-off-by: Lee Jones Reviewed-by: Jacek Anaszewski --- drivers/leds/led-test.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/leds/led-test.c b/drivers/leds/led-test.c index 0f152fb12dfb..760c393f5c5d 100644 --- a/drivers/leds/led-test.c +++ b/drivers/leds/led-test.c @@ -93,9 +93,25 @@ static void led_test_class_add_lookup_and_get(struct kunit *test) led_remove_lookup(&lookup); } +static void led_test_class_init_data_missing_default_label(struct kunit *test) +{ + struct led_test_ddata *ddata = test->priv; + struct led_classdev *cdev = &ddata->cdev; + struct device *dev = ddata->dev; + int ret; + + struct led_init_data init_data = { + .devicename = "led-test-devicename", + }; + + ret = devm_led_classdev_register_ext(dev, cdev, &init_data); + KUNIT_EXPECT_EQ(test, ret, -EINVAL); +} + static struct kunit_case led_test_cases[] = { KUNIT_CASE(led_test_class_register), KUNIT_CASE(led_test_class_add_lookup_and_get), + KUNIT_CASE(led_test_class_init_data_missing_default_label), { } }; From patchwork Thu May 22 08:06:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 892149 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 403E62620F1; Thu, 22 May 2025 08:07:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747901240; cv=none; b=htUugMqfbH50ncSrkaI3dbHThGSuV2AVrmOcZjfea7nodQ2Z2XbGYDMwy0a+LN8ODQ/MrLhPr8cayvhye1CCQjG2H6UvGx9K8Io6el8dlkExz0AtjeJ+hKZt2EnnTOXOkbriVr0oPqyMSdMZkiHTDWYVYVcsBG+fyoduemqEihQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747901240; c=relaxed/simple; bh=KKLcPTErM5B81C/wQDuOlCeHvWVPECHHIK3oMc9gqX0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=b82/PzVlIhoaUbF2XyB66IjX/TGA06uOd5hOSpuLj0faKM712RbNge9Eqc74C3Rq77nKefYba1XCTqAEtJJSzkTL4kRj43PgkxP7NSpPWOoPBaKiF3ZNmd9VBiFpstiBRpENKU0u4v6/+XpZUid4N1AA29Ck9HdoPhpEHdiZl1k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Rt/1WSoO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Rt/1WSoO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16463C4CEEA; Thu, 22 May 2025 08:07:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747901239; bh=KKLcPTErM5B81C/wQDuOlCeHvWVPECHHIK3oMc9gqX0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Rt/1WSoOD5oL+i1psnZRwFRnjcE0qLenLBVdqSofiUsmiAeX9CJJS301w742OONVU XK7LuQcpcGR5xIJVffur8Ofb4Sn8C6ob63yZN7mUuNdjGuPkROCm9rvVloYM/2AbDL Zyo8IaM5wnFaVoRWeR+S94qPDUWTaEpPxklu15KfeEWj1qKFkgozwrCJgB1iK9CR2g H31rEn77CFWYbVHRczAatQXHAhwVH43MOQ5iU1BYqlYDt/8RlONrrzn39vg0ROKi7b BDb/jixVf4d0qX2SyYsp1jE92vacRO5/WBrIQEBeE4CAaafX5SwOccU1HOy2ReLYcR c995OJoQcp3gw== From: Lee Jones To: lee@kernel.org, Pavel Machek , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: bettyzhou@google.com, ynaffit@google.com, tkjos@google.com, jacek.anaszewski@gmail.com Subject: [PATCH v3 3/5] leds: led-test: Provide test for registration with missing devicename Date: Thu, 22 May 2025 09:06:50 +0100 Message-ID: <20250522080656.1215457-3-lee@kernel.org> X-Mailer: git-send-email 2.49.0.1143.g0be31eac6b-goog In-Reply-To: <20250522080656.1215457-1-lee@kernel.org> References: <20250522080656.1215457-1-lee@kernel.org> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Insist on non-DT registration with init_data, but omit the devicename, which should fail with an invalid argument error. Signed-off-by: Lee Jones Reviewed-by: Jacek Anaszewski --- drivers/leds/led-test.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/leds/led-test.c b/drivers/leds/led-test.c index 760c393f5c5d..d378c905546b 100644 --- a/drivers/leds/led-test.c +++ b/drivers/leds/led-test.c @@ -108,10 +108,26 @@ static void led_test_class_init_data_missing_default_label(struct kunit *test) KUNIT_EXPECT_EQ(test, ret, -EINVAL); } +static void led_test_class_init_data_missing_devicename(struct kunit *test) +{ + struct led_test_ddata *ddata = test->priv; + struct led_classdev *cdev = &ddata->cdev; + struct device *dev = ddata->dev; + int ret; + + struct led_init_data init_data = { + .default_label = "led-test-label", + }; + + ret = devm_led_classdev_register_ext(dev, cdev, &init_data); + KUNIT_EXPECT_EQ(test, ret, -EINVAL); +} + static struct kunit_case led_test_cases[] = { KUNIT_CASE(led_test_class_register), KUNIT_CASE(led_test_class_add_lookup_and_get), KUNIT_CASE(led_test_class_init_data_missing_default_label), + KUNIT_CASE(led_test_class_init_data_missing_devicename), { } }; From patchwork Thu May 22 08:06:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 891826 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EAF4263C72; Thu, 22 May 2025 08:07:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747901242; cv=none; b=TXENEvvR3czzImNdsBLgKmYBPqE7zNMbojLs1QL+iHe8D0Fev+wak7tIUAvynrixmdFUg+3TaeRM8dFTZiKvMVL0c8EwN9QyMvYEqVuVRl6aclhTyvICrum0JMXPjbXqlxKhNxJ88+5Y3Fnmpbc5X6QoFfe9FzqfJaasz9I22AM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747901242; c=relaxed/simple; bh=NWBmZu+nCm/4qgTrLER4FFhv9gfe+enwC1LwBbCcO7w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HofDmGfqTKwitTQ0fPSD0ZM74LlbB/4lt4kld+E4mXqUCInXaJiFc5voLdl8+0ufPjnYD6rlSm1vdtFin80CAXYH+/ms0kbSHE0pRjQw/eiuwKccaXx5NvpY9ymWbdsMd+CW7OmgrXPPUnDlVQ9HXJEX5LjpdKrL4num1NXv21I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZwcO/oda; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZwcO/oda" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6AF27C4CEED; Thu, 22 May 2025 08:07:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747901242; bh=NWBmZu+nCm/4qgTrLER4FFhv9gfe+enwC1LwBbCcO7w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZwcO/odaOxPz/hB2ktCvOoZ72lJXXkb3Fet7PyURUwPlPyBRYLOt+ZYOkG05evgKy B0sJy4apYiQclBHQKVf27MY4m/B/CrnfHCq/iDjs0o9Gc7kSZ02nKTRi1XVqDrumGE +1a67OyNuEaG+LSrnnff1TzEw48jDcQOAOqQVdz3gZh9u0EkIkAHWwBsQ2qiYiLBAO Kw7TaWsemazvNe6FBme51c+2/Hi/dhQ6LtDvoclhYGLf5G3jWVBlIDY+JT91KNK4SF tZP6UA7RS4OQ/YZUVa9EnWsLNNoIJbcf8WmX1GR2iotNSoxmfK/+kgjWfjsjXU+IaG whfORLp86HFlg== From: Lee Jones To: lee@kernel.org, Pavel Machek , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: bettyzhou@google.com, ynaffit@google.com, tkjos@google.com, jacek.anaszewski@gmail.com Subject: [PATCH v3 4/5] leds: led-test: Provide test for registration with a name that is too long Date: Thu, 22 May 2025 09:06:51 +0100 Message-ID: <20250522080656.1215457-4-lee@kernel.org> X-Mailer: git-send-email 2.49.0.1143.g0be31eac6b-goog In-Reply-To: <20250522080656.1215457-1-lee@kernel.org> References: <20250522080656.1215457-1-lee@kernel.org> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Insist on non-DT registration with init_data whilst providing a default_label and devicename that when concatenated together results in a device name that is unacceptably long. Signed-off-by: Lee Jones Reviewed-by: Jacek Anaszewski --- drivers/leds/led-test.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/leds/led-test.c b/drivers/leds/led-test.c index d378c905546b..d5017c6dca08 100644 --- a/drivers/leds/led-test.c +++ b/drivers/leds/led-test.c @@ -123,11 +123,28 @@ static void led_test_class_init_data_missing_devicename(struct kunit *test) KUNIT_EXPECT_EQ(test, ret, -EINVAL); } +static void led_test_class_init_data_name_too_long(struct kunit *test) +{ + struct led_test_ddata *ddata = test->priv; + struct led_classdev *cdev = &ddata->cdev; + struct device *dev = ddata->dev; + int ret; + + struct led_init_data init_data = { + .devicename = "led-test-devicename-very-long-names-fail", + .default_label = "led-test-label-also-very-long-names-fail", + }; + + ret = devm_led_classdev_register_ext(dev, cdev, &init_data); + KUNIT_EXPECT_EQ(test, ret, -E2BIG); +} + static struct kunit_case led_test_cases[] = { KUNIT_CASE(led_test_class_register), KUNIT_CASE(led_test_class_add_lookup_and_get), KUNIT_CASE(led_test_class_init_data_missing_default_label), KUNIT_CASE(led_test_class_init_data_missing_devicename), + KUNIT_CASE(led_test_class_init_data_name_too_long), { } }; From patchwork Thu May 22 08:06:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 892148 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 024CF264614; Thu, 22 May 2025 08:07:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747901245; cv=none; b=R6khdk9awer/XHBGmG1hcSgIU74YhIcqKNdZ96pPFDh+vSgyu4M7O7DsfJ54aHV4vhY9CTKf0MLEw14T9tZenX/V0A1IHPgVlm93YmMAcAnbTbcCuFFkVJPJvzq3iPCDhuizl1v6IcHK2cQJmSO2agzLuLmv7Ovw4ovykeXoJj8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747901245; c=relaxed/simple; bh=EPm96wo2mbVeci4pRjlD4z0kcMc1ORV0rQunhCIxSpY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BZn9CQ3yG/imngQ77tY5Wt/kDr3Df4R6f+gSvJrrtSNgArcCsW7FEo/iEjZZ2Ry8MaBcam/l/RiJMw7ma7I7DkBHfM0/L/zuh7d026p6zN3ZufQybYuedUkoerRzFMf8L/vdJqnm0vmvK8hMeVLfKHFokTmIP3Cc90iEbcgicJA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Wsr3WgRN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Wsr3WgRN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C21F0C4CEE4; Thu, 22 May 2025 08:07:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747901244; bh=EPm96wo2mbVeci4pRjlD4z0kcMc1ORV0rQunhCIxSpY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Wsr3WgRNwI4VnohI5Q1/10nRD0fdiMw2ahLFR9HN8Gn7p0HvxnHAvyVMoZHOIjTSt /1CdlAqCBs90adooUd5EZRThdVh99mw4/FUGqf1hSoWIPMYZcrmvFUJ+/1cALL7nmZ 6FT042++cOfCw85muulO2gDzr6y+1iMLK77QQjsmg2FB/JfLleaijBbJ/77sHkuX/t AWwvsqk+jXAWgHQbZeVzr0b3MYcBnMY93lWzYdY6p2xXNNsxjVRCD82vYr1aevPGW9 prR13LKduiKygxKg4xFrQkLaR/UVd9bYOzpKhBuzSKDkV5QtwjF4gBkpP+gCEK5VkR 2HcOsBn2yK/sA== From: Lee Jones To: lee@kernel.org, Pavel Machek , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: bettyzhou@google.com, ynaffit@google.com, tkjos@google.com, jacek.anaszewski@gmail.com Subject: [PATCH v3 5/5] leds: led-test: Provide test for successful registration using init_data Date: Thu, 22 May 2025 09:06:52 +0100 Message-ID: <20250522080656.1215457-5-lee@kernel.org> X-Mailer: git-send-email 2.49.0.1143.g0be31eac6b-goog In-Reply-To: <20250522080656.1215457-1-lee@kernel.org> References: <20250522080656.1215457-1-lee@kernel.org> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This time both the default_label and devicename are provided such that when concatenated together result in a device name that is acceptable. In this case registration should succeed. Signed-off-by: Lee Jones Reviewed-by: Jacek Anaszewski --- drivers/leds/led-test.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/leds/led-test.c b/drivers/leds/led-test.c index d5017c6dca08..9bdebbe04462 100644 --- a/drivers/leds/led-test.c +++ b/drivers/leds/led-test.c @@ -139,12 +139,29 @@ static void led_test_class_init_data_name_too_long(struct kunit *test) KUNIT_EXPECT_EQ(test, ret, -E2BIG); } +static void led_test_class_init_data(struct kunit *test) +{ + struct led_test_ddata *ddata = test->priv; + struct led_classdev *cdev = &ddata->cdev; + struct device *dev = ddata->dev; + int ret; + + struct led_init_data init_data = { + .devicename = "led-test-devicename", + .default_label = "led-test-label", + }; + + ret = devm_led_classdev_register_ext(dev, cdev, &init_data); + KUNIT_EXPECT_EQ(test, ret, 0); +} + static struct kunit_case led_test_cases[] = { KUNIT_CASE(led_test_class_register), KUNIT_CASE(led_test_class_add_lookup_and_get), KUNIT_CASE(led_test_class_init_data_missing_default_label), KUNIT_CASE(led_test_class_init_data_missing_devicename), KUNIT_CASE(led_test_class_init_data_name_too_long), + KUNIT_CASE(led_test_class_init_data), { } };