From patchwork Sat May 24 17:47:15 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Tomasz_Paku=C5=82a?= X-Patchwork-Id: 892444 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB2FE1B043E; Sat, 24 May 2025 17:47:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748108852; cv=none; b=JXdzv8zkVLqyPlhFicv6Ld9mW155UzgtE+MLnj1PqScHG67M8URq8pX5N+QVl6AWxLs2g2kQ+/7iWg2vTN4Wwjj3rTO6/YOhWlIaUz0vQkk6vgtze5IraccKD5IiPoi4eLP5lxtZRGtHCXJHHKAPFg+80eHkqa5S4FNNjw6hgJM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748108852; c=relaxed/simple; bh=q7smeA6/r4PWEKs067Q26OKyLMJglVnlffBS/cN5+Es=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Cn/GRYqTMEHpuuIokN1zXIwV+kBV+XizjkYD4XSZO0qKVHeEwSZqBLa8aKwaxPhLQyn5+az65RK/n3/684AWDbWGvKfJNk0qI5w803XFtMZCtV6MVVizf/Jz2UaeA1/dl4LPizvyNemtH/yrvGiQIMctRMBdZcTdhML1XkMz2Qo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HDm//bAL; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HDm//bAL" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-60169001e0cso133337a12.2; Sat, 24 May 2025 10:47:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748108849; x=1748713649; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=j76gckhvXinrW9VV0Ck2UDRzltEJE3k9ikLRQ/KXetA=; b=HDm//bALwl/Io0gJVgQ6Olw/4SKUY7W7+z19JWGgBhLLv1hSSE8MBI4OwP2o81NgZ8 eRv7mAnj6k7TgZnV6ii1deDSnUxYDBUBXU5cPP/va9SMedJMLvz5cJDyIT7jwV8f4tfl sZTJwz59Aw+kXfEyWOW2rTB4tK+pHQQGKaZ8UUQptUa7ckqlHSF5VcQxX7Z3XFXABmwo n91UC/ySIekyd0sFv5qlNoDOz1wU9KFP56ZcUjhHR9bwM6Rp5IeKluKMF84vxdUIlkE9 k3kFGbKFJHNoMCL0N7VaB4OUieDbtF6JL3B26/t+cveAAPMMMH/hWk2LNM7iuv6USXgd l7mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748108849; x=1748713649; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j76gckhvXinrW9VV0Ck2UDRzltEJE3k9ikLRQ/KXetA=; b=QVaVE0Qc7Upwr8zCmpe0LTBIFWr3rRrdo/3lnXlHeauHhgU6H+H3yqIHY5XUsHpXIj Y65/ZVV3moq1e7ney0vTTtS7+hl9UYBPPtZHcCebo4V6nYrdFelcC4Nr76OGmObr3OuZ 8ILTV55KyMWSXdUjZ+tg3eD7tFXoq/SJY/UAyNylFtxc4W1etXHTk9amhFgXFdT2/Aup Geg2dSxASGGuysH5xgKhVRkjZfkSBhMAUnDjo6tHtgD9Et2txE7ouwdcrbRCgavAAuJ/ yt2HythJIynKxwBicnP1IVc8aKb7rj4F42Zn0vCjo8FqB2XmpCa5UY+lbRJOSoU1Vx3T JPPg== X-Forwarded-Encrypted: i=1; AJvYcCUjv3n587kiG08HF+BEc5eaPrN3Sa/H99BR+KiYMCaBKsXwf0VLZxvgifRyO1QPd0Z4kmGnIxtTbWNZ@vger.kernel.org, AJvYcCWsnI6CRPa+0Icfb/olthNOADZnsZYeMJw8ELapvUzo4mTL0N/uCVT4eNt54W621vcDHEtjz02/bhdDig==@vger.kernel.org X-Gm-Message-State: AOJu0YxbXZsWPsVd4KrJV0Z1vMm9w2fS2hbY1LyaS1oJwTH8417Y+Pft z//DnAbBqzinEkfYRdfrodrRwYxFy0hqbrKV560j8GnrZCFk3s2tLftjhzzU9A== X-Gm-Gg: ASbGncuwOAHHW6RToOe1O95ahcUIdxTbq+n7OU4VBlrfoQ5+3KpJv0gNAE/wzHmEz8E CfKmpJok0mA/G1WP+6BBeWH+SlFfYdOwLKdAXv+gpqZN8+KLwU/DU9qbzbIeUc8xtPvDH7QJGPt OUHDfHEwzFclENgoPoskk+qhAwLXna9IB7BYpv/RZtaOg3XW+BkebK31eCmoKUiIHtYjitXZjnQ P2tasPbetOH4X+yIbEtRP+bdegVELs73xBc1k5xEmCljHx7BLIafk97m0E6JKEZNuoiTnPP72S7 r+EKo0prirptfKm46IQaVOoGpIWNltmYMrsBTXO4tR2qWALaxXPNGYB4h/hRIlr89knse1bBuhe 9 X-Google-Smtp-Source: AGHT+IErSeHhiprcbAvBQsuCOBz0UT/SEe4afsi/ZIa8YSoKGwJ8yaF0qqcIgcbRr9fQCancPO9xhw== X-Received: by 2002:a05:6402:34d6:b0:5f8:e24b:c8c1 with SMTP id 4fb4d7f45d1cf-602da4fd0c3mr1040224a12.9.1748108848962; Sat, 24 May 2025 10:47:28 -0700 (PDT) Received: from laptok.lan ([89.64.31.142]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-602f11a0e0fsm1138789a12.13.2025.05.24.10.47.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 May 2025 10:47:28 -0700 (PDT) From: =?utf-8?q?Tomasz_Paku=C5=82a?= To: jikos@kernel.org, bentiss@kernel.org Cc: oleg@makarenk.ooo, linux-input@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH v2 02/11] HID: hid-ids.h: Fix LITE_STAR_GT987 device id define Date: Sat, 24 May 2025 19:47:15 +0200 Message-ID: <20250524174724.1379440-3-tomasz.pakula.oficjalny@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250524174724.1379440-1-tomasz.pakula.oficjalny@gmail.com> References: <20250524174724.1379440-1-tomasz.pakula.oficjalny@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The name was missing "ID" part Signed-off-by: Tomasz Pakuła --- drivers/hid/hid-ids.h | 2 +- drivers/hid/hid-universal-pidff.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index 1062731315a2..5c75c09c5780 100644 --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h @@ -841,7 +841,7 @@ #define USB_DEVICE_ID_PXN_V12 0x1212 #define USB_DEVICE_ID_PXN_V12_LITE 0x1112 #define USB_DEVICE_ID_PXN_V12_LITE_2 0x1211 -#define USB_DEVICE_LITE_STAR_GT987_FF 0x2141 +#define USB_DEVICE_ID_LITE_STAR_GT987 0x2141 #define USB_VENDOR_ID_LOGITECH 0x046d #define USB_DEVICE_ID_LOGITECH_Z_10_SPK 0x0a07 diff --git a/drivers/hid/hid-universal-pidff.c b/drivers/hid/hid-universal-pidff.c index dad6c5a6e2df..554a6559aeb7 100644 --- a/drivers/hid/hid-universal-pidff.c +++ b/drivers/hid/hid-universal-pidff.c @@ -178,7 +178,7 @@ static const struct hid_device_id universal_pidff_devices[] = { .driver_data = HID_PIDFF_QUIRK_PERIODIC_SINE_ONLY }, { HID_USB_DEVICE(USB_VENDOR_ID_LITE_STAR, USB_DEVICE_ID_PXN_V12_LITE_2), .driver_data = HID_PIDFF_QUIRK_PERIODIC_SINE_ONLY }, - { HID_USB_DEVICE(USB_VENDOR_ID_LITE_STAR, USB_DEVICE_LITE_STAR_GT987_FF), + { HID_USB_DEVICE(USB_VENDOR_ID_LITE_STAR, USB_DEVICE_ID_LITE_STAR_GT987), .driver_data = HID_PIDFF_QUIRK_PERIODIC_SINE_ONLY }, { HID_USB_DEVICE(USB_VENDOR_ID_ASETEK, USB_DEVICE_ID_ASETEK_INVICTA) }, { HID_USB_DEVICE(USB_VENDOR_ID_ASETEK, USB_DEVICE_ID_ASETEK_FORTE) }, From patchwork Sat May 24 17:47:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Tomasz_Paku=C5=82a?= X-Patchwork-Id: 892443 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8CC71F09BD; Sat, 24 May 2025 17:47:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748108855; cv=none; b=sWlopS1+rZn9e98mshgZL1KEoFqbFZk9p24Hjhx9HjEEhM4g+9hH3dVHmFXvwJ+G/+eEL0xhAKJb6Fo76MgAbzx/cXL6f+WCL5i15zQ+TssnMwXOpbAV+3pvKHM2h8ISU7GJa3RSeobpQVNcc2y9xkmdpLxq0qbtNEGdAMX7kGE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748108855; c=relaxed/simple; bh=8zV2Zz38Klb5MFeLBdrn5DHAzPRNSVUba4ee/qaxcto=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=bo5LKwBy98IIKpcitaPnJCVyTWYs1rVHwYd7BR+ppgHDjBazbtQpJk3PXNCCyrjkPjghxuWKUS+LL01ppfglZykcCUFUVEDzbhiTJlsH01NsUejQTgVnsCk9AN4QWKYetSb1GTIr4RAe8CicxR35Z01lZKsetD/fWTPQ6oUMgps= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dtEdiDOc; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dtEdiDOc" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-6041b38c94aso67194a12.0; Sat, 24 May 2025 10:47:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748108851; x=1748713651; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LE2pVpuHLxjaHNVGuCXTpw5e/6sQrWu/pWCwQjCGC5c=; b=dtEdiDOckII2V6yx9PM6GSykqg3d/3q6XYOk5HWVVHFl5yf9xUyaUIQwqe0lcBUjzq LTYH/RzvyITmFqSE7AJ6nIqk1tXniqmp2PlX92eVGyRI23JD0c0BSBnCxaGEMTI4w8oA TZbCO3AAJUpIcHmk95smn7jztZ33gYBZ8g7Fj2fjeqGga8XejXEeT3jP3QtnucCK6tTZ +DDegeFNW8lHfNTFzOPY/lyXpXVC+a/J+3qDdcaI/YjOQ1YHYiE/KXQvIMvqwxNJoECz zUpQaAlwjsUF6DoWj1R1RRvl4YkCpXIW518nbUSkEGmk9mTYw0dnhKaRKPA+ny3kBOym i2PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748108851; x=1748713651; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LE2pVpuHLxjaHNVGuCXTpw5e/6sQrWu/pWCwQjCGC5c=; b=ZVarOXBX3s7AqYqNCaGNvbzt14oSoOwJO77kqMtQ8jaRV2hY5m88a4rNlTmYa7zw9d wSJfQH/LLmjLIgwAxG7yA/vUjPIvdVtPgJmG/bfKtY/xgMh1vPy4NWuuGv0d8fiu8eWE KUoHsFHmW406g2f9m1EhmiS/D/rGi1vgoA1mF29lDaNoOHK9CMMCiA8goPVcE3HZFxhd ZURg72nI9AjDPzacz0d8LQmiH7/vaPdBlkL0ZPjC/BfhPIbVgtXxTd/X009na3WuHhs3 R3bHhCC01c0Q5Loze2zO+GYS9id4WliNf0rO3odRND+Eqd15p8L0SoiZ8UGKcFAz3+Ez zRag== X-Forwarded-Encrypted: i=1; AJvYcCXT+pEJcNDflr7htb1ZdAWvpnzUxLM54sy2RyknEDVwyimObdEOZNNzi4ZBlY6+sQGbLXbfqSaJ3B/zhQ==@vger.kernel.org, AJvYcCXoPQs8iOu3SIiIFjvs0p1Yfl/hAXvzi9ejrJrACCaApS1P9U5nsqitIktxqVU2MG/1FSRWUtXAwPT5@vger.kernel.org X-Gm-Message-State: AOJu0Yy1Zb2H5j1856sqGgj25Cq6lSMqCPCbCVIM6EWm4Ng67P1k1BbB t7DgMpYlhUudBoKObrwzktV04EFrSdPr4JCxKHNS/OU9Gf+kUBFiZDe7 X-Gm-Gg: ASbGnctxVNz2KXefOGNrmFpZQv3m0d9QMfhhWqCv3vD9rioQPDEvCF8R9HWA7nghDwP 5L3j96rhgEzTVd5gPqcS2m+9WMC6uuCCC1qfsh5OF8sKO9oUnFZ9Mk1panGg0cLkSIyoF6mIHZR 4jUSsRRokWiRgUjCkYwsAIvYFKlaJkcURuT5T/4ZiBITUpsxt7tpfBi/xthTXvLpbKqmdXqqQnE zeQR7FPecLEQNc6blLY/onPBc+6/A5HVMFqaQstIbZ0B2nBWY/psHO5J+x8LmIe2lTsuKVvUkdJ pGlkkVPWp5SNymAGWUju/91mXoUrC/8jciZ3Nz/nBpKe49tkYcxZGsfRONRWa3No7qfAzpidS8F P X-Google-Smtp-Source: AGHT+IER32neNIQnu4ymwLiWZkefU2hS2HcLHAH7jWfX7exDg5CYFWg8TX2TN/91xD2vXPTNQSbH6Q== X-Received: by 2002:a05:6402:27c7:b0:5ff:9994:92d3 with SMTP id 4fb4d7f45d1cf-602d9cfb00fmr1039090a12.2.1748108850977; Sat, 24 May 2025 10:47:30 -0700 (PDT) Received: from laptok.lan ([89.64.31.142]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-602f11a0e0fsm1138789a12.13.2025.05.24.10.47.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 May 2025 10:47:30 -0700 (PDT) From: =?utf-8?q?Tomasz_Paku=C5=82a?= To: jikos@kernel.org, bentiss@kernel.org Cc: oleg@makarenk.ooo, linux-input@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH v2 04/11] HID: pidff: Fix missing blank lines after declarations Date: Sat, 24 May 2025 19:47:17 +0200 Message-ID: <20250524174724.1379440-5-tomasz.pakula.oficjalny@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250524174724.1379440-1-tomasz.pakula.oficjalny@gmail.com> References: <20250524174724.1379440-1-tomasz.pakula.oficjalny@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Fixes chackpatch.pl warnings Signed-off-by: Tomasz Pakuła --- drivers/hid/usbhid/hid-pidff.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c index 8dfd2c554a27..3c2b20cf7853 100644 --- a/drivers/hid/usbhid/hid-pidff.c +++ b/drivers/hid/usbhid/hid-pidff.c @@ -241,8 +241,8 @@ static u32 pidff_rescale_time(u16 time, struct hid_field *field) { u32 scaled_time = time; int exponent = field->unit_exponent; - pr_debug("time field exponent: %d\n", exponent); + pr_debug("time field exponent: %d\n", exponent); for (;exponent < FF_TIME_EXPONENT; exponent++) scaled_time *= 10; for (;exponent > FF_TIME_EXPONENT; exponent--) @@ -332,6 +332,7 @@ static int pidff_needs_set_envelope(struct ff_envelope *envelope, struct ff_envelope *old) { bool needs_new_envelope; + needs_new_envelope = envelope->attack_level != 0 || envelope->fade_level != 0 || envelope->attack_length != 0 || @@ -715,6 +716,7 @@ static void pidff_playback_pid(struct pidff_device *pidff, int pid_id, int n) static int pidff_playback(struct input_dev *dev, int effect_id, int value) { struct pidff_device *pidff = dev->ff->private; + pidff_playback_pid(pidff, pidff->pid_id[effect_id], value); return 0; } @@ -1207,6 +1209,7 @@ static int pidff_find_effects(struct pidff_device *pidff, for (i = 0; i < sizeof(pidff_effect_types); i++) { int pidff_type = pidff->type_id[i]; + if (pidff->set_effect_type->usage[pidff_type].hid != pidff->create_new_effect_type->usage[pidff_type].hid) { hid_err(pidff->hid, From patchwork Sat May 24 17:47:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Tomasz_Paku=C5=82a?= X-Patchwork-Id: 892442 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6CBE1F1524; Sat, 24 May 2025 17:47:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748108856; cv=none; b=Va5YKXUrgA6u6jaNiF+p2/2EpmHRVhHZrRnqqObAyS6dFo+lYZVK4SAZo9H0407RnIx9QBZj24oO74wevL+Guz6NOfUU31gYdxzWHRBC7NantvRrZjMiCJP5PeYam+DZnOJLm+7g19I+seFuEPQ7pwmmA/xhqOBf7eWsDh6cFHg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748108856; c=relaxed/simple; bh=plxgnBC3/TSSTHavnweC+mX7Rx6meyv7logqYNGVEVc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=g7qXt4UXVUDMffNIzaPODI7xRwqYjLBgo2gTg80OaQ6R67m2L6snzmv1y1FzaAmOicSyISHPjjWNajbf8WPfQnJHS/8Z8GopaTZ3WP+yM9gHbIJVdkTB36BBZ2E9p0qDfhr3iJBPo0mpMEQ+ccN5/CFWmrVPXtaPnww1bPZ4zGs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OTjSaF9y; arc=none smtp.client-ip=209.85.208.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OTjSaF9y" Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-6041b38c94aso67196a12.0; Sat, 24 May 2025 10:47:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748108853; x=1748713653; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=s1jNkw/6MR5i6Cr/2hMjKLeS6l2X7bhc8cyPl4fASrY=; b=OTjSaF9yc34vdoW4Pg7fmsPz1kuLT+Do66m5PDR/wwaWDgg51pG7UZ4voQyOGmpeA+ zR0qR0WR7TTHosllbzvEuCCZsvCzCXTP7zHevhI4csdRMPmIARoRL0zv9cqXJoErQXa7 b4riRMuEkglQSEnBkcAAuXFjVU2kuoxK/QnU9pUPtqmdYb6waWwXzq0YVjLqg6Jdy67W XOFZvsmJjGQV9v7KAK0ST9rhHZS4qOdeDZGFoN6Uh8oy3ruT7Zdhd9ZWwlvsaEmXYzhP GN1EKZta2LN6G/FNIxuQ74E6mVfUTPtALQQ2IRIVQ11hlJjh4et7/g7WERzU0vlaP0QU OrEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748108853; x=1748713653; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s1jNkw/6MR5i6Cr/2hMjKLeS6l2X7bhc8cyPl4fASrY=; b=TZontHfrggnyH0cogtXHOKVhy5eY19SlOPkYU2/WJU/dXJ80tAbyXCwean25wnhpzk ffITmPMdQUOAvNJWizj4wlzmiU22rBpSp3HGeyr5nMzW/bAJ2E7An0nP5THEFSPYrzOi kIi0HqYSvE+wDLjf6CM8pUwDbGi5HWtQw9+fWkplWk1AwiLOQwrYBYoSikqPCPlszRv9 axuOMapg1nmeQN280UBzKWCWBlAae8Co73oqWcN1+LFTwQ5oQCiQ/6O8HI3dKVC0sai3 nj3eYf9kW23pVqVb6dYJWEAmKb3hNFMT8gJmuVYZcEeOgqj8FI/8vvKBH6DtYX0MeF6E Kw3w== X-Forwarded-Encrypted: i=1; AJvYcCU2soY9yZ2DJxVAgkhwjqRIEVnsBn+uBbn9QHPASO2ZTE93Vm3p+i4RzFlEVls68+j7b0/OWsYrhTuo@vger.kernel.org, AJvYcCXkP3xF1jZIinarthylFweXO+wwE2bI6p8N4qVYLnBcAi2RT3ZegEeszN2DUj0sbvv71IqrgZ3Wo9M4Yg==@vger.kernel.org X-Gm-Message-State: AOJu0YwNoqimk1LYvh88OolHAGsEtdv/vndk/Edl7hx6a+QX7xj+wzQw LKc+sPUZRs2T4PsdqS5VDDkX4oBU78qLrES76xJji6ZrISAJB9mm1vfi X-Gm-Gg: ASbGncuEjzqitAKvUW4WqHVf8rs6sf8qhSvIx9XVZj0mqBVoOP7v1W4dr8lkteoM7lh QksFgqQcC+fEUOzf3e6MermYvq+RUZVSqv2cCOXhOZdQ3ffnNtBl7T/egKseIo62Om6LuECW3l7 71d8wfUyZMmj4NndlQrgDeoYiiPrsP3M0yLLhiV9c2BP0ly2SpIe934W3a/1SlofQtIFjHpycvJ jZB7O/E2fOWqpTD8ktuia1Auch9iv2eqWMnRr+aJBEG1LGx/yvk7R/hIG7zFqVhAlmFbAEtHQGa DXnIUFDksI6Nn6Gxvnxct64YjLBywqx2S/eScOKv21Pf6aB+A/ETE8jhu80NC7yHZQ== X-Google-Smtp-Source: AGHT+IE4W1WB8obcvELVn+wfAIx5Jo4kUWsgTf7DpJX77pKDmtKaACgzTfTL+g1STqrPnix5Pr5LPg== X-Received: by 2002:a05:6402:354f:b0:5f6:c5e3:faa0 with SMTP id 4fb4d7f45d1cf-602db3b4ebdmr1141430a12.10.1748108852944; Sat, 24 May 2025 10:47:32 -0700 (PDT) Received: from laptok.lan ([89.64.31.142]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-602f11a0e0fsm1138789a12.13.2025.05.24.10.47.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 May 2025 10:47:32 -0700 (PDT) From: =?utf-8?q?Tomasz_Paku=C5=82a?= To: jikos@kernel.org, bentiss@kernel.org Cc: oleg@makarenk.ooo, linux-input@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH v2 06/11] HID: pidff: Rework pidff_set_time() to fix warnings Date: Sat, 24 May 2025 19:47:19 +0200 Message-ID: <20250524174724.1379440-7-tomasz.pakula.oficjalny@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250524174724.1379440-1-tomasz.pakula.oficjalny@gmail.com> References: <20250524174724.1379440-1-tomasz.pakula.oficjalny@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Fixes blank line warning from checkpatch.pl script Signed-off-by: Tomasz Pakuła --- drivers/hid/usbhid/hid-pidff.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c index 44cbd2a0461a..743b76c8d3b2 100644 --- a/drivers/hid/usbhid/hid-pidff.c +++ b/drivers/hid/usbhid/hid-pidff.c @@ -273,8 +273,8 @@ static void pidff_set_signed(struct pidff_usage *usage, s16 value) static void pidff_set_time(struct pidff_usage *usage, u16 time) { - u32 modified_time = pidff_rescale_time(time, usage->field); - usage->value[0] = pidff_clamp(modified_time, usage->field); + usage->value[0] = pidff_clamp( + pidff_rescale_time(time, usage->field), usage->field); } static void pidff_set_duration(struct pidff_usage *usage, u16 duration) From patchwork Sat May 24 17:47:21 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Tomasz_Paku=C5=82a?= X-Patchwork-Id: 892441 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEC8B1F1315; Sat, 24 May 2025 17:47:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748108858; cv=none; b=XvmbcegzY22OaXYX3UEg5O34vkRhBHERDpH/xFQbr894qV/7z/dlZLWblTGgE3hosBFZYidLA+RxNwz8vslFwCE8OKIStGiKKEkwBET05MLGd38Bv9k5jShbxD4HCx8eJqg3SmOO1U5rX0tIm/KrCJU7+rou83kq7n6jjR72BGQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748108858; c=relaxed/simple; bh=j1BMQHjcfhSqWMrNSBDGMw3T0MHTY3JcNOw5ASp1Aik=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rMyqv2fnc2HeYcm7AYIPPRJPqeLVxdAsarO7580yz+o2G+kvmer/UAjpgNKLFKVvkIM3uhwEJVvbzEjd8W0j5kqloMPZWL3m5DifN413yR06mifl4XpDyqUm+65k6noVJxDUz48duykLeAjqZ92IeAhN9+ubENM5lgQcPGluxUc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aAM7dTER; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aAM7dTER" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-601df382301so116918a12.1; Sat, 24 May 2025 10:47:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748108855; x=1748713655; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WDh+Scz/A/iAtqESiw80/C2QD/zEyqnzP4ky3talhiQ=; b=aAM7dTERy6AbUJkgDB5nUnIiIt1P6ZmPb+N06Gzzmr3IwEdMpN8+/cXIXVfCSMBRDC MfPWkTFQOwNtjBB67OktG55YKQ9MzUGYV1A9QDW60m8QkBIn6wEuOuCzlFYn9+YOG3SZ qiO4qlFSrlu8qPoUT4NW+JLsbBdSNvMyGsQOQsjcwGrqYJImSUW2fDsUmuGr58fshBA8 HTAlQCvz2NlJFfgnuXDYVHG/xZugXDgPPcGQAqOqCGrl+r9GdU6BOQrdZGtLfKqIelWe G1hswPXNV3q+GA6KWxNP7uBOqvprtayRc3BL3Xw7v0k48a8DW0YJwQ1tSpkTEotvty5+ dJow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748108855; x=1748713655; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WDh+Scz/A/iAtqESiw80/C2QD/zEyqnzP4ky3talhiQ=; b=A+6s+NcUeD6XxbWwyJhOrj46Mfw7RDJlAgvLKjRv8ecH20PwbRbYh/KFJzBMUZ2jE4 +90nG+N1siJ7PsMczp/g2KZyrMfJ7Rk9lnUq5TTTJUpdtb2peaN2I9W9lKnr6H5mOrLp +Spbfb86nKwNlIQUX695pA4vUd78GKLMtEYm+14U4MRTXG6CmYSX0TCeXTKT6GhVQWtC Z/sSDA7AD4R3FttI+aRKGBEMjn3UiYz7w9Kfb0z3sYnjWDP3l17hcBww3OBCtMlSXAfW 8MlYJodpkCMjlrnDk5c9AKX3q2WHk6nBXNs7MnovHQy5Bv8/MWdS2go3LHu0fFxUEiil v6nw== X-Forwarded-Encrypted: i=1; AJvYcCUuk9MfeKNYhHqYt4wYO+bAIQQOVOTKbGiefHgqrjtGifgEIunJO4vH9wIcvuh2FipBYusCtqNn9Fih@vger.kernel.org, AJvYcCX+b6/1981PeFZVuENzscjqccN4HP/2f1XPUsiETWq7oL7kQSagrjVtYsmsDZS7hwKdLDkUaF1IDia1rA==@vger.kernel.org X-Gm-Message-State: AOJu0YyIoRbFjMP2Z/4tThNdh9p5NGwSXbXPV2Pl9Db20eyPvzLyaqI4 O2/6zh9lERYSo1Ebwz4MZQ/s/7a0wB/MAOcFMP+eCER4ho24N/i1tE7Cj0JESw== X-Gm-Gg: ASbGnctvwdNpiQLV3wxhuXAuLO2clFLkEz8je1QGfWeq8z9WAIa+Ug0mPvv6OD2R9BM O/C5+KhlG2KrzyJA93p/gv5eMsd8pFdpszeSOkKMZb2RuztOu5PpXRvErD9pNVJmHVIFXojFhHQ ZknvaYEauCfdAbPp6eBmG0czgS0Jsw+KIU5cZiZX0aubeRFt0GdaTcgI+FAKqmoTNTyaIW0dOiz KEnETz+bwVheaLyPgbd0fLGKYu4Q46N6G2Pn0FTh/XI1L/HfKupWgc1f/Xzv3Mya8LLSFjMo8zG NlRtOPvyQgfj50/JF5uNlXkSUCKUlj5UVabLYNU34dQPLL0QjMoFzciccc9xoZQP1A== X-Google-Smtp-Source: AGHT+IFjAi84HTZ/A4pA+C9Uh4taswArg/OQm9/eLcxntsiK+e5pN7QhquKttk1aEoXnZwZedC5iWg== X-Received: by 2002:a05:6402:3550:b0:602:427c:4570 with SMTP id 4fb4d7f45d1cf-602dafc7e9amr1072307a12.10.1748108854849; Sat, 24 May 2025 10:47:34 -0700 (PDT) Received: from laptok.lan ([89.64.31.142]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-602f11a0e0fsm1138789a12.13.2025.05.24.10.47.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 May 2025 10:47:34 -0700 (PDT) From: =?utf-8?q?Tomasz_Paku=C5=82a?= To: jikos@kernel.org, bentiss@kernel.org Cc: oleg@makarenk.ooo, linux-input@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH v2 08/11] HID: pidff: Remove unneeded else in pidff_find_special_field() Date: Sat, 24 May 2025 19:47:21 +0200 Message-ID: <20250524174724.1379440-9-tomasz.pakula.oficjalny@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250524174724.1379440-1-tomasz.pakula.oficjalny@gmail.com> References: <20250524174724.1379440-1-tomasz.pakula.oficjalny@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Fixes checkpatch.pl warning Signed-off-by: Tomasz Pakuła --- drivers/hid/usbhid/hid-pidff.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c index 88eb832265a4..6f25490ce464 100644 --- a/drivers/hid/usbhid/hid-pidff.c +++ b/drivers/hid/usbhid/hid-pidff.c @@ -1081,10 +1081,9 @@ static struct hid_field *pidff_find_special_field(struct hid_report *report, if (!enforce_min || report->field[i]->logical_minimum == 1) return report->field[i]; - else { - pr_err("logical_minimum is not 1 as it should be\n"); - return NULL; - } + + pr_err("logical_minimum is not 1 as it should be\n"); + return NULL; } } return NULL; From patchwork Sat May 24 17:47:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Tomasz_Paku=C5=82a?= X-Patchwork-Id: 892440 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87BED1F1531; Sat, 24 May 2025 17:47:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748108860; cv=none; b=R4u0Yy0RUDlISIQbbS/azsnyHZniZIzdmUEVBKIxo8pq/DuFhhNdTKnNb6GQrnPT0jmCgULWNr9I0jEMvHXSNpm7484fsYnZs7sgZJiNYtkwbr8HRnZ2FZ+1ONK75wrLUkhEzV4+O87nKpIiR/drJ04gxAfaMfo1oO6aa3NFEAY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748108860; c=relaxed/simple; bh=nTZ6r0Tda4xGcagX9QEjNojbjy4ea8auhWMH6Rp3B3U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=bKAIUAPQt3QxyZBYzKGxogJN9ld9hHaClsPU20VwiGIHJhN1Z5wBWdDEQ6GS4v3U0ft0ybS8pp5GPHLnIKV7FA48I/rpJGYN6gNgBW4Tif3scBFTWqEEd3jEpYpYsUOQmFVY8najeDDlyPQQ7LiBzzfzLdQSrl2qMxfn5soI1io= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Doq59GBD; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Doq59GBD" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-604583107c9so41698a12.1; Sat, 24 May 2025 10:47:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748108857; x=1748713657; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qTp4yJzrpEAf36Dg0kswN0Ez0D2ZNwqFBQu1Ab6aMnA=; b=Doq59GBDb3g7LfFKSdUtjBOLZ41oxOnuYkyRVUiMaZk/1VpH8BGa7le8DO1QUWi9J6 c2CI+nak1SQRMsBHoNk/j3Rn0BMK6gSdyiNJZcgBZLeJsQp/UZoqMQBKn3Zx/5L8W8rx bHemxMvoPxmlnVYtD5+vSn2SG3Oz8jBPNyvZEiWyDx/M797Em4ePXDX2acrNDm+rsLIF it7zhfrDYJp7+BuN1NGZneKqpK0RBV4yy/bGIYsPXoR/QP6eUGm4ftSYlrlysdn5eUM6 WzAEhJ0gQPFBn6Eg1kGiY/thslLfIWK4uLdn6s4J7xDBqkcG+60yWmisu//PTKKeKXQq fbIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748108857; x=1748713657; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qTp4yJzrpEAf36Dg0kswN0Ez0D2ZNwqFBQu1Ab6aMnA=; b=R+WN+8dJlIKW7WeThiJ+roACdQVRcLE89U9AZ2K7+bTy24G9H7ACeECpWnmMygMzqv p1UZg1t2QQe+zQ5oIys2Uju66nVVCxprUgcOPEW7lF2mRzd+M3f0xyp4dz7a1lo7nZce 2c76BCOLx4Kb4T8UuqMoMrBT36F0rak2wZOkWY7bOZM+WWXB29Hg+OuBx5KOavZvtApG yC2KlIeXmokIRxx4humEMjZSX11twQCgZ3efGpfpQkNuM9VpRi62HyfntH0NQDl1wd+L Fww/A7J/JiDswch3pnHsgP/GxlkfcdrEWlEWbsmBy58QI7zOCXKPovBK9KBPc8mVzm2z UPrQ== X-Forwarded-Encrypted: i=1; AJvYcCVWCjiAKnGKqtGymQrOUI6YbNGDu41EP6GU/5hfb9TgmAZ+vR+q+Gr3tLJfa++tN7A7E1uWfR+opYHb5g==@vger.kernel.org, AJvYcCXyyqi1wic9IwkKSeIAnMwUTQSx04+kc49gAG2NEabmfoobA1Xup9ybqnYYmPxNV3i9HZ0gMbuTwjMI@vger.kernel.org X-Gm-Message-State: AOJu0Yw8dJQ6kQICMz9XRUR3nqZtsOMduyaKnPDwPUIJ+XiRERtjwg8y xFzJTfNnJkkqgjt9HRf2Zs/Pbv/z4qTrJ5EMrb7dz3hwA0g694Xmh91jWcVncA== X-Gm-Gg: ASbGncuvFsbwdOwUOrOLKAMmcBjvIQ8j727mLINV8vUic03wBkdkei3xQGQ9nRT/r3J EO6l6+RYPALtbU+W9bOFZXP1X9x9t5d8GJgRzTP5vTBmQNsDC7W42Rnq2QnKkop5ZMkOG2AQhBZ 6kzjRAZDz8aAjlEce0PQMRFed1cNhjs/lBJWO8iA44qkuq+qQRzbOc3AssW5ypLqS5P/RKwHHAD peBDHuDOMaSA6CmY2pt4X+I9PS5qKa0ydLDyfqMcU9noa7wdEo52MDRuFFDDz341GU+hjTm4GiN R8XOCvLHZq3McSiAAtJI60wojVQTQh0aAnBwK8NMXofnmQ5s9YQXAo3GL4B+8aaqcw== X-Google-Smtp-Source: AGHT+IFh/1YhdOhvyRdRQV0WancP9s++sWPxCtKHk3dD1D8TocPQ7CfEIuctsg7Y5aEW3ehDowG64Q== X-Received: by 2002:a05:6402:26c3:b0:5f6:261e:db8c with SMTP id 4fb4d7f45d1cf-602da0ed590mr1055021a12.4.1748108856677; Sat, 24 May 2025 10:47:36 -0700 (PDT) Received: from laptok.lan ([89.64.31.142]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-602f11a0e0fsm1138789a12.13.2025.05.24.10.47.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 May 2025 10:47:36 -0700 (PDT) From: =?utf-8?q?Tomasz_Paku=C5=82a?= To: jikos@kernel.org, bentiss@kernel.org Cc: oleg@makarenk.ooo, linux-input@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH v2 10/11] HID: pidff: Add missing spaces Date: Sat, 24 May 2025 19:47:23 +0200 Message-ID: <20250524174724.1379440-11-tomasz.pakula.oficjalny@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250524174724.1379440-1-tomasz.pakula.oficjalny@gmail.com> References: <20250524174724.1379440-1-tomasz.pakula.oficjalny@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Fixes checkpatch.pl errors Signed-off-by: Tomasz Pakuła --- drivers/hid/usbhid/hid-pidff.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c index 0e19d61f4936..a07c5efddbe4 100644 --- a/drivers/hid/usbhid/hid-pidff.c +++ b/drivers/hid/usbhid/hid-pidff.c @@ -243,9 +243,9 @@ static u32 pidff_rescale_time(u16 time, struct hid_field *field) int exponent = field->unit_exponent; pr_debug("time field exponent: %d\n", exponent); - for (;exponent < FF_TIME_EXPONENT; exponent++) + for (; exponent < FF_TIME_EXPONENT; exponent++) scaled_time *= 10; - for (;exponent > FF_TIME_EXPONENT; exponent--) + for (; exponent > FF_TIME_EXPONENT; exponent--) scaled_time /= 10; pr_debug("time calculated from %d to %d\n", time, scaled_time); @@ -569,7 +569,7 @@ static void pidff_set_device_control(struct pidff_device *pidff, int field) hid_dbg(pidff->hid, "DEVICE_CONTROL is a bitmask\n"); /* Clear current bitmask */ - for(i = 0; i < sizeof(pidff_device_control); i++) { + for (i = 0; i < sizeof(pidff_device_control); i++) { index = pidff->control_id[i]; if (index < 1) continue; @@ -620,7 +620,7 @@ static void pidff_fetch_pool(struct pidff_device *pidff) struct hid_device *hid = pidff->hid; /* Repeat if PID_SIMULTANEOUS_MAX < 2 to make sure it's correct */ - for(i = 0; i < 20; i++) { + for (i = 0; i < 20; i++) { hid_hw_request(hid, pidff->reports[PID_POOL], HID_REQ_GET_REPORT); hid_hw_wait(hid); @@ -851,7 +851,7 @@ static int pidff_upload_effect(struct input_dev *dev, struct ff_effect *effect, case FF_INERTIA: case FF_FRICTION: if (!old) { - switch(effect->type) { + switch (effect->type) { case FF_SPRING: type_id = PID_SPRING; break;