From patchwork Mon May 26 10:49:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 892790 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B12B51F5423 for ; Mon, 26 May 2025 10:50:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748256607; cv=none; b=q2UUNCs4OXw+XC8yeRSIj56jyA+RVoATjJHZdfVCF7/vj0lK5hUvNzmPRc+6jo9RZ2r+bc4Ar31ATsn60TdasELgcpEwQxHxd6Msh2XWwJ4U8noAEqNT01irE0L3ytoSAuVkd99n3UtlhAmccTW3XhQ2OegdErpq38p5sSNrxMw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748256607; c=relaxed/simple; bh=XGChspJP5I3LQLqq5KcsHIKk69mbsIBA6WisBz3c/1c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LVQ5VgDGz70bMTyNxLnV+2qz2DxmUBwg+StnpgHDyhCYL4IinHxV+VHTF7AAsI76DArw9duyC/KD06r55sT/wYHEpcOtwhxb+gHTzAmxyNFjbTAtTCxTewukKfXweHJ3aBU/cK5IssJ6ELK0EKADGatVq3OL0fzF8NSKHpmIfMQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=oFuxcXNc; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oFuxcXNc" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-43d72b749dcso3633255e9.1 for ; Mon, 26 May 2025 03:50:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748256604; x=1748861404; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=qFXCm+Uh4tsObSJSuPLxOgv+0sGR9msvlsEdl0EYMLI=; b=oFuxcXNcc/xdNE57fPwx+5yg/aFrR2NQLLRslgRt6M0ulVYPUPHySHyqOvMmWw4PRG GTVcAz2luafG934MDWPjedSuhmHS6tCZExIOgo/7ZwuVLYRluv6wH8I3gAinhfPEhQgS hgcpIioEYfLdTUunBvnUrAGUUbuloGhYGdGLyNUvO6rJeMq+k+vJiBvSaUthEbTVhwL3 JAPcMNKme9JXoWqxAExUx8OJ9EYb8lyYuvBkV+wfVmeSWNVzZJkIv8iV7nejvKQKfYUf /ouSCb1TDWo/+IJzx70BDPJE/2qm4i7tBmuDLfEfQ7zRTrbrxYcorm4YYf53S6cAddNU jInA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748256604; x=1748861404; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qFXCm+Uh4tsObSJSuPLxOgv+0sGR9msvlsEdl0EYMLI=; b=pFOpiXadQ/9Fd8sMNg5lzElcS5c1Ro3QU2Y7EMdypxQ+lD+TVUZs96PFlVJCCQnsrP rcES4S+I9i96yqStAQhQPEeT+a1Mf2as8zMGvf2w3deH5De2VGM5ujvKXVs3CD+nx46A 5Ags1IUhIZxJJR6/jdnkOeN9O3qq6RTY9uefQml3EegOehmpDIhSx+g+ewJy9ddZJ7qu 4L2ZiyJd4UACgAFIbqZsQ0BNXqhauVKfpHfPyhklFZuNV6Y9pZviz6pZKm/r8AzOThAm +CBg/7pknjrrxe8pvzXAA6RYSRWlLg+SQ4dVB/BQK4lofbUra+RLuT0R5nWRYE9kL37n 94SQ== X-Forwarded-Encrypted: i=1; AJvYcCWcoV7S8yZD4kZEhWm0KeM47kr8lP1NSrlURzBs6qkXOSiPw5zMX0/361/vt1f413PmxCc1HV22rPaQGoIR@vger.kernel.org X-Gm-Message-State: AOJu0YyWsZd7XPOTDTIfC/83yhCQJws9wcdqbx7nF78yOUSdEuQMltgR F6MUxR5YObFxiScVD234Zq6Pl/N3/M6WRb1W3HRI+kz8NuZ+8wWvCBqp9Qwo8abg8U8= X-Gm-Gg: ASbGnctWSglPtMPbzzubchNyN9scA6OGpGhZzb6CZLRL99wIEdFyDSyFSGgs+HPqned kJggYnMamPIWGNq6ySby4u2kX//wDsQss4mxVSWQ92qV4habVxZtXQD7raCIBNBXr9uXwIFscCb klxrT1oHbiUuROWiiYcT2Fjx5RKRpzI7VD55ZF8idcLe+iT2ITXS4PGcoDQFjcicWvCej2+51E+ N0Z54psEnETn312Qs91gScQ4lVUvGEF4AqT+jutT4tIJXGMfK6YM1tGLNCV55HX6tT9CDJMrO5V dMWqKd57pQlubzJrQYucNe/uMRZXkPWrdjQzU+9unxneDehkXYeJc8IynZmn9UDkBdmatxc= X-Google-Smtp-Source: AGHT+IHYHftMvEfeiSKYWstcFFrN43xpqYIuFKIcRUyEfc0gwSeBaOs0vjH9Mu5CZOZZ/7pihewLcw== X-Received: by 2002:a05:600c:314f:b0:43d:fa58:81d2 with SMTP id 5b1f17b1804b1-44c939c15b7mr24735175e9.9.1748256604027; Mon, 26 May 2025 03:50:04 -0700 (PDT) Received: from [192.168.1.29] ([178.197.223.125]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-447f73d4b68sm236337215e9.23.2025.05.26.03.50.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 May 2025 03:50:02 -0700 (PDT) From: Krzysztof Kozlowski Date: Mon, 26 May 2025 12:49:50 +0200 Subject: [PATCH 1/6] ASoC: codecs: wcd937x: Simplify with devm_regulator_bulk_get_enable() Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250526-b4-asoc-wcd9395-vdd-px-v1-1-64d3cb60313b@linaro.org> References: <20250526-b4-asoc-wcd9395-vdd-px-v1-0-64d3cb60313b@linaro.org> In-Reply-To: <20250526-b4-asoc-wcd9395-vdd-px-v1-0-64d3cb60313b@linaro.org> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Srinivas Kandagatla , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3852; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=XGChspJP5I3LQLqq5KcsHIKk69mbsIBA6WisBz3c/1c=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoNEdSNq1JlnADTyFmOYOva9S2yE0qZLeRmm4Ke fgfaCsJr2OJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaDRHUgAKCRDBN2bmhouD 11J6D/9AQADKnL5YeUoI8wafKTT22RpydZbuOjd0qKPDS3tzMmFKm1DhAr6ZUeFLfGbusE3Y2wC OC/4r9LWc7yKKAF2cZpQtQC9/s1FTB1g9rUrreSKKH+1X11uoJsfgJva2VN0rkUIm97G3MuguE4 U3GxzF/ExBW/ES5cCfThYZ8ABKxHrp2CdcLYu6ofFKKyd+epTFjI/196h+CVSdZVkFEHnxlUfz8 dHqpAz5wbGvwooH9fSME3CpZTqMxLzjYjfSJVet4lfLPR2Oyxps6KTUYnCiEAJeSZ9dMIywnNhF s6B3uvNgPd1Cr36Rve/zTIuY8MlIqjAxLLt1+X5c5qtn8Kz+j7gAaUSoLiaDxu9H+bAVVKk0Svl CkKVahcAvhU9RmDpmi9zYdaSkZSqoEuUd80vCw7PoM1F8321hBSdDK3rgH0gKMQu6rFbRSrhPP7 4o3xlPkhL2yOS5UPmMXU/aCAMSpc+XTSk0otabTcgJFgbeZIVbcpuaFhM2/PlNb3l7QTzu9Dq+h 7g6aWxVKofxbKpQsr4yqVJuGiXMhQEV5vCW1iGtqBfRXgkce8fdULzZ6nxXNN+5AfdJjiqa+1tH WE4R+OgaBl2oNLDuku6bU5Y3UNJfIdV0pTO6z12Gk3rvYHIW5yhkbSXw4Vdu2fBkP28Ko6v5stA vO5g48qsQ9i2FwA== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Drop separate regulator get and enable in probe() path with devm_regulator_bulk_get_enable(), which simplifies cleanup paths and device remove(). Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/wcd937x.c | 31 +++++++++---------------------- sound/soc/codecs/wcd937x.h | 1 - 2 files changed, 9 insertions(+), 23 deletions(-) diff --git a/sound/soc/codecs/wcd937x.c b/sound/soc/codecs/wcd937x.c index b9df58b86ce953427e01ffb8c7eb7e52f9c2392a..92765a8693fbf87e2ba53fef75657ffb1b5fdb8f 100644 --- a/sound/soc/codecs/wcd937x.c +++ b/sound/soc/codecs/wcd937x.c @@ -90,7 +90,6 @@ struct wcd937x_priv { struct irq_domain *virq; struct regmap_irq_chip *wcd_regmap_irq_chip; struct regmap_irq_chip_data *irq_chip; - struct regulator_bulk_data supplies[WCD937X_MAX_BULK_SUPPLY]; struct snd_soc_jack *jack; unsigned long status_mask; s32 micb_ref[WCD937X_MAX_MICBIAS]; @@ -113,6 +112,10 @@ struct wcd937x_priv { atomic_t ana_clk_count; }; +static const char * const wcd937x_supplies[] = { + "vdd-rxtx", "vdd-px", "vdd-mic-bias", "vdd-buck", +}; + static const SNDRV_CTL_TLVD_DECLARE_DB_MINMAX(ear_pa_gain, 600, -1800); static const DECLARE_TLV_DB_SCALE(line_gain, 0, 7, 1); static const DECLARE_TLV_DB_SCALE(analog_gain, 0, 25, 1); @@ -2934,18 +2937,10 @@ static int wcd937x_probe(struct platform_device *pdev) cfg = &wcd937x->mbhc_cfg; cfg->swap_gnd_mic = wcd937x_swap_gnd_mic; - wcd937x->supplies[0].supply = "vdd-rxtx"; - wcd937x->supplies[1].supply = "vdd-px"; - wcd937x->supplies[2].supply = "vdd-mic-bias"; - wcd937x->supplies[3].supply = "vdd-buck"; - - ret = devm_regulator_bulk_get(dev, WCD937X_MAX_BULK_SUPPLY, wcd937x->supplies); + ret = devm_regulator_bulk_get_enable(dev, ARRAY_SIZE(wcd937x_supplies), + wcd937x_supplies); if (ret) - return dev_err_probe(dev, ret, "Failed to get supplies\n"); - - ret = regulator_bulk_enable(WCD937X_MAX_BULK_SUPPLY, wcd937x->supplies); - if (ret) - return dev_err_probe(dev, ret, "Failed to enable supplies\n"); + return dev_err_probe(dev, ret, "Failed to get and enable supplies\n"); wcd937x_dt_parse_micbias_info(dev, wcd937x); @@ -2962,13 +2957,13 @@ static int wcd937x_probe(struct platform_device *pdev) ret = wcd937x_add_slave_components(wcd937x, dev, &match); if (ret) - goto err_disable_regulators; + return ret; wcd937x_reset(wcd937x); ret = component_master_add_with_match(dev, &wcd937x_comp_ops, match); if (ret) - goto err_disable_regulators; + return ret; pm_runtime_set_autosuspend_delay(dev, 1000); pm_runtime_use_autosuspend(dev); @@ -2978,25 +2973,17 @@ static int wcd937x_probe(struct platform_device *pdev) pm_runtime_idle(dev); return 0; - -err_disable_regulators: - regulator_bulk_disable(WCD937X_MAX_BULK_SUPPLY, wcd937x->supplies); - - return ret; } static void wcd937x_remove(struct platform_device *pdev) { struct device *dev = &pdev->dev; - struct wcd937x_priv *wcd937x = dev_get_drvdata(dev); component_master_del(&pdev->dev, &wcd937x_comp_ops); pm_runtime_disable(dev); pm_runtime_set_suspended(dev); pm_runtime_dont_use_autosuspend(dev); - - regulator_bulk_disable(WCD937X_MAX_BULK_SUPPLY, wcd937x->supplies); } #if defined(CONFIG_OF) diff --git a/sound/soc/codecs/wcd937x.h b/sound/soc/codecs/wcd937x.h index 4ef57c496c37c555c8684d65249c53f6a8b645a1..3ab21bb5846e2c85520d67e7dc248d4e7715dba5 100644 --- a/sound/soc/codecs/wcd937x.h +++ b/sound/soc/codecs/wcd937x.h @@ -487,7 +487,6 @@ #define WCD937X_MAX_REGISTER (WCD937X_DIGITAL_EFUSE_REG_31) #define WCD937X_MAX_MICBIAS 3 -#define WCD937X_MAX_BULK_SUPPLY 4 #define WCD937X_MAX_SWR_CH_IDS 15 #define WCD937X_SWRM_CH_MASK(ch_idx) BIT(ch_idx - 1) From patchwork Mon May 26 10:49:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 892642 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F17D1F7075 for ; Mon, 26 May 2025 10:50:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748256608; cv=none; b=jip7yO8iUL5j4KE+uG55chszrmJoCUdI+V4xpEmpD0dn9HLz4JKwXLgf3WFSJrR6ZRBNaEfCG+1zBi+LI+AbnfPnJg6q63eEEtRQBuIFq6ng2pPt8VMUqD/OLTg+/dLssLbFXaZ71rvChqkSszaL3ddp+IroCPj3k6bhrrq0zIc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748256608; c=relaxed/simple; bh=FX2ZFjqB2aYhVdKNptGSxqmvCuZ9hZy30zaZX4GDw44=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mynIV9FCaKq81Kz4sRaRU0a4CRelvh8HEZqEbIUHNMcdmTDSgHKTkkrZ5vCE74MR9QNzjNV1sR2gz6Xegt587OSRK1Ijd5OgbLXa7MBJuL/b1qFlW9VM2E7tkYrt5DlukBqiS4onV7t7Z31r6urKb+gs4QrsA+ukJiux/mgoxP8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=aGj5T5na; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="aGj5T5na" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-43d4ff56136so3837585e9.3 for ; Mon, 26 May 2025 03:50:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748256605; x=1748861405; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=6OBa2xDaiXmKdEIq6qhKC9jrSr7c++QZFJ/xALZlOQ4=; b=aGj5T5nay07zznx8pR8v0dhboSodH1SsYkGEHtkYnkfJ4qIx+jrW9GT2sM2DFG/4HL 1CqzqPBJ7VMlaQwgVApNUww9d13ZS5PF6eKdgXJnuoCvlG5sDygrKrPwSscwlYUQrcCH msEvHED8ep5B77EEEEBImxFegE24jXNQrt5ND2/jn/OlPIhp0Ge/klfhjR+rhHtOtkfF /VedZBPyCFCQrvg9YdfaDxwhAkcwM4td2wpKW+2qz6JVQDteTHf6gmoELUWu5Ce0jiob KX3HL+oxCxjo04RAS1eVihxFt9ZQVgrZk7LLZUTawZIeI4fZkGvRp7mLf3N74kZMaocC yeZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748256605; x=1748861405; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6OBa2xDaiXmKdEIq6qhKC9jrSr7c++QZFJ/xALZlOQ4=; b=OJSsS3YcqS7vuAx/ge5/HHgMzfP5ICQwJ1Zw5noozzxEasrnX0osAw53BESk2MAmmW jrFXFshjz3NiH0e2uAPoGQGmW5pz3yNQMs2h/dqKWRPb4qy7wN++G2RwMl2FbUsot4u3 L8hjQn0OqVvQ9lj+dbDFioKWZYVjoqz6IdVPhr9SNbnjIjaQJb29NpgWzIo+MC4q0xBz Bnm14OftI8EvFlJE9dep7RZaotm36kaSZs4ACh4u+7gpjtLK3r9AQInbF4dTQbrx5IMh YXgv66nmwJTBsmaDSSYixdoxpRd2E4OJMODRYTOp76xEqqDxbAge00xN6TIRJs5dgi2B mqBA== X-Forwarded-Encrypted: i=1; AJvYcCVtIxawm4Jf9qF8RS5jdjq3rVRuFXeJ6ZS5ENC1CbdJdn5iYCahzyVeBFrmhNTGEl+/Rb+0APcz/z/7GnUt@vger.kernel.org X-Gm-Message-State: AOJu0Yxi4mq9DgHwo60IQdKugp4glmd+O1x5HuO3XqEr1DoMql0zNY0+ jwNh2yThF2NlHPhCx3MtXYtTmHl6jABsZwyvbFM3CEzcrIt3sIJGNpQGbnNfBylIdTc= X-Gm-Gg: ASbGnctPGOsu0cFzJdg5xnPxaQSMSl39MAvgpKkMgPWh8z5ajCnMa4LAN/4n0miO7o+ 7xtdQWZzg/Ve3Ccg2QykdtNEWPIbMh3onmcBDUVUCMJyz2QehwI22qY5wgIqz9VFh4yPoXdUF/J xSw3tpsiOcoO3Af3QXYFcxN49qMhM9Bs10VrORcxfwVUKxdhF0aj9F1jBOPS6RumyVOUSPnhPCF dzXwm69clHn89nHfRiOF8Qx8zC2n9EgSUacIQUw0eyoVkSKS8vfauSdAU+YsxQVEaEHKU7LL6iv DqMgD3iOEVdlnxhn8NCgaw6YYhFoxwsheuyVVTYBkMUkY0EeLXlzmkvtStbQiOuAS2XerDGyjzY Atx2ELw== X-Google-Smtp-Source: AGHT+IFSOavn4OiSrSRdrm9EzdjRM1GrZSVArSnm26/rNTPuIKZdeK4R3ePwvsxF952fDQYtmip+zg== X-Received: by 2002:a05:600c:314f:b0:43d:fa58:81d2 with SMTP id 5b1f17b1804b1-44c939c15b7mr24735485e9.9.1748256605290; Mon, 26 May 2025 03:50:05 -0700 (PDT) Received: from [192.168.1.29] ([178.197.223.125]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-447f73d4b68sm236337215e9.23.2025.05.26.03.50.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 May 2025 03:50:04 -0700 (PDT) From: Krzysztof Kozlowski Date: Mon, 26 May 2025 12:49:51 +0200 Subject: [PATCH 2/6] ASoC: codecs: wcd938x: Simplify with devm_regulator_bulk_get_enable() Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250526-b4-asoc-wcd9395-vdd-px-v1-2-64d3cb60313b@linaro.org> References: <20250526-b4-asoc-wcd9395-vdd-px-v1-0-64d3cb60313b@linaro.org> In-Reply-To: <20250526-b4-asoc-wcd9395-vdd-px-v1-0-64d3cb60313b@linaro.org> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Srinivas Kandagatla , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3617; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=FX2ZFjqB2aYhVdKNptGSxqmvCuZ9hZy30zaZX4GDw44=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoNEdT4SZiF025Slz7VB0w5N98QbFUA1zL2sYW3 aTRyW0ou9iJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaDRHUwAKCRDBN2bmhouD 1ymHEACD9dNrF5rGR+clcwGAMbhlbQKPvqR1x/XZrLX52FjAlS2Xm+SHUaHY6J38Y1vQaabhg5V URL5gaSkQEKGg20/QEZyFE7HPlWPhuPxqFsESzHfDQ+AqqCdsm1MkJbYnSeRfQ6q4A4UpqT6KwT iXPD0s8LES8fbpHLe3sEX0FE2RTmScWPBwbXo38Y8wFaJK8UcawkOQyFGL2jVbTknNi5pF0N1pz 40cSXezzh1ajx+7A/UcyvtN/Ki/AJLdMCF0Wzf1o/OEo/UUVoscDYExfZvCX3CwrSe6gohL+7/v 0u15LRbO7Iyp44OdB5jbq4WyNTrpYf8StE6rUsa2hGPC2Cxj6r3jd1GIjhkj+tC5HbPamB4jyRn 4g59xkDysKF7f4H4QJNrshH/AcQxwniurhYatLxTvbCL3x6EOwOwk1gbWz8MoX9Cl03ANV6zZ3o +2p6vN4E4i76zujMGBu7yM4gcbD9zEbKpwErt/v6TFD1N/UsHoU7uvzFagpMe7p8DHUVB07NAKa TbQ76qbV9ELcZVifL/uKPCrDKJs9IQrWUfj81j2ZWfiVeFZel1/QWQKFs/mVoFE6Z1a/SvK9uHK Ydbmsi87xMe+U989Gd4w6tOeyVjraXep06d6AfR8fE+q4b2OpnpViziFW3lkXProDFir1gUakys STMQ5yoE0ABiFTw== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Drop separate regulator get and enable in probe() path with devm_regulator_bulk_get_enable(), which simplifies cleanup paths and device remove(). Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/wcd938x.c | 35 +++++++++-------------------------- 1 file changed, 9 insertions(+), 26 deletions(-) diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c index b72dcd9d01720f44550d6e438498a2e7eab6dc1a..72c36c6138e1f0e33d5acb3972aa26f7d2dd9b22 100644 --- a/sound/soc/codecs/wcd938x.c +++ b/sound/soc/codecs/wcd938x.c @@ -26,7 +26,6 @@ #include "wcd938x.h" #define WCD938X_MAX_MICBIAS (4) -#define WCD938X_MAX_SUPPLY (4) #define WCD938X_MBHC_MAX_BUTTONS (8) #define TX_ADC_MAX (4) @@ -161,7 +160,6 @@ struct wcd938x_priv { struct irq_domain *virq; struct regmap_irq_chip *wcd_regmap_irq_chip; struct regmap_irq_chip_data *irq_chip; - struct regulator_bulk_data supplies[WCD938X_MAX_SUPPLY]; struct snd_soc_jack *jack; unsigned long status_mask; s32 micb_ref[WCD938X_MAX_MICBIAS]; @@ -188,6 +186,10 @@ struct wcd938x_priv { bool mux_setup_done; }; +static const char * const wcd938x_supplies[] = { + "vdd-rxtx", "vdd-io", "vdd-buck", "vdd-mic-bias", +}; + static const SNDRV_CTL_TLVD_DECLARE_DB_MINMAX(ear_pa_gain, 600, -1800); static const DECLARE_TLV_DB_SCALE(line_gain, -3000, 150, 0); static const SNDRV_CTL_TLVD_DECLARE_DB_MINMAX(analog_gain, 0, 3000); @@ -3293,20 +3295,10 @@ static int wcd938x_populate_dt_data(struct wcd938x_priv *wcd938x, struct device cfg->swap_gnd_mic = wcd938x_swap_gnd_mic; - wcd938x->supplies[0].supply = "vdd-rxtx"; - wcd938x->supplies[1].supply = "vdd-io"; - wcd938x->supplies[2].supply = "vdd-buck"; - wcd938x->supplies[3].supply = "vdd-mic-bias"; - - ret = regulator_bulk_get(dev, WCD938X_MAX_SUPPLY, wcd938x->supplies); + ret = devm_regulator_bulk_get_enable(dev, ARRAY_SIZE(wcd938x_supplies), + wcd938x_supplies); if (ret) - return dev_err_probe(dev, ret, "Failed to get supplies\n"); - - ret = regulator_bulk_enable(WCD938X_MAX_SUPPLY, wcd938x->supplies); - if (ret) { - regulator_bulk_free(WCD938X_MAX_SUPPLY, wcd938x->supplies); - return dev_err_probe(dev, ret, "Failed to enable supplies\n"); - } + return dev_err_probe(dev, ret, "Failed to get and enable supplies\n"); wcd938x_dt_parse_micbias_info(dev, wcd938x); @@ -3570,13 +3562,13 @@ static int wcd938x_probe(struct platform_device *pdev) ret = wcd938x_add_slave_components(wcd938x, dev, &match); if (ret) - goto err_disable_regulators; + return ret; wcd938x_reset(wcd938x); ret = component_master_add_with_match(dev, &wcd938x_comp_ops, match); if (ret) - goto err_disable_regulators; + return ret; pm_runtime_set_autosuspend_delay(dev, 1000); pm_runtime_use_autosuspend(dev); @@ -3586,12 +3578,6 @@ static int wcd938x_probe(struct platform_device *pdev) pm_runtime_idle(dev); return 0; - -err_disable_regulators: - regulator_bulk_disable(WCD938X_MAX_SUPPLY, wcd938x->supplies); - regulator_bulk_free(WCD938X_MAX_SUPPLY, wcd938x->supplies); - - return ret; } static void wcd938x_remove(struct platform_device *pdev) @@ -3607,9 +3593,6 @@ static void wcd938x_remove(struct platform_device *pdev) if (wcd938x->us_euro_mux && wcd938x->mux_setup_done) mux_control_deselect(wcd938x->us_euro_mux); - - regulator_bulk_disable(WCD938X_MAX_SUPPLY, wcd938x->supplies); - regulator_bulk_free(WCD938X_MAX_SUPPLY, wcd938x->supplies); } #if defined(CONFIG_OF) From patchwork Mon May 26 10:49:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 892789 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 572F31F91F6 for ; Mon, 26 May 2025 10:50:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748256611; cv=none; b=tSd60j2Hz6jhwzobFS3AuyDvDtLd/Km6BhO8o+NSOpuNmeC5RNlMMOXlGXShc+Ynnoxg5cHYAdCdyGOWj9IjxDeQY14JOXM48XsKW0BE87BtfY8wWuXKDbge/tzTmv+l8/26uMbMmDkFbkI2tNc5bRYmUU7Ew67B4W2/0V9UshM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748256611; c=relaxed/simple; bh=T1UmHGMEhh+HGHkTKffRpGf8EB6LiXyuaermIIJZ7Uw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=O2P4wQoDw2z/O/k010Jhh0MRZI0tm9nBqG9D7SsR34yn9vG8jJE8zY/X4B51NQEd9w3GOFMkdHZmGD1pOSDGaKfpv6WvWK9Kp+R/+uSex24ZMsSKXa4NbYrYzZwkHtUE8Jov1sn08zfUWxFIqoJQxeZs6X6lExmgT5HJm80NB8s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Neju5nb2; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Neju5nb2" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-3a4d4504f75so38883f8f.3 for ; Mon, 26 May 2025 03:50:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748256607; x=1748861407; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GxdjNywcZoPk9rUuL+juhOPpZUTe7YyKpdPGQqOg0oU=; b=Neju5nb2tZOt+SIozvcHzX4RASBKqLNxYtLICyFhceHiRRFtr94xmrbQngzJLdvB6Z VEon1oQtLSS9j2Jldt0DZfonizB5BcoPQwxXjlkjuPB93VMoZSQNbpPtIYszg6R/iPS6 k/R+tb42ETk5ZI45EWJURNlMbXUhA+qDhUfDBSMF6P1AfKWqSfgjbzBoz84auxGsuKnD MIfbuGwTuoOxnxG/Td0s+O+UCQ6BYpMHPNz/Uxe3ORtkuGCuEYbcOTqTboOtHeQ/BLvD 1xaAT9A0mu9KziLV3dCvzwUCtnNItMjogBEjJsTWvDTEM+7O5G4Er3bLZs6bqCtSDWmU scjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748256607; x=1748861407; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GxdjNywcZoPk9rUuL+juhOPpZUTe7YyKpdPGQqOg0oU=; b=BJEYG8IqFDNJGFOdjzDgIMDZQwTlIfF/w/58rBP3Pke6/ywRwjVzj0EOKNE4lwbiXk 9C9eImkDm2/ziRJF0yIM2P042r4f9vYbpl8qVeiG91d22FOO5YPRUO5q+YcAal0RVJMH 8XaMnTPZoSBg9QgC6IVEN21AEPk0sCZ6S+8ncM9GutE50WK8Iq3uwOaK4Wv0wnoafg5P fdRukXBONAQBK2DHRG3xb028OzjT8lPNa5hiFYb6ptL9QyZZtEVpI9RCaIml4WRApbhb GIq0WbMHJlIWeRcmjm2vx8QL4GVHzEzpidVbCHMG8W52WOhXHosI52NwIEVp6wzslhLB O04A== X-Forwarded-Encrypted: i=1; AJvYcCUCkSGADszKgdSDo6FS+ixOZKa2lPW+1t2w0hKqm30OTITwRGqUQByvcoGr5OREcPQgiCTXhvClVFMMiOv4@vger.kernel.org X-Gm-Message-State: AOJu0YxEn4FBVzh6uwH1lu5w6h13pyCJvVoY9KRJQcMQ2nWVyhPKMA/a +KKSdXz3TSQLFMxc+UN05C08ywgi5Bxa+ZYWYv2ko/XkZvqF7rq7DGFluEyfUrr5dsk= X-Gm-Gg: ASbGncsPdAZ7UpxGE3gG0gTdNiHAv2KV0tITzA6AXsSRdpw6QV9R64f6IwiAC0gw1QE DtcwRWorysNwP/zC5dnSOPGOCssbRLj/MBI0c3Z6WRXaAbHnJZB5FZhQGlElrqRJUBgHYipDGJ8 Bvlx04/VUQwdWK3CsU50if1Y9WojlQj4W37kjj3fIPmUclgDi2UxqpGkDD9YZV4Am2jPsPcOVeJ B6nKc2AS+cPzYW8PnduByRzrZwjtEDVMAQDjxgZy4Sh2ab2xhiqArxqtqI8KkuduS6Sr7D4GniL yXdqkKoqvZP4ei67/59HkfzrPWKCbPCMMfI9Yc1aU1IGlcPzWvwu40BQg2V/CXN+0AqOjn4= X-Google-Smtp-Source: AGHT+IGkrJ9NILdheV9RaN0QoLBtP4gK+AfGXmY1/vtQ2GjEgvHeVOK+paC1IUjYwHzNeti95HpQHQ== X-Received: by 2002:a05:600c:c0c3:10b0:439:94f8:fc7b with SMTP id 5b1f17b1804b1-44c90f4ccb1mr16989275e9.0.1748256607476; Mon, 26 May 2025 03:50:07 -0700 (PDT) Received: from [192.168.1.29] ([178.197.223.125]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-447f73d4b68sm236337215e9.23.2025.05.26.03.50.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 May 2025 03:50:07 -0700 (PDT) From: Krzysztof Kozlowski Date: Mon, 26 May 2025 12:49:52 +0200 Subject: [PATCH 3/6] ASoC: codecs: wcd939x: Simplify with devm_regulator_bulk_get_enable() Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250526-b4-asoc-wcd9395-vdd-px-v1-3-64d3cb60313b@linaro.org> References: <20250526-b4-asoc-wcd9395-vdd-px-v1-0-64d3cb60313b@linaro.org> In-Reply-To: <20250526-b4-asoc-wcd9395-vdd-px-v1-0-64d3cb60313b@linaro.org> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Srinivas Kandagatla , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3822; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=T1UmHGMEhh+HGHkTKffRpGf8EB6LiXyuaermIIJZ7Uw=; b=kA0DAAoBwTdm5oaLg9cByyZiAGg0R1SjimkbkrXTp9xVvToa/7VuiXtcbsL/56oXOJnkwQ4nc okCMwQAAQoAHRYhBN3SYig9ERsjO264qME3ZuaGi4PXBQJoNEdUAAoJEME3ZuaGi4PXRKkQAIfo lSkuJhxgpdvo/1nZJ+/ngiqYillnf6Sw/lcFW7C1/Q87Zfu/Xz/6BReObA9Ry6mYhUDatZX4xhb sRQeNiXUcaJXiB2iV0FK960+gkdAilI0tS93SBXKvjegzbE6eNHWeKb+RtPZZ1VdCJBiiM8PHdA jyEuR95vUrbKFKTM5F6XCsFyAj1qRaR9abB74bYOAHou2Yp/nt2C9nE3TnaXW0UIo1yZPOm3rxA d83a+uKrGctHpm9Zp4kYVpOdAnLTH1IXr3JrQD0vKJ5APqRjdxbih9t3gs3M2gzmSceUSXuYOke NBAimw2CTRr2nr9+HXZhcOLqqEq9kvsCAJU0BhGKU6XNR5662SGDQCuIwMpM8+rMtd6ewxqW9BJ eq8JZtqEdBztEQxBv3G9OpDuQhl2J81gVweESupWIOZq3/cT0PedZJO64okYIBeoVXG5haN9KgI XKRYjAWz6Bbzc7Myul8vH3kRZ6VW8aOd31xkzijIlmrgkCDnYHvl0iF//y2VybZZrsO4XUg5CnP lxzluqcLap6Yh5UN6VtarEzf8W2/B22KUyp8wf0sv/4lPWRbzE/uJNqLsCOKnf6P0xkpDXiABcF TIAkd+NaYv3aEqgCnVE0ukrdJPBMAiAivd1/APHPFJl4rn127OGN2Mvg+fwBOePwW6UprsP4cRg aLJa/ X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Drop separate regulator get and enable in probe() path with devm_regulator_bulk_get_enable(), which simplifies cleanup paths and device remove(). Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/wcd939x.c | 38 ++++++++++---------------------------- 1 file changed, 10 insertions(+), 28 deletions(-) diff --git a/sound/soc/codecs/wcd939x.c b/sound/soc/codecs/wcd939x.c index 067d23c7ecf90ae06da1ad6cc89d273fb7f7f875..95cd88a37acb5ef455d4a40948284ae45e2dfb28 100644 --- a/sound/soc/codecs/wcd939x.c +++ b/sound/soc/codecs/wcd939x.c @@ -32,7 +32,6 @@ #include "wcd939x.h" #define WCD939X_MAX_MICBIAS (4) -#define WCD939X_MAX_SUPPLY (4) #define WCD939X_MBHC_MAX_BUTTONS (8) #define TX_ADC_MAX (4) #define WCD_MBHC_HS_V_MAX 1600 @@ -192,7 +191,6 @@ struct wcd939x_priv { struct irq_domain *virq; struct regmap_irq_chip *wcd_regmap_irq_chip; struct regmap_irq_chip_data *irq_chip; - struct regulator_bulk_data supplies[WCD939X_MAX_SUPPLY]; struct snd_soc_jack *jack; unsigned long status_mask; s32 micb_ref[WCD939X_MAX_MICBIAS]; @@ -213,6 +211,10 @@ struct wcd939x_priv { bool ldoh; }; +static const char * const wcd939x_supplies[] = { + "vdd-rxtx", "vdd-io", "vdd-buck", "vdd-mic-bias", +}; + static const SNDRV_CTL_TLVD_DECLARE_DB_MINMAX(ear_pa_gain, 600, -1800); static const DECLARE_TLV_DB_SCALE(line_gain, 0, 7, 1); static const DECLARE_TLV_DB_SCALE(analog_gain, 0, 25, 1); @@ -3244,20 +3246,10 @@ static int wcd939x_populate_dt_data(struct wcd939x_priv *wcd939x, struct device return dev_err_probe(dev, ret, "Failed to get reset gpio\n"); } - wcd939x->supplies[0].supply = "vdd-rxtx"; - wcd939x->supplies[1].supply = "vdd-io"; - wcd939x->supplies[2].supply = "vdd-buck"; - wcd939x->supplies[3].supply = "vdd-mic-bias"; - - ret = regulator_bulk_get(dev, WCD939X_MAX_SUPPLY, wcd939x->supplies); + ret = devm_regulator_bulk_get_enable(dev, ARRAY_SIZE(wcd939x_supplies), + wcd939x_supplies); if (ret) - return dev_err_probe(dev, ret, "Failed to get supplies\n"); - - ret = regulator_bulk_enable(WCD939X_MAX_SUPPLY, wcd939x->supplies); - if (ret) { - regulator_bulk_free(WCD939X_MAX_SUPPLY, wcd939x->supplies); - return dev_err_probe(dev, ret, "Failed to enable supplies\n"); - } + return dev_err_probe(dev, ret, "Failed to get and enable supplies\n"); wcd939x_dt_parse_micbias_info(dev, wcd939x); @@ -3629,17 +3621,17 @@ static int wcd939x_probe(struct platform_device *pdev) ret = wcd939x_add_typec(wcd939x, dev); if (ret) - goto err_disable_regulators; + return ret; ret = wcd939x_add_slave_components(wcd939x, dev, &match); if (ret) - goto err_disable_regulators; + return ret; wcd939x_reset(wcd939x); ret = component_master_add_with_match(dev, &wcd939x_comp_ops, match); if (ret) - goto err_disable_regulators; + return ret; pm_runtime_set_autosuspend_delay(dev, 1000); pm_runtime_use_autosuspend(dev); @@ -3649,27 +3641,17 @@ static int wcd939x_probe(struct platform_device *pdev) pm_runtime_idle(dev); return 0; - -err_disable_regulators: - regulator_bulk_disable(WCD939X_MAX_SUPPLY, wcd939x->supplies); - regulator_bulk_free(WCD939X_MAX_SUPPLY, wcd939x->supplies); - - return ret; } static void wcd939x_remove(struct platform_device *pdev) { struct device *dev = &pdev->dev; - struct wcd939x_priv *wcd939x = dev_get_drvdata(dev); component_master_del(dev, &wcd939x_comp_ops); pm_runtime_disable(dev); pm_runtime_set_suspended(dev); pm_runtime_dont_use_autosuspend(dev); - - regulator_bulk_disable(WCD939X_MAX_SUPPLY, wcd939x->supplies); - regulator_bulk_free(WCD939X_MAX_SUPPLY, wcd939x->supplies); } #if defined(CONFIG_OF) From patchwork Mon May 26 10:49:53 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 892641 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70F7E1FC0E2 for ; Mon, 26 May 2025 10:50:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748256613; cv=none; b=sTGuicet1zCKIqIrPOtWTJbxzyLRcU1ox+tcYsqYwdIKGAXkWrKW5MFUexQa3sKqzhV2sul3DbwsKeV/uUdrBmRKQhNsMGqUHzmGDvjqMJ6vtbjSnwDMmTOYhew2dIj2PreIrzc9tth1gY7ADIreqFXv/CFFZPO5QEabmK5pTY8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748256613; c=relaxed/simple; bh=ZrdzTcfjUGSR0yWCXEjXZS0NUv9q8i0Hdkr7tuUh74g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gFZotdnuTzoFT5LB9ukYh/yhhYzsCvAvHbiHA2KUeHyhBQHQFL7w63He6BrG26bx1Af0MPsRBEVa2W41K3iY44EL20MUIR8KnVk1mZjhQZxCkfcnCTj5UKHZXazHIerdb1QZBblW2bbssTjJKB3DF4l4P7buM+vrtwvoQF75OgM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=FrFKl1rp; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FrFKl1rp" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-43cee550af2so460225e9.1 for ; Mon, 26 May 2025 03:50:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748256610; x=1748861410; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=UVQ9CzZhsmaSNU4Qn5Q0sFWe1e8bN4jvT/YOnDNAKJI=; b=FrFKl1rpkeegaeITaVWPs/hoWaMxxZBm46My6D4c0X+v2ejkKel2bRZoJVPl0DNLIM idwXZfdx8XIc6nEqwDCzVfFCEQjK53gl6rlNJJe7uHQCoqpVHcVQV8O87vFPosMcO+gN 70wX6e2jNH2GH8lyRKPYJwQ3uUU/x4xIPMH5EpqP8dMnsfJ9xKPRDJp1nM+S048uS3eK dCRIDVHbO5twQNd7php48c73xADn9UypZY8ifMsxZa0GJ+4aaMANPpOKasEywrAN1ogk nh204lOBaGRBEb1Gy/u4wVhFn7vCtRcPrsnSYgj431F0Gii2Sux5FP4qXGuFcd1FuS6y jjGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748256610; x=1748861410; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UVQ9CzZhsmaSNU4Qn5Q0sFWe1e8bN4jvT/YOnDNAKJI=; b=FtOcesAPGCOe+GzbaZagSckPRb19cMowwWkg5IF6zn/YfQpo9cu42STrJIHgtOj5eh DCeJ8EXup6oonMLZcIdGjz0N2Bmxc0dMLzCQItcyYYtEhfGaR0PXL3EqorGeL9y9KmV7 a51CbLjQIguatUE6JBzEMA7LFhf5CW0NpDFfRcI4oi5nxP9PxhJ3iDG5eTkT0+ifkFl4 LfmPhRa3lRP6NWn1SMoI483dBN/snQo+jUUg0qmzxZ8RTfQNzrvEwtFNqz1redA0HiI3 QQ7dHgBWBLdH5sEqIzNt9Hsp3Q/lskU0vmpi95LryJH/OelZ3m5uE7Zbz/uswGiVLEa8 tFtA== X-Forwarded-Encrypted: i=1; AJvYcCWGtVOFtCsLamcDRj5pJEdQDQ/xmZGgLIleytowurpU3HMNmdmyNmxo2Q+5CtR891zMKLQWuEUVsrIfYInc@vger.kernel.org X-Gm-Message-State: AOJu0Yyw4hObbqcv37JOPa9QhOzB9Bqw/I9/O6oiKyMSELvwQk8LfcJV C8Nuss3vjTrGsFPDjICwgvWS7Cq9czwDZZXwGB/i1W83MVVnTHtgC2usYRRIvBUtksQ= X-Gm-Gg: ASbGncs0GV6rFZhVKIaLuLBACvgdg0Oc86BJ+hNXo5gGmQT5YHOHwamg9DyglzJvhJ1 zzM7feNT+STdKIu3he0a7DUL3WVZLga41s1bAUHcADaqEH3OMdI8m+WsUkMDFqGM9ZX6lSgO0EA ygW+IywvgvCCvLpBb7pvnp2HJE9+Q9KgxQNZuhy31nmRDK9B/pJcTCAEjCk81zg/jtKkR4I+qH1 tltZ4IJiJGQuCLqk5KiTh4TWbKPNmY0P6Ak5maPOBU0s6/VrFPHFIpIHONVvuiEB1AU9foOX/KL D/sSA3I6JEI/BGx156h9/1lSVQtH6ZyWT4C14xmlJtcJ7OICmNF0yMQFZ45s9yG3LD/QCT8= X-Google-Smtp-Source: AGHT+IHOsZcTI7UEfdgo1fLZAipybkP0owKVRNTuB1jpnww6CtR037zAeuvHuyQO/estCgAm7u+9Xg== X-Received: by 2002:a05:600c:1c24:b0:439:9ec5:dfa with SMTP id 5b1f17b1804b1-44c938cb1e6mr28426795e9.7.1748256609774; Mon, 26 May 2025 03:50:09 -0700 (PDT) Received: from [192.168.1.29] ([178.197.223.125]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-447f73d4b68sm236337215e9.23.2025.05.26.03.50.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 May 2025 03:50:09 -0700 (PDT) From: Krzysztof Kozlowski Date: Mon, 26 May 2025 12:49:53 +0200 Subject: [PATCH 4/6] ASoC: codecs: wcd939x: Simplify return from devm_gpiod_get() error Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250526-b4-asoc-wcd9395-vdd-px-v1-4-64d3cb60313b@linaro.org> References: <20250526-b4-asoc-wcd9395-vdd-px-v1-0-64d3cb60313b@linaro.org> In-Reply-To: <20250526-b4-asoc-wcd9395-vdd-px-v1-0-64d3cb60313b@linaro.org> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Srinivas Kandagatla , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1073; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=ZrdzTcfjUGSR0yWCXEjXZS0NUv9q8i0Hdkr7tuUh74g=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoNEdVecFPbjX6JYFFxQlwwYCpkVFzD7vXFrX2D HYU/bWST+CJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaDRHVQAKCRDBN2bmhouD 17c2D/9gaiXizasSYMwA+a5cJk7IpdYFuqPOoFSZHkcUbGVU5Q8psDMoUkI6yoXlqrytEwgpcbQ DFAZT4BFFFZx714wvQ6gatZfyDSP3lDfOA6YJw2fwyIskhqsBMKj2EL20bGu7SNSs9vgGZgcycK ZQ5A9OWQMoXAgyQpWwfcWdJed8pWUl6mZv983TIb7Le9Wxz4Me3c3rtNFXysG4JpE2q7P1Qylhi WJvdcyzbZTTUlyyCPhwEg/wnSiPViXWA5fjiwyOXhs5u6vQUycaDmjKRyF8Gshh8KpL55tcIrtG pVjvunBE6g9BQgv/eArB4u6biW5FlHW0ZWGsbMpdPpLJR5mwVcs0fKZXGItESzz6DE6zpnCUC6p MCQ8R3Dw5ZNLpmw0c8tBcSl/s+RXOm/PIfPt8Tve2TLaAF11EkdkeyoM0C/Ukfr3d450aUctTAD Ei1t8+9IbXgfLfRtIHd04rVJeohTXBv7odCdMOFzPniYKf7qAJo/s5XlE6GfJR/V33luDW03QM6 Dex/OAOwzhVjMsuOWE+TdghNegFnMp8dJn9R5jndluYmKe8YrmYFBfHc09kVdSLPUYHAvPcdUO5 nvItgqB3c2fnOz0/UlqDG8XcGruK35oPgVRP8mZ0lYFeSC8bqorts/av81nordMJE6gNvhVyuq+ H6y/2MMsedBCGfg== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B No need to store devm_gpiod_get() error code in temporary variable. Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/wcd939x.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/wcd939x.c b/sound/soc/codecs/wcd939x.c index 95cd88a37acb5ef455d4a40948284ae45e2dfb28..9592462f2d6e3067a2ed3339ddd5f676eaf3b5ed 100644 --- a/sound/soc/codecs/wcd939x.c +++ b/sound/soc/codecs/wcd939x.c @@ -3241,10 +3241,9 @@ static int wcd939x_populate_dt_data(struct wcd939x_priv *wcd939x, struct device int ret; wcd939x->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); - if (IS_ERR(wcd939x->reset_gpio)) { - ret = PTR_ERR(wcd939x->reset_gpio); - return dev_err_probe(dev, ret, "Failed to get reset gpio\n"); - } + if (IS_ERR(wcd939x->reset_gpio)) + return dev_err_probe(dev, PTR_ERR(wcd939x->reset_gpio), + "Failed to get reset gpio\n"); ret = devm_regulator_bulk_get_enable(dev, ARRAY_SIZE(wcd939x_supplies), wcd939x_supplies); From patchwork Mon May 26 10:49:54 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 892788 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5D9E1FCFEF for ; Mon, 26 May 2025 10:50:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748256614; cv=none; b=MXhYdfPcPupDoGeB5MXJQDT69Zv7nGUX17uVlm0CjydaxX2LqU8omdISDSErV5qCQXPLtewPRyJ+sUSNQ0RlvAPSzLcHDVR0LorE+D/te5PMFM+UhK46EjPs8TSz/dC2V1wuEt3ah+azQO7Pd31AOrvp/wy++bn23yf3tN7BJNM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748256614; c=relaxed/simple; bh=yU2q2dc/+ye9DTxIWNsU5+R7KFc2SHPwmGkeguoT2DU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Wd3r+WCTYh/TdVNW3zpTAYGbIVtdDNufAOvT2Xa67ine+SQBbR0ebQoyZOZNvv0wDLITUOD8/avikL1UfxKHlb/kfVKFPESa6ywd7/kVtL6iCywh3I9J9iClCBcqrEt4b1RXf9EVWTOt4xFGOBmouztFYZAv94SI2TNSaXPmi24= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ZKi4Yxf8; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZKi4Yxf8" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-44069f5f3aaso3331885e9.2 for ; Mon, 26 May 2025 03:50:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748256611; x=1748861411; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=cG61swMbPld1iw/+98rFclnYQ/laAvEp49eN2rhhuD0=; b=ZKi4Yxf89MaoGNzI9gAkOxTWglmbyBLI4996/CmEmdSzBbM0Nuf8o3+NM2zvpBHC1b 3RjTtqarnBAhQjGoGngHcgIk24OIjREmN+oP0QaCsBBNmAVrNqzqfXOiYmsbhKXP/zM2 SbaJRnp37gQoQryqeicmpYBFjDwBx6YDPtp/ySpvI9Eq8gfkEjyK+BDgqaaOn4tyu2Qo sdZEncNoCZ/+CXZc22cWVU4pOViU0TJdxR6fEB6toKT67HbL0dWjqL9XEXBAd8CdnyhH TUdmlqS7/lFADfjvPLAyNrfmUveILIm4zO4cOUTPFgE/uy4QzlRwXjtpx7GQ9IIyq9Z4 lxAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748256611; x=1748861411; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cG61swMbPld1iw/+98rFclnYQ/laAvEp49eN2rhhuD0=; b=dyxD3PXKU5/TIBcOdkjFFuHCUYUqMLGDLvp25Ph2kpsDNgrImH6w704Nm+t93WV+IG qQ0NowTIwYEuyCkr1P4xwUCMR1zWukKABs49H2xBD7EwPF/erZdpoEroewATOBc4Bbi8 eEabgWAPUpKY+5WHDhLH0SQW7OaPJA2FtDDTrOnQ9MpOHP7aEGXpIiGZRshYmkTMgzcH ebnhBHFJBQqL61U3l7e/ufD6nBMb3jbrGUJira7MOQkue7xZFE3Ty2dXuQ51uztvEQms JndvmAxw7FzswFXYnyBYsUnPF4pAwJs7aW7+7vZbhIk1VVLbMYo62hbjk/Xuq8VSapJw ifbQ== X-Forwarded-Encrypted: i=1; AJvYcCV2+KIBs48E0R3naeq+/us0L8U5vuHWdgAE5uNwhnskqSdAX7Pub2XEkMpZ8raDp2PRRIQ4FDJKtZQ/ZUEv@vger.kernel.org X-Gm-Message-State: AOJu0YxDh8i1LuUyOfzPwagT3HtVWCCAzPk19dk3DOUp6vvGX5w7OmvR +x0wEIgt3j/5d5UkNGKPgZ1NpBknCYtENcSNlrVbyt5XitbYORJYvjHe1WHBAgYKAyE= X-Gm-Gg: ASbGnctl0Q7ZHBmq4p1Gw8OxK7Geg1aVuC9Jcfod+jS9ceFCeARkPK/2EGxR48PKOEr 3Sg4OT060TAqAjOyaxGWHL1cA5QJYv65YVdOaTCwcnwONqPO95hYZngmsj4Z6uDkz2009lJ2902 c18vuTbrPBYaFSBvGSQ5FWBw7ZHWWzeAoMOf96dBzkEtIQxNTaDEXysMdQFUIja9lSaUinVx0I8 CZ48kP7oVgWKGlg1Ok3mkUOtX6GXm2aWHKvBIkwjiauQyxEEYqJ0c6jWg5YO2tDhuMxkvJ8+ziv NuVW1VglhsdH7GkrbMNEmgdH2rxq5NnP9nEtdQHeh4IMCDlrJ0pwC45O6J+lVmRpcw1+5RQ= X-Google-Smtp-Source: AGHT+IGnwTHuuG+Jho/HJOTkFbKRV/f+Q8dqSHAsHXqa/3j8hdS8CB5qeUUJMIQv9Qhw06xYFkFQhA== X-Received: by 2002:a05:600c:c0c3:10b0:439:94f8:fc7b with SMTP id 5b1f17b1804b1-44c90f4ccb1mr16989755e9.0.1748256611031; Mon, 26 May 2025 03:50:11 -0700 (PDT) Received: from [192.168.1.29] ([178.197.223.125]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-447f73d4b68sm236337215e9.23.2025.05.26.03.50.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 May 2025 03:50:10 -0700 (PDT) From: Krzysztof Kozlowski Date: Mon, 26 May 2025 12:49:54 +0200 Subject: [PATCH 5/6] ASoC: dt-bindings: qcom,wcd939x: Document missing VDD_PX supply Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250526-b4-asoc-wcd9395-vdd-px-v1-5-64d3cb60313b@linaro.org> References: <20250526-b4-asoc-wcd9395-vdd-px-v1-0-64d3cb60313b@linaro.org> In-Reply-To: <20250526-b4-asoc-wcd9395-vdd-px-v1-0-64d3cb60313b@linaro.org> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Srinivas Kandagatla , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=915; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=yU2q2dc/+ye9DTxIWNsU5+R7KFc2SHPwmGkeguoT2DU=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoNEdWT6Qq3CPHamy1JbqY3q1W+b8Ex7iNBmMFR d7LsD2+YDyJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaDRHVgAKCRDBN2bmhouD 12B/D/sEd9n9p/vaz9wGIctCYELj5BTiT1VBT+p/3XG3w0sikeA9hHKlajpwaNkPLykj+JVhtiR 0VFC96Bd624OTu+kG5aKf+uEOTLp1nNpgNDUNH+dJTH3oKVzNxOiuiDNLRgPcv9x8gwDaOGQNqP Zx+NAv01ezIz3XG9fTL3z9qLbAW0B4EHrbDPBIfK28+RAD0iZcoeI+HKUK7K4jvdZpqxjbNGt5w x1IGp9k8FJ1+vXURk+xEaAeaU7DxR2nTPxfrNiZI6JKCT5WLW0iZSpHljodiY/13UU6em8Y4g6P Bsfx5Zh+uNVNeNfLgkzzQ5rATWC7HYgs6xO5W0brj5TCejaI8gzVdz54gA9aYpaCQlI3mUaDT+G hJkRTic+gKhJo9Bx9jGAdbTFkx8fLsZUCGrn73p3CZR0CQaRBFIf7sjK2gl8HihFjLk8uEy8fpC VM9md59JrfKKIHjTe1cfu+2BwDk9QKevkMPeYcx/KkWc5nkbAtLGqZ59iAmPE4C+usboX4Wcr/I JZcWCjm+q/esf342a1C3qdlUGbLkzybQIobE12JBbYXuuCCO70m2rQma5WvtRk/AsDA1cm6Yd6R A2e5mQ3e0PTCCz2OEGyaOFjfKVWTkczXuz0duEjfNu/2p2oL8xImYLF9VZIfW1FAlHYnUrGBEzC q5bqf5AYmCAI5ag== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Document VDD_PX supply on WCD9390 and WCD9395 audio codecs, which was missed in original posting. Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/sound/qcom,wcd939x.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd939x.yaml b/Documentation/devicetree/bindings/sound/qcom,wcd939x.yaml index c69291f4d575ca5b4fc037ac4d59c91f0df74cd1..85283f94465d4f1ae6ec7a250e0c7f65d2fca172 100644 --- a/Documentation/devicetree/bindings/sound/qcom,wcd939x.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,wcd939x.yaml @@ -45,6 +45,9 @@ properties: purpose of handling altmode muxing and orientation switching to detect and enable Audio Accessory Mode. + vdd-px-supply: + description: A reference to the 1.2V PX supply + required: - compatible From patchwork Mon May 26 10:49:55 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 892640 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D87B1FE44C for ; Mon, 26 May 2025 10:50:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748256615; cv=none; b=YkB5R0mEyu/29dVmTjo7zFnYEIlvMmNNCeFZJ7qfGwhA5SVAXnaOej+xKRjZ6ZH+QLQQQPfITkfq24kLn11DwiDRDMEIYfHSLU4zis6SXLByHYFtlpeEQIW+6mp6S8guBsdXNK0ghU4B8C2jjsqhU80VxxNJer2mVgD/jMQVmG0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748256615; c=relaxed/simple; bh=BxJ2y+p3e45IzKOg0vhlHvkapbzztQvH0zmQluqHJV8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=eWgQf3akWdqYSK8haeEBry3/oW+6wJoku2UTTRJzFi4j1uHCB+3Yayexrz3xWjg0IIV4CX4T0zUKlDvTJ+SHM/Q5guG7/JIeI/p2tv9X5efHY12S2ANBANFwjp2dNf728KlLXyyYh233oiF2q4akezltFkUd+kJIAcN4HN5nrtE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Y4vfCAsM; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Y4vfCAsM" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-3a4cfa5c8ddso340115f8f.0 for ; Mon, 26 May 2025 03:50:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748256612; x=1748861412; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=X1F0JJbw/NsRmxDzxcjla28hDif9xWhQF3zZnWHAIyc=; b=Y4vfCAsMjZrHMN/+FSpKWZMoZ1M4FS2/SxaugAteNgqjJrn00BpiCOcmGZ9gloVYcH CIGjzvkA3hc9WC4bPaVMEFJV1xCqx99xBuKol4Dj071ji2jpXFy6sjYct/LIPAyauIwb peV1X6ZN6F4b8FuTPLmWigJZSPnv4reJyCfUbe8CO9Zzuh7WrHpT44nltphS0GgmPJsf imk5QyatvnX+Z0OYFspzR6lLeuv7nROpsfrPOI4ak+PqsdZRflaa7Gc24J0UfkTCAw1l KOBFviExJPrOlKcI07CnrdS633qWgmfhNAb5hUJpkDEUuA0KvdFSGepgdvjt/nnyvRMA 7jdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748256612; x=1748861412; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X1F0JJbw/NsRmxDzxcjla28hDif9xWhQF3zZnWHAIyc=; b=ZfM903aH6Dzzk0lt/EoTsP7rjFRqQAohOSJGwFyYi0k2DqE3mHYr1+dlLl4vWA5HoE P100FjCm6cU9AFTxXDPWeZqGgkhm4R8mYpPEN8Z8QFVVxrOnDGljdF7hAbi7cwVcQaKu 9eiYycpLRwFoS2bc84+mBpTNofeRSDqIbAhxisONibSls3MVLkb6TBUkIB2Y04meeZw4 hEZqHM9U7n7Cik7bXsYbqMHQq/QoH9rJ9Y7WCcpDA9SxoOwWW8ZJinrq5UUijhqsC84h +iQ3iDPy6zNX3RGqDrbDX+/WB0H/ckk82h1cPCPQicUAy47kErmSUAS47e2rj6nc5Ukd ZcHA== X-Forwarded-Encrypted: i=1; AJvYcCW67YcRmD2TObTmUcjl4tQMDjk6+bdlYnUosV48y1QwNkbaIfIaQGvpr1w3RdiZTY97v3+/TuTI6DKvmIgW@vger.kernel.org X-Gm-Message-State: AOJu0YxEtzJXMtC4GoNCDELrU4tVF3K7vLZQkda0xuGcddAr6dorqzYh LnKiY1PMdxEft2mHcAFaD91oqF+JCjfeMHXmXSqq8SNgWyb70BuEIXKG68pCuSw/KqU= X-Gm-Gg: ASbGncsCQG/e+4hVSpV2Ghsb71yJluR8RdZ8DgJUVcWpKTctAIc5yDwn3QaAbxLA+Vi mX9QrtYlwOIygGyraIVVRxha7hE2nyVbHknhsm5MJT2GicAl+Ut+XOyfklUm1XSasmSgw/Gn7rw GhM3BwfvN4KouuxKgjqVl3hOvtvsNhneKvkwidm0UhQ0oHui/HVemg/Fdk2FdHYQvAgrGKLO7CZ dPjt/WNrV++EiafkY1Yo2B4L8YvP9Gh5Tt3CFYH/laHN7ZV49y+EoSawfJtBbvtYRHWECvTcho5 lZ5uG+AVrBJ8bm4W5aHnEHc4MNW/dQdCOnKVJk3dO3jP+WBCYB1vAF5TwK/yYf2Vetrl2xM= X-Google-Smtp-Source: AGHT+IEc+gSI4dz6PJb6XB2/tm1jAeKYruuziD5I3xYLt4dJi41VULpTVmWm9gG7qkHMbwUWLampxA== X-Received: by 2002:a05:6000:2082:b0:3a2:133:b1a4 with SMTP id ffacd0b85a97d-3a4cb48a237mr2078199f8f.13.1748256612330; Mon, 26 May 2025 03:50:12 -0700 (PDT) Received: from [192.168.1.29] ([178.197.223.125]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-447f73d4b68sm236337215e9.23.2025.05.26.03.50.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 May 2025 03:50:11 -0700 (PDT) From: Krzysztof Kozlowski Date: Mon, 26 May 2025 12:49:55 +0200 Subject: [PATCH 6/6] ASoC: codecs: wcd939x: Add VDD_PX supply Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250526-b4-asoc-wcd9395-vdd-px-v1-6-64d3cb60313b@linaro.org> References: <20250526-b4-asoc-wcd9395-vdd-px-v1-0-64d3cb60313b@linaro.org> In-Reply-To: <20250526-b4-asoc-wcd9395-vdd-px-v1-0-64d3cb60313b@linaro.org> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Srinivas Kandagatla , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=881; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=BxJ2y+p3e45IzKOg0vhlHvkapbzztQvH0zmQluqHJV8=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoNEdX6ua3vxOKUSyAOM3GRxHgAoDMRana3x+JM 90uDzTcvgGJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaDRHVwAKCRDBN2bmhouD 13R7D/9pPE/aTDxvrefDXj5fjGmq+RVR1zaJ8Agf9aOCuT3EVvkdIo8lnsaXmJqllZsHEGXKfRY FFO/lYuKpmUDwSSgPRwij8JS+gidxWuCO8koyagq5HTwUNLPIuUl2k4m6k/KG12o31ALQsT/pMG L27VghMwOoDVf1EYL+2Te+O44EUiP/WqWSwQxHFi4Q+HuhynvtjGANzsz34PEapB9qfcdCORaez haOIa7lopyIwHUMFTkVfVkabOeMAK9E65AVzhmpB13eeOuKNtT3UT0jLBwA5XdGsgIpms9sqEAS /qwtNtbzrpDV0FbDqisgQwtpLbGlraj1S1yv9v7WMOQqQoZsx7Oc4xgWWGeNoaXd9yMSuWsh+Jw 4gdkx4407sADLbOJGwC55BU5EYiw8Sj2fd1ilSayJA2Lu7nm9WspJXuQkhOsaXTLPNFzEwDwH5Y g8Gmi2cTPKM1Ev9K1Q4wjJLf5HkwBToMfSPDpjtj3eeYIYh3Ykrl29xMmE87rXiZY/UGSh4bwEg 1kxK+BglD9gRf016XqgXa66rn5f9xzer/gUknqVSfTXZJiRgazqLzQu0Rcbp7Ma/Nz2q2nCET6D lC0eNpI12nxjFIgE4pupQr2AN+BjG9FqsfhgCvSv4vg4nv7H51ZLK/iQSje9VcZqi5UnubWVpn2 coOXn/LkmU9OP1g== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Device has also VDD_PX supply, which should be acquired by the driver. Regulator framework will provide a dummy supply, thus the change is compatible with older DTS. Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/wcd939x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/wcd939x.c b/sound/soc/codecs/wcd939x.c index 9592462f2d6e3067a2ed3339ddd5f676eaf3b5ed..690832037b5dcee0722e118536a45cb70e5c61c2 100644 --- a/sound/soc/codecs/wcd939x.c +++ b/sound/soc/codecs/wcd939x.c @@ -212,7 +212,7 @@ struct wcd939x_priv { }; static const char * const wcd939x_supplies[] = { - "vdd-rxtx", "vdd-io", "vdd-buck", "vdd-mic-bias", + "vdd-rxtx", "vdd-io", "vdd-buck", "vdd-mic-bias", "vdd-px", }; static const SNDRV_CTL_TLVD_DECLARE_DB_MINMAX(ear_pa_gain, 600, -1800);