From patchwork Thu Jun 5 19:35:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 894199 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:ecd:b0:3a4:ee3f:8f15 with SMTP id ea13csp141776wrb; Thu, 5 Jun 2025 12:36:54 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUmOQ++tvqg18uxTeCOr8oU602MK0TH+QG4+qlXHiYtQZ7zCdBx9E90utFgLwGy58Fk0IxD6Q==@linaro.org X-Google-Smtp-Source: AGHT+IGQWIcsSB1sPdfuDke9HS6qwpwSumGO/FhTZ3OvwVK6eWSTvHTxbc1OMzvvrVZxij0N/PSA X-Received: by 2002:a05:620a:4142:b0:7d0:9e98:bd95 with SMTP id af79cd13be357-7d2298968bdmr100597185a.34.1749152214459; Thu, 05 Jun 2025 12:36:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1749152214; cv=none; d=google.com; s=arc-20240605; b=Hht+5TplVmEsqZHltBdNFm9RWCNdF2FykAZV8zbOtBrqcpSuT/OHxdNmHR3i2KbIT9 Wl05jI8BIMP/aw//xAN2Ppqo8YhQG2df59D6oqFjB+j0nyAEvDxi3y5oB7E5UaLnJ5lt HwEm9DxfYyz4pN5ZWinwKumsrfjxzcrwlMMo7/+HI0HEtuLAUUM/ga6lu1uaZcp1a+4j s1UtsBKrVEq7ZP7ja5SS8L91H2oQn/fkkt+j5bCe5asQRjS2HkalNWMtcHIe6NQOHIaL w+TjGXjKlN5bYIAFsZ6DyvLR8upaDbdkMsKhI0S46WOL8uIAw74BGiSoz/yac26ITAzP 9L4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=WEDanJuT5WWXk9pLyRjI3VBPkEYLoZCOaoP/BA1XIzI=; fh=4h8nYkqSZR/NsvEVgsamRLVoGtMitGyEZZrWhPRdZB0=; b=UrCWUpCBMB6DyAA72CMZYRX7me+tp6NURj6TthBlS7/EMJlvVmaOaG8G5uH4QhB9nf xOzvIrI2Dge2bG9JpLP5/1XhpdbXo+46/MTGJ9Eh+on2qLhpClL1HnP5fYdl+/NWPM3C +QBr7FvGSBLPbcjkJAX04WmKzDt0b4RYcpB1EzZT5c/G+d0GGTgnaYEhzNVI/Q9a6RFH /Q1LEGgfo0a2d2E4U6ddky2pbXBWrGkkhGpAoYY6OcRHUYZjxB7oqjZCST8BZYSvIbRr TafQcx+Ekn0x7ZydepBZaH+s07S4AxgvB1Ldrc7C5uj9vzOmqBAVkwSJLwS2v/cqYsh0 rqlg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CXUu01cl; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7d2669c1713si11873585a.566.2025.06.05.12.36.54 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 05 Jun 2025 12:36:54 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CXUu01cl; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uNGNf-0006ko-G6; Thu, 05 Jun 2025 15:36:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uNGNa-0006iI-7w for qemu-devel@nongnu.org; Thu, 05 Jun 2025 15:35:59 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uNGNX-000168-C9 for qemu-devel@nongnu.org; Thu, 05 Jun 2025 15:35:57 -0400 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-3a5123c1533so761389f8f.2 for ; Thu, 05 Jun 2025 12:35:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749152148; x=1749756948; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WEDanJuT5WWXk9pLyRjI3VBPkEYLoZCOaoP/BA1XIzI=; b=CXUu01cldqKDPVabUN5W7UTR0ufznTeB5ImugbyT3WsRUqD3/kqYoFwznAwdmi3475 V56DP/axfeZCn31SNQD4/8gXCFURDmZdLwJCv7NQRJeb2aiJbcLAO39DoMEHL0rwglED fjhPTyzJfFEUbT8KS5snlPHBQ8iOmbfN/nJs0VHqT4i9I8GMWcyWEKcyTr/7O7zf+tep lNfWyBFTyUzrOY2nh5uBuaDLn9jcXs78gFhazrrWYK1NMExnqWMvqlwU1Q3KMtmFNL8k 3nH7lCfNtt8eLgQVLjm1gGD3oqG2ZUgEMpb898QyjHA/6KxSIO4Cx2on2UG2UGaujrCr uR1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749152148; x=1749756948; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WEDanJuT5WWXk9pLyRjI3VBPkEYLoZCOaoP/BA1XIzI=; b=cBa/YL2/3d6R9IBry/Dj++xZUtcjUkkcZyOY+xR13NHh9dOhl28hkZJUTQohHlhK0y UyH7k5t+OLnkKuFN6DxGhA12LL0tkDdZG90WtZ09HVE66oyO8qtt6rkP5roP6SVjpLj7 QvOVAIy/g9xMEx2HNFh7rCCXGNvElSgDSBiSWHrqjmHDSEo1vPTbYpZvnnoiU5oYbYbk U7FleBOZLcpVloClSvwwI1T+E7XIDcfOJ0ubGUH9mON7qlCPqh1GHLWL3SQLDjU35C28 ptPqEzj0J13uFLgsKyJJ4ltdhATHJSq4q5K8sLs2ngXIBLfMuZQK77FrGHJKhjNqlgMv cIkw== X-Gm-Message-State: AOJu0YyQjBbhVUd0xrBfToRAAK7IuhorAnmgE8ZUIqlmQV3miFoROcBZ v8HV9mFHCM7m/kXZG6DzQ/csVdvKNIpxzslEwEGLc9vpScIpSSsXxrs4cOPuCcI0KDUTDPUeBiR HP3zTaXM= X-Gm-Gg: ASbGncuwqI+5LxNZp/YeQn32oyEE8CxMuIy1fVhdcUZ6pvvpoAXRm/cTDbYOqAC7g6+ ysztY6fHh/vkxcsfXLxetYGOcej6FDCm+D5NSyGjr2kxeg0CVqBbB4+FtAyL/Bhu0oiPdsPxL4E M088N2SG5UeLmhSsGWLZi829TRdyI7aODcMmEpX2VzX7wpJvEI4GwZPahqaOd1vjyP4i9tDM5W2 3u3WWZ/ENGZNRqK5zuycFbUNqgOG3cbbfNuMjtBZ1153SFYenuAZELCFF696KdsAuHCtDaJ9f93 Fa3SJrtuTa8KQCvtOtm1qEEt7oI3EUaXbc6hhDnVFs363ksHedqWGvR4pVsdx1UkG3NcsNlE84w o3/51PKqwgIxDeiKZr9gwe+ktXA== X-Received: by 2002:a05:6000:240b:b0:3a4:f8fa:9c94 with SMTP id ffacd0b85a97d-3a531caa070mr364860f8f.13.1749152148183; Thu, 05 Jun 2025 12:35:48 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45213754973sm2179575e9.35.2025.06.05.12.35.47 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 05 Jun 2025 12:35:47 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, Paolo Bonzini , qemu-arm@nongnu.org, Glenn Miles , =?utf-8?q?Marc-And?= =?utf-8?q?r=C3=A9_Lureau?= , Peter Maydell , Stefan Hajnoczi , Stefan Berger , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= , =?utf-8?q?Daniel_P_=2E_Berrang?= =?utf-8?q?=C3=A9?= Subject: [PATCH 1/4] hw/gpio/pca9552: Avoid using g_newa() Date: Thu, 5 Jun 2025 21:35:37 +0200 Message-ID: <20250605193540.59874-2-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250605193540.59874-1-philmd@linaro.org> References: <20250605193540.59874-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=philmd@linaro.org; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org We have pin_count <= PCA955X_PIN_COUNT_MAX. Having PCA955X_PIN_COUNT_MAX = 16, it is safe to explicitly allocate the char buffer on the stack, without g_newa(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Glenn Miles --- hw/gpio/pca9552.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/gpio/pca9552.c b/hw/gpio/pca9552.c index d65c0a2e90f..1e10238b2e0 100644 --- a/hw/gpio/pca9552.c +++ b/hw/gpio/pca9552.c @@ -76,7 +76,7 @@ static void pca955x_display_pins_status(PCA955xState *s, return; } if (trace_event_get_state_backends(TRACE_PCA955X_GPIO_STATUS)) { - char *buf = g_newa(char, k->pin_count + 1); + char buf[PCA955X_PIN_COUNT_MAX + 1]; for (i = 0; i < k->pin_count; i++) { if (extract32(pins_status, i, 1)) { From patchwork Thu Jun 5 19:35:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 894200 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:ecd:b0:3a4:ee3f:8f15 with SMTP id ea13csp141992wrb; Thu, 5 Jun 2025 12:37:30 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVNfu9WEQcuK1Lj6OpP1KkAO1RDbk5smIi4fci2D9niDyBuEPbyzOUBQbIrPmnb5gcHzpyseA==@linaro.org X-Google-Smtp-Source: AGHT+IFI3ErGrbMWAU+D4goWGUsXkIA7y/zc5ngyz0b1Q2oAgpzXEWuPmdH+i4Bjwf3WILnwALS9 X-Received: by 2002:a05:6214:2aae:b0:6fa:c41e:cc6c with SMTP id 6a1803df08f44-6fb08fdcee8mr10858816d6.15.1749152249995; Thu, 05 Jun 2025 12:37:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1749152249; cv=none; d=google.com; s=arc-20240605; b=HDz2NGWIAJuc9iUJznEQFJtJofcnbMoj1x7CwEqO6c9ggxLC9jM3PzoxBXmU++KRve wvtaKcOnaZKIJOOM/V9fzt2pXrO+Y7wjkFqePJy9i/75tyMZiLuo9I/lJrmUIxcSlO/N Dufj7j2Mu12T8rG1kUpBhaaYKOGMUSQUd6d7s6uoiOh9WuLzi6G6/MzRzNLVioLiZJhX PhG/ugbEExaxgZj0VCNvRd8KMeKE+H2bqZGlv9Nr1J671ZFBOERVAHZffOjYU5dU27lE kqS689y79nt2xDXA52SOWQT9LyLgIGAEikTjFBFpxSGlSt5T/vn7NX2u7E2MfETKoNJf /L6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=83yRFqQDqtEfhfQYce2Osef2dywXWD24VcAWbnFp9Kk=; fh=4h8nYkqSZR/NsvEVgsamRLVoGtMitGyEZZrWhPRdZB0=; b=FulUegrrjqHz9JdNm2mUQ0+E1dIFuec68F6chLem/Jr3IhXyidy4fQOmTEeFrdP2Gm CkmsRHBUL1iodcX80+qcKSGBYqaFnOKsfn4b4yo2Hn8V6Bbg8OWn/0CcZCcexRD7kZrX z9THR/3veG9LI7AkzcrB2wrvUommypWRVVXOiJjrDsGRmKeAxh7DjwGe7Wc4LYdyo4b6 zmZzLMFgqTYNN29Yf3bGjq6NYRYXgu7stzJKLFtj7KdTymU+ejEAby366gsYcXU5KxrB sN7qz7mx6Mk/Io4RmVrMH61VeDCYjvsGdJSIB4OwvjrgPTACMzXibRUMw6s/c6wlH9g7 llfA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Oqcb+mrQ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6fac6dca18esi188919046d6.103.2025.06.05.12.37.29 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 05 Jun 2025 12:37:29 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Oqcb+mrQ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uNGNh-0006lj-P2; Thu, 05 Jun 2025 15:36:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uNGNa-0006iG-6e for qemu-devel@nongnu.org; Thu, 05 Jun 2025 15:35:59 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uNGNX-00016q-Fk for qemu-devel@nongnu.org; Thu, 05 Jun 2025 15:35:57 -0400 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-442f4a3a4d6so8270095e9.0 for ; Thu, 05 Jun 2025 12:35:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749152153; x=1749756953; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=83yRFqQDqtEfhfQYce2Osef2dywXWD24VcAWbnFp9Kk=; b=Oqcb+mrQWvq4iZ1eAEj0YztXidNZ9xREngt3tFL5TMElowPNHfSg54rx8V9GgVwGCP 9Y9FZGTzPkUIYyX0bWPgF9YCMyrbhpc+SyB2RVgIqjio+ZdKzFLfJXMFhajZtazfGRyt eKTIJCv6kDI0Q4ex4fzA7qtYMggbn5XFEFnFOmV6BfZQHqtjC4JyowI1oCg0eP3RiWxP 4Bd6nAGcoEIv70jSsK/+syRWJ+Fe+94qjD3pNDCpB5MCiWhMAuVBsmfA3QkVHQI6C1kL 9vr/SD72ukDLhUKoP78365XuuKOZkjUSuXKwCabYFYxyuGOWoUe8yk6km/dvILoV0GXA sChQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749152153; x=1749756953; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=83yRFqQDqtEfhfQYce2Osef2dywXWD24VcAWbnFp9Kk=; b=BRzX5ofqRQbekSixqYBLHUlnzDLjEVxEvl10zNiQtp7oTTj+2ipC66jVHHmCv8Zqvn Mr8QMw7puH+AYHOIZp1jsYCXKA1c1/AArWV1piyGFuNdOsG+HH9Nit0ss0KCaJBKj1nG 8m1bLNL4BzVaoqIDwGhue99AQgi6c91gL20dJ1zLgcjx9Ivaq2D4ltg66aBN86lA6DUv NyJE7N0xLacE241Rg61fKqQ4L4hnsnxY+Gmym/WkliZtHJPyz1SVMYByxgWYXOgFR5La P54UGxhwin7iSVaxUoRxmmN3vpiaP18aUXMXEWX1UVfpM6nobax25xn4zp55Y/jIdtWp TnXg== X-Gm-Message-State: AOJu0Yy7Bvlkm99bF9GX/ODtW0mBEsvJRuCc7r0R257On4qLDRS+2+4B +FIm1pWnNnON/3wN573Frvsor7vWSLFQUrNtZ3AQdzULEUbLPtxwNT4UeadJktpPZJCSVpB8adx 4Zi1RfSg= X-Gm-Gg: ASbGncuNwc8Icrw4+Ac1gkzQqqkCREJgXUd6bSzz/lzUBHKBV3dfPBmjDMz91AHUCW+ zwTLpGe5pHHYeW8RsWJsgCdyxZIviCiGni/DfsBDedxS1duQOAFzAHHyDQWibAO3Z2ddbcHt64t uHA37XQXCMMhYIUNtw5gIlxUPMxldSQ1Z/duFAk5rMxvoR+zAVZC/EoaMn9gDKiQB/7ZWDG+6HK p3PNcN1TBmjfy7iHnnmK6qff4K2e25ESxvAGhecA8L+qcWfxawvWUQrEjJ2LRlAh/b67HVSV/k1 DEo5KTfUuHV14X0J6aJvNHR9D1xpKhmxu0rShuBdUIxZYJGQps07xeo692AEBpvGg4zN/lq2xFf 1VGVCK31QkXDujHEqPvj1qsDURoYX78GXfDJz X-Received: by 2002:a05:600c:458a:b0:450:d3a1:95e2 with SMTP id 5b1f17b1804b1-451f8855f11mr44862745e9.9.1749152153306; Thu, 05 Jun 2025 12:35:53 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45209ce1f34sm2477585e9.14.2025.06.05.12.35.52 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 05 Jun 2025 12:35:52 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, Paolo Bonzini , qemu-arm@nongnu.org, Glenn Miles , =?utf-8?q?Marc-And?= =?utf-8?q?r=C3=A9_Lureau?= , Peter Maydell , Stefan Hajnoczi , Stefan Berger , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= , =?utf-8?q?Daniel_P_=2E_Berrang?= =?utf-8?q?=C3=A9?= Subject: [PATCH 2/4] backends/tpmL Avoid using g_alloca() Date: Thu, 5 Jun 2025 21:35:38 +0200 Message-ID: <20250605193540.59874-3-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250605193540.59874-1-philmd@linaro.org> References: <20250605193540.59874-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=philmd@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org tpm_emulator_ctrlcmd() is not in hot path. Use the heap instead of the stack, removing the g_alloca() call. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Stefan Berger Reviewed-by: Stefan Berger --- backends/tpm/tpm_emulator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/backends/tpm/tpm_emulator.c b/backends/tpm/tpm_emulator.c index 43d350e895d..4a234ab2c0b 100644 --- a/backends/tpm/tpm_emulator.c +++ b/backends/tpm/tpm_emulator.c @@ -129,11 +129,11 @@ static int tpm_emulator_ctrlcmd(TPMEmulator *tpm, unsigned long cmd, void *msg, CharBackend *dev = &tpm->ctrl_chr; uint32_t cmd_no = cpu_to_be32(cmd); ssize_t n = sizeof(uint32_t) + msg_len_in; - uint8_t *buf = NULL; ptm_res res; WITH_QEMU_LOCK_GUARD(&tpm->mutex) { - buf = g_alloca(n); + g_autofree uint8_t *buf = g_malloc(n); + memcpy(buf, &cmd_no, sizeof(cmd_no)); memcpy(buf + sizeof(cmd_no), msg, msg_len_in); From patchwork Thu Jun 5 19:35:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 894197 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:ecd:b0:3a4:ee3f:8f15 with SMTP id ea13csp141755wrb; Thu, 5 Jun 2025 12:36:51 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVTmqXBArrFQ6XbRA/afkAebsEJ/cnTH/CQF9mJkSBNPe82CJxkZ+NHJfd4sMSJ5rFsPoskdw==@linaro.org X-Google-Smtp-Source: AGHT+IEYO5b3ViKO0lLY7Td9FTy+FQiEhH86mh1nWREqgoQbUxjSSM2jNMpncxxfRrgqCkSBJeM/ X-Received: by 2002:a05:6214:29cc:b0:6fa:c168:b20a with SMTP id 6a1803df08f44-6fb08fdb790mr12376086d6.10.1749152211008; Thu, 05 Jun 2025 12:36:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1749152210; cv=none; d=google.com; s=arc-20240605; b=Oz/CnQnYer26DfWsuIXU1cEwVD0DgxkehcWv1P3fJosUYt2uHmq9bIAtIicNaV/qNO 1iYuV2/spcJEy2TVurE2XJSwMaznkW7bEEpfi/TuMCSFdalkXFZ9AuNF0y9OE/G4L68I nDV6PHlD3TY7Rpiwk1qkV36kuKZnWIuZ2k4KB6cm8o8iSb2Bs4mfbL+zOHz1UiiCjRIr FoABYNiPDCP1lgGL4rwsmT1MmANjFnQhZSThG7cMq/jNQBaC1heycE1oYXaT8fol0fDb v0H5KvhQhEu7CBddyOgyggCS4nvIllRgqN8jYOude1CocksKGM0WdyWm85DxKcXNIE+k mZ/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=0H5JejayswNFHuNqdTgm/gmscONTNKgClj6tOp77taE=; fh=4h8nYkqSZR/NsvEVgsamRLVoGtMitGyEZZrWhPRdZB0=; b=bCyqZoHW/MM6eUqnJkDiTnrkWI5Aa+9YNjym3F2D4VEY20Ryo0CxOZGanzPL0G0BC8 iHBMkzrNyJ17DeK8dAiSLeJvpRDIebuT/wXPG4IbUObUjz1bcfKzXJktkj92LI75azIF ilGhq7cx7DyfEHtdQ6omnNBmTVy35Caznis2xsd06a+7zMb/NuronS9o8pBhu5ta9Nj9 MYQLIxyzksW/vikHAyaHFRY65LidJEcm0zoArz3uCnYaQaKg+IfE4WihLd55BXTYQp+T gAYav6UPAzJK9XWtvrEy3oQGYtMpFPyDCb0gBCYIBc157+EC/ZlVLrioUD7RhOiYllor jHWA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MPJVzBor; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6fac6ee4e42si178424226d6.496.2025.06.05.12.36.50 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 05 Jun 2025 12:36:50 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MPJVzBor; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uNGNj-0006mD-8H; Thu, 05 Jun 2025 15:36:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uNGNf-0006kn-Ca for qemu-devel@nongnu.org; Thu, 05 Jun 2025 15:36:03 -0400 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uNGNc-00017o-S8 for qemu-devel@nongnu.org; Thu, 05 Jun 2025 15:36:03 -0400 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-3a531fcaa05so35612f8f.3 for ; Thu, 05 Jun 2025 12:35:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749152158; x=1749756958; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0H5JejayswNFHuNqdTgm/gmscONTNKgClj6tOp77taE=; b=MPJVzBorwr+KwcPCwwXI0/edacaAKd1su9dFvRHqAbc1Ly49UrxFBNE5Q20wK/0v+Z 5XhSWlZ3LM94cBhYyqUaO9cSQULa0plEmXbkbbH/Ii6PDyrOsuBFk071us8KZBoxOyEN WjaWB4h+dwdez5Gw5cI+jSHGSSk5GyaOwNq2macnlFB4sc2HqvcaZNojRicPl4jL4Rrn vpGcTd/PtGr4ZV/Ta4JCiKyDuXAgQdNGgZuS3UjE5PgvIKwGEzxkRPt3wfnxqUiM8p33 8KGRENZDXavIyPJ8Vi+um4Vd5O7XlxvH8rOsPCU4sKJW2lk00RPkjZf6N3JuEuO8ided ty6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749152158; x=1749756958; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0H5JejayswNFHuNqdTgm/gmscONTNKgClj6tOp77taE=; b=xGPiUC4hvvWurMK29xu5zLor4W5yKeZW9o7PsuvFyx22vZ5/znM7Hs19rwLiAg8vRW 51KAQK9v3TliuFYE7XMIgRKaxxJlO5b/RAiQhUQC0dF2OuY6CtUicGb50XDWkJOtS14R BQ3v+k5RRRKi6NoqKa0S/DCw71G0HhZvoRJAePuBIJRegZwp5+Kn9lc/J6qm5cXwzYoQ On2PjA7Qzljbqp168Nc3tMK0G2o2fZLxFEVfCxZG350mHRo9K8CrvR/2pAG8+UbFsbTg QeLYcdMwHclOd3v/MjDDZ1q3KcuSoQMHFX3oTxVGo9R2kBIkm4D1YJDDAT6o0Z+wGNw0 CrBg== X-Gm-Message-State: AOJu0YyHyO+7nOBdz3h+Izeb7LzASJNtIDigtYGzRKjDakktVfreFWMb QC++8L9Epi2NmfwkGuw0IRLYxkIT00qrjeXmeF9N8HJgwbi5beZzGmbCUHWjVMZsEbFnItpJjIR k+4Ve9CY= X-Gm-Gg: ASbGncvxHdgEwGgPzqKpXmMVnr8fJTakPK3HoommRqcTPepdwkOUGuQCfmepJ5DDnaO D9hAdAy3WnLwTg72njlkejgsBTuvzWNqHd185UiOjf5Bi70WgGtXTmaI2sJbgYQq8LhPCre9dlY DJRQ2hzK1xz1Q4dBzu+zZqHnSYZxqjcmxt5fn3rXlnT6blWnmz2n7PjY168U9519RKTaPgSfn6j A+WLFxUiC8Lg03CDW3Ehmwv5WaZIpNQ1dPGZFDuewvOMTGc7b0wBzqBNnZ3CPG95tr5JHy5YlDl isZrD/K+MCwFBVyXqImsA1/9/dtsCTsGMorK4r9JGnDUA5Gb7f4oiohnuJQ932nfb4bHnpTdOzH JVROgH+1BUTQyMaD5t6qfvy5k4gyalkEDsHZ0 X-Received: by 2002:a05:6000:220d:b0:3a4:f744:e013 with SMTP id ffacd0b85a97d-3a531cb8521mr290974f8f.30.1749152158248; Thu, 05 Jun 2025 12:35:58 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a53244df06sm59169f8f.69.2025.06.05.12.35.57 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 05 Jun 2025 12:35:57 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, Paolo Bonzini , qemu-arm@nongnu.org, Glenn Miles , =?utf-8?q?Marc-And?= =?utf-8?q?r=C3=A9_Lureau?= , Peter Maydell , Stefan Hajnoczi , Stefan Berger , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= , =?utf-8?q?Daniel_P_=2E_Berrang?= =?utf-8?q?=C3=A9?= Subject: [PATCH 3/4] tests/unit/test-char: Avoid using g_alloca() Date: Thu, 5 Jun 2025 21:35:39 +0200 Message-ID: <20250605193540.59874-4-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250605193540.59874-1-philmd@linaro.org> References: <20250605193540.59874-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=philmd@linaro.org; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Do not use g_alloca(), simply allocate the CharBackend structure on the stack. Signed-off-by: Philippe Mathieu-Daudé --- tests/unit/test-char.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/unit/test-char.c b/tests/unit/test-char.c index 60a843b79d9..f30a39f61ff 100644 --- a/tests/unit/test-char.c +++ b/tests/unit/test-char.c @@ -993,7 +993,7 @@ static void char_udp_test_internal(Chardev *reuse_chr, int sock) struct sockaddr_in other; SocketIdleData d = { 0, }; Chardev *chr; - CharBackend *be; + CharBackend stack_be, *be = &stack_be; socklen_t alen = sizeof(other); int ret; char buf[10]; @@ -1009,7 +1009,6 @@ static void char_udp_test_internal(Chardev *reuse_chr, int sock) chr = qemu_chr_new("client", tmp, NULL); g_assert_nonnull(chr); - be = g_alloca(sizeof(CharBackend)); qemu_chr_fe_init(be, chr, &error_abort); } From patchwork Thu Jun 5 19:35:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 894196 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:ecd:b0:3a4:ee3f:8f15 with SMTP id ea13csp141651wrb; Thu, 5 Jun 2025 12:36:36 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWXDoK9wK5RQ/V6cm5CS4KB8poBnaiWWKQhAnMZr+C+cXMhFfgsd477LlJI/6R5ybQ2GyXKtQ==@linaro.org X-Google-Smtp-Source: AGHT+IHB01w+L5Bz8TjGCNs+M6InM0HdFKqMt766+MNzLKEz+e8BsozLQZ0h+3oNIpbHnRZOQ8VU X-Received: by 2002:a05:6214:21ad:b0:6fa:c41e:ccf0 with SMTP id 6a1803df08f44-6fb08f97fb6mr12457986d6.36.1749152195990; Thu, 05 Jun 2025 12:36:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1749152195; cv=none; d=google.com; s=arc-20240605; b=JubjV6gFskpSjM5+D+Ns4kHJWgbe1u12uJVfN04++/HACFXdJTE9dn1MkDfNwD1TtT 1ozV/WUajSl4cw2n9UvvoAPxw0B+QQmsnrmHsl8RuRvenV/H2j7ctyHzX4jvwgfWrx2Q eYQTLEI0RZO8UR4IluidtIcP4uAoodtSaFDFkFYZxtz8Jx9xYqMXfcGpUALP3pF/x98T NLipsysHqZ+8h4cOmCIzp9ut0MpKWL/Mz1/Yyq6C8cH7fHYfsAtDJtUhFj8OIPgmk5ng CcUV3HwnOFLp+JZerXld0H93+eFdTiFAUgtDNVT8iYr8XwUg0gg0iQE8cmGN/QFYXIK9 YrBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=rl1Q+tx40XbBr5+knuEz+9jWMcm+8B54eODQxezOx1g=; fh=4h8nYkqSZR/NsvEVgsamRLVoGtMitGyEZZrWhPRdZB0=; b=hpcO13Zqr8oTSh6FAtVZpGoFUSFe10i0BF+Zp9KkukQY467CcvyywNviQGUh/IErIj QC/vQs5mRXQf61yQApEEWaaMvubV9S341wlVdVIFooqlGhurWXE9uO5D4ITk9pWkwICI JoTrW4w1uPLoq6u3d4XWiZZCPuGNG27+qEIz2yUbJOzQ9vEJWyMckbxQjuFdxf3T4iOQ D14Y5B7qFQwfPrBibfk7pB275kywVmXT5LzzuviXQ658S3ys4PZOgAjFWbGEQKMBsOao zjvz/GDLj9wLnZw/eJHopENJRqbbG8CtxBndmwq42tS1KnidlCe/GqKPsCgMezrYjOwV j5/A==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kUBllly4; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6fac6ec86absi175428116d6.403.2025.06.05.12.36.35 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 05 Jun 2025 12:36:35 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kUBllly4; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uNGNo-0006oj-K7; Thu, 05 Jun 2025 15:36:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uNGNl-0006n5-1Z for qemu-devel@nongnu.org; Thu, 05 Jun 2025 15:36:09 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uNGNi-00018X-J0 for qemu-devel@nongnu.org; Thu, 05 Jun 2025 15:36:08 -0400 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-450cea01b9cso4672745e9.0 for ; Thu, 05 Jun 2025 12:36:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749152165; x=1749756965; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rl1Q+tx40XbBr5+knuEz+9jWMcm+8B54eODQxezOx1g=; b=kUBllly4LO2LIc/Kh7eZ/AZg5veY02yZ7suMxHAPpCWvFUsheBPee5x1ZYoJDdpFsN +vrFVPtoKcL2zMOqsVWeU83UpaYxfDZQQdorIUnzi/wE0d2cENpOurmbHihw/1agQBcg WEiVWg0dEN2xQLU0+uuNiVfT72IvLng+RV25c+tDzUr/LwbNICNmH81ln0wSci0Jyhlu bofxJRK17elnZQ0y5pKFqkL1SK/hNmGylDfyCZjANpOO/tGldd2OPFSViOLItbQfjIRF 9iuVZCVaTgkVm7GYNgCTnSC6qsAIWGAAUeioU294+EXOAeF3AamTME/CM7Y4/hG6pB/c GTxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749152165; x=1749756965; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rl1Q+tx40XbBr5+knuEz+9jWMcm+8B54eODQxezOx1g=; b=Tugr9JD5+eTRYp667aoii9T1VfHIZlfOXBCY84t7EeryesuBNZh5gCdIdYgEOB4oV+ Z1nnUMZWHc1RFEsaIVrChuG0XohSgQ2/XB+/vH1lNePBjFoG39pGFnFm7mQZZPyMHLHF a9rXK6S+RFbJ2B/U2b6twMWDmNxaDI6wjDSOTAAkNnOMgMx0oSBlWHp9Cfu0qBCuDt+6 9lSr0zs4ZLHh8vu+CR+eks9+D69akge3KsS5bKop73hICbeg2IJX8OPi05DJbsHyFwV0 Hl3SWv+Lrhmx8zi5vCdYbL3lkqX4eR/Q5Tl+kH4x56nm5N2pBAIru6AvMWFCpTsjgubD IFTg== X-Gm-Message-State: AOJu0YxeiJi83yMpeCD8V93qKltYD4EhU5JiJiatp2QYWzYJFMui13GV 1LjQnpONOAGEYkwjo3fsyRoFGbmWLQNMWy8ruCqOUuU580Yo5BR+WEsxcaLl9t3gnNqsN5J9jF+ RSIC32Ds= X-Gm-Gg: ASbGncsMBiwc0KvA+AN9661BQcceU6eCecEOoCltxkU2pbZR4GJNDbH958FzgIUMdfR Ky6InlOjiRk2MC72mZXIffGOT9UUwZIgm5ej8ipQVTmzJOjj8WA3MoknGBR84KAlWEU3ItM8F5v TN/w9D2lquY5c53mHvH55WEi/BKsWkf10H6HbBtj9FqHvdYeD7cuJjgeQ5SDSnUlaMp3QTAJDpl VX2iuqeuSCOhfTT1eTyXB+T5Q6DiZspJiCCVB/692djBicKtRIbuAH5+rclA792mOiNgmEkUSLG nXyMjp/1UT63/EIU5jKqbN/8981VixNVy11+aoWd2COYSrpGA1Zr/yyGonYOtggoVL6ZvJWeqP/ m4l+4GZITXV2trall4I6slwC25lBEhurOHD19 X-Received: by 2002:a05:6000:1ac6:b0:3a5:2f23:377d with SMTP id ffacd0b85a97d-3a531cb1037mr317670f8f.50.1749152164760; Thu, 05 Jun 2025 12:36:04 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-452137258bdsm2246645e9.27.2025.06.05.12.36.02 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 05 Jun 2025 12:36:03 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, Paolo Bonzini , qemu-arm@nongnu.org, Glenn Miles , =?utf-8?q?Marc-And?= =?utf-8?q?r=C3=A9_Lureau?= , Peter Maydell , Stefan Hajnoczi , Stefan Berger , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= , =?utf-8?q?Daniel_P_=2E_Berrang?= =?utf-8?q?=C3=A9?= Subject: [RFC PATCH 4/4] buildsys: Prohibit alloca() use on system code Date: Thu, 5 Jun 2025 21:35:40 +0200 Message-ID: <20250605193540.59874-5-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250605193540.59874-1-philmd@linaro.org> References: <20250605193540.59874-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=philmd@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Similarly to commit 64c1a544352 ("meson: Enable -Wvla") with variable length arrays, forbid alloca() uses on system code. There are few uses on ancient linux-user code, do not bother there. Signed-off-by: Philippe Mathieu-Daudé --- meson.build | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/meson.build b/meson.build index ef994676fe9..8c6ccb03c71 100644 --- a/meson.build +++ b/meson.build @@ -774,6 +774,10 @@ if host_os != 'darwin' endif endif +if have_system + warn_flags += ['-Walloca'] +endif + # Set up C++ compiler flags qemu_cxxflags = [] if 'cpp' in all_languages