From patchwork Fri Jun 6 18:49:57 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qasim Ijaz X-Patchwork-Id: 894595 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6641E1F4168; Fri, 6 Jun 2025 18:50:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749235837; cv=none; b=pXZLEZmFaYFEGEfav8OtCV7eVodwg1uUsdntP2q6iXfkC+70M7fx3IH235JASd5erJyEtyOaz6qQYBuWTATans7Uw8wvZOmIXTRtET3lhJgOlAGIUXuEGBtOHk6kGxmUFmX98k1DYRRgFoxVF8d6OfO5ZzbaDWC3f5SnkP+LtKE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749235837; c=relaxed/simple; bh=NdLZx6SNrtrx4SwH5gojmNTGg6eqHtkXjAak/CamQvw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=BqLAoq3y4TXLARpgHVlg4xSQkf9A4VHPGIlcJQl6cEMN9nMBJstH3Vt5hlDVAYkoJnP3vCKpt0Z8mRJU9MTEdO2UuPxNupDwURf3ohsKn11IcpqqCxm64nQZUAE9mEgUBujIa7c6g7kH0a3i2Mi3XObAwKVAkApf5BZr3wO5Quo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PG881Zy1; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PG881Zy1" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-3a5096158dcso2090665f8f.1; Fri, 06 Jun 2025 11:50:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749235833; x=1749840633; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0X9KHOsc9F0ZidCqJwKzDvYsUjyRXhITd5dF3RTeynU=; b=PG881Zy1hQggnmBG1qGrvQAftswSrkRd/xzmiNzksKBcCvBKk6ddyXpcbKrtWYt2CX r5d74B/jvaaMSX50tSjLL65My0c9jLbmJAXJ1sY92JiNwpcQh5UbcLbsAMpdn4zeCiuL ao3ZiXUR5I+8AuiIbMPaGiZnhlCYDxXMaNDBX6lXbNC8YW/xW+hTtquRlhnkzaq5y1WN 6YT2KV4mOh7oA747vkTCGySRD/FfoRjOAnZBUJ6IH0Qr+WjTfez9BOeBpewpgK4siihZ 5iYdUWoouBrxIoFWmCxi+xh6ko6++mu8G3Qui+1kDab/qt2zBubZMvgn9SSpkUooICtz sV3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749235833; x=1749840633; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0X9KHOsc9F0ZidCqJwKzDvYsUjyRXhITd5dF3RTeynU=; b=SsNNp+b7C2rVVCm+Jc1/9LQOZ6D9M4g1o+s0r+ih+z8ZfwyTFklxUUS2jsBrVINljd MoJWtpk8AkuJYA3Yj0uioFLRtYVPOeNsWOiphwefAKiRx5ApYr3SjcfKCPb0bMb4DF+5 Q+2c5baU4pj8BVVna5lyvZ5B0hfl88UzLk/lzp22azilbzwLvuBFh7qOu74GJNBLkwox wM+sG/aqIT2s9HLdf57w50BFoYZ/LTy0OQmnF/bBCBccTCZN1a1sDHu0NVHet2rZVS2Y 3gVuOvcNGspJoLMN5/+IfrTrdbr4bVwGwWHiZpdo5f/+h669JJlQz0pSsqT5HwcL/tUN 9WGA== X-Forwarded-Encrypted: i=1; AJvYcCUdLBKLDHzHZPTVsj9RFDt6L7XsmNlc0numJuZFkNVm5npK5mGj8+PiF6PEERPKw4T8j0k29Ygv+Xagr+JV@vger.kernel.org, AJvYcCWqPhB7sr+YVxVut+dZ0sZ9zwjK2hPCjB7W4kdloTk7sh9aZv91NeEHkJ0rh9CX43yfqOHtTPlM@vger.kernel.org, AJvYcCXStuDFmmG+IebMGRxRq3oXe4MkF0XoOBjiIYZFqgKK570nqTLy8XXzUPWiR1Em7T59KXNdwNA2514RBQ==@vger.kernel.org X-Gm-Message-State: AOJu0YzizqsO5PDoklX9yaz1vCW1xFKBYGh6wH8TSKKhF0kmGEEPNCma p2HtfQTzUEvNHcCMiFtF7pMcXiA9x007lz21WollYHglZDZJha8x2gEv X-Gm-Gg: ASbGncu6i9btpM1P7DP3+YnQbAqx3fED672lxEgt/4gvv+T7/NBeW2/hrNP6awMpB15 ehVoDDw7+Apn/slFcZiBHl2kAdQXoo7z5mkxMwI54F4G+fWBzYNZ2PvxwcDkRIq1/qG/3H0tPYp 1VIjGG8ZVaV7ubt8iSTMka5pJABA6CtZ9UTzqSWinuiwLgaaJx8RSc6X7NsQJslEtius/UdORbg rFCyuS42XA9dHNl1vs0/Gyg/od12+0H+0ttcfGcDsbzLn+/ItLmlyGpYhglplKfXPuSw3QZf3ep aFXjWgEBgUwgqE6lIVLeNT9uXkRGDeXXPNRcPImt4KumLknuaT4tqXkzrxg4y7M= X-Google-Smtp-Source: AGHT+IGnMAGQpDA3bxgIqVeDYLg7txF+FfUKJgcUdxE9mxm3KBo3HRNuKAnnkuXFaZPTqmSQdkyb0A== X-Received: by 2002:a05:6000:220d:b0:3a5:1471:d885 with SMTP id ffacd0b85a97d-3a531cec3e7mr4688607f8f.56.1749235832447; Fri, 06 Jun 2025 11:50:32 -0700 (PDT) Received: from qasdev.Home ([2a02:c7c:6696:8300:44e7:a1ae:b1f1:d5a4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a532435771sm2713057f8f.63.2025.06.06.11.50.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jun 2025 11:50:31 -0700 (PDT) From: Qasim Ijaz To: Ping Cheng , Jason Gerecke , Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Qasim Ijaz , stable@vger.kernel.org Subject: [PATCH RESEND 1/3] HID: wacom: fix memory leak on kobject creation failure Date: Fri, 6 Jun 2025 19:49:57 +0100 Message-Id: <20250606184959.35915-2-qasdev00@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250606184959.35915-1-qasdev00@gmail.com> References: <20250606184959.35915-1-qasdev00@gmail.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 During wacom_initialize_remotes() a fifo buffer is allocated with kfifo_alloc() and later a cleanup action is registered during devm_add_action_or_reset() to clean it up. However if the code fails to create a kobject and register it with sysfs the code simply returns -ENOMEM before the cleanup action is registered leading to a memory leak. Fix this by ensuring the fifo is freed when the kobject creation and registration process fails. Fixes: 83e6b40e2de6 ("HID: wacom: EKR: have the wacom resources dynamically allocated") Reviewed-by: Ping Cheng Cc: stable@vger.kernel.org Signed-off-by: Qasim Ijaz --- drivers/hid/wacom_sys.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c index eaf099b2efdb..ec5282bc69d6 100644 --- a/drivers/hid/wacom_sys.c +++ b/drivers/hid/wacom_sys.c @@ -2048,8 +2048,10 @@ static int wacom_initialize_remotes(struct wacom *wacom) remote->remote_dir = kobject_create_and_add("wacom_remote", &wacom->hdev->dev.kobj); - if (!remote->remote_dir) + if (!remote->remote_dir) { + kfifo_free(&remote->remote_fifo); return -ENOMEM; + } error = sysfs_create_files(remote->remote_dir, remote_unpair_attrs); From patchwork Fri Jun 6 18:49:58 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qasim Ijaz X-Patchwork-Id: 894850 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B5601F4CA6; Fri, 6 Jun 2025 18:50:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749235843; cv=none; b=IEvdk8RqO6C6YdLq1uDdekRQlKFFOSgA6p6WSwLJd21cuE7qZWnva/8fwcbtzm6wj6O9Jf+/0be5KSL6zbHl6pV8abtpbF6OZHIrMDla4Mbt763t21b808gobV6V4+v896aKQweu8agU3WHOx3jdb7dtps8iCXIOQoaV5yT0iYk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749235843; c=relaxed/simple; bh=nkUvevFHBEYITDhC9X1tL+mMaruxONFG3+Czq5DEl9o=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=uWswFyBxCvlyuVXxfwO7ByeAEn3HppEPtBd0NlSSEeSj8+R/FFXvATRavhMMWxV0G+j2QckL0fP2oOHyS9rAvSOlhYEbV3He+culhfRauxDvUKDRdYQBkhOs98zDmmGP5nJGq1nGRRyZdeKLJaMAqhcBmvtgFLs0MirADnIRI1k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=me1vbtH6; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="me1vbtH6" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-3a50956e5d3so2069921f8f.1; Fri, 06 Jun 2025 11:50:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749235840; x=1749840640; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7ltlfK4VAqY2/afqznk26/g8AZIhvK7lNV10GKBdt3Y=; b=me1vbtH6MEGbQcmahN0p6knfB/lYCu6dfCA5Buy8JM5iIP99OQoFYvg2pOyB/+9DuZ 6/W0mfhFeJD1WXoBrzd1J9GeXDYVEOkLHTv8S973wfxzN3cZ2g7jSK9qZLhKHmZU91JV ZT5XAq59/4lv1maxPcYYxBBKPtTsKZaJVmbRdoy0hswc94rB59JSehbAMLQx6mxN97rl /IFvpypgxlCX7nQ9EGpwD0DvoLRTHb7KbL6G44jqUF9upTrgwPuALfhYtStOXJKDn5UR +Tifb8tjFhfoVmp+dyn53cOEOBUnWvhIJ8BKb3dfYQSDaXiuHp/Yw8QK0z6+aGuFxNgD 83dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749235840; x=1749840640; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7ltlfK4VAqY2/afqznk26/g8AZIhvK7lNV10GKBdt3Y=; b=RC1NMxnmvpQByIk3EA1BVdzvVsLtGAghTaOurSosRUMI2nwPd8wvG0uZ3DH/7uc+Br 9IPeJcH3pcgXoPyzLFnzNkzfA3X9z+CCNasy8yGb7XdzC1xEKRsI0Zwo6rpY29ysy8LG udLK1qcUU8UCzZKI7xV+mKcLPlfQhRsrIsIo1qyP7DBaQm89UUGitdRSPjOahJFt5a4G 3eENd4Nc2Dawxxluetc60rsrW878bFeraJmQdrN7yga956pvQK70MZzfSsxWl7+WIsW4 vm060pmD10O1dQFziSE7VK0CPaGliAZPZB90hNSX29FiIOIF7C8krBLRpBYhNp0Xv2Nm P5eA== X-Forwarded-Encrypted: i=1; AJvYcCUYmtNTNyfVV4m4S87eoPPV9lO5SiQ3XlgcDzPOw967Eb9/8Z/wtaLCQTTV+CJo5JoibeIl2XcHZzsnk2zd@vger.kernel.org, AJvYcCWb08Uj+GX6uCAZkStDzwGo8cLiYG8VYaYlRbkmNLV+0gRIOehBko1t3LqeYloXbL3KR3KeIS4G@vger.kernel.org, AJvYcCXnjE5uxaBJ2gLZiKLUb8Hnqq4Xjs5dadDmTyUDIss/bcYLdsG2N9d/JEJnEArD3oxPZQzqWIHcdZJTGQ==@vger.kernel.org X-Gm-Message-State: AOJu0Ywu4/0he5YAHi2I01ZLTIFDhSFlwrgar3gY5NTm1pg701NSdqbo VxyIJz4k8yiiDIFd7HdCxrYqAFUNSMeLSK63gqDqtUm3uarYH7xmPwl2 X-Gm-Gg: ASbGncuXcbiGU5f7XYsVIksSxG2vIVpTMChJ11ZeGSYfJcLA1jodn3mMvrIMuUK077E YK5GsZsDPWEPlZNb+K5+MXvzmu+v2qyMvOSVdtEdUdUsetN/KbgN2KNMqtpvoDLw2J2Aokhev8N EYA4Y5z8a79YVv8wWrEs7iaNnCxwA4iAQYAK/PzvDOAAkPzYHuqGW27nbFw//sZDjyP35Pt31v0 c7jf8GguOyprjCMw5cE3xOTMcN3oHNetWkYmR3hySygRipc43gpSRpXc9Hay9+s4+3slYjF/Pm2 J5+pc/Xl9VS2tK0jwlZSTYFQwm5EqeMKELHIxUXdEN6sjk47ZSOADSGGlpi5Sfs= X-Google-Smtp-Source: AGHT+IH/94E4mFrP2ewqInyn6q7B0DYxbzwousQ8WeFchqMQvKFsIJ3pYFutAaYmNC1kQE6AwEk9oQ== X-Received: by 2002:a05:6000:2088:b0:3a5:2fae:1348 with SMTP id ffacd0b85a97d-3a531cbd87bmr3380350f8f.51.1749235840320; Fri, 06 Jun 2025 11:50:40 -0700 (PDT) Received: from qasdev.Home ([2a02:c7c:6696:8300:44e7:a1ae:b1f1:d5a4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a532435771sm2713057f8f.63.2025.06.06.11.50.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jun 2025 11:50:39 -0700 (PDT) From: Qasim Ijaz To: Ping Cheng , Jason Gerecke , Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Qasim Ijaz , stable@vger.kernel.org Subject: [PATCH RESEND 2/3] HID: wacom: fix memory leak on sysfs attribute creation failure Date: Fri, 6 Jun 2025 19:49:58 +0100 Message-Id: <20250606184959.35915-3-qasdev00@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250606184959.35915-1-qasdev00@gmail.com> References: <20250606184959.35915-1-qasdev00@gmail.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 When sysfs_create_files() fails during wacom_initialize_remotes() the fifo buffer is not freed leading to a memory leak. Fix this by calling kfifo_free() before returning. Fixes: 83e6b40e2de6 ("HID: wacom: EKR: have the wacom resources dynamically allocated") Reviewed-by: Ping Cheng Cc: stable@vger.kernel.org Signed-off-by: Qasim Ijaz --- drivers/hid/wacom_sys.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c index ec5282bc69d6..58cbd43a37e9 100644 --- a/drivers/hid/wacom_sys.c +++ b/drivers/hid/wacom_sys.c @@ -2058,6 +2058,7 @@ static int wacom_initialize_remotes(struct wacom *wacom) if (error) { hid_err(wacom->hdev, "cannot create sysfs group err: %d\n", error); + kfifo_free(&remote->remote_fifo); return error; } From patchwork Fri Jun 6 18:49:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Qasim Ijaz X-Patchwork-Id: 894594 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F58C1F8AF8; Fri, 6 Jun 2025 18:50:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749235846; cv=none; b=LhrVDzrmB0RGe43Glh+vSLJesIvy274IZS5uFOsF8QXMbrZte3GBaHoAuib30pftK01b2J5ss4mRVfNAg0rwG/B47ZS154LiVk4VMLQ/FRk8/ibrSVNYpqFpI0UFPReZvAwO09L1c94iEnkt0IGBMa9skhEUSgglCPJTp70khpM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749235846; c=relaxed/simple; bh=1Y561gxotfU2M/XWcCQd7mQekukJTHXTG9krmV/xt5Y=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=STqwlCKzNCLoOAKaHkhO6owQIXQyrH3krfyRiOagwRfsgVa661DCf++MPIIipdxUGIyYFvXftf2+DnV6NrCIdAWJ43y4Q+BROY8qZn/07Wz/kW2QIZ/E+N0bSG49wFk4CyqCgiXMQHapS2wip74DWhXIkpRYj8uq1NpQlvZ+M5A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ct7SeWIh; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ct7SeWIh" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-3a522224582so1496340f8f.3; Fri, 06 Jun 2025 11:50:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749235843; x=1749840643; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Nz0vQt7877ZXer9aIaRJd98DwV3rwF/l+2VwGrUZkNM=; b=Ct7SeWIh/gDVvCC1BU3wANxWiH1d4DZCxquheWkYGvqibm6gdBSofQHymO8JACzlCx bHvfpOrWdVE7nMDyQAGZz8Wwi0LuAAdPT7/D/18oEhZ7tfIwCW+o/G8MXuVKh2ysgPsx 9lQ9uY18s8E6X8o1m+DRVagy2nda0dvV4P6IYUCdc1mlx09ZSzfyERGXSNoy7iVX9Xkb tZHN4jHIcB4jXhISBjawj3feMe4EPUoU8NDoOIMPgnZJQQvH/uz8T6kog0YeARVKU4fM LvS90Ai0IwKFt02huF5ZMxuk5e1WxpNFypXClvOhb0haa1ttkDbfutxLGtsC5AxdWAJJ xJxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749235843; x=1749840643; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Nz0vQt7877ZXer9aIaRJd98DwV3rwF/l+2VwGrUZkNM=; b=JZ8qkuENIFyXf4tKzAmF3cI7rQXAxBEoTgl+LPpyQkS6xolNXwCemUc0UrtMV2+Tad 3+2zyFwlLogEiKVWpzGnRydV0c1W+QNt9T9Nrd0Q2Qa2RYub2Yv9oe3tufc3bD1nF3sI 2nrypcnm7b+oi/xqyWjEinGwQw2ndSlLrGzLIrdnHh+/FTlxwNPpF0pXrHcd1Y0qJ0PY ig5ZB/RrMXZSz4iwJBAOVi4hg1rhGWRPrLqe1LgN7j/xaGiABdCVvhpOZWUvzXK1Jmyo ZEDcaJiGodH0kffkImtkDDL4ougRRVWqGcAmohlLnlCSe4Qb0Ie8piQqFetczRyqHMT6 BAWw== X-Forwarded-Encrypted: i=1; AJvYcCVLkTm36hhEhBteDG0UFyp4xOiOJ+So6HwGOi49M6fPQwSuIKcI/iyNGASWHecVYhqtAI04CGenRxYmUr9y@vger.kernel.org, AJvYcCVoEX9XUuQRALb2spW0BUh2WlQ4bZqnXHBM/WHNJFaiqH4CPuOsR5SyNX4Hbkyer4qr09WYNh44@vger.kernel.org, AJvYcCVr3LPwpXuFdNFdFBnHILAe6+bLllG7x3uL/gg5n3pg4GVSDe8/VP0A8VUqZFXWN0GiGet4sG2k0jx5LA==@vger.kernel.org X-Gm-Message-State: AOJu0YzGGDItwDh6IrQfV12MljBumMARGbdABl3tmy2npbK5GhRN/f/F BwrcOIP06SqIWtxPzi0i+CIJ2Y5eWXmG4csAQRcf/iVhT+rB1rS1G3gj X-Gm-Gg: ASbGncsg+ihR9rLm/bmvPODpmNNm/L5eBMxNpkCO0c6u8Q1S5E4DT/4DV35OKzYI2Gr 1YJxJnEDUMliFU77gRY5sAr/Fz4kD8+dNoWfdbh3Biqoc0sZIl7tyTS0xdvYY6OyB6DQq6/lmcX av2DXb0WYdoriYo9UuBqB+1jrIC+/kl+C2kzGR7UWfZgNn46Tf6kcYfhkUarmJ9ZEVdU/UD8+iL bqNHDMcUVcaFPbKrc1X5upDVnlBTAGyLqnOgHElANd59Ot94XbxIrKgheC1LUhZJ83Y4xi672yK 4sJWlFlJoliK9hjbUDgHcqv5N9+Vz6syjvNrP2Qa10hNmZMlE8Y9 X-Google-Smtp-Source: AGHT+IFh+cYdb0g9mBFjnbpI441TkiJq6KGm4lUKoKGDJhcnOFv+cJ5fOUYOeLuvGPqAmbNvBpveZw== X-Received: by 2002:adf:e68b:0:b0:3a4:e6bb:2d32 with SMTP id ffacd0b85a97d-3a53189bc60mr3150683f8f.22.1749235842678; Fri, 06 Jun 2025 11:50:42 -0700 (PDT) Received: from qasdev.Home ([2a02:c7c:6696:8300:44e7:a1ae:b1f1:d5a4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a532435771sm2713057f8f.63.2025.06.06.11.50.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jun 2025 11:50:42 -0700 (PDT) From: Qasim Ijaz To: Ping Cheng , Jason Gerecke , Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Qasim Ijaz , stable@vger.kernel.org Subject: [PATCH RESEND 3/3] HID: wacom: fix kobject reference count leak Date: Fri, 6 Jun 2025 19:49:59 +0100 Message-Id: <20250606184959.35915-4-qasdev00@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250606184959.35915-1-qasdev00@gmail.com> References: <20250606184959.35915-1-qasdev00@gmail.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 When sysfs_create_files() fails in wacom_initialize_remotes() the error is returned and the cleanup action will not have been registered yet. As a result the kobject’s refcount is never dropped, so the kobject can never be freed leading to a reference leak. Fix this by calling kobject_put() before returning. Fixes: 83e6b40e2de6 ("HID: wacom: EKR: have the wacom resources dynamically allocated") Acked-by: Ping Cheng Cc: stable@vger.kernel.org Signed-off-by: Qasim Ijaz --- drivers/hid/wacom_sys.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c index 58cbd43a37e9..1257131b1e34 100644 --- a/drivers/hid/wacom_sys.c +++ b/drivers/hid/wacom_sys.c @@ -2059,6 +2059,7 @@ static int wacom_initialize_remotes(struct wacom *wacom) hid_err(wacom->hdev, "cannot create sysfs group err: %d\n", error); kfifo_free(&remote->remote_fifo); + kobject_put(remote->remote_dir); return error; }